| david-lyle | TravT: https://review.openstack.org/206263, but it requires https://review.openstack.org/206260 | 00:00 |
|---|---|---|
| david-lyle | tqtran2: ^^^^^ | 00:00 |
| TravT | david-lyle: ok, thanks. will look now. | 00:00 |
| *** jtriley has quit IRC | 00:01 | |
| david-lyle | thanks to ducttape_ added a nice RedirectMatch, so it will look seemless | 00:01 |
| david-lyle | so you can hit from '/' or '/dashboard' | 00:01 |
| david-lyle | cheers | 00:01 |
| TravT | you should give ducttape_ co-author credit | 00:01 |
| *** Sukhdev has quit IRC | 00:01 | |
| tqtran2 | looking | 00:02 |
| *** kzaitsev_mb has quit IRC | 00:02 | |
| TravT | so, | 00:02 |
| david-lyle | hurgleburgler's patch is because my webroot theme got overlooked in recent rennovations | 00:02 |
| david-lyle | hungry? | 00:02 |
| david-lyle | thirsty? | 00:03 |
| david-lyle | apathetic? | 00:03 |
| TravT | i guess to fully do this... would actually have to pull webroot patch, set reclone=No and then pull this devstack patch | 00:03 |
| david-lyle | yeah, something like that | 00:03 |
| david-lyle | merge hurgleburgler's patch and wait two hours | 00:04 |
| david-lyle | :) | 00:04 |
| TravT | yeah | 00:04 |
| TravT | that's what i'm thinking | 00:04 |
| hurgleburgler | so | 00:04 |
| david-lyle | I tried it, and it fixed my issue | 00:04 |
| david-lyle | hungry? | 00:04 |
| hurgleburgler | this is only gonna work with the default theme | 00:04 |
| hurgleburgler | I hope that's not a problem | 00:04 |
| hurgleburgler | i'm working on a better solution now | 00:04 |
| TravT | eh? | 00:04 |
| TravT | will the jury please disregard that last comment by hurgleburgler | 00:04 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Mock $window for magic-search tests https://review.openstack.org/206267 | 00:05 |
| david-lyle | hurgleburgler: for now, in a non-default theme, the user is editing it anyway | 00:05 |
| hurgleburgler | phew! | 00:05 |
| david-lyle | they can set $webroot to anything they want | 00:05 |
| *** vishwanathj has quit IRC | 00:05 | |
| david-lyle | but long term, that's what we're expecting out of you. a fix for all our problems | 00:05 |
| david-lyle | I've got a list | 00:05 |
| david-lyle | :P | 00:06 |
| david-lyle | the webroot was an example anyway to work in devstack | 00:06 |
| david-lyle | and I would have got away with it too, if it weren't for you meddling kids | 00:06 |
| david-lyle | ! | 00:06 |
| hurgleburgler | I'm on it! ʘ‿ʘ | 00:06 |
| openstackgerrit | KBrown proposed openstack/horizon: WIP: Add angular flavors panel https://review.openstack.org/206203 | 00:07 |
| *** tyr has quit IRC | 00:07 | |
| tqtran2 | david-lyle: https://review.openstack.org/#/c/206263/1/files/apache-horizon.template L14, so we're auto redirecting anyone hitting localhost to horizon directly/ | 00:08 |
| tqtran2 | ? | 00:08 |
| tqtran2 | oh nvm.... | 00:08 |
| tqtran2 | of course we are, that was the default behavior before keystone stole our url | 00:08 |
| david-lyle | so it just redirects '/' only to /dashboard | 00:09 |
| david-lyle | so people don't have to know to type /dashboard | 00:09 |
| tqtran2 | yeah, make sense, it just took me a second to comprehend the meaning of life | 00:09 |
| *** tqtran2 has quit IRC | 00:09 | |
| openstackgerrit | Merged openstack/horizon: Allow STATIC_URL override https://review.openstack.org/204173 | 00:10 |
| david-lyle | ooh, explain to me now | 00:10 |
| *** tqtran has joined #openstack-horizon | 00:10 | |
| david-lyle | I can't tell if tqtran is coming or going | 00:10 |
| david-lyle | all these numbers | 00:10 |
| *** kyleolivo has quit IRC | 00:11 | |
| tqtran | huh? im confuse | 00:11 |
| david-lyle | tqtran2 tqtran | 00:11 |
| david-lyle | so many of you | 00:11 |
| david-lyle | :D | 00:11 |
| tqtran | oh.. lol | 00:11 |
| tqtran | having connection issues, sometimes it says the nick is already taken | 00:11 |
| tqtran | i had to improvise | 00:11 |
| david-lyle | was quality taken? | 00:12 |
| *** alexvictorchan has quit IRC | 00:12 | |
| david-lyle | that's your friday nick btw | 00:12 |
| david-lyle | or should be | 00:12 |
| tqtran | lol shhhh thats my bot's name | 00:13 |
| david-lyle | ok, have to run and mind the kids, will check in later. Let me know what I broke. | 00:13 |
| *** SimonChung has quit IRC | 00:13 | |
| tqtran | have fun! :P | 00:13 |
| TravT | yeah, i'm out for the day too. hasta | 00:13 |
| * david-lyle puts on body armor | 00:13 | |
| *** jingjing_ren has quit IRC | 00:17 | |
| *** dansiwiec has quit IRC | 00:18 | |
| *** dansiwiec has joined #openstack-horizon | 00:19 | |
| *** jasondotstar has quit IRC | 00:21 | |
| *** jasondotstar has joined #openstack-horizon | 00:22 | |
| *** dansiwiec has quit IRC | 00:23 | |
| *** dansiwiec has joined #openstack-horizon | 00:24 | |
| *** kzaitsev_mb has joined #openstack-horizon | 00:27 | |
| *** Drago has joined #openstack-horizon | 00:32 | |
| *** dansiwiec has quit IRC | 00:33 | |
| *** dansiwiec has joined #openstack-horizon | 00:33 | |
| openstackgerrit | Tracy Jones proposed openstack/horizon: move favicon, logo and logo-splash to default theme https://review.openstack.org/195751 | 00:37 |
| *** tjones1 has joined #openstack-horizon | 00:37 | |
| tjones1 | hurgleburgler: you are right on your comment and i pushed the update https://review.openstack.org/#/c/195751 | 00:38 |
| *** btully has quit IRC | 00:39 | |
| *** rajatvig has quit IRC | 00:39 | |
| *** mwhagedorn has quit IRC | 00:42 | |
| *** jasondotstar is now known as jasondotstar|afk | 00:43 | |
| *** dansiwiec has quit IRC | 00:44 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: WIP Adding CREATE action to identity users panel https://review.openstack.org/202315 | 00:44 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding wizard modal service https://review.openstack.org/205716 | 00:44 |
| *** openstackgerrit has quit IRC | 00:46 | |
| *** openstackgerrit has joined #openstack-horizon | 00:47 | |
| *** tqtran has quit IRC | 00:47 | |
| *** dansiwiec has joined #openstack-horizon | 00:50 | |
| *** annashen has joined #openstack-horizon | 00:54 | |
| *** ybathia has quit IRC | 00:54 | |
| *** kevinbenton has quit IRC | 00:54 | |
| *** bpokorny_ has joined #openstack-horizon | 00:55 | |
| *** kevinbenton has joined #openstack-horizon | 00:57 | |
| *** jtriley has joined #openstack-horizon | 00:57 | |
| *** bpokorny has quit IRC | 00:58 | |
| *** annashen has quit IRC | 00:59 | |
| hurgleburgler | tjones1 great! I'll take another look at it | 01:02 |
| tjones1 | thanks | 01:02 |
| tjones1 | oh wait it has a merge conflcit | 01:02 |
| tjones1 | argh! | 01:02 |
| *** kzaitsev_mb has quit IRC | 01:03 | |
| *** jwy has quit IRC | 01:03 | |
| tjones1 | odd - i don't see the conflct | 01:04 |
| *** jtriley has quit IRC | 01:04 | |
| *** dansiwiec has quit IRC | 01:04 | |
| hurgleburgler | Did you pull the latest master? | 01:04 |
| tjones1 | yes | 01:05 |
| openstackgerrit | Tracy Jones proposed openstack/horizon: move favicon, logo and logo-splash to default theme https://review.openstack.org/195751 | 01:05 |
| tjones1 | and rebase -i master | 01:05 |
| tjones1 | and no conlfict | 01:05 |
| tjones1 | im pushing again to see if it clears up | 01:05 |
| tjones1 | it's ok now | 01:05 |
| tjones1 | odd | 01:05 |
| hurgleburgler | Magic! | 01:05 |
| hurgleburgler | ¯＼_(ツ)_/¯ | 01:05 |
| tjones1 | tada! | 01:05 |
| *** lhcheng has joined #openstack-horizon | 01:06 | |
| *** sqchen has quit IRC | 01:08 | |
| *** alexvictorchan has joined #openstack-horizon | 01:11 | |
| *** kyleolivo has joined #openstack-horizon | 01:11 | |
| *** Sukhdev has joined #openstack-horizon | 01:14 | |
| *** rajatvig has joined #openstack-horizon | 01:14 | |
| *** rajatvig has quit IRC | 01:14 | |
| *** sqchen has joined #openstack-horizon | 01:16 | |
| *** jasondotstar|afk has quit IRC | 01:17 | |
| *** absubram has quit IRC | 01:18 | |
| *** btully has joined #openstack-horizon | 01:19 | |
| *** kristine_ has quit IRC | 01:20 | |
| *** btully has quit IRC | 01:24 | |
| *** Sukhdev has quit IRC | 01:25 | |
| *** bpokorny_ has quit IRC | 01:26 | |
| *** jwy has joined #openstack-horizon | 01:26 | |
| *** kyleolivo has quit IRC | 01:28 | |
| *** alexvictorchan has quit IRC | 01:29 | |
| *** dansiwiec has joined #openstack-horizon | 01:30 | |
| *** dansiwiec has quit IRC | 01:36 | |
| *** rajatvig has joined #openstack-horizon | 01:41 | |
| *** rajatvig has quit IRC | 01:44 | |
| *** lexholden has quit IRC | 01:51 | |
| *** yamamoto has joined #openstack-horizon | 01:53 | |
| *** annashen has joined #openstack-horizon | 01:55 | |
| *** Piet has quit IRC | 01:58 | |
| *** yingjun has joined #openstack-horizon | 01:59 | |
| *** kzaitsev_mb has joined #openstack-horizon | 01:59 | |
| *** annashen has quit IRC | 02:00 | |
| *** jtriley has joined #openstack-horizon | 02:00 | |
| *** jwy has quit IRC | 02:02 | |
| *** sqchen has quit IRC | 02:03 | |
| openstackgerrit | ziyu032 proposed openstack/horizon: Display the project name in user detail page https://review.openstack.org/205983 | 02:04 |
| *** jtriley has quit IRC | 02:06 | |
| *** stevemar has joined #openstack-horizon | 02:07 | |
| *** sqchen has joined #openstack-horizon | 02:10 | |
| *** jasondotstar|afk has joined #openstack-horizon | 02:12 | |
| *** tjones1 has quit IRC | 02:12 | |
| *** annashen has joined #openstack-horizon | 02:17 | |
| *** kyleolivo has joined #openstack-horizon | 02:18 | |
| *** zhenguo has joined #openstack-horizon | 02:19 | |
| *** kzaitsev_mb has quit IRC | 02:21 | |
| *** rajatvig has joined #openstack-horizon | 02:45 | |
| *** lhcheng has quit IRC | 02:48 | |
| *** davidmichaelkarr has quit IRC | 02:49 | |
| *** rajatvig has quit IRC | 02:49 | |
| *** bpokorny has joined #openstack-horizon | 02:51 | |
| *** bpokorny has quit IRC | 02:51 | |
| *** bpokorny has joined #openstack-horizon | 02:52 | |
| *** bpokorny has quit IRC | 02:52 | |
| openstackgerrit | lyanchih proposed openstack/horizon: Couldn't provision instance from volume snapshot https://review.openstack.org/199457 | 02:55 |
| *** bpokorny has joined #openstack-horizon | 02:56 | |
| *** annashen_ has joined #openstack-horizon | 02:56 | |
| *** skylerberg has quit IRC | 02:56 | |
| *** sqchen has quit IRC | 03:00 | |
| *** annashen_ has quit IRC | 03:01 | |
| *** stevemar has quit IRC | 03:01 | |
| *** davidmichaelkarr has joined #openstack-horizon | 03:09 | |
| *** kzaitsev_mb has joined #openstack-horizon | 03:17 | |
| *** lhcheng has joined #openstack-horizon | 03:18 | |
| *** Sukhdev has joined #openstack-horizon | 03:21 | |
| *** kzaitsev_mb has quit IRC | 03:22 | |
| *** jasondotstar|afk has quit IRC | 03:24 | |
| *** sqchen has joined #openstack-horizon | 03:26 | |
| *** ducttape_ has joined #openstack-horizon | 03:28 | |
| *** kiran-r has joined #openstack-horizon | 03:34 | |
| *** kiran-r has quit IRC | 03:40 | |
| *** sqchen has quit IRC | 03:42 | |
| *** annashen has quit IRC | 03:45 | |
| *** julim has quit IRC | 03:46 | |
| *** stevemar has joined #openstack-horizon | 03:50 | |
| *** stevemar has quit IRC | 03:52 | |
| *** ducttape_ has quit IRC | 03:55 | |
| *** jacalcat_ has quit IRC | 03:55 | |
| *** ducttape_ has joined #openstack-horizon | 03:55 | |
| *** yingjun has quit IRC | 03:56 | |
| *** annashen has joined #openstack-horizon | 03:57 | |
| *** sayan has joined #openstack-horizon | 03:58 | |
| *** ducttape_ has quit IRC | 04:01 | |
| *** annashen has quit IRC | 04:01 | |
| *** lhcheng has quit IRC | 04:07 | |
| *** alexvictorchan has joined #openstack-horizon | 04:09 | |
| *** btully has joined #openstack-horizon | 04:11 | |
| *** bpokorny has quit IRC | 04:11 | |
| *** bpokorny has joined #openstack-horizon | 04:11 | |
| *** sqchen has joined #openstack-horizon | 04:14 | |
| *** bpokorny has quit IRC | 04:14 | |
| *** bpokorny has joined #openstack-horizon | 04:20 | |
| *** bpokorny has quit IRC | 04:22 | |
| *** jtriley has joined #openstack-horizon | 04:27 | |
| *** kzaitsev_mb has joined #openstack-horizon | 04:33 | |
| *** jtriley has quit IRC | 04:36 | |
| *** kzaitsev_mb has quit IRC | 04:38 | |
| *** sayan has quit IRC | 04:41 | |
| *** tjones has joined #openstack-horizon | 04:51 | |
| *** annashen has joined #openstack-horizon | 04:58 | |
| *** annashen has quit IRC | 05:02 | |
| *** alexvictorchan has quit IRC | 05:13 | |
| *** tjones has quit IRC | 05:14 | |
| *** e0ne has joined #openstack-horizon | 05:14 | |
| *** alexvictorchan has joined #openstack-horizon | 05:18 | |
| *** Drago has quit IRC | 05:20 | |
| *** Sukhdev has quit IRC | 05:20 | |
| *** sayan has joined #openstack-horizon | 05:26 | |
| *** kyleolivo has quit IRC | 05:29 | |
| *** sayan has quit IRC | 05:33 | |
| *** masco has joined #openstack-horizon | 05:36 | |
| *** e0ne has quit IRC | 05:42 | |
| *** e0ne has joined #openstack-horizon | 05:44 | |
| *** jprovazn has joined #openstack-horizon | 05:46 | |
| *** sayan has joined #openstack-horizon | 05:47 | |
| *** yamamoto has quit IRC | 05:48 | |
| *** e0ne has quit IRC | 05:51 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Mock API - Basic mock API server constructor https://review.openstack.org/206312 | 05:52 |
| *** jamielennox is now known as jamielennox|away | 05:52 | |
| *** lucas__ has joined #openstack-horizon | 05:52 | |
| *** e0ne has joined #openstack-horizon | 05:55 | |
| *** yamamoto has joined #openstack-horizon | 05:56 | |
| *** lhcheng has joined #openstack-horizon | 05:56 | |
| *** jamielennox|away is now known as jamielennox | 05:56 | |
| *** lucas__ has quit IRC | 05:57 | |
| *** annashen has joined #openstack-horizon | 05:59 | |
| *** albertom has quit IRC | 06:01 | |
| *** annashen has quit IRC | 06:03 | |
| *** albertom has joined #openstack-horizon | 06:09 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Mock API - mock 404 error https://review.openstack.org/206321 | 06:09 |
| *** jsheeren has joined #openstack-horizon | 06:11 | |
| *** yingjun has joined #openstack-horizon | 06:12 | |
| *** jsheeren has quit IRC | 06:12 | |
| *** e0ne has quit IRC | 06:13 | |
| *** lhcheng has quit IRC | 06:17 | |
| *** chlong has quit IRC | 06:17 | |
| *** fedexo has joined #openstack-horizon | 06:19 | |
| *** belmoreira has joined #openstack-horizon | 06:25 | |
| *** vishwanathj has joined #openstack-horizon | 06:28 | |
| *** kyleolivo has joined #openstack-horizon | 06:29 | |
| *** jtriley has joined #openstack-horizon | 06:33 | |
| *** kyleolivo has quit IRC | 06:40 | |
| *** jtriley has quit IRC | 06:41 | |
| -openstackstatus- NOTICE: zuul is stuck and about to undergo an emergency restart, please be patient as job results may take a long time | 06:45 | |
| *** ChanServ changes topic to "zuul is stuck and about to undergo an emergency restart, please be patient as job results may take a long time" | 06:45 | |
| *** kzaitsev_mb has joined #openstack-horizon | 06:48 | |
| *** lhcheng has joined #openstack-horizon | 06:50 | |
| *** romainh has joined #openstack-horizon | 06:50 | |
| *** btully has quit IRC | 06:52 | |
| *** kzaitsev_mb has quit IRC | 06:53 | |
| *** markus_z has joined #openstack-horizon | 06:59 | |
| *** annashen has joined #openstack-horizon | 07:00 | |
| *** rdopiera has joined #openstack-horizon | 07:00 | |
| *** lyanchih has joined #openstack-horizon | 07:02 | |
| *** sayan has quit IRC | 07:02 | |
| *** rdopiera_ has joined #openstack-horizon | 07:02 | |
| *** annashen has quit IRC | 07:05 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Mock API - Basic mock API server constructor https://review.openstack.org/206312 | 07:07 |
| *** sayan has joined #openstack-horizon | 07:10 | |
| *** sayan has quit IRC | 07:11 | |
| *** sayan has joined #openstack-horizon | 07:11 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Mock API - mock 404 error https://review.openstack.org/206321 | 07:13 |
| openstackgerrit | ziyu032 proposed openstack/horizon: Display the project name in user detail page https://review.openstack.org/205983 | 07:20 |
| *** bfic has joined #openstack-horizon | 07:26 | |
| *** alexvictorchan has quit IRC | 07:31 | |
| *** btully has joined #openstack-horizon | 07:32 | |
| *** jbell8 has joined #openstack-horizon | 07:32 | |
| zigo | Hi. In the Debian package for AngularJS, we have the installation of angular-scenario.js which is disabled. | 07:32 |
| zigo | I've just heard from my colleague that Horizon is using it, however, the reason why it's disabled in Debian is because: | 07:33 |
| zigo | 1/ This one needs a newer version of JQuery, and currently we have only version 1.7 in Debian | 07:33 |
| zigo | 2/ it's going to be deprecated in the favor of protractor | 07:33 |
| zigo | So my question is: which part of Horizon is using angular-scenario.js ? | 07:34 |
| zigo | 2nd question: could we get rid of the use of it, so that Horizon would work in Debian? | 07:34 |
| *** ^Gal^_ has joined #openstack-horizon | 07:35 | |
| *** ^Gal^_ has quit IRC | 07:36 | |
| *** ^Gal^_ has joined #openstack-horizon | 07:36 | |
| *** btully has quit IRC | 07:36 | |
| *** e0ne has joined #openstack-horizon | 07:37 | |
| *** ^Gal^_ is now known as ^Gal^ | 07:43 | |
| *** jbell8 has quit IRC | 07:43 | |
| *** lhcheng has quit IRC | 07:43 | |
| *** jbell8 has joined #openstack-horizon | 07:45 | |
| *** kzaitsev_mb has joined #openstack-horizon | 07:49 | |
| *** KingKhan has joined #openstack-horizon | 07:50 | |
| *** kzaitsev_mb has quit IRC | 07:54 | |
| *** sqchen has quit IRC | 07:58 | |
| *** annashen has joined #openstack-horizon | 08:01 | |
| *** kmARC has joined #openstack-horizon | 08:01 | |
| *** ChanServ changes topic to "OpenStack Horizon" | 08:02 | |
| -openstackstatus- NOTICE: zuul has been restarted and queues restored. It may take some time to work through the backlog. | 08:02 | |
| *** annashen has quit IRC | 08:05 | |
| *** fedexo has quit IRC | 08:08 | |
| *** jbell8 has quit IRC | 08:08 | |
| *** jbell8 has joined #openstack-horizon | 08:13 | |
| *** kzaitsev_mb has joined #openstack-horizon | 08:15 | |
| *** MaxV has joined #openstack-horizon | 08:19 | |
| openstackgerrit | Merged openstack/horizon: Webroot still needs to load default scss files https://review.openstack.org/206260 | 08:22 |
| *** ygbo has joined #openstack-horizon | 08:23 | |
| *** zacdev has joined #openstack-horizon | 08:24 | |
| openstackgerrit | ziyu032 proposed openstack/horizon: Display the project name in user detail page https://review.openstack.org/205983 | 08:25 |
| *** vishwanathj has quit IRC | 08:27 | |
| openstackgerrit | Merged openstack/horizon: Keystone REST handles default role incorrectly https://review.openstack.org/181501 | 08:28 |
| *** vishwanathj has joined #openstack-horizon | 08:28 | |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Logout user if he has no valid tokens https://review.openstack.org/142481 | 08:29 |
| *** bluex-pl has joined #openstack-horizon | 08:29 | |
| *** bluex-pl has quit IRC | 08:29 | |
| *** bluex-pl has joined #openstack-horizon | 08:30 | |
| *** alexpilotti has joined #openstack-horizon | 08:33 | |
| *** vishwanathj has quit IRC | 08:39 | |
| *** aix has joined #openstack-horizon | 08:45 | |
| *** kzaitsev_mb has quit IRC | 08:48 | |
| *** vishwanathj has joined #openstack-horizon | 08:53 | |
| *** ZZelle has quit IRC | 08:53 | |
| *** ZZelle has joined #openstack-horizon | 08:53 | |
| *** hurgleburgler has quit IRC | 09:01 | |
| *** annashen has joined #openstack-horizon | 09:01 | |
| *** annashen has quit IRC | 09:06 | |
| *** jtriley has joined #openstack-horizon | 09:06 | |
| *** yamamoto has quit IRC | 09:09 | |
| *** vishwanathj has quit IRC | 09:10 | |
| *** vishwanathj has joined #openstack-horizon | 09:12 | |
| *** jtriley has quit IRC | 09:12 | |
| *** Ala has joined #openstack-horizon | 09:13 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:14 | |
| *** yamamoto has joined #openstack-horizon | 09:21 | |
| openstackgerrit | Marc Fouché proposed openstack/horizon: Add missing comment in configuration example https://review.openstack.org/206436 | 09:25 |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Logout user if he has no valid tokens https://review.openstack.org/142481 | 09:27 |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Logout user if he has no valid tokens https://review.openstack.org/142481 | 09:27 |
| *** JeanBriceCombebi has quit IRC | 09:27 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:29 | |
| *** jasondotstar|afk has joined #openstack-horizon | 09:29 | |
| *** yingjun has quit IRC | 09:34 | |
| *** JeanBriceCombebi has quit IRC | 09:34 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:36 | |
| *** romainh has quit IRC | 09:36 | |
| openstackgerrit | ziyu032 proposed openstack/horizon: Display the project name in user detail page https://review.openstack.org/205983 | 09:38 |
| *** kzaitsev_mb has joined #openstack-horizon | 09:39 | |
| *** romainh has joined #openstack-horizon | 09:41 | |
| *** kjelly has quit IRC | 09:53 | |
| *** jasondotstar|afk has quit IRC | 09:54 | |
| *** aix has quit IRC | 09:55 | |
| *** yamamoto has quit IRC | 09:58 | |
| openstackgerrit | Merged openstack/horizon: Create image directly in 'copy_from' and 'location' case https://review.openstack.org/169594 | 10:00 |
| *** annashen has joined #openstack-horizon | 10:02 | |
| *** DaveJ__ has joined #openstack-horizon | 10:03 | |
| *** lexholden has joined #openstack-horizon | 10:03 | |
| *** annashen has quit IRC | 10:07 | |
| *** jasondotstar|afk has joined #openstack-horizon | 10:12 | |
| *** aix has joined #openstack-horizon | 10:22 | |
| *** sayan has quit IRC | 10:32 | |
| *** robcresswell has joined #openstack-horizon | 10:37 | |
| robcresswell | o/ | 10:37 |
| *** sayan has joined #openstack-horizon | 10:38 | |
| *** yamamoto has joined #openstack-horizon | 10:39 | |
| *** yamamoto_ has joined #openstack-horizon | 10:40 | |
| *** bradjones has quit IRC | 10:41 | |
| *** mpavlase has joined #openstack-horizon | 10:43 | |
| *** yamamoto has quit IRC | 10:44 | |
| *** yamamoto_ has quit IRC | 10:48 | |
| *** mwhagedorn has joined #openstack-horizon | 10:50 | |
| *** romainh has quit IRC | 11:01 | |
| *** annashen has joined #openstack-horizon | 11:03 | |
| *** JeanBriceCombebi has quit IRC | 11:04 | |
| *** annashen has quit IRC | 11:07 | |
| *** btully has joined #openstack-horizon | 11:08 | |
| *** xiangxinyong has joined #openstack-horizon | 11:10 | |
| xiangxinyong | hi everyone | 11:10 |
| *** btully has quit IRC | 11:12 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/horizon: Fix code that modified dictionaries while iterating over them https://review.openstack.org/201098 | 11:14 |
| robcresswell | xiangxinyong: o/ | 11:17 |
| xiangxinyong | hi <robcresswell> | 11:18 |
| pkarikh | Hi all! Does anyone know, when I can get Thai Tran here? | 11:18 |
| robcresswell | pkarikh: His irc handle is tqtran, and he's california based | 11:20 |
| robcresswell | pkarikh: So UTC -8 iirc | 11:20 |
| xiangxinyong | *-* | 11:21 |
| pkarikh | robcresswell: yes, thanks. Looks like email is better in this case. :) | 11:22 |
| xiangxinyong | robcresswell:how to get the lastest horizon code? | 11:23 |
| xiangxinyong | I have try this link: https://git.openstack.org/openstack/horizon, but it doesn't work | 11:24 |
| robcresswell | xiangxinyong: This is the repo: https://github.com/openstack/horizon. Just use `git clone https://github.com/openstack/horizon.git` | 11:25 |
| robcresswell | duh, that link formatting screwed up | 11:25 |
| xiangxinyong | robcresswell: thank you. | 11:26 |
| robcresswell | Alternatively, there is a tarball at http://tarballs.openstack.org/horizon/horizon-master.tar.gz :) | 11:26 |
| xiangxinyong | ok. get it. | 11:27 |
| pkarikh | xiangxinyong: also git clone https://review.openstack.org/openstack/horizon works fine for me | 11:29 |
| xiangxinyong | ^-^ | 11:29 |
| *** jtriley has joined #openstack-horizon | 11:33 | |
| *** romainh has joined #openstack-horizon | 11:41 | |
| *** jtriley has quit IRC | 11:41 | |
| *** sayan has quit IRC | 11:44 | |
| *** jasondotstar|afk has quit IRC | 11:46 | |
| *** yamamoto has joined #openstack-horizon | 11:52 | |
| *** ^Gal^ has quit IRC | 11:54 | |
| *** ^Gal^ has joined #openstack-horizon | 11:54 | |
| *** sayan has joined #openstack-horizon | 11:59 | |
| *** mwhagedorn has quit IRC | 12:02 | |
| openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Restrict Upload Image form->Image URL field to http/https schemas https://review.openstack.org/204105 | 12:04 |
| *** annashen has joined #openstack-horizon | 12:04 | |
| *** annashen has quit IRC | 12:09 | |
| *** xiangxinyong has quit IRC | 12:13 | |
| *** ericpeterson has joined #openstack-horizon | 12:17 | |
| *** yamamoto has quit IRC | 12:19 | |
| *** sayan_ has joined #openstack-horizon | 12:19 | |
| openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Restrict Upload Image form->Image URL field to http/https schemas https://review.openstack.org/204105 | 12:20 |
| *** sayan_ has quit IRC | 12:21 | |
| *** josecastroleon has joined #openstack-horizon | 12:22 | |
| *** jacalcat has joined #openstack-horizon | 12:22 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 12:23 | |
| *** xiangxinyong has joined #openstack-horizon | 12:26 | |
| openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Restrict Upload Image form->Image URL field to http/https schemas https://review.openstack.org/204105 | 12:30 |
| *** ericpeterson has quit IRC | 12:30 | |
| *** stevemar has joined #openstack-horizon | 12:31 | |
| openstackgerrit | Merged openstack/horizon: Adding Angular Project Images Table https://review.openstack.org/200385 | 12:33 |
| *** jasondotstar|afk has joined #openstack-horizon | 12:37 | |
| *** kyleolivo has joined #openstack-horizon | 12:38 | |
| *** stevemar has quit IRC | 12:38 | |
| *** JeanBriceCombebi has quit IRC | 12:39 | |
| *** kyleolivo has quit IRC | 12:42 | |
| *** zhenguo has quit IRC | 12:42 | |
| *** radez is now known as radez_g0n3 | 12:42 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 12:43 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: exclude subnets without gateway in create interface https://review.openstack.org/206524 | 12:45 |
| *** stevemar has joined #openstack-horizon | 12:45 | |
| *** neelashah has joined #openstack-horizon | 12:49 | |
| *** jasondotstar|afk is now known as jasondotstar | 12:49 | |
| *** kzaitsev_mb has quit IRC | 12:53 | |
| *** julim has joined #openstack-horizon | 12:55 | |
| *** btully has joined #openstack-horizon | 12:56 | |
| *** btully has quit IRC | 13:00 | |
| *** matt-borland has joined #openstack-horizon | 13:01 | |
| *** lexholden has quit IRC | 13:02 | |
| *** doug-fish has quit IRC | 13:03 | |
| *** annashen has joined #openstack-horizon | 13:05 | |
| *** amotoki has joined #openstack-horizon | 13:08 | |
| *** JeanBriceCombebi has quit IRC | 13:09 | |
| *** annashen has quit IRC | 13:09 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:09 | |
| *** jbell8 has quit IRC | 13:10 | |
| svasheka | mpavlase, hi | 13:11 |
| *** bfic has quit IRC | 13:11 | |
| mpavlase | svasheka: o/ | 13:11 |
| svasheka | mpavlase, about your comment on file name of the screen shot | 13:12 |
| svasheka | mpavlase, you ment that I should just put date first, so that it would be easier to sort? | 13:12 |
| svasheka | mpavlase, or you insisting on date format?) | 13:12 |
| mpavlase | svasheka: yes, I think so | 13:12 |
| mpavlase | svasheka: it doesn't matter if it would be screenshot_2015-07-28_151324.png or 2015-07-28_151324_screenshot.png, because the template for naming would be stable. | 13:14 |
| mpavlase | svasheka: I'm just not in favor with current date format | 13:15 |
| mpavlase | svasheka: what is your opinion? | 13:16 |
| svasheka | well, basically we only need date to get timestamp and guarantee unique filename | 13:17 |
| svasheka | it will also do the sorting trick | 13:17 |
| *** lexholden has joined #openstack-horizon | 13:17 | |
| *** mwhagedorn has joined #openstack-horizon | 13:18 | |
| *** JeanBriceCombebi has quit IRC | 13:18 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:18 | |
| svasheka | mpavlase, format itself doesn't rly change anything. | 13:19 |
| *** yamamoto has joined #openstack-horizon | 13:20 | |
| *** xiangxinyong has quit IRC | 13:21 | |
| *** kzaitsev_mb has joined #openstack-horizon | 13:21 | |
| mpavlase | svasheka: I think it would be more clear | 13:22 |
| mpavlase | svasheka: I would be happy for this small change.. I like the patch anyway | 13:23 |
| *** yamamoto has quit IRC | 13:24 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Add angular system information panel https://review.openstack.org/204731 | 13:25 |
| *** pauloewerton has joined #openstack-horizon | 13:26 | |
| *** tosky has joined #openstack-horizon | 13:27 | |
| *** lucas____ has joined #openstack-horizon | 13:27 | |
| *** mpavlase has quit IRC | 13:31 | |
| *** KingKhan has quit IRC | 13:31 | |
| *** dboik has joined #openstack-horizon | 13:32 | |
| *** MaxV has quit IRC | 13:34 | |
| *** jtriley has joined #openstack-horizon | 13:35 | |
| *** ducttape_ has joined #openstack-horizon | 13:36 | |
| *** btully has joined #openstack-horizon | 13:39 | |
| pauloewerton | hi there. is anyone getting this error when trying to run manage.py on master? | 13:41 |
| pauloewerton | ImportError: Could not import settings 'openstack_dashboard.settings' (Is it on sys.path? Is there an import error in the settings file?): No module named angular_gettext | 13:41 |
| ducttape_ | pauloewerton - have you rebuilt your venv recently? | 13:41 |
| ducttape_ | It sounds like you are missing a pip package, was merged in the last week | 13:41 |
| *** lucas____ has quit IRC | 13:42 | |
| pauloewerton | ducttape_, oh, ok. I'm going to try rebuilding venv | 13:42 |
| ducttape_ | matt-borland - are you there? I promise I'll be nicer today ;) | 13:45 |
| *** lucas____ has joined #openstack-horizon | 13:46 | |
| *** mpavlase has joined #openstack-horizon | 13:47 | |
| *** MaxV has joined #openstack-horizon | 13:47 | |
| matt-borland | ducttape_: yep! | 13:48 |
| *** tvanderwiel has joined #openstack-horizon | 13:49 | |
| matt-borland | ducttape_: it's a difficult transition and we all have priorities. I actually got useful, good information for going forward. | 13:49 |
| ducttape_ | so, I have an option for you to shame me - but also continue this conversation of how to add new panels in a better way | 13:49 |
| *** tvanderwiel has left #openstack-horizon | 13:49 | |
| ducttape_ | I added a new panel to designate not too long ago, and I have an example of how much code was needed. DISCLAIMER: I did not add tests, and this is where you shame me | 13:50 |
| ducttape_ | https://review.openstack.org/#/c/187266/ | 13:50 |
| *** stevemar has quit IRC | 13:50 | |
| matt-borland | no shame is necessary... :) I'm working with the coders to get our patches structured in way that fits what we talked about yesterday. | 13:50 |
| ducttape_ | but that is about 100 lines of code change, if I added a test | 13:50 |
| ducttape_ | if a new panel takes 4 patches and 800 lines of code, we are doing something wrong (my $.02) | 13:51 |
| *** belmoreira has quit IRC | 13:51 | |
| matt-borland | I think the main thing that is different with Angular is that there is a lot of markup. | 13:52 |
| matt-borland | esp. as we are establishing our initial patches | 13:52 |
| ducttape_ | I'm not sure how many lines of code, but the point being is that we need a few people building an easy to reuse / extend core.... and then lightweight extensions to add features | 13:52 |
| matt-borland | yep | 13:52 |
| matt-borland | most of this can be done with using the Horizon and other widgets | 13:52 |
| *** JeanBriceCombebi has quit IRC | 13:53 | |
| ducttape_ | right now we have lots of ~500 lines of code changes, each one promises more reuse.... and then it gets followed on with more changes. we've got to round the corner at some point and actually get to a better spot than the old horizon framework. | 13:54 |
| matt-borland | But there is more verbose markup, partly because semantic markup places much of the information structure specification at that level. | 13:54 |
| matt-borland | there are several sides to this coin, as wel | 13:54 |
| ducttape_ | in the past, we had a fair bit of reuse to drive that type of markup though | 13:55 |
| matt-borland | yeah, there are lots of tradeoffs to having all your markup being generated vs. using semantic markup. | 13:55 |
| matt-borland | Also, when enabling a panel, it's about "100" lines of code--quotes because most of that is copyright/license. :) | 13:56 |
| *** doug-fish has joined #openstack-horizon | 13:57 | |
| matt-borland | so if we look at a patch like: https://review.openstack.org/#/c/205296/ | 13:57 |
| matt-borland | (I am not asking for an approval :) ) | 13:57 |
| ducttape_ | that's just the panel enablement, which is pretty much boilerplate / 0 effort | 13:57 |
| matt-borland | it's really not a lot of code. | 13:57 |
| *** stevemar has joined #openstack-horizon | 13:57 | |
| matt-borland | so I would argue that though it's a "300+" line patch | 13:58 |
| matt-borland | it's really not much different. | 13:58 |
| matt-borland | and it is really quite easy to review and understand | 13:58 |
| ducttape_ | that patch looks to be fairly complete, I would agree | 13:59 |
| matt-borland | yeah, that's the direction we want to go ni | 13:59 |
| ducttape_ | at least it is not partial, or doesn't seem to be | 13:59 |
| matt-borland | *in | 13:59 |
| matt-borland | So per the discussion yesterday, we're going to structure the patches much more along these lines. | 13:59 |
| matt-borland | Rajat actually structured it this way prior to our discussion :) | 14:00 |
| matt-borland | In terms of the patches, the plan is to break them out in sequence of dependency: | 14:01 |
| *** drupalmonkey has joined #openstack-horizon | 14:01 | |
| matt-borland | 1) API (both Django/JS), 2) Panel Setup/"First/Table" page(s), 3) Detail Pages. | 14:01 |
| matt-borland | Each is a single patch that contains the code, docs, and tests as appropriate. | 14:01 |
| matt-borland | If there no new APIs then that set starts at #2 above. | 14:02 |
| *** stevemar has quit IRC | 14:02 | |
| *** Piet has joined #openstack-horizon | 14:04 | |
| ducttape_ | cool. thanks. Sorry for getting at it yesterday, but I feel like this pushback - to get back to a more normal way to add features will help. | 14:04 |
| *** radez_g0n3 is now known as radez | 14:04 | |
| matt-borland | sounds good, I think we've come to a good meeting of minds | 14:05 |
| pauloewerton | matt-borland, so we should submit the api patches before they can actually be manually tested with the panel? | 14:05 |
| matt-borland | I wouldn't ask for them to be approved before seeing them in action, | 14:05 |
| ducttape_ | there are also bunches of bugs that new horizon devs could pickup, which would also be a very positive way to help out (and help learn where we are coming from). | 14:05 |
| *** annashen has joined #openstack-horizon | 14:06 | |
| matt-borland | because it's a decoupled process and it's hard to prove "it works" without an end-to-end test. | 14:06 |
| matt-borland | unit tests can only go so far with regards to APIs being setup/used properly | 14:06 |
| matt-borland | the only exception would be if the APIs are shown to be used by two separate panels, in which case I'd still rather prove it works with one, before committing it and making it available. | 14:07 |
| ducttape_ | I think the general goal is to have a complete end-to-end feature added, with everything you need. this is not a hard and fast rule / 100%.... but should apply to most patches | 14:07 |
| matt-borland | ducttape_: yeah | 14:07 |
| matt-borland | So we have efforts to set up Angular-based panels for Flavor, Defaults, and System Info. I'm hoping to get those following this structure within a day or so (in terms of having patches set up) | 14:08 |
| matt-borland | They won't be ready for approval or anything. | 14:09 |
| matt-borland | but then we can see how this model looks and figure out if it makes sense or needs adjustment. | 14:09 |
| matt-borland | I think it will work well. | 14:09 |
| *** annashen has quit IRC | 14:11 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 14:13 | |
| *** Drago has joined #openstack-horizon | 14:18 | |
| *** yingjun has joined #openstack-horizon | 14:21 | |
| *** masco has quit IRC | 14:21 | |
| *** yingjun has quit IRC | 14:22 | |
| *** stevemar has joined #openstack-horizon | 14:38 | |
| pauloewerton | ducttape_, reconstructing venv didn't seem to help, so I manually install pip package xstatic-angular-gettext. seems to be working, thanks! | 14:39 |
| pauloewerton | installed* | 14:39 |
| ducttape_ | thats weird. that package is not in requirements.txt then? | 14:39 |
| ducttape_ | https://github.com/openstack/horizon/blob/master/requirements.txt#L47 | 14:40 |
| ducttape_ | I see it there, hmm | 14:40 |
| *** JeanBriceCombebi has quit IRC | 14:40 | |
| pauloewerton | ducttape_, yeah, it is there | 14:40 |
| *** stevemar has quit IRC | 14:46 | |
| *** liangbo has joined #openstack-horizon | 14:48 | |
| robcresswell | pauloewerton: Are you up to date with upstream? | 14:49 |
| pauloewerton | robcresswell, yes. I tried to run manage.py just after doing a pull in master branch | 14:50 |
| robcresswell | hmm | 14:50 |
| openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Drop QUnit JS tests in favor of Jasmine https://review.openstack.org/156572 | 14:51 |
| robcresswell | pauloewerton: Uh, I hate to ask, but you did activate the venv right? | 14:51 |
| pauloewerton | robcresswell, actually, I was trying to run it in a devstack, so I didn't activate the venv | 14:54 |
| *** stevemar has joined #openstack-horizon | 14:54 | |
| robcresswell | Ohhh. The stack script probably uses global-reqs and hasnt been updated | 14:55 |
| *** virtuallynathan_ has quit IRC | 14:56 | |
| robcresswell | As in, if the devstack is old, but Horizon is new, perhaps those requirements are out of sync if you manually pulled in a new Horizon | 14:56 |
| pauloewerton | I see. yeah, I should probably update devstack and then run ./stack.sh again | 14:57 |
| robcresswell | I don't know how devstack handles requirements so I may be wrong | 14:58 |
| robcresswell | You can add RECLONE=yes to update the repos when you stack... https://github.com/openstack/horizon/blob/master/doc/source/ref/local_conf.rst | 14:59 |
| pauloewerton | robcresswell, I'll try that, thanks | 15:00 |
| *** yamamoto has joined #openstack-horizon | 15:01 | |
| *** yamamoto has quit IRC | 15:01 | |
| *** yamamoto has joined #openstack-horizon | 15:01 | |
| *** annashen has joined #openstack-horizon | 15:06 | |
| *** bpokorny has joined #openstack-horizon | 15:08 | |
| *** bpokorny has quit IRC | 15:10 | |
| *** tyr has joined #openstack-horizon | 15:10 | |
| *** liangbo has quit IRC | 15:10 | |
| *** annashen has quit IRC | 15:11 | |
| *** dansiwiec has joined #openstack-horizon | 15:17 | |
| *** jbell8 has joined #openstack-horizon | 15:18 | |
| *** vishwanathj has quit IRC | 15:20 | |
| *** hurgleburgler has joined #openstack-horizon | 15:21 | |
| *** markus_z has quit IRC | 15:23 | |
| *** bpokorny has joined #openstack-horizon | 15:25 | |
| *** jasondotstar has quit IRC | 15:25 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon's scss webroot should come from settings.py https://review.openstack.org/206592 | 15:32 |
| *** rdopiera_ has quit IRC | 15:33 | |
| *** jmolo has joined #openstack-horizon | 15:34 | |
| *** SimonChung has joined #openstack-horizon | 15:35 | |
| *** aix has quit IRC | 15:38 | |
| *** dansiwiec has quit IRC | 15:38 | |
| *** josecastroleon has quit IRC | 15:41 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Provide safer popping of values in get_panel_group https://review.openstack.org/206594 | 15:42 |
| *** pkarikh has quit IRC | 15:42 | |
| *** alexvictorchan has joined #openstack-horizon | 15:43 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - Use mock module to avoid using window https://review.openstack.org/199333 | 15:43 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - Fix ng-di errors on cloud-services https://review.openstack.org/198840 | 15:43 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Detail-page directives (Angular/UX) with CSS https://review.openstack.org/158881 | 15:43 |
| *** stevemar has quit IRC | 15:44 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - horizon/ tech-debt https://review.openstack.org/199345 | 15:45 |
| *** vijendar has joined #openstack-horizon | 15:46 | |
| *** alexpilotti has quit IRC | 15:47 | |
| *** annashen has joined #openstack-horizon | 15:48 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Detail-page directives (Angular/UX) with CSS https://review.openstack.org/158881 | 15:48 |
| *** nlahouti has joined #openstack-horizon | 15:49 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP - Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 15:49 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP - Image Details Edit/Delete (UX/Angular) https://review.openstack.org/158409 | 15:49 |
| *** sqchen has joined #openstack-horizon | 15:50 | |
| *** sqchen has joined #openstack-horizon | 15:50 | |
| *** annashen has quit IRC | 15:51 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Add angular defaults panel for admin https://review.openstack.org/205296 | 15:54 |
| *** tjones has joined #openstack-horizon | 15:55 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Add angular defaults panel for admin https://review.openstack.org/205296 | 15:55 |
| *** logan2 has quit IRC | 15:55 | |
| *** rajatvig has joined #openstack-horizon | 15:55 | |
| *** juggler_ has joined #openstack-horizon | 15:59 | |
| *** ygbo has quit IRC | 16:00 | |
| *** lucas____ has quit IRC | 16:00 | |
| *** juggler has quit IRC | 16:01 | |
| *** KunalGandhi has joined #openstack-horizon | 16:02 | |
| *** lexholden has quit IRC | 16:02 | |
| *** pkarikh has joined #openstack-horizon | 16:04 | |
| *** rajatvig has quit IRC | 16:05 | |
| *** kmARC has quit IRC | 16:06 | |
| *** annashen has joined #openstack-horizon | 16:07 | |
| *** bluex-pl has quit IRC | 16:11 | |
| *** annashen has quit IRC | 16:12 | |
| *** jbell8 has quit IRC | 16:12 | |
| tsufiev | Has anyone encountered the error u'Expecting to find project, domain, or OS-TRUST:trust in scope - the server could not comply with the request since it is either malformed or otherwise incorrect. The client is assumed to be in error. (HTTP 400)' while connecting authenticating to keystone (exception text from openstack_auth.backend | 16:16 |
| tsufiev | )? | 16:16 |
| ducttape_ | tsufiev - I know keystone made some changes with devstack around the url it was using. not sure if that is related | 16:18 |
| *** e0ne has quit IRC | 16:20 | |
| *** tqtran has joined #openstack-horizon | 16:20 | |
| *** logan2 has joined #openstack-horizon | 16:24 | |
| *** ducttape_ has quit IRC | 16:25 | |
| *** ducttape_ has joined #openstack-horizon | 16:27 | |
| *** jmolo1 has joined #openstack-horizon | 16:31 | |
| *** jmolo has quit IRC | 16:34 | |
| *** jasondotstar has joined #openstack-horizon | 16:34 | |
| *** annashen has joined #openstack-horizon | 16:38 | |
| *** jbell8 has joined #openstack-horizon | 16:38 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon's scss webroot should come from settings.py https://review.openstack.org/206592 | 16:39 |
| *** lucas__ has joined #openstack-horizon | 16:40 | |
| *** lucas__ has quit IRC | 16:41 | |
| *** lucas__ has joined #openstack-horizon | 16:41 | |
| tsufiev | ducttape_, yeah, I encountered this issue also, but it's clearly a different thing | 16:45 |
| *** lucas__ has quit IRC | 16:46 | |
| *** tosky has quit IRC | 16:47 | |
| *** tosky has joined #openstack-horizon | 16:47 | |
| *** KunalGandhi has quit IRC | 16:49 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 16:52 | |
| *** lucas__ has joined #openstack-horizon | 16:53 | |
| *** alexvictorchan has quit IRC | 16:53 | |
| *** sayan has quit IRC | 16:53 | |
| *** tqtran_ has joined #openstack-horizon | 16:54 | |
| *** tqtran_ has quit IRC | 16:54 | |
| *** tosky has quit IRC | 16:55 | |
| *** jbell8 has quit IRC | 16:56 | |
| *** kyleolivo has joined #openstack-horizon | 16:57 | |
| *** annashen has quit IRC | 16:57 | |
| *** ybathia has joined #openstack-horizon | 16:57 | |
| *** kyleolivo has quit IRC | 16:57 | |
| *** alexvictorchan has joined #openstack-horizon | 16:58 | |
| *** kyleolivo has joined #openstack-horizon | 16:59 | |
| *** annashen has joined #openstack-horizon | 16:59 | |
| *** jingjing_ren has joined #openstack-horizon | 17:00 | |
| *** jingjing_ren has quit IRC | 17:00 | |
| *** skylerberg has joined #openstack-horizon | 17:01 | |
| *** jingjing_ren has joined #openstack-horizon | 17:01 | |
| *** dboik has quit IRC | 17:01 | |
| *** dansiwiec has joined #openstack-horizon | 17:02 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Dashboard ReOrg - Move tech-debt into app/ https://review.openstack.org/197353 | 17:03 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Auto-collect app/ instead of only app/core/ https://review.openstack.org/205720 | 17:03 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Dashboard ReOrg - Move APIs into app/core https://review.openstack.org/197330 | 17:03 |
| openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/horizon: Add Storm Job to UI https://review.openstack.org/204647 | 17:04 |
| *** jbell8 has joined #openstack-horizon | 17:04 | |
| *** KunalGandhi has joined #openstack-horizon | 17:09 | |
| *** KunalGandhi has quit IRC | 17:09 | |
| *** KunalGandhi has joined #openstack-horizon | 17:10 | |
| *** dansiwiec has quit IRC | 17:11 | |
| *** lucas__ has quit IRC | 17:11 | |
| *** neelashah has quit IRC | 17:11 | |
| matt-borland | If I could have a couple more eyes on a 6-character fix: https://review.openstack.org/#/c/206594/ | 17:12 |
| *** dansiwiec has joined #openstack-horizon | 17:12 | |
| matt-borland | This safety flaw has side effects that are causing some problems with tests. | 17:13 |
| *** kyleoliv_ has joined #openstack-horizon | 17:13 | |
| *** MaxV has quit IRC | 17:13 | |
| *** kyleolivo has quit IRC | 17:16 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: [Launch Instance Fix] Show Admin Password https://review.openstack.org/171450 | 17:16 |
| *** kyleoliv_ has quit IRC | 17:18 | |
| *** stevemar has joined #openstack-horizon | 17:21 | |
| *** shivrao has joined #openstack-horizon | 17:23 | |
| *** jpomeroy has quit IRC | 17:24 | |
| *** sayan has joined #openstack-horizon | 17:24 | |
| kfox1111_ | ok. so... I'm trying to extract the angular plugin I wrote from the changes I made to horizon, and the changes to horizon to forward port to trunk for submission. | 17:26 |
| *** lucas__ has joined #openstack-horizon | 17:26 | |
| kfox1111_ | I made a tweak to: horizon/static/horizon/js/horizon.images.js which doesn't seem to exist. | 17:26 |
| kfox1111_ | any idea where it might have gone? | 17:26 |
| *** neelashah has joined #openstack-horizon | 17:26 | |
| *** JeanBriceCombebi has quit IRC | 17:28 | |
| tyr | kfox1111_: any particular symbol you are looking for? | 17:29 |
| *** davidmichaelkarr has quit IRC | 17:29 | |
| kfox1111_ | the whole file. doesn't exist for some reason. | 17:30 |
| *** romainh has quit IRC | 17:31 | |
| tyr | yes, that was split out into its corresponding pieces. | 17:31 |
| tyr | See horizon/openstack_dashboard/static/app/tech-debt/ for the ImageFormCtrl | 17:32 |
| tyr | and horizon/horizon/static/framework/util/tech-debt/image-file-on-change.js for the imageFileOnChange directive | 17:33 |
| *** romainh has joined #openstack-horizon | 17:33 | |
| *** rdopiera has quit IRC | 17:33 | |
| kfox1111_ | Ah. there it is. thanks. | 17:34 |
| kfox1111_ | oh. one more. I added a horizon/static/horizon/js/angular/services/hz.api.heat.js | 17:34 |
| kfox1111_ | but that directory is empty on the trunk checkout. | 17:35 |
| *** davidmichaelkarr has joined #openstack-horizon | 17:37 | |
| openstackgerrit | Kyle Olivo proposed openstack/horizon: WIP: Add API services for system information https://review.openstack.org/205196 | 17:38 |
| *** romainh has left #openstack-horizon | 17:40 | |
| *** annashen has quit IRC | 17:42 | |
| *** Ala has quit IRC | 17:42 | |
| kfox1111_ | ah. now looks like its under openstack_dashboard/static/openstack-service-api/ | 17:44 |
| *** jwy has joined #openstack-horizon | 17:46 | |
| *** jbell8 has quit IRC | 17:46 | |
| *** jpomeroy has joined #openstack-horizon | 17:47 | |
| ybathia | horizon stable/juno run_tests.sh gave me oslo related unit test failure and I see horizon stable/juno requirements.txt and the global-requirements.txt in the requirements repo are different, submitted this path of fix the tests https://review.openstack.org/#/c/203783/ but jenkins is giving a strange error, does anyone know what am I missing here? | 17:47 |
| *** amotoki has quit IRC | 17:48 | |
| *** SimonChung has quit IRC | 17:50 | |
| *** SimonChung has joined #openstack-horizon | 17:50 | |
| *** annashen has joined #openstack-horizon | 17:52 | |
| bpokorny | ybathia: I would ask in the infrastructure channel about that one. It's weird that Jenkins -1'd the patch but doesn't show any specific failure. | 17:53 |
| *** Ala has joined #openstack-horizon | 17:54 | |
| ybathia | bpokorny: Thanks, I will ask in the infrastructure channel | 17:54 |
| bpokorny | np | 17:54 |
| *** lhcheng_ has joined #openstack-horizon | 17:55 | |
| *** lhcheng_ has quit IRC | 17:55 | |
| *** lhcheng_ has joined #openstack-horizon | 17:56 | |
| *** annashen has quit IRC | 17:56 | |
| *** ybathia has quit IRC | 17:57 | |
| openstackgerrit | Kyle Olivo proposed openstack/horizon: WIP: Add API services for system information https://review.openstack.org/205196 | 17:57 |
| openstackgerrit | Kyle Olivo proposed openstack/horizon: Add angular system information panel https://review.openstack.org/204731 | 17:57 |
| *** dboik has joined #openstack-horizon | 17:57 | |
| *** saksham has joined #openstack-horizon | 17:58 | |
| *** jasondotstar has quit IRC | 17:58 | |
| *** Piet has quit IRC | 17:58 | |
| *** jwy has quit IRC | 17:59 | |
| *** Ala has quit IRC | 17:59 | |
| *** jwy has joined #openstack-horizon | 17:59 | |
| openstackgerrit | Kyle Olivo proposed openstack/horizon: WIP: Add angular system information panel https://review.openstack.org/204731 | 17:59 |
| *** tosky has joined #openstack-horizon | 18:00 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding PUT to REST api service https://review.openstack.org/206639 | 18:00 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Mock API - mock 401 error https://review.openstack.org/206642 | 18:01 |
| *** neelashah has quit IRC | 18:01 | |
| kfox1111_ | whats the best way to setup the venv with a fresh horizon checkout? | 18:02 |
| david-lyle | kfox1111_: ./run_tests.sh | 18:02 |
| david-lyle | either to run the tests | 18:03 |
| david-lyle | or to launch the test server, both will check for the venv and populate if missing | 18:03 |
| kfox1111_ | k. thanks. | 18:03 |
| tqtran | you can also just -f if you want to force one | 18:03 |
| tqtran | "./run_test.sh -f" that is | 18:04 |
| david-lyle | which is will remove the existing venv and recreate it | 18:04 |
| med_ | cool info. | 18:04 |
| david-lyle | so on a fresh checkout, not necessary :) | 18:04 |
| david-lyle | but useful none the less | 18:04 |
| kfox1111_ | yeah. thrying to come up with instructions for, git clone horizon, ./run_test.sh, checkout plugin, install it, run server standalone, etc. | 18:04 |
| david-lyle | kfox1111_: me too :) | 18:05 |
| david-lyle | but I keep getting sidetracked | 18:05 |
| kfox1111_ | :) | 18:05 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding PUT to REST api service https://review.openstack.org/206639 | 18:05 |
| david-lyle | kfox1111_: https://blueprints.launchpad.net/horizon/+spec/plugin-sanity | 18:06 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon's scss webroot should come from settings.py https://review.openstack.org/206592 | 18:06 |
| kfox1111_ | ah. +1. :) | 18:06 |
| *** romainh has joined #openstack-horizon | 18:08 | |
| *** lucas__ has quit IRC | 18:09 | |
| kfox1111_ | can you run_tests.sh with -f but without doing anything time intensive? | 18:09 |
| *** lucas__ has joined #openstack-horizon | 18:09 | |
| openstackgerrit | Kyle Olivo proposed openstack/horizon: WIP: Add angular system information panel https://review.openstack.org/204731 | 18:10 |
| kfox1111_ | --docs maybe? | 18:10 |
| hurgleburgler | —pep8 is pretty fast | 18:11 |
| kfox1111_ | k. thx. | 18:11 |
| matt-borland | david-lyle: re my patch you commented on (thanks)...openstack_dashboard/test/settings.py...what do I register there? I don't see anything obvious nor do I see it in the docs | 18:11 |
| david-lyle | holy ****: http://logs.openstack.org/63/206263/1/check/gate-tempest-dsvm-full/35e7066/console.html#_2015-07-28_12_27_55_958 | 18:11 |
| matt-borland | at http://docs.openstack.org/developer/horizon/topics/tutorial.html | 18:11 |
| david-lyle | glance tests are hard-coded to use horizon favicon | 18:12 |
| david-lyle | why | 18:12 |
| david-lyle | matt-borland: just a sec | 18:12 |
| matt-borland | np, thx | 18:12 |
| david-lyle | actually I fixed that | 18:14 |
| *** rdopiera has joined #openstack-horizon | 18:14 | |
| david-lyle | is the panel in enabled/ or local/enabled? | 18:14 |
| matt-borland | enabled: openstack_dashboard/enabled/_205_admin_defaults.py | 18:14 |
| matt-borland | in patch: https://review.openstack.org/#/c/205296/ | 18:15 |
| david-lyle | so DISABLED = True in there | 18:15 |
| matt-borland | Yeah, to see the problem set it to DISABLED = False | 18:16 |
| david-lyle | so you're experiencing correct behavior | 18:16 |
| matt-borland | Clearly the panel shows up when I fire up the UI | 18:16 |
| matt-borland | (when DISABLED = False) | 18:16 |
| matt-borland | so it's working at that level. | 18:16 |
| matt-borland | but something about the test context is causing trouble. | 18:17 |
| david-lyle | actually, the real problem is there is no panel_Group with the slug 'admin' | 18:18 |
| matt-borland | ok | 18:18 |
| matt-borland | but, that works, and it doesn't seem to be named 'system' | 18:19 |
| matt-borland | again, difference between test environment and runtime | 18:19 |
| *** lucas__ has quit IRC | 18:19 | |
| matt-borland | so, if 'admin' is incorrect, then what is the proper slug? | 18:19 |
| *** lucas__ has joined #openstack-horizon | 18:19 | |
| david-lyle | actually it is called admin | 18:20 |
| matt-borland | exactly :) | 18:20 |
| david-lyle | poorly named | 18:20 |
| matt-borland | indeed :) | 18:20 |
| matt-borland | that set us back a few minutes. | 18:20 |
| matt-borland | I really don't think the panel is configured wrong. It works. | 18:21 |
| *** vishwanathj has joined #openstack-horizon | 18:21 | |
| david-lyle | why is your panel path a list ?? | 18:21 |
| openstackgerrit | Dan Siwiec proposed openstack/horizon: WIP : Add angular defaults panel for admin https://review.openstack.org/205296 | 18:22 |
| matt-borland | david-lyle: lemme see | 18:22 |
| david-lyle | not a list, just spurious parens | 18:22 |
| david-lyle | probably not an issue | 18:22 |
| matt-borland | ok. | 18:22 |
| david-lyle | adding to admin/dashboard.py should not be necessary | 18:24 |
| matt-borland | Yeah, I agree | 18:24 |
| david-lyle | you are doing the same operation twice | 18:24 |
| *** yamamoto has quit IRC | 18:24 | |
| matt-borland | other patches don't do that. | 18:24 |
| matt-borland | when I took that out, it had no effect. | 18:24 |
| david-lyle | you may be replacing the good reference to the panel with the empty | 18:24 |
| david-lyle | just a thought | 18:24 |
| david-lyle | which would explain why you have it in the list, but no class | 18:24 |
| matt-borland | I think that's true. I tried renaming the panel | 18:24 |
| matt-borland | but that didn't seem to work. | 18:25 |
| *** vishwana_ has joined #openstack-horizon | 18:25 | |
| david-lyle | remove the .pyc files | 18:25 |
| david-lyle | and try again | 18:25 |
| *** vishwanathj has quit IRC | 18:25 | |
| matt-borland | I can do that :) | 18:25 |
| *** ongk has joined #openstack-horizon | 18:25 | |
| *** annashen has joined #openstack-horizon | 18:27 | |
| *** vishwana_ has quit IRC | 18:27 | |
| matt-borland | OK david-lyle: I changed the name to "NG Default" in panel.py, removed panel.pyc, ran the test again, and it still fails. | 18:27 |
| david-lyle | matt-borland: what name? | 18:28 |
| matt-borland | in panel.py, the name that is given to the Panel. | 18:28 |
| matt-borland | Again, it runs just fine even with name collisions. :) Just failing in the tests. | 18:29 |
| *** ybathia has joined #openstack-horizon | 18:30 | |
| matt-borland | and the problem, despite assumptions, goes away when we don't assume that .pop() will always find the key. | 18:31 |
| matt-borland | what exactly is that key that it's searching by? That seems to be making an invalid assumptino. | 18:31 |
| matt-borland | *tion | 18:32 |
| matt-borland | I guess the key is getting overloaded, and when it comes time to clean, there's a dupe in the iterated list but obviously not in the keys. | 18:33 |
| matt-borland | so if this patch is duplicating it shouldn't...I can see that...but I don't know where it is, and it works fine during runtime. | 18:34 |
| matt-borland | hence the 6-character 'fix' | 18:34 |
| david-lyle | matt-borland: the key is the slug, not the name | 18:35 |
| david-lyle | name is only for display | 18:35 |
| matt-borland | ok, so am I duping a slug somewhere? | 18:36 |
| matt-borland | I am setting PANEL = 'ngdefaults' | 18:36 |
| *** SimonChung has quit IRC | 18:36 | |
| *** SimonChung1 has joined #openstack-horizon | 18:36 | |
| matt-borland | and it's not just this patch, I have 3 (very similar) patches that have the same issue, so clearly I'm replicating the problem. :) | 18:37 |
| *** josecastroleon has joined #openstack-horizon | 18:38 | |
| matt-borland | slug = "ngdefaults" too | 18:38 |
| *** Piet has joined #openstack-horizon | 18:41 | |
| david-lyle | matt-borland: couple of more comments on patch | 18:44 |
| matt-borland | sure | 18:44 |
| david-lyle | so the lines are clear | 18:44 |
| matt-borland | it's not up for review yet :) | 18:44 |
| david-lyle | but the manual register may not be a good idea | 18:44 |
| matt-borland | well, it does work. | 18:45 |
| david-lyle | it's not, but the WIP unfortunately has to be flagged with each revisiion | 18:45 |
| david-lyle | sorry in panel.py | 18:45 |
| kfox1111_ | I'm a bit confused... | 18:45 |
| *** DaveJ__ has quit IRC | 18:45 | |
| david-lyle | the registration should happen when the enabled file is processed | 18:46 |
| kfox1111_ | where to the template html files end up on install in mon-ex? | 18:46 |
| matt-borland | david-lyle: I will instruct everyone to WIP it on every commit if that is your direction :) | 18:46 |
| matt-borland | *patchset | 18:46 |
| matt-borland | so, david-lyle, what needs to change? | 18:46 |
| david-lyle | matt-borland: if you are not ready for review, then yes, otherwise we just review | 18:46 |
| matt-borland | yep | 18:47 |
| matt-borland | BUT | 18:47 |
| matt-borland | to the matter at hand | 18:47 |
| david-lyle | #truestory, if you go back and look at the ng launch instance bp, I think all are titled WIP | 18:47 |
| david-lyle | yet merged | 18:47 |
| matt-borland | what needs to change about how I'm registering the panels. | 18:47 |
| matt-borland | I believe everything is OK, and again point out that it functions properly at runtime. | 18:48 |
| david-lyle | the changes to dashboard.py and the register call in panel.py are unnecessary | 18:48 |
| *** stevemar has quit IRC | 18:48 | |
| matt-borland | OK, so I can take those out but the dashboard.py change made no effect | 18:48 |
| lhcheng_ | matt-borland: I think just having WIP in the title would be good enough, it is easy to forget setting the status to WIP every patch set. | 18:48 |
| david-lyle | even so, you're mixing methods of registration | 18:48 |
| david-lyle | whether it works, doesn't make it a good idea | 18:49 |
| david-lyle | :) | 18:49 |
| matt-borland | ok, so I'll take *both* out just just one? | 18:49 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Themes should live at root of openstack_dashboard https://review.openstack.org/206654 | 18:49 |
| matt-borland | also, this does indicate a disconnect between the processes at runtime and in the test runner. | 18:49 |
| matt-borland | which again, I think is the real problem. | 18:49 |
| matt-borland | and the only conflict that comes up is fixed by my patch. :) | 18:50 |
| david-lyle | matt-borland: WIP in title is fine, the BPs become a mess and people don't update them, so I get frustrated as probably the only person that actually looks at the bps | 18:50 |
| kfox1111_ | david-lyle: I think I'm really close, but I'm not sure how the templates are suposed to be installed. they don't seem to be. | 18:50 |
| david-lyle | matt-borland: but your fix is a bandaid to hide the problem | 18:50 |
| matt-borland | agreed, david-lyle | 18:50 |
| david-lyle | we should fix the real problem, if it exists | 18:50 |
| matt-borland | so, david-lyle, let me try removing the dual registration first. | 18:51 |
| matt-borland | although I did try that before (the other patches don't dual register) | 18:51 |
| david-lyle | matt-borland: that's fine, but it's creating unnecessary entanglements | 18:52 |
| david-lyle | that will have to be un-entangled when all panels load via enabled | 18:52 |
| matt-borland | ok, just a second. removing the dashboard registration didn't change anything | 18:52 |
| *** ongk has quit IRC | 18:52 | |
| david-lyle | kfox1111_: aren't the templates in you package? | 18:52 |
| david-lyle | matt-borland: but proved unnecessary :) | 18:53 |
| kfox1111_ | yes, but they don't seem to be installed. | 18:53 |
| *** alexvictorchan has quit IRC | 18:53 | |
| kfox1111_ | they don't seem to intsall in the mon-ex example either. | 18:53 |
| david-lyle | not installed? | 18:53 |
| kfox1111_ | let me double check that with a fresh checkout. | 18:54 |
| david-lyle | they just live in the module where it's installed | 18:54 |
| kfox1111_ | TemplateDoesNotExist at /admin/logs_panel/ | 18:55 |
| kfox1111_ | TemplateDoesNotExist: log_panel/index.html | 18:55 |
| matt-borland | david-lyle: so, no-go on removing those registrations. Still the same error. | 18:55 |
| kfox1111_ | it doesn't look like setup.py's installing it. | 18:55 |
| kfox1111_ | kfox2@mantis:~/svn/mon-ext$ ls ../horizon-app-catalog4/.venv/lib/python2.7/site-packages/log_panel/ | 18:56 |
| kfox1111_ | __init__.py __init__.pyc panel.py panel.pyc tabs.py tabs.pyc urls.py urls.pyc views.py views.pyc | 18:56 |
| *** SimonChung has joined #openstack-horizon | 18:58 | |
| *** SimonChung1 has quit IRC | 18:58 | |
| david-lyle | kfox1111_: well that's odd | 18:59 |
| *** radez is now known as radez_g0n3 | 18:59 | |
| david-lyle | matt-borland: but the runtime still works, correct | 18:59 |
| david-lyle | ? | 18:59 |
| matt-borland | yep | 18:59 |
| matt-borland | so that's 'good' :) | 18:59 |
| david-lyle | so now we just need to figure out why your loading in the test side isn't working without pasting over it | 18:59 |
| matt-borland | yeah | 18:59 |
| matt-borland | seemed like a simple problem at first :) | 19:00 |
| david-lyle | sounds like you have a fun afternoon ahead of you :P | 19:00 |
| david-lyle | jk | 19:00 |
| matt-borland | that's why I put up that patch! | 19:00 |
| matt-borland | ;) | 19:00 |
| david-lyle | so your test works then? | 19:01 |
| matt-borland | when I make that change, yep. | 19:01 |
| david-lyle | when you use null for the __class__? | 19:01 |
| david-lyle | err None | 19:01 |
| matt-borland | it's not using None | 19:01 |
| matt-borland | it's just saying "when you pop, if you don't have that key, return None" | 19:01 |
| kfox1111_ | is it because the templates are non python files? | 19:01 |
| matt-borland | which of course doesn't matter because we're not using the return value. | 19:01 |
| matt-borland | I could have said: | 19:02 |
| david-lyle | forgot patch content, looking again | 19:02 |
| matt-borland | np | 19:02 |
| david-lyle | kfox1111_: are you doing an sdist? | 19:02 |
| david-lyle | on the git repo? | 19:02 |
| * david-lyle feels like watching tennis | 19:03 | |
| kfox1111_ | I did: ../horizon-app-catalog4/tools/with_venv.sh pip install --upgrade . | 19:03 |
| matt-borland | lol david-lyle | 19:03 |
| *** e0ne has joined #openstack-horizon | 19:03 | |
| david-lyle | of the sdist output? | 19:04 |
| kfox1111_ | no. of the git repo. | 19:04 |
| kfox1111_ | do I have to setup sdist first? | 19:04 |
| *** kzaitsev_mb has quit IRC | 19:04 | |
| david-lyle | kfox1111_: try sdist | 19:05 |
| *** Piet has quit IRC | 19:05 | |
| *** jmolo1 has quit IRC | 19:05 | |
| kfox1111_ | just tried that. no templates in the tarball. | 19:05 |
| david-lyle | and use the tar.gz in the dist directory | 19:06 |
| david-lyle | ?? | 19:06 |
| kfox1111_ | same with mon-ext.... | 19:06 |
| david-lyle | kfox1111_: ok, I'm seeing that too | 19:06 |
| david-lyle | hold on | 19:06 |
| *** robcresswell has quit IRC | 19:06 | |
| kfox1111_ | k. thx. | 19:07 |
| *** josecastroleon has quit IRC | 19:08 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Create a Bootstrap Theme Preview Page with HTML Hints https://review.openstack.org/187818 | 19:12 |
| *** jingjing_ren has quit IRC | 19:13 | |
| david-lyle | ok got it | 19:13 |
| david-lyle | will post update to mon-ext | 19:13 |
| *** jingjing_ren has joined #openstack-horizon | 19:13 | |
| kfox1111_ | k. thx. | 19:13 |
| *** jprovazn has quit IRC | 19:14 | |
| david-lyle | kfox1111_: https://github.com/dklyle/mon-ext/blob/master/MANIFEST.in | 19:14 |
| david-lyle | have to specify their inclusion | 19:15 |
| david-lyle | has to be a better way, but that's in the django docs to use | 19:15 |
| david-lyle | (shrug) | 19:15 |
| kfox1111_ | ay. | 19:16 |
| kfox1111_ | ah. | 19:16 |
| kfox1111_ | yup. that did it. thanks. :) | 19:16 |
| kfox1111_ | really close now. :) just gota figure out why encodeURIComponentFilterProvider is not working... | 19:17 |
| *** Piet has joined #openstack-horizon | 19:17 | |
| kfox1111_ | oh. cause I gota figure out where to put my ansible javascript... | 19:17 |
| david-lyle | kfox1111_: add recursive include of static directories as well | 19:18 |
| tyr | tqtran: TravT clu, If you have a moment, https://review.openstack.org/#/c/206267/. It fixes an annoying bug in the magic search tests that make re-running the Jasmine tests problematic. | 19:19 |
| david-lyle | kfox1111_: recursive-include polls/static * | 19:19 |
| kfox1111_ | so in the horizon builtin version, I have it at: horizon/openstack_dashboard/static/dashboard/project/app_catalog/app_catalog.js | 19:19 |
| david-lyle | if polls were your module | 19:19 |
| kfox1111_ | k. | 19:19 |
| *** sqchen has quit IRC | 19:19 | |
| david-lyle | kfox1111_: more info https://docs.djangoproject.com/en/1.8/intro/reusable-apps/ | 19:19 |
| *** sqchen has joined #openstack-horizon | 19:20 | |
| kfox1111_ | k. then need two more things... how to load the js, and what angular module to put it in. right now its .module('hz.dashboard.project', ['hz.dashboard']) | 19:21 |
| kfox1111_ | which I'm sure is wrong now. | 19:21 |
| david-lyle | kfox1111_: I think you'll want to namespace the angular module to your app not horizon | 19:22 |
| tqtran | tyr: there's no redirection happening there | 19:22 |
| tqtran | not sure why its problematic? | 19:22 |
| david-lyle | but tqtran can walk you through that part better than I | 19:22 |
| tyr | it changes the url, after running once in the browser, if you then *reload*, the tests fail | 19:22 |
| *** lhcheng_ has left #openstack-horizon | 19:23 | |
| *** Berezin has joined #openstack-horizon | 19:23 | |
| tqtran | tyr: ah got it, ok i'll take a look | 19:23 |
| david-lyle | matt-borland: do you have a patch for the tests? | 19:23 |
| tyr | tqtran: basically just an annoyance during development and testing | 19:23 |
| tyr | Thanks tqtran! | 19:24 |
| kfox1111_ | tqtran: any thoughts on how to load the js and how to namespace it? | 19:24 |
| tqtran | kfox1111_: the loading of the js files are automatic, just make sure you name your extensions properly | 19:24 |
| kfox1111_ | k. what should it be named? | 19:24 |
| *** yamamoto has joined #openstack-horizon | 19:24 | |
| tqtran | here is the order: *.module.js, *.js, *.mock.js, *.spec.js | 19:25 |
| tyr | kfox1111_: I've been working on a doc update. This might be helpful --> https://review.openstack.org/#/c/203862 | 19:25 |
| tqtran | the auto discovery sort files according to their js file extensions, this ensures that our modules are loaded first | 19:25 |
| *** Drago has quit IRC | 19:26 | |
| tqtran | as for namespace, it should be something like: hz.dashboard.<dashboard>.<panel>.js | 19:26 |
| matt-borland | david-lyle: you mean other patches? | 19:26 |
| kfox1111_ | tyr: Does that apply to external modules as well? | 19:26 |
| kfox1111_ | k. | 19:27 |
| tqtran | kfox1111_: and for more granular things, like table, you'll need a subfolder /table/<panel>.table.js | 19:27 |
| matt-borland | david-lyle: In https://review.openstack.org/#/c/205296/ | 19:27 |
| david-lyle | (facepalm) matt-borland I missed that the test was what was in the patch | 19:27 |
| kfox1111_ | what about sharing a js file between two panels? | 19:27 |
| matt-borland | you can set DISABLED = False | 19:27 |
| *** dhellmann has joined #openstack-horizon | 19:27 | |
| tqtran | yes the naming rules apply to external as well, but we cant enforce that, you can do whatever you want really | 19:28 |
| matt-borland | to test the proposed fix, you can just change horizon/base.py as shown in the fix patch. | 19:28 |
| kfox1111_ | k. and how do you load it externally? | 19:28 |
| david-lyle | matt-borland: no | 19:28 |
| david-lyle | I won't | 19:28 |
| david-lyle | :P | 19:28 |
| matt-borland | :) | 19:28 |
| dhellmann | david-lyle: drop by #openstack-relmgr-office when you're ready to talk about milestone tags for L2 this week | 19:28 |
| david-lyle | dhellmann: on my way | 19:29 |
| *** yamamoto has quit IRC | 19:29 | |
| tqtran | kfox1111_: for sharing a JS, you will need to put it into openstack_dashboard/static/app/core/* | 19:29 |
| kfox1111_ | externally? | 19:29 |
| tqtran | yes, you can override these, they are static files | 19:30 |
| tqtran | well not override, "add to" is the more correct term | 19:30 |
| tyr | kfox1111_: are you trying to share .js between two panels within the same dashboard...or different dashboards? | 19:30 |
| *** annashen has quit IRC | 19:30 | |
| kfox1111_ | so mon-ext/openstack_dashboard/static/app/core/foo.js | 19:30 |
| *** radez_g0n3 is now known as radez | 19:30 | |
| kfox1111_ | same dashboard. | 19:31 |
| tqtran | if its the same, you dont need to do anything | 19:31 |
| tqtran | the JS file should be accessible anywhere within that dashboard | 19:31 |
| tyr | app/core is intended for files that need to be shared across dashboards, but aren't generic enough to be stand alone widgets in horizon.framework | 19:31 |
| kfox1111_ | k. | 19:32 |
| *** KunalGandhi has quit IRC | 19:32 | |
| kfox1111_ | so, back to david-lyle's example, | 19:32 |
| kfox1111_ | we pull https://github.com/dklyle/mon-ext.git, | 19:33 |
| kfox1111_ | add mon-ext/openstack_dashboard/static/app/core/foo.js | 19:33 |
| *** jmolo has joined #openstack-horizon | 19:33 | |
| kfox1111_ | and the templates inside can use angular stuff defined in foo? | 19:33 |
| *** jingjing_ren has quit IRC | 19:33 | |
| tqtran | you would need to create a /static/dashboard/<DASHBOARD>/<PANEL>/*.js | 19:34 |
| kfox1111_ | ... | 19:34 |
| tqtran | no need to put it into core for this one, since they all go into the same dashboard | 19:34 |
| kfox1111_ | I've got two panels. app_catalog and component_catalog. They both should share the same js file. | 19:34 |
| tqtran | core is only for sharing between two different dashboard: like admin dashboard and identity dashboard | 19:34 |
| tqtran | ok, let me walk you through an example: | 19:35 |
| kfox1111_ | yes please. :) | 19:35 |
| tqtran | you have app_catalog and comp_catalog panels | 19:35 |
| tqtran | and you want to add them to the projects dashboard | 19:35 |
| *** Piet has quit IRC | 19:36 | |
| tqtran | ok lets pretend you want to add to admin dashboard instead | 19:36 |
| tqtran | since it fits dave's file structure a bit more | 19:36 |
| *** radez is now known as radez_g0n3 | 19:36 | |
| *** lucas__ has quit IRC | 19:36 | |
| david-lyle | kfox1111_: I'm not sure the path in my example should have openstack_dashboard in it | 19:36 |
| *** nlahouti has quit IRC | 19:36 | |
| *** lucas__ has joined #openstack-horizon | 19:37 | |
| matt-borland | david-lyle: so how do you want me to structure the patch(es) to demonstrate how the proposed fix fixes the problem? Since these are *appropriately* not merged panel patches? | 19:38 |
| matt-borland | I think it's pretty clear that the fix doesn't have a negative effect, and does have a positive effect. | 19:38 |
| tqtran | kfox1111_: let me actually upload something that you can use | 19:38 |
| tqtran | i think that would be a lot clearer | 19:39 |
| kfox1111_ | k. thx. :) | 19:39 |
| *** guya has joined #openstack-horizon | 19:39 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: WIP Adding CREATE action to identity users panel https://review.openstack.org/202315 | 19:39 |
| david-lyle | matt-borland: I'm going to run locally and try to figure out why you're in that state | 19:40 |
| matt-borland | thank you, david-lyle | 19:40 |
| david-lyle | but I'd rather find the underlying problem | 19:40 |
| matt-borland | agreed...and if I can help, I tried rooting around as well, just less familiar with the depths here. | 19:41 |
| *** neelashah has joined #openstack-horizon | 19:42 | |
| kfox1111_ | tqtran: is that gerrit post the example, or something different? | 19:43 |
| *** SimonChung has quit IRC | 19:43 | |
| *** SimonChung has joined #openstack-horizon | 19:43 | |
| *** jbell8 has joined #openstack-horizon | 19:44 | |
| *** jasondotstar has joined #openstack-horizon | 19:44 | |
| *** jbell8 has quit IRC | 19:45 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - Use mock module to avoid using window https://review.openstack.org/199333 | 19:46 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - Fix ng-di errors on cloud-services https://review.openstack.org/198840 | 19:46 |
| *** rajatvig has joined #openstack-horizon | 19:46 | |
| *** radez_g0n3 is now known as radez | 19:47 | |
| *** MaxV has joined #openstack-horizon | 19:47 | |
| kfox1111_ | I've got a meeting to go to in about 7 min... :/ | 19:48 |
| rajatvig | Could someone please review the patch at https://review.openstack.org/#/c/158881/ ? | 19:50 |
| *** alexvictorchan has joined #openstack-horizon | 19:53 | |
| *** annashen has joined #openstack-horizon | 19:53 | |
| matt-borland | rajatvig: I'll take another look at it, thx | 19:53 |
| tqtran | kfox1111_: i'll put it on github when i have the example up and running | 19:53 |
| kfox1111_ | ok. thanks. | 19:53 |
| *** Berezin has quit IRC | 19:54 | |
| *** Berezin has joined #openstack-horizon | 19:54 | |
| kfox1111_ | mine's looking almost exactly like david-lyles. the two different panels provided by the one plugin. I'd like to share some angular js between the templates in the two panels. | 19:54 |
| kfox1111_ | bbiab. Thanks for the help. | 19:54 |
| *** ducttape_ has quit IRC | 19:55 | |
| *** julim has quit IRC | 19:55 | |
| *** ducttape_ has joined #openstack-horizon | 19:56 | |
| *** KunalGandhi has joined #openstack-horizon | 19:57 | |
| *** annashen has quit IRC | 19:57 | |
| *** tjones has quit IRC | 19:57 | |
| *** KunalGandhi has quit IRC | 19:58 | |
| *** Berezin has quit IRC | 19:58 | |
| *** tqtran is now known as tqtran-afk | 20:01 | |
| *** jmolo has quit IRC | 20:01 | |
| *** jmolo has joined #openstack-horizon | 20:01 | |
| *** jmolo has quit IRC | 20:02 | |
| *** jbell8 has joined #openstack-horizon | 20:02 | |
| *** neelashah has quit IRC | 20:03 | |
| *** jmolo has joined #openstack-horizon | 20:05 | |
| *** alexpilotti has joined #openstack-horizon | 20:06 | |
| *** kzaitsev_mb has joined #openstack-horizon | 20:06 | |
| openstackgerrit | Ishita Mandhan proposed openstack/horizon: DataTable column level policy https://review.openstack.org/164010 | 20:07 |
| *** KunalGandhi has joined #openstack-horizon | 20:09 | |
| *** tjones has joined #openstack-horizon | 20:10 | |
| *** alexpilotti has quit IRC | 20:12 | |
| *** sqchen has quit IRC | 20:12 | |
| *** KunalGandhi has quit IRC | 20:13 | |
| *** rdopiera has quit IRC | 20:19 | |
| *** e0ne has quit IRC | 20:19 | |
| *** annashen has joined #openstack-horizon | 20:20 | |
| *** e0ne has joined #openstack-horizon | 20:21 | |
| *** MaxV has quit IRC | 20:21 | |
| *** e0ne has quit IRC | 20:21 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 20:22 | |
| *** julim has joined #openstack-horizon | 20:22 | |
| *** lucas__ has quit IRC | 20:23 | |
| *** jingjing_ren has joined #openstack-horizon | 20:38 | |
| *** nlahouti has joined #openstack-horizon | 20:38 | |
| *** lexholden has joined #openstack-horizon | 20:39 | |
| *** lucas__ has joined #openstack-horizon | 20:39 | |
| *** alexpilotti has joined #openstack-horizon | 20:42 | |
| *** logan2 has quit IRC | 20:42 | |
| *** lucas__ has quit IRC | 20:44 | |
| *** mpavlase has quit IRC | 20:45 | |
| *** logan2 has joined #openstack-horizon | 20:45 | |
| *** tqtran-afk is now known as tqtran | 20:45 | |
| *** JeanBriceCombebi has quit IRC | 20:47 | |
| *** MaxV has joined #openstack-horizon | 20:48 | |
| *** jwy has quit IRC | 20:48 | |
| ducttape_ | david-lyle - you had mentioned desire for horizon to have cross region pages / views. I have a need for cross region data for a designate change. any more info / insight to share on this mind blowing use of cloud technology ? | 20:49 |
| david-lyle | ducttape_: I have said desires | 20:49 |
| ducttape_ | if that's all you care to share, I don't want to judge you | 20:50 |
| *** rajatvig has quit IRC | 20:50 | |
| david-lyle | oh and matt-borland I understand the root of your problem, working on a proper fix | 20:50 |
| * ducttape_ still judges him just the same | 20:50 | |
| david-lyle | you just don't want to | 20:50 |
| *** lucas__ has joined #openstack-horizon | 20:50 | |
| david-lyle | well... | 20:51 |
| ducttape_ | the root of my problem? I expect that to be complex | 20:51 |
| david-lyle | matt-borland's problem | 20:51 |
| david-lyle | I don't have a clue about your problem | 20:51 |
| ducttape_ | scientists don't either | 20:51 |
| *** lucas__ has quit IRC | 20:51 | |
| *** alexpilotti has quit IRC | 20:52 | |
| *** lucas__ has joined #openstack-horizon | 20:52 | |
| matt-borland | david-lyle: thanks! | 20:52 |
| david-lyle | ducttape_: I think really it's just about making calls to multiple endpoints, the question become do you want that data to live in the same table or different based on region | 20:52 |
| david-lyle | separate tables are easier for actions, I think | 20:52 |
| david-lyle | I was going to start with a simple view | 20:53 |
| ducttape_ | I think separate tables / by a lazy loaded tab... would be nice | 20:53 |
| david-lyle | ducttape_: by tabs? or same page? | 20:53 |
| ducttape_ | same page, using tabbedtableview | 20:54 |
| david-lyle | tabbed table view would work for now | 20:54 |
| ducttape_ | and you can tell the tab to be lazy loaded and it works pretty well | 20:54 |
| david-lyle | I won't say the A word, but in an ideal world that would make async on one page without tabs easier | 20:55 |
| david-lyle | but I have other bedtime stories to tell if you like that one | 20:55 |
| ducttape_ | it uses the same ajax approach as ng, except it's less code (troll) | 20:55 |
| tqtran | david-lyle: i have a question for you, i just git clone your repo and pip install, dropped enabled file in, then restarted test server, but its not able to find the module | 20:56 |
| *** rajatvig has joined #openstack-horizon | 20:56 | |
| david-lyle | my question is: is there value in being able to multiple tables at once, especially if you are looking for something specific | 20:56 |
| *** lucas__ has quit IRC | 20:56 | |
| tqtran | ImportError: No module named mon_panel | 20:56 |
| tqtran | did i miss a step? | 20:56 |
| ducttape_ | I would think a lazy loaded single tab table view would be pretty much a single change to make everything async | 20:56 |
| david-lyle | tqtran: did you sdist? | 20:57 |
| tqtran | nope lol | 20:57 |
| ducttape_ | also need to make sure its in your pypath.... like pip install in your venv etc | 20:57 |
| david-lyle | git clone; python setup.py sdist; then install the tar.gz in dist | 20:57 |
| *** MaxV has quit IRC | 20:57 | |
| david-lyle | well that's the pip install | 20:57 |
| tqtran | damn still fails after i manually run setup.py sdist | 20:58 |
| david-lyle | but yeah if you are expecting it in your .venv you'll need tools/with_venv.sh pip install | 20:58 |
| tqtran | ah got it | 20:58 |
| ducttape_ | but the pip install will either use the venv or the system path. one works with apache, one with run_tests.sh | 20:58 |
| david-lyle | I should update the readme | 21:00 |
| david-lyle | should | 21:00 |
| david-lyle | may not | 21:00 |
| ducttape_ | david-lyle: https://review.openstack.org/#/c/111854/ that review has cross region stuff. it gets ugly if you start down that path | 21:00 |
| tqtran | haha yeah you should update the readme | 21:00 |
| tqtran | i got it to work, thanks! | 21:00 |
| david-lyle | should | 21:00 |
| david-lyle | I also accept pull requests | 21:00 |
| david-lyle | see what I did there | 21:01 |
| david-lyle | ducttape_: messier yes | 21:01 |
| *** MaxV has joined #openstack-horizon | 21:02 | |
| david-lyle | I think the parts in api/ look right | 21:02 |
| tqtran | david-lyle: lol i just forked your repo | 21:04 |
| david-lyle | I have conflicting thoughts as to whether the region loop should happen in openstack_dashboard/api | 21:05 |
| david-lyle | rather than at the page level | 21:05 |
| david-lyle | tqtran: perfect, now just submit a pull request when you've updated the README | 21:06 |
| *** jtriley has quit IRC | 21:06 | |
| *** Berezin has joined #openstack-horizon | 21:06 | |
| *** aix has joined #openstack-horizon | 21:06 | |
| *** vijendar has quit IRC | 21:07 | |
| tqtran | um you might not want it, i removed/add a bunch of other stuff | 21:07 |
| ducttape_ | david-lyle - you are going to need to have the region stuff bleed all the way through to the client eventually. there is no clean way to encapsulate all that | 21:08 |
| david-lyle | tqtran: ok | 21:08 |
| *** sqchen has joined #openstack-horizon | 21:08 | |
| david-lyle | ducttape_: I agree, but just would rather be more DRY about it if possible | 21:08 |
| david-lyle | than custom region loops per page | 21:09 |
| ducttape_ | you could have another version of get_data that calls it X times, once / region | 21:09 |
| ducttape_ | and sets the region outside of the existing call | 21:09 |
| *** KunalGandhi has joined #openstack-horizon | 21:10 | |
| ducttape_ | just add another mixin to our current conglomerate of mixins | 21:10 |
| *** jasondotstar has quit IRC | 21:11 | |
| *** KunalGandhi has quit IRC | 21:14 | |
| david-lyle | that's a way to go | 21:14 |
| david-lyle | honestly I was going to experiment | 21:15 |
| ducttape_ | in Colorado that is perfectly legal and encouraged at some places | 21:15 |
| david-lyle | lol | 21:15 |
| *** yamamoto has joined #openstack-horizon | 21:16 | |
| *** MaxV has quit IRC | 21:16 | |
| *** matt-borland has quit IRC | 21:16 | |
| *** KunalGandhi has joined #openstack-horizon | 21:17 | |
| *** jacalcat has quit IRC | 21:18 | |
| *** jbell8 has quit IRC | 21:18 | |
| *** neelashah has joined #openstack-horizon | 21:19 | |
| *** dansiwie_ has joined #openstack-horizon | 21:21 | |
| *** dansiwiec has quit IRC | 21:21 | |
| *** rajatvig has quit IRC | 21:21 | |
| *** rajatvig has joined #openstack-horizon | 21:22 | |
| *** neelashah has quit IRC | 21:22 | |
| *** yamamoto has quit IRC | 21:25 | |
| *** neelashah has joined #openstack-horizon | 21:25 | |
| *** neelashah1 has joined #openstack-horizon | 21:26 | |
| *** juggler_ is now known as juggler | 21:28 | |
| *** neelashah has quit IRC | 21:30 | |
| *** vishwanathj has joined #openstack-horizon | 21:31 | |
| *** Drago has joined #openstack-horizon | 21:31 | |
| *** Drago has quit IRC | 21:33 | |
| *** Drago has joined #openstack-horizon | 21:33 | |
| tqtran | david-lyle: question, how are static files included at the panel level? | 21:35 |
| tqtran | i managed to get it to package the static files, but when i try to include it in ADD_JS_FILES, it fails to see it | 21:35 |
| tqtran | so for whatever reason, the static collector isnt seeing it, do i need to manually run collect static? | 21:36 |
| *** vishwanathj has quit IRC | 21:36 | |
| *** neelashah1 has quit IRC | 21:39 | |
| *** lucas__ has joined #openstack-horizon | 21:39 | |
| tqtran | ok nvm, looks like i might need to rebuild venv, will try that | 21:41 |
| openstackgerrit | Dan Siwiec proposed openstack/horizon: WIP : Add angular defaults panel for admin https://review.openstack.org/205296 | 21:42 |
| *** doug-fish has left #openstack-horizon | 21:42 | |
| *** ybathia has quit IRC | 21:43 | |
| *** lucas__ has quit IRC | 21:43 | |
| *** jingjing_ren has quit IRC | 21:44 | |
| *** rajatvig has quit IRC | 21:46 | |
| *** guya has quit IRC | 21:47 | |
| *** ybathia has joined #openstack-horizon | 21:48 | |
| *** jingjing_ren has joined #openstack-horizon | 21:49 | |
| *** vishwanathj has joined #openstack-horizon | 21:52 | |
| *** annashen_ has joined #openstack-horizon | 21:53 | |
| *** jingjing_ren has quit IRC | 21:54 | |
| *** rajatvig has joined #openstack-horizon | 21:57 | |
| *** annashen_ has quit IRC | 21:58 | |
| *** vishwanathj has quit IRC | 22:00 | |
| *** bpokorny_ has joined #openstack-horizon | 22:01 | |
| *** bpokorny has quit IRC | 22:04 | |
| *** bpokorny_ has quit IRC | 22:04 | |
| *** bpokorny has joined #openstack-horizon | 22:04 | |
| *** vishwanathj has joined #openstack-horizon | 22:04 | |
| *** jwy has joined #openstack-horizon | 22:05 | |
| *** ericpeterson has joined #openstack-horizon | 22:06 | |
| *** vishwanathj has quit IRC | 22:09 | |
| *** pauloewerton has quit IRC | 22:09 | |
| *** ducttape_ has quit IRC | 22:09 | |
| *** jpomeroy has quit IRC | 22:11 | |
| *** dboik has quit IRC | 22:19 | |
| *** kzaitsev_mb has quit IRC | 22:19 | |
| *** yamamoto has joined #openstack-horizon | 22:26 | |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 22:27 | |
| *** mwhagedorn has quit IRC | 22:28 | |
| *** Berezin has quit IRC | 22:29 | |
| *** Berezin has joined #openstack-horizon | 22:29 | |
| *** bpokorny has quit IRC | 22:29 | |
| *** bpokorny has joined #openstack-horizon | 22:29 | |
| *** yamamoto has quit IRC | 22:30 | |
| *** rajatvig has quit IRC | 22:31 | |
| *** sayan has quit IRC | 22:32 | |
| *** SimonChung1 has joined #openstack-horizon | 22:32 | |
| *** SimonChung has quit IRC | 22:32 | |
| *** Piet has joined #openstack-horizon | 22:34 | |
| *** jingjing_ren has joined #openstack-horizon | 22:38 | |
| *** jingjing_ren has quit IRC | 22:41 | |
| kfox1111_ | tqtran: Get it figured out? | 22:42 |
| tqtran | yep, im cleaning up some stuff | 22:42 |
| tqtran | almost done | 22:42 |
| *** rajatvig has joined #openstack-horizon | 22:45 | |
| kfox1111_ | cool. :) | 22:49 |
| *** garthb has joined #openstack-horizon | 22:50 | |
| *** garthb_ has joined #openstack-horizon | 22:50 | |
| *** garthb_ has quit IRC | 22:50 | |
| *** bpokorny has quit IRC | 22:52 | |
| *** bpokorny has joined #openstack-horizon | 22:53 | |
| *** rajatvig has quit IRC | 22:55 | |
| *** lucas__ has joined #openstack-horizon | 23:02 | |
| tqtran | kfox1111_: testing it now | 23:03 |
| tqtran | its complaining about a missing module, so let me figure that part out and i should be ready to share | 23:03 |
| *** rajatvig has joined #openstack-horizon | 23:04 | |
| kfox1111_ | k. thanks. :) | 23:04 |
| *** rajatvig has quit IRC | 23:04 | |
| *** lucas__ has quit IRC | 23:06 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Dashboard ReOrg - Relocate Launch Instance module https://review.openstack.org/197234 | 23:07 |
| *** jpomeroy has joined #openstack-horizon | 23:09 | |
| *** ericpeterson has quit IRC | 23:09 | |
| *** ducttape_ has joined #openstack-horizon | 23:10 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Dashboard ReOrg - hz.dashboard --> horizon.dashboard https://review.openstack.org/206760 | 23:14 |
| *** ducttape_ has quit IRC | 23:15 | |
| *** jmolo has quit IRC | 23:15 | |
| *** romainh has left #openstack-horizon | 23:15 | |
| *** kzaitsev_mb has joined #openstack-horizon | 23:17 | |
| *** kzaitsev_mb has quit IRC | 23:21 | |
| *** rajatvig has joined #openstack-horizon | 23:22 | |
| tqtran | kfox1111_: https://github.com/tqtran7/mon-ext | 23:23 |
| tqtran | it should look something like that | 23:23 |
| tqtran | i have some js error that i still need to figure out, but its a good start | 23:24 |
| tqtran | im not too sure if auto discovery will work at the panel level, sqchen? | 23:24 |
| *** Piet has quit IRC | 23:25 | |
| tqtran | i know it works at the dashboard level, but not sure if we have it in place for panels as well | 23:25 |
| tqtran | if not, that might be a good follow on patch, sqchen | 23:25 |
| *** jmolo has joined #openstack-horizon | 23:26 | |
| *** Piet has joined #openstack-horizon | 23:26 | |
| *** tosky has quit IRC | 23:27 | |
| tyr | tqtran: auto-discovery doesn't care about dashboards vs panels. | 23:28 |
| tyr | it picks up anything in a python modules "static/" directory | 23:28 |
| tqtran | but you have to turn the flag on, and currently, isnt it turn on at the dashboard level? | 23:29 |
| tyr | the code is run from settings.py : update_dashboards() | 23:29 |
| tqtran | https://github.com/openstack/horizon/blob/master/openstack_dashboard/enabled/_25_identity.py#L26 | 23:29 |
| tqtran | the question is, if i have add that flag to https://github.com/tqtran7/mon-ext/blob/master/enabled/_91_admin_my_panel.py | 23:30 |
| tyr | right. Not certain what happens if you attempt to add a panel to a dashboard that doesn't have that flag set | 23:30 |
| tqtran | would it do anything? | 23:30 |
| tqtran | exactly.... | 23:31 |
| tyr | I'd think your panel settings would get merged into the overall enabled file for that dashboard...? | 23:31 |
| tqtran | if you have full control over the dashboard, then its not a problem | 23:32 |
| tqtran | but if you only want to add a panel, you may not want to touch the dashboard's enabled file | 23:32 |
| tqtran | we should support auto collecting at the panel level as well | 23:32 |
| tyr | update_dashboards() looks to me like it is parsing the options of each module independently. So one panel might enable that flag, even though the dashboard it is adding itself to does not have the flag | 23:32 |
| tqtran | i have to take a closer look at the code | 23:33 |
| *** rhagarty_ has quit IRC | 23:33 | |
| *** rhagarty has quit IRC | 23:33 | |
| tqtran | was hoping you or sqchen know the answer :P | 23:33 |
| tyr | settings.py:111 I haven't actually done the experiment you are about to try :) | 23:33 |
| tyr | its cool that you are testing this using David's panel | 23:34 |
| tqtran | yeah, someone's gotta do it :P | 23:34 |
| tyr | on this topic...do you or david-lyle recall the setting that lets us pick up enabled files out of tree? | 23:35 |
| david-lyle | openstack_dashboard/utils/settings.py update_dashboards() | 23:36 |
| david-lyle | is that what you're asking about? | 23:36 |
| tyr | I'm looking at the now lonely dashboard.module.js. It seems to me that we should be concating plugins onto horizon.dashboard (since that is the parent of things like horizon.dashboard.project etc), instead of concating them onto horizon.app | 23:36 |
| tyr | david-lyle: I meant, there is something I can add to a local_settings.py that will allow update_dashboards to parse modules that live out of tree? | 23:38 |
| *** rhagarty has joined #openstack-horizon | 23:38 | |
| *** rhagarty_ has joined #openstack-horizon | 23:39 | |
| david-lyle | tyr: it will process out of tree, but you have to add an enabled file | 23:39 |
| david-lyle | part of the enabled file is specifying the python module | 23:39 |
| tqtran | tyr: thats a good question to raise, not even sure we need the hz.dashboard at all, since with the plugin system, we need them to live independently: https://review.openstack.org/#/c/190865/10/openstack_dashboard/enabled/_25_identity.py L24 | 23:39 |
| tyr | into /horizon/openstack_dashboard/enabled/. I thought last week you said there was another way to locate enabled files that might also be out of tree? | 23:39 |
| david-lyle | tyr: right now enabled or local/enabled | 23:40 |
| tyr | local/enabled...that was it. Thanks! | 23:40 |
| david-lyle | patch to change to config files is https://review.openstack.org/#/c/100521/ | 23:40 |
| david-lyle | but I haven't dug into that yet | 23:41 |
| *** jasondotstar has joined #openstack-horizon | 23:41 | |
| tqtran | is it the symlink we're talking about here? | 23:41 |
| david-lyle | tyr, really you can put the enabled directory anywhere in the file system, with several caveats | 23:41 |
| david-lyle | the dir has to be in the python path | 23:41 |
| david-lyle | _AND_ it has to be a python module | 23:42 |
| david-lyle | but you could create a python module called enabled that lived at /etc/horizon/enabled | 23:42 |
| david-lyle | but it's uglier than it's worth | 23:42 |
| david-lyle | ideally we move from python files | 23:42 |
| david-lyle | and just point to a dif | 23:42 |
| david-lyle | *dir | 23:43 |
| tyr | Yeah, I like that direction. | 23:43 |
| david-lyle | the oslo.config patch I linked is a step in that direction | 23:43 |
| david-lyle | not sure it simplifies things though | 23:43 |
| david-lyle | for the end user | 23:43 |
| david-lyle | s/user/deployer | 23:43 |
| david-lyle | but that may not need much editing | 23:44 |
| tyr | if all you want to do is link in new javascript panels...it is odd to have to package that as Python | 23:44 |
| david-lyle | works better for puppet and other tools too | 23:44 |
| tyr | that won't start to really bother us until we get more base content converted | 23:44 |
| david-lyle | I agree, but any plugin that isn't adding an API layer as well, isn't much of a plugin | 23:45 |
| *** SimonChung1 has quit IRC | 23:45 | |
| david-lyle | and the pure js reimplementations can live in tree | 23:45 |
| tyr | That's true...but using magic-search as an example, the API layer might live client-side, right? | 23:45 |
| *** jwy has left #openstack-horizon | 23:46 | |
| david-lyle | are all the rest APIs available for it? | 23:46 |
| david-lyle | in Horizon | 23:46 |
| tyr | I didn't follow that last | 23:46 |
| *** albertom has quit IRC | 23:46 | |
| david-lyle | so magic search is going to call back to the horizon server | 23:46 |
| david-lyle | if all the API calls are implemented in Horizon already, it could be purely js | 23:47 |
| tyr | 1 idea discussed was to hit the searchlight service directly from the client, and use horizon server only as degraded backup | 23:47 |
| david-lyle | but if you're adding new search filters into the python APIs or are expecting to call REST APIs they may not be there yet | 23:47 |
| david-lyle | sure, but I imagine the degraded path is supported in the plugin | 23:48 |
| *** albertom has joined #openstack-horizon | 23:48 | |
| david-lyle | would be odd not to be | 23:48 |
| * david-lyle has to run for a bit | 23:48 | |
| david-lyle | back online later | 23:49 |
| tyr | to be honest I don't have much opinion in this space. I was more imagining someone saying "ooo, we'd like to add an Angular dashboard" | 23:49 |
| tyr | tqtran: I think horizon.dashboard might still be useful as a collection point for the plugins. I'll experiment with a patch as part of the reorg series. | 23:50 |
| * tyr has to grab dinner | 23:50 | |
| openstackgerrit | Brad Pokorny proposed openstack/horizon: Configurable token hashing https://review.openstack.org/206765 | 23:50 |
| sqchen | horizon.dashboard won’t be very useful, unless, we use it as a bootstraping thing. | 23:51 |
| sqchen | Sorry, join the discussion late. | 23:51 |
| tqtran | tyr: the way we're currently loading the plugins, we're bypassing the hz.board completely | 23:54 |
| *** annashen_ has joined #openstack-horizon | 23:54 | |
| tqtran | but yeah, it could maybe be useful for bootstrapping, but thats hypothetical at this point | 23:54 |
| sqchen | agreed. | 23:55 |
| tqtran | kfox1111_: the plugin is complete, all bugs fixed, have fun! | 23:55 |
| *** annashen has quit IRC | 23:55 | |
| sqchen | I think we could remove it once we have launch-instance re-located. | 23:55 |
| tqtran | kfox1111_: here it is again in case you missed it, https://github.com/tqtran7/mon-ext | 23:56 |
| *** jmolo has quit IRC | 23:57 | |
| *** jmolo has joined #openstack-horizon | 23:57 | |
| *** Berezin has quit IRC | 23:58 | |
| *** annashen_ has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!