| *** rajatvig has quit IRC | 00:00 | |
| kzaitsev_mb | lhcheng: looks like a low hangin fruit to me =) | 00:01 |
|---|---|---|
| lhcheng | kzaitsev_mb: yeah, the problem is already resolved in L. but some work is still needed to fix it for Kilo. | 00:02 |
| *** ducttape_ has joined #openstack-horizon | 00:05 | |
| kzaitsev_mb | lhcheng: Are you sure? A quick grep only shows openstack.common modules, which we should not edit in horizon codebase anyway | 00:06 |
| *** jtriley has quit IRC | 00:06 | |
| *** ducttape_ has quit IRC | 00:08 | |
| *** nzeplowi has quit IRC | 00:08 | |
| *** garthb has quit IRC | 00:11 | |
| lhcheng | kzaitsev_mb: yeah, it is fixed in L. you can check with sjmc7 with that. | 00:12 |
| *** jtriley has joined #openstack-horizon | 00:12 | |
| lhcheng | kzaitsev_mb: yes, we should not be making changing in openstack.common directly. We could only do a sync. | 00:12 |
| kzaitsev_mb | lhcheng: I mean I checked in stable/kilo and it seems that the bug is not there too. | 00:13 |
| lhcheng | kzaitsev_mb: sjmc7 reported hitting the issue this morning | 00:14 |
| *** nzeplowi has joined #openstack-horizon | 00:14 | |
| lhcheng | I haven't got the chance to test it yet. | 00:14 |
| TravT | yes | 00:15 |
| TravT | that was intended for gerrit | 00:15 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Adding Angular Project Images Table https://review.openstack.org/200385 | 00:15 |
| kzaitsev_mb | ok, will ping him then =) Also, I updated https://wiki.openstack.org/wiki/Meetings/Horizon and will most surely attend =) | 00:16 |
| lhcheng | kzaitsev_mb: note that the meeting time switches :) | 00:17 |
| TravT | tqtran: david-lyle: there you go^. shared code so that projects dashboard just imports from core. tomorrow will look at taking that further with some shared directives | 00:18 |
| *** sqchen has quit IRC | 00:18 | |
| kzaitsev_mb | lhcheng: every week, yep. This week's the lively one. | 00:19 |
| *** yamamoto has quit IRC | 00:19 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Adding Angular Project Images Table https://review.openstack.org/200385 | 00:20 |
| *** ducttape_ has joined #openstack-horizon | 00:21 | |
| *** neelashah has quit IRC | 00:21 | |
| *** vijendar1 has joined #openstack-horizon | 00:22 | |
| *** nzeplowi has quit IRC | 00:22 | |
| *** vijendar has quit IRC | 00:23 | |
| *** alexpilotti has quit IRC | 00:26 | |
| openstackgerrit | JasonPan proposed openstack/horizon: Fix CSS GET None when mouse over the table cell https://review.openstack.org/199923 | 00:27 |
| *** yingjun has joined #openstack-horizon | 00:32 | |
| *** kzaitsev_mb has quit IRC | 00:32 | |
| *** cody-somerville has joined #openstack-horizon | 00:34 | |
| *** cody-somerville has quit IRC | 00:34 | |
| *** cody-somerville has joined #openstack-horizon | 00:34 | |
| *** ybathia has quit IRC | 00:35 | |
| *** SimonChung has quit IRC | 00:39 | |
| openstackgerrit | Lin Hua Cheng proposed openstack/django_openstack_auth: Fix Login form's fields sorting for Django 1.7 https://review.openstack.org/201379 | 00:39 |
| *** ducttape_ has quit IRC | 00:42 | |
| *** TravT has quit IRC | 00:52 | |
| *** kyleolivo has quit IRC | 00:54 | |
| openstackgerrit | Merged openstack/horizon: Identity dashboard's style should be customizable https://review.openstack.org/200718 | 00:55 |
| openstackgerrit | Merged openstack/horizon: Dashboard ReOrg - Move workflow into app/core https://review.openstack.org/197347 | 00:55 |
| openstackgerrit | Merged openstack/horizon: Adding Angular Project Images Panel https://review.openstack.org/200324 | 00:55 |
| *** deuce has joined #openstack-horizon | 01:01 | |
| *** deuce has left #openstack-horizon | 01:01 | |
| *** kyleolivo has joined #openstack-horizon | 01:01 | |
| *** gyee has quit IRC | 01:02 | |
| *** ducttape_ has joined #openstack-horizon | 01:03 | |
| *** yingjun has quit IRC | 01:04 | |
| *** bradjones_ has joined #openstack-horizon | 01:06 | |
| *** bradjones_ has quit IRC | 01:06 | |
| *** bradjones_ has joined #openstack-horizon | 01:06 | |
| *** bradjones has quit IRC | 01:06 | |
| *** bradjones_ is now known as bradjones | 01:07 | |
| *** jpomero_ has joined #openstack-horizon | 01:08 | |
| *** kyleolivo has quit IRC | 01:08 | |
| *** yamamoto has joined #openstack-horizon | 01:10 | |
| *** andrewbogott is now known as andrewbogott_afk | 01:10 | |
| *** jpomero has quit IRC | 01:11 | |
| *** geoffarnold has joined #openstack-horizon | 01:14 | |
| *** chlong-afk has joined #openstack-horizon | 01:15 | |
| *** geoffarnold has quit IRC | 01:16 | |
| *** geoffarnold has joined #openstack-horizon | 01:17 | |
| openstackgerrit | Merged openstack/horizon: JSCS Cleanup-style guide cleanup for filters.js https://review.openstack.org/199789 | 01:17 |
| openstackgerrit | Merged openstack/horizon: JSCS Cleanup-style guide cleanup for filters.js https://review.openstack.org/199789 | 01:17 |
| *** sqchen has joined #openstack-horizon | 01:22 | |
| *** annashen has joined #openstack-horizon | 01:25 | |
| *** ducttape_ has quit IRC | 01:25 | |
| *** ducttape_ has joined #openstack-horizon | 01:25 | |
| *** vincent_hou has joined #openstack-horizon | 01:26 | |
| *** ducttape_ has quit IRC | 01:27 | |
| *** jwy1 has quit IRC | 01:29 | |
| *** annashen has quit IRC | 01:30 | |
| *** ongk has quit IRC | 01:35 | |
| *** tqtran has quit IRC | 01:36 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 01:38 |
| *** TravT has joined #openstack-horizon | 01:39 | |
| *** kyleolivo has joined #openstack-horizon | 01:41 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 01:42 |
| openstackgerrit | Merged openstack/horizon: Addresses use of digest in launch-instance specs by using apply instead https://review.openstack.org/200763 | 01:42 |
| *** drupalmonkey has quit IRC | 01:44 | |
| *** TravT has quit IRC | 01:44 | |
| *** drupalmonkey has joined #openstack-horizon | 01:44 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 01:45 |
| *** pamo has quit IRC | 01:47 | |
| Piet | Edit Project is ready for UX review https://openstack.invisionapp.com/d/main/#/projects/4105611 | 01:47 |
| *** ducttape_ has joined #openstack-horizon | 01:48 | |
| *** drupalmonkey has quit IRC | 01:49 | |
| *** drupalmonkey has joined #openstack-horizon | 01:50 | |
| *** SimonChung has joined #openstack-horizon | 01:52 | |
| *** dboik has joined #openstack-horizon | 01:53 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Dashboard ReOrg - Move cloud-services into app/core https://review.openstack.org/197334 | 01:53 |
| *** masco__ has joined #openstack-horizon | 01:54 | |
| *** dboik_ has joined #openstack-horizon | 01:54 | |
| *** SimonChung has quit IRC | 01:56 | |
| *** geoffarnold has quit IRC | 01:57 | |
| *** dboik has quit IRC | 01:58 | |
| *** kzaitsev_mb has joined #openstack-horizon | 01:58 | |
| *** SimonChung has joined #openstack-horizon | 02:00 | |
| *** lhcheng has quit IRC | 02:01 | |
| openstackgerrit | Merged openstack/horizon: JSCS Cleanup - Include angular plugin for auth js https://review.openstack.org/201027 | 02:02 |
| openstackgerrit | Merged openstack/horizon: JSCS Cleanup - rename vm as ctrl for login controller https://review.openstack.org/201032 | 02:02 |
| *** geoffarnold has joined #openstack-horizon | 02:03 | |
| *** kzaitsev_mb has quit IRC | 02:04 | |
| *** masco__ has quit IRC | 02:04 | |
| *** lyanchih has joined #openstack-horizon | 02:04 | |
| *** btully has quit IRC | 02:08 | |
| *** neelashah has joined #openstack-horizon | 02:13 | |
| *** albertom has quit IRC | 02:14 | |
| *** albertom has joined #openstack-horizon | 02:21 | |
| *** sqchen has quit IRC | 02:23 | |
| *** sqchen has joined #openstack-horizon | 02:24 | |
| *** annashen has joined #openstack-horizon | 02:26 | |
| *** zhenguo has joined #openstack-horizon | 02:27 | |
| *** annashen has quit IRC | 02:31 | |
| *** stevemar has joined #openstack-horizon | 02:33 | |
| *** geoffarnold has quit IRC | 02:36 | |
| *** albertom has quit IRC | 02:38 | |
| *** btully has joined #openstack-horizon | 02:38 | |
| *** masco__ has joined #openstack-horizon | 02:42 | |
| *** nlahouti has quit IRC | 02:43 | |
| *** btully has quit IRC | 02:43 | |
| *** dboik_ has quit IRC | 02:44 | |
| *** dboik has joined #openstack-horizon | 02:44 | |
| *** albertom has joined #openstack-horizon | 02:45 | |
| *** lhcheng has joined #openstack-horizon | 02:47 | |
| *** kzaitsev_mb has joined #openstack-horizon | 03:00 | |
| *** kzaitsev_mb has quit IRC | 03:04 | |
| *** TravT has joined #openstack-horizon | 03:05 | |
| *** ducttape_ has quit IRC | 03:08 | |
| *** neelashah has quit IRC | 03:18 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Adding Angular Project Images Table https://review.openstack.org/200385 | 03:18 |
| *** jbell8 has joined #openstack-horizon | 03:21 | |
| *** jbell8 has quit IRC | 03:22 | |
| *** yingjun has joined #openstack-horizon | 03:23 | |
| *** lyanchih has quit IRC | 03:28 | |
| *** lyanchih has joined #openstack-horizon | 03:34 | |
| *** Longgeek has joined #openstack-horizon | 03:35 | |
| *** albertom has quit IRC | 03:38 | |
| *** ducttape_ has joined #openstack-horizon | 03:42 | |
| *** albertom has joined #openstack-horizon | 03:45 | |
| *** jtriley has quit IRC | 03:45 | |
| *** stevemar has quit IRC | 03:51 | |
| *** stevemar has joined #openstack-horizon | 03:52 | |
| *** yingjun has quit IRC | 03:53 | |
| *** annashen has joined #openstack-horizon | 03:56 | |
| *** esp_ has joined #openstack-horizon | 03:56 | |
| *** ducttape_ has quit IRC | 03:56 | |
| *** annashen has quit IRC | 04:01 | |
| *** kzaitsev_mb has joined #openstack-horizon | 04:01 | |
| *** kzaitsev_mb has quit IRC | 04:06 | |
| *** oro has joined #openstack-horizon | 04:24 | |
| *** tjones1 has joined #openstack-horizon | 04:25 | |
| *** tjones1 has left #openstack-horizon | 04:27 | |
| *** jtriley has joined #openstack-horizon | 04:42 | |
| *** sayan has joined #openstack-horizon | 04:46 | |
| *** jtriley has quit IRC | 04:48 | |
| *** annashen has joined #openstack-horizon | 04:57 | |
| *** yingjun has joined #openstack-horizon | 04:59 | |
| *** vincent_hou has quit IRC | 05:01 | |
| *** kzaitsev_mb has joined #openstack-horizon | 05:02 | |
| *** annashen has quit IRC | 05:02 | |
| *** stevemar has quit IRC | 05:06 | |
| *** stevemar has joined #openstack-horizon | 05:06 | |
| *** kzaitsev_mb has quit IRC | 05:06 | |
| *** stevemar has quit IRC | 05:09 | |
| *** btully has joined #openstack-horizon | 05:10 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: [WIP] Unit tests for auto file discovery https://review.openstack.org/201418 | 05:17 |
| *** yingjun has quit IRC | 05:32 | |
| *** nlahouti has joined #openstack-horizon | 05:36 | |
| *** sqchen has quit IRC | 05:39 | |
| *** nlahouti has quit IRC | 05:41 | |
| *** yingjun has joined #openstack-horizon | 05:41 | |
| *** nlahouti has joined #openstack-horizon | 05:41 | |
| *** kyleolivo has quit IRC | 05:48 | |
| *** sqchen has joined #openstack-horizon | 05:48 | |
| *** kyleolivo has joined #openstack-horizon | 05:50 | |
| *** nlahouti has quit IRC | 05:51 | |
| *** esp_ has quit IRC | 05:52 | |
| *** lyanchih has quit IRC | 05:56 | |
| *** annashen has joined #openstack-horizon | 05:58 | |
| *** annashen has quit IRC | 06:03 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/200793 | 06:05 |
| *** lyanchih has joined #openstack-horizon | 06:09 | |
| *** chlong-afk has quit IRC | 06:09 | |
| *** kyleolivo has quit IRC | 06:12 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: [WIP] Unit tests for auto file discovery https://review.openstack.org/201418 | 06:20 |
| *** cody-somerville has quit IRC | 06:20 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - Fix ng-di errors on cloud-services https://review.openstack.org/198840 | 06:22 |
| *** drupalmonkey has quit IRC | 06:23 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - Fix eslint metadata-tree widgets. https://review.openstack.org/200752 | 06:23 |
| *** oro has quit IRC | 06:25 | |
| *** oro has joined #openstack-horizon | 06:27 | |
| *** yingjun has quit IRC | 06:29 | |
| *** kiran-r has joined #openstack-horizon | 06:36 | |
| *** belmoreira has joined #openstack-horizon | 06:36 | |
| *** ankit_ag has joined #openstack-horizon | 06:37 | |
| *** psanchez_ has joined #openstack-horizon | 06:44 | |
| *** yamamoto has quit IRC | 06:49 | |
| *** yingjun has joined #openstack-horizon | 06:55 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 06:58 |
| *** kiran-r has quit IRC | 06:58 | |
| *** annashen has joined #openstack-horizon | 06:59 | |
| *** markus_z has joined #openstack-horizon | 07:00 | |
| *** kiran-r has joined #openstack-horizon | 07:01 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Unit tests for auto file discovery https://review.openstack.org/201418 | 07:01 |
| *** yamamoto has joined #openstack-horizon | 07:02 | |
| *** kzaitsev_mb has joined #openstack-horizon | 07:03 | |
| *** annashen has quit IRC | 07:03 | |
| *** sqchen has left #openstack-horizon | 07:05 | |
| *** rdopiera has joined #openstack-horizon | 07:08 | |
| *** _stowa has joined #openstack-horizon | 07:08 | |
| *** kzaitsev_mb has quit IRC | 07:08 | |
| *** kiran-r has quit IRC | 07:08 | |
| *** amotoki_ has joined #openstack-horizon | 07:11 | |
| *** kyleolivo has joined #openstack-horizon | 07:12 | |
| openstackgerrit | Kuo-tung Kao proposed openstack/horizon: Don't get descript if attribute doesn't exist. https://review.openstack.org/201437 | 07:13 |
| *** _stowa has quit IRC | 07:17 | |
| *** _stowa has joined #openstack-horizon | 07:21 | |
| *** mrunge has joined #openstack-horizon | 07:21 | |
| openstackgerrit | Kuo-tung Kao proposed openstack/horizon: Don't get descript if attribute doesn't exist. https://review.openstack.org/201437 | 07:22 |
| openstackgerrit | ziyu032 proposed openstack/horizon: make cancel button a unified style https://review.openstack.org/150686 | 07:24 |
| openstackgerrit | Radomir Dopieralski proposed openstack/horizon: Add an OPENSTACK_SIMPLE_TENANT_USAGE_ENABLED settings option https://review.openstack.org/201221 | 07:28 |
| *** jcoufal has joined #openstack-horizon | 07:30 | |
| *** sayan has quit IRC | 07:31 | |
| *** masco__ has quit IRC | 07:36 | |
| *** chlong-afk has joined #openstack-horizon | 07:37 | |
| *** kyleolivo has quit IRC | 07:41 | |
| *** mpavlase has joined #openstack-horizon | 07:50 | |
| *** katyafervent is now known as katyafervent_awa | 07:53 | |
| *** katyafervent_awa is now known as katyafervent | 07:53 | |
| *** Longgeek has quit IRC | 07:53 | |
| *** annashen has joined #openstack-horizon | 08:00 | |
| *** Longgeek has joined #openstack-horizon | 08:00 | |
| *** annashen has quit IRC | 08:04 | |
| *** lhcheng has quit IRC | 08:08 | |
| *** yingjun has quit IRC | 08:13 | |
| *** zz_ttrifonov is now known as ttrifonov | 08:14 | |
| *** btully has quit IRC | 08:18 | |
| *** yingjun has joined #openstack-horizon | 08:21 | |
| *** katyafervent is now known as katyafervent_awa | 08:22 | |
| *** amotoki_ has quit IRC | 08:22 | |
| *** katyafervent_awa is now known as katyafervent | 08:23 | |
| *** katyafervent is now known as katyafervent_awa | 08:24 | |
| *** kiran-r has joined #openstack-horizon | 08:29 | |
| *** kiran-r has quit IRC | 08:29 | |
| *** kiran-r has joined #openstack-horizon | 08:31 | |
| *** sayan has joined #openstack-horizon | 08:34 | |
| *** _kiran_ has joined #openstack-horizon | 08:35 | |
| *** kiran-r has quit IRC | 08:35 | |
| *** _kiran_ has quit IRC | 08:40 | |
| *** ttrifonov is now known as zz_ttrifonov | 08:41 | |
| openstackgerrit | Kuo-tung Kao proposed openstack/horizon: reset cache and attribute changed by preempt case https://review.openstack.org/201462 | 08:47 |
| *** kyleolivo has joined #openstack-horizon | 08:50 | |
| *** aix has joined #openstack-horizon | 08:51 | |
| openstackgerrit | Matthias Runge proposed openstack/horizon: remove django<1.7 from tests https://review.openstack.org/201066 | 08:53 |
| *** kyleolivo has quit IRC | 08:55 | |
| *** aix has quit IRC | 08:58 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Add Curvature topology https://review.openstack.org/141078 | 08:59 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Refactor network topology graph as an Angular directive https://review.openstack.org/199063 | 08:59 |
| *** kzaitsev_mb has joined #openstack-horizon | 09:00 | |
| *** annashen has joined #openstack-horizon | 09:00 | |
| *** e0ne has joined #openstack-horizon | 09:02 | |
| openstackgerrit | Matthias Runge proposed openstack/horizon: remove django<1.7 from tests https://review.openstack.org/201066 | 09:03 |
| *** aix has joined #openstack-horizon | 09:03 | |
| *** annashen has quit IRC | 09:05 | |
| *** tosky has joined #openstack-horizon | 09:05 | |
| *** jcoufal_ has joined #openstack-horizon | 09:09 | |
| *** mswitch has joined #openstack-horizon | 09:09 | |
| mswitch | Hi All, I was wondering if there was anything in the works to be able to create a VM with an SR-IOV NIC from Horizon? It is exposed in the CLI/API, but there is no option in Horizon it seems. | 09:10 |
| *** e0ne is now known as e0ne_ | 09:12 | |
| *** jcoufal has quit IRC | 09:12 | |
| *** yingjun has quit IRC | 09:13 | |
| *** kzaitsev_mb has quit IRC | 09:14 | |
| *** yingjun has joined #openstack-horizon | 09:14 | |
| *** e0ne_ is now known as e0ne | 09:16 | |
| *** alexpilotti has joined #openstack-horizon | 09:16 | |
| *** amotoki_ has joined #openstack-horizon | 09:16 | |
| *** btully has joined #openstack-horizon | 09:27 | |
| *** btully has quit IRC | 09:31 | |
| *** yingjun has quit IRC | 09:31 | |
| *** masco__ has joined #openstack-horizon | 09:31 | |
| *** sayan has quit IRC | 09:39 | |
| *** sayan has joined #openstack-horizon | 09:39 | |
| *** mrunge has quit IRC | 09:45 | |
| openstackgerrit | lyanchih proposed openstack/horizon: Couldn't provision instance from volume snapshot https://review.openstack.org/199457 | 09:50 |
| *** Longgeek has quit IRC | 09:51 | |
| *** masco__ has quit IRC | 09:51 | |
| *** jcoufal has joined #openstack-horizon | 09:53 | |
| *** vijendar1 has quit IRC | 09:55 | |
| *** vijendar has joined #openstack-horizon | 09:55 | |
| *** jcoufal_ has quit IRC | 09:57 | |
| *** mrunge has joined #openstack-horizon | 09:58 | |
| *** e0ne is now known as e0ne_ | 09:58 | |
| *** e0ne_ is now known as e0ne | 10:01 | |
| *** annashen has joined #openstack-horizon | 10:01 | |
| *** kiran-r has joined #openstack-horizon | 10:03 | |
| *** annashen has quit IRC | 10:06 | |
| *** sayan has quit IRC | 10:07 | |
| *** robcresswell has joined #openstack-horizon | 10:10 | |
| *** sayan has joined #openstack-horizon | 10:13 | |
| *** masco__ has joined #openstack-horizon | 10:14 | |
| *** sayan has quit IRC | 10:15 | |
| *** sayan has joined #openstack-horizon | 10:19 | |
| *** kzaitsev_mb has joined #openstack-horizon | 10:19 | |
| *** aix has quit IRC | 10:21 | |
| *** stevemar has joined #openstack-horizon | 10:22 | |
| *** Longgeek has joined #openstack-horizon | 10:22 | |
| *** stevemar has quit IRC | 10:24 | |
| *** oro has quit IRC | 10:27 | |
| *** lyanchih has quit IRC | 10:29 | |
| *** aix has joined #openstack-horizon | 10:34 | |
| *** e0ne is now known as e0ne_ | 10:45 | |
| *** Longgeek_ has joined #openstack-horizon | 10:46 | |
| *** Longgeek has quit IRC | 10:48 | |
| *** e0ne_ is now known as e0ne | 10:49 | |
| *** kyleolivo has joined #openstack-horizon | 10:51 | |
| *** pkarikh has quit IRC | 10:52 | |
| *** pkarikh has joined #openstack-horizon | 10:52 | |
| *** kyleolivo has quit IRC | 10:56 | |
| *** tosky has quit IRC | 10:57 | |
| *** tosky has joined #openstack-horizon | 10:59 | |
| *** psanchez_ has quit IRC | 11:01 | |
| *** annashen has joined #openstack-horizon | 11:02 | |
| *** annashen has quit IRC | 11:07 | |
| *** openstackgerrit has quit IRC | 11:09 | |
| *** openstackgerrit has joined #openstack-horizon | 11:10 | |
| robcresswell | Gooood afternoon | 11:10 |
| robcresswell | Anyone need reviews/ help? :) | 11:10 |
| *** psanchez_ has joined #openstack-horizon | 11:17 | |
| mrunge | robcresswell, depending what you're looking for :) | 11:21 |
| mrunge | but greatly appreciated anyways! | 11:21 |
| robcresswell | mrunge: Haha, I can help review if there is anything you would like another pair of eyes on. Although I am sure if you are stuck with packaging issues, it is unlikely I could help :p | 11:23 |
| mrunge | robcresswell, you got me wrong :D | 11:23 |
| mrunge | I was more asking, if you were looking for more pythonic issues or more javascript stuff | 11:24 |
| mrunge | any help would be appreciated with moving to Django-1.8 | 11:24 |
| mrunge | as we just moved to 1.7; 1.6 contains a known and not patched security issue | 11:25 |
| mrunge | with "we" I mean upstream horizon | 11:25 |
| openstackgerrit | Merged openstack/horizon: Replace mox with mox3 https://review.openstack.org/201095 | 11:30 |
| *** kjelly has joined #openstack-horizon | 11:31 | |
| robcresswell | mrunge: Ah I see. Yes, the 1.8 work is critical for this cycle as it becomes the new Django LTS when 1.4 support ends in October | 11:33 |
| robcresswell | mrunge: I'll get reviewing on Victors patches and see if I can contribute any other fixes | 11:34 |
| mrunge | robcresswell, that'll be awesome! | 11:34 |
| mrunge | and I saw, you already reviewed them | 11:35 |
| *** masco__ has quit IRC | 11:35 | |
| robcresswell | mrunge: Yup, they are mostly okay, just going to double check before throwing out some +2s | 11:38 |
| *** lyanchih has joined #openstack-horizon | 11:39 | |
| *** e0ne is now known as e0ne_ | 11:39 | |
| *** e0ne_ is now known as e0ne | 11:41 | |
| *** jtriley has joined #openstack-horizon | 11:44 | |
| *** jtriley has quit IRC | 11:52 | |
| *** lyanchih has quit IRC | 11:52 | |
| *** btully has joined #openstack-horizon | 11:56 | |
| kjelly | Hi, guys. Please help me review the patch. Thank you. https://review.openstack.org/#/c/198281/ | 11:56 |
| *** e0ne is now known as e0ne_ | 11:56 | |
| *** pauloewerton has joined #openstack-horizon | 11:57 | |
| *** ducttape_ has joined #openstack-horizon | 11:58 | |
| *** e0ne_ is now known as e0ne | 11:59 | |
| *** julim has joined #openstack-horizon | 12:00 | |
| openstackgerrit | Matthias Runge proposed openstack/django_openstack_auth: Replace AnonymousUser with AbstractBaseUser https://review.openstack.org/167981 | 12:00 |
| *** btully has quit IRC | 12:02 | |
| *** annashen has joined #openstack-horizon | 12:03 | |
| *** kzaitsev_mb has quit IRC | 12:04 | |
| *** kzaitsev_mb has joined #openstack-horizon | 12:05 | |
| *** annashen has quit IRC | 12:08 | |
| *** ducttape_ has quit IRC | 12:10 | |
| *** openstack has joined #openstack-horizon | 12:12 | |
| robcresswell | kjelly: Reviewing now. | 12:15 |
| *** kzaitsev_mb has quit IRC | 12:16 | |
| *** Longgeek_ has quit IRC | 12:17 | |
| *** pkarikh has quit IRC | 12:17 | |
| *** pkarikh_ has joined #openstack-horizon | 12:17 | |
| *** absubram has joined #openstack-horizon | 12:18 | |
| *** absubram has quit IRC | 12:19 | |
| *** Longgeek has joined #openstack-horizon | 12:19 | |
| *** absubram has joined #openstack-horizon | 12:20 | |
| *** ig0r_ has joined #openstack-horizon | 12:24 | |
| *** kzaitsev_mb has joined #openstack-horizon | 12:31 | |
| *** linkedinyou has joined #openstack-horizon | 12:32 | |
| *** yingjun has joined #openstack-horizon | 12:33 | |
| *** Piet has quit IRC | 12:36 | |
| openstackgerrit | svasheka proposed openstack/horizon: Add _save_screenshot functionality to helpers. https://review.openstack.org/194646 | 12:39 |
| *** raildo has joined #openstack-horizon | 12:40 | |
| *** absubram has quit IRC | 12:41 | |
| *** e0ne is now known as e0ne_ | 12:42 | |
| kjelly | @robcresswell Thank you for your reviewing | 12:43 |
| *** e0ne_ is now known as e0ne | 12:47 | |
| *** julim has quit IRC | 12:47 | |
| *** neelashah has joined #openstack-horizon | 12:49 | |
| *** lyanchih has joined #openstack-horizon | 12:51 | |
| *** kyleolivo has joined #openstack-horizon | 12:52 | |
| *** kzaitsev_mb has quit IRC | 12:54 | |
| *** kyleolivo has quit IRC | 12:56 | |
| *** oro has joined #openstack-horizon | 13:01 | |
| *** ZZelle has quit IRC | 13:02 | |
| *** ZZelle has joined #openstack-horizon | 13:03 | |
| *** kzaitsev_mb has joined #openstack-horizon | 13:03 | |
| *** annashen has joined #openstack-horizon | 13:04 | |
| *** annashen has quit IRC | 13:09 | |
| lyanchih | guys plz help me to review this https://review.openstack.org/#/c/199457/ | 13:09 |
| *** petertr7_away is now known as petertr7 | 13:10 | |
| *** julim has joined #openstack-horizon | 13:13 | |
| *** tvanderwiel has joined #openstack-horizon | 13:15 | |
| *** jpomero_ is now known as jpomero | 13:16 | |
| *** peristeri has joined #openstack-horizon | 13:17 | |
| *** lblanchard has joined #openstack-horizon | 13:18 | |
| *** drupalmonkey has joined #openstack-horizon | 13:22 | |
| *** yamamoto has quit IRC | 13:22 | |
| *** petertr7 is now known as petertr7_away | 13:25 | |
| *** geoffarnold has joined #openstack-horizon | 13:27 | |
| *** Piet has joined #openstack-horizon | 13:27 | |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Angular metadata update modal https://review.openstack.org/184274 | 13:28 |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Angularize metadata update modals https://review.openstack.org/184275 | 13:29 |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Allow to edit image metadata from project view https://review.openstack.org/184280 | 13:29 |
| *** _crobertsrh is now known as crobertsrh | 13:32 | |
| *** yingjun has quit IRC | 13:32 | |
| *** yingjun has joined #openstack-horizon | 13:33 | |
| *** vijendar1 has joined #openstack-horizon | 13:33 | |
| *** petertr7_away is now known as petertr7 | 13:34 | |
| *** vijendar has quit IRC | 13:35 | |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon: Moving Sahara to contrib https://review.openstack.org/197363 | 13:35 |
| *** matt-borland has joined #openstack-horizon | 13:36 | |
| *** jtriley has joined #openstack-horizon | 13:39 | |
| *** e0ne is now known as e0ne_ | 13:40 | |
| *** lhcheng has joined #openstack-horizon | 13:41 | |
| *** bradjones has quit IRC | 13:41 | |
| *** masco__ has joined #openstack-horizon | 13:42 | |
| *** vijendar1 has quit IRC | 13:42 | |
| *** vijendar has joined #openstack-horizon | 13:42 | |
| *** Piet has quit IRC | 13:44 | |
| *** bradjones has joined #openstack-horizon | 13:48 | |
| *** bradjones has quit IRC | 13:48 | |
| *** bradjones has joined #openstack-horizon | 13:48 | |
| *** e0ne_ is now known as e0ne | 13:48 | |
| *** kjelly has quit IRC | 13:51 | |
| *** dboik has quit IRC | 13:52 | |
| *** pkarikh_ has quit IRC | 13:53 | |
| *** pkarikh has joined #openstack-horizon | 13:53 | |
| *** absubram has joined #openstack-horizon | 13:56 | |
| *** Longgeek has quit IRC | 13:56 | |
| *** petertr7 is now known as petertr7_away | 13:59 | |
| *** yamamoto has joined #openstack-horizon | 14:00 | |
| *** petertr7_away is now known as petertr7 | 14:00 | |
| *** Longgeek has joined #openstack-horizon | 14:01 | |
| *** Alister has joined #openstack-horizon | 14:04 | |
| *** Alister has quit IRC | 14:05 | |
| *** annashen has joined #openstack-horizon | 14:05 | |
| *** Miouge has joined #openstack-horizon | 14:09 | |
| *** annashen has quit IRC | 14:09 | |
| *** sayan_ has joined #openstack-horizon | 14:10 | |
| *** ducttape_ has joined #openstack-horizon | 14:11 | |
| *** dboik has joined #openstack-horizon | 14:12 | |
| *** sayan has quit IRC | 14:13 | |
| *** Drago has joined #openstack-horizon | 14:17 | |
| *** Drago has quit IRC | 14:18 | |
| *** Drago has joined #openstack-horizon | 14:19 | |
| *** sayan_ is now known as sayan | 14:19 | |
| *** sayan has quit IRC | 14:19 | |
| *** sayan has joined #openstack-horizon | 14:19 | |
| *** tvanderwiel has quit IRC | 14:20 | |
| *** tvanderwiel has joined #openstack-horizon | 14:21 | |
| *** neillc_away is now known as neillc | 14:22 | |
| *** geoffarnold has quit IRC | 14:22 | |
| *** geoffarnold has joined #openstack-horizon | 14:23 | |
| *** nlahouti has joined #openstack-horizon | 14:24 | |
| *** psanchez_ has quit IRC | 14:24 | |
| *** shaggycat has joined #openstack-horizon | 14:25 | |
| *** doug-fish has joined #openstack-horizon | 14:25 | |
| shaggycat | Hi all! I have a error in kilo. In juno all works fine: http://pastebin.com/BBVt8V1q The error reproduce (I deploy my stend by PXE and Puppet) | 14:26 |
| shaggycat | Of cource, In openstack all works (create instances, import vms, etc) | 14:26 |
| *** ankit_ag has quit IRC | 14:26 | |
| shaggycat | I can't login in horizon (dashboard) always | 14:27 |
| openstackgerrit | svasheka proposed openstack/horizon: Add _save_screenshot functionality to helpers. https://review.openstack.org/194646 | 14:28 |
| *** nlahouti has quit IRC | 14:28 | |
| *** andrewbogott_afk is now known as andrewbogott | 14:29 | |
| *** bluex-pl has joined #openstack-horizon | 14:31 | |
| *** _kiran_ has joined #openstack-horizon | 14:31 | |
| *** btully has joined #openstack-horizon | 14:31 | |
| lhcheng | shaggycat: I suspect django compatibility issue. What version are you running? | 14:33 |
| *** kiran-r has quit IRC | 14:35 | |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Client-side Magic Search https://review.openstack.org/201581 | 14:38 |
| openstackgerrit | Kelly Domico proposed openstack/horizon: [Launch Instance Fix] Magic Search in new Launch Instance https://review.openstack.org/201582 | 14:38 |
| *** jcoufal has quit IRC | 14:41 | |
| *** iamjarvo has joined #openstack-horizon | 14:42 | |
| *** zz_ttrifonov is now known as ttrifonov | 14:49 | |
| *** garthb has joined #openstack-horizon | 14:50 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/horizon: Use oslo.config for Horizon and Django configuration https://review.openstack.org/100521 | 14:51 |
| *** hurgleburgler has joined #openstack-horizon | 14:51 | |
| *** kyleolivo has joined #openstack-horizon | 14:53 | |
| *** rwsu has joined #openstack-horizon | 14:56 | |
| *** e0ne is now known as e0ne_ | 14:56 | |
| *** tyr has joined #openstack-horizon | 14:57 | |
| *** kyleolivo has quit IRC | 14:57 | |
| *** rwsu has quit IRC | 14:58 | |
| *** jbell8 has joined #openstack-horizon | 14:58 | |
| *** rwsu has joined #openstack-horizon | 14:58 | |
| *** e0ne_ is now known as e0ne | 14:59 | |
| *** lhcheng has quit IRC | 15:00 | |
| *** TravT has quit IRC | 15:01 | |
| *** TravT has joined #openstack-horizon | 15:02 | |
| *** rdopiera has quit IRC | 15:04 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Remove ngimages index.html domain header https://review.openstack.org/201613 | 15:05 |
| *** _kiran_ is now known as kiran-r | 15:05 | |
| *** annashen has joined #openstack-horizon | 15:06 | |
| *** annashen has quit IRC | 15:10 | |
| *** ig0r_ has quit IRC | 15:10 | |
| *** ig0r__ has joined #openstack-horizon | 15:11 | |
| *** kzaitsev_mb has quit IRC | 15:11 | |
| *** Piet has joined #openstack-horizon | 15:12 | |
| *** petertr7 is now known as petertr7_away | 15:18 | |
| *** peristeri has quit IRC | 15:18 | |
| *** ig0r_ has joined #openstack-horizon | 15:18 | |
| *** ig0r__ has quit IRC | 15:19 | |
| *** katyafervent_awa is now known as katyafervent | 15:19 | |
| lyanchih | guys plz help me to review this https://review.openstack.org/#/c/199457/ | 15:20 |
| *** notmars has joined #openstack-horizon | 15:23 | |
| *** garthb has quit IRC | 15:24 | |
| *** garthb has joined #openstack-horizon | 15:25 | |
| *** masco__ has quit IRC | 15:25 | |
| *** TravT_ has joined #openstack-horizon | 15:25 | |
| *** TravT has quit IRC | 15:26 | |
| *** belmoreira has quit IRC | 15:26 | |
| *** peristeri has joined #openstack-horizon | 15:29 | |
| *** SimonChung has quit IRC | 15:29 | |
| *** kzaitsev_mb has joined #openstack-horizon | 15:30 | |
| *** stevemar has joined #openstack-horizon | 15:34 | |
| *** petertr7_away is now known as petertr7 | 15:35 | |
| *** oro_ has joined #openstack-horizon | 15:38 | |
| *** ongk has joined #openstack-horizon | 15:39 | |
| *** bpokorny has joined #openstack-horizon | 15:39 | |
| *** geoffarnold has quit IRC | 15:40 | |
| *** geoffarnold has joined #openstack-horizon | 15:41 | |
| openstackgerrit | Eric Peterson proposed openstack/horizon: LBAAS VIP floating IP table actions https://review.openstack.org/196740 | 15:41 |
| *** ig0r__ has joined #openstack-horizon | 15:42 | |
| *** bluex-pl has quit IRC | 15:43 | |
| *** ig0r_ has quit IRC | 15:43 | |
| *** nlahouti has joined #openstack-horizon | 15:45 | |
| *** tjones1 has joined #openstack-horizon | 15:45 | |
| *** notmars has quit IRC | 15:46 | |
| *** KunalGandhi has joined #openstack-horizon | 15:46 | |
| *** liangbo has joined #openstack-horizon | 15:47 | |
| *** oro_ has quit IRC | 15:47 | |
| *** oro has quit IRC | 15:48 | |
| *** yingjun has quit IRC | 15:48 | |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Client-side Magic Search https://review.openstack.org/201581 | 15:49 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Dashboard ReOrg - Relocate Launch Instance module https://review.openstack.org/197234 | 15:50 |
| openstackgerrit | Kelly Domico proposed openstack/horizon: [Launch Instance Fix] Magic Search in new Launch Instance https://review.openstack.org/201582 | 15:50 |
| Piet | Edit Project modal has been posted for review. https://openstack.invisionapp.com/d/main/#/projects/4105611 | 15:51 |
| *** sayan has quit IRC | 15:52 | |
| *** e0ne is now known as e0ne_ | 15:53 | |
| *** e0ne_ is now known as e0ne | 15:54 | |
| *** TravT_ has quit IRC | 15:54 | |
| *** ttrifonov is now known as zz_ttrifonov | 15:54 | |
| *** geoffarnold has quit IRC | 15:59 | |
| *** geoffarnold has joined #openstack-horizon | 16:00 | |
| *** amotoki_ has quit IRC | 16:01 | |
| *** TravT has joined #openstack-horizon | 16:01 | |
| *** notmars has joined #openstack-horizon | 16:03 | |
| *** rhagarty has quit IRC | 16:04 | |
| *** rhagarty_ has quit IRC | 16:04 | |
| *** tjones1 has quit IRC | 16:04 | |
| *** kjelly has joined #openstack-horizon | 16:05 | |
| *** stevemar has quit IRC | 16:06 | |
| *** annashen has joined #openstack-horizon | 16:06 | |
| *** kzaitsev_mb has quit IRC | 16:08 | |
| *** rhagarty has joined #openstack-horizon | 16:08 | |
| *** rhagarty_ has joined #openstack-horizon | 16:09 | |
| robcresswell | TravT: Can I jump on the panel bandwagon and add networks? | 16:09 |
| tyr | On master, jasmine/ServiceTests runs about 1/3rd of the tests, then redirects to the login page. Is this already being investigated? | 16:09 |
| *** ongk has quit IRC | 16:09 | |
| robcresswell | Piet: I'll be catching up on the design reviews tomorrow, sorry that I've been a little AWOL on that front | 16:09 |
| matt-borland | tyr: whoa! I'll check it out. | 16:10 |
| *** Drago has quit IRC | 16:10 | |
| *** kjelly has left #openstack-horizon | 16:11 | |
| *** annashen has quit IRC | 16:11 | |
| *** Drago has joined #openstack-horizon | 16:11 | |
| Piet | robcresswell: no worries. My recommendation would be to look at create Image, Create Project and Edit Project | 16:11 |
| TravT | robcresswell: we're still figuring out a few things to make some patterns, but you could get started looking at it. i'm working on some directives today to maybe clean up the images panel which would be helpful to other panels. | 16:11 |
| robcresswell | Piet: Got it, cheers | 16:11 |
| Piet | I think we should also update the Launch Instance and move the Instance Details controls to it's own step | 16:12 |
| robcresswell | TravT: Alrightey, I'll hold back for a few days. Got panel patch, working on table. It's a lot of copy/paste/substitute, so nothing dramatic. | 16:12 |
| Piet | Preferably before the upcoming Launch Instance validation study | 16:13 |
| *** zhenguo has quit IRC | 16:13 | |
| matt-borland | tyr: that is fascinating | 16:14 |
| *** kjelly has joined #openstack-horizon | 16:14 | |
| matt-borland | it's amazing what happens when we ignore false positives in our integration tests | 16:14 |
| tyr | fun yeah? --karma works fine, so something funky with jasmine config. Trying to isolate which test triggers the redirect | 16:15 |
| david-lyle | how about the ability to create network from launch instance :) | 16:15 |
| matt-borland | :) | 16:15 |
| sjmc7 | floating IPs!! | 16:15 |
| sjmc7 | :) | 16:15 |
| david-lyle | ooh, now there's value | 16:16 |
| Piet | I'm down with adding Create Network and Assign Floating IPs to the LI wizard. | 16:16 |
| ducttape_ | fiping ain't easy | 16:16 |
| Piet | Do ya'll need some designs from me? | 16:16 |
| david-lyle | another shirt? | 16:16 |
| *** e0ne is now known as e0ne_ | 16:16 | |
| *** yamamoto has quit IRC | 16:16 | |
| ducttape_ | viping and fiping at the same time - https://review.openstack.org/#/c/196740/ #impossible | 16:17 |
| robcresswell | ducttape_: I read that commit title and understood some of those words. | 16:17 |
| * robcresswell is proud | 16:17 | |
| *** Sukhdev has joined #openstack-horizon | 16:18 | |
| david-lyle | would be better with more acronyms | 16:18 |
| *** e0ne_ is now known as e0ne | 16:18 | |
| *** kzaitsev_mb has joined #openstack-horizon | 16:18 | |
| ducttape_ | all horizons should get what a vip is -> it's how horizon should be deployed | 16:18 |
| david-lyle | LBAAS VIP FIP TA | 16:18 |
| ducttape_ | and floating ip, that should be pretty easy | 16:18 |
| robcresswell | we're now just referred to as horizons? | 16:19 |
| *** yamamoto has joined #openstack-horizon | 16:19 | |
| david-lyle | horizontals | 16:19 |
| ducttape_ | it's better than "you people", or some of the other words I use to describe you | 16:19 |
| robcresswell | bahaha I still love when that guy on the streets at the summit called us Davids children | 16:19 |
| robcresswell | Like we were there with Piet | 16:19 |
| david-lyle | such a proud moment | 16:19 |
| ducttape_ | true story: Dave has more kids than horizon contributors | 16:20 |
| david-lyle | lol | 16:20 |
| david-lyle | and true | 16:20 |
| openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Remove Neutron init from post-deployment init https://review.openstack.org/201649 | 16:20 |
| ducttape_ | david-lyle - I was looking at STATIC_URL stuff, and you had a commit in that mess too. I just wanted to sling your name through the mud, otherwise TravT and tqtran will feel like I was picking on them | 16:21 |
| doug-fish | ducttape_: can you elaborate on "all horizons should get what a vip is -> it's how horizon should be deployed". I don't know how to deploy Horizon this way or why it might be a good idea. | 16:21 |
| ducttape_ | ;) | 16:21 |
| *** kiran-r has quit IRC | 16:21 | |
| david-lyle | ducttape_: I had to change it | 16:21 |
| *** emw has joined #openstack-horizon | 16:21 | |
| david-lyle | the webroot stuff didn't actually work | 16:21 |
| ducttape_ | doug-fish - so the vip is a load balancer term, ideally horizon would have a couple of nodes stood up to back it | 16:22 |
| david-lyle | because the static url wasn't being constructed properly when webroot changed | 16:22 |
| *** dsneddon_away is now known as dsneddon | 16:22 | |
| ducttape_ | "Virtual IP (VIP) is the load-balancing instance where the world points its browsers to get to a site. A VIP has an IP address, which must be publicly available to be useable. Usually a TCP or UDP port number is associated with the VIP, such as TCP port 80 for web traffic." | 16:22 |
| Piet | Wait...did I just get pulled into a conversatino | 16:22 |
| Piet | ? | 16:22 |
| doug-fish | ducttape_: oh I see | 16:22 |
| *** stevemar has joined #openstack-horizon | 16:23 | |
| ducttape_ | doug-fish - general rule of openstack is that everything fails, and needs a load balancer. horizon hardly ever fails, though | 16:23 |
| *** iamjarvo has quit IRC | 16:24 | |
| doug-fish | ducttape_: yeah I understand. BTW - how do you do session storage in that environment? | 16:24 |
| ducttape_ | db/mysql | 16:25 |
| ducttape_ | cookies could work, except we do un-natural things to cookies | 16:26 |
| robcresswell | ducttape_: I guess that depends on the definition of failure... | 16:26 |
| robcresswell | :p | 16:26 |
| *** SimonChung has joined #openstack-horizon | 16:26 | |
| ducttape_ | robcresswell - when you operate openstack, the definition of failure is quite clear, and easily recognized ;) | 16:26 |
| *** stevemar has quit IRC | 16:27 | |
| robcresswell | ducttape_: Yeah I've been working much more closely with the service teams this cycle, hence being slightly less active on irc. I am so glad I currently live in developer land. | 16:29 |
| ducttape_ | robcresswell - try living in both | 16:29 |
| ducttape_ | ;) | 16:29 |
| *** tqtran has joined #openstack-horizon | 16:31 | |
| *** kyleolivo has joined #openstack-horizon | 16:38 | |
| *** annashen has joined #openstack-horizon | 16:39 | |
| *** kyleolivo has quit IRC | 16:39 | |
| *** kyleolivo has joined #openstack-horizon | 16:40 | |
| *** kbrown has joined #openstack-horizon | 16:41 | |
| *** e0ne has quit IRC | 16:42 | |
| *** kzaitsev_mb has quit IRC | 16:42 | |
| openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Remove Neutron init from post-deployment init https://review.openstack.org/201649 | 16:42 |
| esp | hey folks anyone familiar with logout in horizon? we wondering if it’s feasible to delete the session on logout. | 16:42 |
| david-lyle | esp: https://docs.djangoproject.com/en/1.8/topics/auth/default/#django.contrib.auth.logout | 16:44 |
| david-lyle | that should already happen | 16:44 |
| esp | thx david-lyle, we’re seeing some weird caching going on | 16:45 |
| *** KunalGan_ has joined #openstack-horizon | 16:45 | |
| david-lyle | what are you storing your sessions in? | 16:45 |
| esp | trying to hide tabs in the project create/update | 16:45 |
| esp | maybe that’s browser caching? | 16:45 |
| david-lyle | esp: how is that related to session? | 16:46 |
| esp | good question | 16:46 |
| esp | maybe not | 16:46 |
| david-lyle | :D | 16:46 |
| esp | so if I login as Cloud Admin in (with keystone v3, cuz that’s all I do) | 16:46 |
| *** oro_ has joined #openstack-horizon | 16:46 | |
| esp | I see all tabs | 16:46 |
| david-lyle | tabs? | 16:47 |
| esp | in Create/Update project | 16:47 |
| *** oro has joined #openstack-horizon | 16:47 | |
| *** KunalGandhi has quit IRC | 16:47 | |
| esp | tabs —> Project Info, Members, Groups, Quota | 16:47 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Add Angular Basic Page Header Directive https://review.openstack.org/201661 | 16:48 |
| *** lyanchih has quit IRC | 16:48 | |
| david-lyle | so you have a permissions check issue? | 16:48 |
| *** lyanchih has joined #openstack-horizon | 16:49 | |
| david-lyle | I don't think this is session related, other than your token with roles is in the session, but your token is deleted when you logout too | 16:49 |
| esp | sorta, we are trying to hide tabs conditionally based on project admin vs cloud admin | 16:49 |
| esp | gotcha | 16:49 |
| esp | we’re looking clearing cache in the browser now | 16:50 |
| david-lyle | I would look at your check and policy file first | 16:50 |
| david-lyle | nothing in the browse cache should be related | 16:50 |
| david-lyle | but that's me | 16:51 |
| *** notmars has quit IRC | 16:51 | |
| *** kzaitsev_mb has joined #openstack-horizon | 16:51 | |
| esp | k, thx david-lyle | 16:51 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Add Angular Basic Page Header Directive https://review.openstack.org/201661 | 16:52 |
| *** yamamoto has quit IRC | 16:52 | |
| *** jingjing_ren has joined #openstack-horizon | 16:53 | |
| *** yamamoto has joined #openstack-horizon | 16:55 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Adding Angular Project Images Table https://review.openstack.org/200385 | 16:55 |
| openstackgerrit | Eric Peterson proposed openstack/horizon: LBAAS VIP floating IP table actions https://review.openstack.org/196740 | 16:56 |
| tqtran | TravT: you have time to talk about the html directives? lets plan that out now since you're taking off 2nd part of the week | 16:57 |
| tqtran | i can help with that effort as well | 16:57 |
| TravT | tqtran: yes, let's do that. i have 15 minutes now and then can this afternoon. | 16:57 |
| ducttape_ | ahh crap, I had two plus 2, then I added test cases now..... lesson of the day: never write test code | 16:57 |
| TravT | i just put up one patch | 16:57 |
| TravT | can you look at it real quick? | 16:57 |
| tqtran | yeah link | 16:58 |
| TravT | https://review.openstack.org/201661 | 16:58 |
| TravT | and i made the images page depend on it. | 16:58 |
| TravT | wasn't actually planning on that one, until seeing lhcheng comment overnight, so i just added it. | 16:58 |
| *** ghundal_tw has joined #openstack-horizon | 16:59 | |
| *** aix has quit IRC | 16:59 | |
| *** kyleolivo has quit IRC | 17:00 | |
| david-lyle | ducttape_: it was just a tease | 17:00 |
| *** mgarza_ has joined #openstack-horizon | 17:00 | |
| tqtran | TravT: where's lhcheng's comment? i dont see it | 17:01 |
| *** sqchen has joined #openstack-horizon | 17:01 | |
| TravT | just on the base panel patch where I pulled in the wrong django header template. | 17:01 |
| TravT | so, decided to make an angular header template | 17:02 |
| sqchen | tqtran: ping | 17:02 |
| tqtran | TravT: ok one piece of bad news, the angular-babel only picks up the directive and attribute variant, it does not pick up the filter variant quite yet | 17:02 |
| TravT | bummer... | 17:03 |
| tqtran | https://review.openstack.org/#/c/200385/16/openstack_dashboard/dashboards/project/ngimages/templates/ngimages/index.html L7 wouldnt work | 17:03 |
| TravT | well, we could interpolate django tran there. | 17:03 |
| TravT | let the frankensteining continue | 17:03 |
| tqtran | sqchen: hi sean, did you read the comment, thoughts? | 17:03 |
| tqtran | TravT: or you can address the problem, i can put in a patch for it | 17:04 |
| TravT | tqtran: please be my guest! | 17:04 |
| tqtran | or neillc or r1chardj0n3s can as well | 17:04 |
| tqtran | lets talk some more this afternoon when you're free, we can split up the directive work | 17:04 |
| TravT | yeah, that sounds good. | 17:05 |
| tqtran | sqchen: you're still there sean? | 17:05 |
| *** kjelly has quit IRC | 17:05 | |
| sqchen | tqtran: I like your idea! | 17:05 |
| sqchen | I will do it now. | 17:06 |
| tqtran | coolios! | 17:06 |
| *** petertr7 is now known as petertr7_away | 17:06 | |
| sqchen | what about I do the defalt thing in app.module.js | 17:08 |
| sqchen | WEBROOT = WEBROOT || ‘/’; | 17:08 |
| *** bpokorny has quit IRC | 17:08 | |
| *** yamamoto has quit IRC | 17:08 | |
| sqchen | tqtran:^^ | 17:09 |
| *** bpokorny has joined #openstack-horizon | 17:09 | |
| ducttape_ | sqchen - so what would happen when WEBROOT is not at '/' ?? | 17:10 |
| sqchen | when WEBROOT is defined, WEBROOT = WEBROOT || ‘/’ will have no effect. | 17:11 |
| *** skylerberg has joined #openstack-horizon | 17:11 | |
| Piet | Does anyone have cycles to update the menu to the new information archtiecture? | 17:11 |
| sqchen | but in karma and jasmine, WEBROOT is undefined, so it will be set to ‘/’ | 17:12 |
| ducttape_ | sqchen - does karma and jasmine run after collect static has been run / from that folder? | 17:13 |
| * ducttape_ regrets using the / character above | 17:13 | |
| tqtran | sqchen: that would work :) great idea! | 17:14 |
| *** jcoufal has joined #openstack-horizon | 17:15 | |
| *** pamo has joined #openstack-horizon | 17:15 | |
| sqchen | ducttape_: tqtran: yes we nood to be make sure app.moule.js get run first. thx tqtran. | 17:15 |
| *** liangbo has quit IRC | 17:17 | |
| tqtran | ducttape_: karma and jasmine are test runners, you trigger them whenever you want to test. whereas, you collect static when you want to do that. in both cases, the order of the js is loaded according to how they show up in the html, and in our case, the app.module.js will probably be one of the first ones. | 17:17 |
| ducttape_ | my point tqtran sqchen is that if you use the correct settings with collectstatic, that WEBROOT not defined could go away | 17:18 |
| skylerberg | I am interested in displaying some information while hovering over a cell in a table. Is there anything like this supported by horizon? | 17:19 |
| *** jcoufal has quit IRC | 17:19 | |
| skylerberg | I see this bp, but there is no discussion on it: https://blueprints.launchpad.net/horizon/+spec/auto-dropdown | 17:19 |
| tqtran | ducttape_: for jasmine yes, for karma, im not so sure | 17:19 |
| tqtran | jasmine has a jasmine.html that is also a django template, so it would work there | 17:19 |
| *** ghundal_tw has quit IRC | 17:20 | |
| tqtran | but karma is different, we'd need to define WEBROOT in a JS file somewhere, thus the fallback || statement | 17:20 |
| ducttape_ | if you have a js file with WEBROOT and the python template directives in there, you'd have what you want in a static js file | 17:21 |
| *** annashen has quit IRC | 17:23 | |
| skylerberg | Actually the spec is just talking about on a topbar menu, I am interested in having information appear when mousing over a cell in a table. | 17:23 |
| sqchen | js files are static files, python can not reach it. and shouldn’t. | 17:24 |
| *** pamo_ has joined #openstack-horizon | 17:24 | |
| *** deuce has joined #openstack-horizon | 17:24 | |
| *** pamo has quit IRC | 17:25 | |
| sqchen | and also, karma environment is pure static. | 17:25 |
| sqchen | means no python there at all. | 17:25 |
| openstackgerrit | Coleman Beasley proposed openstack/horizon: JSCS Cleanup-style guide cleanup for Magic Search https://review.openstack.org/199327 | 17:26 |
| *** tvanderwiel has quit IRC | 17:26 | |
| *** ybathia has joined #openstack-horizon | 17:26 | |
| *** nlahouti has quit IRC | 17:27 | |
| openstackgerrit | David Lyle proposed openstack/django_openstack_auth: Add domain scoped token to session in multidomain https://review.openstack.org/141153 | 17:27 |
| ducttape_ | sqchen - collectstatic does a one time pass to copy all your static files to a dir. as part of that, it will replace tags like {{ WEBROOT }} | 17:27 |
| ducttape_ | you'd still be fine to run all your stuff out of there, and would not be invoking python | 17:27 |
| *** kiran-r has joined #openstack-horizon | 17:28 | |
| ducttape_ | and in reality, you should probably be running tests this way anyways - it is the closest setup to how stuff would really be deployed | 17:29 |
| ducttape_ | b/c you could have static file collisions etc that do things you were not expecting | 17:29 |
| sqchen | 1) I don’t think we want python-generated js files, 12 karma runs without collectstatic. | 17:30 |
| *** kbrown has quit IRC | 17:31 | |
| *** kbrown has joined #openstack-horizon | 17:32 | |
| *** nlahouti has joined #openstack-horizon | 17:33 | |
| tqtran | I'd have to agree with sqchen here | 17:33 |
| *** Sukhdev has quit IRC | 17:33 | |
| *** pamo_ has quit IRC | 17:33 | |
| *** pamo has joined #openstack-horizon | 17:34 | |
| *** SimonChung1 has joined #openstack-horizon | 17:34 | |
| ducttape_ | seems like I won't convince you, but I still feel like this method is a shortcut and would cause more situations than fixing stuff | 17:34 |
| *** SimonChung has quit IRC | 17:35 | |
| *** markus_z has quit IRC | 17:35 | |
| *** yamamoto has joined #openstack-horizon | 17:35 | |
| tqtran | it's not a shortcut, its gracefully defaulting to something that would allow tests to continue working | 17:36 |
| *** notmars has joined #openstack-horizon | 17:37 | |
| *** sayan has joined #openstack-horizon | 17:37 | |
| *** jbell8 has quit IRC | 17:37 | |
| ducttape_ | tqtran - there are situations where static paths will collide and you will get a file you did not expect - would you agree ? | 17:38 |
| ducttape_ | I can tell you that this does happen, we rely upon this side effect to rebrand horizon | 17:38 |
| tqtran | sorry, im not following. what do you mean static paths collide? | 17:39 |
| ducttape_ | when things eventually get deployed, you will have static paths from various resources .... think like all the xstatic stuff | 17:39 |
| ducttape_ | it is possible (though not a good idea) to have two packages deploy /static/horizon.foo.js | 17:40 |
| tqtran | sure | 17:40 |
| ducttape_ | and only one package will get to lay this file down | 17:40 |
| tqtran | um hm | 17:40 |
| ducttape_ | or the last / first one wins (whatever the policy is) | 17:40 |
| tqtran | probably last one wins | 17:40 |
| ducttape_ | sure, whatever | 17:40 |
| ducttape_ | but if you run collectstatic, then you will have all those files in a folder.... like within ./static for example | 17:41 |
| tqtran | sure | 17:41 |
| *** andrewbogott is now known as andrewbogott_afk | 17:41 | |
| ducttape_ | and that folder will contain exactly what gets deployed | 17:41 |
| tqtran | make sense | 17:41 |
| ducttape_ | and that folder, should be where you point js test frameworks at | 17:41 |
| *** ybathia has quit IRC | 17:42 | |
| tqtran | yes, but im not seeing how defaulting to "/" has anything to do with collect static | 17:42 |
| ducttape_ | if you just say ./horizon/templates/ or ./horizon/static .... that is less ideal | 17:42 |
| *** pamo has quit IRC | 17:42 | |
| tqtran | they are two different things? | 17:42 |
| ducttape_ | because, as part of collectstatic, django variables can get injected into static content | 17:42 |
| tqtran | right, the question is, why would you want to do that? | 17:43 |
| ducttape_ | for things like WEBROOT | 17:43 |
| tqtran | what are the benefits as oppose to just defaulting to / | 17:43 |
| ducttape_ | or STATIC_URL | 17:43 |
| tqtran | sure, if we're using it yes, i agree 100% with you | 17:43 |
| ducttape_ | because then you can test with various setups, and it also more closely resembles what would get deployed | 17:44 |
| tqtran | but we're using it for tests, you dont need the exact WEBROOT or STATIC_URL, karma only needs to know where the JS files are, and it runs it | 17:44 |
| ducttape_ | might not need it, but why not test with stuff that is the closest match for what would be deployed? | 17:44 |
| tqtran | since we're talking hypothetical, let me give you a scenario | 17:45 |
| tqtran | lets say i have a node app and i want to run this same JS file there. it wouldn't work because there is a reliance on python inject | 17:46 |
| ducttape_ | why would it? | 17:46 |
| ducttape_ | I would say it does not | 17:46 |
| tqtran | because its a JS file, clientcode, i would be able to run that on any webapp | 17:46 |
| david-lyle | how js gets referenced in the separate app is its business | 17:47 |
| tqtran | what you're doing here is tying the JS code to a backend framework (django), and without it, it wouldnt work | 17:47 |
| ducttape_ | if you run it on your source folder, then yeah.... you would have {{ STATIC_URL }} in your source folder. if you run collectstatic, then {{ STATIC_URL }} is in your js file as '/static' or whatever | 17:47 |
| tqtran | sure, you can use the static, but the source is not reusable | 17:48 |
| ducttape_ | how is it not ? | 17:48 |
| tqtran | you'd need django to process the file before you can use it | 17:48 |
| david-lyle | tqtran: only the HTML | 17:49 |
| ducttape_ | tqtran: django processes 100% of your static assets right now | 17:49 |
| tqtran | ducttape_: right, but we're only using them to process templates, not JS code | 17:50 |
| ducttape_ | sometimes its during canonical packaging and it happens much earlier.... but it happens | 17:50 |
| sqchen | django service static file, not process IMO | 17:50 |
| david-lyle | how you push the STATIC_URL into the context of a separate app for JS is an exercise for the reader | 17:50 |
| *** ghundal_tw has joined #openstack-horizon | 17:51 | |
| tqtran | david-lyle: i think you're missing the point, we'r taking about having django generate and embed a python variable into a JS file | 17:51 |
| *** ghundal-TW has joined #openstack-horizon | 17:51 | |
| tqtran | that just doesn't make much senes | 17:51 |
| tqtran | lets write angular in python and have it generate a JS file | 17:51 |
| ducttape_ | tqtran - how does your js get loaded by the browser? | 17:51 |
| *** e0ne has joined #openstack-horizon | 17:51 | |
| david-lyle | tqtran: it does when you're building a python app that reads from a python based settings system | 17:51 |
| ducttape_ | I think you are being a bit overboard with that characterization tqtran | 17:52 |
| david-lyle | if you're running node to serve your app, you would use JS | 17:52 |
| *** jpomero has quit IRC | 17:52 | |
| *** jbell8 has joined #openstack-horizon | 17:52 | |
| ducttape_ | you right your js just like you usually do, this just makes it so you can have access to certain settings | 17:52 |
| *** tvanderwiel has joined #openstack-horizon | 17:52 | |
| *** tvanderwiel has left #openstack-horizon | 17:52 | |
| ducttape_ | alternatively, you could also place all these things that offend you, into a single js file | 17:52 |
| david-lyle | ooh, one JS file for all of Horizon | 17:53 |
| ducttape_ | and then 98% of your js can continue as is too | 17:53 |
| ducttape_ | i see what you did there david-lyle | 17:53 |
| david-lyle | :P | 17:53 |
| tqtran | or we can just default to / i really dont see a huge benefit | 17:53 |
| tqtran | we're over complicating things for a small to non gain | 17:53 |
| *** bpokorny_ has joined #openstack-horizon | 17:54 | |
| ducttape_ | the static urls and collisions are a real problem / something to test with I would say | 17:54 |
| tqtran | again, the collision and the defaulting to / is not related | 17:54 |
| *** rajatvig has joined #openstack-horizon | 17:54 | |
| tqtran | they are two different hings eric | 17:54 |
| *** tosky has quit IRC | 17:55 | |
| ducttape_ | you would need to run collectstatic for that, and then at that point..... people would start using the {{ STATIC_URL }} or {{ WEB_ROOT }} stuff | 17:55 |
| ducttape_ | they are, but since you are already going to need one.... | 17:55 |
| tqtran | or, you just default to / and not have to run collect static at all | 17:55 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - use function syntax for i18n https://review.openstack.org/201688 | 17:56 |
| ducttape_ | http://i.kinja-img.com/gawker-media/image/upload/aoz8kgx8pzknypz7z38n.jpg | 17:56 |
| tqtran | hah! | 17:56 |
| *** neelashah has quit IRC | 17:56 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - use $apply instead of $digest in help-panel spec https://review.openstack.org/201689 | 17:56 |
| hurgleburgler | wait, not run collect static at all? | 17:56 |
| *** openstackgerrit has quit IRC | 17:56 | |
| tqtran | iono, think we're trying to over engineer here | 17:56 |
| ducttape_ | thats what they are pushing for hurgleburgler | 17:56 |
| *** bpokorny has quit IRC | 17:56 | |
| hurgleburgler | the collision functionality is going to enable a far more customizable theme | 17:57 |
| *** openstackgerrit has joined #openstack-horizon | 17:57 | |
| david-lyle | we're going to collectstatic that's the point | 17:57 |
| david-lyle | how do you think you get around that? | 17:57 |
| ducttape_ | yeup. ya gotta | 17:57 |
| tqtran | /facepalm, i get that you can use the collision to replace/customize, whatever | 17:57 |
| tqtran | all im saying is, defaulting webroot to / for karma tests | 17:58 |
| tqtran | no need to have python inject anything | 17:58 |
| sqchen | ducttape, the WEBROOT and STATIC_URL is only about ajax all. in the test enveronment, JS files are always servered from the /static/ foler. | 17:58 |
| sqchen | let’s kepp static file static. | 17:58 |
| *** ghundal-TW has quit IRC | 17:59 | |
| *** ghundal_tw has quit IRC | 17:59 | |
| tqtran | and this way, i can reuse the source JS file in other places, not the generated JS file. | 17:59 |
| david-lyle | WEBROOT is certainly not only about AJAX | 17:59 |
| david-lyle | but that may be splitting hairs | 17:59 |
| tqtran | there's a reason we call them static | 17:59 |
| *** ghundal_tw has joined #openstack-horizon | 17:59 | |
| ducttape_ | and neither is STATIC | 17:59 |
| tqtran | and note JS template | 17:59 |
| sqchen | WEBROOT in js is for Ajax | 17:59 |
| sqchen | sorry. | 17:59 |
| ducttape_ | tqtran sqchen - they are static files, in a real deployment. I think you guys are thinking about devstack | 18:00 |
| sqchen | they are static form source code perspective as well. | 18:00 |
| *** bpokorny has joined #openstack-horizon | 18:01 | |
| *** bpokorny has quit IRC | 18:01 | |
| *** SimonChung has joined #openstack-horizon | 18:01 | |
| *** SimonChung1 has quit IRC | 18:01 | |
| *** bpokorny has joined #openstack-horizon | 18:01 | |
| *** ghundal_tw has quit IRC | 18:02 | |
| *** KunalGan_ has quit IRC | 18:02 | |
| *** SimonChung1 has joined #openstack-horizon | 18:03 | |
| *** SimonChung has quit IRC | 18:03 | |
| ducttape_ | are SCSS files static sqchen? | 18:04 |
| *** bpokorny_ has quit IRC | 18:04 | |
| sqchen | yes. | 18:04 |
| hurgleburgler | SCSS files are not static at all, they are just as dynamic as Django templates | 18:04 |
| hurgleburgler | They work the same way as Django templates | 18:04 |
| hurgleburgler | the client side never sees them | 18:05 |
| hurgleburgler | it just sees their final compiled version that is converted INTO css | 18:05 |
| sqchen | they are one time build static file. | 18:05 |
| hurgleburgler | the same as Django Template —> HTML | 18:05 |
| ducttape_ | sqchen can you show me where a client gets directly served a scss file ? | 18:06 |
| sqchen | they are source file to build css files, that happens in build process. | 18:06 |
| ducttape_ | ah, you mean something like collectstatic then | 18:07 |
| ducttape_ | so you agree then ;P | 18:07 |
| sqchen | something is not directly service by server not means they are dynamic. | 18:07 |
| *** petertr7_away is now known as petertr7 | 18:07 | |
| hurgleburgler | The next goal to make it so it doesn't necessarily happen in the build process | 18:07 |
| sqchen | no i don’t agree | 18:07 |
| *** gpeers has joined #openstack-horizon | 18:07 | |
| hurgleburgler | if we want to support on the the fly themes, then we will need to be able to push multiple theme names into the same scss files, and build multiple themes all on the build process | 18:08 |
| hurgleburgler | pushing the themes in via collectstatic, instead of only supporting a single theme via '/static' is gonna be needed | 18:08 |
| sqchen | build mean compile. scss is more like coffeescript, they are static source code. | 18:08 |
| *** geoffarnold has quit IRC | 18:08 | |
| *** annashen has joined #openstack-horizon | 18:09 | |
| ducttape_ | hurgleburgler - there is no convincing sqchen, even though he just described the same process we are talking about | 18:09 |
| *** ghundal_tw has joined #openstack-horizon | 18:09 | |
| sqchen | no you don’t see the defference here, I am sorry for that. :) | 18:10 |
| *** jwy has joined #openstack-horizon | 18:10 | |
| *** ongk has joined #openstack-horizon | 18:11 | |
| ducttape_ | sqchen - fun fact - did you know that python is running your scss compiler? https://github.com/openstack/horizon/blob/master/openstack_dashboard/settings.py#L142 | 18:12 |
| openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Remove Neutron init from post-deployment init https://review.openstack.org/201649 | 18:12 |
| *** iamjarvo has joined #openstack-horizon | 18:13 | |
| tqtran | lol guys, stop picking on sqchen, scss is not the same thing as js. one is meant to be precompiled, while the other is a pure static file. | 18:13 |
| sqchen | I know, but that is defferent. I also use scss in nodejs environment, but that is not mean they become a js stuff there. | 18:13 |
| tqtran | you're comparing apples to oranges and trying to make your point | 18:14 |
| *** jpomero has joined #openstack-horizon | 18:14 | |
| sqchen | scss is like coffeescript, they are static, they are not like html template. | 18:14 |
| sqchen | there are subtle defference there. | 18:15 |
| ducttape_ | sqchen - I am not saying the html templates, I am talking about something different | 18:15 |
| tqtran | on the bright side, im getting my massage machine today!!!!!!!!! | 18:16 |
| hurgleburgler | that sounds nice | 18:16 |
| tqtran | yeah, cant wait to try it out | 18:16 |
| sqchen | JS code can be generated forn typescript or coffeescript, they all static from django’s perspective. But js file should not be generated from python ot node template. | 18:17 |
| *** deuce1 has joined #openstack-horizon | 18:17 | |
| *** e0ne is now known as e0ne_ | 18:17 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 18:18 |
| *** deuce has quit IRC | 18:20 | |
| *** KunalGandhi has joined #openstack-horizon | 18:22 | |
| *** notmars has quit IRC | 18:23 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - horizon/ tech-debt https://review.openstack.org/199345 | 18:23 |
| openstackgerrit | Neill Cox proposed openstack/horizon: Add plurals and comments to angular i18n https://review.openstack.org/201700 | 18:24 |
| *** neelashah has joined #openstack-horizon | 18:25 | |
| *** bpokorny has quit IRC | 18:25 | |
| *** wasmum- has joined #openstack-horizon | 18:25 | |
| *** iamjarvo has quit IRC | 18:25 | |
| *** bpokorny has joined #openstack-horizon | 18:25 | |
| *** sambetts has quit IRC | 18:26 | |
| *** ghundal_tw has quit IRC | 18:26 | |
| *** e0ne_ is now known as e0ne | 18:26 | |
| *** geoffarnold has joined #openstack-horizon | 18:27 | |
| sqchen | Hi david-lyle: tqtran: now openning localhost:9000/jasmine/ is always redirected to http://localhost:9000/auth/login/. Are you guys aware of any change happened recently causing this? | 18:28 |
| *** ^Gal^_ has joined #openstack-horizon | 18:28 | |
| *** sambetts has joined #openstack-horizon | 18:28 | |
| tqtran | sqchen: its running fine for me | 18:29 |
| *** deuce1 has quit IRC | 18:29 | |
| *** mgagne_ has joined #openstack-horizon | 18:29 | |
| *** mpavlase has quit IRC | 18:29 | |
| sqchen | really? I tried many times, let me re-try. | 18:30 |
| *** kcaj_ has joined #openstack-horizon | 18:30 | |
| *** jwy has quit IRC | 18:30 | |
| *** Drago has quit IRC | 18:30 | |
| *** matt-borland has quit IRC | 18:30 | |
| *** chlong-afk has quit IRC | 18:30 | |
| *** ^Gal^ has quit IRC | 18:30 | |
| *** ccard has quit IRC | 18:30 | |
| *** kcaj has quit IRC | 18:30 | |
| *** wasmum has quit IRC | 18:30 | |
| *** mgagne has quit IRC | 18:30 | |
| *** iamjarvo has joined #openstack-horizon | 18:32 | |
| *** mgagne_ has left #openstack-horizon | 18:33 | |
| tyr | sqchen: I just filed https://bugs.launchpad.net/horizon/+bug/1474498 | 18:33 |
| openstack | Launchpad bug 1474498 in OpenStack Dashboard (Horizon) "jasmine tests redirect to login " [Undecided,New] | 18:33 |
| sqchen | tqtran: can you re-try? you need to wait for a couple of seconds. | 18:33 |
| tyr | it appears to be Chrome specific | 18:33 |
| *** oro has quit IRC | 18:34 | |
| *** oro_ has quit IRC | 18:34 | |
| tyr | sqchen: The problem test is added by https://review.openstack.org/#/c/200725 | 18:34 |
| *** neelashah has quit IRC | 18:34 | |
| sqchen | thanks tyr. | 18:34 |
| *** notmars has joined #openstack-horizon | 18:34 | |
| *** Longgeek has quit IRC | 18:36 | |
| david-lyle | sqchen: one spacing nit on line 14 of https://review.openstack.org/#/c/181095/49/horizon/static/framework/util/util.module.js | 18:36 |
| *** sqchen has quit IRC | 18:36 | |
| david-lyle | not worth a -1 | 18:36 |
| david-lyle | but I'll let you fix | 18:36 |
| tqtran | sqchen: oh hm.... i can hit the page, but getting redirected | 18:37 |
| tqtran | damn hes offline :( | 18:37 |
| *** zz_ttrifonov is now known as ttrifonov | 18:38 | |
| *** mgagne_ has joined #openstack-horizon | 18:39 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - Fix ng-di errors on cloud-services https://review.openstack.org/198840 | 18:41 |
| *** pamo has joined #openstack-horizon | 18:43 | |
| tqtran | tyr: lol nice find, so it kicks you even out of jasmine.html lol | 18:44 |
| tqtran | so basically, in order to run tests, you need to log in now | 18:44 |
| tqtran | hahahaha priceless | 18:44 |
| tyr | :) | 18:44 |
| tyr | I emailed Dan to take a look. Still investigating in the meantime. | 18:45 |
| *** KunalGandhi has quit IRC | 18:45 | |
| tqtran | just need to remove that interceptor in jasmine.html | 18:45 |
| tyr | the interceptor is added by framework.module.js | 18:46 |
| *** KunalGandhi has joined #openstack-horizon | 18:47 | |
| tyr | which isn't right, since the redirect is app specific | 18:47 |
| *** kcaj_ has quit IRC | 18:47 | |
| tqtran | yeah, the config really belongs to the app | 18:47 |
| tqtran | are we loading that in jasmine too? | 18:48 |
| tqtran | the app i mean | 18:48 |
| *** neelashah has joined #openstack-horizon | 18:48 | |
| tyr | we load that module for the framework tests | 18:48 |
| *** kcaj has joined #openstack-horizon | 18:49 | |
| tyr | Also a question if the default Ng interpolator can safely move to the app | 18:49 |
| tqtran | i believe so, the user isnt able to hit framework directly | 18:50 |
| tqtran | ok brb, gonna go pick up my massager, ;) | 18:51 |
| *** tqtran is now known as tqtran-afk | 18:51 | |
| *** Sukhdev has joined #openstack-horizon | 18:51 | |
| *** gpeers has quit IRC | 18:51 | |
| *** SimonChung has joined #openstack-horizon | 18:53 | |
| *** SimonChung1 has quit IRC | 18:53 | |
| robcresswell | ...and that was the last anyone ever saw of tqtran | 18:55 |
| *** gpeers has joined #openstack-horizon | 18:55 | |
| *** openstackgerrit has quit IRC | 18:56 | |
| *** sqchen has joined #openstack-horizon | 18:56 | |
| sqchen | ok | 18:56 |
| *** openstackgerrit has joined #openstack-horizon | 18:56 | |
| robcresswell | Are we still planning on using <server:port>/jasmine and also karma? | 18:56 |
| robcresswell | maintaining two test runners is a pain] | 18:57 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 18:57 |
| pamo | hey robcresswell and TravT could you take a look at my comment on valerie's changeset? https://review.openstack.org/#/c/200760/ | 18:58 |
| tyr | robcresswell: I find the jasmine runner useful for debugging, but there is a karma runner that look almost identical which would probably meet our needs and be a good transition | 18:58 |
| robcresswell | tyr: The alternating breakages are frustrating atm | 18:59 |
| tyr | I agree. I think we can eliminate the jasmine runner and focus on karma | 18:59 |
| robcresswell | pamo: Oh yeah, good call. | 19:01 |
| robcresswell | Legacy should just be left | 19:01 |
| *** dsneddon has quit IRC | 19:01 | |
| * robcresswell readies the -2 | 19:02 | |
| pamo | so.. both changesets should be abandonded? | 19:04 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 19:04 |
| pamo | abandoned* | 19:04 |
| *** jtriley has quit IRC | 19:05 | |
| pamo | oh just kidding, valerie just pointed out that my changeset includes changes in the horizon directory | 19:06 |
| pamo | any suggestions as to how to merge the two changesets? | 19:06 |
| pamo | or set one dependent on the other? | 19:06 |
| *** skylerberg has quit IRC | 19:07 | |
| *** jtriley has joined #openstack-horizon | 19:07 | |
| sqchen | robcresswell: tyr: jasmine can test code from outside the source tree via plugin mechanism, not sure about karma, | 19:09 |
| *** radez_g0n3 is now known as radez | 19:09 | |
| tyr | sqchen: Ooo...that's a very good point | 19:09 |
| *** kzaitsev_mb has quit IRC | 19:10 | |
| *** mpavlase has joined #openstack-horizon | 19:10 | |
| *** jtriley has quit IRC | 19:12 | |
| sqchen | also, when trying to fix brocken tests, I find jasmine is much useful. | 19:12 |
| *** tqtran-afk is now known as tqtran | 19:12 | |
| robcresswell | pamo: Just remove the legacy code and only alter the angular code | 19:13 |
| pamo | yea im going to update the changeset and then address the issues on valeries on hers | 19:14 |
| robcresswell | pamo: From a review standpoint, lots of tiny patchsets to fix one file is a little frustrating, as it just means the overhead of checking it all works on every single one | 19:14 |
| *** KunalGandhi has quit IRC | 19:15 | |
| robcresswell | pamo: Hence the -1s on very tiny fixes that leave eslint errors | 19:15 |
| pamo | Yea, I realize that now. Going to keep the changes related to the file valerie touched on that changeset since she renamed the file | 19:15 |
| *** notmars has quit IRC | 19:15 | |
| *** jmolo has joined #openstack-horizon | 19:17 | |
| ducttape_ | https://review.openstack.org/#/c/196740/10 I added tests david-lyle, I think it's ready for merge. is Akihiro online too? | 19:18 |
| *** ZZelle_ has joined #openstack-horizon | 19:21 | |
| *** kbrown has quit IRC | 19:21 | |
| openstackgerrit | Matthias Runge proposed openstack/horizon: Add reference to AUTH_USER_MODEL for tests https://review.openstack.org/201734 | 19:21 |
| *** dsneddon has joined #openstack-horizon | 19:21 | |
| mrunge | david-lyle, thank you for your test with d-o-a and horizon | 19:22 |
| mrunge | david-lyle, https://review.openstack.org/#/c/201734/ this should fix tests | 19:22 |
| *** gpeers has quit IRC | 19:23 | |
| *** jingjing_ren has quit IRC | 19:23 | |
| openstackgerrit | Pamela Ocampo proposed openstack/horizon: Addresses camel-case variables and exceeded max-length violations in Cloud Services, Launch-Instance, and Workflow dashboards https://review.openstack.org/200327 | 19:23 |
| openstackgerrit | Matthias Runge proposed openstack/horizon: Add reference to AUTH_USER_MODEL for tests https://review.openstack.org/201734 | 19:25 |
| *** gpeers has joined #openstack-horizon | 19:27 | |
| *** bpokorny_ has joined #openstack-horizon | 19:28 | |
| *** robcresswell has quit IRC | 19:28 | |
| *** petertr7 is now known as petertr7_away | 19:28 | |
| *** kbrown has joined #openstack-horizon | 19:28 | |
| lyanchih | Hi folks, would you please review our patch? https://review.openstack.org/#/c/199457/ | 19:30 |
| *** bpokorny has quit IRC | 19:30 | |
| *** petertr7_away is now known as petertr7 | 19:31 | |
| *** lyanchih has quit IRC | 19:32 | |
| sqchen | Hi tqtran: | 19:32 |
| *** Piet has quit IRC | 19:33 | |
| *** Piet has joined #openstack-horizon | 19:33 | |
| *** neelashah has quit IRC | 19:34 | |
| tqtran | sqchen: hi sean | 19:37 |
| *** mgarza_ has quit IRC | 19:37 | |
| *** pamo has quit IRC | 19:37 | |
| *** sqchen has quit IRC | 19:37 | |
| *** neelashah has joined #openstack-horizon | 19:38 | |
| *** mgarza_ has joined #openstack-horizon | 19:38 | |
| *** neelashah1 has joined #openstack-horizon | 19:39 | |
| *** sqchen has joined #openstack-horizon | 19:40 | |
| *** KunalGandhi has joined #openstack-horizon | 19:40 | |
| ducttape_ | looks good lyanchih | 19:40 |
| sqchen | tqtran: do you think we still want to have a Django command for auto-file-discovery? | 19:40 |
| sqchen | https://review.openstack.org/#/c/189415/ | 19:41 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon Themes should support and house easy Template Overrides https://review.openstack.org/188162 | 19:41 |
| *** mrunge has quit IRC | 19:41 | |
| *** pamo has joined #openstack-horizon | 19:41 | |
| tqtran | sqchen: probably not, since we're auto triggering it in setup.py | 19:41 |
| *** iamjarvo has quit IRC | 19:43 | |
| tqtran | my only complaint is that i have to re-run autodiscovery when i add new files, but its a minor issue | 19:43 |
| *** neelashah has quit IRC | 19:43 | |
| sqchen | thx, I am asking since we have an internal JIRA ticket for that. I am going to abandont the patch, sounds ok? | 19:43 |
| *** crobertsrh is now known as _crobertsrh | 19:43 | |
| tqtran | yup thats fine | 19:43 |
| sqchen | thx. | 19:43 |
| *** cbader has joined #openstack-horizon | 19:44 | |
| sqchen | Hi ducttape_: | 19:45 |
| ducttape_ | hey | 19:46 |
| sqchen | I am abandoning https://review.openstack.org/#/c/189415/ | 19:46 |
| ducttape_ | ok, no worries | 19:46 |
| sqchen | Is it ok to ignore comments in this patch? | 19:46 |
| sqchen | ok, thx. :) | 19:46 |
| ducttape_ | rule #1) it is always ok to ignore what I say. | 19:47 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon Themes should support and house easy Template Overrides https://review.openstack.org/188162 | 19:48 |
| *** mgarza_ has quit IRC | 19:49 | |
| *** cbader has quit IRC | 19:49 | |
| *** matt-borland has joined #openstack-horizon | 19:49 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon Themes should support and house easy Template Overrides https://review.openstack.org/188162 | 19:49 |
| *** jwy has joined #openstack-horizon | 19:49 | |
| *** ccard has joined #openstack-horizon | 19:49 | |
| *** cbader has joined #openstack-horizon | 19:49 | |
| *** mgarza_ has joined #openstack-horizon | 19:49 | |
| *** Drago has joined #openstack-horizon | 19:49 | |
| *** chlong-afk has joined #openstack-horizon | 19:49 | |
| *** skylerberg has joined #openstack-horizon | 19:50 | |
| *** iamjarvo has joined #openstack-horizon | 19:51 | |
| *** cbader has quit IRC | 19:51 | |
| *** ybathia has joined #openstack-horizon | 19:51 | |
| *** gpeers has quit IRC | 19:52 | |
| *** radez is now known as radez_g0n3 | 19:52 | |
| *** cbader has joined #openstack-horizon | 19:53 | |
| *** cbader has quit IRC | 19:53 | |
| *** jtriley has joined #openstack-horizon | 19:55 | |
| *** mgarza_ has quit IRC | 19:57 | |
| *** mgarza_ has joined #openstack-horizon | 19:57 | |
| *** cbader has joined #openstack-horizon | 19:57 | |
| *** kiran-r has quit IRC | 19:57 | |
| openstackgerrit | Pamela Ocampo proposed openstack/horizon: JSCS Cleanup - use DI in launch instance model https://review.openstack.org/200760 | 19:58 |
| *** gpeers has joined #openstack-horizon | 19:58 | |
| openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Add mox3 to test-requirements.txt https://review.openstack.org/201753 | 19:58 |
| *** neelashah has joined #openstack-horizon | 20:00 | |
| *** sqchen has quit IRC | 20:00 | |
| *** bpokorny_ has quit IRC | 20:01 | |
| *** neelashah1 has quit IRC | 20:01 | |
| *** cbader has quit IRC | 20:01 | |
| *** cbader has joined #openstack-horizon | 20:02 | |
| *** bpokorny has joined #openstack-horizon | 20:02 | |
| *** cbader has quit IRC | 20:04 | |
| *** cbader has joined #openstack-horizon | 20:05 | |
| *** cbader has left #openstack-horizon | 20:05 | |
| *** yamamoto has quit IRC | 20:05 | |
| *** gpeers has quit IRC | 20:06 | |
| *** cbader has joined #openstack-horizon | 20:06 | |
| *** jingjing_ren has joined #openstack-horizon | 20:07 | |
| *** iamjarvo has quit IRC | 20:08 | |
| *** gpeers has joined #openstack-horizon | 20:09 | |
| *** sqchen has joined #openstack-horizon | 20:11 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Add Angular Basic Page Header Directive https://review.openstack.org/201661 | 20:11 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Adding Angular Project Images Table https://review.openstack.org/200385 | 20:13 |
| *** kzaitsev_mb has joined #openstack-horizon | 20:14 | |
| *** annashen has quit IRC | 20:16 | |
| *** jingjing_ren has quit IRC | 20:17 | |
| *** iamjarvo has joined #openstack-horizon | 20:24 | |
| *** annashen has joined #openstack-horizon | 20:24 | |
| *** e0ne has quit IRC | 20:28 | |
| *** tqtran is now known as tqtran-afk | 20:29 | |
| *** linkedinyou has quit IRC | 20:30 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Add keystone version to REST API https://review.openstack.org/200261 | 20:32 |
| *** jmolo has quit IRC | 20:38 | |
| *** mgarza_ has quit IRC | 20:38 | |
| *** mgarza has joined #openstack-horizon | 20:38 | |
| *** mgarza has quit IRC | 20:42 | |
| *** oro_ has joined #openstack-horizon | 20:43 | |
| *** oro has joined #openstack-horizon | 20:43 | |
| *** gpeers has quit IRC | 20:44 | |
| *** bpokorny_ has joined #openstack-horizon | 20:45 | |
| *** gpeers has joined #openstack-horizon | 20:47 | |
| *** bpokorny has quit IRC | 20:48 | |
| openstackgerrit | David Lyle proposed openstack/horizon: Fix static file paths in heat topology view https://review.openstack.org/201769 | 20:49 |
| openstackgerrit | David Lyle proposed openstack/horizon: Fix static file paths in heat topology view https://review.openstack.org/201769 | 20:49 |
| *** mgagne_ is now known as mgagne | 20:50 | |
| *** jbell8 has quit IRC | 20:50 | |
| skylerberg | Is there a way to include static files in a plugin that exists outside of the horizon tree? | 20:51 |
| skylerberg | All of the plugins I have seen either don't have static files or they suggest installing them by copying them into openstack_dashboard. | 20:51 |
| *** Sukhdev has quit IRC | 20:51 | |
| *** raildo has quit IRC | 20:53 | |
| *** gpeers has quit IRC | 20:53 | |
| *** mpavlase has quit IRC | 20:55 | |
| *** gpeers has joined #openstack-horizon | 20:57 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - Fix ng-di errors on cloud-services https://review.openstack.org/198840 | 20:57 |
| *** geoffarnold has quit IRC | 20:58 | |
| *** geoffarnold has joined #openstack-horizon | 20:59 | |
| *** pamo has quit IRC | 20:59 | |
| *** Sukhdev has joined #openstack-horizon | 21:00 | |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: JSCS cleanup - style guide cleanup for table and basic-table https://review.openstack.org/190354 | 21:02 |
| *** geoffarnold has quit IRC | 21:04 | |
| *** geoffarnold has joined #openstack-horizon | 21:04 | |
| *** jingjing_ren has joined #openstack-horizon | 21:05 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - Use explict __globalTestHelpers__ in service-api specs https://review.openstack.org/199333 | 21:06 |
| *** neelashah has quit IRC | 21:06 | |
| *** yamamoto has joined #openstack-horizon | 21:06 | |
| *** jingjing_ren has quit IRC | 21:06 | |
| david-lyle | skylerberg: by adding your plugin via an file in the local/enabled dir, your app will be added and the static should be picked up | 21:06 |
| *** jingjing_ren has joined #openstack-horizon | 21:06 | |
| *** ericpeterson has joined #openstack-horizon | 21:06 | |
| *** ducttape_ has quit IRC | 21:09 | |
| skylerberg | david-lyle: To clarify what you are saying is if I add my_app.enabled to INSTALLED_APPS, then my static files inside my_app should be available, right? | 21:09 |
| *** neelashah has joined #openstack-horizon | 21:10 | |
| *** neelashah1 has joined #openstack-horizon | 21:11 | |
| *** yamamoto has quit IRC | 21:11 | |
| david-lyle | skylerberg: copying a file like https://github.com/openstack/horizon/blob/master/openstack_dashboard/enabled/_25_identity.py#L20 | 21:11 |
| david-lyle | to local/enabled for your plugin | 21:11 |
| david-lyle | the line I highlighted is adding your app to horizon | 21:11 |
| david-lyle | the important thing to not is that you module path in ADD_INSTALLED_APPS needs to be in the python path | 21:11 |
| *** petertr7 is now known as petertr7_away | 21:12 | |
| david-lyle | then yes the static file finders should find the static content | 21:12 |
| skylerberg | david-lyle: Thanks, this should give me something to work with. I also hadn't run into AUTO_DISCOVER_STATIC_FILES before. | 21:13 |
| openstackgerrit | Merged openstack/tuskar-ui: Add mox3 to test-requirements.txt https://review.openstack.org/201753 | 21:13 |
| *** julim has quit IRC | 21:13 | |
| *** sqchen has quit IRC | 21:14 | |
| *** neelashah has quit IRC | 21:14 | |
| *** julim has joined #openstack-horizon | 21:15 | |
| *** julim has quit IRC | 21:15 | |
| openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Remove Neutron init from post-deployment init https://review.openstack.org/201649 | 21:15 |
| *** lblanchard has quit IRC | 21:16 | |
| *** iamjarvo has quit IRC | 21:18 | |
| r1chardj0n3s | morning | 21:19 |
| *** jingjing_ren has quit IRC | 21:19 | |
| *** ducttape_ has joined #openstack-horizon | 21:22 | |
| *** clu_ has joined #openstack-horizon | 21:23 | |
| *** ericpeterson has quit IRC | 21:26 | |
| openstackgerrit | Merged openstack/horizon: delete failed when object id with special char. https://review.openstack.org/198281 | 21:29 |
| *** Piet has quit IRC | 21:30 | |
| *** iamjarvo has joined #openstack-horizon | 21:30 | |
| *** iamjarvo has quit IRC | 21:31 | |
| *** iamjarvo has joined #openstack-horizon | 21:32 | |
| *** notmars has joined #openstack-horizon | 21:32 | |
| *** iamjarvo has quit IRC | 21:32 | |
| rhagarty_ | david-lyle: Hey David - speaking of plug-ins, how are they usually made available to users? github? | 21:33 |
| david-lyle | rhagarty_: or pypi or both | 21:33 |
| rhagarty_ | is Murano ever used? or is that completely different? | 21:34 |
| TravT | tqtran: david-lyle: are you around? | 21:36 |
| r1chardj0n3s | wow, I'm just being a totes downer in this morning's reviews for TravT and sqchen ;) | 21:36 |
| *** sqchen has joined #openstack-horizon | 21:36 | |
| TravT | orly? | 21:36 |
| r1chardj0n3s | well, I was positive towards one of your patches (while being snarky to sean ;) but I totes ragged on your other patch there | 21:37 |
| *** dboik has quit IRC | 21:37 | |
| TravT | ahh, looking at it nwo | 21:37 |
| TravT | now | 21:37 |
| TravT | i think you need to look at that more in re-usability | 21:38 |
| TravT | give a title and / description as input attributes | 21:38 |
| TravT | and anybody who uses that in the future can get all their pages updated by simply changing the template | 21:38 |
| r1chardj0n3s | I think there needs to be a better, written somewhere, justification for creating All The Angular Directives | 21:38 |
| *** iamjarvo has joined #openstack-horizon | 21:38 | |
| r1chardj0n3s | for now, that patch has no justification for itself, is my point | 21:39 |
| TravT | well, we could use the django template that does similar | 21:39 |
| *** iamjarvo has quit IRC | 21:39 | |
| TravT | i think you are wrong though | 21:39 |
| r1chardj0n3s | you think it justifies itself? | 21:40 |
| TravT | lol. of course! | 21:40 |
| r1chardj0n3s | hmm | 21:41 |
| TravT | okay, so long story short is this. | 21:41 |
| r1chardj0n3s | seriously, it's 180 lines of change, with no reason | 21:41 |
| r1chardj0n3s | the commit just says what it does, with no purpose | 21:41 |
| TravT | there are django templates for reusing page headers. we could use that... | 21:41 |
| r1chardj0n3s | the linked bp is irrelevant | 21:41 |
| *** neelashah1 has quit IRC | 21:42 | |
| TravT | you don't want to have to run through your whole app updating the same snippets of html every time you want to change the page header. | 21:42 |
| r1chardj0n3s | for someone who hasn't been deeply involved in the development of angular-for-horizon, how are they to know why this patch exists? how are they to know when *they* should create new directives, or *not* create a directive? | 21:42 |
| *** gpeers has quit IRC | 21:42 | |
| r1chardj0n3s | this isn't something you're supposed to be telling *me* right now, this is something that needs to be documented as "our" (currently *your*) justification for making this change :) | 21:43 |
| r1chardj0n3s | style guide perhaps | 21:43 |
| TravT | if you need to re-use HTML snippets, thats we you'd use templates | 21:43 |
| TravT | doing an ng-include isn't for passing parameters through to put in those snippets | 21:44 |
| r1chardj0n3s | FTR: I'm not saying you are *wrong* in creating this patch! | 21:45 |
| r1chardj0n3s | it just doesn't justify its existence | 21:46 |
| TravT | Ok, so would you like some commit message comments on re-use or a totally new blueprint? | 21:48 |
| *** gpeers has joined #openstack-horizon | 21:48 | |
| *** iamjarvo has joined #openstack-horizon | 21:48 | |
| *** iamjarvo has quit IRC | 21:49 | |
| r1chardj0n3s | The commit message needs a change "We're addressing future tech debt here by breaking out the predicted common pattern of page header HTML into a single angular directive." | 21:50 |
| r1chardj0n3s | or something like that | 21:50 |
| TravT | That sounds wonderful to me. :) | 21:50 |
| *** Piet has joined #openstack-horizon | 21:51 | |
| *** geoffarnold has quit IRC | 21:51 | |
| *** pauloewerton has quit IRC | 21:52 | |
| TravT | r1chardj0n3s: i think it would be worthwhile putting up some guidance on creating directive like you said in the docs. i won't have time for that today, but would you mind doing that? | 21:52 |
| *** peristeri has quit IRC | 21:53 | |
| *** oro has quit IRC | 21:53 | |
| *** oro_ has quit IRC | 21:54 | |
| *** nlahouti has quit IRC | 21:54 | |
| *** SimonChung has quit IRC | 21:55 | |
| *** albertom has quit IRC | 21:56 | |
| *** iamjarvo has joined #openstack-horizon | 21:56 | |
| *** iamjarvo has quit IRC | 21:56 | |
| *** notmars has quit IRC | 21:58 | |
| *** jtriley has quit IRC | 21:59 | |
| *** SimonChung has joined #openstack-horizon | 21:59 | |
| r1chardj0n3s | TravT: I will if I get a chance; I've not had time to revisit rob's doc patch for a while tho | 21:59 |
| *** kbrown has quit IRC | 22:01 | |
| *** emw has quit IRC | 22:02 | |
| *** gpeers has quit IRC | 22:02 | |
| *** gpeers_ has joined #openstack-horizon | 22:02 | |
| *** albertom has joined #openstack-horizon | 22:03 | |
| *** tqtran-afk is now known as tqtran | 22:03 | |
| tqtran | r1chardj0n3s: btw, are you or neillc interested in adding translate filter for babel-angular? | 22:04 |
| tqtran | we only support directive atm, so the filter variant would be useful as well | 22:04 |
| r1chardj0n3s | tqtran: babel-angular? or angular-getttext? /cc neillc | 22:05 |
| tqtran | babel-angular | 22:05 |
| tqtran | angular-gettext already support it | 22:05 |
| r1chardj0n3s | tqtran: just so we're clear, you mean this? https://www.npmjs.com/package/babel-angular | 22:06 |
| tqtran | which reminds me, if you guys can help +1 this https://review.openstack.org/#/c/199349/ | 22:06 |
| r1chardj0n3s | 'cos I'm confused by the relevance | 22:06 |
| tqtran | r1chardj0n3s: no | 22:06 |
| tqtran | https://github.com/openstack/horizon/blob/master/horizon/utils/babel_extract_angular.py | 22:07 |
| *** nlahouti has joined #openstack-horizon | 22:07 | |
| *** nlahouti has quit IRC | 22:07 | |
| r1chardj0n3s | oh, so babel-extract-angular :) | 22:07 |
| r1chardj0n3s | names, they are important :) | 22:07 |
| *** nlahouti has joined #openstack-horizon | 22:08 | |
| r1chardj0n3s | that's neillc's baby, so I'll wait to see what he says (he's currently in Texas, so much closer to your timezone) | 22:09 |
| tqtran | ok cool, yeah let him know | 22:10 |
| *** kbrown has joined #openstack-horizon | 22:11 | |
| *** nlahouti1 has joined #openstack-horizon | 22:12 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Add Angular Basic Page Header Directive https://review.openstack.org/201661 | 22:12 |
| *** nlahouti has quit IRC | 22:15 | |
| openstackgerrit | Dan Nguyen proposed openstack/horizon: WIP - Project Admin support for Domains https://review.openstack.org/201277 | 22:16 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Adding Angular Project Images Table https://review.openstack.org/200385 | 22:17 |
| *** kristinebrown has joined #openstack-horizon | 22:18 | |
| *** jpomero has quit IRC | 22:18 | |
| TravT | tqtran: david-lyle: sqchen: r1chardj0n3s: if you have some time, would like to talk about the re-use pattern. | 22:19 |
| tqtran | sure thing | 22:19 |
| sqchen | sure | 22:19 |
| TravT | basically, regarding thai's comments in above patch | 22:19 |
| TravT | https://review.openstack.org/200385 | 22:19 |
| TravT | tqtran, i had it in projects, but in brief discussion with david-lyle, switched it to be in app-core, thinking that was what the result of that conversation was. | 22:20 |
| TravT | i actually kind of like it | 22:20 |
| *** kbrown has quit IRC | 22:20 | |
| r1chardj0n3s | yeah, that's kinda how I saw shared components going too | 22:21 |
| tqtran | it does make it kind of easier, i agree. but thats almost akin to moving the files in projects into horizon | 22:21 |
| TravT | it is a little less magical this way, rather than fixing up the auto-collector. | 22:21 |
| tqtran | and then admin wouldnt have a dependency on project because its part of the framework | 22:21 |
| r1chardj0n3s | but the files are moved *out* of projects, that's why I don't quite get your point | 22:22 |
| r1chardj0n3s | unless you're talking about those files that were still in the project directory? | 22:22 |
| r1chardj0n3s | the images module? | 22:22 |
| tqtran | so do we do this for panels that share code? if this is the case, a lot of things are going to end up in core instead of their own perspective folder | 22:22 |
| TravT | well, images are core, right? | 22:23 |
| tqtran | yes, images filters are originally from the images panel | 22:23 |
| r1chardj0n3s | tqtran: if that's appropriate, yes | 22:23 |
| tqtran | r1chardj0n3s: and for some of them, we'll only use it in 2 places | 22:23 |
| TravT | this goes back to the whole what's a core part of dashboard vs what's a contrib item | 22:23 |
| r1chardj0n3s | tqtran: yes, that would be true. | 22:24 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - style guide cleanup for Keypair step https://review.openstack.org/193658 | 22:24 |
| openstackgerrit | Merged openstack/tuskar-ui: Remove Neutron init from post-deployment init https://review.openstack.org/201649 | 22:24 |
| r1chardj0n3s | yeah, how would a couple of contrib panels share code? | 22:24 |
| r1chardj0n3s | er contrib dashboards | 22:24 |
| tqtran | they wont be able if we do it this way | 22:24 |
| tqtran | they'd have to basically add their stuff to trunk | 22:25 |
| TravT | those particular filters might be used elsewhere as well. | 22:25 |
| *** vijendar has quit IRC | 22:25 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 22:25 |
| TravT | for example murano uses images | 22:25 |
| tqtran | if we do it via the autodiscovery, then more than one contrib project can share code | 22:25 |
| krotscheck | r1chardj0n3s: lmk when you have a sec, want to brainstorm something. | 22:25 |
| TravT | tqtran, your idea is that we put everything in a project panel. and enable autodiscover for specific shareable things in specific panels, right? | 22:26 |
| r1chardj0n3s | tqtran, TravT I'm still a little hazy on exactly how contrib is going to work anyway | 22:27 |
| tqtran | TravT: if the panel is enabled, the js is auto included. if the panel is disabled but we need the source, have a flag to turn autodiscovery on for it | 22:27 |
| r1chardj0n3s | TravT, tqtran this is awesome, we're going to create a packaging dependency system!!! | 22:28 |
| * TravT looks for exit | 22:28 | |
| tqtran | lol if you put it that way..... | 22:28 |
| r1chardj0n3s | nu-uh, no escape for you!!!!!1 | 22:28 |
| lifeless | r1chardj0n3s: fortunately, you've been around this before :) | 22:28 |
| r1chardj0n3s | noooooooooo | 22:29 |
| lifeless | r1chardj0n3s: thats more like it | 22:29 |
| TravT | r1chardj0n3s --> pigeon-holed | 22:29 |
| r1chardj0n3s | so, let's not over-complicate things eh? | 22:29 |
| lifeless | r1chardj0n3s: I was going to step outside and listen for the screams | 22:29 |
| * r1chardj0n3s sighs | 22:29 | |
| lifeless | TravT: nope, teased. Very different :> | 22:29 |
| tqtran | ok, fine leave it in core/app | 22:30 |
| TravT | lol, we rather like having r1chardj0n3s around here... at least a good number of us do. | 22:30 |
| r1chardj0n3s | so we have enabled, dashboard, core, contrib and now, potentially, "shared"? | 22:30 |
| tqtran | well core is shared | 22:30 |
| r1chardj0n3s | and we're still trying to figure out how those all interact, and we're not even sure we know how contrib works | 22:30 |
| krotscheck | Tee hee | 22:30 |
| r1chardj0n3s | yeah, but "shared" is a "contrib" version. maybe it's just contrib | 22:31 |
| TravT | core seems simpler at the moment. | 22:31 |
| *** jtriley has joined #openstack-horizon | 22:31 | |
| r1chardj0n3s | for *this* case, yes, how about we leave it in core | 22:31 |
| r1chardj0n3s | and worry about contribs depending on each other *if that happens* | 22:31 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - style guide cleanup for Keypair step https://review.openstack.org/193658 | 22:31 |
| *** gpeers_ has quit IRC | 22:31 | |
| r1chardj0n3s | krotscheck: I have a moment now, I think :) | 22:32 |
| TravT | ok, i'll add in sqchen's ngdoc comments. | 22:32 |
| TravT | but tqtran, will you be around in a few minutes to talk about some next steps / directives | 22:32 |
| tqtran | yeah i'll be around | 22:33 |
| *** SimonChung has quit IRC | 22:33 | |
| *** SimonChung1 has joined #openstack-horizon | 22:33 | |
| TravT | ok, gimme just a couple and i'll ping you | 22:33 |
| *** sqchen has left #openstack-horizon | 22:33 | |
| tqtran | btw, you dont need translate = "yes", just having it there is sufficient | 22:33 |
| *** sqchen has joined #openstack-horizon | 22:33 | |
| TravT | tqtran: i figured as much | 22:33 |
| *** SimonChung1 has quit IRC | 22:33 | |
| *** SimonChung has joined #openstack-horizon | 22:33 | |
| krotscheck | r1chardj0n3s: So, after a lovely conversation this afternoon with hurgleburgler, I discovered a bunch of articles that say npm is moving towards supplanting bower. | 22:33 |
| TravT | my editor was autocompleting that for me | 22:34 |
| krotscheck | And, well, yay not having to maintain two package managers. | 22:34 |
| tqtran | haha | 22:34 |
| *** SimonChung has quit IRC | 22:34 | |
| *** SimonChung has joined #openstack-horizon | 22:34 | |
| r1chardj0n3s | krotscheck: oh, that's interesting | 22:34 |
| *** SimonChung has quit IRC | 22:34 | |
| *** SimonChung1 has joined #openstack-horizon | 22:34 | |
| krotscheck | r1chardj0n3s: My question for you is: have you run into any projects that do that? Thick client JS, no backend, only using npm to resolve packages? | 22:34 |
| tqtran | oo new word, supplanting | 22:34 |
| krotscheck | r1chardj0n3s: And if not, what would that look like? | 22:35 |
| krotscheck | reference: http://blog.npmjs.org/post/101775448305/npm-and-front-end-packaging | 22:35 |
| r1chardj0n3s | nope | 22:35 |
| krotscheck | It all seems to be "NPM 3" things. | 22:35 |
| r1chardj0n3s | totally news to me, I'm afraid | 22:35 |
| *** darrenc is now known as darrenc_afk | 22:35 | |
| krotscheck | Aight. | 22:35 |
| r1chardj0n3s | so yeah, on one hand, a good thing | 22:35 |
| *** jtriley has quit IRC | 22:35 | |
| r1chardj0n3s | and maybe npm has better package pin guarantees? | 22:35 |
| r1chardj0n3s | (I don't know, I've neved looked) | 22:35 |
| r1chardj0n3s | so maybe that can solve the issues we run into when discussing bower and its lack of such things | 22:36 |
| krotscheck | r1chardj0n3s: Well, they already have tag signing things. | 22:36 |
| r1chardj0n3s | BUT | 22:36 |
| r1chardj0n3s | it does mean npm | 22:36 |
| r1chardj0n3s | and there's a lot of resistance to npm | 22:36 |
| krotscheck | r1chardj0n3s: Well, it's better than npm _and_ bower. | 22:36 |
| tqtran | now you only have 1 battle to fight | 22:36 |
| r1chardj0n3s | wellll. we were aiming for a bright future of bower without npm | 22:36 |
| krotscheck | Problem reduction by 50%? That's impossible! [/Dragonball] | 22:36 |
| *** lhcheng has joined #openstack-horizon | 22:37 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/tuskar-ui: Updated from global requirements https://review.openstack.org/198460 | 22:37 |
| r1chardj0n3s | ("we" being a select few of us, making little actual political headway) | 22:37 |
| krotscheck | r1chardj0n3s: Well, at least we have a debian and centos native package for both npm and nodejs | 22:37 |
| r1chardj0n3s | lol, how long until they have npm3? or whatever would be needed to support this? | 22:38 |
| krotscheck | Meaning that suddenly the environment looks a lot like python and pip. | 22:38 |
| TravT | krotscheck: side note. can you point me to info on enabling CORS. I want to add that to searchlight. | 22:38 |
| krotscheck | TravT: Dude. Yes. Sec. | 22:38 |
| TravT | i mean via whatever work you'd done recently on that in oslo | 22:38 |
| r1chardj0n3s | krotscheck: and we know how much the packagers *love* pip. oh yeah. they love it so much, they do everything they can to break it | 22:39 |
| krotscheck | TravT: http://docs.openstack.org/developer/oslo.middleware/cors.html -> use version https://review.openstack.org/#/c/199761/ (actually, 2.5.0 is easier to debug) | 22:39 |
| *** gpeers has joined #openstack-horizon | 22:39 | |
| krotscheck | r1chardj0n3s: Yes, but they're dealing with ti. | 22:39 |
| TravT | krotscheck, thanks! | 22:39 |
| krotscheck | TravT: Example for ironic https://review.openstack.org/#/c/199769/ | 22:39 |
| r1chardj0n3s | krotscheck: well, hopefully this npm-replacing-bower news can help. | 22:39 |
| krotscheck | TravT: I'm working on nova right now. | 22:39 |
| krotscheck | r1chardj0n3s: Well, it gets rid of the whole "Bower doesn't actually host the code" problem. | 22:40 |
| TravT | cool. i'll probably just open BP today and if nobody has it done by the time i'm back (monday), i'll do it. | 22:40 |
| r1chardj0n3s | I have to run now (need to do a chemist run to restock drugs), but I'll be back in about an hour if that's at all useful :) | 22:40 |
| r1chardj0n3s | krotscheck: yep | 22:40 |
| krotscheck | r1chardj0n3s: I'll try to be around | 22:41 |
| krotscheck | TravT: There's an OpenStack x-project spec, if you need ammo, all approved and stuff. | 22:41 |
| krotscheck | TravT: specs.openstack.org/openstack/openstack-specs/specs/cors-support.html | 22:41 |
| TravT | :) I don't think I'll need much ammo, but I'll take it. | 22:42 |
| *** sqchen has left #openstack-horizon | 22:43 | |
| *** sqchen has joined #openstack-horizon | 22:43 | |
| tyr | tqtran: TravT: Here is the fix for the Jasmine redirect issue on main --> https://review.openstack.org/#/c/201802 | 22:45 |
| *** nlahouti1 has quit IRC | 22:45 | |
| *** gpeers has quit IRC | 22:47 | |
| *** jtriley has joined #openstack-horizon | 22:48 | |
| *** bpokorny_ has quit IRC | 22:49 | |
| *** bpokorny has joined #openstack-horizon | 22:49 | |
| krotscheck | r1chardj0n3s: Way better overview of where they are right now -> https://github.com/npm/npm/wiki/Roadmap | 22:52 |
| *** gpeers has joined #openstack-horizon | 22:54 | |
| *** jmolo has joined #openstack-horizon | 22:56 | |
| *** darrenc_afk is now known as darrenc | 22:56 | |
| *** doug-fish has left #openstack-horizon | 22:58 | |
| *** Sukhdev has quit IRC | 22:59 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Adding Angular Project Images Table https://review.openstack.org/200385 | 23:01 |
| *** jingjing_ren has joined #openstack-horizon | 23:02 | |
| *** absubram has quit IRC | 23:04 | |
| krotscheck | clu_: When you get a chance, could you register with the npm registry? I'd like to make you an owner on eslint-config-openstack, so you can push releases. (Until the infra job is up and running) | 23:06 |
| krotscheck | clu_: Unless you don't want to. In which case, more power for me! | 23:06 |
| clu_ | krotscheck: lol, sure thing | 23:07 |
| *** annashen has quit IRC | 23:09 | |
| tqtran | tyr: looks good, thanks! | 23:11 |
| krotscheck | clu_: Thanks! Lmk your username once your'e done | 23:12 |
| clu_ | krotscheck: it's clu :) | 23:13 |
| clu_ | no underscore | 23:13 |
| krotscheck | clu_: Done! | 23:14 |
| *** ongk has quit IRC | 23:14 | |
| openstackgerrit | Dan Siwiec proposed openstack/horizon: Fix redirect during jasmine tests https://review.openstack.org/201802 | 23:17 |
| *** jbell8 has joined #openstack-horizon | 23:18 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Adding Angular Project Images Table https://review.openstack.org/200385 | 23:19 |
| tqtran | tyr, sqchen: did one of you put up the ui.bootstrap patch? | 23:23 |
| tqtran | i'm running into it now :P whats the progress on that? | 23:24 |
| tyr | not i | 23:24 |
| sqchen | which one? can you give me a link? | 23:24 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - Fix ng-di errors on cloud-services https://review.openstack.org/198840 | 23:24 |
| sqchen | tqtran: tyr: this one? https://review.openstack.org/#/c/199319/ | 23:26 |
| tqtran | sqchen: yes thats the patch :) | 23:27 |
| *** ducttape_ has quit IRC | 23:27 | |
| tqtran | ok nvm, seems like there are issues | 23:27 |
| tqtran | i'll just include ui.bootstrap for now | 23:27 |
| sqchen | need to look into _conf.htm base.html and script.html, but I thought it was a low-priority | 23:28 |
| sqchen | ok | 23:28 |
| tqtran | it is low | 23:28 |
| tqtran | not a big deal, but would have been nice if it were fixed | 23:29 |
| sqchen | sure. | 23:29 |
| *** jtriley has quit IRC | 23:29 | |
| tqtran | i'll star it, maybe we can come in during rc | 23:29 |
| *** matt-borland has quit IRC | 23:29 | |
| *** ZZelle_ has quit IRC | 23:30 | |
| *** gpeers has quit IRC | 23:30 | |
| *** bitblt has joined #openstack-horizon | 23:31 | |
| sqchen | yep. | 23:32 |
| tyr | tqtran: TravT: Oops. The jasmine redirect change was overwritten a different version after the +2. His version is fine too. When you get a chance... | 23:32 |
| *** nlahouti has joined #openstack-horizon | 23:32 | |
| *** kristinebrown has quit IRC | 23:34 | |
| TravT | tyr: fix looks better, but the comments inline were lost. | 23:37 |
| TravT | can you add something back in comments | 23:37 |
| *** kristinebrown has joined #openstack-horizon | 23:37 | |
| *** ^Gal^_ has quit IRC | 23:38 | |
| *** kristinebrown has quit IRC | 23:39 | |
| *** alexpilotti has quit IRC | 23:40 | |
| *** nlahouti has quit IRC | 23:40 | |
| *** nlahouti has joined #openstack-horizon | 23:41 | |
| *** ^Gal^ has joined #openstack-horizon | 23:41 | |
| r1chardj0n3s | . | 23:41 |
| *** skylerberg has quit IRC | 23:46 | |
| openstackgerrit | Dan Siwiec proposed openstack/horizon: Fix redirect during jasmine tests https://review.openstack.org/201802 | 23:47 |
| *** jtriley has joined #openstack-horizon | 23:48 | |
| *** geoffarnold has joined #openstack-horizon | 23:50 | |
| *** jtriley has quit IRC | 23:53 | |
| *** nlahouti has quit IRC | 23:54 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
