| tqtran | i think all your patch needs is a simple tag check for <translate> and updated tests | 00:00 |
|---|---|---|
| tqtran | and it should be good to go | 00:00 |
| tqtran | if you are busy, i can even do it | 00:00 |
| tqtran | currently blocking https://review.openstack.org/#/c/197373/ | 00:00 |
| tqtran | which is my next piece, so anything i can do to help, let me know | 00:01 |
| *** sqchen has joined #openstack-horizon | 00:01 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: XStatic Libraries should auto discover https://review.openstack.org/195371 | 00:03 |
| *** tjones1 has quit IRC | 00:04 | |
| *** jtriley has quit IRC | 00:06 | |
| *** garthb_ has quit IRC | 00:07 | |
| *** alexvictorchan has quit IRC | 00:12 | |
| Piet | First SWAG at Create Project https://openstack.invisionapp.com/d/main/#/projects/4007880 | 00:13 |
| neillc | tqtran: back from standup. | 00:17 |
| neillc | I'll add the tag now | 00:17 |
| *** mwhagedorn has joined #openstack-horizon | 00:18 | |
| tqtran | cool | 00:20 |
| tqtran | also for tests, i was thinking of something like http://paste.openstack.org/show/333723/ | 00:21 |
| tqtran | this way, you dont have to rewrite them for the <translate> tag | 00:21 |
| tqtran | lastly, i think you can combine it into one if statement: f (tag == 'translate' or (attrs and 'translate' in [attr[0] for attr in attrs])): | 00:22 |
| tqtran | or (tag == 'translate' or hasAttr('translate')) will also work | 00:23 |
| tqtran | for readability | 00:23 |
| tqtran | actually hasAttr is a native func and taken, opsies | 00:23 |
| neillc | tqtran: snap - that's how I had written the if test :) Will look at the test suggestion in a sec | 00:24 |
| *** sqchen has quit IRC | 00:26 | |
| *** andrewbogott is now known as andrewbogott_afk | 00:26 | |
| *** mwhagedorn has quit IRC | 00:27 | |
| tqtran | david-lyle, TravT, clu_: when you guys have time, https://review.openstack.org/#/c/196905/ is ready for your blessing | 00:28 |
| *** yingjun has joined #openstack-horizon | 00:29 | |
| tqtran | clu_: i think the slug is use as the url | 00:29 |
| clu_ | tqtran: k | 00:29 |
| tqtran | is there a reason why we want it as ng_user as opoose to nguser? | 00:29 |
| tqtran | a note on that while we're talking about it, its a temporary name right now | 00:30 |
| *** alexvictorchan has joined #openstack-horizon | 00:30 | |
| tqtran | so it really doesn't matter too much what we name the slug | 00:30 |
| *** albertom has quit IRC | 00:32 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding identity ng-users panel https://review.openstack.org/196905 | 00:35 |
| tqtran | ops sorry, i missed something :P | 00:35 |
| david-lyle | tqtran: you just fixed my comment | 00:37 |
| david-lyle | :P | 00:37 |
| tqtran | lol | 00:39 |
| *** albertom has joined #openstack-horizon | 00:39 | |
| tqtran | i hate it when that happens | 00:39 |
| openstackgerrit | Andrew Bogott proposed openstack/horizon: Exclude images with the 'deprecated' property from the image pick-list. https://review.openstack.org/197306 | 00:39 |
| tqtran | feel free to leave it if you must | 00:39 |
| tqtran | lol | 00:39 |
| david-lyle | no, glad you found it | 00:39 |
| david-lyle | I'm not worried about tallying reviews | 00:40 |
| david-lyle | half of my feedback is verbal | 00:40 |
| david-lyle | or out of gerrit | 00:40 |
| tqtran | its ok, you'll make it for it come feature freeze :D | 00:40 |
| *** Sukhdev has quit IRC | 00:45 | |
| *** clu_ has quit IRC | 00:51 | |
| *** annashen has joined #openstack-horizon | 00:53 | |
| *** jtriley has joined #openstack-horizon | 00:57 | |
| *** alexvictorchan has quit IRC | 00:58 | |
| *** annashen has quit IRC | 00:58 | |
| openstackgerrit | Merged openstack/horizon: Searchbar directive should be prefix with hz https://review.openstack.org/196957 | 00:58 |
| tqtran | have a good one everyone, taking off | 01:01 |
| *** tqtran has quit IRC | 01:01 | |
| openstackgerrit | Merged openstack/horizon: Error message for invalid job binary details page https://review.openstack.org/196999 | 01:01 |
| openstackgerrit | Merged openstack/horizon: Redirect URL for invalid data source details page https://review.openstack.org/197011 | 01:02 |
| *** albertom has quit IRC | 01:02 | |
| *** jasondotstar has joined #openstack-horizon | 01:02 | |
| *** sqchen has joined #openstack-horizon | 01:07 | |
| *** albertom has joined #openstack-horizon | 01:09 | |
| *** andrewbogott_afk is now known as andrewbogott | 01:11 | |
| *** andrewbogott is now known as andrewbogott_afk | 01:12 | |
| *** sqchen has quit IRC | 01:15 | |
| openstackgerrit | David Lyle proposed openstack/horizon: Moving Sahara to contrib https://review.openstack.org/197363 | 01:15 |
| openstackgerrit | Neill Cox proposed openstack/horizon: Angular translation via babel (singular only) https://review.openstack.org/192035 | 01:16 |
| *** stevemar has joined #openstack-horizon | 01:21 | |
| *** stevemar has quit IRC | 01:24 | |
| *** Piet has quit IRC | 01:26 | |
| *** jasondotstar has quit IRC | 01:27 | |
| *** Piet has joined #openstack-horizon | 01:30 | |
| *** wuhg has joined #openstack-horizon | 01:52 | |
| openstackgerrit | Merged openstack/horizon: Apply auto-file-discovery to plugins https://review.openstack.org/191592 | 01:52 |
| *** annashen has joined #openstack-horizon | 01:54 | |
| *** annashen has quit IRC | 01:58 | |
| *** jwy has quit IRC | 02:04 | |
| *** piyanai has joined #openstack-horizon | 02:12 | |
| openstackgerrit | Merged openstack/horizon: Remove first newline from generated OpenSTack RC file https://review.openstack.org/188376 | 02:16 |
| *** ducttape_ has quit IRC | 02:18 | |
| *** clu_ has joined #openstack-horizon | 02:22 | |
| *** clu_ has quit IRC | 02:24 | |
| *** jtriley has quit IRC | 02:24 | |
| *** yingjun has quit IRC | 02:29 | |
| *** yingjun has joined #openstack-horizon | 02:32 | |
| *** lhcheng has quit IRC | 02:43 | |
| *** yamamoto has joined #openstack-horizon | 02:45 | |
| *** darrenc is now known as darrenc_afk | 02:45 | |
| *** stevemar has joined #openstack-horizon | 02:47 | |
| *** annashen has joined #openstack-horizon | 02:55 | |
| *** jtriley has joined #openstack-horizon | 02:55 | |
| *** Drago1 has quit IRC | 02:57 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: XStatic Libraries should auto discover https://review.openstack.org/195371 | 02:58 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon Themes should support and house easy Template Overrides https://review.openstack.org/188162 | 02:58 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Themeing Mechanism now supports 3rd party themes https://review.openstack.org/197821 | 02:58 |
| *** annashen has quit IRC | 02:59 | |
| *** sayan has joined #openstack-horizon | 03:02 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Themeing Mechanism now supports 3rd party themes https://review.openstack.org/197821 | 03:03 |
| *** sqchen has joined #openstack-horizon | 03:12 | |
| *** piyanai has quit IRC | 03:17 | |
| *** jingjing_ren has quit IRC | 03:19 | |
| *** jtriley has quit IRC | 03:24 | |
| *** tjones1 has joined #openstack-horizon | 03:24 | |
| *** tjones1 has left #openstack-horizon | 03:28 | |
| *** sqchen has quit IRC | 03:30 | |
| *** alexvictorchan has joined #openstack-horizon | 03:35 | |
| *** sqchen has joined #openstack-horizon | 03:44 | |
| openstackgerrit | Dan Nguyen proposed openstack/horizon: Makes policy.check aware of domain scoped token https://review.openstack.org/196068 | 03:45 |
| *** yingjun has quit IRC | 03:52 | |
| *** annashen has joined #openstack-horizon | 03:56 | |
| *** jbell8 has quit IRC | 03:58 | |
| *** annashen has quit IRC | 04:00 | |
| *** sqchen has quit IRC | 04:04 | |
| *** kiran-r has joined #openstack-horizon | 04:09 | |
| *** alexvictorchan has quit IRC | 04:15 | |
| *** hurgleburgler1 has joined #openstack-horizon | 04:19 | |
| *** hurgleburgler has quit IRC | 04:19 | |
| *** alexvictorchan has joined #openstack-horizon | 04:20 | |
| *** masco_ has joined #openstack-horizon | 04:21 | |
| *** alexvictorchan has quit IRC | 04:23 | |
| *** lucas__ has joined #openstack-horizon | 04:23 | |
| *** lucas__ has quit IRC | 04:28 | |
| *** vgridnev has joined #openstack-horizon | 04:33 | |
| *** absubram has quit IRC | 04:35 | |
| *** sqchen has joined #openstack-horizon | 04:37 | |
| *** early has quit IRC | 04:55 | |
| *** yamamoto has quit IRC | 04:55 | |
| *** yingjun has joined #openstack-horizon | 04:56 | |
| *** annashen has joined #openstack-horizon | 04:56 | |
| *** yamamoto has joined #openstack-horizon | 04:57 | |
| *** darrenc_afk is now known as darrenc | 05:00 | |
| *** amit213 has joined #openstack-horizon | 05:00 | |
| *** annashen has quit IRC | 05:01 | |
| *** early has joined #openstack-horizon | 05:02 | |
| *** jingjing_ren has joined #openstack-horizon | 05:03 | |
| *** jingjing_ren has quit IRC | 05:07 | |
| *** kzaitsev_mb has joined #openstack-horizon | 05:07 | |
| *** kzaitsev_mb has quit IRC | 05:16 | |
| *** sqchen has quit IRC | 05:17 | |
| openstackgerrit | lawrancejing proposed openstack/horizon: Populate volume/volume_snapshot status without current status https://review.openstack.org/191570 | 05:20 |
| *** yamamoto has quit IRC | 05:22 | |
| *** yamamoto has joined #openstack-horizon | 05:27 | |
| *** yamamoto has quit IRC | 05:36 | |
| *** yamamoto has joined #openstack-horizon | 05:37 | |
| *** yamamoto has quit IRC | 05:39 | |
| *** drupalmonkey has quit IRC | 05:39 | |
| *** jtomasek has joined #openstack-horizon | 05:40 | |
| *** sqchen has joined #openstack-horizon | 05:42 | |
| *** stevemar has quit IRC | 05:42 | |
| *** yamamoto has joined #openstack-horizon | 05:42 | |
| *** Longgeek has joined #openstack-horizon | 05:52 | |
| *** jtomasek has quit IRC | 05:54 | |
| *** annashen has joined #openstack-horizon | 05:57 | |
| *** hurgleburgler1 has quit IRC | 06:01 | |
| *** mrunge has joined #openstack-horizon | 06:02 | |
| *** annashen has quit IRC | 06:02 | |
| *** jtomasek has joined #openstack-horizon | 06:05 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/197847 | 06:06 |
| *** sqchen has quit IRC | 06:08 | |
| *** sqchen has joined #openstack-horizon | 06:09 | |
| *** mohankumar has quit IRC | 06:13 | |
| *** lucas__ has joined #openstack-horizon | 06:35 | |
| *** KingKhan has joined #openstack-horizon | 06:37 | |
| KingKhan | hi I was trying to install kilo stable version of horizon | 06:39 |
| *** lucas__ has quit IRC | 06:39 | |
| KingKhan | I get this error http://paste.openstack.org/show/334735/ repeatedely | 06:40 |
| KingKhan | however i was able to install the mastre branch without any issue | 06:40 |
| *** sqchen has quit IRC | 06:40 | |
| KingKhan | can someone pls help?? | 06:41 |
| *** sqchen has joined #openstack-horizon | 06:41 | |
| KingKhan | I noticed this change https://review.openstack.org/#/c/178504/10/requirements.txt and upgraded the highlited packages also still i face the same issue | 06:42 |
| *** stevemar has joined #openstack-horizon | 06:42 | |
| *** belmoreira has joined #openstack-horizon | 06:44 | |
| *** stevemar has quit IRC | 06:46 | |
| *** sqchen has quit IRC | 06:47 | |
| openstackgerrit | Merged openstack/horizon: Adding identity ng-users panel https://review.openstack.org/196905 | 06:47 |
| *** belmoreira has quit IRC | 06:47 | |
| *** sqchen has joined #openstack-horizon | 06:54 | |
| *** yingjun has quit IRC | 06:55 | |
| *** jtomasek has quit IRC | 06:58 | |
| *** annashen has joined #openstack-horizon | 06:58 | |
| *** belmoreira has joined #openstack-horizon | 06:58 | |
| *** belmoreira has quit IRC | 06:58 | |
| *** belmoreira has joined #openstack-horizon | 06:59 | |
| *** nlahouti has joined #openstack-horizon | 07:03 | |
| *** annashen has quit IRC | 07:03 | |
| *** _kiran_ has joined #openstack-horizon | 07:03 | |
| *** kiranr has joined #openstack-horizon | 07:04 | |
| *** _kiran_ has quit IRC | 07:05 | |
| openstackgerrit | Merged openstack/horizon: Error message for invalid job details page https://review.openstack.org/196988 | 07:05 |
| *** Gal has joined #openstack-horizon | 07:06 | |
| *** nlahouti has quit IRC | 07:07 | |
| *** jtomasek has joined #openstack-horizon | 07:07 | |
| *** kiran-r has quit IRC | 07:07 | |
| *** kiran-r has joined #openstack-horizon | 07:08 | |
| *** kiranr has quit IRC | 07:08 | |
| *** fifieldt has quit IRC | 07:09 | |
| *** kiran-r has quit IRC | 07:13 | |
| *** mpavlase has joined #openstack-horizon | 07:15 | |
| *** mpavlase has quit IRC | 07:16 | |
| *** mpavlase has joined #openstack-horizon | 07:16 | |
| *** MaxV has joined #openstack-horizon | 07:18 | |
| *** aix has joined #openstack-horizon | 07:24 | |
| *** jtomasek has quit IRC | 07:30 | |
| *** jcoufal has joined #openstack-horizon | 07:30 | |
| *** vgridnev has quit IRC | 07:33 | |
| *** nlahouti has joined #openstack-horizon | 07:33 | |
| *** zz_ttrifonov is now known as ttrifonov | 07:35 | |
| *** yingjun has joined #openstack-horizon | 07:38 | |
| *** nlahouti has quit IRC | 07:42 | |
| *** kzaitsev_mb has joined #openstack-horizon | 07:45 | |
| *** kiran-r has joined #openstack-horizon | 07:49 | |
| *** kiran-r has quit IRC | 07:49 | |
| *** stevemar has joined #openstack-horizon | 07:49 | |
| *** kiran-r has joined #openstack-horizon | 07:49 | |
| *** stevemar has quit IRC | 07:53 | |
| *** _kiran_ has joined #openstack-horizon | 07:53 | |
| *** ygbo has joined #openstack-horizon | 07:55 | |
| *** kiran-r has quit IRC | 07:57 | |
| *** lhcheng has joined #openstack-horizon | 07:57 | |
| *** bluex-pl has joined #openstack-horizon | 07:57 | |
| *** bluex-pl has quit IRC | 07:58 | |
| *** bluex-pl has joined #openstack-horizon | 07:58 | |
| *** annashen has joined #openstack-horizon | 07:59 | |
| *** _kiran_ is now known as kiran-r | 08:03 | |
| *** annashen has quit IRC | 08:04 | |
| *** nlahouti has joined #openstack-horizon | 08:09 | |
| *** jcoufal_ has joined #openstack-horizon | 08:09 | |
| *** jcoufal_ has quit IRC | 08:09 | |
| *** Ala has joined #openstack-horizon | 08:09 | |
| *** dboik has joined #openstack-horizon | 08:11 | |
| *** yamamoto has quit IRC | 08:11 | |
| *** dboik_ has quit IRC | 08:12 | |
| *** nlahouti has quit IRC | 08:13 | |
| *** rwsu has quit IRC | 08:13 | |
| *** yingjun has quit IRC | 08:15 | |
| *** yamamoto has joined #openstack-horizon | 08:15 | |
| *** rwsu has joined #openstack-horizon | 08:16 | |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Angular metadata update modal https://review.openstack.org/184274 | 08:17 |
| *** sqchen has quit IRC | 08:17 | |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Angularize metadata update modals https://review.openstack.org/184275 | 08:18 |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Allow to edit image metadata from project view https://review.openstack.org/184280 | 08:19 |
| *** yingjun has joined #openstack-horizon | 08:19 | |
| *** jamielennox is now known as jamielennox|away | 08:20 | |
| *** kzaitsev_mb has quit IRC | 08:22 | |
| *** kodoku has joined #openstack-horizon | 08:23 | |
| kodoku | doug-fish robcresswell Hi | 08:23 |
| kodoku | doug-fish robcresswell So I test horizon KILO with juno env, good works, except with Heat | 08:23 |
| mrunge | kodoku, doug-fish is located in the US. I would expect him here in a few hours | 08:26 |
| kodoku | mrunge ok ;) | 08:27 |
| kodoku | mrunge lock instance need nova kilo ? | 08:32 |
| kodoku | mrunge And the function for shutoff multiple instance is not a horizon function ? | 08:37 |
| kodoku | Because I have issue when I try to shutoff two instances. First is shutoff but after I have big Trace on horizon | 08:37 |
| *** JeanBriceCombebi has joined #openstack-horizon | 08:38 | |
| *** jamielennox|away is now known as jamielennox | 08:41 | |
| *** mohankumar has joined #openstack-horizon | 08:46 | |
| *** amotoki has quit IRC | 08:46 | |
| *** sayan has quit IRC | 08:49 | |
| *** aix has quit IRC | 08:50 | |
| *** Longgeek has quit IRC | 08:52 | |
| *** Longgeek has joined #openstack-horizon | 08:53 | |
| *** romainh has joined #openstack-horizon | 08:59 | |
| *** annashen has joined #openstack-horizon | 09:00 | |
| *** annashen has quit IRC | 09:04 | |
| *** nlahouti has joined #openstack-horizon | 09:09 | |
| *** MaxV has quit IRC | 09:10 | |
| *** MaxV has joined #openstack-horizon | 09:11 | |
| *** nlahouti has quit IRC | 09:13 | |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Fix broken header dropdowns https://review.openstack.org/165893 | 09:15 |
| *** openstackgerrit has quit IRC | 09:19 | |
| *** openstackgerrit has joined #openstack-horizon | 09:20 | |
| *** jasondotstar has joined #openstack-horizon | 09:22 | |
| *** bradjones has quit IRC | 09:33 | |
| *** aix has joined #openstack-horizon | 09:34 | |
| *** jtomasek has joined #openstack-horizon | 09:34 | |
| *** yingjun has quit IRC | 09:35 | |
| *** sayan has joined #openstack-horizon | 09:35 | |
| *** bradjones has joined #openstack-horizon | 09:35 | |
| *** bradjones has quit IRC | 09:35 | |
| *** bradjones has joined #openstack-horizon | 09:35 | |
| *** e0ne has joined #openstack-horizon | 09:35 | |
| openstackgerrit | Vitaly Gridnev proposed openstack/horizon: [Sahara] Move node processes selection to own tab https://review.openstack.org/197018 | 09:36 |
| *** KingKhan has quit IRC | 09:37 | |
| *** Gal has quit IRC | 09:37 | |
| *** stevemar has joined #openstack-horizon | 09:38 | |
| *** nlahouti has joined #openstack-horizon | 09:40 | |
| *** tosky has joined #openstack-horizon | 09:40 | |
| *** stevemar has quit IRC | 09:42 | |
| *** e0ne is now known as e0ne_ | 09:46 | |
| *** robcresswell has joined #openstack-horizon | 09:48 | |
| *** nlahouti has quit IRC | 09:48 | |
| *** annashen has joined #openstack-horizon | 10:01 | |
| *** Gal has joined #openstack-horizon | 10:01 | |
| *** akrivoka has joined #openstack-horizon | 10:04 | |
| *** e0ne_ is now known as e0ne | 10:05 | |
| *** annashen has quit IRC | 10:06 | |
| *** lhcheng has quit IRC | 10:12 | |
| *** robcresswell has quit IRC | 10:14 | |
| *** nlahouti has joined #openstack-horizon | 10:15 | |
| *** JeanBriceCombebi has quit IRC | 10:15 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 10:16 | |
| *** robcresswell has joined #openstack-horizon | 10:22 | |
| *** kodoku has quit IRC | 10:23 | |
| *** nlahouti has quit IRC | 10:23 | |
| *** piyanai has joined #openstack-horizon | 10:27 | |
| *** romainh has left #openstack-horizon | 10:31 | |
| *** rushiagr_away is now known as rushiagr | 10:42 | |
| *** nlahouti has joined #openstack-horizon | 10:50 | |
| *** nlahouti has quit IRC | 10:58 | |
| *** annashen has joined #openstack-horizon | 11:02 | |
| openstackgerrit | Gal proposed openstack/horizon: [data processing] Remove css from templates https://review.openstack.org/197051 | 11:03 |
| *** annashen has quit IRC | 11:06 | |
| *** yamamoto has quit IRC | 11:13 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Update docs for auto js file discovery https://review.openstack.org/197575 | 11:18 |
| *** nlahouti has joined #openstack-horizon | 11:26 | |
| *** stevemar has joined #openstack-horizon | 11:27 | |
| *** kiran-r has quit IRC | 11:27 | |
| *** stevemar has quit IRC | 11:30 | |
| openstackgerrit | Vitaly Gridnev proposed openstack/horizon: Fix deletion action failure handling https://review.openstack.org/197930 | 11:32 |
| *** sayan has quit IRC | 11:32 | |
| *** JeanBriceCombebi has quit IRC | 11:32 | |
| *** yingjun has joined #openstack-horizon | 11:33 | |
| *** nlahouti has quit IRC | 11:34 | |
| *** e0ne is now known as e0ne_ | 11:34 | |
| *** e0ne_ is now known as e0ne | 11:36 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 11:38 | |
| *** dguerri` is now known as dguerri | 11:49 | |
| *** jasondotstar has quit IRC | 11:50 | |
| *** sayan has joined #openstack-horizon | 11:52 | |
| *** jtriley has joined #openstack-horizon | 11:58 | |
| *** drupalmonkey has joined #openstack-horizon | 12:00 | |
| *** zhenguo has quit IRC | 12:01 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: corrected the wrong url in admin instance detail https://review.openstack.org/197935 | 12:02 |
| *** annashen has joined #openstack-horizon | 12:02 | |
| *** jtriley has quit IRC | 12:02 | |
| openstackgerrit | Vitaly Gridnev proposed openstack/horizon: Fix deletion action failure handling https://review.openstack.org/197930 | 12:03 |
| openstackgerrit | Vitaly Gridnev proposed openstack/horizon: Fix deletion action failure handling https://review.openstack.org/197930 | 12:05 |
| *** e0ne is now known as e0ne_ | 12:06 | |
| *** annashen has quit IRC | 12:07 | |
| *** e0ne_ is now known as e0ne | 12:11 | |
| *** julim has joined #openstack-horizon | 12:22 | |
| *** JeanBriceCombebi has quit IRC | 12:23 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 12:26 | |
| *** yingjun has quit IRC | 12:26 | |
| *** julim has quit IRC | 12:27 | |
| *** yingjun has joined #openstack-horizon | 12:28 | |
| *** yamamoto has joined #openstack-horizon | 12:35 | |
| *** jasondotstar has joined #openstack-horizon | 12:37 | |
| *** Gal is now known as ^Gal^ | 12:39 | |
| robcresswell | Gooood afternoon | 12:42 |
| robcresswell | Anyone needing help/ reviews? | 12:42 |
| *** radez_g0n3 is now known as radez | 12:46 | |
| *** masco_ has quit IRC | 12:48 | |
| *** jtriley has joined #openstack-horizon | 12:50 | |
| *** nlahouti has joined #openstack-horizon | 13:02 | |
| *** dsneddon has quit IRC | 13:03 | |
| *** nlahouti1 has joined #openstack-horizon | 13:03 | |
| *** annashen has joined #openstack-horizon | 13:03 | |
| *** neelashah has joined #openstack-horizon | 13:05 | |
| *** piyanai has quit IRC | 13:05 | |
| *** petertr7_away is now known as petertr7 | 13:06 | |
| *** nlahouti has quit IRC | 13:06 | |
| *** annashen has quit IRC | 13:08 | |
| *** stevemar has joined #openstack-horizon | 13:09 | |
| *** nlahouti1 has quit IRC | 13:11 | |
| *** julim has joined #openstack-horizon | 13:15 | |
| *** zhenguo has joined #openstack-horizon | 13:16 | |
| openstackgerrit | Vitaly Gridnev proposed openstack/horizon: [Sahara] Move cluster configuration to separate tab https://review.openstack.org/197965 | 13:19 |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding Angular Identity Projects Panel https://review.openstack.org/191225 | 13:19 |
| openstackgerrit | Vitaly Gridnev proposed openstack/horizon: [Sahara] Move cluster configuration to separate tab https://review.openstack.org/197965 | 13:21 |
| *** jtriley has quit IRC | 13:25 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Remove Router Dashboard https://review.openstack.org/197969 | 13:26 |
| *** peristeri has joined #openstack-horizon | 13:27 | |
| *** amotoki has joined #openstack-horizon | 13:28 | |
| *** jtriley has joined #openstack-horizon | 13:29 | |
| *** mrunge has quit IRC | 13:29 | |
| *** e0ne is now known as e0ne_ | 13:29 | |
| *** lucas__ has joined #openstack-horizon | 13:31 | |
| *** piyanai has joined #openstack-horizon | 13:35 | |
| *** nlahouti has joined #openstack-horizon | 13:37 | |
| openstackgerrit | Vitaly Gridnev proposed openstack/horizon: [Sahara] Move cluster configuration to separate tab https://review.openstack.org/197965 | 13:39 |
| *** piyanai has quit IRC | 13:40 | |
| *** romainh has joined #openstack-horizon | 13:41 | |
| *** nlahouti has quit IRC | 13:41 | |
| *** ZZelle has quit IRC | 13:42 | |
| *** ZZelle has joined #openstack-horizon | 13:42 | |
| *** tjones1 has joined #openstack-horizon | 13:43 | |
| *** e0ne_ is now known as e0ne | 13:43 | |
| *** tvanderwiel has joined #openstack-horizon | 13:44 | |
| *** petertr7 is now known as petertr7_away | 13:47 | |
| *** JeanBriceCombebi has quit IRC | 13:49 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:49 | |
| *** petertr7_away is now known as petertr7 | 13:53 | |
| *** fifieldt has joined #openstack-horizon | 13:53 | |
| *** JeanBriceCombebi has quit IRC | 13:56 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:56 | |
| *** dboik has quit IRC | 13:57 | |
| *** matt-borland has joined #openstack-horizon | 13:57 | |
| *** masco_ has joined #openstack-horizon | 14:00 | |
| *** annashen has joined #openstack-horizon | 14:04 | |
| *** sayan has quit IRC | 14:07 | |
| *** kodoku has joined #openstack-horizon | 14:07 | |
| kodoku | robcresswell Hi :) | 14:08 |
| *** bluex-pl has quit IRC | 14:09 | |
| *** ducttape_ has joined #openstack-horizon | 14:09 | |
| *** annashen has quit IRC | 14:09 | |
| *** ducttape_ has quit IRC | 14:10 | |
| *** ducttape_ has joined #openstack-horizon | 14:10 | |
| *** dboik has joined #openstack-horizon | 14:16 | |
| *** aix has quit IRC | 14:21 | |
| robcresswell | kodoku: Hullo | 14:22 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Add New UX CSS for Upcoming Detail Screens https://review.openstack.org/158881 | 14:27 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Detail-page directives (Angular/UX) https://review.openstack.org/173359 | 14:27 |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 14:27 |
| *** e0ne is now known as e0ne_ | 14:30 | |
| *** matt-borland_ has joined #openstack-horizon | 14:32 | |
| *** e0ne_ is now known as e0ne | 14:32 | |
| *** matt-borland_ has quit IRC | 14:32 | |
| sjmc7 | hi folks. our internal CI is breaking as of recent, getting "ImportError: Could not import settings 'openstack_dashboard.settings' (Is it on sys.path? Is there an import error in the settings file?): cannot import name i18n" | 14:33 |
| sjmc7 | i know oslo.i18n 2.0.0 got released recently but horizon & global reqs still seem to be specifying >=1.5.0 | 14:33 |
| *** matt-borland has quit IRC | 14:33 | |
| *** matt-borland has joined #openstack-horizon | 14:34 | |
| sjmc7 | i don't pay enough attention in here, but was this/is this an issue? | 14:34 |
| *** tjones1 has left #openstack-horizon | 14:34 | |
| robcresswell | sjmc7: I've seen this a few times. I would ask in the oslo channel | 14:37 |
| *** andrewbogott_afk is now known as andrewbogott | 14:37 | |
| *** JeanBriceCombebi has quit IRC | 14:37 | |
| sjmc7 | oh no, one of those :) ok, will do | 14:39 |
| openstackgerrit | Merged openstack/horizon: Update project list in the header bar. https://review.openstack.org/184257 | 14:40 |
| *** JeanBriceCombebi has joined #openstack-horizon | 14:43 | |
| *** andrewbogott is now known as andrewbogott_afk | 14:45 | |
| *** andrewbogott_afk is now known as andrewbogott | 14:45 | |
| *** petertr7 is now known as petertr7_away | 14:52 | |
| *** piyanai has joined #openstack-horizon | 14:56 | |
| *** bradjones has quit IRC | 14:57 | |
| *** petertr7_away is now known as petertr7 | 14:58 | |
| *** bradjones has joined #openstack-horizon | 14:58 | |
| *** bradjones has quit IRC | 14:58 | |
| *** bradjones has joined #openstack-horizon | 14:58 | |
| *** absubram has joined #openstack-horizon | 15:02 | |
| *** annashen has joined #openstack-horizon | 15:05 | |
| *** yingjun has quit IRC | 15:05 | |
| *** dguerri is now known as dguerri` | 15:07 | |
| *** annashen has quit IRC | 15:10 | |
| *** belmoreira has quit IRC | 15:10 | |
| *** asahlin_away is now known as asahlin | 15:10 | |
| *** Piet has quit IRC | 15:10 | |
| *** ttrifonov is now known as zz_ttrifonov | 15:12 | |
| *** jtriley has quit IRC | 15:16 | |
| *** Drago has joined #openstack-horizon | 15:17 | |
| *** Drago has quit IRC | 15:17 | |
| *** Drago has joined #openstack-horizon | 15:17 | |
| *** hurgleburgler has joined #openstack-horizon | 15:22 | |
| *** chlong has quit IRC | 15:23 | |
| *** yamamoto has quit IRC | 15:24 | |
| *** jcoufal has quit IRC | 15:25 | |
| *** yamamoto has joined #openstack-horizon | 15:25 | |
| *** masco_ has quit IRC | 15:26 | |
| *** Berezin has joined #openstack-horizon | 15:28 | |
| openstackgerrit | Michael Krotscheck proposed openstack/horizon: Added .eslintignore https://review.openstack.org/197709 | 15:29 |
| openstackgerrit | Michael Krotscheck proposed openstack/horizon: Add selective ESLint rule activation for Horizon Legacy JS https://review.openstack.org/195799 | 15:29 |
| *** pkarikh has quit IRC | 15:30 | |
| *** jtriley has joined #openstack-horizon | 15:30 | |
| *** pkarikh has joined #openstack-horizon | 15:30 | |
| kodoku | robcresswell I try kilo dashboard with juno env. Good for now | 15:30 |
| kodoku | robcresswell Now I need to delete new function of KILO version. Need modify code | 15:30 |
| kodoku | Because I have always trace If I use new functions | 15:31 |
| openstackgerrit | Merged openstack/horizon: Wrong url in document of horizon tutorial https://review.openstack.org/185346 | 15:33 |
| *** masco_ has joined #openstack-horizon | 15:34 | |
| *** doug-fish has quit IRC | 15:35 | |
| openstackgerrit | George Peristerakis proposed openstack/horizon: Refactoring the exceptions lists https://review.openstack.org/173027 | 15:39 |
| *** jtriley_ has joined #openstack-horizon | 15:41 | |
| *** ducttape_ has quit IRC | 15:43 | |
| *** jtriley has quit IRC | 15:44 | |
| *** jtriley_ has quit IRC | 15:46 | |
| *** JeanBriceCombebi has quit IRC | 15:48 | |
| *** stevemar has quit IRC | 15:48 | |
| *** ducttape_ has joined #openstack-horizon | 15:48 | |
| *** Piet has joined #openstack-horizon | 15:54 | |
| *** masco_ has quit IRC | 15:54 | |
| *** dboik_ has joined #openstack-horizon | 15:58 | |
| *** dboik has quit IRC | 15:58 | |
| *** dboik has joined #openstack-horizon | 16:00 | |
| *** Berezin has quit IRC | 16:00 | |
| *** jbell8 has joined #openstack-horizon | 16:00 | |
| *** jtomasek has quit IRC | 16:01 | |
| *** dboik_ has quit IRC | 16:03 | |
| *** ygbo has quit IRC | 16:04 | |
| *** mwhagedorn has joined #openstack-horizon | 16:05 | |
| *** annashen has joined #openstack-horizon | 16:06 | |
| *** Drago1 has joined #openstack-horizon | 16:06 | |
| *** Drago1 has quit IRC | 16:06 | |
| *** Drago1 has joined #openstack-horizon | 16:06 | |
| *** Drago has quit IRC | 16:06 | |
| *** annashen has quit IRC | 16:10 | |
| *** lucas__ has quit IRC | 16:11 | |
| *** piyanai has quit IRC | 16:11 | |
| *** ericpeterson has joined #openstack-horizon | 16:13 | |
| *** stevemar has joined #openstack-horizon | 16:13 | |
| *** stevemar has quit IRC | 16:14 | |
| *** amotoki_ has joined #openstack-horizon | 16:14 | |
| *** alexvictorchan has joined #openstack-horizon | 16:16 | |
| *** ducttape_ has quit IRC | 16:17 | |
| *** amotoki has quit IRC | 16:17 | |
| *** piyanai has joined #openstack-horizon | 16:18 | |
| asahlin | What am I missing? https://review.openstack.org/#/c/189431, needed to rebase so auto file discovery in effect. I am renaming "horizon/static/framework/widgets/table/search-bar.directive.js" to "horizon/static/framework/widgets/table/hz-search-bar.directive.js", jasmine tests failing cause it can't find that directive. Do I need to enable auto discovery for framework/widgets? | 16:18 |
| *** sqchen has joined #openstack-horizon | 16:19 | |
| *** Ala has quit IRC | 16:22 | |
| *** kodoku has quit IRC | 16:23 | |
| *** petertr7 is now known as petertr7_away | 16:25 | |
| *** annashen has joined #openstack-horizon | 16:26 | |
| amotoki_ | david-lyle: I found the author of https://review.openstack.org/#/c/175982/ already has another review for the same bug. Could you reconsider your +2? | 16:26 |
| *** dsneddon has joined #openstack-horizon | 16:26 | |
| *** alexvictorchan has quit IRC | 16:32 | |
| *** MaxV has quit IRC | 16:32 | |
| robcresswell | sqchen, TravT: Docs up for auto file discovery https://review.openstack.org/#/c/197575/ | 16:37 |
| robcresswell | sqchen: Tried to incorporate what you had written already sean; sorry for the work duplication. | 16:37 |
| *** mayurig has joined #openstack-horizon | 16:37 | |
| sqchen | No, thank you so much for taking the work! You did much better work than me. | 16:38 |
| *** Drago1 has quit IRC | 16:42 | |
| *** garthb has joined #openstack-horizon | 16:42 | |
| *** annashen has quit IRC | 16:42 | |
| *** annashen has joined #openstack-horizon | 16:43 | |
| *** annashen has quit IRC | 16:43 | |
| *** annashen has joined #openstack-horizon | 16:44 | |
| *** alexvictorchan has joined #openstack-horizon | 16:46 | |
| *** lucas_ has joined #openstack-horizon | 16:47 | |
| *** lucas_ has quit IRC | 16:48 | |
| *** lucas_ has joined #openstack-horizon | 16:48 | |
| *** mpavlase has quit IRC | 16:50 | |
| *** lucas_ has quit IRC | 16:52 | |
| *** piyanai has quit IRC | 16:56 | |
| openstackgerrit | Brian Tully proposed openstack/horizon: Add anti-ClickJack XFS hardening for old browsers https://review.openstack.org/191591 | 16:58 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Remove Router Dashboard https://review.openstack.org/197969 | 17:00 |
| robcresswell | david-lyle: Getting there! https://review.openstack.org/#/c/197969/ Still waiting on infra/ governance patches. | 17:01 |
| *** gyee has joined #openstack-horizon | 17:01 | |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: JSCS cleanup - style guide cleanup for table and basic-table https://review.openstack.org/190354 | 17:01 |
| *** piyanai has joined #openstack-horizon | 17:02 | |
| *** annashen has quit IRC | 17:02 | |
| *** Drago has joined #openstack-horizon | 17:02 | |
| *** dscottsf has joined #openstack-horizon | 17:03 | |
| *** annashen has joined #openstack-horizon | 17:03 | |
| *** Drago has quit IRC | 17:03 | |
| *** Drago1 has joined #openstack-horizon | 17:03 | |
| asahlin | disregard my previous comment 1) I posted the wrong review ;-) 2) read robcresswell's auto file discovery doc patch and found my answer | 17:04 |
| *** kiran-r has joined #openstack-horizon | 17:04 | |
| *** gokrokve has joined #openstack-horizon | 17:06 | |
| openstackgerrit | Romain Hardouin proposed openstack/horizon: DataTable column level policy https://review.openstack.org/164010 | 17:06 |
| *** romainh has left #openstack-horizon | 17:07 | |
| *** Berezin has joined #openstack-horizon | 17:07 | |
| *** annashen has quit IRC | 17:08 | |
| *** garthb has quit IRC | 17:10 | |
| *** dscottsf has quit IRC | 17:11 | |
| *** e0ne has quit IRC | 17:11 | |
| *** rajatvig has joined #openstack-horizon | 17:13 | |
| Piet | Can roles have descriptions? I noticed that descriptions weren't included in Horizon | 17:13 |
| *** stevemar has joined #openstack-horizon | 17:15 | |
| *** piyanai has quit IRC | 17:16 | |
| *** piyanai has joined #openstack-horizon | 17:17 | |
| *** rajatvig has left #openstack-horizon | 17:17 | |
| robcresswell | asahlin: Success! | 17:17 |
| *** petertr7_away is now known as petertr7 | 17:17 | |
| *** rajatvig has joined #openstack-horizon | 17:17 | |
| *** jasondotstar is now known as jasondotstar|afk | 17:19 | |
| *** stevemar has quit IRC | 17:19 | |
| *** mwhagedorn has quit IRC | 17:19 | |
| *** piyanai_ has joined #openstack-horizon | 17:20 | |
| *** piyanai has quit IRC | 17:21 | |
| *** piyanai_ is now known as piyanai | 17:21 | |
| *** mwhagedorn has joined #openstack-horizon | 17:23 | |
| *** drupalmonkey has quit IRC | 17:24 | |
| *** jingjing_ren has joined #openstack-horizon | 17:26 | |
| *** petertr7 is now known as petertr7_away | 17:27 | |
| *** piyanai has quit IRC | 17:27 | |
| *** petertr7_away is now known as petertr7 | 17:27 | |
| *** piyanai has joined #openstack-horizon | 17:28 | |
| *** clu_ has joined #openstack-horizon | 17:30 | |
| *** garthb has joined #openstack-horizon | 17:31 | |
| *** Berezin has quit IRC | 17:32 | |
| *** nzeplowi has joined #openstack-horizon | 17:32 | |
| *** deuce_ has joined #openstack-horizon | 17:34 | |
| *** kiran-r has quit IRC | 17:36 | |
| *** absubram has quit IRC | 17:36 | |
| *** lucas__ has joined #openstack-horizon | 17:37 | |
| *** mwhagedorn has quit IRC | 17:37 | |
| *** albertom has quit IRC | 17:39 | |
| *** annashen has joined #openstack-horizon | 17:39 | |
| *** garthb has quit IRC | 17:39 | |
| *** absubram has joined #openstack-horizon | 17:40 | |
| *** jasondotstar|afk has quit IRC | 17:45 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Extending Karma config https://review.openstack.org/198073 | 17:45 |
| *** albertom has joined #openstack-horizon | 17:47 | |
| *** yamamoto has quit IRC | 17:49 | |
| Piet | Updated Create Project modal based on feedback from Lin. https://openstack.invisionapp.com/d/main/#/projects/4007880 | 17:52 |
| *** mpavlase has joined #openstack-horizon | 17:54 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Dashboard ReOrg - Create 'project' module https://review.openstack.org/196271 | 17:55 |
| *** absubram has quit IRC | 17:55 | |
| *** tjones1 has joined #openstack-horizon | 17:55 | |
| openstackgerrit | George Peristerakis proposed openstack/horizon: Generating a rdp file for a windows instance https://review.openstack.org/91394 | 18:01 |
| openstackgerrit | George Peristerakis proposed openstack/horizon: Display event stream in the instance audit tab https://review.openstack.org/188134 | 18:02 |
| *** mayurig has quit IRC | 18:02 | |
| *** mayurig has joined #openstack-horizon | 18:02 | |
| openstackgerrit | Tracy Jones proposed openstack/horizon: move favicon, logo and logo-splash to default theme https://review.openstack.org/195751 | 18:03 |
| *** logan2 has quit IRC | 18:03 | |
| *** Drago1 has quit IRC | 18:05 | |
| *** piyanai has quit IRC | 18:08 | |
| *** piyanai has joined #openstack-horizon | 18:09 | |
| *** amotoki_ has quit IRC | 18:09 | |
| *** Berezin has joined #openstack-horizon | 18:09 | |
| *** jwy has joined #openstack-horizon | 18:13 | |
| *** absubram has joined #openstack-horizon | 18:15 | |
| *** petertr7 is now known as petertr7_away | 18:17 | |
| *** ericpeterson has quit IRC | 18:17 | |
| *** annashen has quit IRC | 18:19 | |
| *** annashen has joined #openstack-horizon | 18:20 | |
| *** akrivoka has quit IRC | 18:21 | |
| *** Berezin has quit IRC | 18:22 | |
| *** Berezin has joined #openstack-horizon | 18:23 | |
| *** petertr7_away is now known as petertr7 | 18:23 | |
| *** ducttape_ has joined #openstack-horizon | 18:23 | |
| *** annashen has quit IRC | 18:24 | |
| *** rushiagr is now known as rushiagr_away | 18:26 | |
| *** lhcheng has joined #openstack-horizon | 18:29 | |
| *** neelashah has quit IRC | 18:31 | |
| *** stevemar has joined #openstack-horizon | 18:31 | |
| *** neelashah has joined #openstack-horizon | 18:32 | |
| *** nzeplowi has quit IRC | 18:32 | |
| *** rajatvig has quit IRC | 18:32 | |
| *** zhenguo has quit IRC | 18:33 | |
| *** wuhg has quit IRC | 18:34 | |
| *** stevemar has quit IRC | 18:34 | |
| *** packet has joined #openstack-horizon | 18:34 | |
| *** gokrokve has quit IRC | 18:35 | |
| openstackgerrit | Merged openstack/horizon: JSCS Cleanup - style cleanup for Launch Instance Security Groups Step https://review.openstack.org/193608 | 18:40 |
| *** tosky has quit IRC | 18:42 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Extending Karma config https://review.openstack.org/198073 | 18:42 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Dashboard ReOrg - Create 'project' module https://review.openstack.org/196271 | 18:42 |
| *** Longgeek has quit IRC | 18:43 | |
| *** kzaitsev_mb has joined #openstack-horizon | 18:43 | |
| *** Longgeek has joined #openstack-horizon | 18:43 | |
| openstackgerrit | Merged openstack/horizon: Add integration tests for Identity->Projects page https://review.openstack.org/110919 | 18:46 |
| *** e0ne has joined #openstack-horizon | 18:46 | |
| openstackgerrit | Merged openstack/horizon: Remove 'shared' from Neutron Firewall table https://review.openstack.org/194621 | 18:46 |
| *** Drago has joined #openstack-horizon | 18:46 | |
| *** julim has quit IRC | 18:47 | |
| *** stevemar has joined #openstack-horizon | 18:48 | |
| *** Sukhdev has joined #openstack-horizon | 18:48 | |
| *** yamamoto has joined #openstack-horizon | 18:49 | |
| *** logan2 has joined #openstack-horizon | 18:49 | |
| *** lhcheng has quit IRC | 18:52 | |
| *** tqtran has joined #openstack-horizon | 18:52 | |
| *** ZZelle_ has joined #openstack-horizon | 18:52 | |
| *** kzaitsev_mb has quit IRC | 18:53 | |
| *** sqchen has quit IRC | 18:53 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: JSCS Cleanup - style cleanup for modal factory https://review.openstack.org/196836 | 18:53 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Update docs for auto js file discovery https://review.openstack.org/197575 | 18:53 |
| *** sqchen has joined #openstack-horizon | 18:53 | |
| robcresswell | argh git review stupidity | 18:54 |
| *** yamamoto has quit IRC | 18:54 | |
| *** Longgeek has quit IRC | 18:54 | |
| robcresswell | TravT: Right I rebased on top of your patch, but accidentally pushed a new patch set so just approved it again | 18:55 |
| *** robcresswell has quit IRC | 18:55 | |
| tqtran | damn the doug-fish is not on | 18:55 |
| tqtran | so i guess i have to bug one of you to do it :) | 18:56 |
| tqtran | clu_, TravT, david-lyle: https://review.openstack.org/#/c/192035/ | 18:56 |
| tqtran | the angular translate is ready for bussiness | 18:56 |
| *** sayan has joined #openstack-horizon | 18:57 | |
| *** deuce_ has quit IRC | 18:58 | |
| *** ericpeterson has joined #openstack-horizon | 18:58 | |
| *** absubram has quit IRC | 19:01 | |
| *** Longgeek has joined #openstack-horizon | 19:02 | |
| *** kzaitsev_mb has joined #openstack-horizon | 19:02 | |
| *** ducttape_ has quit IRC | 19:02 | |
| *** jtomasek has joined #openstack-horizon | 19:02 | |
| *** sqchen has quit IRC | 19:02 | |
| *** nzeplowi has joined #openstack-horizon | 19:03 | |
| *** sqchen has joined #openstack-horizon | 19:03 | |
| *** stevemar has quit IRC | 19:05 | |
| openstackgerrit | Merged openstack/horizon: Remove serial console hardcode url https://review.openstack.org/195939 | 19:06 |
| ericpeterson | david-lyle - if you can redo another DOA release, we can move on a session cleanup ticket | 19:07 |
| *** dsneddon is now known as dsneddon_biab | 19:10 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Theming Mechanism now supports 3rd party themes https://review.openstack.org/198095 | 19:11 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Theming Mechanism now supports 3rd party themes https://review.openstack.org/197821 | 19:13 |
| tqtran | sqchen: question https://review.openstack.org/#/c/181095/32/openstack_dashboard/static/dashboard/dashboard.module.js | 19:14 |
| *** Longgeek has quit IRC | 19:14 | |
| *** petertr7 is now known as petertr7_away | 19:17 | |
| tqtran | lets say i want to append this dashboard path to the identity dashboard | 19:18 |
| tqtran | https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/static/dashboard/identity/identity.module.js | 19:18 |
| tqtran | do i inject the dashboardBasePath? or do i hardcode /static/dashboard/identity/? | 19:19 |
| *** tqtran is now known as tqtran-afk | 19:19 | |
| *** petertr7_away is now known as petertr7 | 19:20 | |
| *** annashen has joined #openstack-horizon | 19:20 | |
| *** kzaitsev_mb has quit IRC | 19:22 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Corrections to WEBROOT docs. https://review.openstack.org/198099 | 19:24 |
| matt-borland | sqchen: TravT: ^^ | 19:24 |
| sqchen | tqtran: sorry I was in a meeting. | 19:25 |
| *** amerine has joined #openstack-horizon | 19:25 | |
| matt-borland | This is just adding some detail to the existing docs for WEBROOT. It doesn't speak specifically to devstack | 19:25 |
| matt-borland | np sqchen...I just posted it now :) | 19:25 |
| *** annashen has quit IRC | 19:25 | |
| *** lhcheng has joined #openstack-horizon | 19:27 | |
| sqchen | thx matt-borland: | 19:28 |
| sqchen | tqtran: Ithink you should use /static/dashboard/identity/ directly, and ignore dashboardBasePath. | 19:29 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - rename *.factory.js to *.service.js https://review.openstack.org/197340 | 19:30 |
| sqchen | dashboardBasePath maybe not need anymore, insdead, we will have a base path for the core. | 19:30 |
| *** amerine has left #openstack-horizon | 19:30 | |
| openstackgerrit | Eric Peterson proposed openstack/horizon: LBAAS VIP floating IP table actions https://review.openstack.org/196740 | 19:36 |
| *** nzeplowi has quit IRC | 19:38 | |
| *** nzeplowi has joined #openstack-horizon | 19:39 | |
| *** kbrown has joined #openstack-horizon | 19:42 | |
| *** jtomasek has quit IRC | 19:44 | |
| *** kzaitsev_mb has joined #openstack-horizon | 19:46 | |
| *** nzeplowi_ has joined #openstack-horizon | 19:47 | |
| *** nzeplowi has quit IRC | 19:47 | |
| *** igor___ has joined #openstack-horizon | 19:48 | |
| *** jasondotstar|afk has joined #openstack-horizon | 19:49 | |
| *** varoske has joined #openstack-horizon | 19:50 | |
| *** dsneddon_biab is now known as dsneddon | 19:50 | |
| *** e0ne has quit IRC | 19:55 | |
| *** mwhagedorn has joined #openstack-horizon | 19:55 | |
| *** tqtran-afk is now known as tqtran | 19:56 | |
| tqtran | sqchen: ok so just hardcode it? | 19:56 |
| *** rajatvig has joined #openstack-horizon | 19:56 | |
| *** rajatvig has joined #openstack-horizon | 19:57 | |
| sqchen | yes, each basePath is actaully independent. | 19:57 |
| *** Berezin has quit IRC | 19:57 | |
| *** Berezin has joined #openstack-horizon | 19:58 | |
| tqtran | ok that is fine then | 19:58 |
| *** piyanai has quit IRC | 20:00 | |
| *** packet has quit IRC | 20:01 | |
| *** piyanai has joined #openstack-horizon | 20:05 | |
| *** stevemar has joined #openstack-horizon | 20:05 | |
| openstackgerrit | Merged openstack/horizon: Added .eslintignore https://review.openstack.org/197709 | 20:08 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 20:09 |
| *** stevemar has quit IRC | 20:09 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Corrections to WEBROOT docs. https://review.openstack.org/198099 | 20:11 |
| *** Longgeek has joined #openstack-horizon | 20:14 | |
| *** e0ne has joined #openstack-horizon | 20:15 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 20:16 |
| *** jrist has quit IRC | 20:20 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - style guide cleanup for Keypair step https://review.openstack.org/193658 | 20:21 |
| *** annashen has joined #openstack-horizon | 20:21 | |
| *** kbrown has quit IRC | 20:21 | |
| *** jasondotstar|afk has quit IRC | 20:22 | |
| *** lucas__ has quit IRC | 20:23 | |
| *** annashen has quit IRC | 20:26 | |
| *** Berezin has quit IRC | 20:27 | |
| tqtran | clu_: http://paste.openstack.org/show/336299/ | 20:28 |
| tqtran | use the contents of the file as test | 20:28 |
| clu_ | ok tq | 20:28 |
| clu_ | thx | 20:28 |
| clu_ | tqtran* | 20:28 |
| *** tjones1 has quit IRC | 20:32 | |
| *** TravT has quit IRC | 20:33 | |
| *** jasondotstar|afk has joined #openstack-horizon | 20:34 | |
| Piet | Is Lin around? | 20:36 |
| *** jbell8 has quit IRC | 20:37 | |
| matt-borland | sqchen: TravT: WEBROOT latest patch looks good...+1 | 20:37 |
| *** reed has quit IRC | 20:37 | |
| sqchen | Thanks! | 20:37 |
| *** reed_ is now known as reed | 20:37 | |
| *** reed has quit IRC | 20:38 | |
| *** reed has joined #openstack-horizon | 20:38 | |
| matt-borland | I left a comment, but I tested on my DevStack with a WEBROOT of /dashboard and it works without any hiccups. | 20:38 |
| *** reed_ has joined #openstack-horizon | 20:38 | |
| matt-borland | I also navigated to it from Images (Launch action) and it worked correctly. | 20:38 |
| sqchen | That is great. | 20:40 |
| Piet | tqtran: Are we including project hierarchies to the Create Project modal? | 20:41 |
| *** matt-borland has quit IRC | 20:41 | |
| tqtran | slow down Piet, let me catch up with the users modal first | 20:41 |
| Piet | tqtran: May also impact the Users modals as well. | 20:42 |
| tqtran | we can talk about it, but i wont be able to give any meaningful feedback because i havent even taken a look at the projects panel yet | 20:42 |
| tqtran | yeah, it might, can we come back to this in like a week's time when the code is slightly more caught up to the mock? | 20:43 |
| *** TravT has joined #openstack-horizon | 20:44 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding identity users table https://review.openstack.org/197373 | 20:45 |
| *** tjones1 has joined #openstack-horizon | 20:46 | |
| *** petertr7 is now known as petertr7_away | 20:47 | |
| *** Sukhdev has quit IRC | 20:48 | |
| *** petertr7_away is now known as petertr7 | 20:52 | |
| *** Sukhdev has joined #openstack-horizon | 20:56 | |
| openstackgerrit | Merged openstack/horizon: JSCS Cleanup - style cleanup for modal factory https://review.openstack.org/196836 | 20:58 |
| *** dboik has quit IRC | 21:00 | |
| Piet | tqtran: we knew this day was coming. Time to look at tables/lists with hierarchies in them! | 21:00 |
| tqtran | -_- no.... i hate hierarchical tables.... can we explore alternatives? | 21:03 |
| *** tvanderwiel_ has joined #openstack-horizon | 21:03 | |
| tqtran | i have done them in the past, and they are usually not a good idea | 21:03 |
| openstackgerrit | Tracy Jones proposed openstack/horizon: move favicon, logo and logo-splash to default theme https://review.openstack.org/195751 | 21:03 |
| tqtran | on paper it sounds great, but i think it will get messy | 21:04 |
| tqtran | *sounds and look great | 21:04 |
| *** annashen has joined #openstack-horizon | 21:04 | |
| *** tvanderwiel_ has quit IRC | 21:05 | |
| *** tvanderwiel has quit IRC | 21:06 | |
| *** rajatvig has quit IRC | 21:07 | |
| *** stevemar has joined #openstack-horizon | 21:07 | |
| *** petertr7 is now known as petertr7_away | 21:08 | |
| *** stevemar has quit IRC | 21:09 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - style guide cleanup for Keypair step https://review.openstack.org/193658 | 21:10 |
| *** neelashah has quit IRC | 21:10 | |
| *** rajatvig has joined #openstack-horizon | 21:10 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding identity users table https://review.openstack.org/197373 | 21:10 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding identity users table https://review.openstack.org/197373 | 21:17 |
| *** jasondotstar|afk has quit IRC | 21:17 | |
| pauloewerton | Piet, tqtran, there's a work we've proposed not long ago on hirarchical projects in horizon https://blueprints.launchpad.net/horizon/+spec/hierarchical-projects including modifications to the create project modal form | 21:18 |
| pauloewerton | that work is blocked by now because there's a lot to take into consideration | 21:19 |
| tqtran | pauloewerton: reading | 21:19 |
| pauloewerton | quotas and such | 21:19 |
| *** Longgeek has quit IRC | 21:20 | |
| tqtran | instead of hierarchy tables, can we just have a tree navigation? | 21:20 |
| tqtran | and when you click on a project, then the table updates the information? | 21:20 |
| pauloewerton | yes, it does | 21:20 |
| *** e0ne has quit IRC | 21:20 | |
| pauloewerton | I mean, I'd have to check. long time without testing that code | 21:21 |
| pauloewerton | but for what I know, it the table is indeed updated | 21:21 |
| tqtran | here's an example of a treegrid (aka tree table) http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/grid/tests/test_treegrid.html | 21:22 |
| tqtran | notice how there are a lot of empty cells, and alignment isn't going to be friendly | 21:23 |
| tqtran | also keep in mind that the aggregation would have to be done as well, which would require additional processing | 21:23 |
| TravT | ugh... that's kind of ugly. | 21:23 |
| tqtran | right... which is why im against going in that direction | 21:24 |
| pauloewerton | yeah, I agree | 21:24 |
| pauloewerton | and that is just the table | 21:24 |
| tqtran | my preference would be to have a tree nav somewhere that allow you to navigation like a file structure (except its projects) | 21:25 |
| * david-lyle just threw up a bit in his mouth | 21:25 | |
| tqtran | and when you click on one, then display the information in a table/orwhatever manner | 21:25 |
| pauloewerton | creating a project considering hierarchy is a tough task | 21:25 |
| *** piyanai has quit IRC | 21:26 | |
| *** nzeplowi_ has quit IRC | 21:26 | |
| Piet | This is going to take some discussion, but one proposal would be to just display all projects in the table and use one of the columns to display the path | 21:26 |
| tqtran | Piet's gotta pull out his creative tools and help us out here | 21:26 |
| tqtran | i think filtering will help a great deal here | 21:26 |
| TravT | we did that in an internal project not too long ago to flatten a tree. | 21:27 |
| tqtran | you can filter by a project name and then maybe sort by paths? *shrugs* | 21:27 |
| Piet | Yeah, agreed. Filtering is awesomeness | 21:27 |
| *** nzeplowi has joined #openstack-horizon | 21:27 | |
| Piet | Take a look here: https://openstack.invisionapp.com/d/main/#/projects/2966363 | 21:27 |
| tqtran | ok cool, thats all i wanted to raise, as long as we dont do hierarchical tables, i think im good with anything | 21:28 |
| Piet | Coolio | 21:28 |
| TravT | you could also breadcrumb the path | 21:29 |
| tqtran | yeah, that would be really cool | 21:29 |
| TravT | like finder in mac | 21:29 |
| tqtran | yep | 21:29 |
| Piet | Need to know if the mocks made David throw-up in his mouth, though | 21:29 |
| TravT | no, he's just been drinking since 7 am | 21:29 |
| *** nzeplowi has quit IRC | 21:29 | |
| david-lyle | view only the current level of the hierarchy give context at the top | 21:29 |
| david-lyle | select a row to change context info at top and load with new level | 21:30 |
| david-lyle | and a column indicating leaf or node | 21:30 |
| TravT | yeah, that's what I was thinking david. | 21:30 |
| Piet | I was hoping to use magic search to filter the table by project | 21:30 |
| TravT | and like finder, you could switch to total flat search. | 21:30 |
| david-lyle | don't force extra complexity in to the table itself | 21:30 |
| *** logan2 has quit IRC | 21:31 | |
| *** nzeplowi has joined #openstack-horizon | 21:31 | |
| david-lyle | how the search field works, I don't know | 21:31 |
| Piet | David, were you thinking about having users click on the path in the rows to filter? | 21:32 |
| TravT | magic search facet it | 21:32 |
| TravT | path is just a facet | 21:32 |
| *** piyanai has joined #openstack-horizon | 21:32 | |
| TravT | if not specified then search across all projects | 21:32 |
| david-lyle | TravT: actually I have no idea what filter the keystone API provides there, I don't imagine enough | 21:33 |
| david-lyle | TravT: then the results are mixed levels in the tree | 21:33 |
| sqchen | Hi tqtran: clu_: TravT, can you guys take a look at 198073 and 196271? they are very simple, but can unblock other code-reorg work. | 21:33 |
| TravT | prob not... david-lyle: are projects something searchlight-able? | 21:33 |
| david-lyle | just changed the behavior of the table | 21:33 |
| david-lyle | if you only want to search the first 500 | 21:33 |
| TravT | well, Piet's mock have path as a colum | 21:33 |
| TravT | n | 21:33 |
| tqtran | we can always just use whatever api is available to us, and let the path search be done clientside | 21:34 |
| david-lyle | tqtran: then search is at the current level only | 21:34 |
| tqtran | ;( ok.... | 21:35 |
| david-lyle | I think we over estimate what the API will return | 21:35 |
| david-lyle | unless you walk up and down the tree programmatically | 21:36 |
| tqtran | can we use lazy loading to some extend? | 21:36 |
| tqtran | *extent | 21:36 |
| david-lyle | this will be more like a file explorer like TravT said | 21:36 |
| tqtran | yeah, thats kind of how i envision it | 21:36 |
| david-lyle | only request the next layer when requested | 21:36 |
| tqtran | sqchen: https://review.openstack.org/#/c/198073/2/openstack_dashboard/karma.conf.js | 21:37 |
| david-lyle | show the path in the header | 21:37 |
| david-lyle | not necessary to put the path in a column | 21:37 |
| tqtran | sqchen: not sure i understand what you mean by extending, it looks to me like **/*.spec.js already covers ../dashboards/**/* doesn't it? | 21:37 |
| TravT | simple breadcrumb navigation would work to start i think. | 21:38 |
| *** jrist has joined #openstack-horizon | 21:38 | |
| tqtran | i have no idea what performance will be like for large project pools, but at least it will be an improvement if we use lazy loading | 21:39 |
| *** piyanai has quit IRC | 21:39 | |
| sqchen | tqtran: it doesn’t. ** is based on './static/' | 21:39 |
| *** sambetts has quit IRC | 21:39 | |
| *** piyanai has joined #openstack-horizon | 21:39 | |
| tqtran | sqchen: im confuse, **/ means to search any hierarchy of folders doesn't it? | 21:40 |
| *** piyanai has quit IRC | 21:40 | |
| tqtran | so wouldn't it include ../dashboards/** as well? | 21:40 |
| david-lyle | TravT: yep, fortunately we don't have to invent anything new | 21:40 |
| sqchen | in the current karma config, there is one line like this: basePath: './static/' | 21:41 |
| *** sambetts has joined #openstack-horizon | 21:42 | |
| sqchen | if we defined it as basePath: ‘./‘ ** will cover dashboards/ as well. | 21:42 |
| sqchen | the line number is 59. | 21:43 |
| tqtran | yep, just saw that | 21:43 |
| tqtran | are there folders we want to ignore inside of ./ ? | 21:44 |
| tqtran | ok i see what you're doing now | 21:44 |
| tqtran | '../dashboards/**/*.spec.js', would also be inside of **/static/** | 21:45 |
| tqtran | otherwise it wont get serve | 21:45 |
| tqtran | ame for module, mock, etc.... | 21:45 |
| tqtran | *same | 21:45 |
| *** nzeplowi_ has joined #openstack-horizon | 21:51 | |
| *** nzeplowi has quit IRC | 21:51 | |
| sqchen | only .html need to be specific like that, since we don’t want to discover djanog templates that are also have extension of .html. but, for js file, they are always come from static folder. | 21:51 |
| tqtran | the other way around sean, what i mean to say is that JS files should also live inside static | 21:53 |
| tqtran | it doesn't make sense to have JS file not inside of static, since it wont get aggregated at the root static folder | 21:53 |
| *** Piet has quit IRC | 21:53 | |
| *** nzeplowi_ has quit IRC | 21:55 | |
| sqchen | With the current pattern, the all the js files will be found, regardless they are under static or not. But I can change is to only find js file from static folder. Is this what you want? | 21:56 |
| *** logan2 has joined #openstack-horizon | 21:56 | |
| tqtran | yes | 21:57 |
| tqtran | it doesn't make sense to have js outside of static does it? | 21:57 |
| tqtran | that was a question btw lol | 21:57 |
| sqchen | right. I’ll make the change. | 21:58 |
| *** ericpeterson has quit IRC | 21:58 | |
| tjones1 | hurgleburgler: https://review.openstack.org/#/c/195751/ finally passed tempest if you have time to take another look | 21:58 |
| TravT | fwiw on projects. they appear to be able to be listed flat or by filtering with a parent id. | 22:01 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Extending Karma config https://review.openstack.org/198073 | 22:01 |
| *** nzeplowi has joined #openstack-horizon | 22:01 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Fix eslint errors on the login controller https://review.openstack.org/198148 | 22:02 |
| *** lhcheng has quit IRC | 22:03 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Dashboard ReOrg - Create 'project' module https://review.openstack.org/196271 | 22:03 |
| openstackgerrit | Merged openstack/horizon: JSCS cleanup - launch-instance.js https://review.openstack.org/196881 | 22:05 |
| tqtran | david-lyle: did we intentionally turn off integration test at the gate again? lol | 22:05 |
| *** rwsu has quit IRC | 22:05 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Fix eslint errors on the login controller https://review.openstack.org/198152 | 22:05 |
| david-lyle | tqtran: yes, it's too flakey | 22:07 |
| david-lyle | until it's actually solid and we don't have 3-4 skipped tests, there is no reason to have it voting | 22:07 |
| david-lyle | doesn't mean it should be ignored | 22:07 |
| tqtran | yeah, i wanna come around to it at some point | 22:08 |
| TravT | tqtran: for you: http://i1.wp.com/www.brooksgroup.com/assets/2013/08/Round-tuit1.jpg?resize=250%2C254 | 22:11 |
| tqtran | lol ok took me a few seconds to figure out what it means | 22:12 |
| tqtran | doit tuit | 22:12 |
| TravT | that was your lame joke of the day. :P | 22:12 |
| tqtran | lol | 22:12 |
| *** cody-somerville has quit IRC | 22:13 | |
| *** rajatvig has quit IRC | 22:16 | |
| *** Longgeek has joined #openstack-horizon | 22:17 | |
| *** chlong has joined #openstack-horizon | 22:18 | |
| openstackgerrit | Tracy Jones proposed openstack/horizon: move favicon, logo and logo-splash to default theme https://review.openstack.org/195751 | 22:19 |
| *** nzeplowi has quit IRC | 22:19 | |
| *** nzeplowi has joined #openstack-horizon | 22:20 | |
| tjones1 | thanks btully - i fixed the tab issues | 22:20 |
| *** rajatvig has joined #openstack-horizon | 22:21 | |
| *** sayan has quit IRC | 22:23 | |
| tqtran | sqchen, TravT: guys, theres a bunch of test failures when i ran the jasmine test runner | 22:23 |
| tqtran | i think it might be because of https://review.openstack.org/#/c/196881/ | 22:24 |
| TravT | oh no. | 22:25 |
| TravT | let me try it out | 22:25 |
| *** Longgeek has quit IRC | 22:25 | |
| sqchen | Let me run the tests. | 22:25 |
| tqtran | yup, just confirmed it | 22:25 |
| tqtran | i went back a patch and it all work | 22:25 |
| *** mwhagedorn has quit IRC | 22:26 | |
| sqchen | all green to me. | 22:26 |
| tqtran | really? let me try again | 22:27 |
| sqchen | webroot patch has some broken tests, I am fixing it. | 22:27 |
| TravT | so, i had run npm run test and i manually tested launch instance. | 22:27 |
| TravT | but i just ran jasmine on this one manually and i do see some failures | 22:27 |
| sqchen | I run the jasmine tests with latest master. | 22:28 |
| TravT | actually tqtran | 22:28 |
| TravT | i just forced a clean cache and it runs fine | 22:28 |
| tqtran | hm wth, it seems to run fine for me as well now | 22:28 |
| tqtran | must have been a cache issue then | 22:28 |
| sqchen | cool. :) | 22:29 |
| *** sambetts has quit IRC | 22:29 | |
| TravT | i've been trying to remember to run jasmine manually on patches as well. | 22:29 |
| tqtran | ok false alarm lol | 22:29 |
| *** sambetts has joined #openstack-horizon | 22:29 | |
| TravT | tqtran is ejected | 22:29 |
| tqtran | :( | 22:29 |
| TravT | :P | 22:29 |
| * TravT wonders what he was doing... | 22:30 | |
| sqchen | guys, https://review.openstack.org/#/c/198073/ is updated :) | 22:30 |
| sqchen | since you guys are here ;) | 22:30 |
| TravT | ok, i'll look in just a sec. i was in the middle of another review and almost done. | 22:30 |
| sqchen | sure, :) | 22:31 |
| tqtran | also sean, https://review.openstack.org/#/c/197373/ regarding the _ prefix | 22:32 |
| tqtran | i think its fine to keep the standard? unless you have something else in mind | 22:33 |
| *** peristeri has quit IRC | 22:33 | |
| sqchen | are they still django template? | 22:33 |
| tqtran | they are not | 22:34 |
| tqtran | but i still want to indicate that they are partial templates | 22:34 |
| sqchen | if they django templates, the naming is correct, if they are static html template for angular, they are odd. | 22:34 |
| TravT | tqtran: we've used dashes in the other angular partials. | 22:35 |
| TravT | let me grab an example | 22:35 |
| tqtran | like table-row.html? | 22:35 |
| TravT | https://github.com/openstack/horizon/tree/master/openstack_dashboard/static/dashboard/launch-instance/security-groups | 22:35 |
| *** annashen has quit IRC | 22:36 | |
| tqtran | hm..... i see i think the security-groups-* might be excessive | 22:38 |
| tqtran | since you're already in the security-groups folder | 22:38 |
| tqtran | i can't think of an advantage of having such a long name? | 22:39 |
| sqchen | I have help-panel.scss, help-panel.xxx.js and then, help-panel.html, make sense? :) | 22:39 |
| *** skylerberg has joined #openstack-horizon | 22:40 | |
| TravT | tqtran: tangent switch through me off for a minute. | 22:40 |
| TravT | yes, the long name may be excessive, but that still is representative of what we've been doing. | 22:40 |
| tqtran | sqchen: that make sense | 22:40 |
| TravT | can dig for more | 22:40 |
| tqtran | im fine with renaming it to table-headers.html, table-*.html | 22:41 |
| tqtran | would that suffice for you folks? | 22:41 |
| sqchen | yep. | 22:42 |
| TravT | yeah, like sean, still need to look through rest of patch. was on my todo today, but time is running out. | 22:42 |
| *** amit213 has quit IRC | 22:42 | |
| tqtran | JULY 4th!!!!!!!!!! | 22:42 |
| TravT | woot! | 22:42 |
| TravT | do you guys have the day off tomorrow? | 22:43 |
| skylerberg | Is the customization_module setting something that should be used for a plugin to alter existing tables? (for reference http://docs.openstack.org/developer/horizon/topics/customizing.html#modifying-existing-dashboards-and-panels) | 22:43 |
| sqchen | I will take one day off. | 22:43 |
| TravT | yeah, i'm taking friday off, but will be back on Monday | 22:43 |
| openstackgerrit | Merged openstack/horizon: JSCS Cleanup - rename *.factory.js to *.service.js https://review.openstack.org/197340 | 22:44 |
| openstackgerrit | Merged openstack/horizon: Angular translation via babel (singular only) https://review.openstack.org/192035 | 22:44 |
| skylerberg | I am a little bit hesitant to use customization_module because it doesn't appear to allow more than one such customization, which would indicated that it is not meant for plugins. | 22:44 |
| *** dboik has joined #openstack-horizon | 22:46 | |
| tqtran | i have tomorrow off | 22:46 |
| tqtran | according to clu_ | 22:46 |
| sqchen | tqtran, TravT the same here. | 22:47 |
| tqtran | skylerberg: couldn't you just extend whatever you want to modify? | 22:47 |
| clu_ | tqtran: lemme find you proof, just in case :D | 22:47 |
| skylerberg | tqtran: You mean inside a module loaded with customization_module, or is there another way to extend them? | 22:48 |
| TravT | geez, about 5 interruptions at once just now... bbiab | 22:48 |
| tqtran | you should be able to extend them inside your own customization module as well | 22:49 |
| tqtran | skylerberg: ^---- | 22:49 |
| *** dboik has quit IRC | 22:50 | |
| *** Drago has quit IRC | 22:51 | |
| skylerberg | tqtran: My reservation about using customization module is that it seems to not support more than one module. That would not really work for plugins because then if anyone else tried the same thing the user would have to choose. | 22:51 |
| tqtran | right, if that is your concern, then create a plugin that extends an existing table | 22:51 |
| tqtran | this way, you have 2 tables, one that is the origin, and another that inherits from the origin but lives in a different panel | 22:52 |
| tqtran | maybe im not understanding you correctly :P that is also entirely possible | 22:52 |
| skylerberg | tqtran: If I understand what you are suggesting it is to add another panel so that there user would be able to select say "Instances" and see the original or "MyInstances" and see the modified one? | 22:53 |
| *** annashen has joined #openstack-horizon | 22:53 | |
| tqtran | yes that is correct | 22:53 |
| tqtran | but the MyInstances panel can live in a plugin folder, so you dont have to modify source | 22:54 |
| tqtran | i mean trunk/master/whatever | 22:54 |
| skylerberg | tqtran: That would work and be easy for users to add | 22:55 |
| skylerberg | but it wouldn't be a particularly seamless experience for the users in horizon. | 22:55 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding identity users table https://review.openstack.org/197373 | 22:55 |
| *** Sukhdev has quit IRC | 22:56 | |
| tqtran | what do you mean when you say "not support more than one module"? | 22:56 |
| skylerberg | tqtran: Say as part of installing a plugin you have to edit local_settings HORIZON_CONFIG and you add "customization_module": "my_project.overrides" | 22:57 |
| skylerberg | There is only one slot for a customization module. | 22:58 |
| skylerberg | So no other plugin could that did the same thing could work at the same time. | 22:58 |
| *** nzeplowi has quit IRC | 22:59 | |
| *** lhcheng has joined #openstack-horizon | 23:00 | |
| tqtran | skylerberg: ok got what you're saying | 23:00 |
| tqtran | next question: what exactly are you trying to do in the your customization_module? | 23:01 |
| *** nzeplowi has joined #openstack-horizon | 23:02 | |
| tqtran | it might be entirely possible to use the plugin mechanism instead if you are not looking to modify existing dashboards/panels | 23:02 |
| *** annashen has quit IRC | 23:02 | |
| skylerberg | tqtran: Right now I am evaluating if I can add information to rows for instances or volumes. For example, an extra column could say whether or not a volume uses a vendor specific setting. | 23:04 |
| tqtran | and you're afraid that by modifying something using this customization_module, there will be conflicts with other other's customization_module | 23:06 |
| skylerberg | tqtran: Yeah. I am also worried that I would be using the feature in a way it was not intended to be used and could run into trouble later. | 23:07 |
| tqtran | thats a valid concern, dont think we have a great solution for it atm. david-lyle? | 23:08 |
| skylerberg | taking the customization_module approach could also be problematic because it doesn't really offer any contract. Later changes could easily be breaking. For example, if I add a column and then a column name changes in a later release, the plugin would break. | 23:10 |
| tqtran | i also dont think there is a good solution for that today even | 23:11 |
| tqtran | if im using some 3rd party libary, and things change, i have to manually update my code | 23:11 |
| tqtran | if i want to upgrade to the greatest and latest | 23:11 |
| tqtran | at some point, you will have to manually merge code, not sure if its entirely possible to avoid that | 23:12 |
| *** rajatvig has quit IRC | 23:12 | |
| tqtran | when you get a chance, maybe talk to david-lyle or send out a ML. he's probably better equip to answer your questions than i am :) | 23:13 |
| skylerberg | Alright. Thanks for all the help! | 23:14 |
| *** raildo_ has joined #openstack-horizon | 23:20 | |
| *** nzeplowi_ has joined #openstack-horizon | 23:22 | |
| *** varoske has quit IRC | 23:22 | |
| *** ZZelle_ has quit IRC | 23:23 | |
| openstackgerrit | Andrew Bogott proposed openstack/horizon: Exclude images with the 'deprecated' property from the image pick-list. https://review.openstack.org/197306 | 23:23 |
| *** kzaitsev_mb has quit IRC | 23:23 | |
| *** yamamoto has joined #openstack-horizon | 23:24 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 23:24 |
| *** nzeplowi has quit IRC | 23:25 | |
| *** Sukhdev has joined #openstack-horizon | 23:27 | |
| *** mpavlase has quit IRC | 23:28 | |
| *** nzeplowi_ has quit IRC | 23:31 | |
| *** alexvictorchan has quit IRC | 23:32 | |
| *** alexpilotti has joined #openstack-horizon | 23:32 | |
| *** nzeplowi has joined #openstack-horizon | 23:33 | |
| *** nzeplowi has quit IRC | 23:36 | |
| *** chlong has quit IRC | 23:36 | |
| *** alexpilotti has quit IRC | 23:38 | |
| TravT | tqtran: sqchen: any time to talk about my comments on https://review.openstack.org/#/c/197373/ | 23:38 |
| tqtran | i dont really like it either | 23:39 |
| tqtran | but thats what it is, and if you modify it now, it will break existing plugins | 23:39 |
| tqtran | so that is a no go | 23:39 |
| TravT | it will? | 23:39 |
| TravT | the static is fine. | 23:39 |
| TravT | hmmm... | 23:39 |
| TravT | i see what you are saying partially... | 23:40 |
| *** nzeplowi has joined #openstack-horizon | 23:40 | |
| TravT | maybe a new setting on the enabled file? | 23:40 |
| TravT | BASE_STATIC_PATH | 23:40 |
| tqtran | don't introduce more problems :P | 23:40 |
| tqtran | if you keep rewriting as you go, you will never get to the end | 23:41 |
| TravT | this double nesting is kinda crazy though | 23:41 |
| tqtran | it is, but that is how it is today, and another problem for another day | 23:41 |
| TravT | now if you rename a dashboard, you have to rename in another place | 23:41 |
| TravT | now as in with all this new code. | 23:41 |
| tqtran | i would prefer to tackle this as a different problem | 23:42 |
| sqchen | I like Travis idea, but those static finder for scss/css and js is not under our control | 23:42 |
| tqtran | sqchen: you can probably rewrite it, but thats a whole other beast that i dont wanna touch | 23:42 |
| TravT | i just have nightmares of long ago trying to learn horizon by working from shell into a remote VM. | 23:42 |
| tqtran | not to mention that it will break existing plugins if you modify it | 23:43 |
| TravT | it was like inception and this is another iteration on that | 23:43 |
| tqtran | its really not that bad, just over look it for now. and after we get standard on angular, you are free to propose a different mechanism for collecting statics | 23:43 |
| tqtran | but i dont want to weave one problem into another and keep delaying a standard angular dashboard | 23:44 |
| tqtran | we have enough problems already | 23:44 |
| *** alexpilotti has joined #openstack-horizon | 23:44 | |
| sqchen | I think the root `issue` is, client-side code is nested in Djanog’s server side code, but we couldn’t fix it easily. | 23:45 |
| * TravT begrudgingly thinks you are probably right, but not happy | 23:45 | |
| *** alexpilotti has quit IRC | 23:46 | |
| tqtran | :) trust me, i hated it too | 23:47 |
| *** yamamoto has quit IRC | 23:47 | |
| tqtran | tyr and i had a long talk about it | 23:47 |
| TravT | as david-lyle said earlier... i threw up in my mouth just a bit when I pulled those two patches and encountered the structure. | 23:47 |
| lhcheng | TravT: you can add one more on the list of tech debt :) | 23:47 |
| TravT | lhcheng: lol... | 23:48 |
| TravT | lhcheng, maybe you could take a look and see what you think. | 23:48 |
| sqchen | I personaly prefer to have all static code under one static folder, I think that is acheivable. | 23:48 |
| *** zhenguo has joined #openstack-horizon | 23:48 | |
| tqtran | it is not sqchen, think plugins guys | 23:49 |
| tqtran | you cant have one static folder for plugins, it just doesnt work | 23:49 |
| sqchen | but for external plugins, they need a convention… | 23:49 |
| TravT | an external static folder would like look like this internal plugin folder structure though. | 23:50 |
| TravT | which doesn't really solve the cringing i had when encountering it. | 23:50 |
| tqtran | i would say, think about it some more and whether it is worth the effort. | 23:51 |
| lhcheng | TravT: the angular stuff should are new code that should be easier to read and maintain, not harder | 23:51 |
| tqtran | ok lets just rewrite the plugin mechanism then | 23:52 |
| *** mayurig has quit IRC | 23:52 | |
| TravT | i like self contained plugins, speaking to tqtran's points. | 23:52 |
| * tqtran being sarcastic. | 23:52 | |
| TravT | sqchen, if i just dismissed something you have a good idea around, please interject | 23:52 |
| lhcheng | tqtran: lol.. I was going to say let's do it :P | 23:53 |
| tqtran | lhcheng: lol do i have a volunteer? | 23:54 |
| lhcheng | TravT: self contained plugin sounds good | 23:54 |
| sqchen | no, TravT. I like selfcomtain as well. | 23:54 |
| tqtran | there's definitely room for plugin improvements, but the timing is probably not right now | 23:55 |
| * lhcheng ducks | 23:55 | |
| sqchen | let me take the nested path as a cost for it. :) | 23:55 |
| *** andrewbogott is now known as andrewbogott_afk | 23:55 | |
| lhcheng | I think this is the right timing, otherwise we might be building on technical debt.. with interest :) | 23:55 |
| *** nzeplowi_ has joined #openstack-horizon | 23:55 | |
| sqchen | tqtran: agreed | 23:55 |
| tqtran | and what about existing plugins? we just say, you're screwed? | 23:56 |
| TravT | you said it, not me | 23:56 |
| TravT | ;) | 23:56 |
| TravT | seriously, you know from all our conversations that I've never advocating for leaving people screwed... | 23:57 |
| *** nzeplowi_ has quit IRC | 23:57 | |
| tqtran | hahaha, im with sqchen here, if looking at nested folder is the cost, then im gonna overlook it. we have enough problems to tackle, lets not add another obstacle to overcome | 23:57 |
| TravT | for the tooling "not in our control", have we checked if there are any existing configuration options here? | 23:57 |
| sqchen | our we can have a preperty for each enabled stuff, like PLUGIN_PATH. | 23:58 |
| lhcheng | tqtran: propose a better plugin for angular, then we're going to support both. angular are new stuff anyway, there won't be operator using it yet. | 23:58 |
| lhcheng | and deprecate the old plugin config as we move everything to angular | 23:58 |
| sqchen | PLUGIN_PATH = /dashboard/ | 23:58 |
| *** nzeplowi has quit IRC | 23:59 | |
| tqtran | lhcheng: my priority right now is to get us an angular dashboard. that's an entirely differently problem i don't want to tackle. | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
