| *** Longgeek has quit IRC | 00:00 | |
| *** chlong has joined #openstack-horizon | 00:04 | |
| *** stevemar has quit IRC | 00:10 | |
| *** stevemar has joined #openstack-horizon | 00:10 | |
| *** stevemar has quit IRC | 00:19 | |
| *** stevemar has joined #openstack-horizon | 00:20 | |
| *** darrenc is now known as darrenc_afk | 00:26 | |
| *** jamielennox is now known as jamielennox|away | 00:26 | |
| *** jamielennox|away is now known as jamielennox | 00:30 | |
| *** hurgleburgler has quit IRC | 00:34 | |
| *** sputnik1_ has quit IRC | 00:38 | |
| *** darrenc_afk is now known as darrenc | 00:58 | |
| *** zhenguo has joined #openstack-horizon | 01:16 | |
| *** drupalmonkey has quit IRC | 01:34 | |
| openstackgerrit | Li Yingjun proposed openstack/horizon: [Launch instance Fix] Fixes booting issue when booting from volume https://review.openstack.org/191716 | 01:36 |
|---|---|---|
| *** jasondotstar has joined #openstack-horizon | 01:40 | |
| *** Longgeek has joined #openstack-horizon | 01:59 | |
| *** hurgleburgler has joined #openstack-horizon | 02:00 | |
| *** Sukhdev has joined #openstack-horizon | 02:01 | |
| *** iamjarvo_ has joined #openstack-horizon | 02:01 | |
| *** drupalmonkey has joined #openstack-horizon | 02:05 | |
| *** hurgleburgler1 has joined #openstack-horizon | 02:07 | |
| *** stevemar has quit IRC | 02:07 | |
| *** hurgleburgler has quit IRC | 02:07 | |
| *** stevemar has joined #openstack-horizon | 02:08 | |
| *** hurgleburgler1 has quit IRC | 02:10 | |
| *** hurgleburgler has joined #openstack-horizon | 02:10 | |
| *** Longgeek has quit IRC | 02:11 | |
| *** dboik has quit IRC | 02:16 | |
| *** hurgleburgler has quit IRC | 02:16 | |
| *** hurgleburgler has joined #openstack-horizon | 02:17 | |
| *** yamamoto has joined #openstack-horizon | 02:18 | |
| *** hurgleburgler1 has joined #openstack-horizon | 02:20 | |
| *** hurgleburgler has quit IRC | 02:20 | |
| *** hurgleburgler1 has quit IRC | 02:22 | |
| *** hurgleburgler has joined #openstack-horizon | 02:22 | |
| *** hurgleburgler1 has joined #openstack-horizon | 02:25 | |
| *** hurgleburgler has quit IRC | 02:25 | |
| *** ducttape_ has joined #openstack-horizon | 02:26 | |
| *** hurgleburgler1 has quit IRC | 02:29 | |
| *** hurgleburgler has joined #openstack-horizon | 02:29 | |
| *** stevemar has quit IRC | 02:30 | |
| *** stevemar has joined #openstack-horizon | 02:31 | |
| *** hurgleburgler1 has joined #openstack-horizon | 02:32 | |
| *** hurgleburgler has quit IRC | 02:32 | |
| *** hurgleburgler1 has quit IRC | 02:34 | |
| *** hurgleburgler has joined #openstack-horizon | 02:34 | |
| *** ducttape_ has quit IRC | 02:36 | |
| *** neelashah1 has joined #openstack-horizon | 02:42 | |
| *** iamjarvo_ has quit IRC | 02:43 | |
| *** iamjarvo has joined #openstack-horizon | 02:44 | |
| *** sputnik13 has joined #openstack-horizon | 02:55 | |
| *** neelashah1 has quit IRC | 02:55 | |
| *** Longgeek has joined #openstack-horizon | 03:07 | |
| *** flwang1 has quit IRC | 03:11 | |
| *** piyanai has joined #openstack-horizon | 03:14 | |
| *** Longgeek has quit IRC | 03:20 | |
| *** flwang1 has joined #openstack-horizon | 03:20 | |
| *** piyanai has quit IRC | 03:25 | |
| *** hurgleburgler1 has joined #openstack-horizon | 03:29 | |
| *** hurgleburgler has quit IRC | 03:29 | |
| *** hurgleburgler has joined #openstack-horizon | 03:31 | |
| *** hurgleburgler1 has quit IRC | 03:31 | |
| *** jasondotstar has quit IRC | 03:32 | |
| *** jasondotstar has joined #openstack-horizon | 03:33 | |
| *** hurgleburgler has quit IRC | 03:34 | |
| *** hurgleburgler1 has joined #openstack-horizon | 03:34 | |
| *** hurgleburgler has joined #openstack-horizon | 03:36 | |
| *** hurgleburgler1 has quit IRC | 03:36 | |
| *** hurgleburgler1 has joined #openstack-horizon | 03:37 | |
| *** hurgleburgler1 has quit IRC | 03:40 | |
| *** hurgleburgler2 has joined #openstack-horizon | 03:40 | |
| *** hurgleburgler has quit IRC | 03:41 | |
| *** hurgleburgler has joined #openstack-horizon | 03:42 | |
| *** hurgleburgler2 has quit IRC | 03:43 | |
| *** hurgleburgler has quit IRC | 03:45 | |
| *** hurgleburgler has joined #openstack-horizon | 03:45 | |
| *** hurgleburgler1 has joined #openstack-horizon | 03:48 | |
| *** hurgleburgler has quit IRC | 03:48 | |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Fix _get_tenant_volume_usages https://review.openstack.org/196523 | 03:49 |
| *** rushiagr_away is now known as rushiagr | 03:57 | |
| *** Sukhdev has quit IRC | 04:01 | |
| *** rushiagr is now known as rushiagr_away | 04:03 | |
| *** stevemar has quit IRC | 04:03 | |
| *** stevemar has joined #openstack-horizon | 04:04 | |
| *** hurgleburgler has joined #openstack-horizon | 04:13 | |
| *** hurgleburgler1 has quit IRC | 04:13 | |
| *** hurgleburgler1 has joined #openstack-horizon | 04:16 | |
| *** hurgleburgler has quit IRC | 04:16 | |
| *** hurgleburgler1 has quit IRC | 04:18 | |
| *** hurgleburgler has joined #openstack-horizon | 04:18 | |
| *** hurgleburgler1 has joined #openstack-horizon | 04:21 | |
| *** hurgleburgler has quit IRC | 04:21 | |
| *** kiran-r has joined #openstack-horizon | 04:23 | |
| *** hurgleburgler1 has quit IRC | 04:23 | |
| *** hurgleburgler has joined #openstack-horizon | 04:24 | |
| *** hurgleburgler1 has joined #openstack-horizon | 04:26 | |
| *** hurgleburgler has quit IRC | 04:26 | |
| *** hurgleburgler1 has quit IRC | 04:28 | |
| *** hurgleburgler has joined #openstack-horizon | 04:29 | |
| *** kzaitsev_mb has joined #openstack-horizon | 04:29 | |
| *** hurgleburgler1 has joined #openstack-horizon | 04:31 | |
| *** hurgleburgler has quit IRC | 04:31 | |
| *** hurgleburgler1 has quit IRC | 04:34 | |
| *** hurgleburgler has joined #openstack-horizon | 04:34 | |
| *** masco_ has joined #openstack-horizon | 04:43 | |
| *** tjones1 has joined #openstack-horizon | 04:44 | |
| *** kzaitsev_mb has quit IRC | 04:53 | |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Fix _get_tenant_volume_usages https://review.openstack.org/196523 | 04:53 |
| *** kzaitsev_mb has joined #openstack-horizon | 04:57 | |
| *** kiran-r has quit IRC | 05:03 | |
| openstackgerrit | mariam john proposed openstack/horizon: DataTable column level policy https://review.openstack.org/164010 | 05:07 |
| *** hurgleburgler1 has joined #openstack-horizon | 05:15 | |
| *** hurgleburgler has quit IRC | 05:16 | |
| *** Longgeek has joined #openstack-horizon | 05:17 | |
| *** hurgleburgler1 has quit IRC | 05:18 | |
| *** hurgleburgler has joined #openstack-horizon | 05:18 | |
| *** shivrao has joined #openstack-horizon | 05:20 | |
| *** hurgleburgler has quit IRC | 05:20 | |
| *** hurgleburgler1 has joined #openstack-horizon | 05:20 | |
| *** drupalmonkey has quit IRC | 05:22 | |
| *** hurgleburgler1 has quit IRC | 05:23 | |
| *** hurgleburgler has joined #openstack-horizon | 05:23 | |
| *** Longgeek has quit IRC | 05:25 | |
| *** Longgeek has joined #openstack-horizon | 05:25 | |
| *** hurgleburgler1 has joined #openstack-horizon | 05:26 | |
| *** kzaitsev_mb has quit IRC | 05:27 | |
| *** kzaitsev_mb has joined #openstack-horizon | 05:27 | |
| *** shivrao_ has joined #openstack-horizon | 05:27 | |
| *** shivrao has quit IRC | 05:28 | |
| *** shivrao_ is now known as shivrao | 05:28 | |
| *** hurgleburgler has quit IRC | 05:28 | |
| *** hurgleburgler1 has quit IRC | 05:29 | |
| *** hurgleburgler has joined #openstack-horizon | 05:29 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: Added 'enabled' option in create user form https://review.openstack.org/194967 | 05:32 |
| *** Longgeek has quit IRC | 05:34 | |
| *** Longgeek has joined #openstack-horizon | 05:34 | |
| *** tjones1 has quit IRC | 05:36 | |
| *** hurgleburgler has quit IRC | 05:37 | |
| *** hurgleburgler has joined #openstack-horizon | 05:37 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: Remove current QoS spec in volume type https://review.openstack.org/193504 | 05:38 |
| *** iamjarvo has quit IRC | 05:39 | |
| *** hurgleburgler has quit IRC | 05:41 | |
| *** hurgleburgler has joined #openstack-horizon | 05:41 | |
| *** mpavlase has joined #openstack-horizon | 05:42 | |
| *** shivrao has quit IRC | 05:43 | |
| *** hurgleburgler has quit IRC | 05:44 | |
| *** hurgleburgler has joined #openstack-horizon | 05:44 | |
| *** jasondotstar has quit IRC | 05:53 | |
| *** iamjarvo has joined #openstack-horizon | 05:54 | |
| *** iamjarvo has quit IRC | 06:02 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/196419 | 06:05 |
| openstackgerrit | Canh Truong proposed openstack/horizon: Wrong url in document of horizon tutorial https://review.openstack.org/185346 | 06:10 |
| *** jtomasek has joined #openstack-horizon | 06:13 | |
| *** stevemar has quit IRC | 06:16 | |
| *** stevemar has joined #openstack-horizon | 06:16 | |
| *** hurgleburgler has quit IRC | 06:19 | |
| *** oro has joined #openstack-horizon | 06:20 | |
| *** kzaitsev_mb has quit IRC | 06:23 | |
| *** stevemar has quit IRC | 06:30 | |
| openstackgerrit | mariam john proposed openstack/horizon: Add support for root enable and show https://review.openstack.org/183196 | 06:44 |
| *** oro has quit IRC | 06:55 | |
| *** MaxV has joined #openstack-horizon | 07:04 | |
| *** ccard_ has quit IRC | 07:09 | |
| *** Longgeek has quit IRC | 07:13 | |
| *** Longgeek has joined #openstack-horizon | 07:13 | |
| *** Ala has joined #openstack-horizon | 07:16 | |
| *** amotoki has joined #openstack-horizon | 07:17 | |
| *** leanderthal has left #openstack-horizon | 07:21 | |
| *** mrunge has joined #openstack-horizon | 07:24 | |
| *** nlahouti has joined #openstack-horizon | 07:25 | |
| *** lsmola has joined #openstack-horizon | 07:26 | |
| *** yamamoto has quit IRC | 07:27 | |
| *** zz_ttrifonov is now known as ttrifonov | 07:27 | |
| *** nlahouti has quit IRC | 07:28 | |
| *** nlahouti has joined #openstack-horizon | 07:28 | |
| *** stevemar has joined #openstack-horizon | 07:30 | |
| *** yamamoto has joined #openstack-horizon | 07:31 | |
| *** stevemar has quit IRC | 07:33 | |
| *** markus_z has joined #openstack-horizon | 07:37 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/196419 | 07:40 |
| *** jtomasek has quit IRC | 07:42 | |
| *** kiran-r has joined #openstack-horizon | 07:42 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 07:57 | |
| *** chlong has quit IRC | 08:03 | |
| *** ygbo has joined #openstack-horizon | 08:13 | |
| *** dguerri` is now known as dguerri | 08:23 | |
| *** jtomasek has joined #openstack-horizon | 08:28 | |
| *** Longgeek has quit IRC | 08:38 | |
| openstackgerrit | Gerome Chardon proposed openstack/horizon: Glance Image Member Management https://review.openstack.org/195460 | 08:43 |
| *** JeanBriceCombebi has quit IRC | 08:50 | |
| *** oro has joined #openstack-horizon | 08:50 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:02 | |
| *** belmoreira has joined #openstack-horizon | 09:10 | |
| *** yamamoto has quit IRC | 09:11 | |
| *** Longgeek has joined #openstack-horizon | 09:12 | |
| *** JeanBriceCombebi has quit IRC | 09:14 | |
| *** fnordahl has quit IRC | 09:15 | |
| *** fnordahl has joined #openstack-horizon | 09:17 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:17 | |
| *** bluex-pl has joined #openstack-horizon | 09:18 | |
| *** bluex-pl has quit IRC | 09:19 | |
| *** bluex-pl has joined #openstack-horizon | 09:19 | |
| *** tosky has joined #openstack-horizon | 09:19 | |
| *** stevemar has joined #openstack-horizon | 09:20 | |
| *** robcresswell has joined #openstack-horizon | 09:21 | |
| *** stevemar has quit IRC | 09:22 | |
| *** yamamoto has joined #openstack-horizon | 09:29 | |
| *** henrynash has quit IRC | 09:30 | |
| *** pkarikh has joined #openstack-horizon | 09:31 | |
| openstackgerrit | Merged openstack/horizon: Added 'enabled' option in create user form https://review.openstack.org/194967 | 09:48 |
| openstackgerrit | Kuo-tung Kao proposed openstack/horizon: changing email from user list deletes user passwd https://review.openstack.org/196605 | 09:51 |
| *** aix has joined #openstack-horizon | 09:53 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: Useing 'yesno' filter to display Boolean value https://review.openstack.org/196606 | 09:53 |
| *** openstackgerrit has quit IRC | 09:53 | |
| *** openstackgerrit has joined #openstack-horizon | 09:53 | |
| *** JeanBriceCombebi has quit IRC | 09:57 | |
| *** akrivoka has joined #openstack-horizon | 09:59 | |
| *** uschreiber_ has joined #openstack-horizon | 10:03 | |
| *** uschreiber_ has quit IRC | 10:05 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 10:05 | |
| *** JeanBriceCombebi has quit IRC | 10:16 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 10:25 | |
| *** henrynash has joined #openstack-horizon | 10:26 | |
| openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Update project list in the header bar. https://review.openstack.org/184257 | 10:26 |
| openstackgerrit | Tatiana Ovchinnikova proposed openstack/horizon: Error message for invalid cluster template details page https://review.openstack.org/196616 | 10:28 |
| *** Piet has quit IRC | 10:30 | |
| *** MaxV has quit IRC | 10:31 | |
| *** JeanBriceCombebi has quit IRC | 10:36 | |
| *** ducttape_ has joined #openstack-horizon | 10:36 | |
| *** bluex-pl has quit IRC | 10:41 | |
| *** henrynash has quit IRC | 10:42 | |
| *** eandersson has joined #openstack-horizon | 10:43 | |
| eandersson | Is there an easy solution for loading issues when one site is down? Horizon gets stuck for 5-20minutes trying to connect to an unaccsible nova endpoint. | 10:44 |
| *** henrynash has joined #openstack-horizon | 10:47 | |
| mrunge | eandersson, good question | 10:49 |
| mrunge | eandersson, the thing is, you can not really use horizon, if nova is down | 10:49 |
| mrunge | or keystone | 10:49 |
| *** tosky_ has joined #openstack-horizon | 10:49 | |
| mrunge | eandersson, that's infrastructure for your cloud infrastructure. it should be highly available | 10:50 |
| *** tosky__ has joined #openstack-horizon | 10:52 | |
| *** tosky has quit IRC | 10:53 | |
| *** tosky_ has quit IRC | 10:54 | |
| *** tosky__ is now known as tosky | 10:54 | |
| eandersson | Yea, exactly. I mean for production it would never be down, but my concern is what if we are doing maintenance on one site, and it is causing Horizon to become unavailable for anyone that has that region selected. | 10:55 |
| *** Gal has joined #openstack-horizon | 10:57 | |
| Gal | Hi guys, could kindly use your help to review my blueprint https://blueprints.launchpad.net/horizon/+spec/stack-add-additional-files | 10:58 |
| *** ducttape_ has quit IRC | 10:59 | |
| robcresswell | Gal: Can you base it off the template? https://blueprints.launchpad.net/horizon/+spec/template | 11:03 |
| Gal | yeah, tnx | 11:07 |
| *** yamamoto has quit IRC | 11:08 | |
| *** henrynash has quit IRC | 11:18 | |
| openstackgerrit | Tatiana Ovchinnikova proposed openstack/horizon: Error message for invalid node group template details page https://review.openstack.org/196630 | 11:23 |
| *** bluex-pl has joined #openstack-horizon | 11:25 | |
| *** dguerri is now known as dguerri` | 11:28 | |
| openstackgerrit | Tatiana Ovchinnikova proposed openstack/horizon: Error message for invalid cluster template details page https://review.openstack.org/196616 | 11:28 |
| *** mpavlase has joined #openstack-horizon | 11:29 | |
| openstackgerrit | Carlos Gonçalves proposed openstack/horizon: Add 'Download Image' option to Images table https://review.openstack.org/74799 | 11:34 |
| *** SimonChung1 has quit IRC | 11:40 | |
| *** SimonChung has joined #openstack-horizon | 11:40 | |
| *** iamjarvo has joined #openstack-horizon | 11:40 | |
| *** MaxV has joined #openstack-horizon | 11:44 | |
| *** dguerri` is now known as dguerri | 11:48 | |
| *** bfic has joined #openstack-horizon | 11:54 | |
| openstackgerrit | Tatiana Ovchinnikova proposed openstack/horizon: Error message for invalid node group template details page https://review.openstack.org/196630 | 11:56 |
| *** SimonChung has quit IRC | 11:57 | |
| *** SimonChung has joined #openstack-horizon | 11:57 | |
| *** yamamoto has joined #openstack-horizon | 12:01 | |
| *** markus_z has quit IRC | 12:01 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 12:01 | |
| *** mrunge has quit IRC | 12:02 | |
| *** markus_z has joined #openstack-horizon | 12:06 | |
| *** mrunge has joined #openstack-horizon | 12:07 | |
| *** sayan has joined #openstack-horizon | 12:10 | |
| *** eandersson has quit IRC | 12:12 | |
| *** yamamoto has quit IRC | 12:22 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: AngularJS in Horizon Documentation https://review.openstack.org/182243 | 12:24 |
| *** raildo has joined #openstack-horizon | 12:25 | |
| *** dguerri is now known as dguerri` | 12:28 | |
| *** JeanBriceCombebi has quit IRC | 12:29 | |
| *** yamamoto has joined #openstack-horizon | 12:30 | |
| *** kristen-young has quit IRC | 12:32 | |
| *** dguerri` is now known as dguerri | 12:32 | |
| *** masco_ has quit IRC | 12:32 | |
| openstackgerrit | Merged openstack/horizon: changing email from user list deletes user passwd https://review.openstack.org/196605 | 12:33 |
| *** Gal has quit IRC | 12:34 | |
| *** ducttape_ has joined #openstack-horizon | 12:35 | |
| *** yamamoto has quit IRC | 12:35 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 12:41 | |
| ducttape_ | mrunge - do you have a preference for blueprint vs bug: We would like to add a menu drop down in the lbaas area, where you can associate a floating ip with a lbaas vip. | 12:43 |
| ducttape_ | I'd add the code for it / up for review. Just wondered what the guidelines are for bug vs blueprint. | 12:44 |
| mrunge | ducttape_, good question. new features are blueprints for me | 12:44 |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Allow to edit image metadata from project view https://review.openstack.org/184280 | 12:44 |
| *** kiran-r has quit IRC | 12:44 | |
| ducttape_ | ok. thanks mrunge :D | 12:44 |
| mrunge | ducttape_, so: more blueprint than bug | 12:44 |
| robcresswell | I agree with mrunge. Features should be blueprints :) | 12:44 |
| ducttape_ | I like to sneak in features ;) | 12:45 |
| robcresswell | ducttape_: Yeah that's even more tempting when you can automatically approve your own code... | 12:46 |
| amotoki | For small features, either bug or blueprint works for me. | 12:46 |
| amotoki | Even if it is small but we need a design disucssion, blueprint would be better. | 12:46 |
| *** chlong has joined #openstack-horizon | 12:46 | |
| robcresswell | Very small features are a bit of a grey area. Personally I prefer blueprints where possible, because it's easier to divide up progress at the end of the cycle; list of "things fixed" vs list "features added" | 12:47 |
| amotoki | in addition, we can easily know what are added in Libety by using a blueprint :-) | 12:47 |
| amotoki | robcresswell: totally agree. The only merit to use a bug is to avoid our blueprint process. | 12:48 |
| robcresswell | amotoki: haha... that should not be a merit! :p | 12:48 |
| amotoki | hehe :p If so it is a symptom of failure of our process... | 12:49 |
| *** yamamoto has joined #openstack-horizon | 12:52 | |
| *** iamjarvo has quit IRC | 12:52 | |
| ducttape_ | https://blueprints.launchpad.net/horizon/+spec/lbaas-vip-fip-associate is what I was mentioning | 12:52 |
| *** piyanai has joined #openstack-horizon | 12:52 | |
| robcresswell | I've gone a bit review mad today btw, if anyone needs code looking over. | 12:54 |
| robcresswell | A little overdue on core duties :) | 12:54 |
| *** henrynash has joined #openstack-horizon | 12:56 | |
| tosky | ooo, robcresswell, so what do you think about those two backports? https://review.openstack.org/#/c/195657/ and https://review.openstack.org/#/c/195663/ | 12:57 |
| *** stevemar has joined #openstack-horizon | 12:57 | |
| *** radez_g0n3 is now known as radez | 12:57 | |
| *** josecastroleon has quit IRC | 12:57 | |
| robcresswell | tosky: I'm not core on the stables unfortunately, so can't help much with pushing code through | 12:59 |
| tosky | robcresswell: oh, thanks anyway; who can I nag for that? | 12:59 |
| tosky | more generally, what is the easier way to find the "core" for a certain project? I know the ones of sahara which I work more on, but I'm a bit lost when I go out of it | 13:00 |
| *** stevemar has quit IRC | 13:00 | |
| *** iamjarvo has joined #openstack-horizon | 13:00 | |
| robcresswell | tosky: both lhcheng and david-lyle are core for stables | 13:01 |
| *** iamjarvo has quit IRC | 13:01 | |
| robcresswell | tosky: https://review.openstack.org/#/admin/groups/43,members | 13:01 |
| tosky | robcresswell: thanks; so I need to convince lhcheng that the patch is needed, and to remove the -1 | 13:01 |
| robcresswell | tosky: Yup, pretty much | 13:02 |
| *** mrunge has quit IRC | 13:02 | |
| tosky | robcresswell: but that's the group for core, how to find for stable? | 13:02 |
| ducttape_ | I don't think there is a core group for stable vs other things | 13:03 |
| *** JeanBriceCombebi has quit IRC | 13:03 | |
| robcresswell | ducttape_: I'm unsure; I was under the impression there was. I've not been able to merge code to the stable branches afaik. | 13:04 |
| ducttape_ | mrunge would know, I think | 13:05 |
| *** fifieldt has joined #openstack-horizon | 13:06 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:07 | |
| amotoki | tosky: stable core team consists of two teams: stable-maint-core and per project stable core (horizon-stable-maint in this case). | 13:08 |
| amotoki | The reason we have a separate team for stable branches is they need to understand stable branch policies. | 13:09 |
| tosky | amotoki: thanks | 13:10 |
| amotoki | Honestly we don't have an explicit criteria for backporitng tests. | 13:11 |
| robcresswell | Yeah, can't just break things like us master branch cores -.- | 13:11 |
| amotoki | As I commented in the first review, it does not affect the qualify of our releases directly. | 13:11 |
| *** Ala has quit IRC | 13:11 | |
| amotoki | so we accept test changes in general to improve our test coverage and gate stability. | 13:11 |
| tosky | amotoki: I think I already mentioned it here: in Sahara we are likely moving to a separate repository for integration tests, to follow a branchless/always use master policy like in tempest | 13:12 |
| tosky | amotoki: maybe the same change could be planned for horizon | 13:13 |
| *** zhenguo has quit IRC | 13:13 | |
| amotoki | tosky: yes. I saw your comment. My comment is just to support your comment. | 13:14 |
| *** peristeri has joined #openstack-horizon | 13:14 | |
| *** gerchardon has quit IRC | 13:14 | |
| *** gerchardon has joined #openstack-horizon | 13:14 | |
| amotoki | tosky: one thing I haven't understood is whether planned changes in Sahara integration test affect stable branch testing or not. | 13:14 |
| *** yamamoto has quit IRC | 13:15 | |
| tosky | amotoki: the blueprint is not available yet, but the idea is to use integration tests from master; so also stable branches will use integration tests from master, afaik | 13:15 |
| tosky | amotoki: exactly like tempest does right now | 13:17 |
| amotoki | tosky: Neutron team moved our functional tests from tempest tree to neutron tree in the last release kilo. | 13:17 |
| amotoki | tosky: At that time, we keep the existing tests for stable branches so that we don't break anything in stable reviews. | 13:18 |
| amotoki | tosky: I am not sure what is the general appraoch which tempest team suggests. | 13:18 |
| amotoki | tosky: If it is suggested by QA team, i am okay with it and if I have a question I can ask them in -qa channel. | 13:18 |
| tosky | amotoki: uhm, maybe the existing tests in neutron stable branch where different enough; this is a different scenario | 13:19 |
| *** petertr7_away is now known as petertr7 | 13:20 | |
| tosky | amotoki: there are no existing tempest tests to be moved; there are just horizon tests in master; so you can | 13:20 |
| tosky | - implement "master tests should work on all supported branches" from liberty onward (and keep stable/kilo as it is) or | 13:20 |
| tosky | - horizon test from master to work on stable/kilo and do the change also on kilo | 13:21 |
| amotoki | tosky: got it. I thought we already have some integration tests for stable branches in tempest. | 13:21 |
| *** henrynash has quit IRC | 13:21 | |
| tosky | given that this is all a quite general discussion here, I bet the first option is the more realistic :) | 13:21 |
| *** akrivoka has quit IRC | 13:21 | |
| amotoki | yeah, generally speaking I like the approach of using master for all branches :) | 13:22 |
| *** neelashah1 has joined #openstack-horizon | 13:22 | |
| amotoki | tosky: thanks for your input. I got more clear understanding now. | 13:23 |
| *** cardeois has joined #openstack-horizon | 13:23 | |
| *** julim has joined #openstack-horizon | 13:24 | |
| *** yamamoto has joined #openstack-horizon | 13:24 | |
| *** akrivoka has joined #openstack-horizon | 13:24 | |
| *** josecastroleon has joined #openstack-horizon | 13:28 | |
| openstackgerrit | Tatiana Ovchinnikova proposed openstack/horizon: Error message for invalid job template details page https://review.openstack.org/196662 | 13:32 |
| *** pauloewerton has joined #openstack-horizon | 13:33 | |
| *** iamjarvo has joined #openstack-horizon | 13:33 | |
| *** drupalmonkey has joined #openstack-horizon | 13:35 | |
| *** absubram has quit IRC | 13:36 | |
| *** absubram has joined #openstack-horizon | 13:36 | |
| *** ZZelle has joined #openstack-horizon | 13:42 | |
| *** oro has quit IRC | 13:42 | |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Fix _get_tenant_volume_usages https://review.openstack.org/196523 | 13:46 |
| *** Drago has joined #openstack-horizon | 13:46 | |
| *** Drago has quit IRC | 13:47 | |
| *** Drago has joined #openstack-horizon | 13:48 | |
| *** lblanchard has joined #openstack-horizon | 13:50 | |
| *** nlahouti has quit IRC | 13:52 | |
| *** dboik has joined #openstack-horizon | 13:54 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Detail-page directives (Angular/UX) https://review.openstack.org/173359 | 13:57 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Add New UX CSS for Upcoming Detail Screens https://review.openstack.org/158881 | 13:58 |
| *** amotoki has quit IRC | 13:59 | |
| *** mou has joined #openstack-horizon | 13:59 | |
| *** cody-somerville has quit IRC | 14:07 | |
| *** bfic has quit IRC | 14:08 | |
| *** absubram has quit IRC | 14:11 | |
| *** doug-fish has joined #openstack-horizon | 14:14 | |
| *** JeanBriceCombebi has quit IRC | 14:14 | |
| *** absubram has joined #openstack-horizon | 14:15 | |
| *** absubram has quit IRC | 14:15 | |
| *** mrunge has joined #openstack-horizon | 14:16 | |
| *** stevemar has joined #openstack-horizon | 14:19 | |
| *** Gal has joined #openstack-horizon | 14:21 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 14:21 | |
| Gal | Hi, updated my blueprint format - would appreciate a review https://blueprints.launchpad.net/horizon/+spec/stack-add-additional-files | 14:22 |
| *** mrunge has quit IRC | 14:23 | |
| *** henrynash has joined #openstack-horizon | 14:23 | |
| *** cardeois has quit IRC | 14:23 | |
| *** cardeois has joined #openstack-horizon | 14:24 | |
| *** ducttape_ has quit IRC | 14:27 | |
| *** oro has joined #openstack-horizon | 14:27 | |
| *** henrynash has quit IRC | 14:32 | |
| *** cody-somerville has joined #openstack-horizon | 14:32 | |
| *** kzaitsev_mb has joined #openstack-horizon | 14:33 | |
| *** clu_ has joined #openstack-horizon | 14:33 | |
| *** sergmelikyan has joined #openstack-horizon | 14:35 | |
| *** garthb has joined #openstack-horizon | 14:37 | |
| *** garthb_ has joined #openstack-horizon | 14:37 | |
| *** lucas__ has joined #openstack-horizon | 14:39 | |
| openstackgerrit | Wim De Clercq proposed openstack/horizon: Add allowed address pair extension UI for neutron ports. https://review.openstack.org/193079 | 14:40 |
| *** yamamoto has quit IRC | 14:41 | |
| *** lucas__ has quit IRC | 14:42 | |
| *** piyanai has quit IRC | 14:42 | |
| *** lucas__ has joined #openstack-horizon | 14:42 | |
| *** yamamoto has joined #openstack-horizon | 14:43 | |
| *** sayan has quit IRC | 14:46 | |
| *** piyanai has joined #openstack-horizon | 14:47 | |
| *** piyanai has quit IRC | 14:47 | |
| *** petertr7 is now known as petertr7_away | 14:47 | |
| *** piyanai has joined #openstack-horizon | 14:47 | |
| *** petertr7_away is now known as petertr7 | 14:48 | |
| *** tvanderwiel has joined #openstack-horizon | 14:48 | |
| *** piyanai has quit IRC | 14:52 | |
| *** piyanai has joined #openstack-horizon | 14:52 | |
| *** piyanai has quit IRC | 14:52 | |
| *** masco_ has joined #openstack-horizon | 14:54 | |
| *** jmolo has joined #openstack-horizon | 15:00 | |
| *** kiran-r has joined #openstack-horizon | 15:01 | |
| *** henrynash has joined #openstack-horizon | 15:01 | |
| *** jtomasek has quit IRC | 15:04 | |
| *** absubram has joined #openstack-horizon | 15:04 | |
| *** kzaitsev_mb has quit IRC | 15:05 | |
| *** ducttape_ has joined #openstack-horizon | 15:06 | |
| *** sputnik13 has quit IRC | 15:07 | |
| *** SimonChung has quit IRC | 15:07 | |
| *** TravT has joined #openstack-horizon | 15:09 | |
| *** sputnik13 has joined #openstack-horizon | 15:10 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Detail-page directives (Angular/UX) https://review.openstack.org/173359 | 15:11 |
| *** sputnik13 has quit IRC | 15:13 | |
| *** TravT has quit IRC | 15:13 | |
| *** masco_ has quit IRC | 15:16 | |
| ducttape_ | does anyone use memcached for their dev setup to back sessions? when I do this, every code change reloads django (which is normal) - but then I also need to re-login again | 15:18 |
| ducttape_ | david-lyle have you been using memcached without incident ^ ?? | 15:19 |
| *** yamamoto has quit IRC | 15:20 | |
| *** hurgleburgler has joined #openstack-horizon | 15:21 | |
| *** kiran-r has quit IRC | 15:22 | |
| *** jmolo has left #openstack-horizon | 15:23 | |
| *** e0ne has joined #openstack-horizon | 15:23 | |
| *** yamamoto has joined #openstack-horizon | 15:23 | |
| *** e0ne is now known as e0ne_ | 15:25 | |
| *** e0ne_ is now known as e0ne | 15:25 | |
| david-ly_ | ducttape_: I've found the same to be true, yes annoying | 15:26 |
| ducttape_ | I have another opportunity as well | 15:26 |
| ducttape_ | whomever wrote the lbaas stuff, didn't understand horizon actions I fear: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/loadbalancers/views.py#L45 | 15:27 |
| ducttape_ | it seems like there is a better way to write that | 15:27 |
| *** david-ly_ is now known as david-lyle | 15:27 | |
| *** ChanServ sets mode: +o david-lyle | 15:27 | |
| *** geoffarnold has quit IRC | 15:28 | |
| david-lyle | ducttape_: I fear you are correct | 15:28 |
| ducttape_ | so I have a blueprint around adding another action, and I will be doing it the documented way.... which will make this code look funky | 15:29 |
| *** belmoreira has quit IRC | 15:29 | |
| *** jbell8 has joined #openstack-horizon | 15:30 | |
| *** MaxV has quit IRC | 15:32 | |
| *** JeanBriceCombebi has quit IRC | 15:34 | |
| *** oro has quit IRC | 15:36 | |
| *** mou has quit IRC | 15:36 | |
| *** mou has joined #openstack-horizon | 15:37 | |
| *** asahlin_away is now known as asahlin | 15:37 | |
| *** tyr_ has joined #openstack-horizon | 15:37 | |
| *** kiran-r has joined #openstack-horizon | 15:38 | |
| *** cardeois has quit IRC | 15:41 | |
| *** cardeois has joined #openstack-horizon | 15:41 | |
| *** hurgleburgler has quit IRC | 15:42 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 15:42 |
| *** hurgleburgler has joined #openstack-horizon | 15:43 | |
| *** TravT has joined #openstack-horizon | 15:44 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Applying auto-file-discovery partially https://review.openstack.org/193771 | 15:46 |
| *** yamamoto has quit IRC | 15:46 | |
| *** Sukhdev has joined #openstack-horizon | 15:46 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: [WIP] Dashboard ReOrg - Create 'project' https://review.openstack.org/196271 | 15:46 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Detail-page directives (Angular/UX) https://review.openstack.org/173359 | 15:46 |
| *** e0ne has quit IRC | 15:46 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 15:47 |
| *** kiran-r has quit IRC | 15:47 | |
| *** e0ne has joined #openstack-horizon | 15:48 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 15:48 | |
| doug-fish | ducttape_, david-lyle: I use memcached for session storage in my dev environment and I don't have to relog on code updates. | 15:49 |
| doug-fish | I wonder why? | 15:49 |
| *** bethelwell has joined #openstack-horizon | 15:49 | |
| ducttape_ | yeah, I'd love to know what I am doing wrong :\ | 15:49 |
| david-lyle | are you sure | 15:49 |
| david-lyle | ? | 15:49 |
| doug-fish | :-) pretty sure. | 15:49 |
| *** sergmelikyan has quit IRC | 15:50 | |
| david-lyle | how is your session info being mapped in your restarted app? | 15:50 |
| david-lyle | interesting | 15:50 |
| doug-fish | mapped? | 15:50 |
| *** cardeois has quit IRC | 15:50 | |
| *** cardeois has joined #openstack-horizon | 15:51 | |
| david-lyle | Trying to figure out how your newly started horizon app can map something in memcache that your previous horizon app set up | 15:51 |
| *** TravT has quit IRC | 15:51 | |
| david-lyle | but I suppose I don't know what the key is | 15:52 |
| doug-fish | I thought Django handled all of that mapping for free | 15:52 |
| *** TravT has joined #openstack-horizon | 15:53 | |
| *** e0ne is now known as e0ne_ | 15:53 | |
| *** ducttape_ has quit IRC | 15:53 | |
| openstackgerrit | Merged openstack/tuskar-ui: Updated from global requirements https://review.openstack.org/196264 | 15:54 |
| david-lyle | time to dig into django code | 15:54 |
| *** JeanBriceCombebi has quit IRC | 15:55 | |
| *** mwhagedorn has joined #openstack-horizon | 15:55 | |
| *** e0ne_ is now known as e0ne | 15:55 | |
| *** gyee has joined #openstack-horizon | 16:00 | |
| doug-fish | david-lyle: I just verified that I'm reloading code and not losing the session. My settings aren't very special: http://pastebin.com/Gy3byjX8 | 16:00 |
| *** yamamoto has joined #openstack-horizon | 16:01 | |
| david-lyle | doug-fish: I wonder if the CACHES part is maintaining the reference to the session key | 16:01 |
| *** SimonChung has joined #openstack-horizon | 16:01 | |
| *** Gal has quit IRC | 16:01 | |
| david-lyle | otherwise the app just creates a random number | 16:01 |
| doug-fish | I'm confused - why is the app create a random number? | 16:02 |
| doug-fish | isn't the same session key being passed in from the browser? | 16:03 |
| doug-fish | and the session should be found | 16:03 |
| doug-fish | - that's my superficial understanding without having dug into that code | 16:03 |
| david-lyle | hmm, good point | 16:04 |
| *** petertr7 is now known as petertr7_away | 16:05 | |
| david-lyle | turns out I turned on LocMemCache for testing some time ago and left that on, so I'm bowing at on stupidity factor at this point | 16:05 |
| doug-fish | :-) I'm going to guess you aren't the first person to have done that. | 16:06 |
| *** TravT_ has joined #openstack-horizon | 16:06 | |
| doug-fish | In fact I _know_ you aren't the first person to have done that | 16:06 |
| *** kiran-r has joined #openstack-horizon | 16:07 | |
| *** TravT has quit IRC | 16:07 | |
| *** tqtran has joined #openstack-horizon | 16:07 | |
| *** rwsu has joined #openstack-horizon | 16:08 | |
| *** iamjarvo has quit IRC | 16:09 | |
| *** iurygregory has joined #openstack-horizon | 16:10 | |
| *** eandersson has joined #openstack-horizon | 16:10 | |
| *** geoffarnold has joined #openstack-horizon | 16:10 | |
| *** sqchen has joined #openstack-horizon | 16:11 | |
| *** kiran-r has quit IRC | 16:11 | |
| *** TravT_ is now known as TravT | 16:13 | |
| robcresswell | TravT: o/ | 16:13 |
| *** petertr7_away is now known as petertr7 | 16:13 | |
| TravT | robcresswell o/ | 16:13 |
| iurygregory | doug-fish, about the K2K in Horizon (https://review.openstack.org/#/c/159910/) since the Plugin (https://review.openstack.org/#/c/188581/) is merged what are the next steps? ^^ | 16:16 |
| *** lucas__ has quit IRC | 16:16 | |
| *** henrynash has quit IRC | 16:17 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 16:17 |
| robcresswell | TravT: If you can spare the time later this week, it'd be great to schedule a hangout to make sure I'm on top of the JS changes | 16:19 |
| *** sqchen has quit IRC | 16:19 | |
| *** henrynash has joined #openstack-horizon | 16:19 | |
| *** sqchen has joined #openstack-horizon | 16:20 | |
| *** tyr_ has quit IRC | 16:20 | |
| *** tyr_ has joined #openstack-horizon | 16:20 | |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: JSCS cleanup - style guide cleanup for table and basic-table https://review.openstack.org/190354 | 16:20 |
| TravT | robcreswell, that probably would be a good idea. there are a number of people doing a number of things here and we could all use a little sync up I think. | 16:22 |
| doug-fish | iurygregory: there's an additional critical keystone client patch that's needed https://review.openstack.org/#/c/192438/, then the code in https://review.openstack.org/#/c/159910/ needs to be updated with the calls modelled in https://review.openstack.org/#/c/160851/ ... | 16:23 |
| robcresswell | TravT: Yeah, I've got a lot of time right now for reviews so it would be sensible to target that better, and have a few late nights working closely with you US folk :) | 16:23 |
| *** mpavlase has quit IRC | 16:24 | |
| doug-fish | finally that code needs to be completed with proper logout behavior, handling duplicate region names, dealing with that multi-keystone region selector (maybe?), and maybe some multi-threading if we are feeling fancy. | 16:24 |
| robcresswell | doug-fish: So, nearly there then... :p | 16:25 |
| *** ygbo has quit IRC | 16:25 | |
| *** kiran-r has joined #openstack-horizon | 16:25 | |
| doug-fish | It's much closer than it used to be! | 16:25 |
| *** packet has joined #openstack-horizon | 16:25 | |
| TravT | robcresswell so, i've been trying to help get all the style changes reviewed and through, because they have a lot of merge conflicts. And we really need to get that effort over with. Also, sqchen has been working on ways to reduce merge conflicts with auto collection of js files. | 16:25 |
| *** mpavlase has joined #openstack-horizon | 16:25 | |
| robcresswell | TravT: Yeah the auto collection is one of the bits I could do with going over, that effort has mostly passed me by | 16:26 |
| TravT | sqchen is the best one to provide overview on that, i think. | 16:27 |
| TravT | its getting close | 16:27 |
| TravT | https://review.openstack.org/#/c/193771/ | 16:28 |
| robcresswell | Yeah I'll have to track him down too | 16:28 |
| TravT | there is a webroot problem that is 1) a problem for launch instance NG. But 2) will be a problem for any of the new angular work. | 16:29 |
| TravT | https://review.openstack.org/#/c/181095/ | 16:29 |
| *** lucas__ has joined #openstack-horizon | 16:29 | |
| *** sqchen has quit IRC | 16:29 | |
| *** sputnik13 has joined #openstack-horizon | 16:30 | |
| *** kiran-r has quit IRC | 16:30 | |
| robcresswell | TravT: Gotcha. Added myself. | 16:30 |
| *** kiran-r has joined #openstack-horizon | 16:30 | |
| *** sqchen has joined #openstack-horizon | 16:30 | |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: JSCS Cleanup - style cleanup for Launch Instance Security Groups Step https://review.openstack.org/193608 | 16:32 |
| *** ducttape_ has joined #openstack-horizon | 16:32 | |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: JSCS Cleanup - style cleanup for Launch Instance Source Step https://review.openstack.org/194306 | 16:33 |
| tqtran | robcresswell: https://review.openstack.org/#/c/186921/ lol | 16:33 |
| tqtran | that is hilarious | 16:34 |
| robcresswell | tqtran: haha | 16:35 |
| robcresswell | tqtran: Yeah, I reacted with my first thought, and then sat and reflected on it for a few minutes. | 16:35 |
| *** _kiran_ has joined #openstack-horizon | 16:35 | |
| TravT | robcresswell: best to not think. | 16:35 |
| robcresswell | Literally just arguing with myself in the comments -.- | 16:35 |
| *** henrynash has quit IRC | 16:35 | |
| *** kiran-r has quit IRC | 16:36 | |
| robcresswell | TravT: Probably best if I just shut up all together :p | 16:36 |
| tqtran | seems like the midcycle is mostly people from US, you cant make it rob? | 16:36 |
| robcresswell | tqtran: Narp. No travel approval. | 16:37 |
| TravT | :( | 16:37 |
| robcresswell | New CEO so everything will change for 6 months then go back to normal. | 16:37 |
| robcresswell | If you guys can stream it somehow, like a hangout on air with a spare laptop, that would be awesome. | 16:38 |
| *** yamamoto has quit IRC | 16:38 | |
| robcresswell | But otherwise you can just ping me for reviews :p | 16:38 |
| TravT | robcresswell: we can certainly try. | 16:39 |
| *** henrynash has joined #openstack-horizon | 16:39 | |
| *** akrivoka has quit IRC | 16:39 | |
| *** dguerri is now known as dguerri` | 16:40 | |
| *** yamamoto has joined #openstack-horizon | 16:41 | |
| openstackgerrit | Brian Tully proposed openstack/horizon: Fix project name error when creating project (Keystone v3) https://review.openstack.org/188116 | 16:41 |
| *** akrivoka has joined #openstack-horizon | 16:41 | |
| *** petertr7 is now known as petertr7_away | 16:42 | |
| krotscheck | robcresswell: I resent your implication that I'm being patronizing, especially given the tone of the comment you yourself gave. If you would like better tracking for this work, I'm currently working on putting together the x-project spec, however I do not believe that this work should be tracked under horizon. | 16:43 |
| tqtran | robcresswell: question, https://review.openstack.org/#/c/182243/9/doc/source/contributing.rst | 16:43 |
| krotscheck | robcresswell: If you'd like to track it there, you're more than welcome to add your own blueprint. | 16:43 |
| tqtran | what does the .._translatability do? | 16:43 |
| iurygregory | Thanks doug-fish ;D | 16:44 |
| openstackgerrit | Eric Peterson proposed openstack/horizon: LBAAS VIP floating IP table actions https://review.openstack.org/196740 | 16:44 |
| *** henrynash has quit IRC | 16:45 | |
| *** nlahouti has joined #openstack-horizon | 16:46 | |
| *** henrynash has joined #openstack-horizon | 16:47 | |
| *** _kiran_ has quit IRC | 16:47 | |
| robcresswell | krotscheck: Fair enough. I considered linking me to Thierrys post on standing out of the way fairly rude, but I may have misinterpreted your tone, and if so I apologise. | 16:47 |
| krotscheck | robcresswell: Thank you. Now, would you like to wait for the x-project spec to be submitted, landed, or.... | 16:48 |
| ducttape_ | david-lyle - that ugly lbaas thing.... https://review.openstack.org/#/c/196740/1/openstack_dashboard/dashboards/project/loadbalancers/views.py,cm going to do that for now, to contain that can of worms | 16:48 |
| robcresswell | tqtran: Yup? | 16:48 |
| tqtran | what does the .._translatability do? | 16:49 |
| robcresswell | tqtran: Lets me link directly to it from another place in the docs | 16:49 |
| *** yamamoto has quit IRC | 16:51 | |
| robcresswell | krotscheck: I'm actually not terribly concerned about the cross-project spec. As far as I'm aware, those are more for documentation of the feature, but what I'm interested in is the tracking. As I said in the comment, for me it's useful to have a bp that lists the feature change and the relevant patches. | 16:52 |
| robcresswell | krotscheck: If it doesn't bother you, I'm happy to push up a small bp and link the patches myself, but didnt want to intrude. | 16:52 |
| openstackgerrit | Brian Tully proposed openstack/horizon: Fix project name error when creating project (Keystone v3) https://review.openstack.org/188116 | 16:53 |
| robcresswell | I'm just reading through x-proj specs though, so I'm not terribly familiar with how they tie into the relevant projects/ patches with regards to tracking. | 16:53 |
| *** yamamoto has joined #openstack-horizon | 16:54 | |
| *** ducttape_ has quit IRC | 16:54 | |
| krotscheck | robcresswell: I get that tracking is good. I personally prefer to use gerrit to do that, since code > talk. Either way, I feel that if there's a blueprint to link against, it may need to be the JSCS blueprint. | 16:54 |
| krotscheck | Mostly because that blueprint's job can be slightly expanded to handle "improve code style in horizon" and then roll tooling under that. | 16:54 |
| krotscheck | robcresswell: Especially since things like removing jshint would have to be done anyway had horizon continued forward with jscs | 16:55 |
| *** ybathia has joined #openstack-horizon | 16:55 | |
| *** nlahouti1 has joined #openstack-horizon | 16:55 | |
| *** ducttape_ has joined #openstack-horizon | 16:56 | |
| *** hurgleburgler1 has joined #openstack-horizon | 16:56 | |
| robcresswell | That's also fine, it just gives some form of reference. | 16:57 |
| *** ducttape_ has quit IRC | 16:57 | |
| *** nlahouti has quit IRC | 16:58 | |
| *** ducttape_ has joined #openstack-horizon | 16:58 | |
| *** bluex-pl has quit IRC | 16:59 | |
| *** hurgleburgler has quit IRC | 16:59 | |
| *** e0ne has quit IRC | 16:59 | |
| openstackgerrit | Merged openstack/horizon: Error message for invalid job template details page https://review.openstack.org/196662 | 17:01 |
| openstackgerrit | Michael Krotscheck proposed openstack/horizon: Switched from JSCS to ESLint https://review.openstack.org/192327 | 17:04 |
| *** cody-somerville has quit IRC | 17:05 | |
| openstackgerrit | Michael Krotscheck proposed openstack/horizon: Switched from JSCS to ESLint https://review.openstack.org/192327 | 17:05 |
| *** dscottsf has joined #openstack-horizon | 17:05 | |
| *** yamamoto has quit IRC | 17:05 | |
| krotscheck | clu_: I can't edit the JSCS blueprint. Would you be willing to edit it to be a little more generic? As in "Let's use the John Papa Style Guides and deprecate jshint", with the tooling being less defined? | 17:06 |
| *** yamamoto has joined #openstack-horizon | 17:06 | |
| *** mpavlase has quit IRC | 17:06 | |
| clu_ | hey krotscheck: sure, i'll do that | 17:06 |
| *** lhcheng has joined #openstack-horizon | 17:07 | |
| *** bethelwell has quit IRC | 17:07 | |
| krotscheck | clu_, robcresswell, tqtran, TravT, david-lyle: I have a patch up to disable the jshint build for liberty+. https://review.openstack.org/#/c/196250/ | 17:07 |
| openstackgerrit | Merged openstack/horizon: JSCS cleanup - openstack_dashboard/static/dashboard/workflow https://review.openstack.org/195660 | 17:07 |
| *** lhcheng_ has joined #openstack-horizon | 17:08 | |
| *** sqchen has quit IRC | 17:09 | |
| *** jingjing_ren has joined #openstack-horizon | 17:09 | |
| *** dscottsf has quit IRC | 17:09 | |
| robcresswell | krotscheck: Looks good | 17:09 |
| *** lsmola has quit IRC | 17:09 | |
| *** yamamoto has quit IRC | 17:09 | |
| *** lhcheng has quit IRC | 17:11 | |
| *** sqchen has joined #openstack-horizon | 17:12 | |
| *** mou has quit IRC | 17:13 | |
| iurygregory | doug-fish, you think you'll need help in tests or code to have this feature in Liberty? ^^ | 17:15 |
| doug-fish | iurygregory: Having help will certainly move things along faster. | 17:17 |
| doug-fish | I assume that was an offer? | 17:17 |
| iurygregory | yes =) pauloewerton works with horizon and can give help | 17:19 |
| iurygregory | i can only help with review =D | 17:19 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 17:20 |
| pauloewerton | doug-fish, iurygregory sure, I'd be glad to help. trying to test the current version right now | 17:21 |
| doug-fish | cool! I'd say step 1 is to get your environment to the point where you can confirm that https://review.openstack.org/#/c/160851/ works (or doesn't) ... I'll spend some time reflecting on how to divide up the work for https://review.openstack.org/#/c/159910/ itself | 17:21 |
| iurygregory | Ok doug-fish | 17:21 |
| *** matt-borland has joined #openstack-horizon | 17:23 | |
| robcresswell | krotscheck: ESLint patch looks good to go IMO, I'll fill out the bp a little more so its a bit more generic | 17:23 |
| krotscheck | Thanks | 17:23 |
| robcresswell | krotscheck: One tiny thing, with the run lint cmd, since it errors on failure, is there a nicer way to return? | 17:24 |
| openstackgerrit | Merged openstack/horizon: JSCS cleanup - style guide cleanup for metadata-display https://review.openstack.org/189074 | 17:25 |
| openstackgerrit | Merged openstack/horizon: Use URLField instead of CharField for image_url https://review.openstack.org/194527 | 17:25 |
| krotscheck | robcresswell: I can check to see if we can make NPM be a little more helpful in its error messages. | 17:25 |
| openstackgerrit | Merged openstack/horizon: Error message for invalid cluster template details page https://review.openstack.org/196616 | 17:25 |
| openstackgerrit | Merged openstack/horizon: Prevent infinite 'Loading' spinner when using mouse https://review.openstack.org/143991 | 17:25 |
| openstackgerrit | Merged openstack/horizon: Clean up terminal output for stack details section https://review.openstack.org/142599 | 17:25 |
| krotscheck | robcresswell: Issue is that npm is constructing a virtualenv and running a command, and they've decided that other error messages are more important to raise than just passing the return code of the internal command through. | 17:26 |
| robcresswell | krotscheck: Great. I think its just due to the return value of eslint, that npm command seems to error despite functioning normally, which isn't ideal for newer users imo. | 17:26 |
| *** oro has joined #openstack-horizon | 17:26 | |
| robcresswell | krotscheck: It isn't a blocker, we can fix it later, was just wondering if there was a neat fix. | 17:27 |
| krotscheck | robcresswell: There might be a --silent option that does that. testing now | 17:27 |
| krotscheck | robcresswell: Looks like that might work. | 17:28 |
| *** mpavlase has joined #openstack-horizon | 17:30 | |
| *** MaxV has joined #openstack-horizon | 17:30 | |
| *** dontalton has joined #openstack-horizon | 17:32 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding Angular Users Panel https://review.openstack.org/190865 | 17:32 |
| openstackgerrit | Merged openstack/horizon: Error message for invalid node group template details page https://review.openstack.org/196630 | 17:33 |
| *** petertr7_away is now known as petertr7 | 17:33 | |
| *** akrivoka has quit IRC | 17:34 | |
| *** akrivoka has joined #openstack-horizon | 17:35 | |
| robcresswell | tqtran, david-lyle: I'll fix those issues tomorrow morning. Thanks! | 17:35 |
| *** MaxV has quit IRC | 17:37 | |
| *** TravT_ has joined #openstack-horizon | 17:39 | |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Angularize Identity Projects Panel https://review.openstack.org/191225 | 17:40 |
| *** TravT has quit IRC | 17:41 | |
| *** TravT__ has joined #openstack-horizon | 17:41 | |
| *** TravT_ has quit IRC | 17:42 | |
| tqtran | david-lyle, TravT_, clu_, robcresswell: https://review.openstack.org/#/c/190852/10 can we get this merge? seems like Paulo is interested in helping out with the projects panel | 17:42 |
| david-lyle | tqtran: was just looking at that | 17:43 |
| *** petertr7 is now known as petertr7_away | 17:43 | |
| david-lyle | aren't the static paths incorrect? | 17:43 |
| *** chlong has quit IRC | 17:43 | |
| tqtran | they're correct, we are using the pluggable format | 17:44 |
| david-lyle | tqtran: nvmd, you are right | 17:45 |
| david-lyle | was just looking at the enabled file | 17:45 |
| *** Sukhdev has quit IRC | 17:46 | |
| *** petertr7_away is now known as petertr7 | 17:47 | |
| *** Ephur has joined #openstack-horizon | 17:47 | |
| tqtran | pauloewerton: whats your email? i have something to forward you | 17:48 |
| *** tyr_ has quit IRC | 17:50 | |
| openstackgerrit | Michael Krotscheck proposed openstack/horizon: Add selective ESLint rule activation for Horizon Legacy JS https://review.openstack.org/195799 | 17:51 |
| *** TravT has joined #openstack-horizon | 17:52 | |
| pauloewerton | hey tqtran. pauloewerton@lsd.ufcg.edu.br | 17:52 |
| tqtran | yup emails already sent | 17:52 |
| tqtran | i found you on launchpad :P | 17:52 |
| pauloewerton | tqtran, ok ;-) | 17:53 |
| tqtran | some feedback from ops | 17:53 |
| *** TravT__ has quit IRC | 17:53 | |
| tqtran | i think piet will come up with some nice mocks at some point, you should work closely with him to make sure we have good ux support | 17:53 |
| sqchen | Hi clu_: I am going to jscs launch-instance.js, has anyone already started working on it yet? | 17:54 |
| *** mwhagedorn has quit IRC | 17:55 | |
| clu_ | hi sqchen | 17:55 |
| TravT | tqtran: clu_: david-lyle: could I get you do look back at this one again? | 17:56 |
| TravT | https://review.openstack.org/#/c/179545/ | 17:56 |
| clu_ | we've been working on the steps, but no one for launch-instance.js yet :) | 17:56 |
| tqtran | TravT: added to my Q | 17:57 |
| TravT | remember it is only about 45 lines of new code. rest is comments, tests | 17:57 |
| tqtran | ok | 17:57 |
| david-lyle | TravT: I will not remember | 17:57 |
| david-lyle | :P | 17:57 |
| tqtran | lol | 17:57 |
| TravT | david-lyle: that's okay, i wouldn't expect that much from you. :) | 17:57 |
| sqchen | clu_, cool. I will work on launch-instance.js. :) | 17:58 |
| tqtran | +1 to honesty, -1 to memory | 17:58 |
| david-lyle | glad your expectations are in order | 17:58 |
| TravT | :P | 17:58 |
| openstackgerrit | George Peristerakis proposed openstack/horizon: Refactoring the exceptions lists https://review.openstack.org/173027 | 17:58 |
| *** jingjing_ren has quit IRC | 18:00 | |
| *** eandersson has quit IRC | 18:01 | |
| *** Ephur has quit IRC | 18:03 | |
| *** eandersson has joined #openstack-horizon | 18:03 | |
| pauloewerton | tqtran, of course, thank you. I will contact Piet | 18:03 |
| *** markus_z has quit IRC | 18:04 | |
| openstackgerrit | Michael Krotscheck proposed openstack/horizon: Removed JSHint https://review.openstack.org/196257 | 18:05 |
| *** piyanai has joined #openstack-horizon | 18:07 | |
| *** yamamoto has joined #openstack-horizon | 18:10 | |
| *** mwhagedorn has joined #openstack-horizon | 18:12 | |
| *** robcresswell has quit IRC | 18:14 | |
| *** yamamoto has quit IRC | 18:15 | |
| *** tosky has quit IRC | 18:15 | |
| *** piyanai has quit IRC | 18:15 | |
| *** ttrifonov is now known as zz_ttrifonov | 18:16 | |
| *** piyanai has joined #openstack-horizon | 18:17 | |
| *** Sukhdev has joined #openstack-horizon | 18:24 | |
| *** TravT_ has joined #openstack-horizon | 18:24 | |
| *** mpavlase has quit IRC | 18:26 | |
| *** mpavlase has joined #openstack-horizon | 18:26 | |
| *** TravT has quit IRC | 18:26 | |
| *** jingjing_ren has joined #openstack-horizon | 18:27 | |
| *** openstackgerrit has quit IRC | 18:30 | |
| *** Sukhdev has quit IRC | 18:30 | |
| *** mpavlase has quit IRC | 18:30 | |
| *** openstackgerrit has joined #openstack-horizon | 18:30 | |
| *** TravT_ has quit IRC | 18:35 | |
| *** TravT has joined #openstack-horizon | 18:35 | |
| *** stevemar has quit IRC | 18:43 | |
| *** stevemar has joined #openstack-horizon | 18:44 | |
| *** TravT has quit IRC | 18:45 | |
| *** TravT_ has joined #openstack-horizon | 18:45 | |
| *** jingjing_ren has quit IRC | 18:51 | |
| *** Sukhdev has joined #openstack-horizon | 18:51 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - style guide cleanup for Keypair step https://review.openstack.org/193658 | 18:52 |
| *** TravT_ has quit IRC | 18:52 | |
| *** TravT has joined #openstack-horizon | 18:52 | |
| *** ducttape_ has quit IRC | 18:56 | |
| *** hurgleburgler1 has quit IRC | 18:56 | |
| *** hurgleburgler has joined #openstack-horizon | 18:56 | |
| *** TravT has quit IRC | 18:57 | |
| *** TravT has joined #openstack-horizon | 18:59 | |
| *** ducttape_ has joined #openstack-horizon | 19:07 | |
| *** petertr7 is now known as petertr7_away | 19:09 | |
| *** petertr7_away is now known as petertr7 | 19:10 | |
| *** ducttape_ has quit IRC | 19:11 | |
| *** kzaitsev_mb has joined #openstack-horizon | 19:12 | |
| *** TravT has quit IRC | 19:17 | |
| *** TravT has joined #openstack-horizon | 19:17 | |
| *** dguerri` is now known as dguerri | 19:18 | |
| *** tqtran has quit IRC | 19:19 | |
| *** tqtran has joined #openstack-horizon | 19:19 | |
| *** dguerri is now known as dguerri` | 19:20 | |
| *** nlahouti1 has quit IRC | 19:23 | |
| *** ZZelle_ has joined #openstack-horizon | 19:24 | |
| *** ducttape_ has joined #openstack-horizon | 19:25 | |
| *** piyanai has quit IRC | 19:25 | |
| *** piyanai has joined #openstack-horizon | 19:26 | |
| *** piyanai has quit IRC | 19:26 | |
| *** kzaitsev_mb has quit IRC | 19:26 | |
| *** ducttape_ has quit IRC | 19:28 | |
| *** jingjing_ren has joined #openstack-horizon | 19:30 | |
| *** sqchen has quit IRC | 19:30 | |
| *** kzaitsev_mb has joined #openstack-horizon | 19:31 | |
| *** Drago has quit IRC | 19:31 | |
| *** sqchen has joined #openstack-horizon | 19:32 | |
| openstackgerrit | George Peristerakis proposed openstack/horizon: Generating a rdp file for a windows instance https://review.openstack.org/91394 | 19:33 |
| *** TravT has quit IRC | 19:35 | |
| *** TravT has joined #openstack-horizon | 19:36 | |
| *** ducttape_ has joined #openstack-horizon | 19:37 | |
| *** piyanai has joined #openstack-horizon | 19:44 | |
| *** lucas__ has quit IRC | 19:44 | |
| *** dguerri` is now known as dguerri | 19:47 | |
| *** MaxV has joined #openstack-horizon | 19:48 | |
| *** lucas__ has joined #openstack-horizon | 19:49 | |
| *** ducttape_ has quit IRC | 19:52 | |
| *** lucas__ has quit IRC | 19:53 | |
| *** MaxV has quit IRC | 19:54 | |
| *** MaxV has joined #openstack-horizon | 19:56 | |
| *** stevemar has quit IRC | 19:56 | |
| *** stevemar has joined #openstack-horizon | 19:57 | |
| *** lucas__ has joined #openstack-horizon | 20:00 | |
| *** TravT_ has joined #openstack-horizon | 20:02 | |
| *** dscottsf has joined #openstack-horizon | 20:02 | |
| *** kzaitsev_mb has quit IRC | 20:02 | |
| *** TravT__ has joined #openstack-horizon | 20:04 | |
| *** TravT has quit IRC | 20:04 | |
| *** lblanchard has quit IRC | 20:05 | |
| *** TravT_ has quit IRC | 20:06 | |
| *** stevemar has quit IRC | 20:08 | |
| *** kzaitsev_mb has joined #openstack-horizon | 20:11 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: JSCS Cleanup - style cleanup for modal factory https://review.openstack.org/196836 | 20:11 |
| openstackgerrit | Merged openstack/horizon: AngularJS in Horizon Documentation https://review.openstack.org/182243 | 20:12 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: JSCS Cleanup - style cleanup for modal factory https://review.openstack.org/196836 | 20:13 |
| *** stevemar has joined #openstack-horizon | 20:15 | |
| *** hurgleburgler1 has joined #openstack-horizon | 20:16 | |
| *** hurgleburgler has quit IRC | 20:16 | |
| openstackgerrit | Merged openstack/horizon: Adding Angular Identity Dashboard https://review.openstack.org/190852 | 20:17 |
| *** ducttape_ has joined #openstack-horizon | 20:20 | |
| *** dscottsf has quit IRC | 20:21 | |
| *** nlahouti has joined #openstack-horizon | 20:21 | |
| *** Longgeek has quit IRC | 20:21 | |
| *** akrivoka has quit IRC | 20:23 | |
| *** TravT has joined #openstack-horizon | 20:25 | |
| *** dontalton has quit IRC | 20:26 | |
| *** TravT__ has quit IRC | 20:27 | |
| *** julim has quit IRC | 20:29 | |
| *** Piet has joined #openstack-horizon | 20:30 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/tuskar-ui: Updated from global requirements https://review.openstack.org/196850 | 20:35 |
| *** drupalmonkey has quit IRC | 20:41 | |
| *** drupalmonkey has joined #openstack-horizon | 20:42 | |
| openstackgerrit | Michael Krotscheck proposed openstack/horizon: Switched from JSCS to ESLint https://review.openstack.org/192327 | 20:43 |
| openstackgerrit | Merged openstack/horizon: JSCS Cleanup - style cleanup for Launch Instance Source Step https://review.openstack.org/194306 | 20:45 |
| *** petertr7 is now known as petertr7_away | 20:45 | |
| *** petertr7_away is now known as petertr7 | 20:47 | |
| *** cardeois has quit IRC | 20:48 | |
| *** stevemar has quit IRC | 20:49 | |
| *** stevemar has joined #openstack-horizon | 20:50 | |
| *** Sukhdev has quit IRC | 20:51 | |
| openstackgerrit | Michael Krotscheck proposed openstack/horizon: Switched from JSCS to ESLint https://review.openstack.org/192327 | 20:53 |
| *** stevemar has quit IRC | 20:55 | |
| *** TravT_ has joined #openstack-horizon | 21:01 | |
| *** TravT has quit IRC | 21:01 | |
| *** Drago has joined #openstack-horizon | 21:05 | |
| *** Drago has quit IRC | 21:05 | |
| *** Drago has joined #openstack-horizon | 21:05 | |
| *** petertr7 is now known as petertr7_away | 21:09 | |
| *** lucas__ has quit IRC | 21:09 | |
| *** dboik has quit IRC | 21:10 | |
| openstackgerrit | Eric Peterson proposed openstack/horizon: LBAAS VIP floating IP table actions https://review.openstack.org/196740 | 21:11 |
| openstackgerrit | Merged openstack/horizon: Adding Angular Users Panel https://review.openstack.org/190865 | 21:12 |
| *** MaxV has quit IRC | 21:14 | |
| *** hurgleburgler has joined #openstack-horizon | 21:16 | |
| *** hurgleburgler1 has quit IRC | 21:19 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: JSCS Cleanup - style cleanup for modal factory https://review.openstack.org/196836 | 21:21 |
| *** Longgeek has joined #openstack-horizon | 21:22 | |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: Switched from JSCS to ESLint https://review.openstack.org/192327 | 21:22 |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: JSCS cleanup - style guide cleanup for table and basic-table https://review.openstack.org/190354 | 21:22 |
| *** matt-borland has quit IRC | 21:22 | |
| *** tqtran_ has joined #openstack-horizon | 21:24 | |
| *** TravT_ has quit IRC | 21:24 | |
| *** TravT has joined #openstack-horizon | 21:25 | |
| *** oro has quit IRC | 21:25 | |
| *** pauloewerton has quit IRC | 21:25 | |
| *** ducttape_ has quit IRC | 21:25 | |
| *** packet has quit IRC | 21:26 | |
| *** hurgleburgler1 has joined #openstack-horizon | 21:26 | |
| *** hurgleburgler has quit IRC | 21:26 | |
| *** piyanai has quit IRC | 21:27 | |
| *** lucas__ has joined #openstack-horizon | 21:27 | |
| *** Sukhdev has joined #openstack-horizon | 21:27 | |
| *** lucas___ has joined #openstack-horizon | 21:28 | |
| *** lucas__ has quit IRC | 21:29 | |
| *** lucas___ has quit IRC | 21:29 | |
| *** lucas____ has joined #openstack-horizon | 21:29 | |
| *** hurgleburgler1 has quit IRC | 21:30 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: JSCS Cleanup - style cleanup for modal factory https://review.openstack.org/196836 | 21:30 |
| *** kevinbenton has quit IRC | 21:31 | |
| *** hurgleburgler has joined #openstack-horizon | 21:31 | |
| *** jbell8 has quit IRC | 21:31 | |
| *** jbell8 has joined #openstack-horizon | 21:32 | |
| *** notmars has joined #openstack-horizon | 21:33 | |
| *** lucas____ has quit IRC | 21:34 | |
| *** peristeri has quit IRC | 21:34 | |
| Piet | Does anyone know many TC members need to sign-off for a proposal to become an offciial project? | 21:35 |
| david-lyle | 7 and a +A | 21:36 |
| Piet | "+ A" ? | 21:36 |
| *** jbell8 has quit IRC | 21:37 | |
| david-lyle | like all patches, it requires an approval of the workflow | 21:37 |
| david-lyle | +A | 21:37 |
| david-lyle | 7 +2s and +A | 21:37 |
| david-lyle | won't merge without the +A | 21:37 |
| Piet | Ahhhh...thanks | 21:37 |
| david-lyle | sure | 21:38 |
| *** hurgleburgler1 has joined #openstack-horizon | 21:40 | |
| *** hurgleburgler has quit IRC | 21:40 | |
| *** kzaitsev_mb has quit IRC | 21:42 | |
| *** TravT_ has joined #openstack-horizon | 21:45 | |
| *** TravT has quit IRC | 21:49 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: JSCS cleanup - launch-instance.js https://review.openstack.org/196881 | 21:50 |
| *** tyr_ has joined #openstack-horizon | 21:53 | |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: JSCS Cleanup - style cleanup for Launch Instance Security Groups Step https://review.openstack.org/193608 | 21:54 |
| *** jingjing_ren has quit IRC | 21:55 | |
| *** Longgeek has quit IRC | 21:56 | |
| *** neelashah1 has quit IRC | 22:03 | |
| *** asahlin is now known as asahlin_away | 22:07 | |
| tqtran_ | neillc: ping pong | 22:07 |
| *** piyanai has joined #openstack-horizon | 22:09 | |
| *** TravT has joined #openstack-horizon | 22:11 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Applying auto-file-discovery partially https://review.openstack.org/193771 | 22:12 |
| *** TravT_ has quit IRC | 22:12 | |
| *** absubram has quit IRC | 22:19 | |
| *** TravT_ has joined #openstack-horizon | 22:19 | |
| *** TravT__ has joined #openstack-horizon | 22:21 | |
| *** TravT has quit IRC | 22:22 | |
| *** TravT_ has quit IRC | 22:23 | |
| *** jingjing_ren has joined #openstack-horizon | 22:25 | |
| *** jingjing_ren has quit IRC | 22:28 | |
| *** jingjing_ren has joined #openstack-horizon | 22:28 | |
| *** TravT has joined #openstack-horizon | 22:31 | |
| *** TravT__ has quit IRC | 22:32 | |
| krotscheck | david-lyle: https://review.openstack.org/#/c/196250/ -> Disabling JShint run in liberty | 22:35 |
| *** TravT_ has joined #openstack-horizon | 22:36 | |
| *** TravT has quit IRC | 22:37 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: JSCS cleanup - launch-instance.js https://review.openstack.org/196881 | 22:39 |
| *** piyanai has quit IRC | 22:39 | |
| *** lucas__ has joined #openstack-horizon | 22:44 | |
| *** dansiwiec has joined #openstack-horizon | 22:44 | |
| *** mwhagedorn has quit IRC | 22:44 | |
| *** crobertsrh is now known as _crobertsrh | 22:47 | |
| dansiwiec | hello Horizon. I'd like to contribute a small modification to run_tests.sh + package.json and wanted to bounce if off you guys first | 22:48 |
| dansiwiec | run_jshint function does stuff like 'jshint horizon/static/horizon/js', which assumes that jshint is installed globally, which might not be the case | 22:49 |
| *** lucas__ has quit IRC | 22:49 | |
| dansiwiec | instead, it would be nice to have a script entry in packge.json to run it via a local node module and have run_jshint run it via 'npm run hint' | 22:49 |
| krotscheck | dansiwiec: The jshint job is on its way out. | 22:50 |
| krotscheck | dansiwiec: For the new hotness, I think https://review.openstack.org/#/c/192327/ will make you rather happy. | 22:50 |
| dansiwiec | that's already how it's being done for karma | 22:50 |
| dansiwiec | ...reading.... | 22:51 |
| *** notmars has quit IRC | 22:51 | |
| dansiwiec | ESlint would replace JSCS and JSHint, correct? | 22:52 |
| krotscheck | dansiwiec: Correct. | 22:52 |
| dansiwiec | sweet. that makes sense, thanks | 22:52 |
| krotscheck | dansiwiec: JSCS, being a codestyle only thing, and JSHint, having a not-good liecense, don't meet all the needs that openstack has. | 22:52 |
| krotscheck | dansiwiec: Most of the javascript-based jobs are currently being overhauled, in order to make openstack friendlier to node things as well. Ultimately we're aiming towards "npm run [verb]" | 22:53 |
| krotscheck | Where verb == 'lint', 'test', 'package', 'license', 'turn-into-unicorns' | 22:53 |
| *** tvanderwiel has quit IRC | 22:53 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: JSCS cleanup - launch-instance.js https://review.openstack.org/196881 | 22:54 |
| dansiwiec | krotscheck: that explains things | 22:54 |
| *** Drago has quit IRC | 22:54 | |
| krotscheck | dansiwiec: If you have questions, I'd be happy to answer htem. | 22:55 |
| dansiwiec | krotscheck: is there a desire to introduce node in the backend as well, to slowly phase out django, or is it just ment for project grooming? | 22:55 |
| krotscheck | dansiwiec: That.... is a question I can't answer. I'm addressing the toolchain from an openstack-global perspective. I _do_ konw that ironic-webclient wants to be a JS-only thick client, for which I'm currently introducing CORS support in openstack. | 22:56 |
| krotscheck | I also know that ironic wants to be as-reusable-as-possible, so the likelyhood of a JS lib that is imported into horizon is likely | 22:56 |
| dansiwiec | krotscheck: cool, thanks | 23:01 |
| dansiwiec | krotscheck: never worked with ESLint before. how does it compare against JSHint? | 23:02 |
| dansiwiec | krotscheck: nvm. found a comparison here: http://www.sitepoint.com/comparison-javascript-linting-tools/ | 23:05 |
| krotscheck | dansiwiec: It's a fork, from pre-we-want-jscs-to-be-a-different-thing days | 23:07 |
| *** ZZelle_ has quit IRC | 23:13 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: [WIP] Dashboard ReOrg - Create 'project' https://review.openstack.org/196271 | 23:14 |
| *** dguerri is now known as dguerri` | 23:17 | |
| *** yamamoto has joined #openstack-horizon | 23:24 | |
| *** lucas__ has joined #openstack-horizon | 23:25 | |
| krotscheck | clu_, david-lyle, robcresswell, TravT_, tqtran: The most recent patch on the ESlint patch just passed. I'd like this one not to bitrot, can we get a final set of approvals on it please? https://review.openstack.org/#/c/192327/ | 23:26 |
| *** Sukhdev has quit IRC | 23:27 | |
| tqtran_ | krotscheck: so is the plan to get this merge, then fix remaining errors, then make it voting? | 23:27 |
| krotscheck | tqtran_: That's the plan. | 23:27 |
| krotscheck | tqtran_: HOpefully the timing will work out so that I can roll the activated rules into the eslint-config-opentstack package and then just pull in the dependency. | 23:28 |
| tqtran_ | k taking a look | 23:29 |
| *** lucas__ has quit IRC | 23:30 | |
| *** tyr_ has quit IRC | 23:30 | |
| *** jasondotstar has joined #openstack-horizon | 23:31 | |
| tqtran_ | looks fine to me, i'll run it locally to confirm, if theres nothing outstanding, i'll +2 it | 23:32 |
| *** lucas__ has joined #openstack-horizon | 23:33 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: WIP Adding identity users table https://review.openstack.org/196905 | 23:34 |
| *** KunalGandhi has joined #openstack-horizon | 23:34 | |
| TravT_ | krotscheck, been keeping my eye on it. will check it out | 23:36 |
| krotscheck | TravT_: Thanks. | 23:37 |
| tqtran_ | krotscheck: question, if i already have some packages in npm, and you updated the package.json. when i attempt to run eslint via run_script, i get an error | 23:38 |
| *** lucas__ has quit IRC | 23:38 | |
| tqtran_ | https://review.openstack.org/#/c/192327/20/run_tests.sh L173 | 23:38 |
| tqtran_ | to resolve this error, i had to manually run "sudo npm install" | 23:38 |
| krotscheck | tqtran_: Alright, so manually execute npm install? | 23:39 |
| tqtran_ | the run_eslint doesn't catch this, it only checks if you npm or not, doesn't consider the case where you have a previously installed packages (aka update) | 23:39 |
| tqtran_ | yeah i think that should be ok, if there are no changes, it will just skip | 23:39 |
| krotscheck | Is it just me, or does git review on horizon take forever? | 23:41 |
| tqtran_ | just you, its fine for me | 23:42 |
| openstackgerrit | Michael Krotscheck proposed openstack/horizon: Switched from JSCS to ESLint https://review.openstack.org/192327 | 23:42 |
| krotscheck | tqtran_: Alright, give that a shot. | 23:42 |
| * krotscheck settles back to wait another 2 hours for tempest. | 23:43 | |
| *** garthb__ has joined #openstack-horizon | 23:44 | |
| *** TravT has joined #openstack-horizon | 23:46 | |
| *** TravT_ has quit IRC | 23:46 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: WIP Adding identity users table https://review.openstack.org/196905 | 23:47 |
| *** garthb_ has quit IRC | 23:48 | |
| *** garthb has quit IRC | 23:48 | |
| tqtran_ | krotscheck: i think you might need to sudo that | 23:49 |
| *** garthb__ has quit IRC | 23:49 | |
| tqtran_ | yup, doesnt work w/o sudo | 23:49 |
| sqchen | krotscheck: got a question to your last change to the patch. | 23:50 |
| *** tqtran_ is now known as tqtran-afk | 23:53 | |
| *** Longgeek has joined #openstack-horizon | 23:54 | |
| *** yamamoto has quit IRC | 23:56 | |
| krotscheck | tqtran: Sudo? That makes zero sense, the npm run command constructs its own virtualenv. | 23:56 |
| krotscheck | tqtran: Can you give me more details as to how you're trying to run eslint? | 23:58 |
| *** dsneddon has quit IRC | 23:58 | |
| *** Sukhdev has joined #openstack-horizon | 23:59 | |
| krotscheck | tqtran: Are you maybe just trying to run eslint from the commandline? | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!