| *** gyee has quit IRC | 00:00 | |
| *** hurgleburgler has quit IRC | 00:02 | |
| *** petertr7 is now known as petertr7_away | 00:03 | |
| *** ducttape_ has quit IRC | 00:04 | |
| *** Sukhdev has quit IRC | 00:07 | |
| *** Sukhdev has joined #openstack-horizon | 00:07 | |
| *** TravT_ has quit IRC | 00:08 | |
| *** belmoreira has joined #openstack-horizon | 00:11 | |
| *** ongk has joined #openstack-horizon | 00:11 | |
| *** darrenc_afk is now known as darrenc | 00:14 | |
| *** annashen has quit IRC | 00:16 | |
| *** ybathia has quit IRC | 00:19 | |
| *** alexvictorchan has quit IRC | 00:20 | |
| *** yingjun has joined #openstack-horizon | 00:21 | |
| openstackgerrit | Kelly Domico proposed openstack/horizon: JSCS cleanup - horizon/static/framework conf and util https://review.openstack.org/188987 | 00:22 |
|---|---|---|
| *** amotoki has joined #openstack-horizon | 00:33 | |
| *** yingjun has quit IRC | 00:33 | |
| *** yingjun has joined #openstack-horizon | 00:33 | |
| *** alexpilotti has quit IRC | 00:36 | |
| *** amotoki has quit IRC | 00:38 | |
| *** tqtran has quit IRC | 00:39 | |
| *** kiran-r has joined #openstack-horizon | 00:44 | |
| *** ducttape_ has joined #openstack-horizon | 00:44 | |
| *** ducttape_ has quit IRC | 00:44 | |
| *** pece has quit IRC | 00:46 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: WIP - Replace makemessages with babel https://review.openstack.org/188665 | 00:46 |
| *** annashen has joined #openstack-horizon | 00:47 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: WIP - Replace makemessages with babel https://review.openstack.org/188665 | 00:47 |
| *** yamamoto has joined #openstack-horizon | 00:52 | |
| *** annashen has quit IRC | 00:54 | |
| *** jingjing_ren has quit IRC | 00:57 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - style guide cleanup for toast https://review.openstack.org/189524 | 00:58 |
| openstackgerrit | Kelly Domico proposed openstack/horizon: JSCS cleanup - style guide cleanup for action-list https://review.openstack.org/188995 | 00:58 |
| *** nlahouti has quit IRC | 01:03 | |
| *** lhcheng has joined #openstack-horizon | 01:06 | |
| *** lhcheng_ has joined #openstack-horizon | 01:07 | |
| *** jingliuqing has joined #openstack-horizon | 01:09 | |
| *** jingliuqing has quit IRC | 01:09 | |
| *** lhcheng has quit IRC | 01:10 | |
| *** chlong has quit IRC | 01:11 | |
| openstackgerrit | Kelly Domico proposed openstack/horizon: JSCS cleanup - style guide cleanup for charts https://review.openstack.org/188998 | 01:15 |
| openstackgerrit | Richard Jones proposed openstack/horizon: ngReorg - move core HTML from framework to dashboard https://review.openstack.org/186295 | 01:20 |
| openstackgerrit | Ryan Brady proposed openstack/tuskar-ui: Add Network Isolation https://review.openstack.org/190149 | 01:22 |
| *** neillc_bf is now known as neillc | 01:26 | |
| openstackgerrit | Kelly Domico proposed openstack/horizon: JSCS cleanup - style guide cleanup for metadata-display https://review.openstack.org/189074 | 01:28 |
| *** Drago has joined #openstack-horizon | 01:28 | |
| *** Drago has quit IRC | 01:28 | |
| *** Drago has joined #openstack-horizon | 01:29 | |
| *** iamjarvo has joined #openstack-horizon | 01:30 | |
| *** bpokorny has quit IRC | 01:30 | |
| r1chardj0n3s | TravT if you're awake still and need me I've managed to get IRC up and going for a bit... | 01:31 |
| openstackgerrit | Merged openstack/horizon: Updated from global requirements https://review.openstack.org/190356 | 01:32 |
| *** eroussel has joined #openstack-horizon | 01:36 | |
| *** xnox has quit IRC | 01:44 | |
| *** yingjun has quit IRC | 01:45 | |
| *** yingjun has joined #openstack-horizon | 01:45 | |
| *** eroussel has quit IRC | 01:45 | |
| *** xnox has joined #openstack-horizon | 01:47 | |
| *** belmoreira has quit IRC | 01:50 | |
| *** stevemar has quit IRC | 01:53 | |
| *** KunalGandhi has quit IRC | 02:04 | |
| *** nullvariable has quit IRC | 02:05 | |
| *** Sukhdev has quit IRC | 02:07 | |
| *** bpokorny has joined #openstack-horizon | 02:14 | |
| *** Piet has quit IRC | 02:15 | |
| *** amotoki has joined #openstack-horizon | 02:21 | |
| *** juggler has quit IRC | 02:33 | |
| *** juggler has joined #openstack-horizon | 02:33 | |
| openstackgerrit | Ryan Peters proposed openstack/horizon: Add no-cache directive when generating keypair https://review.openstack.org/189904 | 02:34 |
| *** yingjun_ has joined #openstack-horizon | 02:35 | |
| *** yingjun has quit IRC | 02:35 | |
| *** ongk has quit IRC | 02:35 | |
| *** jwy has quit IRC | 02:38 | |
| *** eroussel has joined #openstack-horizon | 02:39 | |
| *** amotoki has quit IRC | 02:40 | |
| *** stevemar has joined #openstack-horizon | 02:41 | |
| *** lhcheng_ has quit IRC | 02:44 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Extends .jscsrc to ignore 3rd party files https://review.openstack.org/190131 | 02:50 |
| *** kiran-r has quit IRC | 02:51 | |
| *** stevemar has quit IRC | 02:59 | |
| *** jpomero has quit IRC | 03:03 | |
| *** david-lyle has joined #openstack-horizon | 03:04 | |
| *** ChanServ sets mode: +o david-lyle | 03:04 | |
| *** iamjarvo has quit IRC | 03:05 | |
| *** tyr_ has quit IRC | 03:08 | |
| *** cody-somerville has quit IRC | 03:34 | |
| openstackgerrit | Neill Cox proposed openstack/horizon: WIP - Replace makemessages with babel https://review.openstack.org/188665 | 03:37 |
| *** hurgleburgler has joined #openstack-horizon | 03:40 | |
| *** kiran-r has joined #openstack-horizon | 03:42 | |
| *** nlahouti has joined #openstack-horizon | 03:44 | |
| *** eroussel has quit IRC | 03:46 | |
| *** bpokorny has quit IRC | 03:46 | |
| *** yingjun_ has quit IRC | 03:46 | |
| *** nlahouti has quit IRC | 03:47 | |
| *** cody-somerville has joined #openstack-horizon | 03:47 | |
| *** amotoki has joined #openstack-horizon | 03:49 | |
| *** nlahouti has joined #openstack-horizon | 03:51 | |
| *** kiran-r has quit IRC | 03:57 | |
| *** fifieldt has joined #openstack-horizon | 03:58 | |
| *** iamjarvo has joined #openstack-horizon | 04:01 | |
| openstackgerrit | Merged openstack/horizon: corrected the wrong url in admin instance detail https://review.openstack.org/189601 | 04:03 |
| *** xnox has quit IRC | 04:05 | |
| *** TravT_ has joined #openstack-horizon | 04:09 | |
| *** xnox has joined #openstack-horizon | 04:11 | |
| *** annashen has joined #openstack-horizon | 04:22 | |
| *** annashen has quit IRC | 04:27 | |
| *** nlahouti has quit IRC | 04:44 | |
| *** yingjun has joined #openstack-horizon | 04:56 | |
| *** yingjun has quit IRC | 04:56 | |
| *** yingjun has joined #openstack-horizon | 04:56 | |
| *** kiran-r has joined #openstack-horizon | 05:15 | |
| *** TravT_ has quit IRC | 05:18 | |
| *** belmoreira has joined #openstack-horizon | 05:22 | |
| *** yingjun has quit IRC | 05:34 | |
| *** belmoreira has quit IRC | 05:38 | |
| *** rushiagr_away is now known as rushiagr | 05:41 | |
| *** stevemar has joined #openstack-horizon | 05:42 | |
| *** tjones1 has joined #openstack-horizon | 05:48 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: JSCS cleanup - launch-instance/configuration/ https://review.openstack.org/190488 | 05:48 |
| *** lsmola has joined #openstack-horizon | 05:57 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: JSCS cleanup - launch-instance/flavor/ https://review.openstack.org/190489 | 05:58 |
| *** stevemar2 has joined #openstack-horizon | 06:04 | |
| *** tjones1 has quit IRC | 06:05 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/django_openstack_auth: Imported Translations from Transifex https://review.openstack.org/190496 | 06:05 |
| *** stevemar has quit IRC | 06:06 | |
| *** mrunge has joined #openstack-horizon | 06:07 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: JSCS cleanup - launch-instance/source/ https://review.openstack.org/190498 | 06:11 |
| *** yingjun has joined #openstack-horizon | 06:14 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/190501 | 06:21 |
| *** annashen has joined #openstack-horizon | 06:24 | |
| *** iamjarvo has quit IRC | 06:26 | |
| *** jtomasek has joined #openstack-horizon | 06:27 | |
| *** absubram has quit IRC | 06:28 | |
| *** annashen has quit IRC | 06:29 | |
| *** lhcheng has joined #openstack-horizon | 06:31 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: JSCS cleanup - launch-instance/ https://review.openstack.org/190505 | 06:35 |
| *** lhcheng_ has joined #openstack-horizon | 06:39 | |
| *** absubram has joined #openstack-horizon | 06:39 | |
| *** lhcheng has quit IRC | 06:41 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: JSCS cleanup - launch-instance/cloud-services/ https://review.openstack.org/190508 | 06:44 |
| *** ZZelle_ has joined #openstack-horizon | 06:45 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: JSCS cleanup - dashboard/cloud-services/ https://review.openstack.org/190508 | 06:46 |
| *** jcoufal has joined #openstack-horizon | 06:49 | |
| *** rushiagr is now known as rushiagr_away | 06:50 | |
| *** darrenc is now known as darrenc_afk | 07:04 | |
| *** masco has joined #openstack-horizon | 07:05 | |
| *** e0ne has joined #openstack-horizon | 07:08 | |
| *** markus_z has joined #openstack-horizon | 07:12 | |
| *** e0ne has quit IRC | 07:12 | |
| *** juggler has quit IRC | 07:17 | |
| *** MaxV has joined #openstack-horizon | 07:19 | |
| *** jrist has quit IRC | 07:23 | |
| *** ZZelle_ has quit IRC | 07:23 | |
| *** mpavlase has joined #openstack-horizon | 07:23 | |
| *** bradjones has quit IRC | 07:27 | |
| *** e0ne has joined #openstack-horizon | 07:28 | |
| *** bradjones has joined #openstack-horizon | 07:29 | |
| *** bradjones has quit IRC | 07:29 | |
| *** bradjones has joined #openstack-horizon | 07:29 | |
| *** e0ne has quit IRC | 07:29 | |
| *** juggler_ has joined #openstack-horizon | 07:29 | |
| *** Ala has joined #openstack-horizon | 07:54 | |
| *** pkarikh has joined #openstack-horizon | 07:56 | |
| *** darrenc_afk is now known as darrenc | 07:56 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/190501 | 07:56 |
| *** JeanBriceCombebi has joined #openstack-horizon | 08:00 | |
| *** ZZelle has quit IRC | 08:01 | |
| *** ZZelle has joined #openstack-horizon | 08:02 | |
| *** krykowski has joined #openstack-horizon | 08:04 | |
| *** JeanBriceCombebi has quit IRC | 08:05 | |
| *** stevemar2 has quit IRC | 08:09 | |
| r1chardj0n3s | robcresswell: hope I didn't tread on toes - figured it was such a minor change I could just do it | 08:13 |
| *** yingjun has quit IRC | 08:15 | |
| robcresswell | r1chardj0n3s: Not at all! Thanks for doing it | 08:15 |
| *** romainh has joined #openstack-horizon | 08:18 | |
| *** yingjun has joined #openstack-horizon | 08:19 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: JSCS Cleanup - tech-debt and auth https://review.openstack.org/188316 | 08:21 |
| *** ygbo has joined #openstack-horizon | 08:22 | |
| *** dsneddon is now known as dsneddon_zzz | 08:22 | |
| *** TravT_ has joined #openstack-horizon | 08:23 | |
| *** annashen has joined #openstack-horizon | 08:25 | |
| *** annashen has quit IRC | 08:30 | |
| *** bluex-pl has joined #openstack-horizon | 08:34 | |
| openstackgerrit | Merged openstack/horizon: Change 'Update Metadata' to specific name in modal header https://review.openstack.org/188713 | 08:35 |
| *** bethelwell has joined #openstack-horizon | 08:38 | |
| *** oro has joined #openstack-horizon | 08:54 | |
| *** yingjun has quit IRC | 08:54 | |
| *** TravT_ has quit IRC | 08:55 | |
| openstackgerrit | Martin Pavlásek proposed openstack/horizon: Refactor of BaseTestCase https://review.openstack.org/190077 | 08:55 |
| *** katyafervent_awa is now known as katyafervent | 08:58 | |
| *** lhcheng_ has quit IRC | 09:04 | |
| *** sqchen has quit IRC | 09:09 | |
| *** sqchen has joined #openstack-horizon | 09:10 | |
| openstackgerrit | Yves-Gwenael Bourhis proposed openstack/horizon: Allow to attach FIP without a router https://review.openstack.org/189215 | 09:11 |
| *** tosky has joined #openstack-horizon | 09:13 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: LB method column is added in pools table https://review.openstack.org/190556 | 09:20 |
| openstackgerrit | Martin Pavlásek proposed openstack/horizon: Integration tests - Object store https://review.openstack.org/151187 | 09:22 |
| *** sqchen has quit IRC | 09:23 | |
| robcresswell | TravT: Thanks for the reviews, isn't it crazy late for you? | 09:29 |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:29 | |
| *** masco has quit IRC | 09:35 | |
| *** masco has joined #openstack-horizon | 09:38 | |
| *** Drago has quit IRC | 09:40 | |
| *** yingjun has joined #openstack-horizon | 09:42 | |
| openstackgerrit | Merged openstack/horizon: JSCS cleanup - Angular framework widgets (partial2) https://review.openstack.org/187758 | 09:43 |
| *** kiran-r is now known as kiran-r|afk | 09:46 | |
| *** kiran-r|afk is now known as kiran-r | 09:46 | |
| *** e0ne has joined #openstack-horizon | 09:47 | |
| openstackgerrit | Tatiana Ovchinnikova proposed openstack/horizon: Delete VIP action refactoring https://review.openstack.org/184776 | 09:49 |
| *** tosky has quit IRC | 09:51 | |
| *** yingjun has quit IRC | 09:53 | |
| *** yingjun has joined #openstack-horizon | 09:53 | |
| *** e0ne is now known as e0ne_ | 09:54 | |
| *** TravT_ has joined #openstack-horizon | 09:55 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: Hide attach fip if already fip attached https://review.openstack.org/188718 | 09:57 |
| *** yingjun has quit IRC | 09:58 | |
| *** tosky has joined #openstack-horizon | 09:58 | |
| *** TravT_ has quit IRC | 10:00 | |
| *** e0ne_ has quit IRC | 10:00 | |
| *** e0ne has joined #openstack-horizon | 10:01 | |
| *** zhenguo has quit IRC | 10:09 | |
| *** dsneddon_zzz has quit IRC | 10:16 | |
| *** akrivoka has joined #openstack-horizon | 10:16 | |
| *** kmartin has quit IRC | 10:21 | |
| *** annashen has joined #openstack-horizon | 10:28 | |
| *** annashen has quit IRC | 10:32 | |
| *** e0ne is now known as e0ne_ | 10:33 | |
| *** e0ne_ is now known as e0ne | 10:34 | |
| *** jrist has joined #openstack-horizon | 10:34 | |
| *** romainh has quit IRC | 10:36 | |
| openstackgerrit | Martin Pavlásek proposed openstack/horizon: Refactor of BaseTestCase https://review.openstack.org/190077 | 10:47 |
| *** romainh has joined #openstack-horizon | 10:56 | |
| *** jtomasek has quit IRC | 10:58 | |
| *** masco has quit IRC | 11:02 | |
| *** oro has quit IRC | 11:06 | |
| *** aix has quit IRC | 11:07 | |
| *** jtomasek has joined #openstack-horizon | 11:08 | |
| *** openstackgerrit has quit IRC | 11:13 | |
| *** openstackgerrit has joined #openstack-horizon | 11:14 | |
| *** TravT_ has joined #openstack-horizon | 11:16 | |
| *** TravT_ has quit IRC | 11:21 | |
| *** e0ne is now known as e0ne_ | 11:21 | |
| *** ducttape_ has joined #openstack-horizon | 11:27 | |
| *** e0ne_ has quit IRC | 11:32 | |
| *** hurgleburgler has quit IRC | 11:34 | |
| *** e0ne has joined #openstack-horizon | 11:36 | |
| openstackgerrit | svasheka proposed openstack/horizon: Fix for test_image_create_delete https://review.openstack.org/190596 | 11:36 |
| openstackgerrit | svasheka proposed openstack/horizon: Fix for test_image_create_delete https://review.openstack.org/190596 | 11:37 |
| *** radez_g0n3 is now known as radez | 11:40 | |
| *** ducttape_ has quit IRC | 11:45 | |
| *** julim has joined #openstack-horizon | 11:45 | |
| *** JeanBriceCombebi has quit IRC | 11:48 | |
| *** oro has joined #openstack-horizon | 11:48 | |
| *** yamamoto has quit IRC | 11:53 | |
| *** jrist has quit IRC | 11:55 | |
| *** jrist has joined #openstack-horizon | 11:59 | |
| *** alexpilotti has joined #openstack-horizon | 12:01 | |
| *** iamjarvo has joined #openstack-horizon | 12:03 | |
| *** _crobertsrh is now known as crobertsrh | 12:03 | |
| *** aix has joined #openstack-horizon | 12:09 | |
| *** alexpilotti has quit IRC | 12:09 | |
| *** Ala has quit IRC | 12:23 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 12:31 | |
| *** yamamoto has joined #openstack-horizon | 12:32 | |
| *** yamamoto has quit IRC | 12:33 | |
| *** yamamoto has joined #openstack-horizon | 12:34 | |
| *** yamamoto_ has joined #openstack-horizon | 12:34 | |
| *** ygbo has quit IRC | 12:34 | |
| *** Ala has joined #openstack-horizon | 12:35 | |
| openstackgerrit | Merged openstack/horizon: Extends .jscsrc to ignore 3rd party files https://review.openstack.org/190131 | 12:38 |
| *** absubram has quit IRC | 12:38 | |
| *** yamamoto has quit IRC | 12:38 | |
| *** mrunge has quit IRC | 12:43 | |
| *** JeanBriceCombebi has quit IRC | 12:46 | |
| *** amotoki has quit IRC | 12:50 | |
| *** jcoufal has quit IRC | 12:51 | |
| *** fifieldt has quit IRC | 12:53 | |
| *** petertr7_away is now known as petertr7 | 13:00 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:03 | |
| *** TravT_ has joined #openstack-horizon | 13:04 | |
| *** josecastroleon has quit IRC | 13:05 | |
| *** Longgeek_ has quit IRC | 13:06 | |
| openstackgerrit | Merged openstack/horizon: JSCS Cleanup - style guide cleanup for toast https://review.openstack.org/189524 | 13:06 |
| *** ducttape_ has joined #openstack-horizon | 13:07 | |
| *** ducttape_ has quit IRC | 13:08 | |
| *** ducttape_ has joined #openstack-horizon | 13:09 | |
| *** TravT_ has quit IRC | 13:09 | |
| *** ducttape_ has quit IRC | 13:09 | |
| openstackgerrit | svasheka proposed openstack/horizon: Fix for test_image_create_delete https://review.openstack.org/190596 | 13:12 |
| openstackgerrit | Ryan Peters proposed openstack/horizon: Add no-cache directive when generating keypair https://review.openstack.org/189904 | 13:22 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: AngularJS in Horizon Documentation https://review.openstack.org/182243 | 13:23 |
| *** JeanBriceCombebi has quit IRC | 13:25 | |
| *** drupalmonkey has joined #openstack-horizon | 13:27 | |
| *** jtriley has joined #openstack-horizon | 13:28 | |
| openstackgerrit | Ryan Peters proposed openstack/horizon: ngReorg - move core HTML from framework to dashboard https://review.openstack.org/186295 | 13:28 |
| *** lblanchard has joined #openstack-horizon | 13:29 | |
| *** annashen has joined #openstack-horizon | 13:30 | |
| *** radez is now known as radez_g0n3 | 13:31 | |
| *** krykowski has quit IRC | 13:31 | |
| openstackgerrit | Ryan Peters proposed openstack/horizon: ngReorg - Move API files to openstack_dashboard https://review.openstack.org/184543 | 13:32 |
| *** eandersson has joined #openstack-horizon | 13:33 | |
| *** sqchen has joined #openstack-horizon | 13:33 | |
| *** jpomero has joined #openstack-horizon | 13:35 | |
| *** annashen has quit IRC | 13:35 | |
| *** mwhagedorn has joined #openstack-horizon | 13:38 | |
| *** jtriley has quit IRC | 13:40 | |
| *** tvanderwiel has joined #openstack-horizon | 13:40 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:40 | |
| *** ccrouch has joined #openstack-horizon | 13:42 | |
| *** sqchen has quit IRC | 13:46 | |
| *** alexpilotti has joined #openstack-horizon | 13:46 | |
| *** matt-borland has joined #openstack-horizon | 13:49 | |
| *** DaveJ__ has joined #openstack-horizon | 13:51 | |
| *** peristeri has joined #openstack-horizon | 13:51 | |
| *** yamamoto_ has quit IRC | 13:54 | |
| *** jprovazn has joined #openstack-horizon | 13:54 | |
| *** oro has quit IRC | 13:58 | |
| *** tyr_ has joined #openstack-horizon | 14:01 | |
| *** jtriley has joined #openstack-horizon | 14:01 | |
| *** ygbo has joined #openstack-horizon | 14:02 | |
| *** bethelwell has quit IRC | 14:03 | |
| *** TravT_ has joined #openstack-horizon | 14:05 | |
| *** petertr7 is now known as petertr7_away | 14:06 | |
| *** ducttape_ has joined #openstack-horizon | 14:06 | |
| *** petertr7_away is now known as petertr7 | 14:06 | |
| robcresswell | matt-borland: Need anything else reviewed? I've freed up a couple of hours to do nothing but code review. | 14:07 |
| robcresswell | -1's for everybody... muhahaha | 14:07 |
| *** yamamoto has joined #openstack-horizon | 14:07 | |
| *** tjones1 has joined #openstack-horizon | 14:08 | |
| matt-borland | robcresswell: hey! thanks for the review | 14:08 |
| matt-borland | Matt Wood has a review to update XStatic/Jasmine | 14:09 |
| matt-borland | https://review.openstack.org/#/c/189481/ | 14:09 |
| *** JeanBriceCombebi has quit IRC | 14:09 | |
| matt-borland | Jasmine, for the old-school browser testing, is lagging a bit and this causes problems with some of the directive tests. | 14:09 |
| *** TravT_ has quit IRC | 14:10 | |
| *** dboik has joined #openstack-horizon | 14:11 | |
| matt-borland | robcresswell: there are two SUPER EASY patches Mr. Wood has: | 14:12 |
| matt-borland | https://review.openstack.org/#/c/189485/ | 14:12 |
| *** Drago has joined #openstack-horizon | 14:12 | |
| *** Drago has quit IRC | 14:12 | |
| matt-borland | https://review.openstack.org/#/c/189483/ | 14:12 |
| *** Drago has joined #openstack-horizon | 14:12 | |
| matt-borland | Those are adding some simple, useful files. | 14:12 |
| *** JeanBriceCombebi has joined #openstack-horizon | 14:15 | |
| openstackgerrit | Jiri Tomasek proposed openstack/tuskar-ui: Add template processing before creating/updating stack https://review.openstack.org/190655 | 14:18 |
| *** Drago has quit IRC | 14:20 | |
| *** ericpeterson has joined #openstack-horizon | 14:21 | |
| *** yamamoto has quit IRC | 14:22 | |
| *** sjmc7 has joined #openstack-horizon | 14:22 | |
| *** doug-fish has joined #openstack-horizon | 14:24 | |
| *** ducttape_ has quit IRC | 14:24 | |
| robcresswell | matt-borland: Awesome. I'll have a look through, just having some lunch. Realised I'd forgotten to eat. | 14:28 |
| matt-borland | whoops! | 14:28 |
| matt-borland | "You wouldn't like me when I'm hungry!" | 14:28 |
| robcresswell | haha | 14:28 |
| openstackgerrit | Merged stackforge/xstatic-jasmine: Adding LICENSE file https://review.openstack.org/189485 | 14:29 |
| matt-borland | THAT was fast. | 14:29 |
| matt-borland | no real gate checks I guess. | 14:30 |
| robcresswell | Yeah I love seeing those go through | 14:30 |
| robcresswell | Somehow it feels really satisfying to approve something that goes instantly through. | 14:30 |
| *** absubram has joined #openstack-horizon | 14:31 | |
| *** e0ne is now known as e0ne_ | 14:34 | |
| robcresswell | matt-borland: Mildly curious, why not just jump to Jasmine 2.3? Are there many compatibility issues? | 14:35 |
| matt-borland | Ah! Glad you asked! | 14:35 |
| matt-borland | Matt Wood, I believe, checked with Mr. Lyle and he suggested that we should do step-up-versions. | 14:35 |
| matt-borland | Eventually going up to 2.3.x | 14:35 |
| matt-borland | Although I may have been horribly incorrect in that statement, that was my understanding. | 14:36 |
| openstackgerrit | Matt Borland proposed openstack/horizon: [Launch Instance Fix] Tests for Base Controllers https://review.openstack.org/172057 | 14:37 |
| robcresswell | Hmmm, seems a little cautious given they aren't major versions. But, no worries | 14:37 |
| matt-borland | robcresswell: I think it had something to do with the way packagers do stuff. Don't know any more than anecdotal conversation drifting over cube walls. | 14:39 |
| matt-borland | robcresswell: I modified the Base Controller tests as you and Travis suggest, please review when you can to ensure I did what you wanted! | 14:40 |
| robcresswell | matt-borland: Sure. I'll ask later on. | 14:40 |
| robcresswell | matt-borland: Yup, got it open now :) | 14:40 |
| robcresswell | matt-borland: Couple of teeny tiny issues, then I'll +2 | 14:41 |
| matt-borland | sure thing...lemme see | 14:41 |
| openstackgerrit | Matt Borland proposed openstack/horizon: [Launch Instance Fix] Tests for Base Controllers https://review.openstack.org/172057 | 14:44 |
| matt-borland | yabba dabba doo! | 14:44 |
| *** kiran-r has quit IRC | 14:44 | |
| robcresswell | matt-borland: Thanks :) | 14:45 |
| matt-borland | no problem! I like real-time fixing. | 14:45 |
| *** e0ne_ has quit IRC | 14:45 | |
| *** jbell8 has joined #openstack-horizon | 14:46 | |
| matt-borland | robcresswell: thank YOU and TravT: for taking time! | 14:46 |
| *** tjones1 has quit IRC | 14:47 | |
| robcresswell | matt-borland: No problem. When you get some downtime, could you glance over https://review.openstack.org/#/c/182243/ again? | 14:47 |
| matt-borland | sure thing! | 14:48 |
| *** JeanBriceCombebi has quit IRC | 14:49 | |
| *** yamamoto has joined #openstack-horizon | 14:49 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 14:50 | |
| *** jcoufal has joined #openstack-horizon | 14:50 | |
| *** juggler_ has quit IRC | 14:51 | |
| *** TravT_ has joined #openstack-horizon | 14:51 | |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Angular metadata update modal https://review.openstack.org/184274 | 14:52 |
| matt-borland | robcresswell: It must pain you to type "utilize." | 14:52 |
| robcresswell | matt-borland: You have no idea. | 14:52 |
| matt-borland | Do British keyboards even have a Z? | 14:52 |
| sjmc7 | silenze, you | 14:52 |
| matt-borland | LOL | 14:53 |
| robcresswell | matt-borland: I took mine off and replaced it with a picture of the queen. | 14:53 |
| matt-borland | robcresswell: too...many...snoring...jokes... | 14:53 |
| robcresswell | haha :p | 14:53 |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Angularize metadata update modals https://review.openstack.org/184275 | 14:59 |
| *** romainh has left #openstack-horizon | 15:01 | |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: JSCS cleanup - style guide cleanup for modal https://review.openstack.org/189460 | 15:03 |
| *** JeanBriceCombebi has quit IRC | 15:04 | |
| *** Piet has joined #openstack-horizon | 15:05 | |
| *** romainh has joined #openstack-horizon | 15:06 | |
| *** romainh has left #openstack-horizon | 15:07 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 15:07 | |
| *** nlahouti has joined #openstack-horizon | 15:07 | |
| *** MaxV has quit IRC | 15:12 | |
| *** bpokorny has joined #openstack-horizon | 15:12 | |
| robcresswell | matt-borland: haha, I'll fix up that whitespace now. | 15:15 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: AngularJS in Horizon Documentation https://review.openstack.org/182243 | 15:15 |
| *** kmartin has joined #openstack-horizon | 15:15 | |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Allow to edit image metadata from project view https://review.openstack.org/184280 | 15:20 |
| *** markus_z has quit IRC | 15:21 | |
| *** Piet has quit IRC | 15:25 | |
| *** ongk has joined #openstack-horizon | 15:28 | |
| *** annashen has joined #openstack-horizon | 15:32 | |
| *** ducttape_ has joined #openstack-horizon | 15:32 | |
| *** ericpeterson has quit IRC | 15:33 | |
| *** bluex-pl has quit IRC | 15:33 | |
| pkarikh | Has somebody faced this error? "Uncaught Error: [$injector:unpr] Unknown provider: $$sanitizeUriProvider <- $$sanitizeUri <- $sanitize <- $sceDelegate <- $sce <- $interpolate <- $compile <- horizon.framework.util.tech-debt.helper-functions" | 15:35 |
| *** annashen has quit IRC | 15:36 | |
| *** fedexo has joined #openstack-horizon | 15:37 | |
| robcresswell | pkarikh: Its an angularjs error, normally thrown by a service being defined incorrectly (or not at all) | 15:37 |
| robcresswell | pkarikh: Where did you get that error? And is this on current master? | 15:39 |
| pkarikh | robcresswell: yep, but I've just pulled our master and got it. All requrements are installed. Something strange. | 15:39 |
| pkarikh | And I have no 3-d-side panels installed. git index is clear so looks like I have no changed files in Horizon. | 15:41 |
| *** Drago has joined #openstack-horizon | 15:41 | |
| tyr_ | pkarikh: What operation causes the error? I don't see anything suspicious just logging in. | 15:41 |
| *** Drago has quit IRC | 15:41 | |
| robcresswell | mm, curious where this was seen | 15:42 |
| *** Drago has joined #openstack-horizon | 15:42 | |
| *** ericpeterson has joined #openstack-horizon | 15:42 | |
| robcresswell | Just restacking to see for myself | 15:42 |
| pkarikh | tyr_: after login. | 15:42 |
| tyr_ | pkarikh: I have slightly older DevStack, but Horizon from current master. I'm not seeing that same error. | 15:44 |
| *** ducttape_ has quit IRC | 15:45 | |
| pkarikh | tyr_: hm.. I've set COMPRESS_ENABLED = False and now everything looks fine. | 15:45 |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: JSCS cleanup - style guide cleanup for modal-wait-spinner https://review.openstack.org/189431 | 15:48 |
| pkarikh | Maybe it was some interference with old compressed files, I don't know. But now it's ok. Thanks. :) | 15:48 |
| robcresswell | pkarikh, tyr_: Just to follow up, I can't reproduce this either, so it looks like something odd happened. | 15:49 |
| *** jtriley has quit IRC | 15:53 | |
| *** alexvictorchan has joined #openstack-horizon | 15:53 | |
| *** peristeri_ has joined #openstack-horizon | 15:55 | |
| *** jtriley has joined #openstack-horizon | 15:57 | |
| *** peristeri has quit IRC | 15:58 | |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: JSCS cleanup - style guide cleanup for modal https://review.openstack.org/189460 | 16:03 |
| *** KunalGandhi has joined #openstack-horizon | 16:07 | |
| *** jwy has joined #openstack-horizon | 16:08 | |
| *** radez_g0n3 is now known as radez | 16:10 | |
| *** kiran-r has joined #openstack-horizon | 16:10 | |
| asahlin_away | robcresswell: ongk: clu: So for controller file names what do we want to go with. xxx.controller or xxx.ctrl. I noted in my review that both are being used and we should pick one and go with it. | 16:12 |
| *** MaxV has joined #openstack-horizon | 16:12 | |
| *** mpavlase has quit IRC | 16:12 | |
| asahlin_away | nick /asahlin | 16:12 |
| *** asahlin_away is now known as asahlin | 16:13 | |
| asahlin | ahh that's better | 16:13 |
| ongk | I went with .ctrl since the controller names ended with Ctrl | 16:13 |
| openstackgerrit | Kelly Domico proposed openstack/horizon: JSCS cleanup - horizon/static/framework conf and util https://review.openstack.org/188987 | 16:15 |
| asahlin | ongk: yeah makes sense, and I am ok with that. But wondering if we should be doing https://github.com/johnpapa/angular-styleguide#style-y120 | 16:16 |
| asahlin | I really dont care either way, just need agreement. | 16:17 |
| ongk | yeah, I don’t either. Controller is so much to type, but it’s also clearer | 16:17 |
| *** clu has joined #openstack-horizon | 16:20 | |
| asahlin | robcresswell: clu: ^^^^^ | 16:21 |
| clu | hey asahlin, just joined can you post again | 16:21 |
| tyr_ | asahlin: I think our general goal initially is to do what John Papa does unless we have a compelling reason to do otherwise. | 16:22 |
| *** kiran-r has quit IRC | 16:22 | |
| *** petertr7 is now known as petertr7_away | 16:22 | |
| tyr_ | (plus the number of .controller.js files will likely be fairly small in favor of directives) | 16:23 |
| asahlin | clu: sure, So for controller file names what do we want to go with. xxx.controller or xxx.ctrl. I noted in my review that both are being used and we should pick one and go with it. | 16:24 |
| asahlin | tyr_: good point | 16:24 |
| clu | yea, not sure | 16:24 |
| openstackgerrit | Kelly Domico proposed openstack/horizon: JSCS cleanup - horizon/static/framework conf and util https://review.openstack.org/188987 | 16:25 |
| *** dsneddon has joined #openstack-horizon | 16:25 | |
| *** dsneddon has quit IRC | 16:25 | |
| clu | i don't have a preference | 16:25 |
| tyr_ | clu: Papa prefers .controller.js | 16:25 |
| asahlin | alright I will pick lets go with .controller.js | 16:25 |
| asahlin | ;-) | 16:26 |
| *** dsneddon has joined #openstack-horizon | 16:26 | |
| clu | tyr_, asahlin: good decision :) | 16:26 |
| *** fedexo has quit IRC | 16:26 | |
| *** e0ne has joined #openstack-horizon | 16:27 | |
| ongk | should we rename all controllers as well? | 16:27 |
| asahlin | yeah I think so. | 16:29 |
| asahlin | Papa says: https://github.com/johnpapa/angular-styleguide#style-y120 | 16:29 |
| ongk | Ok sounds good | 16:29 |
| *** sqchen has joined #openstack-horizon | 16:34 | |
| *** jcoufal has quit IRC | 16:36 | |
| *** Ala has quit IRC | 16:38 | |
| *** Ephur has joined #openstack-horizon | 16:38 | |
| *** ygbo has quit IRC | 16:38 | |
| *** jprovazn has quit IRC | 16:39 | |
| *** dscottsf has joined #openstack-horizon | 16:44 | |
| *** JeanBriceCombebi has quit IRC | 16:44 | |
| *** annashen has joined #openstack-horizon | 16:45 | |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: JSCS cleanup - style guide cleanup for modal https://review.openstack.org/189460 | 16:46 |
| *** lhcheng has joined #openstack-horizon | 16:48 | |
| *** dscottsf has quit IRC | 16:50 | |
| *** sambetts has quit IRC | 16:51 | |
| *** sambetts has joined #openstack-horizon | 16:54 | |
| *** stevemar has joined #openstack-horizon | 16:54 | |
| *** Drago has quit IRC | 17:00 | |
| *** Drago1 has joined #openstack-horizon | 17:00 | |
| *** jingjing_ren has joined #openstack-horizon | 17:04 | |
| *** Drago1 has quit IRC | 17:05 | |
| *** Drago has joined #openstack-horizon | 17:05 | |
| *** jwy has quit IRC | 17:06 | |
| *** yamamoto has quit IRC | 17:07 | |
| *** yamamoto has joined #openstack-horizon | 17:07 | |
| *** pkarikh has quit IRC | 17:07 | |
| *** e0ne has quit IRC | 17:09 | |
| *** yamamoto has quit IRC | 17:10 | |
| *** yamamoto has joined #openstack-horizon | 17:11 | |
| *** tqtran has joined #openstack-horizon | 17:14 | |
| *** yamamoto has quit IRC | 17:14 | |
| *** iamjarvo has quit IRC | 17:24 | |
| *** tvanderwiel has quit IRC | 17:32 | |
| *** tosky has quit IRC | 17:34 | |
| *** TravT_ has quit IRC | 17:34 | |
| *** petertr7_away is now known as petertr7 | 17:35 | |
| *** jtomasek has quit IRC | 17:38 | |
| tqtran | r1chardj0n3s: are you awake yet? | 17:40 |
| *** sqchen has quit IRC | 17:42 | |
| *** sqchen has joined #openstack-horizon | 17:46 | |
| *** cbader has joined #openstack-horizon | 17:51 | |
| *** jtomasek has joined #openstack-horizon | 17:51 | |
| *** iamjarvo has joined #openstack-horizon | 17:51 | |
| *** iamjarvo has quit IRC | 17:51 | |
| *** iamjarvo has joined #openstack-horizon | 17:52 | |
| *** iamjarvo has quit IRC | 17:52 | |
| *** tosky has joined #openstack-horizon | 17:56 | |
| *** jingjing_ren has quit IRC | 18:00 | |
| *** jtriley has quit IRC | 18:00 | |
| openstackgerrit | Merged openstack/django_openstack_auth: Imported Translations from Transifex https://review.openstack.org/190496 | 18:01 |
| *** jtriley has joined #openstack-horizon | 18:04 | |
| *** tvanderwiel has joined #openstack-horizon | 18:05 | |
| *** yamamoto has joined #openstack-horizon | 18:15 | |
| *** jbell8 has quit IRC | 18:19 | |
| *** yamamoto has quit IRC | 18:19 | |
| *** sjmc7 has quit IRC | 18:21 | |
| *** jbell8 has joined #openstack-horizon | 18:23 | |
| *** jingjing_ren has joined #openstack-horizon | 18:24 | |
| *** juggler has joined #openstack-horizon | 18:29 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Angular table paging buttons clickable https://review.openstack.org/190747 | 18:30 |
| *** DaveJ__ has quit IRC | 18:31 | |
| *** operator99 has quit IRC | 18:32 | |
| *** iamjarvo has joined #openstack-horizon | 18:32 | |
| *** iamjarvo has quit IRC | 18:33 | |
| *** iamjarvo has joined #openstack-horizon | 18:33 | |
| *** iamjarvo has quit IRC | 18:33 | |
| *** jingjing_ren has quit IRC | 18:34 | |
| *** iamjarvo has joined #openstack-horizon | 18:35 | |
| *** iamjarvo has quit IRC | 18:35 | |
| *** jingjing_ren has joined #openstack-horizon | 18:38 | |
| *** jingjing_ren has quit IRC | 18:39 | |
| *** eandersson has quit IRC | 18:40 | |
| *** MaxV has quit IRC | 18:40 | |
| *** gyee has joined #openstack-horizon | 18:41 | |
| *** aix has quit IRC | 18:49 | |
| *** TravT_ has joined #openstack-horizon | 18:51 | |
| *** e0ne has joined #openstack-horizon | 18:51 | |
| *** e0ne is now known as e0ne_ | 18:51 | |
| *** tqtran is now known as tqtran_afk | 18:52 | |
| *** e0ne_ is now known as e0ne | 18:53 | |
| matt-borland | TravT_: ping | 18:53 |
| *** sjmc7 has joined #openstack-horizon | 18:57 | |
| *** e0ne is now known as e0ne_ | 19:00 | |
| *** greghaynes has quit IRC | 19:05 | |
| *** greghaynes has joined #openstack-horizon | 19:05 | |
| *** annashen has quit IRC | 19:08 | |
| TravT_ | matt-borland: hello | 19:10 |
| matt-borland | TravT_: hey! | 19:10 |
| matt-borland | how's life as a core? :) | 19:10 |
| matt-borland | I wanted to let you know that I worked with Rob Cresswell to put in some changes to that one test patch | 19:11 |
| matt-borland | https://review.openstack.org/#/c/172057/ | 19:11 |
| matt-borland | You had +2d it with notes, I think I covered those notes in the subsequent changes | 19:11 |
| *** stevemar has quit IRC | 19:12 | |
| TravT_ | okay, cool. thanks! i didn't want to -1 over it, but did want to see that extra bit of testing | 19:12 |
| TravT_ | i'll look now. | 19:12 |
| matt-borland | I agree. I blitzed through those tests in many cases, I think it's an improvement. | 19:13 |
| matt-borland | Just let me know if there's anything else you'd like to see. | 19:13 |
| TravT_ | i debated on suggesting injecting a fake service catalog that would report that the network service wasn't avaialble... | 19:13 |
| matt-borland | Thanks! :) | 19:13 |
| TravT_ | but decided that would lead to another unit vs integration test discussion | 19:13 |
| matt-borland | TravT_: interesting idea though! | 19:13 |
| matt-borland | does the logic for exclusion happen here or in the base wizard? | 19:14 |
| TravT_ | i think base wizard | 19:14 |
| matt-borland | that's the main question, I'll have to take a look | 19:14 |
| *** clu has quit IRC | 19:14 | |
| matt-borland | we should probably test that there then at least. | 19:14 |
| TravT_ | yeah | 19:14 |
| *** annashen has joined #openstack-horizon | 19:14 | |
| TravT_ | but at least this now checks to ensure that the step doesn't lose its network requirement | 19:14 |
| matt-borland | yes, exactly. | 19:15 |
| matt-borland | There's no doubt we should add more tests. :) | 19:15 |
| *** zz_ttrifonov is now known as ttrifonov | 19:18 | |
| *** jtriley has quit IRC | 19:23 | |
| *** TravT_ has quit IRC | 19:24 | |
| *** cuddyt has joined #openstack-horizon | 19:24 | |
| *** jtriley has joined #openstack-horizon | 19:26 | |
| *** mattfarina has joined #openstack-horizon | 19:27 | |
| *** annashen has quit IRC | 19:31 | |
| *** e0ne_ is now known as e0ne | 19:35 | |
| *** stevemar has joined #openstack-horizon | 19:40 | |
| *** ZZelle_ has joined #openstack-horizon | 19:44 | |
| *** dguerri has joined #openstack-horizon | 19:44 | |
| *** hurgleburgler has joined #openstack-horizon | 19:45 | |
| *** akrivoka has quit IRC | 19:46 | |
| *** matt-borland has quit IRC | 19:48 | |
| *** jingjing_ren has joined #openstack-horizon | 19:49 | |
| *** dguerri is now known as dguerri` | 19:49 | |
| *** TravT_ has joined #openstack-horizon | 19:51 | |
| *** jbell8 has quit IRC | 19:56 | |
| *** TravT_ has quit IRC | 20:04 | |
| *** lblanchard has quit IRC | 20:05 | |
| *** nlahouti has quit IRC | 20:05 | |
| *** lhcheng_ has joined #openstack-horizon | 20:05 | |
| *** sqchen has quit IRC | 20:06 | |
| *** lhcheng has quit IRC | 20:08 | |
| *** jbell8 has joined #openstack-horizon | 20:10 | |
| *** sqchen has joined #openstack-horizon | 20:10 | |
| *** clu has joined #openstack-horizon | 20:13 | |
| *** clu has quit IRC | 20:15 | |
| *** matt-borland has joined #openstack-horizon | 20:16 | |
| *** lucas___ has joined #openstack-horizon | 20:16 | |
| openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Add missing form attribute for image upload form https://review.openstack.org/190800 | 20:18 |
| *** matt-borland has quit IRC | 20:18 | |
| *** matt-borland has joined #openstack-horizon | 20:19 | |
| *** annashen has joined #openstack-horizon | 20:21 | |
| *** Sukhdev has joined #openstack-horizon | 20:25 | |
| *** sqchen has quit IRC | 20:29 | |
| *** stevemar has quit IRC | 20:30 | |
| *** alexpilotti has quit IRC | 20:31 | |
| *** TravT_ has joined #openstack-horizon | 20:31 | |
| *** jtomasek has quit IRC | 20:33 | |
| *** ongk has quit IRC | 20:36 | |
| *** radez is now known as radez_g0n3 | 20:38 | |
| *** dguerri` is now known as dguerri | 20:39 | |
| *** sqchen has joined #openstack-horizon | 20:40 | |
| *** ongk has joined #openstack-horizon | 20:42 | |
| *** dboik has quit IRC | 20:45 | |
| *** jbell8 has quit IRC | 20:46 | |
| *** e0ne has quit IRC | 20:54 | |
| *** jbell8 has joined #openstack-horizon | 20:54 | |
| *** jbell8 has quit IRC | 20:55 | |
| tqtran_afk | matt-borland: ping | 21:03 |
| *** tqtran_afk is now known as tqtran | 21:04 | |
| tqtran | r1chardj0n3s: ping also | 21:04 |
| *** raildo has quit IRC | 21:04 | |
| matt-borland | tqtran: here! | 21:05 |
| tqtran | I have a question on this patch: https://review.openstack.org/#/c/182786/ | 21:05 |
| matt-borland | whoops, service unavailable | 21:05 |
| tqtran | heah its dpwn | 21:05 |
| matt-borland | which one is that? | 21:06 |
| tqtran | https://github.com/openstack/horizon/commit/659f385424e46ee2d40ee642541053914a888681 | 21:06 |
| matt-borland | ah, yes | 21:06 |
| *** ttrifonov is now known as zz_ttrifonov | 21:06 | |
| tqtran | so if i remembered correctly, we had a jasmine spec runner in horizon, you introduced a jasmine spec runner into dashboard | 21:06 |
| tqtran | and now we're saying its not getting use anywhere? | 21:06 |
| -openstackstatus- NOTICE: Gerrit has been restarted to terminate a persistent looping third-party CI bot | 21:06 | |
| matt-borland | yeah, that file wasn't necessary though I believe | 21:07 |
| matt-borland | because of the way the app loaded using _10_project.py | 21:07 |
| tqtran | so how are tests running in dashboard then? | 21:08 |
| matt-borland | They run at the root level | 21:08 |
| matt-borland | oh, wait, sorry... | 21:08 |
| *** jingjing_ren has quit IRC | 21:08 | |
| tqtran | :) the root level is horizon, doesn't include dashboard | 21:09 |
| *** jwy has joined #openstack-horizon | 21:09 | |
| tqtran | that was the reason why you introduced the servicetests into dashboard, so that we had something to run against | 21:09 |
| matt-borland | Well, they can run separately. | 21:09 |
| *** tvanderwiel has quit IRC | 21:10 | |
| tqtran | yes, but by removing that file, you can't run it any longer | 21:10 |
| matt-borland | witness how they run in --only-selenium | 21:10 |
| *** Piet has joined #openstack-horizon | 21:10 | |
| *** crobertsrh is now known as _crobertsrh | 21:10 | |
| *** petertr7 is now known as petertr7_away | 21:11 | |
| *** TravT_ has quit IRC | 21:11 | |
| matt-borland | or just /jasmine/ with --runserver. | 21:11 |
| matt-borland | (which will run all, certainly) | 21:12 |
| tqtran | https://github.com/openstack/horizon/blob/master/horizon/test/jasmine/jasmine_tests.py | 21:13 |
| tqtran | non of the dashboard stuff is in there | 21:14 |
| matt-borland | ok? | 21:14 |
| matt-borland | I'm just saying that it gets the js files from _10_project.py | 21:14 |
| tqtran | so my question is, where is the dashboard specs included in the jasmine spec runner? | 21:14 |
| tqtran | ah | 21:14 |
| matt-borland | yeah, I don't like it...but that's OK, Tyr is looking into further cleanup of karma so it does similar things as the jasmine runner, | 21:15 |
| matt-borland | so just one config. | 21:15 |
| openstackgerrit | Merged openstack/horizon: JSCS Cleanup - karma.conf https://review.openstack.org/190134 | 21:16 |
| matt-borland | tyr_: anything to add? | 21:16 |
| matt-borland | ^^ | 21:16 |
| tqtran | ok thats fine, as long as it works | 21:17 |
| matt-borland | yep. | 21:17 |
| matt-borland | thanks! | 21:17 |
| tqtran | have you guys ran jasmine recently? seems to be failing | 21:17 |
| matt-borland | Well, the selenium tests are certainly failing... | 21:17 |
| tyr_ | reading... | 21:17 |
| tqtran | might be something richard introduced | 21:17 |
| *** jingjing_ren has joined #openstack-horizon | 21:18 | |
| matt-borland | I haven't checked dashboard stuff in the last several days | 21:18 |
| matt-borland | sadly the selenium gate always passes these days | 21:18 |
| matt-borland | regardless of test failure | 21:18 |
| tqtran | hz.api.service.js, utils.spec.js not found | 21:18 |
| matt-borland | fabulous! | 21:18 |
| tqtran | right, which is really bad | 21:18 |
| matt-borland | let's get a bug on that if not already | 21:18 |
| tqtran | gonna create a bug/fix for it right now | 21:19 |
| *** jtriley has quit IRC | 21:19 | |
| matt-borland | excellent, thanks. We need to continue testing both approaches at all times. | 21:20 |
| *** peristeri_ has quit IRC | 21:20 | |
| tqtran | yeah, especially since selenium isnt a voting job atm | 21:20 |
| tqtran | when are we going to fix that damn ff browser incompatibility issue? | 21:20 |
| *** dguerri is now known as dguerri` | 21:21 | |
| tyr_ | tests for dashboard are brought in via jasmine.html. the openstack_dashboard version of jasmine_tests.py wasn't actually executing any tests. | 21:22 |
| matt-borland | gotta duck out! | 21:23 |
| *** matt-borland has quit IRC | 21:23 | |
| tqtran | tyr_: so do we need the //openstack_dashboard/test/jasmine folder? | 21:30 |
| tyr_ | yes. Jasmine.py is the piece that assembles the source and test from the various plugins | 21:32 |
| tyr_ | For example, https://review.openstack.org/#/c/188067/2/openstack_dashboard/test/jasmine/jasmine.py | 21:32 |
| *** lucas___ has quit IRC | 21:32 | |
| tyr_ | This patch demonstrates a way to include common test-only functionality in a sort of "test framework" | 21:33 |
| tyr_ | er...checking if what I just said is still actually true. | 21:34 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Utils for auto-file-discovery https://review.openstack.org/183364 | 21:36 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Rename files to enable auto-file-discovery https://review.openstack.org/190028 | 21:36 |
| *** TravT_ has joined #openstack-horizon | 21:37 | |
| *** nlahouti has joined #openstack-horizon | 21:38 | |
| tyr_ | tqtran: I not 100% certain if openstack_dashboard/test/jasmine/jasmine.py is currently needed since it appears to simply override the horizon version | 21:39 |
| tyr_ | I'd need to test a bit to sort it out. However, ultimately we want/need to be able to test the framework separately from the application. Richard's work to unDjangle (tm) base.html will make this a little easier. | 21:40 |
| tyr_ | After Richard's reorg stuff goes through, I think we will again need an openstack_dashboard verison of jasmine_test.py, to allow for testing code that is shared by multiple dashboards (like the APIs) | 21:42 |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: JSCS cleanup - style guide cleanup for modal https://review.openstack.org/189460 | 21:43 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Removing unused file references in Jasmine https://review.openstack.org/190830 | 21:43 |
| *** lucas___ has joined #openstack-horizon | 21:43 | |
| tqtran | tyr_: ok just read up on what you said | 21:44 |
| tqtran | can you write a bug on this so we are tracking it? | 21:44 |
| tyr_ | sure! | 21:45 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Removing unused file references in Jasmine https://review.openstack.org/190830 | 21:45 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Removing unused file references in Jasmine https://review.openstack.org/190830 | 21:45 |
| tqtran | thanks tyr_!!!! | 21:47 |
| *** lucas___ has quit IRC | 21:48 | |
| *** TravT_ has quit IRC | 21:48 | |
| tqtran | r1chardj0n3s: ping pong, need to talk to you about the babel patch | 21:48 |
| tqtran | r1chardj0n3s: dont think we need the compilemessages part, can rely on django to do that for us | 21:49 |
| *** lucas___ has joined #openstack-horizon | 21:51 | |
| *** annashen has quit IRC | 21:53 | |
| *** lucas___ has quit IRC | 21:56 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Angular table paging buttons clickable https://review.openstack.org/190747 | 21:58 |
| *** lucas has joined #openstack-horizon | 21:58 | |
| tyr_ | tqtran: That bug report you requested is ready: https://bugs.launchpad.net/horizon/+bug/1464424 | 21:59 |
| openstack | Launchpad bug 1464424 in OpenStack Dashboard (Horizon) "Separate openstack_dashboard jasmine tests " [Undecided,New] | 21:59 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: auto-file-discovery - apply to jasmine runner https://review.openstack.org/189997 | 21:59 |
| tqtran | thanks tyr_, subscribed myself to it | 21:59 |
| tqtran | very descriptive if i might add, great contexts | 22:00 |
| tyr_ | Ryan's API patch https://review.openstack.org/#/c/184543/ will set up the need to fix that new bug | 22:00 |
| tyr_ | great. Thanks! | 22:00 |
| *** doug-fish has left #openstack-horizon | 22:01 | |
| *** lucas___ has joined #openstack-horizon | 22:01 | |
| *** lucas___ has quit IRC | 22:02 | |
| tqtran | yeah i have his and richard's marked for next review | 22:02 |
| *** lucas___ has joined #openstack-horizon | 22:02 | |
| *** lucas has quit IRC | 22:03 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Apply auto-file-discovery to _10_project https://review.openstack.org/190038 | 22:03 |
| *** lucas___ has quit IRC | 22:07 | |
| *** sqchen has quit IRC | 22:10 | |
| *** sqchen has joined #openstack-horizon | 22:10 | |
| *** matt-borland has joined #openstack-horizon | 22:13 | |
| *** sqchen has quit IRC | 22:14 | |
| *** ybathia has joined #openstack-horizon | 22:17 | |
| *** absubram has quit IRC | 22:22 | |
| *** Sukhdev has quit IRC | 22:25 | |
| *** jwy has quit IRC | 22:29 | |
| r1chardj0n3s | tqtran: hi | 22:34 |
| tqtran | hey richard | 22:35 |
| r1chardj0n3s | so that patch is neill's really, I'm hands-off the implementation :) | 22:35 |
| tqtran | https://review.openstack.org/#/c/188665/ | 22:35 |
| tqtran | ah ok | 22:35 |
| tqtran | yeah i left a comment there | 22:35 |
| *** ericpeterson has quit IRC | 22:36 | |
| r1chardj0n3s | ok, cool | 22:36 |
| r1chardj0n3s | the commit message I changed was adding the depends-on | 22:37 |
| r1chardj0n3s | mostly because I was training some people about openstack contribution, not because it was strictly necessary ;) | 22:37 |
| tqtran | ah ok, got it | 22:41 |
| tqtran | yeah, i think it make sense to reuse django's compile messages | 22:41 |
| tqtran | this way, we dont have to worry about locale and such | 22:41 |
| neillc | tqtran: I'll remove/split the compilemessages step. I'm not really happy with it :) | 22:43 |
| neillc | Was mainly about consistency. | 22:43 |
| *** matt-borland has quit IRC | 22:43 | |
| tqtran | neillc: ok, would be good if you can move out the config file too | 22:44 |
| neillc | Lots of comments in the commit because of concerns. | 22:44 |
| tqtran | and i dont think you need the keyword defaults either | 22:44 |
| tqtran | those are auto included in ngu gettext | 22:44 |
| neillc | r1chardj0n3s has suggested a follow on patch perhaps. | 22:44 |
| tqtran | yeah, i wanna come back to it after global req merges | 22:45 |
| *** clu has joined #openstack-horizon | 22:45 | |
| neillc | keywords seem to make a difference to message catalog, but I will do some testing to double check. | 22:45 |
| *** jtriley has joined #openstack-horizon | 22:46 | |
| neillc | I think babel may override default keywords. Will chrck. | 22:46 |
| tqtran | ok coolios | 22:51 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding Angular Identity Dashboard https://review.openstack.org/190852 | 22:51 |
| *** annashen has joined #openstack-horizon | 22:54 | |
| *** annashen has quit IRC | 22:55 | |
| *** lhcheng_ has quit IRC | 22:58 | |
| *** lhcheng has joined #openstack-horizon | 22:58 | |
| *** jingjing_ren has quit IRC | 22:59 | |
| *** jwy has joined #openstack-horizon | 23:00 | |
| *** jbell8 has joined #openstack-horizon | 23:01 | |
| *** jtriley has quit IRC | 23:02 | |
| *** lhcheng has quit IRC | 23:02 | |
| *** lucas has joined #openstack-horizon | 23:05 | |
| *** lucas has quit IRC | 23:06 | |
| *** lucas has joined #openstack-horizon | 23:06 | |
| *** ZZelle_ has quit IRC | 23:06 | |
| *** cuddyt has quit IRC | 23:06 | |
| *** ongk has quit IRC | 23:07 | |
| *** lucas has quit IRC | 23:10 | |
| *** annashen has joined #openstack-horizon | 23:11 | |
| *** lucas has joined #openstack-horizon | 23:11 | |
| *** lucas has quit IRC | 23:13 | |
| *** lucas has joined #openstack-horizon | 23:13 | |
| *** Drago has quit IRC | 23:13 | |
| *** zhenguo has joined #openstack-horizon | 23:15 | |
| *** lucas has quit IRC | 23:18 | |
| *** mwhagedorn has quit IRC | 23:18 | |
| *** Sukhdev has joined #openstack-horizon | 23:19 | |
| *** annashen has quit IRC | 23:21 | |
| *** ccrouch has quit IRC | 23:22 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: WIP - injectjs - a new Django command https://review.openstack.org/189415 | 23:25 |
| *** jingjing_ren has joined #openstack-horizon | 23:26 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: WIP: Converting horizon JS to use use i18n library https://review.openstack.org/180157 | 23:30 |
| *** jingjing_ren has quit IRC | 23:31 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: WIP: Converting horizon JS to use use i18n library https://review.openstack.org/180157 | 23:34 |
| *** chlong has joined #openstack-horizon | 23:35 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: WIP: Converting horizon JS to use use i18n library https://review.openstack.org/180157 | 23:37 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: WIP: Converting horizon JS to use use i18n library https://review.openstack.org/180157 | 23:37 |
| *** annashen has joined #openstack-horizon | 23:38 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: WIP: Converting horizon JS to use use i18n library https://review.openstack.org/180157 | 23:38 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: WIP: Converting horizon JS to use use i18n library https://review.openstack.org/180157 | 23:39 |
| *** tyr_ has quit IRC | 23:40 | |
| *** yamamoto has joined #openstack-horizon | 23:41 | |
| *** lucas has joined #openstack-horizon | 23:43 | |
| *** lucas___ has joined #openstack-horizon | 23:44 | |
| *** lucas___ has quit IRC | 23:45 | |
| *** lucas has quit IRC | 23:45 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding Angular Users Panel https://review.openstack.org/190865 | 23:45 |
| *** lucas has joined #openstack-horizon | 23:45 | |
| *** tosky has quit IRC | 23:47 | |
| *** yamamoto has quit IRC | 23:47 | |
| *** lucas has quit IRC | 23:50 | |
| *** ybathia has quit IRC | 23:50 | |
| *** ongk has joined #openstack-horizon | 23:50 | |
| *** ongk has quit IRC | 23:51 | |
| *** tqtran has quit IRC | 23:52 | |
| *** lucas has joined #openstack-horizon | 23:52 | |
| *** lhcheng has joined #openstack-horizon | 23:56 | |
| *** jingjing_ren has joined #openstack-horizon | 23:56 | |
| *** lucas has quit IRC | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!