| *** garthb_ has quit IRC | 00:03 | |
| *** petertr7_away is now known as petertr7 | 00:03 | |
| *** alexvictorchan_ has quit IRC | 00:10 | |
| *** jtriley has joined #openstack-horizon | 00:11 | |
| *** petertr7 is now known as petertr7_away | 00:13 | |
| *** gokrokve has quit IRC | 00:13 | |
| *** gokrokve has joined #openstack-horizon | 00:14 | |
| *** jtriley has quit IRC | 00:15 | |
| *** gokrokve has quit IRC | 00:18 | |
| *** hurgleburgler has quit IRC | 00:20 | |
| tqtran | r1chardj0n3s: ping, you stil here? | 00:24 |
|---|---|---|
| r1chardj0n3s | tqtran: yus! | 00:24 |
| tqtran | ok so babel does have string extraction tools as mentioned | 00:25 |
| *** ybathia has quit IRC | 00:25 | |
| tqtran | but it doesn't the format we want, for example: | 00:25 |
| tqtran | you can do something like gettext('single', 'plural', 'context') | 00:26 |
| tqtran | and you can replace gettext with a different function name | 00:26 |
| *** ongk has joined #openstack-horizon | 00:26 | |
| tqtran | or even re-arrange the ordering of the params | 00:26 |
| tqtran | so something like sexybeast('plural', 'context', 'singular') will also work | 00:26 |
| tqtran | BUT what you can't do is <div trans>singular</div> or <trans>singular</trans> | 00:27 |
| tqtran | all text translation tools out there right now is base off of the gnu gettext | 00:27 |
| r1chardj0n3s | wait, isn't that what http://babel.edgewall.org/browser/contrib/django/babeldjango/extract.py for example is doing? | 00:27 |
| r1chardj0n3s | it's looking for translation blocks django-style (as well as functions) | 00:28 |
| tqtran | one sec, let me look at code | 00:28 |
| tqtran | can you find usage examples of that function? | 00:30 |
| r1chardj0n3s | usage of the extract function? | 00:30 |
| r1chardj0n3s | it's a plugin for babel | 00:30 |
| *** botang has joined #openstack-horizon | 00:32 | |
| tqtran | so im reading the code | 00:34 |
| tqtran | doesnt look like its doing anything with keywords? | 00:34 |
| *** gyee has quit IRC | 00:34 | |
| tqtran | its only listed as a param, but never used in the code | 00:34 |
| r1chardj0n3s | well yes, because it's using the tags | 00:35 |
| openstackgerrit | Merged openstack/horizon: Provide unittests for magic-search.js https://review.openstack.org/179168 | 00:36 |
| r1chardj0n3s | extract is a generator, returns the things for translation. how they're extracted is entirely up to you. in the django example above it uses the django template parser. for us, we could use the regex thing you wrote | 00:37 |
| tqtran | ok lets assuming that i can pass in keywords, how would i translate something like: "<div translate>hello</div>" in babel? | 00:37 |
| r1chardj0n3s | you don't need to use the keywords argument | 00:37 |
| r1chardj0n3s | you ignore it | 00:37 |
| r1chardj0n3s | the function/generator can do whatever it wants to get the info out of the file | 00:38 |
| r1chardj0n3s | it's just code | 00:38 |
| tqtran | ok so you're saying, we would have to implement a file like this one | 00:39 |
| tqtran | and how does it get included into the django catalog object? | 00:39 |
| r1chardj0n3s | you use babel instead of django | 00:40 |
| r1chardj0n3s | ugh mistype | 00:40 |
| tqtran | >< | 00:40 |
| r1chardj0n3s | you use babel instead of django's makemessages call to generate the same catalog file | 00:40 |
| tqtran | um... that doesn't sound good | 00:40 |
| r1chardj0n3s | why? | 00:40 |
| tqtran | because now there is two translation layer to use | 00:41 |
| r1chardj0n3s | no, there's one | 00:41 |
| r1chardj0n3s | just babel | 00:41 |
| tqtran | but we already have django | 00:41 |
| tqtran | why not just hook into that? | 00:41 |
| openstackgerrit | Merged openstack/horizon: JSHINT error on master https://review.openstack.org/187332 | 00:41 |
| r1chardj0n3s | the angular extraction is done using a plugin which we can publish and share (because it extracts standard angular-gettext messages) | 00:41 |
| r1chardj0n3s | so instead of a hack inside horizon, everything is out in the open and clearer | 00:41 |
| tqtran | we can still publish and share the django command we wrote up | 00:42 |
| r1chardj0n3s | as I said earlier, what we do here is a legacy we're leaving for future horizon developers. Horizon today is full of obscure stuff that's a serious impediment to incoming developers. I'd really like to avoid adding to that while we're also trying to clean it up. | 00:42 |
| tqtran | it works the same way, its sort of like a plugin, just include and you're good to go | 00:43 |
| r1chardj0n3s | "sort of like a plugin" except not? :) | 00:43 |
| *** tyr_ has joined #openstack-horizon | 00:43 | |
| tqtran | so what you're saying is, introduce babel and move everything that we have today do it? | 00:43 |
| tqtran | that sounds like a lot of work for a small feature | 00:44 |
| r1chardj0n3s | I don't think i18n is a small feature - and the "plugin" you're talking about is going to get more complex as it handles more of angular-gettext | 00:45 |
| tqtran | having 2 translation layer will make it more confusing | 00:45 |
| r1chardj0n3s | but there won't *ve* 2 | 00:45 |
| r1chardj0n3s | be even | 00:45 |
| r1chardj0n3s | lol | 00:45 |
| tqtran | lol | 00:45 |
| r1chardj0n3s | what you're talking about is 2 layers | 00:45 |
| r1chardj0n3s | standard django makemessage and then a hack layer on top of that (that's fragile if makemessage ever changes) to do some other munging as well | 00:46 |
| r1chardj0n3s | (no, I'm not going to stop calling it a hack :) | 00:46 |
| tqtran | ok if you look at extract_django, its doing pretty similar things | 00:46 |
| tqtran | so its not really a hack, its working code | 00:47 |
| *** bpokorny has quit IRC | 00:47 | |
| *** tyr_ has quit IRC | 00:48 | |
| tqtran | its like saying, why didn't we just use the django-REST framework instead of using what we have today? do you consider that a hack? | 00:48 |
| tqtran | :) pom pom pom | 00:48 |
| r1chardj0n3s | it's a hack in the sense that it's extending a class that you don't control (hence fragile) to munge a file into some temporary file for further processing by something that isn't extensible enough to be directly modified. | 00:49 |
| r1chardj0n3s | that's a hack | 00:49 |
| r1chardj0n3s | the code works, sure, but that doesn't change the semantics | 00:49 |
| r1chardj0n3s | ugh, my Internet is stuffed | 00:50 |
| tqtran | ok, i think this is a bigger discussion then just between the 2 of us | 00:50 |
| tqtran | i'll bring it up at the horizon meeting and get other's feedback | 00:50 |
| r1chardj0n3s | ... and I'm back, I think | 00:51 |
| r1chardj0n3s | tqtran: yeah, sorry to be a pain in the ass about this, but the legacy issue is something I'm deeply worried about | 00:51 |
| r1chardj0n3s | tqtran: it's why I also don't want to see us writing our own angular-gettext | 00:52 |
| tqtran | did you see the comment about bringing it up for discussion at meeting? | 00:52 |
| *** alexvictorchan has joined #openstack-horizon | 00:52 | |
| r1chardj0n3s | yep, thanks | 00:52 |
| tqtran | yeah i understand, i really wouldnt mind using some 3rd party stuff for extraction, but thats not really an option atm. and i hate to introduce yet another translation tool since django already provides one | 00:53 |
| tqtran | basically my preference is to build on top of what we have already | 00:53 |
| tqtran | as oppose to switching to another framework that most of us aren't familiar with yet | 00:53 |
| tqtran | and if we havent use it, there are probably pitfalls we arent't aware of yet | 00:54 |
| r1chardj0n3s | agh, dropped again | 00:54 |
| tqtran | >< | 00:54 |
| r1chardj0n3s | (I got your messages tho) | 00:54 |
| tqtran | yeah i understand, i really wouldnt mind using some 3rd party stuff for extraction, but thats not really an option atm. and i hate to introduce yet another translation tool since django already provides one | 00:54 |
| tqtran | basically my preference is to build on top of what we have already | 00:54 |
| tqtran | as oppose to switching to another framework that most of us aren't familiar with yet | 00:54 |
| tqtran | ok good lol | 00:54 |
| tqtran | ops... apparently i copy/pasted | 00:55 |
| r1chardj0n3s | I use a separate server to connect to IRC so it's always connected even if my home Internet is dead | 00:55 |
| r1chardj0n3s | so I don't miss any messages, just can't send any sometimes :/ | 00:55 |
| tqtran | i see | 00:55 |
| r1chardj0n3s | OK, let's continue to discuss in a broader context at the meeting | 00:56 |
| * r1chardj0n3s looks up when the next one is | 00:56 | |
| r1chardj0n3s | oh, tonight, I think | 00:56 |
| r1chardj0n3s | oh, no, it's tomorrow 6am | 00:56 |
| r1chardj0n3s | ok | 00:56 |
| tqtran | hm.... is it 1200 utc or 2000 utc? | 00:57 |
| r1chardj0n3s | June 3 2000 UTC | 00:57 |
| tqtran | cool, thats like 12pm my time :D | 00:59 |
| tqtran | so if you're not there, i win right? hahahaha | 00:59 |
| r1chardj0n3s | :) | 01:00 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Angular translation makemessages for singular https://review.openstack.org/187321 | 01:00 |
| r1chardj0n3s | it's really, really cold here in the mornings at the moment, but Imma get up anyway ;) | 01:00 |
| *** jingjing_ren has quit IRC | 01:01 | |
| tqtran | hahaha, you really don't have to | 01:01 |
| *** lhcheng has quit IRC | 01:01 | |
| r1chardj0n3s | you'll push my point of view in the dicussion? thanks!! :) | 01:01 |
| tqtran | LOL | 01:01 |
| tqtran | yeah i will cover both of our POV | 01:01 |
| tqtran | so you want to move everything to babel? | 01:02 |
| r1chardj0n3s | so hey, I also wanted to hassle you about that review comment you made on https://review.openstack.org/#/c/185140/ | 01:02 |
| *** sjmc7 has joined #openstack-horizon | 01:02 | |
| tqtran | and basically not use django translation at all? | 01:02 |
| tqtran | we would need to use the babeldjango plugin as well | 01:02 |
| r1chardj0n3s | not use django *makemessage* | 01:02 |
| tqtran | in other to support legacy | 01:03 |
| r1chardj0n3s | using django translation is fine | 01:03 |
| *** lhcheng has joined #openstack-horizon | 01:03 | |
| *** yamamoto has joined #openstack-horizon | 01:03 | |
| tqtran | so if you dont use the makemessage, does it get incorporated into django catalog object? | 01:03 |
| tqtran | basically, we can get it translated, but how do we get the translated texts client-side? | 01:04 |
| tqtran | you know what would really help? if you want to put up a patch to demostrate this | 01:04 |
| tqtran | seeing code will help make it clearer to me | 01:04 |
| r1chardj0n3s | yes, the messages are extracted into the same catalog | 01:04 |
| r1chardj0n3s | doing otherwise would be crazy ;) | 01:05 |
| *** jwy has quit IRC | 01:05 | |
| tqtran | ok, so let me get it straight in case i have to argue for you | 01:05 |
| tqtran | you're saying: use babel for the text extraction instead of django's makemessages | 01:06 |
| r1chardj0n3s | 1) use angular-gettext now, not later | 01:06 |
| tqtran | and everything else will be django-based | 01:06 |
| r1chardj0n3s | 2) use babel to extract messages from django templates and angular templates, exrtacting into the current messages catalog | 01:06 |
| r1chardj0n3s | 3) use django's translation system as we do today over the top of that messages catalog | 01:06 |
| tqtran | ok | 01:06 |
| r1chardj0n3s | did I miss anything? | 01:06 |
| *** sjmc7 has quit IRC | 01:07 | |
| tqtran | need to have babeldjango plugin | 01:07 |
| tqtran | and write our own for the angular piece | 01:07 |
| r1chardj0n3s | yep, but you've already written the angular one ;) | 01:07 |
| tqtran | yeah, it can be re-use for babel | 01:07 |
| *** lhcheng has quit IRC | 01:07 | |
| r1chardj0n3s | you just need to refactor it a little and publish it | 01:07 |
| tqtran | ok i got it copied into notepad | 01:09 |
| r1chardj0n3s | I should do that also so I can be coherent at 6am ;) | 01:10 |
| tqtran | oh wow, its already 6:10pm here, im working too hard | 01:10 |
| r1chardj0n3s | yeah duded, take a break | 01:10 |
| *** ducttape_ has joined #openstack-horizon | 01:10 | |
| r1chardj0n3s | but PLEASE follow up on that comment thing I need feedback on first :) | 01:10 |
| tqtran | what comment? | 01:11 |
| r1chardj0n3s | "I also wanted to hassle you about that review comment you made on https://review.openstack.org/#/c/185140/" | 01:11 |
| r1chardj0n3s | :)_ | 01:11 |
| r1chardj0n3s | I need to know what you mean by it | 01:11 |
| tqtran | whoa page not found | 01:12 |
| r1chardj0n3s | https://review.openstack.org/#/c/185140/ | 01:12 |
| r1chardj0n3s | so this comment https://review.openstack.org/#/c/185140/12/horizon/static/dashboard-app/dashboard-app.module.js,cm | 01:13 |
| tqtran | ah ok | 01:13 |
| r1chardj0n3s | I'm not sure what you mean by "The last part is missing in this patch." | 01:13 |
| tqtran | so dashboard-app depends on framework, framework depends on framework.utils and framework.utils should depend on framework.util.tech-debt but it currently isnt | 01:14 |
| tqtran | https://github.com/openstack/horizon/blob/master/horizon/static/framework/util/util.module.js | 01:14 |
| tqtran | you need to add horizon.framework.util.tech-debt to that list | 01:14 |
| tqtran | otherwise, we will never get to that code | 01:14 |
| r1chardj0n3s | it is in the list... that's weird | 01:14 |
| r1chardj0n3s | wait, that's master | 01:15 |
| r1chardj0n3s | https://review.openstack.org/#/c/185140/12/horizon/static/framework/util/util.module.js,cm | 01:15 |
| tqtran | ah... | 01:15 |
| tqtran | yeah i see it | 01:15 |
| tqtran | i was looking for that file, must have missed it | 01:15 |
| tqtran | ok just the jshint stuff then | 01:16 |
| r1chardj0n3s | ok, thanks | 01:16 |
| r1chardj0n3s | hm, so I get no jshint errors | 01:17 |
| tqtran | https://review.openstack.org/#/c/185140/12/horizon/static/framework/util/tech-debt/helper-functions.js | 01:17 |
| r1chardj0n3s | oh, there's no errors, just the globals don't need to be there | 01:17 |
| r1chardj0n3s | ok | 01:17 |
| tqtran | global angular | 01:17 |
| r1chardj0n3s | and the others | 01:18 |
| tqtran | that is not needed since we already added angular to global | 01:18 |
| tqtran | yep | 01:18 |
| r1chardj0n3s | why does our jshintrc declare the globals false | 01:18 |
| r1chardj0n3s | ? | 01:18 |
| r1chardj0n3s | that's odd | 01:18 |
| tqtran | Setting an entry to true enables reading and writing to that variable. Setting it to false will trigger JSHint to consider that variable read-only. | 01:18 |
| tqtran | from the official jshint docs | 01:19 |
| r1chardj0n3s | ah, thanks | 01:19 |
| tqtran | you should also shoot travis an email explaning that you dont need to test that patch because its all legacy code you're moving around | 01:19 |
| r1chardj0n3s | yeah, I need to follow him up on that | 01:20 |
| tqtran | unless he wants you to write tests for legacy stuff, which i think will be a waste of your time | 01:20 |
| r1chardj0n3s | I needed to clarify which tests he was referring to, yeah | 01:20 |
| tqtran | just fix your jshint stuff and i'll re-approve | 01:20 |
| tqtran | would like to get this in asap | 01:20 |
| *** yamamoto has quit IRC | 01:21 | |
| tqtran | ok bbl, going to shoot some hoops! | 01:23 |
| *** tqtran is now known as tqtran_afk | 01:23 | |
| r1chardj0n3s | ok, have fun! | 01:23 |
| openstackgerrit | Richard Jones proposed openstack/horizon: ngReorg - move utils from dashboad-app https://review.openstack.org/185140 | 01:23 |
| openstackgerrit | Richard Jones proposed openstack/horizon: ngReorg - move utils from dashboad-app https://review.openstack.org/185140 | 01:23 |
| openstackgerrit | Richard Jones proposed openstack/horizon: ngReorg - move dashboard-app/login out https://review.openstack.org/185133 | 01:24 |
| *** Sukhdev has quit IRC | 01:24 | |
| *** Sukhdev has joined #openstack-horizon | 01:25 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: ngReorg - move dashboard controllers from horizon https://review.openstack.org/185132 | 01:25 |
| *** yamamoto has joined #openstack-horizon | 01:28 | |
| *** yamamoto has quit IRC | 01:29 | |
| *** jingjing_ren has joined #openstack-horizon | 01:31 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: ngReorg - move core HTML from framework to dashboard https://review.openstack.org/186295 | 01:32 |
| *** jwy has joined #openstack-horizon | 01:32 | |
| *** radez is now known as radez_g0n3 | 01:33 | |
| *** alanf-mc has quit IRC | 01:34 | |
| *** davidmichaelkarr has quit IRC | 01:35 | |
| *** DuncanT has quit IRC | 01:36 | |
| *** jingjing_ren has quit IRC | 01:38 | |
| *** ongk has quit IRC | 01:38 | |
| *** davidmichaelkarr has joined #openstack-horizon | 01:41 | |
| *** Sukhdev has quit IRC | 01:43 | |
| *** DuncanT has joined #openstack-horizon | 01:45 | |
| *** jbell8 has joined #openstack-horizon | 01:49 | |
| *** clu_ has joined #openstack-horizon | 02:00 | |
| *** alexpilotti has quit IRC | 02:00 | |
| *** nlahouti has quit IRC | 02:01 | |
| *** clu_ has quit IRC | 02:02 | |
| *** zhenguo has joined #openstack-horizon | 02:03 | |
| *** jwy has quit IRC | 02:05 | |
| *** yamamoto has joined #openstack-horizon | 02:13 | |
| *** ducttape_ has quit IRC | 02:18 | |
| *** KunalGan_ has joined #openstack-horizon | 02:21 | |
| *** dboik has joined #openstack-horizon | 02:31 | |
| *** sqchen has quit IRC | 02:31 | |
| *** ducttape_ has joined #openstack-horizon | 02:32 | |
| *** jingliuqing has joined #openstack-horizon | 02:33 | |
| *** sqchen has joined #openstack-horizon | 02:35 | |
| *** chlong has quit IRC | 02:39 | |
| *** jbell8 has quit IRC | 02:43 | |
| *** dboik has quit IRC | 02:45 | |
| *** yingjun has joined #openstack-horizon | 02:51 | |
| openstackgerrit | Eric Peterson proposed openstack/horizon: Don't pass read only attributes on neutron update https://review.openstack.org/186211 | 02:52 |
| *** amotoki has joined #openstack-horizon | 02:56 | |
| *** 17SACPWTU has joined #openstack-horizon | 02:58 | |
| ducttape_ | r1chardj0n3s - ping | 03:03 |
| r1chardj0n3s | ducttape_: yup? | 03:03 |
| ducttape_ | I was looking at a review of yours - https://review.openstack.org/#/c/185133/ | 03:03 |
| ducttape_ | I think I grock it, but saw a lot of copyright IBM stuff. not sure if you intended this or cared | 03:04 |
| r1chardj0n3s | I'm just moving files around, copyright notices intact | 03:04 |
| ducttape_ | ah ok. thanks | 03:04 |
| r1chardj0n3s | that ngReorg patch chain is all about moving files around | 03:05 |
| r1chardj0n3s | (the linked bug has the justification) | 03:05 |
| ducttape_ | gotcha. seems fine to me, I'm not the most qualified to review the angular stuff but I get the idea | 03:06 |
| r1chardj0n3s | ok | 03:08 |
| openstackgerrit | Eric Peterson proposed openstack/horizon: Add fip to lbaas vip info https://review.openstack.org/180676 | 03:08 |
| *** sqchen has quit IRC | 03:11 | |
| openstackgerrit | Eric Peterson proposed openstack/horizon: Removing last_activity session flag https://review.openstack.org/179513 | 03:13 |
| *** sqchen has joined #openstack-horizon | 03:18 | |
| *** chlong has joined #openstack-horizon | 03:22 | |
| *** ducttape_ has quit IRC | 03:22 | |
| *** ducttape_ has joined #openstack-horizon | 03:27 | |
| *** fedexo has joined #openstack-horizon | 03:33 | |
| *** yingjun has quit IRC | 03:33 | |
| *** yingjun has joined #openstack-horizon | 03:39 | |
| *** alexvictorchan has quit IRC | 03:39 | |
| *** yamamoto has quit IRC | 03:48 | |
| *** yamamoto has joined #openstack-horizon | 03:48 | |
| *** clu_ has joined #openstack-horizon | 03:49 | |
| *** clu_ has quit IRC | 03:50 | |
| *** dsneddon has quit IRC | 03:51 | |
| *** ducttape_ has quit IRC | 03:54 | |
| *** ducttape_ has joined #openstack-horizon | 03:55 | |
| openstackgerrit | Lin Cai proposed openstack/horizon: I/O error uploading image https://review.openstack.org/184935 | 03:57 |
| *** ducttape_ has quit IRC | 04:00 | |
| *** yamamoto has quit IRC | 04:01 | |
| *** jingliuqing has quit IRC | 04:02 | |
| *** yingjun has quit IRC | 04:07 | |
| *** yamamoto has joined #openstack-horizon | 04:08 | |
| *** bpokorny has joined #openstack-horizon | 04:13 | |
| *** lhcheng has joined #openstack-horizon | 04:16 | |
| *** bpokorny has quit IRC | 04:17 | |
| *** Sukhdev has joined #openstack-horizon | 04:21 | |
| *** david-lyle has quit IRC | 04:24 | |
| *** david-lyle has joined #openstack-horizon | 04:25 | |
| *** ChanServ sets mode: +o david-lyle | 04:25 | |
| *** neelabh has joined #openstack-horizon | 04:29 | |
| *** alexvictorchan has joined #openstack-horizon | 04:35 | |
| *** garthb has joined #openstack-horizon | 04:36 | |
| *** jingliuqing has joined #openstack-horizon | 04:39 | |
| *** alexvictorchan has quit IRC | 04:42 | |
| *** KunalGan_ has quit IRC | 04:43 | |
| *** KunalGandhi has joined #openstack-horizon | 04:45 | |
| *** clu_ has joined #openstack-horizon | 04:50 | |
| *** KunalGandhi has quit IRC | 04:50 | |
| *** clu_ has quit IRC | 04:51 | |
| openstackgerrit | lawrancejing proposed openstack/horizon: Refactor some scss code https://review.openstack.org/187163 | 04:56 |
| *** ducttape_ has joined #openstack-horizon | 04:56 | |
| *** ducttape_ has quit IRC | 05:01 | |
| *** garthb has quit IRC | 05:02 | |
| *** lhcheng_ has joined #openstack-horizon | 05:06 | |
| *** Longgeek has joined #openstack-horizon | 05:07 | |
| *** lhcheng has quit IRC | 05:09 | |
| *** kiran-r has joined #openstack-horizon | 05:13 | |
| *** yingjun has joined #openstack-horizon | 05:13 | |
| *** Longgeek has quit IRC | 05:13 | |
| *** yingjun has quit IRC | 05:14 | |
| *** tqtran_afk has quit IRC | 05:17 | |
| *** jingjing_ren has joined #openstack-horizon | 05:22 | |
| *** jingjing_ren has quit IRC | 05:27 | |
| *** stevemar has quit IRC | 05:31 | |
| *** reed has quit IRC | 05:33 | |
| *** KunalGandhi has joined #openstack-horizon | 05:34 | |
| *** Kunal has joined #openstack-horizon | 05:34 | |
| *** zhenguo has quit IRC | 05:37 | |
| *** sqchen has quit IRC | 05:37 | |
| *** KunalGandhi has quit IRC | 05:39 | |
| *** Kunal has quit IRC | 05:44 | |
| *** reed has joined #openstack-horizon | 05:47 | |
| *** Longgeek has joined #openstack-horizon | 05:52 | |
| *** masco has joined #openstack-horizon | 05:58 | |
| *** sumanth has quit IRC | 06:04 | |
| *** yingjun has joined #openstack-horizon | 06:04 | |
| *** neelabh has quit IRC | 06:12 | |
| *** yingjun has quit IRC | 06:19 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/187469 | 06:20 |
| *** Sukhdev has quit IRC | 06:21 | |
| *** neelabh has joined #openstack-horizon | 06:24 | |
| *** KunalGandhi has joined #openstack-horizon | 06:24 | |
| *** nlahouti has joined #openstack-horizon | 06:25 | |
| *** nlahouti has quit IRC | 06:27 | |
| *** Kunal has joined #openstack-horizon | 06:27 | |
| *** nlahouti has joined #openstack-horizon | 06:29 | |
| *** yingjun has joined #openstack-horizon | 06:34 | |
| *** clu_ has joined #openstack-horizon | 06:38 | |
| *** belmoreira has joined #openstack-horizon | 06:38 | |
| *** clu_ has quit IRC | 06:40 | |
| *** markus_z has joined #openstack-horizon | 06:43 | |
| *** mrunge has joined #openstack-horizon | 06:43 | |
| *** ducttape_ has joined #openstack-horizon | 06:45 | |
| *** jingliuqing has quit IRC | 06:48 | |
| *** jcoufal has joined #openstack-horizon | 06:48 | |
| *** ducttape_ has quit IRC | 06:50 | |
| *** jcoufal has quit IRC | 06:50 | |
| *** jcoufal has joined #openstack-horizon | 06:52 | |
| *** krykowski has joined #openstack-horizon | 06:53 | |
| *** zhenguo has joined #openstack-horizon | 06:54 | |
| openstackgerrit | Neill Cox proposed openstack/horizon: Single page navigation https://review.openstack.org/137980 | 06:56 |
| *** zz_ttrifonov is now known as ttrifonov | 06:57 | |
| *** neillc is now known as neillc_away | 06:58 | |
| *** ttrifonov is now known as zz_ttrifonov | 07:04 | |
| *** krykowski has quit IRC | 07:05 | |
| *** Drago has quit IRC | 07:12 | |
| *** Drago has joined #openstack-horizon | 07:13 | |
| *** Drago has quit IRC | 07:14 | |
| *** nlahouti has quit IRC | 07:17 | |
| *** jsheeren has joined #openstack-horizon | 07:17 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: Support of rescue instance in Horizon https://review.openstack.org/107379 | 07:21 |
| *** lhcheng_ has quit IRC | 07:23 | |
| *** KunalGandhi has quit IRC | 07:24 | |
| *** neelabh has quit IRC | 07:28 | |
| *** Kunal has quit IRC | 07:28 | |
| *** nlahouti has joined #openstack-horizon | 07:46 | |
| *** dguerri`away is now known as dguerri | 07:48 | |
| *** Ala has joined #openstack-horizon | 07:52 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/187469 | 07:53 |
| *** fedexo has quit IRC | 07:53 | |
| *** oro has joined #openstack-horizon | 07:54 | |
| *** nlahouti has quit IRC | 07:56 | |
| *** chlong has quit IRC | 07:56 | |
| *** akrivoka has joined #openstack-horizon | 07:57 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 08:00 | |
| *** bluex-pl has joined #openstack-horizon | 08:00 | |
| *** JeanBriceCombebi has quit IRC | 08:00 | |
| *** ducttape_ has joined #openstack-horizon | 08:01 | |
| *** ygbo has joined #openstack-horizon | 08:02 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 08:03 | |
| *** ducttape_ has quit IRC | 08:06 | |
| *** jingliuqing has joined #openstack-horizon | 08:10 | |
| *** zz_ttrifonov is now known as ttrifonov | 08:12 | |
| *** yingjun has quit IRC | 08:15 | |
| *** romainh has joined #openstack-horizon | 08:18 | |
| *** mpavlase has joined #openstack-horizon | 08:23 | |
| *** 17SACPWTU has quit IRC | 08:24 | |
| *** jbell8 has joined #openstack-horizon | 08:24 | |
| *** jbell8 has quit IRC | 08:25 | |
| *** clu_ has joined #openstack-horizon | 08:27 | |
| *** ZZelle has quit IRC | 08:28 | |
| *** ZZelle has joined #openstack-horizon | 08:28 | |
| *** clu_ has quit IRC | 08:29 | |
| *** unixlike has joined #openstack-horizon | 08:42 | |
| unixlike | Hi there ! | 08:42 |
| *** vkmc has quit IRC | 08:45 | |
| *** vkmc has joined #openstack-horizon | 08:45 | |
| unixlike | I just looking for an solution to make hide and show some widgets of workflow like a Instance Boot Source in create_instance workflow | 08:45 |
| *** nlahouti has joined #openstack-horizon | 08:47 | |
| unixlike | I can't understand yet how this switching organized | 08:47 |
| *** nlahouti has quit IRC | 08:52 | |
| *** DaveJ__ has joined #openstack-horizon | 08:58 | |
| *** yingjun has joined #openstack-horizon | 08:59 | |
| *** aix has joined #openstack-horizon | 09:01 | |
| *** akrivoka has quit IRC | 09:03 | |
| *** jingliuqing has quit IRC | 09:03 | |
| *** akrivoka has joined #openstack-horizon | 09:04 | |
| *** neillc_away is now known as neillc | 09:08 | |
| *** JeanBriceCombebi has quit IRC | 09:11 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:12 | |
| *** nlahouti has joined #openstack-horizon | 09:17 | |
| *** e0ne has joined #openstack-horizon | 09:20 | |
| *** nlahouti has quit IRC | 09:22 | |
| *** yingjun has quit IRC | 09:33 | |
| openstackgerrit | Neill Cox proposed openstack/horizon: Single page navigation https://review.openstack.org/137980 | 09:35 |
| *** aix has quit IRC | 09:45 | |
| *** aix has joined #openstack-horizon | 09:45 | |
| *** JeanBriceCombebi has quit IRC | 09:46 | |
| *** nlahouti has joined #openstack-horizon | 09:48 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:48 | |
| *** josecastroleon has joined #openstack-horizon | 09:49 | |
| *** ducttape_ has joined #openstack-horizon | 09:50 | |
| *** nlahouti has quit IRC | 09:53 | |
| *** amotoki_ has joined #openstack-horizon | 09:53 | |
| *** ducttape_ has quit IRC | 09:55 | |
| *** yamamoto has quit IRC | 09:59 | |
| *** e0ne is now known as e0ne_ | 10:13 | |
| *** JeanBriceCombebi has quit IRC | 10:15 | |
| *** clu_ has joined #openstack-horizon | 10:16 | |
| *** clu_ has quit IRC | 10:17 | |
| *** e0ne_ has quit IRC | 10:24 | |
| *** e0ne has joined #openstack-horizon | 10:29 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: added description column in vpn tables https://review.openstack.org/187517 | 10:36 |
| *** ttrifonov is now known as zz_ttrifonov | 10:36 | |
| *** dguerri is now known as dguerri`away | 10:37 | |
| *** oro has quit IRC | 10:44 | |
| *** alexpilotti has joined #openstack-horizon | 10:46 | |
| *** ducttape_ has joined #openstack-horizon | 10:54 | |
| *** neelabh has joined #openstack-horizon | 10:59 | |
| *** Longgeek_ has joined #openstack-horizon | 11:01 | |
| *** Longgeek has quit IRC | 11:01 | |
| neelabh | Resource Usage panel is only showing Usage Report but not showing statics. I have run two instances but it is showing nothing.. | 11:02 |
| neelabh | please tell me why, Do I need some settings | 11:02 |
| *** liuqingqing has joined #openstack-horizon | 11:06 | |
| liuqingqing | Thai Tran: ping | 11:08 |
| *** zz_ttrifonov is now known as ttrifonov | 11:08 | |
| mrunge | liuqingqing, I would expect Thai in a few hours earliest | 11:13 |
| mrunge | liuqingqing, maybe 7 hours or so? | 11:14 |
| liuqingqing | :) i'm UTC8 | 11:15 |
| liuqingqing | some problem about the patch : https://review.openstack.org/#/c/159822/ | 11:15 |
| liuqingqing | one more question, the horizon meeting will coming about 8~9 hours later? | 11:17 |
| *** e0ne has quit IRC | 11:19 | |
| *** rushiagr_away is now known as rushiagr | 11:22 | |
| *** e0ne has joined #openstack-horizon | 11:24 | |
| *** e0ne is now known as e0ne_ | 11:25 | |
| *** e0ne_ is now known as e0ne | 11:30 | |
| mrunge | liuqingqing, uhm, isn't the meeting at 20 UTC tomorrow? | 11:31 |
| mrunge | liuqingqing, https://wiki.openstack.org/wiki/Meetings/Horizon | 11:32 |
| liuqingqing | mrunge, thanks | 11:34 |
| *** yingjun has joined #openstack-horizon | 11:37 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: added description column in firewall tables https://review.openstack.org/187536 | 11:39 |
| *** ducttape_ has quit IRC | 11:40 | |
| *** oro has joined #openstack-horizon | 11:49 | |
| *** romainh has quit IRC | 11:54 | |
| *** romainh1 has joined #openstack-horizon | 11:54 | |
| *** zhenguo has quit IRC | 11:57 | |
| neelabh | Resource Usage panel is only showing Usage Report but not showing statics. I have run two instances but it is showing nothing, please tell me why, Do I need some settings | 11:58 |
| *** Miouge has quit IRC | 12:02 | |
| *** liuqingqing has quit IRC | 12:02 | |
| *** e0ne is now known as e0ne_ | 12:04 | |
| *** ducttape_ has joined #openstack-horizon | 12:04 | |
| *** akrivoka has quit IRC | 12:04 | |
| mrunge | neelabh, do you have ceilometer configured? | 12:04 |
| neelabh | yes | 12:04 |
| neelabh | http://stackoverflow.com/questions/30593874/i-have-been-activated-the-ceilometer-but-it-is-showing-any-statics-in-resource-u | 12:05 |
| *** clu_ has joined #openstack-horizon | 12:05 | |
| mrunge | there is nothing to configure in horizon | 12:05 |
| *** akrivoka has joined #openstack-horizon | 12:05 | |
| neelabh | mrunge: plz see the this question posted by me | 12:05 |
| *** clu_ has quit IRC | 12:06 | |
| neelabh | mrunge: I have created two instance, which are running but When I See the Resource Panel It showing nothing on statics tab, | 12:06 |
| mrunge | neelabh, internet explorer? | 12:07 |
| neelabh | mrunge: No firefox | 12:07 |
| neelabh | I am using firefox | 12:07 |
| neelabh | centos 7 | 12:07 |
| mrunge | neelabh, did you do ./manage collectstatic at some point of time? | 12:07 |
| neelabh | no | 12:08 |
| *** ducttape_ has quit IRC | 12:08 | |
| mrunge | you should | 12:08 |
| mrunge | neelabh, one of devstacks issues are: it's just suitable for development | 12:08 |
| mrunge | neelabh, if you want to do just a tiny bit more: use a real install | 12:09 |
| mrunge | and before that, reinstall your machine | 12:09 |
| neelabh | mrunge: Thanks for responding, Have you seen the images on stack-over flow by me (http://stackoverflow.com/questions/30593874/i-have-been-activated-the-ceilometer-but-it-is-showing-any-statics-in-resource-u), Resource panel is activated.. | 12:09 |
| mrunge | devstack happily pollutes your system with all kinds of files | 12:09 |
| mrunge | neelabh, I saw, there are tiny images attached | 12:10 |
| neelabh | In stats Tab? | 12:10 |
| *** Miouge has joined #openstack-horizon | 12:11 | |
| mrunge | what? | 12:11 |
| neelabh | So what should I do, Should I run ./manage collectstatic, What It will do | 12:11 |
| mrunge | neelabh, is there shown anything? | 12:11 |
| mrunge | if you switch to images in stats tab? | 12:11 |
| *** thiagop has quit IRC | 12:11 | |
| mrunge | or something else? | 12:11 |
| mrunge | neelabh, that data is read out of ceilometer | 12:12 |
| neelabh | Yes stas tab It showing nothing | 12:12 |
| mrunge | and choosing a different metric? | 12:12 |
| neelabh | k | 12:12 |
| neelabh | I check every matrix showing nothing, When I change the matrix is gives alert "Error: An error occurred. Please try again later. | 12:13 |
| neelabh | × | 12:13 |
| neelabh | Error: An error occurred. Please try again later. " | 12:13 |
| *** e0ne_ has quit IRC | 12:14 | |
| mrunge | aha. you need to dive into logs | 12:15 |
| *** jsheeren has quit IRC | 12:15 | |
| neelabh | means? plz elaborate more on it.. Thanks | 12:15 |
| mrunge | i have no idea, where devstack stores its logs | 12:15 |
| mrunge | but you didn't describe, where you got your error message either | 12:16 |
| mrunge | you need to look at ceilometers logs and at horizons logs too | 12:16 |
| *** yingjun has quit IRC | 12:16 | |
| mrunge | if you caught an exception, please add that to your stackoverflow post, thanks | 12:16 |
| neelabh | K, as you told for matrix (like instance, memory, vcpus, tect) when I change the matrix I get alert error "Error: An error occurred. Please try again later. " | 12:17 |
| neelabh | As you told change matrix.. | 12:18 |
| neelabh | I have change the matrix then I am getting error as above.. | 12:18 |
| neelabh | As you told me that run ./manage collectstatic , from which directory Should I run.. | 12:19 |
| *** masco has quit IRC | 12:19 | |
| mrunge | neelabh, that should be a separate issue. | 12:21 |
| *** JeanBriceCombebi has joined #openstack-horizon | 12:21 | |
| mrunge | neelabh, I don't use devstack; thus, I have no idea, where it stores logs etc. | 12:22 |
| neelabh | mrunge : I am very sorry But I made mistake I session was out, But still I is giving nothing but only tiny thing with some time but no alert this time | 12:22 |
| neelabh | My session was out that why I was getting alert, sorry for that | 12:22 |
| mrunge | aha | 12:23 |
| neelabh | sorry | 12:23 |
| neelabh | but It is giving tiny figure when I hover the mouse on it.. | 12:24 |
| neelabh | But not detailed | 12:24 |
| neelabh | From which directory should I run "./manage collectstatic" | 12:26 |
| *** robcresswell_afk is now known as robcresswell | 12:32 | |
| *** Miouge has quit IRC | 12:32 | |
| *** e0ne has joined #openstack-horizon | 12:36 | |
| *** robcresswell is now known as robcresswell_afk | 12:38 | |
| *** robcresswell_afk has quit IRC | 12:47 | |
| *** _crobertsrh is now known as crobertsrh | 12:51 | |
| *** ducttape_ has joined #openstack-horizon | 12:51 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: [Launch Instance Fix] Tests for Base Controllers https://review.openstack.org/172057 | 12:52 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Angular API Unit Tests https://review.openstack.org/178227 | 12:56 |
| *** JeanBriceCombebi has quit IRC | 12:58 | |
| *** mrunge has quit IRC | 12:58 | |
| *** ducttape_ has quit IRC | 12:58 | |
| *** iurygregory has quit IRC | 12:59 | |
| *** matt-borland has joined #openstack-horizon | 12:59 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:00 | |
| *** oro has quit IRC | 13:01 | |
| *** sjmc7 has joined #openstack-horizon | 13:01 | |
| *** sjmc7 has quit IRC | 13:07 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: [Launch Instance Fix] Add Flavor Step Unit Tests https://review.openstack.org/167326 | 13:07 |
| openstackgerrit | Matt Borland proposed openstack/horizon: [Launch Instance Fix] Add Model Unit Tests https://review.openstack.org/167738 | 13:08 |
| *** kiran-r has quit IRC | 13:09 | |
| *** cardeois___ has quit IRC | 13:09 | |
| *** cardeois___ has joined #openstack-horizon | 13:09 | |
| *** petertr7_away is now known as petertr7 | 13:13 | |
| *** Ephur has joined #openstack-horizon | 13:13 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: [Launch Instance Fix] Add Model Unit Tests https://review.openstack.org/167738 | 13:14 |
| *** doug-fish has joined #openstack-horizon | 13:16 | |
| *** julim has joined #openstack-horizon | 13:17 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Extending test coverage for core components https://review.openstack.org/170554 | 13:18 |
| *** Ephur has quit IRC | 13:19 | |
| *** JeanBriceCombebi has quit IRC | 13:22 | |
| *** Ephur has joined #openstack-horizon | 13:23 | |
| *** yamamoto has joined #openstack-horizon | 13:25 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:26 | |
| *** yamamoto_ has joined #openstack-horizon | 13:26 | |
| *** yingjun has joined #openstack-horizon | 13:26 | |
| *** ducttape_ has joined #openstack-horizon | 13:27 | |
| *** ducttape_ has quit IRC | 13:27 | |
| *** radez_g0n3 is now known as radez | 13:28 | |
| *** yamamoto has quit IRC | 13:30 | |
| *** dguerri`away is now known as dguerri | 13:31 | |
| *** yamamoto_ has quit IRC | 13:32 | |
| matt-borland | Any and all, in the interests of getting the Angular service APIs get test coverage *before* the massive reorganization, I'd like to get the following tests in: https://review.openstack.org/#/c/178227/ | 13:33 |
| matt-borland | That way we can ensure functionality is consistent on both sides of the reorg. | 13:34 |
| *** lblanchard has joined #openstack-horizon | 13:34 | |
| doug-fish | matt-borland: yeah - I started looking at that yesterday. 927 lines is a lot to look at! But I'll set aside some time for that one today - I agree it's important | 13:35 |
| openstackgerrit | Doug Fish proposed openstack/horizon: I/O error uploading image https://review.openstack.org/184935 | 13:35 |
| *** yamamoto has joined #openstack-horizon | 13:36 | |
| doug-fish | I'm interesting in seeing this one merge: https://review.openstack.org/#/c/186211/ You can't edit IPv6 subnets without it! I'm hoping to cherry-pick it back to kilo. | 13:37 |
| doug-fish | s/interesting/interested | 13:37 |
| matt-borland | doug-fish: Thanks! I appreciate it...let me know if you want me to review any specific patches you have up as well :) | 13:38 |
| matt-borland | (e.g. the one I see up above) | 13:39 |
| doug-fish | :-) yeah https://review.openstack.org/#/c/186211/ is the one I'm most concerned about right now - I need to review this one myself as well: https://review.openstack.org/184935 - you can't upload images by file with Django 1.7+ without that fix. I'd appreciate other reviews on that as well. | 13:40 |
| matt-borland | OK, cool, I will do that! Thanks again. | 13:40 |
| doug-fish | np - thank you! | 13:40 |
| *** ErickHeinrich has joined #openstack-horizon | 13:41 | |
| *** ErickHeinrich has quit IRC | 13:41 | |
| *** peristeri has joined #openstack-horizon | 13:41 | |
| *** rushiagr is now known as rushiagr_away | 13:41 | |
| *** yingjun has quit IRC | 13:46 | |
| *** jtriley has joined #openstack-horizon | 13:49 | |
| *** dboik has joined #openstack-horizon | 13:50 | |
| *** masco has joined #openstack-horizon | 13:50 | |
| *** clu_ has joined #openstack-horizon | 13:53 | |
| *** clu_ has quit IRC | 13:55 | |
| *** Miouge has joined #openstack-horizon | 13:58 | |
| *** tyr_ has joined #openstack-horizon | 14:01 | |
| *** julim has quit IRC | 14:02 | |
| *** julim has joined #openstack-horizon | 14:03 | |
| *** mark-os has joined #openstack-horizon | 14:04 | |
| mark-os | Hey everyone | 14:05 |
| mark-os | Anyone struggling to login to their instance of their dashboard? | 14:06 |
| mark-os | Wondering if it's due to a new update | 14:06 |
| *** petertr7 is now known as petertr7_away | 14:08 | |
| *** gokrokve has joined #openstack-horizon | 14:09 | |
| *** petertr7_away is now known as petertr7 | 14:09 | |
| matt-borland | mark-os: I haven't seen that problem, I'm on master right now | 14:10 |
| mark-os | matt-borland: It's only started within the last hour | 14:10 |
| matt-borland | What are the symptoms? Do you see errors in your JavaScript console? | 14:10 |
| mark-os | unless I've changed something without realising there would be a knock on effect | 14:10 |
| mark-os | 'An error occurred authenticating. Please try again later.' I'm guessing this should be a keystone issue | 14:13 |
| *** ducttape_ has joined #openstack-horizon | 14:14 | |
| mark-os | matt-borland: yep, I've changed something. Realised what it is now. | 14:14 |
| matt-borland | cool! Good that it's not something in master. :) | 14:14 |
| *** masco has quit IRC | 14:17 | |
| openstackgerrit | Martin Pavlásek proposed openstack/horizon: Limit max length of gen_random_resource_name https://review.openstack.org/187600 | 14:17 |
| *** ericpeterson has joined #openstack-horizon | 14:18 | |
| neelabh | mark-os: I think, have same problem authentication Error During Login in dashbaord, I followed the following instruction | 14:19 |
| mark-os | neelabh: I discovered what the problem was I think, just need to test it now. | 14:20 |
| mark-os | Fingers crossed it'll be okay | 14:20 |
| neelabh | k grt ... | 14:21 |
| mark-os | neelabh: thanks for offering! | 14:22 |
| *** stevemar has joined #openstack-horizon | 14:23 | |
| neelabh | No problem.. | 14:23 |
| *** ducttape_ has quit IRC | 14:23 | |
| mark-os | matt-borland neelabh, yeah had no issue with logging in whenever I fixed one of the files with my login details. | 14:23 |
| *** radez is now known as radez_g0n3 | 14:23 | |
| mark-os | Tried a fresh install of Horizon and it worked fine :) | 14:23 |
| matt-borland | cool mark-os | 14:23 |
| openstackgerrit | Martin Pavlásek proposed openstack/horizon: Limit max length of gen_random_resource_name https://review.openstack.org/187600 | 14:24 |
| openstackgerrit | Justin Pomeroy proposed openstack/horizon: Prevent multiple form submission on table row actions https://review.openstack.org/187604 | 14:24 |
| mark-os | matt-borland: out of interest, is there a place which contains a list of updates being released for Horizon? | 14:24 |
| mark-os | matt-borland: one which includes the updates which have been released and also the updates which are planned for say, this week or next week for example? | 14:25 |
| matt-borland | mark-os: sadly, no. I discussed this with one of the people leading the reorganization yesterday. We really need a changelog/upgrade guide. | 14:26 |
| openstackgerrit | Martin Pavlásek proposed openstack/horizon: Limit max length of gen_random_resource_name https://review.openstack.org/187605 | 14:26 |
| matt-borland | I had to wade through quite a bit of name changes and they were not always easy to determine the current state. | 14:26 |
| *** radez_g0n3 is now known as radez | 14:26 | |
| mark-os | matt-borland: It would be a life saver being able to quickly look at a list which has dates of planned updates, just in case any of them will effect the stuff I'm working on for example. | 14:27 |
| matt-borland | yeah. I'm in the same boat as you in this regard. | 14:28 |
| *** jbell8 has joined #openstack-horizon | 14:28 | |
| matt-borland | There are some patches in play that are continuing to reorganize, let me see if there's a blueprint that details this. | 14:28 |
| matt-borland | the short answer is no, it doesn't look like there's an upgrade guide exactly. | 14:29 |
| *** vahidh has quit IRC | 14:30 | |
| neelabh | Hi guys, I am using devstack. On my dashboard three instance are running but In dashboard "stats tab" under Resource Usage is not showing anything. | 14:31 |
| neelabh | Please tell be how to show matrix | 14:31 |
| *** jingliuqing has joined #openstack-horizon | 14:32 | |
| neelabh | I have same problem : http://lists.openstack.org/pipermail/openstack/2014-April/006554.html | 14:32 |
| *** jingliuqing has quit IRC | 14:33 | |
| *** jbell8 has quit IRC | 14:33 | |
| *** garthb has joined #openstack-horizon | 14:38 | |
| *** garthb_ has joined #openstack-horizon | 14:38 | |
| *** JeanBriceCombebi has quit IRC | 14:43 | |
| *** neelabh has quit IRC | 14:45 | |
| *** vijendar has joined #openstack-horizon | 14:46 | |
| *** jbell8 has joined #openstack-horizon | 14:46 | |
| *** henrique_ has quit IRC | 14:48 | |
| *** htruta has joined #openstack-horizon | 14:48 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Improve unittests for angular charts https://review.openstack.org/179251 | 14:51 |
| *** radez is now known as radez_g0n3 | 14:54 | |
| *** jbell8 has quit IRC | 15:03 | |
| *** jcoufal has quit IRC | 15:04 | |
| mark-os | matt-borland: I can imagine these reorganisation patches could be a pain for those who have developed plugins for Horizon in the past but now have the old organisation instead? (E.g. AVOS) | 15:05 |
| matt-borland | exactly. | 15:05 |
| *** JeanBriceCombebi has joined #openstack-horizon | 15:06 | |
| *** e0ne is now known as e0ne_ | 15:09 | |
| *** e0ne_ is now known as e0ne | 15:09 | |
| *** notmars has joined #openstack-horizon | 15:12 | |
| *** jbell8 has joined #openstack-horizon | 15:14 | |
| *** hurgleburgler has joined #openstack-horizon | 15:14 | |
| *** bpokorny has joined #openstack-horizon | 15:15 | |
| *** JeanBriceCombebi has quit IRC | 15:15 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 15:17 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Adding tests for button-tooltip.js https://review.openstack.org/178434 | 15:17 |
| *** markus_z has quit IRC | 15:22 | |
| *** hurglebu_ has joined #openstack-horizon | 15:26 | |
| *** hurgleburgler has quit IRC | 15:27 | |
| *** neelabh has joined #openstack-horizon | 15:29 | |
| *** petertr7 is now known as petertr7_away | 15:31 | |
| *** cbader has quit IRC | 15:35 | |
| *** petertr7_away is now known as petertr7 | 15:36 | |
| *** hurglebu_ has quit IRC | 15:36 | |
| *** clu_ has joined #openstack-horizon | 15:39 | |
| *** clu_ has quit IRC | 15:41 | |
| *** openstackgerrit has quit IRC | 15:42 | |
| *** openstackgerrit has joined #openstack-horizon | 15:43 | |
| *** jprovazn has joined #openstack-horizon | 15:43 | |
| *** absubram has joined #openstack-horizon | 15:45 | |
| *** petertr7 is now known as petertr7_away | 15:45 | |
| *** neelabh has quit IRC | 15:46 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: [Launch Instance Fix] Add Flavor Step Unit Tests https://review.openstack.org/167326 | 15:49 |
| *** hurgleburgler has joined #openstack-horizon | 15:50 | |
| *** alexvictorchan has joined #openstack-horizon | 15:51 | |
| *** cbader has joined #openstack-horizon | 15:52 | |
| *** ongk has joined #openstack-horizon | 15:52 | |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: JSCS Cleanup - Legacy JS test files https://review.openstack.org/187301 | 15:52 |
| *** Drago has joined #openstack-horizon | 15:54 | |
| *** Drago has quit IRC | 15:54 | |
| *** Kunal has joined #openstack-horizon | 15:54 | |
| *** Drago has joined #openstack-horizon | 15:54 | |
| *** KunalGandhi has joined #openstack-horizon | 15:55 | |
| *** doug-fish has quit IRC | 15:56 | |
| *** doug-fish has joined #openstack-horizon | 15:57 | |
| *** ttrifonov is now known as zz_ttrifonov | 16:01 | |
| *** yamamoto has quit IRC | 16:02 | |
| *** notmars has quit IRC | 16:02 | |
| *** oro has joined #openstack-horizon | 16:05 | |
| *** amotoki_ has quit IRC | 16:05 | |
| *** jbell8 has quit IRC | 16:07 | |
| *** nlahouti has joined #openstack-horizon | 16:08 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Improving filter and existing API service tests https://review.openstack.org/176532 | 16:08 |
| *** yamamoto has joined #openstack-horizon | 16:10 | |
| *** gyee has joined #openstack-horizon | 16:10 | |
| *** belmoreira has quit IRC | 16:12 | |
| *** garthb has quit IRC | 16:12 | |
| *** garthb_ has quit IRC | 16:12 | |
| *** gokrokve_ has joined #openstack-horizon | 16:14 | |
| *** TravT has joined #openstack-horizon | 16:15 | |
| *** gokrokve has quit IRC | 16:17 | |
| *** JeanBriceCombebi has quit IRC | 16:18 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 16:21 | |
| *** mattfarina has joined #openstack-horizon | 16:22 | |
| *** Ala has quit IRC | 16:23 | |
| *** clu_ has joined #openstack-horizon | 16:25 | |
| *** clu_ has quit IRC | 16:26 | |
| *** clu_ has joined #openstack-horizon | 16:26 | |
| *** amotoki_ has joined #openstack-horizon | 16:29 | |
| *** e0ne has quit IRC | 16:29 | |
| *** ygbo has quit IRC | 16:31 | |
| *** cardeois____ has joined #openstack-horizon | 16:37 | |
| *** absubram has quit IRC | 16:38 | |
| *** absubram has joined #openstack-horizon | 16:38 | |
| ericpeterson | low-hanging-fruit bug : https://bugs.launchpad.net/horizon/+bug/1461158 | 16:39 |
| openstack | Launchpad bug 1461158 in OpenStack Dashboard (Horizon) "image table throws errrors into log files trying to display size attr" [Undecided,New] | 16:39 |
| *** lhcheng has joined #openstack-horizon | 16:39 | |
| *** jingjing_ren has joined #openstack-horizon | 16:40 | |
| *** cardeois___ has quit IRC | 16:41 | |
| *** DaveJ__ has quit IRC | 16:41 | |
| *** gokrokve_ has quit IRC | 16:43 | |
| *** gokrokve has joined #openstack-horizon | 16:43 | |
| *** dscottsf has joined #openstack-horizon | 16:44 | |
| *** gokrokve has quit IRC | 16:45 | |
| *** gokrokve_ has joined #openstack-horizon | 16:45 | |
| *** notmars has joined #openstack-horizon | 16:47 | |
| *** garthb has joined #openstack-horizon | 16:49 | |
| *** bluex-pl has quit IRC | 16:49 | |
| *** garthb_ has joined #openstack-horizon | 16:49 | |
| *** cardeois_____ has joined #openstack-horizon | 16:50 | |
| matt-borland | question for the room...it seems now that when I run "./run_tests.sh --only-selenium" I get failures on master. Yet it seems that on Jenkins the selenium tests pass. | 16:51 |
| *** pkarikh has quit IRC | 16:51 | |
| matt-borland | I have one patch which I know is a failure, and Jenkins thinks it's OK. | 16:51 |
| *** dscottsf has quit IRC | 16:52 | |
| *** cardeois____ has quit IRC | 16:53 | |
| matt-borland | False positives worry me. | 16:53 |
| matt-borland | david-lyle: know anything about this? ^^ | 16:54 |
| david-lyle | it's true, False positives worry you | 16:55 |
| david-lyle | :D | 16:55 |
| matt-borland | :) | 16:55 |
| david-lyle | no, but it's possible the error is not being tracked properly | 16:55 |
| david-lyle | does the detailed console log show anything on the jenkins job? | 16:56 |
| matt-borland | it looked somewhat brief | 16:56 |
| david-lyle | should show a log of what tests ran | 16:56 |
| matt-borland | but it does indicate successes. | 16:56 |
| david-lyle | if they are not being run, it could jump to immediate success | 16:57 |
| matt-borland | " WARNING:test command found but not installed in testenv" | 16:57 |
| matt-borland | It seems to have run all the tests in just a few seconds. | 16:58 |
| david-lyle | that seems wrong | 16:59 |
| david-lyle | those tests take a while | 16:59 |
| matt-borland | "Ran 1368 tests in 8.815s" | 16:59 |
| david-lyle | with new tox, less env vars are passed on into the test run | 16:59 |
| david-lyle | wonder if that's failing | 16:59 |
| matt-borland | ah, interesting. | 16:59 |
| david-lyle | your output would be for non-selenium runs | 17:00 |
| matt-borland | oh, ok. | 17:00 |
| *** jbell8 has joined #openstack-horizon | 17:00 | |
| david-lyle | hmm | 17:00 |
| matt-borland | It's just clear that master has bad selenium tests :( | 17:01 |
| david-lyle | looking at sample output, selenium is not running on the horizon-selenium test job | 17:02 |
| *** sjmc7 has joined #openstack-horizon | 17:02 | |
| david-lyle | that's sub-optimal | 17:02 |
| *** drupalmonkey has joined #openstack-horizon | 17:02 | |
| *** notmars has quit IRC | 17:04 | |
| *** dguerri is now known as dguerri`away | 17:04 | |
| *** KunalGandhi has quit IRC | 17:06 | |
| david-lyle | matt-borland: job invocation is correct "venv runtests: commands[0] | ../../../../bin/bash run_tests.sh -N --only-selenium" | 17:07 |
| david-lyle | something is getting lost in the execution | 17:07 |
| david-lyle | test not found is problematic too | 17:07 |
| matt-borland | yup | 17:08 |
| david-lyle | found fine in the py27 job | 17:08 |
| david-lyle | 124.598 secs for openstack_dashboard tests in py27 | 17:08 |
| david-lyle | 8.7776 in selenium | 17:09 |
| matt-borland | interesting | 17:09 |
| david-lyle | it's skipping all the non-selenium tests, but not running the selenium tests | 17:09 |
| david-lyle | OK (SKIP=1367) | 17:10 |
| *** JeanBriceCombebi has quit IRC | 17:10 | |
| *** alanf-mc has joined #openstack-horizon | 17:10 | |
| *** dsneddon has joined #openstack-horizon | 17:10 | |
| david-lyle | so we install dependencies into the venv and pass | 17:10 |
| *** Kunal has quit IRC | 17:10 | |
| david-lyle | tox | 17:10 |
| matt-borland | brb, have to eat lunch | 17:15 |
| *** sqchen has joined #openstack-horizon | 17:15 | |
| *** rushiagr_away is now known as rushiagr | 17:17 | |
| *** petertr7_away is now known as petertr7 | 17:21 | |
| *** hurgleburgler has quit IRC | 17:23 | |
| matt-borland | back | 17:26 |
| *** vijendar has quit IRC | 17:26 | |
| sqchen | tqtran: TravT: Are you guys around? | 17:27 |
| TravT | hi sqchen | 17:27 |
| sqchen | TravT: I’d like to know you guys’ idea about auto-focus, if we feel it is not that impoartant, I can abandon it. | 17:28 |
| sqchen | actually I don’t like it anymore, it take me too much time maintian the patch. | 17:28 |
| TravT | do you have the patch number? | 17:29 |
| sqchen | https://review.openstack.org/#/c/156785/ | 17:29 |
| *** jwy has joined #openstack-horizon | 17:31 | |
| doug-fish | sqchen: isn't autofocus needed so that newly opened dialogs have the cursor placed in them? | 17:32 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Angular API Unit Tests https://review.openstack.org/178227 | 17:32 |
| *** e0ne has joined #openstack-horizon | 17:32 | |
| TravT | sqchen: i think the patch is still good... i'm just looking through the various comments on it right now. | 17:33 |
| sqchen | doug-fish: right. | 17:33 |
| *** vijendar has joined #openstack-horizon | 17:33 | |
| doug-fish | that seems important to me | 17:33 |
| doug-fish | sqchen: are you trying to ensure you'll get reviews if you update it again? | 17:34 |
| doug-fish | I can commit to that | 17:34 |
| sqchen | TravT: after the code-reorg, it needs a manual rebase, I want to do it ONLY when it become a feathre we want to have. | 17:34 |
| *** ybathia has joined #openstack-horizon | 17:34 | |
| *** amotoki_ has quit IRC | 17:34 | |
| doug-fish | matt-borland: I've reviewed https://review.openstack.org/#/c/178227/ - the code looks good to me and works well, but one thing confuses me ... | 17:35 |
| matt-borland | yup, what's up? | 17:35 |
| doug-fish | I can't figure out why the tests succeed both before and after applying the patch, given changes that you've made in hz.api.cinder.js for example | 17:35 |
| doug-fish | does that mean I still don't know how to properly run the tests? | 17:35 |
| *** yamamoto has quit IRC | 17:36 | |
| matt-borland | Nope, they do run on both sides of the patch. | 17:36 |
| matt-borland | we are just adding a lot more tests and test cases...is that what you meant? | 17:36 |
| doug-fish | more tests I understand, but hz.api.cinder.js has a changed test | 17:36 |
| matt-borland | ok, just a sec. | 17:36 |
| matt-borland | let me look at that one. | 17:36 |
| doug-fish | I can't figure out how it succeeds both before and after -- sure, thanks | 17:36 |
| *** romainh1 has left #openstack-horizon | 17:37 | |
| matt-borland | in this case it "succeeds" before because it's untested. | 17:37 |
| matt-borland | thus nothing fails for cinder. | 17:37 |
| doug-fish | you mean the test doesn't run? | 17:37 |
| matt-borland | there is no test for cinder in master. | 17:38 |
| TravT | sqchen: i would propose that we get the tests in and re-org in and then your patch. So, maybe hold off on a rebase until that's done? | 17:38 |
| *** robcresswell has joined #openstack-horizon | 17:38 | |
| doug-fish | ooh - you've included a change to the code as well as the updated test? | 17:38 |
| matt-borland | yeah. Because otherwise I'd have to write a) broken tests, or b) a bad test. | 17:38 |
| matt-borland | it's a cart-and-horse thing :) | 17:39 |
| * doug-fish thinking | 17:39 | |
| *** josecastroleon has quit IRC | 17:39 | |
| matt-borland | If I left the code alone, I'd have to write a test that indicated bad language. | 17:39 |
| sqchen | TravT: sure no problems. the auto-focus has its unit tests and do not rely on the functional test though. | 17:39 |
| matt-borland | If I write a test with good language and bad code, the test would break. | 17:40 |
| matt-borland | it wouldn't be proper to write a test that is testing for bad data. | 17:40 |
| TravT | sqchen, just trying to reduce moving parts so we can get those tests / reorg in quickly. | 17:40 |
| matt-borland | so the lesser of two evils is to fix the code at the same time as applying the test. | 17:41 |
| doug-fish | matt-borland: oh yeah, that part makes sense. My concern is along the lines of code maintenance. You've fixed bad code in master. If that fix were needed in stable/kilo it would be impossible to cherry-pick back because its in a 1k patch. | 17:41 |
| *** yamamoto has joined #openstack-horizon | 17:41 | |
| doug-fish | well, it could be cherry-picked but the stable maintainers would never approve it | 17:41 |
| matt-borland | right. | 17:41 |
| doug-fish | I'm not sure it matters in this case | 17:41 |
| doug-fish | hence the "thinking" on my part | 17:41 |
| matt-borland | yep, it's a good point, and I had to ponder it a bit as well. | 17:41 |
| *** robcresswell has quit IRC | 17:42 | |
| *** robcresswell has joined #openstack-horizon | 17:42 | |
| sqchen | TravT: I don’t think auto-focus will block those functional tests, but sure, we can will until they are landed. | 17:42 |
| *** vahidh has joined #openstack-horizon | 17:45 | |
| doug-fish | matt-borland: I'm not sure I like your message changes (I'm still looking at the one in hz.api.cinder.js). The original message looks like a more usual style to me, though I'm not sure I'd call either wrong - what motivated you to correct/change messages as part of the test effort? | 17:45 |
| doug-fish | I'm wondering if we have some standard which would call the original version of the message wrong | 17:46 |
| matt-borland | good point. | 17:46 |
| matt-borland | I feel that the messages should be standard English as we are supplying them for translation. | 17:46 |
| *** neelabh has joined #openstack-horizon | 17:47 | |
| matt-borland | also, use of periods was all over the place. | 17:47 |
| matt-borland | I had to fix those. | 17:47 |
| matt-borland | I couldn't write tests that were inconsistent. | 17:47 |
| TravT | i see there actually are some real fixes. | 17:47 |
| TravT | line 233 | 17:47 |
| TravT | https://review.openstack.org/#/c/178227/43/horizon/static/horizon/js/angular/services/hz.api.keystone.js | 17:47 |
| robcresswell | Sorry for any noise, sorting out my ZNC setup | 17:48 |
| doug-fish | TravT: yeah, I think that's an easy one to accept | 17:48 |
| matt-borland | yep | 17:48 |
| matt-borland | Basically the phrasing was written inconsistently. | 17:48 |
| matt-borland | I applied consistency because the tests should enforce consistency. | 17:48 |
| matt-borland | hence, cart-and-horse | 17:49 |
| TravT | doug-fish... i'm wondering if the ship has sailed on a cherry pick anyway due to the code re-org efforts? | 17:49 |
| *** cardeois_____ has quit IRC | 17:49 | |
| doug-fish | TravT: yeah, that hasn't escaped my attention. | 17:50 |
| *** cardeois_____ has joined #openstack-horizon | 17:50 | |
| TravT | i had that concern on this patch as well: https://review.openstack.org/#/c/181095/ | 17:50 |
| TravT | i spoke with david-lyle and I think mrunge about it in Vancouver. if I recall correctly, they said that with a bit more effort you can do non-cherry pick changes. | 17:51 |
| doug-fish | looking forward we certainly need to get in the habit of writing smaller patches that fix specific issues to facilitate code maintenance and understandability | 17:51 |
| *** cardeois has joined #openstack-horizon | 17:52 | |
| matt-borland | the problem here is that we had a dearth of testing. I wasn't going to write 100 patches for testing. keeping 10 alive was hard enough. | 17:52 |
| matt-borland | if people write tests along side their code, this is not a problem. | 17:52 |
| *** e0ne is now known as e0ne_ | 17:52 | |
| doug-fish | agreed | 17:53 |
| matt-borland | doug-fish: I will certainly -1 any patch that doesn't add valid testing from here on :) | 17:53 |
| doug-fish | matt-borland: I appreciate that effort for all patches except ones that I write. ;-) | 17:53 |
| doug-fish | it's really the right thing to do | 17:54 |
| matt-borland | :) | 17:54 |
| *** cardeois_____ has quit IRC | 17:54 | |
| *** e0ne_ is now known as e0ne | 17:57 | |
| *** aix has quit IRC | 17:57 | |
| *** jingjing_ren has quit IRC | 18:00 | |
| *** radez_g0n3 is now known as radez | 18:02 | |
| *** Drago has quit IRC | 18:04 | |
| *** Drago has joined #openstack-horizon | 18:04 | |
| *** cardeois_ has joined #openstack-horizon | 18:05 | |
| *** KunalGandhi has joined #openstack-horizon | 18:05 | |
| *** cardeois has quit IRC | 18:08 | |
| *** openstackgerrit has quit IRC | 18:09 | |
| *** openstackgerrit has joined #openstack-horizon | 18:10 | |
| *** notmars has joined #openstack-horizon | 18:10 | |
| *** dguerri`away is now known as dguerri | 18:11 | |
| *** jprovazn has quit IRC | 18:12 | |
| *** tqtran has joined #openstack-horizon | 18:14 | |
| openstackgerrit | Kelly Domico proposed openstack/horizon: JSCS cleanup - Angular framework widgets (partial) https://review.openstack.org/187366 | 18:16 |
| openstackgerrit | Chad Roberts proposed openstack/horizon: Adding option for Spark jobs to use Swift paths https://review.openstack.org/187711 | 18:16 |
| *** notmars has quit IRC | 18:17 | |
| openstackgerrit | Chad Roberts proposed openstack/horizon: Adding option for Spark jobs to use Swift paths https://review.openstack.org/187711 | 18:23 |
| *** gokrokve_ has quit IRC | 18:23 | |
| *** jingjing_ren has joined #openstack-horizon | 18:24 | |
| *** thiagop has joined #openstack-horizon | 18:26 | |
| *** hurgleburgler has joined #openstack-horizon | 18:26 | |
| *** ybathia has quit IRC | 18:29 | |
| *** yamamoto has quit IRC | 18:30 | |
| *** ybathia has joined #openstack-horizon | 18:30 | |
| rhagarty | hello - can anyone point me to some documentation on creating a plug-in? I'm trying to add a new action for an existing volume table row. I can get the action to show up, but I can't get it to link to my new plug-in based form. | 18:30 |
| *** meagleso has joined #openstack-horizon | 18:31 | |
| *** jingjing_ren has quit IRC | 18:31 | |
| *** yamamoto has joined #openstack-horizon | 18:31 | |
| *** petertr7 is now known as petertr7_away | 18:33 | |
| *** amotoki_ has joined #openstack-horizon | 18:35 | |
| *** notmars has joined #openstack-horizon | 18:35 | |
| *** petertr7_away is now known as petertr7 | 18:37 | |
| *** ybathia has quit IRC | 18:37 | |
| *** hurglebu_ has joined #openstack-horizon | 18:37 | |
| *** hurglebu_ is now known as hurgleburlger | 18:37 | |
| *** mpavlase has quit IRC | 18:38 | |
| *** hurgleburgler has quit IRC | 18:38 | |
| *** hurgleburlger is now known as hurgleburgler | 18:38 | |
| *** amotoki_ has quit IRC | 18:40 | |
| *** sqchen has quit IRC | 18:40 | |
| *** gokrokve has joined #openstack-horizon | 18:42 | |
| *** elmiko has joined #openstack-horizon | 18:44 | |
| *** gokrokve has quit IRC | 18:44 | |
| elmiko | clu_: ping | 18:44 |
| *** gokrokve has joined #openstack-horizon | 18:44 | |
| *** Piet has joined #openstack-horizon | 18:44 | |
| *** sqchen has joined #openstack-horizon | 18:44 | |
| *** ongk has quit IRC | 18:45 | |
| *** ongk has joined #openstack-horizon | 18:46 | |
| *** yamamoto has quit IRC | 18:47 | |
| *** cardeois_ has quit IRC | 18:49 | |
| *** yamamoto has joined #openstack-horizon | 18:49 | |
| *** cardeois__ has joined #openstack-horizon | 18:49 | |
| *** kiran-r has joined #openstack-horizon | 18:50 | |
| *** ongk has quit IRC | 18:50 | |
| *** cardeois___ has joined #openstack-horizon | 18:50 | |
| *** cbader has quit IRC | 18:51 | |
| *** rhagarty_ has quit IRC | 18:51 | |
| *** cbader has joined #openstack-horizon | 18:51 | |
| *** rhagarty_ has joined #openstack-horizon | 18:51 | |
| *** rhagarty_ has quit IRC | 18:51 | |
| *** cbader has quit IRC | 18:51 | |
| *** rhagarty_ has joined #openstack-horizon | 18:52 | |
| *** cbader has joined #openstack-horizon | 18:52 | |
| *** alexpilotti has quit IRC | 18:52 | |
| matt-borland | doug-fish: with regards to the API Tests patch, was there anything other than the verbiage that presented a problem/questions? | 18:54 |
| *** cardeois__ has quit IRC | 18:54 | |
| tqtran | matt-borland: i discovered something accidentally today while testing | 18:55 |
| matt-borland | tqtran: what was that? | 18:55 |
| doug-fish | matt-borland: nope. I was just waiting for other issues noted to be addressed. | 18:55 |
| tqtran | if you enable a different language, most tests will fail | 18:55 |
| *** cbader has quit IRC | 18:55 | |
| tqtran | thats because in our specs, we are testing for pure english values | 18:55 |
| *** cbader has joined #openstack-horizon | 18:55 | |
| tqtran | not sure if that is an issue, are we assuming that testers have to all enable english before testing? | 18:56 |
| matt-borland | yeah. That is another reason for getting over to use the i18n pathc, for sure. To enforce a single lang for testing. | 18:56 |
| tqtran | doug-fish: what is the i18n norm here? | 18:56 |
| *** cbader has quit IRC | 18:56 | |
| *** openstackgerrit has quit IRC | 18:56 | |
| *** rhagarty has quit IRC | 18:56 | |
| matt-borland | tqtran: I know I put in a patch last year to get all selenium working in any language. | 18:56 |
| *** cbader has joined #openstack-horizon | 18:56 | |
| doug-fish | tqtran: I haven't seen any unit tests that address i18n | 18:56 |
| *** rhagarty has joined #openstack-horizon | 18:56 | |
| matt-borland | but that was done by not checking localized strings | 18:56 |
| *** rhagarty has quit IRC | 18:56 | |
| *** cbader has quit IRC | 18:56 | |
| *** openstackgerrit has joined #openstack-horizon | 18:56 | |
| doug-fish | cheater! | 18:56 |
| matt-borland | no, I mean by checking things *other* than localized strings. | 18:57 |
| *** rhagarty has joined #openstack-horizon | 18:57 | |
| *** cbader has joined #openstack-horizon | 18:57 | |
| tqtran | well, we are already including the django i18n in jasmine.html | 18:57 |
| *** cbader has quit IRC | 18:57 | |
| matt-borland | more valid tests, that is to say. Testing a list against itself is not a valid test. :) | 18:57 |
| *** rhagarty_ has quit IRC | 18:57 | |
| tqtran | so it should have access to it, plus you added that shim to karma | 18:57 |
| *** rhagarty has quit IRC | 18:57 | |
| matt-borland | tqtran: not quite. | 18:57 |
| tqtran | BUT...... the shim won't work properly | 18:57 |
| doug-fish | I'd love to see an automated, effective way to test for i18n issues, but I'm not sure that I've seen a model for that yet | 18:57 |
| *** cbader has joined #openstack-horizon | 18:58 | |
| tqtran | the spec runner will work though | 18:58 |
| *** rhagarty has joined #openstack-horizon | 18:58 | |
| matt-borland | exactly, the fundamental problem is you don't want the test to rely on the same translation mechanism. | 18:58 |
| tqtran | because its taking it from Django directly | 18:58 |
| *** rhagarty has quit IRC | 18:58 | |
| *** cbader has quit IRC | 18:58 | |
| *** rhagarty has joined #openstack-horizon | 18:58 | |
| *** cbader has joined #openstack-horizon | 18:58 | |
| tqtran | =/ guess im ok with it for now since its just test code. how do you feel about that doug-fish? | 18:59 |
| * doug-fish on the phone | 18:59 | |
| tqtran | oh.... ok | 18:59 |
| matt-borland | At the end of the day we can't actually write tests that mean anything string wise unless we focus on a single language. | 18:59 |
| matt-borland | the only other way is to have message labels, but django doesn't work that way either. | 18:59 |
| matt-borland | so essentiall "english" is the message label. | 18:59 |
| matt-borland | again, the solution in selenium is not the same as what we have here. | 19:00 |
| *** rushiagr is now known as rushiagr_away | 19:01 | |
| *** rhagarty has quit IRC | 19:01 | |
| *** rhagarty has joined #openstack-horizon | 19:01 | |
| *** jingjing_ren has joined #openstack-horizon | 19:01 | |
| *** rhagarty has quit IRC | 19:01 | |
| *** rhagarty has joined #openstack-horizon | 19:02 | |
| matt-borland | doug-fish: what other issues were noted that needed addressing in that API Test patch? I'm looking through the comments. | 19:02 |
| *** garthb_ has quit IRC | 19:03 | |
| *** garthb has quit IRC | 19:03 | |
| *** cbader has quit IRC | 19:03 | |
| *** garthb_ has joined #openstack-horizon | 19:03 | |
| *** garthb has joined #openstack-horizon | 19:03 | |
| *** cbader has joined #openstack-horizon | 19:03 | |
| doug-fish | matt-borland: last I looked there were comments from Tyr and Cindy that needed to be addressed | 19:03 |
| *** notmars has quit IRC | 19:03 | |
| * doug-fish still on the phone | 19:04 | |
| *** yamamoto has quit IRC | 19:04 | |
| matt-borland | np | 19:04 |
| *** garthb has quit IRC | 19:04 | |
| *** garthb_ has quit IRC | 19:04 | |
| *** rhagarty has quit IRC | 19:04 | |
| *** cbader has quit IRC | 19:04 | |
| * doug-fish needs to stop typing before mrs fish realizes she doesn't have my full attention | 19:04 | |
| tqtran | matt-borland: https://review.openstack.org/#/c/170554/ | 19:04 |
| tqtran | also commented on this test patch | 19:04 |
| *** cbader has joined #openstack-horizon | 19:04 | |
| *** rhagarty has joined #openstack-horizon | 19:04 | |
| matt-borland | cool! Thanks tqtran! | 19:05 |
| *** garthb has joined #openstack-horizon | 19:05 | |
| *** garthb_ has joined #openstack-horizon | 19:05 | |
| *** rhagarty has quit IRC | 19:05 | |
| *** cbader has quit IRC | 19:05 | |
| matt-borland | tqtran: good points on that patch...thanks again | 19:05 |
| *** garthb has quit IRC | 19:05 | |
| *** garthb_ has quit IRC | 19:05 | |
| *** cbader has joined #openstack-horizon | 19:06 | |
| *** rhagarty has joined #openstack-horizon | 19:06 | |
| *** garthb_ has joined #openstack-horizon | 19:06 | |
| *** garthb has joined #openstack-horizon | 19:06 | |
| *** jingjing_ren has quit IRC | 19:06 | |
| *** garthb has quit IRC | 19:06 | |
| *** yamamoto has joined #openstack-horizon | 19:07 | |
| *** garthb has joined #openstack-horizon | 19:07 | |
| *** rhagarty has quit IRC | 19:08 | |
| *** cardeois____ has joined #openstack-horizon | 19:08 | |
| *** rhagarty has joined #openstack-horizon | 19:08 | |
| *** cardeois___ has quit IRC | 19:09 | |
| *** cbader has quit IRC | 19:09 | |
| *** cbader has joined #openstack-horizon | 19:09 | |
| *** cardeois_____ has joined #openstack-horizon | 19:09 | |
| *** cbader has quit IRC | 19:10 | |
| *** garthb_ has quit IRC | 19:10 | |
| *** garthb has quit IRC | 19:10 | |
| *** petertr7 is now known as petertr7_away | 19:10 | |
| *** cbader has joined #openstack-horizon | 19:10 | |
| *** garthb has joined #openstack-horizon | 19:10 | |
| *** garthb_ has joined #openstack-horizon | 19:10 | |
| *** rhagarty has quit IRC | 19:11 | |
| *** rhagarty has joined #openstack-horizon | 19:11 | |
| *** cbader has quit IRC | 19:12 | |
| *** rhagarty has quit IRC | 19:12 | |
| *** petertr7_away is now known as petertr7 | 19:12 | |
| *** cbader has joined #openstack-horizon | 19:12 | |
| *** rhagarty has joined #openstack-horizon | 19:12 | |
| *** cardeois____ has quit IRC | 19:12 | |
| *** rhagarty has quit IRC | 19:13 | |
| *** yamamoto has quit IRC | 19:13 | |
| *** rhagarty has joined #openstack-horizon | 19:13 | |
| *** rhagarty has quit IRC | 19:14 | |
| *** cbader has quit IRC | 19:14 | |
| *** cbader has joined #openstack-horizon | 19:15 | |
| *** rhagarty has joined #openstack-horizon | 19:15 | |
| *** jingjing_ren has joined #openstack-horizon | 19:15 | |
| *** dmz has joined #openstack-horizon | 19:16 | |
| dmz | hey if i wanted to monitor for failed logons which logs should I look at (horizon only) | 19:16 |
| neelabh | Hi Guys, I just configure Ceilometer in OpenStack, But Ceilometer stats does not show, I have same problem like http://lists.openstack.org/pipermail/openstack/2014-April/006554.html, I have also asked question of stackOver flaw: http://stackoverflow.com/questions/30593874/i-have-been-activated-the-ceilometer-but-it-is-showing-any-statics-in-resource-u | 19:18 |
| doug-fish | tqtran: regarding i18n I don't think we want to impose that in general - but if we could come up with reasonable i18n automated tests that would be interesting | 19:19 |
| *** iamjarvo has joined #openstack-horizon | 19:19 | |
| tqtran | doug-fish: ok cool, thanks for the info | 19:19 |
| david-lyle | dmz: /var/log/apache2/horizon_error.log | 19:19 |
| dmz | hmm, let me go look; wasn't expecting it there with it auth through keystone | 19:19 |
| *** belmoreira has joined #openstack-horizon | 19:20 | |
| dmz | david-lyle cool, thanks! | 19:21 |
| *** gyee has quit IRC | 19:21 | |
| *** crobertsrh is now known as _crobertsrh | 19:22 | |
| dmz | :( too bad it doesn't say what IP the failure was from | 19:22 |
| * dmz goes to look at code | 19:22 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Angular API Unit Tests https://review.openstack.org/178227 | 19:22 |
| *** akrivoka has quit IRC | 19:23 | |
| dmz | hard to block brute force attacks w/out knowing source of attack :( | 19:23 |
| *** clu_ has quit IRC | 19:23 | |
| david-lyle | dmz, you can instrument the code in django_openstack_auth, to provide more info | 19:25 |
| lhcheng | dmz: I agree, I've created a custom logger for that one. | 19:26 |
| davidmichaelkarr | Hey, I'm trying to to set up a local horizon build so I can start investigating integrating Require.js into the test structure. I'm having some trouble with the initial env setup. | 19:26 |
| davidmichaelkarr | I'm using a CentOS vm. I cloned the repo, but there doesn't appear to be a "virtualenv" package. | 19:26 |
| dmz | lhcheng have you pushed your logger up so others can benifit from your hard work :) | 19:27 |
| davidmichaelkarr | I'm following the instructions on the QuickStart page: http://docs.openstack.org/developer/horizon/quickstart.html . | 19:28 |
| openstackgerrit | Kelly Domico proposed openstack/horizon: JSCS cleanup - Angular framework widgets (partial) https://review.openstack.org/187366 | 19:29 |
| davidmichaelkarr | The "run_tests.sh" script says "Please install 'python-virtualenv'", but the attempt to install that says "no package ...". | 19:29 |
| matt-borland | tqtran: Hey , I'm confused by your comments on https://review.openstack.org/#/c/170554/ | 19:29 |
| * dmz doesn't quite grok python yet :) need to figure out what's holding the web client ip address.. | 19:29 | |
| tqtran | hm? | 19:29 |
| doug-fish | davidmichaelkarr: I have to confess I'm very lazy with environment setup. I always run devstack first - which brings in all of the requirements needed for horizon. | 19:30 |
| lhcheng | dmz: nope, I've done it on my previous job. | 19:30 |
| matt-borland | With regards to the file structure, I'm following the code. If the modalContainerControl needs to be broken out, that's OK. But I'm just writing a test following the current code structure. | 19:30 |
| matt-borland | tqtran: should I break out the wizard code as per the reorg as part of this patch? | 19:30 |
| lhcheng | dmz: I don't have the code anymore. if you open a bug, maybe we can add it in horizon. | 19:30 |
| davidmichaelkarr | doug-fish: All I know is to follow the instructions. Are they not up to date? | 19:30 |
| dmz | i'm putting a quick hack in to test now | 19:31 |
| tqtran | matt-borland: no thats fine, just wanted to point that out | 19:31 |
| tqtran | matt-borland: just add the test for help-panel and you're gtg | 19:31 |
| matt-borland | tqtran: the second part is, I am not sure what you mean by help-panel | 19:31 |
| matt-borland | I don't think that is part of wizard.js | 19:32 |
| doug-fish | davidmichaelkarr: Not sure -- I don't follow those. If they aren't working I'd say submit a bug https://bugs.launchpad.net/horizon and in the meantime you are welcome to try my suggestion as a workaround | 19:32 |
| lhcheng | dmz: the tricky part is getting the IP if the request pass through the load balancer. Might be dependent on the LB hardware. | 19:32 |
| tqtran | matt-borland: https://github.com/openstack/horizon/blob/master/horizon/static/framework/widgets/wizard/wizard.html#L64 | 19:32 |
| *** notmars has joined #openstack-horizon | 19:32 | |
| tqtran | https://github.com/openstack/horizon/blob/master/horizon/static/framework/widgets/wizard/wizard.spec.js#L44 | 19:33 |
| tqtran | you're testing for steps, navs, but not help-panels | 19:33 |
| tqtran | if there are 3 steps, there should be 3 navs, and also 3 help panels right? | 19:33 |
| dmz | ah true but won't it have x_forwarded_for? | 19:34 |
| matt-borland | honestly, I didn't write this test | 19:34 |
| neelabh | Guys Plz help me on this,=> Ceilometer stats does not show, I have same problem like http://lists.openstack.org/pipermail/openstack/2014-April/006554.html plz help me on this.... | 19:34 |
| tqtran | understood, but its missing, so while we're at it, lets include | 19:34 |
| matt-borland | yeah, yeah, let me see | 19:34 |
| tqtran | :D | 19:34 |
| matt-borland | cool, I'll try to get that test in | 19:34 |
| matt-borland | :) | 19:34 |
| matt-borland | thanks for finding that! | 19:34 |
| tqtran | thanks matt-borland, sorry for being a pain | 19:34 |
| matt-borland | no, I want it all ironed out! | 19:34 |
| tqtran | :) | 19:35 |
| *** elmiko has left #openstack-horizon | 19:35 | |
| openstackgerrit | Merged openstack/horizon: The overview chart is so big and ugly while use `width: 100%` https://review.openstack.org/187169 | 19:38 |
| *** ongk has joined #openstack-horizon | 19:39 | |
| asahlin | ongk: clu: tgtran: For the JSCS cleanup... I am regretting setting the max line width to 80 char... | 19:40 |
| ongk | ha. me too | 19:40 |
| asahlin | ongk: clu: tgtran: I am wondering if we should reconsider.. To me it's making the code harder to read. Thoughts? | 19:41 |
| asahlin | tqtran: ^^^^^ sorry, through a 'g' in there | 19:42 |
| sqchen | if 80 is too small, maybe 100. but we don’t want it too big, do we? | 19:43 |
| asahlin | sqchen: correct, i was thinking 100 | 19:43 |
| asahlin | that was the john papa default length too. | 19:44 |
| *** nlahouti has quit IRC | 19:44 | |
| sqchen | Thanks asahlin, I use two culomns in Sublime, more than 100 makes it hard to show in each culomn. | 19:45 |
| *** sjmc7 has quit IRC | 19:47 | |
| *** kiran-r has quit IRC | 19:48 | |
| *** jtomasek has quit IRC | 19:48 | |
| ongk | asahlin, I think 100 would be fine and eliminate a lot of the errors we’re getting | 19:49 |
| *** hurgleburgler has quit IRC | 19:49 | |
| *** belmoreira has quit IRC | 19:49 | |
| *** mpavlase has joined #openstack-horizon | 19:51 | |
| asahlin | clu: tqtran: all in favor say 'aye' | 19:52 |
| dmz | cool, got it logging, not the best but it's a start; where should i file bug/feature request for openstack-auth? | 19:53 |
| *** TravT has quit IRC | 19:53 | |
| *** lucas___ has joined #openstack-horizon | 19:54 | |
| *** sjmc7 has joined #openstack-horizon | 19:54 | |
| *** alanf-mc has quit IRC | 19:54 | |
| *** TravT has joined #openstack-horizon | 19:55 | |
| tqtran | ok 100 is fine | 19:55 |
| pauloewerton | dmz, https://bugs.launchpad.net/django-openstack-auth/ | 19:56 |
| dmz | thanks | 19:56 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: [Launch Instance Fix] Clean up Wizard scope https://review.openstack.org/169976 | 19:59 |
| r1chardj0n3s | morning | 19:59 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Extending test coverage for core components https://review.openstack.org/170554 | 20:00 |
| *** neelabh has quit IRC | 20:02 | |
| matt-borland | tqtran: FYI I just put up a patchset for https://review.openstack.org/#/c/170554/ that includes a (very simple) test for help-panel. | 20:07 |
| matt-borland | ensures that it has one as an element | 20:07 |
| *** Raildo has joined #openstack-horizon | 20:08 | |
| *** openstackgerrit has quit IRC | 20:10 | |
| *** openstackgerrit has joined #openstack-horizon | 20:10 | |
| matt-borland | r1chardj0n3s: afternoon! | 20:13 |
| r1chardj0n3s | someone please wake me up when this other, random, unrelated, disconnected set of patches about testing land, kthx | 20:14 |
| *** iamjarvo has quit IRC | 20:14 | |
| *** jtomasek has joined #openstack-horizon | 20:19 | |
| *** cardeois_____ has quit IRC | 20:21 | |
| *** cardeois_____ has joined #openstack-horizon | 20:22 | |
| *** clu_ has joined #openstack-horizon | 20:22 | |
| *** clu_ has quit IRC | 20:24 | |
| *** amotoki_ has joined #openstack-horizon | 20:24 | |
| *** gary-smith has joined #openstack-horizon | 20:25 | |
| *** clu_ has joined #openstack-horizon | 20:27 | |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: JSCS cleanup - Angular framework widgets (partial2) https://review.openstack.org/187758 | 20:28 |
| *** amotoki_ has quit IRC | 20:29 | |
| *** alanf-mc has joined #openstack-horizon | 20:29 | |
| *** julim has quit IRC | 20:32 | |
| *** Raildo_ has joined #openstack-horizon | 20:35 | |
| *** operator99 is now known as gyee | 20:39 | |
| *** Raildo has quit IRC | 20:39 | |
| *** iamjarvo has joined #openstack-horizon | 20:42 | |
| *** ybathia has joined #openstack-horizon | 20:46 | |
| *** notmars has quit IRC | 20:50 | |
| *** gyee has quit IRC | 20:53 | |
| *** gyee has joined #openstack-horizon | 20:53 | |
| *** hurgleburgler has joined #openstack-horizon | 21:00 | |
| *** jwy has quit IRC | 21:01 | |
| *** petertr7 is now known as petertr7_away | 21:02 | |
| *** Raildo__ has joined #openstack-horizon | 21:03 | |
| *** jtriley has quit IRC | 21:05 | |
| *** Raildo_ has quit IRC | 21:08 | |
| dmz | pauloewerton not sure if it'll help or be deleted or what :) https://bugs.launchpad.net/django-openstack-auth/+bug/1461266 not even sure it's a bug but i didn't see a way to request a feature | 21:08 |
| openstack | Launchpad bug 1461266 in django-openstack-auth "Failed logon does not state where user is from (REMOTE_IP)" [Undecided,New] | 21:08 |
| *** ducttape_ has joined #openstack-horizon | 21:09 | |
| *** e0ne has quit IRC | 21:11 | |
| *** radez is now known as radez_g0n3 | 21:11 | |
| *** ericpeterson has quit IRC | 21:12 | |
| *** nlahouti has joined #openstack-horizon | 21:12 | |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: JSCS Cleanup - Legacy JS test files https://review.openstack.org/187301 | 21:13 |
| *** radez_g0n3 is now known as radez | 21:14 | |
| *** notmars has joined #openstack-horizon | 21:15 | |
| *** hurgleburgler has quit IRC | 21:16 | |
| *** hurgleburgler has joined #openstack-horizon | 21:18 | |
| *** lblanchard has quit IRC | 21:19 | |
| *** dboik has quit IRC | 21:21 | |
| *** hurgleburgler has quit IRC | 21:21 | |
| *** hurglebu_ has joined #openstack-horizon | 21:22 | |
| *** Raildo__ has quit IRC | 21:22 | |
| *** hurglebu_ has quit IRC | 21:22 | |
| *** cardeois______ has joined #openstack-horizon | 21:22 | |
| *** hurgleburgler has joined #openstack-horizon | 21:22 | |
| *** doug-fish has left #openstack-horizon | 21:25 | |
| *** iamjarvo has quit IRC | 21:25 | |
| *** cardeois_____ has quit IRC | 21:26 | |
| *** mattfarina has quit IRC | 21:28 | |
| *** hurgleburgler has quit IRC | 21:28 | |
| *** hurgleburgler has joined #openstack-horizon | 21:28 | |
| *** dsneddon has quit IRC | 21:29 | |
| *** jwy has joined #openstack-horizon | 21:30 | |
| *** hurgleburgler has quit IRC | 21:30 | |
| *** thiagop has quit IRC | 21:32 | |
| *** cardeois_______ has joined #openstack-horizon | 21:32 | |
| *** dsneddon has joined #openstack-horizon | 21:34 | |
| *** cardeois______ has quit IRC | 21:34 | |
| *** hurgleburgler has joined #openstack-horizon | 21:36 | |
| *** sqchen has quit IRC | 21:36 | |
| *** peristeri has quit IRC | 21:36 | |
| *** lucas___ has quit IRC | 21:37 | |
| *** matt-borland has quit IRC | 21:38 | |
| *** hurglebu_ has joined #openstack-horizon | 21:39 | |
| *** hurglebu_ has quit IRC | 21:39 | |
| *** hurgleburgler has quit IRC | 21:40 | |
| *** hurgleburgler has joined #openstack-horizon | 21:40 | |
| *** jbell8 has quit IRC | 21:40 | |
| *** jbell8 has joined #openstack-horizon | 21:41 | |
| bpokorny | Does anyone know if Horizon uses the Glance v2 API for anything currently? | 21:41 |
| bpokorny | Just looking at the logs, it looks like most calls to Glance go to the v1 API. | 21:42 |
| david-lyle | bpokorny: I don't think so | 21:42 |
| *** hurgleburgler has quit IRC | 21:42 | |
| david-lyle | there is a BP to add support | 21:42 |
| david-lyle | TravT might own it | 21:42 |
| *** hurgleburgler has joined #openstack-horizon | 21:42 | |
| david-lyle | he might be willing to let it go and provide compensation | 21:43 |
| TravT | hey bpokorny | 21:43 |
| TravT | if you want it, please take it | 21:43 |
| TravT | but to your question | 21:43 |
| TravT | we do use v2 for metadata definitions | 21:43 |
| david-lyle | ah, that would be true, wouldn't it | 21:43 |
| bpokorny | Cool, sounds good. Thanks, david-lyle and TravT. | 21:44 |
| TravT | so if you go to admin --> images / flavors / aggregates and do an update metadata on them, it will call the v2 API to get available definitions | 21:44 |
| TravT | if v2 isn't available, you'll have to freeform it | 21:44 |
| bpokorny | I see. Thanks, TravT. | 21:45 |
| *** jbell8 has quit IRC | 21:46 | |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: JSCS cleanup - Angular framework widgets (partial2) https://review.openstack.org/187758 | 21:47 |
| openstackgerrit | Brian Tully proposed openstack/horizon: WIP - Hide Quota/Usage table actions re Domains https://review.openstack.org/187783 | 21:50 |
| *** aix has joined #openstack-horizon | 21:50 | |
| *** jtomasek has quit IRC | 21:51 | |
| *** dguerri is now known as dguerri`away | 21:51 | |
| *** asahlin is now known as asahlin_afk | 21:53 | |
| *** hurgleburgler has quit IRC | 21:53 | |
| *** Raildo has joined #openstack-horizon | 21:53 | |
| *** ZZelle_ has joined #openstack-horizon | 21:55 | |
| *** notmars has quit IRC | 21:57 | |
| *** radez is now known as radez_g0n3 | 21:59 | |
| *** garthb_ has quit IRC | 21:59 | |
| *** garthb has quit IRC | 21:59 | |
| *** KunalGan_ has joined #openstack-horizon | 22:01 | |
| *** hurgleburgler has joined #openstack-horizon | 22:03 | |
| *** hurgleburgler has quit IRC | 22:03 | |
| *** KunalGan_ has quit IRC | 22:03 | |
| *** lhcheng has quit IRC | 22:04 | |
| *** KunalGan_ has joined #openstack-horizon | 22:04 | |
| *** KunalGandhi has quit IRC | 22:04 | |
| *** garthb has joined #openstack-horizon | 22:05 | |
| *** garthb_ has joined #openstack-horizon | 22:05 | |
| *** absubram has quit IRC | 22:07 | |
| *** lhcheng has joined #openstack-horizon | 22:08 | |
| openstackgerrit | Eric Peterson proposed openstack/horizon: Add fip to lbaas vip info https://review.openstack.org/180676 | 22:13 |
| *** ZZelle_ has quit IRC | 22:14 | |
| *** jingjing_ren has quit IRC | 22:15 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Adding John Papa style guide to JSCS https://review.openstack.org/185725 | 22:16 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS cleanup - Angular services https://review.openstack.org/186154 | 22:19 |
| openstackgerrit | Brian Tully proposed openstack/horizon: WIP - Hide Quota/Usage table actions re Domains https://review.openstack.org/187783 | 22:19 |
| *** tqtran_ has joined #openstack-horizon | 22:20 | |
| *** cardeois_______ has quit IRC | 22:20 | |
| *** vijendar has quit IRC | 22:20 | |
| *** cardeois_______ has joined #openstack-horizon | 22:20 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Bootstrap variables should derive from a known theme. https://review.openstack.org/187797 | 22:30 |
| *** hurgleburgler has joined #openstack-horizon | 22:33 | |
| *** Sukhdev has joined #openstack-horizon | 22:35 | |
| openstackgerrit | Merged openstack/horizon: Extending test coverage for core components https://review.openstack.org/170554 | 22:40 |
| tqtran | clu_: thanks for updating the rules | 22:41 |
| *** ducttape_ has quit IRC | 22:44 | |
| *** jingjing_ren has joined #openstack-horizon | 22:45 | |
| *** tosky_ has joined #openstack-horizon | 22:46 | |
| openstackgerrit | Kelly Domico proposed openstack/horizon: JSCS cleanup - Angular framework widgets (partial) https://review.openstack.org/187366 | 22:46 |
| openstackgerrit | Kelly Domico proposed openstack/horizon: JSCS cleanup - Angular framework widgets (partial) https://review.openstack.org/187366 | 22:47 |
| *** garthb_ has quit IRC | 22:48 | |
| *** garthb has quit IRC | 22:48 | |
| *** clu_ has quit IRC | 22:50 | |
| *** jingjing_ren has quit IRC | 22:52 | |
| *** tosky_ has quit IRC | 22:57 | |
| *** sqchen has joined #openstack-horizon | 22:59 | |
| *** kellyd has joined #openstack-horizon | 23:01 | |
| openstackgerrit | Kelly Domico proposed openstack/horizon: JSCS cleanup - Angular framework widgets (partial) https://review.openstack.org/187366 | 23:01 |
| *** tqtran_ has quit IRC | 23:02 | |
| *** ongk has quit IRC | 23:03 | |
| *** kellyd is now known as ongk | 23:03 | |
| *** ongk has quit IRC | 23:04 | |
| *** hurgleburgler has quit IRC | 23:12 | |
| *** stevemar has quit IRC | 23:12 | |
| *** hurglebu_ has joined #openstack-horizon | 23:12 | |
| *** garthb has joined #openstack-horizon | 23:12 | |
| *** garthb_ has joined #openstack-horizon | 23:12 | |
| *** stevemar has joined #openstack-horizon | 23:12 | |
| *** hurglebu_ has quit IRC | 23:17 | |
| *** hurgleburgler has joined #openstack-horizon | 23:18 | |
| *** hurgleburgler has quit IRC | 23:21 | |
| *** hurglebu_ has joined #openstack-horizon | 23:21 | |
| *** chlong has joined #openstack-horizon | 23:22 | |
| *** jingjing_ren has joined #openstack-horizon | 23:23 | |
| *** hurglebu_ is now known as hurgleburgler | 23:25 | |
| *** Drago has quit IRC | 23:25 | |
| *** mpavlase has quit IRC | 23:28 | |
| *** hurgleburgler has quit IRC | 23:32 | |
| *** hurgleburgler has joined #openstack-horizon | 23:33 | |
| *** lhcheng has quit IRC | 23:35 | |
| *** hurgleburgler has quit IRC | 23:38 | |
| *** clu_ has joined #openstack-horizon | 23:38 | |
| *** hurgleburgler has joined #openstack-horizon | 23:38 | |
| *** alexvictorchan has quit IRC | 23:40 | |
| *** hurgleburgler has quit IRC | 23:42 | |
| *** hurglebu_ has joined #openstack-horizon | 23:42 | |
| *** bradjones has quit IRC | 23:43 | |
| *** bradjones has joined #openstack-horizon | 23:45 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!