| openstackgerrit | Richard Jones proposed openstack/horizon: ngReorg - move utils from dashboad-app https://review.openstack.org/185140 | 00:07 |
|---|---|---|
| openstackgerrit | Richard Jones proposed openstack/horizon: ngReorg - move dashboard-app/login out https://review.openstack.org/185133 | 00:10 |
| openstackgerrit | Richard Jones proposed openstack/horizon: ngReorg - move dashboard controllers from horizon https://review.openstack.org/185132 | 00:12 |
| *** chlong has joined #openstack-horizon | 00:15 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: ngReorg - move dashboard-app to dashboard https://review.openstack.org/185191 | 00:15 |
| r1chardj0n3s | srsly, no-one is about eh? | 00:18 |
| r1chardj0n3s | oh well, off to the email | 00:18 |
| *** amotoki has joined #openstack-horizon | 00:26 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: ngReorg - move framework.util.form to validators https://review.openstack.org/185475 | 00:52 |
| *** yamamoto has quit IRC | 00:58 | |
| *** bpokorny has joined #openstack-horizon | 00:59 | |
| *** marzif has quit IRC | 01:00 | |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 01:01 | |
| *** ericksonsantos has quit IRC | 01:21 | |
| *** julim has joined #openstack-horizon | 01:21 | |
| *** julim has quit IRC | 01:21 | |
| *** petertr7 is now known as petertr7_away | 01:25 | |
| *** logan2 has joined #openstack-horizon | 01:25 | |
| *** ericksonsantos has joined #openstack-horizon | 01:31 | |
| *** dguerri`away has quit IRC | 01:41 | |
| *** dguerri`away has joined #openstack-horizon | 01:45 | |
| *** dguerri`away is now known as dguerri | 01:45 | |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 02:10 | |
| *** notmars has joined #openstack-horizon | 02:19 | |
| *** lhcheng has quit IRC | 02:19 | |
| *** notmars has quit IRC | 02:27 | |
| *** notmars has joined #openstack-horizon | 02:28 | |
| *** notmars has quit IRC | 02:37 | |
| *** yamamoto has joined #openstack-horizon | 02:39 | |
| *** Piet has joined #openstack-horizon | 03:00 | |
| *** darrenc is now known as darrenc_afk | 03:22 | |
| *** yingjun has joined #openstack-horizon | 03:23 | |
| *** jbell8 has joined #openstack-horizon | 03:27 | |
| *** neelabh has joined #openstack-horizon | 03:45 | |
| *** yingjun has quit IRC | 03:48 | |
| *** alexpilotti has joined #openstack-horizon | 04:06 | |
| *** bpokorny has quit IRC | 04:09 | |
| *** btully has joined #openstack-horizon | 04:15 | |
| *** absubram has joined #openstack-horizon | 04:25 | |
| *** dboik has joined #openstack-horizon | 04:27 | |
| *** absubram has quit IRC | 04:31 | |
| *** absubram has joined #openstack-horizon | 04:32 | |
| *** jbell8 has quit IRC | 04:33 | |
| *** alexpilotti has quit IRC | 04:41 | |
| *** darrenc_afk is now known as darrenc | 04:42 | |
| *** absubram has quit IRC | 04:45 | |
| *** absubram has joined #openstack-horizon | 04:46 | |
| *** User17 has joined #openstack-horizon | 04:52 | |
| *** absubram has quit IRC | 04:52 | |
| *** lhcheng has joined #openstack-horizon | 05:01 | |
| *** logan2 has quit IRC | 05:08 | |
| *** dboik has quit IRC | 05:14 | |
| *** dboik has joined #openstack-horizon | 05:14 | |
| *** petertr7_away is now known as petertr7 | 05:19 | |
| *** kiran-r has joined #openstack-horizon | 05:26 | |
| *** petertr7 is now known as petertr7_away | 05:28 | |
| *** dboik has quit IRC | 05:30 | |
| *** kiran-r has quit IRC | 05:33 | |
| *** kiran-r has joined #openstack-horizon | 05:35 | |
| *** lhcheng has quit IRC | 05:41 | |
| *** krykowski has joined #openstack-horizon | 05:43 | |
| *** lhcheng has joined #openstack-horizon | 05:45 | |
| *** lhcheng has quit IRC | 05:46 | |
| *** e0ne has joined #openstack-horizon | 05:46 | |
| *** lhcheng has joined #openstack-horizon | 05:46 | |
| *** kiran-r has quit IRC | 05:53 | |
| *** e0ne has quit IRC | 05:53 | |
| *** lhcheng has quit IRC | 06:07 | |
| *** mflobo has joined #openstack-horizon | 06:10 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/185506 | 06:20 |
| *** akrivoka has joined #openstack-horizon | 06:24 | |
| *** chlong has quit IRC | 06:30 | |
| *** fedexo has joined #openstack-horizon | 06:45 | |
| *** akrivoka has quit IRC | 06:46 | |
| *** ZZelle has quit IRC | 06:48 | |
| *** akrivoka has joined #openstack-horizon | 06:48 | |
| *** kiran-r has joined #openstack-horizon | 06:50 | |
| neelabh | I want to customize side_bar, like slide-out slide-in, looking for angularjs file for this.. | 06:56 |
| *** jtomasek has joined #openstack-horizon | 07:03 | |
| *** logan2 has joined #openstack-horizon | 07:06 | |
| *** petertr7_away is now known as petertr7 | 07:07 | |
| openstackgerrit | LIU Yulong proposed openstack/horizon: Add floating IP panel to admin dashboard https://review.openstack.org/143628 | 07:09 |
| *** cody-somerville has joined #openstack-horizon | 07:10 | |
| *** cody-somerville has quit IRC | 07:10 | |
| *** cody-somerville has joined #openstack-horizon | 07:10 | |
| *** akrivoka has quit IRC | 07:12 | |
| *** logan2 has quit IRC | 07:17 | |
| *** cody-somerville has quit IRC | 07:17 | |
| *** petertr7 is now known as petertr7_away | 07:17 | |
| *** krykowski has quit IRC | 07:25 | |
| *** Ala has joined #openstack-horizon | 07:29 | |
| *** btully has quit IRC | 07:29 | |
| neelabh | I am looking for AnguarJs for image which fetch the data from database. Please help me on this, give just name of file... | 07:29 |
| *** romainh has joined #openstack-horizon | 07:31 | |
| *** e0ne has joined #openstack-horizon | 07:39 | |
| *** e0ne is now known as e0ne_ | 07:40 | |
| *** akrivoka has joined #openstack-horizon | 07:44 | |
| *** markus_z has joined #openstack-horizon | 07:44 | |
| *** bfic has joined #openstack-horizon | 07:49 | |
| *** belmoreira has joined #openstack-horizon | 07:49 | |
| *** e0ne_ is now known as e0ne | 07:49 | |
| *** zz_ttrifonov is now known as ttrifonov | 07:52 | |
| *** xiaohui has joined #openstack-horizon | 07:53 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/185506 | 07:53 |
| *** ttrifonov is now known as zz_ttrifonov | 07:54 | |
| *** kjelly has joined #openstack-horizon | 07:56 | |
| *** akrivoka has quit IRC | 07:58 | |
| *** tosky has joined #openstack-horizon | 08:00 | |
| *** zz_ttrifonov is now known as ttrifonov | 08:01 | |
| neelabh | I want to customize side_bar, like slide-out slide-in, looking for angularjs file for this. | 08:08 |
| *** fedexo has quit IRC | 08:13 | |
| *** ygbo has joined #openstack-horizon | 08:16 | |
| *** ZZelle has joined #openstack-horizon | 08:27 | |
| *** Ala has quit IRC | 08:35 | |
| *** mpavlase has joined #openstack-horizon | 08:37 | |
| *** kiran-r has quit IRC | 08:39 | |
| *** kiran-r has joined #openstack-horizon | 08:39 | |
| *** fedexo has joined #openstack-horizon | 08:40 | |
| *** e0ne is now known as e0ne_ | 08:42 | |
| *** e0ne_ is now known as e0ne | 08:43 | |
| *** akrivoka has joined #openstack-horizon | 08:50 | |
| neelabh | I want to create one external angularJs file, could anybody tell directory of angularjs file... | 08:55 |
| *** petertr7_away is now known as petertr7 | 08:56 | |
| *** logan2 has joined #openstack-horizon | 09:02 | |
| *** sambetts has joined #openstack-horizon | 09:06 | |
| *** petertr7 is now known as petertr7_away | 09:06 | |
| *** aix has joined #openstack-horizon | 09:08 | |
| *** kjelly_ has joined #openstack-horizon | 09:14 | |
| *** fedexo has quit IRC | 09:15 | |
| jtomasek | hey, can anyone please help me with this: when I run ./run_tests.sh in tuskar-ui I get https://gist.github.com/jtomasek/312449d3211879e514b3 doing the same in horizon passes ok, although the failing dependencies are not tuskar-ui specific but come from horizon | 09:15 |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:16 | |
| *** kjelly_ has quit IRC | 09:17 | |
| *** kjelly_ has joined #openstack-horizon | 09:17 | |
| *** bluex-pl has joined #openstack-horizon | 09:27 | |
| *** bluex-pl has quit IRC | 09:27 | |
| *** bluex-pl has joined #openstack-horizon | 09:28 | |
| neelabh | I want to create one external angularJs file, could anybody tell directory of angularjs file. | 09:29 |
| kjelly | Does horizon support page function in 'admin/flavor' ? I created 40 flavors but horizon doesn't page it. | 09:29 |
| r1chardj0n3s | neelabh: the current sidebar is not angularjs | 09:31 |
| r1chardj0n3s | neelabh: the current angularjs code is in horizon/static or openstack_dashboard/static | 09:32 |
| neelabh | <r1chardj0n3s>: thanks for reply, Why same content in two separate directory.. | 09:33 |
| r1chardj0n3s | neelabh: historically "Horizon" has been split between a library/framework ("horizon") and the actual user interface ("openstack_dashboard") | 09:34 |
| r1chardj0n3s | with the intent being that openstack_dashboard is just a sample application, though in practise people just use it as their dashboard | 09:35 |
| neelabh | So in which directory should I add ex-anagulrjs file? | 09:35 |
| r1chardj0n3s | if it's entirely for your own purposes then openstack_dashboard would be fine | 09:35 |
| neelabh | k, | 09:36 |
| neelabh | I try to change some code of some file in angularjs in openstack_dashboard was not reflecting on dashboard. | 09:37 |
| r1chardj0n3s | make sure you force a full refresh of your browser (ctrl-shift-R or cmd-shift-R if on a mac) | 09:38 |
| r1chardj0n3s | that hotkey works in FF and Chrome, might work in others | 09:39 |
| neelabh | For testing purpose I just delete whole code of pie-chart.js but it still showing piechart, Yaa I am doing refresh browser, | 09:39 |
| r1chardj0n3s | the code might be compiled into a minified download. how are you launching django? | 09:40 |
| *** bluex-pl has quit IRC | 09:41 | |
| r1chardj0n3s | robcresswell_afk: thanks for the additional note on https://bugs.launchpad.net/horizon/+bug/1458697 | 09:41 |
| openstack | Launchpad bug 1458697 in OpenStack Dashboard (Horizon) "Horizon/Dashboard source reorganisation" [High,In progress] - Assigned to Richard Jones (r1chardj0n3s) | 09:41 |
| *** bluex-pl has joined #openstack-horizon | 09:41 | |
| *** bluex-pl has quit IRC | 09:42 | |
| *** bluex-pl has joined #openstack-horizon | 09:42 | |
| openstackgerrit | Bradley Jones proposed openstack/horizon: Refactor quota limit summary template https://review.openstack.org/170147 | 09:42 |
| neelabh | <r1chardj0n3s>: I am using vagrant virtual box in centos7, I run ./run_tests.sh --runserver 0.0.0.0:8080 then run rejoin-stack.sh | 09:43 |
| r1chardj0n3s | neelabh: you might need to restart your django (./run_tests.sh --runserver) before the change to the library is detected | 09:44 |
| neelabh | k, | 09:44 |
| neelabh | Let me try, I was thing just browser refresh will do the changes due to django | 09:45 |
| r1chardj0n3s | neelabh: in a perfect world, yes, it would | 09:46 |
| *** Ala has joined #openstack-horizon | 09:49 | |
| neelabh | <r1chardj0n3s>:On Project dashboard, there is panel name "Overview" This panel showing pie chart, Just for testing purpose I want to delete code of corresponding anagularJs file, I try to delete pie-chart.js in horizon/static directory, "But still it is showing", I followed your procedure but May be I have taken wrong Angularjs file, So could you tell me the correct angularjs file corresponding Project dashboad , overview panel | 09:52 |
| neelabh | Thanks | 09:53 |
| *** kjelly_ has left #openstack-horizon | 09:54 | |
| r1chardj0n3s | neelabh: the dashboards are in openstack_dashboard/dashboards/ and in this case in project/overview/ with the actual HTML in templates/ | 09:54 |
| r1chardj0n3s | neelabh: so the full path is openstack_dashboard/dashboards/project/overview/templates/overview/usage.html | 09:55 |
| neelabh | Where is angularjs file corresponing to this template.. | 09:55 |
| r1chardj0n3s | that view is not angularjs | 09:55 |
| neelabh | k | 09:56 |
| r1chardj0n3s | it's a straight django templated page | 09:56 |
| r1chardj0n3s | robcresswell_afk: if you have any thoughts on the post I wrote to [Horizon] today about the base.html move I'd appreciate it :) | 09:57 |
| neelabh | I want to just test some changes in angularjs on some template, there are lots of angaulJs and tempates. | 09:57 |
| r1chardj0n3s | neelabh: there are no dashboards implemented using angularjs at present | 09:58 |
| neelabh | but I thing kilo is using angularjs | 09:59 |
| r1chardj0n3s | the new Launch Instance wizard, which you have to enable, is implemented using it, yes | 09:59 |
| r1chardj0n3s | also the serial console (if available) uses it | 10:00 |
| *** Ala has quit IRC | 10:03 | |
| *** JeanBriceCombebi has quit IRC | 10:03 | |
| *** bluex-pl has quit IRC | 10:06 | |
| *** e0ne is now known as e0ne_ | 10:08 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 10:10 | |
| neelabh | thanks <r1chardj0n3s> | 10:12 |
| *** e0ne_ has quit IRC | 10:19 | |
| *** romainh has quit IRC | 10:23 | |
| *** e0ne has joined #openstack-horizon | 10:28 | |
| *** e0ne is now known as e0ne_ | 10:39 | |
| *** marzif has joined #openstack-horizon | 10:39 | |
| openstackgerrit | Bradley Jones proposed openstack/horizon: Refactor quota limit summary template https://review.openstack.org/170147 | 10:40 |
| *** petertr7_away is now known as petertr7 | 10:45 | |
| neelabh | There is are two directory where angularjs is defined | 10:48 |
| neelabh | dir-1: stack/horizon/horizon/angular/ | 10:48 |
| neelabh | dir-2. stack/horizon/static/angular/ which contents the same code, | 10:48 |
| neelabh | As suggested by "r1chardj0n3s" "Horizon" has been split between a library/framework ("horizon") and the actual user interface ("openstack_dashboard"), | 10:48 |
| neelabh | For library/framework ("horizon") and ("openstack_dashboard") what is the correct directories, dir-1 or dir-2. | 10:48 |
| neelabh | Could anybody help me on this.. | 10:49 |
| *** e0ne_ has quit IRC | 10:49 | |
| *** petertr7 is now known as petertr7_away | 10:55 | |
| *** bluex-pl has joined #openstack-horizon | 11:01 | |
| *** bluex-pl has quit IRC | 11:02 | |
| *** bluex-pl has joined #openstack-horizon | 11:02 | |
| openstackgerrit | Merged openstack/horizon: Check delay and timeout when editing monitor https://review.openstack.org/176237 | 11:13 |
| *** aix has quit IRC | 11:14 | |
| *** kiranr has joined #openstack-horizon | 11:15 | |
| *** aix has joined #openstack-horizon | 11:15 | |
| *** kiran-r has quit IRC | 11:16 | |
| *** kiranr is now known as kiran-r | 11:19 | |
| *** crobertsrh has joined #openstack-horizon | 11:19 | |
| pkarikh | Hi all! Does anyone know when we are going to fix failing gate-horizon-dsvm-integration? | 11:22 |
| *** JeanBriceCombebi has quit IRC | 11:34 | |
| openstackgerrit | Akihiro Motoki proposed openstack/django_openstack_auth: Use graduated version of oslo.policy https://review.openstack.org/164420 | 11:42 |
| *** ctina__ has joined #openstack-horizon | 11:43 | |
| *** yamamoto has quit IRC | 11:50 | |
| openstackgerrit | Merged openstack/horizon: Empty cell should obey sorting order https://review.openstack.org/165518 | 11:52 |
| openstackgerrit | Merged openstack/horizon: Made HorizonComponent class Python3 compatible https://review.openstack.org/183367 | 11:52 |
| mpavlase | Hi folks, we have several patches on review with several +1 but nobody from core-reviewers doesn't pay attention to move them forward :-( Can you please take a look for them please? Filter is here: https://review.openstack.org/#/q/project:openstack/horizon+file:%255E.*/integration_tests/.*+status:open,n,z | 11:59 |
| *** e0ne has joined #openstack-horizon | 12:00 | |
| neelabh | Hi Guys, How we are using angularJs for overview panel of project dashboard in openstack-kilo? Please help me on this.. | 12:01 |
| openstackgerrit | Merged openstack/horizon: Added a validation to the Keypair creation form https://review.openstack.org/183117 | 12:04 |
| *** romainh has joined #openstack-horizon | 12:06 | |
| *** ducttape_ has joined #openstack-horizon | 12:09 | |
| *** dguerri is now known as dguerri`away | 12:10 | |
| *** yamamoto has joined #openstack-horizon | 12:12 | |
| *** logan2 has quit IRC | 12:12 | |
| *** doug-fish has joined #openstack-horizon | 12:15 | |
| *** ekarlso has quit IRC | 12:16 | |
| *** ekarlso has joined #openstack-horizon | 12:16 | |
| *** alla__ has joined #openstack-horizon | 12:18 | |
| neelabh | Hi Guys, How we are using angularJs for overview panel of project dashboard in openstack-kilo? Please help me on this.. | 12:29 |
| *** htruta has joined #openstack-horizon | 12:31 | |
| *** petertr7_away is now known as petertr7 | 12:34 | |
| pauloewerton | neelabh, AngularJS is not being used in this panel nor in any dashboard yet | 12:34 |
| pauloewerton | neelabh, there's the new launch instance wizard, though | 12:35 |
| *** ducttape_ has quit IRC | 12:35 | |
| pauloewerton | doug-fish, hi | 12:35 |
| pauloewerton | doug-fish, besides that k2k auth plugin dependency, is there any issues that should be addressed for horizon to support k2k federation? | 12:36 |
| neelabh | <pauloewerton>, thanks, could you tell me where we are using angularJS? | 12:36 |
| pauloewerton | neelabh, as I told you only in launch instance wizard. please see https://github.com/openstack/horizon/tree/master/openstack_dashboard/static/dashboard/launch-instance | 12:37 |
| *** btully has joined #openstack-horizon | 12:39 | |
| neelabh | Thanks,I will be great help, Could you tell me what is use of of launch instance wizard and its usages.. | 12:39 |
| *** petertr7 is now known as petertr7_away | 12:43 | |
| openstackgerrit | Andrey Pavlov proposed openstack/horizon: [Sahara] Added volume type and instance locality support https://review.openstack.org/172416 | 12:44 |
| *** btully has quit IRC | 12:44 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 12:47 | |
| *** btully has joined #openstack-horizon | 12:49 | |
| openstackgerrit | Merged openstack/horizon: Network Step uses controller-as syntax https://review.openstack.org/183102 | 12:49 |
| *** dguerri`away is now known as dguerri | 12:50 | |
| akrivoka | hey horizon, can I humbly ask a core to take a look at this patch? I need a final +A: https://review.openstack.org/#/c/179833/ | 12:51 |
| *** btully has quit IRC | 12:53 | |
| openstackgerrit | Jiri Tomasek proposed openstack/tuskar-ui: Synced run_tests.sh with horizon, requirements cleanup https://review.openstack.org/185583 | 12:55 |
| pauloewerton | neelabh, the launch instance wizard is a form basically used to start a new virtual machine in openstack. see http://docs.openstack.org/user-guide/dashboard_launch_instances.html | 12:56 |
| neelabh | <pauloewerton>: Thanks... | 12:57 |
| *** sseago has quit IRC | 13:02 | |
| *** sseago has joined #openstack-horizon | 13:02 | |
| doug-fish | pauloewerton: regarding k2k, the auth plugin is the only dependency to get the patch running that I proposed -- there are still a few issues that need to be addressed in the django_openstack_auth code itself - off the top of my head I know cleanup/logout needs to be addressed as well as handling duplicate region names defined in different keystone catalogs. | 13:04 |
| *** JeanBriceCombebi has quit IRC | 13:10 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:10 | |
| *** e0ne is now known as e0ne_ | 13:10 | |
| *** alla__ has quit IRC | 13:12 | |
| *** julim has joined #openstack-horizon | 13:12 | |
| *** rushiagr_away is now known as rushiagr | 13:13 | |
| *** stevemar has joined #openstack-horizon | 13:14 | |
| *** peristeri has joined #openstack-horizon | 13:15 | |
| *** alla__ has joined #openstack-horizon | 13:16 | |
| *** e0ne_ has quit IRC | 13:21 | |
| *** logan2 has joined #openstack-horizon | 13:21 | |
| *** sseago has quit IRC | 13:22 | |
| openstackgerrit | WonChon proposed openstack/horizon: Support flavor-id uuid format at trove. https://review.openstack.org/181657 | 13:25 |
| *** e0ne has joined #openstack-horizon | 13:26 | |
| *** bfic has quit IRC | 13:32 | |
| *** Ephur has joined #openstack-horizon | 13:35 | |
| *** sseago has joined #openstack-horizon | 13:35 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Add New UX CSS for Upcoming Detail Screens https://review.openstack.org/158881 | 13:36 |
| *** mwhagedorn has quit IRC | 13:37 | |
| *** jtriley has joined #openstack-horizon | 13:37 | |
| *** mwhagedorn has joined #openstack-horizon | 13:37 | |
| openstackgerrit | Jiri Tomasek proposed openstack/tuskar-ui: Synced run_tests.sh with horizon, requirements cleanup https://review.openstack.org/185583 | 13:40 |
| *** Ephur has quit IRC | 13:40 | |
| *** matt-borland has joined #openstack-horizon | 13:41 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Get unit tests working with Karma https://review.openstack.org/168152 | 13:44 |
| *** btully has joined #openstack-horizon | 13:45 | |
| openstackgerrit | Merged openstack/manila-ui: Show test names and results instead of "." and "S" https://review.openstack.org/185356 | 13:46 |
| *** drupalmonkey has joined #openstack-horizon | 13:47 | |
| *** kiran-r has quit IRC | 13:49 | |
| *** cardeois has joined #openstack-horizon | 13:53 | |
| *** akrivoka has quit IRC | 13:53 | |
| *** cardeois has joined #openstack-horizon | 13:53 | |
| *** logan2 has quit IRC | 13:54 | |
| *** lblanchard has joined #openstack-horizon | 13:56 | |
| *** radez_g0n3 is now known as radez | 14:01 | |
| *** jprovazn has joined #openstack-horizon | 14:01 | |
| *** ducttape_ has joined #openstack-horizon | 14:02 | |
| krotscheck | General FYI: Today's X-Project meeting has CORS support on the agenda. Time is 2100UTC, 1400PCT | 14:02 |
| *** Piet has quit IRC | 14:03 | |
| iurygregory | hi doug-fish, i have a question about how you use the concept of regions in K2K Federation. | 14:04 |
| iurygregory | Apparently in your code you handle Service Providers as regions. But in kilo this have change to a Service Provider Object (http://rodrigods.com/it-is-time-to-play-with-keystone-to-keystone-federation-in-kilo/), will your code reflect this change in future patches? https://review.openstack.org/#/c/159910/10/openstack_auth/views.py | 14:04 |
| doug-fish | iurygregory: sure, let's see if I have an answer! | 14:05 |
| doug-fish | (reading the actual question now) | 14:05 |
| * stevemar waits to see the answer | 14:07 | |
| doug-fish | It's not exactly accurate to say that my code handles Service Providers as Regions - it should be possible with my code for each Service Provider to provide several Regions and Horizon will show each Region as an option in it's drop down ... | 14:10 |
| * doug-fish goes off to read Rodrigo's artcile | 14:10 | |
| *** mattfarina has joined #openstack-horizon | 14:10 | |
| doug-fish | _now_ I understand the question! | 14:11 |
| doug-fish | yes - that's something I'll need to account for before my d_o_a patch is "ripe" | 14:11 |
| *** gokrokve has joined #openstack-horizon | 14:15 | |
| *** JeanBriceCombebi has quit IRC | 14:15 | |
| iurygregory | doug-fish, thanks =) | 14:16 |
| pauloewerton | doug-fish, thank you. I will investigate and see if I can come up with something to address these issues | 14:18 |
| *** JeanBriceCombebi has joined #openstack-horizon | 14:18 | |
| doug-fish | pauloewerton: not sure if you were following my other discussion thread, but that patch will need updates to how it finds the SP Keystones as well. | 14:19 |
| *** rushiagr is now known as rushiagr_away | 14:19 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Get unit tests working with Karma https://review.openstack.org/168152 | 14:20 |
| *** nlahouti has joined #openstack-horizon | 14:20 | |
| *** nlahouti has quit IRC | 14:20 | |
| pauloewerton | doug-fish, Sure. I am going to wait then until the patch is updated | 14:21 |
| doug-fish | sounds good | 14:21 |
| *** petertr7_away is now known as petertr7 | 14:23 | |
| *** notmars has joined #openstack-horizon | 14:25 | |
| *** davidmichaelkarr has joined #openstack-horizon | 14:27 | |
| *** akrivoka has joined #openstack-horizon | 14:29 | |
| *** petertr7 is now known as petertr7_away | 14:32 | |
| openstackgerrit | WonChon proposed openstack/horizon: Support flavor-id uuid format at trove. https://review.openstack.org/181657 | 14:33 |
| *** JeanBriceCombebi has quit IRC | 14:33 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Detail-page directives (Angular/UX) https://review.openstack.org/173359 | 14:34 |
| *** TravT has joined #openstack-horizon | 14:35 | |
| openstackgerrit | Ryan Peters proposed openstack/horizon: ngReorg - Move API files to openstack_dashboard https://review.openstack.org/184543 | 14:38 |
| *** ducttape_ has quit IRC | 14:38 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 14:39 | |
| neelabh | I want to add external angularjs for base.html(stack/horizon/horizon/template/base.html). For this I made folder "dashboard" inside stack/horizon/static/angular/. And defined file dashboard.js. and include this in widget.module.js file inside stack/horizon/static/angular like "'hz.dashboard'," It is giving error, could you tell me why it is happing, | 14:40 |
| *** e0ne is now known as e0ne_ | 14:41 | |
| *** e0ne_ has quit IRC | 14:41 | |
| *** vijendar has joined #openstack-horizon | 14:43 | |
| *** ducttape_ has joined #openstack-horizon | 14:43 | |
| *** dguerri is now known as dguerri`away | 14:44 | |
| *** cody-somerville has joined #openstack-horizon | 14:45 | |
| *** cody-somerville has quit IRC | 14:45 | |
| *** cody-somerville has joined #openstack-horizon | 14:45 | |
| *** Ephur has joined #openstack-horizon | 14:49 | |
| *** notmars has quit IRC | 14:51 | |
| *** e0ne has joined #openstack-horizon | 14:58 | |
| *** neelabh has quit IRC | 14:59 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Add New UX CSS for Upcoming Detail Screens https://review.openstack.org/158881 | 15:01 |
| *** JeanBriceCombebi has quit IRC | 15:03 | |
| *** katyafervent_ is now known as katyafervent_awa | 15:03 | |
| *** kiran-r has joined #openstack-horizon | 15:09 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 15:11 | |
| *** mattfarina has quit IRC | 15:13 | |
| *** alejandrito has joined #openstack-horizon | 15:14 | |
| *** alla__ has quit IRC | 15:15 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Detail-page directives (Angular/UX) https://review.openstack.org/173359 | 15:16 |
| *** ttrifonov is now known as zz_ttrifonov | 15:17 | |
| *** rward has joined #openstack-horizon | 15:17 | |
| *** TravT has quit IRC | 15:19 | |
| *** vahidh has joined #openstack-horizon | 15:19 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 15:20 |
| *** petertr7_away is now known as petertr7 | 15:23 | |
| *** bpokorny has joined #openstack-horizon | 15:25 | |
| *** TravT has joined #openstack-horizon | 15:26 | |
| *** rhagarty has joined #openstack-horizon | 15:30 | |
| *** rhagarty_ has joined #openstack-horizon | 15:30 | |
| *** katyafervent_awa is now known as katyafervent | 15:30 | |
| *** dsneddon has joined #openstack-horizon | 15:32 | |
| *** lhcheng has joined #openstack-horizon | 15:32 | |
| *** mattfarina has joined #openstack-horizon | 15:33 | |
| *** petertr7 is now known as petertr7_away | 15:33 | |
| *** hurgleburgler2 has joined #openstack-horizon | 15:34 | |
| *** mattfarina has quit IRC | 15:36 | |
| *** mattfarina has joined #openstack-horizon | 15:37 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Detail-page directives (Angular/UX) https://review.openstack.org/173359 | 15:37 |
| *** lhcheng has quit IRC | 15:37 | |
| *** gyee has joined #openstack-horizon | 15:42 | |
| *** yamamoto has quit IRC | 15:42 | |
| *** e0ne is now known as e0ne_ | 15:43 | |
| *** mriedem has joined #openstack-horizon | 15:43 | |
| mriedem | so....was the jshint job running and voting when the master branch was kilo? https://review.openstack.org/#/c/185172/ | 15:44 |
| mriedem | i'm trying to figure out why this is just now failing on stable/kilo: http://logs.openstack.org/56/183656/1/check/gate-horizon-jshint/cd75430/console.html.gz#_2015-05-15_19_27_08_073 | 15:44 |
| *** kiran-r has quit IRC | 15:44 | |
| *** kiranr has joined #openstack-horizon | 15:44 | |
| mriedem | i don't want to backport https://review.openstack.org/#/c/184865/ to stable/kilo b/c it's huge | 15:44 |
| *** nlahouti has joined #openstack-horizon | 15:44 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 15:44 |
| *** tosky has quit IRC | 15:45 | |
| *** tosky has joined #openstack-horizon | 15:45 | |
| *** kiranr is now known as kiran-r | 15:45 | |
| doug-fish | mriedem: I'm looking back now - I became aware of this issue working on https://review.openstack.org/#/c/183321/ ... I see jshint was successful May 14 .... it didn't run on one May 15 version of that patch, then failed later with the jshint issue | 15:46 |
| *** e0ne_ is now known as e0ne | 15:46 | |
| mriedem | was there a new version? | 15:47 |
| doug-fish | not to my knowledge. But sometimes things happen I don't know about. | 15:47 |
| * doug-fish waits to hear any confessions | 15:47 | |
| mriedem | jshint was 2.7.0 when it was passing: http://logs.openstack.org/21/183321/1/check/gate-horizon-jshint/90ca4dd/console.html.gz#_2015-05-14_22_50_02_203 | 15:47 |
| mriedem | same when it's failing http://logs.openstack.org/56/183656/1/check/gate-horizon-jshint/cd75430/console.html.gz#_2015-05-15_19_27_07_266 | 15:48 |
| mriedem | nothing changed in horizon on stable/kilo between 5/14 and 5/15: https://github.com/openstack/horizon/commits/stable/kilo | 15:49 |
| mriedem | so i'm guessing a library updated happened externally | 15:49 |
| mriedem | just need to figure out what | 15:49 |
| mriedem | i'll check that | 15:49 |
| doug-fish | thx - I'm completely baffled. If it's not jshint I can't guess what it would be. | 15:49 |
| *** JeanBriceCombebi has quit IRC | 15:51 | |
| *** bluex-pl has quit IRC | 15:52 | |
| mriedem | <Released django-openstack-auth 1.3.1 2015-05-14 16:20:18> | 15:52 |
| mriedem | that is capped on stable/kilo though so not the issue | 15:53 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 15:56 |
| *** iamjarvo has joined #openstack-horizon | 15:58 | |
| mriedem | doug-fish: the only difference i see is when it was working, tox was 1.9.2 and when it's failing tox is 2.0.1 | 15:58 |
| doug-fish | mriedem: I notice different data in the section 2015-05-15 19:27:14.534 | Begin pbr freeze output from test virtualenv: like 2015-05-15 19:27:14.592 | colorama==0.3.3 vs | 15:58 |
| doug-fish | 2015-05-14 22:50:09.361 | colorama==0.3.3 # git sha baf55ce | 15:58 |
| mriedem | tox > 2 blew up some other projects before too | 15:58 |
| mriedem | doug-fish: i think it's something with tox 2.0 not picking up the env stuff | 15:59 |
| doug-fish | I see | 15:59 |
| mriedem | which is why bknudon's change is explicitly calling out .jshintrc | 15:59 |
| *** belmoreira has quit IRC | 15:59 | |
| *** juggler has quit IRC | 15:59 | |
| *** ygbo has quit IRC | 16:00 | |
| *** juggler has joined #openstack-horizon | 16:00 | |
| doug-fish | I'll look again at bknudson's patch | 16:01 |
| *** Drago has joined #openstack-horizon | 16:02 | |
| doug-fish | I'm still baffled why this isn't needed on master | 16:02 |
| *** Drago has quit IRC | 16:02 | |
| *** rwsu has joined #openstack-horizon | 16:02 | |
| *** Drago has joined #openstack-horizon | 16:02 | |
| *** e0ne is now known as e0ne_ | 16:04 | |
| *** alexvictorchan has joined #openstack-horizon | 16:04 | |
| mriedem | opened a bug https://bugs.launchpad.net/horizon/+bug/1458928 | 16:04 |
| openstack | Launchpad bug 1458928 in OpenStack Dashboard (Horizon) "jshint failing on angular js in stable/kilo" [Undecided,New] | 16:04 |
| *** tqtran has joined #openstack-horizon | 16:04 | |
| mriedem | doug-fish: my guess is, it's not an issue on master b/c https://review.openstack.org/#/c/171321/ is on master | 16:04 |
| doug-fish | TravT, r1chardj0n3s any thoughts on the bug ^ I can't guess why this setting is needed | 16:05 |
| doug-fish | mriedem: yeah, that's plausible. | 16:05 |
| *** e0ne_ is now known as e0ne | 16:06 | |
| tqtran | doug-fish: what setting? | 16:06 |
| mriedem | tqtran: see https://bugs.launchpad.net/horizon/+bug/1458928 | 16:06 |
| openstack | Launchpad bug 1458928 in OpenStack Dashboard (Horizon) "jshint failing on angular js in stable/kilo" [Undecided,Confirmed] | 16:06 |
| mriedem | .jshintrc appears to not be getting picked up on stable/kilo after tox 2.0 | 16:06 |
| *** daudet has joined #openstack-horizon | 16:07 | |
| doug-fish | tqtran: here's a more focus fix that's proposed for the problem https://review.openstack.org/#/c/185172/ | 16:07 |
| doug-fish | I just can't figure out why this is needed only for stable/kilo and not master. Master doesn't need the config file? | 16:07 |
| tqtran | right, that was the strange part to me as well | 16:08 |
| tqtran | i dont think its a jshint bug though | 16:08 |
| *** petertr7_away is now known as petertr7 | 16:09 | |
| doug-fish | this is related to https://review.openstack.org/#/c/171321/ which we were discussing Friday | 16:09 |
| doug-fish | tqtran: mriedem has rightly pointed out that https://review.openstack.org/#/c/171321/ is giant which makes it unsuitable for adding to a stable release | 16:09 |
| tqtran | https://bugs.launchpad.net/grenade/+bug/1456835 | 16:10 |
| openstack | Launchpad bug 1456835 in OpenStack-Gate "check-grenade-dsvm fails with [ERROR] /opt/stack/new/grenade/inc/plugin:Failed to die /opt/stack/new/devstack/functions-common" [Undecided,In progress] - Assigned to Matt Riedemann (mriedem) | 16:10 |
| *** alexpilotti has joined #openstack-horizon | 16:10 | |
| mriedem | does jshint rely on environment variables? | 16:10 |
| tqtran | doug-fish: ok i'll take it down then | 16:11 |
| tqtran | mriedem: not sure, let me see how we're running it in run_tests | 16:11 |
| *** ctina__ has quit IRC | 16:12 | |
| tqtran | https://github.com/openstack/horizon/blob/master/run_tests.sh#L159 | 16:13 |
| doug-fish | I don't think jshint relies on environment variables. I like the hypothesis that it's not needed in master because https://review.openstack.org/#/c/171321/ is on master. Part of that change included removing some inline jshint related declarations. | 16:13 |
| *** clu has joined #openstack-horizon | 16:13 | |
| tqtran | looks like we hard coded the path | 16:13 |
| *** mpavlase has quit IRC | 16:13 | |
| tqtran | doug-fish: right, but thats exactly what i patched, and it still failed | 16:14 |
| ducttape_ | tqtran - I'm not sure where the angular ID panels are, but I have some (hopefully) helpful customer / operator input for you | 16:15 |
| ducttape_ | someone just complained to me that he was trying to access swift container with 80k objects in it, via horizon | 16:16 |
| doug-fish | tqtran: remember, your patch worked - my update failed because of poor conflict resolution | 16:16 |
| *** mpavlase has joined #openstack-horizon | 16:16 | |
| ducttape_ | and our general consensus is that 10k objects in swift is small. horizon works up to about 50-100. math (and horizon) says that 50-100 << 10k | 16:17 |
| doug-fish | I didn't go back an fix it up because even with proper conflict resolution that patch is huge | 16:17 |
| tqtran | doug-fish: it passed the jshint part yes, but failed the grenade section | 16:17 |
| tqtran | which i thought was what we were talking about? | 16:17 |
| mriedem | tqtran: the grenade failure is a different global blocker on stable/kilo | 16:17 |
| mriedem | tqtran: nope, grenade is separate | 16:17 |
| tqtran | oh ok..... | 16:17 |
| tqtran | ok yeah thats what i thought | 16:18 |
| tqtran | because i saw the issue in cinder, etc.. | 16:18 |
| mriedem | the grenade fix is merged on stable/kilo now | 16:18 |
| mriedem | https://review.openstack.org/#/c/185073/ | 16:18 |
| tqtran | so what is the procedure on merging https://review.openstack.org/#/c/171321/ since it contains other code? | 16:19 |
| tqtran | *merging --> cherry-picking | 16:19 |
| doug-fish | the real answer is that it should have been multiple, smaller patches in the first place | 16:20 |
| doug-fish | I'm not sure how to fix at this point | 16:20 |
| doug-fish | the good news is that we have a small, focused patch proposed that seems to solve the issue | 16:21 |
| doug-fish | I just don't understand why it works, which doesn't give me much confidence in it | 16:21 |
| mriedem | it appears that jshint is just not finding .jshintrc, that's why bknudson's change to explicitly declare it is making things work | 16:21 |
| mriedem | i'm trying to recreate locally | 16:21 |
| mriedem | and reading up on jshint usage | 16:21 |
| tqtran | ducttape_: sorry, im not following, how is angular ID related to swift panel today? | 16:22 |
| *** lhcheng has joined #openstack-horizon | 16:22 | |
| ducttape_ | it's not, that is the problem | 16:22 |
| TravT | ducttape_: we had some interested talked with the swift guys last week | 16:23 |
| tqtran | ducttape_: so you're saying that angular would solve this issue? | 16:23 |
| ducttape_ | the swift area is especially an area where angular could have a HUGE impact, for the better | 16:23 |
| tqtran | ducttape_: is it fetched in one shot today? | 16:24 |
| ducttape_ | the swift area of horizon is only useful in devstack really, where you are storing a few items. this is not how most people use swift, and adding angular tools into the swift / horizon arena would be awesome. | 16:24 |
| TravT | not just from an angular perspective, but from a search perspective. | 16:24 |
| ducttape_ | that too TravT, but I'd not get the horse ahead of the cart | 16:25 |
| ducttape_ | first get horizon+swift working better. then you could add the meta data / search stuff too | 16:25 |
| *** JeanBriceCombebi has joined #openstack-horizon | 16:25 | |
| ducttape_ | that would be my desire / what our users (and most users I believe) would appreciate | 16:26 |
| TravT | they had a whole session on searching it and want to pull us in | 16:26 |
| TravT | they've got an initial spec to enable notification, which are needed for indexing | 16:26 |
| TravT | https://review.openstack.org/#/c/180914/2/specs/in_progress/notifications.rst | 16:26 |
| *** notmars has joined #openstack-horizon | 16:26 | |
| ducttape_ | yeah no doubt, there is a need for it. let's just fix the first glaring problem and make the meta data stuff a secondary / optional thing | 16:26 |
| TravT | but yes, angular first is very important. | 16:26 |
| tqtran | cool, i can tackle it after we get the users table merged | 16:27 |
| tqtran | or if someone else wants it own it, thats cool too :) | 16:27 |
| TravT | the whole UI needs some UX work first, IMO | 16:28 |
| tqtran | yes and that | 16:28 |
| TravT | current swift UI is very confusing if you ask me. | 16:28 |
| ducttape_ | the swift thing could be very cool, it could have a a new folder ui (not the table stuff elsewhere) | 16:28 |
| tqtran | hm... sounds like piet is going to get busy | 16:28 |
| ducttape_ | 13,000 containers with a million objects -> that was from one of our swift users | 16:29 |
| *** Drago has quit IRC | 16:29 | |
| ducttape_ | granted, that is the high end | 16:29 |
| *** jmolo has joined #openstack-horizon | 16:29 | |
| *** tosky has quit IRC | 16:30 | |
| *** vahidh has quit IRC | 16:30 | |
| tqtran | ducttape_: i have a feeling that even with angular, 1 million objects is going to blow up your browser's memory | 16:30 |
| TravT | john dickinson (swift PTL) said that aspire goals for swift in the largest deployments are to deal with 100,000 operations per second in terms of storing, changing, deleting objects. | 16:31 |
| tqtran | ducttape_: we may have to chunk the data | 16:31 |
| ducttape_ | there is no doubt angular would blow up with that many, but we should have a smoother paging / scrolling experience (as well as general UX) | 16:31 |
| TravT | you can't just pull all the objects into memory and expect them to stay up to date. | 16:32 |
| *** jwy has joined #openstack-horizon | 16:32 | |
| *** matt-borland has quit IRC | 16:33 | |
| mriedem | doug-fish: confirmed it's definitely a tox > 2.0 issue, | 16:33 |
| mriedem | doug-fish: tqtran: i had tox 1.9.2 locally and jshint tests on stable/kilo were fine | 16:33 |
| mriedem | upgrade tox to 2.0.1 now and re-running the jshint tests | 16:33 |
| ducttape_ | I agree with all these points TravT and tqtran. I'd say the horizon swift stuff is a very high impact area, rich with opportunities ;) | 16:34 |
| tqtran | :D yes, i think swift will test the performance of our work | 16:35 |
| ducttape_ | if you guys start working on this, and need someone to pull in a change set and review it in a large deployment - lemme know | 16:36 |
| tqtran | ducttape_: ok awesome, will keep that in mind | 16:37 |
| TravT | sounds good ducttape_: | 16:37 |
| *** JeanBriceCombebi has quit IRC | 16:38 | |
| *** alanf-mc has joined #openstack-horizon | 16:41 | |
| *** SimonChung has joined #openstack-horizon | 16:42 | |
| *** mpavlase has quit IRC | 16:43 | |
| *** mpavlase has joined #openstack-horizon | 16:43 | |
| *** e0ne has quit IRC | 16:45 | |
| *** mpavlase has quit IRC | 16:45 | |
| *** notmars has quit IRC | 16:45 | |
| *** mpavlase has joined #openstack-horizon | 16:46 | |
| *** samueldmq has joined #openstack-horizon | 16:49 | |
| *** jingjing_ren has joined #openstack-horizon | 16:52 | |
| *** jingjing_ren has quit IRC | 16:52 | |
| *** jingjing_ren has joined #openstack-horizon | 16:52 | |
| *** gokrokve has quit IRC | 16:53 | |
| tqtran | TravT: what is tyr's irc handle? | 16:53 |
| TravT | tyr | 16:53 |
| TravT | i can tell him to come online. | 16:54 |
| doug-fish | mriedem: how's your tox run going? mine seems to have just hung without completing | 16:54 |
| mriedem | doug-fish: failed the same as upstream | 16:54 |
| mriedem | trying to poke around the venv | 16:54 |
| *** cbader has joined #openstack-horizon | 16:54 | |
| *** sqchen has joined #openstack-horizon | 16:56 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Angular API Unit Tests https://review.openstack.org/178227 | 16:58 |
| *** tyr_ has joined #openstack-horizon | 16:59 | |
| *** matt-borland has joined #openstack-horizon | 16:59 | |
| *** markus_z has quit IRC | 17:00 | |
| mriedem | doug-fish: if i source .tox/jshint/bin/activate and then run "bash run_tests.sh -N --jshint", it's fine | 17:00 |
| mriedem | so my guess is there is something wonky with nodeenv and tox 2.0 | 17:03 |
| *** kiran-r has quit IRC | 17:04 | |
| *** mpavlase has quit IRC | 17:05 | |
| doug-fish | It's still not very satisfying that we don't see the same problem on master. I can't believe we are completely ignoring the jshintrc file there. | 17:05 |
| doug-fish | But given that we don't see jshint failures on master, I guess I should settle down. | 17:06 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Extending test coverage for core components https://review.openstack.org/170554 | 17:07 |
| mriedem | doug-fish: you could try reverting https://review.openstack.org/#/c/184865/ on master and run the jshint tests against it | 17:07 |
| mriedem | i mean this https://review.openstack.org/#/c/171321/ | 17:08 |
| mriedem | doug-fish: but i think removing /* jshint globalstrict: true */ is why it works on master | 17:08 |
| *** Drago has joined #openstack-horizon | 17:08 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Small fix to angular docs https://review.openstack.org/185668 | 17:08 |
| mriedem | doug-fish: that change ^ removed /* jshint globalstrict: true */ on master | 17:08 |
| *** garthb has joined #openstack-horizon | 17:09 | |
| *** garthb_ has joined #openstack-horizon | 17:09 | |
| mriedem | http://jshint.com/docs/options/#globalstrict | 17:09 |
| *** Drago has quit IRC | 17:10 | |
| *** Drago has joined #openstack-horizon | 17:10 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Extending test coverage for core components https://review.openstack.org/170554 | 17:11 |
| doug-fish | mriedem: yes, I'm pretty sure you are right on that - I still have the suspicion that our jshintrc file is ignored on master + that bknudson's change should first be on master and picked back to stable/kilo | 17:11 |
| *** romainh has quit IRC | 17:12 | |
| mriedem | doug-fish: want to test just removing .jshintrc on master and see if jshint cares? | 17:12 |
| *** tyr_ has quit IRC | 17:13 | |
| doug-fish | mriedem: I removed it. jshint doesn't care. | 17:16 |
| *** notmars has joined #openstack-horizon | 17:17 | |
| doug-fish | jshint doesn't care = it still returns success | 17:17 |
| doug-fish | but I think that means we aren't checking everything we expect without the change bknudson proposed for stable/kilo | 17:17 |
| tqtran | doug-fish, mriedem: hold on, the jshintrc file define rules, so yes it should run without the file but it assumes that we have no rules setup | 17:19 |
| tqtran | and im pretty sure its reading the rules on master | 17:20 |
| tqtran | rules/config | 17:20 |
| doug-fish | tqtran: can you prove that? | 17:20 |
| doug-fish | I'd suspect that it's not reading the rules on master | 17:20 |
| tqtran | let me test that to make sure im not just blowing smoke :) | 17:21 |
| mriedem | doug-fish: after you removed .jshintrc, you rebuilt the tox venv right? tox -r -e jshint? | 17:21 |
| doug-fish | mriedem: I did not | 17:21 |
| doug-fish | let me try it again | 17:21 |
| tqtran | doug-fish: yep just tested | 17:24 |
| tqtran | so heres what you do, go into a JS file and add an additional param that you don't use | 17:24 |
| tqtran | and run jshint via the run_tests script, it will fail | 17:24 |
| tqtran | if you remove the file, you remove the config/rules, so of course it will all pass | 17:25 |
| *** ctina__ has joined #openstack-horizon | 17:25 | |
| tqtran | and if you include the file, it will still all pass, because all of the JS files conform to those rules | 17:25 |
| doug-fish | tqtran: but did you try this running the tests from tox? after upgrading to tox 2.0.1? | 17:26 |
| mriedem | tqtran: is there a way to run jshint in debug or verbose mode to tell if it's findind and reading from the .jshintrc file? | 17:27 |
| tqtran | doug-fish: running it on master, so i would assume its tox 2.0.1, but let me explicitly run it using tox instead of the run_test script | 17:27 |
| tqtran | mriedem: jshint --verbose | 17:28 |
| tqtran | hm... nvm | 17:28 |
| tqtran | it only list the files | 17:28 |
| mriedem | tqtran: you have to pip install --upgrade tox locally | 17:28 |
| mriedem | tqtran: what do you have for tox locally? pip show tox? | 17:28 |
| *** bpokorny_ has joined #openstack-horizon | 17:29 | |
| tqtran | :O wth... | 17:29 |
| tqtran | tox v1.6.1 | 17:29 |
| mriedem | :) | 17:29 |
| mriedem | yeah, it was fine locally for me before when i had tox 1.9.2 | 17:29 |
| *** bpokorny has quit IRC | 17:29 | |
| mriedem | move up to 2.0.1 and it will start failing on stable/kilo | 17:29 |
| openstackgerrit | Doug Fish proposed openstack/horizon: Test Patch Do Not Merge https://review.openstack.org/185681 | 17:30 |
| tqtran | ok let me try that | 17:30 |
| *** yamamoto has joined #openstack-horizon | 17:31 | |
| doug-fish | The patch I just submitted introduces an unused var. | 17:31 |
| doug-fish | That should fail, right tqtran? | 17:31 |
| tqtran | yeah that should fail | 17:32 |
| tqtran | wait... one sec | 17:33 |
| tqtran | let me verify that we actually added those rules in kilo | 17:33 |
| tqtran | https://review.openstack.org/#/c/169243/ | 17:34 |
| tqtran | https://github.com/openstack/horizon/blob/master/.jshintrc#L5 | 17:34 |
| tqtran | yup, it landed in kilo | 17:34 |
| *** yamamoto has quit IRC | 17:35 | |
| *** dsneddon has quit IRC | 17:36 | |
| *** lhcheng_ has joined #openstack-horizon | 17:37 | |
| *** ybathia has joined #openstack-horizon | 17:38 | |
| *** lhcheng has quit IRC | 17:39 | |
| *** HenryG has quit IRC | 17:42 | |
| *** alexpilotti has quit IRC | 17:42 | |
| *** gugl has joined #openstack-horizon | 17:43 | |
| *** jwy has quit IRC | 17:45 | |
| *** HenryG has joined #openstack-horizon | 17:46 | |
| *** dsneddon has joined #openstack-horizon | 17:47 | |
| openstackgerrit | Merged openstack/horizon: ngReorg - Align constants, factories and services https://review.openstack.org/184345 | 17:49 |
| *** alexvictorchan has quit IRC | 17:50 | |
| *** alexvictorchan has joined #openstack-horizon | 17:54 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Refactor Angular features enablement https://review.openstack.org/179545 | 17:54 |
| *** doug-fish has quit IRC | 17:54 | |
| *** doug-fish has joined #openstack-horizon | 17:55 | |
| mriedem | tqtran: doug-fish: i have a fix | 17:55 |
| tqtran | mriedem: :D yay! | 17:56 |
| tqtran | btw, just ran it locally, got the same result | 17:56 |
| mriedem | i'll push up a fix shortly | 17:57 |
| mriedem | tox wasn't getting the env vars from nodeenv | 17:57 |
| *** doug-fish has quit IRC | 17:59 | |
| *** HenryG has quit IRC | 18:01 | |
| *** HenryG has joined #openstack-horizon | 18:01 | |
| mriedem | https://review.openstack.org/#/c/185681/ did pass the jshint test | 18:02 |
| *** cody-somerville has quit IRC | 18:03 | |
| *** cody-somerville has joined #openstack-horizon | 18:04 | |
| openstackgerrit | Jiri Tomasek proposed openstack/tuskar-ui: Synced run_tests.sh with horizon, requirements cleanup https://review.openstack.org/185583 | 18:05 |
| *** doug-fish has joined #openstack-horizon | 18:08 | |
| *** dguerri`away is now known as dguerri | 18:08 | |
| *** alanf-mc has quit IRC | 18:09 | |
| openstackgerrit | Merged openstack/horizon: ngReorg - Relocate filters and a validator https://review.openstack.org/184575 | 18:09 |
| *** mpavlase has joined #openstack-horizon | 18:09 | |
| *** lblanchard has quit IRC | 18:10 | |
| *** jingjing_ren has quit IRC | 18:11 | |
| *** alanf-mc has joined #openstack-horizon | 18:11 | |
| *** jingjing_ren has joined #openstack-horizon | 18:13 | |
| *** lblanchard has joined #openstack-horizon | 18:20 | |
| *** TravT has quit IRC | 18:23 | |
| *** gokrokve has joined #openstack-horizon | 18:25 | |
| *** neelabh has joined #openstack-horizon | 18:25 | |
| *** TravT has joined #openstack-horizon | 18:25 | |
| *** aix has quit IRC | 18:25 | |
| *** alanf-mc has quit IRC | 18:28 | |
| *** jprovazn has quit IRC | 18:28 | |
| *** alanf-mc has joined #openstack-horizon | 18:31 | |
| *** jingjing_ren has quit IRC | 18:34 | |
| *** jingjing_ren has joined #openstack-horizon | 18:36 | |
| *** gyee has quit IRC | 18:37 | |
| *** alejandrito has quit IRC | 18:38 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Remove bad 404 calls https://review.openstack.org/182728 | 18:40 |
| *** iamjarvo has quit IRC | 18:40 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Remove bad 404 calls https://review.openstack.org/182728 | 18:40 |
| *** jingjing_ren has quit IRC | 18:42 | |
| *** tqtran is now known as tqtran_afk | 18:43 | |
| *** logan2 has joined #openstack-horizon | 18:47 | |
| doug-fish | david-lyle, tqtran_afk, robcresswell_afk - hey guys I see you've been merging a lot of javascript today - I suspect that we aren't running jshint on it at all due to https://bugs.launchpad.net/horizon/+bug/1458928 - I think it would be safer to hold off until we have jshint tests before merging! | 18:47 |
| openstack | Launchpad bug 1458928 in OpenStack Dashboard (Horizon) "jshint failing on angular js in stable/kilo" [Critical,Confirmed] - Assigned to Doug Fish (drfish) | 18:47 |
| *** jbell8 has joined #openstack-horizon | 18:48 | |
| *** e0ne has joined #openstack-horizon | 18:53 | |
| *** naghceuz has joined #openstack-horizon | 18:54 | |
| openstackgerrit | Merged openstack/horizon: Quota graph label aligned https://review.openstack.org/169076 | 18:57 |
| openstackgerrit | Doug Fish proposed openstack/horizon: Add explicit path to jshint config file https://review.openstack.org/185703 | 18:59 |
| openstackgerrit | Matt Borland proposed openstack/horizon: [Launch Instance Fix] Add Flavor Step Unit Tests https://review.openstack.org/167326 | 19:01 |
| openstackgerrit | Doug Fish proposed openstack/horizon: Add explicit path to jshint config file https://review.openstack.org/185703 | 19:05 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Get unit tests working with Karma https://review.openstack.org/168152 | 19:07 |
| *** TravT has quit IRC | 19:13 | |
| *** jbell8 has quit IRC | 19:13 | |
| *** TravT has joined #openstack-horizon | 19:14 | |
| openstackgerrit | Merged openstack/horizon: ngReorg - Create dashboard-app https://review.openstack.org/184597 | 19:14 |
| *** iamjarvo has joined #openstack-horizon | 19:15 | |
| openstackgerrit | Matt Riedemann proposed openstack/horizon: Inherit environment variables for tests that use nodeenv https://review.openstack.org/185707 | 19:18 |
| *** nlahouti has quit IRC | 19:18 | |
| mriedem | doug-fish: -1'd your change | 19:18 |
| mriedem | see mine ^ | 19:18 |
| mriedem | doug-fish: can you restore https://review.openstack.org/#/c/185681/ so i can rebase that on top of my change and verify it works? | 19:19 |
| mriedem | works as in https://review.openstack.org/#/c/185681/ will fail | 19:19 |
| doug-fish | mriedem: yeah yours looks better | 19:20 |
| openstackgerrit | Matt Riedemann proposed openstack/horizon: Test Patch Do Not Merge https://review.openstack.org/185681 | 19:21 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Get unit tests working with Karma https://review.openstack.org/168152 | 19:24 |
| openstackgerrit | Matt Riedemann proposed openstack/horizon: Ignore all egg type artifacts https://review.openstack.org/185709 | 19:25 |
| openstackgerrit | Matt Riedemann proposed openstack/horizon: Ignore all egg type artifacts https://review.openstack.org/185709 | 19:25 |
| *** notmars has quit IRC | 19:28 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: [Launch Instance Fix] Add Model Unit Tests https://review.openstack.org/167738 | 19:32 |
| *** tqtran_afk is now known as tqtran | 19:33 | |
| mriedem | doug-fish: verified jshint fails on your change | 19:33 |
| mriedem | horizon/static/framework/widgets/widgets.module.js: line 4, col 7, 'heyWhatsUp' is defined but never used. | 19:33 |
| mriedem | https://jenkins04.openstack.org/job/gate-horizon-jshint/78/console | 19:33 |
| doug-fish | let's ship it | 19:33 |
| mriedem | well, round up your horizon core buddies | 19:34 |
| tqtran | BAM! | 19:35 |
| doug-fish | yeah. I was thinking maybe let the gate jobs finish first | 19:35 |
| doug-fish | or not | 19:35 |
| tqtran | can wait until it passes to +A | 19:35 |
| *** TravT has quit IRC | 19:35 | |
| *** TravT has joined #openstack-horizon | 19:36 | |
| mriedem | sure, i'm watching it in zuul.o.o | 19:36 |
| doug-fish | I'm going to get some coffee + harass people if it isn't merged when I get back. | 19:37 |
| doug-fish | s/harass/kindly ask for help from | 19:37 |
| tqtran | lhcheng_, david-lyle, TravT: https://review.openstack.org/#/c/185707/ needs immediate attention :) | 19:37 |
| mriedem | well, you have about 45 minutes | 19:37 |
| mriedem | b/c of the devstack + tempeat and grenade jobs | 19:37 |
| *** jingjing_ren has joined #openstack-horizon | 19:39 | |
| akrivoka | clu: hey Cindy, would you mind re-reviewing this when you get a chance? https://review.openstack.org/#/c/179833/ | 19:43 |
| clu | hi akrivoka: no problem :) | 19:46 |
| akrivoka | clu: thanks! | 19:47 |
| *** notmars has joined #openstack-horizon | 19:50 | |
| *** Sukhdev has joined #openstack-horizon | 19:50 | |
| *** yamamoto has joined #openstack-horizon | 19:51 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: ngReorg - move utils from dashboad-app https://review.openstack.org/185140 | 19:52 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Encase helper-functions spec in IIEF https://review.openstack.org/185721 | 19:52 |
| *** e0ne has quit IRC | 19:55 | |
| tqtran | r1chardj0n3s: ping | 19:56 |
| tqtran | r1chardj0n3s: https://review.openstack.org/#/c/185140/ if you can rebase and address comments, we can move it along | 19:56 |
| openstackgerrit | Ryan Peters proposed openstack/horizon: ngReorg - Move API files to openstack_dashboard https://review.openstack.org/184543 | 19:58 |
| *** jbell8 has joined #openstack-horizon | 19:59 | |
| jbell8 | david-lyle: i just confirmed with the PI for the Mass Open Cloud, we can host the Horizon mid-cycle at Boston University if you guys want | 20:00 |
| TravT | tqtran: david-lyle: any reason for us to not +A this through? | 20:00 |
| TravT | https://review.openstack.org/#/c/185707/ | 20:00 |
| *** e0ne has joined #openstack-horizon | 20:00 | |
| jbell8 | david-lyle: is there an etherpad that I should add our name to? | 20:00 |
| TravT | it passed tests | 20:00 |
| *** alanf-mc has quit IRC | 20:01 | |
| *** alanf-mc_ has joined #openstack-horizon | 20:02 | |
| jbell8 | TravT: do you know where we're recording potential locations for the mid-cycle? | 20:02 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding John Papa style guide to JSCS https://review.openstack.org/185725 | 20:03 |
| tqtran | TravT: was waiting on gate earlier | 20:03 |
| openstackgerrit | Ryan Peters proposed openstack/horizon: ngReorg - Move API files to openstack_dashboard https://review.openstack.org/184543 | 20:04 |
| *** radez is now known as radez_g0n3 | 20:04 | |
| *** ctina__ has quit IRC | 20:05 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: ngReorg - move utils from dashboad-app https://review.openstack.org/185140 | 20:10 |
| *** iamjarvo has quit IRC | 20:11 | |
| *** jwy has joined #openstack-horizon | 20:11 | |
| *** iamjarvo has joined #openstack-horizon | 20:12 | |
| mriedem | doug-fish: you can abandon https://review.openstack.org/#/c/185681/ now | 20:13 |
| mriedem | thanks | 20:13 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding John Papa style guide to JSCS https://review.openstack.org/185725 | 20:13 |
| *** ZZelle_ has joined #openstack-horizon | 20:13 | |
| *** samueldmq has quit IRC | 20:15 | |
| *** jbell8 has quit IRC | 20:16 | |
| *** jbell8 has joined #openstack-horizon | 20:18 | |
| *** neelabh has quit IRC | 20:23 | |
| asahlin | tqtran: Any plan of attack on how to tackle 15,000+ JSCS issues found by https://review.openstack.org/185725? Divide and conquer? | 20:25 |
| tqtran | TravT: does it make sense for us to just remove the recommend and required section for our angular stuff? | 20:25 |
| tqtran | asahlin, TravT: i think we can just provide a link to JP's guide, it doesnt make sense for us to parrot | 20:25 |
| tqtran | asahlin: yeah, same strategy as the jshint issue in kilo, tackle by sections and then enable globally once it all passes | 20:26 |
| TravT | tqtran: i think so | 20:26 |
| tqtran | ok i'll update the doc accordingly then | 20:26 |
| *** radez_g0n3 is now known as radez | 20:26 | |
| *** julim has quit IRC | 20:27 | |
| TravT | tqtran: i almost deleted it when I added the original link to the JP guide | 20:27 |
| asahlin | TravT: tqtran: I 2nd the removal of the required and recommended sections.. I added those initially when we didn't have any rules to follow. | 20:27 |
| TravT | so, i'd say go ahead. | 20:27 |
| *** gyee has joined #openstack-horizon | 20:28 | |
| asahlin | or 3rd it | 20:28 |
| tqtran | well the translation stuff in required is still needed | 20:30 |
| tqtran | so i'll keep that around | 20:30 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Remove unused config access via REST https://review.openstack.org/183224 | 20:33 |
| *** nlahouti has joined #openstack-horizon | 20:35 | |
| *** jbell8 has quit IRC | 20:36 | |
| ducttape_ | docs question: if I have a change that requires an update to http://docs.openstack.org/developer/horizon/topics/settings.html - how do I go about making sure that this page gets updated too ? | 20:36 |
| *** yamamoto has quit IRC | 20:38 | |
| asahlin | ducttape_: you would need to update doc/source/topics/settings.rst | 20:38 |
| openstackgerrit | George Peristerakis proposed openstack/horizon: Refactoring the exceptions lists https://review.openstack.org/173027 | 20:38 |
| ducttape_ | thanks asahlin! | 20:38 |
| asahlin | ducttape_: no problem | 20:39 |
| *** alanf-mc has joined #openstack-horizon | 20:39 | |
| *** alanf-mc_ has quit IRC | 20:39 | |
| tqtran | TravT, asahlin: how do i view the docs locally? | 20:40 |
| TravT | ./run_tests.sh --docs | 20:40 |
| asahlin | tqtran: tox -edocs | 20:40 |
| asahlin | or what TravT said | 20:41 |
| *** alanf-mc has quit IRC | 20:41 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Small fix to angular docs https://review.openstack.org/185668 | 20:42 |
| *** alanf-mc has joined #openstack-horizon | 20:42 | |
| *** yamamoto has joined #openstack-horizon | 20:43 | |
| *** mriedem has left #openstack-horizon | 20:44 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Small fix to angular docs https://review.openstack.org/185668 | 20:45 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Small fix to angular docs https://review.openstack.org/185668 | 20:45 |
| *** peristeri has quit IRC | 20:46 | |
| *** sqchen has quit IRC | 20:50 | |
| *** jbell8 has joined #openstack-horizon | 20:50 | |
| *** iamjarvo has quit IRC | 20:54 | |
| dmz | is there any specific log I can monitor for brute force attacks against my horizon service? | 20:55 |
| openstackgerrit | Merged openstack/horizon: Add kernel/ramdisk for image create https://review.openstack.org/179833 | 20:56 |
| *** gokrokve has quit IRC | 21:01 | |
| *** gokrokve has joined #openstack-horizon | 21:02 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Get unit tests working with Karma https://review.openstack.org/168152 | 21:02 |
| openstackgerrit | Merged openstack/horizon: Inherit environment variables for tests that use nodeenv https://review.openstack.org/185707 | 21:02 |
| r1chardj0n3s | morning | 21:03 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Angular API Unit Tests https://review.openstack.org/178227 | 21:03 |
| *** HenryG has quit IRC | 21:04 | |
| *** jbell8 has quit IRC | 21:06 | |
| *** jtriley has quit IRC | 21:07 | |
| *** HenryG has joined #openstack-horizon | 21:07 | |
| *** lhcheng_ is now known as lhcheng | 21:10 | |
| r1chardj0n3s | tqtran: thanks for the nit edits in https://review.openstack.org/#/c/185140/ | 21:10 |
| *** sqchen has joined #openstack-horizon | 21:10 | |
| r1chardj0n3s | oh wow, did all Tyr's ngReorg patches land while I was asleep?! cool! | 21:11 |
| *** crobertsrh is now known as _crobertsrh | 21:12 | |
| *** lblanchard has quit IRC | 21:13 | |
| tqtran | r1chardj0n3s: yup it did | 21:14 |
| r1chardj0n3s | nice work all :) | 21:14 |
| *** garthb__ has joined #openstack-horizon | 21:15 | |
| *** garthb has quit IRC | 21:15 | |
| *** garthb_ has quit IRC | 21:15 | |
| *** garthb has joined #openstack-horizon | 21:15 | |
| *** mattfarina has quit IRC | 21:15 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Get unit tests working with Karma https://review.openstack.org/168152 | 21:19 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Angular API Unit Tests https://review.openstack.org/178227 | 21:19 |
| *** matt-borland has quit IRC | 21:20 | |
| openstackgerrit | Eric Peterson proposed openstack/django_openstack_auth: Support removal of last_activity session flag https://review.openstack.org/179800 | 21:22 |
| *** notmars has quit IRC | 21:24 | |
| *** iamjarvo has joined #openstack-horizon | 21:25 | |
| openstackgerrit | Eric Peterson proposed openstack/django_openstack_auth: Support removal of last_activity session flag https://review.openstack.org/179800 | 21:27 |
| *** sqchen has quit IRC | 21:28 | |
| ducttape_ | thanks pep8 import organization, thanks. +100 pep8 | 21:28 |
| *** sqchen has joined #openstack-horizon | 21:29 | |
| *** akrivoka has quit IRC | 21:30 | |
| *** iamjarvo has quit IRC | 21:31 | |
| openstackgerrit | Eric Peterson proposed openstack/horizon: Removing last_activity session flag https://review.openstack.org/179513 | 21:32 |
| openstackgerrit | Eric Peterson proposed openstack/horizon: Removing last_activity session flag https://review.openstack.org/179513 | 21:34 |
| krotscheck | Everyone should go +1 this spec :D https://review.openstack.org/#/c/179866/ | 21:45 |
| r1chardj0n3s | krotscheck: oh, is this CORS-in-OpenStack mk 4? :) | 21:46 |
| krotscheck | r1chardj0n3s: Yep | 21:46 |
| tqtran | krotscheck: i thought there was already a cors util in oslo? | 21:46 |
| krotscheck | r1chardj0n3s: It comes with an already-landed middleware :) | 21:46 |
| *** lhcheng has left #openstack-horizon | 21:46 | |
| krotscheck | This just puts a policy in place we can reference when telling other openstack projects that they should implement CORS. | 21:47 |
| krotscheck | And provides them with a _dead simple_ way to support it. | 21:47 |
| krotscheck | (Assuming they're a python wsgi app) | 21:47 |
| r1chardj0n3s | krotscheck: hm. config is a single line-item in this spec whereas in reality it's going to be the hardest part to get right | 21:48 |
| r1chardj0n3s | the complexity of config killed my (olso) spec | 21:48 |
| *** notmars has joined #openstack-horizon | 21:49 | |
| *** gokrokve has quit IRC | 21:50 | |
| *** Sukhdev has quit IRC | 21:50 | |
| krotscheck | r1chardj0n3s: I may have solved that. | 21:50 |
| krotscheck | Programatically, anyway. | 21:51 |
| *** Sukhdev has joined #openstack-horizon | 21:51 | |
| krotscheck | http://docs.openstack.org/developer/oslo.middleware/cors.html | 21:51 |
| r1chardj0n3s | krotscheck: oh, the *technical* side of configuration is easy. getting deployers to get it right is very hard. | 21:54 |
| r1chardj0n3s | since *service* authors cannot configure CORS for them | 21:55 |
| *** lhcheng has joined #openstack-horizon | 21:55 | |
| r1chardj0n3s | the deployers must write the CORS config entries | 21:55 |
| krotscheck | Yeah, that's why I suspect I"m going to be writing an awful lot of documentation this cycle. | 21:55 |
| *** vijendar has quit IRC | 21:55 | |
| r1chardj0n3s | and the configuration also requires a pretty deep knowledge of the APIs being exposed. which means more solid API documentation than we currently have | 21:55 |
| *** jtriley has joined #openstack-horizon | 21:56 | |
| r1chardj0n3s | I wish there was an easy way to discover my old spec, which hashed out a bunch of these issues | 21:56 |
| krotscheck | And yet, it's a necessary evil. | 21:56 |
| r1chardj0n3s | sure, but relegating config to one line item is not accepting the risk it presents | 21:57 |
| krotscheck | And yet, still a necessary evil. | 21:57 |
| krotscheck | Here's the thing: We can either put something together that's well documented, or we can continue to maintain a proxy service. | 21:58 |
| krotscheck | The "new thing" is hard. | 21:58 |
| r1chardj0n3s | krotscheck: my old spec https://review.openstack.org/#/c/119485/ | 21:58 |
| r1chardj0n3s | "withdrawing this spec as I don't see a need for code to be in oslo at this point, and there's a generic WSGI CORS solution out there already" | 21:58 |
| krotscheck | Which is why doing it _once_ makes the most sense. | 21:58 |
| krotscheck | r1chardj0n3s: The one you linked to was a blanket on-switch mirror if I recall correctly. | 21:59 |
| r1chardj0n3s | no, it was not | 21:59 |
| r1chardj0n3s | not that I recall anyway ;) | 21:59 |
| r1chardj0n3s | one of us recalls incorrectly | 21:59 |
| *** gokrokve has joined #openstack-horizon | 21:59 | |
| krotscheck | Right. | 21:59 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Encase helper-functions spec in IIFE https://review.openstack.org/185721 | 22:00 |
| openstackgerrit | Thai Tran proposed openstack/horizon: ngReorg - move utils from dashboad-app https://review.openstack.org/185140 | 22:00 |
| krotscheck | So there's flask-cors (not usable because platform specific), Django cors (for the same reason), wsgicors (domain and subdomain only, not multidomain).... | 22:00 |
| krotscheck | Wait, I'm wrong on that last one. | 22:00 |
| krotscheck | Except it requires a different configuration entry point, and we already have oslo. | 22:01 |
| *** Sukhdev has quit IRC | 22:02 | |
| r1chardj0n3s | krotscheck: well if you don't want to rewrite it, I've already written a CORS middleware for oslo.middleware. Just bring it back from the dead. https://review.openstack.org/#/c/120964/ | 22:03 |
| krotscheck | r1chardj0n3s: I actually ripped most of your tests out of that one and reused them. | 22:03 |
| r1chardj0n3s | right | 22:03 |
| krotscheck | r1chardj0n3s: But, well, the middleware has already been built and approved. | 22:03 |
| krotscheck | And merged. | 22:03 |
| krotscheck | And it's in global-requirements. | 22:04 |
| r1chardj0n3s | ok | 22:04 |
| r1chardj0n3s | what on earth are you asking for +1 for? | 22:04 |
| *** Sukhdev has joined #openstack-horizon | 22:04 | |
| krotscheck | So now the only thing left to do is encourage everyone else to do it. Which is waht the +1's on the openstack-global spec is for. | 22:04 |
| r1chardj0n3s | ok | 22:05 |
| krotscheck | Because doing anything x-project without involving the TC and the x-project types is bound to run into a quagmire of political fiefdoms. | 22:05 |
| *** gokrokve has quit IRC | 22:05 | |
| r1chardj0n3s | fair enough | 22:05 |
| *** gokrokve has joined #openstack-horizon | 22:06 | |
| *** iamjarvo has joined #openstack-horizon | 22:08 | |
| *** notmars has quit IRC | 22:11 | |
| r1chardj0n3s | +1'ing "those docs are sooo not my problem" :) | 22:13 |
| *** jtriley has quit IRC | 22:14 | |
| david-lyle | I'm going to cancel tomorrows Horizon meeting unless someone has something pressing | 22:16 |
| david-lyle | nothing on the agenda, and we just chatted | 22:16 |
| r1chardj0n3s | ohai david-lyle o/ | 22:17 |
| david-lyle | o/ r1chardj0n3s | 22:18 |
| r1chardj0n3s | movement in ngReorg land, which is nice to see :) | 22:18 |
| david-lyle | yes | 22:19 |
| *** garthb__ has quit IRC | 22:19 | |
| *** garthb__ has joined #openstack-horizon | 22:19 | |
| david-lyle | and stable/kilo was fixed today which pointed out an issue with jshint on master not being honored | 22:19 |
| david-lyle | so good progress | 22:19 |
| david-lyle | let's not slow it down with meetings ;) | 22:19 |
| david-lyle | of course the second might mean that the first let in exceptions | 22:20 |
| *** doug-fish has left #openstack-horizon | 22:21 | |
| *** iamjarvo has quit IRC | 22:21 | |
| david-lyle | canceled | 22:23 |
| david-lyle | how did you summit end up? good? meh? | 22:24 |
| david-lyle | the trip home | 22:25 |
| r1chardj0n3s | not slowing down with meetings o/ | 22:25 |
| r1chardj0n3s | so where was everyone yesterday? | 22:25 |
| tqtran | in SJ relaxing | 22:25 |
| david-lyle | US holiday | 22:25 |
| r1chardj0n3s | I got back and fired up to get all productive and no-one was in here | 22:25 |
| r1chardj0n3s | oh! | 22:25 |
| tqtran | lol | 22:25 |
| r1chardj0n3s | oh, of course. memorial day | 22:25 |
| r1chardj0n3s | lol | 22:25 |
| tqtran | memorial day | 22:25 |
| r1chardj0n3s | yeah | 22:25 |
| david-lyle | extra day of quiet for you | 22:25 |
| r1chardj0n3s | ok, so my brain wasn't firing on *all* cylinders ;) | 22:26 |
| tqtran | r1chardj0n3s: https://github.com/johnpapa/angular-styleguide#style-y060 | 22:26 |
| tqtran | this is JP | 22:26 |
| tqtran | JP's recommendation | 22:26 |
| r1chardj0n3s | good that I got the in-theory +1 on the email tho, gives me confidence to fire on ahead | 22:26 |
| david-lyle | you just sounded so lonely in the email | 22:27 |
| r1chardj0n3s | tqtran: is that pertinent to something specific, or just in general? | 22:27 |
| david-lyle | felt like I had to respond | 22:27 |
| r1chardj0n3s | david-lyle aw shucks | 22:27 |
| tqtran | you have been a big proponent of getting rid of it, now is the time to voice your opinion, because once it goes in, we're not changing | 22:27 |
| david-lyle | tqtran: ABC | 22:27 |
| david-lyle | always be closing | 22:27 |
| tqtran | lol | 22:27 |
| tqtran | ABC? | 22:27 |
| r1chardj0n3s | tqtran: ah, ok. yeah, well, with the recent stuff that's landed we *have* to use DI strings because we have to rename them thanks to the DI sources having fully.qualified.module.names | 22:28 |
| r1chardj0n3s | so I lose :) | 22:28 |
| tqtran | r1chardj0n3s: sorry wrong section: https://github.com/johnpapa/angular-styleguide#style-y090 | 22:28 |
| tqtran | oh right... lol | 22:29 |
| david-lyle | tqtran: https://www.youtube.com/watch?v=Q4PE2hSqVnk | 22:29 |
| david-lyle | you peddling code | 22:29 |
| david-lyle | :D | 22:29 |
| * r1chardj0n3s can't view that toob because regions :/ | 22:29 | |
| ducttape_ | is that the censored version ? | 22:29 |
| david-lyle | ah no | 22:30 |
| openstackgerrit | Ryan Peters proposed openstack/horizon: ngReorg - Move API files to openstack_dashboard https://review.openstack.org/184543 | 22:30 |
| *** naghceuz has quit IRC | 22:30 | |
| ducttape_ | what happened to you, david-lyle? to make you that way? ;) | 22:31 |
| *** radez is now known as radez_g0n3 | 22:34 | |
| *** lifeless has quit IRC | 22:35 | |
| *** mwhagedorn has quit IRC | 22:36 | |
| tqtran | :O omg... | 22:37 |
| tqtran | he makes my boss look like an angel | 22:37 |
| david-lyle | tqtran: I thought you linked a patch, now realizing just a link | 22:37 |
| david-lyle | thought you were trying to close | 22:37 |
| david-lyle | alas, just entertainment | 22:37 |
| tqtran | lol ABC, now i know the true meaning | 22:38 |
| ducttape_ | do you want some reviews for closers? I got 'em | 22:38 |
| tqtran | he looks so young back then | 22:38 |
| tqtran | brass balls.... lol hilarious | 22:38 |
| tqtran | apparently he happens to carry them around | 22:38 |
| david-lyle | r1chardj0n3s: Glengarry glen ross Always be closing speech | 22:38 |
| david-lyle | tqtran: you don't? | 22:39 |
| tqtran | ok i was going to respond to that, but then realize that i shouldnt, so i'll keep it that way lol | 22:39 |
| david-lyle | lol | 22:40 |
| r1chardj0n3s | so we had someone in channel yesterday asking about where to find the angularjs dashboards in the horizon code | 22:46 |
| r1chardj0n3s | I could only disappoint | 22:46 |
| david-lyle | dashboards? | 22:47 |
| r1chardj0n3s | yep | 22:47 |
| david-lyle | did they expand? | 22:47 |
| r1chardj0n3s | I guess word might have gotten around that there are some | 22:47 |
| r1chardj0n3s | I actually think this person thought everything was angularjs | 22:47 |
| david-lyle | hmm, that's a bit off | 22:48 |
| david-lyle | :D | 22:48 |
| r1chardj0n3s | yup ;) | 22:48 |
| openstackgerrit | Kahou Lei proposed openstack/horizon: User should be able to update allocation pool values. https://review.openstack.org/185772 | 22:48 |
| *** jbell8 has joined #openstack-horizon | 22:48 | |
| r1chardj0n3s | oh, and also there was confusion about the horizon/dashboard split :) | 22:48 |
| tqtran | what split? | 22:48 |
| r1chardj0n3s | it was "neelabh" if you want to go back in scrollback | 22:48 |
| r1chardj0n3s | tqtran: oh, that split that people pretend exists ;) | 22:49 |
| tqtran | lol | 22:49 |
| openstackgerrit | Kahou Lei proposed openstack/horizon: User should be able to update allocation pool values. https://review.openstack.org/185772 | 22:50 |
| *** lhcheng_ has joined #openstack-horizon | 22:51 | |
| *** ducttape_ has quit IRC | 22:52 | |
| *** jbell8 has quit IRC | 22:52 | |
| *** lhcheng has quit IRC | 22:53 | |
| *** e0ne has quit IRC | 22:53 | |
| openstackgerrit | David Lyle proposed openstack/horizon: Removing last_activity session flag https://review.openstack.org/179513 | 22:55 |
| *** dguerri is now known as dguerri`away | 22:57 | |
| *** stevemar has quit IRC | 22:58 | |
| *** botang has quit IRC | 23:01 | |
| *** botang_ has joined #openstack-horizon | 23:03 | |
| *** robcresswell_afk is now known as robcresswell | 23:04 | |
| *** Ephur has quit IRC | 23:06 | |
| *** ZZelle_ has quit IRC | 23:07 | |
| *** robcresswell is now known as robcresswell_afk | 23:07 | |
| *** Piet has joined #openstack-horizon | 23:07 | |
| *** sqchen has quit IRC | 23:08 | |
| *** chlong has joined #openstack-horizon | 23:09 | |
| r1chardj0n3s | tqtran: around? | 23:11 |
| tqtran | r1chardj0n3s: yup still here | 23:12 |
| r1chardj0n3s | kewl. wonder if I could borrow your eyeballs to look at this failure http://logs.openstack.org/91/185191/6/check/gate-horizon-python27-django14/be25723/console.html.gz | 23:12 |
| tqtran | whats the patch? | 23:12 |
| r1chardj0n3s | basically, the tests are failing because compressor can't find "dashboard/app/app.module.js" | 23:12 |
| r1chardj0n3s | 185191 (it's in the URL ;) | 23:12 |
| *** Sukhdev has quit IRC | 23:13 | |
| r1chardj0n3s | but that file does exist, and django will happily serve it as "/static/dashboard/app/app.module.js" so I'm stumped as to why the compressor can't find it | 23:13 |
| r1chardj0n3s | also, I don't get that compressor error when running the server locally | 23:13 |
| tqtran | ok let me take a look | 23:14 |
| r1chardj0n3s | thanks | 23:14 |
| r1chardj0n3s | I figure I'm just missing something stupid | 23:14 |
| *** chlong has quit IRC | 23:15 | |
| *** jingjing_ren has quit IRC | 23:16 | |
| *** jingjing_ren has joined #openstack-horizon | 23:17 | |
| r1chardj0n3s | can't reproduce running unit tests locally either :/ | 23:17 |
| r1chardj0n3s | can't see any undetected problems in the test setup | 23:18 |
| tqtran | i already saw a few, let me pull down your patch and run it locally :P | 23:18 |
| *** yamamoto has quit IRC | 23:18 | |
| r1chardj0n3s | ok | 23:19 |
| *** Sukhdev has joined #openstack-horizon | 23:20 | |
| tqtran | so first of all, your ng-app is set to the wrong module | 23:20 |
| tqtran | https://review.openstack.org/#/c/185191/7/horizon/templates/base.html | 23:20 |
| tqtran | should be hz.dashboard.app i think | 23:20 |
| r1chardj0n3s | yes | 23:21 |
| tqtran | so heres another wierd thing | 23:21 |
| tqtran | we have hz.dashboard.app | 23:21 |
| tqtran | which depends on hz.dashboard module | 23:22 |
| tqtran | that seems a bit strange to me | 23:22 |
| r1chardj0n3s | that's actually something I think is broken. I think it should be hz.app | 23:22 |
| r1chardj0n3s | don't want the dashboard *module* having the app as a dependency. I think | 23:22 |
| tqtran | ok, or just hz? | 23:22 |
| r1chardj0n3s | hm | 23:22 |
| tqtran | also, should be use horizon instead of hz? | 23:23 |
| tqtran | we're using horizon.framework, horizon.widgets, etc... | 23:23 |
| *** sqchen has joined #openstack-horizon | 23:23 | |
| r1chardj0n3s | the hz-vs-horizon was argued over in tyr's patch chain IIRC | 23:23 |
| tqtran | ok, let me read that | 23:23 |
| r1chardj0n3s | I don't recall specifically where though | 23:23 |
| r1chardj0n3s | if you find it pls share ;) | 23:23 |
| openstackgerrit | Ryan Peters proposed openstack/horizon: ngReorg - Move API files to openstack_dashboard https://review.openstack.org/184543 | 23:24 |
| tqtran | r1chardj0n3s: >< theres quite a few of those | 23:24 |
| tqtran | is it inline or comment? | 23:25 |
| r1chardj0n3s | don't recall, sorry | 23:25 |
| tqtran | ok so what was the outcome? | 23:26 |
| r1chardj0n3s | hang on, I'm just trying to find where it was done | 23:26 |
| r1chardj0n3s | https://review.openstack.org/#/c/184597/ is close, might be it | 23:26 |
| *** darrenc is now known as darrenc_afk | 23:26 | |
| *** gokrokve has quit IRC | 23:27 | |
| tqtran | yup that was the first patch i scan through, i didnt see discussion on it | 23:28 |
| r1chardj0n3s | I think the discussion is back on the megapatch | 23:28 |
| tqtran | i think we should just be consistent and use the horizon namespace | 23:28 |
| tqtran | not sure why we use hz for some and horizon for some, its confusing | 23:28 |
| r1chardj0n3s | I agree | 23:28 |
| r1chardj0n3s | "hz" is the old-school tech-debt angularjs stuff | 23:29 |
| r1chardj0n3s | I think it's reasonable to lose that for things we are going to keep | 23:29 |
| r1chardj0n3s | actually, I take that back | 23:30 |
| r1chardj0n3s | most of the hits are in the API code, which ryan's moving (don't know ryan's IRC nick) | 23:30 |
| r1chardj0n3s | there's still things like hzUtils and hzConf which we can clean up later, but hz as a module namespace should be changeable | 23:31 |
| tqtran | yup, sounds good, lets do that | 23:31 |
| TravT | hz is supposed to be for directive prefixes. horizon for module prefixes | 23:31 |
| r1chardj0n3s | ok | 23:31 |
| tqtran | TravT: make sense | 23:32 |
| tqtran | just like angular vs ng | 23:32 |
| TravT | yep | 23:32 |
| r1chardj0n3s | ok, so that means a mega refactor patch in openstack_dashboard to s/hz./horizon./g so I'll figure out where in the chain it makes sense to do that | 23:32 |
| *** mpavlase has quit IRC | 23:33 | |
| tqtran | r1chardj0n3s === MEGAMAN | 23:33 |
| r1chardj0n3s | lulz | 23:33 |
| tqtran | hahaha | 23:33 |
| TravT | r1chardj0n3s: tqtran: i just put a comment on https://review.openstack.org/#/c/185140/ | 23:33 |
| tqtran | yep just saw your comments | 23:35 |
| r1chardj0n3s | thanks for noting that TravT, will have to address it yup | 23:35 |
| r1chardj0n3s | I gotta disappear for a bit, back in a few minutes | 23:35 |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 23:36 | |
| TravT | thanks. i have to leave for now as well | 23:36 |
| tqtran | theres another issue with he console as well, looks like richshaw and datepicker css | 23:36 |
| tqtran | are missing | 23:36 |
| TravT | that error has been going on for some time | 23:36 |
| TravT | matt-borland put up a fix on it | 23:36 |
| TravT | and was -1'd but i never investigated | 23:36 |
| r1chardj0n3s_afk | yeah, there's something screwy with the static files config | 23:37 |
| tqtran | oh cool, can you link the patch? | 23:37 |
| TravT | https://review.openstack.org/#/c/182728/ | 23:37 |
| tqtran | saves me the work of investigating :D | 23:37 |
| *** darrenc_afk is now known as darrenc | 23:37 | |
| TravT | i've gotta run for now. | 23:38 |
| *** jtriley has joined #openstack-horizon | 23:40 | |
| *** jamielennox is now known as jamielennox|away | 23:42 | |
| *** ZZelle_ has joined #openstack-horizon | 23:44 | |
| *** chlong has joined #openstack-horizon | 23:44 | |
| *** jtriley has quit IRC | 23:46 | |
| *** alanf-mc has quit IRC | 23:48 | |
| *** yamamoto has joined #openstack-horizon | 23:50 | |
| *** lifeless has joined #openstack-horizon | 23:54 | |
| *** Sukhdev has quit IRC | 23:54 | |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 23:56 | |
| *** ducttape_ has joined #openstack-horizon | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!