| *** peristeri has quit IRC | 00:00 | |
| *** jingjing_ren has quit IRC | 00:00 | |
| *** jingjing_ren has joined #openstack-horizon | 00:04 | |
| openstackgerrit | Merged openstack/django_openstack_auth: Updated from global requirements https://review.openstack.org/167942 | 00:06 |
|---|---|---|
| *** ybathia has quit IRC | 00:07 | |
| *** ybathia has joined #openstack-horizon | 00:07 | |
| *** alexvictorchan has quit IRC | 00:11 | |
| *** sqchen has quit IRC | 00:15 | |
| *** iamjarvo has joined #openstack-horizon | 00:16 | |
| *** jbell8 has joined #openstack-horizon | 00:18 | |
| *** iamjarvo has quit IRC | 00:24 | |
| *** jbell8 has quit IRC | 00:24 | |
| *** ybathia has quit IRC | 00:27 | |
| *** david-lyle has quit IRC | 00:32 | |
| *** tqtran has quit IRC | 00:35 | |
| *** jtriley has joined #openstack-horizon | 00:37 | |
| *** yingjun has joined #openstack-horizon | 00:39 | |
| *** yingjun_ has joined #openstack-horizon | 00:40 | |
| *** jingjing_ren has quit IRC | 00:41 | |
| *** jtriley has quit IRC | 00:42 | |
| *** yingjun has quit IRC | 00:44 | |
| *** lhcheng_ is now known as lhcheng | 00:48 | |
| *** drupalmonkey has quit IRC | 00:53 | |
| *** lhcheng has quit IRC | 01:06 | |
| *** lhcheng has joined #openstack-horizon | 01:08 | |
| *** jingjing_ren has joined #openstack-horizon | 01:11 | |
| *** bpokorny has quit IRC | 01:12 | |
| *** yingjun_ has quit IRC | 01:13 | |
| *** lhcheng has quit IRC | 01:13 | |
| *** alexvictorchan has joined #openstack-horizon | 01:13 | |
| *** jwy has quit IRC | 01:14 | |
| *** jingjing_ren has quit IRC | 01:16 | |
| *** david-lyle has joined #openstack-horizon | 01:20 | |
| *** ChanServ sets mode: +o david-lyle | 01:20 | |
| *** yamamoto has quit IRC | 01:24 | |
| *** yamamoto has joined #openstack-horizon | 01:24 | |
| *** zhenguo has joined #openstack-horizon | 01:38 | |
| *** annashen has joined #openstack-horizon | 01:39 | |
| *** annashen has quit IRC | 01:42 | |
| *** jtriley has joined #openstack-horizon | 01:43 | |
| *** jwy has joined #openstack-horizon | 01:44 | |
| *** jtriley has quit IRC | 01:48 | |
| *** yamamoto has quit IRC | 01:56 | |
| *** darrenc is now known as darrenc_afk | 01:57 | |
| *** harlowja is now known as harlowja_away | 02:03 | |
| *** kiseok7_ has quit IRC | 02:06 | |
| r1chardj0n3s | right, so pyscss <1.3 is broken by mis-ordering imports, but pyscss >1.3 (or possibly django-pyscss >2) is broken in other more bizarre ways :/ | 02:09 |
| *** alexvictorchan has quit IRC | 02:10 | |
| david-lyle | r1chardj0n3s: as far as results? | 02:10 |
| *** nlahouti has quit IRC | 02:11 | |
| r1chardj0n3s | david-lyle: switching to pyscss1.3/django-pyscss2.0 results in broken imports (inability to find files) in ways that I've struggled to fathom, but think I found the "bug" in django-pyscss that causes it... but now I'm getting "SuspiciousFileOperation: Attempted access to '/custom/variables.scss' denied" during compilation :/ | 02:12 |
| david-lyle | SuspiciousFileOperation | 02:13 |
| r1chardj0n3s | yup | 02:13 |
| *** darrenc_afk is now known as darrenc | 02:14 | |
| david-lyle | The joined path is located outside of the base path component | 02:14 |
| david-lyle | maybe | 02:14 |
| r1chardj0n3s | I'm poking at it further, but this code is ... complex ;) | 02:15 |
| david-lyle | the path /custom/variables.scss is wrong | 02:15 |
| david-lyle | maybe | 02:15 |
| david-lyle | not qualified properly | 02:15 |
| david-lyle | I imagine the code to be magnificent | 02:15 |
| david-lyle | don't ruin that illusion | 02:15 |
| r1chardj0n3s | haha, so if I lose the leading "/" in that then scss can't find the file during import scanning. it | 02:16 |
| r1chardj0n3s | it's "later" that it then tries to do something with the file that SuspiciousFileOperation rears its head | 02:17 |
| r1chardj0n3s | why scss, why | 02:17 |
| david-lyle | I was thinking a relative path | 02:18 |
| david-lyle | or "//" in the path somewhee | 02:19 |
| david-lyle | but I'm just repeating google at this point | 02:19 |
| r1chardj0n3s | hmm, ok, so I see how I broke that, but I'm honestly confused as hell how to make this code work. I think I need to read an scss spec or something :/ | 02:19 |
| david-lyle | the horror | 02:20 |
| *** alexvictorchan has joined #openstack-horizon | 02:20 | |
| r1chardj0n3s | I'm going to assume that bootstrap is scss-compliant, and that it's pyscss/django-pyscss that are doing The Wrong Thing | 02:22 |
| r1chardj0n3s | but having said that, either django-pyscss doesn't have any users or none of them are using bootstrap | 02:23 |
| david-lyle | yeah the scss tools for python/django are pretty horrid | 02:23 |
| r1chardj0n3s | OR | 02:23 |
| r1chardj0n3s | horizon / xstatic is broken | 02:23 |
| r1chardj0n3s | ugh | 02:23 |
| david-lyle | we took a bit of a tour to get where we are | 02:23 |
| r1chardj0n3s | yeah | 02:23 |
| david-lyle | some dead ends | 02:23 |
| david-lyle | IIUC the next version of bootstrap will be scss native | 02:23 |
| r1chardj0n3s | I think I'm getting there, but the pathing stuff for django-pyscss is such a rabbit warren | 02:23 |
| david-lyle | xstatic could be broken too | 02:24 |
| david-lyle | all these technologies are now being pushed past their intended purpose I think | 02:25 |
| r1chardj0n3s | like there's this bit in the file finder part of django-pyscss which, when looking for the @imports for bootstrap/scss/bootstrap.scss and it hits "@import bootstrap/variables" it explicitly strips off the "bootstrap/" part of the import, which breaks it | 02:27 |
| r1chardj0n3s | leaving that part *on* though, is what results in the SuspiciousFileOperation for "/custom/variables.scss" which I simply cannot fathom | 02:27 |
| *** yingjun has joined #openstack-horizon | 02:27 | |
| r1chardj0n3s | (also, I suspect that the path stripping stuff means that the top-level variables.scss is being loaded for the "@import /custom/variables" which is quite broken | 02:28 |
| r1chardj0n3s | actually, no, it's not. hmm. that's a lead. | 02:28 |
| david-lyle | loading custom/variables was working when I was playing with theming | 02:29 |
| david-lyle | have to run for a bit | 02:29 |
| r1chardj0n3s | thanks for being my rubber duck :) | 02:29 |
| r1chardj0n3s | (slightly more knowledgable than the duck tho :) | 02:30 |
| david-lyle | well, anytime I can't help, just let me know, I'll come running :D | 02:30 |
| david-lyle | I like to play to my strengths | 02:30 |
| david-lyle | :P | 02:30 |
| r1chardj0n3s | :) | 02:30 |
| david-lyle | ttyl | 02:30 |
| *** david-lyle has quit IRC | 02:30 | |
| *** david-lyle has joined #openstack-horizon | 02:31 | |
| *** ChanServ sets mode: +o david-lyle | 02:31 | |
| *** jbell8 has joined #openstack-horizon | 02:35 | |
| *** david-lyle has quit IRC | 02:36 | |
| *** jwy has quit IRC | 02:38 | |
| *** gyee has quit IRC | 02:53 | |
| *** yingjun has quit IRC | 02:59 | |
| *** alexvictorchan has quit IRC | 03:07 | |
| *** yingjun has joined #openstack-horizon | 03:08 | |
| r1chardj0n3s | TravT: well, I'd like to work on the new menu thing, but https://github.com/fusionbox/django-pyscss/issues/34 :/ | 03:24 |
| r1chardj0n3s | (fixing that then exposes further knock-on issues with our scss) | 03:24 |
| *** alexvictorchan has joined #openstack-horizon | 03:30 | |
| *** david-lyle has joined #openstack-horizon | 03:32 | |
| *** ChanServ sets mode: +o david-lyle | 03:32 | |
| TravT | r1chardj0n3s: bummer. | 03:45 |
| TravT | Does your commit fix that issue? | 03:45 |
| *** kiseok7_ has joined #openstack-horizon | 03:46 | |
| *** yingjun has quit IRC | 04:01 | |
| *** lhcheng has joined #openstack-horizon | 04:05 | |
| r1chardj0n3s | TravT: ohai, sorry, was walking back from cafe | 04:09 |
| TravT | no worries... i'm just debating on whether or not to use a compile or link function in a directive. something one shouldn't do this late at night. | 04:09 |
| *** ybathia has joined #openstack-horizon | 04:10 | |
| r1chardj0n3s | so there's many layers to this problem ;) | 04:11 |
| r1chardj0n3s | that django-pyscss PR fixes that particular path bug in that project, which gets us further | 04:11 |
| r1chardj0n3s | I've hit a bizarre error deep inside pyscss now where it can't deal with the "& + .btn:not(:first-child)" rule in action-list.scss | 04:11 |
| r1chardj0n3s | ... and at the moment I'm trying to find an SCSS reference to even know what that is trying to do (I know what the ampersand is doing, but the "+" I don't know yet | 04:11 |
| r1chardj0n3s | if anyone knows of a good scss reference, I'd love to know, because Google can't find one (!) | 04:11 |
| r1chardj0n3s | srsly, searching for "scss" turns up NOTHING :/ | 04:11 |
| *** ybathia_ has joined #openstack-horizon | 04:11 | |
| *** btully has quit IRC | 04:11 | |
| TravT | hmm... | 04:12 |
| *** ybathia has quit IRC | 04:15 | |
| *** ybathia_ is now known as ybathia | 04:15 | |
| TravT | well, i think kelly or brian wrote that and neither are showing online in our hipchat | 04:15 |
| r1chardj0n3s | um | 04:17 |
| r1chardj0n3s | so I *think* the "+" in "& + .btn:not(:first-child)" is a typo. I cannot find anything that tells me what it might do | 04:17 |
| r1chardj0n3s | removing it makes the scss compile | 04:17 |
| r1chardj0n3s | http://xkcd.com/1513/ | 04:17 |
| r1chardj0n3s | ahh, it's saying parent + child as in adjacent in CSS | 04:17 |
| r1chardj0n3s | yikes | 04:17 |
| r1chardj0n3s | ok, I'm pretty sure the & in that is incorrect | 04:18 |
| r1chardj0n3s | & means combine the selector with the parent | 04:18 |
| TravT | yeah, I'm googling around for that little + as well... | 04:18 |
| r1chardj0n3s | you can't combine *and* be adjacent | 04:19 |
| r1chardj0n3s | so "& +" makes zero sense | 04:19 |
| TravT | it does seem like a somebody used it like a concatenation operator on accident? | 04:19 |
| r1chardj0n3s | I'm gonna look into the use of the style to see what the intent was | 04:19 |
| r1chardj0n3s | + in CSS means adjacent | 04:19 |
| *** stevemar has joined #openstack-horizon | 04:19 | |
| r1chardj0n3s | so "a + button" selects for a button tag adjacent to an anchor tag | 04:20 |
| *** cody-somerville has joined #openstack-horizon | 04:20 | |
| *** rushiagr_away is now known as rushiagr | 04:21 | |
| TravT | i'm not seeing that line in the action-list scss file i have | 04:22 |
| TravT | nvrmind. see it now | 04:22 |
| r1chardj0n3s | oh. hm | 04:24 |
| r1chardj0n3s | I am on master AFAICT | 04:24 |
| r1chardj0n3s | the "& +" combo is used twice in the file | 04:24 |
| r1chardj0n3s | hm | 04:24 |
| TravT | yeah, for that popover | 04:25 |
| TravT | is this the styling for the drop down buttons when you have more than one? | 04:25 |
| r1chardj0n3s | holy cow http://blog.teamtreehouse.com/sass-tip-double-ampersand-selector | 04:26 |
| r1chardj0n3s | "& + &" | 04:26 |
| r1chardj0n3s | yikes | 04:26 |
| r1chardj0n3s | it's for styling the notifications into the action list, IIUC | 04:27 |
| r1chardj0n3s | looking at select-flavor-table.html which uses the action-list/notifications combo | 04:27 |
| r1chardj0n3s | reading that treehouse link, I'm still not sure that "& + .btn:not..." makes sense. I think in this case it would expand to "notifications + .btn:not..." which is what you get if you just leave the "&" out | 04:29 |
| r1chardj0n3s | if I understand scss correctly ;) | 04:29 |
| r1chardj0n3s | I think I'm going to have to just push this patch up and see what kelly says ;) | 04:36 |
| r1chardj0n3s | unfortunately testing the patch is a pain because of the django-pyscss bug | 04:36 |
| r1chardj0n3s | but all of this is necessary if we're going to do the menu stuff (without reimplementing bootstrap) | 04:37 |
| *** neelabh has joined #openstack-horizon | 04:37 | |
| *** btully has joined #openstack-horizon | 04:39 | |
| TravT | btully: you there? | 04:41 |
| btully | hey, yeah what’s up? | 04:41 |
| TravT | r1chardj0n3s: is looking at the action-list scss | 04:42 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Upgrade pyScss to version 1.3.4 https://review.openstack.org/178504 | 04:42 |
| TravT | did you work on that? | 04:42 |
| btully | not sure. checking now | 04:43 |
| btully | is there something broken? | 04:43 |
| r1chardj0n3s | ohai btully | 04:44 |
| r1chardj0n3s | I'm pretty sure this code is kelly's tho | 04:44 |
| r1chardj0n3s | https://review.openstack.org/#/c/178504/ (no idea why there was no IRC notification) | 04:44 |
| r1chardj0n3s | btully: if you're confident in your scss I'd appreciate you looking at that ^^ | 04:44 |
| btully | it looks like Thai and Kelly | 04:44 |
| btully | sure i can take a look | 04:44 |
| r1chardj0n3s | btully: thanks. I'm feeling more and more like it's going to turn out to be a bug in pyscss | 04:44 |
| TravT | r1chardj0n3s: that's what I was just trying out locally. | 04:44 |
| *** sqchen has joined #openstack-horizon | 04:44 | |
| *** rushiagr is now known as rushiagr_away | 04:45 | |
| r1chardj0n3s | so. that ol' ruby toolchain eh? | 04:46 |
| TravT | hey r1chardj0n3s: when I take out that + i get the same result on the flavors tables. | 04:47 |
| r1chardj0n3s | yeah, that's what I saw | 04:48 |
| r1chardj0n3s | I'm pretty sure that rule isn't being used | 04:48 |
| TravT | so, is it going to choke on that popover as well? | 04:48 |
| r1chardj0n3s | no, there's no problem there | 04:49 |
| r1chardj0n3s | it's just when it tries to merge selectors it runs into issue with that one on .btn | 04:49 |
| btully | interestin | 04:51 |
| btully | g | 04:51 |
| btully | it’s valid css, using the adjacent sibling selector | 04:52 |
| r1chardj0n3s | yeah, and it's probably valid scss too - though I'm not convinced the "&" isn't a NOOP in that selector (since the + would be applied to the parent anyway) | 04:53 |
| r1chardj0n3s | but pyscss chokes on a bare "+" as well | 04:55 |
| r1chardj0n3s | hence my feeling that pyscss is broken | 04:55 |
| r1chardj0n3s | but I'm not experienced enough with SCSS to know for sure | 04:55 |
| r1chardj0n3s | I'm working on isolating a test case that exhibits the issue | 04:55 |
| btully | yes i’ve used it in scss before | 04:56 |
| r1chardj0n3s | so the error I get from pyscss is: | 04:56 |
| r1chardj0n3s | ValueError: Don't know how to merge conflicting combinators: <SimpleSelector: u'+ .btn:not(:first-child)'> and <SimpleSelector: u'> .btn'> | 04:56 |
| btully | i’ve used & + & before when laying out columns | 04:56 |
| r1chardj0n3s | with no context | 04:56 |
| r1chardj0n3s | right | 04:57 |
| r1chardj0n3s | hrm | 04:59 |
| r1chardj0n3s | I can't force an error by just compiling action-list.scss with bootstrap imported | 04:59 |
| ongk | r1chardj0n3s: I heard my name | 05:04 |
| r1chardj0n3s | ohai ongk :) | 05:04 |
| r1chardj0n3s | gimme a sec | 05:05 |
| ongk | k | 05:05 |
| r1chardj0n3s | I'm so this is the bane of my existence at the moment https://review.openstack.org/#/c/178504/ | 05:05 |
| r1chardj0n3s | bootstrap is currently broken in horizon, and fixing it is a rabbit hole that just keeps giving | 05:05 |
| r1chardj0n3s | :) | 05:05 |
| r1chardj0n3s | I'm 95% sure that pyscss is broken for the specific thing I hit in action-list.scss, but producing a test case to provide upstream is proving very difficult | 05:06 |
| r1chardj0n3s | I imagine it'd be easier for someone with better scss chops than me :) | 05:06 |
| ongk | haha, I shall take a look | 05:07 |
| r1chardj0n3s | cheers. unfortunately I also found a bug in django-pyscss which needs to be patched before anything else can be done :/ | 05:07 |
| r1chardj0n3s | see aforementioned rabbit hole and how deep it is | 05:07 |
| ongk | Ah, I remember that. The code from line 25-27 is for rounding the button corners for a button group | 05:14 |
| *** yingjun has joined #openstack-horizon | 05:14 | |
| *** yingjun has quit IRC | 05:14 | |
| r1chardj0n3s | ongk: do we actually have a button group in an action list? | 05:15 |
| r1chardj0n3s | even if we don't, it still seems like there's a bug here to file against pyscss | 05:15 |
| ongk | Yeah, you can define 3 actions within the action-list and it will generate a button group | 05:17 |
| r1chardj0n3s | oh sure, in theory it can be done, I'm just not sure we're doing it atm ;) | 05:17 |
| ongk | Oh, ha. not atm | 05:18 |
| btully | yeah, scratching my head. it’s valid scss | 05:18 |
| r1chardj0n3s | and the rule only applies to an action-list with an embedded notification IIUC | 05:18 |
| *** yamamoto has joined #openstack-horizon | 05:18 | |
| btully | also i compiled it using ruby and there were no problems | 05:18 |
| r1chardj0n3s | btully / ongk: if you guys could produce a simplest valid test case to feed back to the pyscss authors, that'd be awesome | 05:18 |
| r1chardj0n3s | btully: how did you compile it with the rubby? lots of include paths? | 05:19 |
| r1chardj0n3s | I started trying to compile it using the pyscss command-line but the -I switches got way out of hand :/ | 05:19 |
| btully | no i just edited out the color variables | 05:19 |
| r1chardj0n3s | oh, the file by itself compiles just fine | 05:19 |
| btully | $brand-danget and $invalid-color | 05:19 |
| r1chardj0n3s | it also compiles if I @import bootstrap | 05:19 |
| r1chardj0n3s | so it's something more complex than that | 05:20 |
| btully | ok i’ll check back in the morning, which at this point is only a few hours away :/ | 05:23 |
| btully | nite nite | 05:23 |
| r1chardj0n3s | oh, yikes | 05:23 |
| r1chardj0n3s | gnight! | 05:23 |
| ongk | r1chardj0n3s: I will also check in tomorrow morning if you haven’t made progress :) | 05:25 |
| r1chardj0n3s | thanks ongk! | 05:25 |
| ongk | np | 05:26 |
| *** pauloefg has quit IRC | 05:27 | |
| *** pauloefg has joined #openstack-horizon | 05:28 | |
| *** jbell8 has quit IRC | 05:32 | |
| *** yamamoto has quit IRC | 05:37 | |
| *** yamamoto has joined #openstack-horizon | 05:40 | |
| *** josecastroleon has joined #openstack-horizon | 05:40 | |
| *** annashen has joined #openstack-horizon | 05:45 | |
| *** stevemar has quit IRC | 05:54 | |
| *** yamamoto has quit IRC | 05:54 | |
| *** mrunge has joined #openstack-horizon | 05:54 | |
| *** yamamoto has joined #openstack-horizon | 05:54 | |
| *** yingjun has joined #openstack-horizon | 05:55 | |
| *** annashen has quit IRC | 05:57 | |
| *** ybathia has quit IRC | 05:58 | |
| *** romainh has joined #openstack-horizon | 06:02 | |
| *** lhcheng has quit IRC | 06:03 | |
| *** Longgeek has joined #openstack-horizon | 06:03 | |
| *** Longgeek has quit IRC | 06:08 | |
| *** yamamoto has quit IRC | 06:08 | |
| *** pcaruana has joined #openstack-horizon | 06:09 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/178517 | 06:17 |
| *** zul has joined #openstack-horizon | 06:17 | |
| *** zul has quit IRC | 06:24 | |
| *** zul has joined #openstack-horizon | 06:25 | |
| *** tnovacik has joined #openstack-horizon | 06:28 | |
| *** rdopiera has joined #openstack-horizon | 06:31 | |
| *** Ala has joined #openstack-horizon | 06:45 | |
| *** jcoufal has joined #openstack-horizon | 06:49 | |
| *** neelabh has quit IRC | 06:51 | |
| *** masco has joined #openstack-horizon | 06:53 | |
| *** Longgeek has joined #openstack-horizon | 06:56 | |
| *** Longgeek has quit IRC | 07:02 | |
| *** Longgeek has joined #openstack-horizon | 07:06 | |
| *** jtriley has joined #openstack-horizon | 07:09 | |
| *** alexvictorchan has quit IRC | 07:10 | |
| *** neelabh has joined #openstack-horizon | 07:11 | |
| *** MaxV has joined #openstack-horizon | 07:13 | |
| *** sqchen has quit IRC | 07:14 | |
| *** sqchen has joined #openstack-horizon | 07:14 | |
| *** jtriley has quit IRC | 07:14 | |
| *** sqchen has quit IRC | 07:15 | |
| *** bfic has joined #openstack-horizon | 07:25 | |
| *** jbell8 has joined #openstack-horizon | 07:26 | |
| *** btully has quit IRC | 07:26 | |
| neelabh | In Juno, horizon/static/horizon/lib/jquery, have only one file "jquery.bootstrap.wizard.js", But in icehouse version we have are lots of files, Why we removed files or move to other directory form juno | 07:28 |
| *** jtomasek has joined #openstack-horizon | 07:28 | |
| neelabh | sorry from juno | 07:28 |
| ccard | doug-fish: LOGIN_REDIRECT_URL is set to /dashboard, but I can't see WEBROOT mentioned anywhere. | 07:30 |
| *** zul has quit IRC | 07:32 | |
| *** zul has joined #openstack-horizon | 07:32 | |
| mrunge | ccard, WEBROOT is a new feature in Kilo | 07:34 |
| mrunge | ccard, and we had WEBROOT for a long time in Red Hat, RDO and Fedora packages | 07:34 |
| mrunge | neelabh, all those javascript libraries were removed, because they were just bundling external dependencies | 07:35 |
| mrunge | neelabh, bundling is just bad by design and will cause more issues than it solves | 07:36 |
| neelabh | <mrunge>, thanks | 07:37 |
| openstackgerrit | Radomir Dopieralski proposed openstack/tuskar-ui: Add python-tuskarclient to the installation docs https://review.openstack.org/178539 | 07:42 |
| *** dguerri is now known as _dguerri | 07:44 | |
| *** _dguerri is now known as dguerri | 07:52 | |
| *** jbell8 has quit IRC | 07:56 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 08:00 | |
| *** zz_ttrifonov is now known as ttrifonov | 08:02 | |
| *** Longgeek has quit IRC | 08:05 | |
| openstackgerrit | Dariusz Smigiel proposed openstack/tuskar-ui: Allow to upload all data from nodes.csv file https://review.openstack.org/168059 | 08:07 |
| *** zul has quit IRC | 08:09 | |
| *** mpavlase has joined #openstack-horizon | 08:09 | |
| *** ttrifonov is now known as zz_ttrifonov | 08:23 | |
| *** zul has joined #openstack-horizon | 08:25 | |
| *** zz_ttrifonov is now known as ttrifonov | 08:25 | |
| *** ttrifonov is now known as zz_ttrifonov | 08:28 | |
| *** robcresswell_afk is now known as robcresswell | 08:29 | |
| *** zz_ttrifonov is now known as ttrifonov | 08:30 | |
| ccard | mrunge: we're using juno, and I've just compared juno/stable with master. WEBROOT isn't in juno/stable. | 08:34 |
| mrunge | ccard, yes, you're right | 08:35 |
| ccard | I'm trying to analyse what happens differently when I have SESSION_ENGINE set to use cache. | 08:35 |
| ccard | With SESSION_ENGINE set to use cache I see this sequence: | 08:35 |
| ccard | POST /dashboard/auth/login -> 302 FOUND Location: /dashboard/admin | 08:36 |
| ccard | GET /dashboard/admin -> 302 FOUND Location: /dashboard/auth/login/?next=/dashboard/admin | 08:36 |
| ccard | GET /dashboard/auth/login/?next=/dashboard/admin -> 200 OK | 08:36 |
| robcresswell | r1chardj0n3s, tqtran: Thanks :) | 08:37 |
| ccard | GET /dashboard/i18n/js/horizon/ | 08:37 |
| ccard | but that's all | 08:37 |
| ccard | with SESSION_ENGINE left to default I see | 08:37 |
| ccard | POST /dashboard/auth/login -> 302 FOUND Location: /dashboard/admin | 08:37 |
| ccard | GET /dashboard/admin -> 200 OK | 08:38 |
| ccard | GET /dashboard/i18n/js/horizon/ | 08:38 |
| ccard | -> 200 OK | 08:39 |
| ccard | GET /static/dashboard/img/logo.png?096dc063a0b0 -> 200 OK | 08:39 |
| ccard | etc. | 08:39 |
| *** yingjun has quit IRC | 08:42 | |
| sambetts | Congrats robcresswell TravT and Doug :) | 08:42 |
| mrunge | ccard, I remember this behavior from a debug session | 08:43 |
| *** yingjun has joined #openstack-horizon | 08:43 | |
| robcresswell | sambetts: Thanks! I think dougs irc is doug-fish | 08:43 |
| ccard | mrunge: any pointers would be useful :) | 08:45 |
| mrunge | that's why I proposed to move the session engine | 08:45 |
| mrunge | even temporarily | 08:45 |
| *** JeanBriceCombebi has quit IRC | 08:47 | |
| *** ttrifonov is now known as zz_ttrifonov | 08:47 | |
| mrunge | ccard, https://docs.djangoproject.com/en/1.8/topics/http/sessions/ | 08:47 |
| mrunge | ccard, and configure a database backed session engine | 08:47 |
| ccard | mrunge: I can give that a try, but as far as I can tell memcached is working fine and storing the session info. | 08:49 |
| *** zz_ttrifonov is now known as ttrifonov | 08:50 | |
| mrunge | ccard, yes, sure. that was, what I saw as well | 08:50 |
| mrunge | ccard, good luck anyways | 08:50 |
| *** ttrifonov is now known as zz_ttrifonov | 08:51 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 08:52 | |
| *** zz_ttrifonov is now known as ttrifonov | 08:54 | |
| *** bfic has quit IRC | 08:54 | |
| *** annashen has joined #openstack-horizon | 08:57 | |
| *** jtriley has joined #openstack-horizon | 08:58 | |
| *** JeanBriceCombebi has quit IRC | 09:01 | |
| *** annashen has quit IRC | 09:02 | |
| *** jtriley has quit IRC | 09:02 | |
| *** bfic has joined #openstack-horizon | 09:04 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:04 | |
| *** bfic has quit IRC | 09:04 | |
| *** e0ne has joined #openstack-horizon | 09:06 | |
| *** Longgeek has joined #openstack-horizon | 09:06 | |
| *** unixlike has joined #openstack-horizon | 09:06 | |
| *** e0ne is now known as e0ne_ | 09:06 | |
| unixlike | Hi there ! | 09:06 |
| unixlike | I coming back to ask next stupid question ) | 09:07 |
| unixlike | Is it possible to show two vaious tables on same panel ? | 09:07 |
| robcresswell | unixlike: Yup. Look at the current Network Details :) | 09:08 |
| robcresswell | unixlike: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/networks/templates/networks/detail.html | 09:09 |
| unixlike | robcresswell: Thanks for quick response ! it is what i mean . | 09:10 |
| ccard | mrunge: thanks. Any pointers on how to debug this? I've tried dumping tracebacks from the horizon code, but the top of the stack is in wsgi.py | 09:11 |
| *** Longgeek has quit IRC | 09:12 | |
| *** Longgeek has joined #openstack-horizon | 09:13 | |
| *** yingjun has quit IRC | 09:13 | |
| *** yingjun_ has joined #openstack-horizon | 09:13 | |
| *** MaxV has quit IRC | 09:13 | |
| *** e0ne_ is now known as e0ne | 09:14 | |
| *** JeanBriceCombebi has quit IRC | 09:15 | |
| *** MaxV has joined #openstack-horizon | 09:16 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:18 | |
| unixlike | ccard: did you try to run dashboard with python manage.py runserver | 09:22 |
| unixlike | ? | 09:22 |
| ccard | unixlike: no, at the moment everything is run by pacemaker (it's an HA setup) | 09:25 |
| unixlike | ccard: also i think you should run this command as web-server user to keep file privileges as is | 09:25 |
| ccard | unixlike: and it's running under apache wsgi | 09:26 |
| unixlike | ccard: As i understand you have some problem with dashboard and cant debug this ? | 09:27 |
| *** zul has quit IRC | 09:27 | |
| unixlike | ccard: sorry for my english ) | 09:27 |
| *** bluex-pl has joined #openstack-horizon | 09:28 | |
| *** tnovacik has quit IRC | 09:31 | |
| ccard | unixlike: I'm not familiar with django or wsgi really, so I'm not sure *how* to debug it | 09:31 |
| *** JeanBriceCombebi has quit IRC | 09:32 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:32 | |
| *** josecastroleon has quit IRC | 09:33 | |
| *** krykowski has joined #openstack-horizon | 09:35 | |
| *** yingjun_ has quit IRC | 09:35 | |
| *** akrivoka has joined #openstack-horizon | 09:40 | |
| *** JeanBriceCombebi has quit IRC | 09:41 | |
| *** akrivoka has quit IRC | 09:41 | |
| *** akrivoka has joined #openstack-horizon | 09:41 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:44 | |
| unixlike | ccard: as i said before you should find file settings.py or local_settings.py and set variable DEBUG to True , then you should run django webserver : python manage.py runserver . This command runs server on http://127.0.0.1:8000/ | 09:45 |
| mrunge | ccard, my first try would be to change session engine to something database backed | 09:46 |
| mrunge | and see what happens | 09:46 |
| mrunge | if that doesn't solve your issue, it's not session related or cockie size related | 09:47 |
| unixlike | before doing this you should add /bin/bash as shell for user apache or httpd and switch to this user | 09:47 |
| mrunge | unixlike, seriously? | 09:48 |
| mrunge | unixlike, it works well when using a different user for this | 09:48 |
| rdopiera | how would I go about getting currently logged in user's e-mail address? | 09:49 |
| *** oro has joined #openstack-horizon | 09:49 | |
| mrunge | rdopiera, identity panel, users tab | 09:50 |
| mrunge | email address is actually an attribute of user | 09:50 |
| mrunge | rdopiera, but we removed the requirement to have an email address | 09:50 |
| *** sayan has joined #openstack-horizon | 09:50 | |
| mrunge | you can have a user without a (valid) email address | 09:51 |
| *** zul has joined #openstack-horizon | 09:51 | |
| unixlike | mrunge: I think if you run python manage.py runserver it changes permissions to pyc files | 09:51 |
| mrunge | unixlike, hmm. if there were changes on .py files, the interpreter would try to update/recreate .pyc files | 09:52 |
| mrunge | but in general, there is no need to have write access there | 09:53 |
| mrunge | esp. one doesn't have write access to /usr/share/python2.7/site-packages... | 09:53 |
| ccard | unixlike: DEBUG is already set. I naively tried running python manage.py runserver, but it needs something to tell it where to find my local_settings file. Environment variable? | 09:55 |
| unixlike | mrunge: i think if you create pyc file as root user, then apache user can't modify it | 09:55 |
| rdopiera | mrunge: I mean in the code, would just request.user.email work? | 09:55 |
| rdopiera | mrunge: or do I need to get the user object from keystone? | 09:55 |
| mrunge | rdopiera, I didn't try any of those | 09:56 |
| rdopiera | mrunge: in the latter case, which id on request.user is the right id to use for that? | 09:56 |
| mrunge | rdopiera, that should be transferred from keystone during log in | 09:56 |
| neelabh | As table view(_data_table.html in horizon/templates/horizon/common), I want to add one more view grid view, Please tell me I have to add extra-file or in the same file | 09:56 |
| mrunge | users are created by template from keystone | 09:56 |
| mrunge | rdopiera, something like request.user.email should be it | 09:57 |
| unixlike | neelabh: you can find tutor in horizon directory | 09:57 |
| unixlike | just run: find /horion_directory | grep -i tutor | 09:58 |
| *** akrivoka has quit IRC | 09:58 | |
| neelabh | sorry, but I am customize the | 09:58 |
| neelabh | horizon, I am new to open-stack | 09:58 |
| neelabh | there is very less documentation | 09:59 |
| rdopiera | mrunge: great, thank you | 09:59 |
| openstackgerrit | Radomir Dopieralski proposed openstack/tuskar-ui: Use current user's e-mail address as default in post-init https://review.openstack.org/178587 | 10:01 |
| *** bfic has joined #openstack-horizon | 10:02 | |
| *** bfic has quit IRC | 10:02 | |
| *** e0ne is now known as e0ne_ | 10:03 | |
| unixlike | ccard: Please try to open your horizon dashboard url with incorrect ending . as example http:1.1.1.1/dashboard/fnvdjfvdnf | 10:03 |
| unixlike | ccard: Do you see debug page ? | 10:03 |
| *** e0ne_ is now known as e0ne | 10:05 | |
| *** tnovacik has joined #openstack-horizon | 10:10 | |
| *** akrivoka has joined #openstack-horizon | 10:10 | |
| ccard | unixlike: yes | 10:13 |
| unixlike | ccard: seems that debug already enabled . I think that you find all available log under directory /var/log/http or /var/log/apache . and i recommend you to turn off DEBUG after solving your issue | 10:15 |
| ccard | unixlike: there is nothing useful that I can see in the logs | 10:18 |
| *** zul has quit IRC | 10:19 | |
| *** akrivoka has quit IRC | 10:20 | |
| *** akrivoka has joined #openstack-horizon | 10:25 | |
| openstackgerrit | Bradley Jones proposed openstack/horizon: Replace pie chart with number for unlimited quotas https://review.openstack.org/168335 | 10:36 |
| *** _crobertsrh has quit IRC | 10:41 | |
| *** jtriley has joined #openstack-horizon | 10:47 | |
| *** jtriley has quit IRC | 10:51 | |
| *** bfic has joined #openstack-horizon | 10:56 | |
| *** bfic has quit IRC | 10:57 | |
| *** bfic has joined #openstack-horizon | 10:58 | |
| *** krykowski has quit IRC | 11:03 | |
| *** krykowski_ has joined #openstack-horizon | 11:04 | |
| *** JeanBriceCombebi has quit IRC | 11:21 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/tuskar-ui: Use newer django https://review.openstack.org/178619 | 11:22 |
| *** doug-fish has joined #openstack-horizon | 11:22 | |
| *** bluex-pl has quit IRC | 11:28 | |
| *** bluex-pl has joined #openstack-horizon | 11:29 | |
| *** e0ne is now known as e0ne_ | 11:30 | |
| *** aix has joined #openstack-horizon | 11:35 | |
| *** sayan has quit IRC | 11:37 | |
| *** krykowski_ has quit IRC | 11:38 | |
| *** bfic has quit IRC | 11:40 | |
| *** crobertsrh has joined #openstack-horizon | 11:41 | |
| *** krykowski has joined #openstack-horizon | 11:45 | |
| *** zul has joined #openstack-horizon | 11:53 | |
| *** bfic has joined #openstack-horizon | 12:01 | |
| david-lyle | Meeting starting in #openstack-meeting-3 for those interested | 12:02 |
| openstackgerrit | Radomir Dopieralski proposed openstack/tuskar-ui: Fix tests failing under django 1.8 https://review.openstack.org/178637 | 12:02 |
| *** krykowski has quit IRC | 12:03 | |
| *** bluex-pl has quit IRC | 12:03 | |
| *** krykowski has joined #openstack-horizon | 12:03 | |
| *** raildo has joined #openstack-horizon | 12:03 | |
| *** bluex-pl has joined #openstack-horizon | 12:04 | |
| *** sayan has joined #openstack-horizon | 12:05 | |
| *** sayan has quit IRC | 12:05 | |
| *** sayan has joined #openstack-horizon | 12:06 | |
| *** openstackgerrit has quit IRC | 12:07 | |
| *** openstackgerrit has joined #openstack-horizon | 12:07 | |
| openstackgerrit | Merged openstack/tuskar-ui: Add python-tuskarclient to the installation docs https://review.openstack.org/178539 | 12:08 |
| *** krykowski has quit IRC | 12:08 | |
| *** bluex-pl has quit IRC | 12:09 | |
| *** mpavlase has quit IRC | 12:15 | |
| *** mpavlase has joined #openstack-horizon | 12:16 | |
| *** Ephur has joined #openstack-horizon | 12:20 | |
| openstackgerrit | Merged openstack/tuskar-ui: Use newer django https://review.openstack.org/178619 | 12:22 |
| *** bfic has quit IRC | 12:26 | |
| *** e0ne_ is now known as e0ne | 12:26 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 12:30 | |
| *** jtriley has joined #openstack-horizon | 12:35 | |
| *** jtriley has quit IRC | 12:40 | |
| *** EmilienM is now known as EmilienM|afk | 12:41 | |
| *** sayan has quit IRC | 12:41 | |
| *** lifeless has quit IRC | 12:43 | |
| *** chlong has joined #openstack-horizon | 12:44 | |
| *** MaxV has quit IRC | 12:44 | |
| *** krykowski has joined #openstack-horizon | 12:45 | |
| *** masco has quit IRC | 12:45 | |
| *** neelashah has joined #openstack-horizon | 12:49 | |
| *** MaxV has joined #openstack-horizon | 12:50 | |
| *** bluex-pl has joined #openstack-horizon | 12:52 | |
| *** krykowski has quit IRC | 12:52 | |
| *** e0ne is now known as e0ne_ | 12:54 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Get unit tests working with Karma https://review.openstack.org/168152 | 12:56 |
| *** asahlin_afk is now known as asahlin | 12:56 | |
| *** bfic has joined #openstack-horizon | 12:59 | |
| *** lblanchard has joined #openstack-horizon | 13:00 | |
| *** bluex-pl has quit IRC | 13:01 | |
| *** ir2ivps10 has quit IRC | 13:01 | |
| *** bluex-pl has joined #openstack-horizon | 13:02 | |
| *** julim has joined #openstack-horizon | 13:05 | |
| *** krykowski has joined #openstack-horizon | 13:06 | |
| *** e0ne_ is now known as e0ne | 13:06 | |
| *** julim has quit IRC | 13:06 | |
| *** radez_g0n3 is now known as radez | 13:08 | |
| *** ZZelle has quit IRC | 13:08 | |
| *** julim has joined #openstack-horizon | 13:08 | |
| *** ZZelle has joined #openstack-horizon | 13:09 | |
| *** neelabh has quit IRC | 13:12 | |
| *** Madkiss has quit IRC | 13:13 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Add Angular service to provide translation https://review.openstack.org/175976 | 13:18 |
| *** julim has quit IRC | 13:18 | |
| *** mwhagedorn has joined #openstack-horizon | 13:21 | |
| *** matt-borland has joined #openstack-horizon | 13:21 | |
| *** mattfarina has joined #openstack-horizon | 13:23 | |
| *** mattfarina has quit IRC | 13:24 | |
| *** btully has joined #openstack-horizon | 13:24 | |
| *** peristeri has joined #openstack-horizon | 13:25 | |
| *** vhoward has joined #openstack-horizon | 13:26 | |
| *** btully has quit IRC | 13:28 | |
| *** ir2ivps10 has joined #openstack-horizon | 13:33 | |
| *** jtriley has joined #openstack-horizon | 13:34 | |
| *** EmilienM|afk is now known as EmilienM | 13:37 | |
| *** e0ne is now known as e0ne_ | 13:38 | |
| *** lifeless has joined #openstack-horizon | 13:38 | |
| *** e0ne_ is now known as e0ne | 13:39 | |
| *** MaxV has quit IRC | 13:39 | |
| *** josecastroleon has joined #openstack-horizon | 13:39 | |
| *** iamjarvo has joined #openstack-horizon | 13:55 | |
| *** iamjarvo has quit IRC | 13:56 | |
| *** iamjarvo has joined #openstack-horizon | 13:57 | |
| *** iamjarvo has quit IRC | 13:57 | |
| *** iamjarvo has joined #openstack-horizon | 13:57 | |
| *** iamjarvo has quit IRC | 13:58 | |
| *** iamjarvo has joined #openstack-horizon | 13:58 | |
| *** iamjarvo has quit IRC | 13:58 | |
| *** iamjarvo has joined #openstack-horizon | 13:59 | |
| *** iamjarvo has quit IRC | 13:59 | |
| *** iamjarvo has joined #openstack-horizon | 14:00 | |
| *** rushiagr_away has quit IRC | 14:05 | |
| *** alexpilotti has joined #openstack-horizon | 14:05 | |
| -openstackstatus- NOTICE: gerrit has been restarted to clear a stuck events queue. any change events between 13:29-14:05 utc should be rechecked or have their approval votes reapplied to trigger jobs | 14:05 | |
| *** bfic has quit IRC | 14:06 | |
| ccard | mrunge: I've made some progress: the problem appears to be an exception in get_user() in openstack_auth/utils.py, which (as I discovered eventually after lots of digging) is monkey-patching auth.get_user(). | 14:07 |
| *** btully has joined #openstack-horizon | 14:08 | |
| *** ericpeterson has joined #openstack-horizon | 14:08 | |
| *** cbits has joined #openstack-horizon | 14:08 | |
| *** cbits has left #openstack-horizon | 14:09 | |
| mrunge | ccard, strange | 14:09 |
| ccard | on this line: | 14:10 |
| ccard | user_id = request.session[auth.SESSION_KEY] | 14:10 |
| mrunge | ccard, did you stick in a different session store? | 14:10 |
| mrunge | such as database backed sessions? | 14:10 |
| ccard | no, this is still the caching session engine | 14:10 |
| mrunge | you should give it a try | 14:11 |
| ccard | I wanted to find out where it was failing | 14:11 |
| mrunge | if I understand this right, your session data gets too long and the rest is truncated | 14:11 |
| mrunge | basically anything could happen then | 14:11 |
| mrunge | we're fighting with that for a longer time now | 14:12 |
| mrunge | it works in many cases, until it stops ;-) | 14:12 |
| ccard | the code is here: http://pastebin.com/XbCJK6J0 | 14:12 |
| mrunge | so, in your case request.session[auth.SESSION_KEY] fails? | 14:13 |
| *** jprovazn has joined #openstack-horizon | 14:13 | |
| ccard | yes. My debug is saying: | 14:14 |
| ccard | request.session = <django.contrib.sessions.backends.cache.SessionStore object at 0x7ffd731942d0>, auth.SESSION_KEY = _auth_user_id | 14:14 |
| ccard | I'm not sure if that code will ever work with a SessionStore object, but I'm still investigating | 14:15 |
| *** rushiagr_away has joined #openstack-horizon | 14:16 | |
| mrunge | good luck | 14:16 |
| *** zhenguo has quit IRC | 14:17 | |
| *** drupalmonkey has joined #openstack-horizon | 14:17 | |
| rdopiera | mrunge: seems like django was swallowing up some exceptions in our tests, and 1.8 does not anymore, so they started failing visibly (they always failed, just django lied to us) | 14:21 |
| *** jtriley has quit IRC | 14:23 | |
| zigo | When running unit tests of Horizon (when building Horizon Kilo RC2 in Sid), I get: "optparse.OptionConflictError: option --no-color: conflicting option string(s): --no-color" | 14:28 |
| zigo | Any idea why? | 14:29 |
| zigo | mrunge: ^ | 14:29 |
| zigo | rdopiera: ^ | 14:29 |
| *** julim has joined #openstack-horizon | 14:31 | |
| *** JeanBriceCombebi has quit IRC | 14:37 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Angular API Unit Tests https://review.openstack.org/178227 | 14:37 |
| openstackgerrit | Merged openstack/tuskar-ui: Allow to upload all data from nodes.csv file https://review.openstack.org/168059 | 14:38 |
| *** jprovazn has quit IRC | 14:39 | |
| *** vijendar has joined #openstack-horizon | 14:42 | |
| *** sseago has left #openstack-horizon | 14:48 | |
| *** alexpilotti has quit IRC | 14:49 | |
| *** katyafervent is now known as katyafervent_awa | 14:52 | |
| *** katyafervent_awa is now known as katyafervent | 14:55 | |
| *** cody-somerville has quit IRC | 14:58 | |
| *** jtriley has joined #openstack-horizon | 14:58 | |
| *** packet has joined #openstack-horizon | 15:02 | |
| *** peristeri has quit IRC | 15:04 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Angular API Unit Tests https://review.openstack.org/178227 | 15:08 |
| *** alexpilotti has joined #openstack-horizon | 15:11 | |
| openstackgerrit | Matthew D. Wood proposed openstack/horizon: Adding tests for button-tooltip.js https://review.openstack.org/178434 | 15:12 |
| openstackgerrit | Matthew D. Wood proposed openstack/horizon: Adding tests for button-tooltip.js https://review.openstack.org/178434 | 15:12 |
| *** sqchen has joined #openstack-horizon | 15:14 | |
| *** jbell8 has joined #openstack-horizon | 15:18 | |
| *** bpokorny has joined #openstack-horizon | 15:25 | |
| *** cody-somerville has joined #openstack-horizon | 15:31 | |
| *** cody-somerville has quit IRC | 15:31 | |
| *** cody-somerville has joined #openstack-horizon | 15:31 | |
| *** sqchen has quit IRC | 15:32 | |
| *** peristeri has joined #openstack-horizon | 15:33 | |
| *** iamjarvo has quit IRC | 15:36 | |
| openstackgerrit | Derek Higgins proposed openstack/tuskar-ui: Fix typo in "Voltage" https://review.openstack.org/178740 | 15:39 |
| *** jmolo has joined #openstack-horizon | 15:42 | |
| *** stevemar has joined #openstack-horizon | 15:42 | |
| *** julim has quit IRC | 15:43 | |
| *** Piet has joined #openstack-horizon | 15:44 | |
| *** mhorban has quit IRC | 15:45 | |
| *** jcoufal has quit IRC | 15:45 | |
| *** rushiagr_away is now known as rushiagr | 15:46 | |
| *** ttrifonov is now known as zz_ttrifonov | 15:52 | |
| ccard | mrunge: I believe I know what the problem is now: memcached and HA openstack don't mix very well :( | 15:53 |
| *** nlahouti has joined #openstack-horizon | 15:53 | |
| ccard | so a db backend is probably the way to go, but I don't see anything in quickstack puppet files to help set it up | 15:53 |
| *** alexvictorchan has joined #openstack-horizon | 15:55 | |
| *** Sukhdev has joined #openstack-horizon | 15:55 | |
| *** lblanchard has quit IRC | 15:57 | |
| *** robcresswell is now known as robcresswell_afk | 16:05 | |
| *** Ala has quit IRC | 16:09 | |
| *** jtomasek has quit IRC | 16:10 | |
| *** Drago has joined #openstack-horizon | 16:10 | |
| *** Drago has left #openstack-horizon | 16:11 | |
| *** zul has quit IRC | 16:15 | |
| *** julim has joined #openstack-horizon | 16:17 | |
| *** oro has quit IRC | 16:17 | |
| *** josecastroleon has quit IRC | 16:17 | |
| *** chlong has quit IRC | 16:19 | |
| *** alexpilotti has quit IRC | 16:20 | |
| *** dscottsf has joined #openstack-horizon | 16:21 | |
| *** pcaruana has quit IRC | 16:22 | |
| *** tqtran has joined #openstack-horizon | 16:23 | |
| *** akrivoka has quit IRC | 16:24 | |
| *** gyee has joined #openstack-horizon | 16:25 | |
| rdopiera | zigo: that's strange | 16:27 |
| *** dscottsf has quit IRC | 16:27 | |
| rdopiera | zigo: I have to run :( | 16:27 |
| *** rdopiera has quit IRC | 16:27 | |
| TravT | mrunge: what is it that you guys use for video conferencing? | 16:27 |
| TravT | also, did vidyo work for you previously? | 16:28 |
| TravT | I'm still wanting to find a video conferencing tool that works for everybody without small limits. | 16:28 |
| *** btully has quit IRC | 16:28 | |
| *** lblanchard has joined #openstack-horizon | 16:31 | |
| *** mattfarina has joined #openstack-horizon | 16:34 | |
| *** mattfarina has quit IRC | 16:34 | |
| openstackgerrit | Merged openstack/tuskar-ui: Fix tests failing under django 1.8 https://review.openstack.org/178637 | 16:38 |
| *** lblanchard has quit IRC | 16:41 | |
| *** mpavlase has quit IRC | 16:41 | |
| *** jtriley has quit IRC | 16:43 | |
| tqtran | TravT: any news from JohnPapa? | 16:49 |
| tqtran | I have to say, after reading this post, now I understand where Sean is coming from | 16:49 |
| TravT | Hey tqtran: | 16:50 |
| TravT | no, his "email submission form" explicitly states he tries to respond to most email, but is usually delayed | 16:50 |
| *** jingjing_ren has joined #openstack-horizon | 16:51 | |
| TravT | I've been thinking a lot about the john papa style guide (why I put the mention on your patch). It is based on a lot of feedback from the angular community. | 16:53 |
| TravT | And is referencable. | 16:53 |
| tqtran | yeah, it should also help the review process too, now that there is a guideline to point to | 16:54 |
| TravT | We don't have to follow everything in it, but at least it is already providing some concrete guidance. | 16:54 |
| TravT | We can also influence it. | 16:54 |
| tqtran | yeah for sure, as we start using it, we can start making recommendations | 16:55 |
| tqtran | would be great if there is a way to enforce them like how pep8 is doing it for python | 16:55 |
| TravT | yeah, i'm hoping he response saying there is some tool or maybe he's get some code style templates we can use | 16:56 |
| *** romainh has left #openstack-horizon | 16:56 | |
| TravT | but, i'd be a little surprised. | 16:56 |
| tqtran | https://github.com/jscs-dev/node-jscs | 16:57 |
| tqtran | we might be able to use something like this if he comes back and says no | 16:57 |
| TravT | matt already started down this track: | 16:58 |
| TravT | https://review.openstack.org/#/c/170204/ | 16:58 |
| tqtran | oh cool, didnt see that | 16:59 |
| *** btully has joined #openstack-horizon | 16:59 | |
| *** sqchen has joined #openstack-horizon | 16:59 | |
| matt-borland | hello :) | 16:59 |
| matt-borland | I started a basic patch for JSCS, with only one example config. | 17:00 |
| matt-borland | trailingWhitespace :) | 17:00 |
| TravT | gotta start somewhere | 17:00 |
| matt-borland | I also looked through the list of code styles and came up with a short list of things we might be interested in. | 17:00 |
| TravT | https://github.com/johnpapa/angular-jscs | 17:00 |
| matt-borland | interesting! | 17:00 |
| TravT | looks like john papa wants to provide it... | 17:01 |
| tqtran | oh nice, maybe we can just scrap his jscs config and use | 17:01 |
| TravT | but he hasn't done much | 17:01 |
| tqtran | jk, looks like its blank lol | 17:01 |
| tqtran | ok we can help him populate it hahaha | 17:01 |
| matt-borland | :) | 17:02 |
| TravT | looks like there's plenty to choose from: | 17:03 |
| TravT | https://www.linkedin.com/groupItem?commentID=-1&item=5945483989950226433&type=member&gid=5010991&view=&readyComment=true#lastComment | 17:03 |
| TravT | we had some consultants recommend john papa | 17:04 |
| asahlin | TravT: I commented in the user table review as well, but thanks for posting the link to john papa's style guide. | 17:06 |
| *** jingjing_ren has quit IRC | 17:07 | |
| TravT | asahlin: cool, i'll take a look | 17:07 |
| *** bpokorny has quit IRC | 17:08 | |
| *** jingjing_ren has joined #openstack-horizon | 17:08 | |
| *** bpokorny has joined #openstack-horizon | 17:09 | |
| TravT | tqtran: google and angularjs specifically recomends john papa | 17:10 |
| TravT | http://angularjs.blogspot.com/2014/02/an-angularjs-style-guide-and-best.html | 17:10 |
| *** aix has quit IRC | 17:10 | |
| tqtran | yeah just did a google search, looks like him and todd motto are the drivers | 17:12 |
| TravT | guess i could try to email todd motto too | 17:13 |
| *** neelashah has quit IRC | 17:16 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Get unit tests working with Karma https://review.openstack.org/168152 | 17:17 |
| *** dguerri is now known as _dguerri | 17:18 | |
| *** _dguerri is now known as dguerri | 17:18 | |
| matt-borland | tqtran: TravT: FYI I updated the i18n patch to include Thai's notes from yesterday. In addition, I expect to follow onto this patch with adding 'interpolate' | 17:18 |
| openstackgerrit | Matthew D. Wood proposed openstack/horizon: Adding tests for button-tooltip.js https://review.openstack.org/178434 | 17:19 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Get unit tests working with Karma https://review.openstack.org/168152 | 17:21 |
| TravT | tqtran: maybe we could just copy that node-jscs, remove anything not in johnpapa;s guide, and issue a pull request to johnpapa. | 17:22 |
| tqtran | we can | 17:23 |
| tqtran | though i'm not even sure what is in node-jscs | 17:24 |
| TravT | me neither | 17:24 |
| TravT | should I go ahead and add the link to the style guide on the wiki? right now, i only have it on the etherpad I sent out to the ML. | 17:25 |
| *** bluex-pl has quit IRC | 17:25 | |
| TravT | or should we take up a formal vote? | 17:25 |
| asahlin | I'd say at it to the wiki now, ask for forgiveness later ;-) | 17:26 |
| tqtran | formal vote, right now its just a small group of folks deciding, would be good to ask for other's inputs as well | 17:26 |
| tqtran | asahlin: lol nicely put | 17:26 |
| asahlin | could just put up a patch to the .rst, and 'vote' that way | 17:27 |
| TravT | How about I'll add it and note that it is up for discussion. | 17:27 |
| tqtran | fine with me | 17:27 |
| tqtran | fine by me? or fine with me? | 17:27 |
| TravT | that's a good idea.... but what about this page: | 17:27 |
| TravT | https://wiki.openstack.org/wiki/Horizon/Javascript | 17:27 |
| tqtran | will probably need updating to have a much bigger angular section | 17:28 |
| TravT | yes, but also referencing the style guide may make that not quite so big | 17:28 |
| asahlin | If it were me, I would do what you said "update and add a note". Then based on patch review update accordingly | 17:29 |
| TravT | Okay, I'm going to put up a note on the wiki about it. | 17:29 |
| TravT | And I'll put up an RST patch | 17:29 |
| TravT | good ideas, aaron. | 17:29 |
| asahlin | cool | 17:29 |
| *** iamjarvo has joined #openstack-horizon | 17:30 | |
| *** iamjarvo has quit IRC | 17:30 | |
| *** iamjarvo has joined #openstack-horizon | 17:31 | |
| *** iamjarvo has quit IRC | 17:31 | |
| *** iamjarvo has joined #openstack-horizon | 17:31 | |
| *** iamjarvo has quit IRC | 17:32 | |
| *** lhcheng has joined #openstack-horizon | 17:32 | |
| *** iamjarvo has joined #openstack-horizon | 17:32 | |
| tqtran | asahlin: +1 | 17:33 |
| *** neelashah has joined #openstack-horizon | 17:33 | |
| *** neelashah1 has joined #openstack-horizon | 17:34 | |
| tqtran | matt-borland: so just wanted to understand the reasons for moving to karma better. is it solely a developer tool? and what advantage does it provide over the jasmine spec runner? | 17:35 |
| matt-borland | sure, | 17:35 |
| tqtran | my understanding of karma is limited | 17:35 |
| tqtran | just wanted to pick your brain and learn more | 17:35 |
| matt-borland | first off, it's slightly more meta- than Jasmine. | 17:35 |
| matt-borland | it can run various types of tests (Jasmine, qunit) and can attach various types of plugins to its process. | 17:36 |
| matt-borland | so, for example, you can easily plug in code coverage. | 17:36 |
| matt-borland | and other other reporters, such as junit output | 17:36 |
| matt-borland | so when I do an 'npm test' or 'npm run test' in this environment, I can not only get console-level info, I can also get all those reporters run | 17:37 |
| *** neelashah has quit IRC | 17:37 | |
| matt-borland | on the dev side, this is useful to have a one-stop shop for all those needs | 17:38 |
| matt-borland | same thing on the gate | 17:38 |
| matt-borland | it's also a little smarter about fileglobbing and determining what to do with input files. | 17:38 |
| tqtran | so you can choose to run karma once? or is it a background process? | 17:39 |
| matt-borland | You can do it both ways | 17:39 |
| matt-borland | or within an IDE | 17:39 |
| tqtran | i see | 17:39 |
| matt-borland | right now the default behavior through npm is to run-single | 17:39 |
| matt-borland | although if you call karma more directly, it will watch for files and rerun tests when changed. | 17:39 |
| tqtran | and im assuming the gate is similarly running jshint the same way? | 17:40 |
| matt-borland | It also notifies you of JS errors, unlike Jasmine's runner | 17:40 |
| matt-borland | I think so | 17:40 |
| matt-borland | I think the idea is to have 'npm run test' and 'npm lint' or whatever the command is, to further loosen dependencies on the specific mechanism | 17:41 |
| tqtran | I think the jasmine runner does tell you the js errors | 17:42 |
| tqtran | and which line failed | 17:42 |
| matt-borland | In my experience, it doesn't | 17:42 |
| tqtran | then you can debug it via the chrome inspector as well | 17:42 |
| matt-borland | the web browser just doesn't process the js that fails | 17:42 |
| matt-borland | e.g. when running the localhost/jasmine web tests (Jasmine) | 17:43 |
| tqtran | right, when i run localhost/jasmine, i can put in breakpoints and debug | 17:43 |
| tqtran | and the spec runner does tell me where it fails | 17:43 |
| matt-borland | gotcha | 17:44 |
| tqtran | or sometimes it will fail silently, but the console will output errors | 17:44 |
| matt-borland | yeah. | 17:44 |
| tqtran | so far, that has worked for me, which is why i didnt see a strong need for karma. | 17:45 |
| matt-borland | ah | 17:45 |
| tqtran | and the reason why i need more convincing haha. | 17:45 |
| matt-borland | :) | 17:45 |
| *** rlrevell has joined #openstack-horizon | 17:45 | |
| rlrevell | hi | 17:46 |
| matt-borland | just ask most of us on the team, you'll probably get other reasons | 17:46 |
| matt-borland | coverage is huge | 17:46 |
| matt-borland | pluggability is nice | 17:46 |
| tqtran | i'm not against it, but if we have something that works decently, why the move to karma? | 17:46 |
| tqtran | yes that part is nice | 17:46 |
| rlrevell | was the login form changed to autocomplete=off by horizon devs or is this something ubuntu changed? | 17:46 |
| matt-borland | I don't really like that we have to treat the web page result as a single pass/fail in selenium | 17:46 |
| matt-borland | (in Jasmine) | 17:46 |
| matt-borland | it's really kind of wonky in my view. Having it all run separately is nice. | 17:47 |
| tqtran | matt-borland: thats true, but that is a limitation of selenium (or at least our implementation of it). | 17:47 |
| *** woodm1979 has joined #openstack-horizon | 17:47 | |
| *** iamjarvo has quit IRC | 17:48 | |
| matt-borland | yeah. | 17:48 |
| matt-borland | I think overall, having a good meta-framework that is simple to configure and has lots of flexible options is better than a single test runner | 17:48 |
| tqtran | i'll look into karma some more and think on it | 17:50 |
| matt-borland | I can't speak enough to the coverage feature :) | 17:50 |
| matt-borland | coverage reports are located in the .coverage-karma dirs. Very useful in the work we've done the last 2 weeks. | 17:52 |
| woodm1979 | tqtran: we haven't done the config work yet, but you can add your coverage reports as junit format. Then they can be mixed with our python code-coverage reports and we can get an actual sense of what's being covered, or include the metric in the gate job or whatever at a later date. Also, the click-able coverage report is just gold. | 17:55 |
| *** Sukhdev has quit IRC | 17:55 | |
| *** iamjarvo has joined #openstack-horizon | 17:55 | |
| *** iamjarvo has quit IRC | 17:55 | |
| tqtran | woodm1979, matt-borland: ok, I have to play around with it some more to get a better sense | 17:56 |
| matt-borland | sounds good, just let us know if you have any questions! | 17:56 |
| *** iamjarvo has joined #openstack-horizon | 17:56 | |
| tqtran | ok will do | 17:56 |
| woodm1979 | :-) | 17:56 |
| woodm1979 | I see pretty green lines! and ugly red ones too. Red make woodm1979 angry! | 17:57 |
| matt-borland | woodm1979: I will accept nothing less than 100%, or more! | 17:57 |
| *** e0ne has quit IRC | 17:57 | |
| woodm1979 | I'm shooting for 110% test coverage! | 17:57 |
| woodm1979 | (boom) | 17:57 |
| *** harlowja_away is now known as harlowja | 18:00 | |
| *** krykowski has quit IRC | 18:04 | |
| openstackgerrit | Matthew D. Wood proposed openstack/horizon: Adding tests for button-tooltip.js https://review.openstack.org/178434 | 18:05 |
| openstackgerrit | Matthew D. Wood proposed openstack/horizon: Adding tests for button-tooltip.js https://review.openstack.org/178434 | 18:06 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Make directory structure match Angular modules https://review.openstack.org/176152 | 18:07 |
| tqtran | r1chardj0n3s, neillc: https://openstack.invisionapp.com/share/6W2OXDHEK#/screens/73119719?maintainScrollPosition=false | 18:09 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Make directory structure match Angular modules https://review.openstack.org/176152 | 18:09 |
| tqtran | if you guys need extra help on it, I'd be happy to chime in | 18:09 |
| *** sayan has joined #openstack-horizon | 18:11 | |
| *** harlowja has quit IRC | 18:16 | |
| *** harlowja has joined #openstack-horizon | 18:16 | |
| *** harlowja has quit IRC | 18:17 | |
| *** harlowja has joined #openstack-horizon | 18:20 | |
| *** jprovazn has joined #openstack-horizon | 18:20 | |
| *** jmolo has quit IRC | 18:22 | |
| *** harlowja has quit IRC | 18:29 | |
| *** harlowja has joined #openstack-horizon | 18:29 | |
| *** dguerri is now known as _dguerri | 18:30 | |
| *** ybathia has joined #openstack-horizon | 18:31 | |
| *** e0ne has joined #openstack-horizon | 18:31 | |
| *** e0ne is now known as e0ne_ | 18:31 | |
| *** e0ne_ is now known as e0ne | 18:32 | |
| *** e0ne is now known as e0ne_ | 18:32 | |
| *** e0ne_ is now known as e0ne | 18:32 | |
| *** e0ne has quit IRC | 18:32 | |
| *** jingjing_ren has quit IRC | 18:34 | |
| *** _dguerri is now known as dguerri | 18:34 | |
| *** oro has joined #openstack-horizon | 18:35 | |
| *** jingjing_ren has joined #openstack-horizon | 18:36 | |
| *** jingjing_ren has quit IRC | 18:38 | |
| *** jingjing_ren has joined #openstack-horizon | 18:39 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Adding new util: next unique ID https://review.openstack.org/177506 | 18:40 |
| *** dguerri has quit IRC | 18:42 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Angular API Unit Tests https://review.openstack.org/178227 | 18:42 |
| *** jingjing_ren has quit IRC | 18:46 | |
| *** e0ne has joined #openstack-horizon | 18:48 | |
| *** Piet has quit IRC | 18:48 | |
| *** annashen has joined #openstack-horizon | 18:55 | |
| *** annashen has quit IRC | 19:01 | |
| *** annashen has joined #openstack-horizon | 19:02 | |
| *** mrunge has quit IRC | 19:03 | |
| *** bpokorny_ has joined #openstack-horizon | 19:03 | |
| *** ericpeterson has quit IRC | 19:06 | |
| *** jtriley has joined #openstack-horizon | 19:06 | |
| *** annashen has quit IRC | 19:06 | |
| *** bpokorny has quit IRC | 19:07 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Angular API Unit Tests https://review.openstack.org/178227 | 19:07 |
| *** cody-somerville has quit IRC | 19:09 | |
| *** lblanchard has joined #openstack-horizon | 19:14 | |
| *** rushiagr is now known as rushiagr_away | 19:15 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/django_openstack_auth: Updated from global requirements https://review.openstack.org/178808 | 19:16 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Updated from global requirements https://review.openstack.org/178809 | 19:17 |
| openstackgerrit | Merged openstack/horizon: Add Angular service to provide translation https://review.openstack.org/175976 | 19:22 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Angular API Unit Tests https://review.openstack.org/178227 | 19:24 |
| openstackgerrit | Matthew D. Wood proposed openstack/horizon: Adding tests for button-tooltip.js https://review.openstack.org/178434 | 19:26 |
| *** cody-somerville has joined #openstack-horizon | 19:28 | |
| *** neelashah1 has quit IRC | 19:30 | |
| *** lblanchard has quit IRC | 19:34 | |
| *** neelabh has joined #openstack-horizon | 19:36 | |
| openstackgerrit | Merged openstack/horizon: avoid calling neutron, when neutron is disabled https://review.openstack.org/178163 | 19:41 |
| *** david-lyle has quit IRC | 19:44 | |
| *** david-lyle has joined #openstack-horizon | 19:44 | |
| *** ChanServ sets mode: +o david-lyle | 19:44 | |
| openstackgerrit | Michael Hagedorn proposed openstack/horizon: [Launch Instance Fix] Add Flavor Step Unit Tests https://review.openstack.org/167326 | 19:46 |
| openstackgerrit | Michael Hagedorn proposed openstack/horizon: Get unit tests working with Karma https://review.openstack.org/168152 | 19:46 |
| *** jprovazn has quit IRC | 19:47 | |
| *** bpokorny has joined #openstack-horizon | 19:48 | |
| openstackgerrit | Michael Hagedorn proposed openstack/horizon: [Launch Instance Fix] Add Flavor Step Unit Tests https://review.openstack.org/167326 | 19:49 |
| *** jingjing_ren has joined #openstack-horizon | 19:51 | |
| *** bpokorny_ has quit IRC | 19:52 | |
| *** ericpeterson has joined #openstack-horizon | 19:53 | |
| *** jingjing_ren has quit IRC | 19:55 | |
| *** nlahouti has quit IRC | 19:56 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Make directory structure match Angular modules https://review.openstack.org/176152 | 19:56 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Get unit tests working with Karma https://review.openstack.org/168152 | 19:56 |
| TravT | tqtran: clu_: r1chardj0n3s: david-lyle: are you available for a hangout in a few minutes? | 19:57 |
| tqtran | yeah I'm good for about 30m | 19:57 |
| TravT | ok, one of the things definitely want to talk about is ^ the directory structure | 19:58 |
| TravT | https://review.openstack.org/176152 | 19:58 |
| *** jwy has joined #openstack-horizon | 19:58 | |
| TravT | we need to get that under our belts, so we avoid massive merge conflicts. | 19:59 |
| asahlin | speaking of directory structure, does anyone know Tyr Johanson nick? I just started working on https://bugs.launchpad.net/horizon/+bug/1446886, but I see that their patch https://review.openstack.org/#/c/176152/ does that and alot more.. | 20:00 |
| openstack | Launchpad bug 1446886 in OpenStack Dashboard (Horizon) "Move angular service api to dashboard" [Medium,New] - Assigned to Aaron Sahlin (asahlin) | 20:00 |
| TravT | hey aaron, he'll be in that hangout... i was hoping richard would be around to share his vidyo technology. | 20:01 |
| TravT | hangouts have a participant limit | 20:01 |
| david-lyle | TravT: o/ | 20:02 |
| *** tyr_ has joined #openstack-horizon | 20:03 | |
| asahlin | ok, if there is room I will hop on.. otherwise just wanted to let him know that I will abodon my change, and he can take ownership of that bug. (since he has a patch for it already) | 20:03 |
| TravT | well, i guess we can start with https://plus.google.com/hangouts/_/g6r2z56lrtiy2qrjdf45zfem6ia | 20:03 |
| TravT | asahlin: there's room | 20:06 |
| *** jingjing_ren has joined #openstack-horizon | 20:08 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Angular API Unit Tests https://review.openstack.org/178227 | 20:09 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Angular API Unit Tests https://review.openstack.org/178227 | 20:10 |
| *** jtriley has quit IRC | 20:15 | |
| *** mpavlase has joined #openstack-horizon | 20:15 | |
| *** dguerri has joined #openstack-horizon | 20:18 | |
| *** jtriley has joined #openstack-horizon | 20:19 | |
| *** e0ne has quit IRC | 20:26 | |
| *** mpavlase has quit IRC | 20:32 | |
| *** e0ne has joined #openstack-horizon | 20:36 | |
| *** radez is now known as radez_g0n3 | 20:44 | |
| *** e0ne has quit IRC | 20:44 | |
| *** jcoufal has joined #openstack-horizon | 20:45 | |
| *** nlahouti has joined #openstack-horizon | 20:47 | |
| *** oro has quit IRC | 20:48 | |
| *** mpavlase has joined #openstack-horizon | 20:50 | |
| *** matt-borland has quit IRC | 20:56 | |
| *** raildo has quit IRC | 20:58 | |
| *** iamjarvo has quit IRC | 20:58 | |
| *** jcoufal has quit IRC | 21:03 | |
| *** cody-somerville has quit IRC | 21:05 | |
| *** iamjarvo has joined #openstack-horizon | 21:06 | |
| *** iamjarvo has quit IRC | 21:06 | |
| *** iamjarvo has joined #openstack-horizon | 21:07 | |
| *** peristeri has quit IRC | 21:09 | |
| *** jtriley has quit IRC | 21:12 | |
| *** neelabh has quit IRC | 21:13 | |
| *** iamjarvo has quit IRC | 21:14 | |
| *** Sukhdev has joined #openstack-horizon | 21:14 | |
| *** annashen has joined #openstack-horizon | 21:21 | |
| *** Longgeek has quit IRC | 21:29 | |
| *** julim has quit IRC | 21:30 | |
| *** cody-somerville has joined #openstack-horizon | 21:31 | |
| *** annashen has quit IRC | 21:33 | |
| *** stevemar has quit IRC | 21:36 | |
| *** jbell8 has quit IRC | 21:36 | |
| *** harlowja is now known as harlowja_away | 21:36 | |
| *** harlowja_away is now known as harlowja | 21:37 | |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: Add description & example for isServer property in Magic Search https://review.openstack.org/178286 | 21:39 |
| *** mattfarina has joined #openstack-horizon | 21:40 | |
| *** mattfarina has quit IRC | 21:40 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Angular Identity Users Panel Demo https://review.openstack.org/177489 | 21:44 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Angularize Identity Users Panel https://review.openstack.org/133767 | 21:44 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: WIP Angular Users Panel - Admin Password check https://review.openstack.org/176540 | 21:44 |
| *** crobertsrh is now known as _crobertsrh | 21:45 | |
| *** jtriley has joined #openstack-horizon | 21:47 | |
| *** ericpeterson has quit IRC | 21:54 | |
| *** mwhagedorn has quit IRC | 21:56 | |
| *** ericpeterson has joined #openstack-horizon | 21:57 | |
| *** jbell8 has joined #openstack-horizon | 21:58 | |
| *** jbell8 has quit IRC | 21:58 | |
| *** rlrevell has quit IRC | 22:02 | |
| *** mpavlase has left #openstack-horizon | 22:02 | |
| *** Piet has joined #openstack-horizon | 22:03 | |
| *** vijendar has quit IRC | 22:12 | |
| *** dguerri is now known as _dguerri | 22:18 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Upgrade pyScss to version 1.3.4 https://review.openstack.org/178504 | 22:20 |
| r1chardj0n3s | btully/ongk django-pyscss upstream accepted my patch so the requirements are updated ^^ ... if you're confident we can get all the scss working I'll look at putting in the global-requirements patch | 22:21 |
| TravT | great work r1chardj0n3s! | 22:22 |
| r1chardj0n3s | I'll make the menu work dependent on that patch, but it's still very early WIP so I'm not sure there's any point sharing it for review | 22:24 |
| TravT | well, right now, i'm working on a patch that is going to get stomped on by the directory structure changes. | 22:25 |
| r1chardj0n3s | yeah - did that get resolved at all this morning? | 22:26 |
| TravT | no | 22:26 |
| r1chardj0n3s | I seriously think we could discuss it for weeks | 22:26 |
| TravT | yes | 22:26 |
| r1chardj0n3s | just needs to have a line drawn in the sand and say "good enough" | 22:27 |
| TravT | Tyr is going to upload another take on it shortly | 22:27 |
| r1chardj0n3s | ok | 22:27 |
| TravT | i think we've made good progress | 22:28 |
| r1chardj0n3s | \o/ | 22:28 |
| TravT | there was some discussion on where APIs should live | 22:28 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: WIP Angular alert service - add auto dismiss https://review.openstack.org/172602 | 22:28 |
| TravT | as you'll see reflected in my comments | 22:29 |
| r1chardj0n3s | oh, I like the legacy thing | 22:36 |
| *** ZZelle_ has joined #openstack-horizon | 22:37 | |
| r1chardj0n3s | TravT: I don't see any need to move the api common code back to horizon unless we envisage ever having api implemented in horizon | 22:40 |
| TravT | great! that was the net result of the earlier conversation as well. | 22:41 |
| r1chardj0n3s | oh! good :) | 22:41 |
| r1chardj0n3s | so were there any outstanding issues? It seems from the review that there's nothing unresolved at this point | 22:43 |
| *** ericpeterson has quit IRC | 22:44 | |
| *** josecastroleon has joined #openstack-horizon | 22:46 | |
| *** bpokorny_ has joined #openstack-horizon | 22:47 | |
| *** josecastroleon has quit IRC | 22:48 | |
| TravT | there are a few. | 22:48 |
| TravT | for one thing the dependency injection is messed up because of horizon base.html defining ng-app='hz' | 22:49 |
| TravT | but i think we got that figured out. | 22:50 |
| TravT | Tyr is off working on the patch now | 22:51 |
| r1chardj0n3s | ok | 22:51 |
| *** dboik has quit IRC | 22:51 | |
| *** bpokorny has quit IRC | 22:51 | |
| r1chardj0n3s | I'll have another look when he lands the next revision | 22:51 |
| TravT | hopefully get a new revision up for review | 22:51 |
| *** dboik has joined #openstack-horizon | 22:51 | |
| *** ZZelle_ has quit IRC | 22:53 | |
| *** drupalmonkey has quit IRC | 22:54 | |
| *** Raildo has joined #openstack-horizon | 22:57 | |
| *** tyr_ has quit IRC | 22:59 | |
| *** woodm1979 has quit IRC | 22:59 | |
| *** Raildo is now known as raildo | 23:00 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Fixed dashboard angular translation issue https://review.openstack.org/174615 | 23:07 |
| *** bpokorny has joined #openstack-horizon | 23:07 | |
| *** tqtran has quit IRC | 23:07 | |
| *** tqtran_ has joined #openstack-horizon | 23:07 | |
| *** tqtran_ is now known as tqtran | 23:07 | |
| *** bpokorny_ has quit IRC | 23:10 | |
| openstackgerrit | Merged openstack/horizon: Updated from global requirements https://review.openstack.org/178809 | 23:12 |
| openstackgerrit | Merged openstack/horizon: Populating job type choices via api call https://review.openstack.org/174479 | 23:12 |
| *** dscottsf has joined #openstack-horizon | 23:13 | |
| *** dscottsf has quit IRC | 23:13 | |
| *** Sukhdev has quit IRC | 23:14 | |
| *** kmartin_ has quit IRC | 23:17 | |
| *** kmartin has joined #openstack-horizon | 23:17 | |
| *** Raildo_ has joined #openstack-horizon | 23:21 | |
| *** raildo has quit IRC | 23:25 | |
| *** packet has quit IRC | 23:25 | |
| *** Raildo_ has quit IRC | 23:27 | |
| *** alexvictorchan has quit IRC | 23:29 | |
| *** jtriley has quit IRC | 23:30 | |
| *** tnovacik has quit IRC | 23:44 | |
| *** ericpeterson has joined #openstack-horizon | 23:45 | |
| zigo | It's looking like horizon has a build-conflict with a python package. I don't know which one yet, but I'll find out. | 23:48 |
| zigo | I know it's already build-conflicting with unittest2 ... | 23:48 |
| *** chlong has joined #openstack-horizon | 23:50 | |
| *** ericpeterson has quit IRC | 23:51 | |
| *** annashen has joined #openstack-horizon | 23:52 | |
| *** ybathia has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!