| openstackgerrit | Shaoquan Chen proposed openstack/horizon: [Launch Instance Fix] Wizard should have max-width of 1440px https://review.openstack.org/166363 | 00:03 |
|---|---|---|
| *** ZZelle_ has quit IRC | 00:05 | |
| *** alexvictorchan has quit IRC | 00:11 | |
| *** annashen has quit IRC | 00:13 | |
| *** Glass_saga has joined #openstack-horizon | 00:20 | |
| *** SimonChung1 has joined #openstack-horizon | 00:21 | |
| *** SimonChung1 has quit IRC | 00:21 | |
| *** SimonChung has quit IRC | 00:21 | |
| *** SimonChung2 has joined #openstack-horizon | 00:21 | |
| *** SimonChung2 has quit IRC | 00:21 | |
| Glass_saga | hello | 00:21 |
| Glass_saga | Can anyone review this? Thank you in advance: https://review.openstack.org/#/c/165711/ | 00:22 |
| *** e0ne has quit IRC | 00:23 | |
| *** mwhagedorn has quit IRC | 00:25 | |
| openstackgerrit | Merged openstack/horizon: [Launch Instance Fix] Launch instance refreshes instance tables https://review.openstack.org/165961 | 00:26 |
| *** SimonChung has joined #openstack-horizon | 00:27 | |
| *** ericpeterson has joined #openstack-horizon | 00:31 | |
| *** bpokorny has joined #openstack-horizon | 00:33 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding styling for disabled and danger action items https://review.openstack.org/166411 | 00:35 |
| *** bpokorn__ has quit IRC | 00:36 | |
| *** jcoufal has joined #openstack-horizon | 00:38 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: [Launch Instance Fix] Add step help content https://review.openstack.org/166376 | 00:43 |
| *** jhesketh has quit IRC | 00:43 | |
| *** jhesketh has joined #openstack-horizon | 00:43 | |
| *** ayoung has quit IRC | 00:43 | |
| *** mwhagedorn has joined #openstack-horizon | 00:46 | |
| *** Longgeek has joined #openstack-horizon | 00:51 | |
| *** SimonChung has quit IRC | 00:55 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: [Launch Instance Fix] Add details to Select Flavor step https://review.openstack.org/165260 | 00:56 |
| *** bpokorny has quit IRC | 01:11 | |
| *** annashen has joined #openstack-horizon | 01:13 | |
| *** annashen has quit IRC | 01:19 | |
| *** lhcheng has quit IRC | 01:24 | |
| *** clu_ has quit IRC | 01:31 | |
| *** smc7 has joined #openstack-horizon | 01:32 | |
| *** alexvictorchan has joined #openstack-horizon | 01:35 | |
| *** smc7 has quit IRC | 01:37 | |
| *** gary-smith__ has quit IRC | 01:37 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: [Launch Instance Fix] Enhancing wizard widget https://review.openstack.org/165475 | 01:39 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Launch Instance - Optional Network Enabled https://review.openstack.org/164359 | 01:39 |
| *** alanf-mc has quit IRC | 01:48 | |
| *** mwhagedorn has quit IRC | 01:49 | |
| *** iamjarvo has joined #openstack-horizon | 01:49 | |
| *** iamjarvo has quit IRC | 01:49 | |
| *** iamjarvo has joined #openstack-horizon | 01:50 | |
| *** SimonChung has joined #openstack-horizon | 02:05 | |
| *** SimonChung1 has joined #openstack-horizon | 02:06 | |
| *** bpokorny has joined #openstack-horizon | 02:08 | |
| *** SimonChung has quit IRC | 02:09 | |
| *** tqtran has quit IRC | 02:14 | |
| *** neelashah has joined #openstack-horizon | 02:15 | |
| *** alexvictorchan has quit IRC | 02:16 | |
| openstackgerrit | Brad Pokorny proposed openstack/horizon: Retrieve domain scoped token https://review.openstack.org/148082 | 02:18 |
| openstackgerrit | Brad Pokorny proposed openstack/horizon: Allow Domain Admin to list roles on project https://review.openstack.org/161985 | 02:18 |
| *** ericpeterson has quit IRC | 02:19 | |
| *** dsneddon has quit IRC | 02:20 | |
| *** neelashah has quit IRC | 02:21 | |
| *** jwy has quit IRC | 02:22 | |
| *** ericpeterson has joined #openstack-horizon | 02:23 | |
| *** lhcheng has joined #openstack-horizon | 02:25 | |
| openstackgerrit | Merged openstack/horizon: Fix common misspellings https://review.openstack.org/166826 | 02:26 |
| *** jcoufal has quit IRC | 02:29 | |
| *** lhcheng has quit IRC | 02:29 | |
| r1chardj0n3s | ongk: you around? | 02:31 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Launch Instance - Optional Network Enabled https://review.openstack.org/164359 | 02:31 |
| openstackgerrit | Richard Jones proposed openstack/horizon: [Launch Instance Fix] Split Security and Access into two steps https://review.openstack.org/167078 | 02:33 |
| openstackgerrit | Richard Jones proposed openstack/horizon: [Launch Instance Fix] Add step help content https://review.openstack.org/166376 | 02:35 |
| r1chardj0n3s | ongk: don't worry, I made the edit I was going to ask for ^^ | 02:35 |
| *** absubram has joined #openstack-horizon | 02:40 | |
| *** zul has quit IRC | 02:47 | |
| *** ericpete_ has joined #openstack-horizon | 02:48 | |
| *** ericpete_ has quit IRC | 02:51 | |
| *** ericpeterson has quit IRC | 02:51 | |
| *** bpokorny has quit IRC | 02:54 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: [Launch Instance Fix] Split Security and Access into two steps https://review.openstack.org/167078 | 02:54 |
| *** zul has joined #openstack-horizon | 02:59 | |
| *** gyee has quit IRC | 03:06 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Launch Instance - Optional Network Enabled https://review.openstack.org/164359 | 03:15 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Launch Instance - Optional Network Enabled https://review.openstack.org/164359 | 03:19 |
| *** Longgeek_ has joined #openstack-horizon | 03:22 | |
| *** Longgeek has quit IRC | 03:25 | |
| *** lhcheng has joined #openstack-horizon | 03:30 | |
| *** ccard_ has quit IRC | 03:34 | |
| *** ccard_ has joined #openstack-horizon | 03:35 | |
| *** sbfox has joined #openstack-horizon | 03:49 | |
| r1chardj0n3s | TravT: around? | 04:01 |
| *** samueldmq has quit IRC | 04:07 | |
| TravT | hey r1chardj0n3s: | 04:08 |
| TravT | was just looking at that patch... trying to figure out why background important is being selected | 04:08 |
| r1chardj0n3s | heya, I've gotta duck out in a moment but I've got an initial cut at splitting out the instance details page about to hit | 04:09 |
| TravT | isn't | 04:09 |
| openstackgerrit | Richard Jones proposed openstack/horizon: [Launch Instance Fix] Add step help content https://review.openstack.org/166376 | 04:10 |
| openstackgerrit | Richard Jones proposed openstack/horizon: [Launch Instance Fix] Move instance name form to its own step https://review.openstack.org/167085 | 04:10 |
| r1chardj0n3s | ah there we go | 04:10 |
| r1chardj0n3s | so I've got a comment in the commit message there ... I'm not sure I understand why the graph includes the count of the sources selected, given that you can only select one source... | 04:11 |
| TravT | yeah, we talked about that last week. I also didn't understand that | 04:11 |
| r1chardj0n3s | I've left the graph on both pages though. *shrug* | 04:11 |
| r1chardj0n3s | it's easy enough to tweak around, but yeah, confusing | 04:11 |
| r1chardj0n3s | anyhoo, time for me to go pick up daughter from school, bbl | 04:12 |
| TravT | i mentioned to sean that it shouldn't | 04:12 |
| TravT | cool | 04:12 |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 04:12 | |
| TravT | i'm gonna probably look back at this in the morning. | 04:12 |
| TravT | thx | 04:12 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: [Launch Instance Fix] Split Security and Access into two steps https://review.openstack.org/167078 | 04:23 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: [Launch Instance Fix] Split Security and Access into two steps https://review.openstack.org/167078 | 04:26 |
| *** lhcheng has quit IRC | 04:27 | |
| *** lhcheng has joined #openstack-horizon | 04:34 | |
| *** amotoki has joined #openstack-horizon | 04:39 | |
| *** masco has joined #openstack-horizon | 04:43 | |
| r1chardj0n3s_afk | haha, tbhanks TravT, I had that scss fix on disk put didn't have time to push it up ;) | 04:45 |
| r1chardj0n3s_afk | need to make the same change to the other one | 04:45 |
| *** ishant has joined #openstack-horizon | 04:48 | |
| *** iamjarvo has quit IRC | 04:50 | |
| *** amotoki has quit IRC | 04:51 | |
| *** amotoki has joined #openstack-horizon | 04:52 | |
| *** amotoki has quit IRC | 04:52 | |
| *** amotoki has joined #openstack-horizon | 04:52 | |
| *** lhcheng_ has joined #openstack-horizon | 04:54 | |
| TravT | r1chardj0n3s_afk: I'm also looking at switching it to use the controller as syntax. Part way through that now. | 04:56 |
| TravT | everything I've read indicates that is best practice. | 04:57 |
| r1chardj0n3s_afk | oh, I have some edits in flight | 04:57 |
| *** lhcheng has quit IRC | 04:57 | |
| r1chardj0n3s_afk | not in 167078 | 04:57 |
| r1chardj0n3s_afk | in 167085 | 04:57 |
| TravT | ok, i'm looking at 167078 | 04:57 |
| r1chardj0n3s_afk | ok | 04:57 |
| *** lhcheng_ has left #openstack-horizon | 04:57 | |
| TravT | i can back off until morning though | 04:57 |
| r1chardj0n3s_afk | no, go for it | 04:57 |
| r1chardj0n3s_afk | I'm messing with the other one | 04:57 |
| TravT | ok | 04:58 |
| r1chardj0n3s_afk | I took the graph off the source page | 04:58 |
| r1chardj0n3s_afk | it just doesn't make sense there | 04:58 |
| TravT | how does that interplay with what Sean had started? | 04:59 |
| TravT | https://review.openstack.org/#/c/166561/ | 05:00 |
| r1chardj0n3s_afk | oh ffs | 05:01 |
| TravT | whatever the case, i want to review changes with piet. | 05:01 |
| r1chardj0n3s_afk | he didn't mark it in the etherpad | 05:01 |
| r1chardj0n3s_afk | :( | 05:01 |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 05:01 | |
| TravT | oh, he left it on the list at the bottom, didn't he | 05:01 |
| TravT | :( | 05:01 |
| r1chardj0n3s | yup | 05:01 |
| TravT | well, if you are further along, then we'll use yours | 05:02 |
| r1chardj0n3s | looks extremely similar | 05:04 |
| r1chardj0n3s | he even removed the source count stuff from the donut like I have | 05:04 |
| r1chardj0n3s | welp, that was a fun exercise in getting nowhere | 05:05 |
| TravT | :( | 05:05 |
| TravT | dang | 05:05 |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 05:07 | |
| *** smc7 has joined #openstack-horizon | 05:10 | |
| *** smc7 has quit IRC | 05:15 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: [Launch Instance Fix] Split Security and Access into two steps https://review.openstack.org/167078 | 05:19 |
| *** harlowja is now known as harlowja_away | 05:22 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: [Launch Instance Fix] Split Security and Access into two steps https://review.openstack.org/167078 | 05:24 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: [Launch Instance Fix] Split Security and Access into two steps https://review.openstack.org/167078 | 05:33 |
| TravT | r1chardj0n3s_afk: ^ you're probably smarter than me and have stopped for you day, but if not, please take a look at the above. just added controller as syntax. I'm done mucking around for the night. | 05:35 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: [Launch Instance Fix] Split Security and Access into two steps https://review.openstack.org/167078 | 05:40 |
| *** _gryf|afk is now known as _gryf | 06:00 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: [Launch Instance Fix] Split Security and Access into two steps https://review.openstack.org/167078 | 06:08 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/167109 | 06:12 |
| *** annashen has joined #openstack-horizon | 06:18 | |
| *** annashen has quit IRC | 06:24 | |
| *** sayan has joined #openstack-horizon | 06:24 | |
| *** ankit_ag has joined #openstack-horizon | 06:27 | |
| *** tnovacik has joined #openstack-horizon | 06:31 | |
| *** rdopiera has joined #openstack-horizon | 06:32 | |
| *** oro_ has joined #openstack-horizon | 06:34 | |
| *** oro has joined #openstack-horizon | 06:34 | |
| *** vishwanathj has quit IRC | 06:37 | |
| *** pcaruana has quit IRC | 06:41 | |
| *** chlong has quit IRC | 06:42 | |
| *** mrunge has joined #openstack-horizon | 06:48 | |
| *** mrunge has quit IRC | 06:48 | |
| *** mrunge has joined #openstack-horizon | 06:48 | |
| *** jtomasek has joined #openstack-horizon | 06:52 | |
| *** oro_ has quit IRC | 06:53 | |
| *** oro has quit IRC | 06:53 | |
| *** smc7 has joined #openstack-horizon | 07:00 | |
| *** chlong has joined #openstack-horizon | 07:03 | |
| openstackgerrit | Merged openstack/horizon: Replace 'raise AssertionError' with 'self.assertIn' https://review.openstack.org/165711 | 07:04 |
| *** akanksha has joined #openstack-horizon | 07:07 | |
| *** sbfox has quit IRC | 07:10 | |
| *** oro_ has joined #openstack-horizon | 07:19 | |
| *** oro has joined #openstack-horizon | 07:20 | |
| *** Ala has joined #openstack-horizon | 07:21 | |
| *** sayan has quit IRC | 07:29 | |
| *** dsneddon has joined #openstack-horizon | 07:36 | |
| *** jtomasek has quit IRC | 07:53 | |
| *** markus_z has joined #openstack-horizon | 07:56 | |
| *** stevemar has quit IRC | 07:58 | |
| *** Longgeek_ has quit IRC | 07:58 | |
| *** sayan has joined #openstack-horizon | 07:59 | |
| *** jtomasek has joined #openstack-horizon | 08:06 | |
| *** yingjun has joined #openstack-horizon | 08:07 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/167109 | 08:10 |
| *** chlong has quit IRC | 08:12 | |
| *** ccard__ has quit IRC | 08:13 | |
| *** romainh has joined #openstack-horizon | 08:13 | |
| *** yingjun has quit IRC | 08:19 | |
| *** yingjun has joined #openstack-horizon | 08:22 | |
| *** oro_ has quit IRC | 08:23 | |
| *** oro has quit IRC | 08:24 | |
| *** ericksonfgds has quit IRC | 08:29 | |
| *** zz_ttrifonov is now known as ttrifonov | 08:32 | |
| *** mrunge has quit IRC | 08:46 | |
| *** Ala has quit IRC | 08:50 | |
| *** Ala has joined #openstack-horizon | 08:51 | |
| *** jprovazn has joined #openstack-horizon | 08:56 | |
| *** ygbo has joined #openstack-horizon | 09:00 | |
| *** robcresswell_afk is now known as robcresswell | 09:04 | |
| *** ygbo has quit IRC | 09:07 | |
| *** ttrifonov is now known as zz_ttrifonov | 09:08 | |
| *** krykowski has joined #openstack-horizon | 09:09 | |
| *** ygbo has joined #openstack-horizon | 09:09 | |
| *** zz_ttrifonov is now known as ttrifonov | 09:09 | |
| *** oro_ has joined #openstack-horizon | 09:10 | |
| *** oro has joined #openstack-horizon | 09:10 | |
| *** mrunge has joined #openstack-horizon | 09:11 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:11 | |
| robcresswell | morning all | 09:13 |
| *** mpavlase has joined #openstack-horizon | 09:29 | |
| r1chardj0n3s_afk | TravT: much nicer, thanks for doing that (it was on my TO DO :) | 09:30 |
| r1chardj0n3s_afk | TravT: hopefully the etherpad will be uptodate tomorrow so I'll be able to grab an actual free task off the list to work on ;) | 09:30 |
| r1chardj0n3s_afk | (ohai robcresswell and good evening to you :) | 09:30 |
| *** e0ne has joined #openstack-horizon | 09:31 | |
| *** smc7 has quit IRC | 09:32 | |
| *** yingjun has quit IRC | 09:33 | |
| *** JeanBriceCombebi has quit IRC | 09:37 | |
| robcresswell | r1chardj0n3s_afk: evening :) | 09:38 |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:39 | |
| *** e0ne has quit IRC | 09:40 | |
| *** krykowski has quit IRC | 09:43 | |
| *** ZZelle has quit IRC | 09:44 | |
| *** ZZelle has joined #openstack-horizon | 09:44 | |
| *** lhcheng has joined #openstack-horizon | 09:44 | |
| *** mwhagedorn has joined #openstack-horizon | 09:49 | |
| openstackgerrit | Cedric Brandily proposed openstack/horizon: Support fwaasrouterinsertion extension (2/3) https://review.openstack.org/167153 | 09:54 |
| *** JeanBriceCombebi has quit IRC | 09:56 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:57 | |
| openstackgerrit | Gerome Chardon proposed openstack/horizon: Add Extra Routes to Router Tabs View https://review.openstack.org/135890 | 09:58 |
| *** JeanBriceCombebi has quit IRC | 10:09 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 10:09 | |
| *** samueldmq-away is now known as samueldmq | 10:26 | |
| *** e0ne has joined #openstack-horizon | 10:29 | |
| *** lhcheng has quit IRC | 10:32 | |
| *** JeanBriceCombebi has quit IRC | 10:50 | |
| openstackgerrit | Michael Hagedorn proposed openstack/horizon: [Launch Instance Fix] upstream deltas needed for neutron api https://review.openstack.org/164287 | 10:51 |
| *** JeanBriceCombebi has joined #openstack-horizon | 10:52 | |
| *** tosky has joined #openstack-horizon | 10:58 | |
| *** mark-os has quit IRC | 11:03 | |
| *** e0ne is now known as e0ne_ | 11:09 | |
| bradjones | mrunge: left comment about https://review.openstack.org/119427/ please look when you can happy to talk more about your concern here | 11:12 |
| *** mark-os has joined #openstack-horizon | 11:12 | |
| *** iamjarvo has joined #openstack-horizon | 11:14 | |
| *** smc7 has joined #openstack-horizon | 11:18 | |
| *** e0ne_ has quit IRC | 11:19 | |
| *** e0ne has joined #openstack-horizon | 11:20 | |
| *** smc7 has quit IRC | 11:23 | |
| *** annashen has joined #openstack-horizon | 11:23 | |
| mrunge | bradjones, I'm very sorry for being here the party pooper. | 11:24 |
| *** iamjarvo has quit IRC | 11:24 | |
| mrunge | bradjones, still I think you can not solve the issues with your patch | 11:24 |
| *** annashen has quit IRC | 11:28 | |
| bradjones | mrunge: the only thing that I think this patch doesn't address is when quotas are not in use at all | 11:30 |
| mrunge | yes, that's correct | 11:31 |
| mrunge | and that's, what the bug described | 11:31 |
| mrunge | Pie charts are empty when quota is zero | 11:31 |
| mrunge | see? | 11:31 |
| sambetts | mrunge: so is it not possible to have a zero quota without it become unlimited ?? | 11:32 |
| mrunge | that's a valid question | 11:34 |
| mrunge | I thought, until now, quota=0 and unlimited quota are the same | 11:34 |
| robcresswell | That's interesting. I had assumed quota=0 was to restrict specific users for using a certain type of service. | 11:35 |
| sambetts | I had no idea that unlimted quotas were even possible | 11:35 |
| mrunge | I would think of using policies to restrict people from doing certain actions | 11:36 |
| mrunge | but that might not be the only way | 11:36 |
| *** e0ne is now known as e0ne_ | 11:36 | |
| sambetts | mrunge: according to the docs quotas have to be negativeto be unlimited | 11:37 |
| sambetts | http://docs.openstack.org/user-guide-admin/content/cli_set_quotas.html | 11:37 |
| bradjones | I need to test this again but my understanding is that if you have 2 of x and then the quota goes down to 0 you are 'oversubscribed' and couldn't create any more of x | 11:37 |
| bradjones | that was what made me change my mind initially over the pie charts empty/full debate | 11:38 |
| *** john-davidge has joined #openstack-horizon | 11:38 | |
| * bradjones waiting to stack then will test that ^ | 11:38 | |
| *** zul has quit IRC | 11:40 | |
| mrunge | ok, bradjones sambetts robcresswell thanks. convinced. | 11:40 |
| robcresswell | thanks mrunge :) | 11:41 |
| *** zul has joined #openstack-horizon | 11:41 | |
| mrunge | could you please file a bug on not showing graphs on unlimited quota then? | 11:41 |
| robcresswell | will do that now | 11:41 |
| mrunge | thank you | 11:41 |
| bradjones | mrunge: thanks | 11:41 |
| *** jamielennox is now known as jamielennox|away | 11:45 | |
| *** e0ne_ has quit IRC | 11:46 | |
| robcresswell | mrunge: https://bugs.launchpad.net/horizon/+bug/1435811 Done. Feel free to add if I missed anything useful | 11:46 |
| openstack | Launchpad bug 1435811 in OpenStack Dashboard (Horizon) "Quota charts should be hidden if quota is unlimited" [Undecided,New] | 11:46 |
| *** iamjarvo has joined #openstack-horizon | 11:47 | |
| mrunge | robcresswell, thank you | 11:52 |
| *** e0ne has joined #openstack-horizon | 11:53 | |
| openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Add integration tests for Identity->Projects page https://review.openstack.org/110919 | 12:01 |
| *** _gryf has quit IRC | 12:06 | |
| *** mwhagedorn has quit IRC | 12:06 | |
| openstackgerrit | Matthias Runge proposed openstack/horizon: Chnage preset for resource usage to last day https://review.openstack.org/167190 | 12:08 |
| openstackgerrit | Matthias Runge proposed openstack/horizon: Change preset for resource usage to 'last day' https://review.openstack.org/167190 | 12:09 |
| *** chlong has joined #openstack-horizon | 12:12 | |
| *** ZZelle has quit IRC | 12:15 | |
| *** chlong has quit IRC | 12:15 | |
| *** ZZelle has joined #openstack-horizon | 12:15 | |
| *** ericpeterson has joined #openstack-horizon | 12:19 | |
| *** jcoufal has joined #openstack-horizon | 12:22 | |
| *** thiagop has quit IRC | 12:28 | |
| *** fthiagogv has joined #openstack-horizon | 12:28 | |
| *** ericpeterson has quit IRC | 12:29 | |
| *** akrivoka has joined #openstack-horizon | 12:30 | |
| *** chlong has joined #openstack-horizon | 12:32 | |
| *** akrivoka has quit IRC | 12:34 | |
| *** akrivoka has joined #openstack-horizon | 12:35 | |
| *** chlong has quit IRC | 12:35 | |
| *** ishant has quit IRC | 12:36 | |
| *** chlong has joined #openstack-horizon | 12:36 | |
| *** rushiagr_away is now known as rushiagr | 12:37 | |
| *** ericksonfgds has joined #openstack-horizon | 12:39 | |
| *** chlong has quit IRC | 12:39 | |
| *** Miouge has joined #openstack-horizon | 12:44 | |
| *** iamjarvo has quit IRC | 12:48 | |
| *** andrewbogott_afk is now known as andrewbogott | 12:55 | |
| *** chlong has joined #openstack-horizon | 12:56 | |
| *** rushiagr is now known as rushiagr_away | 13:00 | |
| *** julim has joined #openstack-horizon | 13:01 | |
| *** Miouge has quit IRC | 13:04 | |
| *** Miouge has joined #openstack-horizon | 13:05 | |
| *** Miouge has quit IRC | 13:05 | |
| *** mwhagedorn has joined #openstack-horizon | 13:06 | |
| *** amotoki has quit IRC | 13:09 | |
| *** amotoki has joined #openstack-horizon | 13:12 | |
| *** iamjarvo has joined #openstack-horizon | 13:17 | |
| *** iamjarvo has quit IRC | 13:17 | |
| *** iamjarvo has joined #openstack-horizon | 13:18 | |
| *** iamjarvo has quit IRC | 13:18 | |
| *** iamjarvo has joined #openstack-horizon | 13:19 | |
| *** neelashah has joined #openstack-horizon | 13:19 | |
| *** neelashah1 has joined #openstack-horizon | 13:20 | |
| *** andrewbogott is now known as andrewbogott_afk | 13:23 | |
| *** neelashah has quit IRC | 13:24 | |
| openstackgerrit | Merged openstack/horizon: Updated overview graph when usage exceeds quota https://review.openstack.org/119427 | 13:27 |
| *** iamjarvo has quit IRC | 13:30 | |
| *** rushiagr_away is now known as rushiagr | 13:33 | |
| *** jprovazn has quit IRC | 13:33 | |
| openstackgerrit | Merged openstack/horizon: Admin state column added in firewall table https://review.openstack.org/166124 | 13:35 |
| *** peristeri has joined #openstack-horizon | 13:35 | |
| *** dboik has joined #openstack-horizon | 13:38 | |
| *** dboik has quit IRC | 13:38 | |
| *** dboik has joined #openstack-horizon | 13:39 | |
| *** mattfarina has joined #openstack-horizon | 13:43 | |
| *** andrewbogott_afk is now known as andrewbogott | 13:45 | |
| *** matt-borland has joined #openstack-horizon | 13:46 | |
| *** lblanchard has joined #openstack-horizon | 13:55 | |
| *** samueldmq is now known as samueldmq-away | 13:55 | |
| *** lblanchard has quit IRC | 13:59 | |
| *** obutenko has quit IRC | 13:59 | |
| *** radez_g0n3 is now known as radez | 14:00 | |
| mark-os | Could someone explain how I'm supposed to be able to use the dashboard if you can't open Firefox on the Openstack VM? | 14:00 |
| *** dboik_ has joined #openstack-horizon | 14:00 | |
| *** neelashah1 has quit IRC | 14:00 | |
| rdopiera | mark-os: why would you need firefox on the vm? | 14:00 |
| rdopiera | mark-os: open firefox on your workstation | 14:01 |
| *** TravT has quit IRC | 14:01 | |
| *** wchrisj has joined #openstack-horizon | 14:01 | |
| mark-os | rdopiera: I've opened firefox on my local VM | 14:01 |
| mark-os | tried using the IP address for the Openstack VM | 14:01 |
| *** lblanchard has joined #openstack-horizon | 14:01 | |
| rdopiera | ... | 14:02 |
| *** obutenko has joined #openstack-horizon | 14:02 | |
| mark-os | rdopiera: It didn't work | 14:02 |
| mark-os | rdopiera: It didn't connect | 14:02 |
| rdopiera | no wonder | 14:02 |
| *** mrunge has quit IRC | 14:03 | |
| *** julim has quit IRC | 14:03 | |
| *** mwhagedorn has quit IRC | 14:03 | |
| *** dboik has quit IRC | 14:04 | |
| mark-os | rdopiera: I followed the guide and they suggested using 'http://controller' but I don't see how that would work | 14:04 |
| *** mwhagedorn has joined #openstack-horizon | 14:04 | |
| *** obutenko has quit IRC | 14:05 | |
| *** jecarey has joined #openstack-horizon | 14:05 | |
| *** neelashah has joined #openstack-horizon | 14:06 | |
| *** julim has joined #openstack-horizon | 14:06 | |
| mark-os | rdopiera: apache is running, I just don't know how to connect to the dashboard as it looks like I've got everything else set up. Could you provide guidance please? | 14:07 |
| rdopiera | mark-os: run firefox on your workstation, not in a vm | 14:07 |
| *** ericpeterson has joined #openstack-horizon | 14:08 | |
| *** ericpeterson has quit IRC | 14:09 | |
| *** ericpeterson has joined #openstack-horizon | 14:09 | |
| *** jtriley has joined #openstack-horizon | 14:13 | |
| mark-os | rdopiera: openstack workstation? | 14:13 |
| *** jprovazn has joined #openstack-horizon | 14:14 | |
| *** vijendar has joined #openstack-horizon | 14:14 | |
| *** iamjarvo has joined #openstack-horizon | 14:16 | |
| mark-os | rdopiera: | 14:17 |
| *** smc7 has joined #openstack-horizon | 14:17 | |
| rdopiera | mark-os: no, the computer you are sitting in front of | 14:18 |
| mark-os | rdopiera: thank you, any idea why it doesn't work in a VM? | 14:21 |
| mark-os | rdopiera: I'm getting some server error | 14:21 |
| mark-os | rdopiera: The server encountered an internal error and was unable to complete your request. Either the server is overloaded or there was an error in a CGI script. | 14:25 |
| *** annashen has joined #openstack-horizon | 14:26 | |
| *** annashen has quit IRC | 14:30 | |
| *** e0ne is now known as e0ne_ | 14:31 | |
| *** e0ne_ has quit IRC | 14:36 | |
| *** jprovazn has quit IRC | 14:36 | |
| *** akanksha has quit IRC | 14:37 | |
| *** jprovazn has joined #openstack-horizon | 14:38 | |
| *** e0ne has joined #openstack-horizon | 14:38 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: [Launch Instance Fix] Add Network Step Unit Tests https://review.openstack.org/167253 | 14:39 |
| *** Piet has quit IRC | 14:41 | |
| mark-os | So I've checked the openstack-dashboard-error_log and this seems to be the issue: Permission denied: '/srv/www/openstack-dashboard/openstack_dashboard/local/.secret_key_store' | 14:44 |
| pkarikh | Hi all! Does anyone know, if there any way to complitly disable Horizon authentication? | 14:46 |
| *** masco has quit IRC | 14:48 | |
| pkarikh | *completely | 14:48 |
| *** stevemar has joined #openstack-horizon | 14:48 | |
| *** jtriley has quit IRC | 14:49 | |
| *** EmilienM|PTO is now known as EmilienM | 14:51 | |
| openstackgerrit | Merged openstack/tuskar-ui: Remove password check from is_required Parameter method https://review.openstack.org/166160 | 14:52 |
| *** ankit_ag has quit IRC | 14:52 | |
| mark-os | Switched the file ownership to wwwrun:www | 14:53 |
| mark-os | that's got me passed that error | 14:53 |
| *** bpokorny has joined #openstack-horizon | 14:55 | |
| *** tosky has quit IRC | 14:55 | |
| *** tnovacik has quit IRC | 14:56 | |
| *** tosky has joined #openstack-horizon | 14:56 | |
| *** bpokorny has quit IRC | 14:59 | |
| *** neelashah has quit IRC | 14:59 | |
| *** raildo|away is now known as raildo | 15:01 | |
| *** neelashah has joined #openstack-horizon | 15:04 | |
| david-lyle | pkarikh: no there is not | 15:04 |
| david-lyle | you need the token and catalog in the token to do anything | 15:05 |
| pkarikh | david-lyle: ok, thank you! | 15:07 |
| *** bpokorny has joined #openstack-horizon | 15:08 | |
| *** SimonChung1 has quit IRC | 15:13 | |
| *** sayan has quit IRC | 15:15 | |
| robcresswell | pkarikh: This *may* be related to your question https://review.openstack.org/#/c/148997/ | 15:16 |
| openstackgerrit | Matt Borland proposed openstack/horizon: [Launch Instance Fix] Add Network Step Unit Tests https://review.openstack.org/167253 | 15:19 |
| *** jtriley has joined #openstack-horizon | 15:23 | |
| *** JeanBriceCombebi has quit IRC | 15:24 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 15:27 | |
| *** TravT has joined #openstack-horizon | 15:31 | |
| *** vishwanathj has joined #openstack-horizon | 15:35 | |
| *** _crobertsrh is now known as crobertsrh | 15:36 | |
| openstackgerrit | Kelly Domico proposed openstack/horizon: [Launch Instance Fix] Adding validation https://review.openstack.org/165155 | 15:37 |
| *** krykowski has joined #openstack-horizon | 15:38 | |
| *** robcresswell is now known as robcresswell_afk | 15:38 | |
| *** ericksonsantos has quit IRC | 15:38 | |
| *** gyee has joined #openstack-horizon | 15:39 | |
| *** absubram has quit IRC | 15:40 | |
| mark-os | Where can I learn about how Horizon supports Ironic? | 15:43 |
| david-lyle | robcresswell_afk: that's for heat only | 15:46 |
| david-lyle | mark-os: horizon does not have support for ironic currently | 15:46 |
| *** rdopiera has quit IRC | 15:46 | |
| david-lyle | it's a goal, but we haven't added it yet | 15:46 |
| *** JeanBriceCombebi has quit IRC | 15:46 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 15:47 | |
| mark-os | david-lyle: Is there no progress at all on it? Has it been targetted for a certain release? | 15:47 |
| david-lyle | mark-os: it was desired for this release, but no one worked on it. There is some support in tuskar_ui which is a plugin for horizon, but it requires tripleO and the tuskar service to use | 15:48 |
| *** Drago has quit IRC | 15:49 | |
| *** Drago1 has joined #openstack-horizon | 15:49 | |
| *** bradjones has quit IRC | 15:51 | |
| mark-os | david-lyle: So to get this correct, Horizon itself doesn't support Ironic however there is a plugin for Horizon called Tuskar UI which has some support for Ironic? | 15:51 |
| *** bradjones has joined #openstack-horizon | 15:51 | |
| *** bradjones has quit IRC | 15:51 | |
| *** bradjones has joined #openstack-horizon | 15:51 | |
| *** Miouge has joined #openstack-horizon | 15:53 | |
| david-lyle | mark-os: yes, but the plugin requires more things | 15:53 |
| *** nlahouti has joined #openstack-horizon | 15:53 | |
| david-lyle | that aren't standard openstack | 15:53 |
| mark-os | david-lyle: By this release do you mean Juno or Kilo which is going to be released end of April? | 15:53 |
| mark-os | david-lyle: Okay thanks for your help | 15:53 |
| david-lyle | Kilo | 15:53 |
| mark-os | thanks | 15:54 |
| mark-os | Could anyone tell me what is the User Name supposed to be for the login page for the dashboard? | 15:54 |
| *** markus_z has quit IRC | 15:55 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: [Launch Instance Fix] Add Network Step Unit Tests https://review.openstack.org/167253 | 15:55 |
| mark-os | I've tried the name of some of the users I have in Keystone and also some of the emails but none have worked so far | 15:55 |
| david-lyle | mark-os: in devstack 'admin' and 'demo' are added as users by default | 15:57 |
| vishwanathj | crobertsrh, Hi, I have a pycharm related question - was wondering how to run tests in debug mode? Have you ever run horizon tests in debug mode from pycharm, Thanks | 15:57 |
| mark-os | david-lyle: I haven't used devstack | 15:57 |
| david-lyle | oh | 15:57 |
| david-lyle | have you point your horizon at your keystone? | 15:58 |
| david-lyle | settings.py | 15:58 |
| *** rushiagr is now known as rushiagr_away | 15:58 | |
| crobertsrh | vishwanathj: I just run the tests from the command line. I have not yet run the tests via pycharm | 15:59 |
| david-lyle | mark-os: actually local_settings.py https://github.com/openstack/horizon/blob/master/openstack_dashboard/local/local_settings.py.example#L153 | 15:59 |
| *** radez is now known as radez_g0n3 | 16:00 | |
| vishwanathj | crobertsrh, Ok, Thanks, some of the test failures are hard to root cause, was hoping there would be an easier way to debug via pycharm | 16:00 |
| crobertsrh | I suspect there is a way to do it. I'll give it a try right now. | 16:01 |
| *** EmilienM is now known as EmilienM|PTO | 16:02 | |
| david-lyle | vishwanathj: are you still working on your tests issue from about 10 hours ago? | 16:02 |
| vishwanathj | david-lyle, yes, unfortunately, | 16:03 |
| vishwanathj | it seems like it could be a simple thing, but am unable to figure it out | 16:04 |
| *** alexvictorchan has joined #openstack-horizon | 16:04 | |
| vishwanathj | as I have not done that before | 16:04 |
| crobertsrh | vishwanathj: Ok, I was able to run the tests for my panel in pycharm | 16:04 |
| *** amotoki has quit IRC | 16:04 | |
| david-lyle | so on your page http://logs.openstack.org/52/162552/32/check/gate-horizon-python27/4166700/console.html you are trying to use tab_group but it's not defined | 16:05 |
| *** amotoki has joined #openstack-horizon | 16:05 | |
| crobertsrh | Are you looking to run unit tests for a given panel? | 16:05 |
| david-lyle | do you have a link to your patch vishwanathj | 16:05 |
| vishwanathj | david-lyle, the link to patch is https://review.openstack.org/#/c/162552/ | 16:05 |
| *** radez_g0n3 is now known as radez | 16:06 | |
| vishwanathj | crobertsrh, i am trying to execute the equivalent of ./run_tests.sh openstack_dashboard.dashboards.project.firewalls.tests from pycharm | 16:06 |
| crobertsrh | Ok, no problem.... | 16:07 |
| crobertsrh | You'll want to go to "run, edit configurations"...then add one for a new Django test... | 16:07 |
| crobertsrh | For target, you might want to set it to "firewalls" (module name) | 16:08 |
| crobertsrh | Add an env variable of DJANGO_SETTINGS_MODULE=openstack_dashboard.test.settings | 16:08 |
| crobertsrh | Set working directory to <your path>/horizon/openstack_dashboard/dashboards/project/firewalls | 16:09 |
| *** sayan has joined #openstack-horizon | 16:10 | |
| vishwanathj | crobertsrh, trying it now | 16:12 |
| openstackgerrit | Brian Tully proposed openstack/horizon: Add help panel text - Launch Instance source step https://review.openstack.org/166358 | 16:13 |
| *** iamjarvo has quit IRC | 16:13 | |
| *** e0ne is now known as e0ne_ | 16:13 | |
| *** jprovazn has quit IRC | 16:14 | |
| crobertsrh | Ok, hopefully it will work for you. If not, let me know. I have to run to eat lunch, but I'll be back. | 16:14 |
| *** chlong has quit IRC | 16:16 | |
| vishwanathj | It failed with an ImportError: No module named django_nose, will try to investigate that further | 16:16 |
| vishwanathj | thanks crobertsrh | 16:16 |
| *** Miouge has quit IRC | 16:20 | |
| *** Miouge has joined #openstack-horizon | 16:20 | |
| *** jmolo has joined #openstack-horizon | 16:21 | |
| openstackgerrit | Gerome Chardon proposed openstack/horizon: Add Extra Routes to Router Tabs View https://review.openstack.org/135890 | 16:21 |
| *** samueldmq-away is now known as samueldmq | 16:25 | |
| *** Miouge has quit IRC | 16:26 | |
| *** e0ne_ is now known as e0ne | 16:27 | |
| *** absubram has joined #openstack-horizon | 16:29 | |
| *** tnovacik has joined #openstack-horizon | 16:30 | |
| *** Drago1 has quit IRC | 16:31 | |
| *** Drago has joined #openstack-horizon | 16:31 | |
| *** Miouge has joined #openstack-horizon | 16:32 | |
| *** SimonChung has joined #openstack-horizon | 16:34 | |
| *** amotoki has quit IRC | 16:35 | |
| mark-os | david-lyle: is there any way to check if keystone has been successfully linked to the dashboard? Having trouble signing in with any of the names on keystone user-list | 16:36 |
| *** tnovacik has quit IRC | 16:40 | |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Metadata widget multivalue selection support https://review.openstack.org/153210 | 16:42 |
| *** tqtran has joined #openstack-horizon | 16:43 | |
| *** romainh has left #openstack-horizon | 16:45 | |
| *** sbfox has joined #openstack-horizon | 16:51 | |
| *** andrewbogott is now known as andrewbogott_afk | 16:54 | |
| *** krykowski has quit IRC | 16:54 | |
| *** andrewbogott_afk is now known as andrewbogott | 16:56 | |
| *** alanf-mc has joined #openstack-horizon | 16:57 | |
| *** neelashah has quit IRC | 17:00 | |
| mark-os | david-lyle: I've entered in the URL of my Keystone service and it's still not recognising any of the users from my keystone user-list | 17:01 |
| *** alanf-mc has quit IRC | 17:01 | |
| mark-os | david-lyle: I've tried using both name and email with their passwords | 17:01 |
| openstackgerrit | Matt Borland proposed openstack/horizon: [Launch Instance Fix] Add Configuration Step Unit Tests https://review.openstack.org/167323 | 17:01 |
| david-lyle | mark-os: I'd look in the logs for something useful? | 17:02 |
| david-lyle | the authenticate is handled by django_openstack_auth which is a separate package from horizon | 17:03 |
| david-lyle | but shares the same log | 17:03 |
| mark-os | david-lyle: that log being openstack-dashboard-error_log correct? | 17:04 |
| *** lhcheng has joined #openstack-horizon | 17:04 | |
| *** neelashah has joined #openstack-horizon | 17:05 | |
| mark-os | david-lyle: AH00082: an unknown filter was not added: DEFLATE | 17:06 |
| david-lyle | you're still encountering apache problems | 17:06 |
| david-lyle | seems that tutorial is incomplete | 17:07 |
| david-lyle | and I can't help much more than google can on that | 17:07 |
| david-lyle | *seems like you're still encountering apache problems | 17:08 |
| david-lyle | slight correction | 17:08 |
| openstackgerrit | Matt Borland proposed openstack/horizon: [Launch Instance Fix] Add Flavor Step Unit Tests https://review.openstack.org/167326 | 17:09 |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Demo of Action List https://review.openstack.org/162496 | 17:11 |
| *** alanf-mc has joined #openstack-horizon | 17:12 | |
| *** JeanBriceCombebi has quit IRC | 17:13 | |
| *** harlowja_away is now known as harlowja | 17:18 | |
| *** e0ne is now known as e0ne_ | 17:19 | |
| *** ygbo has quit IRC | 17:21 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: [Launch Instance Fix] Add Details Step Unit Tests https://review.openstack.org/167333 | 17:21 |
| *** e0ne_ is now known as e0ne | 17:22 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: [Launch Instance Fix] Add Source Step Unit Tests https://review.openstack.org/167334 | 17:27 |
| *** annashen has joined #openstack-horizon | 17:28 | |
| *** dboik_ has quit IRC | 17:30 | |
| *** dboik has joined #openstack-horizon | 17:30 | |
| *** SimonChung1 has joined #openstack-horizon | 17:31 | |
| *** SimonChung2 has joined #openstack-horizon | 17:31 | |
| *** SimonChung has quit IRC | 17:31 | |
| *** SimonChung1 has quit IRC | 17:31 | |
| *** tyr_ has joined #openstack-horizon | 17:31 | |
| *** sbfox has quit IRC | 17:31 | |
| *** SimonChung2 has quit IRC | 17:32 | |
| *** SimonChung has joined #openstack-horizon | 17:32 | |
| *** annashen has quit IRC | 17:33 | |
| *** SimonChung1 has joined #openstack-horizon | 17:34 | |
| *** SimonChung has quit IRC | 17:34 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: [Launch Instance Fix] Add Security Group Step Unit Tests https://review.openstack.org/167337 | 17:35 |
| ccard | I have horizon configured to support multidomains, and can successfully create a project within a domain, with an initial set of users. But if I try to add a user to an existing project in the domain I get an Unauthorized error from horizon "Error: Unauthorized: Failed to modify 0 project members, update project groups and update project quotas". I can see a stack trace in the horizon log from openstack_dashboard/api/keystone.py", line 295, in | 17:35 |
| ccard | user_list, and I see an error in the keystone log "No domain information specified as part of list request". Is this a known issue? Or is my OpenStack misconfigured? | 17:35 |
| *** john-davidge has quit IRC | 17:36 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Enhance policy rules to workflow actions https://review.openstack.org/144152 | 17:38 |
| *** ttrifonov is now known as zz_ttrifonov | 17:39 | |
| david-lyle | esp ^^^ I'll let you handle that | 17:39 |
| openstackgerrit | Matt Borland proposed openstack/horizon: [Launch Instance Fix] Add Keypair Step Unit Tests https://review.openstack.org/167338 | 17:39 |
| esp | thx david-lyle :) | 17:40 |
| david-lyle | :D | 17:40 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: [Launch Instance Fix] Adding launch details step https://review.openstack.org/166561 | 17:41 |
| *** Ala has quit IRC | 17:42 | |
| *** oro has quit IRC | 17:42 | |
| openstackgerrit | Brian Tully proposed openstack/horizon: Add help panel text - Launch Instance source step https://review.openstack.org/166358 | 17:42 |
| *** oro_ has quit IRC | 17:42 | |
| openstackgerrit | Merged openstack/horizon: [Launch Instance Fix] Add step help content https://review.openstack.org/166376 | 17:43 |
| *** dboik_ has joined #openstack-horizon | 17:44 | |
| *** dboik has quit IRC | 17:47 | |
| *** tnovacik has joined #openstack-horizon | 17:51 | |
| *** mpavlase has quit IRC | 17:52 | |
| *** dsneddon has quit IRC | 17:57 | |
| *** dsneddon has joined #openstack-horizon | 17:57 | |
| *** bpokorny has quit IRC | 18:01 | |
| *** bpokorny has joined #openstack-horizon | 18:03 | |
| *** SimonChung1 has quit IRC | 18:03 | |
| *** SimonChung has joined #openstack-horizon | 18:03 | |
| *** jcoufal has quit IRC | 18:04 | |
| *** jamielennox|away is now known as jamielennox | 18:04 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: [Launch Instance Fix] Adding launch details step https://review.openstack.org/166561 | 18:06 |
| *** SimonChung1 has joined #openstack-horizon | 18:08 | |
| *** SimonChung has quit IRC | 18:08 | |
| tqtran | ongk: question, do you have a demo patch for the search bar? | 18:10 |
| tqtran | if not, is there a code sample i can use to get it in users table? | 18:10 |
| tqtran | nvm found it | 18:12 |
| openstackgerrit | Matt Borland proposed openstack/horizon: [Launch Instance Fix] Add Configuration Step Unit Tests https://review.openstack.org/167323 | 18:15 |
| *** bpokorny_ has joined #openstack-horizon | 18:16 | |
| *** bpokorny has quit IRC | 18:19 | |
| *** e0ne has quit IRC | 18:21 | |
| *** sbfox has joined #openstack-horizon | 18:24 | |
| *** ZZelle_ has joined #openstack-horizon | 18:26 | |
| *** jwy has joined #openstack-horizon | 18:28 | |
| *** Piet has joined #openstack-horizon | 18:29 | |
| *** neelashah has quit IRC | 18:33 | |
| tsufiev_ | tqtran, hi! how can I see the new Launch Instance view? (I've seen a lot of bugs about improving it, yet current Instances page looks the same as before) | 18:35 |
| *** jwy has quit IRC | 18:36 | |
| *** jwy has joined #openstack-horizon | 18:37 | |
| *** oro has joined #openstack-horizon | 18:37 | |
| *** oro_ has joined #openstack-horizon | 18:37 | |
| openstackgerrit | Jamie Lennox proposed openstack/django_openstack_auth: Create plugin model for DOA authentication https://review.openstack.org/153910 | 18:38 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: [Launch Instance Fix] Add details to Select Flavor step https://review.openstack.org/165260 | 18:38 |
| *** fthiagogv has quit IRC | 18:46 | |
| lhcheng | tqtran: ping | 18:46 |
| tqtran | lhcheng: pong | 18:47 |
| tqtran | tsufiev_: TravT will be able to help you there | 18:47 |
| tsufiev_ | tqtran, okay | 18:47 |
| lhcheng | tqtran: I have some time this week, do you need help with the websso patch? | 18:48 |
| tsufiev_ | TravT, could you shed some light onto that matter :)? | 18:48 |
| tqtran | lhcheng: sure, if you want to take over the tests in doa | 18:48 |
| lhcheng | tqtran: I am going to rebase it using the plugin model jamielennox is proposing | 18:49 |
| lhcheng | tqtran: yeah, and the test too | 18:49 |
| lhcheng | :) | 18:49 |
| lhcheng | tqtran: also have to figure out the project switching issue | 18:49 |
| tqtran | lhcheng: right, on phone atm, slow respond | 18:52 |
| lhcheng | tqtran: might need to update the horizon patch too, I'll update it as needed | 18:53 |
| openstackgerrit | Matt Borland proposed openstack/horizon: [Launch Instance Fix] Add Security Group Step Unit Tests https://review.openstack.org/167337 | 18:55 |
| openstackgerrit | Matt Borland proposed openstack/horizon: [Launch Instance Fix] Add Security Group Step Unit Tests https://review.openstack.org/167337 | 18:56 |
| openstackgerrit | Kelly Domico proposed openstack/horizon: [Launch Instance Fix] Adding validation https://review.openstack.org/165155 | 18:56 |
| *** mpavlase has joined #openstack-horizon | 18:57 | |
| tqtran | lhcheng: ok sounds good, thanks lin | 19:01 |
| tqtran | lhcheng: yeah, havent had time to look into issue yet, but i have a feeling it has to do with the redirect | 19:01 |
| tqtran | i believe that when the redirection happens, the request object is lost | 19:01 |
| lhcheng | tqtran: for federated user, we need a way to keep track of it and make a different user's project list API call | 19:06 |
| tqtran | yes, but i think we are making the right call. | 19:07 |
| lhcheng | tqtran: I remember you asked about adding that flag in the user object a week back | 19:07 |
| tqtran | https://review.openstack.org/#/c/136178/20/openstack_auth/user.py L290 | 19:08 |
| tqtran | https://review.openstack.org/#/c/136178/20/openstack_auth/utils.py L266 | 19:08 |
| tqtran | i put a breakpoint in there, and its called multiple times, i think a few of those are from horizon context selection | 19:09 |
| tqtran | for some reason, some of them dont contain the kwargs | 19:09 |
| tqtran | and i believe the redirection is wiping these kwargs | 19:10 |
| tqtran | but is just a theory, i havent look into it | 19:10 |
| lhcheng | tqtran: ah didn't notice the latest patch already have that flag | 19:10 |
| *** SimonChung has joined #openstack-horizon | 19:11 | |
| *** SimonChung1 has quit IRC | 19:11 | |
| *** jcoufal has joined #openstack-horizon | 19:11 | |
| *** e0ne has joined #openstack-horizon | 19:11 | |
| lhcheng | tqtran: yeah, that could be the reason. or we might need to put the flag somewhere it could persist | 19:11 |
| *** SimonChung1 has joined #openstack-horizon | 19:11 | |
| *** SimonChung has quit IRC | 19:12 | |
| lhcheng | tqtran: I'll take a look at it. | 19:12 |
| lhcheng | tqtran: going to incorporate the plugin model stuff first | 19:12 |
| tqtran | lhcheng: sounds good, thanks!! | 19:13 |
| tqtran | if you and i both work on it, who will approve it? lol | 19:13 |
| tqtran | do we have another core that knows doa well enough to +2? | 19:13 |
| lhcheng | tqtran: lol | 19:14 |
| lhcheng | good question | 19:14 |
| openstackgerrit | Matt Borland proposed openstack/horizon: [Launch Instance Fix] Add Keypair Step Unit Tests https://review.openstack.org/167338 | 19:14 |
| tqtran | can an exception be made? haha | 19:14 |
| tqtran | david-lyle: ^--- | 19:15 |
| lhcheng | have to find someone else to review and tests | 19:15 |
| lhcheng | maybe clu would be interested :) | 19:21 |
| *** matt-borland has quit IRC | 19:26 | |
| *** matt-borland has joined #openstack-horizon | 19:26 | |
| *** smc7 has quit IRC | 19:27 | |
| *** gyee has quit IRC | 19:30 | |
| *** dboik_ has quit IRC | 19:30 | |
| *** dboik has joined #openstack-horizon | 19:31 | |
| *** tosky has quit IRC | 19:31 | |
| tqtran | yeah i can talk to her about it | 19:31 |
| *** dboik_ has joined #openstack-horizon | 19:35 | |
| *** nlahouti has quit IRC | 19:36 | |
| tqtran | ongk: have you guys tried having a search bar and buttons docked at the right? | 19:37 |
| tqtran | its quite difficult | 19:38 |
| openstackgerrit | Brian Tully proposed openstack/horizon: Make donut chart styles common for all steps https://review.openstack.org/167377 | 19:38 |
| *** dboik has quit IRC | 19:38 | |
| *** morganfainberg is now known as needslesscoffee | 19:39 | |
| *** ccard_ has quit IRC | 19:43 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: [Launch Instance Fix] Add Details Step Unit Tests https://review.openstack.org/167333 | 19:44 |
| lhcheng | jamielennox: I think we should just raise an exception when no plugin is found: https://review.openstack.org/#/c/153910/ | 19:45 |
| lhcheng | jamielennox: the logic in views has been removed anyway, it should be fine to just raise an exception | 19:46 |
| jamielennox | lhcheng: i was basing this on the django defaults | 19:46 |
| jamielennox | umm let me find it | 19:46 |
| *** jtomasek has quit IRC | 19:46 | |
| lhcheng | jamielennox: just worried that there are some unexpected error down the line if we return Non | 19:46 |
| lhcheng | *None | 19:46 |
| jamielennox | lhcheng: https://docs.djangoproject.com/en/1.7/topics/auth/customizing/#writing-an-authentication-backend | 19:48 |
| *** ccard_ has joined #openstack-horizon | 19:48 | |
| jamielennox | Either way, authenticate should check the credentials it gets, and it should return a User object that matches those credentials, if the credentials are valid. If they’re not valid, it should return None. | 19:48 |
| jamielennox | and actually that is something that i think that the existing login form view didn't handle well | 19:48 |
| *** needslesscoffee is now known as morganfainberg | 19:50 | |
| TravT | tsufiev_: was out to lunch. sorry. still there? | 19:54 |
| *** jcoufal has quit IRC | 19:58 | |
| lhcheng | jamielennox: yeah, it doesn't handle it well. :( | 19:59 |
| ongk | @tqtran: I have tried adding search bar with buttons but not submitted in a patch anywhere | 19:59 |
| lhcheng | jamielennox: tried returning None, and got an erro 'AnonymousUser' object has no attribute 'backend' | 19:59 |
| *** ccard__ has joined #openstack-horizon | 20:00 | |
| tqtran | ongk: does it automatically resize on window resize? | 20:00 |
| *** bpokorny has joined #openstack-horizon | 20:00 | |
| tqtran | i got it to work as well, but css override | 20:00 |
| lhcheng | jamielennox: the code in the forms that authenticate should return something, otherwise unexpected things would happen | 20:01 |
| lhcheng | jamielennox: https://github.com/openstack/django_openstack_auth/blob/master/openstack_auth/forms.py#L98 | 20:01 |
| ongk | tqtran: The search bar resizes, the buttons remain the same width | 20:01 |
| tqtran | can you show me the html? | 20:02 |
| *** ccard_ has quit IRC | 20:02 | |
| *** Drago has quit IRC | 20:02 | |
| tqtran | would be nice if it is supported out of the box, but im ok if we have to override it for each panel as well. | 20:02 |
| *** Drago has joined #openstack-horizon | 20:02 | |
| *** bpokorny_ has quit IRC | 20:03 | |
| jamielennox | lhcheng: that seems like something we should fix in the forms rather than make the plugin adopt right? | 20:03 |
| lhcheng | jamielennox: true.. could add a check in the form if authenticate returns None | 20:04 |
| lhcheng | okay, let's keep it as is. | 20:04 |
| lhcheng | jamielennox: can work on the form as follow-up patch | 20:05 |
| *** asahlin_ has joined #openstack-horizon | 20:05 | |
| jamielennox | lhcheng: sure, can do - its fairly unlikely if you have properly configured horizon that you'd get None returned there anyway | 20:05 |
| jamielennox | maybe at the very least a warning should be logged there because it is essentially a bad configuration if you can't find any plugin | 20:06 |
| lhcheng | yup, that would be good | 20:06 |
| *** neelashah has joined #openstack-horizon | 20:06 | |
| *** smc7 has joined #openstack-horizon | 20:07 | |
| *** SimonChung1 has quit IRC | 20:08 | |
| *** SimonChung has joined #openstack-horizon | 20:08 | |
| openstackgerrit | Kelly Domico proposed openstack/horizon: [Launch Instance Fix] Adding validation https://review.openstack.org/165155 | 20:10 |
| jamielennox | lhcheng: you +2ed - do you want me to add the warning to this patch or add after/ | 20:12 |
| ongk | tqtran: I can show you after my meetings :) | 20:12 |
| *** akanksha has joined #openstack-horizon | 20:12 | |
| lhcheng | jamielennox: I didn't think it was a blocker so gave it a +2, but you can add the warning now. I'll +2 it again. | 20:13 |
| tqtran | ongk: sounds good, lets compare notes and see which works | 20:13 |
| jamielennox | lhcheng: are you looking at the websso patches? | 20:19 |
| *** tyr_ has quit IRC | 20:20 | |
| jamielennox | lhcheng: https://review.openstack.org/#/c/136178/20 would seem to be able to be extracted into a new package | 20:20 |
| jamielennox | lhcheng: i don't know how to link in some of the changes https://review.openstack.org/#/c/151842/ into that package - but i think it should be possible | 20:21 |
| lhcheng | jamielennox: yeah, I am planning to update the websso patches after the plugin lands | 20:21 |
| jamielennox | david-lyle: if you're around can you have a look at https://review.openstack.org/#/c/153910/ we're looking at patches post this and it'd be good to know if it needs a new spin | 20:22 |
| openstackgerrit | Kelly Domico proposed openstack/horizon: [Launch Instance Fix] Adding validation https://review.openstack.org/165155 | 20:22 |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 20:26 | |
| r1chardj0n3s | morning | 20:26 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: [Launch Instance Fix] Adding launch details step https://review.openstack.org/166561 | 20:29 |
| *** peristeri has quit IRC | 20:30 | |
| *** nlahouti has joined #openstack-horizon | 20:31 | |
| openstackgerrit | Kelly Domico proposed openstack/horizon: [Launch Instance Fix] Smart-Table Client Side Magic Search https://review.openstack.org/166080 | 20:34 |
| *** andrewbogott is now known as andrewbogott_afk | 20:37 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: [Launch Instance Fix] Adding launch details step https://review.openstack.org/166561 | 20:43 |
| *** matt-borland has quit IRC | 20:46 | |
| *** matt-borland has joined #openstack-horizon | 20:46 | |
| *** sayan has quit IRC | 20:46 | |
| *** neelashah has quit IRC | 20:47 | |
| *** nlahouti has quit IRC | 20:55 | |
| *** samueldmq is now known as samueldmq-away | 20:55 | |
| *** andrewbogott_afk is now known as andrewbogott | 20:58 | |
| *** ericpete_ has joined #openstack-horizon | 21:00 | |
| openstackgerrit | Jamie Lennox proposed openstack/django_openstack_auth: Expose keystone client version as a plugin property https://review.openstack.org/167402 | 21:00 |
| david-lyle | jamielennox: why are we losing the username in the logging in doa? | 21:02 |
| jamielennox | david-lyle: because we can't know that it's there | 21:02 |
| jamielennox | in the case of kerberos for example there isn't a username | 21:02 |
| jamielennox | or at least not that's exposed there | 21:03 |
| david-lyle | makes the log message a lot less valuable, but yes, I understand | 21:03 |
| *** ericpeterson has quit IRC | 21:03 | |
| jamielennox | so there are follow ups that we could do, for example put a log message into the password plugin | 21:03 |
| david-lyle | won't line 107 be misleading as well | 21:03 |
| david-lyle | ? | 21:04 |
| jamielennox | we could have the plugin provide like an identifier | 21:04 |
| david-lyle | in backends.py | 21:04 |
| jamielennox | that could be logged | 21:04 |
| jamielennox | david-lyle: yea, that should probably become Invalid credentials | 21:04 |
| *** SimonChung has quit IRC | 21:04 | |
| *** SimonChung1 has joined #openstack-horizon | 21:04 | |
| david-lyle | minor issue | 21:05 |
| *** lhcheng has quit IRC | 21:05 | |
| *** lhcheng has joined #openstack-horizon | 21:05 | |
| jamielennox | yep, up to you if you want to -1 or let me follow up. I need to do a follow up to log where no plugin is found anyway | 21:05 |
| *** openstackgerrit has quit IRC | 21:07 | |
| david-lyle | jamielennox: I'll approve and we can fix in a follow on | 21:07 |
| *** openstackgerrit has joined #openstack-horizon | 21:07 | |
| david-lyle | I also agree that None is probably the wrong thing to return | 21:07 |
| david-lyle | in the failure case | 21:07 |
| jamielennox | david-lyle: so that's a django thing, i had a link | 21:08 |
| david-lyle | don't you go educating me | 21:08 |
| david-lyle | :P | 21:08 |
| jamielennox | https://docs.djangoproject.com/en/1.7/topics/auth/customizing/#writing-an-authentication-backend | 21:08 |
| david-lyle | I see it above | 21:08 |
| jamielennox | however we are so tightly couple to the DOA specifics that it maybe doesn't matter | 21:09 |
| jamielennox | i think another auth plugin would have problems anyway | 21:09 |
| david-lyle | let's fix it if it's problematic | 21:09 |
| jamielennox | or enabling multiple backends at the same time | 21:10 |
| david-lyle | +A'd | 21:11 |
| *** gokrokve has joined #openstack-horizon | 21:13 | |
| jamielennox | david-lyle: \o/ | 21:15 |
| *** e0ne is now known as e0ne_ | 21:18 | |
| *** neelashah has joined #openstack-horizon | 21:20 | |
| *** lblanchard has quit IRC | 21:20 | |
| openstackgerrit | Jamie Lennox proposed openstack/django_openstack_auth: Follow ups to Authentication Plugins https://review.openstack.org/167404 | 21:21 |
| openstackgerrit | Gary W. Smith proposed openstack/horizon: Use custom form for Volume Transfer Details https://review.openstack.org/167405 | 21:21 |
| jamielennox | david-lyle, lhcheng: ^ follow ups patch | 21:21 |
| *** julim has quit IRC | 21:26 | |
| *** bpokorny_ has joined #openstack-horizon | 21:27 | |
| *** bpokorny has quit IRC | 21:30 | |
| *** annashen has joined #openstack-horizon | 21:32 | |
| *** harlowja is now known as harlowja_away | 21:32 | |
| lhcheng | jamielennox: thanks! | 21:35 |
| *** annashen has quit IRC | 21:36 | |
| *** jmolo has quit IRC | 21:40 | |
| *** jtriley has quit IRC | 21:40 | |
| *** jmolo has joined #openstack-horizon | 21:40 | |
| *** mwhagedorn has quit IRC | 21:40 | |
| *** jmolo has quit IRC | 21:41 | |
| *** akrivoka has quit IRC | 21:45 | |
| *** robcresswell_afk has quit IRC | 21:48 | |
| *** xnox has quit IRC | 21:48 | |
| *** dloi_ has quit IRC | 21:48 | |
| *** tristanC has quit IRC | 21:48 | |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: Update Magic Search https://review.openstack.org/166374 | 21:49 |
| *** robcresswell_afk has joined #openstack-horizon | 21:49 | |
| *** xnox has joined #openstack-horizon | 21:49 | |
| *** dloi_ has joined #openstack-horizon | 21:49 | |
| *** tristanC has joined #openstack-horizon | 21:49 | |
| *** mattfarina has quit IRC | 21:53 | |
| *** mark-os has quit IRC | 21:56 | |
| *** matt-borland has quit IRC | 21:56 | |
| *** radez is now known as radez_g0n3 | 21:56 | |
| openstackgerrit | Merged openstack/django_openstack_auth: Create plugin model for DOA authentication https://review.openstack.org/153910 | 21:57 |
| *** vijendar has quit IRC | 21:58 | |
| *** nlahouti has joined #openstack-horizon | 21:59 | |
| *** nlahouti has quit IRC | 21:59 | |
| *** neelashah has quit IRC | 22:00 | |
| *** nlahouti has joined #openstack-horizon | 22:02 | |
| lhcheng | \o/ | 22:02 |
| *** lhcheng has quit IRC | 22:04 | |
| *** SimonChung1 has quit IRC | 22:04 | |
| *** alanf-mc has quit IRC | 22:05 | |
| *** alanf-mc_ has joined #openstack-horizon | 22:05 | |
| *** harlowja_away is now known as harlowja | 22:05 | |
| openstackgerrit | Jamie Lennox proposed openstack/django_openstack_auth: Follow ups to Authentication Plugins https://review.openstack.org/167404 | 22:06 |
| *** lhcheng has joined #openstack-horizon | 22:06 | |
| *** oro has quit IRC | 22:06 | |
| *** oro_ has quit IRC | 22:07 | |
| *** oro has joined #openstack-horizon | 22:07 | |
| *** andrewbogott is now known as andrewbogott_afk | 22:07 | |
| jamielennox | david-lyle, lhcheng: so somewhat of a bikeshed issue, is there a reason to use _ rather than - in the package name for DOA | 22:07 |
| jamielennox | if i look at creating a new package for kerberos typically i'd called it django-openstack-auth-kerberos | 22:08 |
| jamielennox | or should i follow existing? | 22:08 |
| *** SimonChung has joined #openstack-horizon | 22:09 | |
| *** sbfox1 has joined #openstack-horizon | 22:09 | |
| openstackgerrit | Merged openstack/horizon: Change preset for resource usage to 'last day' https://review.openstack.org/167190 | 22:10 |
| *** SimonChung has quit IRC | 22:10 | |
| *** sbfox has quit IRC | 22:10 | |
| david-lyle | jamielennox: honestly I have no idea, named before I got involved | 22:11 |
| david-lyle | hyphens should be fine | 22:11 |
| jamielennox | cool, it does seem to be the python standard | 22:11 |
| *** Piet has quit IRC | 22:13 | |
| *** SimonChung has joined #openstack-horizon | 22:15 | |
| openstackgerrit | Lin Hua Cheng proposed openstack/django_openstack_auth: Updated parsing of catalog to handle bad format https://review.openstack.org/159303 | 22:19 |
| r1chardj0n3s | jamielennox: most of the tools will normalise the - and _, but convention tends to use the hyphens, yes. | 22:20 |
| ongk | tqtran: ping | 22:21 |
| jamielennox | r1chardj0n3s: yep, the module name needs to use the _ i wasn't sure if it was maybe a django thing to use the _ in the package name | 22:21 |
| tqtran | ongk: hey kelly | 22:21 |
| tqtran | you ready to compare notes? | 22:21 |
| ongk | sure! | 22:22 |
| *** jcoufal has joined #openstack-horizon | 22:23 | |
| *** jecarey has quit IRC | 22:25 | |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: Add Magic Search to users table https://review.openstack.org/151386 | 22:25 |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: WIP angularize identity users. https://review.openstack.org/133767 | 22:25 |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: Modified hzSelectAll to watch changes in row length https://review.openstack.org/166394 | 22:25 |
| *** e0ne_ has quit IRC | 22:25 | |
| *** jrist has quit IRC | 22:28 | |
| *** smc7 has quit IRC | 22:28 | |
| *** jrist has joined #openstack-horizon | 22:29 | |
| *** asahlin_ has quit IRC | 22:30 | |
| *** lhcheng_ has joined #openstack-horizon | 22:39 | |
| *** lhcheng has quit IRC | 22:39 | |
| *** sbfox1 has quit IRC | 22:42 | |
| *** smc7 has joined #openstack-horizon | 22:42 | |
| *** sbfox has joined #openstack-horizon | 22:44 | |
| *** asahlin_ has joined #openstack-horizon | 22:47 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: [Launch Instance Fix] Add Flavor Step Unit Tests https://review.openstack.org/167326 | 22:48 |
| *** mwhagedorn has joined #openstack-horizon | 22:52 | |
| *** absubram has quit IRC | 22:53 | |
| *** sbfox has quit IRC | 22:53 | |
| *** mattfarina has joined #openstack-horizon | 22:54 | |
| *** Piet has joined #openstack-horizon | 22:56 | |
| TravT | r1chardj0n3s: how's it going? | 22:58 |
| r1chardj0n3s | TravT: heya, good. in a cafe about to have my standup meeting and then back to horizon before my dentist appointment ;) how's you? | 22:59 |
| TravT | pretty good... no coding yet today, though. spent most the day in discussion / reviews on validation. | 23:00 |
| TravT | anyway, i spoke with a bunch of people today about what would be good for you to pick up. | 23:00 |
| TravT | obviously there are several ?? items in the list, but several people specifically said that they'd love to get some reviews from you today on existing patches up for review | 23:01 |
| r1chardj0n3s | yep | 23:01 |
| r1chardj0n3s | ok, focus help is good :) | 23:01 |
| TravT | matt put up initial patches for tests on all steps | 23:02 |
| TravT | as well, so you could add into those as well. | 23:02 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: WIP Angular alert/messaging service https://review.openstack.org/134250 | 23:02 |
| r1chardj0n3s | yep | 23:03 |
| TravT | I haven't looked at neil's keypair patch, but if he's out, maybe you could finish it out if it isn't finished? | 23:05 |
| r1chardj0n3s | yep, that's my plan, but I'm having trouble contacting him about it | 23:06 |
| r1chardj0n3s | apparently he had many issues with opening a dialog from the wizard (competing for modality) so I wouldn't want to have to duplicate that pain | 23:06 |
| TravT | but it sounds like fun! ;) | 23:07 |
| TravT | that does play into my other idea on the network subflow and security group subflow, but i think we're trying to flush the q as much as possible at this point. | 23:09 |
| *** SimonChung1 has joined #openstack-horizon | 23:11 | |
| *** SimonChung2 has joined #openstack-horizon | 23:11 | |
| *** SimonChung3 has joined #openstack-horizon | 23:11 | |
| *** welldannit has joined #openstack-horizon | 23:11 | |
| *** SimonChung2 has quit IRC | 23:12 | |
| *** SimonChung1 has quit IRC | 23:12 | |
| *** SimonChung has quit IRC | 23:12 | |
| openstackgerrit | Brian Tully proposed openstack/horizon: Make donut chart styles common for all steps https://review.openstack.org/167377 | 23:12 |
| r1chardj0n3s | are the reviews needing attention the ones listed in the etherpad? | 23:12 |
| *** SimonChung has joined #openstack-horizon | 23:13 | |
| *** SimonChung3 has quit IRC | 23:13 | |
| TravT | The top list of reviews | 23:13 |
| TravT | they are in sort of priority order | 23:13 |
| *** SimonChung has quit IRC | 23:13 | |
| *** SimonChung has joined #openstack-horizon | 23:13 | |
| TravT | For example, Tyr updated flavors today | 23:14 |
| *** ericpete_ has quit IRC | 23:15 | |
| *** ericpeterson has joined #openstack-horizon | 23:17 | |
| *** tnovacik has quit IRC | 23:17 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: WIP angularize identity users. https://review.openstack.org/133767 | 23:19 |
| *** chlong has joined #openstack-horizon | 23:20 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding transclude to search-bar for batch actions https://review.openstack.org/167446 | 23:28 |
| tqtran | ongk: listing you as co-author for patch above ;) | 23:28 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding transclude to search-bar for batch actions https://review.openstack.org/167446 | 23:29 |
| ongk | tqtran: haha, cool | 23:29 |
| r1chardj0n3s | hey, so there's a thing | 23:32 |
| r1chardj0n3s | TravT, ongk, tqtran, david-lyle: so the ['$bizarre', function ($bizarre) {...}] name duplication stuff in angularjs is done to make dependency injection work in the face of name-mangling JS minifiers | 23:33 |
| *** annashen has joined #openstack-horizon | 23:34 | |
| r1chardj0n3s | so I looked into how to turn off name mangling in our minifier so we didn't have to do the name duplication any longer | 23:34 |
| r1chardj0n3s | ... | 23:34 |
| tqtran | r1chardj0n3s: yes, thats why we do it :) | 23:34 |
| tqtran | really? :O | 23:34 |
| *** stevemar has quit IRC | 23:34 | |
| *** ericpeterson has quit IRC | 23:34 | |
| r1chardj0n3s | and it turns out, the minifer we use *does no name mangling* | 23:34 |
| r1chardj0n3s | so we're doing it entirely without purpose | 23:34 |
| tqtran | i think it was mostly as a safeguard, for if we do switch to one that mangles name | 23:35 |
| *** chlong has quit IRC | 23:35 | |
| *** stevemar has joined #openstack-horizon | 23:35 | |
| tqtran | although, im totally ok with not using it, makes code reading so much nicer | 23:35 |
| r1chardj0n3s | tqtran: no, I think it's reasonable to require no name mangling in any JS minification | 23:35 |
| r1chardj0n3s | yes | 23:35 |
| *** chlong has joined #openstack-horizon | 23:35 | |
| r1chardj0n3s | so, I propose that we stop name duplication, and even remove it from the launch instance code as we make other edits | 23:36 |
| TravT | r1chardj0n3s: david-lyle: do we know if any deployers use a different minifier? | 23:36 |
| tqtran | sounds good to me, lets bring it up at meeting and get general consensus | 23:36 |
| tqtran | before we start enforcing it in code review | 23:37 |
| TravT | yeah, sounds like a clean sweep pass could be done, if we can do that | 23:37 |
| r1chardj0n3s | deployers using a different minifier would be ... odd | 23:37 |
| *** annashen has quit IRC | 23:38 | |
| tqtran | you can config most minifiers to not mangle names anyhow | 23:38 |
| TravT | Wasn't there was a bunch of discussion saying just zip the things and knock off the name mangling all together anyway. | 23:38 |
| r1chardj0n3s | and regardless, the couple of minifiers I looked into that did name mangling had options to turn that feature off | 23:38 |
| r1chardj0n3s | tqtran: yeah | 23:38 |
| r1chardj0n3s | TravT: actually, was to gzip and turn off *minification* altogether | 23:39 |
| r1chardj0n3s | though keeping concatenation | 23:39 |
| r1chardj0n3s | obvs. | 23:39 |
| r1chardj0n3s | hm. Horion meeting page is quite out of date ;) | 23:40 |
| TravT | can we make the first script defined be one that would somehow identify if name mangling was turned on and display an warning message? | 23:40 |
| r1chardj0n3s | TravT: hmm, could be interesting to implement, yeah | 23:40 |
| * TravT thinking of how can we avoid answering that support question 300 times | 23:40 | |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 23:43 | |
| *** smc7 has quit IRC | 23:51 | |
| *** ZZelle_ has quit IRC | 23:52 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: [Launch Instance Fix] Add details to Select Flavor step https://review.openstack.org/165260 | 23:53 |
| *** gyee has joined #openstack-horizon | 23:54 | |
| *** lhcheng_ is now known as lhcheng | 23:57 | |
| *** mwhagedorn has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!