| *** lhcheng_ has quit IRC | 00:00 | |
| *** Sukhdev has quit IRC | 00:01 | |
| *** dboik has joined #openstack-horizon | 00:03 | |
| *** lhcheng has joined #openstack-horizon | 00:03 | |
| *** ericpeterson has quit IRC | 00:14 | |
| lhcheng | david-lyle: do you recall why we changed the django min version to 1.4.2? | 00:17 |
|---|---|---|
| david-lyle | no, probably the latest in the 1.4 base at the time | 00:17 |
| david-lyle | but really I have no idea | 00:18 |
| lhcheng | I can't seem to find a django rpm >= 1.4.2 that works with python2.6 :( | 00:18 |
| lhcheng | don't ask why python2.6 | 00:18 |
| lhcheng | :P | 00:18 |
| *** dboik has quit IRC | 00:22 | |
| *** SimonChung has joined #openstack-horizon | 00:23 | |
| *** SimonChung has quit IRC | 00:23 | |
| *** SimonChung2 has joined #openstack-horizon | 00:23 | |
| *** SimonChung1 has quit IRC | 00:23 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Launch Instance Model https://review.openstack.org/158929 | 00:23 |
| david-lyle | why 2.6? | 00:24 |
| david-lyle | :) | 00:24 |
| david-lyle | we don't support that anymore | 00:24 |
| *** SimonChung2 has quit IRC | 00:24 | |
| *** SimonChung has joined #openstack-horizon | 00:24 | |
| david-lyle | probably bumped and not actually tested, but no idea | 00:24 |
| *** SimonChung1 has joined #openstack-horizon | 00:25 | |
| *** SimonChung has quit IRC | 00:25 | |
| *** david-lyle is now known as david-lyle_afk | 00:25 | |
| openstackgerrit | Brian Tully proposed openstack/horizon: Demo for editable table field directive https://review.openstack.org/158931 | 00:26 |
| lhcheng | juno still should :) | 00:26 |
| openstackgerrit | Merged openstack/horizon: Adding Angular IrDragNDrop to requirements.txt https://review.openstack.org/147366 | 00:26 |
| lhcheng | david-lyle: I've reached out to the metacloud folks about the horizon theming, they may have some spare bandwidth to work on it. | 00:27 |
| lhcheng | david-lyle_afk ^ | 00:28 |
| *** sbfox has quit IRC | 00:33 | |
| openstackgerrit | Brian Tully proposed openstack/horizon: Directive to allow editing of table cell values https://review.openstack.org/158004 | 00:37 |
| *** mattfarina has quit IRC | 00:38 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Launch Instance Step - Select Source https://review.openstack.org/158934 | 00:38 |
| openstackgerrit | Brian Tully proposed openstack/horizon: Demo for editable table field directive https://review.openstack.org/158931 | 00:40 |
| *** peristeri has quit IRC | 00:40 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Refactor REST API tests for common code patterns https://review.openstack.org/158936 | 00:48 |
| *** peristeri has joined #openstack-horizon | 00:58 | |
| *** SimonChung has joined #openstack-horizon | 01:02 | |
| *** SimonChung1 has quit IRC | 01:02 | |
| *** SimonChung1 has joined #openstack-horizon | 01:04 | |
| *** SimonChung has quit IRC | 01:04 | |
| *** lsmola has quit IRC | 01:07 | |
| *** lsmola has joined #openstack-horizon | 01:09 | |
| *** openstack has joined #openstack-horizon | 01:11 | |
| *** ccard_ has quit IRC | 01:16 | |
| *** robcresswell_afk has quit IRC | 01:16 | |
| *** radez_g0n3 has quit IRC | 01:16 | |
| *** dloi_ has quit IRC | 01:16 | |
| *** lifeless has quit IRC | 01:16 | |
| *** tristanC has quit IRC | 01:16 | |
| *** ccard_ has joined #openstack-horizon | 01:17 | |
| *** Longgeek has joined #openstack-horizon | 01:18 | |
| *** Longgeek has quit IRC | 01:18 | |
| *** alexvictorchan has quit IRC | 01:19 | |
| *** robcresswell_afk has joined #openstack-horizon | 01:20 | |
| *** radez_g0n3 has joined #openstack-horizon | 01:20 | |
| *** dloi_ has joined #openstack-horizon | 01:20 | |
| *** lifeless has joined #openstack-horizon | 01:20 | |
| *** tristanC has joined #openstack-horizon | 01:20 | |
| *** lifeless has quit IRC | 01:20 | |
| *** lifeless has joined #openstack-horizon | 01:21 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Launch Instance Step - Select Source https://review.openstack.org/158934 | 01:22 |
| *** KanagarajM has joined #openstack-horizon | 01:25 | |
| *** Longgeek has joined #openstack-horizon | 01:25 | |
| *** amotoki has joined #openstack-horizon | 01:26 | |
| *** dboik has joined #openstack-horizon | 01:30 | |
| *** lhcheng has quit IRC | 01:30 | |
| *** peristeri has quit IRC | 01:33 | |
| *** nlahouti has quit IRC | 01:34 | |
| *** gyee has quit IRC | 01:35 | |
| *** pashkin has quit IRC | 01:35 | |
| *** ekarlso has quit IRC | 01:35 | |
| *** davelowe has quit IRC | 01:35 | |
| *** esp has quit IRC | 01:35 | |
| *** mordred has quit IRC | 01:35 | |
| *** anteaya has quit IRC | 01:35 | |
| *** btully has quit IRC | 01:35 | |
| *** NikitaKonovalov has quit IRC | 01:35 | |
| *** sambetts has quit IRC | 01:35 | |
| *** svasheka has quit IRC | 01:35 | |
| *** agvanya has quit IRC | 01:35 | |
| *** vkmc has quit IRC | 01:35 | |
| *** baffle has quit IRC | 01:35 | |
| *** Madkiss has quit IRC | 01:35 | |
| *** TravT has quit IRC | 01:36 | |
| *** alanf-mc has quit IRC | 01:36 | |
| *** ericpeterson has joined #openstack-horizon | 01:38 | |
| *** gyee has joined #openstack-horizon | 01:39 | |
| *** btully has joined #openstack-horizon | 01:39 | |
| *** ekarlso has joined #openstack-horizon | 01:39 | |
| *** pashkin has joined #openstack-horizon | 01:39 | |
| *** NikitaKonovalov has joined #openstack-horizon | 01:39 | |
| *** sambetts has joined #openstack-horizon | 01:39 | |
| *** esp has joined #openstack-horizon | 01:39 | |
| *** davelowe has joined #openstack-horizon | 01:39 | |
| *** mordred has joined #openstack-horizon | 01:39 | |
| *** anteaya has joined #openstack-horizon | 01:39 | |
| *** svasheka has joined #openstack-horizon | 01:39 | |
| *** agvanya has joined #openstack-horizon | 01:39 | |
| *** vkmc has joined #openstack-horizon | 01:39 | |
| *** baffle has joined #openstack-horizon | 01:39 | |
| *** Madkiss has joined #openstack-horizon | 01:39 | |
| *** gyee has quit IRC | 01:40 | |
| *** pashkin has quit IRC | 01:40 | |
| *** ekarlso has quit IRC | 01:40 | |
| *** davelowe has quit IRC | 01:40 | |
| *** esp has quit IRC | 01:40 | |
| *** mordred has quit IRC | 01:40 | |
| *** anteaya has quit IRC | 01:40 | |
| *** btully has quit IRC | 01:40 | |
| *** NikitaKonovalov has quit IRC | 01:40 | |
| *** sambetts has quit IRC | 01:40 | |
| *** svasheka has quit IRC | 01:40 | |
| *** agvanya has quit IRC | 01:40 | |
| *** vkmc has quit IRC | 01:40 | |
| *** baffle has quit IRC | 01:40 | |
| *** Madkiss has quit IRC | 01:40 | |
| *** clu_ has quit IRC | 01:40 | |
| *** tqtran_ has quit IRC | 01:40 | |
| *** fischerw has quit IRC | 01:40 | |
| *** david-lyle_afk has quit IRC | 01:40 | |
| *** jrist has quit IRC | 01:40 | |
| *** gyee has joined #openstack-horizon | 01:41 | |
| *** btully has joined #openstack-horizon | 01:41 | |
| *** ekarlso has joined #openstack-horizon | 01:41 | |
| *** pashkin has joined #openstack-horizon | 01:41 | |
| *** NikitaKonovalov has joined #openstack-horizon | 01:41 | |
| *** sambetts has joined #openstack-horizon | 01:41 | |
| *** esp has joined #openstack-horizon | 01:41 | |
| *** davelowe has joined #openstack-horizon | 01:41 | |
| *** mordred has joined #openstack-horizon | 01:41 | |
| *** anteaya has joined #openstack-horizon | 01:41 | |
| *** svasheka has joined #openstack-horizon | 01:41 | |
| *** agvanya has joined #openstack-horizon | 01:41 | |
| *** vkmc has joined #openstack-horizon | 01:41 | |
| *** baffle has joined #openstack-horizon | 01:41 | |
| *** Madkiss has joined #openstack-horizon | 01:41 | |
| *** alanf-mc has joined #openstack-horizon | 01:41 | |
| *** alanf-mc has quit IRC | 01:42 | |
| *** alanf-mc has joined #openstack-horizon | 01:42 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Launch Instance Step - Select Flavor https://review.openstack.org/158945 | 01:43 |
| *** KanagarajM has quit IRC | 01:48 | |
| *** Longgeek has quit IRC | 01:49 | |
| *** iamjarvo has quit IRC | 01:49 | |
| *** wchrisj has quit IRC | 01:54 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Launch Instance Step - Access and Security https://review.openstack.org/158949 | 01:55 |
| *** gyee has quit IRC | 01:56 | |
| *** jamielennox is now known as jamielennox|away | 01:58 | |
| *** ayoung has joined #openstack-horizon | 01:59 | |
| *** clu_ has joined #openstack-horizon | 01:59 | |
| *** fischerw has joined #openstack-horizon | 01:59 | |
| *** david-lyle_afk has joined #openstack-horizon | 01:59 | |
| *** jrist has joined #openstack-horizon | 01:59 | |
| *** sendak.freenode.net sets mode: +o david-lyle_afk | 01:59 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Launch Instance Step - Network https://review.openstack.org/158950 | 02:02 |
| *** davelowe has quit IRC | 02:04 | |
| *** jamielennox|away is now known as jamielennox | 02:06 | |
| *** harlowja has quit IRC | 02:07 | |
| *** harlowja_ has joined #openstack-horizon | 02:07 | |
| *** bpokorny has quit IRC | 02:09 | |
| *** ayoung has quit IRC | 02:10 | |
| *** clu_ has quit IRC | 02:10 | |
| *** fischerw has quit IRC | 02:10 | |
| *** david-lyle_afk has quit IRC | 02:10 | |
| *** jrist has quit IRC | 02:10 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Launch Instance Step - Select Source https://review.openstack.org/158953 | 02:12 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Launch Instance Step - Post Creation https://review.openstack.org/158953 | 02:13 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Launch Instance Step - Post Creation https://review.openstack.org/158953 | 02:14 |
| *** ayoung has joined #openstack-horizon | 02:16 | |
| *** fischerw has joined #openstack-horizon | 02:16 | |
| *** david-lyle_afk has joined #openstack-horizon | 02:16 | |
| *** jrist has joined #openstack-horizon | 02:16 | |
| *** sendak.freenode.net sets mode: +o david-lyle_afk | 02:16 | |
| *** jamielennox is now known as jamielennox|away | 02:17 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Launch Instance Step - Select Source https://review.openstack.org/158934 | 02:18 |
| *** SimonChung1 has quit IRC | 02:18 | |
| *** Longgeek has joined #openstack-horizon | 02:18 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Launch Instance Step - Select Flavor https://review.openstack.org/158945 | 02:19 |
| *** alanf-mc has quit IRC | 02:19 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Launch Instance Step - Network https://review.openstack.org/158950 | 02:20 |
| *** nlahouti has joined #openstack-horizon | 02:21 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Launch Instance Step - Access and Security https://review.openstack.org/158949 | 02:21 |
| *** nlahouti has quit IRC | 02:26 | |
| *** jamielennox|away is now known as jamielennox | 02:27 | |
| *** DaveJ__ has quit IRC | 02:30 | |
| *** calinux has joined #openstack-horizon | 02:35 | |
| *** jamielennox is now known as jamielennox|away | 02:38 | |
| *** iamjarvo has joined #openstack-horizon | 02:40 | |
| *** iamjarvo has joined #openstack-horizon | 02:41 | |
| *** iamjarvo has joined #openstack-horizon | 02:41 | |
| *** ericpeterson has quit IRC | 02:44 | |
| *** jamielennox|away is now known as jamielennox | 02:47 | |
| *** calinux has quit IRC | 02:49 | |
| *** mwhagedorn has joined #openstack-horizon | 02:53 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Refactor REST API tests for common code patterns https://review.openstack.org/158936 | 02:53 |
| *** stevemar has joined #openstack-horizon | 02:57 | |
| *** ybathia has quit IRC | 02:57 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Refactor REST API tests for common code patterns https://review.openstack.org/158936 | 02:58 |
| *** ybathia has joined #openstack-horizon | 02:59 | |
| *** ybathia has quit IRC | 03:00 | |
| *** ericpeterson has joined #openstack-horizon | 03:03 | |
| *** calinux has joined #openstack-horizon | 03:09 | |
| *** davelowe has joined #openstack-horizon | 03:14 | |
| *** devlaps has joined #openstack-horizon | 03:14 | |
| *** ericpeterson has quit IRC | 03:15 | |
| *** jamielennox is now known as jamielennox|away | 03:22 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Refactor REST API tests for common code patterns https://review.openstack.org/158936 | 03:26 |
| *** jamielennox|away is now known as jamielennox | 03:33 | |
| openstackgerrit | Trung Trinh proposed openstack/horizon: Ignore Exception in process of Edit Attachments https://review.openstack.org/153460 | 03:38 |
| *** mwhagedorn has quit IRC | 03:38 | |
| *** ericpeterson has joined #openstack-horizon | 03:40 | |
| *** devlaps has quit IRC | 03:40 | |
| *** ericpeterson has quit IRC | 03:48 | |
| *** Longgeek has quit IRC | 03:52 | |
| *** fischerw has quit IRC | 03:58 | |
| *** SimonChung has joined #openstack-horizon | 04:02 | |
| *** Drago has quit IRC | 04:02 | |
| *** SimonChung1 has joined #openstack-horizon | 04:03 | |
| *** TravT has joined #openstack-horizon | 04:05 | |
| *** harlowja_ is now known as harlowja_away | 04:06 | |
| *** SimonChung has quit IRC | 04:06 | |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 04:11 | |
| openstackgerrit | Diego proposed openstack/horizon: spelling mistakes on display outputs and docsstrings https://review.openstack.org/158976 | 04:11 |
| *** ericpeterson has joined #openstack-horizon | 04:14 | |
| *** mwhagedorn has joined #openstack-horizon | 04:14 | |
| *** bpokorny has joined #openstack-horizon | 04:19 | |
| *** sbfox has joined #openstack-horizon | 04:20 | |
| *** bpokorny has quit IRC | 04:20 | |
| *** bpokorny has joined #openstack-horizon | 04:21 | |
| *** ericpeterson has quit IRC | 04:29 | |
| *** ozialien has joined #openstack-horizon | 04:29 | |
| *** ericpeterson has joined #openstack-horizon | 04:37 | |
| *** nlahouti has joined #openstack-horizon | 04:38 | |
| *** ericpeterson has quit IRC | 04:44 | |
| *** nlahouti has quit IRC | 04:44 | |
| *** nlahouti has joined #openstack-horizon | 04:44 | |
| *** Longgeek has joined #openstack-horizon | 04:46 | |
| *** ericpeterson has joined #openstack-horizon | 04:48 | |
| *** alexvictorchan has joined #openstack-horizon | 04:49 | |
| *** ericpeterson has quit IRC | 04:52 | |
| *** alexvictorchan has quit IRC | 04:55 | |
| *** alexvictorchan has joined #openstack-horizon | 04:55 | |
| *** iamjarvo has quit IRC | 04:56 | |
| *** alexvictorchan has quit IRC | 04:59 | |
| *** TravT has quit IRC | 05:05 | |
| *** Longgeek has quit IRC | 05:07 | |
| *** Longgeek has joined #openstack-horizon | 05:07 | |
| *** calinux_ has joined #openstack-horizon | 05:08 | |
| *** ozialien has quit IRC | 05:09 | |
| openstackgerrit | lawrancejing proposed openstack/horizon: Remove unused code for sidebar https://review.openstack.org/158992 | 05:11 |
| *** bpokorny has quit IRC | 05:12 | |
| *** mwhagedorn has quit IRC | 05:14 | |
| *** bpokorny has joined #openstack-horizon | 05:16 | |
| *** bpokorny has quit IRC | 05:17 | |
| *** TravT has joined #openstack-horizon | 05:23 | |
| openstackgerrit | Merged openstack/horizon: Updated from global requirements https://review.openstack.org/158749 | 05:28 |
| *** TravT has quit IRC | 05:34 | |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 05:35 | |
| *** lhcheng has joined #openstack-horizon | 05:45 | |
| *** sbfox has quit IRC | 05:46 | |
| *** jcoufal has joined #openstack-horizon | 05:46 | |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 05:49 | |
| *** Longgeek has quit IRC | 05:50 | |
| *** Longgeek has joined #openstack-horizon | 05:52 | |
| *** sbfox has joined #openstack-horizon | 05:54 | |
| *** jcoufal has quit IRC | 05:59 | |
| *** lhcheng_ has joined #openstack-horizon | 06:05 | |
| *** lhcheng has quit IRC | 06:08 | |
| *** mwhagedorn has joined #openstack-horizon | 06:15 | |
| *** masco has joined #openstack-horizon | 06:17 | |
| *** Longgeek has quit IRC | 06:19 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/django_openstack_auth: Imported Translations from Transifex https://review.openstack.org/159007 | 06:25 |
| *** rwsu is now known as rwsu-afk | 06:25 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/159009 | 06:28 |
| *** GB21 has joined #openstack-horizon | 06:39 | |
| *** masco has quit IRC | 06:47 | |
| openstackgerrit | Swati Sharma proposed openstack/horizon: Confirm Dialog for Delete operation in Network Topology https://review.openstack.org/128873 | 06:51 |
| *** masco has joined #openstack-horizon | 06:58 | |
| *** jcoufal has joined #openstack-horizon | 07:01 | |
| *** calinux_ has quit IRC | 07:05 | |
| *** calinux has quit IRC | 07:06 | |
| *** tnovacik_ has joined #openstack-horizon | 07:08 | |
| *** stevemar has quit IRC | 07:10 | |
| *** stevemar has joined #openstack-horizon | 07:10 | |
| *** ishant has joined #openstack-horizon | 07:12 | |
| *** sayan has joined #openstack-horizon | 07:13 | |
| *** mwhagedorn has quit IRC | 07:15 | |
| *** jcoufal has quit IRC | 07:17 | |
| *** jcoufal has joined #openstack-horizon | 07:18 | |
| *** Miouge has joined #openstack-horizon | 07:30 | |
| *** masco has quit IRC | 07:31 | |
| *** jprovazn has joined #openstack-horizon | 07:42 | |
| *** masco has joined #openstack-horizon | 07:44 | |
| *** ekarlso has quit IRC | 07:48 | |
| *** ericpeterson has joined #openstack-horizon | 07:53 | |
| *** mrunge has joined #openstack-horizon | 07:55 | |
| *** e0ne has joined #openstack-horizon | 07:57 | |
| *** ericpeterson has quit IRC | 07:58 | |
| *** jtomasek has joined #openstack-horizon | 08:02 | |
| *** nlahouti has quit IRC | 08:04 | |
| *** sunilm has joined #openstack-horizon | 08:07 | |
| *** lhcheng_ has quit IRC | 08:08 | |
| *** e0ne has quit IRC | 08:08 | |
| *** Ala has joined #openstack-horizon | 08:14 | |
| *** mwhagedorn has joined #openstack-horizon | 08:15 | |
| *** amotoki has quit IRC | 08:16 | |
| pkarikh | Hi folks! Can anybone tell me, which git tag is for stable/juno? | 08:18 |
| openstackgerrit | Merged openstack/horizon: Add orchestration service status reporting https://review.openstack.org/154952 | 08:19 |
| mrunge | pkarikh, I'd check out origin/stable/juno | 08:22 |
| mrunge | pkarikh, tag would be something like 2014.2.2 | 08:22 |
| *** christophs has quit IRC | 08:25 | |
| *** christophs has joined #openstack-horizon | 08:25 | |
| *** christophs has joined #openstack-horizon | 08:25 | |
| *** christophs has joined #openstack-horizon | 08:25 | |
| *** christophs has joined #openstack-horizon | 08:25 | |
| pkarikh | mrunge: thank you! :) | 08:30 |
| *** sbfox has quit IRC | 08:31 | |
| pkarikh | And the next question: does choice between ceph and lvm makes any changes in Horizon UI? | 08:31 |
| mrunge | pkarikh, I would expect: no | 08:33 |
| mrunge | pkarikh, but honestly, I can't tell | 08:33 |
| *** TravT has joined #openstack-horizon | 08:34 | |
| pkarikh | mrunge: and how I can find out it? I mean, wich part of Horizon code I can look through to clarify it? | 08:34 |
| mrunge | pkarikh, good question. it's a cinder related thing | 08:35 |
| mrunge | but, looking at neutron/nova-network support and try to find differences in horizon code.... | 08:36 |
| mrunge | pkarikh, easiest thing would be, to deploy both | 08:36 |
| mrunge | pkarikh, imho it's *just* a storage backend | 08:36 |
| *** TravT has quit IRC | 08:38 | |
| *** tmazur has joined #openstack-horizon | 08:40 | |
| *** DaveJ__ has joined #openstack-horizon | 08:41 | |
| pkarikh | mrunge: hm.. Ok, thank you again. :) | 08:41 |
| *** MaxV has joined #openstack-horizon | 08:44 | |
| *** MaxV has quit IRC | 08:45 | |
| *** MaxV has joined #openstack-horizon | 08:45 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 08:47 | |
| *** e0ne has joined #openstack-horizon | 08:52 | |
| *** ekarlso has joined #openstack-horizon | 08:54 | |
| *** dkorn has joined #openstack-horizon | 08:56 | |
| *** rdopiera has joined #openstack-horizon | 09:00 | |
| *** zz_ttrifonov is now known as ttrifonov | 09:01 | |
| *** robcresswell_afk is now known as robcresswell | 09:03 | |
| *** rdopiera has quit IRC | 09:04 | |
| robcresswell | Morning all | 09:04 |
| *** rdopiera has joined #openstack-horizon | 09:04 | |
| pkarikh | robcresswell: morning! | 09:12 |
| robcresswell | pkarikh: o/ | 09:13 |
| *** mwhagedorn has quit IRC | 09:15 | |
| *** stevemar has quit IRC | 09:16 | |
| *** ygbo has joined #openstack-horizon | 09:17 | |
| *** doug-fish has quit IRC | 09:18 | |
| *** bluex-pl has joined #openstack-horizon | 09:27 | |
| *** mpavlase has joined #openstack-horizon | 09:32 | |
| *** e0ne has quit IRC | 09:33 | |
| *** akrivoka has joined #openstack-horizon | 09:33 | |
| mpavlase | vokhrimenko: Hi | 09:33 |
| *** e0ne has joined #openstack-horizon | 09:35 | |
| *** Miouge has quit IRC | 09:35 | |
| *** e0ne is now known as e0ne_ | 09:35 | |
| *** markus_z has joined #openstack-horizon | 09:36 | |
| *** cody-somerville has joined #openstack-horizon | 09:37 | |
| *** Miouge has joined #openstack-horizon | 09:42 | |
| *** e0ne_ is now known as e0ne | 09:44 | |
| *** e0ne has quit IRC | 09:52 | |
| *** JeanBriceCombebi has quit IRC | 09:53 | |
| *** amotoki has joined #openstack-horizon | 09:54 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 10:00 | |
| *** dboik has quit IRC | 10:10 | |
| openstackgerrit | Merged openstack/tuskar-ui: Updated from global requirements https://review.openstack.org/158761 | 10:15 |
| *** mwhagedorn has joined #openstack-horizon | 10:15 | |
| *** dboik has joined #openstack-horizon | 10:17 | |
| *** Miouge has quit IRC | 10:20 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: fixed row update for loadbalancer tables https://review.openstack.org/158689 | 10:21 |
| *** tnovacik_ has quit IRC | 10:22 | |
| *** akrivoka has quit IRC | 10:22 | |
| *** Miouge has joined #openstack-horizon | 10:27 | |
| *** Miouge has quit IRC | 10:28 | |
| *** tosky has joined #openstack-horizon | 10:33 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: admin state column added in router table https://review.openstack.org/155257 | 10:36 |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Refactor of Metadata Widget https://review.openstack.org/157466 | 10:37 |
| openstackgerrit | Swati Sharma proposed openstack/horizon: LoadBalancers' Add Member form has missing asterisk for 'Members' list https://review.openstack.org/139546 | 10:44 |
| openstackgerrit | Merged openstack/horizon: Refactor modal forms for Access & Security https://review.openstack.org/158286 | 10:46 |
| openstackgerrit | Ravikumar Venkatesan proposed openstack/horizon: Adds router create/delete integration tests https://review.openstack.org/151177 | 10:50 |
| *** GB21 has quit IRC | 10:52 | |
| *** JeanBriceCombebi has quit IRC | 10:58 | |
| mpavlase | vokhrimenko: I'm still not sure in which cases file a bug tagged by integration-tests and when it's not necessary... should I do that in every change done inside /tests/integration_tests directory? | 11:01 |
| *** aix has joined #openstack-horizon | 11:02 | |
| *** GB21 has joined #openstack-horizon | 11:05 | |
| *** akrivoka has joined #openstack-horizon | 11:07 | |
| mpavlase | it's broadcast question.. ^^ :-) | 11:11 |
| *** rushiagr_away is now known as rushiagr | 11:12 | |
| *** ishant has quit IRC | 11:12 | |
| *** mwhagedorn has quit IRC | 11:15 | |
| *** kmartin has quit IRC | 11:16 | |
| *** tnovacik_ has joined #openstack-horizon | 11:17 | |
| *** Ala has quit IRC | 11:19 | |
| robcresswell | amotoki: Hello! Sorry to bother you, was told you are the go-to guy for networking blueprints. I've got a small feature blueprint, that has code up (https://review.openstack.org/#/c/143139/) - I was wondering if you'd consider looking at it if you get chance. Thanks. | 11:20 |
| * robcresswell feels bad pestering cores for reviews | 11:20 | |
| mrunge | yeah right, robcresswell . you should feel BAAD :D | 11:21 |
| mrunge | robcresswell, seriously, it's quite late for amotoki right now | 11:21 |
| amotoki | robcresswell: thanks. | 11:21 |
| amotoki | mrunge: hehe. just got home. | 11:22 |
| mrunge | oh well... amotoki . it must be after midnight for you | 11:22 |
| robcresswell | mrunge, amotoki: It's not an immediate request! Just wanted to ask if you'd consider looking at it before K-3 :) | 11:22 |
| amotoki | mrunge: it's around 8-9pm now, not midnight in my side :) | 11:23 |
| mrunge | robcresswell, no worries :) | 11:23 |
| mrunge | my tz calculations must have failed in that case. | 11:23 |
| openstackgerrit | Martin Pavlásek proposed openstack/horizon: Avoid failure when spinner is already gone https://review.openstack.org/159084 | 11:24 |
| *** Miouge has joined #openstack-horizon | 11:28 | |
| *** DaveJ__ has quit IRC | 11:30 | |
| *** masco has quit IRC | 11:37 | |
| *** EmilienM is now known as EmilienM|afk | 11:39 | |
| *** akrivoka has quit IRC | 11:44 | |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Refactor, customization and fixes of Metadata Widget https://review.openstack.org/136437 | 11:48 |
| *** masco has joined #openstack-horizon | 11:51 | |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Refactor, customization and fixes of Metadata Widget https://review.openstack.org/136437 | 11:57 |
| amotoki | robcresswell: just post initial feedback. The most tricky area is some binding attributes are optional and we cannot assume they always exit :-( | 11:57 |
| robcresswell | amotoki: Ah, got it. I'll add some more safety checks to it. Thanks for the quick feedback! | 11:58 |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Metadata widget support for ambiguous properties https://review.openstack.org/157367 | 12:01 |
| *** Miouge has quit IRC | 12:02 | |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Metadata widget support for ambiguous properties https://review.openstack.org/157367 | 12:03 |
| *** Miouge has joined #openstack-horizon | 12:04 | |
| *** iamjarvo has joined #openstack-horizon | 12:07 | |
| *** aix has quit IRC | 12:11 | |
| *** e0ne has joined #openstack-horizon | 12:11 | |
| *** mwhagedorn has joined #openstack-horizon | 12:16 | |
| openstackgerrit | Jiri Tomasek proposed openstack/tuskar-ui: Create form input fields according to service param attributes https://review.openstack.org/159094 | 12:17 |
| openstackgerrit | Radomir Dopieralski proposed openstack/tuskar-ui: Change the validation message list into checklist https://review.openstack.org/159096 | 12:21 |
| openstackgerrit | lawrancejing proposed openstack/horizon: Remove unused code for sidebar https://review.openstack.org/158992 | 12:25 |
| *** danieru has quit IRC | 12:26 | |
| *** danieru has joined #openstack-horizon | 12:27 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/159009 | 12:42 |
| openstackgerrit | Merged openstack/horizon: Add support for Trove Replication https://review.openstack.org/114380 | 12:42 |
| openstackgerrit | Merged openstack/horizon: spelling mistakes on display outputs and docsstrings https://review.openstack.org/158976 | 12:43 |
| *** aix has joined #openstack-horizon | 12:43 | |
| *** amotoki has quit IRC | 12:43 | |
| *** doug-fish has joined #openstack-horizon | 12:49 | |
| *** ZZelle has quit IRC | 12:52 | |
| *** amotoki has joined #openstack-horizon | 12:52 | |
| *** ZZelle has joined #openstack-horizon | 12:52 | |
| *** tnovacik_ has quit IRC | 12:53 | |
| *** iamjarvo has joined #openstack-horizon | 13:01 | |
| *** iamjarvo has quit IRC | 13:01 | |
| *** iamjarvo has joined #openstack-horizon | 13:02 | |
| *** tnovacik_ has joined #openstack-horizon | 13:02 | |
| *** EmilienM|afk is now known as EmilienM | 13:03 | |
| openstackgerrit | Merged openstack/horizon: Transfer tables https://review.openstack.org/155371 | 13:09 |
| *** tmazur has quit IRC | 13:11 | |
| *** Ala has joined #openstack-horizon | 13:11 | |
| openstackgerrit | Martin Pavlásek proposed openstack/horizon: Use _wait_for_spinner() https://review.openstack.org/158825 | 13:14 |
| *** jprovazn has quit IRC | 13:15 | |
| *** ericpeterson has joined #openstack-horizon | 13:15 | |
| *** mwhagedorn has quit IRC | 13:15 | |
| openstackgerrit | Tomáš Nová?ik proposed openstack/horizon: Add test_image_register_unregister https://review.openstack.org/112631 | 13:18 |
| *** mrunge_ has joined #openstack-horizon | 13:23 | |
| *** Miouge has quit IRC | 13:25 | |
| *** mrunge_ has quit IRC | 13:25 | |
| *** sayan has quit IRC | 13:29 | |
| *** ericpeterson has quit IRC | 13:32 | |
| *** Miouge has joined #openstack-horizon | 13:32 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:33 | |
| *** masco has quit IRC | 13:35 | |
| *** iamjarvo has quit IRC | 13:44 | |
| *** jprovazn has joined #openstack-horizon | 13:49 | |
| *** masco has joined #openstack-horizon | 13:49 | |
| *** _crobertsrh is now known as crobertsrh | 13:50 | |
| openstackgerrit | Jiri Tomasek proposed openstack/tuskar-ui: Create form input fields according to service param attributes https://review.openstack.org/159094 | 13:57 |
| openstackgerrit | Daniel Korn proposed openstack/horizon: Integration tests - networkspage and test https://review.openstack.org/139028 | 14:00 |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Refactor, customization and fixes of Metadata Widget https://review.openstack.org/136437 | 14:00 |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Refactor of Metadata Widget https://review.openstack.org/157466 | 14:00 |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Metadata display widget https://review.openstack.org/151745 | 14:00 |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Metadata widget support for ambiguous properties https://review.openstack.org/157367 | 14:05 |
| *** iamjarvo has joined #openstack-horizon | 14:06 | |
| *** Miouge has quit IRC | 14:07 | |
| *** akrivoka has joined #openstack-horizon | 14:09 | |
| *** mwhagedorn has joined #openstack-horizon | 14:15 | |
| *** jtomasek has quit IRC | 14:15 | |
| *** jtomasek has joined #openstack-horizon | 14:18 | |
| *** dboik has quit IRC | 14:20 | |
| *** Miouge has joined #openstack-horizon | 14:22 | |
| *** jtomasek has quit IRC | 14:24 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Add New UX CSS for Upcoming Detail Screens https://review.openstack.org/158881 | 14:25 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Angular Filter files https://review.openstack.org/157848 | 14:27 |
| *** peristeri has joined #openstack-horizon | 14:27 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Image Details UX/Angular redesign https://review.openstack.org/158409 | 14:29 |
| *** Miouge has quit IRC | 14:29 | |
| *** mattfarina has joined #openstack-horizon | 14:30 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Instance Details UX/Angular redesign https://review.openstack.org/153602 | 14:31 |
| *** iamjarvo has quit IRC | 14:31 | |
| *** matt-borland has joined #openstack-horizon | 14:31 | |
| *** lblanchard has joined #openstack-horizon | 14:31 | |
| *** iamjarvo has joined #openstack-horizon | 14:32 | |
| *** radez_g0n3 is now known as radez | 14:32 | |
| *** jtomasek has joined #openstack-horizon | 14:34 | |
| *** iamjarvo has quit IRC | 14:35 | |
| *** sayan has joined #openstack-horizon | 14:35 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Image Details UX/Angular redesign https://review.openstack.org/158409 | 14:35 |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Instance Details UX/Angular redesign https://review.openstack.org/153602 | 14:36 |
| *** jtriley has joined #openstack-horizon | 14:36 | |
| *** Drago has joined #openstack-horizon | 14:40 | |
| *** Miouge has joined #openstack-horizon | 14:41 | |
| *** Drago has quit IRC | 14:41 | |
| *** Drago has joined #openstack-horizon | 14:41 | |
| *** sayan has quit IRC | 14:41 | |
| *** zul has quit IRC | 14:43 | |
| *** dboik has joined #openstack-horizon | 14:43 | |
| *** zul has joined #openstack-horizon | 14:44 | |
| *** masco has quit IRC | 14:45 | |
| *** dboik has quit IRC | 14:46 | |
| *** cody-somerville has quit IRC | 14:46 | |
| *** dboik has joined #openstack-horizon | 14:47 | |
| *** TravT has joined #openstack-horizon | 14:47 | |
| *** cody-somerville has joined #openstack-horizon | 14:47 | |
| david-lyle_afk | pkarikh: cinder abstracts all the storage backend differences out, so same interface in horizon | 14:48 |
| *** david-lyle_afk is now known as david-lyle | 14:48 | |
| *** ayoung has left #openstack-horizon | 15:01 | |
| *** peristeri has quit IRC | 15:03 | |
| pkarikh | david-lyle_afk: ok, thank you! | 15:06 |
| *** openstackgerrit has quit IRC | 15:08 | |
| *** openstackgerrit has joined #openstack-horizon | 15:08 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Image Details UX/Angular redesign https://review.openstack.org/158409 | 15:08 |
| *** zul has quit IRC | 15:09 | |
| *** zul has joined #openstack-horizon | 15:09 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Add New UX CSS for Upcoming Detail Screens https://review.openstack.org/158881 | 15:09 |
| *** peristeri has joined #openstack-horizon | 15:12 | |
| *** jtriley has quit IRC | 15:15 | |
| *** jprovazn has quit IRC | 15:16 | |
| *** iamjarvo has joined #openstack-horizon | 15:16 | |
| *** ericpeterson has joined #openstack-horizon | 15:16 | |
| *** jprovazn has joined #openstack-horizon | 15:22 | |
| *** mordred has quit IRC | 15:22 | |
| *** mordred has joined #openstack-horizon | 15:22 | |
| *** JeanBriceCombebi has quit IRC | 15:25 | |
| *** mwhagedorn has quit IRC | 15:25 | |
| *** jprovazn has quit IRC | 15:26 | |
| *** wchrisj has joined #openstack-horizon | 15:29 | |
| *** jprovazn has joined #openstack-horizon | 15:30 | |
| *** Sukhdev has joined #openstack-horizon | 15:31 | |
| *** alexvictorchan has joined #openstack-horizon | 15:39 | |
| *** woodm1979 has joined #openstack-horizon | 15:41 | |
| *** vijendar has joined #openstack-horizon | 15:43 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 15:46 | |
| *** rushiagr is now known as rushiagr_away | 15:46 | |
| *** Piet has quit IRC | 15:48 | |
| *** Drago has quit IRC | 15:50 | |
| *** Drago has joined #openstack-horizon | 15:50 | |
| *** dkorn has quit IRC | 15:52 | |
| *** dkorn has joined #openstack-horizon | 15:53 | |
| *** stevemar has joined #openstack-horizon | 15:54 | |
| *** MasterPiece has joined #openstack-horizon | 15:56 | |
| TravT | mrunge: are you still around? | 15:57 |
| *** iamjarvo has quit IRC | 16:00 | |
| *** kmartin has joined #openstack-horizon | 16:01 | |
| *** jtriley has joined #openstack-horizon | 16:04 | |
| *** jtomasek has quit IRC | 16:04 | |
| *** mwhagedorn has joined #openstack-horizon | 16:05 | |
| *** iamjarvo has joined #openstack-horizon | 16:06 | |
| *** jtomasek has joined #openstack-horizon | 16:06 | |
| *** nlahouti has joined #openstack-horizon | 16:09 | |
| *** jcoufal has quit IRC | 16:09 | |
| *** tnovacik_ has quit IRC | 16:09 | |
| *** bpokorny has joined #openstack-horizon | 16:09 | |
| *** dkorn has quit IRC | 16:09 | |
| *** jcoufal has joined #openstack-horizon | 16:09 | |
| *** dak419 has joined #openstack-horizon | 16:11 | |
| *** tnovacik_ has joined #openstack-horizon | 16:12 | |
| dak419 | rbertram, hello… David from HP/Euca here | 16:12 |
| rbertram | Hi dak419 | 16:12 |
| rbertram | PM... | 16:12 |
| *** sunilm has quit IRC | 16:12 | |
| *** sbfox has joined #openstack-horizon | 16:15 | |
| *** sbfox has quit IRC | 16:19 | |
| *** alexvictorchan has quit IRC | 16:26 | |
| *** lhcheng has joined #openstack-horizon | 16:26 | |
| *** tnovacik_ has quit IRC | 16:28 | |
| *** rwsu-afk has quit IRC | 16:31 | |
| *** rushiagr_away is now known as rushiagr | 16:33 | |
| *** iamjarvo has quit IRC | 16:35 | |
| *** jtriley has quit IRC | 16:36 | |
| *** jtriley has joined #openstack-horizon | 16:38 | |
| *** mpavlase has quit IRC | 16:41 | |
| *** iamjarvo has joined #openstack-horizon | 16:42 | |
| *** jcoufal has quit IRC | 16:44 | |
| robcresswell | network tests imports a "tests" file, and then someone else has masked the helpers import as "test". *facepalm* | 16:45 |
| *** rwsu has joined #openstack-horizon | 16:52 | |
| *** cbader has joined #openstack-horizon | 16:54 | |
| mrunge | TravT, sure. more or less | 16:54 |
| mrunge | TravT, will be back after 19 UTC | 16:54 |
| mrunge | TravT, you need anything special from me? | 16:55 |
| *** jtriley has quit IRC | 16:55 | |
| *** jtriley has joined #openstack-horizon | 16:56 | |
| lhcheng | hi mrunge! | 16:56 |
| mrunge | lhcheng, hey | 16:57 |
| mrunge | I'm cooking dinner; will be back in about 2 hrs... | 16:57 |
| lhcheng | got a question for you on django rpm | 16:57 |
| lhcheng | sure, ping when me when you're back | 16:57 |
| lhcheng | nothing urgent | 16:58 |
| mrunge | lhcheng, will ping you back | 16:58 |
| lhcheng | mrunge, thanks! | 16:58 |
| david-lyle | robcresswell: I have no idea why we are defining a new test case in the first place | 16:58 |
| david-lyle | I'm thinking about removing and just using the already defined ones | 16:59 |
| david-lyle | lhcheng, robcresswell do you see an issue with that | 16:59 |
| david-lyle | I think it's very likely you'll want a session value in the REST API tests | 16:59 |
| david-lyle | or something regarding a role | 16:59 |
| *** alanf-mc has joined #openstack-horizon | 17:02 | |
| lhcheng | david-lyle: issue with what? just logon a few minutes ago, missed the convo | 17:03 |
| david-lyle | just my last 5 lines | 17:04 |
| david-lyle | https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/helpers.py#L428 | 17:04 |
| david-lyle | makes no sense to startover at testtools.TestCase to me | 17:04 |
| david-lyle | why not locally defined TestCase? or just put the assert in locally defined TestCase | 17:05 |
| TravT | there is a class call RestTestUtils that we were going to move all those methods into RestTestCase | 17:05 |
| *** tnovacik_ has joined #openstack-horizon | 17:06 | |
| TravT | and originally RestTestCase I though of extending from APITestCase, but didn't need everything in it | 17:06 |
| david-lyle | if we were actually testing things, you'd need it for stuff like https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/rest/keystone.py#L42 | 17:06 |
| david-lyle | but we aren't, so it doesn't show up | 17:06 |
| david-lyle | people don't understand how much framework is built into those tests to allow things to actually be tested | 17:07 |
| lhcheng | david-lyle: good catch on the domain context | 17:07 |
| *** amotoki has quit IRC | 17:07 | |
| david-lyle | session and roles are important | 17:08 |
| woodm1979 | That's news. Sessions and roles matter in this product? | 17:08 |
| david-lyle | woodm1979: only to me | 17:08 |
| david-lyle | :D | 17:08 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Angular Filter files https://review.openstack.org/157848 | 17:08 |
| david-lyle | I think the limited nature of the implementation is encouraging circumventing lessons learned | 17:09 |
| TravT | so, do you want to put rest specific helper code in TestCase? | 17:09 |
| lhcheng | david-lyle: looking at the rest test, not sure what it is testing | 17:09 |
| *** ygbo has quit IRC | 17:10 | |
| david-lyle | :D | 17:10 |
| lhcheng | david-lyle: the return value is mocked too | 17:10 |
| lhcheng | :| | 17:10 |
| david-lyle | lhcheng: they are mostly if I pass in expected data validate that it doesn't explode | 17:10 |
| david-lyle | much like most of the view tests | 17:11 |
| david-lyle | TravT: yes, it's just an assert | 17:11 |
| david-lyle | there is a form assert in TestCase | 17:11 |
| david-lyle | not all TestCase's test forms | 17:11 |
| david-lyle | the part I'm more interested in is tests with different roles | 17:12 |
| robcresswell | Heh, I was just referring to this https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/networks/tests.py#L24 in my original comment. | 17:12 |
| TravT | seems reasonable | 17:12 |
| robcresswell | and how masking imports nearly identical to others is stupid | 17:12 |
| david-lyle | ideally Admin test view will be wrapped in, and the role would be settable too | 17:12 |
| *** iamjarvo has quit IRC | 17:12 | |
| TravT | i started a few tests that leveraged the API level tests, and it started looking like a repeat of 90% of what's already in the API tests. | 17:12 |
| robcresswell | especially when helpers is a perfectly valid name. | 17:12 |
| lhcheng | david-lyle: probably need something like the API test case, where we also validate it is making all the correct call to the api layer (openstack_dashboard.api) | 17:12 |
| david-lyle | but that's a fight for a different day | 17:12 |
| david-lyle | lhcheng: probably need a lot | 17:13 |
| david-lyle | depends on your definition of unit test | 17:13 |
| david-lyle | if you are strict in your definition the current ones are unit tests, but of dubious value | 17:14 |
| lhcheng | david-lyle: I'm trying to make it sound less troubling here :) | 17:14 |
| david-lyle | testing more than one layer is more of an integration test, but of significantly more value | 17:14 |
| david-lyle | I'm pro value | 17:15 |
| david-lyle | don't know why | 17:15 |
| david-lyle | will post patch to change | 17:15 |
| david-lyle | people can yay or nay | 17:15 |
| openstackgerrit | Dan Nguyen proposed openstack/horizon: Retrieve domain scoped token https://review.openstack.org/148082 | 17:16 |
| esp | ^ @woodm1979 | 17:17 |
| lhcheng | I also got another question on implementation, curious why we used $http for making rest call, why not restangular. | 17:17 |
| lhcheng | TravT: ^ | 17:17 |
| TravT | lhcheng: i think we'd actually rather use: https://docs.angularjs.org/api/ngResource/service/$resource | 17:18 |
| lhcheng | thinking if we use restangular, we don't need to recode the service layer if we move to angular2. | 17:18 |
| lhcheng | TravT: yeah, that's another option | 17:18 |
| matt-borland | Travt: ++ re $resource | 17:18 |
| lhcheng | TravT: read somewhere about $http vs $resource vs restangular | 17:19 |
| TravT | http://sauceio.com/index.php/2014/07/angularjs-data-models-http-vs-resource-vs-restangular/ | 17:20 |
| lhcheng | I guess $resource should be good too, since we have well formed response | 17:20 |
| lhcheng | TravT: ah yeah, that one | 17:20 |
| TravT | i'd vote no on any attempt to bring in a new dependency before we even have any code written that uses the rest apis | 17:20 |
| TravT | the basic discussion was this: enable access to the data in the least intrusive way and then morph it appropriately from there | 17:21 |
| *** tnovacik_ has quit IRC | 17:21 | |
| *** jamielennox is now known as jamielennox|away | 17:22 | |
| *** cody-somerville has quit IRC | 17:22 | |
| lhcheng | TravT: missed the thread when it was discussed, good to know | 17:24 |
| TravT | The work to actually use these APIs is really getting going now, so I think it'll become more evident what the best approach is. | 17:25 |
| *** JeanBriceCombebi has quit IRC | 17:26 | |
| *** Ala has quit IRC | 17:27 | |
| TravT | so maybe in a week you'll see begging for restangular... | 17:27 |
| david-lyle | TravT, lhcheng: looking through all this, holy shit | 17:28 |
| david-lyle | (facepalm) | 17:28 |
| david-lyle | wait my git doesn't mesh, wtf | 17:29 |
| *** rwsu has quit IRC | 17:29 | |
| lhcheng | TravT: yeah, I guess once we require some more complex interaction we might need a better library. | 17:30 |
| david-lyle | https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/api_tests/rest_util_tests.py#L20 and https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/helpers.py#L428 | 17:30 |
| david-lyle | pure awesome | 17:30 |
| lhcheng | the Launch Instance is the most complex screen, you guys will probably figure out soon if we need it or not | 17:30 |
| *** jamielennox|away is now known as jamielennox | 17:30 | |
| *** Sukhdev has quit IRC | 17:30 | |
| lhcheng | david-lyle: the other one is mo betta | 17:31 |
| *** justincampbell has joined #openstack-horizon | 17:31 | |
| lhcheng | :) | 17:31 |
| david-lyle | just roll the dice | 17:31 |
| david-lyle | flip a coin | 17:31 |
| *** trown is now known as trown|lunch | 17:31 | |
| david-lyle | you pick | 17:31 |
| TravT | david, that's what we were saying about moving all that over into helpers | 17:32 |
| david-lyle | ok, it's just a mess | 17:32 |
| TravT | yeah... last night we were talking about submitting a patch to clean that up | 17:33 |
| david-lyle | TravT: is there a patch? or should I just continue with mine | 17:33 |
| david-lyle | ? | 17:33 |
| TravT | continue with your if you've started it | 17:33 |
| david-lyle | cause I'm halfway through | 17:33 |
| david-lyle | sure | 17:33 |
| *** matt-borland has quit IRC | 17:33 | |
| david-lyle | borks my plan to move it into TestCase though | 17:33 |
| *** matt-borland has joined #openstack-horizon | 17:33 | |
| david-lyle | needs to inherit from it | 17:34 |
| *** ttrifonov is now known as zz_ttrifonov | 17:34 | |
| *** rwsu has joined #openstack-horizon | 17:34 | |
| david-lyle | but I need role and session stuff | 17:34 |
| david-lyle | mixin it is | 17:34 |
| * robcresswell adds angular tests to research list | 17:35 | |
| TravT | so, what about making RestAPITestCase extend from something else... need to scroll back | 17:35 |
| david-lyle | yeah, but I need admin and member type roles | 17:35 |
| david-lyle | for different cases | 17:35 |
| david-lyle | and setting session values | 17:35 |
| david-lyle | maybe not a mixin, but more reorg | 17:36 |
| david-lyle | I think a third RestApiTestCase will solve things :) | 17:36 |
| TravT | so, something like this: | 17:37 |
| TravT | http://xkcd.com/927/ | 17:37 |
| robcresswell | TravT: +1 | 17:38 |
| david-lyle | +100 | 17:38 |
| *** gyee has joined #openstack-horizon | 17:38 | |
| robcresswell | This sounds like a discussion for a presummit meetup | 17:39 |
| robcresswell | :D | 17:39 |
| TravT | robcresswell: just reminded me to bring that up again in today's meeting | 17:40 |
| TravT | but no | 17:40 |
| TravT | we need to do some cleanup now | 17:40 |
| TravT | there was also some discussion of getting the base things added | 17:41 |
| TravT | and the patterns would become clear | 17:41 |
| TravT | and then clean it up | 17:41 |
| lhcheng | david-lyle: there was no meeting last week? http://eavesdrop.openstack.org/meetings/horizon/2015/ | 17:41 |
| david-lyle | lhcheng: I missed it and no one ran it | 17:41 |
| TravT | but to try to clean it up asap | 17:42 |
| lhcheng | david-lyle: didn't notice I read the old log last wednesday *facepalm | 17:42 |
| david-lyle | thumb on the pulse | 17:43 |
| david-lyle | :P | 17:43 |
| lhcheng | hah | 17:46 |
| *** iamjarvo has joined #openstack-horizon | 17:48 | |
| *** EmilienM is now known as EmilienM|afk | 17:49 | |
| *** MaxV has quit IRC | 17:52 | |
| *** sbfox has joined #openstack-horizon | 17:54 | |
| *** tnovacik_ has joined #openstack-horizon | 17:56 | |
| david-lyle | TravT, lhcheng on the plus side the TestCase defined in rest_util_tests.py isn't ever used | 17:58 |
| david-lyle | any idea why it's there? | 17:58 |
| robcresswell | -.- | 17:58 |
| TravT | david-lyle: i was just wondering about | 17:59 |
| david-lyle | which puts me back at TestCase being the simplest option | 17:59 |
| openstackgerrit | Matthew D. Wood proposed openstack/horizon: Retrieve domain scoped token https://review.openstack.org/148082 | 17:59 |
| * lhcheng shrugs | 17:59 | |
| david-lyle | since another setup is not being specified | 17:59 |
| david-lyle | and we can extend if actually necessary, when necessary | 18:00 |
| openstackgerrit | Merged openstack/horizon: Skip also test fixtures when the entire class is skipped https://review.openstack.org/158366 | 18:01 |
| *** robcresswell is now known as robcresswell_afk | 18:01 | |
| *** jamielennox is now known as jamielennox|away | 18:02 | |
| *** iamjarvo has quit IRC | 18:04 | |
| *** ybathia has joined #openstack-horizon | 18:06 | |
| *** bluex-pl has quit IRC | 18:12 | |
| *** Anticimex has quit IRC | 18:12 | |
| *** bluex-pl has joined #openstack-horizon | 18:13 | |
| *** iamjarvo has joined #openstack-horizon | 18:14 | |
| *** jamielennox|away is now known as jamielennox | 18:15 | |
| openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Fix typo errors in comments for api modules https://review.openstack.org/159212 | 18:17 |
| TravT | david-lyle: i've been having to be in another meeting | 18:18 |
| *** Anticimex has joined #openstack-horizon | 18:18 | |
| TravT | but i just looked at what you shared previously | 18:18 |
| TravT | that is a test for testing https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/rest/utils.py | 18:18 |
| david-lyle | ah, ok | 18:20 |
| david-lyle | thought it was another util shoved in the test directory | 18:20 |
| TravT | https://review.openstack.org/#/c/136676/ | 18:21 |
| openstackgerrit | Matthew D. Wood proposed openstack/horizon: Retrieve domain scoped token https://review.openstack.org/148082 | 18:21 |
| TravT | yeah, I glanced at it and was confused at first as well | 18:21 |
| TravT | a bad pattern that was emerging was everybody redefining the assert status code in every test | 18:21 |
| TravT | so there was talk of moving that into https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/api_tests/rest_test_utils.py | 18:22 |
| TravT | or creating a new RestTestCase and putting things into there | 18:23 |
| TravT | yesterday, the discussion was to get rid of https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/api_tests/rest_test_utils.py | 18:23 |
| TravT | and move those into https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/helpers.py#L428 | 18:23 |
| TravT | but then this morning you found other needs. | 18:24 |
| david-lyle | I moved it to openstack_dashboard/test, but could roll into helpers | 18:24 |
| TravT | idea was to then change all rest test cases to extend from https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/helpers.py#L428 | 18:25 |
| *** aix has quit IRC | 18:25 | |
| TravT | and to stop importing that rest_test_utils. | 18:25 |
| david-lyle | that class is really unncessary | 18:25 |
| david-lyle | unnecessary | 18:26 |
| *** alanf-mc- has joined #openstack-horizon | 18:26 | |
| *** robcresswell_afk is now known as robcresswell | 18:27 | |
| *** Miouge has quit IRC | 18:28 | |
| *** alanf-mc has quit IRC | 18:29 | |
| doug-fish | I'm trying to get up to speed on project vs domain scoped tokens ... based on my read of the code keystoneclient in openstack_dashboard/api/keystone.py is always going to use the domain scoped token if one is available. Is that expected? | 18:30 |
| *** iamjarvo has quit IRC | 18:30 | |
| doug-fish | or maybe even a step back ... is that really the way it works? | 18:31 |
| *** MasterPiece has quit IRC | 18:33 | |
| *** MasterPiece has joined #openstack-horizon | 18:35 | |
| *** rushiagr is now known as rushiagr_away | 18:35 | |
| openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Fix typo in comments for api modules https://review.openstack.org/159220 | 18:40 |
| david-lyle | lhcheng: why the new review? | 18:41 |
| david-lyle | git commit --amend | 18:41 |
| *** mwhagedorn has quit IRC | 18:41 | |
| lhcheng | david-lyle: something weird going on | 18:42 |
| lhcheng | original patch is: https://review.openstack.org/#/c/66166/ | 18:42 |
| lhcheng | when I submitted for review, it created a new patch: https://review.openstack.org/#/c/159212/ | 18:43 |
| lhcheng | notice that change-id is the same | 18:43 |
| david-lyle | did you git review -d ? | 18:43 |
| david-lyle | wait what? same id | 18:44 |
| lhcheng | david-lyle: doesn't that submit review as draft | 18:44 |
| david-lyle | git review -d <ID> to checkout | 18:44 |
| david-lyle | is what I meant | 18:44 |
| *** ericpeterson has quit IRC | 18:44 | |
| david-lyle | your last review has a different changeID than the original | 18:45 |
| openstackgerrit | Luigi Toscano proposed openstack/horizon: Add test_sahara_image_registry https://review.openstack.org/112631 | 18:45 |
| lhcheng | yeah, gerrit was rejecting my patch after I abandone the old one | 18:45 |
| lhcheng | like the patch is already closed | 18:45 |
| lhcheng | trying git review -d... | 18:46 |
| *** tqtran has joined #openstack-horizon | 18:46 | |
| openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Fix typo errors in comments for api modules https://review.openstack.org/159212 | 18:51 |
| *** markus_z has quit IRC | 18:51 | |
| lhcheng | david-lyle: it created another patch :D | 18:52 |
| *** alanf-mc- has quit IRC | 18:52 | |
| david-lyle | something wrong with the original? | 18:53 |
| lhcheng | david-lyle: do I need to specify the id when I do "git review" to submit? | 18:53 |
| david-lyle | no | 18:53 |
| lhcheng | david-lyle: could be.. | 18:53 |
| david-lyle | just git review | 18:53 |
| lhcheng | or just too old? | 18:53 |
| lhcheng | :P | 18:53 |
| *** alanf-mc has joined #openstack-horizon | 18:54 | |
| *** jgravel_ has joined #openstack-horizon | 18:57 | |
| openstackgerrit | David Lyle proposed openstack/horizon: Refactoring the rest tests and their tooling https://review.openstack.org/159224 | 18:58 |
| david-lyle | lhcheng: was the original done on a local branch or directly off master | 18:59 |
| david-lyle | wonder if that would make a difference | 18:59 |
| lhcheng | david-lyle: directly off master | 18:59 |
| david-lyle | TravT that's me testing proposal ^^^ | 19:00 |
| david-lyle | s/me/my | 19:00 |
| doug-fish | aww don't fix me/my. I read your line in a pirate voice. | 19:00 |
| david-lyle | lhcheng: you added a co-author so, abandon the old and point to the new | 19:00 |
| *** rhagarty has joined #openstack-horizon | 19:00 | |
| lhcheng | david-lyle: yeah, that's what I did. It is a trivial change, didn't want to spent too much time on it | 19:01 |
| david-lyle | yup | 19:01 |
| david-lyle | just curious when the tooling doesn't work like you expect | 19:01 |
| lhcheng | david-lyle: the magic of change-id failed :) | 19:02 |
| openstackgerrit | Brian Tully proposed openstack/horizon: Directive to allow editing of table cell values https://review.openstack.org/158004 | 19:09 |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Instance Details UX/Angular redesign https://review.openstack.org/153602 | 19:09 |
| *** bluex-pl has quit IRC | 19:14 | |
| *** ericpeterson has joined #openstack-horizon | 19:14 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Instance Details UX/Angular redesign https://review.openstack.org/153602 | 19:15 |
| mrunge | lhcheng, pong. | 19:15 |
| mrunge | you had a Q about django rpm | 19:15 |
| lhcheng | hey mrunge | 19:15 |
| lhcheng | yeah, there are multiple django rpms.. wondering why there are different names :) | 19:16 |
| lhcheng | Django, python-django, Django14 | 19:16 |
| mrunge | you mean like Django14 | 19:16 |
| mrunge | yep. in short: historic | 19:17 |
| lhcheng | all three | 19:17 |
| lhcheng | heh | 19:17 |
| mrunge | Django was first, then , because of being a python package, it was renamed to python-django | 19:17 |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Image Details UX/Angular redesign https://review.openstack.org/158409 | 19:17 |
| mrunge | in EPEL, we had Django, which was older (or newer, I forgot) | 19:18 |
| mrunge | and Django14 was a compatibility package | 19:18 |
| *** jwy has joined #openstack-horizon | 19:18 | |
| mrunge | I'm trying to get rid of all strangely named packages | 19:18 |
| lhcheng | hmm so which is the correct one to use for rhel6? | 19:19 |
| mrunge | simple: Django14 | 19:19 |
| lhcheng | I guess moving forward, python-django will be used? | 19:19 |
| mrunge | which will be supported until end of March | 19:19 |
| mrunge | THIS YEAR | 19:19 |
| mrunge | yeah, but not for RHEL6 | 19:19 |
| lhcheng | I got a month to use it :D | 19:20 |
| lhcheng | I see | 19:20 |
| mrunge | I'm planning to move all I have to Django-1.8 | 19:20 |
| mrunge | which is the next long term supported Django version | 19:20 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Add New UX CSS for Upcoming Detail Screens https://review.openstack.org/158881 | 19:20 |
| mrunge | sadly, it supports only python-2.7+ | 19:21 |
| lhcheng | why Django and not python-django? | 19:21 |
| lhcheng | thought Django is the old one.. | 19:21 |
| mrunge | ok, the next package will be python-django, and it will be Django version 1.8 | 19:21 |
| mrunge | confusing? Sure! | 19:21 |
| lhcheng | mrunge: yeah, sad about only supporting 2.7 | 19:22 |
| mrunge | that's Django upstream decision | 19:22 |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Image Details UX/Angular redesign https://review.openstack.org/158409 | 19:22 |
| mrunge | but, hey, that's what we do with OpenStack, too | 19:22 |
| lhcheng | mrunge: rhel7 only supports 2.7+? | 19:22 |
| mrunge | yes! | 19:22 |
| lhcheng | mrunge: I see, that explains it | 19:22 |
| mrunge | rhel7 has python-2.7 | 19:22 |
| mrunge | I'm not 100% sure about SuSE and python-2.6 support | 19:23 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Add New UX CSS for Upcoming Detail Screens https://review.openstack.org/158881 | 19:23 |
| mrunge | they might have it still. | 19:23 |
| lhcheng | keeping the python-django makes sense, just need to do some magic with the Django in the requirements file into python-django | 19:23 |
| *** trown|lunch is now known as trown | 19:24 | |
| mrunge | lhcheng, for rpm packages, we completely ignore requirements.txt | 19:24 |
| mrunge | it's all mapped in RPM requirements | 19:24 |
| lhcheng | mrunge: in the spec file? | 19:25 |
| mrunge | lhcheng, if you're going to install openstack-dashboard, yum will pull in all dependencies, as required | 19:25 |
| mrunge | lhcheng, yes | 19:25 |
| mrunge | Requires: lines | 19:25 |
| mrunge | (there are lots of them...) | 19:25 |
| *** mwhagedorn has joined #openstack-horizon | 19:25 | |
| lhcheng | mrunge: cool | 19:26 |
| *** sqchen has joined #openstack-horizon | 19:26 | |
| mrunge | lhcheng, so basically, what we do in openstack with pip and requirements.txt | 19:27 |
| *** akrivoka has quit IRC | 19:28 | |
| mrunge | not very different, plus a layer, that you can provide your own package mirror. you don't need to rely on pypi | 19:28 |
| lhcheng | mrunge: in anvil packaging, it tries to build an rpm for each requirements.txt if it could not find it in epel. There is some sort of translation from pypi name into rpm name: https://github.com/stackforge/anvil/blob/master/conf/distros/redhat.yaml#L15 | 19:29 |
| *** tosky has quit IRC | 19:30 | |
| lhcheng | mrunge: not sure if this is the best solution, but that's how it is done now | 19:30 |
| mrunge | lhcheng, cool! | 19:30 |
| lhcheng | mrunge: standardizing on the convention of using python-* is actually good for anvil. As it also used a possible name when looking it up in epel. :) | 19:31 |
| mrunge | lhcheng, it's quite simple to add a provides: line into epel packages, to make this kind of mapping easier | 19:32 |
| mrunge | e.g someone shoud add provides: python-scss to the package named python-scss | 19:33 |
| mrunge | (that would obsolete line https://github.com/stackforge/anvil/blob/master/conf/distros/redhat.yaml#L15 ) | 19:33 |
| mrunge | ah, please ignore my last comment. it seems you just need it as mapping | 19:34 |
| lhcheng | mrunge: yeah, this is from requirements file to rpm package | 19:35 |
| lhcheng | mrunge: I was happy there for a moment | 19:35 |
| openstackgerrit | Brian Tully proposed openstack/horizon: Directive to allow editing of table cell values https://review.openstack.org/158004 | 19:35 |
| *** jgravel_ has quit IRC | 19:36 | |
| *** iamjarvo has joined #openstack-horizon | 19:42 | |
| *** GB21 has quit IRC | 19:44 | |
| openstackgerrit | David Lyle proposed openstack/horizon: Heat topology display improvement https://review.openstack.org/110888 | 19:46 |
| *** GB21 has joined #openstack-horizon | 19:46 | |
| *** e0ne has quit IRC | 19:50 | |
| *** absubram has joined #openstack-horizon | 19:50 | |
| david-lyle | 51 failures out of 70 spec tests is pretty nice | 19:50 |
| david-lyle | could be >51 I suppose | 19:50 |
| openstackgerrit | Brian Tully proposed openstack/horizon: Demo for editable table field directive https://review.openstack.org/158931 | 19:51 |
| david-lyle | seems like smart-table is missing as a module according to the selenium spec test we run, anyone working on that? | 19:51 |
| *** matt-borland has quit IRC | 19:52 | |
| *** matt-borland has joined #openstack-horizon | 19:53 | |
| TravT | david-lyle: just put up a review on that test refactor | 19:54 |
| openstackgerrit | David Lyle proposed openstack/horizon: Adding policy rest endpoint for angular https://review.openstack.org/158914 | 19:56 |
| openstackgerrit | GB21 proposed openstack/horizon: Change of path of wrap_delimiter function https://review.openstack.org/157760 | 19:57 |
| *** sqchen has quit IRC | 19:58 | |
| openstackgerrit | Tomáš Nová?ik proposed openstack/horizon: Fix skip decorator in integration tests https://review.openstack.org/159237 | 20:01 |
| *** EmilyW has joined #openstack-horizon | 20:02 | |
| mrunge | meeting in -2 minutes? | 20:02 |
| mrunge | david-lyle, ?? | 20:02 |
| david-lyle | doh | 20:03 |
| mrunge | :D | 20:03 |
| mrunge | happens to the best of us ;-) | 20:03 |
| openstackgerrit | Tomáš Nová?ik proposed openstack/horizon: Fix skip decorator in integration tests https://review.openstack.org/159237 | 20:03 |
| *** sqchen has joined #openstack-horizon | 20:04 | |
| *** gugl has joined #openstack-horizon | 20:06 | |
| *** clu_ has joined #openstack-horizon | 20:07 | |
| *** iamjarvo has quit IRC | 20:07 | |
| *** GB21 has quit IRC | 20:16 | |
| *** jprovazn has quit IRC | 20:21 | |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 20:23 | |
| r1chardj0n3s | morning | 20:23 |
| *** iamjarvo has joined #openstack-horizon | 20:26 | |
| *** Piet has joined #openstack-horizon | 20:30 | |
| mrunge | morning r1chardj0n3s | 20:33 |
| mrunge | david-lyle, for later reference: https://blueprints.launchpad.net/horizon/+spec/django18 | 20:43 |
| *** iamjarvo has quit IRC | 20:46 | |
| *** nlahouti has quit IRC | 20:48 | |
| justincampbell | esp: thanks again for your help yesterday | 20:54 |
| esp | np justincampbell | 20:54 |
| justincampbell | esp: do you know if theres a way to use the v3 policy files and not break admin/default ? | 20:54 |
| esp | hmm | 20:54 |
| esp | can you explain the breakage a bit? | 20:54 |
| justincampbell | would like to deploy devstack with the files and still be able to run the API commands to create cloud_admin later | 20:54 |
| *** MasterPiece has quit IRC | 20:55 | |
| esp | justincampbell: so, deploy devstack wit keystone v3 policy file first | 20:55 |
| justincampbell | once we copy the v3 policy files, we're unable to login to horizon with default domain, admin user | 20:55 |
| justincampbell | yes | 20:55 |
| esp | I *think* that should work | 20:56 |
| justincampbell | so right now, we create cloud_admin, assign admin role to cloud_admin for default, copy policy files, then auth as cloud_admin to crete the rest | 20:56 |
| justincampbell | s/crete/create/g | 20:56 |
| esp | if you have the “admin_domain_id” set in the file(s) one for keystone and one for horizon | 20:56 |
| justincampbell | hmm | 20:56 |
| justincampbell | ah yes, we have that set to default | 20:57 |
| justincampbell | but only cloud_admin is able to login | 20:57 |
| esp | you will need to make sure your /etc/keystone/keystone.conf has the “magic” token too I think | 20:57 |
| *** MasterPiece has joined #openstack-horizon | 20:57 | |
| *** shivrao has joined #openstack-horizon | 20:57 | |
| esp | justincampbell: right but you could create a domain + domain_admin after that | 20:58 |
| esp | is that what you were thinking? | 20:58 |
| justincampbell | esp: yeah i think thats what we're doing, but it seems very coupled to when the policy files are copied | 20:59 |
| justincampbell | we create cloud_admin, copy files, restart apache, then use cloud_admin to create the rest of the users | 20:59 |
| justincampbell | if we copy the files earlier, we're unable to use admin to create cloud_admin, and if we copy them later we can't login as cloud_admin and the domain we created | 20:59 |
| justincampbell | esp: https://gist.github.com/justincampbell/2ac40f316c4a1e1c03f3#file-multi-domain-setup-py-L33 | 21:00 |
| esp | yeah that’s kinda what I was thinking but you might check with keystone to see if there is something I’m missing | 21:00 |
| esp | ah, that might be a bug in my patch :( | 21:00 |
| justincampbell | esp: nah, i think it was happening before those patches as well | 21:00 |
| esp | k | 21:01 |
| esp | I know early on, when I followed some instructions for bootstrapping a cloud admin | 21:01 |
| esp | I used curl commands to get an admin token from the v2 api | 21:01 |
| esp | and then turn around and used that to grant access to the default domain (v3) | 21:02 |
| esp | then I got a domain scoped token for cloud admin and went from there | 21:02 |
| tqtran | r1chardj0n3s: looks like you and david have similar patch up: https://review.openstack.org/#/c/159224/, https://review.openstack.org/#/c/158936/ | 21:03 |
| r1chardj0n3s | hey, so I have to do Dad stuff this morning, so can only poke in here briefly over the next 30 minutes, but david-lyle and I need to Thunderdome over https://review.openstack.org/#/c/158936/ vs https://review.openstack.org/#/c/159224/ | 21:03 |
| esp | justincampbell: but check with gyee regarding the order of when you can create a domain_admin | 21:03 |
| r1chardj0n3s | yeah tqtran, I wrote mine after the sprint yesterday | 21:03 |
| r1chardj0n3s | (as I said I would :P ) | 21:03 |
| *** robcresswell is now known as robcresswell_afk | 21:04 | |
| r1chardj0n3s | anyhoo, popping away for a sec | 21:04 |
| david-lyle | r1chardj0n3s: I asked TravT if there was a patch, hadn't seen it | 21:04 |
| david-lyle | apologies | 21:04 |
| *** matt-borland has quit IRC | 21:04 | |
| tqtran | double work means double check right? | 21:04 |
| TravT | david-lyle: yep, i should have looked at r1chardj0n3s patch list | 21:05 |
| david-lyle | still not convinced of the need for a special class | 21:05 |
| *** matt-borland has joined #openstack-horizon | 21:05 | |
| *** EmilyW has quit IRC | 21:05 | |
| david-lyle | TravT: me too, I lazily asked you | 21:05 |
| TravT | let's just merge them both and see which wins in zuul | 21:05 |
| woodm1979 | tqtran: Doesn't double-work mean you don't need tests any more? | 21:05 |
| TravT | race to the death | 21:05 |
| *** EmilyW has joined #openstack-horizon | 21:05 | |
| tqtran | woodm1979: hm.. good point | 21:05 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Angular-based Modal Wait Spinner Widget https://review.openstack.org/158819 | 21:06 |
| *** mattamizer has joined #openstack-horizon | 21:07 | |
| openstackgerrit | David Lyle proposed openstack/horizon: Refactoring the rest tests and their tooling https://review.openstack.org/159224 | 21:07 |
| *** rdopiera has quit IRC | 21:08 | |
| *** iamjarvo has joined #openstack-horizon | 21:10 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Angular-based Modal Wait Spinner Widget https://review.openstack.org/158819 | 21:12 |
| doug-fish | matt-borland: I've actually shared the review comments now | 21:12 |
| matt-borland | thanks! | 21:12 |
| doug-fish | I comments on patch set 10, but then did the review on set 11 | 21:12 |
| doug-fish | sorry about that, and thanks for following up! | 21:13 |
| matt-borland | ha! gotcha. Thanks for checking on that. | 21:13 |
| *** gugl has quit IRC | 21:13 | |
| matt-borland | Cool! OK, I see those now. | 21:13 |
| *** jtomasek has quit IRC | 21:14 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Modal Wait Spinner Demo https://review.openstack.org/158835 | 21:14 |
| doug-fish | sounds good! | 21:14 |
| matt-borland | Heh, your notes were in my pasted-in code. :) Makes me feel a little better. | 21:14 |
| matt-borland | doug-fish: very good notes, thanks! | 21:15 |
| doug-fish | yw | 21:16 |
| openstackgerrit | David Lyle proposed openstack/horizon: Refactoring the rest tests and their tooling https://review.openstack.org/159224 | 21:17 |
| matt-borland | tqtran: here? | 21:20 |
| tqtran | mattfarina: sorta | 21:20 |
| tqtran | mattfarina: shoot | 21:20 |
| matt-borland | other matt :) | 21:20 |
| mattfarina | haha | 21:20 |
| tqtran | crap, thanks a lot tab! | 21:20 |
| tqtran | matt-borland: there we go :) | 21:20 |
| matt-borland | tqtran: regarding https://review.openstack.org/#/c/157848/, I copied your filters that you suggested over. | 21:20 |
| *** woodm1979 has quit IRC | 21:21 | |
| matt-borland | only question is, are there are any good existing tests for the elapsedTime filter? | 21:21 |
| matt-borland | it's quite complicated, and I only put together one test. | 21:21 |
| matt-borland | I feel a little concerned committing it without taking the time for good tests, but on the other hand I sorta want to push this along | 21:22 |
| matt-borland | since a lot of work is looking for the filters to land | 21:22 |
| tqtran | I think we might have a few python tests for those. | 21:22 |
| matt-borland | maybe in qunit? | 21:23 |
| tqtran | let me see if i can find it | 21:23 |
| matt-borland | tqtran: thanks! | 21:23 |
| r1chardj0n3s | david-lyle: ok, so um, you're still working on your patch so I guess I just have to withdraw mine | 21:23 |
| tqtran | do we need it for launch instance work atm? | 21:23 |
| matt-borland | nope | 21:23 |
| tqtran | im ok with removing the elapsedtime for now then | 21:23 |
| r1chardj0n3s | and a no-comment -1 from tqtran | 21:24 |
| matt-borland | OK. I will do that in the next patch. | 21:24 |
| r1chardj0n3s | so yeah | 21:24 |
| matt-borland | tqtran: thanks! | 21:24 |
| david-lyle | r1chardj0n3s: no, I just wanted to get it looking like I thought it should be | 21:24 |
| tqtran | r1chardj0n3s: lol i commented above, maybe you can nudge david to list you as co-author | 21:24 |
| david-lyle | I could couldn't care less if we use mine | 21:24 |
| tqtran | everyone wins | 21:24 |
| r1chardj0n3s | ok, I gotta do the school run, back in 30 | 21:25 |
| david-lyle | I just didn't know you started one, because I was trying to fix my tests on policy and got agitated | 21:25 |
| r1chardj0n3s | yep | 21:25 |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 21:25 | |
| david-lyle | I fine with rolling it into yours | 21:25 |
| david-lyle | but we should talk about base classes when you're back r1chardj0n3s_afk | 21:26 |
| *** tnovacik_ has quit IRC | 21:29 | |
| *** mattamizer has quit IRC | 21:34 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Angular Filter files https://review.openstack.org/157848 | 21:37 |
| *** jtriley has quit IRC | 21:39 | |
| *** sqchen has quit IRC | 21:42 | |
| *** iamjarvo has quit IRC | 21:45 | |
| *** nlahouti has joined #openstack-horizon | 21:46 | |
| *** iamjarvo has joined #openstack-horizon | 21:52 | |
| *** iamjarvo has quit IRC | 21:52 | |
| *** iamjarvo has joined #openstack-horizon | 21:52 | |
| *** ybathia has quit IRC | 21:53 | |
| *** radez is now known as radez_g0n3 | 21:53 | |
| *** sqchen has joined #openstack-horizon | 21:57 | |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 21:59 | |
| *** matt-borland has quit IRC | 21:59 | |
| r1chardj0n3s | . | 21:59 |
| *** EmilyW has quit IRC | 21:59 | |
| r1chardj0n3s | right, sorry, busy morning | 22:00 |
| r1chardj0n3s | unfortunate duplication of effort, but I guess it meant more brains on the job | 22:00 |
| r1chardj0n3s | I'll have a look at the new reviews | 22:00 |
| *** jtriley has joined #openstack-horizon | 22:01 | |
| *** crobertsrh is now known as _crobertsrh | 22:01 | |
| *** EmilyW has joined #openstack-horizon | 22:02 | |
| *** ybathia has joined #openstack-horizon | 22:03 | |
| *** EmilyW has quit IRC | 22:07 | |
| *** EmilyW has joined #openstack-horizon | 22:08 | |
| *** mattfarina has quit IRC | 22:10 | |
| *** cody-somerville has joined #openstack-horizon | 22:11 | |
| *** lblanchard has quit IRC | 22:13 | |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Fix Jasmine unit tests failing https://review.openstack.org/159271 | 22:17 |
| *** nlahouti has quit IRC | 22:19 | |
| *** echevemaster has joined #openstack-horizon | 22:20 | |
| rbertram | tqtran: Are you still thinking of getting Users angularized in Kilo? | 22:24 |
| tqtran | rbertram: yes sir | 22:25 |
| rbertram | tqtran, TravT: another place where MS could potentially fit | 22:25 |
| tqtran | rbertram: precisely, but I'm ok with postponing it if there are too many issues with MS | 22:26 |
| tqtran | rbertram: the basic search that comes with smart-table will suffice if we cant get MS in reasonable shape | 22:26 |
| r1chardj0n3s | tqtran, rbertram yeah, I'd like to see a first cut of users make it in too | 22:27 |
| rbertram | tqtran: Having thought about it some more, I completely agree | 22:27 |
| *** stevemar has quit IRC | 22:27 | |
| r1chardj0n3s | tqtran: have we got all the user prerequisite angular parts in for that to proceed now? | 22:27 |
| tqtran | r1chardj0n3s: one more, david's policy work | 22:27 |
| r1chardj0n3s | ah, yep | 22:27 |
| tqtran | r1chardj0n3s: reviewing that atm | 22:27 |
| rbertram | David K & I are hoping to have the final xstatic package by Monday, and I'll start the requirement approval. But if we have any unresolvable problems with it after that, we pull it out. Easy fallback is to just use smart-table searches. | 22:28 |
| tqtran | rbertram: sounds great | 22:29 |
| *** TealThanatos has joined #openstack-horizon | 22:29 | |
| TravT | that sounds good | 22:29 |
| rbertram | So I'm keeping the momentum going on it, but knowing L-1 is a possibility | 22:29 |
| * tqtran give rbertram a thumbs up. | 22:30 | |
| ongk | tqtran: fix for Jasmine tests failing - https://review.openstack.org/159271 | 22:30 |
| tqtran | ongk: done, forgot to change path in jasmine as well :P my bad! | 22:31 |
| ongk | hehe, np | 22:32 |
| *** sbfox1 has joined #openstack-horizon | 22:32 | |
| *** mrunge is now known as mrunge_zzz | 22:33 | |
| *** nlahouti has joined #openstack-horizon | 22:33 | |
| *** sbfox has quit IRC | 22:33 | |
| *** ybathia has quit IRC | 22:35 | |
| *** oro has joined #openstack-horizon | 22:36 | |
| *** ybathia has joined #openstack-horizon | 22:38 | |
| *** ybathia has quit IRC | 22:38 | |
| *** ybathia has joined #openstack-horizon | 22:38 | |
| *** ybathia has quit IRC | 22:38 | |
| *** mpavlase has joined #openstack-horizon | 22:44 | |
| *** jwy has quit IRC | 22:48 | |
| *** jcoufal has joined #openstack-horizon | 22:50 | |
| *** jtriley has quit IRC | 22:52 | |
| *** mrunge_zzz has quit IRC | 22:53 | |
| *** ybathia has joined #openstack-horizon | 22:57 | |
| btully | is gate-horizon-jshint not working correctly a known issue? | 22:59 |
| btully | “This test has failed because it attempted to execute commands with sudo” | 22:59 |
| *** davelowe has quit IRC | 23:04 | |
| *** davelowe has joined #openstack-horizon | 23:06 | |
| *** oro has quit IRC | 23:10 | |
| *** peristeri has quit IRC | 23:12 | |
| *** iamjarvo has quit IRC | 23:13 | |
| *** mpavlase has quit IRC | 23:18 | |
| *** absubram has quit IRC | 23:19 | |
| *** gyee has quit IRC | 23:20 | |
| *** davelowe has quit IRC | 23:22 | |
| *** davelowe has joined #openstack-horizon | 23:24 | |
| *** vijendar has quit IRC | 23:24 | |
| *** davelowe has quit IRC | 23:25 | |
| *** davelowe has joined #openstack-horizon | 23:26 | |
| *** dboik_ has joined #openstack-horizon | 23:29 | |
| *** dboik has quit IRC | 23:33 | |
| *** dboik_ has quit IRC | 23:34 | |
| *** cody-somerville has quit IRC | 23:35 | |
| *** chlong has quit IRC | 23:43 | |
| *** chlong_ has quit IRC | 23:44 | |
| *** jwy has joined #openstack-horizon | 23:45 | |
| *** Drago has quit IRC | 23:47 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Auto-focus for modal dialog https://review.openstack.org/156785 | 23:48 |
| *** chlong has joined #openstack-horizon | 23:48 | |
| *** Piet has quit IRC | 23:49 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Demo for auto-focus https://review.openstack.org/158100 | 23:50 |
| *** jcoufal has quit IRC | 23:58 | |
| *** dboik has joined #openstack-horizon | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!