Friday, 2015-02-06

tsufiev_hello, horizoneers! Could anyone point me to the code in tables inline-editing where csrf-middleware token is generated?00:03
tsufiev_fast search for 'csrf' didn't help00:03
lhchengtsufiev_: thought horizon.ajax handles it somewhere..00:06
*** alexvictorchan has quit IRC00:06
lhchengtsufiev_: https://github.com/openstack/horizon/blob/master/horizon/static/horizon/js/horizon.tables_inline_edit.js#L21700:08
lhchengusually the csrf token is included in the form00:08
tsufiev_lhcheng, yep, thank you very much! I think that the token is generated on server-side00:08
lhchengtsufiev_: glad to help00:09
*** Piet has quit IRC00:22
*** Sukhdev has joined #openstack-horizon00:26
*** sqchen has joined #openstack-horizon00:41
*** sqchen has left #openstack-horizon00:49
*** sqchen has joined #openstack-horizon00:49
*** mgarza has quit IRC00:52
*** ericpeterson has joined #openstack-horizon00:53
openstackgerritMerged openstack/horizon: Create a reusable angular-based wizard  https://review.openstack.org/13741700:54
r1chardj0n3smerged!! \o/00:54
*** ericpeterson has quit IRC00:57
*** mpavlase has quit IRC01:00
*** zul has quit IRC01:03
openstackgerritThai Tran proposed openstack/horizon: Angular Modal  https://review.openstack.org/14093201:05
*** sqchen has left #openstack-horizon01:16
*** doug-fish has left #openstack-horizon01:16
*** sqchen has joined #openstack-horizon01:16
ongktqtran: ping01:22
tqtranongk: pong01:22
ongktqtran: for the tables, you want a separate patch for docs or in the same one?01:23
tqtransame one please01:23
*** lhcheng has quit IRC01:24
*** alexvictorchan has joined #openstack-horizon01:25
*** clu_ has quit IRC01:25
ongkIs there a separate JS documentation somewhere I can check out?01:26
ongktqtran: I’m only seeing the python docs01:28
tqtranMatt provided a pretty good example01:29
tqtranjust take a look at any of the angular directive and follow01:29
tqtranhttps://github.com/angular/angular.js/tree/master/src01:29
*** Sukhdev has quit IRC01:31
*** openstack has joined #openstack-horizon01:33
ongkOh, you mean in the JS file. Thought you meant something else :)01:34
*** TravT has quit IRC01:39
*** r1chardj0n3s is now known as r1chardj0n3s_afk01:40
*** alexvictorchan has quit IRC01:42
*** TravT has joined #openstack-horizon01:46
*** TravT has quit IRC01:53
*** rwsu is now known as rwsu-afk01:53
*** Sukhdev has joined #openstack-horizon02:00
*** sqchen has left #openstack-horizon02:03
*** sayan has joined #openstack-horizon02:06
*** ybathia has quit IRC02:09
*** bpokorny has quit IRC02:11
*** nlahouti has quit IRC02:20
openstackgerritKelly Domico proposed openstack/horizon: Pie and donut chart directive  https://review.openstack.org/14693402:24
*** ericpeterson has joined #openstack-horizon02:25
*** ericpeterson has quit IRC02:26
*** tqtran has quit IRC02:30
*** sayan has quit IRC02:47
*** harlowja is now known as harlowja_away02:48
openstackgerritKelly Domico proposed openstack/horizon: Re-designed and Angularized tables  https://review.openstack.org/14739303:07
*** r1chardj0n3s_afk is now known as r1chardj0n3s03:09
openstackgerritRichard Jones proposed openstack/horizon: Re-designed and Angularized tables  https://review.openstack.org/14739303:13
*** bpokorny has joined #openstack-horizon03:32
*** bpokorny has quit IRC03:33
*** bpokorny has joined #openstack-horizon03:33
*** sayan has joined #openstack-horizon03:34
*** Longgeek has joined #openstack-horizon03:36
openstackgerritKelly Domico proposed openstack/horizon: Re-designed and Angularized tables  https://review.openstack.org/14739303:38
*** mattfarina has joined #openstack-horizon03:40
*** lhcheng has joined #openstack-horizon03:44
*** tzumainn has quit IRC03:49
openstackgerritKelly Domico proposed openstack/horizon: Demo for Re-designed Tables  https://review.openstack.org/15110103:58
*** Sukhdev has quit IRC04:00
*** early has quit IRC04:04
*** early has joined #openstack-horizon04:25
openstackgerritTrung Trinh proposed openstack/horizon: Ignore Exception in process of Edit Attachments  https://review.openstack.org/15346004:26
*** lhcheng has quit IRC04:26
*** sayan has quit IRC04:28
*** TravT has joined #openstack-horizon04:29
*** TravT has quit IRC04:29
*** TravT has joined #openstack-horizon04:29
openstackgerritTrung Trinh proposed openstack/horizon: Ignore Exception in process of Edit Attachments  https://review.openstack.org/15346004:31
*** early has quit IRC04:43
*** EmilienM|afk has quit IRC04:45
*** sayan has joined #openstack-horizon04:45
*** EmilienM has joined #openstack-horizon04:46
*** nlahouti has joined #openstack-horizon04:47
*** neelashah has joined #openstack-horizon04:50
*** nlahouti has quit IRC04:50
*** nlahouti has joined #openstack-horizon04:51
*** mattfarina has quit IRC04:51
*** neelashah has quit IRC04:51
*** nlahouti has quit IRC05:13
*** nlahouti has joined #openstack-horizon05:13
*** nikunj2512 has joined #openstack-horizon05:14
*** tmazur_ has quit IRC05:17
*** r1chardj0n3s is now known as r1chardj0n3s_afk05:19
*** harlowja_away has quit IRC05:38
*** echevemaster has quit IRC05:42
*** jasondotstar has quit IRC05:43
*** early has joined #openstack-horizon05:47
*** ishant has joined #openstack-horizon05:48
*** early has quit IRC05:50
*** early has joined #openstack-horizon06:06
openstackgerritOpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex  https://review.openstack.org/15347606:10
*** masco has joined #openstack-horizon06:10
*** early has quit IRC06:12
*** early has joined #openstack-horizon06:23
*** rushiagr_away is now known as rushiagr06:29
*** openstackgerrit has quit IRC06:35
*** openstackgerrit has joined #openstack-horizon06:35
*** danieru has quit IRC06:36
*** tsufiev_ is now known as tsufiev06:37
*** danieru has joined #openstack-horizon06:37
*** early has quit IRC06:43
*** denis_makogon has joined #openstack-horizon06:43
*** early has joined #openstack-horizon06:49
*** denis_makogon has quit IRC06:56
*** josecastroleon has joined #openstack-horizon07:01
*** chlong has quit IRC07:12
*** chlong has joined #openstack-horizon07:13
*** jtomasek has joined #openstack-horizon07:34
*** nlahouti has quit IRC07:37
*** oro has joined #openstack-horizon08:07
*** zz_ttrifonov is now known as ttrifonov08:23
quist`Hello everyone, i have a question regarding modification of Horizon. Would this channel be the appropriate place for such questions?08:35
*** stevemar has quit IRC08:39
nikunj2512quist`: Seems so.. Please ask your question08:40
*** ygbo has joined #openstack-horizon08:40
*** markus_z has joined #openstack-horizon08:42
quist`nikunj2512: Ah ok, is it possible to add images to the Dashboards, groups and panels into the Horizon menu?08:46
nikunj2512quist`: yes.. Take a look at this wiki: http://docs.openstack.org/developer/horizon/quickstart.html#dashboard-configuration08:48
nikunj2512quist`: but you have to change some code...08:49
nikunj2512http://docs.openstack.org/admin-guide-cloud/content/dashboard-custom-brand.html08:49
*** alexpilotti has joined #openstack-horizon08:50
nikunj2512quist`: This will help you -> https://horizon-openstack-dashboard.readthedocs.org/en/latest/topics/customizing.html08:51
*** chlong has quit IRC08:53
openstackgerritVlad Okhrimenko proposed openstack/horizon: Wait till spinner is disappears  https://review.openstack.org/15160808:53
*** oro has quit IRC08:56
*** teju has joined #openstack-horizon08:57
*** jpich has joined #openstack-horizon08:59
*** amerine_ has joined #openstack-horizon08:59
*** amerine has quit IRC09:00
*** mpavlase has joined #openstack-horizon09:06
*** JeanBriceCombebi has joined #openstack-horizon09:06
*** JeanBriceCombebi has quit IRC09:23
*** jtomasek has quit IRC09:30
*** alexpilotti has quit IRC09:32
*** jtomasek has joined #openstack-horizon09:33
*** oro has joined #openstack-horizon09:37
*** robcresswell_afk is now known as robcresswell09:39
*** JeanBriceCombebi has joined #openstack-horizon09:39
robcresswellOoooh the Angular wizard went in09:41
*** e0ne has joined #openstack-horizon09:41
*** sayan has quit IRC09:43
*** jtomasek has quit IRC09:43
*** MaxV has joined #openstack-horizon09:45
*** jcoufal has joined #openstack-horizon09:46
*** e0ne has quit IRC09:49
*** e0ne has joined #openstack-horizon09:50
*** early has quit IRC09:51
*** SlickNik has quit IRC09:52
*** jpich has quit IRC09:52
*** raildo has quit IRC09:53
*** jcoufal has quit IRC09:55
*** sayan has joined #openstack-horizon09:56
*** SlickNik has joined #openstack-horizon09:57
*** jtomasek has joined #openstack-horizon09:57
*** jpich has joined #openstack-horizon10:06
*** raildo has joined #openstack-horizon10:06
*** chlong has joined #openstack-horizon10:09
*** oro has quit IRC10:12
*** agvanya has joined #openstack-horizon10:14
*** aix has joined #openstack-horizon10:16
*** agvanya_ has joined #openstack-horizon10:17
*** JeanBriceCombebi has quit IRC10:20
*** bluex-pl has joined #openstack-horizon10:21
*** bluex-pl has quit IRC10:21
*** bluex-pl has joined #openstack-horizon10:22
*** sayan has quit IRC10:22
*** JeanBriceCombebi has joined #openstack-horizon10:22
*** pkarikh has quit IRC10:23
*** e0ne is now known as e0ne_10:23
*** sayan has joined #openstack-horizon10:24
*** e0ne_ is now known as e0ne10:25
*** pkarikh has joined #openstack-horizon10:25
*** jcoufal has joined #openstack-horizon10:33
*** bpokorny has quit IRC10:36
*** bpokorny has joined #openstack-horizon10:44
*** JeanBriceCombebi has quit IRC10:54
*** bpokorny has quit IRC10:55
*** amotoki has joined #openstack-horizon10:56
*** JeanBriceCombebi has joined #openstack-horizon10:56
*** bpokorny has joined #openstack-horizon11:01
*** bpokorny has quit IRC11:07
openstackgerritNikunj Aggarwal proposed openstack/horizon: Adds styling of "Confirm Password" Field in user forms  https://review.openstack.org/15352011:11
*** ishant has quit IRC11:11
*** bpokorny has joined #openstack-horizon11:15
*** akrivoka has joined #openstack-horizon11:27
*** teju has left #openstack-horizon11:31
*** zigo has quit IRC11:42
openstackgerritRob Cresswell proposed openstack/horizon: Addresses Detail page inconsistencies & code style  https://review.openstack.org/15176211:46
openstackgerritRob Cresswell proposed openstack/horizon: Fixes inconsistent Router Details page  https://review.openstack.org/15122611:46
*** dachary has quit IRC11:48
*** dachary has joined #openstack-horizon11:48
openstackgerritRob Cresswell proposed openstack/horizon: Applies ImageFormCtrl to Admin > Images  https://review.openstack.org/13674411:49
robcresswellpkarikh: Don't suppose you feel like reviewing a mammoth patch? https://review.openstack.org/#/c/151762/9 :p11:51
*** e0ne is now known as e0ne_11:54
nikunj2512jpich: hi, i have a question about Launch Clusters.. In Launch Cluster form, we can import a keypair from the Launch Cluster form but if user don't have any image, they have to go to images panel to upload the image. Will it be good usecase to allow users to dynamically upload the image from the Launch Cluster form?11:54
pkarikhrobcresswell: wow.. Are you trying to refactor whole Horizon? :D11:54
robcresswellpkarikh: No, its just the details pages :(11:54
robcresswellpkarikh: The line count is really high because of file renames... May revert it just so it actually gets reviewed11:55
robcresswellpkarikh: It adds a common detail template and changes the styling so they all look consistent. Bit of a nightmare.11:55
*** JeanBriceCombebi has quit IRC11:58
*** bradjones has quit IRC11:59
*** e0ne_ is now known as e0ne11:59
*** zul has joined #openstack-horizon11:59
*** dsneddon has quit IRC12:00
pkarikhrobcresswell: rdopiera has replased icons in whole horizon with a few patches. So maybe if you divide it into several patches it will be reviewed a little bit faster.. For example as admin, than jobs, than clusters. It's really hard to find out how to separate them.12:00
*** dsneddon has joined #openstack-horizon12:00
pkarikhrobcresswell: how many time did you spent on it?12:00
robcresswellpkarikh: Yeah, I think that may the only way to do it. Will have to leave it to next week when I have some more time.12:01
*** zul has quit IRC12:01
*** zul has joined #openstack-horizon12:01
robcresswellpkarikh: Just been a gradual thing. It isn't complex... just repetitive.12:01
*** bradjones has joined #openstack-horizon12:02
nikunj2512ttrifonov: Hi, please can you take a look at this patch -> https://review.openstack.org/#/c/135256/4 as per your convience12:03
pkarikhrobcresswell: '+629, -1122' sounds like core-reviewers nightmare. :D12:03
robcresswellpkarikh: Yeah, the previous one was only about +300 -600. It hasnt picked up the renames, thinks they are new files :(12:04
*** julim has quit IRC12:04
robcresswellpkarikh: Which is *very* frustrating.12:04
robcresswellpkarikh: I'll break it down next week, ha12:05
*** bluex-pl has quit IRC12:06
*** bluex-pl has joined #openstack-horizon12:06
*** julim has joined #openstack-horizon12:06
*** jroll has quit IRC12:06
pkarikhrobcresswell: or you can just wait till most patient reviewers will see your patch. :) However, I'll try to take a look later.12:13
openstackgerritMerged openstack/tuskar-ui: Remove outdated FIXME  https://review.openstack.org/15327512:14
robcresswellpkarikh: Thankyou, I appreciate it. As I said, it isn't terribly complex, just *big*.12:17
robcresswellpkarikh: And its mainly HTML - easiest test is just to pull it and look through :)12:18
*** zul has quit IRC12:19
*** dachary has quit IRC12:19
*** miguelgrinberg has quit IRC12:19
*** medberry has quit IRC12:19
*** mgagne has quit IRC12:19
*** jroll has joined #openstack-horizon12:20
*** zul has joined #openstack-horizon12:20
*** medberry has joined #openstack-horizon12:20
*** dachary has joined #openstack-horizon12:20
*** miguelgrinberg has joined #openstack-horizon12:20
*** mgagne has joined #openstack-horizon12:20
pkarikhrobcresswell: no problem. :)12:27
openstackgerritVlad Okhrimenko proposed openstack/horizon: Wait till spinner disappears  https://review.openstack.org/15160812:49
*** sayan has quit IRC12:49
pkarikhHi all Do we have any bugs/blueprints about page load speed? I'm interested in the list of most 'heavy' pages in Horizon. Do we have any?12:52
robcresswellpkarikh: mattfarina has some ongoing work around JS memory management/cleanup, so he may have a good idea of slower pages12:56
*** early has joined #openstack-horizon13:01
*** masco has quit IRC13:03
jpichnikunj2512: Hi! I'm afraid I'm not very familiar with the Launch Cluster page, so I don't have any special thoughts on what could make it better, sorry. If you think there is a justification for this and it would be a good improvement, and that wouldn't be too complex to maintain - go for it!13:04
nikunj2512jpich: Ok.. Thank You13:05
*** early has quit IRC13:08
*** chaii has joined #openstack-horizon13:09
*** rushiagr is now known as rushiagr_away13:10
*** lblanchard has joined #openstack-horizon13:11
*** lblanchard has quit IRC13:13
*** tzumainn has joined #openstack-horizon13:14
*** JeanBriceCombebi has joined #openstack-horizon13:14
*** chaii has quit IRC13:16
*** athomas has joined #openstack-horizon13:16
openstackgerritAna Krivokapic proposed openstack/tuskar-ui: Auto-discover missing node parameters by default  https://review.openstack.org/15221913:19
*** alexpilotti has joined #openstack-horizon13:20
*** bluex-pl has quit IRC13:25
pkarikhrobcresswell: thanks!13:27
openstackgerritMerged openstack/tuskar-ui: Remove Inheritable*TestCase  https://review.openstack.org/15045413:31
*** lblanchard has joined #openstack-horizon13:32
*** gerchardon has quit IRC13:35
openstackgerritNikunj Aggarwal proposed openstack/horizon: Improves Launch Cluster model in Data Processing panel  https://review.openstack.org/13525613:44
ekarlsowhy does horizon do The settings.py file points to a v2.0 keystone endpoint, but v3 is specified as the API version to use. Using v3 endpoint for authentication.13:45
ekarlsowhen I tell it to use v2 ?13:45
nikunj2512ekarlso: You by default horizon uses V213:46
ekarlsonikunj2512: why does it use v3 then ?!13:47
nikunj2512ekarlso: but for you if Horizon is using keystone v3 than you can goto openstack_dashboard/local/local_settings.py and check there if Keystone V3 is enables or not13:47
ekarlsoit's not ...13:48
ekarlsoi've told it to use v213:48
*** sayan has joined #openstack-horizon13:48
nikunj2512ekarlso: Where you told it to use v2?13:48
*** oro has joined #openstack-horizon13:48
*** cbader has quit IRC13:49
*** _crobertsrh is now known as crobertsrh13:49
nikunj2512ekarlso: the setting in local_settings.py file is to use v3 and when horizon doesn't find the value of OPENSTACK_API_VERSIONS, it uses v213:49
*** rushiagr_away is now known as rushiagr13:50
*** athomas has quit IRC13:52
nikunj2512ekarlso: see here -> this is the code which tell keystone which version to use -> https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/keystone.py#L6113:52
*** bluex-pl has joined #openstack-horizon13:58
*** bluex-pl has quit IRC13:58
*** bluex-pl has joined #openstack-horizon13:59
openstackgerritWu Hong Guang proposed openstack/horizon: Integration test - Create and delete user  https://review.openstack.org/14302714:00
pkarikhDoes anyone know when lcheng usualy is around here?14:03
*** jroll has quit IRC14:03
*** jroll has joined #openstack-horizon14:03
*** quist` has quit IRC14:05
robcresswellpkarikh: US I believe - going back through logs. Have to be up late :p14:06
*** neelashah has joined #openstack-horizon14:08
*** radez_g0n3 is now known as radez14:11
openstackgerritSzymon Wróblewski proposed openstack/horizon: Refactor, customization and fixes of Metadata Widget  https://review.openstack.org/13643714:14
openstackgerritSzymon Wróblewski proposed openstack/horizon: Metadata display widget  https://review.openstack.org/15174514:14
*** rm_work|away is now known as rm_work14:17
openstackgerritWu Hong Guang proposed openstack/horizon: Integration tests - Run test on Windows with Chrome or IE  https://review.openstack.org/14742614:24
*** obutenko has joined #openstack-horizon14:25
*** davelowe has joined #openstack-horizon14:28
openstackgerritSzymon Wróblewski proposed openstack/horizon: Metadata widget multivalue selection support  https://review.openstack.org/15321014:28
*** sseago has joined #openstack-horizon14:30
openstackgerritWu Hong Guang proposed openstack/horizon: Integration tests - Run test on Windows with Chrome or IE  https://review.openstack.org/14742614:31
*** Ctina_ has joined #openstack-horizon14:31
*** mpavlase has quit IRC14:31
*** mattfarina has joined #openstack-horizon14:32
*** sseago has left #openstack-horizon14:34
*** ZZelle has quit IRC14:35
*** ZZelle has joined #openstack-horizon14:35
*** JeanBriceCombebi has quit IRC14:37
*** jpomero has joined #openstack-horizon14:39
*** JeanBriceCombebi has joined #openstack-horizon14:40
pkarikhmattfarina: Hello! Do you have a few minutes?14:40
mattfarinapkarikh sure. what's up?14:51
*** markus_z has quit IRC14:55
pkarikhmattfarina: I'm interested about some list of most heavy/long loading pages in horizon. robcresswell said that you could know something about fast/slow pages.14:57
mattfarinai know some things. they happen for a number of reasons. is there something specific you're looking for or to do?14:58
*** vijendar has joined #openstack-horizon15:03
openstackgerritMerged openstack/tuskar-ui: Make node registration fields required  https://review.openstack.org/15326515:06
mattfarinapkarikh are you looking to improve JS, clean up API calls, or something else?15:11
*** Drago has joined #openstack-horizon15:12
*** Drago has quit IRC15:12
pkarikhmattfarina: oh, sorry, haven't seen you answer. At this moment I just wont to know which pages are most slow15:12
*** Drago has joined #openstack-horizon15:12
*** rushiagr is now known as rushiagr_away15:15
*** stevemar has joined #openstack-horizon15:17
mattfarinapkarikh i've not walked through horizon to know for sure. but, on table listings that are long (like /identity/users with hundreds of users) you have lag. See https://bugs.launchpad.net/horizon/+bug/141189215:20
openstackLaunchpad bug 1411892 in OpenStack Dashboard (Horizon) "JS keyup/keydown making user create very difficult" [Undecided,New] - Assigned to Chris Johnson (wchrisjohnson)15:20
mattfarinapkarikh this has to do with the keydown event and the :input jquery psuedo selector15:20
mattfarinapkarikh on a page like that if you try to create a user you might see a lag of a few seconds from touching a key to a character showing up in a form15:21
pkarikhmattfarina: hm.. Ok, thanks. Right now I'm more insterested about just how long page is loaded frim server into the browser, but your info is very interesting too, thanks!15:22
mattfarinapkarikh ah. ok. i'll have to get back with you on that. i'm heading out the door on vacation and can't grab that information until I get back15:23
nikunj2512ttrifonov: Hi, i have addressed your comments in this patch ->https://review.openstack.org/#/c/135256/15:24
pkarikhmattfarina: ok, thanks. Have a nice vacations! :)15:26
openstackgerritAna Krivokapic proposed openstack/tuskar-ui: Auto-discover missing node parameters by default  https://review.openstack.org/15221915:29
*** Piet has joined #openstack-horizon15:31
*** athomas has joined #openstack-horizon15:33
*** JeanBriceCombebi has quit IRC15:33
openstackgerritMatt Borland proposed openstack/horizon: WIP - Instance Details UX/Angular redesign  https://review.openstack.org/15360215:40
*** MaxV has quit IRC15:44
*** neelashah has quit IRC15:46
*** nikunj2512 has quit IRC15:47
*** bpokorny has quit IRC15:52
*** lnxnut has joined #openstack-horizon15:54
openstackgerritMerged openstack/horizon: Imported Translations from Transifex  https://review.openstack.org/15347615:55
*** oro has quit IRC16:02
*** bluex-pl has quit IRC16:06
*** david-lyle_afk is now known as david-lyle16:07
*** bpokorny has joined #openstack-horizon16:10
openstackgerritPaul Karikh proposed openstack/horizon: Remove admin role name 'admin' hardcode  https://review.openstack.org/12374116:13
*** TravT has quit IRC16:18
openstackgerritRandy Bertram proposed openstack/horizon: Serial Console  https://review.openstack.org/14465916:19
*** jcoufal has quit IRC16:19
*** openstackgerrit has quit IRC16:21
*** openstackgerrit has joined #openstack-horizon16:22
*** TravT has joined #openstack-horizon16:34
openstackgerritPaul Karikh proposed openstack/horizon: Remove admin role name 'admin' hardcode  https://review.openstack.org/12374116:35
pkarikhdavid-lyle: hello! Could you please take a look at this patch (custom admin roles and RBAC) and tell me if I'm going in right or wrong direction. Thnak you!16:38
pkarikhdavid-lyle: hello! Could you please take a look at this patch (custom admin roles and RBAC) and tell me if I'm going in right or wrong direction. Thnak you! Here the patch: https://review.openstack.org/#/c/123741/16:39
pkarikhI'm sorry for spam :(16:39
*** pkarikh has quit IRC16:39
*** pkarikh has joined #openstack-horizon16:40
*** nikunj2512_ has joined #openstack-horizon16:40
pkarikhrobcresswell: sorry, I haven't enough time to take a look on your patch.  I'll try to do it on Monday.16:42
*** ybathia has joined #openstack-horizon16:46
*** pkarikh has quit IRC16:48
*** enykeev has quit IRC16:50
*** enykeev has joined #openstack-horizon16:52
*** nlahouti has joined #openstack-horizon16:53
*** josecastroleon has quit IRC16:57
*** cbader has joined #openstack-horizon16:59
*** jtomasek has quit IRC17:00
*** nikunj2512_ has quit IRC17:05
*** sayan has quit IRC17:05
*** nikunj2512_ has joined #openstack-horizon17:05
*** lhcheng has joined #openstack-horizon17:06
*** rwsu-afk is now known as rwsu17:09
*** Ala has quit IRC17:12
*** ttrifonov is now known as zz_ttrifonov17:14
nikunj2512_akrivoka: Please can you take a look at this patch -> https://review.openstack.org/#/c/124712/, as per your convenience17:16
*** bpokorny_ has joined #openstack-horizon17:20
*** raildo has quit IRC17:20
*** rwsu has quit IRC17:20
*** bpokorny has quit IRC17:23
*** early has joined #openstack-horizon17:23
*** e0ne has quit IRC17:24
*** fischerw has joined #openstack-horizon17:24
*** sqchen has joined #openstack-horizon17:24
*** raildo has joined #openstack-horizon17:24
*** jpich has quit IRC17:28
*** alexvictorchan has joined #openstack-horizon17:29
*** sayan has joined #openstack-horizon17:30
*** obutenko has quit IRC17:34
*** sivy has joined #openstack-horizon17:39
sivygood morning17:39
*** radez is now known as radez_g0n317:43
*** ZZelle has quit IRC17:44
fischerwdavid-lyle: If you get a chance, can you take a look at https://review.openstack.org/#/c/145870/. It is my understanding that this documentation change was something you asked for. Thanks.17:45
*** sqchen has quit IRC17:45
fischerwdavid-lyle: I work with gugl, gary-smith, jgravel, and rhagarty.17:47
*** rwsu has joined #openstack-horizon17:49
*** ZZelle has joined #openstack-horizon17:50
*** tjones1 has joined #openstack-horizon17:51
tjones1hi - i am trying to populate a dropdown menu based on the selection in another dropdown.  are there examples of how to accomplish this?17:52
*** ygbo has quit IRC17:55
robcresswellsivy: Evening! :p17:56
*** neelashah has joined #openstack-horizon17:58
*** sqchen has joined #openstack-horizon17:59
*** early has quit IRC18:00
*** garthb has joined #openstack-horizon18:01
*** gyee has joined #openstack-horizon18:03
*** garthb has quit IRC18:05
*** early has joined #openstack-horizon18:06
*** bpokorny has joined #openstack-horizon18:07
*** bpokorny_ has quit IRC18:10
tjones1looks like i need to use DynamicSelectWidget - so i am searching for examples of that18:12
*** harlowja has joined #openstack-horizon18:15
*** early has quit IRC18:20
*** e0ne has joined #openstack-horizon18:26
*** sayan has quit IRC18:30
*** bpokorny_ has joined #openstack-horizon18:33
*** bpokorn__ has joined #openstack-horizon18:35
*** bpokorny has quit IRC18:36
*** bpokorny_ has quit IRC18:38
*** early has joined #openstack-horizon18:38
openstackgerritAna Krivokapic proposed openstack/tuskar-ui: Join node registration and upload forms  https://review.openstack.org/15365018:41
*** bpokorny has joined #openstack-horizon18:42
*** bpokorn__ has quit IRC18:45
*** sayan has joined #openstack-horizon18:50
*** early has quit IRC18:53
nikunj2512_david-lyle: Hi, please take a look at this patch-> https://review.openstack.org/#/c/135256/4 as per your convenience18:54
*** TravT has quit IRC18:56
*** TravT_ has joined #openstack-horizon18:57
*** oro has joined #openstack-horizon19:01
*** mattfarina has quit IRC19:04
*** mattfarina has joined #openstack-horizon19:04
*** Ctina_ is now known as Ctina19:05
openstackgerritShaoquan Chen proposed openstack/horizon: add .idea to gitignore  https://review.openstack.org/15366219:05
*** sayan has quit IRC19:05
*** akrivoka has quit IRC19:07
*** alexpilotti has quit IRC19:12
*** nikunj2512_ has quit IRC19:23
*** nikunj2512_ has joined #openstack-horizon19:24
openstackgerritChad Roberts proposed openstack/horizon: Guided job execution page for Sahara  https://review.openstack.org/14791819:26
openstackgerritChad Roberts proposed openstack/horizon: Guided cluster creation mode for Sahara  https://review.openstack.org/14767719:26
*** e0ne has quit IRC19:28
*** tqtran has joined #openstack-horizon19:31
*** oro has quit IRC19:38
*** mpavlase has joined #openstack-horizon19:45
*** Miouge has joined #openstack-horizon19:46
*** bradjones has quit IRC19:47
*** early has joined #openstack-horizon19:50
*** Ctina has quit IRC19:50
*** bradjones has joined #openstack-horizon19:50
*** radez_g0n3 is now known as radez19:50
*** early has quit IRC19:53
*** ctina has joined #openstack-horizon19:54
*** early has joined #openstack-horizon19:58
*** ctina has left #openstack-horizon19:59
*** ctina has joined #openstack-horizon20:00
*** early has quit IRC20:03
*** ctina has quit IRC20:05
*** early has joined #openstack-horizon20:07
*** raildo has quit IRC20:07
openstackgerritMatt Borland proposed openstack/horizon: WIP - Instance Details UX/Angular redesign  https://review.openstack.org/15360220:07
openstackgerritKelly Domico proposed openstack/horizon: Re-designed and Angularized tables  https://review.openstack.org/14739320:08
openstackgerritKelly Domico proposed openstack/horizon: Demo for Re-designed Tables  https://review.openstack.org/15110120:09
*** bpokorny_ has joined #openstack-horizon20:09
*** nlahouti has quit IRC20:10
*** bpokorn__ has joined #openstack-horizon20:11
*** bpokorny has quit IRC20:13
ongktqtran: ping20:13
*** bpokorny_ has quit IRC20:14
*** early has quit IRC20:14
tqtranongk: pong20:17
ongktqtran: updated the table docs. Used ngdoc. Do you have a preference?20:18
ongkvs jsdoc?20:18
openstackgerritChad Roberts proposed openstack/horizon: Guided cluster creation mode for Sahara  https://review.openstack.org/14767720:19
openstackgerritChad Roberts proposed openstack/horizon: Guided job execution page for Sahara  https://review.openstack.org/14791820:19
tqtranngdoc is fine20:19
ongkthere isn’t a mechanism in place to generate the docs yet, is there?20:20
*** nlahouti has joined #openstack-horizon20:20
*** early has joined #openstack-horizon20:24
openstackgerritMerged openstack/horizon: add angular-bootstrap to jasmine spec runner page  https://review.openstack.org/15281420:31
fischerwdavid-lyle: thanks for the review. will push changes later today.20:33
david-lylefischerw: np, thanks for your efforts20:33
* TravT_ is sad... just discovered computer is on corporate network and can't pull patches.20:35
*** TravT has joined #openstack-horizon20:36
david-lylewifi20:37
david-lyleTravT20:37
TravTyep20:37
david-lyleor are you somewhere else?20:37
TravTno, i'm in the office20:37
*** stevemar has quit IRC20:37
TravTjust switched, so good to go again20:37
*** stevemar has joined #openstack-horizon20:38
*** TravT_ has quit IRC20:38
TravTongk: are you there?20:40
ongkTravT: yup, what’s up?20:40
TravTis your demo patch supposed to also include sorting?20:40
ongkNot at the moment. Don’t have the dragAndDrop library in Horizon yet20:41
TravTok.20:41
TravTso that will be a subsequent patch?20:41
ongkOh wait - I misunderstood maybe. I was thinking re-ordering the rows.20:42
TravTno, i'm thinking the sort by clicking table row header20:42
ongkI didn’t include sorting in the demo patch but can probably do that20:42
TravTyeah, drag and drop is something diff20:43
david-lyleI'm definitely pro-sorting20:43
david-lyle:D20:43
TravTyeah, if you can include the demo of sorting.20:44
david-lylesorting > no sorting20:44
tqtransorting? you dont need that20:44
TravTI'd like to see how that works in comparison to the mockups we all went through.20:44
david-lylesee what I did there20:44
david-lyletqtran: well, I don't20:44
david-lylebut some may20:44
ongksure, will do20:44
david-lyleongk: your nick was not obvious20:45
tqtrandavid-lyle: i believe thats her last name20:45
david-lylesaw it many times thinking, who is that?20:45
david-lyleeh-eh20:45
* tqtran laughs secretly....20:45
ongkhaha20:45
david-lyleah20:45
david-lylesuch shenanigans20:46
esp;)20:46
TravT\me was actually just thinking of how Dan's nick is also non-obvious20:46
* TravT can't type correctly slash20:47
espwell yeh…20:47
david-lylehe already knew that20:47
espblame the rax dudes, they all had such cool handles20:47
espI didn’t want to appear inadequate at that too20:47
TravTlol20:47
ongksadly, someone started using my other name to buy stuff at Urban Outfitters20:49
*** early has quit IRC20:49
espdavid-lyle: I’m hoping to get a new patchset up soon for domain-scoped-tokens work today20:49
espyour DOA patch looks good so far20:50
david-lyleinconceivable20:50
openstackgerritShaoquan Chen proposed openstack/horizon: Correcting JavaScript files order  https://review.openstack.org/15368620:50
david-lyleIt worked what I tried it out20:50
espseriously, I was gonna get my bag of +1’s out and everything..20:50
david-lylein all the cases I claimed, but let me know where I mucked it up20:51
*** r1chardj0n3s_afk is now known as r1chardj0n3s20:51
TravTwhere do you get that bag of +1's?20:51
espnp, I’m sure I’ve got some things to iron out too20:51
TravTDo they sell those in Washington state?20:52
espTravT: I stole them ;)20:52
TravTok... thought maybe they'd be in the new vending machines I heard about20:52
openstackgerritMatt Borland proposed openstack/horizon: WIP - Instance Details UX/Angular redesign  https://review.openstack.org/15360220:53
ongkTravT: ha, don’t need to buy ‘em. Just walk down the street and get it for free20:54
*** bpokorny has joined #openstack-horizon20:55
*** htruta has quit IRC20:55
TravTongk: lol20:58
*** bpokorn__ has quit IRC20:58
openstackgerritKelly Domico proposed openstack/horizon: Demo for Re-designed Tables  https://review.openstack.org/15110121:00
* TravT pulls https://review.openstack.org/15110121:01
ongkTravT: username is sorted by default21:01
david-lylehopefully that's true for all tables21:02
david-lyle:D21:02
TravTjust pulled it.  was very disappointed i could sort by action buttons. ;-)21:03
TravTcould -> couldn't21:03
TravTongk: sort looks just like the mocks.  awesome21:04
ongkTravT: is that hover sort icon too light?21:05
TravTlet me see if i can grab piet21:05
TravTto get his opinion21:05
ongkI can make it bright red. j/k21:06
PietTravis, need you in an interview21:06
TravTi vaguely remember discussions of pink and fuschia21:06
TravTPiet: ok21:07
david-lylePiet can you really call for help in interviews?21:07
david-lyleif you don't know the answer, fess up21:07
PietFunny...21:07
david-lyleI bet21:07
TravTROFL21:07
PietTravis, stop laughing and get into the interview!21:08
david-lyleat least you'll have an answer for what's your greatest weakness21:08
*** Miouge has quit IRC21:08
david-lyleerr, opportunity for improvement21:08
openstackgerritChad Roberts proposed openstack/horizon: Data Processing: changing labels of submit buttons  https://review.openstack.org/15369321:09
PietMy social skills?21:10
PietYou should be nice...this person will be doing UX work for the community fulltime21:10
david-lyleok, 2 opportunities21:10
david-lyle:D21:10
david-lyleoooh, nice21:11
openstackgerritMatt Borland proposed openstack/horizon: WIP - Instance Details UX/Angular redesign  https://review.openstack.org/15360221:11
Pietdavid; you might be interviewing him at some point21:11
sqchendavid-lyle: Hi David, please take a look at https://review.openstack.org/153686, a first step to inject javascript file from HORIZON.js_files.21:12
david-lyleif you want21:12
david-lylePiet21:12
*** jpomero has quit IRC21:13
openstackgerritDavid Lyle proposed openstack/horizon: Making modify usage report params modal  https://review.openstack.org/15369421:13
*** gary-smith_ has joined #openstack-horizon21:13
david-lyleLow-hanging review there folks ^^^^21:14
david-lylechanging the world21:14
david-lyleone css class at a time21:14
espdavid-lyle: you should hire some PR ;)21:14
david-lyleI certainly need help21:15
*** alexvictorchan has quit IRC21:16
*** alexvictorchan has joined #openstack-horizon21:16
david-lylesqchen: I look in a little bit, busy changing the world21:16
david-lyleThanks for looking into it21:17
sqchenjust want to get the direction right. :)21:17
david-lyletqtran, r1chardj0n3s and I were discussing a bit yesterday21:18
david-lyle*discussing it21:18
r1chardj0n3srunning away from it21:18
r1chardj0n3slooking at it all side-eye21:18
david-lyler1chardj0n3s: it's saturday, you punishing yourself for something?21:19
r1chardj0n3syou lot are always busy on Friday afternoons/evenings so it behooves me to drop in an see what you are all up to so there's no big surprises on Monday :)21:19
r1chardj0n3salso Monday is really quiet ;)21:19
david-lylesqchen: I should have looked before punting21:21
david-lyleI was expecting something monstrous21:21
david-lyleThat's a reasonable start21:22
david-lylewhy we were loading them in earlier is a mystery to me21:22
david-lylesqchen: question, how does a new angular panel in the horizon tree take advantage of this?21:24
sqchenI guess people don’t know what we want to add to the js_files.21:24
*** r1chardj0n3s is now known as r1chardj0n3s_afk21:24
david-lylesqchen: for extensions it's easy21:24
david-lylefor in-tree the issue I had was do we really want to hard-code all these21:25
david-lylemaybe we just move all panels to be plugins21:25
david-lylethat live in tree21:25
david-lylehave them specify their custom js files in the enabled/my_panel.py file21:26
david-lyleand their modules21:26
david-lyletqtran: thoughts21:26
david-lylesqchen: but the loading order should be fixed either way21:27
david-lyleso your patch makes sense21:27
sqchenHaving  the file listed centrally somewhere make sense to me. With that we do not need to redo the same thing for jasmine test21:27
david-lylesqchen: which file?21:27
david-lyleto include in the jasmine test runs?21:28
sqchensorrey, having all the js files listed ...21:28
david-lylebut jasmine is a good point21:28
david-lylewe will want to tie them in there as well21:28
sqchenmy typing is very slow…21:28
david-lylemaybe a test_js_files field in the enabled/my_panel.py file as well21:29
tqtrantqtran: one sec, catching up on chat21:29
sqchencurrently all js sources and spec are defined in another python class.21:30
TravTtqtran: do you always talk to yourself?21:30
david-lylewon't auto complete my own nick21:31
sqchencurrently all js sources and spec files for Jasmine are defined in another python class.21:31
* david-lyle makes be a smart-ass harder21:31
*** radez is now known as radez_g0n321:31
david-lylesqchen: don't you think that will need to be pluggable?21:31
esphaha21:31
tqtranTravT: dont we all? :P21:32
david-lyleI think if you analyzed my contributions in IRC, you would deduce my English fluency is that of an eight year old21:32
david-lylenot, far off actually21:32
sqchenSo if we could have source files defined for production AND jasmine togeter somewhere. it will save us some time.21:33
tqtransqchen, david-lyle: so my concern is that we're basically moving the hardcode from one location to another21:33
david-lylean enabled file21:33
david-lyletqtran: it's all hard-coded at some level21:33
espbpokorny: thx for review comments, fixin some of them now21:33
tqtransqchen: but i do agree that this is a small step that would help with jasmine tests21:33
openstackgerritChad Roberts proposed openstack/horizon: Guided cluster creation mode for Sahara  https://review.openstack.org/14767721:34
bpokornyesp: No problem.  Sounds good.21:34
david-lyletqtran: it's localized to the panel directory, or enabled file21:34
tqtrandavid-lyle: it just seems a bit strange to me that we would move our js files to a settings CONFIG object21:34
david-lyletqtran: only for panel specific js21:35
david-lylenot general widgets21:35
david-lylethe file paths, not the files21:35
tqtrandavid-lyle: if that were the case, it makes little sense to do it for jasmine tests even. since jasmine tests will require all of the widgets be present to test21:35
david-lyleI want jasmine to run tests for the panels too, no?21:36
openstackgerritChad Roberts proposed openstack/horizon: Guided job execution page for Sahara  https://review.openstack.org/14791821:36
david-lylethere are two classes of js code here21:36
sqchendavid_lyle: I don’t understand the how plug system works yet.21:36
tqtrandavid-lyle: yes, but now the config object will explode21:36
david-lylegeneral purpose and specific21:36
david-lylefor general, it makes sense to lump them all together in a link file21:37
david-lyles/link/import/21:37
david-lyletqtran: with what, 10 path strings?21:37
david-lylethe js files still live in the panel's static dir21:37
*** clu_ has joined #openstack-horizon21:37
TravTdavid-lyle: are you saying plugin per panel?21:37
TravTor could we have plugins even within a panel.21:38
david-lyleTravT: you win21:38
david-lyleformer not latter21:38
david-lylebut latter eventually21:38
TravTthat would be super ideal21:38
david-lylebut that mechanism doesn't exist yet21:38
david-lylethe sub-plugin plugin21:38
TravTone of the biggest problems projects face in horizon is that they essentially can't "decorate" a panel with extra functionality21:39
david-lylethey can, but it's requires some stake in the game21:39
TravTexactly.21:39
TravTwell, maybe.21:40
TravTcan you clarify21:40
david-lylea custom horizon app with template overrides21:40
david-lylethe main way to do extensive modifications to horizon21:40
TravTok.21:40
david-lylestake is they have to build and maintain that app21:40
TravTyeah.21:40
david-lylebut that's what most companies do already21:41
david-lyleunless they are delivering vanilla horizon21:41
*** amotoki has quit IRC21:41
tqtrandavid-lyle: ok I get what you're saying about template overrides, but im not sure how that is connected to the config object21:41
david-lylesqchen: the system actually works pretty well21:41
tqtrandavid-lyle: you kinda lost me there21:42
david-lylethe config object contains an optional field to specify js files in your plugin to add to the _scripts.html file dynamically21:43
* TravT happy not the only one.... i thought we were talking about angular plugins for a panel.21:43
david-lylereset21:43
david-lylewe're trying to figure out a way to pull in js files from in tree panels without hard-coding them in _scripts.html21:44
tqtrandavid-lyle: but couldnt you do that already if you extend the _script template?21:44
TravTbut tqtran: isn't that an all or nothing?21:45
david-lyletqtran: if I have a _script file with 500 entries, I'll shoot myself21:45
tqtrandavid-lyle: ok, just to clarify, when we have js files, are we talking  about libraries, our js files, or plugin js files?21:45
tqtran*when we say21:45
* robcresswell is starting to regret trying to fix every single Details page21:45
tqtranTravT: no, you can extend the template, its not a complete replacement21:45
*** nlahouti has quit IRC21:45
tqtranTravT: although you could replace it if you want to21:46
david-lyleyou want me to extend it for every panel?21:46
david-lylewhat if I want to use something cross-panel?21:46
tqtrandavid-lyle: no, just once because its part of the base template21:46
tqtrandavid-lyle: lets say you need js 1,2,3 for panels a,b,c. you would extend _scripts to include 1,2,3 and panels a,b,c should work21:47
david-lylewhere's sqchen's patch for launch instance?21:47
*** alexpilotti has joined #openstack-horizon21:47
tqtranhttps://review.openstack.org/#/c/152822/2/horizon/templates/horizon/_scripts.html21:48
*** nlahouti has joined #openstack-horizon21:48
david-lyletqtran: yeah, that. that's not going to happen21:49
david-lylethat makes no sense21:49
tqtrandavid-lyle: so what are you proposing? that we move these includes into the config object?21:49
TravThttps://review.openstack.org/#/c/152822/21:49
david-lyleper panel21:49
TravTSean has a question on the bottom there21:49
david-lylewe're discussing that now, I believe21:50
tqtrandavid-lyle: per panel.... ok i'm starting to maybe follow21:50
tqtrandavid-lyle: but the issue is that we are moving toward a single-page-app21:50
TravTdavid-lyle: yes i agree with the premise of what you are saying21:50
*** vijendar has quit IRC21:50
tqtrandavid-lyle: so loading it per panel would actually be longer load time21:50
david-lyletqtran: some day, but you'll still need a dynamic mechanism to extend it21:51
TravTtqtran:21:51
david-lyletqtran: not loading per panel21:51
david-lylespecifying per panel21:51
TravTthe loaded modules would be injected into this dynamically?21:51
david-lylethey all end up loaded here: https://review.openstack.org/#/c/153686/1/horizon/templates/horizon/_scripts.html line 6921:51
*** oro has joined #openstack-horizon21:52
tqtrandavid-lyle: could you provide an example of what the config object would look like?21:52
sqchenWe may need a client-side dynamic mechanism to load JS file as well, in the future.21:52
david-lylereal life extension today21:53
david-lylehttps://github.com/stackforge/monasca-ui/blob/master/monitoring/enabled/_50_admin_add_monitoring_panel.py21:53
david-lyleso we already have a mechanism to dynamically (just not hard-coded in one file) angular modules and js files21:53
david-lylejust use that to load the panels21:53
sqchenI got it, but for launch instance where I should list JS files?21:54
david-lylespecify all the ADD_JS_FILES for the panel21:54
tqtrandavid-lyle: ok, that that config object gets loaded into scripts. i still don't see how that is panel-specific?21:54
david-lylethat one's at the dashboard level21:54
tqtrandavid-lyle: its globally available in the base page21:54
sqchenwhich panel is for launch instance21:54
tqtranoh....21:54
david-lylesqchen: instances panel21:54
TravTinstances21:54
david-lyleno config file yet21:55
david-lylethat's what I'm suggesting21:55
david-lylecreate one for all panels21:55
david-lyleuse the mechanism we have21:55
david-lyleadd a new field for ADD_JASMINE_FILES21:55
david-lyleand bob's your uncle21:55
sqchenas a base panel>21:55
david-lylesqchen: huh?21:56
TravTsome wizards can be launched from more than one panel...21:56
TravTfor example, network panel today let's you launch in instance21:56
TravTwould they both specify all the scripts?21:56
sqchenshould the launch instance panel a base panel?21:56
david-lylesqchen: no21:56
sqchenok21:57
david-lyleTravT: some things should be common in openstack_dashboard21:57
david-lylewhich is where we talked about putting those things as well21:57
sqchenADD_JASMINE_FILES for jasmine spec file, right?21:57
david-lylesome time in the distant past21:57
david-lylesqchen: yes21:57
tqtrandavid-lyle: so for each panel, we would have a settings.py?21:59
*** crobertsrh is now known as _crobertsrh21:59
sqchenTravT: only the applied wizard should go to panel. the wizard widget stay the curretly way of loading — in _script.html21:59
david-lyletqtran: basically an enabled file21:59
sqchendavid-lyle: it there an example there I can follow?22:00
david-lylesqchen: for?22:01
sqchenis there an example there I can follow to have a seeting.py for instance panel?22:01
TravTok, i have to go somewhere. brb.  but, it also seems to me that for customization it wouldn't have to even be at openstack_dashboard level22:01
TravTa panel should just say what module it depends on22:02
sqchenAgree with TravT22:02
*** mattfarina has quit IRC22:02
TravTi don't think every panel should track all its js independently22:03
david-lyleTravT: only if it's isolated to that panel22:03
tqtranI think the modules can be left out, we can just list it inside the JS22:03
tqtranso the ADD_ANGULAR_MODULES field is not neccessary22:03
sqchenYes, I think it is, at the first glance it seems no though22:04
TravTbe back in 30 mins. :(22:04
tqtransqchen: angular has DI for that, why do we need to inject that using python?22:05
sqchenit can make the code break if the modules names defined in panel, but delcaird in horizon.js22:05
tqtranfor example: for your module requires 'monitoringApp22:05
david-lylebecause my panel's js should know that it needs to be appended to angular.module.hz.widgets?22:05
david-lylethat's not the right path22:06
*** nikunj2512_ has quit IRC22:06
david-lylebut it requires internals knowledge of horizon22:06
tqtranwell no, it shouldnt need to append to hz.widgets22:06
david-lylewas a for instance22:06
sqchenDI is for providers, the module themselves cannot be injected.22:06
openstackgerritRob Cresswell proposed openstack/horizon: Addresses Detail page inconsistencies & code style  https://review.openstack.org/15176222:06
*** nikunj2512_ has joined #openstack-horizon22:07
tqtranI think a concrete piece of code will really help here. I think we're on the same page but not understanding each other clearly22:08
robcresswellTravT: I tidied up that details patch... I think its a good start for a unified template and a more common theme. Data_processing pages are also done, Network Details in the pipeline...22:08
robcresswellTravT: Would really appreciate comments if you get some time :)22:08
tqtrandavid-lyle: but yes, the proposed mechanism should work22:09
*** fischerw has quit IRC22:09
tqtranwell its not proposed since its already there....?22:09
*** bradjones has quit IRC22:09
david-lyletqtran: I'm proposing to use the existing mechanism22:09
TravTi'm back (for 20 mins).22:09
sqchenFor the statically added framework level components, like wizard widget, the current way of decalred modue dependencies is correct. But for dynamically added modules, there name cannot be statically added.22:09
*** fischerw has joined #openstack-horizon22:10
*** mattfarina has joined #openstack-horizon22:10
david-lylelast part is cross panel js that is not a base widget22:10
*** mattfarina has quit IRC22:10
david-lyleI think that's just part of openstack_dashboard/static22:10
david-lylethe soon to be network wizard e.g.22:11
TravTrobcresswell: will do. might be this weekend or monday.22:11
*** zigo has joined #openstack-horizon22:11
tqtrandavid-lyle: sigh.. so we're gonna have 3 places to add scripts?22:11
tqtrandavid-lyle: i thought 2 was already confusing enough, now we're gonna hve 3......22:11
tqtranactually 4, not counting the settings.py22:11
robcresswellTravT: Not expecting reviews over the weekend, haha. Just keep it in mind :)22:11
david-lylehow many places do we add python files?22:12
david-lylehtml files?22:12
david-lylethere is a reason they are placed where they are22:13
david-lylelogical separation22:13
*** bradjones has joined #openstack-horizon22:13
david-lylemonolithic lists are bad for everything22:13
david-lylejust ask Santa22:13
TravTi think we need to sketch out a bigger vision for dynamic content, but in the meantime, why can't it simply by a list of angular modules needed by the panel and then this little snippet in _scripts.html goes into that module and adds the js files?22:14
david-lyleTravT: how?22:15
*** fischerw has quit IRC22:15
TravT'doh22:15
*** cbader has quit IRC22:15
*** fischerw has joined #openstack-horizon22:16
david-lylein essence, I'm trying establish that mechanism22:16
TravThow what?22:17
tqtrandavid-lyle: is it possible to extend if we have a static folder in each panel?22:17
tqtrandavid-lyle: so instead of a config file, we just pick up the static folder and do template override/extend22:18
david-lyleoverride what?22:18
tqtrandavid-lyle: the _script.html22:18
tqtrandavid-lyle: basically, the ADD_JS_FILES eventually get included in the _script.html22:19
david-lyletqtran: yes22:19
david-lylebut overriding _scripts for each page seems like overkill22:20
david-lyleI have two goals here22:21
david-lyleextensibility22:21
tqtrandavid-lyle: it is, but that is pretty similar to what we're doing with the settings.py22:21
* TravT studying code22:21
tqtrandavid-lyle: when we have the ADD_JS_FILES, we are in essence, regenerating the _script.thml22:21
tqtraneach time for each panel22:21
david-lyleno22:21
david-lylenot at all22:21
david-lyleat startup22:22
sqchenWIth angular DI, if we could have all the files that define modules but not only using modules listed before any other JS file, the order doesn’t matter. With this fact, we DO NOT need to have any JS file list. The only thing we need is a pattern to collect JS file automatically.22:22
david-lylewe build a list of ADD_JS_FILES22:22
tqtranok so this is done prior to any page loading22:22
sqchenyes build it automatically, not manually,22:22
tqtranit just appends them all at the global level, then insert all at once22:23
david-lylethen when the _scripts.html template gets loaded, it adds all the JS file includes22:23
sqchenright22:23
tqtrandavid-lyle: yes, but when it does the insertion, isn't it modifying the _script.html? how is that different than extending and including a new script tag?22:24
*** tjones1 has left #openstack-horizon22:24
tqtranfor example: the _header.html we have in dashboard today extends the one in horizon22:24
TravTwhat all does collectstatic do?22:25
david-lyleTravT: mostly collects static files :P22:25
robcresswellhaha22:25
tqtranlol22:26
* TravT that seems odd22:26
TravTlol22:26
robcresswelltqtran: o/22:26
*** stevemar has quit IRC22:26
david-lyleit walks all the static dirs and makes those files available, js, images, etc22:26
david-lylein theory it aggregates them22:26
TravTthat's what I figured (just never actually looked at the code)22:27
david-lylethen you come through and compress22:27
tqtranright, so if we have these static folders in each panel. it will do the same thing right?22:27
david-lylebut compress is it's own step22:27
david-lyletqtran: you have to link them22:27
*** stevemar has joined #openstack-horizon22:27
tqtranok, so how hard would it be to link them?22:27
david-lyleas easy as a for loop in _scripts.html after you've added those file paths to your enabled files :D22:28
david-lyleusing ADD_JS_FILES22:28
tqtranlol22:28
david-lylethe other part which TravT makes a good point of22:29
david-lyleis we'll want all of them compressed together22:29
david-lyleif you do it in the panel dirs, we won't get that22:29
david-lyleyou can have a bunch of compressed blobs22:29
david-lylebut not one22:29
*** fischerw has quit IRC22:30
david-lylethat's what you were getting at right TravT?22:30
*** fischerw has joined #openstack-horizon22:30
TravTI was wondering how this would affect that22:30
david-lyle:-)22:30
tqtrannoob question incoming: if i have panel A and B, and in panel A i need js 1,2,3 and in panel B i need js 3,4,5. when i visit panel A, do i see 1,2,3,4,5? or do i only see 1,2,3?22:30
TravTsince I manaully run collectstatic and compress about 20 times a day22:30
david-lyleright now you see 1-522:31
*** fischerw has quit IRC22:31
tqtranbasically, along similar line, is it compress all at once, or per panl?22:31
* TravT sigh... my time ran out again and I have to run again. be back in 30.22:31
*** fischerw has joined #openstack-horizon22:31
david-lyleif they're added via enabled, the same22:32
david-lyleif they're added via a per panel compress, you could get 1,2,3 and 3,4,5 separately22:32
david-lylebut then 3 should really be a part of common blob A22:32
david-lyleand 1,2 should be panel blob and 4,5 should be panel blob22:33
tqtrandoes django save those blob or is it generated each time?22:33
david-lylethey're placed in the root static22:33
david-lylethat's where you pull 1231ab434325be43.js from22:34
david-lyleand 12312bcd7789e.css from22:34
david-lylethen those are cached by your local browser and you only load them once22:35
tqtranif we decide to do this, i would like to see angular templates get included and compress as well22:35
tqtraninstead of ajax fetching them when needed22:35
*** lnxnut has quit IRC22:35
david-lyletqtran: js or html?22:35
tqtranhtml22:35
david-lylenot sure how you do that22:36
tqtranvia a scrip tag, let me find an example....22:36
david-lyleI don't think collectstatic or compressor is built for HTML22:37
sqchenI know what is this. but that will load all templates no matter we need them or not.22:37
*** oro has quit IRC22:38
sqchenI prefer lazy loading22:38
tqtransqchen: yes, but it'll be faster once page loads is completely. and it would also solve the jasmine issue. Im not too crazy about how we're doing it in jasmine today22:38
*** lblanchard has quit IRC22:39
sqchenI am wordering the memory use, not the loading time...22:39
tqtranthe base angular widget templates. doesn't ahve to be panel specific22:40
tqtransince we're doing it for the js, might as well include the template22:40
sqchenGet the page initialzed faster seems a better UX.22:40
sqchenI don’t think we should load all JS files as well22:41
sqchenI prefer increamental loading. Some UI will never open for some user.22:42
david-lylesqchen: I tend to agree22:42
david-lylethat's not how things are structured now22:42
david-lylebut we can junk up the compressed objects22:42
sqchenThis is especially important for mobile devices.22:42
david-lyleI just don't want duplication22:43
fischerwdavid-lyle: For https://review.openstack.org/#/c/145870/11/doc/source/topics/tutorial.rst, for the "circular" comments, did you mean that the comments after the links were unneeded, since following the link gave the details.22:43
*** neelashah has quit IRC22:43
david-lylefischerw: I meant for FilterAction you indicate that it's an action that filters. It would be nice to either reword the description to not echo the class name, or not have it22:44
david-lylepreferably the former22:44
david-lyleit's like saying hairdo is a do for hair22:45
sqchenI agree to load all basic templates together as tqtran said though.22:45
david-lyleit doesn't really help if I don't already know what a hairdo is22:45
david-lylesqchen: html tempates?22:45
sqchenright22:46
tqtransqchen: i think that was a question lol22:46
sqchenbut only for generic templates22:46
sqchencool. we agrred :)22:46
david-lylewhat I'd really like is to get a working solution and then optimize22:47
david-lylebut it will influence the design a bit22:47
tqtranor optimize before we write code, and then never go anywhere22:47
sqchenI think we can optimize later, it is not an issue right now.22:48
david-lylehere's what I don't want, change panel js, add an angular file, have to edit horizon/templates/_scripts.html in the same patch22:48
david-lylethat's too much coupling22:49
sqchenor someon can do it transparently.22:49
david-lylethat doesn't need to work like that22:49
*** fischerw has quit IRC22:49
sqchendavid-lyle: I agreed on that. This is why I had the fix this morning.22:49
david-lylesqchen: I understand22:50
tqtrandavid-lyle: i agree that its more extensible with the config approach. but the coupling doesnt neccessary go away either. you're just rewriting that stuff into settings.py instead of _scripts22:52
sqchenOk, I think the only thing I need is to figure out where to add those JS file names. if the config/setting file does not exist, how to create one.22:52
david-lylenot in settings22:52
david-lyleit's a per panel config22:53
sqchenI think the benefit is that we don’t need to re-write the same list for Jasmin.22:53
david-lyleif we don't want to make each panel pluggable (which I actually do), we just need to add it in the panel.py file22:54
david-lyleand alter horizon/base.py22:54
tqtranno, i like the panel pluggable thing22:54
sqchenAnother benefit is, Horizon is nore customizable.22:54
tqtranim just playing devil's advocate22:55
sqchen more customizable22:55
david-lyleI think for the builtin panels, for now we just put the enabled file in openstack_dashboard/enabled22:55
openstackgerritRob Cresswell proposed openstack/horizon: Fixes inline edit icon size/placement  https://review.openstack.org/14519722:56
sqchentqthai: sorry, I just type slow. I am answer david-lyle22:56
robcresswelldavid-lyle: ^^ That patch is for the pencil icon overlay and skewed buttons in inline_edit you bug reported in December, I think22:58
tqtranPiet: are you still around? got a few UX questions for you22:58
PietDang, I was just headed out the door to get a growler of beer22:59
tqtranPiet: you can get your beer, i will wait22:59
PietWe can chat22:59
tqtranPiet: can we google hangout?23:00
PietWhat's up?23:00
Pietsure23:00
tqtransecret meeting23:00
tqtraninvite only23:00
PietDon't invite David Lyle!23:00
tqtranwhats your gmail?23:00
Pietpkruithofjr23:01
*** robcresswell is now known as robcresswell_afk23:02
tqtraninviting23:02
Piethttps://plus.google.com/hangouts/_/event/c8j8km27k3retmn7jgplp94g61c23:02
Pietjust click on that link23:02
tqtranok im on23:03
tqtranbut i see no one23:03
david-lylemost private when just you23:08
*** fischerw has joined #openstack-horizon23:11
tqtranlol yes indeed23:11
*** fischerw has quit IRC23:17
*** nlahouti has quit IRC23:28
*** ZZelle has quit IRC23:34
openstackgerritRandy Bertram proposed openstack/horizon: WIP Magic Search in Angular User  https://review.openstack.org/15138623:38
*** Drago has quit IRC23:44
*** nlahouti has joined #openstack-horizon23:53
*** nlahouti has quit IRC23:54
*** stevemar has quit IRC23:56
tqtrananyknow how to to enable SSL? the USE_SSL is not in our local_settings.py.example anymore, is it under a different field now?23:56
*** nlahouti has joined #openstack-horizon23:56
*** sqchen has quit IRC23:57
*** sqchen has joined #openstack-horizon23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!