| *** fischerw has quit IRC | 00:02 | |
| *** ericpeterson has quit IRC | 00:02 | |
| *** nlahouti has quit IRC | 00:06 | |
| *** smc7 has joined #openstack-horizon | 00:09 | |
| *** MaxV has joined #openstack-horizon | 00:14 | |
| *** nlahouti has joined #openstack-horizon | 00:16 | |
| *** yingjun has joined #openstack-horizon | 00:27 | |
| *** peristeri has quit IRC | 00:27 | |
| *** gokrokve has quit IRC | 00:32 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Updated from global requirements https://review.openstack.org/149966 | 00:33 |
|---|---|---|
| *** fifieldt has joined #openstack-horizon | 00:39 | |
| *** yingjun has quit IRC | 00:39 | |
| *** smc7 has quit IRC | 00:41 | |
| *** masco has joined #openstack-horizon | 00:41 | |
| *** htruta has quit IRC | 00:41 | |
| *** mriedem has joined #openstack-horizon | 00:42 | |
| mriedem | looks like this is fixed, does anyone know what bug the fix was tracked under? http://logs.openstack.org/00/140000/3/gate/gate-horizon-python27/5fe0994/console.html#_2015-01-26_07_54_57_633 | 00:42 |
| mriedem | and if it was fixed in horizon or novaclient? | 00:42 |
| *** htruta has joined #openstack-horizon | 00:43 | |
| mriedem | http://goo.gl/i0aFOP | 00:43 |
| mriedem | lots of other failures too, man, something blew up hard | 00:46 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Updated from global requirements https://review.openstack.org/149966 | 00:47 |
| mriedem | ^ for https://github.com/openstack/requirements/commit/3758b311e9366103cc2d0fcff4eb05b087234b5d | 00:48 |
| mriedem | looks like that might be it | 00:48 |
| lhcheng | 1.1.8 was tagged a weeks ago, but something went and didn't got release until recently. | 00:50 |
| lhcheng | this was the fix https://review.openstack.org/#/c/149800/ | 00:51 |
| openstackgerrit | Wu Wenxiang proposed openstack/horizon: Incorrect error message when VM deletion failed https://review.openstack.org/149881 | 00:53 |
| *** harlowja has quit IRC | 00:54 | |
| *** stevemar has joined #openstack-horizon | 00:54 | |
| mriedem | lhcheng: yeah, see that, and django-openstack-auth 1.1.9 was released today | 00:54 |
| mriedem | and that's why the failures in logstash drop off today | 00:54 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/tuskar-ui: Updated from global requirements https://review.openstack.org/150196 | 00:55 |
| *** smc7 has joined #openstack-horizon | 00:56 | |
| *** gokrokve has joined #openstack-horizon | 00:56 | |
| *** gokrokve has quit IRC | 01:01 | |
| *** MaxV has quit IRC | 01:03 | |
| *** mriedem has left #openstack-horizon | 01:04 | |
| *** masco has quit IRC | 01:07 | |
| *** Sukhdev has quit IRC | 01:08 | |
| *** gyee has quit IRC | 01:15 | |
| *** gokrokve has joined #openstack-horizon | 01:16 | |
| *** Drago has quit IRC | 01:16 | |
| *** smc7 has quit IRC | 01:16 | |
| *** alexpilotti has joined #openstack-horizon | 01:18 | |
| *** sbfox1 has quit IRC | 01:23 | |
| *** yingjun has joined #openstack-horizon | 01:25 | |
| *** htruta has quit IRC | 01:33 | |
| *** harlowja has joined #openstack-horizon | 01:35 | |
| *** yingjun has quit IRC | 01:35 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: angular-based help-panel widget https://review.openstack.org/148031 | 01:37 |
| *** htruta has joined #openstack-horizon | 01:39 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: angular-based help-panel widget https://review.openstack.org/148031 | 01:43 |
| *** Guest12308 has quit IRC | 01:50 | |
| *** salty has joined #openstack-horizon | 01:51 | |
| *** salty is now known as Guest36108 | 01:51 | |
| *** gokrokve has quit IRC | 01:51 | |
| *** Guest36108 has quit IRC | 01:56 | |
| *** rwsu is now known as rwsu-afk | 02:05 | |
| *** smc7 has joined #openstack-horizon | 02:07 | |
| *** tqtran has quit IRC | 02:11 | |
| *** nlahouti has quit IRC | 02:16 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Updated from global requirements https://review.openstack.org/149966 | 02:17 |
| *** smc7 has quit IRC | 02:21 | |
| *** alexpilotti has quit IRC | 02:22 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/tuskar-ui: Updated from global requirements https://review.openstack.org/150196 | 02:25 |
| *** Putns has quit IRC | 02:29 | |
| *** dboik has quit IRC | 02:38 | |
| *** gokrokve has joined #openstack-horizon | 02:40 | |
| *** dboik has joined #openstack-horizon | 02:58 | |
| *** vivekd has joined #openstack-horizon | 02:58 | |
| *** venky has joined #openstack-horizon | 03:05 | |
| *** TravT has joined #openstack-horizon | 03:09 | |
| *** vivekd has quit IRC | 03:13 | |
| *** yingjun has joined #openstack-horizon | 03:16 | |
| *** venky has quit IRC | 03:19 | |
| *** ybathia has quit IRC | 03:19 | |
| *** dsneddon has quit IRC | 03:21 | |
| *** lhcheng has quit IRC | 03:22 | |
| *** dsneddon has joined #openstack-horizon | 03:22 | |
| *** venky has joined #openstack-horizon | 03:29 | |
| *** vivekd has joined #openstack-horizon | 03:29 | |
| *** TravT has quit IRC | 03:35 | |
| *** rushiagr_away is now known as rushiagr | 03:36 | |
| *** dsneddon has quit IRC | 03:42 | |
| *** dsneddon has joined #openstack-horizon | 03:43 | |
| *** ayoung is now known as ayoung_ZZzz__ | 03:49 | |
| *** tzumainn has quit IRC | 03:53 | |
| *** yingjun has quit IRC | 04:00 | |
| *** rushiagr is now known as rushiagr_away | 04:01 | |
| *** gokrokve has quit IRC | 04:03 | |
| *** smc7 has joined #openstack-horizon | 04:10 | |
| *** vivekd has quit IRC | 04:10 | |
| *** smc7 has quit IRC | 04:15 | |
| *** gokrokve has joined #openstack-horizon | 04:20 | |
| *** dsneddon has quit IRC | 04:24 | |
| *** dsneddon has joined #openstack-horizon | 04:26 | |
| *** vivekd has joined #openstack-horizon | 04:33 | |
| *** lhcheng has joined #openstack-horizon | 04:39 | |
| *** packet has quit IRC | 04:39 | |
| *** amotoki has joined #openstack-horizon | 04:40 | |
| *** dsneddon has quit IRC | 04:45 | |
| *** dsneddon has joined #openstack-horizon | 04:47 | |
| *** alexpilotti has joined #openstack-horizon | 04:48 | |
| *** rushiagr_away is now known as rushiagr | 04:54 | |
| *** sbfox has joined #openstack-horizon | 05:06 | |
| *** harlowja is now known as harlowja_away | 05:10 | |
| openstackgerrit | ziyu032 proposed openstack/horizon: update my mailmap https://review.openstack.org/150261 | 05:13 |
| openstackgerrit | Merged openstack/horizon: Updated from global requirements https://review.openstack.org/149966 | 05:16 |
| *** dsneddon has quit IRC | 05:27 | |
| *** dsneddon has joined #openstack-horizon | 05:29 | |
| *** masco has joined #openstack-horizon | 05:33 | |
| *** yingjun has joined #openstack-horizon | 05:43 | |
| openstackgerrit | Merged openstack/horizon: Make table BatchAction help text configurable https://review.openstack.org/133241 | 05:46 |
| *** nikunj2512 has joined #openstack-horizon | 05:47 | |
| nikunj2512 | amotoki: Hi, please take a look at these patches -> https://review.openstack.org/#/c/148946/ & https://review.openstack.org/#/c/142670/ I have updated them and gave my comments | 05:48 |
| *** dsneddon has quit IRC | 05:48 | |
| *** dsneddon has joined #openstack-horizon | 05:49 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/django_openstack_auth: Imported Translations from Transifex https://review.openstack.org/150274 | 06:02 |
| *** gokrokve_ has joined #openstack-horizon | 06:05 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/150275 | 06:07 |
| *** gokrokve has quit IRC | 06:08 | |
| *** Miouge has joined #openstack-horizon | 06:09 | |
| *** dsneddon has quit IRC | 06:09 | |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Throw a warning message when failed to get pool detail https://review.openstack.org/147790 | 06:09 |
| *** gokrokve_ has quit IRC | 06:10 | |
| *** dsneddon has joined #openstack-horizon | 06:10 | |
| *** dboik has quit IRC | 06:23 | |
| *** mpavlase has joined #openstack-horizon | 06:25 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: added detail page for keypair https://review.openstack.org/148864 | 06:26 |
| *** dsneddon has quit IRC | 06:30 | |
| *** dsneddon has joined #openstack-horizon | 06:32 | |
| *** gokrokve has joined #openstack-horizon | 06:37 | |
| *** venky has quit IRC | 06:38 | |
| *** gokrokve has quit IRC | 06:39 | |
| *** gokrokve has joined #openstack-horizon | 06:39 | |
| *** gokrokve has quit IRC | 06:44 | |
| *** mrunge has joined #openstack-horizon | 06:44 | |
| *** dsneddon has quit IRC | 06:52 | |
| *** dsneddon has joined #openstack-horizon | 06:53 | |
| *** ishant has joined #openstack-horizon | 06:58 | |
| *** nlahouti has joined #openstack-horizon | 07:01 | |
| *** nlahouti has quit IRC | 07:05 | |
| *** nlahouti has joined #openstack-horizon | 07:05 | |
| *** Miouge has quit IRC | 07:12 | |
| *** dsneddon has quit IRC | 07:13 | |
| *** dsneddon has joined #openstack-horizon | 07:13 | |
| *** mpavlase has quit IRC | 07:15 | |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Throw a warning message when failed to get pool detail https://review.openstack.org/147790 | 07:20 |
| *** nyechiel has joined #openstack-horizon | 07:21 | |
| *** sayan has joined #openstack-horizon | 07:25 | |
| openstackgerrit | Merged openstack/horizon: Do not show progress bar for shelved instance https://review.openstack.org/144583 | 07:27 |
| *** jamielennox is now known as jamielennox|away | 07:29 | |
| *** dkorn has joined #openstack-horizon | 07:31 | |
| *** dsneddon has quit IRC | 07:33 | |
| *** TravT has joined #openstack-horizon | 07:34 | |
| *** dsneddon has joined #openstack-horizon | 07:34 | |
| *** stevemar has quit IRC | 07:35 | |
| *** Miouge has joined #openstack-horizon | 07:35 | |
| *** sayan has quit IRC | 07:36 | |
| openstackgerrit | Tatiana Ovchinnikova proposed openstack/horizon: Heat stack status column improvement https://review.openstack.org/150297 | 07:36 |
| *** gokrokve has joined #openstack-horizon | 07:37 | |
| *** dkorn has quit IRC | 07:39 | |
| *** nyechiel has quit IRC | 07:40 | |
| *** gokrokve has quit IRC | 07:42 | |
| *** smc7 has joined #openstack-horizon | 07:48 | |
| *** rdopiera has joined #openstack-horizon | 07:48 | |
| *** rdopiera has quit IRC | 07:49 | |
| *** nlahouti has quit IRC | 07:49 | |
| *** romainh has joined #openstack-horizon | 07:49 | |
| *** rdopiera has joined #openstack-horizon | 07:50 | |
| *** sayan has joined #openstack-horizon | 07:50 | |
| *** romainh has left #openstack-horizon | 07:51 | |
| *** jprovazn has joined #openstack-horizon | 07:51 | |
| *** smc7 has quit IRC | 07:52 | |
| *** dsneddon has quit IRC | 07:54 | |
| *** e0ne has joined #openstack-horizon | 07:55 | |
| *** dsneddon has joined #openstack-horizon | 07:55 | |
| *** MaxV has joined #openstack-horizon | 08:02 | |
| openstackgerrit | Merged openstack/horizon: Disable the IPv6 components in Subnet form https://review.openstack.org/148946 | 08:04 |
| *** MaxV has quit IRC | 08:06 | |
| *** mpavlase has joined #openstack-horizon | 08:07 | |
| *** MaxV has joined #openstack-horizon | 08:08 | |
| *** harlowja_away has quit IRC | 08:08 | |
| *** MaxV has quit IRC | 08:10 | |
| *** dsneddon has quit IRC | 08:15 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: /!\ WIP /!\ Support for Glance v2 https://review.openstack.org/150084 | 08:17 |
| *** dsneddon has joined #openstack-horizon | 08:17 | |
| *** josecastroleon__ has quit IRC | 08:19 | |
| *** josecastroleon__ has joined #openstack-horizon | 08:19 | |
| *** josecastroleon__ is now known as josecastroleo | 08:20 | |
| *** josecastroleo is now known as josecastroleon | 08:21 | |
| *** yingjun has quit IRC | 08:21 | |
| *** sbfox has quit IRC | 08:23 | |
| *** sayan has quit IRC | 08:25 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/150275 | 08:26 |
| *** Ajinkya_P has joined #openstack-horizon | 08:26 | |
| *** yingjun has joined #openstack-horizon | 08:27 | |
| *** markus_z has joined #openstack-horizon | 08:29 | |
| *** alexpilotti has quit IRC | 08:33 | |
| Ajinkya_P | hello | 08:36 |
| *** dsneddon has quit IRC | 08:36 | |
| Ajinkya_P | Is this usually so quiet ? | 08:36 |
| Ajinkya_P | Or am i doing something wrong? | 08:36 |
| *** gokrokve has joined #openstack-horizon | 08:37 | |
| *** dsneddon has joined #openstack-horizon | 08:38 | |
| Ajinkya_P | I have a question: Is there a way for members that are added to a project to only see the instances that they create? because currently any user added to a project has unrestricted access to mess around with the instances that other user has created | 08:38 |
| Ajinkya_P | any help is very much appreciated | 08:38 |
| *** MaxV has joined #openstack-horizon | 08:40 | |
| mrunge | Ajinkya_P, the answer to your question is: yes. (usually that quiet at this time or you're doing something wrong) | 08:41 |
| mrunge | Ajinkya_P, I would create a project for each user | 08:41 |
| *** gokrokve has quit IRC | 08:42 | |
| mrunge | Ajinkya_P, or please consult /etc/openstack-dashboard/nova_policy.json to restrict access to instances | 08:42 |
| mrunge | not sure, if that works, though | 08:42 |
| mrunge | (depending on how nova stores "owner" of instances) | 08:42 |
| nikunj2512 | mrunge: H, its about this bug -> https://bugs.launchpad.net/horizon/+bug/1396562 | 08:42 |
| nikunj2512 | mrunge: *Hi. You told yesterday ask you tomorrow morning | 08:43 |
| nikunj2512 | mrunge: Do you have few minutes? | 08:43 |
| mrunge | nikunj2512, oh yes, I remember | 08:43 |
| *** lhcheng has quit IRC | 08:43 | |
| mrunge | nikunj2512, yes | 08:43 |
| nikunj2512 | mrunge: In that bug you told to move Access & Security somewhere else.. What do you mean by that? | 08:44 |
| nikunj2512 | mrunge: Do you mean whole panel of this tab or some tabs of this panel like Floating IPs and other? | 08:44 |
| *** sayan has joined #openstack-horizon | 08:44 | |
| mrunge | I would ask UX folks about that | 08:45 |
| mrunge | e.g floating ip could be considered to belong to network and to belong to running instances as well | 08:45 |
| mrunge | (depending on your POV) | 08:45 |
| nikunj2512 | mrunge: Ok.. Currently i have a patch where i moved the floating IPs tab under network group as a panel | 08:45 |
| nikunj2512 | mrunge: Yes.. | 08:46 |
| mrunge | nikunj2512, fine. would you care to ask UX folks, please? | 08:46 |
| Ajinkya_P | mrunge: Thanks for your response. But since I am doing a project where I have to manage students for a class, creating a project for around 100 students would be troublesome. Can the instance be restricted based on ownership? | 08:46 |
| mrunge | nikunj2512, or make a link from both, instances and from networks? | 08:46 |
| nikunj2512 | mrunge: Where to ask them? Is they have some separate channel? | 08:46 |
| mrunge | Ajinkya_P, as I said earlier, look at nova policy files | 08:46 |
| mrunge | Ajinkya_P, I wouldn't create projects by hand (the same as for users) | 08:47 |
| nikunj2512 | mrunge: make a link from both?? i didn't get what you mean | 08:47 |
| mrunge | nikunj2512, make floating IP accessible from networks panel and from systems panel | 08:47 |
| mrunge | nikunj2512, and no, UX folks don't have their own channel, they usually avoid irc | 08:48 |
| nikunj2512 | mrunge: Ok... but which systems panel?? | 08:48 |
| Ajinkya_P | mrunge: ok thanks, I'll have a look again. | 08:48 |
| nikunj2512 | mrunge: Then how to contact them? | 08:48 |
| mrunge | nikunj2512, but you have UX folks within HP | 08:48 |
| mrunge | I have no idea, how HP is organized | 08:48 |
| nikunj2512 | mrunge: Yes | 08:48 |
| *** jcoufal has joined #openstack-horizon | 08:48 | |
| nikunj2512 | gone2far | 08:49 |
| nikunj2512 | Sorry it is my password.. :p | 08:49 |
| mrunge | sure | 08:49 |
| nikunj2512 | typed in wrong screen | 08:49 |
| nikunj2512 | mrunge: i meant ux of openstack | 08:49 |
| mrunge | nikunj2512, me too. | 08:49 |
| nikunj2512 | mrunge: Ok... | 08:50 |
| nikunj2512 | mrunge: but what you mean by systems panel? | 08:50 |
| nikunj2512 | mrunge: i don't think there is a panel named systems? | 08:50 |
| mrunge | nikunj2512, there are a few UX folks looking at UX related bugs, and we had a lot of UX folks talking past sessions on openstack summits | 08:50 |
| nikunj2512 | mrunge: Ok | 08:50 |
| mrunge | nikunj2512, I meant /projects | 08:50 |
| nikunj2512 | mrunge: i already made FIPs as a separate panel under->projects->network | 08:51 |
| openstackgerrit | Nikunj Aggarwal proposed openstack/horizon: Adds support to accept IPv6 in VIP Address for LB Pool https://review.openstack.org/142670 | 08:52 |
| *** regebro has quit IRC | 08:52 | |
| *** regebro has joined #openstack-horizon | 08:53 | |
| *** TravT has quit IRC | 08:54 | |
| nikunj2512 | mrunge: See this is patch for FIP -> https://review.openstack.org/#/c/150016/ | 08:55 |
| nikunj2512 | mrunge: Can you just a look at this patch, please.. some tests are failing and i am not able firure out the reason.. Please just one quick look :) | 08:56 |
| mrunge | nikunj2512, not sure, if that is the right way to go | 08:56 |
| *** zz_ttrifonow is now known as ttrifonov | 08:56 | |
| nikunj2512 | mrunge: I asked this from amotoki before submitting the patch because he is Networking expert | 08:57 |
| mrunge | nikunj2512, first guess is, tests were failing because of openstack_auth, which was fixed yesterday | 08:57 |
| *** jpich has joined #openstack-horizon | 08:57 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 08:57 | |
| mrunge | nikunj2512, sorry, you asked what? | 08:57 |
| nikunj2512 | mrunge: I asked amotoki on about where to move the floating ips in the networks. he told to create a separate panel under networks | 08:58 |
| *** sayan has quit IRC | 08:58 | |
| amotoki | nikunj2512: mrunge: i am not sure where is the best place. Input from UX perspective is also important. | 08:59 |
| nikunj2512 | mrunge: Yes.. i fixed the openstack_auth test... but these are failing for some other reason | 08:59 |
| mrunge | nikunj2512, you fixed django_openstack_auth? I thought, it was Lin-Hua Cheng, who did that | 08:59 |
| mrunge | nikunj2512, and please bear in mind, not every installation has floating ips enabled | 09:00 |
| nikunj2512 | mrunge: Sorry, i will rephrase my last message.. i pulled the openstack_auth change which Lin-Hua Cheng fixed | 09:01 |
| nikunj2512 | mrunge: Ohhh... Ok | 09:01 |
| mrunge | nikunj2512, you pulled in the changes to your local system, you meant? | 09:02 |
| nikunj2512 | mrunge: basically i updated the master which pulled the openstack_auth changes and then made a branch from master | 09:02 |
| nikunj2512 | mrunge: So, these test failure are not due to openstack_auth | 09:02 |
| nikunj2512 | mrunge: i am getting this message -> UnicodeEncodeError: 'ascii' codec can't encode characters in position 9-11: ordinal not in range(128) | 09:03 |
| jpich | Also floating IPs can be used with nova network (there is no network panel then) | 09:03 |
| mrunge | well, that has to be proven. but test failures are not due to the state of master branch | 09:03 |
| mrunge | nikunj2512, jpich is correct here. | 09:03 |
| nikunj2512 | mrunge: Yes, i know about nova-network.. Then please suggest me where is a good place to put the Floating IPs? | 09:04 |
| nikunj2512 | jpich: amotoki also mentioned the same thing yesterday... | 09:05 |
| jpich | Good | 09:05 |
| mrunge | nikunj2512, I'm going to repeat myself: ask UX folks, please | 09:05 |
| nikunj2512 | jpich, amotoki, mrunge: i will ask the UX people but from your experience where we should put this FIP? | 09:06 |
| mrunge | in doubt, take it to the list | 09:06 |
| *** ygbo has joined #openstack-horizon | 09:06 | |
| nikunj2512 | mrunge: Ok.. i will ask this question on the mailing list | 09:06 |
| mrunge | nikunj2512, it absolutely makes sense to have it on TWO places | 09:06 |
| nikunj2512 | mrunge: Ok.. one place is with networks and where should be the other place? | 09:07 |
| mrunge | where it is now, because experienced users will look there at first place | 09:07 |
| nikunj2512 | mrunge: Now it is in Access & Security | 09:07 |
| nikunj2512 | mrunge: as a tab | 09:07 |
| mrunge | yes | 09:08 |
| nikunj2512 | mrunge: So, you mean we should keep it under the Access & Security also? | 09:08 |
| mrunge | for now? | 09:09 |
| mrunge | nikunj2512, are you asking me to do the work on that bug= | 09:10 |
| mrunge | ? | 09:10 |
| nikunj2512 | mrunge: Ok.. I will today only will send a email to mailing list about this issue and for now i will put it under two places -> Access & Security and under networks | 09:11 |
| nikunj2512 | mrunge: No.. Oh God no | 09:11 |
| nikunj2512 | mrunge: Just asking for your expert opinions :) | 09:11 |
| nikunj2512 | mrunge: Is that acceptable | 09:11 |
| nikunj2512 | ? | 09:11 |
| mrunge | well, you now keep asking the same questions over and over again, for the past 20 minutes | 09:11 |
| nikunj2512 | mrunge: Sorry :( | 09:12 |
| *** e0ne has quit IRC | 09:13 | |
| *** sayan has joined #openstack-horizon | 09:16 | |
| *** athomas has joined #openstack-horizon | 09:21 | |
| *** vivekd has left #openstack-horizon | 09:29 | |
| *** yingjun has quit IRC | 09:32 | |
| *** gokrokve has joined #openstack-horizon | 09:37 | |
| *** dsneddon has quit IRC | 09:38 | |
| *** gokrokve_ has joined #openstack-horizon | 09:39 | |
| *** Ala has joined #openstack-horizon | 09:39 | |
| *** dsneddon has joined #openstack-horizon | 09:40 | |
| *** gokrokve has quit IRC | 09:41 | |
| *** gokrokve_ has quit IRC | 09:44 | |
| *** obutenko has joined #openstack-horizon | 09:44 | |
| *** ZZelle has quit IRC | 09:50 | |
| *** akrivoka has joined #openstack-horizon | 10:04 | |
| *** JeanBriceCombebi has quit IRC | 10:20 | |
| *** dsneddon has quit IRC | 10:20 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 10:21 | |
| *** dsneddon has joined #openstack-horizon | 10:22 | |
| *** TravT has joined #openstack-horizon | 10:32 | |
| *** Ajinkya_P has quit IRC | 10:35 | |
| *** TravT has quit IRC | 10:37 | |
| *** gokrokve has joined #openstack-horizon | 10:37 | |
| *** yingjun has joined #openstack-horizon | 10:40 | |
| *** dsneddon has quit IRC | 10:41 | |
| *** dsneddon has joined #openstack-horizon | 10:42 | |
| *** gokrokve has quit IRC | 10:42 | |
| *** masco has quit IRC | 10:43 | |
| *** JeanBriceCombebi has quit IRC | 10:46 | |
| *** e0ne has joined #openstack-horizon | 10:47 | |
| *** jtomasek has joined #openstack-horizon | 10:48 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 10:50 | |
| *** JeanBriceCombebi has quit IRC | 10:51 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 10:52 | |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Throw a warning message when failed to get pool detail https://review.openstack.org/147790 | 10:55 |
| *** masco has joined #openstack-horizon | 10:57 | |
| *** dsneddon has quit IRC | 11:02 | |
| *** dsneddon has joined #openstack-horizon | 11:02 | |
| *** yingjun has quit IRC | 11:03 | |
| *** yingjun has joined #openstack-horizon | 11:04 | |
| *** e0ne is now known as e0ne_ | 11:08 | |
| openstackgerrit | Tomáš Nová?ik proposed openstack/horizon: Add general function for generating random names https://review.openstack.org/144206 | 11:08 |
| *** e0ne_ is now known as e0ne | 11:09 | |
| *** tosky has joined #openstack-horizon | 11:11 | |
| openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Use handle_errors decorator to handle image_get https://review.openstack.org/150367 | 11:17 |
| openstackgerrit | Merged openstack/django_openstack_auth: Imported Translations from Transifex https://review.openstack.org/150274 | 11:18 |
| *** akrivoka has quit IRC | 11:18 | |
| *** akrivoka has joined #openstack-horizon | 11:19 | |
| *** dsneddon has quit IRC | 11:22 | |
| *** dsneddon has joined #openstack-horizon | 11:24 | |
| *** smc7 has joined #openstack-horizon | 11:25 | |
| *** smc7 has quit IRC | 11:30 | |
| openstackgerrit | Sam Betts proposed openstack/horizon: Reduced code duplication in creating page headers https://review.openstack.org/142802 | 11:37 |
| *** gokrokve has joined #openstack-horizon | 11:37 | |
| openstackgerrit | Sam Betts proposed openstack/horizon: Add page_title mixin to all templates https://review.openstack.org/149960 | 11:39 |
| *** masco has quit IRC | 11:41 | |
| openstackgerrit | Tomáš Nová?ik proposed openstack/horizon: Add general function for generating random names https://review.openstack.org/144206 | 11:42 |
| *** JeanBriceCombebi has quit IRC | 11:42 | |
| *** gokrokve has quit IRC | 11:43 | |
| *** dsneddon has quit IRC | 11:44 | |
| *** dsneddon has joined #openstack-horizon | 11:44 | |
| *** dkorn has joined #openstack-horizon | 11:47 | |
| *** robcresswell has joined #openstack-horizon | 11:49 | |
| *** masco has joined #openstack-horizon | 11:53 | |
| *** masco has quit IRC | 11:58 | |
| *** e0ne is now known as e0ne_ | 12:10 | |
| *** e0ne_ is now known as e0ne | 12:13 | |
| *** ishant has quit IRC | 12:13 | |
| *** TravT has joined #openstack-horizon | 12:21 | |
| *** dsneddon has quit IRC | 12:25 | |
| *** TravT has quit IRC | 12:26 | |
| *** dsneddon has joined #openstack-horizon | 12:27 | |
| *** amotoki has quit IRC | 12:30 | |
| *** amotoki has joined #openstack-horizon | 12:31 | |
| *** e0ne is now known as e0ne_ | 12:31 | |
| openstackgerrit | Yves-Gwenael Bourhis proposed openstack/horizon: Memoizing with subset of request only https://review.openstack.org/150392 | 12:34 |
| *** e0ne_ is now known as e0ne | 12:34 | |
| *** amotoki has quit IRC | 12:35 | |
| *** amotoki has joined #openstack-horizon | 12:37 | |
| *** gokrokve has joined #openstack-horizon | 12:37 | |
| *** Miouge has quit IRC | 12:39 | |
| *** gokrokve has quit IRC | 12:42 | |
| *** dsneddon has quit IRC | 12:47 | |
| *** dsneddon has joined #openstack-horizon | 12:47 | |
| *** aix has joined #openstack-horizon | 12:48 | |
| *** robcresswell has quit IRC | 12:49 | |
| ygbo | Hi rdopiera, I discoverd an issue in https://review.openstack.org/#/c/150392/. If I pass only the user object... this object never changes even after logout/login, and therefore what is memoized is the same for every user... when a user logs in, the attributes of the user object are changed, not the object which stays the same instance... | 12:59 |
| *** tosky has quit IRC | 12:59 | |
| *** nyechiel has joined #openstack-horizon | 13:00 | |
| *** tosky has joined #openstack-horizon | 13:04 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:05 | |
| rdopiera | ygbo: you shouldn't be using 'is' for comparing objects in the cache | 13:05 |
| rdopiera | ygbo: use '==' | 13:05 |
| *** doug-fish has joined #openstack-horizon | 13:05 | |
| rdopiera | ygbo: then define the proper __eq__ method on the user object, and it will work | 13:05 |
| ygbo | rdopiera: that's what I was about to say, we need a __eq__ on the user object :-) | 13:06 |
| ygbo | rdopiera: curently all user instances are equal... | 13:06 |
| *** dsneddon has quit IRC | 13:07 | |
| rdopiera | ygbo: __eq__ won't help you much if you are using 'is' | 13:07 |
| ygbo | rdopiera: I know :-) | 13:08 |
| rdopiera | also, I foresee a lot more such problems with this approach | 13:08 |
| rdopiera | it's basically very fragile | 13:08 |
| ygbo | rdopiera: I was using 'is' in this patch set because equal was never changing. | 13:08 |
| rdopiera | too much magic | 13:08 |
| *** dsneddon has joined #openstack-horizon | 13:08 | |
| ygbo | rdopiera: in my opinion, I should rewrite list_extensions and only pass the user object. the only place calling this method is extension_supported (which is also memoized). | 13:10 |
| *** JeanBriceCombebi has quit IRC | 13:10 | |
| ygbo | rdopiera: this patch was only a draft wher I discoverd hidden issues in the background :-) | 13:12 |
| *** jprovazn has quit IRC | 13:14 | |
| rdopiera | ygbo: caching is only one of the reasons why semi-global mega-objects like 'request' are generally a bad idea :) | 13:15 |
| rdopiera | testing is another | 13:15 |
| *** tzumainn has joined #openstack-horizon | 13:16 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:18 | |
| openstackgerrit | Tatiana Ovchinnikova proposed openstack/horizon: Stack resources table improvement https://review.openstack.org/150411 | 13:22 |
| *** Longgeek has joined #openstack-horizon | 13:26 | |
| *** alexpilotti has joined #openstack-horizon | 13:33 | |
| *** rushiagr is now known as rushiagr_away | 13:35 | |
| mpavlase | Hi, I have general question about reviews: I spotted one pretty important patch (https://review.openstack.org/#/c/119501/), that author don't care about it for more than one month and it blocks upcoming future patches (so at this moment still don't exists because of that). What do you think, is it correct if I'd like to implement the same blueprint instead of original author? | 13:36 |
| *** gokrokve has joined #openstack-horizon | 13:37 | |
| *** dkorn has quit IRC | 13:38 | |
| akrivoka | mpavlase: thanks for looking to move things forward! generally speaking, it's a good idea to contact the original author and sync up with them, to avoid duplicating effort. if they don't reply within a few days, I would say go ahead and take the patch over. | 13:41 |
| *** gokrokve has quit IRC | 13:42 | |
| *** gokrokve has joined #openstack-horizon | 13:47 | |
| mpavlase | akrivoka: Thanks for reply, I thought about the same way... | 13:49 |
| *** dsneddon has quit IRC | 13:49 | |
| *** dsneddon has joined #openstack-horizon | 13:50 | |
| *** dboik_ has joined #openstack-horizon | 13:51 | |
| *** gokrokve has quit IRC | 13:51 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/tuskar-ui: Tests for utils.metering https://review.openstack.org/150422 | 13:52 |
| *** jprovazn has joined #openstack-horizon | 13:53 | |
| *** JeanBriceCombebi has quit IRC | 13:53 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:55 | |
| *** Sukhdev has joined #openstack-horizon | 13:55 | |
| *** nyechiel has quit IRC | 13:57 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/tuskar-ui: Tests for utils.metering https://review.openstack.org/150422 | 13:57 |
| *** nyechiel has joined #openstack-horizon | 13:57 | |
| *** rushiagr_away is now known as rushiagr | 13:58 | |
| *** radez_g0n3 is now known as radez | 13:59 | |
| *** lblanchard has joined #openstack-horizon | 13:59 | |
| *** _crobertsrh is now known as crobertsrh | 14:01 | |
| *** neelashah has joined #openstack-horizon | 14:04 | |
| sambetts | doug-fish: Hey | 14:06 |
| doug-fish | hi sambetts | 14:06 |
| sambetts | doug-fish: I'm really not sure what that comment in the template means, and I've looked up the files history and can't find anything that refers to searchable stuff | 14:07 |
| doug-fish | sambetts: no worries - I just pointed it out to draw attention in case somebody really knows what it means | 14:08 |
| doug-fish | it implies to me there might be some secret function we could be taking advantage of ... | 14:08 |
| doug-fish | an easter egg in Horizon! | 14:08 |
| sambetts | haha | 14:08 |
| sambetts | that would great!, the only person thats ever worked on that file is david-lyle so could be :-P | 14:09 |
| doug-fish | we've discovered david-lyle_afk's secret code! | 14:09 |
| *** dsneddon has quit IRC | 14:10 | |
| openstackgerrit | Merged openstack/tuskar-ui: Updated from global requirements https://review.openstack.org/150196 | 14:11 |
| *** dsneddon has joined #openstack-horizon | 14:12 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/tuskar-ui: Tests for utils.metering https://review.openstack.org/150422 | 14:12 |
| *** mattfarina has joined #openstack-horizon | 14:13 | |
| openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Improve help text for flavor creation https://review.openstack.org/150428 | 14:18 |
| *** ttrifonov is now known as zz_ttrifonov | 14:19 | |
| *** JeanBriceCombebi has quit IRC | 14:19 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 14:20 | |
| openstackgerrit | Chad Roberts proposed openstack/horizon: Guided job execution page for Sahara https://review.openstack.org/147918 | 14:23 |
| *** Longgeek has quit IRC | 14:23 | |
| *** peristeri has joined #openstack-horizon | 14:25 | |
| *** sayan has quit IRC | 14:29 | |
| openstackgerrit | Ana Krivokapic proposed openstack/horizon: Refactor metering utility and view functions https://review.openstack.org/149665 | 14:30 |
| *** masco has joined #openstack-horizon | 14:31 | |
| *** Ctina has joined #openstack-horizon | 14:34 | |
| *** yingjun has quit IRC | 14:37 | |
| *** gokrokve has joined #openstack-horizon | 14:37 | |
| rbertram | nikunj2512: Still around? | 14:40 |
| *** Miouge has joined #openstack-horizon | 14:41 | |
| *** gokrokve has quit IRC | 14:42 | |
| *** cbader has joined #openstack-horizon | 14:43 | |
| openstackgerrit | Nikita Konovalov proposed openstack/horizon: [Data_processing] fix job_executions table https://review.openstack.org/125927 | 14:44 |
| *** gokrokve has joined #openstack-horizon | 14:48 | |
| *** david-lyle_afk is now known as david-lyle | 14:49 | |
| *** Miouge has quit IRC | 14:50 | |
| *** venky has joined #openstack-horizon | 14:50 | |
| *** gokrokve_ has joined #openstack-horizon | 14:51 | |
| *** dsneddon has quit IRC | 14:52 | |
| *** dsneddon has joined #openstack-horizon | 14:53 | |
| *** gokrokve has quit IRC | 14:53 | |
| *** jcoufal_ has joined #openstack-horizon | 14:55 | |
| *** jcoufal has quit IRC | 14:58 | |
| *** Ctina has quit IRC | 14:59 | |
| *** Ctina has joined #openstack-horizon | 14:59 | |
| *** smc7 has joined #openstack-horizon | 15:01 | |
| sambetts | doug-fish: I found a commit from 2012, which actually has that comment in a place that makes sense, apprently there used to be a searchable=true parameter | 15:03 |
| *** akrivoka has quit IRC | 15:03 | |
| *** rwsu-afk has quit IRC | 15:04 | |
| doug-fish | sambetts: kudos to you for being thorough! | 15:04 |
| doug-fish | I think you are telling me that it's related to code that no longer exists | 15:05 |
| *** akrivoka has joined #openstack-horizon | 15:05 | |
| *** tosky has quit IRC | 15:06 | |
| *** tosky has joined #openstack-horizon | 15:06 | |
| *** ayoung_ZZzz__ is now known as ayoung_snowedin | 15:07 | |
| sambetts | doug-fish: https://github.com/openstack/horizon/blob/50d17b207a44d064e43bc2b69ee6c7e3611fe337/openstack-dashboard/dashboard/templates/_page_header.html | 15:08 |
| *** Drago has joined #openstack-horizon | 15:08 | |
| sambetts | used to exist | 15:08 |
| sambetts | no longer does | 15:08 |
| sambetts | :-P | 15:08 |
| doug-fish | so removing it is perfect! | 15:08 |
| *** Drago has quit IRC | 15:09 | |
| *** Drago has joined #openstack-horizon | 15:09 | |
| sambetts | Seems like a good move :D | 15:09 |
| *** coolsvap is now known as coolsvap|afk | 15:10 | |
| jpich | david-lyle: Thank you for running whatever script that was and cleaning up the review queue! | 15:15 |
| jpich | (My inbox nearly exploded) | 15:15 |
| openstackgerrit | Sam Betts proposed openstack/horizon: Add page_title mixin to all templates https://review.openstack.org/149960 | 15:15 |
| david-lyle | jpich: oops | 15:16 |
| jpich | :D | 15:16 |
| jpich | It's an appreciate explosion | 15:16 |
| david-lyle | auto-abandon script | 15:16 |
| jpich | *appreciative | 15:16 |
| david-lyle | long overdue | 15:16 |
| david-lyle | still almost 300 open reviews | 15:17 |
| david-lyle | may edit scipt to do more cleansing | 15:17 |
| jpich | Did you check how many there were before running the script? | 15:18 |
| david-lyle | jpich: -1 review and over 4 weeks old? | 15:18 |
| david-lyle | jpich, nah I forgot | 15:18 |
| jpich | 5 billions at least | 15:19 |
| david-lyle | my guess is >50 <100 | 15:19 |
| jpich | oh | 15:19 |
| david-lyle | from the console | 15:19 |
| david-lyle | got abandoned | 15:19 |
| jpich | Not too bad. I think there were some really old ones in there | 15:20 |
| *** vijendar has joined #openstack-horizon | 15:20 | |
| david-lyle | what do you think about adding: -1 review and over 4 weeks old | 15:20 |
| *** tsufiev is now known as tsufiev_ | 15:20 | |
| david-lyle | the script prunes -2's over 4 weeks and failed jenkins over 4 weeks | 15:21 |
| *** jpomero has joined #openstack-horizon | 15:22 | |
| jpich | I'm not sure, maybe it's a bit too aggressive? Sometimes people reply to -1 comments but the reviewer never comes back to remove it... | 15:22 |
| jpich | though looking through what's left of reviews, the last 200 or so were updated in January | 15:23 |
| jpich | so it's mostly recent stuff | 15:23 |
| nikunj2512 | david-lyle: i have +2 in these two reviews-> https://review.openstack.org/#/c/131059/ & https://review.openstack.org/#/c/146078/ Please take alook at then when you get some time. Thank You | 15:23 |
| david-lyle | yeah, just in cleanup mode | 15:24 |
| david-lyle | I want to purge more, mwahaha | 15:24 |
| jpich | :D | 15:24 |
| gary-smith | it's like a drug :-) | 15:24 |
| gary-smith | the messages from gerrit seem to have subsided. is you script finished? | 15:25 |
| gary-smith | c/you/your/ | 15:25 |
| david-lyle | yeah | 15:25 |
| david-lyle | script took 1 minute to run | 15:25 |
| david-lyle | automation is good | 15:25 |
| *** TravT has joined #openstack-horizon | 15:25 | |
| gary-smith | can you write a script that cleans out my garage? | 15:26 |
| david-lyle | if I could just automate my regular reviews | 15:26 |
| david-lyle | we'd be in business | 15:26 |
| rdopiera | gary-smith: you only need a match for that ;) | 15:26 |
| gary-smith | :-) | 15:26 |
| *** TravT has quit IRC | 15:27 | |
| *** TravT has joined #openstack-horizon | 15:27 | |
| *** neelashah has quit IRC | 15:28 | |
| mattfarina | david-lyle i don't see an agenda for tomorrows meeting yet. you ok if i start one? | 15:32 |
| david-lyle | mattfarina: absolutely | 15:32 |
| david-lyle | start one | 15:32 |
| mattfarina | thanks | 15:33 |
| *** dsneddon has quit IRC | 15:33 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/tuskar-ui: Remove Inheritable*TestCase https://review.openstack.org/150454 | 15:33 |
| *** dsneddon has joined #openstack-horizon | 15:34 | |
| openstackgerrit | Chad Roberts proposed openstack/horizon: Improving data processing job binaries form https://review.openstack.org/150458 | 15:39 |
| *** e0ne is now known as e0ne_ | 15:41 | |
| *** obutenko has quit IRC | 15:41 | |
| *** rwsu has joined #openstack-horizon | 15:42 | |
| *** neelashah has joined #openstack-horizon | 15:42 | |
| *** Sukhdev has quit IRC | 15:42 | |
| *** JeanBriceCombebi has quit IRC | 15:43 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 15:45 | |
| *** stevemar has joined #openstack-horizon | 15:47 | |
| *** fischerw has joined #openstack-horizon | 15:48 | |
| *** e0ne_ has quit IRC | 15:51 | |
| *** dsneddon has quit IRC | 15:54 | |
| *** dsneddon has joined #openstack-horizon | 15:55 | |
| openstackgerrit | lawrancejing proposed openstack/horizon: Add project column for admin images tables https://review.openstack.org/147997 | 15:55 |
| *** sayan has joined #openstack-horizon | 15:57 | |
| openstackgerrit | David Lyle proposed openstack/horizon: Adding review clean up script https://review.openstack.org/150469 | 15:57 |
| *** akrivoka has quit IRC | 16:00 | |
| *** akrivoka has joined #openstack-horizon | 16:00 | |
| *** nikunj2512 has quit IRC | 16:03 | |
| *** packet has joined #openstack-horizon | 16:07 | |
| *** jpomero_ has joined #openstack-horizon | 16:10 | |
| *** lblanchard1 has joined #openstack-horizon | 16:11 | |
| *** dsneddon has quit IRC | 16:14 | |
| *** sambetts_ has joined #openstack-horizon | 16:15 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/django_openstack_auth: Updated from global requirements https://review.openstack.org/149964 | 16:15 |
| *** dsneddon has joined #openstack-horizon | 16:15 | |
| pkarikh | david-lyle: hi! | 16:16 |
| *** sambetts has quit IRC | 16:16 | |
| *** sambetts_ is now known as sambetts | 16:16 | |
| *** ericpeterson has joined #openstack-horizon | 16:17 | |
| david-lyle | pkarikh: hi | 16:17 |
| *** e0ne has joined #openstack-horizon | 16:17 | |
| *** lblanchard has quit IRC | 16:17 | |
| *** jpomero has quit IRC | 16:18 | |
| *** svasheka has quit IRC | 16:18 | |
| *** coolsvap|afk is now known as coolsvap | 16:18 | |
| *** jprovazn has quit IRC | 16:18 | |
| pkarikh | david-lyle: what if I have a patch with -2 from core reviewer, but I've changed patch and he does not responds and this -2 still with patch. What I have to do? | 16:18 |
| david-lyle | pkarikh: can you point me at the patch? there are limited options, but there are ways around it | 16:19 |
| david-lyle | I might be able to get a response if you can't | 16:19 |
| pkarikh | david-lyle: here it is: https://review.openstack.org/#/c/142844/2 | 16:19 |
| *** svasheka has joined #openstack-horizon | 16:21 | |
| david-lyle | pkarikh: here's the thing, I don't see any input from you back to the core reviewer as to why this needed and how the currently implemented feature doesn't address the problem | 16:22 |
| david-lyle | that's what he's waiting for, "tell me why I'm wrong" | 16:23 |
| david-lyle | without that, there is little point in trying to override or circumvent the -2 | 16:23 |
| david-lyle | let's use that route first | 16:24 |
| *** TravT has quit IRC | 16:25 | |
| pkarikh | david-lyle: hmm.. Ok, it's clear. I'm going to ask Gabriel in comments directly. My fault. Thank you! | 16:26 |
| *** TravT has joined #openstack-horizon | 16:26 | |
| *** salty has joined #openstack-horizon | 16:26 | |
| *** salty is now known as Guest25872 | 16:26 | |
| pkarikh | david-lyle: for some reason I thought that he will response because of new patch. :) | 16:27 |
| *** Ala has quit IRC | 16:30 | |
| *** TravT has quit IRC | 16:30 | |
| *** dsneddon has quit IRC | 16:35 | |
| *** dsneddon has joined #openstack-horizon | 16:36 | |
| *** e0ne is now known as e0ne_ | 16:41 | |
| *** ftcjeff has joined #openstack-horizon | 16:44 | |
| *** drewfisher314 has joined #openstack-horizon | 16:46 | |
| david-lyle | is it just me, or is the javascript in horizon horribly broken :( | 16:46 |
| david-lyle | on master | 16:46 |
| david-lyle | modals aren't working and tabs don't navigate | 16:46 |
| *** venky has quit IRC | 16:47 | |
| david-lyle | nevermind | 16:47 |
| david-lyle | restarting FF helped | 16:47 |
| drewfisher314 | morning all. I have a couple of questions about horizon in juno. first, the requirements file lists xstatic-jsencrypt as a dependency but I'm not seeing where it's actually used. | 16:47 |
| david-lyle | memory leak? | 16:47 |
| mattfarina | david-lyle the js in horizon is in bad shape. there are memory leaks and things using too much memory | 16:48 |
| mattfarina | david-lyle and i added something to the agenda a little bit ago to talk about one of those things :) | 16:48 |
| david-lyle | mattfarina: I think I just had the same browser instance open too long | 16:48 |
| mattfarina | that's because of horizon. i can leave gmail open for days with no problem | 16:48 |
| david-lyle | we should really add more javascript | 16:48 |
| david-lyle | mattfarina: I understand | 16:49 |
| mattfarina | and this is something i want to help get cleaned up | 16:49 |
| david-lyle | make it so | 16:49 |
| jpich | drewfisher314: It's used for something to do with windows passwords, let me find the blueprint | 16:49 |
| drewfisher314 | jpich: awesome. | 16:49 |
| *** alexpilotti has quit IRC | 16:49 | |
| david-lyle | jpich: I'm glad your memory works! | 16:49 |
| drewfisher314 | no need for a restart. no memory leak ther e;) | 16:50 |
| *** e0ne_ has quit IRC | 16:51 | |
| *** nlahouti has joined #openstack-horizon | 16:52 | |
| jpich | drewfisher314: Ah here it is! https://blueprints.launchpad.net/horizon/+spec/decrypt-and-display-vm-generated-password - it needs to be enabled, I don't think it is by default | 16:52 |
| drewfisher314 | awesome. thank you! | 16:52 |
| *** rwsu_ has joined #openstack-horizon | 16:53 | |
| jpich | You're welcome | 16:53 |
| *** Guest25872 has quit IRC | 16:53 | |
| *** rwsu has quit IRC | 16:53 | |
| *** e0ne has joined #openstack-horizon | 16:56 | |
| *** dsneddon has quit IRC | 16:56 | |
| *** dsneddon has joined #openstack-horizon | 16:57 | |
| *** ftcjeff has quit IRC | 16:58 | |
| openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Add integration tests for Identity->Projects page https://review.openstack.org/110919 | 17:00 |
| openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Fix editing current project https://review.openstack.org/149303 | 17:00 |
| *** e0ne_ has joined #openstack-horizon | 17:02 | |
| *** Miouge has joined #openstack-horizon | 17:03 | |
| *** rwsu_ is now known as rwsu | 17:04 | |
| *** e0ne has quit IRC | 17:06 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix editing current project https://review.openstack.org/149303 | 17:08 |
| *** rm_work is now known as rm_work|away | 17:10 | |
| *** masco has quit IRC | 17:13 | |
| *** MaxV has quit IRC | 17:14 | |
| openstackgerrit | Merged openstack/horizon: Replace lockfile by oslo_concurrency https://review.openstack.org/148539 | 17:14 |
| openstackgerrit | Merged openstack/horizon: Fix disappearing Sahara workflow navbar in 'Jobs' panel https://review.openstack.org/150060 | 17:14 |
| openstackgerrit | Merged openstack/horizon: Fixes Error message during image upload due to file filtering https://review.openstack.org/131059 | 17:15 |
| *** nikunj2512_ has joined #openstack-horizon | 17:16 | |
| *** dsneddon has quit IRC | 17:17 | |
| *** sbfox has joined #openstack-horizon | 17:17 | |
| nikunj2512_ | david-lyle: Hi, i have a question related to this bug ->https://bugs.launchpad.net/horizon/+bug/1414830 | 17:17 |
| *** Drago1 has joined #openstack-horizon | 17:18 | |
| nikunj2512_ | david-lyle: in this bug, as it is mentioned the hidden fields are not prepopulated | 17:18 |
| *** rdopiera has quit IRC | 17:18 | |
| *** dsneddon has joined #openstack-horizon | 17:18 | |
| nikunj2512_ | david-lyle: As i inspected the code, i found out we are setting those fields as password fields and django doesn't support the initialization of password fields | 17:19 |
| *** Drago has quit IRC | 17:19 | |
| nikunj2512_ | david-lyle: My question is this -> Is i am allowed to make a custom form field and use it? | 17:19 |
| *** lhcheng has joined #openstack-horizon | 17:20 | |
| *** salty has joined #openstack-horizon | 17:20 | |
| *** salty is now known as Guest77172 | 17:21 | |
| *** dboik_ has quit IRC | 17:21 | |
| *** Drago1 has quit IRC | 17:22 | |
| *** ygbo has quit IRC | 17:22 | |
| *** sbfox has quit IRC | 17:22 | |
| *** Drago has joined #openstack-horizon | 17:22 | |
| *** jpich has quit IRC | 17:24 | |
| *** gokrokve_ has quit IRC | 17:28 | |
| *** sbfox has joined #openstack-horizon | 17:28 | |
| *** JeanBriceCombebi has quit IRC | 17:28 | |
| openstackgerrit | Julien Danjou proposed openstack/tuskar-ui: Remove lockfile from requirements https://review.openstack.org/150508 | 17:29 |
| *** markus_z has quit IRC | 17:30 | |
| rbertram | nikunj2512_: did you get an answer about how to get UX input on where to put fips? | 17:31 |
| david-lyle | nikunj2512_: I'm not sure why'd we hide the username | 17:31 |
| david-lyle | the password is another issue | 17:31 |
| david-lyle | not sure what the appropriate answer is for that | 17:31 |
| david-lyle | could make a custom field that has password like behavior | 17:32 |
| nikunj2512_ | rbertram: Sadly, no | 17:32 |
| *** jtomasek has quit IRC | 17:32 | |
| david-lyle | nikunj2512_: you want UX input on what? | 17:32 |
| nikunj2512_ | david-lyle: I also don't know but if in the heat template user have set it to hide than we can't much.. Correct? | 17:33 |
| *** drewfisher314 has left #openstack-horizon | 17:33 | |
| nikunj2512_ | david-lyle: UX input on where to put Floating IPs tab | 17:33 |
| david-lyle | other ways to hide | 17:33 |
| david-lyle | Piet | 17:33 |
| david-lyle | Piet: around | 17:33 |
| david-lyle | Piet | 17:33 |
| david-lyle | Piet | 17:33 |
| david-lyle | Piet just ran a little study on that type of question | 17:34 |
| nikunj2512_ | david-lyle: This is the bug on which i need UX input -> https://bugs.launchpad.net/horizon/+bug/1396562 | 17:34 |
| david-lyle | Piet, lblanchard1 ^^^ | 17:34 |
| Piet | Hey | 17:34 |
| Piet | Just got back from Starbucks | 17:34 |
| david-lyle | nikunj2512_: has an IA question | 17:34 |
| nikunj2512_ | Piet: Hi | 17:34 |
| *** mpavlase has quit IRC | 17:34 | |
| david-lyle | seems your card sort could provide some guidance | 17:34 |
| david-lyle | where to put floating IPs | 17:35 |
| Piet | Melissa is actually giving a presentation from the card sort study on Thursday if you can wait | 17:35 |
| david-lyle | nikunj2512_: the tricky part is we still support nova-net as well as neutron | 17:35 |
| nikunj2512_ | david-lyle: Piet can provide guidance on Floating IP or the custom password filed? | 17:36 |
| rbertram | nikunj2512_: Good to chat here; also for future reference, you can set Piet or jacalcat to be reviewers of your patch. this is one good way to ask for their input. | 17:36 |
| Piet | Also, let me know if you want to attend! | 17:36 |
| david-lyle | but that doesn't make network panel group a bad place to put it | 17:36 |
| rbertram | nikunj2512_: for UX, I mean | 17:36 |
| nikunj2512_ | david-lyle: Ok | 17:36 |
| nikunj2512_ | rbertram: Thank You.. I will | 17:36 |
| *** dboik has joined #openstack-horizon | 17:36 | |
| nikunj2512_ | david-lyle: Yes that question came today morning while i was talking with mrunge | 17:37 |
| nikunj2512_ | david-lyle: He gave two advices First ask UX and other have the FIP at two places | 17:37 |
| *** jcoufal_ has quit IRC | 17:37 | |
| david-lyle | nikunj2512_: for heat stuff, there are other options for hiding fields than password fields, javascript could be used to collapse and area | 17:37 |
| nikunj2512_ | david-lyle: One in compute and one in networks | 17:37 |
| david-lyle | ick on two places | 17:37 |
| david-lyle | network applies regardless of the type of network you're using | 17:38 |
| *** dsneddon has quit IRC | 17:38 | |
| david-lyle | just most of the other panels would be hidden with nova-net | 17:38 |
| nikunj2512_ | david-lyle: Yes... But it seems most of people wishes to group FIP with networks | 17:38 |
| david-lyle | yup, that's what I said | 17:39 |
| nikunj2512_ | david-lyle: Yes... But it seems most of people wishes to group FIP with networks | 17:39 |
| nikunj2512_ | david-lyle: Sorry | 17:39 |
| nikunj2512_ | david-lyle: Yes | 17:39 |
| david-lyle | network meaning neutron is only in developers' heads | 17:39 |
| david-lyle | users don't care | 17:39 |
| nikunj2512_ | david-lyle: Yes, you are right | 17:39 |
| nikunj2512_ | Piet: What are your thoughts on this matter? | 17:39 |
| *** dsneddon has joined #openstack-horizon | 17:40 | |
| Piet | I'm currently looking at the blueprint | 17:40 |
| nikunj2512_ | david-lyle: But we have to find a solution to this problem,... | 17:40 |
| Piet | One sec... | 17:40 |
| *** rushiagr is now known as rushiagr_away | 17:40 | |
| nikunj2512_ | david-lyle: Ok | 17:40 |
| nikunj2512_ | Piet: Ok | 17:40 |
| nikunj2512_ | david-lyle: For heat problem, can't i make all the fields as charfields and then using javascript change the fields which have passwords as password fields? | 17:41 |
| Piet | So, a couple of thoughts. First, I think it would be a good idea for some of the people that are part of the Horizon team to watch Melissa's presentation on Thursday to give context. | 17:42 |
| Piet | I also think that it may make sense to view the entire menu more holistically rather than on a per panel basis | 17:43 |
| nikunj2512_ | Piet: Where we can watch Melissa's presentation? | 17:43 |
| Piet | Is it possible to wait until Thursday? | 17:43 |
| nikunj2512_ | Piet: Ok | 17:43 |
| nikunj2512_ | Piet: Yes, it is | 17:43 |
| Piet | Awesome - thanks for your patience | 17:44 |
| nikunj2512_ | Piet: No problem :) | 17:44 |
| nikunj2512_ | Piet: Where we can watch Melissa's presentation? | 17:44 |
| Piet | Should I send a link to the Horizon email list? | 17:44 |
| *** gokrokve has joined #openstack-horizon | 17:44 | |
| *** masco has joined #openstack-horizon | 17:45 | |
| nikunj2512_ | Piet: That will be great | 17:45 |
| david-lyle | nikunj2512_: I don't see why not | 17:46 |
| Piet | I'm thinking it will on Google Event where anyone with the link can watch | 17:46 |
| david-lyle | or flag them with an attribute that changes the behavior | 17:46 |
| david-lyle | if that's possible | 17:46 |
| *** TravT has joined #openstack-horizon | 17:46 | |
| david-lyle | left as an exercise for the reader :D | 17:47 |
| nikunj2512_ | david-lyle: flag that how? | 17:47 |
| nikunj2512_ | david-lyle: i tried using AngularJs but wasn't successful | 17:47 |
| david-lyle | html attribute? no idea | 17:47 |
| david-lyle | just a thought | 17:47 |
| *** krykowski has joined #openstack-horizon | 17:48 | |
| nikunj2512_ | david-lyle: Ok... | 17:48 |
| Piet | So, key pairs and security groups traveled together in the card sort. It doesn't matter what group - they where always together | 17:48 |
| *** masco has quit IRC | 17:50 | |
| *** sambetts has quit IRC | 17:50 | |
| *** krykowski has quit IRC | 17:51 | |
| *** krykowski has joined #openstack-horizon | 17:51 | |
| *** sambetts has joined #openstack-horizon | 17:52 | |
| *** romainh has joined #openstack-horizon | 17:53 | |
| *** ayoung_snowedin is now known as ayoung | 17:55 | |
| Piet | Here is the event link for Melissa's presentation | 17:57 |
| Piet | https://plus.google.com/events/ce58sr44fa2t2010pqp1k1cco9o | 17:57 |
| asahlin | Question for the group.. How does one translate multi line strings in JavaScript using django gettext? The only way I found is by ending each line to be translated with //\ then next line being a + to concatenate the next line | 17:58 |
| openstackgerrit | Merged openstack/django_openstack_auth: Updated from global requirements https://review.openstack.org/149964 | 17:58 |
| *** e0ne_ has quit IRC | 17:59 | |
| *** openstack` has joined #openstack-horizon | 18:04 | |
| *** tqtran has joined #openstack-horizon | 18:05 | |
| *** openstack` is now known as openstack | 18:06 | |
| *** harlowja has joined #openstack-horizon | 18:06 | |
| *** Miouge has quit IRC | 18:06 | |
| *** Miouge has joined #openstack-horizon | 18:08 | |
| *** Miouge has quit IRC | 18:08 | |
| *** krykowski has quit IRC | 18:09 | |
| *** krykowski has joined #openstack-horizon | 18:09 | |
| *** nyechiel has quit IRC | 18:13 | |
| *** athomas has quit IRC | 18:18 | |
| *** gyee has joined #openstack-horizon | 18:20 | |
| *** dsneddon has quit IRC | 18:20 | |
| *** krykowski has quit IRC | 18:20 | |
| *** dsneddon has joined #openstack-horizon | 18:21 | |
| openstackgerrit | Eric Peterson proposed openstack/horizon: Correcting heat resource page title https://review.openstack.org/150532 | 18:22 |
| *** romainh has quit IRC | 18:22 | |
| ericpeterson | my fix ^ is like 12 characters to fix a glaring issue with heat | 18:23 |
| *** jroll has quit IRC | 18:24 | |
| ericpeterson | see screen shot @ https://bugs.launchpad.net/horizon/+bug/1415095 for the current behavior that is busted | 18:25 |
| *** krykowski has joined #openstack-horizon | 18:25 | |
| *** jroll has joined #openstack-horizon | 18:26 | |
| sambetts | ericpeterson: Could you rebased that on top of my patch? https://review.openstack.org/#/c/149960/ | 18:27 |
| sambetts | s/rebased/rebase | 18:27 |
| *** gokrokve_ has joined #openstack-horizon | 18:28 | |
| david-lyle | ericpeterson: that's an informative title | 18:28 |
| ericpeterson | sambetts - Are your changes currently in the accepted pipeline? Our two sets should be trivial merge I would think | 18:29 |
| openstackgerrit | David Lyle proposed openstack/horizon: Reordering batch action help text. https://review.openstack.org/150535 | 18:29 |
| ericpeterson | david-lyle - you mean this is the informative title? https://launchpadlibrarian.net/195956784/horizon_fail.png | 18:30 |
| rbertram | So nikunj2512_: Since your fips patch is possibly going to change a lot, I will wait to figure out the test bug | 18:30 |
| david-lyle | ericpeterson: yes | 18:30 |
| *** crobertsrh has quit IRC | 18:30 | |
| ericpeterson | tmi | 18:30 |
| *** jroll has quit IRC | 18:30 | |
| *** jroll has joined #openstack-horizon | 18:30 | |
| *** openstackgerrit has quit IRC | 18:30 | |
| sambetts | ericpeterson: I would like to get some more attention on it, my parent patch to that one has a +2 so you could rebase off that instead | 18:31 |
| *** gokrokve has quit IRC | 18:31 | |
| gary-smith | ericpeterson: you probably want to supply a default for that getattr call so it won't throw an exception if it is missing | 18:32 |
| gary-smith | ericpeterson: (gerrit is unreachable at the moment) | 18:32 |
| *** openstackgerrit has joined #openstack-horizon | 18:32 | |
| ericpeterson | yeah, I see that now too :( | 18:32 |
| ericpeterson | I think I broke it, most likely | 18:32 |
| ericpeterson | 1 line of code change = overloaded | 18:33 |
| gary-smith | :-) | 18:33 |
| *** gokrokve_ has quit IRC | 18:33 | |
| ericpeterson | yeah, default value is fine, could pretty it up what not. Its a simple change, can look at yours too sambetts once gerrit returns | 18:33 |
| ericpeterson | bingo | 18:34 |
| sambetts | ericpeterson: resource.html and the ResourceView class are actually a case that I missed in my patch, grep let me down haha | 18:34 |
| ericpeterson | yep, if you want to steal my change or improve it, have at it ;) | 18:35 |
| nikunj2512_ | rbertram: Ok..Thank You :) | 18:35 |
| *** ybathia has joined #openstack-horizon | 18:36 | |
| sambetts | ericpeterson: I can add it to my patch, or I'll add the changes that I would make and you can rebase on top | 18:38 |
| *** e0ne has joined #openstack-horizon | 18:38 | |
| *** e0ne is now known as e0ne_ | 18:38 | |
| sambetts | ericpeterson: my patch is already huge, so it might be worth not losing a change like that in the middle of all mine | 18:38 |
| ericpeterson | ok. yeah, I can see the pattern you have sambetts. seams reasonable enough. | 18:39 |
| *** romainh has joined #openstack-horizon | 18:39 | |
| *** sbfox has quit IRC | 18:40 | |
| *** dsneddon has quit IRC | 18:41 | |
| sambetts | ericpeterson: thanks for the comment :-) I think the flexablity is still there, because at least from what i've seen if you include the {% block page_header %} block in your template it simply overrides the on in base.html letting you customise away | 18:42 |
| sambetts | s/on/one/ | 18:42 |
| lhcheng | Not sure why it the notification didn't pop-up in this room | 18:42 |
| lhcheng | openstackstatus: | 18:42 |
| lhcheng | NOTICE: Gerrit and Zuul will be offline for a few minutes for a security update | 18:42 |
| *** dsneddon has joined #openstack-horizon | 18:42 | |
| *** e0ne_ is now known as e0ne | 18:43 | |
| ericpeterson | its back now | 18:43 |
| lhcheng | that was sent out an hour ago | 18:43 |
| *** romainh has left #openstack-horizon | 18:45 | |
| *** mpavlase has joined #openstack-horizon | 18:45 | |
| *** sbfox has joined #openstack-horizon | 18:48 | |
| *** romainh has joined #openstack-horizon | 18:49 | |
| *** romainh has left #openstack-horizon | 18:49 | |
| *** e0ne has quit IRC | 18:49 | |
| *** Miouge has joined #openstack-horizon | 18:49 | |
| *** gokrokve has joined #openstack-horizon | 18:50 | |
| *** harlowja has quit IRC | 18:52 | |
| openstackgerrit | Sam Betts proposed openstack/horizon: Add page_title mixin to all templates https://review.openstack.org/149960 | 18:53 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix editing current project https://review.openstack.org/149303 | 18:53 |
| *** krykowski has quit IRC | 18:53 | |
| *** ericpeterson has quit IRC | 18:54 | |
| *** gokrokve has quit IRC | 18:56 | |
| *** gokrokve has joined #openstack-horizon | 18:56 | |
| *** coolsvap is now known as coolsvap|afk | 18:56 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix editing current project https://review.openstack.org/149303 | 19:00 |
| *** rushiagr_away is now known as rushiagr | 19:00 | |
| *** dsneddon has quit IRC | 19:02 | |
| *** doug-fish has quit IRC | 19:02 | |
| *** rm_work|away is now known as rm_work | 19:03 | |
| *** dsneddon has joined #openstack-horizon | 19:04 | |
| *** lblanchard1 is now known as lblanchard | 19:10 | |
| openstackgerrit | Sam Betts proposed openstack/horizon: Add page_title mixin to all templates https://review.openstack.org/149960 | 19:12 |
| openstackgerrit | Sam Betts proposed openstack/horizon: Reduced code duplication in creating page headers https://review.openstack.org/142802 | 19:12 |
| *** doug-fish has joined #openstack-horizon | 19:15 | |
| jamielennox | david-lyle: when you get some time can you review https://review.openstack.org/#/c/121281/ - i understand you're the other person that understands that area well | 19:20 |
| david-lyle | jamielennox: still slowly working my way through it | 19:21 |
| david-lyle | it's fundamental to a working horizon so I want to be thorough | 19:23 |
| doug-fish | david-lyle: I'm not quite sure what's behind this but people keep asking me when the blueprint freeze for Horizon is. | 19:24 |
| doug-fish | we don't observe such a thing, do we? | 19:24 |
| jamielennox | david-lyle: that's fine - i just wanted to check you were aware of it | 19:24 |
| david-lyle | we do, but it's late in the cycle | 19:24 |
| david-lyle | other projects like nova and neutron tend to already have had theirs | 19:25 |
| doug-fish | FWIW I've been saying people better get your stuff proposed before kilo-3 starts or else it won't get prioritized by reviewers. | 19:25 |
| doug-fish | yeah, those nova/neutron types are so strict! | 19:25 |
| david-lyle | doug-fish: that's a good recommendation | 19:26 |
| david-lyle | sometimes we have tiny, obvious blueprints that come in late, but for the most part, we're already planned | 19:27 |
| *** radez is now known as radez_g0n3 | 19:27 | |
| *** tosky has quit IRC | 19:27 | |
| *** harlowja has joined #openstack-horizon | 19:28 | |
| *** jpomero_ has quit IRC | 19:28 | |
| doug-fish | david-lyle: that's not a surprise to me. Thx for clarifying! | 19:31 |
| *** ericpeterson has joined #openstack-horizon | 19:31 | |
| david-lyle | doug-fish: and by planned, I mean overloaded | 19:31 |
| david-lyle | :P | 19:31 |
| doug-fish | lol, of course! | 19:31 |
| *** e0ne has joined #openstack-horizon | 19:37 | |
| *** rushiagr is now known as rushiagr_away | 19:40 | |
| *** crobertsrh has joined #openstack-horizon | 19:42 | |
| *** dsneddon has quit IRC | 19:43 | |
| *** dsneddon has joined #openstack-horizon | 19:44 | |
| *** Sukhdev has joined #openstack-horizon | 19:48 | |
| *** rushiagr_away is now known as rushiagr | 19:50 | |
| *** nyechiel has joined #openstack-horizon | 19:56 | |
| *** aix has quit IRC | 19:56 | |
| *** neelashah has quit IRC | 19:59 | |
| openstackgerrit | Nikunj Aggarwal proposed openstack/horizon: Fixes heat templates hidden parameters are not loading problem https://review.openstack.org/150567 | 19:59 |
| *** neelashah has joined #openstack-horizon | 20:02 | |
| *** dsneddon has quit IRC | 20:04 | |
| *** dsneddon has joined #openstack-horizon | 20:05 | |
| r1chardj0n3s | morning | 20:06 |
| *** bradjones has quit IRC | 20:07 | |
| *** stevemar has quit IRC | 20:08 | |
| *** stevemar has joined #openstack-horizon | 20:08 | |
| mattfarina | r1chardj0n3s good afternoon ;-) | 20:09 |
| rbertram | hi r1chardj0n3s | 20:10 |
| r1chardj0n3s | heya mattfarina and rbertram :) | 20:10 |
| *** peristeri has quit IRC | 20:12 | |
| *** bradjones has joined #openstack-horizon | 20:13 | |
| *** nikunj2512_ has quit IRC | 20:16 | |
| *** smc7 has quit IRC | 20:19 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Read access to config via REST https://review.openstack.org/150573 | 20:21 |
| *** openstack has joined #openstack-horizon | 20:38 | |
| *** sendak.freenode.net sets mode: +ns | 20:38 | |
| *** sendak.freenode.net sets mode: -o openstack | 20:44 | |
| -sendak.freenode.net- *** Notice -- TS for #openstack-horizon changed from 1422391099 to 1330371319 | 20:44 | |
| *** sendak.freenode.net sets mode: +ct-s | 20:44 | |
| *** dboik has joined #openstack-horizon | 20:44 | |
| *** dsneddon has joined #openstack-horizon | 20:44 | |
| *** ZZelle has joined #openstack-horizon | 20:44 | |
| *** mgagne_ has joined #openstack-horizon | 20:44 | |
| *** EmilienM has joined #openstack-horizon | 20:44 | |
| *** rm_work has joined #openstack-horizon | 20:44 | |
| *** jamielennox has joined #openstack-horizon | 20:44 | |
| *** bradjones has joined #openstack-horizon | 20:44 | |
| *** stevemar has joined #openstack-horizon | 20:44 | |
| *** neelashah has joined #openstack-horizon | 20:44 | |
| *** Sukhdev has joined #openstack-horizon | 20:44 | |
| *** crobertsrh has joined #openstack-horizon | 20:44 | |
| *** e0ne has joined #openstack-horizon | 20:44 | |
| *** ericpeterson has joined #openstack-horizon | 20:44 | |
| *** harlowja has joined #openstack-horizon | 20:44 | |
| *** doug-fish has joined #openstack-horizon | 20:44 | |
| *** gokrokve has joined #openstack-horizon | 20:44 | |
| *** Miouge has joined #openstack-horizon | 20:44 | |
| *** sbfox has joined #openstack-horizon | 20:44 | |
| *** mpavlase has joined #openstack-horizon | 20:44 | |
| *** ybathia has joined #openstack-horizon | 20:44 | |
| *** openstackgerrit has joined #openstack-horizon | 20:44 | |
| *** jroll has joined #openstack-horizon | 20:44 | |
| *** gyee has joined #openstack-horizon | 20:44 | |
| *** tqtran has joined #openstack-horizon | 20:44 | |
| *** sambetts has joined #openstack-horizon | 20:44 | |
| *** TravT has joined #openstack-horizon | 20:44 | |
| *** Drago has joined #openstack-horizon | 20:44 | |
| *** lhcheng has joined #openstack-horizon | 20:44 | |
| *** rwsu has joined #openstack-horizon | 20:44 | |
| *** nlahouti has joined #openstack-horizon | 20:44 | |
| *** svasheka has joined #openstack-horizon | 20:44 | |
| *** lblanchard has joined #openstack-horizon | 20:44 | |
| *** packet has joined #openstack-horizon | 20:44 | |
| *** akrivoka has joined #openstack-horizon | 20:44 | |
| *** sayan has joined #openstack-horizon | 20:44 | |
| *** fischerw has joined #openstack-horizon | 20:44 | |
| *** vijendar has joined #openstack-horizon | 20:44 | |
| *** Ctina has joined #openstack-horizon | 20:44 | |
| *** cbader has joined #openstack-horizon | 20:44 | |
| *** mattfarina has joined #openstack-horizon | 20:44 | |
| *** tzumainn has joined #openstack-horizon | 20:44 | |
| *** amotoki has joined #openstack-horizon | 20:44 | |
| *** regebro has joined #openstack-horizon | 20:44 | |
| *** josecastroleon has joined #openstack-horizon | 20:44 | |
| *** mrunge has joined #openstack-horizon | 20:44 | |
| *** htruta has joined #openstack-horizon | 20:44 | |
| *** fifieldt has joined #openstack-horizon | 20:44 | |
| *** chlong has joined #openstack-horizon | 20:44 | |
| *** jasondotstar has joined #openstack-horizon | 20:44 | |
| *** julim has joined #openstack-horizon | 20:44 | |
| *** raildo has joined #openstack-horizon | 20:44 | |
| *** hhuang has joined #openstack-horizon | 20:44 | |
| *** gary-smith has joined #openstack-horizon | 20:44 | |
| *** rebelagentm has joined #openstack-horizon | 20:44 | |
| *** davelowe has joined #openstack-horizon | 20:44 | |
| *** vhoward has joined #openstack-horizon | 20:44 | |
| *** NikitaKonovalov has joined #openstack-horizon | 20:44 | |
| *** jcooley has joined #openstack-horizon | 20:44 | |
| *** pkarikh has joined #openstack-horizon | 20:44 | |
| *** _gryf has joined #openstack-horizon | 20:44 | |
| *** mitz has joined #openstack-horizon | 20:44 | |
| *** ozialien_ has joined #openstack-horizon | 20:44 | |
| *** mwhagedorn has joined #openstack-horizon | 20:44 | |
| *** lifeless has joined #openstack-horizon | 20:44 | |
| *** DuncanT has joined #openstack-horizon | 20:44 | |
| *** ayoung has joined #openstack-horizon | 20:44 | |
| *** sbadia has joined #openstack-horizon | 20:44 | |
| *** zz_ttrifonov has joined #openstack-horizon | 20:44 | |
| *** tsufiev_ has joined #openstack-horizon | 20:44 | |
| *** SlickNik has joined #openstack-horizon | 20:44 | |
| *** zul has joined #openstack-horizon | 20:44 | |
| *** coolsvap|afk has joined #openstack-horizon | 20:44 | |
| *** anteaya has joined #openstack-horizon | 20:44 | |
| *** d0ugal has joined #openstack-horizon | 20:44 | |
| *** swartulv has joined #openstack-horizon | 20:44 | |
| *** krotscheck has joined #openstack-horizon | 20:44 | |
| *** baffle_ has joined #openstack-horizon | 20:44 | |
| *** rhagarty has joined #openstack-horizon | 20:44 | |
| *** rodrigods has joined #openstack-horizon | 20:44 | |
| *** david-lyle has joined #openstack-horizon | 20:44 | |
| *** tmazur_ has joined #openstack-horizon | 20:44 | |
| *** shadower has joined #openstack-horizon | 20:44 | |
| *** activedecay has joined #openstack-horizon | 20:44 | |
| *** lsmola has joined #openstack-horizon | 20:44 | |
| *** pashkin has joined #openstack-horizon | 20:44 | |
| *** ongk has joined #openstack-horizon | 20:44 | |
| *** boltR has joined #openstack-horizon | 20:44 | |
| *** mordred has joined #openstack-horizon | 20:44 | |
| *** tristanC has joined #openstack-horizon | 20:44 | |
| *** rushiagr has joined #openstack-horizon | 20:44 | |
| *** jhesketh has joined #openstack-horizon | 20:44 | |
| *** Piet has joined #openstack-horizon | 20:44 | |
| *** neillc has joined #openstack-horizon | 20:44 | |
| *** kmartin has joined #openstack-horizon | 20:44 | |
| *** christophs has joined #openstack-horizon | 20:44 | |
| *** zigo has joined #openstack-horizon | 20:44 | |
| *** Anticimex has joined #openstack-horizon | 20:44 | |
| *** cody-somerville has joined #openstack-horizon | 20:44 | |
| *** asahlin has joined #openstack-horizon | 20:44 | |
| *** HenryG has joined #openstack-horizon | 20:44 | |
| *** paul-- has joined #openstack-horizon | 20:44 | |
| *** jrist has joined #openstack-horizon | 20:44 | |
| *** vcasse has joined #openstack-horizon | 20:44 | |
| *** briancline has joined #openstack-horizon | 20:44 | |
| *** freyes has joined #openstack-horizon | 20:44 | |
| *** vkmc has joined #openstack-horizon | 20:44 | |
| *** early` has joined #openstack-horizon | 20:44 | |
| *** randyochoa has joined #openstack-horizon | 20:44 | |
| *** rbertram has joined #openstack-horizon | 20:44 | |
| *** dguerri has joined #openstack-horizon | 20:44 | |
| *** vokhrimenko has joined #openstack-horizon | 20:44 | |
| *** dachary has joined #openstack-horizon | 20:44 | |
| *** abramley has joined #openstack-horizon | 20:44 | |
| *** miguelgrinberg has joined #openstack-horizon | 20:44 | |
| *** esp has joined #openstack-horizon | 20:44 | |
| *** JoshNang has joined #openstack-horizon | 20:44 | |
| *** ekarlso has joined #openstack-horizon | 20:44 | |
| *** csd has joined #openstack-horizon | 20:44 | |
| *** gugl3 has joined #openstack-horizon | 20:44 | |
| *** mariusv_ has joined #openstack-horizon | 20:44 | |
| *** r1chardj0n3s has joined #openstack-horizon | 20:44 | |
| *** danieru has joined #openstack-horizon | 20:44 | |
| *** mfisch has joined #openstack-horizon | 20:44 | |
| *** radez_g0n3 has joined #openstack-horizon | 20:44 | |
| *** clds has joined #openstack-horizon | 20:44 | |
| *** Madkiss has joined #openstack-horizon | 20:44 | |
| *** trown has joined #openstack-horizon | 20:44 | |
| *** jgravel has joined #openstack-horizon | 20:44 | |
| *** dloi has joined #openstack-horizon | 20:44 | |
| *** sendak.freenode.net changes topic to "OpenStack Horizon: y'know the cool interface everybody is talking about..." | 20:44 | |
| *** akrivoka has quit IRC | 20:45 | |
| *** dsneddon has quit IRC | 20:46 | |
| *** salty has joined #openstack-horizon | 20:47 | |
| *** dsneddon has joined #openstack-horizon | 20:47 | |
| *** salty is now known as Guest10102 | 20:48 | |
| *** Guest10102 is now known as McSalty | 20:48 | |
| *** mrunge has quit IRC | 20:49 | |
| *** nlahouti has quit IRC | 20:52 | |
| *** rushiagr is now known as rushiagr_away | 20:53 | |
| *** radez_g0n3 is now known as radez | 20:53 | |
| *** rushiagr_away is now known as rushiagr | 20:59 | |
| *** smc7 has joined #openstack-horizon | 21:01 | |
| *** raildo is now known as raildo_away | 21:04 | |
| *** dsneddon has quit IRC | 21:07 | |
| *** dsneddon has joined #openstack-horizon | 21:08 | |
| *** rushiagr is now known as rushiagr_away | 21:15 | |
| *** neelashah has quit IRC | 21:18 | |
| *** gokrokve has quit IRC | 21:21 | |
| openstackgerrit | Merged openstack/horizon: Fix cell(User Name) inline edit with a link in user table https://review.openstack.org/147193 | 21:22 |
| *** stevemar has quit IRC | 21:28 | |
| *** stevemar has joined #openstack-horizon | 21:28 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Pulled CSS logic from inline-editing https://review.openstack.org/115783 | 21:29 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Pulled CSS logic from inline-editing https://review.openstack.org/115783 | 21:29 |
| *** woodm1979 has joined #openstack-horizon | 21:33 | |
| *** dboik has quit IRC | 21:35 | |
| *** harlowja has quit IRC | 21:35 | |
| woodm1979 | david-lyle: I've got a patch that depends on your patch here: https://review.openstack.org/#/c/141153/2 | 21:37 |
| woodm1979 | Are you thinking htat you'll keep working on it, or should I take another course of action? | 21:37 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Clean modal forms in Identity Users https://review.openstack.org/123550 | 21:40 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Clean modal forms in Identity Users https://review.openstack.org/123550 | 21:41 |
| *** gokrokve has joined #openstack-horizon | 21:46 | |
| *** Miouge has quit IRC | 21:46 | |
| *** Sukhdev has quit IRC | 21:48 | |
| *** dsneddon has quit IRC | 21:48 | |
| *** dsneddon has joined #openstack-horizon | 21:49 | |
| *** nlahouti has joined #openstack-horizon | 21:50 | |
| openstackgerrit | Merged openstack/horizon: Fix setting Primary Project for new user once the project was created https://review.openstack.org/146858 | 21:51 |
| *** jtriley has joined #openstack-horizon | 21:54 | |
| *** neelashah has joined #openstack-horizon | 21:56 | |
| *** akrivoka has joined #openstack-horizon | 21:58 | |
| *** neelashah has quit IRC | 22:01 | |
| *** jtomasek has joined #openstack-horizon | 22:03 | |
| *** akrivoka has quit IRC | 22:03 | |
| *** ZZelle has quit IRC | 22:04 | |
| openstackgerrit | Merged openstack/horizon: Remove extra jQuery object creation in horizon.instances.js https://review.openstack.org/148957 | 22:05 |
| *** mattfarina has quit IRC | 22:07 | |
| *** peristeri has joined #openstack-horizon | 22:09 | |
| doug-fish | david-lyle: I'm surprised to see you -2ed https://review.openstack.org/#/c/145775/ | 22:12 |
| doug-fish | are you saying to opposed to all solutions that let the user log out when an error message is displayed? | 22:13 |
| *** neelashah has joined #openstack-horizon | 22:14 | |
| david-lyle | I'm saying raising the zindex of an arbitrary drop down over random elements is absurd including elements that autoclose in 3 seconds | 22:14 |
| david-lyle | the x on the message will also do the trick in a pinch | 22:14 |
| david-lyle | I would also argue that logging out is not the most common action the user takes | 22:15 |
| david-lyle | in fact, it quite rare, most simply close the browser window/tab | 22:15 |
| david-lyle | because in the end, it doesn't matter, they are timed out anyway | 22:15 |
| doug-fish | they = the messages? | 22:15 |
| doug-fish | Mine don't autoclose - I wonder if I have changed an option away from the default | 22:16 |
| doug-fish | I hadn't thought about most people closing the tab vs logging out | 22:16 |
| david-lyle | hmm, maybe errors don't just info and warn | 22:16 |
| doug-fish | The image in the bug report had multiple error messages | 22:16 |
| doug-fish | so they'd have to click 3 maybe even 4 times to get to the log out button | 22:17 |
| *** radez is now known as radez_g0n3 | 22:17 | |
| david-lyle | why do you want to log out so badly? | 22:17 |
| doug-fish | I bet autoclose is configurable too | 22:17 |
| david-lyle | because you work for a giant corporation that mandates such things? | 22:17 |
| * doug-fish shrugs | 22:17 | |
| doug-fish | logging out fixes everything? | 22:18 |
| doug-fish | I was just surprised when reviewing that you had -2ed it. I'm going to refelct a bit about what you've shared. | 22:18 |
| david-lyle | that's reboot | 22:18 |
| david-lyle | doug-fish: I put it in the review and on the bug | 22:18 |
| david-lyle | my biggest problem is that the solution is lazy/silly design | 22:19 |
| david-lyle | no offense to the author | 22:19 |
| doug-fish | You didn't mention just closing the tab - that's really the obvious option that I hadn't considered | 22:19 |
| doug-fish | and likely the author didn't either | 22:20 |
| *** dboik has joined #openstack-horizon | 22:20 | |
| david-lyle | doug-fish: think about the proposed solution | 22:23 |
| * doug-fish starts thinking | 22:23 | |
| david-lyle | pulling a drop-down with the user name over all top error messages, likely obscuring the text in said message | 22:23 |
| david-lyle | you can't dismiss the drop down that only has the user's name on it, which I hope I already remember, whereas the error message I can close | 22:24 |
| doug-fish | I'm performing a local re-enactment while I think about it ... it strikes me as funny that the drop down menu isn't on top | 22:26 |
| doug-fish | really it looks a bit funny either way | 22:26 |
| *** McSalty has quit IRC | 22:27 | |
| *** jtriley_ has joined #openstack-horizon | 22:28 | |
| tqtran | david-lyle: ping | 22:28 |
| doug-fish | david-lyle: I think it's an arbitrary preference either way - and easy enough to change in a local implementation. I was surprised to see you objected enough to -2 the idea and wanted find out why | 22:28 |
| david-lyle | doug-fish: when do I get to see the top message unobstructed? | 22:28 |
| david-lyle | tqtran: pong | 22:28 |
| doug-fish | when the menu isn't open? | 22:28 |
| *** crobertsrh has quit IRC | 22:29 | |
| tqtran | david-lyle: i'll wait until you're done with doug, I want to bring up the javascript issue again lol | 22:29 |
| *** dsneddon has quit IRC | 22:29 | |
| *** jtomasek has quit IRC | 22:30 | |
| doug-fish | tqtran: you guys go ahead - I feel like we've talked through a trivial issue enough already. I can see where david-lyle is coming from. | 22:30 |
| *** dsneddon has joined #openstack-horizon | 22:30 | |
| tqtran | doug-fish: thanks doug | 22:31 |
| tqtran | david-lyle: https://review.openstack.org/#/c/141457/ so i just added some more comments after reading through yours | 22:31 |
| david-lyle | I'm in a -2 mood, apparently :D | 22:31 |
| tqtran | david-lyle: and actually started work on isolating the CONF, then I remembered why I wasn't able to do that in the first place | 22:31 |
| david-lyle | let's take a look | 22:32 |
| tqtran | david-lyle: lol I have some very convincing arguments that might change your mind | 22:32 |
| david-lyle | I'm not to be reasoned with | 22:32 |
| david-lyle | so first question would be, and this predates me, why would we have _scripts at the end of the body? | 22:33 |
| david-lyle | who made that call, and why? | 22:34 |
| david-lyle | move scripts to the header where it belongs? | 22:34 |
| david-lyle | head | 22:34 |
| tqtran | basically, some developers prefer to have the scripts at the end of body so that the DOM is loaded before the scripts | 22:34 |
| tqtran | but that is sorted of outdate now given that jquery provides a callback function $(document).ready(...) to detect DOM onload event | 22:35 |
| david-lyle | because it's operating on the DOM? isn't that what ready is for? | 22:35 |
| tqtran | david-lyle: yes basically | 22:35 |
| david-lyle | ah you were ahead of my typing | 22:35 |
| tqtran | david-lyle: having said that, im still ok with keeping one file for CONF and one for SCRIPTS, I can just move the SCRIPTS to the head in base.html | 22:36 |
| tqtran | that should solve most of the problems | 22:36 |
| *** jtriley_ has quit IRC | 22:37 | |
| tqtran | so far so good? | 22:37 |
| david-lyle | in fact, _scripts uses ready to trigger the horizon init functions already | 22:38 |
| tqtran | yes it does, the very last line | 22:38 |
| david-lyle | right | 22:38 |
| david-lyle | such silly, much grief | 22:38 |
| david-lyle | works for me to move it | 22:38 |
| david-lyle | I'm sure the world will explode | 22:38 |
| tqtran | ok now let me bring up the next issue | 22:38 |
| tqtran | it might lol | 22:38 |
| tqtran | i have to test it first | 22:38 |
| david-lyle | it usually does | 22:39 |
| tqtran | hahaha probably | 22:39 |
| tqtran | ok next issue on the list | 22:39 |
| david-lyle | sure, hit me | 22:39 |
| tqtran | https://github.com/openstack/horizon/blob/master/horizon/templates/horizon/_conf.html#L35 | 22:39 |
| tqtran | if you look at that line, we are embedding CONFIG into an angular module | 22:40 |
| david-lyle | yeah | 22:40 |
| tqtran | which means that angular has to exist before the embed can happen | 22:40 |
| *** sayan has quit IRC | 22:40 | |
| tqtran | which means that we can not cleanly isolate them | 22:40 |
| tqtran | which means we end up with the same issue, where some scripts will live in CONF while some in SCRIPTS | 22:40 |
| tqtran | and if at any given point in time, we embed any INLINE javascripts in the body, it will blow up | 22:41 |
| tqtran | well... last line not true if we move SCRIPT to head, sorry for confusion | 22:41 |
| *** lblanchard has quit IRC | 22:42 | |
| david-lyle | I thought we just resolved in the council of two to move it to head | 22:42 |
| tqtran | right we did | 22:42 |
| tqtran | dont read those 2 lines | 22:43 |
| tqtran | i was in circular reasoning mode | 22:43 |
| tqtran | but the 2 lines above it are still true | 22:43 |
| david-lyle | a well-rounded argument you say | 22:43 |
| tqtran | lol yep | 22:43 |
| tqtran | ok, lets say we still want to keep CONF and SCRIPT separate and we are ok with some libs included in CONF | 22:44 |
| david-lyle | how we load CONF can change | 22:44 |
| david-lyle | maybe? | 22:44 |
| tqtran | if, and this is a big IF, I give us access to CONF via a REST service | 22:44 |
| *** harlowja has joined #openstack-horizon | 22:44 | |
| tqtran | and this is done as soon as the DOM is loaded, we wont need it at all | 22:45 |
| tqtran | which means, we end up with one dedicated template where we can put in all of our JS | 22:45 |
| tqtran | and our code is much cleaner and happier | 22:46 |
| tqtran | which means in the long run, we can be less confuse | 22:46 |
| tqtran | have I convince you? lol | 22:46 |
| david-lyle | here's the short of it, I want _scripts.html to remain and continue to do at least what it is currently doing, the rest is meh | 22:46 |
| *** mpavlase has quit IRC | 22:46 | |
| david-lyle | I mean I'm not against it, and would like to see it, but _scripts.html is part of the base template | 22:47 |
| tqtran | right understood | 22:47 |
| tqtran | but you will agree at least to move it to the head yes? | 22:47 |
| david-lyle | changing that has huge migration implications I don't want to take on | 22:47 |
| tqtran | ok, for now, i will leave CONF alone | 22:47 |
| david-lyle | I'm fine with it in head, but that will still likely screw people up | 22:48 |
| tqtran | but I will still provide a REST service for it | 22:48 |
| tqtran | well, it shouldnt screw people up actually | 22:48 |
| tqtran | it should work, i honestly dont think it will blow anything up | 22:48 |
| david-lyle | actually, you're sort of right | 22:48 |
| david-lyle | I think | 22:48 |
| tqtran | it will most definitely work =) | 22:49 |
| tqtran | i will guarantee that | 22:49 |
| *** harlowja_ has joined #openstack-horizon | 22:49 | |
| ericpeterson | did our earlier outage cause some problems with zuul / build queues? https://review.openstack.org/#/c/150532/ has no updates from jenkins | 22:50 |
| *** dsneddon has quit IRC | 22:50 | |
| *** harlowja has quit IRC | 22:50 | |
| david-lyle | I imagine things in flight when zuul went belly up, lost state | 22:51 |
| david-lyle | so recheck | 22:51 |
| *** dsneddon has joined #openstack-horizon | 22:51 | |
| * ericpeterson shakes his fist at zuul | 22:52 | |
| doug-fish | ericpeterson: probably karma for bug stealing! | 22:54 |
| ericpeterson | touche | 22:55 |
| doug-fish | david-lyle: that logout style bug is still in my head. Did you look at it? I put together a picture! http://picpaste.com/with_and_without_the_patch-3F21oLFY.png | 22:59 |
| *** ericpeterson has quit IRC | 23:01 | |
| david-lyle | doug-fish: the message is lowered, which was the margin change I glossed over | 23:02 |
| *** harlowja_ has quit IRC | 23:03 | |
| doug-fish | ok sure - and I don't think the button/menu anchor itself (the user name) isn't pulled forward -- although they don't overlap anymore so it doesn't really matter | 23:03 |
| *** e0ne has quit IRC | 23:05 | |
| david-lyle | doug-fish: two things remain | 23:08 |
| david-lyle | one, the messages are now lower z-index than the modal backdrop | 23:08 |
| doug-fish | oops. | 23:09 |
| david-lyle | two, the header and button itself, should someone resize the header are still below the message, it's still a kludge IMO | 23:09 |
| *** peristeri has quit IRC | 23:09 | |
| david-lyle | I have to reverify two | 23:09 |
| *** alan_mc has joined #openstack-horizon | 23:10 | |
| *** neelashah has quit IRC | 23:11 | |
| david-lyle | yeah, I see no z-index set on topbar or button | 23:11 |
| *** dsneddon has quit IRC | 23:11 | |
| *** dsneddon has joined #openstack-horizon | 23:12 | |
| doug-fish | I'm not sure how to disentangle the error message from the menu area - my first thought was just to move it left, but then it would conflict with modal dialogs. | 23:14 |
| doug-fish | I think your model of this is that the error messages are like little modal dialogs and it's okay and expected if you can't logout until they are dismissed... right? | 23:14 |
| david-lyle | doug-fish: yes | 23:15 |
| david-lyle | not a bug | 23:15 |
| doug-fish | :-) | 23:15 |
| david-lyle | I don't mind an improvement, but what is proposed is a band-aid at best | 23:15 |
| david-lyle | we should be designing to make moving forward easy, not to work by coincidence | 23:16 |
| doug-fish | sure, of course. | 23:17 |
| david-lyle | of course theory and practice don't always meet | 23:17 |
| david-lyle | I'll -1 and look for improvements | 23:18 |
| doug-fish | yeah - I hadn't really thought about the error messages as being mini-modal dialogs before | 23:18 |
| doug-fish | but they have an X and everything | 23:18 |
| doug-fish | cool - I do think it's a bug, though I'm not sure if we are really on the path to a right solution | 23:19 |
| *** vijendar has quit IRC | 23:23 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Consolidating conf and scripts https://review.openstack.org/141457 | 23:24 |
| *** rhsu has joined #openstack-horizon | 23:25 | |
| *** gary-smith has quit IRC | 23:25 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Consolidating conf and scripts https://review.openstack.org/141457 | 23:28 |
| *** mgagne_ is now known as mgagne | 23:29 | |
| *** dsneddon has quit IRC | 23:32 | |
| tqtran | doug-fish: regarding patch https://review.openstack.org/#/c/123540/, could you remove the -1? i think the description is too long to fit into a python file, it should continue to sit inside a template | 23:32 |
| *** dsneddon has joined #openstack-horizon | 23:32 | |
| tqtran | doug-fish: otherwise, you end up with very very long text blocks in python, and that is just ugly.... | 23:33 |
| doug-fish | tqtran: let me take a look | 23:33 |
| tqtran | doug-fish: one of these patches already merged, and if you strongly disagree, you can always put up a patch to change it =P | 23:34 |
| * doug-fish shakes his head | 23:34 | |
| doug-fish | the things you get away with when I'm not looking .... | 23:34 |
| *** gary-smith has joined #openstack-horizon | 23:35 | |
| tqtran | lol | 23:35 |
| *** harlowja has joined #openstack-horizon | 23:36 | |
| *** Ctina_ has joined #openstack-horizon | 23:36 | |
| david-lyle | doug-fish: now you know how I feel | 23:36 |
| doug-fish | lol | 23:36 |
| tqtran | hahaha that just wrong.... | 23:36 |
| tqtran | oh dont worry, theres more where that came from | 23:36 |
| david-lyle | I have no doubt | 23:37 |
| doug-fish | tqtran: http://stackoverflow.com/questions/9301466/python-formatting-large-text | 23:37 |
| doug-fish | what about that? | 23:37 |
| doug-fish | beautiful large text in python | 23:37 |
| tqtran | so you would rather have the descriptive text sit inside a python file than html? | 23:37 |
| tqtran | what if in the future i want one of those text to be blue? | 23:38 |
| tqtran | just a single word out of the entire block of text | 23:38 |
| doug-fish | I don't want you to do that, so that makes me want you to put it in python even more | 23:38 |
| tqtran | lol | 23:38 |
| doug-fish | too much flexibility isn't always good | 23:38 |
| tqtran | but its not out of the norm to want to style your help header for example | 23:38 |
| tqtran | so that its more visible | 23:39 |
| doug-fish | are you going to add an extension point to do that without forking? | 23:39 |
| doug-fish | :-P | 23:39 |
| tqtran | well, its already extensible the way it is if we leave it in the template | 23:39 |
| doug-fish | oh? | 23:39 |
| tqtran | im not changing the current behavior | 23:39 |
| *** Ctina has quit IRC | 23:40 | |
| tqtran | the only thing i did was abstract some of the texts like id, header, etc... | 23:40 |
| *** nlahouti has quit IRC | 23:40 | |
| doug-fish | oh yeah - and that was good stuff | 23:40 |
| *** Ctina_ has quit IRC | 23:41 | |
| doug-fish | I just have a hard time seeing 2 templates that differ only by one string | 23:41 |
| tqtran | david-lyle: btw, i just ran integration and normal test, and did some manual testing, looks like moving the script to head works fine. if you can give this patch https://review.openstack.org/#/c/141457/ your bless, I promise not to bother you any time soon | 23:41 |
| tqtran | doug-fish: one very long and large string might i add | 23:41 |
| david-lyle | I don't believe you | 23:41 |
| tqtran | david-lyle: haha, pull it down and test for yourself | 23:41 |
| david-lyle | about the second part, not the first | 23:41 |
| david-lyle | :D | 23:41 |
| tqtran | david-lyle: lol "any time soon" is the key word here | 23:42 |
| doug-fish | they key is the definition of "soon" | 23:42 |
| tqtran | i didnt say "ever again" | 23:42 |
| doug-fish | yeah | 23:42 |
| david-lyle | soon is ambiguous | 23:42 |
| tqtran | exactly, i chose my words carefully | 23:42 |
| david-lyle | I'll look | 23:42 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Clean modal forms in Identity Users https://review.openstack.org/123550 | 23:43 |
| david-lyle | I certainly am not esteemed | 23:43 |
| david-lyle | perhaps a bit steamed | 23:43 |
| tqtran | hahaha i have heard julie say it | 23:43 |
| david-lyle | she doesn't mean it either | 23:43 |
| tqtran | just parroting, i dont even know what it means | 23:43 |
| david-lyle | haha | 23:43 |
| tqtran | ah... respect and admir | 23:43 |
| *** smc7 has quit IRC | 23:47 | |
| doug-fish | tqtran: I +1ed your patch. It's definitely progress - better to get it in. | 23:50 |
| *** nlahouti has joined #openstack-horizon | 23:51 | |
| tqtran | =) awesome, thanks doug | 23:52 |
| doug-fish | sure np | 23:52 |
| *** dsneddon has quit IRC | 23:52 | |
| *** dsneddon has joined #openstack-horizon | 23:53 | |
| *** doug-fish has left #openstack-horizon | 23:53 | |
| *** rhsu has quit IRC | 23:55 | |
| *** TravT has quit IRC | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
