| *** lhcheng has quit IRC | 00:00 | |
| *** yingjun has joined #openstack-horizon | 00:00 | |
| *** amotoki has joined #openstack-horizon | 00:12 | |
| *** ayoung has quit IRC | 00:13 | |
| *** yingjun has quit IRC | 00:27 | |
| openstackgerrit | tinytmy proposed openstack/horizon: Change mbformat to mb_float_format https://review.openstack.org/94128 | 00:33 |
|---|---|---|
| *** ZZelle_ has quit IRC | 00:37 | |
| *** lblanchard has joined #openstack-horizon | 00:48 | |
| *** rwsu has joined #openstack-horizon | 00:48 | |
| *** lblanchard has quit IRC | 00:49 | |
| *** amotoki has quit IRC | 00:59 | |
| *** XinXiaohui has joined #openstack-horizon | 01:04 | |
| *** ybathia has quit IRC | 01:15 | |
| *** sbfox has quit IRC | 01:19 | |
| *** TravT has joined #openstack-horizon | 01:31 | |
| *** packet has quit IRC | 01:32 | |
| *** harlowja_away is now known as harlowja | 01:32 | |
| *** TravT has quit IRC | 01:36 | |
| *** echevemaster has joined #openstack-horizon | 01:42 | |
| *** echevemaster has quit IRC | 01:42 | |
| *** Putns has quit IRC | 01:50 | |
| *** rwsu has quit IRC | 02:01 | |
| *** bpokorny_ has quit IRC | 02:02 | |
| *** amotoki has joined #openstack-horizon | 02:15 | |
| *** tqtran has quit IRC | 02:33 | |
| *** Guest80948 has quit IRC | 02:38 | |
| *** tzumainn has quit IRC | 02:40 | |
| *** dsneddon has quit IRC | 02:41 | |
| *** dsneddon has joined #openstack-horizon | 02:42 | |
| *** TravT has joined #openstack-horizon | 02:47 | |
| *** TravT has quit IRC | 02:52 | |
| *** KanagarajM has joined #openstack-horizon | 02:52 | |
| *** ozialien has joined #openstack-horizon | 03:02 | |
| *** Longgeek has joined #openstack-horizon | 03:11 | |
| *** Longgeek has quit IRC | 03:15 | |
| *** Longgeek has joined #openstack-horizon | 03:15 | |
| *** wchrisj has quit IRC | 03:20 | |
| *** dsneddon has quit IRC | 03:22 | |
| *** dsneddon has joined #openstack-horizon | 03:24 | |
| *** lhcheng has joined #openstack-horizon | 03:34 | |
| *** radez is now known as radez_g0n3 | 03:40 | |
| *** dsneddon has quit IRC | 03:43 | |
| *** dsneddon has joined #openstack-horizon | 03:44 | |
| *** harlowja is now known as harlowja_away | 03:49 | |
| *** dsneddon has quit IRC | 04:04 | |
| *** dsneddon has joined #openstack-horizon | 04:05 | |
| *** tmazur_ has joined #openstack-horizon | 04:06 | |
| *** lhcheng has quit IRC | 04:18 | |
| *** TravT has joined #openstack-horizon | 04:18 | |
| *** chlong has quit IRC | 04:19 | |
| *** TravT has quit IRC | 04:23 | |
| *** dsneddon has quit IRC | 04:25 | |
| *** dsneddon has joined #openstack-horizon | 04:26 | |
| *** chlong has joined #openstack-horizon | 04:28 | |
| *** rushiagr_away is now known as rushiagr | 04:34 | |
| *** dsneddon has quit IRC | 04:46 | |
| *** dsneddon has joined #openstack-horizon | 04:46 | |
| *** dsneddon has quit IRC | 05:06 | |
| *** dsneddon has joined #openstack-horizon | 05:07 | |
| openstackgerrit | Jeffrey Olsen proposed openstack/horizon: recheck https://review.openstack.org/148425 | 05:08 |
| *** david-lyle has joined #openstack-horizon | 05:15 | |
| *** masco has joined #openstack-horizon | 05:17 | |
| *** dsneddon has quit IRC | 05:27 | |
| *** dsneddon has joined #openstack-horizon | 05:29 | |
| *** vivekd has joined #openstack-horizon | 05:37 | |
| *** Sukhdev has joined #openstack-horizon | 05:39 | |
| *** sbfox has joined #openstack-horizon | 05:43 | |
| *** ishant has joined #openstack-horizon | 05:48 | |
| *** dsneddon has quit IRC | 05:48 | |
| *** TravT has joined #openstack-horizon | 05:49 | |
| *** dsneddon has joined #openstack-horizon | 05:50 | |
| *** wuhg has joined #openstack-horizon | 05:50 | |
| *** TravT has quit IRC | 05:54 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: adopt namespace-less oslo imports https://review.openstack.org/148184 | 05:55 |
| *** coolsvap|afk is now known as coolsvap | 05:57 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/django_openstack_auth: Imported Translations from Transifex https://review.openstack.org/148175 | 06:02 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/148441 | 06:07 |
| *** MaxV has joined #openstack-horizon | 06:08 | |
| *** dsneddon has quit IRC | 06:09 | |
| *** dsneddon has joined #openstack-horizon | 06:10 | |
| *** XinXiaohui has quit IRC | 06:11 | |
| *** XinXiaohui has joined #openstack-horizon | 06:25 | |
| *** coolsvap is now known as coolsvap|afk | 06:31 | |
| *** coolsvap|afk is now known as coolsvap | 06:43 | |
| *** oro has joined #openstack-horizon | 06:52 | |
| *** david-lyle has quit IRC | 06:57 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: filter added for snapshots and types https://review.openstack.org/146396 | 07:00 |
| *** vivekd has left #openstack-horizon | 07:05 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: cancel next previous buttons are aligned properly https://review.openstack.org/129212 | 07:12 |
| *** mrunge has joined #openstack-horizon | 07:16 | |
| *** david-lyle has joined #openstack-horizon | 07:31 | |
| *** david-lyle has quit IRC | 07:35 | |
| *** MaxV has quit IRC | 07:38 | |
| *** coolsvap is now known as coolsvap|afk | 07:39 | |
| *** rdopiera has joined #openstack-horizon | 07:39 | |
| *** rdopiera has quit IRC | 07:39 | |
| *** rdopiera has joined #openstack-horizon | 07:40 | |
| *** Sukhdev has quit IRC | 07:40 | |
| *** chlong has quit IRC | 07:41 | |
| *** david-lyle has joined #openstack-horizon | 07:42 | |
| *** coolsvap|afk is now known as coolsvap | 07:46 | |
| *** david-lyle has quit IRC | 07:47 | |
| *** Ala has joined #openstack-horizon | 07:48 | |
| *** oro has quit IRC | 07:49 | |
| *** dsneddon has quit IRC | 07:50 | |
| *** dsneddon has joined #openstack-horizon | 07:51 | |
| *** e0ne has joined #openstack-horizon | 08:00 | |
| *** david-lyle has joined #openstack-horizon | 08:01 | |
| *** jprovazn has joined #openstack-horizon | 08:01 | |
| *** e0ne has quit IRC | 08:05 | |
| *** david-lyle has quit IRC | 08:05 | |
| *** dsneddon has quit IRC | 08:11 | |
| *** dsneddon has joined #openstack-horizon | 08:12 | |
| *** MaxV has joined #openstack-horizon | 08:13 | |
| *** jtomasek has joined #openstack-horizon | 08:17 | |
| *** romainh has joined #openstack-horizon | 08:19 | |
| *** Miouge has joined #openstack-horizon | 08:20 | |
| *** krykowski has joined #openstack-horizon | 08:21 | |
| Miouge | How can I access the token of the current user in Horizon ? | 08:22 |
| Miouge | I want to add it to a “info” page for debug purposes | 08:23 |
| *** krykowski has quit IRC | 08:25 | |
| *** jamielennox is now known as jamielennox|away | 08:28 | |
| *** krykowski has joined #openstack-horizon | 08:30 | |
| *** markus_z has joined #openstack-horizon | 08:32 | |
| *** dsneddon has quit IRC | 08:32 | |
| *** dsneddon has joined #openstack-horizon | 08:34 | |
| *** zz_ttrifonov is now known as ttrifonov | 08:41 | |
| *** jcoufal has joined #openstack-horizon | 08:43 | |
| *** JeanBriceCombebi has quit IRC | 08:54 | |
| *** XinXiaohui has quit IRC | 08:54 | |
| *** dkorn has joined #openstack-horizon | 08:55 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 08:56 | |
| *** oro has joined #openstack-horizon | 09:01 | |
| *** ygbo has joined #openstack-horizon | 09:07 | |
| *** coolsvap is now known as coolsvap|afk | 09:10 | |
| *** jpich has joined #openstack-horizon | 09:10 | |
| *** coolsvap|afk is now known as coolsvap | 09:10 | |
| *** dsneddon has quit IRC | 09:14 | |
| *** dsneddon has joined #openstack-horizon | 09:15 | |
| *** david-lyle has joined #openstack-horizon | 09:19 | |
| *** TravT has joined #openstack-horizon | 09:27 | |
| *** chlong has joined #openstack-horizon | 09:28 | |
| *** bluex-pl has joined #openstack-horizon | 09:28 | |
| *** dkorn has quit IRC | 09:30 | |
| *** dkorn has joined #openstack-horizon | 09:31 | |
| *** TravT has quit IRC | 09:32 | |
| *** dsneddon has quit IRC | 09:35 | |
| *** dsneddon has joined #openstack-horizon | 09:36 | |
| *** krykowski has quit IRC | 09:48 | |
| openstackgerrit | Nikita Konovalov proposed openstack/horizon: [Data_processing] fix job_executions table https://review.openstack.org/125927 | 09:50 |
| *** dsneddon has quit IRC | 09:55 | |
| *** dsneddon has joined #openstack-horizon | 09:56 | |
| *** krykowski has joined #openstack-horizon | 10:05 | |
| *** sbfox has quit IRC | 10:08 | |
| *** e0ne has joined #openstack-horizon | 10:16 | |
| *** dsneddon has quit IRC | 10:16 | |
| *** dsneddon has joined #openstack-horizon | 10:17 | |
| *** akrivoka has joined #openstack-horizon | 10:32 | |
| openstackgerrit | Merged openstack/horizon: Change mbformat to mb_float_format https://review.openstack.org/94128 | 10:32 |
| *** dsneddon has quit IRC | 10:37 | |
| *** dsneddon has joined #openstack-horizon | 10:38 | |
| *** e0ne is now known as e0ne_ | 10:41 | |
| *** e0ne_ has quit IRC | 10:46 | |
| openstackgerrit | Tatiana Ovchinnikova proposed openstack/horizon: Add "Check Stack" action to Stacks table https://review.openstack.org/143098 | 10:51 |
| *** e0ne has joined #openstack-horizon | 10:51 | |
| *** tosky has joined #openstack-horizon | 11:08 | |
| *** krykowski has quit IRC | 11:10 | |
| *** amotoki_ has joined #openstack-horizon | 11:12 | |
| *** amotoki_ has quit IRC | 11:12 | |
| *** JeanBriceCombebi has quit IRC | 11:15 | |
| *** TravT has joined #openstack-horizon | 11:16 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 11:17 | |
| *** TravT has quit IRC | 11:20 | |
| *** romainh has quit IRC | 11:24 | |
| *** krykowski has joined #openstack-horizon | 11:25 | |
| openstackgerrit | Merged openstack/horizon: Make ipmi meters be visible in Horizon https://review.openstack.org/144864 | 11:26 |
| *** Miouge_ has joined #openstack-horizon | 11:32 | |
| *** aix has joined #openstack-horizon | 11:33 | |
| *** Miouge has quit IRC | 11:33 | |
| *** Miouge_ is now known as Miouge | 11:33 | |
| *** tmazur_ has quit IRC | 11:44 | |
| openstackgerrit | Daniel Korn proposed openstack/horizon: Integration tests - networkspage and test https://review.openstack.org/139028 | 11:44 |
| *** Putns has joined #openstack-horizon | 11:46 | |
| *** obutenko has joined #openstack-horizon | 11:56 | |
| *** lsmola_ has quit IRC | 11:57 | |
| *** masco has quit IRC | 11:58 | |
| *** krykowski has quit IRC | 12:00 | |
| *** lsmola has joined #openstack-horizon | 12:01 | |
| *** ishant has quit IRC | 12:03 | |
| *** oro has quit IRC | 12:06 | |
| *** e0ne is now known as e0ne_ | 12:07 | |
| openstackgerrit | Merged openstack/tuskar-ui: Role detail page fixes https://review.openstack.org/147189 | 12:09 |
| *** e0ne_ is now known as e0ne | 12:11 | |
| *** KanagarajM has quit IRC | 12:12 | |
| *** pcaruana has joined #openstack-horizon | 12:17 | |
| *** Ala has quit IRC | 12:20 | |
| *** oro has joined #openstack-horizon | 12:20 | |
| *** Ala has joined #openstack-horizon | 12:21 | |
| *** krykowski has joined #openstack-horizon | 12:30 | |
| *** dkorn has quit IRC | 12:39 | |
| *** e0ne is now known as e0ne_ | 12:40 | |
| openstackgerrit | Merged openstack/horizon: Update AngularJS best practices for translatable string https://review.openstack.org/147971 | 12:41 |
| openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Refactor StackMixin and RoleMixin https://review.openstack.org/148531 | 12:45 |
| *** e0ne_ has quit IRC | 12:46 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/148441 | 12:46 |
| *** e0ne has joined #openstack-horizon | 12:48 | |
| *** raildo has quit IRC | 12:52 | |
| openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Refactor StackMixin and RoleMixin https://review.openstack.org/148531 | 12:54 |
| *** raildo has joined #openstack-horizon | 12:55 | |
| *** romainh has joined #openstack-horizon | 12:58 | |
| *** e0ne is now known as e0ne_ | 13:02 | |
| *** TravT has joined #openstack-horizon | 13:05 | |
| *** tzumainn has joined #openstack-horizon | 13:07 | |
| *** Anticimex has quit IRC | 13:08 | |
| *** Anticimex has joined #openstack-horizon | 13:09 | |
| *** TravT has quit IRC | 13:09 | |
| openstackgerrit | Julien Danjou proposed openstack/horizon: Replace lockfile by oslo_concurrency https://review.openstack.org/148539 | 13:09 |
| *** Ala has quit IRC | 13:10 | |
| *** Ala has joined #openstack-horizon | 13:11 | |
| *** e0ne_ has quit IRC | 13:12 | |
| openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Refactor StackMixin and RoleMixin https://review.openstack.org/148531 | 13:13 |
| *** Longgeek has quit IRC | 13:15 | |
| *** Longgeek has joined #openstack-horizon | 13:16 | |
| *** rushiagr is now known as rushiagr_away | 13:19 | |
| *** raildo has quit IRC | 13:19 | |
| rdopiera | I will just leave this here: http://www.onebigfluke.com/2015/01/experimentally-verified-why-client-side.html | 13:20 |
| *** EmilienM|afk is now known as EmilienM | 13:21 | |
| *** julim has joined #openstack-horizon | 13:22 | |
| *** krykowski has quit IRC | 13:22 | |
| *** krykowski has joined #openstack-horizon | 13:28 | |
| *** raildo has joined #openstack-horizon | 13:35 | |
| *** doug-fish has joined #openstack-horizon | 13:38 | |
| *** _crobertsrh has quit IRC | 13:46 | |
| *** crobertsrh has joined #openstack-horizon | 13:48 | |
| *** neelashah has joined #openstack-horizon | 13:49 | |
| *** e0ne has joined #openstack-horizon | 13:50 | |
| *** Longgeek has quit IRC | 13:57 | |
| *** krykowski has quit IRC | 13:58 | |
| openstackgerrit | Julien Danjou proposed openstack/horizon: Replace lockfile by oslo_concurrency https://review.openstack.org/148539 | 14:00 |
| *** krykowski has joined #openstack-horizon | 14:01 | |
| *** radez_g0n3 is now known as radez | 14:02 | |
| *** jpomero has joined #openstack-horizon | 14:02 | |
| *** Longgeek has joined #openstack-horizon | 14:04 | |
| *** oro has quit IRC | 14:10 | |
| *** mrunge has quit IRC | 14:10 | |
| *** peristeri has joined #openstack-horizon | 14:17 | |
| *** TravT has joined #openstack-horizon | 14:21 | |
| *** TravT has quit IRC | 14:25 | |
| *** jprovazn has quit IRC | 14:26 | |
| *** mattfarina has joined #openstack-horizon | 14:28 | |
| *** Drago has joined #openstack-horizon | 14:33 | |
| *** Piet has quit IRC | 14:34 | |
| *** Drago has quit IRC | 14:35 | |
| *** Drago has joined #openstack-horizon | 14:35 | |
| *** lblanchard has joined #openstack-horizon | 14:39 | |
| *** cbader has joined #openstack-horizon | 14:43 | |
| *** wchrisj has joined #openstack-horizon | 14:46 | |
| *** TravT has joined #openstack-horizon | 14:47 | |
| *** jprovazn has joined #openstack-horizon | 14:49 | |
| openstackgerrit | Julien Danjou proposed openstack/horizon: Replace lockfile by oslo_concurrency https://review.openstack.org/148539 | 14:49 |
| *** masco has joined #openstack-horizon | 14:50 | |
| *** vijendar has joined #openstack-horizon | 14:51 | |
| *** dboik has joined #openstack-horizon | 14:56 | |
| *** rushiagr_away is now known as rushiagr | 14:57 | |
| *** krykowski_ has joined #openstack-horizon | 14:58 | |
| *** lblanchard has quit IRC | 14:58 | |
| *** krykowski has quit IRC | 14:59 | |
| *** tosky has quit IRC | 15:00 | |
| *** tosky has joined #openstack-horizon | 15:01 | |
| *** lblanchard has joined #openstack-horizon | 15:01 | |
| *** jpomero has quit IRC | 15:02 | |
| *** jpomero has joined #openstack-horizon | 15:02 | |
| *** jpomero has quit IRC | 15:02 | |
| *** lhcheng has joined #openstack-horizon | 15:02 | |
| *** jpomero has joined #openstack-horizon | 15:03 | |
| *** josecastroleon_ has joined #openstack-horizon | 15:03 | |
| *** josecastroleon__ has joined #openstack-horizon | 15:04 | |
| *** Miouge has quit IRC | 15:07 | |
| *** josecastroleon has quit IRC | 15:07 | |
| *** josecastroleon has joined #openstack-horizon | 15:07 | |
| *** josecastroleon_ has quit IRC | 15:08 | |
| *** josecastroleon__ has quit IRC | 15:09 | |
| *** Miouge has joined #openstack-horizon | 15:12 | |
| *** lhcheng_ has joined #openstack-horizon | 15:13 | |
| *** JeanBriceCombebi has quit IRC | 15:14 | |
| openstackgerrit | Kelly Domico proposed openstack/horizon: WIP Pie and donut chart directive https://review.openstack.org/146934 | 15:16 |
| *** lhcheng has quit IRC | 15:16 | |
| *** Ctina has joined #openstack-horizon | 15:16 | |
| *** coolsvap is now known as coolsvap|afk | 15:16 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 15:17 | |
| *** Miouge has quit IRC | 15:23 | |
| *** Longgeek has quit IRC | 15:25 | |
| *** EmilyW has joined #openstack-horizon | 15:34 | |
| *** fischerw has joined #openstack-horizon | 15:34 | |
| *** Longgeek has joined #openstack-horizon | 15:35 | |
| *** lhcheng_ is now known as lhcheng | 15:35 | |
| lhcheng | akrivoka: ping | 15:36 |
| *** ayoung has joined #openstack-horizon | 15:36 | |
| *** Longgeek_ has joined #openstack-horizon | 15:37 | |
| akrivoka | lhcheng: pong | 15:37 |
| *** gyee has joined #openstack-horizon | 15:38 | |
| lhcheng | akrivoka: does tuskar-ui already include ironic node management panel? | 15:39 |
| *** masco has quit IRC | 15:40 | |
| *** Longgeek has quit IRC | 15:40 | |
| lhcheng | akrivoka: not sure if we still need this: https://review.openstack.org/#/c/117376/ | 15:40 |
| *** Miouge has joined #openstack-horizon | 15:41 | |
| *** JeanBriceCombebi has quit IRC | 15:41 | |
| akrivoka | lhcheng: it does, but it is not a general node management panel, it is specific to the tripleO use case | 15:43 |
| *** Longgeek_ has quit IRC | 15:44 | |
| *** Longgeek has joined #openstack-horizon | 15:44 | |
| rbertram | lhcheng, akrivoka: I've started looking at this too. Wondering why work stopped on it, and also https://review.openstack.org/#/c/115050/ | 15:46 |
| *** shadower has quit IRC | 15:46 | |
| *** oro has joined #openstack-horizon | 15:47 | |
| rbertram | lhcheng, akrivoka: I wondered if it moved into tuskar-ui, but sounds like not. | 15:47 |
| *** alexpilotti has joined #openstack-horizon | 15:47 | |
| lhcheng | rbertram: I wasn't sure if this just duplicates the node mgmt panel in tuskar-ui | 15:47 |
| lhcheng | rbertram: maybe we can pull it in via config, rather than moving the code. | 15:48 |
| rbertram | lhcheng: yeah, I was wondering about reuse. | 15:48 |
| rbertram | lhcheng: I'm just getting started learning about this, so no great insights (yet) | 15:49 |
| *** Longgeek has quit IRC | 15:49 | |
| akrivoka | I wasn't aware of these patches, need to look into it | 15:50 |
| *** Longgeek has joined #openstack-horizon | 15:50 | |
| lhcheng | akrivoka: maybe jcoufal have some thoughts if we still need the same panels in horizon | 15:51 |
| jcoufal | hey, hi | 15:52 |
| akrivoka | lhcheng: that was my train of thought as well :) let's see what he thinks about it | 15:52 |
| jcoufal | so, the original plan was to use tuskar-ui's panel for node management for generic node management UI for ironic | 15:52 |
| lhcheng | jcoufal: we're trying to figure out if we still need the ironic node mgmt panel in horizon | 15:52 |
| jcoufal | when I discussed with devananda all looked OK, also use-cases | 15:52 |
| jcoufal | we just said that we don't have enough power to make all the changes by ourselves | 15:53 |
| jcoufal | the patches which are above looks like duplicating effort | 15:53 |
| jcoufal | not sure how they look to be honest | 15:53 |
| *** ericpeterson has joined #openstack-horizon | 15:53 | |
| jcoufal | but a lot was already implemented | 15:53 |
| *** JeanBriceCombebi has joined #openstack-horizon | 15:54 | |
| jcoufal | so I don't think it needs to be re-implemented again | 15:54 |
| jcoufal | lhcheng: new one or tuskar-ui one? | 15:54 |
| lhcheng | jcoufal: new ones from the patch mentioned above | 15:55 |
| jcoufal | lhcheng: I don't know what the views look like and what is exact functionality | 15:55 |
| jcoufal | lhcheng: in theory, node-management section can be used without TripleO dependency | 15:56 |
| jcoufal | (since there are no TripleO APIs :) | 15:56 |
| lhcheng | jcoufal: yeah, that's what I thought too | 15:57 |
| lhcheng | the content in openstack_dashboard is for openstack services, ironic is different from functional perspective since it deals with undercloud. | 15:59 |
| jcoufal | lhcheng: there might be few small things like disable this widget if some service is missing (if it is not already there) | 15:59 |
| lhcheng | jcoufal: tuskar-ui might be a better home for it | 15:59 |
| rbertram | lhcheng: I think Ironic is in Kilo now though ,right? | 15:59 |
| jcoufal | but it shouldn't be difficult to add this type of condition | 16:00 |
| rbertram | lhcheng: if Ironic is in Kilo, does that mean Horizon support should be standard and not a plug-in? | 16:00 |
| jcoufal | rbertram: it doesn't matter, the thing is that Ironic is having different use-case than rest of the Horizon | 16:00 |
| jcoufal | rbertram: all panels are like a plugin | 16:01 |
| jcoufal | rbertram: and we need to keep some UX guidelines, not just randomly throw panels to the UI | 16:01 |
| *** athomas has quit IRC | 16:02 | |
| rbertram | ok - I have to drop now, will consider this - I understand | 16:02 |
| jcoufal | thanks | 16:02 |
| lhcheng | +1 on the different use case | 16:03 |
| *** wuhg has quit IRC | 16:04 | |
| lhcheng | jcoufal: for the path forward, we'll recommend to the author of the ironic patch in horizon to do it in tuskar then. makes sense for code and functional perspective | 16:04 |
| lhcheng | jcoufal: someone just need to do the extra work to add the service checking to make it work. | 16:05 |
| doug-fish | I thought ironic could be used to allow user level bare metal access, sitting behind nova | 16:06 |
| doug-fish | wouldn't putting it in tuskar imply it's only for adding new infrastructure? | 16:06 |
| *** athomas has joined #openstack-horizon | 16:06 | |
| jcoufal | lhcheng: it might be there, I am not sure (havn't looked into its guts for very long time) | 16:06 |
| doug-fish | I haven't looked at guts, only a picture: http://docs.openstack.org/developer/ironic/deploy/user-guide.html | 16:06 |
| jcoufal | but in order to make it independent, somebody needs to check it and add that there | 16:07 |
| jcoufal | if it is missing | 16:07 |
| jcoufal | lhcheng: but it looks like the right way forward to me | 16:07 |
| jcoufal | doug-fish: to be fair, it is just another repo at the moment, I would consider it a plugin, which can or doesn't have to be enabled if you have proper setup | 16:10 |
| jcoufal | doug-fish: what we should avoid is to throw it into horizon, saying "we need ui in order to graduate" | 16:10 |
| jcoufal | so if there are any efforts to move it forward, I would welcome anybody to join the dev under tuskar-ui and we can discuss if it needs to move somwhere else in order to support other use-cases | 16:11 |
| lhcheng | doug-fish: tuskar have panel related to infra, and the node mgmt piece of ironic seems more related to that | 16:11 |
| jcoufal | not to duplicate what was already done | 16:11 |
| doug-fish | jcoufal: sure - I've actually gotten some questions related to a Ironic UI in Horizon, I don't think it was motivated by graduation | 16:11 |
| jcoufal | doug-fish: and btw, tuskar-ui is not only about setting up a new infrastructure, it is also ongoing management | 16:12 |
| doug-fish | lhcheng: I think Ironic is more than infrastructure -I know that's an important use case, but my understanding is that bare metal can be made available to end users via nova as well | 16:12 |
| jcoufal | actually anything what is infrastructure related | 16:12 |
| *** Longgeek_ has joined #openstack-horizon | 16:13 | |
| doug-fish | jcoufal: would you define providing a bare metal server to an end user as "infrastructure"? | 16:13 |
| jcoufal | doug-fish: still you are accessing different layer of your cloud | 16:13 |
| * doug-fish thinking | 16:13 | |
| jcoufal | doug-fish: right | 16:13 |
| jcoufal | I got your point | 16:13 |
| jcoufal | well, then I want to know concrete use cases of what the user is going to do with the BM | 16:14 |
| doug-fish | I know little about the use case so far | 16:14 |
| doug-fish | :-) | 16:14 |
| *** ttrifonov is now known as zz_ttrifonov | 16:14 | |
| jcoufal | well, exactly :) | 16:14 |
| jcoufal | so it all depends on that use cases | 16:14 |
| doug-fish | It's hard to know if what we are doing will work when we don't quite know the need | 16:14 |
| *** Longgeek has quit IRC | 16:14 | |
| jcoufal | maybe restricted UI might work and user can take advantage of current node management UI | 16:15 |
| jcoufal | and if that's the case just move the panel somwhere else in customziations | 16:15 |
| openstackgerrit | Brian Fischer proposed openstack/horizon: Update to horizon tutorial.rst https://review.openstack.org/145870 | 16:15 |
| lhcheng | doug-fish: but the user doesn't interact directly with ironic api, it is that nova-compute talks to the ironic api. | 16:15 |
| doug-fish | lhcheng: right | 16:15 |
| *** krykowski_ has quit IRC | 16:16 | |
| *** Longgeek has joined #openstack-horizon | 16:16 | |
| doug-fish | (and glance and neutron too, I think) | 16:16 |
| *** zz_ttrifonov is now known as ttrifonov | 16:16 | |
| *** rdopiera has quit IRC | 16:16 | |
| jcoufal | need to run, sorry | 16:16 |
| doug-fish | bye! | 16:17 |
| jcoufal | we can definitely discuss some other time ;) | 16:17 |
| lhcheng | bye! | 16:17 |
| doug-fish | yeah, I can discuss more intelligently once I have some idea of the use case! | 16:17 |
| *** jcoufal has quit IRC | 16:17 | |
| lhcheng | doug-fish: I need to dig into that too :) | 16:18 |
| *** dkorn has joined #openstack-horizon | 16:18 | |
| lhcheng | I'll try to ask around from ironic folks here | 16:18 |
| doug-fish | yeah that would be great. I'm not sure I know any ironic people (well, not yet) | 16:19 |
| *** Longgeek_ has quit IRC | 16:19 | |
| *** Anticimex has quit IRC | 16:23 | |
| *** oro has quit IRC | 16:27 | |
| *** dboik has quit IRC | 16:30 | |
| openstackgerrit | Nikunj Aggarwal proposed openstack/horizon: Improves the error message on network deletion https://review.openstack.org/131704 | 16:30 |
| openstackgerrit | Christian Berendt proposed openstack/horizon: Fix PEP8 issues in the panel template https://review.openstack.org/146798 | 16:34 |
| *** Anticimex has joined #openstack-horizon | 16:40 | |
| openstackgerrit | Nikunj Aggarwal proposed openstack/horizon: Create a "Identity Projects details" page https://review.openstack.org/134476 | 16:46 |
| *** ygbo has quit IRC | 16:49 | |
| *** Ala has quit IRC | 16:50 | |
| *** dboik has joined #openstack-horizon | 16:52 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Updated from global requirements https://review.openstack.org/148633 | 16:52 |
| *** JeanBriceCombebi has quit IRC | 16:55 | |
| openstackgerrit | Nikunj Aggarwal proposed openstack/horizon: Changes Create & Edit Identity->Projects Forms into Horizontal Forms https://review.openstack.org/146314 | 17:00 |
| *** trown is now known as trown|lunch | 17:01 | |
| *** MaxV has quit IRC | 17:07 | |
| *** ftcjeff has joined #openstack-horizon | 17:08 | |
| *** rwsu has joined #openstack-horizon | 17:08 | |
| *** markus_z has quit IRC | 17:08 | |
| *** ftcjeff has quit IRC | 17:08 | |
| openstackgerrit | Nikunj Aggarwal proposed openstack/horizon: Adds asterisk symbol for image location https://review.openstack.org/124712 | 17:10 |
| openstackgerrit | Imran Hayder Malik proposed openstack/horizon: Fix grammatical mistake in contributing.rst doc https://review.openstack.org/148649 | 17:11 |
| *** nlahouti has joined #openstack-horizon | 17:11 | |
| openstackgerrit | George Peristerakis proposed openstack/horizon: Generate a drop down field for custom heat parameters https://review.openstack.org/133270 | 17:12 |
| *** tqtran has joined #openstack-horizon | 17:15 | |
| *** obutenko has quit IRC | 17:15 | |
| *** rushiagr is now known as rushiagr_away | 17:17 | |
| *** EmilyW has quit IRC | 17:20 | |
| *** EmilyW has joined #openstack-horizon | 17:20 | |
| *** sayan has joined #openstack-horizon | 17:27 | |
| *** oro has joined #openstack-horizon | 17:29 | |
| *** sbfox has joined #openstack-horizon | 17:30 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Consolidating conf and scripts https://review.openstack.org/141457 | 17:30 |
| *** clu_ has joined #openstack-horizon | 17:32 | |
| *** jpich has quit IRC | 17:33 | |
| openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Add integration tests for Identity->Projects page https://review.openstack.org/110919 | 17:35 |
| *** oro has quit IRC | 17:41 | |
| *** athomas has quit IRC | 17:44 | |
| *** dboik has quit IRC | 17:44 | |
| *** sqchen has joined #openstack-horizon | 17:49 | |
| TravT | tqtran: are you there? | 17:50 |
| tqtran | yep | 17:50 |
| sqchen | Hi | 17:50 |
| TravT | so, to make it easier to work with the wizards, we think we need to add a dependency chain | 17:51 |
| TravT | https://review.openstack.org/#/c/137417/ | 17:51 |
| TravT | now that sqchen broke out the help panel: https://review.openstack.org/#/c/148031/ | 17:51 |
| TravT | to create the launch instance wizard, it needs to depend on both (and more unfortunately) | 17:52 |
| TravT | but, thinking of making the reusable wizard component be dependent on the help panel, just to help with dependency chains. | 17:52 |
| TravT | so help panel --> reusable wizard --> launch instance | 17:52 |
| *** athomas has joined #openstack-horizon | 17:53 | |
| TravT | other alternative would be for people pulling to make use of review -x to merge multiple patches locally. | 17:53 |
| TravT | any feedback? | 17:53 |
| tqtran | i think keep them separate for now, and in the demo patch, just pull in all the dependent patches (dont have to chain them). I just wanted to get an idea of how it is use. | 17:53 |
| *** tnovacik has joined #openstack-horizon | 17:53 | |
| tqtran | the demo patch isnt going to get merge anyway, its really just to showcase | 17:53 |
| TravT | true for demo patch. | 17:54 |
| tqtran | so this way, one can just git fetch the demo patch to see how it works | 17:54 |
| TravT | well, if we can get a demo patch rolled and good enough to get the others merged up | 17:54 |
| *** aix has quit IRC | 17:55 | |
| sqchen | Thai’s way would be much easier for me. | 17:55 |
| tqtran | im fine with either, whatever makes it easier. as long as instructions are included | 17:55 |
| TravT | ok. so we can put a couple steps in the commit message | 17:55 |
| TravT | e.g. review -d <demoPatch)> then review -x 148031 | 17:56 |
| *** dboik has joined #openstack-horizon | 17:56 | |
| tqtran | sure, sounds good | 17:57 |
| TravT | thanks | 17:57 |
| sqchen | Ok. | 17:57 |
| *** ttrifonov is now known as zz_ttrifonov | 17:58 | |
| *** sbfox has quit IRC | 17:58 | |
| *** 18VABY19Z is now known as kmartin | 17:59 | |
| *** dboik has quit IRC | 17:59 | |
| *** dboik has joined #openstack-horizon | 17:59 | |
| *** coolsvap|afk has quit IRC | 18:00 | |
| *** pcaruana has quit IRC | 18:00 | |
| ongk | tqtran: got a moment to chat about tables? | 18:00 |
| tqtran | ongk: sure | 18:00 |
| ongk | were you able to take a look at my comment about the action column? | 18:01 |
| tqtran | yes briefly looked at it, let me re-read | 18:02 |
| tqtran | is it possible for you to show me what you mean? | 18:03 |
| *** bpokorny has joined #openstack-horizon | 18:04 | |
| *** ybathia has joined #openstack-horizon | 18:04 | |
| ongk | sure. hangouts/ | 18:04 |
| ongk | ? | 18:04 |
| *** tnovacik has quit IRC | 18:04 | |
| tqtran | yep | 18:04 |
| *** sqchen has quit IRC | 18:05 | |
| *** oro has joined #openstack-horizon | 18:05 | |
| openstackgerrit | Imran Hayder Malik proposed openstack/horizon: Fix grammatical mistake in contributing.rst doc https://review.openstack.org/148649 | 18:05 |
| *** Sukhdev has joined #openstack-horizon | 18:06 | |
| *** e0ne has quit IRC | 18:08 | |
| *** chlong has quit IRC | 18:08 | |
| *** sbfox has joined #openstack-horizon | 18:11 | |
| *** romainh has left #openstack-horizon | 18:15 | |
| openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Fix grammatical mistake in contributing.rst doc https://review.openstack.org/148649 | 18:15 |
| *** mpavlase has joined #openstack-horizon | 18:16 | |
| openstackgerrit | Doug Fish proposed openstack/horizon: Pseudo translation tool https://review.openstack.org/142239 | 18:16 |
| mpavlase | dkorn: Hi o/ | 18:17 |
| *** harlowja_away is now known as harlowja | 18:24 | |
| openstackgerrit | Chad Roberts proposed openstack/horizon: Guided cluster creation mode for Sahara https://review.openstack.org/147677 | 18:24 |
| openstackgerrit | Doug Fish proposed openstack/horizon: Pseudo translation tool https://review.openstack.org/142239 | 18:25 |
| *** robcresswell has joined #openstack-horizon | 18:25 | |
| vhoward | this one has been sitting for 2 weeks, if anyone has a moment to take a look i'd appreciate it: https://review.openstack.org/#/c/142599/ | 18:25 |
| vhoward | do you typically just put a comment for recheck to make reviews more visible? | 18:26 |
| *** Longgeek has quit IRC | 18:26 | |
| openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Fix grammatical mistake in contributing.rst doc https://review.openstack.org/148649 | 18:26 |
| *** gyee has quit IRC | 18:30 | |
| *** mpavlase has quit IRC | 18:30 | |
| *** bpokorny_ has joined #openstack-horizon | 18:31 | |
| openstackgerrit | Tomáš Nová?ik proposed openstack/horizon: Adding -ac and -noreset arguments to Xvfb https://review.openstack.org/148300 | 18:32 |
| *** lhcheng has quit IRC | 18:34 | |
| *** bpokorny has quit IRC | 18:34 | |
| *** sivy has joined #openstack-horizon | 18:34 | |
| *** sqchen has joined #openstack-horizon | 18:37 | |
| robcresswell | vhoward: recheck just runs Jenkins and other tests again, as far as I am aware. Jenkins gets many false positives :) | 18:38 |
| *** dsneddon has quit IRC | 18:39 | |
| vhoward | maybe i'll try just putting a comment for a recheck, i think it only needs core now | 18:39 |
| vhoward | to take a look | 18:39 |
| *** dsneddon has joined #openstack-horizon | 18:39 | |
| *** bpokorny has joined #openstack-horizon | 18:40 | |
| robcresswell | vhoward: It already has +1 from Jenkins | 18:40 |
| robcresswell | vhoward: So recheck would not cause anything | 18:40 |
| *** crobertsrh has quit IRC | 18:41 | |
| robcresswell | vhoward: Needs more +1s really as well, cores tend to look over things when they have more community approval :) But yes, strictly speaking, it just needs core reviews and workflow. | 18:42 |
| vhoward | thanks for the help | 18:43 |
| *** bpokorny_ has quit IRC | 18:43 | |
| sivy | g'day all | 18:43 |
| robcresswell | vhoward: No problem :) I went to review but seems I've already given it +1. | 18:47 |
| robcresswell | sivy: o/ | 18:47 |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Create a reusable angular based wizard https://review.openstack.org/137417 | 18:49 |
| robcresswell | clear | 18:49 |
| robcresswell | oops. | 18:49 |
| bluex-pl | sqchen: updated the wizard | 18:51 |
| *** salty has joined #openstack-horizon | 18:51 | |
| *** salty is now known as Guest98264 | 18:52 | |
| sqchen | Thank | 18:52 |
| bluex-pl | some info: it's bootstrap-ed as much as possible | 18:54 |
| *** oro has quit IRC | 18:55 | |
| bluex-pl | so left navigation panel width is % based with grid rather than absolute | 18:55 |
| bluex-pl | both header and footer height auto-scales depending on content, try not to change that | 18:59 |
| *** dsneddon has quit IRC | 18:59 | |
| *** oro has joined #openstack-horizon | 18:59 | |
| *** dsneddon has joined #openstack-horizon | 19:00 | |
| *** tosky_ has joined #openstack-horizon | 19:07 | |
| *** jtomasek has quit IRC | 19:09 | |
| openstackgerrit | Doug Fish proposed openstack/horizon: Pseudo translation tool https://review.openstack.org/142239 | 19:09 |
| *** tosky has quit IRC | 19:09 | |
| *** lsmola has quit IRC | 19:09 | |
| *** Drago has quit IRC | 19:10 | |
| *** bluex-pl has quit IRC | 19:11 | |
| *** Drago has joined #openstack-horizon | 19:11 | |
| *** packet has joined #openstack-horizon | 19:16 | |
| *** dkorn has quit IRC | 19:17 | |
| *** dsneddon has quit IRC | 19:20 | |
| *** dsneddon has joined #openstack-horizon | 19:21 | |
| *** Sukhdev has quit IRC | 19:23 | |
| *** lsmola has joined #openstack-horizon | 19:23 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: move Users Edit Password into separate form https://review.openstack.org/141489 | 19:27 |
| *** Piet has joined #openstack-horizon | 19:27 | |
| *** tosky_ has quit IRC | 19:29 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: move Users Edit Password into separate form https://review.openstack.org/141489 | 19:32 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: move Users Edit Password into separate form https://review.openstack.org/141489 | 19:35 |
| *** trown|lunch is now known as trown | 19:36 | |
| *** mrunge has joined #openstack-horizon | 19:37 | |
| *** david-lyle has quit IRC | 19:37 | |
| *** dsneddon has quit IRC | 19:41 | |
| *** crobertsrh has joined #openstack-horizon | 19:41 | |
| *** vijendar has quit IRC | 19:48 | |
| *** Sukhdev has joined #openstack-horizon | 19:50 | |
| *** lhcheng has joined #openstack-horizon | 19:59 | |
| *** lhcheng_ has joined #openstack-horizon | 20:01 | |
| *** lhcheng has quit IRC | 20:04 | |
| *** ZZelle_ has joined #openstack-horizon | 20:07 | |
| *** gyee has joined #openstack-horizon | 20:10 | |
| *** lhcheng_ is now known as lhcheng | 20:12 | |
| lhcheng | tqtran: ping | 20:12 |
| tqtran | lhcheng: pong | 20:12 |
| lhcheng | tqtran: did you run the integration test in ubuntu? | 20:13 |
| tqtran | lhcheng: yes | 20:13 |
| lhcheng | tqtran: can you try this patch too? :) https://review.openstack.org/#/c/148300/ | 20:13 |
| tqtran | lhcheng: i managed to get it working for master locally, but it looks like a lot of patches are running into the same issue | 20:13 |
| *** dboik has quit IRC | 20:14 | |
| lhcheng | tqtran: this patch might solve the issue | 20:14 |
| *** akrivoka has quit IRC | 20:14 | |
| tqtran | lhcheng: yeah, that would be great, let me pull it down and try | 20:14 |
| *** dboik has joined #openstack-horizon | 20:14 | |
| lhcheng | tqtran: I was planning to test in ubuntu, but I haven't set it up. Then saw you just run the integration test :P | 20:15 |
| lhcheng | lhcheng: thanks :D | 20:15 |
| tqtran | haha np | 20:15 |
| *** dboik has quit IRC | 20:20 | |
| *** dboik_ has joined #openstack-horizon | 20:20 | |
| *** Drago1 has joined #openstack-horizon | 20:22 | |
| *** Drago has quit IRC | 20:22 | |
| *** vijendar has joined #openstack-horizon | 20:28 | |
| *** radez is now known as radez_g0n3 | 20:30 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Fixes inconsistent Edit between tables & details https://review.openstack.org/146330 | 20:32 |
| tqtran | lhcheng: just ran it with and without the patch, its passing locally for me. let me try applying the patch on top of another patch that i know is failing and see if that fixes it. | 20:33 |
| *** ybathia has quit IRC | 20:33 | |
| lhcheng | tqtran: cool, thanks! hope that patch fixes the issue too! | 20:34 |
| tqtran | i'll be able to tell you in like 20m lol, these damn tests take forever to run | 20:35 |
| *** TravT has quit IRC | 20:40 | |
| *** mrunge has quit IRC | 20:41 | |
| *** TravT has joined #openstack-horizon | 20:41 | |
| lhcheng | tqtran: maybe running it as headless make it faster? | 20:43 |
| tqtran | yes it does | 20:43 |
| lhcheng | and that's still 20m? | 20:44 |
| tqtran | let me time it | 20:44 |
| lhcheng | 20m of the gate job is sponsored by horizon lol | 20:45 |
| tqtran | lol | 20:45 |
| *** TravT has quit IRC | 20:46 | |
| tqtran | 123 | 20:47 |
| tqtran | its super fast with headless actually | 20:48 |
| tqtran | but error details isnt as good | 20:48 |
| *** dboik_ has quit IRC | 20:51 | |
| *** dboik has joined #openstack-horizon | 20:51 | |
| *** jprovazn has quit IRC | 20:51 | |
| *** TravT has joined #openstack-horizon | 20:52 | |
| *** TravT has quit IRC | 20:52 | |
| *** TravT has joined #openstack-horizon | 20:52 | |
| *** nlahouti has quit IRC | 20:53 | |
| *** jprovazn has joined #openstack-horizon | 20:57 | |
| tqtran | lhcheng: ok heres another interesting issue with integration test. https://review.openstack.org/#/c/140932/ and https://review.openstack.org/#/c/137417/ I can't seem to figure out whats causing it all to error out. Looks fine when I manually test it by hand. But for whatever reason, its not finding the elements in the integration test. | 20:57 |
| *** raildo has quit IRC | 20:57 | |
| tqtran | lhcheng: as for the Tomas's patch, I cant determine if it fixes the issue, since it passes for master with and without the patch | 20:58 |
| *** bpokorny_ has joined #openstack-horizon | 21:00 | |
| *** sayan has quit IRC | 21:01 | |
| *** bpokorny has quit IRC | 21:03 | |
| *** dboik has quit IRC | 21:03 | |
| *** dboik has joined #openstack-horizon | 21:03 | |
| *** ybathia has joined #openstack-horizon | 21:07 | |
| *** radez_g0n3 is now known as radez | 21:13 | |
| lhcheng | tqtran: Tomas needed some help to validate the patch doesn't cause regression in ubuntu, since he only have a redhat env. | 21:14 |
| lhcheng | tqtran: as long it still works, it's good for me. thanks for trying it out. | 21:14 |
| tqtran | i see, well it works fine in regular mode | 21:14 |
| *** jprovazn has quit IRC | 21:14 | |
| tqtran | i noticed that headless doesnt work too well, its failing with this error: OSError: [Errno 2] No such file or directory | 21:15 |
| lhcheng | ah, have you install xvfb? | 21:16 |
| lhcheng | I hit this issue yesterday (face palm) | 21:16 |
| tqtran | lol probably not | 21:16 |
| tqtran | yeah i dont have it installed.... | 21:18 |
| *** oro has quit IRC | 21:28 | |
| mattfarina | tqtran if you have a moment, i'm curious what you think of a cleanup like https://bugs.launchpad.net/horizon/+bug/1412971 | 21:31 |
| *** julim has quit IRC | 21:32 | |
| lhcheng | tqtran: we both him the same issue, probably worth documenting about the additional installation. I'll open a bug. | 21:33 |
| tqtran | mattfarina: it make sense to save it to a variable and reuse $(document) if we enclose the entire thing inside a function closure. Furthermore, we actually don't even need the document object given that most of them are search by ID. | 21:35 |
| tqtran | mattfarina: example: https://github.com/openstack/horizon/blob/1385db8d1f8358aca190a40ed4c341bfc3e46f56/horizon/static/horizon/js/horizon.instances.js#L155 | 21:35 |
| tqtran | mattfarina: can be rewritten as $('#tail_length').on('submit', function(e){...}); | 21:35 |
| mattfarina | tqtran in this case, jquery puts the event handler on document and uses event bubbling. That way stuff injected into the page will always work. | 21:36 |
| mattfarina | if #tail_length is added by js it will still work if on the document | 21:36 |
| robcresswell | mattfarina: I'd love to see that kind of cleanup. I've been looking into starting a blueprint for wider cleanup efforts regarding consistency and multiple api calls/ js calls etc | 21:36 |
| tqtran | i see..... | 21:36 |
| robcresswell | I'm curious though, why do we still use jquery? There seems to be jquery-ui elements, which seems odd when we have bootstrap, and we used jquery itself, which seems odd since I thought angular packaged jqlite? | 21:37 |
| mattfarina | robcresswell i was thinking of a wider cleanup but then it's hard to say when something is complete. i tried to keep this to a defined scope | 21:37 |
| mattfarina | robcresswell we have jquery, jquery ui, bootstrap, and angular. :) | 21:38 |
| tqtran | robcresswell: this is legacy stuff, jqlite only works if you're using angular | 21:38 |
| tqtran | robcresswell: and in this case, we're not using angular | 21:38 |
| robcresswell | mattfarina: Agreed, it seems like a sensible move. I was looking into cleaning up all the imports in a separate bug. Debating it with colleagues offline. | 21:38 |
| robcresswell | tqtran: Long term though, is angular to be used across all of openstack_dashboard? | 21:38 |
| tqtran | mattfarina: i would be open to the idea if we also encase the entire thing inside a (function(){....})(); scope | 21:39 |
| *** neelashah has quit IRC | 21:39 | |
| tqtran | robcresswell: yes, long term it will replace everything | 21:39 |
| tqtran | robcresswell: but until then, we're stuck with using both | 21:39 |
| robcresswell | tqtran: Understood | 21:39 |
| mattfarina | tqtran i'd definitely want to keep things scoped cleanly so there was no leading anywhere | 21:39 |
| tqtran | mattfarina: sounds great! I actually wanted to clean up the JS files for sometime now | 21:40 |
| mattfarina | i'm looking into minification and different closure wrappers | 21:40 |
| mattfarina | i want to see some data. i've not done an analysis on horizon yet | 21:40 |
| tqtran | lhcheng: yeah, i think that should be documented, i didnt know about it until you mentioned it =P | 21:41 |
| lhcheng | I didn't know either, Tomas helped me out yesterday :) | 21:41 |
| mattfarina | for something like https://github.com/openstack/horizon/blob/1385db8d1f8358aca190a40ed4c341bfc3e46f56/horizon/static/horizon/js/horizon.instances.js#L154 ... everything is inside a function/closure | 21:41 |
| tqtran | mattfarina: yes, but doesnt make sense to have $(document) to a variable if its only use once | 21:42 |
| tqtran | s/have/save | 21:42 |
| mattfarina | right | 21:42 |
| mattfarina | only if it's used 2 or more times in a given scope | 21:42 |
| mattfarina | and kept locally | 21:42 |
| tqtran | mattfarina: and tbh, i think $(document) is probably very minimal. I believe jquery just uses document.blah underneath, but i'll have to verify by looking at source | 21:43 |
| tqtran | mattfarina: something like $("div.someclass") is probably a lot more expensive because jquery has to traverse dom tree to find it | 21:44 |
| tqtran | mattfarina: then generate some kind of hash for it to easily locate later | 21:44 |
| openstackgerrit | George Peristerakis proposed openstack/horizon: Generate a drop down field for custom heat parameters https://review.openstack.org/133270 | 21:46 |
| *** ayoung has quit IRC | 21:47 | |
| *** Sukhdev has quit IRC | 21:50 | |
| *** nlahouti has joined #openstack-horizon | 21:51 | |
| mattfarina | tqtran $(document) is maybe the fastest one, you're right. but, jquery objects aren't small and you create and GC them. it's a hit. | 21:52 |
| tqtran | mattfarina: sure, i agree that its an improvement for sure. just pointing that the other searches are probably even more expensive | 21:52 |
| mattfarina | yeah. we should fix all the searches! | 21:53 |
| tqtran | mattfarina: so if we're going to do it for document, might be worthwhile to look at the others as well, yep... | 21:53 |
| mattfarina | actually, wchrisj is working on one today that can cause a page, under some circumstances, to pause for seconds when typing | 21:53 |
| *** ayoung has joined #openstack-horizon | 21:53 | |
| tqtran | oh wow.... | 21:53 |
| mattfarina | you need just the right conditions. he's working on a fix that will explain better than I can in irc | 21:54 |
| mattfarina | i was poking at how jquery worked to figure it out | 21:54 |
| *** mpavlase has joined #openstack-horizon | 21:55 | |
| *** oro has joined #openstack-horizon | 21:56 | |
| openstackgerrit | Sam Betts proposed openstack/horizon: Store user settings cookie data with UID https://review.openstack.org/118334 | 22:05 |
| *** lblanchard has quit IRC | 22:06 | |
| *** EmilyW has quit IRC | 22:06 | |
| *** fischerw has quit IRC | 22:10 | |
| *** dsneddon has joined #openstack-horizon | 22:11 | |
| *** sqchen has quit IRC | 22:12 | |
| *** e0ne has joined #openstack-horizon | 22:19 | |
| *** neelashah has joined #openstack-horizon | 22:23 | |
| *** bpokorny has joined #openstack-horizon | 22:25 | |
| *** dsneddon has quit IRC | 22:27 | |
| *** mattfarina has quit IRC | 22:27 | |
| *** dsneddon has joined #openstack-horizon | 22:28 | |
| *** bpokorny_ has quit IRC | 22:29 | |
| openstackgerrit | Merged openstack/horizon: Fix grammatical mistake in contributing.rst doc https://review.openstack.org/148649 | 22:32 |
| *** crobertsrh has quit IRC | 22:33 | |
| *** Ctina_ has joined #openstack-horizon | 22:36 | |
| *** jpomero has quit IRC | 22:38 | |
| *** sqchen has joined #openstack-horizon | 22:39 | |
| *** Ctina has quit IRC | 22:40 | |
| openstackgerrit | Eric Peterson proposed openstack/django_openstack_auth: Store cookies using UID https://review.openstack.org/133540 | 22:40 |
| *** Sukhdev has joined #openstack-horizon | 22:41 | |
| *** Ctina_ has quit IRC | 22:41 | |
| ericpeterson | lhcheng that change above is to coordinate with a similar change by sambetts on using the user id for unique cookie keys (fyi) | 22:42 |
| ericpeterson | it used to be the change for making region and project sticky | 22:43 |
| *** sqchen has quit IRC | 22:43 | |
| lhcheng | ericpeterson: ah you re-used an existing patch, removed the -2. | 22:44 |
| *** Drago1 has quit IRC | 22:44 | |
| ericpeterson | I think there is still some debate to be had, on if using a cookie with the value of a user id - and then storing a complex json object as the value within there - if that is really what we want or not | 22:45 |
| ericpeterson | but I had talked with sam in Paris and promised I'd support his ticket by doing the changes in DOA | 22:45 |
| lhcheng | ah, not sure if we want to store all settings in one json cookie. eventually it will hit the cookie limit. | 22:47 |
| *** dsneddon has quit IRC | 22:48 | |
| *** dsneddon has joined #openstack-horizon | 22:49 | |
| *** gyee has quit IRC | 22:53 | |
| *** gyee has joined #openstack-horizon | 22:54 | |
| *** Piet has quit IRC | 22:54 | |
| *** sqchen has joined #openstack-horizon | 22:57 | |
| *** sivy has quit IRC | 23:00 | |
| *** dboik has quit IRC | 23:01 | |
| *** neelashah has quit IRC | 23:01 | |
| *** oro has quit IRC | 23:05 | |
| *** gyee has quit IRC | 23:06 | |
| *** dsneddon has quit IRC | 23:08 | |
| *** dsneddon has joined #openstack-horizon | 23:09 | |
| *** ZZelle has quit IRC | 23:10 | |
| *** ZZelle has joined #openstack-horizon | 23:10 | |
| ericpeterson | lhcheng - you won't really run out of space, unless you have several people sharing a machine / browser and we add a bunch more settings in our cookies | 23:11 |
| *** mpavlase has quit IRC | 23:11 | |
| ericpeterson | and I'd assume that no one is using cookie backed sessions anymore | 23:12 |
| lifeless | ericpeterson: if its still in the code, someone is using it :/ | 23:14 |
| *** ZZelle_ has quit IRC | 23:14 | |
| *** lhcheng has quit IRC | 23:15 | |
| *** dsneddon has quit IRC | 23:29 | |
| *** dsneddon has joined #openstack-horizon | 23:30 | |
| *** ZZelle_ has joined #openstack-horizon | 23:35 | |
| *** jamielennox|away is now known as jamielennox | 23:36 | |
| *** chlong has joined #openstack-horizon | 23:40 | |
| *** vijendar has quit IRC | 23:41 | |
| *** e0ne has quit IRC | 23:42 | |
| *** peristeri has quit IRC | 23:44 | |
| *** chlong has quit IRC | 23:45 | |
| *** chlong has joined #openstack-horizon | 23:46 | |
| *** ericpeterson has quit IRC | 23:46 | |
| *** dsneddon has quit IRC | 23:50 | |
| *** nlahouti has quit IRC | 23:50 | |
| *** dsneddon has joined #openstack-horizon | 23:51 | |
| *** sambetts has joined #openstack-horizon | 23:53 | |
| *** ZZelle_ has quit IRC | 23:56 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: revise settings doc with Font Awesome reference https://review.openstack.org/148751 | 23:58 |
| *** ayoung has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!