| *** ericpeterson has quit IRC | 00:02 | |
| *** hurgleburgler has quit IRC | 00:03 | |
| clu_ | clu_ | 00:05 |
|---|---|---|
| r1chardj0n3s | tqtran: if you're around, what's your pypi username? | 00:05 |
| *** tosky has quit IRC | 00:06 | |
| tqtran | r1chardj0n3s: let me check | 00:07 |
| tqtran | r1chardj0n3s: login.launchpad.net_92 | 00:08 |
| r1chardj0n3s | I'll add you to https://pypi.python.org/pypi/XStatic-angular-ui and https://pypi.python.org/pypi/XStatic-smart-table | 00:08 |
| *** EmilyW has quit IRC | 00:08 | |
| tqtran | haha sure | 00:08 |
| r1chardj0n3s | (which are, obvs. now done ;) | 00:08 |
| tqtran | awesome, now we need to add to requirements | 00:09 |
| r1chardj0n3s | tox -e xstatic angular-smart-table | 00:09 |
| r1chardj0n3s | cd xstatic_packages/angular_smart_table/ | 00:09 |
| r1chardj0n3s | python setup.py sdist bdist_wheel upload --sign | 00:09 |
| tqtran | <--- not a python expert, so i have no idea what you just did lol | 00:10 |
| doug-fish | david-lyle: I've taken a look at your comments on https://review.openstack.org/#/c/136056/ and I don't think I see your vision. I've tried to outline my confusion in the review. If you have time to look again I'd appreciate it. | 00:10 |
| doug-fish | tqtran, your thoughts would be helpful as well! | 00:11 |
| openstackgerrit | Gary W. Smith proposed openstack/horizon: Add support for volume transfers https://review.openstack.org/112741 | 00:11 |
| openstackgerrit | Merged openstack/horizon: Update metering unit selection to use smaller units for time https://review.openstack.org/130336 | 00:11 |
| tqtran | doug-fish: you would still need to modify the individual views to inject the page_title context | 00:12 |
| openstackgerrit | Merged openstack/horizon: Updated from global requirements https://review.openstack.org/139206 | 00:12 |
| *** dkorn has joined #openstack-horizon | 00:12 | |
| tqtran | doug-fish: but the HTML can be modified at the base level, so it affects all headers | 00:12 |
| doug-fish | tqtran: is the suggestion to change how the page_title is set for all 190-ish instances? | 00:13 |
| tqtran | dough-fish: which leads to your question, what about the pages that dont have them? | 00:14 |
| tqtran | dough-fish: well for those pages, they all have base view classes: table, tab, modal, etc... | 00:14 |
| tqtran | doug-fish: god... im mispelling your name | 00:15 |
| doug-fish | :-) not the first time I've seen that one | 00:15 |
| doug-fish | I really don't want to change _all_ of those pages: that seem way out of scope. | 00:15 |
| tqtran | doug-fish: hm.. let me take another look, i think i get what you're trying to say | 00:16 |
| doug-fish | sure, I appreicate it. I'm about to pack up for the day and I'll be out tomorrow. So no rush. | 00:17 |
| tqtran | doug-fish: ok quick question before you head out | 00:18 |
| doug-fish | sure | 00:18 |
| *** openstackgerrit has quit IRC | 00:18 | |
| tqtran | doug-fish: so for views you did not modify, how/where are the page header define? | 00:19 |
| *** openstackgerrit has joined #openstack-horizon | 00:19 | |
| tqtran | doug-fish: i could research that, but since you're here =P | 00:19 |
| doug-fish | It's passed in from the template directly | 00:19 |
| doug-fish | let me find one ... | 00:19 |
| doug-fish | This is the typical static pattern: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/routers/templates/routers/index.html#L6 | 00:20 |
| tqtran | doug-fish: ok i get it now. jumped to conclusion as always lol | 00:23 |
| doug-fish | BTW, since you're here, would be great to get your thoughts on https://review.openstack.org/#/c/130413/ as well. It uses angular! | 00:23 |
| tqtran | doug-fish: ok, i'll take a look | 00:23 |
| doug-fish | There are 3 people who suggested some sort of refactor on that code; maybe there is an opportunity, but I haven't been able to sort it out. | 00:23 |
| doug-fish | (the first one) | 00:23 |
| doug-fish | If https://review.openstack.org/#/c/130413/ looks good I plan to use a similar pattern to make the dates configurable | 00:24 |
| *** colinmcnamara has joined #openstack-horizon | 00:25 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add new angular dependencies to requirements.txt https://review.openstack.org/139284 | 00:25 |
| r1chardj0n3s | tqtran: ^^ | 00:25 |
| tqtran | r1chardj0n3s: awesome blossom, i'll check it out | 00:28 |
| *** tnovacik has quit IRC | 00:35 | |
| *** vkmc has quit IRC | 00:38 | |
| david-lyle | doug-fish: will respond to review tomorrow, have to run for family time now | 00:38 |
| *** david-lyle is now known as david-lyle_afk | 00:39 | |
| *** ZZelle_ has quit IRC | 00:42 | |
| *** dkorn has quit IRC | 00:44 | |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 00:49 | |
| *** EmilyW has joined #openstack-horizon | 00:54 | |
| *** EmilyW has quit IRC | 00:58 | |
| *** dkorn has joined #openstack-horizon | 01:01 | |
| *** colinmcnamara has quit IRC | 01:02 | |
| *** dboik has joined #openstack-horizon | 01:03 | |
| *** jacalcat has quit IRC | 01:04 | |
| *** dboik_ has quit IRC | 01:05 | |
| *** dkorn has quit IRC | 01:05 | |
| *** hinnant has quit IRC | 01:06 | |
| *** TravT_ has quit IRC | 01:10 | |
| *** ongk has left #openstack-horizon | 01:13 | |
| *** packet has quit IRC | 01:24 | |
| *** dkorn has joined #openstack-horizon | 01:25 | |
| *** dkorn has quit IRC | 01:30 | |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 01:30 | |
| r1chardj0n3s | & have submitted those new angular deps to global-requirements also /cc tqtran | 01:42 |
| *** TravT has joined #openstack-horizon | 01:45 | |
| *** TravT has quit IRC | 01:49 | |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 01:51 | |
| *** clu_ has quit IRC | 02:03 | |
| *** neelashah has joined #openstack-horizon | 02:04 | |
| *** bpokorny has quit IRC | 02:06 | |
| tqtran | r1chardj0n3s: so i dowloaded the xstatic requirement, but the contents inside is structured differently than what im expecting | 02:10 |
| *** jacalcat has joined #openstack-horizon | 02:12 | |
| openstackgerrit | Merged openstack/horizon: Fix the expression to be python3 compatible. https://review.openstack.org/137212 | 02:14 |
| *** alexpilotti has joined #openstack-horizon | 02:15 | |
| *** jacalcat has quit IRC | 02:18 | |
| *** dsneddon has quit IRC | 02:30 | |
| *** dsneddon has joined #openstack-horizon | 02:31 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Create a reusable angular based wizard https://review.openstack.org/137417 | 02:38 |
| *** TravT has joined #openstack-horizon | 02:49 | |
| *** dsneddon has quit IRC | 02:51 | |
| *** dsneddon has joined #openstack-horizon | 02:52 | |
| r1chardj0n3s_afk | tqtran: his so? | 02:53 |
| r1chardj0n3s_afk | how even... | 02:53 |
| *** TravT has quit IRC | 02:54 | |
| r1chardj0n3s_afk | tqtran: yeah, I think I'm missing something, I'll need specifics :/ | 02:57 |
| tqtran | r1chardj0n3s_afk: did you follow these steps? =P https://xstatic.readthedocs.org/en/latest/packaging.html | 02:59 |
| *** jacalcat has joined #openstack-horizon | 02:59 | |
| *** lhcheng_ has quit IRC | 03:01 | |
| *** Poornima has joined #openstack-horizon | 03:01 | |
| *** wuhg has joined #openstack-horizon | 03:06 | |
| *** nlahouti has quit IRC | 03:10 | |
| *** dsneddon has quit IRC | 03:12 | |
| *** dsneddon has joined #openstack-horizon | 03:13 | |
| r1chardj0n3s_afk | tqtran: I did when I created the tool I used to create the packages | 03:14 |
| r1chardj0n3s_afk | tqtran: so I guess I missed something. Again, specific issues would be appreciated :-) | 03:15 |
| *** gyee has quit IRC | 03:25 | |
| openstackgerrit | LIU Yulong proposed openstack/horizon: Make table BatchAction help text configurable https://review.openstack.org/133241 | 03:31 |
| tqtran | r1chardj0n3s_afk: ok so basically, when i rebuild env, and i look into /xstatic/pkg/angular/ i see angular.js | 03:33 |
| *** dsneddon has quit IRC | 03:33 | |
| tqtran | r1chardj0n3s_afk: but when i look into /xstatic/pkg/angular-ui/ i see the file structure from the git repo | 03:33 |
| r1chardj0n3s_afk | Yes, xstatic_bower includes everything from the bower package, which is most of the git repo | 03:34 |
| *** dsneddon has joined #openstack-horizon | 03:34 | |
| tqtran | r1chardj0n3s_afk: so according to this, https://xstatic.readthedocs.org/en/latest/using.html, it taps into xtastic.pkg and redirect /static to the proper place | 03:35 |
| tqtran | r1chardj0n3s_afk: not sure how i would import the js file | 03:36 |
| *** bpokorny has joined #openstack-horizon | 03:36 | |
| tqtran | r1chardj0n3s_afk: ok, heading out for dinner, i'll read into it a bit more tonight | 03:36 |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 03:37 | |
| tqtran | r1chardj0n3s: i suspect it is ok to package like how you did, just not sure how i can reference it | 03:37 |
| r1chardj0n3s | hi, have jumped onto laptop to try to chat better :) | 03:37 |
| tqtran | r1chardj0n3s: haha ok, well, im off for a bit, bbl | 03:37 |
| *** tqtran is now known as tqtran_afk | 03:37 | |
| r1chardj0n3s | ok, have a nice dinner! | 03:37 |
| openstackgerrit | Jeremy Stanley proposed openstack/django_openstack_auth: Workflow documentation is now in infra-manual https://review.openstack.org/139319 | 03:41 |
| openstackgerrit | Jeremy Stanley proposed openstack/horizon: Workflow documentation is now in infra-manual https://review.openstack.org/139327 | 03:41 |
| openstackgerrit | Jeremy Stanley proposed openstack/tuskar-ui: Workflow documentation is now in infra-manual https://review.openstack.org/139403 | 03:52 |
| r1chardj0n3s | tqtran_afk: the path to the entry point for angular-ui is /static/horizon/lib/angular-ui/build/angular-ui.js | 03:53 |
| r1chardj0n3s | tqtran_afk: for smart-table, the bower package actually defines the entry point, so the xstatic package does as well, as the MAIN variable (so /static/horizon/lib/smart-table/dist/smart-table.min.js | 03:55 |
| r1chardj0n3s | tqtran_afk: when we transition to bower we'll be able to automatically use the bower entry point stuff directly, rather than having to stuff about like that | 03:55 |
| *** alexpilotti has quit IRC | 04:00 | |
| *** jacalcat has quit IRC | 04:09 | |
| *** dsneddon has quit IRC | 04:15 | |
| *** david-ly_ has joined #openstack-horizon | 04:15 | |
| *** masco has joined #openstack-horizon | 04:15 | |
| *** dsneddon has joined #openstack-horizon | 04:16 | |
| *** david-lyle_afk has quit IRC | 04:17 | |
| *** neillc is now known as neillc_away | 04:29 | |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon: Split large methods into submethods to reduce max-complexity https://review.openstack.org/129689 | 04:30 |
| *** lhcheng has joined #openstack-horizon | 04:31 | |
| *** doug-fish has left #openstack-horizon | 04:32 | |
| *** dsneddon has quit IRC | 04:36 | |
| *** dsneddon has joined #openstack-horizon | 04:37 | |
| *** TravT has joined #openstack-horizon | 04:54 | |
| *** dsneddon has quit IRC | 04:57 | |
| *** dsneddon has joined #openstack-horizon | 04:59 | |
| *** dboik has quit IRC | 05:04 | |
| *** sayan has joined #openstack-horizon | 05:06 | |
| *** tzumainn has quit IRC | 05:07 | |
| *** dsneddon has quit IRC | 05:18 | |
| *** dsneddon has joined #openstack-horizon | 05:20 | |
| *** sayan has quit IRC | 05:21 | |
| *** Arvinder has joined #openstack-horizon | 05:25 | |
| Arvinder | Hi everyone | 05:26 |
| *** Poornima has quit IRC | 05:26 | |
| *** hurgleburgler has joined #openstack-horizon | 05:32 | |
| tqtran_afk | r1chardj0n3s: ok im back | 05:32 |
| *** tqtran_afk is now known as tqtran | 05:32 | |
| r1chardj0n3s | hi tqtran_afk :) | 05:32 |
| tqtran | r1chardj0n3s: so i tried those entry point, none of them work | 05:32 |
| r1chardj0n3s | I'm just working on the URL stuff needed for the REST API change split ;) | 05:33 |
| r1chardj0n3s | how did they break? | 05:33 |
| r1chardj0n3s | are you using the django dev server? | 05:33 |
| tqtran | r1chardj0n3s: /static/horizon/lib/angular-ui/angular.js also tried /static/horizon/lib/angular_ui/angular.js | 05:33 |
| tqtran | yes i am | 05:33 |
| r1chardj0n3s | /static/horizon/lib/angular-ui/build/angular-ui.js | 05:33 |
| r1chardj0n3s | that's the URL | 05:33 |
| tqtran | still doesnt work | 05:34 |
| tqtran | does it work for you? | 05:34 |
| r1chardj0n3s | what, not found? | 05:34 |
| r1chardj0n3s | yes | 05:34 |
| tqtran | http://localhost:8001/static/horizon/lib/angular-ui/build/angular.js | 05:34 |
| tqtran | oh nvm | 05:34 |
| tqtran | http://localhost:8001/static/horizon/lib/angular-ui/build/angular-ui.js | 05:34 |
| tqtran | yeah, not working for me | 05:34 |
| tqtran | i can see angular/angular.js though | 05:34 |
| r1chardj0n3s | you have xstatic.pkg.angular_ui in your STATICFILES_DIRS? | 05:35 |
| r1chardj0n3s | + ('horizon/lib/angular-ui', | 05:35 |
| r1chardj0n3s | + xstatic.main.XStatic(xstatic.pkg.angular_ui).base_dir), | 05:35 |
| r1chardj0n3s | and | 05:35 |
| r1chardj0n3s | +import xstatic.pkg.angular_ui | 05:35 |
| r1chardj0n3s | ? | 05:35 |
| tqtran | this is in openstack_dashboard/settings.py? | 05:38 |
| r1chardj0n3s | yep | 05:39 |
| *** lhcheng has quit IRC | 05:39 | |
| tqtran | hm guess i dont understand it well, do i have to add code to this file everytime i add requirements? or is this auto generated at some point? | 05:40 |
| r1chardj0n3s | you have to add new staticfiles entry for each new xstatic | 05:40 |
| r1chardj0n3s | the amount of typing will reduce when we switch to bower, but you'll still need to explicitly include it | 05:41 |
| r1chardj0n3s | otherwise django has no way of knowing that some random python package actually has static files to serve in it | 05:41 |
| tqtran | so should that also be included in https://review.openstack.org/#/c/139284/ too? | 05:41 |
| r1chardj0n3s | ah, that seems reasonable, yes. I will add it to that, and then you'll base off that? | 05:42 |
| tqtran | ok works now. let me take a look at radomir's patch, i dont remember if he did something similar | 05:42 |
| Arvinder | Hi everyone... i want to start contributing towards reviewing patches | 05:45 |
| Arvinder | how can i do that | 05:46 |
| Arvinder | i new to the community | 05:46 |
| r1chardj0n3s | Arvinder: https://wiki.openstack.org/wiki/Gerrit_Workflow has the info you need to get started | 05:46 |
| tqtran | Arvinder: hello =) you can get started here http://docs.openstack.org/developer/horizon/contributing.html | 05:46 |
| *** neelashah has quit IRC | 05:47 | |
| tqtran | Arvinder: then follow r1chardj0n3s link to get setup | 05:47 |
| r1chardj0n3s | tqtran's link is a better place to start ;) | 05:47 |
| tqtran | r1chardj0n3s: make sure you make changes to horizon/test/settings.py as well richard | 05:50 |
| r1chardj0n3s | oh! ok | 05:50 |
| tqtran | then also include both scripts in https://review.openstack.org/#/c/120411/4/horizon/templates/horizon/_scripts.html or https://review.openstack.org/#/c/120411/4/horizon/templates/horizon/_conf.html | 05:50 |
| tqtran | ops.... i linked you to a patch didnt i lol | 05:51 |
| r1chardj0n3s | not a problem :) | 05:51 |
| *** Longgeek has joined #openstack-horizon | 05:52 | |
| tqtran | alrighty, i'll take a look at it again tmr, time for bed. =D gnite! | 05:53 |
| r1chardj0n3s | gnite! | 05:53 |
| *** tqtran has quit IRC | 05:53 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add new angular dependencies to requirements.txt https://review.openstack.org/139284 | 05:53 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add new angular dependencies to requirements.txt https://review.openstack.org/139284 | 05:55 |
| *** Poornima has joined #openstack-horizon | 05:56 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: REST API for angular front end. https://review.openstack.org/136676 | 05:57 |
| *** neillc_away is now known as neillc | 05:58 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/139524 | 06:07 |
| *** nikunj2512_ has joined #openstack-horizon | 06:09 | |
| *** nikunj2512_ has quit IRC | 06:09 | |
| *** nikunj2512 has joined #openstack-horizon | 06:09 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: REST API for angular front end. https://review.openstack.org/136676 | 06:12 |
| openstackgerrit | Richard Jones proposed openstack/horizon: REST API for angular front end. https://review.openstack.org/136676 | 06:14 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Keystone REST API for angular front end. https://review.openstack.org/139532 | 06:18 |
| *** mfisch has quit IRC | 06:23 | |
| *** mfisch has joined #openstack-horizon | 06:27 | |
| *** mfisch is now known as Guest45087 | 06:27 | |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 06:28 | |
| *** Longgeek has quit IRC | 06:30 | |
| *** Longgeek has joined #openstack-horizon | 06:32 | |
| *** hurgleburgler has quit IRC | 06:33 | |
| *** Arvinder has quit IRC | 06:39 | |
| *** Arvinder has joined #openstack-horizon | 06:40 | |
| *** nlahouti has joined #openstack-horizon | 06:41 | |
| *** nlahouti has quit IRC | 06:45 | |
| *** nlahouti has joined #openstack-horizon | 06:45 | |
| *** openstackgerrit has quit IRC | 06:49 | |
| *** openstackgerrit has joined #openstack-horizon | 06:49 | |
| *** den9ie has quit IRC | 06:52 | |
| *** amotoki is now known as amotoki__away | 06:55 | |
| openstackgerrit | Merged openstack/horizon: Split large methods into submethods to reduce max-complexity https://review.openstack.org/129689 | 07:00 |
| openstackgerrit | Swati Shukla proposed openstack/horizon: LoadBalancers' Add Member form has missing asterisk for 'Members' list https://review.openstack.org/139546 | 07:06 |
| *** TravT has quit IRC | 07:07 | |
| *** TravT has joined #openstack-horizon | 07:12 | |
| *** zul has quit IRC | 07:14 | |
| *** TravT has quit IRC | 07:16 | |
| *** mrunge has joined #openstack-horizon | 07:25 | |
| *** jprovazn has joined #openstack-horizon | 07:37 | |
| *** tnovacik has joined #openstack-horizon | 07:44 | |
| *** sayan has joined #openstack-horizon | 07:45 | |
| *** romainh has joined #openstack-horizon | 07:49 | |
| *** rdopiera has joined #openstack-horizon | 07:55 | |
| *** nlahouti has quit IRC | 07:56 | |
| *** tnovacik has quit IRC | 07:58 | |
| *** ala_ has joined #openstack-horizon | 08:02 | |
| *** jtomasek has joined #openstack-horizon | 08:03 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/139524 | 08:04 |
| *** sayan has quit IRC | 08:07 | |
| *** zul has joined #openstack-horizon | 08:07 | |
| *** sayan has joined #openstack-horizon | 08:10 | |
| *** Arvinder has quit IRC | 08:18 | |
| *** jcoufal has joined #openstack-horizon | 08:31 | |
| *** markus_z has joined #openstack-horizon | 08:40 | |
| *** MaxV has joined #openstack-horizon | 08:41 | |
| *** jpich has joined #openstack-horizon | 08:55 | |
| *** akrivoka has joined #openstack-horizon | 08:56 | |
| *** Arvinder has joined #openstack-horizon | 08:58 | |
| *** ygbo has joined #openstack-horizon | 09:02 | |
| *** cedrics has joined #openstack-horizon | 09:04 | |
| *** Guest45087 has quit IRC | 09:11 | |
| *** mfisch has joined #openstack-horizon | 09:15 | |
| *** mfisch is now known as Guest3214 | 09:15 | |
| *** e0ne has joined #openstack-horizon | 09:22 | |
| *** e0ne has quit IRC | 09:47 | |
| openstackgerrit | Guilhem Lettron proposed openstack/horizon: Add ability to set settings from a directory. Add file in openstack_dashboard/local/settings/ and reference it in __init__.py like: from myfile import * You can commit it in you own fork and can be used as base setting. https://review.openstack.org/139115 | 09:48 |
| openstackgerrit | Guilhem Lettron proposed openstack/horizon: Add ability to set settings from environment variables https://review.openstack.org/139112 | 09:49 |
| *** masco_ has joined #openstack-horizon | 09:53 | |
| rdopiera | is Guilhem Lettron here? | 10:04 |
| *** MaxV has quit IRC | 10:06 | |
| *** MaxV has joined #openstack-horizon | 10:13 | |
| *** athomas has joined #openstack-horizon | 10:16 | |
| *** aix has joined #openstack-horizon | 10:16 | |
| *** e0ne has joined #openstack-horizon | 10:16 | |
| *** amotoki__away is now known as amotoki | 10:22 | |
| openstackgerrit | Jiri Tomasek proposed openstack/horizon: Modal fixes - 2 columns, padding, header, membership https://review.openstack.org/113519 | 10:25 |
| *** Arvinder has quit IRC | 10:37 | |
| openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Refactor last events https://review.openstack.org/138465 | 10:45 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix Terminate Instance on network topology page https://review.openstack.org/138472 | 10:51 |
| *** tosky has joined #openstack-horizon | 10:53 | |
| *** robcresswell has joined #openstack-horizon | 11:06 | |
| openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Refactor last events https://review.openstack.org/138465 | 11:06 |
| openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Refactor last events https://review.openstack.org/138465 | 11:09 |
| *** my_openstack_use has joined #openstack-horizon | 11:13 | |
| *** masco_ has quit IRC | 11:15 | |
| openstackgerrit | Merged openstack/tuskar-ui: Workflow documentation is now in infra-manual https://review.openstack.org/139403 | 11:18 |
| *** vkmc has joined #openstack-horizon | 11:23 | |
| *** vkmc has quit IRC | 11:23 | |
| *** vkmc has joined #openstack-horizon | 11:23 | |
| *** cedrics has quit IRC | 11:35 | |
| *** akrivoka has quit IRC | 11:37 | |
| *** akrivoka has joined #openstack-horizon | 11:40 | |
| *** sayan has quit IRC | 11:45 | |
| *** masco has quit IRC | 11:50 | |
| *** TravT has joined #openstack-horizon | 11:51 | |
| *** amotoki is now known as amotoki__away | 11:54 | |
| *** TravT has quit IRC | 11:56 | |
| *** jpich has quit IRC | 12:01 | |
| *** jpich has joined #openstack-horizon | 12:02 | |
| robcresswell | nikunj2512: Hullo, have you had chance to look at https://review.openstack.org/#/c/124712/ again? | 12:04 |
| *** markus_z has quit IRC | 12:04 | |
| robcresswell | nikunj2512: I've got a patch waiting on it, was just wondering | 12:04 |
| *** thiagop has quit IRC | 12:14 | |
| *** jcoufal has quit IRC | 12:25 | |
| *** jcoufal has joined #openstack-horizon | 12:27 | |
| *** jcoufal has quit IRC | 12:28 | |
| *** jcoufal has joined #openstack-horizon | 12:29 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Refactor horizon/common/_modal_form.html template https://review.openstack.org/122398 | 12:32 |
| akrivoka | hi Horizon, we need one non-RH core to look at this and potentially merge it. it has already enough +2's, but we need a non-RH person's approval. https://review.openstack.org/#/c/139246/ | 12:36 |
| *** cbader has quit IRC | 12:36 | |
| akrivoka | thanks! | 12:36 |
| *** cbader has joined #openstack-horizon | 12:36 | |
| *** cedrics has joined #openstack-horizon | 12:40 | |
| *** markus_z has joined #openstack-horizon | 12:46 | |
| *** markus_z has quit IRC | 12:46 | |
| *** ZZelle has quit IRC | 12:48 | |
| *** markus_z has joined #openstack-horizon | 12:51 | |
| *** Longgeek has quit IRC | 12:52 | |
| *** mikedillion has joined #openstack-horizon | 12:55 | |
| *** ZZelle has joined #openstack-horizon | 12:55 | |
| *** cedrics has quit IRC | 12:58 | |
| *** sambetts has joined #openstack-horizon | 12:59 | |
| *** cedrics has joined #openstack-horizon | 13:00 | |
| *** robcresswell has quit IRC | 13:01 | |
| *** tzumainn has joined #openstack-horizon | 13:08 | |
| *** ZZelle has quit IRC | 13:09 | |
| *** ZZelle has joined #openstack-horizon | 13:11 | |
| *** jprovazn has quit IRC | 13:14 | |
| *** Longgeek has joined #openstack-horizon | 13:17 | |
| *** mikedillion has quit IRC | 13:19 | |
| *** my_openstack_use has quit IRC | 13:22 | |
| *** e0ne has quit IRC | 13:22 | |
| *** masco has joined #openstack-horizon | 13:23 | |
| *** e0ne has joined #openstack-horizon | 13:28 | |
| openstackgerrit | Chad Roberts proposed openstack/horizon: Adding filtering to data_processing tables https://review.openstack.org/136459 | 13:29 |
| *** cedricss has joined #openstack-horizon | 13:34 | |
| *** cedrics has quit IRC | 13:37 | |
| *** ZZelle has quit IRC | 13:39 | |
| *** underbyte1 has joined #openstack-horizon | 13:43 | |
| *** underbyte1 has left #openstack-horizon | 13:44 | |
| *** ZZelle has joined #openstack-horizon | 13:46 | |
| *** masco has quit IRC | 13:51 | |
| *** ZZelle has quit IRC | 13:55 | |
| *** jprovazn has joined #openstack-horizon | 13:55 | |
| *** alexpilotti has joined #openstack-horizon | 13:56 | |
| *** jcoufal has quit IRC | 14:00 | |
| *** ZZelle has joined #openstack-horizon | 14:02 | |
| *** radez_g0n3 is now known as radez | 14:07 | |
| *** dboik has joined #openstack-horizon | 14:09 | |
| *** ZZelle has quit IRC | 14:12 | |
| *** _crobertsrh is now known as crobertsrh | 14:14 | |
| *** dboik_ has joined #openstack-horizon | 14:17 | |
| *** ZZelle has joined #openstack-horizon | 14:17 | |
| *** mattfarina has joined #openstack-horizon | 14:20 | |
| *** dboik has quit IRC | 14:20 | |
| *** dboik_ has quit IRC | 14:22 | |
| *** cedrics has joined #openstack-horizon | 14:22 | |
| *** cedrics has quit IRC | 14:23 | |
| *** e0ne has quit IRC | 14:28 | |
| *** alexpilotti has quit IRC | 14:30 | |
| *** alexpilotti has joined #openstack-horizon | 14:31 | |
| *** alexpilotti has quit IRC | 14:38 | |
| *** vijendar has joined #openstack-horizon | 14:39 | |
| *** alexpilotti has joined #openstack-horizon | 14:40 | |
| *** e0ne has joined #openstack-horizon | 14:41 | |
| *** alexpilotti has quit IRC | 14:42 | |
| *** TravT has joined #openstack-horizon | 14:44 | |
| *** hurgleburgler has joined #openstack-horizon | 14:45 | |
| *** mikedillion has joined #openstack-horizon | 14:45 | |
| *** dboik has joined #openstack-horizon | 14:48 | |
| *** nikunj2512 has quit IRC | 14:51 | |
| tsufiev | rdopiera, I haven't yet reviewed your patch https://review.openstack.org/#/c/100521/ but already started to promote it, for example here https://bugs.launchpad.net/horizon/+bug/1399585 :) | 15:01 |
| *** Guest3214 is now known as mfisch | 15:01 | |
| *** mfisch has joined #openstack-horizon | 15:01 | |
| tsufiev | though I still don't get what this man actually needs | 15:02 |
| *** alexpilotti has joined #openstack-horizon | 15:02 | |
| *** thiagop has joined #openstack-horizon | 15:03 | |
| *** sambetts has quit IRC | 15:06 | |
| rdopiera | tsufiev: those bugs/patches are problematic in tricky ways, it would take more than 140 characters to explain why | 15:11 |
| *** ongk has joined #openstack-horizon | 15:13 | |
| *** ongk has quit IRC | 15:17 | |
| *** ongk has joined #openstack-horizon | 15:17 | |
| *** Poornima has quit IRC | 15:17 | |
| *** Piet has joined #openstack-horizon | 15:21 | |
| tsufiev | rdopiera, he could use puppet/chef template for local_settings, where encode all the data he needs (same for many instances) | 15:30 |
| rdopiera | tsufiev: or he could load any additional stuff he needs in his onw local_settings | 15:30 |
| rdopiera | tsufiev: there are lots of possibilities | 15:30 |
| tsufiev | rdopiera, yep. That's why I don't understand what Problem he's trying to solve... | 15:31 |
| rdopiera | tsufiev: the problem is that he already has that patch applied in his production :) | 15:33 |
| *** ericpeterson has joined #openstack-horizon | 15:40 | |
| *** bluex-pl has joined #openstack-horizon | 15:43 | |
| openstackgerrit | Guilhem Lettron proposed openstack/horizon: Add ability to set settings from environment variables https://review.openstack.org/139112 | 15:53 |
| *** thiagop has quit IRC | 15:54 | |
| *** e0ne has quit IRC | 15:59 | |
| *** e0ne has joined #openstack-horizon | 16:01 | |
| openstackgerrit | Guilhem Lettron proposed openstack/horizon: Add ability to set settings from a directory. https://review.openstack.org/139115 | 16:03 |
| rdopiera | ^^ should I shorten his suffering and just -2 it? | 16:05 |
| *** bpokorny has quit IRC | 16:07 | |
| tsufiev | hehe :) | 16:08 |
| tsufiev | ... and get another portion of ranting in gerrit comments | 16:09 |
| *** dloi has joined #openstack-horizon | 16:10 | |
| tsufiev | rdopiera, well, you could say to him all the words you said here | 16:10 |
| *** Piet has quit IRC | 16:11 | |
| rdopiera | tsufiev: I wish he was here | 16:12 |
| *** ala_ has quit IRC | 16:20 | |
| *** peristeri has joined #openstack-horizon | 16:23 | |
| *** bpokorny has joined #openstack-horizon | 16:25 | |
| *** ygbo has quit IRC | 16:26 | |
| *** Drago has joined #openstack-horizon | 16:33 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Updated from global requirements https://review.openstack.org/139680 | 16:33 |
| *** bluex-pl has quit IRC | 16:34 | |
| *** cedrics has joined #openstack-horizon | 16:36 | |
| *** cedricss has quit IRC | 16:37 | |
| *** romainh has quit IRC | 16:37 | |
| *** david-ly_ is now known as david-lyle | 16:37 | |
| david-lyle | rdopiera: ping | 16:39 |
| *** woodm1979 has joined #openstack-horizon | 16:40 | |
| *** jpich has quit IRC | 16:41 | |
| *** markus_z has quit IRC | 16:41 | |
| rdopiera | david-lyle: hi | 16:42 |
| rdopiera | david-lyle: thank you for merging that font-awesome patch | 16:43 |
| *** hinnant_ has joined #openstack-horizon | 16:43 | |
| david-lyle | rdopiera: no problem, did you do the upload to pypi? | 16:43 |
| rdopiera | david-lyle: of that new version of xstatic-font-awesome -- yes | 16:44 |
| *** bluex-pl has joined #openstack-horizon | 16:44 | |
| rdopiera | david-lyle: I tagged and uploaded it, I should probably set up a release job on gerrit, but I don't know how | 16:45 |
| david-lyle | rdopiera: hmm, I already pushed the tag | 16:45 |
| david-lyle | yesterday | 16:45 |
| rdopiera | ouch | 16:45 |
| david-lyle | you added another 0 | 16:46 |
| david-lyle | it seems | 16:46 |
| david-lyle | 4.2.0.0 | 16:46 |
| rdopiera | yeah, for the build number | 16:46 |
| david-lyle | ok, I was basing off the 4.1.0 tag already there | 16:46 |
| david-lyle | so pushed 4.2.0 | 16:46 |
| rdopiera | I suppose it doesn't hurt to have two tags pointing to the same revision | 16:47 |
| david-lyle | I wouldn't think so | 16:47 |
| rdopiera | I will research about adding a job that would publish it on pypi automatically | 16:47 |
| david-lyle | anyway, I think if you add openstack-ci as a Package Index Owner, it will upload on a tag push | 16:47 |
| rdopiera | david-lyle: it is added as the owner | 16:48 |
| david-lyle | that's what django_openstack_auth does | 16:48 |
| rdopiera | david-lyle: but the job has to be configured on the repo | 16:48 |
| david-lyle | hmm, I'm not seeing them on the page https://pypi.python.org/pypi/XStatic-Font-Awesome/ | 16:48 |
| david-lyle | https://pypi.python.org/pypi/django_openstack_auth for comparison | 16:49 |
| *** bluex-pl has quit IRC | 16:49 | |
| david-lyle | I guess it's "openstackci" | 16:49 |
| david-lyle | I can ask about where to configure the job | 16:49 |
| rdopiera | aah, that's because the package was originally by Thomas | 16:49 |
| rdopiera | added now | 16:50 |
| david-lyle | great | 16:50 |
| david-lyle | I'll go talk to infra about the jobs | 16:50 |
| david-lyle | thanks for uploading the new version! | 16:50 |
| rdopiera | I will just copy it from the config of other projects | 16:51 |
| rdopiera | I just need to sit down and do it for all those repositories | 16:51 |
| david-lyle | what file? | 16:51 |
| rdopiera | the job is defined in https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/pypi-jobs.yaml | 16:53 |
| rdopiera | but I have to find where it is defined for the projects | 16:53 |
| rdopiera | but somewhere in that repository | 16:53 |
| rdopiera | ah, here it is https://github.com/openstack-infra/project-config/blob/master/zuul/layout.yaml | 16:54 |
| *** nlahouti has joined #openstack-horizon | 16:55 | |
| david-lyle | so adding the publish-to-pypi job to the xstatic repos? | 16:56 |
| rdopiera | yeah, I believe so | 16:56 |
| rdopiera | I will do that on Monday | 16:56 |
| rdopiera | unless someone else is especially bored :) | 16:57 |
| david-lyle | I may take a look, django_openstack_auth seems different for some reason | 16:57 |
| david-lyle | would like to understand the difference | 16:57 |
| rdopiera | interesting | 16:57 |
| rdopiera | well, this is just my guess, but in the worst case, the infra team will comment on my patch and tell me to do it some other way | 16:58 |
| david-lyle | I'll ask, looks like publish-to-pypi allows pre-release patches as wheels | 16:59 |
| david-lyle | release uploads, both wheel and tarball | 17:00 |
| david-lyle | no idea why django_openstack_auth is only set up to do release, not that we need pre-release on any of them | 17:01 |
| rdopiera | I have to run, have a nice weekend! | 17:05 |
| *** rdopiera has quit IRC | 17:05 | |
| *** sbfox has joined #openstack-horizon | 17:10 | |
| *** sbfox has quit IRC | 17:12 | |
| *** sbfox has joined #openstack-horizon | 17:12 | |
| *** pkarikh_ has quit IRC | 17:16 | |
| *** sbfox has quit IRC | 17:16 | |
| *** sbfox has joined #openstack-horizon | 17:17 | |
| *** vkmc has quit IRC | 17:20 | |
| *** mikedillion has quit IRC | 17:24 | |
| *** mikedillion has joined #openstack-horizon | 17:25 | |
| *** Piet has joined #openstack-horizon | 17:25 | |
| openstackgerrit | Merged openstack/horizon: Fix dropdown menu does not open with firefox 34 https://review.openstack.org/139246 | 17:28 |
| *** MaxV has quit IRC | 17:28 | |
| *** cedrics has quit IRC | 17:32 | |
| *** ericpeterson has quit IRC | 17:35 | |
| *** lhcheng has joined #openstack-horizon | 17:36 | |
| *** ericpeterson has joined #openstack-horizon | 17:36 | |
| *** athomas has quit IRC | 17:39 | |
| *** mikedillion has quit IRC | 17:40 | |
| *** ayoung has quit IRC | 17:44 | |
| lhcheng | anyone know why our xstatic packages got renamed with the Title case version?? for example: xstatic-angular-cookies -> Xstatic-Angular-Cookies | 17:50 |
| lhcheng | https://review.openstack.org/#/c/139680/1/requirements.txt | 17:51 |
| * ericpeterson looks for a joke involving ecstatic | 17:55 | |
| *** rwsu has joined #openstack-horizon | 18:02 | |
| *** wuhg has quit IRC | 18:03 | |
| lhcheng | david-lyle: xstatic-font-awesome got updated to 4.2.0 in pypi, did you had to do other than tagging? | 18:06 |
| david-lyle | lhcheng: radomi published it | 18:07 |
| lhcheng | ericpeterson, looks like the xstatic thing is something trigger by infra. Don't see anyone committing the change, it just got merged by jenkins | 18:08 |
| lhcheng | https://github.com/openstack/requirements/commits/master/global-requirements.txt | 18:08 |
| *** tqtran has joined #openstack-horizon | 18:08 | |
| david-lyle | lhcheng: matching pypi | 18:09 |
| david-lyle | pip handles failures better that was | 18:09 |
| david-lyle | s/was/way | 18:09 |
| ericpeterson | looking at that change log, it seems like the robots have finally taken over. right on time for the weekend | 18:09 |
| lhcheng | david-lyle, right.. Wonder why it worked before | 18:09 |
| david-lyle | pip is case sensitive for the most part, but the fall back on a miss does strange things | 18:10 |
| david-lyle | trying to recall all the details, we saw this with pyScss too | 18:10 |
| *** dboik has quit IRC | 18:10 | |
| david-lyle | infra said matching case exactly is mo betta | 18:12 |
| *** akrivoka has quit IRC | 18:18 | |
| *** ayoung has joined #openstack-horizon | 18:20 | |
| *** dsneddon has quit IRC | 18:20 | |
| *** dsneddon has joined #openstack-horizon | 18:21 | |
| lhcheng | david-lyle: cool, good to know. | 18:21 |
| *** gyee has joined #openstack-horizon | 18:25 | |
| rbertram | david-lyle: we talked at summit about caching 100s of instances on client | 18:28 |
| rbertram | david-lyle: thinking about performance... | 18:28 |
| rbertram | david-lyle: were you thinking we would resolve the image name and flavor name only when instance is displayed? | 18:28 |
| rbertram | david-lyle: or could we do it in the cache? | 18:29 |
| *** radez is now known as radez_g0n3 | 18:29 | |
| david-lyle | rbertram: the current calls to find that information is done once to pull all | 18:30 |
| david-lyle | so performance to make those calls from the client rather than the server is not really different | 18:30 |
| david-lyle | would likely need to cache that too | 18:31 |
| Piet | Updated Modal concepts to Invision if anyone is interested in reviewing and leaving comments http://invis.io/QF1TM5UCK | 18:31 |
| *** ericpeterson has quit IRC | 18:31 | |
| raildo | Piet, ++ | 18:31 |
| tqtran | Piet: ++++++++ | 18:32 |
| Piet | tqtran; we included a concept for Create User | 18:33 |
| openstackgerrit | Chad Roberts proposed openstack/horizon: [WIP]Allowing editing of node group and cluster templates https://review.openstack.org/139705 | 18:33 |
| tqtran | Piet: yup, looking through it now | 18:33 |
| rbertram | looks like one call to glance for each server to get its image name. Guess I need to look deeper. | 18:33 |
| david-lyle | rbertram: admin or project view? | 18:34 |
| david-lyle | in this particular case | 18:34 |
| rbertram | looking at admin | 18:34 |
| david-lyle | ok I was looking at project | 18:34 |
| david-lyle | that might explain it :) | 18:34 |
| *** amcrn has joined #openstack-horizon | 18:34 | |
| rbertram | project isn't as scale-challanged | 18:35 |
| *** bpokorny_ has joined #openstack-horizon | 18:35 | |
| david-lyle | depends on your structure, but yes, I agree | 18:35 |
| *** gyee has quit IRC | 18:35 | |
| openstackgerrit | Chad Roberts proposed openstack/horizon: [WIP]Allowing editing of cluster templates https://review.openstack.org/139707 | 18:37 |
| rbertram | The API only offers filtering by id for image & flavor. wondering if we can really do better without driving too much activity. | 18:37 |
| openstackgerrit | Merged openstack/horizon: Updated from global requirements https://review.openstack.org/139680 | 18:37 |
| *** bpokorny has quit IRC | 18:37 | |
| *** e0ne has quit IRC | 18:37 | |
| david-lyle | that's expensive information | 18:37 |
| david-lyle | now and in the future | 18:38 |
| rbertram | maybe need to work backwards, e.g. have all the flavor names handy so we can look up their ids when requested | 18:38 |
| *** gyee has joined #openstack-horizon | 18:38 | |
| david-lyle | that's what it's doing now | 18:38 |
| *** gyee has quit IRC | 18:38 | |
| *** gyee has joined #openstack-horizon | 18:39 | |
| david-lyle | flavors won't be bad, because there aren't that many | 18:39 |
| rbertram | unlike images | 18:39 |
| Piet | Does anyone have a sense of the max number of flavors you would see in Horizon? | 18:39 |
| david-lyle | Piet 5 | 18:39 |
| david-lyle | period | 18:39 |
| david-lyle | :P | 18:39 |
| tqtran | Piet: how are we planning on handling pop up with very long description? shove that into the (?) at the top right? | 18:40 |
| david-lyle | my guess would be 20 or less | 18:40 |
| david-lyle | typical is less than 10 | 18:40 |
| tqtran | Piet: would all dialogs have the same consistent size? | 18:40 |
| david-lyle | rbertram: really depends on you image upload policy | 18:40 |
| rbertram | design for 20, but don't break at 100 | 18:40 |
| david-lyle | s/you/your/ | 18:40 |
| rbertram | david-lyle: what did you mean by: that's what it's doing now? | 18:41 |
| *** dsneddon has quit IRC | 18:41 | |
| david-lyle | admin view is grabbling the full flavor list | 18:41 |
| Piet | Give me a sec, in a meeting for an upcoming usability | 18:41 |
| rbertram | I don't see it letting me give it a flavor name, and converting it to an id for the api | 18:41 |
| david-lyle | and using those | 18:41 |
| david-lyle | if it fails to find an id in the full flavor list, it tries to ask for it individually | 18:42 |
| Piet | tqtran; are you referring to Help in the modals? | 18:42 |
| david-lyle | https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/instances/views.py#L115 | 18:42 |
| david-lyle | https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/instances/views.py#L126 | 18:42 |
| *** clu_ has joined #openstack-horizon | 18:42 | |
| david-lyle | https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/instances/views.py#L131 | 18:43 |
| david-lyle | careful or I'll post a link to all lines in the file :) | 18:43 |
| *** dsneddon has joined #openstack-horizon | 18:43 | |
| *** tosky has quit IRC | 18:43 | |
| rbertram | ah, you mean that's how it gets the flavors to display in the table | 18:44 |
| tqtran | Piet: the create user modal specifically | 18:45 |
| david-lyle | rbertram: yes, what are you talking about | 18:45 |
| * david-lyle is easily confused | 18:45 | |
| david-lyle | talk slowly and use little words | 18:45 |
| rbertram | this is taking a while because I'm typing so slowly :-) actually studying UI... | 18:46 |
| david-lyle | maybe spell phonetically | 18:47 |
| david-lyle | :D | 18:47 |
| *** bpokorny has joined #openstack-horizon | 18:48 | |
| rbertram | Today, if I want to filter my instances by flavor, I first go to the flavors view. | 18:49 |
| rbertram | I copy the id of the flavor | 18:49 |
| rbertram | Then I go to the instances view, select "Flavor ID" in the filter dropdown, and past the id. And hit Enter. | 18:50 |
| rbertram | Better would be if the Filter gave me a dropdown of the 10 filters to choose | 18:50 |
| rbertram | So the UI needs to know the dictionary of filters/ids, and then it can translate from selected name to id | 18:51 |
| rbertram | that's what I meant by "backwards" - opposite of what the table is doing | 18:51 |
| *** bpokorny_ has quit IRC | 18:51 | |
| rbertram | We could do this today with API fitlering. Or in future with instances cached, even though their flavors are still stored by ID on client-side. | 18:53 |
| *** EmilyW has joined #openstack-horizon | 18:53 | |
| Piet | tqtran: The modals would have a consistent height, but the width would change based on the browser window size. Content within the modal would be responsive. | 18:54 |
| tqtran | Piet: i see | 18:55 |
| Piet | tqtran: I also think it makes sense to mockup the Update Default Quotas dialogue because it has a ton of fields. | 18:57 |
| *** ZZelle has quit IRC | 18:57 | |
| *** dboik has joined #openstack-horizon | 18:58 | |
| *** ZZelle has joined #openstack-horizon | 18:58 | |
| tqtran | Piet: yeah, i'll start leaving some comments on nvision. | 18:59 |
| *** jprovazn has quit IRC | 18:59 | |
| Piet | Coolio | 18:59 |
| Piet | david-lyle: Please review the modal proposals. I know you had some concerns around multiple columns of fields. | 19:00 |
| *** dsneddon has quit IRC | 19:02 | |
| *** dsneddon has joined #openstack-horizon | 19:03 | |
| *** mikedillion has joined #openstack-horizon | 19:17 | |
| *** lhcheng has quit IRC | 19:19 | |
| *** Drago has quit IRC | 19:21 | |
| *** dsneddon has quit IRC | 19:23 | |
| *** dsneddon has joined #openstack-horizon | 19:24 | |
| *** ayoung has quit IRC | 19:25 | |
| *** lhcheng has joined #openstack-horizon | 19:26 | |
| *** sbfox has quit IRC | 19:27 | |
| *** raildo has quit IRC | 19:28 | |
| *** samuelms has quit IRC | 19:28 | |
| *** htruta has quit IRC | 19:29 | |
| *** packet has joined #openstack-horizon | 19:31 | |
| *** gyee has quit IRC | 19:34 | |
| *** ongk has quit IRC | 19:39 | |
| openstackgerrit | Chad Roberts proposed openstack/horizon: [WIP]Allowing editing of node group templates https://review.openstack.org/139705 | 19:43 |
| openstackgerrit | Chad Roberts proposed openstack/horizon: [WIP]Allowing editing of cluster templates https://review.openstack.org/139707 | 19:44 |
| *** dsneddon has quit IRC | 19:44 | |
| *** dsneddon has joined #openstack-horizon | 19:46 | |
| tsufiev | tqtran, Hi! https://review.openstack.org/#/c/122398/9/horizon/templates/horizon/common/_modal_form.html - now I'm confused :) | 19:53 |
| tqtran | tsufiev: lol sorry! gimme a sec, i will explain | 19:54 |
| *** alexpilotti has quit IRC | 19:55 | |
| *** dboik has quit IRC | 19:55 | |
| tsufiev | tqtran, I mean, not touching div.modal-footer seems perfectly fine to me because {% block modal-footer %} is inside it | 19:55 |
| tsufiev | okay, I'll be in 20 minutes | 19:56 |
| tqtran | tsufiev: right, thats what i thought at first, but i pulled down your patch and merged it mine, and tested it | 19:56 |
| tqtran | tsufiev: because modal-footer is inside modal-body, we removed the div.modal-footer | 19:57 |
| tqtran | tsufiev: now modal-footer is missing the div.modal-footer, and the buttons are all wrong | 19:57 |
| tqtran | tsufiev: ok, let me show you instead, its less confusing that way | 19:58 |
| *** ongk has joined #openstack-horizon | 19:58 | |
| tqtran | tsufiev: just fetch your patch, then test it, then launch any modal and you will see what i mean | 19:59 |
| *** ayoung has joined #openstack-horizon | 19:59 | |
| *** e0ne has joined #openstack-horizon | 20:01 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Clean modal forms in Identity Roles https://review.openstack.org/123560 | 20:03 |
| *** dsneddon has quit IRC | 20:06 | |
| *** ericpeterson has joined #openstack-horizon | 20:06 | |
| *** dsneddon has joined #openstack-horizon | 20:07 | |
| *** radez_g0n3 is now known as radez | 20:08 | |
| *** ericpeterson has quit IRC | 20:10 | |
| *** ericpeterson has joined #openstack-horizon | 20:10 | |
| *** tqtran is now known as tqtran_afk | 20:24 | |
| *** jacalcat has joined #openstack-horizon | 20:30 | |
| david-lyle | doug-fish: ping | 20:35 |
| david-lyle | re: https://review.openstack.org/136056 | 20:36 |
| david-lyle | One of the things I dislike the most in the openstack_dashboard code base is all the repetition. For instance, all Detail pages using base.html and doing an include of _page_header.html and set the title value Seems like a simpler solution would be have a details page base template that already does that. And pulls in a class attribute to a localization promise object or a method to generate that promise obje | 20:36 |
| david-lyle | ct. | 20:36 |
| david-lyle | Going through and adding something very similar in all the get_context methods points to a common need that I feel could be done more elegantly. | 20:37 |
| david-lyle | Additionally, if you grep through the dashboards, you'll see we include _page_header.html and set the title on many other pages beyond just detail views. Again, pointing to a common need | 20:37 |
| david-lyle | Your bug fix is probably not the right place to address this concern, but I feel the solution is compounding the the lack of DRYness in how headers are handled. | 20:37 |
| david-lyle | I do understand you are just trying to fix some localization issues and I fought it on poor existing architecture concerns | 20:38 |
| david-lyle | The complicating factor is you need data in the context to generate the values, so the additions to get_context would likely stand even if the default behavior changed | 20:42 |
| tsufiev | tqtran_afk, yeah, you right! I've forgotten that we're overriding whole {% block content %} | 20:43 |
| david-lyle | doug-fish, posted to review | 20:48 |
| *** dsneddon has quit IRC | 20:50 | |
| *** dsneddon has joined #openstack-horizon | 20:50 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Refactor horizon/common/_modal_form.html template https://review.openstack.org/122398 | 21:02 |
| *** bpokorny_ has joined #openstack-horizon | 21:02 | |
| *** mikedillion has quit IRC | 21:03 | |
| *** bpokorny has quit IRC | 21:05 | |
| *** dboik has joined #openstack-horizon | 21:18 | |
| *** e0ne has quit IRC | 21:26 | |
| *** ericpete_ has joined #openstack-horizon | 21:29 | |
| r1chardj0n3s_afk | argh, whose big idea was it to merge a huge chagne to requirements.txt just to change case? :P | 21:29 |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 21:30 | |
| *** ericpeterson has quit IRC | 21:31 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Add new angular dependencies to requirements.txt https://review.openstack.org/139284 | 21:34 |
| *** packet has quit IRC | 21:37 | |
| *** ericpete_ has quit IRC | 21:39 | |
| r1chardj0n3s | tqtran_afk: those two updates ^^ fix the missing module | 21:39 |
| *** Longgeek has quit IRC | 21:42 | |
| *** ftcjeff has joined #openstack-horizon | 21:48 | |
| *** ftcjeff has quit IRC | 21:48 | |
| *** crobertsrh is now known as _crobertsrh | 21:50 | |
| openstackgerrit | Gary W. Smith proposed openstack/horizon: Add support for volume transfers https://review.openstack.org/112741 | 21:55 |
| *** bpokorny has joined #openstack-horizon | 21:56 | |
| *** mattfarina has quit IRC | 21:57 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: POST instantiation for Django-Angular https://review.openstack.org/136556 | 21:59 |
| openstackgerrit | Thai Tran proposed openstack/horizon: POST instantiation for Django-Angular https://review.openstack.org/136556 | 21:59 |
| *** bpokorny_ has quit IRC | 21:59 | |
| *** tqtran_afk is now known as tqtran | 22:00 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: POST instantiation for Django-Angular https://review.openstack.org/136556 | 22:03 |
| tqtran | r1chardj0n3s: lol just read your comment, thanks for update | 22:07 |
| *** Piet has quit IRC | 22:10 | |
| openstackgerrit | George Peristerakis proposed openstack/horizon: Generating a rdp file for a windows instance https://review.openstack.org/91394 | 22:14 |
| lhcheng | r1chardj0n3s_afk, infra :) | 22:18 |
| lhcheng | r1chardj0n3s_afk, our requirements is actually wrong, the title case is the correct name. It just so happened that it works before. :P | 22:19 |
| *** dboik has quit IRC | 22:21 | |
| *** jacalcat has quit IRC | 22:21 | |
| *** dboik has joined #openstack-horizon | 22:31 | |
| *** hurgleburgler has quit IRC | 22:43 | |
| *** hurgleburgler has joined #openstack-horizon | 22:44 | |
| *** cbader has quit IRC | 22:45 | |
| *** peristeri has quit IRC | 22:46 | |
| *** alexpilotti has joined #openstack-horizon | 22:49 | |
| tqtran | can i bug a core to review this? https://review.openstack.org/#/c/136556/ its super simple and harmless | 22:53 |
| *** vijendar has quit IRC | 22:54 | |
| *** alexpilotti has quit IRC | 23:00 | |
| *** dboik has quit IRC | 23:01 | |
| openstackgerrit | Merged openstack/horizon: Create titles without concatenation https://review.openstack.org/136056 | 23:05 |
| *** alexpilotti has joined #openstack-horizon | 23:20 | |
| *** rwsu has quit IRC | 23:24 | |
| david-lyle | tqtran: I meant to ask, is the Q for quality? | 23:53 |
| *** ongk has quit IRC | 23:54 | |
| *** vkmc has joined #openstack-horizon | 23:59 | |
| tqtran | david-lyle: yes indeed | 23:59 |
| david-lyle | figured | 23:59 |
| tqtran | david-lyle: its thai quality tran | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!