Wednesday, 2014-11-19

*** doug-fish has left #openstack-horizon00:00
*** ericpeterson has quit IRC00:00
*** lhcheng_ has quit IRC00:04
*** TravT_ has quit IRC00:04
*** TravT has joined #openstack-horizon00:04
*** david-lyle is now known as david-lyle_afk00:06
*** ZZelle has quit IRC00:12
*** r1chardj0n3s is now known as r1chardj0n3s_afk00:13
*** TravT has quit IRC00:17
*** r1chardj0n3s_afk is now known as r1chardj0n3s00:28
*** hurgleburgler has joined #openstack-horizon00:30
*** tzumainn has joined #openstack-horizon00:32
*** hurgleburgler has quit IRC00:35
*** hurgleburgler has joined #openstack-horizon00:35
*** hurgleburgler has quit IRC00:37
*** hurgleburgler has joined #openstack-horizon00:38
*** hurgleburgler has quit IRC00:38
*** hurgleburgler has joined #openstack-horizon00:38
*** Sukhdev has joined #openstack-horizon00:40
*** hurgleburgler has quit IRC00:40
*** raildo_ has joined #openstack-horizon00:40
*** hurgleburgler has joined #openstack-horizon00:41
*** nlahouti has joined #openstack-horizon00:43
*** hurgleburgler has quit IRC00:44
*** hurgleburgler has joined #openstack-horizon00:45
*** sbfox has quit IRC00:46
*** Drago has joined #openstack-horizon00:47
*** nlahouti has quit IRC00:48
*** Drago has quit IRC00:54
*** hinnant_ has quit IRC00:54
*** hurgleburgler has quit IRC00:59
*** hurgleburgler has joined #openstack-horizon00:59
*** hurgleburgler1 has joined #openstack-horizon01:01
*** hurgleburgler has quit IRC01:01
*** hurgleburgler1 has quit IRC01:02
*** hurgleburgler has joined #openstack-horizon01:03
*** Longgeek has joined #openstack-horizon01:07
*** hurgleburgler has quit IRC01:08
*** bpokorny_ has quit IRC01:08
*** hurgleburgler has joined #openstack-horizon01:09
*** ayoung has quit IRC01:09
*** colinmcnamara has quit IRC01:09
*** Longgeek has quit IRC01:12
*** hurgleburgler has quit IRC01:13
*** hurgleburgler has joined #openstack-horizon01:14
*** hurgleburgler has quit IRC01:15
*** hurgleburgler has joined #openstack-horizon01:15
*** hurgleburgler has quit IRC01:16
*** hurgleburgler has joined #openstack-horizon01:17
*** hurgleburgler has quit IRC01:18
*** hurgleburgler has joined #openstack-horizon01:19
*** hurgleburgler has quit IRC01:20
*** hurgleburgler has joined #openstack-horizon01:21
*** hurgleburgler has quit IRC01:21
*** jacalcat has quit IRC01:29
*** Dragomir has joined #openstack-horizon01:33
*** jacalcat has joined #openstack-horizon01:35
*** sayan has quit IRC01:35
*** Sukhdev has quit IRC01:37
*** tqtran has quit IRC01:40
openstackgerritMerged openstack/horizon: Fixes group by none defect in resource usage stats:  https://review.openstack.org/13198001:43
*** r1chardj0n3s is now known as r1chardj0n3s_afk01:49
*** clu_ has quit IRC01:57
*** ayoung has joined #openstack-horizon02:05
*** amcrn has quit IRC02:08
*** r1chardj0n3s_afk is now known as r1chardj0n3s02:18
*** sbfox has joined #openstack-horizon02:24
*** raildo_ has quit IRC02:30
*** nlahouti has joined #openstack-horizon02:31
*** Longgeek has joined #openstack-horizon02:33
*** newb123 has joined #openstack-horizon02:37
*** Longgeek has quit IRC02:38
*** jacalcat has quit IRC02:38
newb123Hi. I have a question about how to use DataTableView. What should get_data(self) be returning? Do I have to create a base.Resource class or is there a simpler way?02:38
*** vivekd has joined #openstack-horizon02:43
*** tzumainn has quit IRC02:48
openstackgerritLi Yingjun proposed openstack/horizon: Support nova service-disable/enable for Hypervisor  https://review.openstack.org/13549102:52
*** vkmc has quit IRC02:54
*** exploreshaifali has joined #openstack-horizon02:58
*** neelashah has joined #openstack-horizon02:59
*** rbertram has joined #openstack-horizon03:00
*** Poornima has joined #openstack-horizon03:00
*** Dragomir has quit IRC03:09
*** bradjones has quit IRC03:10
*** nlahouti has quit IRC03:11
*** Poornima has quit IRC03:11
*** bradjones has joined #openstack-horizon03:12
*** vivekd has quit IRC03:14
*** harlowja is now known as harlowja_away03:16
*** TravT has joined #openstack-horizon03:17
*** ArcTanSusan has quit IRC03:21
*** TravT has quit IRC03:22
*** exploreshaifali has quit IRC03:22
*** Poornima has joined #openstack-horizon03:23
*** bpokorny has joined #openstack-horizon03:23
*** bpokorny has quit IRC03:24
*** bpokorny has joined #openstack-horizon03:25
*** jrist has quit IRC03:28
*** sbfox has quit IRC03:32
*** sbfox has joined #openstack-horizon03:33
*** sbfox has quit IRC03:34
*** Longgeek has joined #openstack-horizon03:34
*** sbfox has joined #openstack-horizon03:35
*** jacalcat has joined #openstack-horizon03:38
*** Longgeek has quit IRC03:38
*** jrist has joined #openstack-horizon03:40
*** jwy has left #openstack-horizon03:41
*** jacalcat has quit IRC03:44
*** sbfox has quit IRC03:48
*** sigmavirus24 is now known as sigmavirus24_awa03:49
*** jacalcat has joined #openstack-horizon03:49
*** vivekd has joined #openstack-horizon03:53
*** vivekd has left #openstack-horizon03:54
*** bpokorny has quit IRC03:55
*** exploreshaifali has joined #openstack-horizon03:56
*** exploreshaifali has quit IRC03:59
*** sbfox has joined #openstack-horizon04:05
*** nikunj2512 has joined #openstack-horizon04:11
*** ayoung is now known as ayoung-ZZZzzzZzz04:13
*** neelashah has quit IRC04:21
*** jpomero has quit IRC04:21
*** exploreshaifali has joined #openstack-horizon04:24
*** sbfox has quit IRC04:28
*** ftcjeff has joined #openstack-horizon04:30
nikunj2512pkarith: Hi04:31
*** r1chardj0n3s is now known as r1chardj0n3s_afk04:31
nikunj2512pkarikh: Hi04:31
openstackgerritNikunj Aggarwal proposed openstack/horizon: Create a "project details" page  https://review.openstack.org/13447604:35
*** ftcjeff has quit IRC04:50
*** ftcjeff has joined #openstack-horizon04:51
*** jacalcat has quit IRC04:52
openstackgerritNikunj Aggarwal proposed openstack/horizon: Create a "user details" page  https://review.openstack.org/13394804:54
*** ttrifonov is now known as zz_ttrifonov04:59
*** sbfox has joined #openstack-horizon05:09
*** ftcjeff has quit IRC05:15
*** pradeep-av has joined #openstack-horizon05:18
openstackgerritSwati Shukla proposed openstack/horizon: Add "Back To Previous Page" link from all Detail pages  https://review.openstack.org/13488805:22
*** sbfox has quit IRC05:24
*** sbfox has joined #openstack-horizon05:27
*** Dragomir has joined #openstack-horizon05:31
*** zz_ttrifonov is now known as ttrifonov05:47
*** k4n0 has joined #openstack-horizon05:52
*** masco has joined #openstack-horizon05:54
*** amotoki_ has quit IRC05:57
openstackgerritOpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex  https://review.openstack.org/13551306:03
*** david-ly_ has joined #openstack-horizon06:11
*** colinmcnamara has joined #openstack-horizon06:12
*** david-lyle_afk has quit IRC06:12
openstackgerritNikunj Aggarwal proposed openstack/horizon: Improves Launch Cluster model in Data Processing panel  https://review.openstack.org/13525606:21
*** Longgeek has joined #openstack-horizon06:23
openstackgerritRavikumar Venkatesan proposed openstack/horizon: Adds floatingip allocate,release integration tests  https://review.openstack.org/10116906:24
*** pradeep-av has quit IRC06:25
nikunj2512wuhg: Hi06:28
*** Longgeek has quit IRC06:28
wuhghi,06:31
nikunj2512wuhg: About the bug you filed.. i am not able to reproduce it06:32
wuhgwhich one?06:32
nikunj2512https://bugs.launchpad.net/horizon/+bug/139404106:33
*** amotoki has joined #openstack-horizon06:33
*** vijendar has quit IRC06:33
nikunj2512wuhg: https://bugs.launchpad.net/horizon/+bug/139404106:34
*** k4n0 has quit IRC06:39
wuhgnikunj2512:you are right ,it can'be reproduced now06:40
wuhgearly this morning, it happened for many time here06:40
nikunj2512wuhg: Ok.. So, i am closing this bug now.. is that ok?06:41
wuhgok , close it , thanks06:41
nikunj2512wuhg: done..  :-)06:41
wuhgdoes it relate with keystone server ?06:42
wuhgthis will happen if the keystone server is down06:43
nikunj2512wuhg: yes and permissions06:43
*** colinmcnamara has quit IRC06:49
*** mrunge has joined #openstack-horizon06:50
*** Longgeek has joined #openstack-horizon06:53
*** k4n0 has joined #openstack-horizon06:54
*** Longgeek has quit IRC06:55
*** Longgeek has joined #openstack-horizon06:56
*** Poornima has quit IRC07:00
*** akrivoka has joined #openstack-horizon07:04
*** jprovazn has joined #openstack-horizon07:09
*** dsneddon has quit IRC07:10
*** newb123 has quit IRC07:18
*** david-ly_ has quit IRC07:18
*** romainh has joined #openstack-horizon07:26
*** gryf has joined #openstack-horizon07:31
*** gryf is now known as _gryf07:31
*** k4n0 has quit IRC07:31
*** dkorn has joined #openstack-horizon07:36
openstackgerritLi Yingjun proposed openstack/horizon: Support nova service-disable/enable for Hypervisor  https://review.openstack.org/13549107:38
*** sayan has joined #openstack-horizon07:38
*** k4n0 has joined #openstack-horizon07:44
*** exploreshaifali has quit IRC07:46
*** amerine has joined #openstack-horizon07:47
*** Dragomir has quit IRC07:54
*** jtomasek has quit IRC07:58
*** ttrifonov is now known as zz_ttrifonov07:59
*** ala_ has joined #openstack-horizon08:01
*** exploreshaifali has joined #openstack-horizon08:05
*** exploreshaifali has quit IRC08:06
*** exploreshaifali has joined #openstack-horizon08:08
*** Poornima has joined #openstack-horizon08:12
*** IvanBerezovskiy has joined #openstack-horizon08:12
*** sbfox has quit IRC08:14
*** sbfox has joined #openstack-horizon08:15
*** qba73 has joined #openstack-horizon08:18
*** tnovacik has joined #openstack-horizon08:18
openstackgerritMerged openstack/tuskar-ui: Make progress code extandable  https://review.openstack.org/13495308:25
openstackgerritMerged openstack/tuskar-ui: Optimize heat.Resource.get_by_node  https://review.openstack.org/13522508:25
*** zz_ttrifonov is now known as ttrifonov08:30
*** ygbo has joined #openstack-horizon08:33
*** MaxV has joined #openstack-horizon08:37
*** david-lyle_afk has joined #openstack-horizon08:49
*** sayan has quit IRC08:51
openstackgerritLi Yingjun proposed openstack/horizon: Support nova service-disable/enable for Hypervisor  https://review.openstack.org/13549108:53
*** amerine has quit IRC08:53
*** amerine has joined #openstack-horizon08:54
openstackgerritMerged openstack/horizon: Imported Translations from Transifex  https://review.openstack.org/13551308:54
nikunj2512alazarev: Hi08:54
*** cedrics has joined #openstack-horizon08:57
*** jcoufal has joined #openstack-horizon08:58
*** jpich has joined #openstack-horizon08:59
*** jcoufal has quit IRC09:01
*** vokhrimenko has quit IRC09:01
*** vokhrimenko has joined #openstack-horizon09:01
*** jcoufal has joined #openstack-horizon09:01
*** jcoufal has quit IRC09:01
*** jcoufal has joined #openstack-horizon09:02
*** sbfox has quit IRC09:16
*** randyochoa has quit IRC09:25
*** esp has quit IRC09:26
*** sambetts has joined #openstack-horizon09:29
*** regebro has joined #openstack-horizon09:30
*** sayan has joined #openstack-horizon09:35
*** Longgeek has quit IRC09:38
*** Longgeek has joined #openstack-horizon09:49
*** exploreshaifali has quit IRC09:51
openstackgerritNikita Konovalov proposed openstack/horizon: [Data_processing] fix job_executions table  https://review.openstack.org/12592709:52
openstackgerritNikita Konovalov proposed openstack/horizon: [Data_processing] auto security group  https://review.openstack.org/12826309:52
*** esp has joined #openstack-horizon10:00
*** randyochoa has joined #openstack-horizon10:00
*** IvanBerezovskiy has quit IRC10:00
MaxVhello all, I have an issue with the gate on this patch https://review.openstack.org/#/c/133175/ I already tried the recheck bug [specific number] and recheck no bug10:01
jpichMaxV: It's looks like it's due to your patch, seems like with it horizon requires xvfbwrapper to run: http://logs.openstack.org/75/133175/1/check/check-tempest-dsvm-full/572051b/logs/horizon_error.txt.gz  which we don't want, since it's a test dependency10:06
jpichmaybe wrapping with it with the selenium imports in https://review.openstack.org/#/c/133175/1/horizon/test/tests/selenium_tests.py would help10:06
MaxVjpich: ok thanks10:06
*** rdopiera has joined #openstack-horizon10:07
openstackgerritKanchan Gupta proposed openstack/horizon: Error message updated.  https://review.openstack.org/12687310:08
*** enykeev has quit IRC10:08
*** enykeev has joined #openstack-horizon10:11
*** Anticimex has quit IRC10:12
*** Anticimex has joined #openstack-horizon10:18
*** aix has joined #openstack-horizon10:23
*** jtomasek has joined #openstack-horizon10:27
*** lhcheng has joined #openstack-horizon10:33
openstackgerritNikunj Aggarwal proposed openstack/horizon: Fixes Error message during image upload due to file filtering  https://review.openstack.org/13105910:38
nikunj2512sambetts: Can you take a look at this patch again - https://review.openstack.org/#/c/131059/10:39
openstackgerritMaxime Vidori proposed openstack/horizon: Revert the use of lazy loading for mox  https://review.openstack.org/13317510:44
* sambetts looks10:47
nikunj2512sambetts: Thank you10:48
*** lhcheng_ has joined #openstack-horizon10:50
*** amotoki has quit IRC10:51
*** lhcheng has quit IRC10:53
*** tnovacik has quit IRC10:54
openstackgerritMerged openstack/horizon: Automatically remove interfaces on router delete  https://review.openstack.org/13274210:59
openstackgerritMerged openstack/horizon: Set row action dropdown to right-align  https://review.openstack.org/13431110:59
openstackgerritNikunj Aggarwal proposed openstack/horizon: Disable "Associate floating IP" when instance error  https://review.openstack.org/13556411:00
*** tnovacik has joined #openstack-horizon11:03
nikunj2512vokhrimenko: Hi, this related to this patch - https://review.openstack.org/#/c/131059/13/openstack_dashboard/dashboards/project/images/images/forms.py11:03
nikunj2512vokhrimenko: We want form to close after submit11:04
vokhrimenkonikunj2512 Hi, after submit (if all good) --- yes, but if we have exception -- we dont need close form11:06
vokhrimenkonikunj2512 We dont need close form for " Unable to create new image: Image name too long:"11:08
*** cedrics has quit IRC11:11
*** john-davidge has joined #openstack-horizon11:13
*** e0ne has joined #openstack-horizon11:13
openstackgerritBradley Jones proposed openstack/horizon: Updated overview graph when usage exceeds quota  https://review.openstack.org/11942711:14
*** robcresswell has joined #openstack-horizon11:14
*** hhuang has joined #openstack-horizon11:15
*** kmartin has quit IRC11:16
openstackgerritnayna-patel proposed openstack/horizon: Adds securitygroup create,edit,delete integration tests  https://review.openstack.org/9932911:22
*** vkmc has joined #openstack-horizon11:28
*** tosky has joined #openstack-horizon11:32
openstackgerritPaul Karikh proposed openstack/horizon: Implementation inline table editing for Users table  https://review.openstack.org/12273711:37
*** alexpilotti has joined #openstack-horizon11:44
*** ekarlso- has quit IRC11:44
nikunj2512vokhrimenko: that exception is coming from glance and i think that is correct behaviour.. if horizon was the one checking for the length of image name than your point hold true but in this case data goes to backend and comes back. I think, it should close11:50
*** ekarlso- has joined #openstack-horizon11:51
regebroAnyone good at how we use Angular here? I get this error with some Angular code, that I didn't write and which once was working: http://pastebin.com/z3WvdH0711:52
*** aix has quit IRC11:52
regebroThe code in question: https://github.com/stackforge/tuskar-ui-extras/blob/master/tuskar_sat_ui/static/infrastructure/js/angular/horizon.node_errata.js11:53
rdopieraregebro: so you are staying with angular anyways?11:55
regebrordopiera: If I can get it to work within 30 minutes.11:55
vokhrimenkonikunj2512   I think it's bad behavior --- for example: if we have Image name too long  -- close form11:55
nikunj2512vokhrimenko: Yes, it is bad behavior if Horizon is checking for the length but it is not if server is checking and sending the response to the user. Then the form will not close in case of any of glance exceptions and i don't think so that is correct behavior11:57
vokhrimenkonikunj2512  In Horizon(forms.SelfHandlingForm) in  handle() we often return False for exception11:57
vokhrimenkohttps://github.com/openstack/horizon/blob/2014.2.rc1/openstack_dashboard/dashboards/admin/aggregates/forms.py#L7911:58
vokhrimenko....one of the many examples11:59
nikunj2512vokhrimenko: But if you see the old code for the images, it closes the form and same with instance panel and then also with users panel12:00
nikunj2512vokhrimenko: Ok.. i am making the changes..12:06
*** hhuang has quit IRC12:08
vokhrimenko<nikunj2512>  can anyone else give my opinion ?12:08
nikunj2512vokhrimenko: i didn't get what are meant by that12:09
pkarikhFolks, does anybody knows, where I can find the code code which calculates values of "Memory Usage " in Admin-Hypervisor pie charts?12:10
openstackgerritNikunj Aggarwal proposed openstack/horizon: Fixes Error message during image upload due to file filtering  https://review.openstack.org/13105912:11
*** Anticimex has quit IRC12:13
nikunj2512vokhrimenko: i have submitted a new patch and implemented your comments please take a look and let me know if something is missing12:14
*** Poornima has quit IRC12:15
sambettspkarikh: Possibly here? openstack_dashboard/usage/base.py , or here horizon/templatetags/horizon.py ??12:16
*** doug-fish has joined #openstack-horizon12:18
*** Anticimex has joined #openstack-horizon12:19
*** nikunj2512 has quit IRC12:22
openstackgerritRadomir Dopieralski proposed openstack/tuskar-ui: Add a scale-out dialog  https://review.openstack.org/13558312:23
*** nikunj2512_ has joined #openstack-horizon12:25
nikunj2512_In horizon, do we have a form template which can render half some of the form fields on right side and some on left side of the form modal?12:27
*** cedrics has joined #openstack-horizon12:33
lhcheng_nikunj2512_, I don't recall any in the horizon upstream, but using that should just be a matter of updating the form class used in the HTML template. I can't recall the class name though.12:33
*** masco has quit IRC12:34
*** Longgeek has quit IRC12:36
*** Longgeek has joined #openstack-horizon12:36
nikunj2512_lhcheng_, with form class you the horizon's default forms class??12:36
lhcheng_yeah, I remember there's out of the box form class that will render the field into two columns12:37
nikunj2512_lhcheng_, now in all horizon forms we use from horizon import forms, Are You talking about this same class??12:37
lhcheng_I meant CSS class12:38
pkarikhsambetts, thank you! I will start from files that you've refered! :)12:39
nikunj2512_lhcheng_, Ohhh.... Ok so that css class will be in the horizon.scss isn't it??12:39
pkarikhsambetts, also what do you think about making email field optional in this patch https://review.openstack.org/#/c/122737/8?12:40
*** aix has joined #openstack-horizon12:42
sambettspkarikh: I think the reason that the field is required there is because in the inline editing system it expects to always send all the columns in the table, even if the cell is empty e.g. if someone hasn't got an email then the cell would just be empty, so it would send ""12:43
lhcheng_nikunj2512_, I don't know where it is now this week. :) Have to look it up, but I am sure we used that class before.12:44
sambettspkarikh: if thats not the case and it literally enforces you send at least one character then I would expect that it needs to be changed12:45
*** aberezin has joined #openstack-horizon12:46
pkarikhsambetts, in other words, you think it should be required?12:47
*** nikunj2512__ has joined #openstack-horizon12:47
*** nikunj2512_ has quit IRC12:47
pkarikhsambetts or should I make it optional? I'm also not sure how to make it better.12:48
*** ekarlso- has quit IRC12:50
*** ekarlso- has joined #openstack-horizon12:50
sambettspkarikh: Depending on what "required" enforces, does it force you to have an email or does it allow you to send an empty string as the email?12:50
sambettspkarikh: ok, I've just looked it up and i think required=False makes more sense, if it is optional in other places in horizon12:52
*** nikunj2512__ has quit IRC12:53
*** nikunj2512__ has joined #openstack-horizon12:53
pkarikhsambetts, I think that requred=False is nice idea, because user creation form doed not require user mail. I'm going to fix in right now.12:53
*** nikunj2512 has joined #openstack-horizon12:53
*** sayan has quit IRC12:56
nikunj2512lhcheng_: Ok.. i will also search for it meanwhile... Thank you12:56
lhcheng_nikunj2512: sure, good luck!12:57
nikunj2512lhcheng_: one more question, if it is a css class than how will one can apply it on the horizon form class?12:57
sambettspkarikh: that makes sense, I think you need to experiment with the usr_obj.email thing and see if it always exists when the field is optional or not12:58
lhcheng_IIRC, there is no need to change the python form code. The css handles splitting the list of fields into two or three columns12:59
nikunj2512pkarikh, sambetts: i had aleady experimented with this and when email is empty then it doesn't not send email variable. it only sends the email field when it has value13:00
nikunj2512pkarikh, sambetts: That is why in comment i told we can use hasattr to find out if field is there or not13:00
nikunj2512lhcheng_: looking into the domails panel code13:00
*** amotoki has joined #openstack-horizon13:01
sambettsnikunj2512: Up until now it should have errored with a ValidationError or did you change email to a optional field to test it ?>13:01
nikunj2512sambetts: yes, i changed the email field to optional and tested it13:04
openstackgerritLennart Regebro proposed openstack/tuskar-ui: Adding a block in the node details template  https://review.openstack.org/13559213:05
*** regebro is now known as regebro|fuud13:06
*** akrivoka has quit IRC13:09
*** ZZelle has joined #openstack-horizon13:13
openstackgerritPaul Karikh proposed openstack/horizon: Implementation inline table editing for Users table  https://review.openstack.org/12273713:14
openstackgerritMaxime Vidori proposed openstack/horizon: Revert the use of lazy loading for mox  https://review.openstack.org/13317513:14
pkarikhsambetts nikunj2512 I've updated patch. Now email field is not requred. https://review.openstack.org/#/c/122737/913:15
* nikunj2512 looking13:16
*** jacalcat has joined #openstack-horizon13:18
*** Longgeek has quit IRC13:18
nikunj2512pkarikh: i think you have to add this required=False...13:19
nikunj2512pkarikh: Isn't it>>13:19
nikunj2512?13:19
*** exploreshaifali has joined #openstack-horizon13:20
sambettsYes https://docs.djangoproject.com/en/dev/ref/forms/fields/#django.forms.Field.required13:20
nikunj2512pkarikh: also now it is not a required field, the email field needs to be handled because when email field value is empty, at that time, the user_obj will not have the email variable??13:20
sambettsthe default for a CharField is required=True, so you have to specfy required=False13:21
*** vijendar has joined #openstack-horizon13:21
*** regebro|fuud is now known as regebro13:21
nikunj2512sambetts: Yes13:21
nikunj2512pkarikh: gave some comments, please check them out.. They are same which i told here13:23
nikunj2512pkarikh: Thank you for the patch :)13:23
nikunj2512pkarikh: Please first you should fix this patch - https://review.openstack.org/#/c/122454/9, because your current patch is dependant on the this patch13:26
*** athomas has joined #openstack-horizon13:27
*** vijendar has quit IRC13:29
*** dkorn has quit IRC13:30
*** nikunj2512__ has quit IRC13:30
nikunj2512How to enable domains panel in Horizon??13:32
openstackgerritPaul Karikh proposed openstack/horizon: Implementation inline table editing for Users table  https://review.openstack.org/12273713:32
*** ayoung-ZZZzzzZzz is now known as ayoung13:33
nikunj2512pkarikh: Please put condition to handle the email when the email is emppty13:34
nikunj2512pkarikh: This will still fail13:34
*** akrivoka has joined #openstack-horizon13:34
*** vijendar has joined #openstack-horizon13:34
pkarikhnikunj2512 yep, now I'm checking wether the line you noted really falls. I've tested in with previous version and everything was Ok. Give me a few minutes. :)13:35
nikunj2512pkarikh: ok.. Thank You13:35
robcresswellnikunj2512: I was curious, wouldnt the error be caught by the try catch block?13:36
nikunj2512robcresswell: Yes it will be but that is because code is not handling the email field properly. And if code is left like this than for all the users who don't have email field value will not be able to use the inline editting, in my view13:37
pkarikhnikunj2512, I've tested it  with submitting empty email input and user_obj.email still equals u''. So, looks everything works fine without some special email handling.13:39
pkarikhnikunj2512, *looks like13:39
*** crobertsrh has joined #openstack-horizon13:40
nikunj2512pkarith: OK... Thank you for testing it.. i will test this patch once more13:40
pkarikhnikunj2512 ok. Feel free to ping me here while you will being testing if patch will be broken13:41
nikunj2512pkarith: OK... Thank you and one more thing as you are going to implement the inline editting for mostly for all the panels and i also wish to work with you in implementing this feature. So, if you don't mind can i also work with you in implementing the inline editting?13:42
*** vijendar1 has joined #openstack-horizon13:43
nikunj2512pkarith: Yes.. it is working fine..13:44
*** vijendar has quit IRC13:44
*** Longgeek has joined #openstack-horizon13:50
*** vijendar1 has quit IRC13:52
*** vijendar has joined #openstack-horizon13:52
*** vijendar1 has joined #openstack-horizon13:53
openstackgerritVlad Okhrimenko proposed openstack/horizon: Renaming a user name with an existing user name  https://review.openstack.org/13395313:55
*** tzumainn has joined #openstack-horizon13:56
*** vijendar has quit IRC13:56
*** cedricss has joined #openstack-horizon13:59
*** exploreshaifali has quit IRC14:02
*** cedrics has quit IRC14:03
*** rbertram has quit IRC14:03
*** rbertram has joined #openstack-horizon14:04
*** _gryf has quit IRC14:05
*** hurgleburgler has joined #openstack-horizon14:06
*** hhuang has joined #openstack-horizon14:08
*** sayan has joined #openstack-horizon14:10
*** hurgleburgler1 has joined #openstack-horizon14:13
*** hurgleburgler has quit IRC14:13
*** hurgleburgler1 has quit IRC14:16
*** neelashah has joined #openstack-horizon14:19
*** hurgleburgler has joined #openstack-horizon14:21
openstackgerritNikita Konovalov proposed openstack/horizon: [Data_processing] auto security group  https://review.openstack.org/12826314:25
nikunj2512akrivoka: Hi, this is about this https://review.openstack.org/#/c/132197/ patch14:26
nikunj2512akrivoka: the ability to set the default log length is already there in the instance log tab.. So, do i have to add this ability in the settings dashboards also??14:27
wuhgjpich:could you help review https://review.openstack.org/#/c/135273/ to see if it fix the logout problem?14:30
akrivokanikunj2512: I would expect something like a default log length to be a setting with is configured in the settings dashboard or the settings.py file. the way your patch works now is, you change the default log length on an instance detail page and then this change is reflected to all other instances also. not sure that this is the desired behavior.14:33
*** openstackgerrit has quit IRC14:33
nikunj2512akrivoka: Ok, i will add this ability to the setting page also.. Will that be acceptable??14:34
*** openstackgerrit has joined #openstack-horizon14:34
akrivokanikunj2512: what I would expect is a way to set the default (in the settings dashboard), and a way to change the log length on a particular instances (on the instance detail page) - which would not affect the default14:34
akrivokaif that makes sense14:34
*** zul has joined #openstack-horizon14:35
nikunj2512akrivoka: Ok14:35
MaxVIs it necessary to open a bug for a code improvement? or can we just ship it into a commit for review?14:35
nikunj2512akrivoka: Yes it makes sense14:35
akrivokanikunj2512: great :) thanks for working on this!14:35
nikunj2512akrivoka: Thank you for reviewing it14:36
akrivokaMaxV: I think it's always useful to have a bug associated with a review, if nothing else then for release tracking purposes14:37
*** peristeri has joined #openstack-horizon14:38
nikunj2512akrivoka: Should there be any limit to the number of lines user can see at once??14:38
akrivokanikunj2512: I'm not really sure, but since there wasn't any such limit before, I don't think you need to implement it in this patch14:40
nikunj2512akrivoka: ok14:40
openstackgerritKamil Rykowski proposed openstack/horizon: Searchable index service PoC  https://review.openstack.org/13268314:41
*** openstackgerrit has quit IRC14:49
*** openstackgerrit has joined #openstack-horizon14:49
*** amotoki has quit IRC14:50
*** e0ne has quit IRC14:54
*** jpomero has joined #openstack-horizon14:54
*** exploreshaifali has joined #openstack-horizon14:54
*** zul has quit IRC14:55
*** MaxV has quit IRC14:57
*** MaxV has joined #openstack-horizon14:58
openstackgerritMaxime Vidori proposed openstack/horizon: Separate jasmine tests between services and controllers  https://review.openstack.org/13561915:02
*** MaxV has quit IRC15:03
*** mrunge has quit IRC15:03
*** e0ne has joined #openstack-horizon15:06
*** ericpeterson has joined #openstack-horizon15:09
*** hurgleburgler has quit IRC15:09
ericpetersonmorning all. I think we have a critical security bug, but checking into it more (fyi)15:10
ericpetersonthe login page accesses the session, and creates new session records in whatever session backend you are using15:10
ericpetersonthis is vulnerable to a DOS attack15:10
jpichIf you find a super-bad security issue, it is usually better to report it first as a private security bug (and maybe it'll get demoted later to only-bad or whatever but that's ok)15:12
ericpetersonI think it might not be a visible issue yet if most people use cookie sessions, then it is not an issue15:14
jpichmany deployers especially for large environments don't use cookie-backed sessions if I recall the recent conversations correctly15:16
ericpetersonyou are correct15:16
*** zul has joined #openstack-horizon15:16
jpichBetter safe than sorry when it comes to security bugs. Thanks for looking into it!15:17
*** nikunj2512_ has joined #openstack-horizon15:20
ericpetersonyeah, I don't have the issue corned right now but am looking into it15:20
ericpetersonwe just now were / are moving to non cookie backends and saw this issue come up pretty quickly15:20
jpichok15:21
*** nikunj2512 has quit IRC15:22
jristericpeterson: how was the meetup last night? I couldn't make it15:22
ericpetersondecent.  bbq, but no beer :(15:22
jristwhat is this world coming to15:22
ericpetersonfwp15:22
jristI just found out about that group a week ago and missed the RSVP15:23
*** sigmavirus24_awa is now known as sigmavirus2415:23
*** amotoki has joined #openstack-horizon15:28
*** MaxV has joined #openstack-horizon15:29
*** colinmcnamara has joined #openstack-horizon15:31
openstackgerritTatiana Ovchinnikova proposed openstack/horizon: Orchestration Resource types panel  https://review.openstack.org/13459115:34
*** rebelagentm has joined #openstack-horizon15:34
MaxVrdopiera: Hello, is there any plan to upgrade jasmine from 1.3 to 2...15:35
MaxVrdopiera: ?15:35
*** Poornima has joined #openstack-horizon15:35
*** ericpeterson has quit IRC15:38
*** ericpeterson has joined #openstack-horizon15:39
*** TravT has joined #openstack-horizon15:40
*** tnovacik has quit IRC15:40
rdopieraMaxV: I certainly don't have any plans15:40
rdopieraMaxV: why?15:40
MaxVrdopiera: I can handle that and it is quite easy15:40
MaxVrdopiera: it provides better and cleaner support for asynchronous testing15:41
rdopieraMaxV: ask mrunge and zigo if it's fine for their distros15:41
MaxVrdopiera: understood15:42
zigoMaxV: rdopiera: I'm around!15:42
MaxVzigo: jasmine is already packaged in xstatic15:42
zigoYup.15:42
MaxVzigo: so it is basically a git push a new tag and a new package15:42
*** teju has joined #openstack-horizon15:43
MaxVzigo: do I have to provide something in addition?15:43
zigoI'm checking, hang on.15:44
zigoMaxV: For that package (ie: python-xstatic-jasmine), I didn't package separately the javascript part, so yes, it's absolutely no work for me, it's very easy.15:45
zigoI'd just git fetch, git merge -X theirs, edit changelog, build and that's it.15:45
zigoSo upgrade if you need...15:45
robcresswellUpstream uses 1.3 atm? Sorry I don't know much about Jasmine15:46
MaxVzigo: ok, I will check with mrunge as soon as I can, and prepare the git repo in the same time15:46
MaxVrobcresswell: in the requirements, the package version match the library version15:46
zigoMaxV: Feel free to add me as a reviewer for the requirements *AND* ping me on IRC (because I'm subscribed to the repo, I may miss your change...).15:47
*** hhuang has quit IRC15:47
MaxVzigo: roger15:47
openstackgerritNikunj Aggarwal proposed openstack/horizon: Adds ability to set default log length  https://review.openstack.org/13219715:49
*** nlahouti has joined #openstack-horizon15:55
openstackgerritKamil Rykowski proposed openstack/horizon: Searchable index service PoC  https://review.openstack.org/13268315:55
*** jprovazn is now known as jprovazn_afk15:56
*** mflobo has quit IRC15:57
*** josecastroleon has quit IRC16:01
MaxVrdopiera: just a quick question, Do I have to create a bp for xstatic update and where do I put this?16:02
*** Sukhdev has joined #openstack-horizon16:02
*** Longgeek has quit IRC16:03
*** nlahouti has quit IRC16:03
openstackgerritWu Hong Guang proposed openstack/horizon: Integration test for fix the logout issue in basepage  https://review.openstack.org/13527316:03
*** nlahouti has joined #openstack-horizon16:04
*** absubram__ has joined #openstack-horizon16:04
*** teju has quit IRC16:08
rdopieraMaxV: I think just a patch in gerrit is enough16:08
*** Dragomir has joined #openstack-horizon16:09
openstackgerritDoug Fish proposed openstack/horizon: Make Task state translatable.  https://review.openstack.org/13463816:10
*** Drago has joined #openstack-horizon16:10
*** hhuang has joined #openstack-horizon16:13
openstackgerritRichard Hagarty proposed openstack/horizon: New admin volume panel to manage/unmanage volumes.  https://review.openstack.org/12965216:19
openstackgerritKamil Rykowski proposed openstack/horizon: Searchable index service PoC  https://review.openstack.org/13268316:21
openstackgerritWu Hong Guang proposed openstack/horizon: Integration test for fix the logout issue in basepage  https://review.openstack.org/13527316:23
*** ttrifonov is now known as zz_ttrifonov16:27
*** zz_ttrifonov is now known as ttrifonov16:30
*** Drago has quit IRC16:30
*** hhuang has quit IRC16:30
robcresswellIs it just Jasmine we use to test JS?16:30
MaxVrobcresswell: currently it depends16:30
*** Drago has joined #openstack-horizon16:30
MaxVrobcresswell: legacy testing use junits16:30
*** hhuang has joined #openstack-horizon16:30
MaxVrobcresswell: angular testing use jasmine16:30
robcresswellMaxV: Gotcha, thanks :)16:31
openstackgerritRadomir Dopieralski proposed openstack/tuskar-ui: Add a scale-out dialog  https://review.openstack.org/13558316:31
*** davelowe has joined #openstack-horizon16:32
*** david-lyle_afk is now known as david-lyle16:34
openstackgerritRadomir Dopieralski proposed openstack/tuskar-ui: Add a scale-out dialog  https://review.openstack.org/13558316:34
*** sigmavirus24 has left #openstack-horizon16:35
*** hhuang has quit IRC16:42
openstackgerritJiri Tomasek proposed openstack/horizon: Modal fixes - 2 columns, padding, header, membership  https://review.openstack.org/11351916:43
openstackgerritJiri Tomasek proposed openstack/horizon: Modal template updates  https://review.openstack.org/13564916:44
*** nikunj2512_ has quit IRC16:47
*** TravT_ has joined #openstack-horizon16:47
*** nikunj2512 has joined #openstack-horizon16:47
openstackgerritJiri Tomasek proposed openstack/horizon: Modal fixes - 2 columns, padding, header, membership  https://review.openstack.org/11351916:48
ericpetersonjpich:  I think the DOS session thing is just how django is supposed to work.  ironic that the cookie based sessions are more secure for this16:49
*** jcoufal has quit IRC16:49
*** TravT has quit IRC16:49
*** ttrifonov is now known as zz_ttrifonov16:49
jpichericpeterson: Ok. If it can become a serious problem I wonder if it may be worth filing a bug to write a security note for it? Or maybe add a note in our docs since we talk about sessions there16:49
ericpetersonif you have csrf protection on the login view, sessions are needed.... etc.16:50
ericpetersonthere are definitely some settings that will help make this less of a problem16:50
ericpetersonsetting SESSION_COOKIE_AGE to a smaller value (default is 2 weeks), and running frequent cron jobs to cleanup sessions will help16:51
*** rbertram is now known as rbertram_afk16:52
*** doug-fish has quit IRC16:53
*** doug-fish has joined #openstack-horizon16:54
*** robcresswell has quit IRC16:54
*** k4n0 has quit IRC16:56
*** bpokorny has joined #openstack-horizon16:56
openstackgerritPaul Karikh proposed openstack/horizon: Add fix for incorrect display email in inline editing input  https://review.openstack.org/12245417:00
*** tqtran has joined #openstack-horizon17:00
*** Longgeek has joined #openstack-horizon17:03
*** kmartin has joined #openstack-horizon17:04
jristdavid-lyle: I wonder if it'd be good to send a summary email out about decisions in the huge angular email (cc: r1chardj0n3s_afk )17:07
*** Drago has quit IRC17:07
david-lylejrist: I think we're closing on decisions, but not sure we're to the making them record stage yet17:08
david-lylehopefully close17:08
jristyeah17:08
jristjust saying17:08
jristit is kind of out of hand :)17:08
*** Longgeek has quit IRC17:08
jpichI guess still-in-process summary may help people who couldn't keep up with the entire thread as well17:09
nikunj2512akrivoka: Hi17:09
david-lylethis is surprising?17:09
ericpetersonmaybe like we are at the 8 track instead of record level ?17:09
ericpetersonreel : reel17:09
*** Sukhdev has quit IRC17:09
david-lylekeepin' it reel17:09
*** jtomasek has quit IRC17:12
akrivokanikunj2512: one way would be to change the cookie name from 'horizon_instance_log_length' to, say 'instance_log_length'17:12
*** jacalcat has quit IRC17:14
nikunj2512akrivoka: Ok17:16
*** jpich has quit IRC17:19
*** packet has joined #openstack-horizon17:22
*** sayan_ has joined #openstack-horizon17:23
ericpetersondid the code that placed the allowed flags in the session get removed???  I ask b/c that limits us to using PickleSerializer, which is no longer recommended.  JSONSerializer is the recommended approach, but only supports basic types.17:23
*** sayan_ has quit IRC17:25
*** ygbo has quit IRC17:25
*** sayan_ has joined #openstack-horizon17:25
openstackgerritNikunj Aggarwal proposed openstack/horizon: Adds ability to set default log length  https://review.openstack.org/13219717:27
*** nikunj2512 has quit IRC17:32
*** cedricss has quit IRC17:36
*** e0ne has quit IRC17:38
openstackgerritSeb Hughes proposed openstack/horizon: Adds ability to change default log length  https://review.openstack.org/13219717:38
*** circ-user-DSgzN has joined #openstack-horizon17:39
*** amotoki has quit IRC17:39
lhcheng_jrist: ++ on having the PTL read through the email thread and summarize it. :D17:43
lhcheng_thanks david-lyle :)17:43
*** ala_ has quit IRC17:44
*** doug-fish1 has joined #openstack-horizon17:46
tqtranlol another item to add to the Horizon team meeting17:46
tqtranemail summarize this week17:46
*** tnovacik has joined #openstack-horizon17:47
*** doug-fish has quit IRC17:48
david-lylelhcheng_, jrist, I just want to be clear... You want me to summarize email chains that you don't want to muster the energy to read? Are you proposing this as a request based process?17:49
jristLOL17:49
jristwow17:49
jristnot nice, d17:49
*** Poornima has quit IRC17:49
jristI just think that this particularly large email chain (whicH I've been diligently but painfully following) warrants a summary17:49
*** harlowja_away is now known as harlowja17:51
ericpetersonsummary:  stuff is going on, and different people have different opinions17:51
*** sayan is now known as Guest4611717:51
*** sayan_ has quit IRC17:51
david-lyleyes there are two threads on the mailing list that would have been nice to cover in the meeting yesterday, unfortunately our current meeting time isn't conducive to having the drivers for those topics attend17:51
*** sayan_ has joined #openstack-horizon17:52
david-lylejrist: my response was in jest17:52
jristhaha17:52
jristthankfully I know that but others might not17:52
*** rebelagentm has quit IRC17:54
david-lyleI think a summary of the result will be more useful than a summary of the ongoing topic mainly because adding more email on the ongoing chain doesn't seem to reduce the load17:54
lhcheng_david-lyle: haha17:54
*** sayan_ has quit IRC17:54
*** MaxV has quit IRC17:55
*** rdopiera has quit IRC17:55
david-lyleemail chain narration as a  service17:55
*** aktas has joined #openstack-horizon17:57
*** aix has quit IRC17:57
lhcheng_me wonders if summily can summarize it in a sentence17:58
tqtrani think eric just did that17:58
tqtranapplies to every email chain17:58
david-lyle"while you were sleeping... the horizon javascript upstart and the distribution stallwarts neared reconciliation on using bower packages without having to repackage them all as xstatic-packages"17:58
lhcheng_lol17:58
david-lyle"there was much consternation and gnashing of teeth, but resulted in an amicable result"18:00
*** jacalcat has joined #openstack-horizon18:01
lhcheng_david-lyle: nice one! haha18:01
david-lyle"stay tuned..."18:02
lhcheng_david-lyle: thanks, see it is not that bad to summarize the ongoing thread :P18:03
tqtranhttp://martinvalasek.com/blog/pictures-from-a-developers-life18:03
tqtranentertainment while you watch that build go18:04
*** qba73 has quit IRC18:06
*** sambetts has quit IRC18:11
*** TravT_ has quit IRC18:13
*** tnovacik has quit IRC18:13
tzumainnout of curiosity, does anyone know what an "UNSTABLE" gate result means?18:20
*** akrivoka has quit IRC18:22
*** exploreshaifali has quit IRC18:23
*** ArcTanSusan_ has joined #openstack-horizon18:23
david-lylepep8 errors?18:25
*** jacalcat has quit IRC18:26
*** neelashah has quit IRC18:29
*** jacalcat has joined #openstack-horizon18:30
*** zul has quit IRC18:31
*** dkorn has joined #openstack-horizon18:32
openstackgerritRichard Hagarty proposed openstack/horizon: New admin volume panel to manage/unmanage volumes.  https://review.openstack.org/12965218:33
*** ArcTanSusan_ has quit IRC18:33
*** e0ne has joined #openstack-horizon18:34
*** raildo_away is now known as raildo18:36
*** ArcTanSusan_ has joined #openstack-horizon18:38
*** regebro has quit IRC18:38
*** sbfox1 has joined #openstack-horizon18:39
*** neelashah has joined #openstack-horizon18:42
*** wuhg has quit IRC18:43
*** radez_g0n3 is now known as radez18:44
*** ArcTanSusan_ has quit IRC18:45
*** rbertram_afk is now known as rbertram18:48
*** packet has quit IRC18:49
*** hinnant_ has joined #openstack-horizon18:51
*** bradjones has quit IRC18:52
*** pkarikh has quit IRC18:56
*** ArcTanSusan_ has joined #openstack-horizon18:56
*** packet has joined #openstack-horizon19:03
*** MaxV has joined #openstack-horizon19:06
ericpetersonoperator request:  it would be nice to have a url that we can use for horizon health checks.  something like "is horizon running and are the basics looking ok"19:09
*** MaxV has quit IRC19:10
*** aktas has quit IRC19:12
*** sayan has joined #openstack-horizon19:12
*** john-davidge has quit IRC19:20
*** ArcTanSusan_ has quit IRC19:21
*** ArcTanSusan_ has joined #openstack-horizon19:23
*** lupu1 has joined #openstack-horizon19:23
*** zul has joined #openstack-horizon19:26
*** julim has quit IRC19:33
*** Sukhdev has joined #openstack-horizon19:35
*** tosky has quit IRC19:37
*** exploreshaifali has joined #openstack-horizon19:38
*** ongk has joined #openstack-horizon19:42
*** ongk has quit IRC19:45
*** ongk has joined #openstack-horizon19:46
*** jtomasek has joined #openstack-horizon19:47
*** ArcTanSusan_ has quit IRC19:48
*** ArcTanSusan_ has joined #openstack-horizon19:54
*** MaxV has joined #openstack-horizon19:55
*** zul has quit IRC19:59
*** david-lyle is now known as david-lyle_afk20:10
*** zul has joined #openstack-horizon20:10
*** jprovazn_afk has quit IRC20:10
*** ongk has quit IRC20:10
*** ongk has joined #openstack-horizon20:14
*** ongk has quit IRC20:15
*** MaxV has quit IRC20:16
*** MaxV has joined #openstack-horizon20:16
*** r1chardj0n3s_afk is now known as r1chardj0n3s20:25
r1chardj0n3smorning20:25
r1chardj0n3sdavid-lyle_afk appears to have accurately summarised the mega-thread. I think we might have reached a consensus OMG20:35
*** julim has joined #openstack-horizon20:38
*** dkorn has quit IRC20:39
*** julim has quit IRC20:39
*** amcrn has joined #openstack-horizon20:40
*** julim has joined #openstack-horizon20:41
*** jtomasek has quit IRC20:46
*** dsneddon has joined #openstack-horizon20:54
*** sayan has quit IRC20:58
*** e0ne has quit IRC21:00
*** julim has quit IRC21:04
*** ArcTanSusan_ has quit IRC21:07
*** julim has joined #openstack-horizon21:07
*** ArcTanSusan_ has joined #openstack-horizon21:08
*** jasondotstar has joined #openstack-horizon21:12
*** jasondotstar has quit IRC21:13
*** jasondotstar has joined #openstack-horizon21:14
*** ArcTanSusan_ has quit IRC21:17
*** cpalan has joined #openstack-horizon21:19
*** tjones has joined #openstack-horizon21:21
tjoneshi - i have a strange message on the create volume panel. under volume limits it says Total Gigabytes (0 GB)21:21
tjones1,000 <django.utils.functional.__proxy__ object at 0x7fd7fa4d3bd0> Available.  Can someone give me a hint on what to look for?21:21
ericpetersonthat is a localization error, or some variation of it21:22
ericpetersonthe proxy is a lazy loaded string that gets localized21:23
*** absubram__ has quit IRC21:23
tjonesericpeterson: thanks - im new to horizon so im still not sure what to look for.21:24
ericpetersonthose strings typically are written in the code as   _('GB')21:25
ericpetersonwhich would return a localized version of the string GB21:25
tjonesthanks let me look21:25
tjonesthe odd thing then is that the localization for the 0 GB (above) is ok21:29
tjonesnever mind - i see it21:31
tjonesthanks ericpeterson21:31
ericpetersonnp tjones ;)21:31
*** ArcTanSusan_ has joined #openstack-horizon21:32
*** ArcTanSusan_ has quit IRC21:34
*** Sukhdev has quit IRC21:34
*** bpokorny has quit IRC21:37
*** exploreshaifali has quit IRC21:39
*** jacalcat has quit IRC21:40
*** peristeri has quit IRC21:43
*** Dragomir has quit IRC21:50
openstackgerritRichard Hagarty proposed openstack/horizon: Add bootable flag to edit volume panel.  https://review.openstack.org/13573021:53
*** tzumainn has quit IRC21:56
*** ArcTanSusan_ has joined #openstack-horizon21:57
*** crobertsrh is now known as _crobertsrh22:03
tqtranso im working on converting table row actions to angular, if anyone on and would like to give some feedback.....22:05
tqtrantheres two ways to go about it: simple or complex, simple is more HTML based, while complex would rely more on directive22:06
tqtranexample of simple:22:06
tqtran<div class="btn-group">             <a href="#" class="btn btn-default btn-sm ajax-modal" id="">Edit</a>             <a class="btn btn-default btn-sm dropdown-toggle" data-toggle="dropdown" href="#">               <span class="caret"></span>             </a>             <ul class="dropdown-menu row_actions clearfix">               <li class="clearfix">                 <button class="btn btn-default btn-sm btn-toggle" disabled="22:06
*** bpokorny has joined #openstack-horizon22:06
tqtranadvantages is that its easier to modify22:07
*** zul has quit IRC22:07
tqtrancomplex would be something like:22:07
gary-smithhttp://paste.openstack.org/ ?22:07
tqtranhm... good idea lol22:07
*** Sukhdev has joined #openstack-horizon22:08
tqtransimple: http://paste.openstack.org/show/134953/22:09
*** openstackgerrit has quit IRC22:10
tqtrancomplex: http://paste.openstack.org/show/134954/22:10
*** openstackgerrit has joined #openstack-horizon22:10
*** jacalcat has joined #openstack-horizon22:10
tqtranwhat do you think gary? =D since you're on22:11
*** zul has joined #openstack-horizon22:11
gary-smiththe "simple" one looks more complex, and the "complex" one looks simpler22:11
tqtranright, its kinda backwards22:12
tqtranbut the simple one uses more HTML22:12
tqtranso its actually easier to insert your own stuff directly, its not wrapped up inside an angular directive's logic22:12
tqtranif say, in the future, instead of a caret, you want a different icon22:12
tqtrancan just easily replace: <span class="caret"></span>  with something else22:13
*** bpokorny_ has joined #openstack-horizon22:13
tqtranbut if its wrapped up in teh angular directive, have to dig into the javascript22:13
tqtranor not.... =/ since the directive has its own template.... hm......22:13
r1chardj0n3shi tqtran, sorry I didn't see the activity here. will look now :)22:14
gary-smithI guess that's the other part of the equation: the difference in complexity in the javascript22:14
r1chardj0n3sI would say don;t go with the directive at this point22:14
tqtranwell, its going ot be a lot less complex that the django view we have now for sure22:14
r1chardj0n3sin the future we might decide one is helpful, but for now, keep it simpler22:15
tqtranso you're advocating more html for now22:15
r1chardj0n3syep22:15
r1chardj0n3sonce we have a clearer understanding of the patterns in those menus, we can look to directives22:16
*** bpokorny has quit IRC22:16
tqtranwell, the only thing is.... those actions require values and type to be filled, and you'll need directive for those22:17
tqtranso in anycase, you're still going to need directive22:17
tqtranor.... maybe not, i'll think some more22:17
tqtranmight be able to do it via controller22:17
r1chardj0n3sthe disabled, action, type, and label could come from the controller, yeah?22:18
tqtrannot really, since the only data coming back are the ones from the API22:18
r1chardj0n3sthe actions?22:18
tqtranlike which actions to show, and what attributes it should have22:19
tqtranand how it looksl ike22:19
tqtransome buttons are in red, while others are in white22:19
tqtranand there are actually two type of actions, one is a link, and one is a submit22:19
r1chardj0n3sok, so the data is definitely coming from the controller... if I understand you correctly22:19
r1chardj0n3s(I've been meaning to ask why the distinction between link and submit)22:19
tqtranthe data has to come from somewhere, but putting it in the controller isnt right, because the controller is shared between all tables22:20
r1chardj0n3swait, the controller being the view controller in this case22:20
r1chardj0n3sthe one that has the model for the page22:20
tqtrancorrect22:20
r1chardj0n3sso that's not shared across multiple tables22:20
r1chardj0n3sor it shouldn't be - it's created each time that view is viewed22:21
r1chardj0n3sso it'll be alive for that one table22:21
r1chardj0n3sunless I'm missing something bigger in the code you're working on :)22:21
tqtranhttps://review.openstack.org/#/c/133767/2/horizon/static/horizon/js/angular/hz.table.js22:22
tqtranlook for hzTableCtrl22:22
tqtranhttps://review.openstack.org/#/c/133767/2/openstack_dashboard/dashboards/identity/users/templates/users/test.html22:23
tqtranso basically, the controller makes an AJAX call to any view, right now its hard coded to identity22:23
r1chardj0n3shm, I missed that in my original review22:23
*** jasondotstar has quit IRC22:24
tqtranthe idea is that we can reuse this controller for any view22:24
r1chardj0n3sso that controller should be called userTableCtrl or similar22:24
r1chardj0n3sbut how do you re-use it - it has the AJAX call hard coded inside22:24
tqtranso you would pass in a url22:24
tqtranexample22:25
r1chardj0n3show do you "pass in a url" to a controller?'22:25
r1chardj0n3sI think that's the wrong approach; I think the view should have a controller *specific* to it, not a generic one.22:25
tqtranhold on lol22:25
tqtranok right now its a controller, but im going to convert to a directive instead22:26
tqtran<hz-table url="/identity/users/test?data">22:26
tqtranand now the controller is re-usable and generic22:26
r1chardj0n3syikes, yuck22:26
r1chardj0n3ssorry, but that's my reaction :)22:26
*** radez is now known as radez_g0n322:27
r1chardj0n3sI don't like that at all :(22:27
r1chardj0n3sit doesn't provide any ability for a controller to play with the data coming back from the AJAX call22:27
tqtranso you want a controller for each view?22:27
tqtraneven if code is repeated many times in those controller?22:27
r1chardj0n3sthat is how I would do it, yes22:27
r1chardj0n3sthe amount of code repeated is minimal, surely?22:28
r1chardj0n3shmm22:28
r1chardj0n3salso, using the directive like that doesn't allow you to pre-fetch the data during routing22:29
r1chardj0n3slet me find an example of what I mean in angboard22:29
*** packet has quit IRC22:30
r1chardj0n3shttps://github.com/r1chardj0n3s/angboard/blob/master/app/scripts/controllers/cinder.js, https://github.com/r1chardj0n3s/angboard/blob/master/app/scripts/services/cinder.js and https://github.com/r1chardj0n3s/angboard/blob/master/app/views/cinder_volumes.html22:30
r1chardj0n3sso, in that: the cinder service knows how to talk to the AJAX API; the cinder routing pre-fetches the volumes info and provides it through DI to the controller, which then sits behind the view22:31
r1chardj0n3smeans that when the user loads the page, it doesn't show up with an empty table if there's data to be shown (while it's async loading it) because the data has already been loaded before the routing completes22:32
r1chardj0n3smuch, much nicer user experience22:32
r1chardj0n3ssorry, that's a lot to take in :)22:33
tqtrani like what you did too22:35
tqtranhaha, have a couple of questions though22:35
r1chardj0n3ssure thing22:35
tqtranso the controllers, are they all loaded at page load?22:36
r1chardj0n3syep22:36
tqtranhow does angular know to load up app.conf for that specific view?22:37
r1chardj0n3ssorry, app.conf?22:38
r1chardj0n3syou mean app.config?22:38
tqtranso in all of your controller: cinder.js nova.ja etc...22:38
tqtranyes app.config22:38
r1chardj0n3sindex.html loads all the js files22:38
tqtranis it based on the url?22:39
r1chardj0n3sit's a single-page app, so all the controllers, directives, etc. are all loaded all the time22:39
r1chardj0n3sthe js files, that is22:39
*** bpokorny_ has quit IRC22:39
r1chardj0n3sso all those config/run are executed by angular at startup22:39
tqtranright, so right now, django view is handling the url22:39
tqtrannot sure how it would fit in22:40
r1chardj0n3sI envisaged that all of the new angular views would belong to the same single-page app22:40
gary-smithIs there any kind of architecture / diagram how the angular and the django play together?22:41
tqtranyes gary22:41
r1chardj0n3swe talked a bunch about that at the summit22:42
tqtranhttps://www.dropbox.com/s/dyretopq71xdqnm/Django-Angular-Playing-Nice.pdf?dl=022:42
tqtranlast page22:42
tqtransorry page 322:42
*** bpokorny has joined #openstack-horizon22:42
tqtranthe future one is what im working on22:42
gary-smithpage 3 is pain points22:42
tqtranpage 4 apparently22:43
tqtranthe page numbers are wrong! lol its off by one22:43
gary-smith(only after the first page)22:43
*** zul has quit IRC22:43
tqtranpage 5 also22:44
tqtranshows the sequential diagram22:44
r1chardj0n3syep, so for now the single-page app is a django view22:44
r1chardj0n3sbut all the views are just static js files22:44
r1chardj0n3sie. the single-page view has an <ng-view> in it22:45
r1chardj0n3sand the meat of the interface (navbar and title aside) is in the views22:45
r1chardj0n3ssomeone has a patch proposed to remove even the need for the single-page to be a django view22:45
r1chardj0n3sI'm trying to find it ;)22:45
r1chardj0n3soh, lol, it's yours tqtran ;)22:46
tqtranlol22:46
r1chardj0n3sa co-worker is looking into whether that could be turned into an angular solution instead though22:46
tqtranit could probably be22:46
r1chardj0n3sthus we'd have a pure-ish angular top-level single-page app22:46
tqtranwell..... not really....22:47
r1chardj0n3swhich would give us the cleanest starting point for the new work22:47
tqtranthe single-page-navigation still has to hit all of the various django view endpoints22:47
tqtranso django is still directing all of the urls22:47
r1chardj0n3sthe idea would be to stop django doing that for the angular URLs22:48
r1chardj0n3sthat was the vision david-lyle_afk presented to me right at the start of the summit :)22:48
r1chardj0n3sgradually replace the django URLs with in-app angular ones22:48
tqtraneventually yes, but dont think we can pull it off right away22:48
r1chardj0n3sI think we're going to make a lot more work for ourselves if we start down a different path22:49
*** david-lyle_afk is now known as david-lyle22:50
tqtrani think in order to achieve what you want richard, we need the api layer first22:50
tqtransorry, restful api layer first22:51
tqtranwhich we dont have atm22:51
tqtranso things have to go through the view for data still22:51
r1chardj0n3sI think it makes sense for the initial version of that to be in your identity patch22:51
r1chardj0n3sit'd be very small to start with22:51
*** romainh has left #openstack-horizon22:51
r1chardj0n3sI would be happy to contribute :)22:52
tqtranok how about this, if you can propose a patch that makes the identity services for users to be RESTful22:52
tqtrani will be happy to rewrite so that the routing is done client-side22:53
r1chardj0n3sok. I'll put something together and get you to review it for sanity and working with your code :)22:53
tqtranhaha ok22:54
gary-smithwhich bp are you doing this under? django-angular-integration?22:54
r1chardj0n3s*cough* there's a bp?22:54
tqtrananguarlize identity users22:54
r1chardj0n3syes, under that one :)22:54
tqtranhttps://blueprints.launchpad.net/horizon/+spec/angularize-identity-tables22:54
gary-smith:-)22:54
r1chardj0n3s(I'm terribly new to openstack ;)22:54
r1chardj0n3sI still haven't heard a peep from the UX folk on this though22:55
r1chardj0n3shmm22:55
*** gyee has joined #openstack-horizon22:55
*** pastypasty has joined #openstack-horizon22:55
*** gyee has quit IRC22:55
*** MaxV has quit IRC22:56
r1chardj0n3stqtran: do you have a relationship with amny of the UX folk?22:56
tqtransomewhat22:57
gary-smithr1chardj0n3s: didn't you have some kind of prototype of an angular horizon?22:57
r1chardj0n3stqtran: I can re-ping them directly if you like22:57
gary-smithis that something UX could look at?22:57
tqtranjeff is an ibm-er and he has connection into the ux folks, but you contact them directly as well, jarda and ju are very receptive22:57
r1chardj0n3sgary-smith: yes, https://github.com/r1chardj0n3s/angboard22:57
r1chardj0n3stqtran: cool, thanks. they were keen to get in on the identity stuff before too much code was written ;)22:58
r1chardj0n3sgary-smith: that prototype is dead, jim22:58
tqtranwell, its going to look the same, not sure how their input would be useful22:58
tqtranthe look and functionality will be identical, (exception like loading bars while page load, etc....) but for the most part, its going to behave the same way it does today?22:59
r1chardj0n3stqtran: the intent was to get them to look at the current thing and provide suggestions to improve it from a UX perspective23:00
tqtranthat might be true, but until we get the angular stuff to where we are today, i dont think its going to be of much help23:00
tqtranfor me, success is if i can get the angular stuff to work exactly as it works today23:01
tqtranthen we can go from there and get the ux folks involve if we want to enhance somethings23:01
r1chardj0n3sok23:01
r1chardj0n3sso yep, today I'll focus on getting that API thing started. I'll specifically focus on support for the view you've created.23:02
tqtranawesome, much appreciated23:02
r1chardj0n3sI don't intend to provide The Whole API in one go23:02
tqtranno thats fine23:02
r1chardj0n3s:)23:02
*** bpokorny_ has joined #openstack-horizon23:02
*** bpokorny has quit IRC23:05
*** jasondotstar has joined #openstack-horizon23:08
*** TravT has joined #openstack-horizon23:12
*** gyee has joined #openstack-horizon23:18
*** dsneddon has quit IRC23:19
*** jwy has joined #openstack-horizon23:20
*** dsneddon has joined #openstack-horizon23:20
*** TravT has quit IRC23:21
*** TravT has joined #openstack-horizon23:25
*** pastypasty has quit IRC23:30
*** ericpeterson has quit IRC23:30
openstackgerritMerged openstack/horizon: Added a modal dialog with the user credentials details  https://review.openstack.org/9968823:30
*** Dragomir has joined #openstack-horizon23:31
*** jasondotstar has quit IRC23:33
openstackgerritMerged openstack/horizon: Add unit conversion for metering views  https://review.openstack.org/9680023:34
*** TravT has quit IRC23:35
*** TravT has joined #openstack-horizon23:36
*** aberezin has quit IRC23:36
*** tjones has left #openstack-horizon23:36
*** jasondotstar has joined #openstack-horizon23:36
*** julim has quit IRC23:39
*** dsneddon has quit IRC23:40
*** dsneddon has joined #openstack-horizon23:41
*** athomas has quit IRC23:44
*** TravT has quit IRC23:45
*** zul has joined #openstack-horizon23:47
*** vahidh has joined #openstack-horizon23:56

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!