| *** amcrn has joined #openstack-horizon | 00:02 | |
| *** david-lyle is now known as david-lyle_afk | 00:03 | |
| *** bpokorny has joined #openstack-horizon | 00:07 | |
| openstackgerrit | A change was merged to openstack/horizon: Field "Volume name" on Horizon no longer mandatory https://review.openstack.org/132748 | 00:12 |
|---|---|---|
| *** Sukhdev has quit IRC | 00:24 | |
| *** Viswanath has joined #openstack-horizon | 00:25 | |
| *** Viswanath has quit IRC | 00:29 | |
| *** hightall has joined #openstack-horizon | 00:34 | |
| r1chardj0n3s | tqtran: I only just got time to load up your nav menu change; immediate reaction: NICE :) | 00:42 |
| tqtran | r1chardj0n3s: =) yeah, its a simple change that makes things a bit more ajaxy | 00:43 |
| openstackgerrit | A change was merged to openstack/horizon: Honor keystone policy file when creating client https://review.openstack.org/133032 | 00:43 |
| r1chardj0n3s | tqtran: there's a few views which don't quite work (instance details for eg, you get two menus) | 00:44 |
| r1chardj0n3s | tqtran: but I'm going to look into that and the selenium thing | 00:44 |
| r1chardj0n3s | tqtran: can a change in gerrit have multiple authors? or do I need to get any suggested edits to you? (sorry, my gerrit/openstack noobishness coming through ;) | 00:45 |
| *** lhcheng_ has quit IRC | 00:46 | |
| tqtran | you can have multiple authors, example: https://review.openstack.org/#/c/94706/ | 00:47 |
| tqtran | just make sure to list yourself in the commit message Co-Authored-By: | 00:48 |
| r1chardj0n3s | ah, ok, cool. are you ok with me submitting fixes to that change set directly? | 00:48 |
| tqtran | and when you're submitting, just reuse the same Change-Id and you're good to go | 00:48 |
| tqtran | yes, thats fine | 00:48 |
| r1chardj0n3s | ok, great! | 00:48 |
| tqtran | so i started using smart table, it is a bit easier | 00:49 |
| tqtran | but the documentation is a bit poorer | 00:49 |
| r1chardj0n3s | there's mention in the angboard readme about sorting, which I failed to get working when I tried it out weeks ago but got distracted before I had a chance to look into it | 00:50 |
| tqtran | had to debug in order to add checkboxes, and would also require a bit more code to get what we want (im perfectly ok with that, more controll) | 00:50 |
| tqtran | yeah, but i think its ok, simplicity is easier to extend | 00:50 |
| r1chardj0n3s | yep. I like that it integrates better with the HTML | 00:51 |
| tqtran | ng-table has more out of the box, but i think would be more painful to extend | 00:51 |
| r1chardj0n3s | yeah, ng-table is powerful, but complex (especially for adding sorting and filtering, but also its configuration mechanism is kinda odd ;) | 00:51 |
| tqtran | yeah it is lol | 00:51 |
| r1chardj0n3s | fyi I did about 12 months of angular before coming on to rackspace to work on horizon; we used ng-table in a couple of projects and it certainly got the job done, it was just so ... inelegant :) | 00:52 |
| *** ybathia has quit IRC | 00:56 | |
| *** hinnant has quit IRC | 00:57 | |
| *** amerine has quit IRC | 00:58 | |
| *** jacalcat has quit IRC | 01:03 | |
| *** neelashah has joined #openstack-horizon | 01:10 | |
| *** amerine has joined #openstack-horizon | 01:14 | |
| *** amerine has joined #openstack-horizon | 01:15 | |
| *** amcrn has quit IRC | 01:17 | |
| *** gokrokve has quit IRC | 01:19 | |
| *** Drago1 has quit IRC | 01:20 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 01:38 | |
| *** tqtran has quit IRC | 01:39 | |
| *** amerine has quit IRC | 01:40 | |
| *** Viswanath has joined #openstack-horizon | 01:47 | |
| *** Viswanath has quit IRC | 01:51 | |
| *** wuhg has joined #openstack-horizon | 02:00 | |
| openstackgerrit | Gloria Gu proposed a change to openstack/horizon: Added volume type description for volume type https://review.openstack.org/133872 | 02:02 |
| *** cody-somerville has quit IRC | 02:04 | |
| *** clu_ has quit IRC | 02:05 | |
| *** amerine has joined #openstack-horizon | 02:06 | |
| *** bpokorny has quit IRC | 02:10 | |
| *** amerine has quit IRC | 02:11 | |
| openstackgerrit | Gloria Gu proposed a change to openstack/horizon: Fixed issue of progress bars in resize instance https://review.openstack.org/117053 | 02:15 |
| *** jacalcat has joined #openstack-horizon | 02:28 | |
| *** ayoung has joined #openstack-horizon | 02:29 | |
| *** openstackgerrit has quit IRC | 02:34 | |
| *** mattfarina has joined #openstack-horizon | 02:56 | |
| *** mattfarina has quit IRC | 02:57 | |
| *** jacalcat has quit IRC | 02:58 | |
| *** pastypasty has quit IRC | 03:10 | |
| *** Viswanath has joined #openstack-horizon | 03:22 | |
| *** Viswanath has quit IRC | 03:25 | |
| *** vivekd has joined #openstack-horizon | 03:30 | |
| *** dsneddon has quit IRC | 03:33 | |
| *** nlahouti has quit IRC | 03:33 | |
| *** dsneddon has joined #openstack-horizon | 03:34 | |
| *** jacalcat has joined #openstack-horizon | 03:34 | |
| *** tzumainn has quit IRC | 03:49 | |
| *** hightall has quit IRC | 03:50 | |
| *** ericpeterson has joined #openstack-horizon | 03:58 | |
| *** katyafervent is now known as katyafervent_awa | 04:03 | |
| *** jacalcat has quit IRC | 04:16 | |
| *** ericpeterson has quit IRC | 04:17 | |
| *** Drago1 has joined #openstack-horizon | 04:18 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 04:19 | |
| *** Drago1 has quit IRC | 04:19 | |
| *** hightall has joined #openstack-horizon | 04:30 | |
| *** neelashah has quit IRC | 04:49 | |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 04:54 | |
| *** nikunj2512 has joined #openstack-horizon | 04:56 | |
| *** jrist has joined #openstack-horizon | 04:57 | |
| *** colinmcnamara has joined #openstack-horizon | 05:00 | |
| *** colinmcnamara has quit IRC | 05:02 | |
| nikunj2512 | gary-smith: Hi | 05:02 |
| *** sirushti has left #openstack-horizon | 05:36 | |
| *** nlahouti has joined #openstack-horizon | 05:37 | |
| *** sayan has joined #openstack-horizon | 05:45 | |
| *** nlahouti has quit IRC | 06:07 | |
| *** nlahouti has joined #openstack-horizon | 06:07 | |
| *** woodm1979 has quit IRC | 06:13 | |
| *** masco has joined #openstack-horizon | 06:33 | |
| *** k4n0 has joined #openstack-horizon | 06:37 | |
| *** mrunge has joined #openstack-horizon | 06:40 | |
| *** enykeev has quit IRC | 06:42 | |
| *** enykeev has joined #openstack-horizon | 06:44 | |
| *** vijendar has quit IRC | 07:15 | |
| *** vijendar has joined #openstack-horizon | 07:15 | |
| *** enykeev has quit IRC | 07:21 | |
| *** enykeev has joined #openstack-horizon | 07:23 | |
| *** tnovacik has joined #openstack-horizon | 07:29 | |
| *** ramishra has joined #openstack-horizon | 07:33 | |
| *** katyafervent_awa is now known as katyafervent | 07:34 | |
| *** exploreshaifali has joined #openstack-horizon | 07:35 | |
| mrunge | zigo, you may want to comment on that JavaScript thread on openstack-dev | 07:40 |
| mrunge | zigo, especially, because that is about adding new dependencies to Horizon | 07:40 |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 07:43 | |
| r1chardj0n3s | ohai mrunge! I have Dad stuff I need to do but I hope my very brief response to your email just now makes sense! | 07:44 |
| r1chardj0n3s | I'll try to pop back in here over the next few hours... | 07:44 |
| mrunge | r1chardj0n3s, hey | 07:44 |
| mrunge | I was about to answer to your mail | 07:44 |
| r1chardj0n3s | cool, I have to run right now, shall read in a bit :) | 07:44 |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 07:44 | |
| mrunge | r1chardj0n3s_afk, enjoy your dads time! | 07:45 |
| *** exploreshaifali has quit IRC | 07:45 | |
| *** Ala has joined #openstack-horizon | 07:46 | |
| *** Drago2 has joined #openstack-horizon | 07:49 | |
| *** Drago2 has quit IRC | 07:50 | |
| *** enykeev has quit IRC | 07:51 | |
| *** enykeev has joined #openstack-horizon | 07:53 | |
| *** e0ne has joined #openstack-horizon | 07:55 | |
| *** MaxV has joined #openstack-horizon | 07:56 | |
| *** jprovazn has joined #openstack-horizon | 07:56 | |
| *** e0ne has quit IRC | 07:59 | |
| *** e0ne has joined #openstack-horizon | 08:04 | |
| *** Longgeek has joined #openstack-horizon | 08:04 | |
| *** Longgeek has quit IRC | 08:06 | |
| *** Longgeek has joined #openstack-horizon | 08:07 | |
| *** e0ne has quit IRC | 08:07 | |
| *** e0ne has joined #openstack-horizon | 08:11 | |
| *** amerine has joined #openstack-horizon | 08:12 | |
| *** MaxV has quit IRC | 08:16 | |
| *** amerine has quit IRC | 08:17 | |
| *** e0ne has quit IRC | 08:20 | |
| *** ramishra has quit IRC | 08:21 | |
| *** romainh has joined #openstack-horizon | 08:23 | |
| *** zz_ttrifonov is now known as ttrifonov | 08:23 | |
| *** ramishra has joined #openstack-horizon | 08:27 | |
| *** jcoufal has joined #openstack-horizon | 08:28 | |
| *** nlahouti has quit IRC | 08:31 | |
| *** ramishra has quit IRC | 08:36 | |
| *** ramishra has joined #openstack-horizon | 08:40 | |
| nikunj2512 | Is there any way to run a single testcase?? | 08:40 |
| *** enykeev has quit IRC | 08:41 | |
| *** enykeev has joined #openstack-horizon | 08:43 | |
| *** enykeev has quit IRC | 08:50 | |
| *** MaxV has joined #openstack-horizon | 08:53 | |
| pkarikh | nikunj2512, have you tried this? http://blog.jasonmeridth.com/posts/how-to-run-a-single-test-with-tox/ | 08:53 |
| nikunj2512 | pkarikh: No, let me try | 08:55 |
| *** cedrics has joined #openstack-horizon | 08:55 | |
| *** enykeev has joined #openstack-horizon | 08:55 | |
| *** ramishra has quit IRC | 08:55 | |
| *** jpich has joined #openstack-horizon | 08:56 | |
| *** romainh has left #openstack-horizon | 08:57 | |
| *** ramishra has joined #openstack-horizon | 09:00 | |
| nikunj2512 | pkarikh: No, let me try | 09:00 |
| nikunj2512 | pkarikh: Not working :( | 09:00 |
| *** ygbo has joined #openstack-horizon | 09:05 | |
| *** masco_ has joined #openstack-horizon | 09:05 | |
| pkarikh | nikunj2512, have you used '.' or '/' to separate directories it path param? This is quite frech blog post and it says that there is a way to run single test. http://thiagodasilvablog.wordpress.com/2013/11/27/debugging-python-unit-tests-while-using-tox-and-nosetests/. It is strange that nothing about it is not written in the official documentation | 09:05 |
| nikunj2512 | pkarikh: / | 09:06 |
| pkarikh | nikunj2512, could you please try '.'? | 09:06 |
| nikunj2512 | pkarikh: Ok | 09:06 |
| nikunj2512 | pkarikh: failing again due to ImportError | 09:09 |
| pkarikh | nikunj2512, I think you can try to run a single module for a start | 09:10 |
| nikunj2512 | pkarikh: Ok | 09:11 |
| *** amerine has joined #openstack-horizon | 09:13 | |
| *** amerine has quit IRC | 09:18 | |
| *** athomas has joined #openstack-horizon | 09:20 | |
| *** asahlin has quit IRC | 09:21 | |
| *** asahlin has joined #openstack-horizon | 09:22 | |
| *** vivekd has quit IRC | 09:23 | |
| *** vokhrimenko has joined #openstack-horizon | 09:25 | |
| *** ramishra has quit IRC | 09:26 | |
| *** ramishra has joined #openstack-horizon | 09:28 | |
| *** hightall has quit IRC | 09:33 | |
| *** ramishra has quit IRC | 09:35 | |
| *** ramishra has joined #openstack-horizon | 09:39 | |
| *** IvanBerezovskiy has quit IRC | 09:51 | |
| *** cedricss has joined #openstack-horizon | 09:51 | |
| *** cedrics has quit IRC | 09:51 | |
| *** IvanBerezovskiy has joined #openstack-horizon | 09:51 | |
| *** e0ne has joined #openstack-horizon | 09:53 | |
| *** foexle has joined #openstack-horizon | 10:00 | |
| *** cedricss has quit IRC | 10:00 | |
| *** sambetts has joined #openstack-horizon | 10:01 | |
| *** vivekd has joined #openstack-horizon | 10:03 | |
| *** ramishra has quit IRC | 10:04 | |
| *** ramishra has joined #openstack-horizon | 10:05 | |
| *** cedrics has joined #openstack-horizon | 10:06 | |
| *** Longgeek has quit IRC | 10:09 | |
| *** Longgeek has joined #openstack-horizon | 10:10 | |
| *** Longgeek_ has joined #openstack-horizon | 10:12 | |
| *** Longgeek has quit IRC | 10:15 | |
| *** dkorn has joined #openstack-horizon | 10:17 | |
| *** aix has joined #openstack-horizon | 10:18 | |
| *** akrivoka has joined #openstack-horizon | 10:24 | |
| *** enykeev has quit IRC | 10:25 | |
| *** enykeev has joined #openstack-horizon | 10:25 | |
| *** ttrifonov is now known as zz_ttrifonov | 10:31 | |
| *** ramishra has quit IRC | 10:33 | |
| *** ramishra has joined #openstack-horizon | 10:38 | |
| *** regebro has joined #openstack-horizon | 10:42 | |
| *** dkorn has quit IRC | 10:42 | |
| *** jprovazn has quit IRC | 10:43 | |
| pkarikh | nikunj2512 any progress with tests? | 10:48 |
| *** zz_ttrifonov is now known as ttrifonov | 10:57 | |
| nikunj2512 | pkarikh: No.... :(... I am back to run ./run_test.sh | 11:01 |
| *** dkorn has joined #openstack-horizon | 11:01 | |
| *** Dafna has joined #openstack-horizon | 11:02 | |
| *** vivekd_ has joined #openstack-horizon | 11:04 | |
| *** vivekd has quit IRC | 11:05 | |
| *** vivekd_ is now known as vivekd | 11:05 | |
| *** tosky has joined #openstack-horizon | 11:06 | |
| mrunge | nikunj2512, at least you can do: ./run_tests.sh openstack_dashboard --failfast | 11:10 |
| mrunge | nikunj2512, at least that will just run tests of openstack_dashboard and will stop immediately after the first issue was found | 11:11 |
| nikunj2512 | mrunge: ohh.... thank you.. i didn't knew about this | 11:12 |
| nikunj2512 | mrunge: i will do that.... :-) | 11:13 |
| *** enykeev has quit IRC | 11:13 | |
| mrunge | nikunj2512, that still takes lots of time :-( | 11:13 |
| *** aix has quit IRC | 11:14 | |
| *** amerine has joined #openstack-horizon | 11:14 | |
| *** amerine has joined #openstack-horizon | 11:15 | |
| nikunj2512 | mrunge: ohhh... | 11:15 |
| *** enykeev has joined #openstack-horizon | 11:15 | |
| *** colinmcnamara has joined #openstack-horizon | 11:15 | |
| *** cedrics has quit IRC | 11:18 | |
| *** nikunj2512 has quit IRC | 11:19 | |
| *** amerine has quit IRC | 11:19 | |
| *** aix has joined #openstack-horizon | 11:28 | |
| pkarikh | nikunj2512, do I understand you correctly, that now single test run but fail with import error? What if add import for method into method? Just for test, of course. | 11:29 |
| *** kmartin has quit IRC | 11:32 | |
| *** ramishra has quit IRC | 11:34 | |
| zigo | mrunge: Thanks for the pointer, I replied. | 11:34 |
| *** sayan has quit IRC | 11:35 | |
| *** sayan has joined #openstack-horizon | 11:38 | |
| *** colinmcnamara has quit IRC | 11:39 | |
| *** colinmcnamara has joined #openstack-horizon | 11:42 | |
| *** akrivoka has quit IRC | 11:49 | |
| *** mflobo has quit IRC | 11:51 | |
| pkarikh | mrunge, I'm sorry but are you sure that I need to implement CSRF-protection for GET-requests for this patch? https://review.openstack.org/#/c/128253/ It is simple GET request to only filter instances, there is no data changing there. There is no side effects there. So these GET-requests are completly safe , aren't they? | 11:56 |
| *** tzumainn has joined #openstack-horizon | 11:57 | |
| *** lhcheng has joined #openstack-horizon | 12:01 | |
| *** ZZelle has joined #openstack-horizon | 12:04 | |
| *** nikunj2512 has joined #openstack-horizon | 12:04 | |
| *** colinmcnamara has quit IRC | 12:05 | |
| *** akrivoka has joined #openstack-horizon | 12:12 | |
| nikunj2512 | The call user testcase is making user_get.__call__(<class 'django.http.HttpRequest'>, u'1') but it code is expecting user_get.__call__(<class 'django.http.request.HttpRequest'> | 12:15 |
| nikunj2512 | How can i make the above to call to below one??? | 12:15 |
| *** hightall has joined #openstack-horizon | 12:19 | |
| nikunj2512 | figured out | 12:22 |
| pkarikh | nikunj2512 and how you've fixed it? | 12:23 |
| nikunj2512 | pkarikh: i was passing wrong number of arguments.. stupid me... and this problem kept me busy whole... :p | 12:24 |
| nikunj2512 | pkarikh: In actual code i was passing 2 parameters and in test case i was passing 3.. | 12:25 |
| pkarikh | nikunj2512 I think the main thing that you have fixed it :) | 12:31 |
| nikunj2512 | pkarikh: Yes :-) | 12:31 |
| pkarikh | Folks, am I right that since this bug https://bugs.launchpad.net/trove/+bug/1391840 is actial, all 'check-devstack-dsvm-cells' tests are going to be failed? | 12:34 |
| pkarikh | Until this bug would be fixed, I mean. | 12:34 |
| *** ramishra has joined #openstack-horizon | 12:34 | |
| nikunj2512 | pkarikh: Thank You for notifying.. I was wondering was check-devstack-dsvm-cells failing | 12:35 |
| *** ramishra has quit IRC | 12:36 | |
| *** ramishra_ has joined #openstack-horizon | 12:36 | |
| *** exploreshaifali has joined #openstack-horizon | 12:37 | |
| mrunge | pkarikh, I see your patch is just about to change filters. But: you'll be setting a pattern for other patches. | 12:45 |
| mrunge | pkarikh, and you'll open your browsing session to (currently very limited) exploits | 12:45 |
| mrunge | pkarikh, please bear that in mind! | 12:45 |
| *** cedrics has joined #openstack-horizon | 12:51 | |
| pkarikh | mrungeб oh, ok. I know very little about csrf attacks so I going to heed your opinion and place @method_decorator(csrf_protect) around get_data method. | 12:52 |
| mrunge | pkarikh, those attacks are quite simple. | 12:53 |
| mrunge | pkarikh, assume, you're logged into your horizon | 12:53 |
| mrunge | pkarikh, then assume I'll send you an email, which includes an image tag like <img src="http://websrv/horizon/project/images/..."/> | 12:54 |
| *** ramishra_ has quit IRC | 12:55 | |
| mrunge | pkarikh, or I'll trick you to visit a web page containing that link. The image won't be displayed, but your browser will tray to access that image anyways. you won't even notice, you just visited that link. but it executes that link within your current scope. | 12:56 |
| mrunge | pkarikh, that is, why you never should GET for parameters | 12:56 |
| *** tosky has quit IRC | 12:56 | |
| *** ramishra has joined #openstack-horizon | 12:59 | |
| pkarikh | mrunge, yea, I understand this. But If we assume that with GET requests we are going to only retrieve data, and not change it. So, for example, you've send me a link with image url from table filtering. So, browser will create a hidden request to tables with filtering params. Of anothe GET request to any horizon page. As far as I can see, we use GET requests in Horizon only to retrive data. So I just cannot imagine case with unsecure GET req | 13:03 |
| pkarikh | uest. Maybe you could give any example of such case? if it does not take to much time for you, of course. | 13:03 |
| *** ramishra has quit IRC | 13:09 | |
| *** thiagop has joined #openstack-horizon | 13:10 | |
| mrunge | pkarikh, my takeaway from those issues is: just don't do it! If there really is no action (no data change at all!), it may be acceptable | 13:11 |
| *** ramishra has joined #openstack-horizon | 13:11 | |
| pkarikh | mrunge, as far as I can see no data changed at all. But I'm going to try implement csrf protection, you've сonvinced me. :) Thanks for yours time and attention. :) | 13:18 |
| *** crobertsrh has joined #openstack-horizon | 13:20 | |
| mrunge | pkarikh, thank you for taking this serious! I'm quite sure, we're in Horizon are exploitable in one or the other view. e.g network views | 13:21 |
| *** dkorn has quit IRC | 13:29 | |
| *** ramishra has quit IRC | 13:32 | |
| *** Longgeek has joined #openstack-horizon | 13:33 | |
| *** jacalcat has joined #openstack-horizon | 13:34 | |
| *** Longgeek_ has quit IRC | 13:36 | |
| *** ramishra has joined #openstack-horizon | 13:38 | |
| *** ramishra has quit IRC | 13:45 | |
| *** k4n0 has quit IRC | 13:46 | |
| *** ramishra has joined #openstack-horizon | 13:53 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 13:54 | |
| *** jacalcat has quit IRC | 13:54 | |
| *** jacalcat has joined #openstack-horizon | 13:54 | |
| *** sambetts has quit IRC | 13:55 | |
| *** sambetts has joined #openstack-horizon | 13:56 | |
| *** masco has quit IRC | 13:59 | |
| *** asahlin has quit IRC | 14:00 | |
| *** ramishra has quit IRC | 14:01 | |
| *** mattfarina has joined #openstack-horizon | 14:02 | |
| *** ramishra has joined #openstack-horizon | 14:03 | |
| *** sayan has quit IRC | 14:06 | |
| *** julim has joined #openstack-horizon | 14:07 | |
| *** neelashah has joined #openstack-horizon | 14:07 | |
| *** johnma has quit IRC | 14:08 | |
| *** IvanBerezovskiy has left #openstack-horizon | 14:13 | |
| *** gokrokve has joined #openstack-horizon | 14:20 | |
| *** jprovazn has joined #openstack-horizon | 14:21 | |
| *** lhcheng_ has joined #openstack-horizon | 14:22 | |
| *** rbertram has quit IRC | 14:23 | |
| *** rbertram has joined #openstack-horizon | 14:23 | |
| *** lhcheng has quit IRC | 14:24 | |
| *** asahlin has joined #openstack-horizon | 14:30 | |
| *** ramishra has quit IRC | 14:32 | |
| *** colinmcnamara has joined #openstack-horizon | 14:34 | |
| *** tnovacik has quit IRC | 14:38 | |
| *** athomas has quit IRC | 14:38 | |
| *** peristeri has joined #openstack-horizon | 14:39 | |
| *** exploreshaifali has quit IRC | 14:39 | |
| *** openstackgerrit has joined #openstack-horizon | 14:40 | |
| *** ramishra has joined #openstack-horizon | 14:41 | |
| *** athomas has joined #openstack-horizon | 14:42 | |
| *** nikunj2512 has quit IRC | 14:45 | |
| *** nikunj2512_ has joined #openstack-horizon | 14:45 | |
| openstackgerrit | Nikunj Aggarwal proposed openstack/horizon: Fixes Error message when image creation fails due to file filtering https://review.openstack.org/131059 | 14:46 |
| *** sayan has joined #openstack-horizon | 14:58 | |
| *** vivekd has quit IRC | 15:00 | |
| *** jpomero has joined #openstack-horizon | 15:01 | |
| *** cedricss has joined #openstack-horizon | 15:13 | |
| *** gokrokve has quit IRC | 15:13 | |
| *** ramishra has quit IRC | 15:15 | |
| *** cedrics has quit IRC | 15:15 | |
| pkarikh | mrunge, do have a couple minutes? | 15:17 |
| *** ramishra has joined #openstack-horizon | 15:17 | |
| *** lhcheng_ has quit IRC | 15:18 | |
| mrunge | pkarikh, somehow, yes | 15:19 |
| *** doug-fish has left #openstack-horizon | 15:19 | |
| pkarikh | mrunge, as far as I undestand, the common way to defend from csrf is compare csrf-token from user cookie and from reques param. And also to check HTTP_referer header field. Am I right? | 15:19 |
| *** vijendar has quit IRC | 15:19 | |
| *** vijendar has joined #openstack-horizon | 15:20 | |
| pkarikh | from request params | 15:20 |
| mrunge | pkarikh, tbh, I never do that manually, since django provides all needed already built in | 15:20 |
| pkarikh | mrunge, yep, but looks like django @csrf_protect decorator works only with POST requests. | 15:21 |
| mrunge | pkarikh, that may have a reason...? | 15:22 |
| mrunge | pkarikh, https://www.owasp.org/index.php/Cross-Site_Request_Forgery_%28CSRF%29_Prevention_Cheat_Sheet#Disclosure_of_Token_in_URL | 15:24 |
| *** cedricss has quit IRC | 15:24 | |
| *** mrunge has quit IRC | 15:27 | |
| *** johnma has joined #openstack-horizon | 15:27 | |
| *** Ala has quit IRC | 15:27 | |
| pkarikh | mrunge, "For these cases, attempting to retrofit this pattern in existing applications requires significant development time and cost, and as a temporary measure it may be better to pass CSRF tokens in the URL. Once the application has been fixed to respond to HTTP GET and POST verbs correctly, CSRF tokens for GET requests should be turned off." | 15:28 |
| pkarikh | mrunge, so Im condused again. If it is bad practise to send csrf-token in GET_param, how can I send it to the server to validate request? | 15:29 |
| pkarikh | mrunge maybe I've missed something? | 15:30 |
| *** rbertram has quit IRC | 15:30 | |
| *** cedrics has joined #openstack-horizon | 15:31 | |
| *** rbertram has joined #openstack-horizon | 15:32 | |
| *** cody-somerville has joined #openstack-horizon | 15:32 | |
| *** gokrokve has joined #openstack-horizon | 15:32 | |
| openstackgerrit | Thiago Paiva Brito proposed openstack/horizon: Clarifying Project Overview usage labels https://review.openstack.org/79688 | 15:33 |
| *** Longgeek has quit IRC | 15:35 | |
| openstackgerrit | Thiago Paiva Brito proposed openstack/horizon: Clarifying Project Overview usage labels https://review.openstack.org/79688 | 15:37 |
| *** cedricss has joined #openstack-horizon | 15:39 | |
| *** cedrics has quit IRC | 15:40 | |
| *** rebelagentm has joined #openstack-horizon | 15:40 | |
| *** ramishra has quit IRC | 15:41 | |
| *** ramishra has joined #openstack-horizon | 15:42 | |
| *** rebelagentm has quit IRC | 15:45 | |
| *** my_openstack_use has joined #openstack-horizon | 15:45 | |
| my_openstack_use | hello | 15:45 |
| *** ramishra has quit IRC | 15:47 | |
| my_openstack_use | HORIZON_CONFIG appears to only accept a single string for customization module | 15:47 |
| my_openstack_use | Is there any support for multiple customization modules enabled at the same time? | 15:48 |
| my_openstack_use | I have one component that adds a dashboard to horizon and two other components that add their panels to that dashboard through customization module | 15:49 |
| *** david-lyle_afk is now known as david-lyle | 15:52 | |
| david-lyle | my_openstack_use: the preferred way for adding that type of content is https://github.com/openstack/horizon/blob/master/doc/source/topics/settings.rst#pluggable-settings | 15:52 |
| *** ayoung is now known as ayoung-afk | 15:53 | |
| my_openstack_use | thanks, this might be just crazy enough to work | 15:54 |
| *** rebelagentm has joined #openstack-horizon | 16:00 | |
| *** Drago has joined #openstack-horizon | 16:03 | |
| *** Drago has quit IRC | 16:03 | |
| *** Drago has joined #openstack-horizon | 16:03 | |
| *** lhcheng has joined #openstack-horizon | 16:04 | |
| *** lhcheng_ has joined #openstack-horizon | 16:06 | |
| *** MaxV has quit IRC | 16:07 | |
| *** lhcheng has quit IRC | 16:09 | |
| *** hightall has quit IRC | 16:11 | |
| *** MaxV has joined #openstack-horizon | 16:13 | |
| openstackgerrit | Ana Krivokapic proposed openstack/horizon: Add support for locking and unlocking servers https://review.openstack.org/133992 | 16:15 |
| *** tosky has joined #openstack-horizon | 16:16 | |
| *** masco has joined #openstack-horizon | 16:20 | |
| *** hinnant has joined #openstack-horizon | 16:22 | |
| *** ericpeterson has joined #openstack-horizon | 16:25 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 16:32 | |
| *** amerine has joined #openstack-horizon | 16:33 | |
| *** gokrokve_ has joined #openstack-horizon | 16:33 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 16:34 | |
| *** dsneddon has quit IRC | 16:35 | |
| *** Longgeek has joined #openstack-horizon | 16:35 | |
| *** dsneddon has joined #openstack-horizon | 16:35 | |
| *** Viswanath has joined #openstack-horizon | 16:36 | |
| *** gokrokve has quit IRC | 16:36 | |
| *** doug-fish has joined #openstack-horizon | 16:36 | |
| *** gokrokve_ has quit IRC | 16:37 | |
| *** Viswanath has quit IRC | 16:39 | |
| *** lhcheng_ has quit IRC | 16:40 | |
| *** ericpeterson has quit IRC | 16:40 | |
| *** ericpeterson has joined #openstack-horizon | 16:40 | |
| *** nlahouti has joined #openstack-horizon | 16:40 | |
| *** Longgeek has quit IRC | 16:40 | |
| *** ericpeterson has quit IRC | 16:40 | |
| *** ericpeterson has joined #openstack-horizon | 16:41 | |
| *** ericpeterson has quit IRC | 16:42 | |
| *** ericpeterson has joined #openstack-horizon | 16:43 | |
| *** neelashah has quit IRC | 16:43 | |
| *** lhcheng has joined #openstack-horizon | 16:44 | |
| *** ericpeterson has quit IRC | 16:45 | |
| *** vokhrimenko has quit IRC | 16:49 | |
| *** lhcheng_ has joined #openstack-horizon | 16:49 | |
| *** amerine has quit IRC | 16:51 | |
| *** lhcheng has quit IRC | 16:51 | |
| *** e0ne has quit IRC | 16:52 | |
| *** ygbo has quit IRC | 16:55 | |
| *** jacalcat has quit IRC | 16:57 | |
| *** ayoung-afk is now known as ayoung | 16:57 | |
| *** mattfarina has quit IRC | 17:03 | |
| *** MaxV has quit IRC | 17:04 | |
| *** mattfarina has joined #openstack-horizon | 17:04 | |
| *** tqtran has joined #openstack-horizon | 17:07 | |
| *** exploreshaifali has joined #openstack-horizon | 17:08 | |
| *** amerine has joined #openstack-horizon | 17:10 | |
| *** gokrokve has joined #openstack-horizon | 17:12 | |
| *** colinmcnamara has quit IRC | 17:13 | |
| *** wuhg has quit IRC | 17:13 | |
| *** cedricss has quit IRC | 17:14 | |
| openstackgerrit | Gloria Gu proposed openstack/horizon: Added volume type description for volume type https://review.openstack.org/133872 | 17:18 |
| *** colinmcnamara has joined #openstack-horizon | 17:21 | |
| *** bpokorny has joined #openstack-horizon | 17:22 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Single page navigation https://review.openstack.org/114392 | 17:24 |
| *** jroovers has joined #openstack-horizon | 17:26 | |
| *** amcrn has joined #openstack-horizon | 17:31 | |
| *** athomas has quit IRC | 17:39 | |
| *** amcrn has quit IRC | 17:41 | |
| *** akrivoka has quit IRC | 17:42 | |
| *** colinmcnamara has quit IRC | 17:46 | |
| *** jpich has quit IRC | 17:46 | |
| *** masco has quit IRC | 17:47 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Modal form cleanup https://review.openstack.org/123472 | 17:49 |
| *** ttrifonov is now known as zz_ttrifonov | 17:49 | |
| *** afaranha has joined #openstack-horizon | 17:52 | |
| *** amcrn has joined #openstack-horizon | 18:00 | |
| *** my_openstack_use has quit IRC | 18:02 | |
| *** gokrokve has quit IRC | 18:03 | |
| *** gokrokve has joined #openstack-horizon | 18:03 | |
| *** rebelagentm has quit IRC | 18:04 | |
| openstackgerrit | Merged openstack/horizon: add tooltip to cells if 'truncate' variable is set https://review.openstack.org/123889 | 18:05 |
| *** sambetts has quit IRC | 18:05 | |
| *** jroovers has quit IRC | 18:10 | |
| *** doug-fish has left #openstack-horizon | 18:11 | |
| *** nikunj2512_ has quit IRC | 18:11 | |
| *** johnma has quit IRC | 18:15 | |
| *** vijendar has quit IRC | 18:19 | |
| *** aix has quit IRC | 18:19 | |
| *** alexpilotti has joined #openstack-horizon | 18:21 | |
| *** amcrn has quit IRC | 18:23 | |
| *** ericpeterson has joined #openstack-horizon | 18:32 | |
| *** bpokorny_ has joined #openstack-horizon | 18:36 | |
| *** randyochoa has joined #openstack-horizon | 18:37 | |
| *** bpokorny has quit IRC | 18:39 | |
| *** Drago has quit IRC | 18:40 | |
| *** arborism has joined #openstack-horizon | 18:52 | |
| *** arborism is now known as amcrn | 18:53 | |
| *** e0ne has joined #openstack-horizon | 18:54 | |
| *** bpokorny has joined #openstack-horizon | 18:58 | |
| *** bpokorny_ has quit IRC | 19:01 | |
| *** gokrokve has quit IRC | 19:02 | |
| *** gokrokve has joined #openstack-horizon | 19:02 | |
| *** radez_g0` is now known as radez | 19:06 | |
| *** vkmc has joined #openstack-horizon | 19:06 | |
| *** vkmc has quit IRC | 19:06 | |
| *** vkmc has joined #openstack-horizon | 19:06 | |
| *** gokrokve has quit IRC | 19:07 | |
| *** alexpilotti_ has joined #openstack-horizon | 19:09 | |
| *** alexpilotti has quit IRC | 19:09 | |
| *** alexpilotti_ is now known as alexpilotti | 19:09 | |
| *** gokrokve has joined #openstack-horizon | 19:10 | |
| *** johnma has joined #openstack-horizon | 19:11 | |
| *** ZZelle_ has joined #openstack-horizon | 19:11 | |
| *** neelashah has joined #openstack-horizon | 19:15 | |
| *** gokrokve has quit IRC | 19:21 | |
| *** gokrokve has joined #openstack-horizon | 19:21 | |
| *** gokrokve has quit IRC | 19:22 | |
| *** gokrokve has joined #openstack-horizon | 19:22 | |
| *** bpokorny_ has joined #openstack-horizon | 19:27 | |
| *** bpokorn__ has joined #openstack-horizon | 19:29 | |
| *** bpokorny has quit IRC | 19:30 | |
| *** tosky has quit IRC | 19:30 | |
| *** bpokorny_ has quit IRC | 19:32 | |
| *** bpokorny has joined #openstack-horizon | 19:40 | |
| *** bpokorn__ has quit IRC | 19:42 | |
| *** romainh has joined #openstack-horizon | 19:43 | |
| *** romainh has left #openstack-horizon | 19:45 | |
| thiagop | david-lyle: Hi! Have you seen that I broke the patches to change the session backend? | 19:47 |
| openstackgerrit | jmurax proposed openstack/django_openstack_auth: Updated the installation instructions https://review.openstack.org/123003 | 19:48 |
| thiagop | david-lyle: I also submitted a patch to ensure devstack is syncing the db once it has the DATABASES setting | 19:48 |
| david-lyle | thiagop: I saw those | 19:49 |
| david-lyle | the devstack patch seems to have a few issues | 19:49 |
| david-lyle | I've been playing with memcached a bit too | 19:50 |
| david-lyle | may be even easier | 19:50 |
| david-lyle | as devstack already has memcached running | 19:50 |
| thiagop | It depends that the first of horizon's, but I can't put a cross project dependency | 19:50 |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/133889 | 19:50 |
| david-lyle | just adding entries for CACHE in the settings and a couple of middleware classes | 19:51 |
| david-lyle | easier HA config as well | 19:51 |
| david-lyle | shrug | 19:51 |
| david-lyle | found another bug related to cookie size overflow, so was testing it out | 19:52 |
| thiagop | Django supports memcached by default as session backend? | 19:53 |
| thiagop | s/Django/does Django/ | 19:53 |
| david-lyle | yeah as long as it's installed and running | 19:53 |
| david-lyle | Django doesn't handle that part | 19:54 |
| thiagop | I couldn't find anything related in the docs... | 19:54 |
| david-lyle | https://docs.djangoproject.com/en/dev/topics/cache/ | 19:55 |
| *** rebelagentm has joined #openstack-horizon | 19:56 | |
| *** e0ne has quit IRC | 19:57 | |
| thiagop | this would change all caches, not just the session one, right? | 19:58 |
| david-lyle | yes, there's a way to limit it to sessions, working through that | 19:58 |
| *** jprovazn has quit IRC | 19:59 | |
| *** foexle has quit IRC | 19:59 | |
| thiagop | what did you put on the SESSION_ENGINE config? django.contrib.sessions.backends.cache? | 19:59 |
| david-lyle | yes | 20:00 |
| thiagop | I see... | 20:00 |
| thiagop | does Devstack already install memcached by default? | 20:00 |
| david-lyle | yes | 20:01 |
| david-lyle | I'd have to track down where to verify that it's dependable | 20:02 |
| david-lyle | actually the SESSION_ENGINE = 'django.contrib.sessions.backends.cache' change is all that's required | 20:05 |
| david-lyle | it seems | 20:06 |
| david-lyle | then the question is for dev setup | 20:07 |
| *** ArcTanSusan has joined #openstack-horizon | 20:08 | |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 20:09 | |
| r1chardj0n3s | morning | 20:09 |
| david-lyle | r1chardj0n3s: morning | 20:11 |
| *** doug-fish has joined #openstack-horizon | 20:12 | |
| r1chardj0n3s | ooh, lots of email to absorb this morning :) | 20:13 |
| *** jcoufal has quit IRC | 20:15 | |
| david-lyle | r1chardj0n3s: so I'm trying to understand what toolchain you're advocating for deployed Horizon | 20:18 |
| david-lyle | are you still wanting to require dynamically installed dependencies for non-dev environments | 20:19 |
| r1chardj0n3s | david-lyle: IIRC some non-dev environments still wish to run the test suite, so there will need to be some tools in those environments, yes | 20:20 |
| r1chardj0n3s | there wasn't really a complete proposal put forward, I think there's still some discussion to be had around grunt/gulp and whether bower is feasible alternative to xstatic | 20:21 |
| *** exploreshaifali has quit IRC | 20:24 | |
| david-lyle | I just know installing packages from an external repo to a production server isn't going to fly in a lot of situations | 20:27 |
| david-lyle | hopefully most situations | 20:28 |
| r1chardj0n3s | righto. so currently the xstatic packages are repackaged by distros? | 20:28 |
| *** bpokorny has quit IRC | 20:28 | |
| david-lyle | yes | 20:30 |
| r1chardj0n3s | yikes, that's a lot of extra work | 20:32 |
| r1chardj0n3s | would be easier to just bundle the stuff ;) | 20:33 |
| *** alexpilotti has quit IRC | 20:33 | |
| * david-lyle cries | 20:37 | |
| r1chardj0n3s | it'd be sad if the blocker to modernising Horizon is packaging, so we'll come up with some solution | 20:44 |
| david-lyle | so packagers used to break out the 3rd party js libraries embedded in Horizon and just point them at the content of their delivered packages | 20:46 |
| david-lyle | they still do that with xstatic packages too | 20:46 |
| r1chardj0n3s | righto | 20:46 |
| david-lyle | I think we'll be able to arrive at a workable solution, it may maximize the amount of work required to get there, but we can find a solution | 20:47 |
| r1chardj0n3s | yup | 20:48 |
| * r1chardj0n3s breaks fast | 20:49 | |
| rbertram | r1chardj0n3s: re: your doodle. If you scroll right horizontally, top right shows that it is adjusting for your local timezone. Your instructions seem to indicate otherwise. Which way is it? | 20:49 |
| david-lyle | thiagop: it looks like at least keystone, ceilometer, and swift require memcached | 20:49 |
| david-lyle | in devstack | 20:50 |
| thiagop | we have to keep in mind that there is the multi-node configuration also | 20:50 |
| *** e0ne has joined #openstack-horizon | 20:50 | |
| david-lyle | I think memcached actually works fine for that | 20:51 |
| r1chardj0n3s | rbertram: sorry, just posted a clarification (I hope) | 20:51 |
| rbertram | david-lyle: fyi, I'm working on paging/sorting instances BP. Found that the new nova API for sorting does not meet our needs due to database schema. :-( so backing off of "virtual paging". | 20:52 |
| david-lyle | rbertram: how does sorting affect virtual paging? | 20:53 |
| rbertram | davaid-lyle: I think sorting, along w/ filtering, are required to make paging valuable. Given many items, need to get the ones you want to the top. Preferably first page. | 20:55 |
| rbertram | davaid-lyle: Currently in instances you can page down through instances, but not back up. The instances are already sorted by time created. So paging down, and back up, is probably valuable, now that I think of it. | 20:57 |
| rbertram | davaid-lyle: At this point, I'm considering a design that does paging & sorting client-side, works for all APIs. Filtering via API may be needed first. Thoughts, anyone? | 21:00 |
| *** bpokorny has joined #openstack-horizon | 21:05 | |
| thiagop | david-lyle: when we can have a final word about that? Do you want to discuss it on the meeting some more? | 21:08 |
| david-lyle | thiagop: ultimately, I don't care which solution we use, I just was playing with memcached and it seems to work easily. | 21:10 |
| david-lyle | esp. with devstack | 21:10 |
| *** dkorn has joined #openstack-horizon | 21:10 | |
| *** MasterPiece has joined #openstack-horizon | 21:11 | |
| david-lyle | rbertram: that sounds more inline with the outcome of the design session | 21:11 |
| rbertram | david-lyle: :-) everyone told me so | 21:12 |
| thiagop | david-lyle: I was just wondering about persistency and reliability issues that we talked on the last discussion, but... I'm not the best advocate. :) | 21:14 |
| david-lyle | memcached cleans up unused data automatically, so no cron job | 21:15 |
| david-lyle | again, really don't care though :) | 21:15 |
| *** lhcheng_ has quit IRC | 21:16 | |
| thiagop | That is a good motive, though. To set this cron job is a little problem, to erase it on "unstack" is a huge one (that I preferred not even to touch) | 21:17 |
| *** e0ne has quit IRC | 21:21 | |
| *** ArcTanSusan has quit IRC | 21:24 | |
| *** ArcTanSusan has joined #openstack-horizon | 21:25 | |
| *** e0ne has joined #openstack-horizon | 21:25 | |
| *** asahlin has quit IRC | 21:29 | |
| *** lhcheng has joined #openstack-horizon | 21:33 | |
| *** ArcTanSusan has quit IRC | 21:35 | |
| *** raildo has quit IRC | 21:36 | |
| *** Viswanath has joined #openstack-horizon | 21:36 | |
| *** ArcTanSusan has joined #openstack-horizon | 21:37 | |
| *** Viswanath has quit IRC | 21:40 | |
| *** Viswanath has joined #openstack-horizon | 21:41 | |
| *** thiagop has quit IRC | 21:43 | |
| openstackgerrit | George Peristerakis proposed openstack/horizon: [WIP] Standardize the exception handling thrown by services. https://review.openstack.org/134058 | 21:43 |
| *** Viswanath has quit IRC | 21:44 | |
| *** ArcTanSusan has quit IRC | 21:49 | |
| *** nlahouti has quit IRC | 21:51 | |
| *** clu_ has joined #openstack-horizon | 21:52 | |
| *** crobertsrh is now known as _crobertsrh | 21:53 | |
| clu_ | david-lyle: https://review.openstack.org/#/c/123889/6 | 21:54 |
| clu_ | reading you comment there | 21:54 |
| david-lyle | clu_: tried to ping you earlier, left review comment instead | 21:55 |
| clu_ | oopsies | 21:55 |
| clu_ | yeah, I made the assumption that 'truncate 'is only set on columns with strings | 21:56 |
| *** tqtran_ has joined #openstack-horizon | 21:56 | |
| david-lyle | clu_: I'm not sure it's an incorrect assumption | 21:56 |
| clu_ | should I add the string type check? | 21:57 |
| david-lyle | but would like to know that before making that type of change | 21:57 |
| david-lyle | I'm guessing a protective try/except block around the len() call would be safer | 21:58 |
| *** clu__ has joined #openstack-horizon | 21:58 | |
| *** e0ne has quit IRC | 21:58 | |
| clu__ | david-lyle: okay, I will add that for safety then :) | 21:59 |
| *** ArcTanSusan has joined #openstack-horizon | 21:59 | |
| *** mattfarina has quit IRC | 22:01 | |
| *** amcrn has quit IRC | 22:04 | |
| *** nlahouti has joined #openstack-horizon | 22:05 | |
| *** jacalcat has joined #openstack-horizon | 22:16 | |
| *** peristeri has quit IRC | 22:16 | |
| *** gokrokve has quit IRC | 22:18 | |
| *** johnma has quit IRC | 22:28 | |
| *** colinmcnamara has joined #openstack-horizon | 22:28 | |
| *** nlahouti has quit IRC | 22:30 | |
| *** colinmcnamara has quit IRC | 22:38 | |
| *** ericpeterson has quit IRC | 22:39 | |
| *** nlahouti has joined #openstack-horizon | 22:41 | |
| *** dkorn has quit IRC | 22:55 | |
| openstackgerrit | Gloria Gu proposed openstack/horizon: Added volume type description for volume type https://review.openstack.org/133872 | 23:09 |
| *** Sukhdev has joined #openstack-horizon | 23:10 | |
| *** amcrn has joined #openstack-horizon | 23:12 | |
| *** david-lyle is now known as david-lyle_afk | 23:12 | |
| *** ArcTanSusan has quit IRC | 23:16 | |
| *** ArcTanSusan has joined #openstack-horizon | 23:20 | |
| *** Sukhdev has quit IRC | 23:27 | |
| *** colinmcnamara has joined #openstack-horizon | 23:27 | |
| *** neelashah has quit IRC | 23:29 | |
| r1chardj0n3s | jtomasek, ayoung: ping? | 23:35 |
| *** ArcTanSusan_ has joined #openstack-horizon | 23:36 | |
| *** ZZelle_ has quit IRC | 23:37 | |
| *** tqtran_ has quit IRC | 23:37 | |
| *** ArcTanSusan has quit IRC | 23:38 | |
| *** ArcTanSusan_ is now known as ArcTanSusan | 23:38 | |
| *** exploreshaifali has joined #openstack-horizon | 23:48 | |
| *** doug-fish has left #openstack-horizon | 23:49 | |
| *** gokrokve has joined #openstack-horizon | 23:56 | |
| *** amotoki has joined #openstack-horizon | 23:56 | |
| *** rebelagentm has quit IRC | 23:57 | |
| *** colinmcnamara has quit IRC | 23:58 | |
| *** ArcTanSusan has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!