Tuesday, 2014-10-21

*** gokrokve_ has quit IRC00:01
*** sbfox has quit IRC00:04
*** zigo has quit IRC00:07
*** ybathia has quit IRC00:08
*** jacalcat has quit IRC00:09
*** david-lyle has quit IRC00:12
*** zigo has joined #openstack-horizon00:13
*** david-lyle has joined #openstack-horizon00:15
openstackgerritAuston McReynolds proposed a change to openstack/horizon: Disallow Resize Volume If Status Is Shutdown  https://review.openstack.org/12945900:27
*** asahlin has quit IRC00:33
*** asahlin has joined #openstack-horizon00:33
*** gokrokve has joined #openstack-horizon00:42
openstackgerritA change was merged to openstack/horizon: Update JavaScript best practices  https://review.openstack.org/11759500:45
*** colinmcnamara has joined #openstack-horizon00:56
*** gokrokve has quit IRC01:02
*** r1chardj0n3s_afk is now known as r1chardj0n3s01:02
*** gokrokve has joined #openstack-horizon01:03
*** amotoki has joined #openstack-horizon01:04
*** gokrokve has quit IRC01:07
*** bpokorny has quit IRC01:08
*** ArcTanSusan has quit IRC01:12
*** ArcTanSusan has joined #openstack-horizon01:21
*** Longgeek has joined #openstack-horizon01:21
*** radez_g0n3 is now known as radez01:24
*** colinmcnamara has quit IRC01:25
*** Longgeek has quit IRC01:27
*** sbfox has joined #openstack-horizon01:27
*** ArcTanSusan has quit IRC01:28
*** gokrokve has joined #openstack-horizon01:29
*** gokrokve has quit IRC01:31
*** nlahouti1 has quit IRC01:31
*** gokrokve has joined #openstack-horizon01:31
*** jacalcat has joined #openstack-horizon01:33
*** sbfox has quit IRC01:35
*** neelashah has joined #openstack-horizon01:44
*** tqtran has quit IRC01:47
*** clu_ has quit IRC01:52
*** jacalcat has quit IRC02:03
*** sbfox has joined #openstack-horizon02:06
*** sbfox has quit IRC02:14
*** wuhg has joined #openstack-horizon02:25
*** david-lyle_ has joined #openstack-horizon02:42
*** david-lyle has quit IRC02:44
*** Dragomir has quit IRC02:49
*** ramishra has joined #openstack-horizon02:52
*** nlahouti has joined #openstack-horizon02:53
*** jacalcat has joined #openstack-horizon02:55
*** exploreshaifali has joined #openstack-horizon02:59
*** radez is now known as radez_g0n303:01
*** amotoki_ has joined #openstack-horizon03:01
*** amotoki has quit IRC03:09
*** amotoki_ is now known as amotoki03:10
*** Longgeek has joined #openstack-horizon03:10
*** exploreshaifali has quit IRC03:12
*** r1chardj0n3s is now known as r1chardj0n3s_afk03:13
*** jacalcat has quit IRC03:14
*** Longgeek has quit IRC03:15
*** rbertram has quit IRC03:29
*** nlahouti has quit IRC03:31
*** ayoung has quit IRC03:35
*** asahlin_ has joined #openstack-horizon03:38
*** asahlin has quit IRC03:41
*** Dragomir has joined #openstack-horizon03:42
*** r1chardj0n3s_afk is now known as r1chardj0n3s03:53
*** Dragomir has quit IRC03:57
*** sbfox has joined #openstack-horizon03:59
*** gokrokve_ has joined #openstack-horizon04:02
*** exploreshaifali has joined #openstack-horizon04:05
*** bradjones has quit IRC04:05
*** gokrokve has quit IRC04:06
*** hhuang has joined #openstack-horizon04:07
*** gokrokve_ has quit IRC04:07
*** bradjones has joined #openstack-horizon04:07
*** ramishra has quit IRC04:13
*** sbfox has quit IRC04:14
*** nlahouti has joined #openstack-horizon04:18
*** ramishra has joined #openstack-horizon04:21
*** vkmc has quit IRC04:21
*** lhcheng has quit IRC04:28
*** exploreshaifali has quit IRC04:53
*** sayan has joined #openstack-horizon05:09
*** tzumainn has quit IRC05:12
*** nlahouti has quit IRC05:14
*** nlahouti has joined #openstack-horizon05:14
*** gokrokve has joined #openstack-horizon05:25
*** Sukhdev has joined #openstack-horizon05:30
*** harlowja is now known as harlowja_away05:30
*** gokrokve has quit IRC05:34
*** gokrokve has joined #openstack-horizon05:34
*** exploreshaifali has joined #openstack-horizon05:37
*** Longgeek has joined #openstack-horizon05:41
*** Longgeek has quit IRC05:47
*** david-lyle_ has quit IRC05:48
*** sbfox has joined #openstack-horizon05:49
*** k4n0 has joined #openstack-horizon05:50
*** gokrokve has quit IRC05:57
*** gokrokve has joined #openstack-horizon05:58
*** neelashah has quit IRC06:01
*** gokrokve has quit IRC06:02
*** mrunge has joined #openstack-horizon06:04
*** mrunge has quit IRC06:08
*** mrunge has joined #openstack-horizon06:08
*** r1chardj0n3s is now known as r1chardj0n3s_afk06:14
*** Longgeek has joined #openstack-horizon06:15
*** ramishra has quit IRC06:18
*** gokrokve has joined #openstack-horizon06:28
*** gokrokve has quit IRC06:33
*** jprovazn has joined #openstack-horizon06:40
*** rm_work has quit IRC06:48
*** rm_work has joined #openstack-horizon06:49
openstackgerritMatthias Runge proposed a change to openstack/horizon: Refactor metering dashboard  https://review.openstack.org/10701106:52
*** sayali has joined #openstack-horizon06:53
*** jtomasek has joined #openstack-horizon06:56
*** nlahouti has quit IRC07:03
*** lhcheng has joined #openstack-horizon07:05
*** sbfox has quit IRC07:05
*** Sukhdev has quit IRC07:08
*** e0ne has joined #openstack-horizon07:12
*** lhcheng has quit IRC07:17
*** amcrn has quit IRC07:20
openstackgerritNikita Konovalov proposed a change to openstack/horizon: [Data_processing] auto security group  https://review.openstack.org/12826307:22
openstackgerritNikita Konovalov proposed a change to openstack/horizon: [Data_processing] auto security group  https://review.openstack.org/12826307:22
*** MaxV has joined #openstack-horizon07:23
*** zz_ttrifonov is now known as ttrifonov07:24
openstackgerritMarcin Karkocha proposed a change to openstack/horizon: Fix misleading  message in Update Metadata Form.  https://review.openstack.org/12887807:26
*** sayan has quit IRC07:28
*** gokrokve has joined #openstack-horizon07:28
*** ttrifonov is now known as zz_ttrifonov07:31
*** gokrokve has quit IRC07:33
*** zz_ttrifonov is now known as ttrifonov07:33
*** ttrifonov is now known as zz_ttrifonov07:36
*** vokhrimenko has joined #openstack-horizon07:37
*** aberezin has joined #openstack-horizon07:40
*** zz_ttrifonov is now known as ttrifonov07:45
*** ttrifonov is now known as zz_ttrifonov07:49
*** jcoufal has joined #openstack-horizon07:50
*** mitz has quit IRC07:52
openstackgerritA change was merged to openstack/horizon: Removed references to hadoop data_processing  https://review.openstack.org/12155707:54
*** alexpilotti has joined #openstack-horizon07:54
*** zz_ttrifonov is now known as ttrifonov07:54
*** mitz has joined #openstack-horizon07:55
*** jpich has joined #openstack-horizon07:56
*** ttrifonov is now known as zz_ttrifonov07:59
*** zz_ttrifonov is now known as ttrifonov08:00
*** cedrics has joined #openstack-horizon08:03
*** ygbo has joined #openstack-horizon08:05
*** rdopieralski has joined #openstack-horizon08:08
*** athomas has joined #openstack-horizon08:10
*** qba73 has joined #openstack-horizon08:14
*** aix has joined #openstack-horizon08:18
*** gokrokve has joined #openstack-horizon08:28
pkarikhhi folks! Who can tell me, what exactly means tag DocImact - that patch contains documantation changes or that patch only requires that the documentation has been changed?08:29
*** e0ne has quit IRC08:30
rdopieralskipkarikh: isn't that the same thing?08:31
jpichHi pkarikh. It means the patch affects the documentation (e.g. install guide), it sends an email to the docs team list -> https://wiki.openstack.org/wiki/Documentation/DocImpact08:31
jpichIdeally one would follow up to help the docs team with the update too :)08:31
amotokiAFAIK if a patch has DocImpact flag, a bug will be filed when the patch is merged.08:32
*** gokrokve has quit IRC08:33
pkarikhrdopieralski perhaps I'm not quite formulated the question, sorry. :) I mean, this tag means I'm the author of the commit already changed the documentation, right?08:33
*** lsmola has quit IRC08:33
pkarikh* tag means that the author of commit08:33
*** openstackgerrit has quit IRC08:34
rdopieralskipkarikh: yeah, nobody will change the documentation for you08:34
rdopieralskipkarikh: if your change requires documentation changes, you have to include them in the patch08:34
amotokipkarikh: DocImpact flag means your commit affect the documentaiton and some work on documentation is required.08:35
*** openstackgerrit has joined #openstack-horizon08:35
pkarikhrdopieralski, I always change documentation, but wasn't sure whether to ask another person to change documentation in review. Now it's clear, thanks.08:36
pkarikhamotoki, ok, thank you.08:37
*** sayan has joined #openstack-horizon08:40
*** lsmola has joined #openstack-horizon08:46
*** sayali_ has joined #openstack-horizon08:52
*** bradjones_ has joined #openstack-horizon08:53
*** bradjones has quit IRC08:53
*** bradjones_ is now known as bradjones08:53
*** bradjones has quit IRC08:53
*** bradjones has joined #openstack-horizon08:53
*** sayali has quit IRC08:56
*** lsmola has quit IRC09:05
*** cedrics has quit IRC09:17
*** cedrics has joined #openstack-horizon09:17
*** athomas has quit IRC09:18
*** aix has quit IRC09:19
*** lsmola has joined #openstack-horizon09:20
*** aix has joined #openstack-horizon09:22
*** kaliya has joined #openstack-horizon09:28
*** gokrokve has joined #openstack-horizon09:28
*** athomas has joined #openstack-horizon09:29
*** teju has joined #openstack-horizon09:30
*** gokrokve has quit IRC09:33
*** cedricss has joined #openstack-horizon09:33
*** cedrics has quit IRC09:36
*** e0ne has joined #openstack-horizon09:37
*** sc-rm has joined #openstack-horizon09:40
*** cedrics has joined #openstack-horizon09:43
*** cedricss has quit IRC09:46
*** cedrics has quit IRC09:54
*** nikunj2512 has joined #openstack-horizon09:57
nikunj2512@rdopieralski: This is related to detecting browser version blueprint. Do you have minute to talk?09:59
rdopieralskinikunj2512: sure09:59
nikunj2512@rdopieralski: As i remember we agreed that we will parse the User-Agent string and then inject the message in the base template, correct??10:00
mrungewtf....10:00
nikunj2512mrunge: What happened??10:01
*** kaliya has left #openstack-horizon10:01
rdopieralskinikunj2512: I think I just said that it's the least icky of the solutions that were mentioned10:01
mrungestill that warning thing?10:01
mrungeI'm still not convinced at all nikunj251210:01
*** akrivoka has joined #openstack-horizon10:01
nikunj2512mrunge: Why??10:02
jpichFor stuff we don't support at all like IE8 it makes sense to me, to gently let users know10:02
nikunj2512jpich: that is what my intentions are10:02
rdopieralskijpich: yeah, but then we need an explicit black list of "known broken" versions, I think10:02
*** tosky has joined #openstack-horizon10:02
rdopieralskijpich: I think I would even phrase the message like that, "The browser that you seem to be using is know to have problems with Horizon."10:03
rdopieralskiknown10:03
nikunj2512rdopieralski: yes, we can test things in different browsers with different versions and can come up with a minimum version for browsers in which horizon will work10:03
jpichrdopieralski: That sounds acceptable to me, just the old stuff, and a warning only once on the login page or something - let me people continue at their own risk if they wish10:04
mrungei don't think, it's a good idea to query for browser versions at all10:05
mrungebecause they are changing so fast10:05
nikunj2512jpich: message is not yet decided that is why i asked Horizon community to help and decide what should be the message10:05
rdopieralskinikunj2512: that's not going to work, because the agent string is notoriously tricky to parse, and non-mainstream browsers will appear to be be an old version, but might actually support everything fine10:05
mrungeand we don't remind windows users not to use it10:05
mrungeetc.10:05
rdopieralskimrunge: the idea is to only show it for known broken versions10:05
rdopieralskimrunge: that is, for the versions that are released long time ago and we know don't work10:06
mrungesigh.10:07
nikunj2512@rdopieralski: for non-mainstream browsers, we can tell user that Horizon is not test on this browser and please proceed at Your own risk10:07
rdopieralskimrunge: I don't like it either, I'm just looking for the least wrong way of doing it10:07
rdopieralskinikunj2512: I don't think we should do that10:07
mrungeit sounds like a waste of time for me10:08
rdopieralskimrunge: agreed10:08
mrungesorry nikunj2512 for those harsh words10:08
rdopieralskithen again, we should not discourage contributors :)10:08
mrungeI appreciate *every* contributor10:08
nikunj2512mrunge: nothing to be sorry for but as jpich told, it just to show users that we don't support this version of the browser10:09
jpichI'd agree that a blacklist of old versions/known bad version seems sufficient here10:09
nikunj2512mrunge: if you see the horizon bug list many duplicate bugs are there related to older browsers10:09
mrungenikunj2512, yes, I see that.10:09
rdopieralskinikunj2512: the thing is, if someone has a non-mainstream browser, there is a good chance that they alreay know perfectly well that they use it at their own risk, and often have no choice about it10:09
mrungemaybe we should fix those issues?10:09
mrungeas customers will come exactly with those deprecated, defunct or whatever versions10:10
mrungeand will request to fix10:10
nikunj2512rdopieralski: yes but i think it is our duty to atleast warn them just for once10:10
rdopieralskinikunj2512: it's noty10:10
*** jcoufal has quit IRC10:10
rdopieralskinot10:11
rdopieralskithis is patronizing and annoying10:11
nikunj2512mrunge: The issues which old browsers have specially IE are way too many and i think it will create more mess to support them10:11
mrungenikunj2512, and as long as Windows XP is still more popular than newer Windows versions, folks will use IE 8 (or whatever was latest)10:11
rdopieralskiand drives people into the mainstream browsers, which strenghtens the monopoly and hurts the web itsel10:11
rdopieralskif10:11
mrunge+1 rdopieralski10:11
nikunj2512mrunge, rdopieralski: I seriouly don't know what to say more :(10:12
jpichI don't think we should even try to support unsupported browsers, IE8 is EOL10:12
*** ramishra has joined #openstack-horizon10:13
nikunj2512jpich: +110:13
rdopieralskiwe don't10:13
jpichThere are a few browsers, especially old IEs, that we explicitly don't support, IMO a blacklist with a warning is a nice to have10:13
jpichOtherwise I agree with rdopieralski that we shouldn't have a whitelist of "explicitly tested browsers", that way lies madness10:13
rdopieralskithe warning is only on the login page, by the way10:13
nikunj2512But when user uses horizon in old browsers and when we don't show any kind of message user thinks all will work in this browser10:14
rdopieralskinot on every page or anything like that10:14
jpichThat sounds good to me10:14
mrungejpich, nikunj2512 whenever you need to tweak pages to be shown on ...., there's something completely broken10:14
jpichThat sounds good to me -> +1 login page only, aka once10:14
nikunj2512jpich: Yes warning is only on login page10:14
jpichmrunge: Fancy javascript stuffs usually ends up implying browser restrictions, I suspect it'll get worse before it gets better :|10:15
rdopieralskimrunge: well, normally there would be the issue of caching proxies and the like10:15
rdopieralskimrunge: but horizon is a login-only webpage, so that's not relevant10:15
rdopieralskimrunge: I mean, you won't cache the pages anyways10:16
*** colinmcnamara has joined #openstack-horizon10:17
nikunj2512jpich: that is what we can use bare minimum JS or User-Agent pasring10:17
mrungerdopieralski, yes, but that's not contrary to something said before.10:17
nikunj2512jpich: i wanted to use jquery_migrate but rdopieralski told it can be removed anytime in future10:17
mrungeI'd still vote for supporting a standard, not for supporting a browser10:17
openstackgerritLi Yingjun proposed a change to openstack/horizon: Add floating ip status to table  https://review.openstack.org/12818510:19
rdopieralskimrunge: so compile a list of js and css features that we require, and check those with modernizr?10:19
mrungerdopieralski, no. why?10:19
jpichmrunge: A nice goal, and it might work out that way, showing the warning to people whose browser knowingly don't support X or Y. I doubt most users would know what standard(s) their browser supports10:19
rdopieralskimrunge: supporting a standard is impractical when 1/3 of the market uses browsers that fail to implement it10:20
nikunj2512rdopieralski, jpich: +110:20
mrungemaybe it helps, if we'd create a customer ticket at major vendors for not supporting feature x or y10:20
mrungeand I still think, there is a basis supported by all browsers10:21
rdopieralskimrunge: no, because the browsers in question have been released 10 years ago, are not acticely developed or supported and new versions have it fixed already10:21
nikunj2512mrunge: But how will you still stop users from using old browsers and then saying things are not working10:21
rdopieralskinikunj2512: why do you need to stop users?10:21
mrungenikunj2512, as long as 60% of users are still on wondows xp, what can we do there?10:22
nikunj2512rdopieralski: I meant tell the users to use the lastes version10:22
mrungerdopieralski, we could ask vendors for backporting features ;-)10:23
nikunj2512mrunge: By default XP have IE 8, we can tell them to upgrade to IE 9 or higher10:23
rdopieralskimrunge: won't happen10:23
mrungenikunj2512, really?10:23
nikunj2512mrunge: Do You seriouly think microsoft will do that10:23
mrungeI doubt it10:23
nikunj2512mrunge: Yes10:23
mrungeI still think, we shouldn't use those features, if they are not supported10:24
mrungewhat value do we have from that?10:24
jpichA much nicer user experience for users with recent browsers10:24
jpiche.g. I still struggle to set up networking properly without the network topology view10:24
nikunj2512mrunge: Which features?? You mean we should not use new feature provided by HTML and CSS just because older browsers don't have support10:24
nikunj2512??10:24
mrungenikunj2512, basically: yes10:25
nikunj2512mrunge: User Experince matters. Just think will be still using gmail if they had bad user expericence10:25
nikunj2512??10:25
mrungejpich, struggle to set up networking is mostly due to neutron issues10:25
mrungenikunj2512, why use gmail?10:26
jpichmrunge: The network topology view is still lovely10:26
jpichlol10:26
nikunj2512mrunge: with all respect, that is ridiculuos. Why should we limit ourselves10:26
mrungebecause of user experience?10:26
nikunj2512mrunge: yes10:26
mrungeinteresting.10:26
jpichmrunge: I'm afraid this particular ship has sailed :-)10:26
mrungeIMHO that's highly dependent of your point of view10:27
mrungejpich, yes, probably.10:27
mrungeI still believe it's wrong10:27
nikunj2512mrunge: we can backport the nice horizon features :)10:27
nikunj2512mrunge: we can't backport the nice horizon features :)10:27
nikunj2512mrunge: Sorry missed a not there :p10:28
mrungenikunj2512, sorry, I can't follow you10:28
mrungenikunj2512, why should we backport nice features?10:28
*** gokrokve has joined #openstack-horizon10:28
nikunj2512mrunge: As You should we should not use new feature provided by HTML and CSS. As jpich mentioned that now that is not possible. So, i am saying i don't think so it will be wise to backport most of the nice features of horizon for older browsers10:29
* mrunge waits for the first bug report of a IE 8 user, using a user agent switcher to avoid the warning on the login page10:29
*** gokrokve has quit IRC10:29
nikunj2512mrunge: Backporting will be more cucumbersome and messy than notifying the user10:29
*** gokrokve has joined #openstack-horizon10:30
mrungenikunj2512, I thought you were talking about backporting features to older horizon versions10:30
jpichmrunge: Currently we're getting bugs because some things (like the network topology view) don't work with IE8, so it seems worthwhile giving this notification workaround a shot10:31
nikunj2512mrunge: if user uses user agent switcher then it is their wish and we should not be concern about that10:31
jpichWe can revert it if it causes more issues than it resolves10:31
jpichNo one will be blocked from using horizon10:31
nikunj2512jpich: yes no one will be blocked, just a friendly warning10:31
nikunj2512jpich: And even after the warning if they still want to use it, its their wish but from our end we did our job in notifying them10:32
rdopieralskijpich: the solution that I would have chosen would be to use modernizr to check for the particular features that the network view needs, and display a message in a placeholder only there10:33
rdopieralskijpich: but that's obviously much more work10:33
jpichrdopieralski: If that's the only thing we know doesn't work, it's an option. I wouldn't be surprised if more things are not working though - but I haven't tested it10:34
rdopieralskithat would be the "correct" way10:34
nikunj2512rdopieralski: but broken network topology is just one instance what about broken css??10:34
rdopieralskinikunj2512: you could say that about any bug in Horizon10:34
openstackgerritNikunj Aggarwal proposed a change to openstack/horizon: Fixes resource name problem in "Resources Usage" tab  https://review.openstack.org/12530710:34
*** exploreshaifali has quit IRC10:34
*** gokrokve has quit IRC10:35
rdopieralskinikunj2512: yet we don't display a warning to the users "this application may contain defects, use at own risk"10:35
nikunj2512rdopieralski: yes but It is not as much as screwed up as in older browsers10:35
rdopieralskinikunj2512: instead we try to fix or work around the individual bugs10:35
rdopieralskimaybe we shouldn't be trying to fix all those bugs at once with a single patch10:36
nikunj2512rdopieralski: we are not saying that Horizon is defected, we will be saying the browser doesn't supports some of its features10:36
rdopieralskinikunj2512: you are missing my point10:36
*** ramishra has quit IRC10:36
*** teju has left #openstack-horizon10:37
nikunj2512rdopieralski: Sorry, can You explain what is Your point.10:37
rdopieralskinikunj2512: the fact that there are many bugs related to browsers doesn't mean that we have to fix them all at once with a single patch10:37
rdopieralskinikunj2512: in fact, the more you try to fix at once, the less useful the fix is10:37
nikunj2512rdopieralski: Ok10:38
rdopieralskinikunj2512: yours is at the brink of simply shifting the blame10:38
*** jcoufal has joined #openstack-horizon10:38
rdopieralskithe users don't care whose fault it is that it doesn't work10:38
rdopieralskithey just want a solution10:39
*** jcoufal has quit IRC10:39
nikunj2512rdopieralski: Yes and we are giving them solution10:39
*** jcoufal has joined #openstack-horizon10:39
nikunj2512rdopieralski: We will be telling them upgrade your browser10:39
nikunj2512rdopieralski: But if none of You guys think that this will be a value add to the horizon than we can drop this..10:41
nikunj2512rdopieralski: I am just trying to reduce the problem set10:41
rdopieralskinikunj2512: of course, and we appreciate your work on that10:43
rdopieralskinikunj2512: but we think that the solution you came up with is maybe a little bit too general10:43
rdopieralskinikunj2512: then again, we can try it and see what happens10:43
rdopieralskinikunj2512: I replied to your e-mail to make sure it's clear that there is no consensus on this matter10:45
nikunj2512rdopieralski: Yes, i am also just asking a try, it will not be a major change10:45
*** bradjones has quit IRC10:45
*** bradjones has joined #openstack-horizon10:47
*** sayali__ has joined #openstack-horizon10:51
*** sayali_ has quit IRC10:54
*** ramishra has joined #openstack-horizon10:54
openstackgerritRadomir Dopieralski proposed a change to openstack/horizon: Replace the glyphicons with font awesome icons  https://review.openstack.org/11936910:59
*** cedrics has joined #openstack-horizon11:00
*** exploreshaifali has joined #openstack-horizon11:02
openstackgerritVlad Okhrimenko proposed a change to openstack/horizon: Hide the "Host Aggregates" admin panel if not enabled  https://review.openstack.org/12112711:06
*** ramishra has quit IRC11:14
*** nikunj2512 has quit IRC11:16
*** hhuang has quit IRC11:18
*** gokrokve has joined #openstack-horizon11:28
*** gokrokve has quit IRC11:32
*** jprovazn has quit IRC11:37
*** k4n0 has quit IRC11:37
*** dsneddon has quit IRC11:37
*** vijendar has quit IRC11:37
*** rwsu has quit IRC11:37
*** vijendar has joined #openstack-horizon11:37
*** dsneddon has joined #openstack-horizon11:37
*** jprovazn has joined #openstack-horizon11:37
*** rwsu has joined #openstack-horizon11:38
*** k4n0 has joined #openstack-horizon11:38
*** colinmcnamara has quit IRC11:41
tsufievjpomero, hi! are you there?11:42
*** Longgeek has quit IRC11:42
*** sayali__ has quit IRC11:43
*** jprovazn has quit IRC11:46
*** jprovazn has joined #openstack-horizon11:46
*** k4n0 has quit IRC11:46
*** k4n0 has joined #openstack-horizon11:46
*** aix has quit IRC11:48
*** aix has joined #openstack-horizon11:49
*** Longgeek has joined #openstack-horizon11:50
*** sayali__ has joined #openstack-horizon11:50
*** ZZelle has quit IRC11:51
*** ZZelle has joined #openstack-horizon11:51
*** sayan has quit IRC12:02
*** nikunj2512 has joined #openstack-horizon12:09
nikunj2512rdopieralski: Please say something.. What to do?? Either reject this idea or give it a shot??12:10
rdopieralskinikunj2512: I'm not the king of horizon, I don't make decisions, I can only give you my opinion12:11
rdopieralskinikunj2512: which I did12:11
nikunj2512rdopieralski: So, don't implement... Ok :(.. Thank You12:11
rdopieralskinikunj2512: perhaps you could come to today's team meeting?12:12
rdopieralskinikunj2512: in 4 hours from now12:12
nikunj2512rdopieralski: Ok.. Same channel??12:12
rdopieralskino12:12
rdopieralskihttps://wiki.openstack.org/wiki/Meetings/Horizon12:13
rdopieralskinikunj2512: you can add it to the agenda12:13
nikunj2512rdopieralski: Ok.. Thank You12:13
rdopieralskinikunj2512: that's for the summit12:16
rdopieralskinikunj2512: add it on the wiki12:16
nikunj2512rdopieralski: By editing the wiki??12:17
rdopieralskiyes12:17
rdopieralskiyou can log in with your launchpad account12:17
nikunj2512rdopieralski: i did, so i add below the "Move to DB backend session" topic??12:18
nikunj2512rdopieralski: i edited it, please can you take a look??12:19
rdopieralskinikunj2512: I added it for you12:19
*** tnovacik has joined #openstack-horizon12:19
rdopieralskiah, nevermind, I will delete it12:19
nikunj2512rdopieralski: Thank You12:20
nikunj2512rdopieralski: No i deleted mine12:20
rdopieralskiargh12:20
rdopieralski:)12:20
nikunj2512rdopieralski: Thank You12:20
rdopieralskinikunj2512: this thing wastes much too much time, really12:20
nikunj2512rdopieralski: Yes but i think it will be a good feature to have it in Horizon. We can certainly give this feature a chance :)12:21
nikunj2512rdopieralski: I am pushing this because i wish to improve the user experience for the end-user. And i know everyone here wants the same12:22
*** k4n0 has quit IRC12:28
*** gokrokve has joined #openstack-horizon12:28
jpomerotsufiev, hi12:31
*** gokrokve has quit IRC12:33
*** vkmc has joined #openstack-horizon12:35
*** neelashah has joined #openstack-horizon12:37
*** tnovacik has quit IRC12:40
*** hhuang has joined #openstack-horizon12:43
*** exploreshaifali has quit IRC12:45
akrivokanikunj2512: ping12:50
nikunj2512akrivoka: Hi12:50
akrivokanikunj2512: hi! I was wondering if it's ok if I took over this bug https://bugs.launchpad.net/horizon/+bug/137824012:51
akrivokanikunj2512: I have a fix already12:51
nikunj2512akrivoka: Ok :)12:52
akrivokanikunj2512: great, thanks!12:52
nikunj2512akrivoka: no problem and Thank You :)12:52
tsufievjpomero, hi! I've left a comment in your patch for fixing dynamic select. Seems that some changes in bootstrap has broken it12:54
*** hhuang has quit IRC12:54
*** jprovazn has quit IRC12:57
*** julim has joined #openstack-horizon12:57
jpomerotsufiev, thanks i will take a look12:58
*** jprovazn has joined #openstack-horizon12:59
*** sseago has quit IRC13:02
*** sseago has joined #openstack-horizon13:03
*** Sukhdev has joined #openstack-horizon13:04
*** mrunge has quit IRC13:06
*** sigmavirus24_awa is now known as sigmavirus2413:07
*** tzumainn has joined #openstack-horizon13:07
openstackgerritAna Krivokapic proposed a change to openstack/horizon: Make modal dialogs draggable  https://review.openstack.org/12989613:09
*** _crobertsrh is now known as crobertsrh13:10
*** amotoki has quit IRC13:11
*** sayan has joined #openstack-horizon13:13
*** radez_g0n3 is now known as radez13:17
*** ZZelle has quit IRC13:17
*** freyes has quit IRC13:19
*** freyes has joined #openstack-horizon13:20
*** peristeri has joined #openstack-horizon13:21
*** sseago has quit IRC13:23
*** sseago has joined #openstack-horizon13:24
*** absubram has joined #openstack-horizon13:26
*** jacalcat has joined #openstack-horizon13:31
*** tnovacik has joined #openstack-horizon13:33
*** peristeri has quit IRC13:34
*** peristeri has joined #openstack-horizon13:35
*** ZZelle has joined #openstack-horizon13:35
openstackgerritJustin Pomeroy proposed a change to openstack/horizon: Fix dynamic select layout when help block is displayed  https://review.openstack.org/11702113:35
*** ZZelle has quit IRC13:35
*** jacalcat has quit IRC13:36
*** amotoki has joined #openstack-horizon13:37
*** Drago has joined #openstack-horizon13:39
*** radez is now known as radez_g0n313:41
openstackgerritNikita Konovalov proposed a change to openstack/horizon: [Data_processing] auto security group  https://review.openstack.org/12826313:45
openstackgerritNikita Konovalov proposed a change to openstack/horizon: [Data_processing] fix job_executions table  https://review.openstack.org/12592713:46
*** jprovazn has quit IRC13:47
*** katyafervent_awa is now known as katyafervent13:47
*** jprovazn has joined #openstack-horizon13:48
*** shadower has quit IRC13:49
*** shadower has joined #openstack-horizon13:51
*** exploreshaifali has joined #openstack-horizon13:58
*** ayoung has joined #openstack-horizon13:59
*** sambetts has joined #openstack-horizon14:00
*** gokrokve has joined #openstack-horizon14:01
*** cody-somerville has quit IRC14:03
*** sayali__ has quit IRC14:04
*** sayan has quit IRC14:08
*** tosky has quit IRC14:10
*** ramishra has joined #openstack-horizon14:15
*** cody-somerville has joined #openstack-horizon14:16
*** bradjones has quit IRC14:16
*** Drago has quit IRC14:21
*** ramishra has quit IRC14:21
*** ramishra has joined #openstack-horizon14:23
*** woodm1979 has joined #openstack-horizon14:23
*** ZZelle has joined #openstack-horizon14:24
*** Drago has joined #openstack-horizon14:24
*** gokrokve has quit IRC14:28
*** bradjones has joined #openstack-horizon14:29
*** gokrokve has joined #openstack-horizon14:29
*** tmazur has joined #openstack-horizon14:32
*** bradjones has quit IRC14:37
*** ramishra has quit IRC14:40
*** vijendar has quit IRC14:41
*** vijendar has joined #openstack-horizon14:41
*** ZZelle has quit IRC14:41
*** ZZelle has joined #openstack-horizon14:42
*** ericpeterson has joined #openstack-horizon14:43
*** rbertram has joined #openstack-horizon14:45
*** jprovazn has quit IRC14:47
*** bpokorny has joined #openstack-horizon14:48
ericpetersonI'm seeing the identity panel show up for non admin users in the left hand navigation, but clicking it gives me the "you are not authorized for this url" login screen.  Any ideas???14:50
*** david-lyle_ has joined #openstack-horizon14:54
*** absubram has quit IRC14:54
pkarikhericpeterson have you changed default admin role name?14:58
*** hurgleburgler has joined #openstack-horizon14:58
doug-fishericpeterson: Did you have to do some configuration to make that happen?  I have approximately the master level of horizon and a 1 month old dev stack.  I don't see the Identity Panel when I log in.14:59
*** david-lyle_ has quit IRC15:00
*** Drago has quit IRC15:01
ericpetersonyeah, not changed the admin role15:01
*** tosky has joined #openstack-horizon15:01
ericpetersonif I add this after the policy declaration, it goes away:  permissions = ('openstack.roles.admin', )15:01
ericpetersonsomething is definitely wierd, must be my specific stuff.  thanks for the sanity check doug-fish and pkarikh  :)15:02
*** Sukhdev has quit IRC15:04
pkarikhericpeterson, are you shure that you using stable branch? There some patches about RBAC and checking permissions, but if I'm not mistaken, they have not been merged yet.15:05
*** hhuang has joined #openstack-horizon15:05
ericpetersonI roll on master.  I'm hardcore ;)15:05
*** absubram has joined #openstack-horizon15:06
*** rebelagentm has joined #openstack-horizon15:06
ericpetersonmy name and stable don't go together ;)15:06
*** david-lyle has joined #openstack-horizon15:06
jpichericpeterson: I smell tee-shirts slogans coming up, keep 'em coming!15:07
*** Sukhdev has joined #openstack-horizon15:08
ericpetersonjpich: you will owe all of us some insider tips on Paris and French stuff in general :)15:08
jpichericpeterson: No matter what happens. make sure to carry at least one baguette at all times15:09
tzumainnwhat happens if you do not?15:10
ericpetersonyou don't want to find out15:10
pkarikhericpeterson, you can ensure that you do not affected themes from this bug https://bugs.launchpad.net/horizon/+bug/1161144 or this blueprint https://blueprints.launchpad.net/horizon/+spec/admin-rbac15:10
pkarikhI cannot offer anything more useful, sorry. :)15:10
ericpetersonpkarikh :  my admin role is called admin15:11
ericpetersonit's something else I think15:11
*** neelashah has quit IRC15:11
*** vijendar1 has joined #openstack-horizon15:12
pkarikhericpeterson, ok, sorry that I could not help you. :)15:13
*** ramishra has joined #openstack-horizon15:14
ericpetersonthe method def _can_access(self, request):  in the base class defaults to true for every panel.... the policy stuff is busted15:14
david-lyle_can_access should default to true15:14
david-lyleif there is not policy rule added to limit access, then assume allowed15:15
*** vijendar has quit IRC15:15
david-lylepolicy model is open then allow constraint on top of that15:15
ericpetersonthe identity panels for users and projects is showing up for me, for non admin users15:16
david-lyleit's not just deny and allow selective permission15:16
david-lyleprojects should show up15:16
*** jcoufal has quit IRC15:16
ericpetersonif you are not an admin it does?15:16
david-lyleyes15:17
david-lyleyou will notice it's just a list of projects you have access to15:17
ericpetersonrule:admin_required   why is that in the policy?  that's confusing15:17
david-lyleericpeterson, in what policy15:17
david-lyleyou're question is confusing :)15:18
david-lyles/you're/your15:18
ericpetersonhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/users/panel.py#L2915:19
ericpetersonhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/conf/keystone_policy.json#L4415:19
ericpetersonthat seems to point to admin being req'd15:19
ericpetersonexcept is doesn't work that way15:19
ericpetersonand I added some print output to def _can_access(self, request): in the base class, and every single class is defaulting to return true15:20
ericpetersonI could simplify that method alot if we always want to return true ;)15:21
david-lyleI should unless that policy check passes15:21
*** ramishra has quit IRC15:21
david-lyleerr fails15:21
david-lyleI think an "improvement" when in recently that may have "improved" the behavior15:21
david-lyles/when/went/15:21
ericpetersongit pull it is.  thanks15:22
*** radez_g0n3 is now known as radez15:22
ericpetersonit still shows up.  digging some more.  thanks for the help all15:25
*** neelashah has joined #openstack-horizon15:25
amotokijpich: ping15:26
jpichamotoki: hey15:26
*** cody-somerville has quit IRC15:26
amotokijpich: i see your name as doc liaison. I heard the install guide for juno wil be cut tomorrow.15:26
amotokijpich: do we need to cover how to compile message catalog in the installation guide?15:26
tsufievericpeterson, are you talking about the panel not being hidden? (sorry, too much text to read it all)15:27
* jpich vaguely remembers putting herself as a Horizon point of contact for docs people15:28
amotoki ^^15:28
david-lyleericpeterson, is your policy_check_function not set for some reason?15:28
david-lylehttps://github.com/openstack/horizon/blob/master/horizon/base.py#L12915:28
jpichamotoki: If I recall correctly, the installation guide covers installing using packages so I would say no, it shouldn't be needed because the packages should have the translations already15:29
jpichamotoki: Could you also let me know where I am written down as a docs liaison?15:29
david-lylejpich https://wiki.openstack.org/wiki/CrossProjectLiaisons15:30
amotokijpich: https://wiki.openstack.org/wiki/CrossProjectLiaisons15:30
amotokidavid-lyle: you beat me :p15:30
david-lylewas just looking those up15:31
jpichGood to know. Thanks for the info david-lyle, amotoki15:31
jpichBetter start attending the docs meetings then15:31
david-lyleif you didn't sign up for that, jpich, remove your name15:31
ericpetersontsufiev david-lyle  my issue started with this:  the identity panels for projects and users show up in the navigation, but when I click on them I get the not authorized login screen thing15:32
jpichI'm not quite sure what it entails but I'll figure it out and give it a shot this cycle. I'd like to get a better understanding of how Horizon is covered in the main docs, I'm embarrassed to say I have very little idea15:32
*** exploreshaifali has quit IRC15:32
ericpetersonit seems like if the policy is preventing this eventually, why show it in the nav15:33
amotokijpich: regarding the installation guide, you are correct. it depends on distros and we don't need to take care of it in the installation guide :-)15:33
david-lyleericpeterson, it should not show if the policy rules don't allow15:34
david-lyleyou are correct15:34
jpichamotoki: Sounds good to me so :-)15:34
amotokiregarding docs, we still need to explore how to manage the configuration guides.... horizon dev docs has no stable branch on docs.openstack.org.15:35
*** EmilyW has joined #openstack-horizon15:36
*** cbader has joined #openstack-horizon15:37
david-lyleericpeterson, you said you were in the debugger, you're not getting in https://github.com/openstack/horizon/blob/master/horizon/base.py#L133 ?15:38
*** alexpilotti has quit IRC15:38
tsufievericpeterson, seems like a caching issue to me15:39
ericpetersonit gets into that loop15:39
ericpetersonyeah, it caches on first login - I see that too15:40
tsufievericpeterson, in case you log in - log out, do you still see Identity dashboard?15:42
ericpetersonyep15:43
tsufievoh, I mean log out - log in15:43
david-lylewhich policy check is passing?15:43
ericpetersonyeah, that's what I am doing to test as I don't trust the session allowed thing ;)15:43
david-lylethere are only two for the nav part15:43
jpichamotoki: The configuration guide for the dashboard could use some improvements indeed. Did you have some ideas? I'm thinking starting with the settings, and maybe also updating what is there for customisations (based on our own docs)15:44
ericpetersonpolicy_check((rule,), request) runs with rule = ('identity', 'identity:get_user')   and it returns True15:44
jpichamotoki: Probably the info we have in /doc/ that's aimed at deployers rather than developers should move over... though the limit between deployer customising panels and developer creating panels is blurry15:45
*** hhuang has quit IRC15:45
* jpich going to think about it more15:45
david-lyleand your policy file in openstack_dashboard/conf/policy.json what is the rule?15:45
david-lyleoops keystone.json15:45
amotokijpich: agree. horizon dev docs have two kind of docs: for deployers and for developers.15:46
david-lyleerr, keystone_policy.json15:46
*** sayan has joined #openstack-horizon15:46
ericpeterson   "identity:get_user": "rule:admin_required",15:46
david-lylethere only three tries15:46
david-lylewhat roles does your user have?15:46
ericpeterson_member_15:46
david-lylethat's it15:47
david-lyle?15:47
ericpetersonlemme double check15:47
amotokijpich: i have no good idea on how to improve the config guide on docs.openstack.org.... this is one of the reasons I like radomir's oslo.config proposal.15:47
*** Sukhdev has quit IRC15:48
amotokijpich: I think it is better to discuss it with docs people but personally I run out of time...15:49
ericpetersonI'm _member_ and that's it15:49
openstackgerritMartin Hickey proposed a change to openstack/horizon: Change "System Info" to "System Information"  https://review.openstack.org/12995415:50
jpichamotoki: Yes, that's a good idea. I'll make sure to chat with people during the Summit if not before. Might become a general Kilo task for me :)15:50
*** tqtran has joined #openstack-horizon15:52
*** gokrokve has quit IRC15:52
*** TravT has joined #openstack-horizon15:59
*** lhcheng has joined #openstack-horizon15:59
*** aberezin has quit IRC16:00
*** johnma has joined #openstack-horizon16:00
*** alexpilotti has joined #openstack-horizon16:01
*** alexpilotti_ has joined #openstack-horizon16:04
*** clu_ has joined #openstack-horizon16:04
*** alexpilotti has quit IRC16:07
*** alexpilotti_ is now known as alexpilotti16:07
openstackgerritPaul Karikh proposed a change to openstack/horizon: Rewrite table filtering to use GET-requests  https://review.openstack.org/12825316:08
*** cody-somerville has joined #openstack-horizon16:10
*** hhuang has joined #openstack-horizon16:12
*** qba73 has quit IRC16:15
mgagneReading http://docs.openstack.org/developer/horizon/topics/customizing.html I see you can override existing methods like allowed to hide/disable buttons and stuff. I would also like to be able to override policy_rules attribute but it looks to not be possible. Can someone assist me?16:18
jpichmgagne: Is it not? It sounds like it should like overriding any other attribute, like "allowed" in the example?16:19
mgagnejpich: yep, that was the impression I got but button is still showing so I'm confused as to what I'm doing wrong16:20
*** exploreshaifali has joined #openstack-horizon16:20
jpichmgagne: What did you overwrite it with?16:20
mgagnejpich: here is my use case: http://paste.openstack.org/show/122768/16:21
mgagnejpich: I have an older version which didn't have policy rules for network so I wish to patch it with overrides16:21
*** sambetts has quit IRC16:22
mgagnejpich: HORIZON_CONFIG['customization_module'] is set, POLICY_FILES_PATH and POLICY_PATH are also set with network policy16:23
jpichmgagne: Did neutron_policy.json already exist at the time? You may have to update the POLICY_FILES to reference your new config file otherwise -> https://github.com/openstack/horizon/blob/master/openstack_dashboard/local/local_settings.py.example#L27616:23
jpich...ah :P16:23
mgagnejpich: obviously, my policy denies it and I'm testing with a normal user without admin role16:24
mgagnejpich: if I had the line directly in openstack_dashboard.dashboards.project.networks.tables, it works. using .allowed = NO instead of .policy_rules works fine16:25
*** gokrokve has joined #openstack-horizon16:25
jpichmgagne: If you add the policy_rules straight into the code rather than customisation module, it's picked up correctly?16:27
mgagnejpich: yep16:27
* jpich scratches head16:29
mgagnejpich: is there any config I can enable to debug policy checks?16:29
*** aix has quit IRC16:30
jpichmgagne: ericpeterson was just playing with this... I'm not sure there's anything more sophisticated than "adding debug statement to the 'can_access' method" available currently16:30
mgagnejpich: I don't mind going down that path and debug16:30
mgagnejpich: that will do I guess16:30
*** ttrifonov is now known as zz_ttrifonov16:31
*** lhcheng_ has joined #openstack-horizon16:31
*** Dafna has quit IRC16:31
*** lhcheng has quit IRC16:33
*** packet has joined #openstack-horizon16:34
*** packet has quit IRC16:34
*** packet has joined #openstack-horizon16:34
*** ygbo has quit IRC16:34
mgagnejpich: hahaha16:35
mgagnejpich: found it16:35
jpichmgagne: What is it what is it?16:35
mgagnejpich: the version of Horizon I have embed an old version of the policy enforcer which does not understand "unscoped" policy rule16:36
mgagnejpich: changed create_network rule to network:create_network in policy.json, updated my override accordingly and it's now working fine16:36
jpichmgagne: What does unscoped mean in the context of policies?16:36
jpichOh, I see16:36
mgagnejpich: well, I might use the wrong word16:37
jpichmgagne: The example helped :-)16:37
jpichmgagne: But, wasn't it working when you modified the tables code directly?16:37
* ericpeterson is going to read how mgagne solved this problem16:37
mgagnejpich: let me recheck to be sure16:37
jpichericpeterson: I think it comes from manually defining rules vs. using the default rules as defined in the original policy files, so probably won't help you :-)16:38
mgagnejpich: hmm I might be wrong on the conclusion16:38
jpichericpeterson: ...Or not!16:38
mgagnejpich: but it still worked :-/16:38
mgagnejpich: https://github.com/openstack/horizon/blob/master/openstack_dashboard/openstack/common/policy.py#L53316:38
*** sbfox has joined #openstack-horizon16:39
mgagneok, let me triple check again ^^'16:39
jpichhaha16:40
mgagnejpich: wth... original code is now working fine...16:43
* mgagne defenestrates himself16:43
*** ybathia has joined #openstack-horizon16:44
*** ybathia has quit IRC16:45
*** mfer has joined #openstack-horizon16:46
jpichmgagne: I'm hm glad it's working? Please undefenestrate yourself?16:46
mgagnejpich: I suspected memcache but it looks to not be involved16:46
exploreshaifalitqtran, hi, patch didn't merge till now16:46
exploreshaifalitqtran, https://review.openstack.org/#/c/126141/16:46
asahlin_nikunj2512:  I am fine with showing the message, just wanted to take a step back.16:47
tqtranexploreshaifali: nice, one more +2 to go!16:47
*** ybathia has joined #openstack-horizon16:47
mfertqtran nikunj2512 are you looking to whitelist or blacklist browsers?16:48
*** ybathia has quit IRC16:48
mferi can see messaging a few old ones but in general it's a bad practice to get into16:48
*** vokhrimenko has quit IRC16:48
mfermodernizr makes it pretty easy16:48
exploreshaifalitqtran, yes but it is same since past 5-6 days16:48
mgagnejpich: sorry to have bothered you :P16:49
jpichmgagne: No worries! Happy to be the rubber duck anytime (I'm thinking of https://en.wikipedia.org/wiki/Rubber_duck_debugging but may need a better expression :-))16:50
mgagnejpich: yha, I know that one, I have 3 ducks from conferences here, they are just laughing at me now16:51
jpichhaha16:51
*** cedrics has quit IRC16:53
*** Ala has quit IRC16:56
*** ArcTanSusan has joined #openstack-horizon16:57
nikunj2512asahlin_: Sorry, just now saw Your message.. Ok.. Thank You16:57
nikunj2512mfer: As i mentioned in the meeting that using modernirn to detect all the broken features will be huge and cucumbersome work and it will create a bigger mess16:58
nikunj2512mfer: We can show a message for old browsers and if something is left after that than we can use modernizr to detect that feature and notify the user16:59
mgagnejpich: haha, it worked because I forgot to remove policy_rules in tables.py =(17:00
*** tmazur has quit IRC17:00
tzumainndavid-lyle, out of curiosity, how many contributors were there in icehouse?17:00
jpichmgagne: Maybe you should call it a day? :-)17:00
tqtranexploreshaifali: it takes time for reviews to get approve, be patient =)17:01
*** lhcheng_ has quit IRC17:01
mgagnejpich: I would like to but that's my task for this week :-/17:01
david-lyletzumainn, I think 12617:01
*** lhcheng has joined #openstack-horizon17:01
exploreshaifalitqtran, ok, Thanks!! :)17:01
jpichmgagne: If you still see this tomorrow feel free to open up a bug with that info, I wouldn't mind poking at it a little too, I am curious17:01
*** jpomero has quit IRC17:01
david-lyledid I say Havana in the meeting ?17:01
tzumainndavid-lyle, ah, okay - you mentioned havana and juno, was wondering if there was a deviation in icehouse17:01
david-lyleI keep doing that17:01
mgagnejpich: will debug on my side first17:01
david-lylewhat's icehouse again ;)17:01
tzumainnlol17:01
*** packet has quit IRC17:01
jpichmgagne: Sounds good, please let me know what you find in the end17:02
sigmavirus24nikunj2512: why wouldn't we want to use browser detection (that we'll be adding) to warn people about whether they're susceptible to attacks?17:02
mgagnedavid-lyle: the version I'm working with :P17:02
david-lylemgagne, what failure are you seeing17:03
david-lylereading back, but I don't think I made it far enough17:03
nikunj2512sigmavirus24: I think it is not our job to tell this to the users and when distros releases the patch for that attack, it will fixed17:03
mgagnedavid-lyle: working with policies, trying to override an action and force my own policy rules. not much success here17:03
*** ybathia has joined #openstack-horizon17:03
david-lylehow are you overriding it?17:04
david-lyleand where?17:04
nikunj2512sigmavirus24: But before going too far into future lets implement a simple notification feature which we can extend further later17:04
sigmavirus24nikunj2512: it isn't a distro based problem in the slightest and since we're already taking the position of telling users to update their browsers, we should do it for security too otherwise it's a joke17:04
mgagnedavid-lyle: http://paste.openstack.org/show/122768/17:04
mgagnedavid-lyle: in an overrides included with customization_module17:04
david-lyleok, and what's the result17:04
david-lyle?17:04
mgagnedavid-lyle: hehe, not what I want? override looks to be ignored17:05
nikunj2512sigmavirus24: My primary concern is improving the User Experience for the end user. As i said, first we can implement the warning feature and later we can extend it with other functionalities17:05
*** ArcTanSusan has quit IRC17:05
*** colinmcnamara has joined #openstack-horizon17:05
david-lylemgagne, looking17:05
*** ArcTanSusan has joined #openstack-horizon17:06
sigmavirus24nikunj2512: mind keeping me looped in on the warning/notification feature? I'll write the patch myself if it'll make you feel better17:06
sigmavirus24The reality is, if the user's connection is attacked and successfully decrypted, their experience will be worse for having a compromised openstack installation that an attacker could then take advantage of17:07
david-lylemgagne, you added the neutron policy file to openstack_dashboard/conf ?17:07
nikunj2512sigmavirus24: Due to older browsers users are having bad experience and i think we should first rectify that problem. No problem. Please put Your comments here - https://blueprints.launchpad.net/horizon/+spec/detecting-browser17:07
mgagnedavid-lyle: yep. editing tables.py directly works fine. non-admin users can't see the button17:07
*** zigo has quit IRC17:08
sigmavirus24Thanks for the link nikunj2512 I'll read up and I've already subscribed17:08
nikunj2512sigmavirus24: But first lets start with one thing at a time. Please i request You to put Your comments on the blueprint page for everyone to see.17:08
sigmavirus24nikunj2512: I'm going to17:08
nikunj2512sigmavirus24: Thank You for taking an interest17:08
sigmavirus24I just think ignoring the se17:08
*** zigo has joined #openstack-horizon17:08
mgagnedavid-lyle: http://paste.openstack.org/show/122782/ will try to put in openstack_dashboard/conf instead and see what happens17:08
nikunj2512sigmavirus24: Bye and ??17:08
sigmavirus24*security benefits this could have would be foolish17:08
sigmavirus24bye nikunj251217:08
nikunj2512sigmavirus24: Ok17:09
david-lylemgagne, /etc/openstack-dashboard should be fine17:09
mgagnedavid-lyle: I'm to a point where I will test anything =)17:10
nikunj2512david-lyle: Just one question, So, do we have to discuss about browser detection feature in next horizon meeting??17:10
nikunj2512david-lyle: Or we can do before that also17:10
david-lylenikunj2512, we can do it outside the meeting17:10
david-lylethe meeting directed focus and created attention, that's it's main goal, the rest can be resolved as part of the blueprint process17:11
nikunj2512david-lyle: Ok.. I have already submitted it as a blueprint - https://blueprints.launchpad.net/horizon/+spec/detecting-browser, please take a look17:11
nikunj2512david-lyle: Ok.. Thank You17:11
*** hhuang has quit IRC17:12
*** jpich has quit IRC17:12
nikunj2512david-lyle: Bye17:13
*** nikunj2512 has quit IRC17:13
*** bpokorny has quit IRC17:15
*** harlowja_away is now known as harlowja17:15
*** rdopieralski has quit IRC17:15
david-lylemgagne, I'm not seeing anything obvious, what does policy_rules look like when the action is called?17:18
*** akrivoka has quit IRC17:18
mgagnedavid-lyle: I enabled debug and I don't see any call to o_d.openstack.common.policy on the networks dashboard. I see a bunch in instances though17:19
david-lylemgagne, do you need to override the __init__ method on the CreateNetwork action to pass in the policy rules?17:21
mgagnedavid-lyle: looks to be a class attribute like allowed17:21
*** katyafervent is now known as katyafervent_awa17:21
mgagnedavid-lyle: well, allowed is a method17:22
david-lylehttps://github.com/openstack/horizon/blob/stable/icehouse/horizon/tables/actions.py#L33617:22
david-lylewhich calls https://github.com/openstack/horizon/blob/stable/icehouse/horizon/tables/actions.py#L8717:22
*** bpokorny has joined #openstack-horizon17:23
openstackgerritThai Tran proposed a change to openstack/horizon: Breadcrumbs for all pages  https://review.openstack.org/12998517:24
*** athomas has quit IRC17:24
mgagnedavid-lyle: jesus, are you telling that overriding the class attribute (like with allowed) is not enough as the action class is probably already instantiated at that time? if so, why overriding allowed works? allowed is not a static method.17:24
*** radez is now known as radez_g0n317:24
mgagnedavid-lyle: I'm looking at https://github.com/openstack/horizon/commit/d93722d379c503f16239dbf345b341c679c7210f#diff-241ab3a155bf9729680ae942a9ed26b1 to see if there any required change I missed17:25
david-lylemgagne, I don't know why override the class variable is not working, just trying to figure out what does work and get to where you actually want to be17:25
*** radez_g0n3 is now known as radez17:26
mgagnedavid-lyle: I tried to override verbose_name instead and it's not working so you might be on to something17:27
*** amcrn has joined #openstack-horizon17:27
*** colinmcnamara has quit IRC17:28
*** ZZelle_ has joined #openstack-horizon17:28
david-lyleI think it's getting reinitialized for some reason17:30
david-lyleto None after you set it to your desired value17:30
tqtranoh wow, gerrit stuff shows up here too?17:30
david-lyleanyone notice the check queue os 600+ deep17:32
david-lyleis*17:32
*** bpokorny_ has joined #openstack-horizon17:32
*** bpokorny has quit IRC17:34
clu_tqtran: yeah noticed that recently too :)17:36
tqtranclu_: yeah, thats pretty neat17:38
mgagnedavid-lyle: I will have to pause this work for now but so far, I tried to override the class of the view and redefined CreationNetwork table action and it worked17:38
mgagnedavid-lyle: http://paste.openstack.org/show/122786/17:39
mgagnedavid-lyle: will stick to .allowed = NO for now and come back to it later17:39
*** MaxV has quit IRC17:39
*** exploreshaifali has quit IRC17:41
*** colinmcnamara has joined #openstack-horizon17:41
*** zigo has quit IRC17:41
*** amotoki has quit IRC17:41
*** zigo has joined #openstack-horizon17:41
mgagnedavid-lyle: thanks for your help! will try to find an explanation later when I'll be less in a rush17:42
*** wuhg has quit IRC17:43
*** ArcTanSusan has quit IRC17:45
*** legend has joined #openstack-horizon17:46
*** whitebyte has joined #openstack-horizon17:46
*** legend has left #openstack-horizon17:46
*** david-lyle has quit IRC17:49
*** mfer has quit IRC17:49
*** david-lyle has joined #openstack-horizon17:49
*** sayali__ has joined #openstack-horizon17:51
*** jprovazn has joined #openstack-horizon17:52
*** mfer has joined #openstack-horizon17:52
*** whitebyte has left #openstack-horizon17:54
*** ArcTanSusan has joined #openstack-horizon17:56
*** colinmcnamara has quit IRC18:00
*** bpokorny has joined #openstack-horizon18:01
*** sbfox has quit IRC18:03
*** colinmcnamara has joined #openstack-horizon18:04
*** jpomero has joined #openstack-horizon18:04
*** colinmcnamara has quit IRC18:04
*** bpokorny_ has quit IRC18:05
*** e0ne has quit IRC18:07
*** absubram has quit IRC18:09
*** afaranha has left #openstack-horizon18:10
*** radez is now known as radez_g0n318:14
*** radez_g0n3 is now known as radez18:15
*** dsneddon has quit IRC18:17
*** dsneddon has joined #openstack-horizon18:18
*** exploreshaifali has joined #openstack-horizon18:18
*** mfer has quit IRC18:19
*** sbfox has joined #openstack-horizon18:22
*** aberezin has joined #openstack-horizon18:24
*** Sukhdev has joined #openstack-horizon18:26
*** tosky has quit IRC18:29
*** ArcTanSusan has quit IRC18:33
*** jpomero has quit IRC18:36
*** jpomero has joined #openstack-horizon18:36
*** bpokorny_ has joined #openstack-horizon18:41
*** radez is now known as radez_g0n318:43
*** bpokorny has quit IRC18:44
openstackgerritGary W. Smith proposed a change to openstack/horizon: Add support for volume transfers  https://review.openstack.org/11274118:44
*** sigmavirus24 is now known as sigmavirus24_awa18:51
*** sigmavirus24_awa is now known as sigmavirus2418:52
*** sayan has quit IRC18:55
*** ArcTanSusan has joined #openstack-horizon18:56
*** tnovacik has quit IRC19:00
*** ArcTanSusan has quit IRC19:02
*** mfer has joined #openstack-horizon19:03
*** Longgeek has quit IRC19:04
*** exploreshaifali has quit IRC19:04
*** rbertram has quit IRC19:07
*** sayali__ has quit IRC19:10
ericpetersondavid-lyle:  had to step away for a while.... seems like the allowed stuff and policy files is still kind of weird?19:11
ericpetersonor is there now more proof that I am an idiot?19:11
ericpeterson(both could be true, technically)19:12
openstackgerritA change was merged to openstack/horizon: Fixing typo  https://review.openstack.org/12973819:12
*** cody-somerville has quit IRC19:13
*** radez_g0n3 is now known as radez19:14
*** ayoung has quit IRC19:15
*** jtomasek has quit IRC19:22
*** aberezin has quit IRC19:25
*** MaxV has joined #openstack-horizon19:28
david-lyleericpeterson, worst words when faced with a problem, but it works fine for me on master19:29
david-lylesession overflow issues?19:29
ericpetersonno I found it19:30
ericpetersonthe problem for me was answer b I think: I'm an idiot19:30
david-lyleI was trying to be diplomatic :P19:31
ericpetersonPOLICY_FILES_PATH  not configd correctly19:31
david-lylethat would do it19:31
ericpetersonI just change my irc handle to derp19:33
ericpetersonshould19:33
*** sbfox has quit IRC19:33
ericpetersonsee, I can't even make fun of myself19:33
*** packet has joined #openstack-horizon19:33
*** packet has quit IRC19:35
*** neelashah has quit IRC19:38
*** nlahouti1 has joined #openstack-horizon19:44
*** nlahouti1 has left #openstack-horizon19:50
*** ybathia has quit IRC19:51
*** e0ne has joined #openstack-horizon19:51
*** TravT has quit IRC19:52
*** sbfox has joined #openstack-horizon19:53
*** amcrn has quit IRC19:54
*** neelashah has joined #openstack-horizon19:56
*** zz_ttrifonov is now known as ttrifonov20:03
*** bpokorny has joined #openstack-horizon20:03
*** david-lyle has quit IRC20:04
*** bpokorny_ has quit IRC20:06
*** cody-somerville has joined #openstack-horizon20:09
*** david-lyle has joined #openstack-horizon20:15
*** ayoung has joined #openstack-horizon20:16
*** r1chardj0n3s_afk is now known as r1chardj0n3s20:20
*** colinmcnamara has joined #openstack-horizon20:21
*** e0ne has quit IRC20:25
*** Sukhdev has quit IRC20:26
*** ybathia has joined #openstack-horizon20:29
*** ayoung has quit IRC20:30
*** julim has quit IRC20:33
openstackgerritThai Tran proposed a change to openstack/horizon: Breadcrumbs for all pages  https://review.openstack.org/12998520:39
*** jprovazn has quit IRC20:41
openstackgerritThai Tran proposed a change to openstack/horizon: Add init methods to javascript  https://review.openstack.org/10814420:43
openstackgerritThai Tran proposed a change to openstack/horizon: Add init methods to javascript  https://review.openstack.org/10814420:44
*** ayoung has joined #openstack-horizon20:45
*** radez is now known as radez_g0n320:46
*** ayoung has quit IRC20:47
*** ayoung has joined #openstack-horizon20:47
*** nlahouti has joined #openstack-horizon20:48
*** neelashah has quit IRC20:51
*** neelashah has joined #openstack-horizon20:52
openstackgerritThai Tran proposed a change to openstack/horizon: Single page navigation  https://review.openstack.org/11439220:52
*** katyafervent_awa has quit IRC20:53
*** katyafervent_awa has joined #openstack-horizon20:53
openstackgerritThai Tran proposed a change to openstack/horizon: Single page navigation  https://review.openstack.org/11439220:53
openstackgerritGary W. Smith proposed a change to openstack/horizon: Add support for volume transfers  https://review.openstack.org/11274120:54
*** bpokorny_ has joined #openstack-horizon20:57
*** bpokorn__ has joined #openstack-horizon20:59
gary-smithIs it me, or do the Sahara Hadoop Cluster CI verification jobs complete suspiciously quickly?20:59
*** ybathia has quit IRC20:59
*** bpokorny has quit IRC21:00
gary-smithIs it supposed to be verifying horizon patchsets?21:00
tqtrani noticed that also21:01
tqtranas soon as i upload a patch, it completes haha21:01
*** bpokorn__ has quit IRC21:01
*** bpokorny_ has quit IRC21:01
*** crobertsrh is now known as _crobertsrh21:01
*** mfer has quit IRC21:02
*** lblanchard has joined #openstack-horizon21:14
*** packet has joined #openstack-horizon21:15
*** packet has quit IRC21:15
*** packet has joined #openstack-horizon21:15
*** packet has quit IRC21:16
*** packet has joined #openstack-horizon21:16
*** lblanchard has quit IRC21:19
*** AliceR has joined #openstack-horizon21:25
*** asahlin_ has quit IRC21:27
*** ttrifonov is now known as zz_ttrifonov21:27
*** ybathia has joined #openstack-horizon21:33
*** alexpilotti has quit IRC21:35
*** alexpilotti has joined #openstack-horizon21:38
*** AliceR is now known as aliceR21:39
*** zz_ttrifonov is now known as ttrifonov21:40
openstackgerritCindy Lu proposed a change to openstack/horizon: Resource Usage Overview - reduce dropdown menu width  https://review.openstack.org/13004021:41
*** alexpilotti has quit IRC21:41
*** alexpilotti has joined #openstack-horizon21:43
*** ttrifonov is now known as zz_ttrifonov21:43
*** bpokorny has joined #openstack-horizon21:43
ericpetersonlhcheng or david-lyle... any thoughts on this bug?  https://review.openstack.org/#/q/status:open+project:openstack/django_openstack_auth+branch:master+topic:bug/1357047,n,z21:46
*** woodm1979 has quit IRC21:50
*** amcrn has joined #openstack-horizon21:54
*** MaxV has quit IRC21:55
*** bpokorny_ has joined #openstack-horizon21:59
*** ericpeterson has quit IRC21:59
openstackgerritDoug Fish proposed a change to openstack/horizon: Make status in instance details screen translatable  https://review.openstack.org/13004821:59
lhchengericpeterson, I’ll add some notes on the patch22:01
david-lyleericpeterson, I have no issues with fixing the bug, nor the use of cookies. I'm not a big fan of the use of a classes static method in its constructor though22:01
*** bpokorn__ has joined #openstack-horizon22:01
*** bpokorny has quit IRC22:02
*** bpokorny_ has quit IRC22:03
*** gokrokve has quit IRC22:05
*** cody-somerville has quit IRC22:10
*** david-lyle has quit IRC22:13
*** cody-somerville has joined #openstack-horizon22:15
*** david-lyle has joined #openstack-horizon22:15
*** mrmoje has joined #openstack-horizon22:17
*** jpomero has quit IRC22:22
*** neelashah has quit IRC22:39
*** rebelagentm has quit IRC22:42
*** hurgleburgler1 has joined #openstack-horizon22:43
*** asahlin has joined #openstack-horizon22:43
*** hurgleburgler has quit IRC22:44
*** nlahouti has quit IRC22:46
*** aberezin has joined #openstack-horizon22:46
*** mrmoje has quit IRC22:47
*** gokrokve has joined #openstack-horizon22:48
*** alexpilotti has quit IRC22:52
*** nlahouti has joined #openstack-horizon22:55
*** hurgleburgler has joined #openstack-horizon23:02
*** bpokorny has joined #openstack-horizon23:02
*** bpokorny has quit IRC23:03
*** hurgleburgler1 has quit IRC23:03
*** bpokorn__ has quit IRC23:05
*** MaxV has joined #openstack-horizon23:06
*** bpokorny has joined #openstack-horizon23:07
*** aberezin has quit IRC23:10
*** MaxV has quit IRC23:10
*** doug-fish has left #openstack-horizon23:13
*** EmilyW has quit IRC23:13
*** EmilyW has joined #openstack-horizon23:13
*** cbader has quit IRC23:16
*** peristeri has quit IRC23:18
*** sbfox has quit IRC23:21
*** david-lyle has quit IRC23:30
*** bpokorny has quit IRC23:31
*** hurgleburgler has quit IRC23:41
*** EmilyW has quit IRC23:48
*** sigmavirus24 is now known as sigmavirus24_awa23:52

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!