Thursday, 2014-10-16

*** sbfox has quit IRC00:01
*** cody-somerville has quit IRC00:01
*** ramishra has joined #openstack-horizon00:10
*** packet has joined #openstack-horizon00:18
*** cody-somerville has joined #openstack-horizon00:43
*** cody-somerville has quit IRC00:43
*** cody-somerville has joined #openstack-horizon00:43
*** cody-somerville has quit IRC00:44
*** ramishra has quit IRC00:51
*** ramishra has joined #openstack-horizon00:52
*** ramishra has quit IRC01:02
*** packet has quit IRC01:03
*** hightall has joined #openstack-horizon01:06
*** sunrenjie6 has joined #openstack-horizon01:09
*** r1chardj0n3s is now known as r1chardj0n3s_afk01:14
openstackgerritCindy Lu proposed a change to openstack/horizon: add Column attribute for help tooltip in heading  https://review.openstack.org/12880401:19
*** Longgeek has joined #openstack-horizon01:19
openstackgerritCindy Lu proposed a change to openstack/horizon: add Column attribute for help tooltip in heading  https://review.openstack.org/12880401:21
*** Longgeek has quit IRC01:25
*** bpokorny has quit IRC01:28
*** ramishra has joined #openstack-horizon01:32
*** vkmc has joined #openstack-horizon01:33
*** r1chardj0n3s_afk is now known as r1chardj0n3s01:38
*** clu_ has quit IRC01:39
*** ramishra has quit IRC01:42
*** ramishra has joined #openstack-horizon02:02
*** Longgeek has joined #openstack-horizon02:04
*** sunrenjie6 has quit IRC02:05
*** tqtran has quit IRC02:14
*** nlahouti has joined #openstack-horizon02:19
*** AliceR has quit IRC02:20
*** nlahouti has quit IRC02:23
*** jacalcat has joined #openstack-horizon02:25
*** lhcheng has quit IRC02:31
*** lhcheng has joined #openstack-horizon02:40
*** ramishra_ has joined #openstack-horizon02:58
*** ramishra has quit IRC03:00
*** ybathia has quit IRC03:07
*** ramishra_ has quit IRC03:10
*** jacalcat has quit IRC03:15
*** vkmc has quit IRC03:30
*** ramishra has joined #openstack-horizon03:32
*** harlowja is now known as harlowja_away03:32
*** harlowja_away is now known as harlowja03:34
openstackgerritA change was merged to openstack/horizon: _formset_table_row.html missing i18n tag.  https://review.openstack.org/12861403:38
openstackgerritZhenguo Niu proposed a change to openstack/horizon: Restrict the length of user name input  https://review.openstack.org/12881903:41
*** vivekd has joined #openstack-horizon03:41
*** sbfox has joined #openstack-horizon03:46
*** masco has joined #openstack-horizon03:49
*** AliceR has joined #openstack-horizon03:58
*** amotoki__zzz has quit IRC04:00
*** sayan has joined #openstack-horizon04:12
*** vivekd has quit IRC04:17
*** lhcheng has quit IRC04:19
*** lhcheng has joined #openstack-horizon04:19
*** lhcheng has quit IRC04:24
*** ramishra has quit IRC04:24
*** vivekd has joined #openstack-horizon04:27
*** vivekd has left #openstack-horizon04:28
openstackgerritTravis Tripp proposed a change to openstack/horizon: Base Glance Metadata Definitions Admin UI  https://review.openstack.org/10406304:31
*** nikunj2512 has joined #openstack-horizon04:43
*** hightall has quit IRC05:04
*** lhcheng has joined #openstack-horizon05:05
*** lhcheng has quit IRC05:08
*** lhcheng has joined #openstack-horizon05:09
*** hightall has joined #openstack-horizon05:12
*** masco has quit IRC05:17
*** ramishra has joined #openstack-horizon05:21
*** k4n0 has joined #openstack-horizon05:29
*** Longgeek has quit IRC05:35
*** HenryG has quit IRC05:36
*** sbfox has quit IRC05:37
*** harlowja is now known as harlowja_away05:41
*** sayan has quit IRC05:54
*** amotoki has joined #openstack-horizon05:56
*** coolsvap|afk is now known as coolsvap05:56
openstackgerritA change was merged to openstack/horizon: Hiding device name field when unhandled  https://review.openstack.org/6942305:57
*** Longgeek has joined #openstack-horizon06:03
*** sayan has joined #openstack-horizon06:07
*** mrunge has joined #openstack-horizon06:08
*** masco has joined #openstack-horizon06:10
*** nlahouti has joined #openstack-horizon06:18
*** nlahouti has quit IRC06:18
*** nlahouti has joined #openstack-horizon06:19
*** johnma has quit IRC06:25
*** johnma has joined #openstack-horizon06:25
*** lhcheng has quit IRC06:29
*** sbfox has joined #openstack-horizon06:33
*** echevemaster has quit IRC06:36
*** dsneddon has quit IRC06:36
*** dsneddon has joined #openstack-horizon06:37
*** sayan has quit IRC06:37
*** lhcheng has joined #openstack-horizon06:45
*** exploreshaifali has joined #openstack-horizon06:47
*** nlahouti has quit IRC06:47
*** ramishra has quit IRC06:56
*** dsneddon has quit IRC06:57
*** nlahouti has joined #openstack-horizon06:57
*** ramishra has joined #openstack-horizon06:57
*** dsneddon has joined #openstack-horizon06:58
*** vokhrimenko has joined #openstack-horizon07:03
*** jtomasek has joined #openstack-horizon07:03
*** e0ne has joined #openstack-horizon07:05
*** e0ne has quit IRC07:07
*** sbfox has quit IRC07:09
*** e0ne has joined #openstack-horizon07:11
*** e0ne has quit IRC07:13
openstackgerritMatthias Runge proposed a change to openstack/horizon: Refactor metering dashboard  https://review.openstack.org/10701107:15
*** jcoufal has joined #openstack-horizon07:16
*** ramishra has quit IRC07:16
*** ramishra has joined #openstack-horizon07:17
*** dsneddon has quit IRC07:18
*** dsneddon has joined #openstack-horizon07:18
*** nlahouti has quit IRC07:18
*** Ala has joined #openstack-horizon07:19
*** lhcheng has quit IRC07:20
*** HenryG has joined #openstack-horizon07:20
*** lhcheng has joined #openstack-horizon07:21
*** sayan has joined #openstack-horizon07:21
*** ramishra has quit IRC07:22
openstackgerritA change was merged to openstack/horizon: Fix an encoding exception when creating a public_url  https://review.openstack.org/10845007:22
*** zz_ttrifonov is now known as ttrifonov07:23
*** lhcheng has quit IRC07:26
*** e0ne has joined #openstack-horizon07:28
*** cedrics has joined #openstack-horizon07:28
*** Ala has quit IRC07:30
*** cedrics has quit IRC07:31
*** e0ne has quit IRC07:32
*** cedrics has joined #openstack-horizon07:34
*** jprovazn has joined #openstack-horizon07:36
*** cedrics has quit IRC07:37
*** e0ne has joined #openstack-horizon07:37
*** cedrics has joined #openstack-horizon07:37
*** Ala has joined #openstack-horizon07:37
*** ramishra has joined #openstack-horizon07:38
openstackgerritJiri Tomasek proposed a change to openstack/horizon: Restyled topbar to resemble UX guidelines  https://review.openstack.org/11711807:39
*** cedricss has joined #openstack-horizon07:39
*** sunilm has joined #openstack-horizon07:39
*** cedrics_ has joined #openstack-horizon07:40
*** cedrics has quit IRC07:42
*** cedricss has quit IRC07:44
*** cedrics has joined #openstack-horizon07:44
*** cedricss has joined #openstack-horizon07:45
openstackgerritOpenStack Proposal Bot proposed a change to openstack/horizon: Imported Translations from Transifex  https://review.openstack.org/12884207:46
*** cedrics_ has quit IRC07:46
*** cedrics has quit IRC07:49
*** e0ne has quit IRC07:49
*** e0ne has joined #openstack-horizon07:53
*** ramishra has quit IRC07:53
*** e0ne has quit IRC07:53
openstackgerritAkihiro Motoki proposed a change to openstack/horizon: Fix E128 errors in remaining openstack_dashboard/  https://review.openstack.org/12514107:55
openstackgerritAkihiro Motoki proposed a change to openstack/horizon: Fix E128 errors in openstack_dashboard/dashboards/project/  https://review.openstack.org/12514007:55
*** romainh has joined #openstack-horizon07:59
*** ygbo has joined #openstack-horizon08:04
*** ala_ has joined #openstack-horizon08:05
*** Ala has quit IRC08:08
*** jpich has joined #openstack-horizon08:16
*** MaxV has joined #openstack-horizon08:17
*** akrivoka has joined #openstack-horizon08:22
*** qba73 has joined #openstack-horizon08:27
mrungeakrivoka, your patches for https://review.openstack.org/#/q/status:merged+project:openstack/horizon+branch:master+topic:bp/detail-pages-ia,n,z caused missed neutron mocks etc. Do you know, which commit fixed that?08:28
akrivokamrunge: https://review.openstack.org/#/c/127237/08:29
jpichmrunge: https://review.openstack.org/#/c/127237/ I think08:29
mrungeah great, thanks08:29
jpichmrunge: Will we need that on stable/juno once it's cut?08:37
*** hightall has quit IRC08:37
mrungejpich, I guess, no08:37
*** hightall has joined #openstack-horizon08:37
jpichmrunge: Ok! Thanks :)08:38
mrungejpich, I was pulling in akrivoka s patches to https://github.com/redhat-openstack/horizon08:38
mrungeand unit tests were quite ugly then08:38
jpichmrunge: Got it! I get easily lost :-)08:39
*** katyafervent_awa is now known as katyafervent08:41
*** ramishra has joined #openstack-horizon08:43
*** hightall has quit IRC08:48
*** AliceR has quit IRC08:51
*** e0ne has joined #openstack-horizon08:51
openstackgerritMatthias Runge proposed a change to openstack/horizon: Refactor metering dashboard  https://review.openstack.org/10701108:57
*** ramishra has quit IRC09:01
*** exploreshaifali has quit IRC09:14
*** exploreshaifali has joined #openstack-horizon09:18
*** hhuang has joined #openstack-horizon09:25
*** exploreshaifali has quit IRC09:33
*** aix has joined #openstack-horizon09:38
*** hhuang has quit IRC09:42
openstackgerritAkihiro Motoki proposed a change to openstack/horizon: Do not log keystone token  https://review.openstack.org/12885909:43
*** paulmillar has quit IRC09:55
openstackgerritA change was merged to openstack/horizon: Imported Translations from Transifex  https://review.openstack.org/12884209:56
openstackgerritVlad Okhrimenko proposed a change to openstack/horizon: Switch Region dropdown  https://review.openstack.org/12754409:58
openstackgerritA change was merged to openstack/horizon: Make "VLAN", "VXLAN" and "GRE" translatable  https://review.openstack.org/12873209:59
*** paulmillar has joined #openstack-horizon10:00
*** ZZelle has joined #openstack-horizon10:07
*** openstackgerrit has quit IRC10:19
*** openstackgerrit has joined #openstack-horizon10:20
*** akrivoka has quit IRC10:21
openstackgerritSwati Shukla proposed a change to openstack/horizon: Confirm Dialog for Delete operation  https://review.openstack.org/12887310:21
*** sambetts has joined #openstack-horizon10:24
openstackgerritMarcin Karkocha proposed a change to openstack/horizon: Fix inconsistent displaying message in 'Other Field' in Update Metadata Form when you put something and delete it next.  https://review.openstack.org/12887810:27
*** ramishra has joined #openstack-horizon10:28
*** ramishra has quit IRC10:32
*** cedrics has joined #openstack-horizon10:33
*** cedricss has quit IRC10:36
*** sayali has joined #openstack-horizon10:41
*** kmartin has quit IRC10:46
*** cedrics has quit IRC10:56
*** ramishra has joined #openstack-horizon10:57
*** akrivoka has joined #openstack-horizon10:59
*** nikunj2512 has quit IRC11:12
*** MaxV has quit IRC11:27
*** MaxV has joined #openstack-horizon11:28
*** MaxV has quit IRC11:32
mrungehas anyone tested horizon on django-1.7?11:32
mrungeand if yes: do we have changes merged back?11:32
mrungezigo?11:32
amotokimrunge: zigo test django-1.7 and one unit test failure is still remaining.11:32
mrungeI saw some translation issues11:33
amotokiI have not tried django 1.7 yet..11:34
mrungeamotoki, http://paste.fedoraproject.org/142396/13459234/11:34
mrungeso, I wonder, how successful tests really were11:34
*** ramishra has quit IRC11:35
zigomrunge: There seems to be another issue undetected with unit tests: http://lists.alioth.debian.org/pipermail/openstack-devel/2014-October/007488.html11:38
zigoI would need help to fix this ...11:38
*** cedrics has joined #openstack-horizon11:41
*** MaxV has joined #openstack-horizon11:43
amotokii think so. it seems a different thing.11:45
amotokiI am not sure wsgi.py is called in unit tests.11:45
*** julim has quit IRC11:46
openstackgerritA change was merged to openstack/horizon: Fix E128 errors in openstack_dashboard/dashboards/project/  https://review.openstack.org/12514011:46
tsufievdoes anyone know Lin Hua Cheng nick here?11:50
mrungetsufiev, it's lcheng or lhcheng11:54
mrungetsufiev, he's located in the US11:54
mrungezigo, it looks like your issue is the same as mine with Django-1.711:56
zigomrunge: Ok, good to know. Did you file a bug?11:56
mrungewell, same issue, different location11:56
mrungezigo, not yet. did you?11:57
zigomrunge: No, please do ! :)11:57
mrungezigo, this is Icehouse version in Debian, right?12:00
zigomrunge: There's Icehouse in Sid/Jessie, and Juno in Experimental.12:00
zigoI need both to work with Django 1.7. :/12:00
mrungeno.12:01
mrungereally?12:01
mrungeso, this is critical, right?12:02
mrungezigo; https://bugs.launchpad.net/horizon/+bug/138202312:02
*** radez_g0n3 is now known as radez12:04
zigomrunge: yes, this is critical, and I would very much prefer it to be fixed before Jessie is frozen on the 5th of November.12:06
mrungezigo, the question is more: is this so critical to prevent a Juno release?12:06
zigomrunge: As always, people in OpenStack will say "but we only declared compatibility with an older version, so we don't care" ...12:07
zigoReality, people try to do their best.12:07
zigoBut that can't block a release.12:07
*** rbertram has quit IRC12:14
*** rbertram has joined #openstack-horizon12:14
zigomrunge: Also, as long as we have a patch, it can be included in the distro, even if it's not merged upstream yet.12:15
zigoSo the important bit is to have someone to work on it...12:15
mrungezigo, I would want a patch to be merged...12:15
zigomrunge: Of course, that's *better*, but not mandatory for me.12:16
*** ramishra has joined #openstack-horizon12:16
zigoAs long as I have a patch to use...12:16
mrungezigo, are you applying some other patches on horizon?12:19
zigomrunge: Yes, I do.12:19
mrunge... is there a patch to upstream?12:19
zigofix-dashboard-django-wsgi.patch12:20
zigofix-dashboard-manage.patch12:20
zigofixed-horizon-MANIFEST.in.patch12:20
zigodisable-failed-django-1.7-test.patch12:20
zigoRemove_selenium_dependency_when_not_using_selenium_tests.patch12:20
zigoThat's what I currently have.12:20
mrungezigo, could you submit them for review?12:20
mrungeif manageable, I mean12:20
*** vkmc has joined #openstack-horizon12:21
mrungeit would be a shame, not to submit patches back upstream12:21
mrunge^ zigo12:21
*** vkmc has quit IRC12:21
*** vkmc has joined #openstack-horizon12:21
zigomrunge: Some don't need to, and are Debian specific, some I already tried and failed to gather upstream attention or got negative reviews, and the last one is from upstream but not yet merged (probably it is right now...).12:21
zigomrunge: Most Django 1.7 patches, I was the one to send them for review.12:22
zigoThanks to Raphael Hertzhog for his help on them though ! :)12:22
mrungezigo, could you probably link them to the django-1.7 bug report?12:22
mrunge.. just to make them more prominent?12:22
zigomrunge: Link the patches which were aready merged?12:23
zigoI don't think I'd have time to do that right now.12:23
* zigo is busy with building and uploading Juno final tags to Debian Experimental.12:23
mrungeno, I meant to link unmerged patches12:24
*** hightall has joined #openstack-horizon12:26
jpichmrunge, zigo: Updating the wsgi file like in https://www.pythonanywhere.com/forums/topic/1629/#id_post_11030 appears to resolve the AppRegistryNotReady issue for me (I haven't checked yet if it's backwards compatible though...)12:27
zigomrunge: All Django 1.7 patches I sent were merged, at least for Juno, not all were backported to Icehouse though.12:27
mrungezigo, thank you, good to hear12:27
zigojpich: Oh, thanks a lot Julie !!! :)12:27
* zigo reads12:27
*** ramishra has quit IRC12:28
zigojpich: So, if I follow what you send, we should do:12:29
zigofrom django.core.wsgi import get_wsgi_application12:29
zigoapplication = get_wsgi_application()12:29
zigojpich: But where should that be replaced?12:29
jpichInstead of import django.core.handlers.wsgi and application = django.core.handlers.wsgi.WSGIHandler() yeah, in https://github.com/openstack/horizon/blob/master/openstack_dashboard/wsgi/django.wsgi12:29
mrungejpich, thanks, that looks promising12:30
* zigo currently installs Jessie to test this out.12:30
openstackgerritVlad Okhrimenko proposed a change to openstack/horizon: Hide the "Host Aggregates" admin panel if not enabled  https://review.openstack.org/12112712:31
*** absubram has quit IRC12:31
mrungejpich, apparently, that works in Django-1.6 as well12:31
mrungeDjango-1.6 and icehouse I meant12:31
jpichSounds good! Let's see if we can support back to 1.4 with this...12:32
mrungejpich, are you going to submit a patch?12:32
jpichmrunge: For now I'm updating the bug and figuring out the backwards compatibility implications12:32
mrungejpich, thank you very much, awesome!12:32
*** neelashah has joined #openstack-horizon12:32
jpichThough I guess we could make a conditional import based on django version if it comes down to it probably12:33
openstackgerritAdrien VergĂ© proposed a change to openstack/horizon: [Sahara] Support Cinder availability zones  https://review.openstack.org/12890612:33
zigojpich: How would you test Django's version? Is there something smarter than just pkg-resources ?12:34
jpichzigo: There's a django_version variable of some sorts, we use it in a few places, it's pretty hackish. But it looks we won't need to here, woot :)12:35
jpichI'll submit a patch then12:35
amotokiyeah! hacking patch series is completing... the final one goes into the gate.12:36
jpichall the progress :-)12:38
mrungejpich, would be nice, if this patch could make it into Juno12:40
jpichmrunge: Juno's already been tagged so it's not going to happen for the release today, but possibly there is an argument for the first stable point release12:40
jpichthough it's a bit featurish?12:41
mrungewell, if it works from Django-1.4 and up?12:41
jpichIf the patches are minimal, it certainly sounds reasonable to me12:42
jpichyou're the stable maintainer either way ;)12:42
mrungewho?12:42
mrunge;-)12:42
*** johnma has quit IRC12:45
*** _crobertsrh is now known as crobertsrh12:52
*** ramishra has joined #openstack-horizon12:54
*** shadower39 has joined #openstack-horizon12:57
openstackgerritJulie Pichon proposed a change to openstack/horizon: Update WSGI app creation to be compatible with Django 1.7  https://review.openstack.org/12891113:00
*** shadower39 has quit IRC13:01
*** shadower78 has joined #openstack-horizon13:02
*** shadower has quit IRC13:03
*** shadower78 is now known as shadower13:03
openstackgerritJiri Tomasek proposed a change to openstack/horizon: Restyled sidebar to resemble UX guidelines  https://review.openstack.org/12628913:03
*** tnovacik has joined #openstack-horizon13:05
*** neelashah has quit IRC13:06
*** tzumainn has joined #openstack-horizon13:06
*** johnma has joined #openstack-horizon13:12
*** thiagop has joined #openstack-horizon13:14
openstackgerritOpenStack Proposal Bot proposed a change to openstack/horizon: Merge tag '2014.2'  https://review.openstack.org/12891613:20
*** ramishra has quit IRC13:20
*** ramishra has joined #openstack-horizon13:21
*** julim has joined #openstack-horizon13:21
openstackgerritMarcin Karkocha proposed a change to openstack/horizon: Fix misleading  message in Update Metadata Form. First you put some data to Other field. In next step you delete it. Then you give message 'invalid key name'. This is inconsistent to this field behavior.  https://review.openstack.org/12887813:23
*** peristeri has joined #openstack-horizon13:28
*** johnma has quit IRC13:29
*** jacalcat has joined #openstack-horizon13:31
openstackgerritA change was merged to openstack/horizon: Fix E128 errors in remaining openstack_dashboard/  https://review.openstack.org/12514113:32
*** absubram has joined #openstack-horizon13:33
thiagoptsufiev: ping13:35
*** jprovazn has quit IRC13:37
*** hightall has quit IRC13:38
jpichamotoki: Thanks for linking to the 1.7 release notes in the wsgi bug, that was useful information. I need to read them more carefully next time rather than skimming :)13:47
tsufievthiagop, pong13:48
*** shufflebot has quit IRC13:48
thiagophenrynash: tsufiev Hi! I have ended a PoC of that 2nd part of RBAC on Horizon (the one that retrieves the policy from the endpoint on keystone)13:48
thiagoptsufiev: would you like to take a look?13:49
*** cody-somerville has joined #openstack-horizon13:50
*** cody-somerville has quit IRC13:50
*** cody-somerville has joined #openstack-horizon13:50
*** hightall has joined #openstack-horizon13:51
*** sigmavirus24_awa is now known as sigmavirus2413:56
*** sigmavirus24 has left #openstack-horizon13:59
*** hightall has quit IRC14:00
*** ramishra has quit IRC14:00
*** doug-fish has joined #openstack-horizon14:00
*** hightall has joined #openstack-horizon14:01
*** ericpeterson has joined #openstack-horizon14:02
ericpetersonhey all, checking in if there have been any fixes around the project picker in the last 18 hours or so?  seeing problems on master14:03
ericpetersonwhen you switch projects, the old token is purged / deactived..... and the session does not get updated with the new token14:03
mrungeericpeterson, if I'm not totally wrong, there was a change on that topic14:05
ericpetersonthat would be awesome if a fix came in recently14:08
ericpetersonseems like yesterday things were pretty broken14:08
ericpeterson(could be yesterday - 1 day or so)14:09
*** ramishra has joined #openstack-horizon14:09
thiagopericpeterson: I found what caused it14:10
thiagopericpeterson: just couldn't find the main cause14:10
ericpetersonyeah, the user tries to get updated, but it doesn't stick14:10
jpichIs that a problem on Juno too or is it new?14:11
ericpetersonI think it's been around for a few days at least, maybe longer14:11
*** cedricss has joined #openstack-horizon14:11
ericpeterson     request._cached_user = user14:11
ericpeterson     request.user = user14:11
ericpeterson+    request.session.modified = True14:11
ericpetersonI tried this in DOA ^14:12
thiagopit was caused by this commit14:12
thiagophttps://github.com/openstack/horizon/commit/16db58fabad8934b8fbdfc6aee0361cc138b20af14:12
thiagopwhen you remove the decorator from the can_access function, it works like a charm14:12
tsufievthiagop, sure, this would be very interesting14:12
*** jprovazn has joined #openstack-horizon14:12
thiagopit appears that the context being received by the decorator remains the same of before changing the project14:13
thiagop(I have printed the token before and after project changes, with and without the decorator)14:13
ericpetersonexcellent find btw ;)14:14
*** sunilm has quit IRC14:14
*** cedrics has quit IRC14:14
*** amotoki_ has joined #openstack-horizon14:14
thiagopwhen you get the decorator out, the context on "can_acess" is correct (to the new project)14:15
thiagopit's VERY weird... I struggled with it for the whole day yesterday14:15
ericpetersonit's like there is a copy of the session, and we modify one version, and then the old version gets saved last14:15
*** david-lyle has joined #openstack-horizon14:16
tsufievthiagop, ericpeterson: shouldn't this problem be handled in https://github.com/openstack/horizon/commit/16db58fabad8934b8fbdfc6aee0361cc138b20af#diff-3ff8a61f264181ecfecf2ba85e7781c6R63 ?14:17
*** amerine_ has joined #openstack-horizon14:17
tsufievi thought that one project can be distinguished from another by their tokens14:17
*** amerine has quit IRC14:17
thiagoptsufiev: You're right, but the context being received in this function is, for some reason, the old context (before the new token being inserted in the session)14:19
ericpetersonthe tokens and the projects are a bit differet..... a token will either give access to a project or not14:19
ericpetersonyeah, we have the old token, get a new token..... we then invalidate the old token14:20
thiagoptsufiev: about the PoC, #links: https://etherpad.openstack.org/p/poc-endpoint-policy-horizon and https://github.com/tpborion/horizon/compare/poc-endpoint-policy?expand=114:20
ericpetersonand we try to save the new token...14:20
ericpetersonbut we reuse the old token14:20
ericpetersonand then all the things fail in horrific fashion14:20
tsufievthiagop, thanks, will take a look!14:21
ericpetersonis there a bug open on this?14:22
ericpetersoncuz it's like super bad14:22
*** packet has joined #openstack-horizon14:22
thiagopwe can file one now :)14:22
*** athomas has quit IRC14:23
ericpetersonif you can't change projects, that seems like a complete show stopper14:23
thiagopI was mainly preoccupied with the solution14:23
ericpetersonyeah, me too.  you want to file or I?14:23
thiagopI can do that14:23
ericpetersonthanks! :D14:23
*** vijendar has quit IRC14:26
*** nikunj2512 has joined #openstack-horizon14:26
ericpetersonwhy is this stuff being saved on the session anyways?  seems like allowed stuff should not be on the session14:26
ericpetersona memoized version maybe, but on the session is not right14:27
jpichI guess because we don't really have a way to store anything horizon specific so that's where stuff tends to go14:27
ericpetersonmemoize works too, we use it elsewhere14:27
ericpetersonhindsight is 20:20.... I'm just blathering on14:28
tsufievericpeterson, guess that's because we need same behavior across several apache web-servers on many controller nodes and cookie-based sessions provide that?14:29
*** johnma has joined #openstack-horizon14:29
*** athomas has joined #openstack-horizon14:30
ericpetersonif you are rellying upon cookie based sessions, that is a non starter14:30
ericpetersoncookie based sessions are only usefull in very small deployments like devstack14:30
ericpetersonwith the cookie size maxing at 4k and our tokens being huge14:31
thiagopericpeterson: https://bugs.launchpad.net/horizon/+bug/138207914:31
ericpetersonthiagop  thanks, I think I can see a way to fix, trying to understand orig patch14:32
ericpetersonwe want to memoize this, and not use sessions14:32
*** exploreshaifali has joined #openstack-horizon14:32
thiagopericpeterson: sorry, I didn't get your point. Can you elaborate? :)14:34
ericpetersonhere is an example of all the new items we are keeping on the session (appologies ahead of time):14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.project.overview.panel.Overview14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.project.instances.panel.Instances14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.project.volumes.panel.Volumes14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.project.images.panel.Images14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.project.access_and_security.panel.AccessAndSecurity14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.project.network_topology.panel.NetworkTopology14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.project.networks.panel.Networks14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.project.routers.panel.Routers14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.project.loadbalancers.panel.LoadBalancer14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.project.firewalls.panel.Firewall14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.project.vpn.panel.VPN14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.project.containers.panel.Containers14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.project.stacks.panel.Stacks14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.project.databases.panel.Databases14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.project.database_backups.panel.Backups14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.project.data_processing.clusters.panel.ClustersPanel14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.project.data_processing.cluster_templates.panel.ClusterTemplatesPanel14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.project.data_processing.nodegroup_templates.panel.NodegroupTemplatesPanel14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.project.data_processing.job_executions.panel.JobExecutionsPanel14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.project.data_processing.jobs.panel.JobsPanel14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.project.data_processing.job_binaries.panel.JobBinariesPanel14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.project.data_processing.data_sources.panel.DataSourcesPanel14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.project.data_processing.data_image_registry.panel.ImageRegistryPanel14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.project.data_processing.data_plugins.panel.PluginsPanel14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.project.dashboard.Project14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.admin.overview.panel.Overview14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.admin.metering.panel.Metering14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.admin.hypervisors.panel.Hypervisors14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.admin.aggregates.panel.Aggregates14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.admin.instances.panel.Instances14:35
ericpetersonbeing called for key =  openstack_dashboard.dashboards.admin.volumes.panel.Volumes14:36
ericpetersonbeing called for key =  openstack_dashboard.dashboards.admin.flavors.panel.Flavors14:36
ericpetersonbeing called for key =  openstack_dashboard.dashboards.admin.images.panel.Images14:36
ericpetersonbeing called for key =  openstack_dashboard.dashboards.admin.networks.panel.Networks14:36
ericpetersonbeing called for key =  openstack_dashboard.dashboards.admin.routers.panel.Routers14:36
jpichThis is pretty horrifying. Please use paste.openstack.org for that kind of long paste in the future? You're probably getting throttled for spam too :-)14:36
ericpetersonbeing called for key =  openstack_dashboard.dashboards.admin.defaults.panel.Defaults14:36
ericpetersonbeing called for key =  openstack_dashboard.dashboards.admin.info.panel.Info14:36
ericpetersonbeing called for key =  openstack_dashboard.dashboards.admin.dashboard.Admin14:36
ericpetersonbeing called for key =  openstack_dashboard.dashboards.identity.projects.panel.Tenants14:36
ericpetersonbeing called for key =  openstack_dashboard.dashboards.identity.users.panel.Users14:36
ericpetersonbeing called for key =  openstack_dashboard.dashboards.identity.dashboard.Identity14:36
ericpetersonbeing called for key =  openstack_dashboard.dashboards.settings.user.panel.UserPanel14:36
ericpetersonbeing called for key =  openstack_dashboard.dashboards.settings.password.panel.PasswordPanel14:36
ericpetersonand each one of those gets a func kept with it14:36
ericpetersonthiagop  there is a memoize decorator you can add to cache a method14:36
*** coolsvap is now known as coolsvap|afk14:36
vkmcericpeterson, please use http://paste.openstack.org14:37
*** jacalcat1 has joined #openstack-horizon14:37
ericpetersonthanks, sorry about that14:37
*** jacalcat has quit IRC14:37
thiagopericpeterson: got it14:37
ericpetersonhttps://github.com/openstack/horizon/blob/master/horizon/utils/memoized.py  has the function that would work mo betta I think14:38
ericpetersondecorator / whatever14:38
tsufievericpeterson, do you think we're hitting 4K limit here?14:38
jpichIt seems the goal is different though, since memoized only works once per request?14:38
jpichwhile I assume the other one was caching it for the session length14:38
ericpetersonwhich is exactly what I think you'd want, for allowed checks14:39
jpichIn case someone gets their access rights downgraded while doing naughty things?14:40
ericpetersonand the other once makes 43 session modifications per reques14:40
ericpetersont14:40
*** k4n0 has quit IRC14:40
zigojpich: Thanks for your WGSI application patch.14:41
ericpetersonsorry, 43 session writes initially on login14:41
jpichzigo: Cool! So it does resolve the problem for you too?14:41
zigojpich: Can't tell yet, still reinstalling my test vm...14:42
zigojpich: I'll comment in the review.14:42
jpichericpeterson: A once-off cost at login may be more acceptable than when loading a page each time though, depending on the impact...14:42
jpichzigo: I'm fairly confident/hopeful this is the same issue but it's always good to have confirmation so, thanks! Let me know.14:43
ericpetersonyeah, I am floundering through geting this fixed, a bit all over the place atm14:43
*** cody-somerville has quit IRC14:44
jpichOk, don't let me interrupt your thinking aloud then :-) Good luck14:45
*** akrivoka has quit IRC14:47
*** openstackgerrit has quit IRC14:48
*** openstackgerrit has joined #openstack-horizon14:50
*** akrivoka has joined #openstack-horizon14:50
*** hightall has quit IRC14:53
tzumainnhiya - does anyone know who does the horizon pypi releases?  we'd like to do one for tuskar-ui, but I'm not entirely sure what the requirements for that are14:55
jpichtzumainn: I *think* openstack projects get released onto pypi automatically whenever a tag is pushed14:56
*** vijendar has joined #openstack-horizon14:56
thiagopericpeterson: I'd like very much to know why these contexts are coming differently14:56
jpichtzumainn: Do you mean you need today's release for tuskar-ui, or you want to have tuskar-ui released there too?14:56
tzumainnjpich, oh, I think I mean I just need to know how to push a tag : )14:57
* thiagop going lunch!14:57
openstackgerritMarcin Karkocha proposed a change to openstack/horizon: Fix misleading  message in Update Metadata Form.  https://review.openstack.org/12887814:57
tzumainnjpich, I think I need permissions somewhere somehow, not sure if I can get those permissions or if I need to ask someone else to create the tag for me. . . ?14:58
jpichtzumainn: I think anyone on the core team can do that? Or maybe only PTLs? I would suggest asking the way more knowledgeable #openstack-infra folks :-) They should be able to let you know if the repo is set up for it or not, too14:58
david-lyletzumainn, I think that's me14:58
david-lyleare you wanting tuskar-ui tagged?14:59
tzumainndavid-lyle, ah, yep!14:59
david-lylewhat tag?14:59
*** ramishra has quit IRC15:00
tzumainn0.2.015:00
*** KurtMartin has joined #openstack-horizon15:00
david-lyleeverything's in that needs to be?15:00
tzumainnyep!15:00
*** jprovazn is now known as jprovazn_afk15:00
tzumainnjpich, thanks for the info btw!15:03
*** MaxV has quit IRC15:03
*** hightall has joined #openstack-horizon15:05
jpichtzumainn: You're quite welcome15:06
openstackgerritA change was merged to openstack/horizon: Update WSGI app creation to be compatible with Django 1.7  https://review.openstack.org/12891115:07
ericpetersonhttp://paste.openstack.org/show/121487/  seems to be a version of a fix thiagop15:08
ericpetersonnot sure that is really correct tho15:08
ericpetersonit IS better, tho15:08
ericpetersonor less broken, at least15:08
*** ramishra has joined #openstack-horizon15:10
*** masco has quit IRC15:16
*** nikunj2512 has quit IRC15:18
david-lyle tzumainn, tag pushed and release uploaded15:20
tzumainndavid-lyle, thanks!15:20
tzumainndavid-lyle, so is the correct procedure to ping you when we need a release?  or is there another preferable method?15:21
*** ramishra has quit IRC15:22
david-lyletzumainn, ping me is the route, there is a ptl group for horizon that can push tags15:22
*** nikunj2512 has joined #openstack-horizon15:22
tzumainndavid-lyle, okay, thanks again!15:23
david-lylenp15:23
*** ala_ has quit IRC15:24
*** rebelagentm has joined #openstack-horizon15:25
*** vijendar has quit IRC15:28
*** nikunj2512 has quit IRC15:36
*** qba73 has quit IRC15:37
*** qba73 has joined #openstack-horizon15:38
openstackgerritAbishek Subramanian proposed a change to openstack/horizon: Display profile information in network details  https://review.openstack.org/7678715:41
*** sayan is now known as sayan|afk15:42
*** hightall has quit IRC15:46
openstackgerritMingyan Bao proposed a change to openstack/horizon: Add pagination support to the volume page  https://review.openstack.org/11845015:50
*** exploreshaifali has quit IRC15:54
*** david-lyle has quit IRC15:54
*** qba73 has quit IRC15:54
ericpetersonthiagop:  found the issue / fix15:55
ericpetersonthe issue we both see is related to sessions going over the limit with cookies15:57
ericpetersonif you hook up mysql as your session backend, stuff works then15:57
ericpetersonor if you take that pastebin change, that would work too15:57
ericpetersonor if you have a service catalog with about 5 bytes, that would help too ;)15:58
*** cedricss has quit IRC15:59
jpichMaybe we could disintegrate projects to make sure the cookie doesn't get too large ever16:04
*** jacalcat1 has quit IRC16:04
*** gugl2 has quit IRC16:05
*** aix has quit IRC16:07
tzumainnhuh16:09
tzumainnnow I want to eat cookies16:09
*** lhcheng has joined #openstack-horizon16:10
*** Longgeek has quit IRC16:12
*** ygbo has quit IRC16:12
openstackgerritPaul Karikh proposed a change to openstack/horizon: Remove admin role name 'admin' hardcode  https://review.openstack.org/12374116:15
*** KurtMartin has quit IRC16:15
*** KurtMartin has joined #openstack-horizon16:16
*** vokhrimenko has quit IRC16:18
*** AliceR has joined #openstack-horizon16:18
*** akrivoka has quit IRC16:19
ericpetersonlhcheng - do you know about memoize per session?16:21
ericpetersonseems like we'd want something like that for this case maybe16:21
*** david-lyle has joined #openstack-horizon16:21
* thiagop I'm back16:22
*** ramishra has joined #openstack-horizon16:22
ericpetersonthiagop: got a fix16:22
ericpetersonkind of16:22
ericpetersonthe problem is that we are overflowing the session with this change16:22
ericpetersonif you used mysql sessions, it's fine16:22
ericpetersonor if you just memoize it that works too16:22
*** vijendar has joined #openstack-horizon16:23
ericpetersonhttp://paste.openstack.org/show/121487/  thiagop is the memoized version of that16:26
*** jcoufal has quit IRC16:26
thiagopericpeterson: I've not tryied it yet, but maybe we can remove this decorator and use just memoize? What do you think?16:28
thiagop(on "allowed")16:28
*** lsmola has quit IRC16:29
david-lyleregardless, that info should not be shoved into the session data16:30
lhchengericpeterson: don't recall we have a code that memoize by session.  closest is probably memoizing it by token16:32
*** sigmavirus24 has joined #openstack-horizon16:34
*** ramishra has quit IRC16:34
zigojpich: Your wsgi application patch fixes the issue for me in Icehouse! :)16:36
jpichzigo: \o/16:36
zigojpich: I didn't test Juno yet, but I'm quite sure it's going to be the same.16:36
david-lylelhcheng, how are we memoizing by session? I thought it was scoped to the request/response cycle16:37
zigojpich: Or is it merged in Juno already?16:37
zigoAh no...16:37
zigoSorry! :P16:37
zigojpich: Please do backport it to both Icehouse and Juno.16:38
jpichzigo: I would assume so yeah. The master patch already merged, I'll submit a juno backport when the stable branch is properly open16:39
jpichyup!16:39
*** jpich has quit IRC16:41
*** sayan has joined #openstack-horizon16:43
*** lsmola has joined #openstack-horizon16:44
*** sbfox has joined #openstack-horizon16:45
lhchengdavid-lyle, we don't have anything memoizing by session :)   Closest I could think of memoizing up to scope of token. token != session, user can switch tokens in a single session.16:47
david-lylenot sure how it's even across token?16:48
lhchengdavid-lyle, we have a function that is memoized by keyword argument, we passed the token as the key to used to store in cache.16:49
*** jamespage_ has joined #openstack-horizon16:49
lhchengdavid-lyle, we used it in caching get_project_list()16:50
david-lylebut we're not using a cache backend, how is this info not getting cleaned up when response is sent?16:51
*** jamespage_ has quit IRC16:51
david-lyleah, because we're implementing our own memoize for some reason16:52
lhchengstored in memory, it gets cleaned up when the user logs out16:52
david-lylewas referencing any of the other 18 implemenations of memoize in python and django16:53
david-lylein fact memoize is built in to django16:53
david-lyleand is starting a deprecation cycle in 1.716:53
david-lylewhy we built our own ?? who knows16:54
*** coolsvap|afk is now known as coolsvap16:55
thiagopdavid-lyle lhcheng so, you think we should not be using memoized?16:56
david-lylememoize is fine16:58
david-lylejust odd to me that we reimplemented it16:58
david-lylemay want to look at replacing with the django implementation, although that seems to be transitioning16:59
thiagopdavid-lyle: even with the imminent deprecation of the django's impl?16:59
ericpetersonlet's write a new version of memoize for this case  :P16:59
david-lylewe have some strange issues with the weak_ref in our implementation17:00
* ericpeterson ducks17:00
david-lylethiagop, it's transitioning17:00
*** ybathia has joined #openstack-horizon17:00
david-lylehttp://django.readthedocs.org/en/latest/releases/1.7.html#django-utils-functional-memoize-function17:01
lhchengdavid-lyle: I joined late, I was just responding to ericpeterson if we have memoized by session.  didn't have a context of the question if we should memoize or not17:01
*** sbfox has quit IRC17:02
david-lylelhcheng, the recent fix to can_access stores a ton of stuff on the session that is overflowing the session cookie17:02
*** sbfox has joined #openstack-horizon17:02
david-lylequestion is can we move that to memoize17:02
lhchengdavid-lyle I've looked at memoized in django, it is fairly primitive. It takes the a number of the args to used as key, there is no guarantee it'll use token as the key to the cache.17:03
david-lyleI think we can, token based would actually be perfect, because the results can change on token rescope17:03
david-lylelhcheng, was hoping it was more mature17:03
david-lyle:(17:03
david-lylethat's disappointing17:04
david-lylethere are whole pypi projects implementing memoize in django as well17:04
ericpetersonhttp://paste.openstack.org/show/121487/   lhcheng  was the change around current issue we see17:04
ericpetersonyou can see we stored a ton of stuff on the session with a recent change17:05
*** ArcTanSusan has joined #openstack-horizon17:05
lhchengrecent merge?17:06
lhchenghaven't seen that before...17:06
thiagoplhcheng: https://github.com/openstack/horizon/commit/16db58fabad8934b8fbdfc6aee0361cc138b20af17:08
*** sbfox has quit IRC17:09
lhchengdavid-lyle, I agree. We should not putting caching those information in the session..17:11
david-lylewe're already pushing the limit without it17:11
lhchengwe know better than adding more data to session :P17:12
david-lyleindeed we do17:12
lhchengthe api calls can be reduced by just memoizing on the service calls17:13
david-lyleas long as that works with mox, which was the main reason for the change17:13
lhchengthe service made on the panels are just checked if the extension is enabled.17:13
lhchengwe could just memoized it for the whole app17:13
david-lyledifferent neutron endpoints could potentially have different extension enabled, no?17:14
lhchengthere was a patch the works around that..17:14
lhchenggood call about neutron endpoint17:14
david-lyleisn't that patch what merged?17:14
lhchengdavid-lyle checking...17:16
david-lylepretty sure it is17:17
david-lylejust not mentioned in the bug report17:17
*** harlowja_away is now known as harlowja17:19
lhchengdavid-lyle https://review.openstack.org/#/c/121127/17:20
*** johnma has quit IRC17:20
*** sbfox has joined #openstack-horizon17:21
lhchengthis will need to be rebased from the commit that thiagop gave me17:21
*** sbfox has quit IRC17:22
david-lylewonder if we should just revert the panel cache17:22
david-lyleseems misguided17:22
david-lylethat's causing the current issues17:23
david-lylesession scope is too long17:23
thiagopdavid-lyle: +1, at least while we can't think of a better solution17:23
lhchengdavid-lyle, I agree17:23
thiagopericpeterson: the solution using memoized seems to be always calling the policy validation17:24
lhchengericpeterson, what that the cause of your issue yesterday?17:24
thiagopIt's like it wasn't there...17:24
*** cody-somerville has joined #openstack-horizon17:25
david-lylesambetts: around?17:26
david-lylelhcheng, yeah, this is related to the issue yesterday17:28
sambettsdavid-lyle: Hi!17:31
thiagoplhcheng: do you mean the issue of couldn't change between projects?17:31
david-lylewe're discussing a patch of yours17:31
thiagops/change/changing/17:32
sambettsThe panel access caching one I'm, guessing??17:32
david-lylehttps://github.com/openstack/horizon/commit/16db58fabad8934b8fbdfc6aee0361cc138b20af17:32
david-lyleyeah17:32
david-lyleit's problematic on a few levels17:32
david-lyle1) it blows up the session cookie size limit17:33
lhchengthiagop: yes!17:33
*** ericpeterson has quit IRC17:33
david-lyle2) it seems to not be updating on token rescope changes17:33
thiagoplhcheng: This is what I've found so far https://bugs.launchpad.net/horizon/+bug/138207917:34
thiagopsambetts: ^17:34
david-lylewe're considering either moving to use memoize, or revert completely and rethink17:34
david-lylewould like your opinion17:34
*** aberezin has quit IRC17:36
sambettsI've not used memoize before so I can't comment there, in response to your second point I'm pretty sure I tested that senario and it was updating when I change the project from the drop down so I'm not sure what going on there17:37
david-lylesambetts, memoize would store the results in memory on the server rather than in the session cookie17:38
sambettsas far as I could see it wasn't storing it in the cookie anyway, I see a session key, but I never saw anything else stored in the cookie, surly I would have seen an error as soon as it hit the 4k limit17:40
sambettsI assumed it used the key in the cookie to access something in memory17:41
*** tnovacik has quit IRC17:41
*** ArcTanSusan has quit IRC17:45
*** athomas has quit IRC17:46
thiagopsambetts david-lyle : according to ericpetterson, the problem doesn't occurs when you are using the SQL session backend17:46
sambettswhich is default? because I run standard devstack and have not seen any issues17:47
*** arborism has joined #openstack-horizon17:47
thiagopI believe the default is signed_cookie.17:48
*** arborism has quit IRC17:48
thiagopsambetts: did you run it using keystone v2.0 or v3?17:48
sambettswhichever is default in devstack17:48
thiagopdavid-lyle: ^17:49
sambettsthe only config I've changed in the devstack env is to turn on neutron17:49
sambettseverything else I've left default17:49
thiagopmaybe the session is blowing up due to v3 token info17:49
tsufievdavid-lyle, what if we look in the direction of clientside localStorage? I've been thinking about whether could solve the problems that cookie-session have?17:50
sambettsthiagop: In reference to that bug report, that seems to me like something else is falling out of sync if its passing the wrong context into the decorator17:52
thiagopsambetts: I believe it too. But I've looking into it a day and a half and cannot yet find where it's changing this context17:53
*** wuhg has quit IRC17:53
thiagopbut, as david-lyle said, it's putting too much info into the session cookie17:53
thiagopdavid-lyle lhcheng sambetts the problem indeed doesn't occurs when using identity v2.017:54
*** ArcTanSusan has joined #openstack-horizon17:56
lhchengthiagop identity v2 has smaller footprint on the data stored in session than v317:57
*** cody-somerville has quit IRC17:57
*** clu_ has joined #openstack-horizon17:57
lhchengthiagop, the endpoint data is smaller, due to the data structure difference17:58
openstackgerritJiri Tomasek proposed a change to openstack/horizon: Restyled sidebar to resemble UX guidelines  https://review.openstack.org/12628917:58
sambettsI confused by the difference between using .session and .cookie then, I thought that .session wasn't bound by the 4k limit17:58
lhchengas thiagop mentioned, the default is signed_cookies for storing session information17:59
lhchengthe session information is passed back and forth as cookies17:59
thiagopsambetts: the session, by default, is stored in cookies.17:59
sambettsI hadn't realised that it was stored as a encrypted blob, I see that now, I thought that the hash I was seeing was just a unique key back to something stored in memory on the server18:00
thiagopsambetts: that's when you're using database session backend18:01
thiagopbtw, why do we use signed_cookies as default?18:02
*** ericpeterson has joined #openstack-horizon18:04
sambettsif we use memoize does that use a key stored in the cookie/session for retreival??18:04
lhchengthiagop: I guess it was used to simplify devstack setup, less dependency (no additional service).18:04
sambettskeystone v3 uses the tokens that are close to 4k anyway, so surely that leads to nearly all other cookie/session storage becoming problematic? Like the user settings for instance18:06
*** akrivoka has joined #openstack-horizon18:07
*** ericpeterson has quit IRC18:08
openstackgerritNikita Konovalov proposed a change to openstack/horizon: [Data_processing] fix job_executions table  https://review.openstack.org/12592718:09
openstackgerritCindy Lu proposed a change to openstack/horizon: add Column attribute for help tooltip in heading  https://review.openstack.org/12880418:09
*** akrivoka has quit IRC18:14
*** e0ne has quit IRC18:16
*** jwy has joined #openstack-horizon18:16
thiagopdavid-lyle: changing the subject for a while, we have made a PoC of using the endpoint policy to do the RBAC validation on Horizon18:18
thiagopdavid-lyle: do you mind to take a look?18:18
openstackgerritSayali Lunkad proposed a change to openstack/horizon: Removes term inconsistency in the dashboard  https://review.openstack.org/7322218:22
*** ericpeterson has joined #openstack-horizon18:23
*** jwy1 has joined #openstack-horizon18:25
*** jwy has quit IRC18:25
david-lylethiagop, additionally, HA is much easier when passing all the session info around.18:25
david-lylewhat really needs to happen is the service catalog getting removed from the token18:26
*** jwy1 has left #openstack-horizon18:26
david-lylepki tokens will still be a problem then18:26
ericpetersonif we can assume everyone's catalog always looks the same, then I'm on board18:26
david-lylethink separate API18:27
thiagopdavid-lyle: It's simple. There is a flag "--nocatalog" on getting tokens on keystone18:27
david-lylemoving forward18:28
david-lyleand the HTTP interface supports that?18:28
thiagopyou mean the REST API?18:30
david-lylevia keystoneclient yes18:31
thiagopgive me 5min to check...18:31
david-lylenot seeing it documented in the client, that may just be an oversight18:32
thiagopon the client, it seems that it's not available18:34
thiagopbut we can take care of it :D18:35
david-lyleI'm sure that will change, but hard to use as is :)18:35
*** ramishra has joined #openstack-horizon18:35
*** johnma has joined #openstack-horizon18:37
*** ArcTanSusan has quit IRC18:38
*** ramishra has quit IRC18:40
*** ramishra has joined #openstack-horizon18:53
*** ramishra has quit IRC18:58
*** ArcTanSusan has joined #openstack-horizon18:59
thiagopsambetts david-lyle lhcheng ericpeterson : what do you think of this structure? http://paste.openstack.org/show/121522/19:01
*** sbfox has joined #openstack-horizon19:01
thiagopseems to work (left the prints for you to see)19:01
thiagopwhen you open a window for the first time, it reloads the cache and, if you reload the same page on the same project, it doesn't reloads19:02
thiagopif you change the project, the reloading occurs19:02
thiagop(there is also a CACHE global on top of the module)19:02
*** ybathia has quit IRC19:06
*** ybathia has joined #openstack-horizon19:09
*** cody-somerville has joined #openstack-horizon19:09
*** jprovazn_afk has quit IRC19:12
*** ybathia has quit IRC19:14
openstackgerritAdrien VergĂ© proposed a change to openstack/horizon: [Sahara] Support Cinder availability zones  https://review.openstack.org/12890619:15
sambettsthiagop: does every user get a clean CACHE variable? or does the global go between users??19:15
thiagopsambetts: I didn't test that, but I believe each user has a cache due to threading isolation.19:16
thiagopsambetts: But I have to test that indeed19:17
*** ArcTanSusan has quit IRC19:18
sambettsI don't think every Django communication/session runs in isolation so I think you would end up with cross talk between clients, thats why we have the session store19:18
sambettsotherwise you could just store everything in variables and you would never need the cookie19:19
*** david-lyle_ has joined #openstack-horizon19:20
*** david-lyle has quit IRC19:20
thiagopsambetts: makes sense.19:21
*** mrunge has quit IRC19:23
thiagopsambetts: maybe it works because the token is different between users. But I wonder how users may "steal" the cache from each other in a production environment...19:25
*** david-lyle_ is now known as david-lyle19:27
sambettsI think what will happen right now with your suggestion, is that every time a different user refreshes the page it invalidates the cache and rebuilds it so there is no advantage unless you only have one user19:27
sambettsthiagop: ^19:27
sambettsthiagop: I can see that leading into some serious race hazards too, its not somewhere we want to go19:28
*** exploreshaifali has joined #openstack-horizon19:28
thiagopsambetts: so, we have to find another way of approaching this without putting the cached checks into the session.19:29
openstackgerritDavid Lyle proposed a change to openstack/horizon: Fixing template syntax  https://review.openstack.org/12902819:29
sambettsthiagop: agreed, something that I was considering was, similar to yours except the CACHE variable had another layer above it so it was like { some_session_identifier : the_cached_data, another_session_identifier: thier cached data } however what I've realised is that using variables/global or is just a plain old bad idea for scalablity of the dashboard,19:34
*** clu_ has quit IRC19:35
sambettssay your runing multiple horizons under a load balancer variables won't be shared == bad idea19:35
*** ArcTanSusan has joined #openstack-horizon19:37
sambettsI've have been thinking about the cookie idea for a bit now, because of another patch I worked on, and I have learned that you can have multple cookies for a single site, which woul allow us to extend past the 4k limit, then we could have a cookie for the token/auth stuff, and one for user settings and one for something like this?19:39
sambettsif I've understood it correctly that is,19:39
*** absubram has quit IRC19:39
sambettsthiagop, david-lyle: ^19:39
*** ArcTanSusan has quit IRC19:41
david-lylesambetts, regardless of the number, size limit is 4K19:41
david-lyleeven if you have 50 cookies, they share the same 4K cap19:42
ericpetersonmust be site wide ?19:42
sambettseven with mutliple cookie files, so they are bound to different urls?19:42
david-lyleyes19:42
david-lyleper domain19:42
david-lyleI believe19:42
david-lylelooked into the details many times19:43
ericpetersonI'd say the caching right now is not 100%, and for many uses you are best off not caching at all19:43
ericpetersonit's better to have a slower system and you can actually switch projects, than to have a fast setup with only one project19:44
sambettsthe cache really isn't the issue tbh, the issue is that once you introduce the PKI token you have zero storage left for anything let alone caching19:45
ericpetersonwell, the cache places 43 or something like that items into the cookie, so I'd say it's part of the problem19:46
*** cody-somerville has quit IRC19:46
ericpetersonand if you remove the cache, everything else works....  so I'd disagree and say the cache most certainly is part of the problem19:46
ericpetersonbut yeah, it's resource contention in the big picture19:46
*** ArcTanSusan has joined #openstack-horizon19:47
sambettsadmittly there are improvments that need to be made and can be made in the future, but once v3 comes in I think it even proves an issue for storing the user settings19:47
lhchengsambetts, we got a workaround for the PKI token. It is a hack, but it works with horizon in devstack.19:48
sambettsoh cool! have you got a link?19:49
david-lylewe should not be pushing a bunch of method references in the session19:51
sambettsdavid-lyle: When I was working on it, I discussed a lot here, and we decided that right now it was the only way to reference each panel uniquly as there is no unqiue identifier for each panel19:53
david-lylehow does that translate if your session gets load balanced to another server/19:53
david-lyle?19:53
*** ramishra has joined #openstack-horizon19:54
sambettsthey are class refrences as far as im aware the class names and locations wont change dynamically19:55
sambettsor based on different instances19:55
sambettsthey aren't object references19:55
david-lyleI haven't looked at how it's encoded19:56
sambetts"openstack_dashboard.dashboard.project.network" will always be just that afaik19:56
*** romainh has quit IRC19:56
david-lyleok19:56
*** e0ne has joined #openstack-horizon19:57
sambettsI would imagen if you wanted to reduce the size that it takes up in the cookie, there is alot of redundency in the names so it would compress well19:58
*** cody-somerville has joined #openstack-horizon19:58
*** ramishra has quit IRC19:59
sambettsor something I discuss with Radomir I think was actually adding a variable to every horizon_component object which is a unique identifier, like "admin_network_panel" or something similar19:59
sambettsand have a check similar to the slug check that ensures that one is given to each component and that its unique with every other one that exists so far20:00
sambettsthen you wouldn't need the full class path for everything20:01
*** clu_ has joined #openstack-horizon20:02
sambettsis there a reason that the slug variable isn't unique? Every panel has to have one but for instance both admin->network and project->network both have the slug "networks"20:03
*** david-lyle_ has joined #openstack-horizon20:04
*** e0ne has quit IRC20:05
*** david-lyle has quit IRC20:06
sambettsdavid-lyle_: ^20:07
ericpetersonso keeping your permissions in the clients cookie is an idea that seems to be pretty sticky here20:09
sambettsericpeterson: its only the same as the token is in the cookie because its in the session in this case20:11
openstackgerritSam Betts proposed a change to openstack/horizon: Pass correct project ID to get tenant_usages  https://review.openstack.org/12903720:13
ericpetersonwe had a problem that sometimes happened, where we would overflow the cookie size from time to time.   now it's worse / more frequent.  that much we all agree upon, right?20:15
*** ybathia has joined #openstack-horizon20:17
sambettsI think cookie based session store is a bad idea period, for security and for the fact that people understand that cookies have a limit and sessions normally dont, and storing the session in the cookie just limits our use of the session, surly if we want a string free implmentation for devstack we can just use Sqlite or something as the session backend20:18
thiagopericpeterson: +120:18
thiagopsambetts: I also think that cookie transmission is a undesirable overhead on the traffic user<->web server20:20
ericpetersonsambetts: I agree that cookie backed sessions are not realistic, but that's jumping ahead I think.  I'd like to move to something else, but that's not a 2 day fix either20:20
thiagopIt's not a "oh my god, this cookie is huge", but if you have a clean solution that could do the same thing without transmitting this "almost 4K cookie", it would be awesome20:21
sambettsericpeterson: everything uses the django helpers for session and cookie so switching the default backend to something else shouldnt effect the code at all, something like Sqlite should just drop in no hassel20:22
*** ybathia has quit IRC20:22
sambettsdjango will handle the rest surly20:22
sambettseven just swapping it out to django.contrib.sessions.backends.file would be more desirable wouldn't it20:23
*** woodm1979 has joined #openstack-horizon20:24
*** sambetts_ has joined #openstack-horizon20:25
*** sambetts has quit IRC20:26
thiagopwe have the 'file', 'cache' and 'cached_db' options. I tried with cached_db and I throws an exception because settings.DATABASES is not configured20:26
david-lyle_thiagop, other session types require additional configuration20:27
thiagopI know that sqlite has a way to store the database in [memory] instead of in a file, but I'm worried about the concurrent access...20:27
thiagopdavid-lyle_: 'cache' doesn't20:28
sambetts_sqlite knows how to handle concurrency afaik20:28
david-lyle_sqlite used to be the default20:28
david-lyle_in Horizon back in Grizzly I believe20:29
david-lyle_requires an additional call to manage.py to syncdb on set up20:30
sambetts_back then keystone used PKI too didn't it? I remeber working with it a while ago and PKI was causing issues with cookies for me20:30
david-lyle_sambetts_, maybe, can't remember when PKI support was added, Grizzly or Havana20:31
*** ArcTanSusan has quit IRC20:31
sambetts_I ended up have to move everything into SQLite in my project to handle the amount of data I wanted to store alongside the token20:32
sambetts_was there a reason that horizon moved away from SQLite ??20:32
openstackgerritSayali Lunkad proposed a change to openstack/horizon: Removes term inconsistency in the dashboard  https://review.openstack.org/7322220:34
ericpetersonI think it's that one additional call on manage syncdb20:36
ericpetersoni.e. convenience20:36
ericpetersonnot such a good idea, as we can see now ;)20:36
thiagopericpeterson: in fact, it's a sine qua non condition to have a database on horizon.20:38
thiagopso far, we rely the persistence of everything in other services..20:38
sambetts_ericpeterson: thats something that could be easily dealt with in the devstack script or run_tests right?20:39
ericpetersonyes, it could20:39
ericpetersonit also raises a different issue around HA20:40
ericpetersonif you used sqllite in the file mode, that is not really going to work for HA20:40
ericpetersonif you use cookies, that *can* work for HA (so long as you have one region, keep your cookie size small, etc20:41
ericpetersonso some of the openstack distros / vendors might care about this20:41
sambetts_I think at the point you start running a HA environment youll want to be running a real DB, every other service is so why does horizon need to be different20:42
ericpetersonagreed20:44
*** cody-somerville has quit IRC20:46
*** david-lyle_ is now known as david-lyle20:48
thiagopsambetts_: +120:49
*** sambetts has joined #openstack-horizon20:49
*** sambetts is now known as Guest741820:49
*** crobertsrh is now known as _crobertsrh20:50
*** sambetts_ has quit IRC20:51
*** Guest7418 is now known as sambetts_20:51
*** amcrn has joined #openstack-horizon20:53
sambetts_ericpeterson, david-lyle: My internet died for some reason, while I was mid reply, I'm heading off for the evening, its nearly 22:00 where I am, I'll be back online ~9:00 UTC so can we continue these discussions tomrrow?20:53
david-lylesure20:54
david-lylehave a good night20:54
thiagopsambetts_: sure, good night!20:54
sambetts_Thanks v.much see you tomorrow20:54
*** ramishra has joined #openstack-horizon20:55
*** sambetts_ has quit IRC20:55
thiagopdavid-lyle: have you taken a look in the PoC I mentioned before?20:58
*** raildo is now known as raildo_away20:59
david-lylethiagop, not yet, it's in my queue20:59
*** ramishra has quit IRC20:59
*** cbader has joined #openstack-horizon21:00
thiagopOk. Just to know that you have seen and is not forgotten. No pressure. :)21:00
ericpetersonthanks, good night :)21:00
*** ArcTanSusan has joined #openstack-horizon21:01
thiagopericpeterson: thanks to you! see ya.21:02
*** ArcTanSusan has quit IRC21:02
*** doug-fish has quit IRC21:03
*** ArcTanSusan has joined #openstack-horizon21:07
*** thiagop has quit IRC21:08
*** ybathia has joined #openstack-horizon21:13
*** exploreshaifali has quit IRC21:23
*** cody-somerville has joined #openstack-horizon21:25
*** cody-somerville has quit IRC21:25
*** cody-somerville has joined #openstack-horizon21:25
*** nlahouti has joined #openstack-horizon21:26
*** sayali has quit IRC21:31
openstackgerritDavid Lyle proposed a change to openstack/horizon: Juno Release Notes  https://review.openstack.org/12874421:33
*** cody-somerville has quit IRC21:35
*** MaxV has joined #openstack-horizon21:36
*** freyes has quit IRC21:40
*** freyes has joined #openstack-horizon21:41
*** MaxV has quit IRC21:41
*** alexpilotti has joined #openstack-horizon21:41
*** sayali has joined #openstack-horizon21:44
*** MaxV has joined #openstack-horizon21:45
*** julim has quit IRC21:47
*** MaxV_ has joined #openstack-horizon21:48
*** david-lyle has quit IRC21:49
*** MaxV has quit IRC21:49
*** ramishra has joined #openstack-horizon21:55
*** MaxV has joined #openstack-horizon21:59
*** cody-somerville has joined #openstack-horizon22:00
*** cody-somerville has quit IRC22:00
*** cody-somerville has joined #openstack-horizon22:00
*** ramishra has quit IRC22:00
*** MaxV_ has quit IRC22:02
*** radez is now known as radez_g0n322:04
*** ArcTanSusan has quit IRC22:04
*** david-lyle has joined #openstack-horizon22:05
*** johnma has quit IRC22:06
*** rwsu has quit IRC22:07
*** ArcTanSusan has joined #openstack-horizon22:07
*** packet has quit IRC22:09
*** ericpeterson has quit IRC22:20
*** TravT has quit IRC22:23
*** david-lyle has quit IRC22:24
*** woodm1979 has quit IRC22:24
*** afaranha has quit IRC22:24
rodrigodsamotoki, lhcheng there?22:25
*** peristeri has quit IRC22:27
*** colinmcnamara has joined #openstack-horizon22:28
*** sigmavirus24 is now known as sigmavirus24_awa22:28
*** MaxV has quit IRC22:28
*** afaranha has joined #openstack-horizon22:30
*** sigmavirus24_awa is now known as sigmavirus2422:37
lhchengrodrigods, yes?22:38
*** colinmcnamara has quit IRC22:39
rodrigodslhcheng, not sure how the backport potential works, but I think that maybe is the case with: https://bugs.launchpad.net/horizon/+bug/136913722:39
lhchengnot sure if it is really backport potential, don't think people have really started using keystone v3 :P22:40
rodrigodslhcheng, hehe, ok... since federation and k2k are the main "stars" from keystone in juno release, I thought would be the case here22:41
lhchengeven with federation, users are not required to move to v3 (I think)22:43
rodrigodslhcheng, federation is an v3 extension22:46
rodrigods(it requires domains and groups)22:46
lhchengah.. another bad news. horizon doesn't support federation yet.22:47
rodrigodsyeah, hope it will soon22:47
lhchenghopefully in kilo22:47
lhchengyeah22:47
*** ramishra has joined #openstack-horizon22:56
*** ramishra has quit IRC23:01
*** sayali has quit IRC23:03
*** cbader has quit IRC23:15
*** sbfox has quit IRC23:24
*** echevemaster has joined #openstack-horizon23:24
*** cody-somerville has quit IRC23:39
*** exploreshaifali has joined #openstack-horizon23:40
*** sigmavirus24 is now known as sigmavirus24_awa23:52
*** ramishra has joined #openstack-horizon23:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!