| *** nlahouti has joined #openstack-horizon | 00:17 | |
| *** Daisy has joined #openstack-horizon | 00:41 | |
| *** rbertram has joined #openstack-horizon | 00:54 | |
| *** dsneddon_ has quit IRC | 01:01 | |
| *** dsneddon_ has joined #openstack-horizon | 01:03 | |
| *** Daisy has quit IRC | 01:18 | |
| *** jacalcat has quit IRC | 01:44 | |
| *** ramishra has joined #openstack-horizon | 02:19 | |
| *** nlahouti has quit IRC | 02:47 | |
| *** nlahouti has joined #openstack-horizon | 02:48 | |
| *** jacalcat has joined #openstack-horizon | 02:49 | |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 03:11 | |
| *** jacalcat has quit IRC | 03:33 | |
| *** echevemaster has quit IRC | 03:35 | |
| *** dsneddon_ has quit IRC | 03:47 | |
| *** dsneddon_ has joined #openstack-horizon | 03:48 | |
| *** gokrokve has joined #openstack-horizon | 03:51 | |
| *** gokrokve has quit IRC | 03:53 | |
| *** gokrokve has joined #openstack-horizon | 03:53 | |
| *** gokrokve has quit IRC | 03:53 | |
| *** sayan_ has joined #openstack-horizon | 04:03 | |
| *** tzumainn has quit IRC | 04:05 | |
| *** sayan has quit IRC | 04:10 | |
| *** hhuang has joined #openstack-horizon | 04:12 | |
| *** nikunj2512 has joined #openstack-horizon | 04:18 | |
| *** sayan has joined #openstack-horizon | 04:23 | |
| *** fifieldt has joined #openstack-horizon | 04:25 | |
| *** gokrokve has joined #openstack-horizon | 04:25 | |
| *** gokrokve has quit IRC | 04:25 | |
| *** vkmc has quit IRC | 04:25 | |
| *** amotoki has joined #openstack-horizon | 04:27 | |
| *** sayali has joined #openstack-horizon | 04:49 | |
| *** lcheng has joined #openstack-horizon | 04:57 | |
| *** lcheng has quit IRC | 04:58 | |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 04:58 | |
| *** lcheng has joined #openstack-horizon | 04:58 | |
| *** lcheng has quit IRC | 05:03 | |
| *** lcheng has joined #openstack-horizon | 05:06 | |
| *** lcheng has quit IRC | 05:09 | |
| *** lcheng has joined #openstack-horizon | 05:10 | |
| *** sayali has quit IRC | 05:12 | |
| *** vivekd has joined #openstack-horizon | 05:22 | |
| *** sayali has joined #openstack-horizon | 05:26 | |
| *** coolsvap|afk is now known as coolsvap | 05:35 | |
| *** vivekd has quit IRC | 05:39 | |
| *** e0ne has joined #openstack-horizon | 05:39 | |
| *** e0ne has quit IRC | 05:40 | |
| *** k4n0 has joined #openstack-horizon | 05:44 | |
| *** e0ne has joined #openstack-horizon | 05:45 | |
| *** e0ne has quit IRC | 05:47 | |
| *** e0ne has joined #openstack-horizon | 05:51 | |
| *** vivekd has joined #openstack-horizon | 05:53 | |
| *** e0ne has quit IRC | 05:55 | |
| zigo | rdopieralski's stackforge repository for xstatic-bootstrap-datepicker is completely outdated. | 05:56 |
|---|---|---|
| zigo | It only has verison doesn't contain version 1.3.1. | 05:56 |
| zigo | I have no idea where he picked-up version 1.3.1 btw, there's no such thing upstream, only 1.3.0 | 05:56 |
| zigo | It'd be nice to have this addressed quickly so that I can make sure I can update the Debian libjs-twitter-bootstrap-datepicker on which the xstatic package will depend. | 05:57 |
| zigo | Making a diff between what's in https://github.com/eternicode/bootstrap-datepicker and the XStatic package from pypi shows that I don't have the same version, that's really frustrating ! :( | 05:59 |
| *** e0ne has joined #openstack-horizon | 05:59 | |
| *** e0ne has quit IRC | 06:08 | |
| amotoki | zigo: ping | 06:09 |
| *** nlahouti1 has joined #openstack-horizon | 06:12 | |
| *** e0ne has joined #openstack-horizon | 06:13 | |
| *** masco has joined #openstack-horizon | 06:13 | |
| *** nlahouti has quit IRC | 06:14 | |
| *** enykeev has joined #openstack-horizon | 06:15 | |
| *** mrunge has joined #openstack-horizon | 06:16 | |
| *** e0ne has quit IRC | 06:17 | |
| *** nlahouti1 has quit IRC | 06:21 | |
| *** rdopieralski has joined #openstack-horizon | 06:21 | |
| *** nlahouti has joined #openstack-horizon | 06:21 | |
| *** e0ne has joined #openstack-horizon | 06:22 | |
| *** e0ne has quit IRC | 06:23 | |
| *** vivekd has left #openstack-horizon | 06:23 | |
| *** e0ne has joined #openstack-horizon | 06:27 | |
| zigo | amotoki: Hi. | 06:32 |
| amotoki | zigo: hi, i am planning to remove mo files (compiled message catalogs) from git repo, but automaticaly compilation support by setup.py install is not so easy. | 06:33 |
| amotoki | zigo: If you need to add an extra step to compile message catalogs (run_tests.sh --compilemessages), is it a problem for you? | 06:33 |
| zigo | amotoki: As long as I know how to do it, it's ok. | 06:33 |
| zigo | amotoki: The run_test.sh is one thing, then I also need to know how to compile them in my package too. | 06:33 |
| zigo | amotoki: Thanks for working on this, it's really helpful for me, it will remove all the "git merge -X theirs" issues I had in the past! :) | 06:34 |
| *** sayali has quit IRC | 06:34 | |
| zigo | (also, to take the most extreem point of view, .mo files could be considered non-free binary blobs...) | 06:34 |
| zigo | amotoki: Do you have any idea about the bootstrap-datepicker upstream source? | 06:35 |
| amotoki | zigo: run_tests.sh --compilemessages does all. I proposed horiozn document update to describe the steps. | 06:35 |
| amotoki | zigo: https://review.openstack.org/#/c/126169/2/doc/source/topics/install.rst | 06:35 |
| rdopieralski | if any horizon cores have some time on their hands, I would ask you to review the patches to the xstatic-* packages -- they are mostly trivial (maintenance or upgrades from upstream) and already have one +2 | 06:36 |
| rdopieralski | https://review.openstack.org/#/q/status:open+project:%255Estackforge/xstatic.*,n,z | 06:36 |
| zigo | rdopieralski: Cool, you came here ! :) | 06:36 |
| rdopieralski | zigo: I always come here | 06:37 |
| zigo | rdopieralski: Where may I found the bootstrap-datepicker upstream source code? The git repo only has versoin 1.3.0 ... | 06:37 |
| rdopieralski | zigo: as you can see, the patches are in the queue, but nobody reviews them | 06:37 |
| rdopieralski | zigo: see the link ^^ | 06:37 |
| -amotoki- am looking xstatic reviews | 06:37 | |
| zigo | rdopieralski: I think you need to update the xstatic-bootstrap-datepicker git repo, it currently only has a single commit, and no tags ... | 06:38 |
| *** e0ne has quit IRC | 06:42 | |
| *** jprovazn has joined #openstack-horizon | 06:42 | |
| amotoki | rdopieralski: a couple of question on xstatic datepicker review. | 06:42 |
| zigo | rdopieralski: FYI, Debian already uses 1.2.23 of all angular stuff. | 06:42 |
| rdopieralski | zigo: great, thank you | 06:42 |
| rdopieralski | amotoki: shoot | 06:42 |
| amotoki | rdopieralski: 1. there is no pointer where is the upstream of xstatic bootstrap datepicker. | 06:42 |
| amotoki | rdopieralski: 2. what version should we go for Juno? 1.3.1.0? | 06:43 |
| zigo | rdopieralski: I'd advise you to add people to the git reviews, otherwise, they don't even know that you need approval. | 06:43 |
| zigo | It's crazy that we already have approved 1.3.1.0 in Horizon, but that the xstatic-bootstrap-datepicker repo gets no approval. | 06:44 |
| *** nlahouti has quit IRC | 06:45 | |
| zigo | amotoki: You're core, right? Could you review these? https://review.openstack.org/#/q/status:open+project:stackforge/xstatic-bootstrap-datepicker,n,z | 06:45 |
| zigo | amotoki: I really need them, otherwise, I can't work out Debian packages ... | 06:45 |
| amotoki | zigo: i can. my question above comes from the pending reviews. how can I check the difference from the upstream... | 06:46 |
| *** e0ne has joined #openstack-horizon | 06:46 | |
| rdopieralski | amotoki: 1. the link to the homepage is in metadata at line 31 of https://review.openstack.org/#/c/116866/1/xstatic/pkg/bootstrap_datepicker/__init__.py | 06:46 |
| rdopieralski | amotoki: yes, horizon uses 1.3.1.0 now | 06:46 |
| amotoki | rdopieralski: thanks | 06:46 |
| zigo | rdopieralski: Where's upstream source code for 1.3.1 ? | 06:46 |
| zigo | (sorry to insist ...) | 06:46 |
| amotoki | rdopieralski: I was looking for the information in the repo tree..... | 06:47 |
| *** sayan_ has quit IRC | 06:48 | |
| rdopieralski | amotoki: if you have any suggestions on how I can improve the setup of those repositories... | 06:48 |
| amotoki | rdopieralski: I think it already has good information. I just didn't check __init__ file.... | 06:48 |
| rdopieralski | yeah, xstatic is funny like that with actual content in the __init__ file, we can't help it | 06:49 |
| amotoki | rdopieralski: it may be better we have a pointer to __init__ file in README file at the top directory. | 06:50 |
| rdopieralski | good idea | 06:50 |
| zigo | Good idea, but like 20 repo to update ... :/ | 06:50 |
| zigo | rdopieralski: IMO, just document that in the main xstatic package, not on all of the others... | 06:50 |
| amotoki | yeah we have many .... :( | 06:50 |
| zigo | We don't need to have that information duplicated X times. | 06:51 |
| zigo | Oh... | 06:51 |
| zigo | rdopieralski: Do you have commit rights for xstatic itself? | 06:51 |
| rdopieralski | zigo: I belive it's mentioned in the xstatic documentation | 06:51 |
| zigo | Then fine... | 06:51 |
| rdopieralski | I don't have commit rights, but the author is responsibe and accepts pull requests | 06:52 |
| rdopieralski | I can get him to give me commit rights if need be | 06:52 |
| zigo | rdopieralski: And what about the upstream sources for libjs-bootstrap-datepicker 1.3.1 ? :) | 06:55 |
| rdopieralski | amotoki: thank you for your reviews, I hope it will all merge now... if I didn't break the repo setup | 06:55 |
| zigo | Where did you grap the sources? | 06:55 |
| zigo | Is it a specific version for the xstatic package? | 06:55 |
| rdopieralski | zigo: https://github.com/eternicode/bootstrap-datepicker/ | 06:56 |
| zigo | rdopieralski: This repository does *not* have 1.3.1, but only 1.3.0. | 06:56 |
| *** lcheng has quit IRC | 06:56 | |
| rdopieralski | hmm, wait | 06:56 |
| rdopieralski | rbertram: ^^ | 06:57 |
| rdopieralski | zigo: rbertram where did you get 1.3.1? | 06:57 |
| *** e0ne has quit IRC | 06:58 | |
| * rdopieralski has a feeling he screwed up | 06:58 | |
| *** akrivoka has joined #openstack-horizon | 06:59 | |
| zigo | rdopieralski: Would 1.3.0 be ok? | 07:01 |
| rdopieralski | zigo: it's not my patch, so I don't know, honestly | 07:02 |
| zigo | :/ | 07:02 |
| zigo | maximum frustration ... | 07:02 |
| zigo | :) | 07:02 |
| zigo | FYI, Horizon is currently broken in Debian because I don't have datepicker up-to-date (and the compressor can't find datepicker3.css, therefore the postinst crashes...) | 07:04 |
| amotoki | datepicker 1.3.0 looks good to me. I put -1 to 1.3.1 update due to lack of the upstream information. It potentialluy causes version numbering problem. | 07:04 |
| nikunj2512 | Hi, now branch for kilo is open, so will i have to rebase my existing patches for the kilo branch?? | 07:05 |
| *** vokhrimenko has joined #openstack-horizon | 07:06 | |
| zigo | I'll try to work this out with 1.3.0, then let's see how it goes... | 07:06 |
| rdopieralski | I think 1.3.1 was required for i18n of month names or something like that | 07:07 |
| zigo | Oh ok, so that's "kind of" fine (eg: can be fixed later on...) | 07:07 |
| rdopieralski | rbertram knows the details, I hope he can explain when he comes | 07:07 |
| zigo | Let's wait until he wakes up! :P | 07:07 |
| rdopieralski | otherwise we are going to have a bad time rolling back the global requirements | 07:08 |
| amotoki | nikunj2512: not necessarily if your patch does conflict with the master branch. | 07:08 |
| zigo | BTW, it's annoying that the upstream repository for libjs-twitter-bootstrap-datepicker has some non-free files... : find . -iname '*min*' | 07:08 |
| zigo | ./tests/assets/jquery-1.7.1.min.js | 07:08 |
| rdopieralski | weird | 07:08 |
| rdopieralski | well, xstatic never includes tests... :) | 07:09 |
| zigo | Well, I'm packaging a libjs- lib separately ... :P | 07:10 |
| rdopieralski | maybe you could just symlink it? | 07:10 |
| * rdopieralski has no idea what techniques are kosher | 07:11 | |
| *** akrivoka has quit IRC | 07:11 | |
| zigo | rdopieralski: Not in a source package, no. | 07:12 |
| zigo | Hum... | 07:12 |
| zigo | Maybe at runtime. | 07:12 |
| zigo | I mean build time. | 07:12 |
| zigo | Though I wont be running the unit tests of that package at build time, so I don't really care, I'll just remove the file from the source package and upload that ... | 07:12 |
| *** hhuang has quit IRC | 07:13 | |
| nikunj2512 | @amotoki: Thank you | 07:14 |
| *** cedrics has joined #openstack-horizon | 07:15 | |
| zigo | rdopieralski: Thanks for all the info btw. | 07:15 |
| rdopieralski | zigo: thank you for doing the work | 07:17 |
| zigo | :) | 07:17 |
| *** ttrifonov_zZzz is now known as ttrifonov | 07:18 | |
| zigo | rdopieralski: Have you seen that Canonical people are reverting all of it? | 07:18 |
| zigo | This is crazy stuff... | 07:18 |
| zigo | They are re-embedding all the xstatic packages in Horizon. | 07:19 |
| zigo | They will regret it, I'm sure. | 07:19 |
| zigo | It's a way more easy to update a small libjs- package than the full of Horizon. | 07:19 |
| rdopieralski | zigo: you mean they copy all the js and css files back into horizon's tree? | 07:19 |
| zigo | rdopieralski: BTW, someone has to track security issues for all of the JS things, will you do that in the future? | 07:20 |
| zigo | rdopieralski: Yeah, that's what James Page wrote to me yesterday on #debian-openstack in OFTC. | 07:20 |
| rdopieralski | what have I done | 07:20 |
| zigo | rdopieralski: It's *stupid* work that they do if you ask me. | 07:20 |
| zigo | One more reason to not use OpenStack in Ubuntu ... :) | 07:21 |
| zigo | rdopieralski: James Page told me that this was a decision from the Canonical security team, which don't want to manage all of the libjs in Ubuntu main. | 07:21 |
| zigo | I don't think he's so happy about it. | 07:21 |
| *** pkoniszewski has joined #openstack-horizon | 07:22 | |
| rdopieralski | politics... | 07:22 |
| zigo | So, that reason, plus the fact that they are in deep freeze. | 07:22 |
| rdopieralski | zigo: I will need to check back with my manager about tracking the security issues, but I suppose I have been chosen | 07:22 |
| zigo | Good to know. | 07:23 |
| rdopieralski | I mean, nobody else is doing it? | 07:23 |
| rdopieralski | so I will have to start | 07:23 |
| *** jtomasek has joined #openstack-horizon | 07:25 | |
| *** cedrics has quit IRC | 07:30 | |
| *** cedrics has joined #openstack-horizon | 07:31 | |
| *** ZZelle has quit IRC | 07:44 | |
| *** ZZelle has joined #openstack-horizon | 07:44 | |
| *** dsneddon_ has quit IRC | 07:44 | |
| *** Ala has joined #openstack-horizon | 07:44 | |
| *** dsneddon_ has joined #openstack-horizon | 07:45 | |
| *** e0ne has joined #openstack-horizon | 07:46 | |
| *** hhuang has joined #openstack-horizon | 07:50 | |
| *** romainh has joined #openstack-horizon | 07:51 | |
| *** e0ne has quit IRC | 07:56 | |
| *** e0ne has joined #openstack-horizon | 07:57 | |
| *** qba73 has joined #openstack-horizon | 08:00 | |
| *** jpich has joined #openstack-horizon | 08:02 | |
| *** regebro has joined #openstack-horizon | 08:07 | |
| *** ygbo has joined #openstack-horizon | 08:10 | |
| *** sc-rm has quit IRC | 08:14 | |
| zigo | rdopieralski: It's particularly annoying that some packages don't follow upstream / debian-package structure for files. | 08:14 |
| zigo | rdopieralski: For example, jquery-ui: | 08:15 |
| zigo | # ls xstatic/pkg/jquery_ui/data/ | 08:15 |
| zigo | images jquery-ui.css jquery-ui.js jquery-ui.min.css jquery-ui.min.js jquery-ui.structure.css jquery-ui.structure.min.css jquery-ui.theme.css jquery-ui.theme.min.css themes | 08:15 |
| zigo | But then in Debian: | 08:15 |
| zigo | # ls /usr/share/javascript/jquery-ui | 08:15 |
| zigo | css jquery-ui.js jquery-ui.min.js themes ui | 08:15 |
| zigo | So, I'll have to rework the package to do individual symlinks for each file ... :( | 08:15 |
| *** jcoufal has joined #openstack-horizon | 08:19 | |
| rdopieralski | zigo: no | 08:20 |
| rdopieralski | zigo: that's actually the problem we've been discussing | 08:20 |
| zigo | rdopieralski: What do you mean "no" ? :) | 08:20 |
| *** ramishra has quit IRC | 08:20 | |
| rdopieralski | zigo: those packages follow the structure of the upstream project | 08:21 |
| rdopieralski | zigo: it's that jquery-ui changed its structure between versions | 08:21 |
| zigo | Ah ok, so it's the Debian libjs-jquery-ui package who isn't then ... | 08:21 |
| zigo | Oh... :/ | 08:21 |
| zigo | Never mind, burden on me then... | 08:21 |
| rdopieralski | zigo: but that's fine, because horizon checks the version and uses a different directory structure depending on it | 08:21 |
| *** Dafna has joined #openstack-horizon | 08:22 | |
| rdopieralski | zigo: so just get the xstatic package for the version that you actually have | 08:22 |
| zigo | rdopieralski: Well, probably the Debian maintainer didn't follow upstream and kept the old structure in order to avoid breakage with existing packages. | 08:22 |
| rdopieralski | zigo: in this case it's important that the version of the xstatic package matches the version of the actual static files | 08:23 |
| zigo | rdopieralski: Well, as I said, I'm going to do individual symlinks for every files you have in the xstatic-jquery-ui package. I did that for a few xstatic packages already, it worked out well. | 08:23 |
| zigo | Very annoying, but doable. | 08:23 |
| rdopieralski | ugh | 08:30 |
| rdopieralski | zigo: why not just change the path in the __init__ file? | 08:30 |
| *** hhuang has quit IRC | 08:34 | |
| *** lsmola has joined #openstack-horizon | 08:37 | |
| *** coolsvap is now known as coolsvap|afk | 08:40 | |
| *** ramishra has joined #openstack-horizon | 08:41 | |
| *** athomas has joined #openstack-horizon | 08:41 | |
| *** cedricss has joined #openstack-horizon | 08:41 | |
| *** cedrics has quit IRC | 08:44 | |
| *** k4n0 has quit IRC | 08:46 | |
| *** akrivoka has joined #openstack-horizon | 08:50 | |
| *** coolsvap|afk is now known as coolsvap | 08:51 | |
| *** Clabbe has quit IRC | 08:52 | |
| *** pbelanyi_ is now known as pbelanyi | 08:52 | |
| *** krykowski has joined #openstack-horizon | 08:55 | |
| *** alexpilotti has joined #openstack-horizon | 08:59 | |
| exploreshaifali | I have submitted a patch, need it to be reiewed https://review.openstack.org/#/c/126141/ | 08:59 |
| *** k4n0 has joined #openstack-horizon | 09:01 | |
| *** ttrifonov is now known as ttrifonov_zZzz | 09:03 | |
| *** ttrifonov_zZzz is now known as ttrifonov | 09:04 | |
| rdopieralski | exploreshaifali: is there any particular reason why your patch should be reviewed before all the other patches that all the other people have submitted? | 09:05 |
| nikunj2512 | Does anyone know how to upgrade the tox enviroment?? | 09:05 |
| rdopieralski | nikunj2512: I just delete it, usually | 09:06 |
| nikunj2512 | @rdopieralski: Thank You | 09:06 |
| rdopieralski | nikunj2512: I mean, the .tox directory | 09:07 |
| rdopieralski | but I think that tox is smart enough to upgrade it on itself | 09:07 |
| *** aix has joined #openstack-horizon | 09:07 | |
| nikunj2512 | @rdopieralski: Sadly it is not :( | 09:07 |
| exploreshaifali | rdopieralski, no no nothing like that, I will be participating in opw this round, and for that only I was trying to fix a bug and submit a patch.... actually this is in progress state | 09:08 |
| exploreshaifali | rdopieralski, I want views of others, that whatever I did(used <em>) tag is okay or I should do something else | 09:09 |
| rdopieralski | exploreshaifali: the thing is, we have hundreds of patches to review and very few reviewers, so it takes time | 09:16 |
| rdopieralski | exploreshaifali: you can help a little by reviewing some patches yourself | 09:16 |
| exploreshaifali | rdopieralski, :D sure, I can try for that | 09:17 |
| *** e0ne has quit IRC | 09:18 | |
| *** MaxV has joined #openstack-horizon | 09:26 | |
| *** k4n0 has quit IRC | 09:41 | |
| *** Longgeek has joined #openstack-horizon | 09:44 | |
| *** Longgeek has quit IRC | 09:46 | |
| *** Longgeek has joined #openstack-horizon | 09:47 | |
| *** dulek has joined #openstack-horizon | 09:49 | |
| *** qba73 has quit IRC | 09:50 | |
| *** qba73 has joined #openstack-horizon | 09:51 | |
| *** dulek_ has joined #openstack-horizon | 09:57 | |
| *** k4n0 has joined #openstack-horizon | 09:57 | |
| *** dulek has quit IRC | 09:57 | |
| *** dulek_ has quit IRC | 10:04 | |
| *** akrivoka has quit IRC | 10:09 | |
| *** akrivoka has joined #openstack-horizon | 10:09 | |
| *** dulek has joined #openstack-horizon | 10:10 | |
| *** sayan has quit IRC | 10:10 | |
| *** jprovazn has quit IRC | 10:14 | |
| *** dulek_ has joined #openstack-horizon | 10:15 | |
| *** krykowski has quit IRC | 10:15 | |
| *** dulek has quit IRC | 10:15 | |
| *** krykowski has joined #openstack-horizon | 10:23 | |
| *** sayan has joined #openstack-horizon | 10:23 | |
| *** tosky has joined #openstack-horizon | 10:36 | |
| *** bradjones has joined #openstack-horizon | 10:40 | |
| *** qba73 has quit IRC | 10:40 | |
| *** qba73 has joined #openstack-horizon | 10:41 | |
| *** qba73 has quit IRC | 10:42 | |
| *** vkmc has joined #openstack-horizon | 10:44 | |
| *** harlowja_away has quit IRC | 10:47 | |
| *** nikunj2512 has quit IRC | 10:48 | |
| *** amotoki has quit IRC | 10:48 | |
| *** e0ne has joined #openstack-horizon | 10:58 | |
| *** qba73 has joined #openstack-horizon | 11:01 | |
| *** alexpilotti has quit IRC | 11:03 | |
| *** dulek_ has quit IRC | 11:08 | |
| *** krykowski_ has joined #openstack-horizon | 11:13 | |
| *** pkoniszewski has quit IRC | 11:16 | |
| *** krykowski has quit IRC | 11:18 | |
| *** coolsvap is now known as coolsvap|afk | 11:23 | |
| *** nikunj2512 has joined #openstack-horizon | 11:25 | |
| *** qba73 has quit IRC | 11:29 | |
| *** qba73 has joined #openstack-horizon | 11:31 | |
| *** qba73 has quit IRC | 11:32 | |
| *** dsneddon_ has quit IRC | 11:33 | |
| *** dsneddon_ has joined #openstack-horizon | 11:34 | |
| *** mflobo has joined #openstack-horizon | 11:36 | |
| zigo | rdopieralski: There's some images I can't find in the Debian jquery-ui package. | 11:38 |
| zigo | Like ui-bg_diagonals-thick_18_b81900_40x40.png for example. | 11:38 |
| zigo | rdopieralski: Do you know if they are used? | 11:38 |
| *** qba73 has joined #openstack-horizon | 11:39 | |
| zigo | rdopieralski: Also, there's all the themes by default in the xstatic package, in Debian, it's one package per theme. | 11:42 |
| zigo | rdopieralski: Could you tell which one is in use? | 11:42 |
| *** sayan has quit IRC | 11:42 | |
| zigo | It's looking like I'll have to symlink each individual image... :( | 11:46 |
| *** pkoniszewski has joined #openstack-horizon | 11:47 | |
| rdopieralski | zigo: we don't use any images | 11:48 |
| rdopieralski | zigo: or any css | 11:48 |
| zigo | rdopieralski: Oh ok, good! :) | 11:48 |
| rdopieralski | zigo: as far as I know we only unclude the js from jquery-ui | 11:48 |
| rdopieralski | include* | 11:48 |
| zigo | Currently, I do: | 11:48 |
| zigo | for i in $(CURDIR)/debian/python*-jquery-ui/usr/lib/python*/dist-packages/xstatic/pkg/jquery_ui/data ; do \ | 11:48 |
| zigo | ln -s /usr/share/javascript/jquery-ui/jquery-ui.js $$i/jquery-ui.js ; \ | 11:48 |
| zigo | ln -s /usr/share/javascript/jquery-ui/jquery-ui.min.js $$i/jquery-ui.min.js ; \ | 11:48 |
| zigo | ln -s /usr/share/javascript/jquery-ui/themes/base/jquery-ui.theme.css $$i/jquery-ui.theme.css ; \ | 11:48 |
| zigo | ln -s /usr/share/javascript/jquery-ui/css/smoothness/jquery-ui.css $$i/jquery-ui.css ; \ | 11:48 |
| zigo | ln -s /usr/share/javascript/jquery-ui/jquery.ui.theme.css/jquery-ui.theme.min.css $$i/jquery-ui.theme.min.css ; \ | 11:48 |
| zigo | ln -s /usr/share/javascript/jquery-ui/themes $$i/themes ; \ | 11:49 |
| zigo | ln -s /usr/share/javascript/jquery-ui/themes $$i/images ; \ | 11:49 |
| zigo | done | 11:49 |
| *** dulek has joined #openstack-horizon | 11:49 | |
| zigo | I'll remove the images folder then... | 11:49 |
| zigo | (I was working on it) | 11:49 |
| rdopieralski | no themes either | 11:49 |
| rdopieralski | and I *think* we don't use the i18n | 11:50 |
| zigo | rdopieralski: Then it's a bit silly to have *all* theme by default in the xstatic package, but never mind, it wont even be on the Debian source pcakge. | 11:50 |
| rdopieralski | zigo: the idea for the xstatic packages is that they are used by other projects too | 11:50 |
| zigo | Right. | 11:50 |
| rdopieralski | zigo: and in the case of jquery-ui, they are | 11:50 |
| rdopieralski | zigo: by Moin Moin 2 | 11:51 |
| zigo | But I don't really care about that (yet). | 11:51 |
| zigo | If someone in Debian needs it, I'll fix it. | 11:51 |
| zigo | Oh! moin moin is the wiki of Debian! :) | 11:51 |
| *** dulek has quit IRC | 11:55 | |
| *** sayan has joined #openstack-horizon | 11:55 | |
| *** regebro_ has joined #openstack-horizon | 11:58 | |
| *** regebro is now known as Guest38351 | 11:58 | |
| *** regebro_ is now known as regebro | 11:58 | |
| *** Guest38351 has joined #openstack-horizon | 11:59 | |
| *** regebro has quit IRC | 11:59 | |
| *** Guest38351 is now known as regebro | 11:59 | |
| *** pkoniszewski has quit IRC | 11:59 | |
| *** regebro is now known as Guest5639 | 11:59 | |
| *** krykowski_ has quit IRC | 11:59 | |
| *** regebro2 has joined #openstack-horizon | 12:00 | |
| *** krykowski has joined #openstack-horizon | 12:01 | |
| *** tzumainn has joined #openstack-horizon | 12:05 | |
| *** asahlin has quit IRC | 12:05 | |
| *** qba73 has quit IRC | 12:06 | |
| *** asahlin has joined #openstack-horizon | 12:06 | |
| *** qba73 has joined #openstack-horizon | 12:07 | |
| mflobo | Why, in the image edition window, the "architecture" property is "read only"? | 12:07 |
| *** regebro2 has quit IRC | 12:07 | |
| *** sambetts has joined #openstack-horizon | 12:14 | |
| *** qba73 has quit IRC | 12:20 | |
| *** qba73 has joined #openstack-horizon | 12:21 | |
| zigo | rdopieralski: Do we use jquery-ui.theme.css / jquery-ui.theme.min.css? | 12:27 |
| zigo | Cause these aren't in Debian ... | 12:28 |
| rdopieralski | zigo: no | 12:31 |
| zigo | Cool. | 12:31 |
| *** alexpilotti has joined #openstack-horizon | 12:33 | |
| *** jprovazn has joined #openstack-horizon | 12:37 | |
| *** jprovazn is now known as jprovazn_afk | 12:37 | |
| *** alexpilotti_ has joined #openstack-horizon | 12:37 | |
| *** alexpilotti has quit IRC | 12:37 | |
| *** alexpilotti_ is now known as alexpilotti | 12:37 | |
| *** asahlin has quit IRC | 12:38 | |
| rbertram | rdopieralski, zigo: Hi I am awake now, looking through messages & notes | 12:41 |
| zigo | rbertram: Thanks! :) | 12:41 |
| zigo | rbertram: Basically, where may I find bootstrap-datepicker 1.3.1 source code? It's nowhere available (not on the github account...). | 12:42 |
| *** ramishra has quit IRC | 12:43 | |
| *** ayoung-ZzzZzzZzz is now known as ayoung | 12:44 | |
| rbertram | To answer an earlier question, the 1.3.1 patch fixes a bug in 1.3.0. The bug throws a javascript exception if you click on the date that is already selected. | 12:44 |
| *** vijendar has joined #openstack-horizon | 12:44 | |
| rdopieralski | rbertram: but where is the source code for 1.3.1? | 12:44 |
| rbertram | getting it | 12:44 |
| *** julim has joined #openstack-horizon | 12:46 | |
| rbertram | https://github.com/n9/bootstrap-datepicker/tree/1.3.1 | 12:47 |
| *** Guest5639 has quit IRC | 12:49 | |
| *** regebro2 has joined #openstack-horizon | 12:49 | |
| *** regebro2 has quit IRC | 12:49 | |
| *** regebro has joined #openstack-horizon | 12:49 | |
| rbertram | rdopieralski: Is there a problem with that? | 12:49 |
| *** regebro has quit IRC | 12:50 | |
| *** regebro has joined #openstack-horizon | 12:50 | |
| rdopieralski | rbertram: in that case you should update the project url in the __init__ | 12:51 |
| rdopieralski | rbertram: can you do it, and bump the release version? | 12:53 |
| *** _crobertsrh is now known as crobertsrh | 12:54 | |
| rbertram | rdopieralski: Glad to, just a newbie at this :-) | 12:54 |
| *** asahlin has joined #openstack-horizon | 12:54 | |
| rdopieralski | rbertram: please do it as another version of the patch that bumps to 1.3.1 | 12:58 |
| *** aix has quit IRC | 12:58 | |
| rbertram | rdopieralski: Since https://review.openstack.org/#/c/116866/ is merged, you don't want me to just change __init__.py? | 12:58 |
| rdopieralski | rbertram: it's not merged | 12:59 |
| rdopieralski | rbertram: that's the problem | 12:59 |
| *** aix has joined #openstack-horizon | 12:59 | |
| rbertram | rdopieralski: I see. So I change the existing patch? | 13:00 |
| rdopieralski | yes, but also bump the release version, so that we can have a new release on pypi once this gets merged properly | 13:00 |
| rbertram | rdopieralski: OK | 13:01 |
| rdopieralski | s/releae/packaging | 13:01 |
| rdopieralski | BUILD | 13:01 |
| rdopieralski | that's how they call it there | 13:01 |
| *** raildo_away has quit IRC | 13:02 | |
| afaranha | As I saw, the network, compute and block Blueprints for RBAC support ( https://blueprints.launchpad.net/horizon/+spec/rbac-panels ) doesn't have tests for them | 13:07 |
| afaranha | I'm implementing RBAC Identity support and would like to know where can I test if some panels are visible or not | 13:08 |
| *** hhuang has joined #openstack-horizon | 13:09 | |
| afaranha | or if it's not needed | 13:10 |
| *** krykowski_ has joined #openstack-horizon | 13:15 | |
| *** krykowski has quit IRC | 13:16 | |
| *** jay-atl has quit IRC | 13:18 | |
| *** krykowski has joined #openstack-horizon | 13:19 | |
| *** katyafervent is now known as katyafervent_awa | 13:20 | |
| *** krykowski_ has quit IRC | 13:20 | |
| *** krykowski_ has joined #openstack-horizon | 13:20 | |
| *** krykowski has quit IRC | 13:24 | |
| rbertram | rdopieralski: so in __init__.py, BUILD = '0' becomes BUILD = '1' , right? | 13:25 |
| rdopieralski | rbertram: yup | 13:25 |
| *** mikedillion has joined #openstack-horizon | 13:26 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 13:30 | |
| *** vijendar has quit IRC | 13:30 | |
| *** peristeri has joined #openstack-horizon | 13:32 | |
| rbertram | rdopieralski: just committed; look ok? | 13:32 |
| *** krykowski has joined #openstack-horizon | 13:33 | |
| *** absubram has joined #openstack-horizon | 13:35 | |
| rdopieralski | rbertram: I think that just "https://github.com/n9/bootstrap-datepicker" is enough for the homepage | 13:36 |
| *** krykowski_ has quit IRC | 13:36 | |
| *** absubram has quit IRC | 13:38 | |
| rbertram | rdopieralski: that makes sense, now that you mention it. No need to change it again for a new version. I will fix it again. | 13:38 |
| *** neelashah has joined #openstack-horizon | 13:40 | |
| *** vijendar has joined #openstack-horizon | 13:40 | |
| *** pkarikh has joined #openstack-horizon | 13:40 | |
| rbertram | rdopieralski: committed again | 13:43 |
| *** masco has quit IRC | 13:44 | |
| *** ramishra has joined #openstack-horizon | 13:53 | |
| zigo | rbertram: Thanks! | 13:55 |
| zigo | rbertram: What's the review URL? | 13:55 |
| rbertram | zigo: https://review.openstack.org/#/c/116866/ | 13:57 |
| rbertram | zigo, rdopieralski: Sorry for the trouble | 13:57 |
| zigo | rbertram: I do appreciate a lot the xstatic effort thing, though it's kind of late in the release. | 13:58 |
| rdopieralski | rbertram: not at all, it's my fault for introducing the whole chaos and not going through the normal review process | 13:58 |
| zigo | I've spent all my time today on Horizon, instead of testing all of Juno... :( | 13:58 |
| rdopieralski | zigo: we started at the beginning of Juno | 13:58 |
| rdopieralski | zigo: global requirements patches took a lot of time | 13:58 |
| rdopieralski | to get merged | 13:59 |
| zigo | rdopieralski: Yeah, but you should have stopped earlier, even if it wasn't finished. | 13:59 |
| zigo | rdopieralski: Sure, but I couldn't test it before the RC1 of Horizon. | 13:59 |
| zigo | And I'm discovering issues *now* ... | 13:59 |
| rdopieralski | zigo: I will keep it in mind for the horizon/horizon_lib split in Kilo | 13:59 |
| zigo | :) | 13:59 |
| zigo | Sorry if I'm a bit grumpy today... | 14:00 |
| rdopieralski | no, that's totally natural | 14:00 |
| *** pkarikh has quit IRC | 14:01 | |
| *** cody-somerville has joined #openstack-horizon | 14:02 | |
| *** cody-somerville has quit IRC | 14:02 | |
| *** cody-somerville has joined #openstack-horizon | 14:02 | |
| zigo | libjs-twitter-bootstrap-datepicker_1.3.1+dfsg1-1 uploaded to unstable. | 14:02 |
| zigo | :) | 14:02 |
| *** regebro has quit IRC | 14:03 | |
| *** doug-fish has joined #openstack-horizon | 14:05 | |
| *** vijendar has quit IRC | 14:06 | |
| zigo | rdopieralski: I still get some jquery-ui issues when building horizon: https://juno.dev-debian.pkgs.enovance.com/job/horizon/35/consoleFull | 14:17 |
| zigo | rdopieralski: How can I check the path thing? (eg: where should I look into?) | 14:18 |
| *** ericpeterson has joined #openstack-horizon | 14:18 | |
| zigo | I don't even see xstatic stuff in the stack dump... | 14:19 |
| mrunge | zigo, you mean the uncompressablefileerrors? | 14:21 |
| zigo | mrunge: yes | 14:21 |
| zigo | It can't find jquery-ui.js | 14:21 |
| zigo | I don't get why ... | 14:21 |
| rdopieralski | zigo: the settings.py file | 14:22 |
| rdopieralski | zigo: in openstack_dashboard/settings.py | 14:22 |
| mrunge | zigo, I'd check xstatic-jquery-ui | 14:22 |
| mrunge | zigo, xstatic is quite simple, but it needs to get the right files | 14:23 |
| zigo | # ls -lah /usr/lib/python2.7/dist-packages/xstatic/pkg/jquery_ui/data/jquery-ui.js | 14:23 |
| zigo | lrwxrwxrwx 1 root root 60 Oct 6 12:31 /usr/lib/python2.7/dist-packages/xstatic/pkg/jquery_ui/data/jquery-ui.js -> ../../../../../../../share/javascript/jquery-ui/jquery-ui.js | 14:23 |
| zigo | This looks good to me ! | 14:23 |
| *** julim has quit IRC | 14:23 | |
| zigo | Which is why I don't understand. | 14:23 |
| mrunge | zigo, we collect all javascript files in some javascript dir | 14:24 |
| mrunge | and I modify those xstatic files to directly read from that javascript path | 14:25 |
| mrunge | it works quite well and does not need any links etc. | 14:25 |
| *** katyafervent_awa is now known as katyafervent | 14:25 | |
| zigo | mrunge: I don't think you get what I did... | 14:25 |
| mrunge | zigo, you made a link | 14:26 |
| zigo | mrunge: I packaged python-xstatic-jquery-ui in Debian to use the files from libjs-jquery-ui. | 14:26 |
| mrunge | which is not exactly the same | 14:26 |
| zigo | mrunge: Yeah, and for a good reason: the layout in the Debian package of libjs-jquery-ui isn't the same as the one in the xstatic package. | 14:26 |
| mrunge | zigo, same here | 14:27 |
| zigo | mrunge: What worries me is the fact that we're having "jquery-ui/ui" <--- why the additional "ui" ? | 14:27 |
| mrunge | zigo, that was an upstream decision | 14:27 |
| mrunge | i mean jquery-ui upstream decision | 14:27 |
| zigo | mrunge: But itsn't it looking like it's my issue? | 14:27 |
| *** david-lyle has joined #openstack-horizon | 14:28 | |
| zigo | mrunge: Shouldn't I try to move stuff into a "ui" folder in the xstatic-jquery-ui Debian package? | 14:28 |
| mrunge | zigo, I haven't built rc1 for fedora yet, I have to get 2 additional deps reviewed first | 14:28 |
| zigo | Ok. | 14:28 |
| *** gokrokve has joined #openstack-horizon | 14:28 | |
| mrunge | zigo, as far as I saw, rdopieralski kept that change in mind | 14:28 |
| mrunge | but I might be wrong here | 14:29 |
| * zigo is testing | 14:31 | |
| *** dsneddon_ has quit IRC | 14:31 | |
| *** jcoufal has quit IRC | 14:31 | |
| *** dsneddon_ has joined #openstack-horizon | 14:32 | |
| zigo | Gosh, it's looking like it's working in Sid... :/ | 14:33 |
| zigo | Something must be wrong in my Wheezy setup. | 14:33 |
| *** absubram has joined #openstack-horizon | 14:33 | |
| *** jcoufal has joined #openstack-horizon | 14:34 | |
| *** vkmc has quit IRC | 14:34 | |
| *** radez_g0n3 is now known as radez | 14:34 | |
| *** krykowski has quit IRC | 14:35 | |
| *** masco has joined #openstack-horizon | 14:35 | |
| *** rebelagentm has joined #openstack-horizon | 14:35 | |
| *** jacalcat has joined #openstack-horizon | 14:38 | |
| *** coolsvap|afk is now known as coolsvap | 14:41 | |
| *** rbertram has quit IRC | 14:43 | |
| *** aix has quit IRC | 14:48 | |
| zigo | mrunge: The problem is indeed the "ui" folder, though it appears only in Wheezy, which is weird. | 14:50 |
| *** qba73 has quit IRC | 14:53 | |
| rdopieralski | zigo: the settings.py has some code that checks the installed version of xstatic-jquery-ui and uses a different url depending on it (including ui or not) | 14:56 |
| rdopieralski | zigo: I had to do that to support different directory structure in different versions of jquery-ui | 14:56 |
| *** qba73 has joined #openstack-horizon | 14:57 | |
| *** jay-atl has joined #openstack-horizon | 14:57 | |
| *** coolsvap is now known as coolsvap|afk | 14:58 | |
| *** amotoki has joined #openstack-horizon | 14:58 | |
| *** rdopieralski has quit IRC | 14:58 | |
| *** vijendar has joined #openstack-horizon | 14:58 | |
| *** aix has joined #openstack-horizon | 15:00 | |
| *** dsneddon_ has quit IRC | 15:00 | |
| *** dsneddon_ has joined #openstack-horizon | 15:02 | |
| *** gokrokve_ has joined #openstack-horizon | 15:05 | |
| *** gokrokve has quit IRC | 15:08 | |
| *** sayan has quit IRC | 15:14 | |
| amotoki | david-lyle: jpich: I updated Horizon meeting agenda to share RC2 potential topics. https://wiki.openstack.org/wiki/Meetings/Horizon | 15:15 |
| jpich | Thanks amotoki! | 15:15 |
| amotoki | I don't think we need to discuss them now, and just would like to discuss our meeting tomorrow. | 15:15 |
| david-lyle | amotoki, jpich: I am unfortunately going to be on a plane during meeting time tomorrow, maybe we should do it now if you have time | 15:16 |
| amotoki | jpich: there are several progress in i18n topics. | 15:16 |
| *** ericpeterson has quit IRC | 15:16 | |
| amotoki | david-lyle: I am okay now. | 15:16 |
| david-lyle | or I'll read the log when I land to catch up | 15:16 |
| jpich | amotoki: I saw the logs from last week's meeting, thanks for driving the translation discussion and imports again | 15:17 |
| *** ericpeterson has joined #openstack-horizon | 15:17 | |
| *** echevemaster has joined #openstack-horizon | 15:17 | |
| *** cedricss has quit IRC | 15:17 | |
| david-lyle | which reminds me, jpich or amotoki would you mind leading tomorrow's meeting :) | 15:17 |
| *** jtomasek has quit IRC | 15:18 | |
| jpich | david-lyle: Since amotoki has written up most of the agenda it might make more sense for him to lead it :) But I don't mind at all chairing it either way | 15:19 |
| *** julim has joined #openstack-horizon | 15:19 | |
| jpich | ...After missing it for ages lol | 15:19 |
| david-lyle | penance | 15:19 |
| david-lyle | :) | 15:19 |
| amotoki | I can host tomorrow meeting too. | 15:20 |
| david-lyle | thanks amotoki! | 15:20 |
| jpich | Cool, I shall be here as support! ;) | 15:20 |
| amotoki | though it will the first time to me | 15:20 |
| jpich | Congratulations? | 15:20 |
| jpich | :) | 15:20 |
| amotoki | :) | 15:20 |
| *** dsneddon_ has quit IRC | 15:21 | |
| *** david-lyle has quit IRC | 15:22 | |
| amotoki | most of the topics we have for RC2 are related to documentation, so I don't have much concern now. | 15:22 |
| *** david-lyle has joined #openstack-horizon | 15:22 | |
| david-lyle | chat client died on me | 15:22 |
| *** dsneddon_ has joined #openstack-horizon | 15:23 | |
| *** ericpeterson has joined #openstack-horizon | 15:25 | |
| amotoki | and the potential topic is xstatic related: xstatic-bootstrap-datepicker 1.3.1. | 15:25 |
| amotoki | we are importing bootstrap-datepicker from several places release by release.... https://review.openstack.org/#/c/116866/ | 15:26 |
| *** nikunj2512 has quit IRC | 15:26 | |
| amotoki | it is raised by zigo early today. | 15:27 |
| david-lyle | on https://review.openstack.org/#/c/126164/ it's not only deprecated, there are several places where it's not even acknowledged, IIRC | 15:27 |
| *** nikunj2512 has joined #openstack-horizon | 15:27 | |
| *** katyafervent is now known as katyafervent_awa | 15:27 | |
| david-lyle | amotoki, re: https://review.openstack.org/#/c/126164/1 what version do the distos support? | 15:30 |
| david-lyle | *distros | 15:30 |
| amotoki | in my understanding, OPENSTACK_QUANTUM_NETWORK is used only for enable_lb (LBaaS) in the past release. | 15:30 |
| amotoki | david-lyle: in Juno, we introduces is_enabled_by_config and this method looks up both *QUANTUM* and *NEUTRON* | 15:31 |
| david-lyle | amotoki, ok, I guess my thought was if a deployer had OPENSTACK_QUANTUM_NETWORK and merely made the name change when we did, they might have the mistaken conception that it would work the same | 15:32 |
| david-lyle | amotoki, I recall that patch | 15:32 |
| david-lyle | I thought it's use was not exhaustive | 15:32 |
| amotoki | david-lyle: most features are exposed thru *NEUTRON_NETWORK in Icehouse. | 15:32 |
| *** absubram has quit IRC | 15:32 | |
| david-lyle | but I may not be remembering correctly either | 15:32 |
| amotoki | in addition, *QUANTUM is still avaialble and the patch just add a deprecation notice. | 15:32 |
| amotoki | i forgot to propose a patch for RC1 :-( | 15:33 |
| david-lyle | we'll have an RC2 any way, I don't mind using it | 15:34 |
| amotoki | david-lyle: thanks | 15:35 |
| david-lyle | amotoki, here is an example of what I'm worried about | 15:35 |
| david-lyle | https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/network_topology/views.py#L106 | 15:35 |
| david-lyle | I should just propose a patch to replace those remaining instances | 15:36 |
| *** lcheng has joined #openstack-horizon | 15:36 | |
| amotoki | david-lyle: I think new options introduced in Icehouse or later uses OPENSTACK_NEUTORN_NETWORK setting. | 15:36 |
| david-lyle | amotoki, I understand, I don't think I | 15:37 |
| david-lyle | 'm being clear | 15:37 |
| amotoki | david-lyle: I'll check usage of *QUANTUM* again tomorrow. | 15:37 |
| david-lyle | OOENSTACK_QUANTUM_NETWORK to OPENSTACK_NEUTRON_NETWORK looks like a simple name change, but in fact, it's a name and functionality change | 15:38 |
| david-lyle | if a deployer was already using OPENSTACK_QUANTUM_NETWORK, they may incorrectly assume they can just plug in the other settings into their existing OPENSTACK_QUANTUM_NETWORK | 15:39 |
| david-lyle | probably not a large problem, but could easily see it happening | 15:39 |
| amotoki | so we don't remove it in Juno and just deprecate it in Juno (with warning in log message) | 15:39 |
| amotoki | so that we can remove OPENSTACK_QUANTUM_NETWORK in Kilo. | 15:40 |
| david-lyle | amotoki, that's fine, I'm just wondering if the log message is extensive enough | 15:40 |
| *** gokrokve_ has quit IRC | 15:40 | |
| david-lyle | perhaps point out that NEUTRON_NETWORK and QUANTUM_NETWORK are not equivalent | 15:41 |
| zigo | YEAAAH ! Got Horizon working again! \o/ | 15:41 |
| amotoki | according to my investigation, python DeprecationWarning is only logged first time it is used. | 15:41 |
| david-lyle | amotoki, ok, may not be worth pursuing a greater change | 15:41 |
| david-lyle | just wanted to get your opinion | 15:42 |
| amotoki | zigo: nice! what solves your problem? | 15:42 |
| *** dsneddon_ has quit IRC | 15:42 | |
| *** jcoufal has quit IRC | 15:43 | |
| zigo | amotoki: I had to do "ln -s . ui" in xstatic-jquery-ui. | 15:43 |
| zigo | amotoki: Plus some other crap I had to fix in some xstatic package (not interesting... my own bad). | 15:43 |
| *** lcheng has quit IRC | 15:43 | |
| *** dsneddon_ has joined #openstack-horizon | 15:44 | |
| amotoki | zigo: datepicker 1.3.1 seems to be got from another place accoridng to the new patchset of https://review.openstack.org/#/c/116866/ | 15:45 |
| zigo | amotoki: I got it, and fixed it. | 15:45 |
| amotoki | zigo: but I am concerning we use various sources and i am afraid it potentially causes a problem on versioning :-( | 15:46 |
| *** nlahouti has joined #openstack-horizon | 15:47 | |
| amotoki | zigo: what was the conversation on this with radomir? I didn't follow it after that. | 15:47 |
| *** qba73 has quit IRC | 15:47 | |
| zigo | amotoki: About jquery-ui path, but got it fixed with the symlink hack. | 15:48 |
| *** Drago has joined #openstack-horizon | 15:49 | |
| amotoki | zigo: happy to hear that. | 15:49 |
| zigo | Funny, my horizon is full of stuff from tempest! :) | 15:50 |
| *** Drago has quit IRC | 15:50 | |
| zigo | (from my last test in Icehouse...) | 15:50 |
| *** Drago has joined #openstack-horizon | 15:50 | |
| zigo | That date picker was worth the trouble, it's kind of nice. | 15:51 |
| *** Drago has quit IRC | 15:51 | |
| *** lcheng has joined #openstack-horizon | 15:51 | |
| *** Drago has joined #openstack-horizon | 15:51 | |
| amotoki | good night, all! | 15:51 |
| zigo | amotoki: I'm going to sleep as well. Bye ! :) | 15:51 |
| *** amotoki has quit IRC | 15:51 | |
| *** TravT has joined #openstack-horizon | 15:52 | |
| *** lcheng has quit IRC | 15:52 | |
| *** ramishra has quit IRC | 15:53 | |
| *** ramishra has joined #openstack-horizon | 15:54 | |
| *** sayali has joined #openstack-horizon | 15:54 | |
| *** bpokorny has joined #openstack-horizon | 15:55 | |
| *** ramishra_ has joined #openstack-horizon | 15:56 | |
| nikunj2512 | good night :) | 15:56 |
| *** ramishra has quit IRC | 15:57 | |
| *** masco has quit IRC | 15:57 | |
| *** ttrifonov is now known as ttrifonov_zZzz | 15:58 | |
| *** lcheng_ has joined #openstack-horizon | 15:58 | |
| *** exploreshaifali is now known as expshaifali|afk | 15:59 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 16:00 | |
| *** nikunj2512 has quit IRC | 16:00 | |
| *** ramishra_ has quit IRC | 16:02 | |
| *** ramishra has joined #openstack-horizon | 16:03 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 16:04 | |
| *** inyourgroove has joined #openstack-horizon | 16:05 | |
| *** coolsvap|afk is now known as coolsvap | 16:06 | |
| *** jprovazn_afk has quit IRC | 16:07 | |
| *** ramishra has quit IRC | 16:08 | |
| *** vokhrimenko has quit IRC | 16:12 | |
| *** e0ne has quit IRC | 16:12 | |
| *** lcheng_ has quit IRC | 16:14 | |
| *** inyourgroove has quit IRC | 16:14 | |
| *** akrivoka has quit IRC | 16:14 | |
| *** lhcheng has joined #openstack-horizon | 16:14 | |
| *** sayan_ has joined #openstack-horizon | 16:18 | |
| *** ygbo has quit IRC | 16:20 | |
| *** Longgeek has quit IRC | 16:21 | |
| *** esp has joined #openstack-horizon | 16:26 | |
| *** MaxV has quit IRC | 16:28 | |
| *** esp has quit IRC | 16:28 | |
| *** Guest84187 is now known as mfisch | 16:30 | |
| *** gokrokve has joined #openstack-horizon | 16:30 | |
| *** mfisch is now known as Guest9962 | 16:30 | |
| *** johnma has joined #openstack-horizon | 16:33 | |
| *** Ala has quit IRC | 16:35 | |
| *** jpich has quit IRC | 16:35 | |
| *** esp has joined #openstack-horizon | 16:37 | |
| *** expshaifali|afk is now known as exploreshaifali | 16:37 | |
| *** rwsu has joined #openstack-horizon | 16:44 | |
| tsufiev | folks, if I want to add a new JS library to Horizon (Sinon.js for different kinds of mocks and stubs in JS unit-tests), should I wrap it as xstatic package? | 16:46 |
| david-lyle | tsufiev, yes | 16:48 |
| *** neelashah1 has joined #openstack-horizon | 16:49 | |
| *** aix has quit IRC | 16:49 | |
| *** sbfox has joined #openstack-horizon | 16:50 | |
| tsufiev | david-lyle, is there some sort of tutorial for complete beginners with xstatic packaging :)? | 16:52 |
| *** neelashah has quit IRC | 16:52 | |
| *** gokrokve has quit IRC | 16:52 | |
| david-lyle | radomir added something to the docs, let me look | 16:52 |
| *** gokrokve has joined #openstack-horizon | 16:52 | |
| david-lyle | tsufiev, https://github.com/openstack/horizon/blob/master/doc/source/contributing.rst#javascript-and-css-libraries | 16:53 |
| tsufiev | david-lyle, ah, thank you! | 16:53 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 16:55 | |
| *** athomas has quit IRC | 16:55 | |
| *** romainh has quit IRC | 16:58 | |
| *** e0ne has joined #openstack-horizon | 17:01 | |
| *** MaxV has joined #openstack-horizon | 17:06 | |
| doug-fish | I've been looking at how we use self.classes inside our code. It looks like sometimes it's a tuple and sometimes it's a list. That seems less than optimal to me. | 17:12 |
| doug-fish | Does anyone know how that came to be? or what might be wrong with changing all of them to lists? | 17:12 |
| *** MaxV has quit IRC | 17:15 | |
| *** e0ne has quit IRC | 17:15 | |
| *** cedrics_ has joined #openstack-horizon | 17:16 | |
| *** e0ne has joined #openstack-horizon | 17:17 | |
| *** cedrics has joined #openstack-horizon | 17:19 | |
| *** cedrics_ has quit IRC | 17:21 | |
| thiagop | Hey guys, does somebody know if there is any tests in Horizon related to multidomain support feature? And if it does exist, where is it? | 17:23 |
| *** coolsvap is now known as coolsvap|afk | 17:27 | |
| *** cedrics has quit IRC | 17:32 | |
| *** bpokorny_ has joined #openstack-horizon | 17:32 | |
| *** rbertram has joined #openstack-horizon | 17:33 | |
| ericpeterson | thiagop: I'm not sure horizon has complete support for multi-domains, but I'm not 100% | 17:33 |
| *** MaxV has joined #openstack-horizon | 17:33 | |
| *** cedrics has joined #openstack-horizon | 17:34 | |
| thiagop | ericpeterson: until where I tested, it's completely beautiful. :D | 17:34 |
| *** harlowja has joined #openstack-horizon | 17:34 | |
| *** tosky has quit IRC | 17:34 | |
| thiagop | ericpeterson: But I found a minor bug in the interface. I'd like to add a test to the solution, but I'm not finding any tests related | 17:35 |
| *** e0ne has quit IRC | 17:35 | |
| *** bpokorny has quit IRC | 17:35 | |
| *** echevemaster has quit IRC | 17:35 | |
| ericpeterson | I would believe you if you said there are no multi domain tests ;) | 17:36 |
| *** julim has quit IRC | 17:38 | |
| *** sambetts has quit IRC | 17:39 | |
| *** cedrics has quit IRC | 17:40 | |
| *** julim has joined #openstack-horizon | 17:41 | |
| *** cedrics has joined #openstack-horizon | 17:43 | |
| *** romainh has joined #openstack-horizon | 17:45 | |
| *** ArcTanSusan has quit IRC | 17:45 | |
| *** romainh has left #openstack-horizon | 17:45 | |
| *** amcrn has joined #openstack-horizon | 17:48 | |
| thiagop | ericpeterson: I prefer to maintain hope there is and I'm not aware enough to find it. | 17:50 |
| *** sbfox has quit IRC | 17:51 | |
| *** david-lyle has quit IRC | 17:51 | |
| *** bpokorny has joined #openstack-horizon | 17:52 | |
| *** sbfox has joined #openstack-horizon | 17:53 | |
| *** Guest9962 is now known as mfisch | 17:54 | |
| *** lhcheng has quit IRC | 17:54 | |
| *** lhcheng has joined #openstack-horizon | 17:55 | |
| *** mfisch is now known as Guest33821 | 17:55 | |
| *** bpokorny_ has quit IRC | 17:55 | |
| *** ArcTanSusan has joined #openstack-horizon | 18:02 | |
| *** vijendar has quit IRC | 18:02 | |
| *** neelashah has joined #openstack-horizon | 18:03 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 18:04 | |
| *** neelashah1 has quit IRC | 18:05 | |
| *** katyafervent_awa has quit IRC | 18:09 | |
| *** ayoung has quit IRC | 18:11 | |
| *** katyafervent_awa has joined #openstack-horizon | 18:12 | |
| *** ericpeterson has quit IRC | 18:18 | |
| *** ayoung has joined #openstack-horizon | 18:20 | |
| *** amcrn has quit IRC | 18:20 | |
| *** cedrics has quit IRC | 18:23 | |
| *** arborism has joined #openstack-horizon | 18:24 | |
| *** cedrics has joined #openstack-horizon | 18:24 | |
| *** ArcTanSusan has quit IRC | 18:27 | |
| *** mikedillion has quit IRC | 18:29 | |
| *** mikedillion has joined #openstack-horizon | 18:30 | |
| afaranha | lhcheng: Hi, About the blueprint to implement RBAC in Identity ( https://blueprints.launchpad.net/horizon/+spec/identity-rbac ), it's not working for the Identity panel | 18:31 |
| afaranha | for example, if I allow any user to list users, only the user with role admin will list the users | 18:31 |
| lhcheng | afaranha: how are you enabling any user to list users? | 18:33 |
| lhcheng | based on the keystone policy file, only users with admin role should be able to see all users. | 18:33 |
| *** ericpeterson has joined #openstack-horizon | 18:35 | |
| *** ericpete_ has joined #openstack-horizon | 18:35 | |
| lhcheng | freyes: ping | 18:35 |
| lhcheng | freyes: I'm interested in picking up the BP related to oslo clean-up. Haven't seen activity for a while, like to get this going early Kilo. https://blueprints.launchpad.net/horizon/+spec/improve-oslo-usage | 18:36 |
| *** jacalcat has quit IRC | 18:37 | |
| afaranha | lhcheng: It's working, sorry :P | 18:38 |
| afaranha | But, I'm quite sure I tested it last month and the boolean admin parameter deny non-admin user to do some actions | 18:38 |
| afaranha | Is it a recent change, or I just made a mistake? | 18:39 |
| *** cedricss has joined #openstack-horizon | 18:39 | |
| *** cedrics has quit IRC | 18:40 | |
| *** e0ne has joined #openstack-horizon | 18:41 | |
| afaranha | lhcheng: Sorry, my mistake again. I just tested with the change I made :P | 18:41 |
| afaranha | And, yes, it's not working, I set the permission to "@" in user CRUD, and when accessing Horizon I got error: "You do not have permission to access the resource:/identity/users/Login as different user or go back to home page" | 18:41 |
| afaranha | or just doesn't show the identity Panel | 18:41 |
| lhcheng | david-lyle made a tweak when the Identity panels moved to Identity dashboard from Admin dasboard, regular user will be able to see at least their account now. But the RBAC to list all users has been there for a while. | 18:41 |
| lhcheng | afaranha: so you updated the policy file to just use "@"? | 18:43 |
| *** MaxV has quit IRC | 18:44 | |
| afaranha | lhcheng: Yes, to to check if the Identity dashboard is reflecting the policy | 18:45 |
| lhcheng | Ah, you also need to make the change in the policy file in keystone too | 18:45 |
| *** david-lyle has joined #openstack-horizon | 18:46 | |
| lhcheng | afaranha: I suspect it was keystone that is rejecting the request, that's why it is throwing a permission error. | 18:46 |
| *** david-lyle_ has joined #openstack-horizon | 18:47 | |
| *** bpokorny_ has joined #openstack-horizon | 18:47 | |
| afaranha | lhcheng: When I put the url to list the users it's probably the Keystone, but When I just access the Horizon the Identity Panel is not shown | 18:47 |
| afaranha | lhcheng: I just updated the Horizon code and waiting for it to re stack to test again | 18:48 |
| *** neelashah has quit IRC | 18:48 | |
| *** neelashah has joined #openstack-horizon | 18:49 | |
| *** david-lyle has quit IRC | 18:50 | |
| *** bpokorny has quit IRC | 18:50 | |
| lhcheng | afaranha: okay, update the policy file in keystone too. That should fix the permission issue. | 18:50 |
| afaranha | lhcheng: What I saw is that the identity sub-panels are always checking by api/keystone_client if the user is admin, passing the boolean admin parameter as true | 18:50 |
| lhcheng | afaranha: or if user has the "admin" role returned from the get token call from keystone. | 18:54 |
| lhcheng | afaranha: try updating the policy file too in : https://github.com/openstack/keystone/blob/master/etc/policy.json#L42 | 18:56 |
| afaranha | lhcheng: Okay, gonna check that | 18:57 |
| afaranha | I just got an issue with devstack, it'll take a time until run it again | 18:57 |
| *** neelashah has quit IRC | 18:58 | |
| *** MaxV has joined #openstack-horizon | 19:00 | |
| *** clu_ has joined #openstack-horizon | 19:00 | |
| *** sbfox has quit IRC | 19:01 | |
| *** jacalcat has joined #openstack-horizon | 19:07 | |
| *** ZZelle_ has joined #openstack-horizon | 19:12 | |
| *** halede has joined #openstack-horizon | 19:14 | |
| *** gabriel-bezerra has quit IRC | 19:15 | |
| *** amoturi has joined #openstack-horizon | 19:20 | |
| *** gabriel-bezerra has joined #openstack-horizon | 19:22 | |
| exploreshaifali | https://review.openstack.org/#/c/126141/ | 19:23 |
| *** ArcTanSusan has joined #openstack-horizon | 19:25 | |
| *** neelashah has joined #openstack-horizon | 19:25 | |
| *** vijendar has joined #openstack-horizon | 19:28 | |
| *** vijendar has quit IRC | 19:31 | |
| *** vijendar has joined #openstack-horizon | 19:32 | |
| *** EmilyW has joined #openstack-horizon | 19:40 | |
| *** clu_ has quit IRC | 19:50 | |
| *** sbfox has joined #openstack-horizon | 19:52 | |
| *** Drago has quit IRC | 19:55 | |
| *** nlahouti has quit IRC | 19:56 | |
| *** sayali has quit IRC | 19:59 | |
| *** jtomasek has joined #openstack-horizon | 20:01 | |
| *** lhcheng has quit IRC | 20:08 | |
| *** lhcheng has joined #openstack-horizon | 20:08 | |
| *** neelashah has quit IRC | 20:09 | |
| *** gabriel-bezerra has quit IRC | 20:22 | |
| *** cedricss has quit IRC | 20:24 | |
| *** ArcTanSusan has quit IRC | 20:30 | |
| *** clu_ has joined #openstack-horizon | 20:33 | |
| *** julim has quit IRC | 20:35 | |
| *** gabriel-bezerra has joined #openstack-horizon | 20:36 | |
| *** ArcTanSusan has joined #openstack-horizon | 20:37 | |
| *** neelashah has joined #openstack-horizon | 20:39 | |
| *** jacalcat has quit IRC | 20:40 | |
| *** e0ne has quit IRC | 20:42 | |
| *** david-lyle_ is now known as david-lyle | 20:42 | |
| *** MaxV has quit IRC | 20:44 | |
| *** ArcTanSusan has quit IRC | 20:52 | |
| *** TravT has quit IRC | 20:54 | |
| *** nlahouti has joined #openstack-horizon | 20:55 | |
| *** MaxV has joined #openstack-horizon | 20:57 | |
| *** crobertsrh is now known as _crobertsrh | 20:58 | |
| *** ArcTanSusan has joined #openstack-horizon | 21:01 | |
| *** MaxV has quit IRC | 21:02 | |
| *** peristeri has quit IRC | 21:04 | |
| *** ayoung is now known as ayoung-afk | 21:07 | |
| *** krotscheck has quit IRC | 21:09 | |
| *** amoturi has quit IRC | 21:09 | |
| *** krotscheck has joined #openstack-horizon | 21:11 | |
| *** cedrics has joined #openstack-horizon | 21:11 | |
| *** jacalcat has joined #openstack-horizon | 21:13 | |
| *** fifieldt_ has joined #openstack-horizon | 21:14 | |
| *** hhuang has quit IRC | 21:18 | |
| *** dsneddon_ has quit IRC | 21:18 | |
| *** fifieldt has quit IRC | 21:18 | |
| *** mrunge has quit IRC | 21:18 | |
| *** dsneddon_ has joined #openstack-horizon | 21:19 | |
| *** cedrics has quit IRC | 21:20 | |
| *** rbertram has quit IRC | 21:27 | |
| *** david-lyle has quit IRC | 21:27 | |
| *** hhuang has joined #openstack-horizon | 21:30 | |
| *** rebelagentm has quit IRC | 21:38 | |
| *** johnma_ has joined #openstack-horizon | 21:45 | |
| *** johnma has quit IRC | 21:47 | |
| *** johnma_ is now known as johnma | 21:47 | |
| *** neillc has joined #openstack-horizon | 21:59 | |
| *** radez is now known as radez_g0n3 | 22:00 | |
| *** woodm1979 has joined #openstack-horizon | 22:00 | |
| *** doug-fish has left #openstack-horizon | 22:03 | |
| *** cedrics has joined #openstack-horizon | 22:11 | |
| *** cedrics has quit IRC | 22:20 | |
| *** bpokorny_ has quit IRC | 22:23 | |
| *** david-lyle has joined #openstack-horizon | 22:29 | |
| *** david-lyle_ has joined #openstack-horizon | 22:35 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 22:37 | |
| *** ZZelle_ has quit IRC | 22:37 | |
| *** jtomasek has quit IRC | 22:38 | |
| *** rbertram has joined #openstack-horizon | 22:38 | |
| *** david-lyle has quit IRC | 22:39 | |
| *** woodm1979 has quit IRC | 22:42 | |
| boltR | how do I enable/disable dashboards in havana? | 22:43 |
| boltR | doesn't seem to be a notion of an enabled file | 22:43 |
| *** Dafna has quit IRC | 22:49 | |
| *** rwsu has quit IRC | 22:51 | |
| *** nlahouti has quit IRC | 22:53 | |
| *** david-lyle has joined #openstack-horizon | 22:53 | |
| david-lyle | boltR: overrides.py | 22:54 |
| david-lyle | which dashboard though? | 22:55 |
| david-lyle | can remove admin, not project | 22:55 |
| boltR | hi david-lyle | 22:55 |
| boltR | pretty much every dashboard | 22:55 |
| david-lyle | you could just take the dash out of the INSTALLED_APPS list | 22:55 |
| boltR | i'm trying to unit test some code and i'm missing all the dashboards | 22:56 |
| boltR | hmm, maybe I can just add them to the INSTALLED_APPS list | 22:56 |
| boltR | like you just mentioned | 22:56 |
| *** david-lyle_ has quit IRC | 22:56 | |
| david-lyle | the last part is wrong, unless you just want to use the horizon side of the repo | 22:57 |
| david-lyle | ah, so you're actually wanting the inverse? | 22:57 |
| *** ericpete_ has quit IRC | 22:57 | |
| boltR | inverse meaning adding dashboards? | 22:58 |
| boltR | let me start from the beginning :) | 22:58 |
| david-lyle | in Havana, the list of desired dashboards is part of HORIZON_CONFIG in settings.py | 22:58 |
| boltR | i see, i noticed that too | 22:59 |
| david-lyle | boltR, you seem to be asking how did I remove dashboards unintentionally | 22:59 |
| boltR | but after adding it in the urls are resolving | 22:59 |
| boltR | yes | 22:59 |
| boltR | urls are not resolving* | 22:59 |
| boltR | david-lyle: yes, somehow the namespaces for the dashboards aren't being registered even after adding it to HORIZON_CONFIG | 23:00 |
| david-lyle | most likely a random syntax error that django is making look like unresolved urls because it conveniently ate another error and let the app keep going | 23:00 |
| boltR | hmm | 23:01 |
| david-lyle | something you're adding content wise is causing an exception | 23:01 |
| david-lyle | these are notoriously difficult to track down, unfortunately | 23:01 |
| boltR | okay, maybe i should work on something else and come back to it later | 23:03 |
| *** rwsu has joined #openstack-horizon | 23:04 | |
| boltR | thanks for the help david-lyle | 23:05 |
| david-lyle | wish I had a better answer | 23:05 |
| *** neelashah has quit IRC | 23:06 | |
| *** cedrics has joined #openstack-horizon | 23:11 | |
| *** neillc has quit IRC | 23:11 | |
| *** mikedillion has quit IRC | 23:11 | |
| *** Drago has joined #openstack-horizon | 23:15 | |
| *** Drago has quit IRC | 23:17 | |
| *** Drago has joined #openstack-horizon | 23:17 | |
| *** alexpilotti has quit IRC | 23:18 | |
| *** cedrics has quit IRC | 23:20 | |
| *** david-lyle has quit IRC | 23:22 | |
| *** david-lyle has joined #openstack-horizon | 23:23 | |
| *** nlahouti has joined #openstack-horizon | 23:25 | |
| *** bpokorny has joined #openstack-horizon | 23:28 | |
| lhcheng | david-lyle: Just saw the comment in : https://review.openstack.org/#/c/125135/ . we'll holding off merges to Kilo until RC2 closes? | 23:31 |
| david-lyle | lhcheng, not merges in general, but that's a fairly extensive change | 23:32 |
| david-lyle | potential for merge conflicts will go up | 23:32 |
| david-lyle | not sure how great the risk is | 23:32 |
| lhcheng | I see. | 23:33 |
| *** hurgleburgler has quit IRC | 23:33 | |
| lhcheng | that makes sense | 23:33 |
| david-lyle | I +1'd it, might just be me being lazy | 23:33 |
| lhcheng | just confused why we're holding this one off | 23:33 |
| david-lyle | :) | 23:33 |
| lhcheng | any tentative date you think we can close out RC2? | 23:33 |
| *** david-lyle has quit IRC | 23:34 | |
| *** amoturi has joined #openstack-horizon | 23:34 | |
| lhcheng | RC2 will just mostly be translations? | 23:34 |
| *** amoturi has quit IRC | 23:35 | |
| *** neillc_ has joined #openstack-horizon | 23:37 | |
| *** EmilyW has quit IRC | 23:39 | |
| *** nlahouti has quit IRC | 23:39 | |
| *** nlahouti has joined #openstack-horizon | 23:41 | |
| *** dsneddon_ has quit IRC | 23:44 | |
| *** dsneddon_ has joined #openstack-horizon | 23:45 | |
| *** jacalcat has quit IRC | 23:56 | |
| *** sbfox has quit IRC | 23:57 | |
| *** ArcTanSusan has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!