| *** nlahouti has quit IRC | 00:09 | |
| *** gokrokve has joined #openstack-horizon | 00:10 | |
| *** gokrokve has quit IRC | 00:13 | |
| *** gary-smith has quit IRC | 00:16 | |
| *** colinmcnamara has quit IRC | 00:20 | |
| *** neelashah has joined #openstack-horizon | 00:20 | |
| *** alexpilotti has quit IRC | 00:30 | |
| *** ZZelle_ has quit IRC | 00:30 | |
| *** neelashah has quit IRC | 00:34 | |
| *** neelashah has joined #openstack-horizon | 00:35 | |
| *** neelashah has quit IRC | 00:36 | |
| *** neelashah has joined #openstack-horizon | 00:37 | |
| *** neelashah has quit IRC | 00:38 | |
| *** neelashah has joined #openstack-horizon | 00:39 | |
| *** lcheng has joined #openstack-horizon | 00:43 | |
| *** gokrokve has joined #openstack-horizon | 00:44 | |
| *** alexpilotti has joined #openstack-horizon | 00:44 | |
| *** gokrokve has quit IRC | 00:45 | |
| *** gokrokve has joined #openstack-horizon | 00:45 | |
| *** ArcTanSusan has quit IRC | 00:45 | |
| *** jacalcat has quit IRC | 00:47 | |
| *** alexpilotti has quit IRC | 00:49 | |
| *** neelashah1 has joined #openstack-horizon | 00:50 | |
| *** neelashah has quit IRC | 00:52 | |
| *** lcheng has quit IRC | 00:58 | |
| *** cedrics has joined #openstack-horizon | 01:00 | |
| *** cedrics has quit IRC | 01:06 | |
| *** clu_ has quit IRC | 01:11 | |
| *** neillc has quit IRC | 01:17 | |
| *** Sukhdev has quit IRC | 01:23 | |
| *** bpokorny has quit IRC | 01:39 | |
| *** HenryG has joined #openstack-horizon | 01:49 | |
| *** jacalcat has joined #openstack-horizon | 01:53 | |
| *** Drago has joined #openstack-horizon | 02:19 | |
| *** packet has joined #openstack-horizon | 02:23 | |
| *** Drago has quit IRC | 02:23 | |
| *** packet has quit IRC | 02:23 | |
| *** packet has joined #openstack-horizon | 02:23 | |
| *** Drago has joined #openstack-horizon | 02:23 | |
| *** gokrokve has quit IRC | 02:33 | |
| *** Drago has quit IRC | 02:33 | |
| *** Sukhdev has joined #openstack-horizon | 02:33 | |
| *** harlowja is now known as harlowja_away | 02:38 | |
| *** ramishra has joined #openstack-horizon | 02:39 | |
| *** amcrn has quit IRC | 02:47 | |
| *** ramishra has quit IRC | 03:01 | |
| *** jacalcat has quit IRC | 03:07 | |
| *** packet has quit IRC | 03:11 | |
| *** ramishra has joined #openstack-horizon | 03:23 | |
| *** vkmc has quit IRC | 03:34 | |
| *** dsneddon has quit IRC | 03:40 | |
| *** dsneddon has joined #openstack-horizon | 03:41 | |
| *** alexpilotti has joined #openstack-horizon | 03:46 | |
| *** alexpilotti has quit IRC | 04:00 | |
| *** ramishra_ has joined #openstack-horizon | 04:07 | |
| *** ramishra has quit IRC | 04:08 | |
| *** sbfox has joined #openstack-horizon | 04:11 | |
| *** paul-- has quit IRC | 04:19 | |
| *** paulmillar has joined #openstack-horizon | 04:19 | |
| *** nikunj2512 has joined #openstack-horizon | 04:22 | |
| *** arborism has joined #openstack-horizon | 04:25 | |
| *** sbfox has quit IRC | 04:29 | |
| nikunj2512 | @jpomero: For this https://review.openstack.org/#/c/110067/, Yes it is a working patch | 04:32 |
|---|---|---|
| nikunj2512 | @jpomero: Please make sure the Your IE is not loading the horizon in the compatibility mode and also you have installed the Xstatic-jReject pip package. | 04:32 |
| nikunj2512 | @jpomero: If you use the lastest horizon code, it will automatically force the IE out of compatibility mode | 04:33 |
| *** Sukhdev has quit IRC | 04:33 | |
| *** neelashah1 has quit IRC | 04:37 | |
| *** lcheng has joined #openstack-horizon | 04:50 | |
| *** cody-somerville has quit IRC | 04:54 | |
| *** gokrokve has joined #openstack-horizon | 04:59 | |
| *** nlahouti has joined #openstack-horizon | 05:01 | |
| *** lcheng has quit IRC | 05:03 | |
| *** nlahouti has quit IRC | 05:07 | |
| *** nlahouti has joined #openstack-horizon | 05:08 | |
| *** arborism has quit IRC | 05:10 | |
| *** tzumainn has quit IRC | 05:11 | |
| *** nlahouti1 has joined #openstack-horizon | 05:13 | |
| *** nlahouti has quit IRC | 05:13 | |
| nikunj2512 | @jpich: For this bug - https://bugs.launchpad.net/horizon/+bug/1334897, can i implement modify the Quota like this http://people.redhat.com/~lsurette/OpenStack/Edit%20Project%20-%20Quota?? | 05:14 |
| jpich | nikunj2512: Sounds reasonable to me | 05:15 |
| *** nlahouti1 has quit IRC | 05:18 | |
| nikunj2512 | @jpich: Ok i will start work on it. Thank You | 05:18 |
| *** nlahouti has joined #openstack-horizon | 05:18 | |
| jpich | nikunj2512: Great, thanks! It looks like quite a few changes so it'll probably be targeted for Kilo | 05:19 |
| nikunj2512 | @jpich: Ok Julie | 05:19 |
| *** fifieldt has joined #openstack-horizon | 05:21 | |
| fifieldt | hi all | 05:21 |
| fifieldt | was xstatic a new dependency for Juno? | 05:21 |
| fifieldt | I'm just debugging ubuntu packaging | 05:21 |
| fifieldt | ah, I see it was added 24th march with https://github.com/openstack/horizon/commit/802caf23d79923fb620855aab879b1356dce6693 | 05:24 |
| jpich | fifieldt: Yes, we have a lot of new xstatic dependencies in Juno. The goal is to manage Javascript dependencies more transparently | 05:25 |
| fifieldt | it makes sense :) | 05:25 |
| fifieldt | unfortunately it doesn't look like the packaging teams have caught up to this yet :D | 05:25 |
| fifieldt | a default install of horizon fails badly at the moment on 14.04 | 05:26 |
| fifieldt | I've submitted the bug | 05:26 |
| fifieldt | https://bugs.launchpad.net/ubuntu/+source/openstack-dashboard/+bug/1374273 | 05:26 |
| fifieldt | if you wanted to track it | 05:26 |
| jpich | Cool, thanks! I know zigo's been keeping up with creating debian packages for it | 05:26 |
| jpich | so hopefully it'll ease the task for the ubuntu folks | 05:26 |
| fifieldt | fingers crossed! | 05:26 |
| jpich | :) | 05:27 |
| *** rdopieralski has joined #openstack-horizon | 05:36 | |
| *** amcrn has joined #openstack-horizon | 05:37 | |
| *** lcheng has joined #openstack-horizon | 05:39 | |
| *** gokrokve_ has joined #openstack-horizon | 05:40 | |
| *** gokrokve has quit IRC | 05:43 | |
| *** lcheng has quit IRC | 05:44 | |
| *** gokrokve_ has quit IRC | 05:45 | |
| *** jprovazn has joined #openstack-horizon | 05:51 | |
| *** sayali has joined #openstack-horizon | 05:57 | |
| *** mrunge has joined #openstack-horizon | 05:58 | |
| *** masco has joined #openstack-horizon | 05:59 | |
| *** gokrokve has joined #openstack-horizon | 06:15 | |
| *** gokrokve has quit IRC | 06:20 | |
| *** nlahouti has quit IRC | 06:25 | |
| nikunj2512 | @jpich: Julie for this https://bugs.launchpad.net/horizon/+bug/1335032, i investigated and came to know that the mappings which horizon is manintaining has to be updated | 06:25 |
| nikunj2512 | @jpich: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/stacks/mappings.py#L28 | 06:26 |
| jpich | nikunj2512: Yay, glad if I could be helpful :) | 06:26 |
| jpich | Oh is that where the problem lies? | 06:26 |
| nikunj2512 | @jipch: heat has many more mapping then listed in this file | 06:26 |
| nikunj2512 | @jipch: yes Julie | 06:26 |
| jpich | Cool, well found! | 06:27 |
| jpich | nikunj2512: That's cool, looking forward to the fix :-) | 06:28 |
| nikunj2512 | @jipch: So, we need to update the mappings in this file. But problem is Heat has a hell lot of resource types and i am not sure that we can map everything with horizon | 06:28 |
| jpich | nikunj2512: Maybe add a comment to the bug with that additional information for now | 06:28 |
| *** rhagarty_ has joined #openstack-horizon | 06:28 | |
| jpich | If the mappings were in the client we could import them rather than maintain a copy... but I guess they're on the server side? | 06:29 |
| *** swartulv has quit IRC | 06:29 | |
| *** rhagarty has quit IRC | 06:29 | |
| *** swartulv has joined #openstack-horizon | 06:29 | |
| nikunj2512 | @jpich: Ok but will i add the resources which can be mapped to Heat currently and for the leftovers we can decide later?? | 06:30 |
| nikunj2512 | @jipch: This will atleast solve some of the problem mentioned in this bug | 06:30 |
| jpich | nikunj2512: I guess, yeah, just make sure to add the explanation too so if someone has a better idea they can pop in | 06:31 |
| jpich | Then once we have described the problem it would be worthwhile also asking the people in Heat if they see a better way to handle this | 06:31 |
| jpich | The Heat folks I've talked to in the past are pretty nice and helpful :) | 06:31 |
| nikunj2512 | @jpich: Ok but i has asked around with the heat folks near me and they said that he will not make a changes related to this issue but we never know :) | 06:32 |
| nikunj2512 | @jpich: Same here also :) | 06:33 |
| jpich | nikunj2512: Fair enough | 06:33 |
| *** e0ne has joined #openstack-horizon | 06:36 | |
| *** k4n0 has joined #openstack-horizon | 06:37 | |
| *** e0ne has quit IRC | 06:41 | |
| *** Mzoorikh has joined #openstack-horizon | 06:41 | |
| Mzoorikh | My openstack installation was successfuly done(I installed the | 06:43 |
| Mzoorikh | dashboard on my controller node). But the dashboard is only accessible | 06:43 |
| Mzoorikh | from the controller node(via curl -k https://localhost/horizon), and I | 06:43 |
| Mzoorikh | can not access to dashboard from other computer on the network. | 06:43 |
| Mzoorikh | Error on my browser: Connection Time Out | 06:43 |
| Mzoorikh | Any idea to resolve? | 06:43 |
| jpich | Mzoorikh: Is port 80 open on the controller's firewall? | 06:44 |
| Mzoorikh | How can I check? | 06:45 |
| Mzoorikh | Yes it is open. | 06:46 |
| Mzoorikh | But the problem is on https. | 06:47 |
| Mzoorikh | The appache respond well on http and return the index.html page | 06:47 |
| jpich | ah, I miss it sorry. Is port 443 open too? :-) | 06:48 |
| Mzoorikh | Just checking | 06:48 |
| *** Longgeek has joined #openstack-horizon | 06:49 | |
| *** coolsvap|afk is now known as coolsvap | 06:55 | |
| Mzoorikh | iptables is not installed on my host | 06:58 |
| Mzoorikh | the "service iptables stop" command, returns "unrecognize service" | 06:58 |
| *** ramishra_ has quit IRC | 07:00 | |
| jpich | Could be your OS uses something else that iptables? | 07:00 |
| jpich | What are you running? | 07:00 |
| Mzoorikh | ebtables is installed. But I killed it by "/etc/init.d/ebtables stop" | 07:01 |
| Mzoorikh | My OS is debian | 07:01 |
| mrunge | Mzoorikh, that's not a real service | 07:02 |
| mrunge | Mzoorikh, it just loads and unloads tables | 07:02 |
| mrunge | the same for iptables | 07:02 |
| mrunge | Mzoorikh, hint: iptables -L will show you current tables | 07:03 |
| mrunge | even if there is no service for this! | 07:03 |
| *** romainh has joined #openstack-horizon | 07:03 | |
| jpich | Thanks for the tips mrunge :) | 07:03 |
| *** amotoki has joined #openstack-horizon | 07:03 | |
| Mzoorikh | Thanks for your hints mrunge | 07:04 |
| Mzoorikh | mrunge: How can I check whether 443 port is open or not on iptables? | 07:05 |
| mrunge | Mzoorikh, depending on your setup, that can be very complicated | 07:07 |
| Mzoorikh | I found it: iptables -A INPUT -p tcp -m tcp --sport 443 -j ACCEPT | 07:07 |
| mrunge | no! | 07:07 |
| mrunge | --dport | 07:07 |
| mrunge | not --sport | 07:07 |
| Mzoorikh | mrunge: yes, fine | 07:08 |
| mrunge | Mzoorikh, your rule adds an entry to open your ip tables to let all packages pass originating from source port 443 | 07:08 |
| Mzoorikh | I know, my server run on test environment, not production | 07:08 |
| *** cedrics has joined #openstack-horizon | 07:09 | |
| mrunge | Mzoorikh, please paste iptables -L INPUT somewhere | 07:12 |
| *** swartulv has quit IRC | 07:15 | |
| *** swartulv has joined #openstack-horizon | 07:16 | |
| *** gokrokve has joined #openstack-horizon | 07:16 | |
| *** athomas has joined #openstack-horizon | 07:17 | |
| *** Ala has quit IRC | 07:18 | |
| *** Ala has joined #openstack-horizon | 07:18 | |
| *** gokrokve has quit IRC | 07:21 | |
| nikunj2512 | @rdopieralski: I has bumped the version in run_test.sh but still tests are failing for the same reason | 07:21 |
| rdopieralski | nikunj2512: the tests are failing, because the package is not listed in global requirements | 07:23 |
| Mzoorikh | mrunge: check my "iptables -L INPUT": at http://www.4shared.com/photo/LOVVe1xfce/iptables_INPUT.html | 07:24 |
| nikunj2512 | @rdopieralski: you mean openstack global requiements?? | 07:25 |
| mrunge | Mzoorikh, very clear, your iptables drops packages for dest port 443 | 07:25 |
| rdopieralski | nikunj2512: yes, the computers that run the tests don't normally have internet access, they only have the pypi packages that are listed in the global requirements | 07:26 |
| jpich | Yup, seems "http" is in there but not https | 07:26 |
| *** ygbo has joined #openstack-horizon | 07:27 | |
| Mzoorikh | mrunge: How can I fix it? I executed the "iptables -A INPUT -p tcp -m tcp --dport 443 -j ACCEPT" command. But yet, https requests are droped? Why? | 07:28 |
| mrunge | probably because you added that rule on the bottom, after the REJECT line? | 07:29 |
| mrunge | Mzoorikh, try instead: iptables -I INPUT -p tcp -m tcp --dport 443 -j ACCEPT | 07:29 |
| jpich | mrunge... Are you remembering the syntax for iptables rules off the top of your head just like that? | 07:30 |
| mrunge | jpich, at least %some% of them, yes | 07:31 |
| jpich | wooow | 07:31 |
| *** tnovacik_ has joined #openstack-horizon | 07:33 | |
| *** tnovacik_ has quit IRC | 07:33 | |
| *** tnovacik has joined #openstack-horizon | 07:34 | |
| tnovacik | jpich, hi, do you have sec? | 07:35 |
| jpich | tnovacik: Sure, try me | 07:35 |
| *** vokhrimenko has joined #openstack-horizon | 07:35 | |
| tnovacik | jpich, i see https://review.openstack.org/#/c/115004/ that it is merged | 07:35 |
| jpich | tnovacik: Haha. Yeeees \o/ | 07:36 |
| jpich | So it's only an experimental job for now | 07:36 |
| Mzoorikh | Mrunge: Thanks alot. The problem was fixed. Really you have a good memory in your head. I always forgot iptables rules and switches. Thanks again. | 07:36 |
| tnovacik | jpich, but from the log http://logs.openstack.org/06/112406/7/check/gate-horizon-selenium/7c9f04a/console.html - i cannot see any test running | 07:36 |
| jpich | tnovacik: No, that's different. The selenium tests is only for the unit tests | 07:36 |
| mrunge | Mzoorikh, there is a service in Debian for storing iptables rules | 07:36 |
| mrunge | Mzoorikh, but I forgot the name of it | 07:37 |
| jpich | tnovacik: The whole integration tests with Selenium is new so it doesn't run on every patch by default yet | 07:37 |
| jpich | tnovacik: You have to leave a comment to trigger it first. I tested it there: https://review.openstack.org/#/c/102274/ but it hasn't returned yet and I likely won't be able to check the results today | 07:37 |
| Mzoorikh | jpich: Thanks for your tips, also. | 07:37 |
| jpich | tnovacik: For now I just want to see if I created the infra job correctly and if it can complete without issues | 07:38 |
| jpich | tnovacik: If it does, I'll send an email to the dev list about it so other people writing integration tests can start using it | 07:38 |
| jpich | tnovacik: Then if it looks ok after a few more tests we can add it as non-voting | 07:38 |
| tnovacik | jpich, ah, Nice ! Thanks for the explanation :) | 07:39 |
| jpich | tnovacik: But for now I'm not shouting across the rooftops about it yet because maybe I got the job definition wrong, I'm no infra master yet :) | 07:39 |
| jpich | tnovacik: We're getting there!! | 07:39 |
| jpich | Mzoorikh: You're welcome, glad to hear that it's resolved! | 07:39 |
| mrunge | Mzoorikh, but yes, you're welcome! | 07:40 |
| Mzoorikh | jpich: Yes it was resolved. The problem was simply dropping of 443 port request by iptables. | 07:40 |
| *** MaxV has joined #openstack-horizon | 07:41 | |
| *** ramishra has joined #openstack-horizon | 07:42 | |
| Mzoorikh | How can I change the openstack-dashboard username and password? | 07:45 |
| mrunge | Mzoorikh, it's all managed via keystone | 07:46 |
| mrunge | Mzoorikh, depending on your keystone setting, you might be able to change your password via settings menu | 07:47 |
| *** qba73 has joined #openstack-horizon | 07:47 | |
| Mzoorikh | mrunge: let me to check on the keystone.conf | 07:47 |
| mrunge | Mzoorikh, no. | 07:47 |
| mrunge | Mzoorikh, what kind of backend do you use for keystone? | 07:48 |
| Mzoorikh | Mrunge: Backend database, you mean? | 07:48 |
| mrunge | yes | 07:48 |
| Mzoorikh | mysql | 07:48 |
| mrunge | Mzoorikh, no ad/ldap involved? | 07:49 |
| Mzoorikh | No | 07:49 |
| mrunge | Mzoorikh, go to settings in horizon and try to change your password | 07:50 |
| mrunge | Mzoorikh, there should be the identity panel visible in horizon directly | 07:50 |
| mrunge | depending on the installed version of horizon | 07:50 |
| Mzoorikh | mrunge: The problem is that, I forgot my admin password. I cloudn't log-in to the horizon and have to reset the horizon password via commands. | 07:51 |
| mrunge | :D | 07:52 |
| Mzoorikh | mrunge: :) | 07:52 |
| Mzoorikh | mrunge: That's why i am struggling... | 07:52 |
| mrunge | Mzoorikh, when using "commands", do you use --OS_TENANT etc? | 07:53 |
| mrunge | I mean, environment variables? | 07:53 |
| mrunge | Mzoorikh, the same usernames and passwords are valid for horizon | 07:53 |
| Mzoorikh | mrunge: Yes, I put all of my credential environment variables to creds file, and import them using 'source creds' | 07:54 |
| mrunge | Mzoorikh, depending on your environment, it even might be faster to set up a new environment | 07:54 |
| Mzoorikh | mrunge: OK, let me to check | 07:54 |
| mrunge | Mzoorikh, then I'd inspect your creds file | 07:54 |
| *** regebro has joined #openstack-horizon | 07:55 | |
| jpich | Mzoorikh: Also Keystone has an admin token defined in its config file, that you should be able to use to do something like that from the CLI (it's meant to be used e.g. when creating users for the first time) - though hopefully your credentials file have the info you're looking for | 07:56 |
| *** amerine has quit IRC | 07:58 | |
| jpich | tnovacik: FYI the integration test job failed. I'm not sure if it's the job fault or a more general infra problem, every other experimental job failed too. Boo ;( | 07:59 |
| *** jcoufal has joined #openstack-horizon | 07:59 | |
| *** jtomasek has joined #openstack-horizon | 08:01 | |
| tnovacik | jpich, :'( | 08:02 |
| jpich | tnovacik: The infra folks said they were freezing their repo to change a lot of things around in the last couple of days so... maybe related? I won't have time to look into it today but will, of course, investigate further later on :-) | 08:03 |
| tnovacik | jpich, okay, but FIY not all tests on master are currently passing, there is fix for one test(https://review.openstack.org/#/c/121406/) -> so even if infra stuff fixed it probably fails -> do not be surprised :) | 08:06 |
| jpich | tnovacik: Gotcha! If it's the tests themselves that fail (they don't even launch now) I'll be happy :D | 08:07 |
| jpich | well, not *as* happy as could be but. Progress ;) | 08:07 |
| tnovacik | definitely ! :) thanks for taking care of that | 08:08 |
| jpich | My pleasure | 08:08 |
| *** jpich has quit IRC | 08:12 | |
| *** gokrokve has joined #openstack-horizon | 08:15 | |
| *** gokrokve has quit IRC | 08:17 | |
| mflobo | What is the status of this blueprint? https://blueprints.launchpad.net/horizon/+spec/horizon-create-image-metadata | 08:17 |
| *** gokrokve has joined #openstack-horizon | 08:17 | |
| mflobo | the official status is "Approved", but, aparently, there is only one patch and it is abandoned | 08:18 |
| mrunge | mflobo, that means, you're welcome to submit patches | 08:19 |
| mflobo | mrunge, ok, that's good to hear ;) | 08:20 |
| *** gokrokve has quit IRC | 08:21 | |
| mflobo | mrunge, that blueprint is only for properties, i guess. Not for tags | 08:23 |
| mrunge | mflobo, it says: metadata | 08:24 |
| mrunge | whatever that means | 08:24 |
| *** akrivoka has joined #openstack-horizon | 08:24 | |
| Mzoorikh | My RabbitMQ server is down, but all openstack services are activated, and also horizon is accessible. Where the RabbitMQ server is involved? | 08:30 |
| *** Longgeek has quit IRC | 08:31 | |
| *** amcrn has quit IRC | 08:32 | |
| *** Longgeek has joined #openstack-horizon | 08:35 | |
| *** tnovacik has quit IRC | 08:35 | |
| *** sambetts has joined #openstack-horizon | 08:37 | |
| *** krykowski has joined #openstack-horizon | 08:43 | |
| nikunj2512 | @rdopieralski: so unless my package name gets added in global requiements file, it will continue to fail?? | 08:44 |
| nikunj2512 | @rdopieralski: Also i have submitted a review for the change in global requirements file | 08:45 |
| *** dvorak has quit IRC | 08:47 | |
| *** aix has joined #openstack-horizon | 08:49 | |
| *** dvorak has joined #openstack-horizon | 08:50 | |
| *** ramishra has quit IRC | 08:57 | |
| *** akrivoka has quit IRC | 08:59 | |
| *** e0ne has joined #openstack-horizon | 09:02 | |
| *** Dafna has joined #openstack-horizon | 09:07 | |
| *** Mzoorikh has quit IRC | 09:09 | |
| *** Mzoorikh has joined #openstack-horizon | 09:10 | |
| *** Mzoorikh has left #openstack-horizon | 09:10 | |
| *** ZZelle has quit IRC | 09:12 | |
| rdopieralski | nikunj2512: yeah, but I have to admit that it fails in an unexpected way | 09:14 |
| rdopieralski | nikunj2512: have you considered specifying the minimum version? | 09:14 |
| nikunj2512 | @rdopieralski: How so? | 09:14 |
| rdopieralski | nikunj2512: it should fail at the installation step, when it can't find that package | 09:15 |
| *** ramishra has joined #openstack-horizon | 09:15 | |
| nikunj2512 | @rdopieralski: i don't think so its version will change | 09:15 |
| *** lsmola has joined #openstack-horizon | 09:15 | |
| rdopieralski | famous last words :) | 09:15 |
| nikunj2512 | @rdopieralski: Ohh... But won't it can get package from pip??? | 09:15 |
| rdopieralski | no, because the computers that run the tests have no internet access | 09:16 |
| *** gokrokve has joined #openstack-horizon | 09:16 | |
| nikunj2512 | @rdopieralski: I am only worried because reviewers will not review this patch because of jenkins -1 | 09:16 |
| rdopieralski | well, we are in freeze anyways | 09:17 |
| *** gokrokve has quit IRC | 09:17 | |
| *** gokrokve has joined #openstack-horizon | 09:18 | |
| rdopieralski | you have to get it approved into the global requirements before it can be merged anyways | 09:18 |
| nikunj2512 | @rdopieralski: Ok but how can i do that??? I already submitted a patch for global requirements | 09:19 |
| rdopieralski | nikunj2512: so just wait for it to get merged | 09:20 |
| rdopieralski | nikunj2512: there may be some comments or questions, you have to answer them | 09:20 |
| nikunj2512 | @rdopieralski: Ok :) | 09:21 |
| rdopieralski | it would also be nice if you put the source for the xstatic package on the stackforge | 09:21 |
| nikunj2512 | @rdopieralski: Ok. i will be glad if reviewers come and give comments that means things are moving forward :) | 09:21 |
| rdopieralski | nikunj2512: see http://docs.openstack.org/developer/horizon/contributing.html#javascript-and-css-libraries | 09:22 |
| nikunj2512 | @rdopieralski: Ok, i will put the code on the stackforge | 09:22 |
| *** gokrokve has quit IRC | 09:22 | |
| *** krykowski has quit IRC | 09:25 | |
| *** krykowski has joined #openstack-horizon | 09:27 | |
| *** Longgeek has quit IRC | 09:38 | |
| *** dulek has joined #openstack-horizon | 09:38 | |
| *** Longgeek has joined #openstack-horizon | 09:42 | |
| *** bfic has joined #openstack-horizon | 09:51 | |
| *** ttrifonov is now known as ttrifonov_zZzz | 10:02 | |
| *** krykowski has quit IRC | 10:03 | |
| *** dulek has quit IRC | 10:03 | |
| *** Longgeek has quit IRC | 10:11 | |
| *** jprovazn has quit IRC | 10:14 | |
| *** gokrokve has joined #openstack-horizon | 10:16 | |
| mflobo | How can re-define /horizon/templates/horizon/common/_data_table_table_actions.html only for project dashboard? | 10:16 |
| mflobo | My idea is modify this file for image list in project dashboard | 10:17 |
| mflobo | how can I modify this file only for image list? | 10:17 |
| *** Longgeek has joined #openstack-horizon | 10:17 | |
| mrunge | mflobo, put that into project/images/templates dir | 10:19 |
| mrunge | mflobo, or however that dir is called | 10:19 |
| mrunge | *templates* is important here | 10:19 |
| *** amotoki has quit IRC | 10:20 | |
| *** gokrokve has quit IRC | 10:21 | |
| *** athomas has quit IRC | 10:21 | |
| *** amotoki has joined #openstack-horizon | 10:24 | |
| *** krykowski has joined #openstack-horizon | 10:24 | |
| *** cedrics has quit IRC | 10:25 | |
| *** athomas has joined #openstack-horizon | 10:30 | |
| *** krykowski has quit IRC | 10:33 | |
| mrunge | vokhrimenko, thanks for your review(s) on https://review.openstack.org/#/c/107011 | 10:34 |
| mrunge | is your issue with that patch now fixed? | 10:35 |
| zigo | fifieldt: I did all the xstatic dependencies for Horizon, if Ubuntu guys don't catch up and sync all of my packages, it's their problem, really. | 10:44 |
| zigo | I spent *a lot* of my time creating all of these 20 xstatic packages, plus the corresponding libjs-* packages when needed. | 10:45 |
| zigo | I really would like it to be useful. | 10:45 |
| *** krykowski has joined #openstack-horizon | 10:55 | |
| *** e0ne has quit IRC | 10:57 | |
| *** e0ne has joined #openstack-horizon | 10:58 | |
| *** vijendar has joined #openstack-horizon | 10:59 | |
| *** jprovazn has joined #openstack-horizon | 11:08 | |
| *** Longgeek has quit IRC | 11:15 | |
| *** sayali has quit IRC | 11:17 | |
| *** akrivoka has joined #openstack-horizon | 11:22 | |
| *** pawels has joined #openstack-horizon | 11:24 | |
| *** krykowski has quit IRC | 11:27 | |
| *** krykowski has joined #openstack-horizon | 11:29 | |
| *** Longgeek has joined #openstack-horizon | 11:29 | |
| *** sayali has joined #openstack-horizon | 11:30 | |
| *** sayali has quit IRC | 11:35 | |
| *** akrivoka has quit IRC | 11:38 | |
| *** tosky has joined #openstack-horizon | 11:43 | |
| *** k4n0 has quit IRC | 11:46 | |
| *** akrivoka has joined #openstack-horizon | 11:49 | |
| bradjones | amotoki: ping | 11:56 |
| amotoki | bradjones: pong | 11:57 |
| bradjones | hey just a question regarding your comments here https://review.openstack.org/#/c/123123 | 11:58 |
| amotoki | bradjones: sure | 11:58 |
| bradjones | because the Step that needs to be hidden is not initialised at the point where I set data-hide-tab I cannot use the get_id function | 11:59 |
| bradjones | it is my understanding that you would rather just explicitly define the id of the tab at this point rather than using the additional logic? | 12:00 |
| amotoki | bradjones: yes. I understand the situation. This is because i wrote the second option to use immediate value. | 12:00 |
| amotoki | bradjones: The duplicated logic lowers the maintenancability and I would like to avoid it. | 12:00 |
| amotoki | bradjones: it is my opinion but I think others agree it. | 12:01 |
| bradjones | Yeah I understand that, I didn't know that the get_id function existed hence I created the additional logic but I will remove that and use the immediate value there instead | 12:02 |
| *** cedrics has joined #openstack-horizon | 12:03 | |
| amotoki | bradjones: thanks. When i wrote a comment in the previous patch set, I wasnt aware of it either. sorry if my ambiguous comment confuses you. | 12:03 |
| bradjones | amotoki: thanks for clearing that up for me, I will update the patch | 12:05 |
| amotoki | bradjones: Your patch is really nice for better user experience :-) | 12:05 |
| *** akrivoka has quit IRC | 12:08 | |
| *** krykowski_ has joined #openstack-horizon | 12:08 | |
| *** nikunj2512 has quit IRC | 12:09 | |
| *** krykowski has quit IRC | 12:10 | |
| *** woodm1979 has joined #openstack-horizon | 12:14 | |
| *** radez_g0n3 is now known as radez | 12:17 | |
| *** jacalcat has joined #openstack-horizon | 12:20 | |
| *** vkmc has joined #openstack-horizon | 12:20 | |
| *** vkmc has quit IRC | 12:20 | |
| *** vkmc has joined #openstack-horizon | 12:20 | |
| bradjones | amotoki: I have submitted another patch set but now I am wondering if the 'Create Subnet' checkbox should be moved to the network tab and if it is unticked both of the subnet steps would be disabled | 12:30 |
| *** pawels has left #openstack-horizon | 12:30 | |
| amotoki | bradjones: thanks. will check soon. Regarding moving "Create Subnet" checkbox, can we consider it in Kilo? I tend to agree the direction with you :-) | 12:31 |
| *** vijendar has quit IRC | 12:32 | |
| bradjones | amotoki: sounds good to me | 12:34 |
| mflobo | mrunge, I've tried to put /horizon/templates/horizon/common/_data_table_table_actions.html (modified version) on | 12:36 |
| mflobo | /openstack-dashboard/openstack_dashboard/dashboards/project/images/templates ... NO CHANGES | 12:36 |
| mflobo | /openstack-dashboard/openstack_dashboard/dashboards/project/images/templates/images/ ... NO CHANGES | 12:36 |
| mflobo | /openstack-dashboard/openstack_dashboard/dashboards/project/images/templates/images/images ... NO CHANGES | 12:36 |
| mflobo | always restarting httpd | 12:37 |
| *** jacalcat has quit IRC | 12:39 | |
| mflobo | mrunge, table_actions_template attribute always get the same value https://github.com/openstack/horizon/blob/stable/icehouse/horizon/tables/base.py#L912 | 12:42 |
| *** jacalcat has joined #openstack-horizon | 12:42 | |
| mflobo | and render_table_actions doesnhttps://github.com/openstack/horizon/blob/stable/icehouse/horizon/tables/base.py#L1258 | 12:43 |
| mrunge | mflobo, you need to put the file including full path below that templates dir | 12:43 |
| mflobo | doesn't change nothing or browse in other directories | 12:43 |
| mrunge | don't name that file templates/_data_table_table.... | 12:44 |
| *** coolsvap is now known as coolsvap|afk | 12:44 | |
| mrunge | but templates/horizon/common/_data_table_table_actions.html | 12:44 |
| mflobo | mmmm, so, /openstack-dashboard/openstack_dashboard/dashboards/project/images/templates/horizon/common/_data_table_table_actions.html | 12:44 |
| mflobo | ? | 12:44 |
| mrunge | yes | 12:45 |
| mflobo | mmm, i'll try | 12:45 |
| mrunge | no need to restart httpd, depending how you call it | 12:45 |
| *** ramishra has quit IRC | 12:46 | |
| mrunge | doug-fish, I'm not sure, if we call removing "Limit project count" a fix | 12:47 |
| mrunge | but I partly agree here: that field didn't do anything useful | 12:48 |
| doug-fish | The bug will be closed after you fix | 12:48 |
| doug-fish | *your | 12:48 |
| doug-fish | so either way it should be closed | 12:48 |
| mrunge | yeah | 12:48 |
| doug-fish | I don't feel strongly either way | 12:48 |
| mrunge | I didn't had a real choice for limit project count | 12:48 |
| doug-fish | I'm really more concerned about why our pep8 checks didn't pick up some of the issues that were in that patch | 12:48 |
| mrunge | me too | 12:49 |
| mrunge | !! | 12:49 |
| openstack | mrunge: Error: "!" is not a valid command. | 12:49 |
| doug-fish | I usally don't even though about that kind of stuff; I just expect the tests to find it. | 12:49 |
| rdopieralski | !help | 12:49 |
| openstack | rdopieralski: (help [<plugin>] [<command>]) -- This command gives a useful description of what <command> does. <plugin> is only necessary if the command is in more than one plugin. | 12:49 |
| mrunge | I wonder, if it's in place at all | 12:49 |
| doug-fish | hmm, now that you mention it I see there is no +1 for V on that patch. | 12:51 |
| *** rdopieralski has quit IRC | 12:51 | |
| doug-fish | maybe I was just too impatient. | 12:51 |
| mrunge | doug-fish, there as a +1 earlier today | 12:51 |
| mrunge | and I ran flake8 and tests locally on each commit | 12:52 |
| doug-fish | wow. That makes it even harder to understand | 12:52 |
| mrunge | there *w*as a +1 | 12:52 |
| mrunge | at least, failures are constent with each other | 12:52 |
| mrunge | comparable to deactivated flake8 checks back in May | 12:53 |
| mrunge | or June? | 12:53 |
| doug-fish | I know I saw local pep8 failures just yesterday. | 12:53 |
| doug-fish | maybe my mistakes are bigger than yours? | 12:53 |
| mrunge | doug-fish, at least I have seen flake8 behaving differently on issue, if there were other issues as well | 12:54 |
| mrunge | it ignored other stuff then | 12:54 |
| mrunge | or reported more, if there were other issues | 12:54 |
| mrunge | very strange! | 12:54 |
| doug-fish | I don't know very much about how flake8/pep8 work. I think I'll try to carve out some time to learn. | 12:55 |
| *** ramishra has joined #openstack-horizon | 12:56 | |
| *** dulek has joined #openstack-horizon | 12:56 | |
| *** ZZelle has joined #openstack-horizon | 13:03 | |
| *** krykowski_ has quit IRC | 13:06 | |
| *** rbertram has joined #openstack-horizon | 13:07 | |
| mflobo | mrunge, are you sure about the path to redefine a HTML for project dashboard? | 13:07 |
| mrunge | mflobo, about 80% | 13:08 |
| mflobo | mrunge, i've check the directories where the application search for templates | 13:08 |
| mflobo | /usr/share/openstack-dashboard/openstack_dashboard/templates/ | 13:08 |
| mflobo | /usr/lib/python2.6/site-packages/django/contrib/auth/templates/ | 13:08 |
| mflobo | /usr/lib/python2.6/site-packages/compressor/templates/ | 13:08 |
| mflobo | /usr/lib/python2.6/site-packages/horizon/templates/ | 13:08 |
| *** romainh1 has joined #openstack-horizon | 13:09 | |
| mrunge | mflobo, what version of horizon are you using? | 13:09 |
| mrunge | is that pre-icehouse? | 13:09 |
| mflobo | so, a path like /usr/share/openstack-dashboard/openstack_dashboard/dashboards/project/images/templates/horizon/common/_data_table_table_actions.html is not possible | 13:09 |
| mflobo | is Icehouse | 13:09 |
| *** rbertram has quit IRC | 13:10 | |
| mrunge | mflobo, as you see here: https://github.com/redhat-openstack/horizon/tree/master-patches/openstack_dashboard/dashboards/theme/templates | 13:10 |
| *** romainh has quit IRC | 13:10 | |
| *** _crobertsrh is now known as crobertsrh | 13:10 | |
| mflobo | let me check | 13:10 |
| mrunge | we're using that to provide customization | 13:10 |
| *** rbertram has joined #openstack-horizon | 13:10 | |
| *** rbertram has quit IRC | 13:11 | |
| mflobo | $ yum list openstack-dashboard | 13:11 |
| mflobo | openstack-dashboard.noarch 2014.1.2-2.el6 | 13:11 |
| *** rbertram has joined #openstack-horizon | 13:11 | |
| mflobo | no, I don't know nothing about that | 13:11 |
| *** tzumainn has joined #openstack-horizon | 13:11 | |
| *** krykowski has joined #openstack-horizon | 13:12 | |
| mflobo | I don't have this directory structure in my version... | 13:13 |
| *** tnovacik has joined #openstack-horizon | 13:14 | |
| mflobo | mrunge, I imagine that I can recreate this structure in my version by myself but, is it necessary to configure something to be able to use this "customization" feature? | 13:15 |
| *** gokrokve has joined #openstack-horizon | 13:16 | |
| mrunge | mflobo, I'd say, it depends on your model | 13:20 |
| *** gokrokve has quit IRC | 13:21 | |
| *** peristeri has joined #openstack-horizon | 13:27 | |
| *** neelashah has joined #openstack-horizon | 13:33 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 13:39 | |
| *** dulek has quit IRC | 13:40 | |
| *** jacalcat has quit IRC | 13:46 | |
| amotoki | sambetts: ping | 13:47 |
| *** krykowski has quit IRC | 13:47 | |
| *** krykowski has joined #openstack-horizon | 13:48 | |
| *** tnovacik has quit IRC | 13:48 | |
| *** romainh1 has left #openstack-horizon | 13:50 | |
| *** krykowski has quit IRC | 13:54 | |
| *** masco has quit IRC | 13:54 | |
| *** krykowski has joined #openstack-horizon | 14:00 | |
| *** bfic has quit IRC | 14:02 | |
| *** e0ne has quit IRC | 14:03 | |
| *** e0ne has joined #openstack-horizon | 14:05 | |
| *** krykowski has quit IRC | 14:05 | |
| *** e0ne has quit IRC | 14:09 | |
| *** e0ne has joined #openstack-horizon | 14:10 | |
| *** absubram has joined #openstack-horizon | 14:17 | |
| *** ericpeterson has joined #openstack-horizon | 14:18 | |
| ericpeterson | I know this is going to be a crazy question.... but is anyone using or recently using this??? https://github.com/gabrielhurley/horizon_demo | 14:19 |
| *** krykowski has joined #openstack-horizon | 14:20 | |
| mrunge | ericpeterson, that code is just ancient. | 14:21 |
| ericpeterson | I know | 14:22 |
| *** regebro has quit IRC | 14:22 | |
| ericpeterson | I'm just wondering what other approaches we would support for customizing horizon.... like I know the plug able dashboards and the enabled folder stuff. | 14:23 |
| mrunge | ericpeterson, I'm using a dashboard plugged into horizon for customization reasons | 14:24 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 14:24 | |
| ericpeterson | the approach gabriel has does have some advantage, as horizon gets plugged into a bigger app you might have | 14:25 |
| ericpeterson | the other approach we have been using is that we plug into horizon, kind of the opposite | 14:25 |
| *** david-lyle has joined #openstack-horizon | 14:25 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 14:27 | |
| mrunge | ericpeterson, ok, I see, what you mean. | 14:30 |
| *** ramishra has quit IRC | 14:31 | |
| *** jay-atl-home has joined #openstack-horizon | 14:35 | |
| *** absubram has quit IRC | 14:38 | |
| *** Ala has quit IRC | 14:39 | |
| *** vijendar has joined #openstack-horizon | 14:40 | |
| *** ramishra has joined #openstack-horizon | 14:41 | |
| *** jay-atl-home has quit IRC | 14:42 | |
| sambetts | amotoki: pong | 14:44 |
| sambetts | amotoki: Hi o/ | 14:44 |
| amotoki | sambetts: hi | 14:44 |
| amotoki | sambetts: I reviewed your patch of caching can_access results. | 14:44 |
| sambetts | yes, thank you :) | 14:44 |
| amotoki | sambetts: I have some idea on avoiding programming error (forgetting to add the decorator). I am okay with your version at now but would like to know your opinion. | 14:45 |
| amotoki | sambetts: I commented my idea on gerrit comments and it works in my local test. | 14:45 |
| sambetts | amotoki: I agree that having the subclasses define the decorator might lead to some instances when a programmer may forget to include the decorator, however having the subclasses use the decorator means thats if there is a case when they don't want to use the caching they can leave it out? | 14:48 |
| amotoki | sambetts: I think all panels should be treated in a same way and if there is such need the base class should support such option. thought? | 14:50 |
| *** jacalcat has joined #openstack-horizon | 14:50 | |
| sambetts | amotoki: good point, now its just working out how to implement it | 14:53 |
| amotoki | sambetts: A patch of my idea (against your patch) is here: http://paste.openstack.org/show/115630/ | 14:53 |
| amotoki | sambetts: i hope it helps your thought. | 14:55 |
| *** jay-atl-home has joined #openstack-horizon | 14:55 | |
| *** vokhrimenko has quit IRC | 14:56 | |
| sambetts | amotoki: Yeah, It does however I'm a bit cautious about adding another function just for the sake of can_access, there is already can_access and _can_access which is a little confusing | 14:57 |
| *** krykowski has quit IRC | 14:58 | |
| amotoki | sambetts: yes it is true to some extent. IMHO a value of _can_access is little. In my change, allowed() is to determine if the access is allowed WITHOUT any side effect. | 15:00 |
| amotoki | sambetts: can_access() is now cached in session storage. so the roles of these two are now clearly defined. | 15:01 |
| sambetts | amotoki: Ok, so can_access is cached and allowed isn't that makes sense | 15:02 |
| amotoki | sambetts: One point we need to check is can_access in Dashboard class. | 15:03 |
| *** cedricss has joined #openstack-horizon | 15:03 | |
| sambetts | amotoki: Yes it is | 15:04 |
| amotoki | sambetts: previously _can_access is used to determine a component itself can be accessed and it is not changed even if _can_access is replaced with allowed() and it can be overridden. | 15:05 |
| *** romainh has joined #openstack-horizon | 15:05 | |
| *** romainh has left #openstack-horizon | 15:05 | |
| *** radez is now known as radez_g0n3 | 15:05 | |
| *** cedrics has quit IRC | 15:06 | |
| *** Longgeek has quit IRC | 15:07 | |
| *** qba73 has quit IRC | 15:09 | |
| *** cedrics has joined #openstack-horizon | 15:10 | |
| *** cedricss has quit IRC | 15:10 | |
| sambetts | amotoki: So I think adding the allowed function makes sense, and then the can_access function in dashboard would become allowed | 15:12 |
| *** gary-smith has joined #openstack-horizon | 15:15 | |
| *** gokrokve has joined #openstack-horizon | 15:16 | |
| *** bpokorny has joined #openstack-horizon | 15:19 | |
| *** gokrokve has quit IRC | 15:20 | |
| amotoki | sambetts: it makes sense in general, but "uncached" allowed() may be called multiple times (from dashboard and panel itself). | 15:23 |
| *** anteaya has quit IRC | 15:23 | |
| *** cedrics has quit IRC | 15:23 | |
| *** Sukhdev has joined #openstack-horizon | 15:23 | |
| sambetts | jpomero: I saw you comments, and I think that the neatest solution would be to just not bother with the API call if the tenant doesn't exist what do you think? | 15:24 |
| *** jay-atl-home has quit IRC | 15:24 | |
| jpomero | sambetts, yeah that seemed to be my first reaction, just wasn't sure how easy that would be | 15:24 |
| amotoki | sambetts: i might misunderstand your comment. are you talking about Dashboard.can_access() or panel.can_access in Dashboard.can_access() ? | 15:25 |
| sambetts | jpomero: simply an extra if statement I believe | 15:25 |
| *** Drago has joined #openstack-horizon | 15:25 | |
| sambetts | amotoki: I have changes Dashboard.can_access to Dashboard.allowed but left the panel.can_access alone | 15:25 |
| *** jprovazn has quit IRC | 15:25 | |
| jpomero | sambetts, yeah i say go with that. no reason to make another API call if you know nothing will be returned. | 15:25 |
| amotoki | sambetts: got it. totally makes sense. | 15:26 |
| *** Drago has quit IRC | 15:28 | |
| *** Drago has joined #openstack-horizon | 15:28 | |
| *** mrunge has quit IRC | 15:32 | |
| *** woodm1979 has quit IRC | 15:32 | |
| *** gokrokve has joined #openstack-horizon | 15:36 | |
| *** nlahouti has joined #openstack-horizon | 15:42 | |
| *** jay-atl-home has joined #openstack-horizon | 15:43 | |
| *** bradjones has quit IRC | 15:46 | |
| *** bradjones has joined #openstack-horizon | 15:57 | |
| *** bradjones has quit IRC | 15:57 | |
| *** bradjones has joined #openstack-horizon | 15:57 | |
| *** Drago has quit IRC | 15:57 | |
| sambetts | doug-fish: I'm just wondering is what situation your expecting someone to have signed in and out of 30 user accounts on one computer/browser? | 15:57 |
| *** Drago has joined #openstack-horizon | 15:58 | |
| *** Drago has joined #openstack-horizon | 15:58 | |
| *** romainh has joined #openstack-horizon | 16:00 | |
| *** romainh has left #openstack-horizon | 16:01 | |
| fifieldt | zigo, agreed :) | 16:02 |
| *** gary-smith has quit IRC | 16:04 | |
| zigo | fifieldt: I get this when I install the openstack-dashboard Juno b3 package: http://paste.openstack.org/show/115644/ | 16:12 |
| zigo | fifieldt: Any idea why? | 16:12 |
| *** sambetts has quit IRC | 16:19 | |
| *** cody-somerville has joined #openstack-horizon | 16:22 | |
| *** cedrics has joined #openstack-horizon | 16:23 | |
| *** Drago has quit IRC | 16:25 | |
| *** Drago has joined #openstack-horizon | 16:28 | |
| *** masco has joined #openstack-horizon | 16:29 | |
| *** Drago has quit IRC | 16:29 | |
| *** Drago has joined #openstack-horizon | 16:30 | |
| masco | doug-fish, https://review.openstack.org/#/c/120755/ | 16:30 |
| *** masco has quit IRC | 16:33 | |
| *** Drago has quit IRC | 16:34 | |
| *** anteaya has joined #openstack-horizon | 16:34 | |
| *** Drago has joined #openstack-horizon | 16:35 | |
| *** Drago1 has joined #openstack-horizon | 16:35 | |
| *** Drago has quit IRC | 16:37 | |
| *** Drago has joined #openstack-horizon | 16:37 | |
| *** Drago has quit IRC | 16:37 | |
| *** MaxV has quit IRC | 16:37 | |
| *** Drago has joined #openstack-horizon | 16:41 | |
| *** Drago has quit IRC | 16:42 | |
| *** ramishra has quit IRC | 16:42 | |
| *** Drago has joined #openstack-horizon | 16:43 | |
| *** ericpete_ has joined #openstack-horizon | 16:43 | |
| *** ericpeterson has quit IRC | 16:43 | |
| doug-fish | sambetts: 30 users student computer in a CS class where homework is performed on a teacher assigned VM? Honestly, I don't think its a normal scenario, but I do think its concerning well before the 30 user mark is reached | 16:47 |
| *** Dafna has quit IRC | 16:53 | |
| *** Drago2 has joined #openstack-horizon | 16:55 | |
| *** packet has joined #openstack-horizon | 16:57 | |
| *** Drago has quit IRC | 16:59 | |
| *** e0ne has quit IRC | 17:02 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 17:08 | |
| *** ArcTanSusan has joined #openstack-horizon | 17:08 | |
| *** ramishra has joined #openstack-horizon | 17:14 | |
| *** athomas has quit IRC | 17:16 | |
| doug-fish | amotoki, not sure how strongly you feel about this fix, but its down to only 4 changed translation segements https://review.openstack.org/#/c/107154/ | 17:22 |
| *** Sukhdev has quit IRC | 17:23 | |
| *** lcheng has joined #openstack-horizon | 17:23 | |
| *** ygbo has quit IRC | 17:24 | |
| amotoki | doug-fish: is it required for Juno? Friday is over to my side and the gate queue is long enough, so I think we can't make more patch in RC1..... | 17:25 |
| doug-fish | amotoki: I wouldn't hold up the release for it. We shipped every previous version without translated timezones. | 17:27 |
| *** Drago2 has quit IRC | 17:27 | |
| doug-fish | but then again, I'm an English speaker, so they look fine to me. :-) | 17:27 |
| *** Drago has joined #openstack-horizon | 17:27 | |
| *** Sukhdev has joined #openstack-horizon | 17:30 | |
| *** bpokorny_ has joined #openstack-horizon | 17:31 | |
| *** ramishra has quit IRC | 17:34 | |
| *** bpokorny has quit IRC | 17:35 | |
| *** Drago has quit IRC | 17:37 | |
| *** doug-fish has left #openstack-horizon | 17:41 | |
| *** Drago1 has quit IRC | 17:42 | |
| *** doug-fish has joined #openstack-horizon | 17:59 | |
| *** bpokorny has joined #openstack-horizon | 17:59 | |
| *** harlowja_away is now known as harlowja | 17:59 | |
| *** neelashah has quit IRC | 18:00 | |
| *** gokrokve_ has joined #openstack-horizon | 18:01 | |
| *** bpokorny_ has quit IRC | 18:02 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 18:02 | |
| *** gary-smith has joined #openstack-horizon | 18:03 | |
| *** gokrokve_ has quit IRC | 18:05 | |
| *** gokrokve has quit IRC | 18:05 | |
| *** gokrokve has joined #openstack-horizon | 18:05 | |
| *** gokrokve has quit IRC | 18:10 | |
| *** ericpete_ has quit IRC | 18:13 | |
| *** jcoufal has quit IRC | 18:13 | |
| *** tosky has quit IRC | 18:13 | |
| *** e0ne has joined #openstack-horizon | 18:15 | |
| *** e0ne has quit IRC | 18:16 | |
| *** e0ne has joined #openstack-horizon | 18:20 | |
| *** ericpeterson has joined #openstack-horizon | 18:21 | |
| *** ericpeterson has joined #openstack-horizon | 18:21 | |
| rbertram | doug-fish: I rebased https://review.openstack.org/#/c/112654/4 This probably needs to go in Juno IMO, because the use of these global js variables is spreading. Note that another file was pulled in now. | 18:24 |
| *** e0ne has quit IRC | 18:24 | |
| *** radez_g0n3 is now known as radez | 18:24 | |
| doug-fish | rbertram: I agree its an important change, but I don't think it will be in Juno. Today is the cutoff for rc1 - unless a change is already approved its probably not getting in.... | 18:25 |
| doug-fish | at this point its a question of "would you stop the release for this fix?". I don't think the one you suggest meets that criteria | 18:26 |
| rbertram | doug-fish: agreed | 18:26 |
| doug-fish | still, I expect it to get into early kilo | 18:26 |
| *** Sukhdev has quit IRC | 18:27 | |
| *** e0ne has joined #openstack-horizon | 18:28 | |
| *** e0ne has quit IRC | 18:30 | |
| *** gokrokve has joined #openstack-horizon | 18:31 | |
| rbertram | doug-fish: It needs to get in ahead of the new wave of angular work we are discussing. | 18:31 |
| *** ericpeterson has quit IRC | 18:32 | |
| rbertram | doug-fish: It's not that big a deal itself. We just need the gate to start catching these global var problems. I know asahlin is working toward that. | 18:32 |
| doug-fish | sure, we can actively promote the review and until the gate stop it, we can review javascript code for the use of globals | 18:33 |
| *** peristeri has quit IRC | 18:36 | |
| *** gokrokve has quit IRC | 18:36 | |
| amotoki | re javascript code, all(?) javascript files are under horizon dir. generic horizon codes and dashboard specific codes are mixed. we need to clean up them too in Kilo. | 18:36 |
| *** ericpeterson has joined #openstack-horizon | 18:40 | |
| *** ericpeterson has joined #openstack-horizon | 18:40 | |
| *** e0ne has joined #openstack-horizon | 18:41 | |
| *** e0ne has quit IRC | 18:49 | |
| *** e0ne has joined #openstack-horizon | 18:50 | |
| *** amotoki has quit IRC | 18:52 | |
| *** Sukhdev has joined #openstack-horizon | 18:52 | |
| *** rm_work is now known as rm_work|away | 18:57 | |
| *** rm_work|away is now known as rm_work | 18:57 | |
| *** e0ne has quit IRC | 19:01 | |
| *** cedricss has joined #openstack-horizon | 19:02 | |
| *** EmilyW has joined #openstack-horizon | 19:02 | |
| *** ArcTanSusan has quit IRC | 19:03 | |
| *** e0ne has joined #openstack-horizon | 19:05 | |
| *** lcheng has quit IRC | 19:06 | |
| *** cedrics has quit IRC | 19:06 | |
| *** cedricss has quit IRC | 19:07 | |
| *** ericpeterson has quit IRC | 19:08 | |
| *** e0ne has quit IRC | 19:11 | |
| *** e0ne has joined #openstack-horizon | 19:15 | |
| *** ericpeterson has joined #openstack-horizon | 19:16 | |
| *** ericpeterson has joined #openstack-horizon | 19:16 | |
| *** jacalcat has quit IRC | 19:16 | |
| *** e0ne has quit IRC | 19:18 | |
| *** bpokorny_ has joined #openstack-horizon | 19:21 | |
| *** e0ne has joined #openstack-horizon | 19:22 | |
| *** cedricss has joined #openstack-horizon | 19:22 | |
| *** bpokorny has quit IRC | 19:25 | |
| *** e0ne has quit IRC | 19:26 | |
| *** e0ne has joined #openstack-horizon | 19:31 | |
| *** cedricss has quit IRC | 19:31 | |
| *** gokrokve has joined #openstack-horizon | 19:32 | |
| *** e0ne has quit IRC | 19:35 | |
| *** gokrokve has quit IRC | 19:37 | |
| *** jtomasek has quit IRC | 19:38 | |
| *** cedrics has joined #openstack-horizon | 19:41 | |
| *** nlahouti has quit IRC | 19:44 | |
| *** cedrics has quit IRC | 19:45 | |
| *** hurgleburgler has joined #openstack-horizon | 19:50 | |
| *** amcrn has joined #openstack-horizon | 19:50 | |
| *** ArcTanSusan has joined #openstack-horizon | 19:59 | |
| *** jacalcat has joined #openstack-horizon | 20:00 | |
| *** julim has quit IRC | 20:05 | |
| *** hurgleburgler has left #openstack-horizon | 20:11 | |
| *** clu_ has joined #openstack-horizon | 20:16 | |
| *** ArcTanSusan has quit IRC | 20:17 | |
| *** lcheng has joined #openstack-horizon | 20:19 | |
| *** aix has quit IRC | 20:21 | |
| *** ArcTanSusan has joined #openstack-horizon | 20:28 | |
| *** rwsu has quit IRC | 20:31 | |
| *** gokrokve has joined #openstack-horizon | 20:32 | |
| *** jtomasek has joined #openstack-horizon | 20:34 | |
| *** morganfainberg is now known as morgan | 20:36 | |
| *** morgan is now known as morganfainberg | 20:37 | |
| *** gokrokve has quit IRC | 20:37 | |
| *** nlahouti has joined #openstack-horizon | 20:43 | |
| *** bpokorny_ has quit IRC | 20:44 | |
| *** lcheng has quit IRC | 20:48 | |
| *** radez is now known as radez_g0n3 | 20:50 | |
| *** Sukhdev has quit IRC | 20:52 | |
| *** crobertsrh is now known as _crobertsrh | 20:53 | |
| *** jtomasek has quit IRC | 20:53 | |
| *** amcrn_ has joined #openstack-horizon | 21:11 | |
| *** amcrn has quit IRC | 21:12 | |
| *** ericpeterson has quit IRC | 21:16 | |
| *** ericpeterson has joined #openstack-horizon | 21:17 | |
| *** Sukhdev has joined #openstack-horizon | 21:17 | |
| *** gokrokve has joined #openstack-horizon | 21:32 | |
| *** gokrokve has quit IRC | 21:33 | |
| *** gokrokve has joined #openstack-horizon | 21:34 | |
| *** ericpeterson has quit IRC | 21:34 | |
| *** ericpeterson has joined #openstack-horizon | 21:35 | |
| *** gokrokve has quit IRC | 21:38 | |
| *** packet has quit IRC | 21:39 | |
| *** vijendar has quit IRC | 21:42 | |
| *** bpokorny has joined #openstack-horizon | 21:44 | |
| *** Sukhdev_ has joined #openstack-horizon | 21:44 | |
| *** Sukhdev has quit IRC | 21:46 | |
| *** ericpeterson has quit IRC | 21:51 | |
| *** david-lyle has quit IRC | 21:56 | |
| *** Drago1 has joined #openstack-horizon | 21:57 | |
| *** ArcTanSusan has quit IRC | 22:02 | |
| *** doug-fish has left #openstack-horizon | 22:02 | |
| *** ArcTanSusan has joined #openstack-horizon | 22:03 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 22:13 | |
| *** david-lyle has joined #openstack-horizon | 22:17 | |
| *** david-lyle has quit IRC | 22:21 | |
| *** Sukhdev_ has quit IRC | 22:23 | |
| *** EmilyW has quit IRC | 22:25 | |
| *** jacalcat has quit IRC | 22:29 | |
| *** Sukhdev has joined #openstack-horizon | 22:31 | |
| *** gokrokve has joined #openstack-horizon | 22:32 | |
| *** rbertram has quit IRC | 22:33 | |
| *** ArcTanSusan has quit IRC | 22:36 | |
| *** gokrokve has quit IRC | 22:37 | |
| *** Drago1 has quit IRC | 22:39 | |
| *** rm_work is now known as rm_work|away | 22:40 | |
| *** ArcTanSusan has joined #openstack-horizon | 22:40 | |
| *** ArcTanSusan has quit IRC | 22:42 | |
| *** rwsu has joined #openstack-horizon | 22:47 | |
| *** EmilyW has joined #openstack-horizon | 22:49 | |
| *** Drago1 has joined #openstack-horizon | 22:49 | |
| *** bpokorny_ has joined #openstack-horizon | 22:50 | |
| *** ArcTanSusan has joined #openstack-horizon | 22:50 | |
| *** bpokorny has quit IRC | 22:53 | |
| *** ArcTanSusan has quit IRC | 23:01 | |
| *** ArcTanSusan has joined #openstack-horizon | 23:02 | |
| *** Drago has joined #openstack-horizon | 23:06 | |
| *** Drago has quit IRC | 23:07 | |
| *** rwsu has quit IRC | 23:30 | |
| *** gokrokve has joined #openstack-horizon | 23:32 | |
| *** ArcTanSusan has quit IRC | 23:33 | |
| *** gokrokve has quit IRC | 23:36 | |
| *** ArcTanSusan has joined #openstack-horizon | 23:37 | |
| *** EMW has joined #openstack-horizon | 23:37 | |
| *** ArcTanSusan has quit IRC | 23:39 | |
| *** ArcTanSusan has joined #openstack-horizon | 23:40 | |
| *** EmilyW has quit IRC | 23:40 | |
| *** EMW has quit IRC | 23:41 | |
| *** ArcTanSusan has quit IRC | 23:53 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!