| *** dsneddon has joined #openstack-horizon | 00:13 | |
| *** nlahouti has quit IRC | 00:15 | |
| *** Drago has quit IRC | 00:29 | |
| *** jacalcat has quit IRC | 00:29 | |
| *** rodrigods_ has joined #openstack-horizon | 00:31 | |
| *** ramishra has joined #openstack-horizon | 00:33 | |
| *** sseago has quit IRC | 00:36 | |
| *** Drago has joined #openstack-horizon | 00:39 | |
| *** tqtran has quit IRC | 00:40 | |
| *** Alexane_Metz has quit IRC | 00:42 | |
| *** ArcTanSusan has quit IRC | 00:43 | |
| *** gokrokve_ has quit IRC | 00:44 | |
| *** Arvid_Ebert86 has joined #openstack-horizon | 00:44 | |
| *** bpokorny_ has quit IRC | 00:47 | |
| *** ArcTanSusan has joined #openstack-horizon | 00:48 | |
| *** gokrokve has joined #openstack-horizon | 00:49 | |
| *** neillc has quit IRC | 00:50 | |
| *** ArcTanSusan has quit IRC | 00:55 | |
| *** rodrigods_ has quit IRC | 00:56 | |
| *** Longgeek has joined #openstack-horizon | 01:03 | |
| *** gokrokve has quit IRC | 01:07 | |
| *** lcheng has joined #openstack-horizon | 01:13 | |
| *** jay-atl-home has quit IRC | 01:14 | |
| *** david-lyle has joined #openstack-horizon | 01:17 | |
| *** jacalcat has joined #openstack-horizon | 01:23 | |
| *** Arvid_Ebert86 has quit IRC | 01:25 | |
| *** Drago has quit IRC | 01:31 | |
| *** jacalcat has quit IRC | 01:33 | |
| *** jacalcat has joined #openstack-horizon | 01:34 | |
| *** sseago has joined #openstack-horizon | 01:40 | |
| *** amotoki has joined #openstack-horizon | 01:47 | |
| *** Alyson_Cassin83 has joined #openstack-horizon | 01:48 | |
| *** clu_ has quit IRC | 01:48 | |
| *** jacalcat has quit IRC | 01:50 | |
| *** jay-atl has joined #openstack-horizon | 01:51 | |
| *** david-lyle has quit IRC | 02:05 | |
| *** david-lyle has joined #openstack-horizon | 02:06 | |
| *** ramishra has quit IRC | 02:08 | |
| *** ramishra has joined #openstack-horizon | 02:09 | |
| *** gokrokve has joined #openstack-horizon | 02:09 | |
| *** david-lyle has quit IRC | 02:10 | |
| *** lcheng has quit IRC | 02:12 | |
| *** lcheng has joined #openstack-horizon | 02:19 | |
| *** gokrokve has quit IRC | 02:31 | |
| *** asahlin has quit IRC | 02:31 | |
| *** gokrokve has joined #openstack-horizon | 02:32 | |
| *** gokrokve has quit IRC | 02:36 | |
| *** harlowja is now known as harlowja_away | 02:36 | |
| *** Alyson_Cassin83 has quit IRC | 02:38 | |
| *** Alfonzo80 has joined #openstack-horizon | 02:41 | |
| *** rodrigods_ has joined #openstack-horizon | 02:43 | |
| *** gary-smith has quit IRC | 02:51 | |
| *** rodrigods_ has quit IRC | 02:52 | |
| *** hhuang has joined #openstack-horizon | 02:56 | |
| *** jacalcat has joined #openstack-horizon | 03:03 | |
| *** rbertram has quit IRC | 03:08 | |
| *** radez_g0n3 is now known as radez | 03:19 | |
| *** Longgeek_ has joined #openstack-horizon | 03:20 | |
| *** echevemaster has quit IRC | 03:21 | |
| *** jacalcat has quit IRC | 03:21 | |
| *** Longgeek has quit IRC | 03:23 | |
| *** radez is now known as radez_g0n3 | 03:25 | |
| *** nlahouti has joined #openstack-horizon | 03:25 | |
| *** rodrigods_ has joined #openstack-horizon | 03:33 | |
| *** jrist has quit IRC | 03:33 | |
| *** vkmc has quit IRC | 03:34 | |
| *** Alfonzo80 has quit IRC | 03:39 | |
| *** jrist has joined #openstack-horizon | 03:40 | |
| *** nlahouti has quit IRC | 03:47 | |
| *** Albert87 has joined #openstack-horizon | 03:47 | |
| *** nlahouti has joined #openstack-horizon | 03:47 | |
| *** ramishra has quit IRC | 03:51 | |
| *** johnma has quit IRC | 03:52 | |
| *** rodrigods_ has quit IRC | 03:53 | |
| *** nlahouti has quit IRC | 03:57 | |
| *** nlahouti has joined #openstack-horizon | 03:59 | |
| *** sayali has joined #openstack-horizon | 04:00 | |
| *** sayali has quit IRC | 04:10 | |
| *** ramishra has joined #openstack-horizon | 04:11 | |
| *** jpich has quit IRC | 04:11 | |
| *** jpich has joined #openstack-horizon | 04:12 | |
| *** Drago1 has joined #openstack-horizon | 04:15 | |
| *** Albert87 has quit IRC | 04:18 | |
| *** sayali has joined #openstack-horizon | 04:24 | |
| *** nikunj2512 has joined #openstack-horizon | 04:27 | |
| nikunj2512 | Hi | 04:28 |
|---|---|---|
| nikunj2512 | Does anyone knows where i can find the code which sets the logout_reason cookie?? | 04:28 |
| jpich | nikunj2512: https://github.com/openstack/horizon/blob/master/horizon/utils/functions.py#L37 | 04:31 |
| nikunj2512 | jpich: Thank You | 04:32 |
| jpich | You're welcome! | 04:32 |
| *** ramishra has quit IRC | 04:39 | |
| *** ramishra has joined #openstack-horizon | 04:39 | |
| *** gokrokve has joined #openstack-horizon | 05:00 | |
| *** Longgeek_ has quit IRC | 05:02 | |
| *** e0ne has joined #openstack-horizon | 05:04 | |
| *** e0ne has quit IRC | 05:07 | |
| *** tzumainn has quit IRC | 05:09 | |
| *** tzumainn has joined #openstack-horizon | 05:10 | |
| *** e0ne has joined #openstack-horizon | 05:11 | |
| *** ramishra has quit IRC | 05:13 | |
| *** Drago1 has quit IRC | 05:13 | |
| *** ramishra has joined #openstack-horizon | 05:14 | |
| *** sayali has quit IRC | 05:14 | |
| *** sayan has joined #openstack-horizon | 05:16 | |
| *** Longgeek has joined #openstack-horizon | 05:17 | |
| *** e0ne has quit IRC | 05:22 | |
| *** e0ne has joined #openstack-horizon | 05:26 | |
| *** e0ne has quit IRC | 05:27 | |
| *** sayan has quit IRC | 05:28 | |
| *** sayali has joined #openstack-horizon | 05:28 | |
| *** ramishra has quit IRC | 05:31 | |
| *** ramishra has joined #openstack-horizon | 05:35 | |
| *** lcheng has quit IRC | 05:46 | |
| *** tnovacik has joined #openstack-horizon | 05:51 | |
| *** Longgeek has quit IRC | 05:52 | |
| *** gokrokve_ has joined #openstack-horizon | 05:58 | |
| *** gokrokve has quit IRC | 06:01 | |
| *** tzumainn has quit IRC | 06:01 | |
| *** jcoufal has joined #openstack-horizon | 06:01 | |
| *** gokrokve_ has quit IRC | 06:02 | |
| *** ramishra has quit IRC | 06:04 | |
| *** Swaroop has joined #openstack-horizon | 06:06 | |
| Swaroop | Hi All, | 06:06 |
| *** ramishra has joined #openstack-horizon | 06:07 | |
| Swaroop | Any examples for AngularJS integeration in Horizon dashboard, as I new to Angular JS want to know if any documentation available on the same | 06:08 |
| *** k4n0 has joined #openstack-horizon | 06:09 | |
| *** neillc has joined #openstack-horizon | 06:12 | |
| *** amcrn has quit IRC | 06:15 | |
| *** Swaroop has quit IRC | 06:16 | |
| *** lcheng has joined #openstack-horizon | 06:17 | |
| *** Longgeek has joined #openstack-horizon | 06:18 | |
| *** ramishra has quit IRC | 06:18 | |
| *** gokrokve has joined #openstack-horizon | 06:28 | |
| *** lcheng has quit IRC | 06:29 | |
| *** gokrokve has quit IRC | 06:29 | |
| *** gokrokve has joined #openstack-horizon | 06:30 | |
| *** mrunge has joined #openstack-horizon | 06:32 | |
| *** Drago1 has joined #openstack-horizon | 06:32 | |
| *** gokrokve has quit IRC | 06:35 | |
| *** jprovazn has joined #openstack-horizon | 06:41 | |
| *** Drago1 has quit IRC | 06:41 | |
| *** ramishra has joined #openstack-horizon | 06:41 | |
| *** regebro has joined #openstack-horizon | 06:42 | |
| *** SJ has joined #openstack-horizon | 06:43 | |
| SJ | Any examples for AngularJS integeration in Horizon dashboard, as I new to Angular JS want to know if any documentation available on the same | 06:43 |
| *** nlahouti has quit IRC | 06:43 | |
| *** Drago1 has joined #openstack-horizon | 06:43 | |
| *** athomas has joined #openstack-horizon | 06:43 | |
| *** Ala has joined #openstack-horizon | 06:46 | |
| *** sayan has joined #openstack-horizon | 06:53 | |
| *** jtomasek has joined #openstack-horizon | 06:56 | |
| *** ihrachyshka has joined #openstack-horizon | 06:56 | |
| *** ramishra has quit IRC | 06:58 | |
| *** ihrachyshka has quit IRC | 06:59 | |
| *** ramishra_ has joined #openstack-horizon | 07:00 | |
| *** ihrachyshka has joined #openstack-horizon | 07:01 | |
| *** ttrifonov_zZzz is now known as ttrifonov | 07:01 | |
| *** ihrachyshka has quit IRC | 07:02 | |
| *** Drago1 has quit IRC | 07:11 | |
| *** Drago has joined #openstack-horizon | 07:13 | |
| *** dulek has joined #openstack-horizon | 07:13 | |
| *** vivekd has joined #openstack-horizon | 07:17 | |
| *** romainh has joined #openstack-horizon | 07:19 | |
| *** Drago has quit IRC | 07:19 | |
| *** denis_makogon has joined #openstack-horizon | 07:20 | |
| *** ramishra_ has quit IRC | 07:26 | |
| *** cedrics has joined #openstack-horizon | 07:29 | |
| *** gokrokve has joined #openstack-horizon | 07:31 | |
| *** Longgeek has quit IRC | 07:31 | |
| *** ramishra has joined #openstack-horizon | 07:32 | |
| *** ArthurBerezin has joined #openstack-horizon | 07:33 | |
| *** gokrokve has quit IRC | 07:35 | |
| *** vivekd has left #openstack-horizon | 07:38 | |
| *** sunilm has joined #openstack-horizon | 07:40 | |
| *** ihrachyshka has joined #openstack-horizon | 07:41 | |
| *** ramishra_ has joined #openstack-horizon | 07:41 | |
| *** ramishra has quit IRC | 07:44 | |
| *** ArthurBerezin has quit IRC | 07:47 | |
| *** MaxV has joined #openstack-horizon | 07:48 | |
| *** athomas has quit IRC | 07:51 | |
| *** e0ne has joined #openstack-horizon | 07:53 | |
| *** athomas has joined #openstack-horizon | 07:54 | |
| *** ramishra_ has quit IRC | 08:05 | |
| *** ygbo has joined #openstack-horizon | 08:07 | |
| *** cedricss has joined #openstack-horizon | 08:07 | |
| *** romainh has quit IRC | 08:08 | |
| *** neillc has quit IRC | 08:09 | |
| *** cedrics has quit IRC | 08:10 | |
| *** e0ne has quit IRC | 08:10 | |
| *** Longgeek has joined #openstack-horizon | 08:12 | |
| *** romainh has joined #openstack-horizon | 08:13 | |
| *** hhuang has quit IRC | 08:15 | |
| *** mrunge_ has joined #openstack-horizon | 08:16 | |
| *** mrunge has quit IRC | 08:18 | |
| *** ramishra has joined #openstack-horizon | 08:23 | |
| *** lcheng has joined #openstack-horizon | 08:25 | |
| *** Ala has quit IRC | 08:25 | |
| *** krykowski has joined #openstack-horizon | 08:25 | |
| *** Ala has joined #openstack-horizon | 08:26 | |
| *** gokrokve has joined #openstack-horizon | 08:28 | |
| *** mrunge_ is now known as mrunge | 08:28 | |
| *** masco has joined #openstack-horizon | 08:30 | |
| *** gokrokve has quit IRC | 08:33 | |
| *** ramishra has quit IRC | 08:39 | |
| *** ramishra has joined #openstack-horizon | 08:44 | |
| *** lcheng has quit IRC | 08:46 | |
| *** e0ne has joined #openstack-horizon | 08:50 | |
| SJ | Any documentaion available on Angular JS with Horizon integeration, please provide me the link | 08:57 |
| *** krykowski has quit IRC | 08:58 | |
| *** krykowski has joined #openstack-horizon | 08:59 | |
| *** Longgeek has quit IRC | 09:00 | |
| *** ramishra has quit IRC | 09:02 | |
| *** jpich has quit IRC | 09:04 | |
| *** ramishra has joined #openstack-horizon | 09:05 | |
| *** krykowski has quit IRC | 09:06 | |
| *** pawels has joined #openstack-horizon | 09:08 | |
| *** tosky has joined #openstack-horizon | 09:10 | |
| *** qba73 has joined #openstack-horizon | 09:11 | |
| *** mrunge has quit IRC | 09:18 | |
| *** krykowski has joined #openstack-horizon | 09:20 | |
| *** mrunge has joined #openstack-horizon | 09:22 | |
| *** openstack has joined #openstack-horizon | 09:23 | |
| *** pkarikh has joined #openstack-horizon | 09:26 | |
| *** gokrokve has joined #openstack-horizon | 09:28 | |
| *** pawels has quit IRC | 09:29 | |
| *** gokrokve has quit IRC | 09:29 | |
| *** sambetts has joined #openstack-horizon | 09:30 | |
| *** gokrokve has joined #openstack-horizon | 09:30 | |
| sambetts | ttrifonov: ping | 09:31 |
| *** pawels has joined #openstack-horizon | 09:32 | |
| ttrifonov | sambetts: Hello | 09:32 |
| sambetts | ttrifonov: Hi, I am just working on the commentsy you left on this https://review.openstack.org/#/c/121529/3 and I have a question about the comment you left on horizon/tables/base.py | 09:33 |
| ttrifonov | yep | 09:33 |
| *** ramishra has quit IRC | 09:34 | |
| sambetts | ttrifonov: you say to replace the session_filter variable with filter in self.request.GET however that doesn't handle the case when filter=False correct? | 09:34 |
| *** gokrokve has quit IRC | 09:35 | |
| ttrifonov | hmm, I haven't thought on that.. But does Django convert 'false' to bool value ? | 09:35 |
| ttrifonov | if you pass ?filter=False will it be a bool or a string? | 09:35 |
| sambetts | I belveve django changes it into a bool | 09:36 |
| *** ramishra_ has joined #openstack-horizon | 09:36 | |
| ttrifonov | hmm it would be strange if so | 09:37 |
| ttrifonov | can you check it now ? I think Django might not convert to bool.. | 09:39 |
| sambetts | I'll check because I can't find any docs that support the issue either way | 09:40 |
| *** Longgeek has joined #openstack-horizon | 09:41 | |
| ttrifonov | okay, anyway - I don't believe Django can handle both filter=false and filter=False, so you should add a check for 'is None' or .lower() == 'false' for example... | 09:42 |
| ttrifonov | also - I got your point, maybe the variable should be a bool value - after all checks - like | 09:42 |
| ttrifonov | if blabla or has_session_filter | 09:42 |
| *** denis_makogon has quit IRC | 09:43 | |
| *** ihrachyshka has quit IRC | 09:46 | |
| sambetts | ok, just run some tests and django the .get(filter) is returning a unicode | 09:52 |
| sambetts | so either I change it to match your suggestion in the comments or make it (get(filter) == True or get(filter) == true) to convert it to bool | 09:54 |
| *** e0ne has quit IRC | 09:54 | |
| ttrifonov | yeah, something like: | 09:57 |
| ttrifonov | has_session_filter = 'filter' in request.GET and request.get['filter'].lower() == 'true' | 09:57 |
| ttrifonov | or has_session_filter = request.get('filter', '').lower() == 'true' | 09:58 |
| *** sayan has quit IRC | 09:59 | |
| sambetts | the second one is much neater, and do you think I should eliminate the temp variable and just put that ^ straight into the if statement? | 10:00 |
| *** krykowski has quit IRC | 10:01 | |
| ttrifonov | if it fits in 1 line - you can skip the temp var | 10:02 |
| sambetts | it doesn't even fit into one line with the temp variable :-P | 10:04 |
| ttrifonov | has_filter :) | 10:05 |
| *** e0ne has joined #openstack-horizon | 10:08 | |
| ttrifonov | as Picasso had said: “If I don't have red, I use blue.” | 10:10 |
| *** romainh has quit IRC | 10:12 | |
| sambetts | haha nice idea! | 10:12 |
| *** cedricss has quit IRC | 10:17 | |
| *** ihrachyshka has joined #openstack-horizon | 10:20 | |
| *** tnovacik has quit IRC | 10:23 | |
| *** ankit_ag has joined #openstack-horizon | 10:23 | |
| *** sayali has quit IRC | 10:26 | |
| *** aix has joined #openstack-horizon | 10:27 | |
| *** gokrokve has joined #openstack-horizon | 10:28 | |
| *** nikunj2512 has quit IRC | 10:30 | |
| *** gokrokve has quit IRC | 10:33 | |
| *** krykowski has joined #openstack-horizon | 10:36 | |
| sambetts | ttrifonov: I have another question about a comment on that patch, your first comment about adding another querystring, in the original code any query strings are lost and that I think the goal because its designed to reset the pagination, so I dont think I need to worry about passing any query strings through | 10:44 |
| sambetts | what do you think? | 10:44 |
| sambetts | the other comment was a great suggestion and I have changed the code to use __class__ instead of str(type( | 10:46 |
| *** akrivoka has joined #openstack-horizon | 10:46 | |
| *** sayali has joined #openstack-horizon | 10:51 | |
| *** sambetts has quit IRC | 10:54 | |
| *** sambetts has joined #openstack-horizon | 10:59 | |
| sambetts | ttrifonov: Sorry I'm not sure if you replied or not, my internet dropped | 11:03 |
| *** krykowski has quit IRC | 11:06 | |
| *** e0ne has quit IRC | 11:12 | |
| *** cedrics has joined #openstack-horizon | 11:21 | |
| *** gokrokve has joined #openstack-horizon | 11:28 | |
| *** romainh has joined #openstack-horizon | 11:29 | |
| ttrifonov | sambetts: my idea was to make sure no fragment from the URL is trimmed. I think the code now will retain any QS in URL if any. | 11:30 |
| sambetts | ttrifonov: It doesn't because it still uses get_absolute_url() to get the URL | 11:32 |
| sambetts | tbh I don't think the abolsute URL should have any querystrings in it at all so I'm not even sure that the code that parses the URLs is nessesary | 11:33 |
| *** krykowski has joined #openstack-horizon | 11:33 | |
| *** gokrokve has quit IRC | 11:33 | |
| ttrifonov | you never know... | 11:33 |
| sambetts | no, which is why I included the logic, however nothing from the URL that the post is made too will be passed through | 11:34 |
| ttrifonov | yep, got it. | 11:34 |
| ttrifonov | skip this comment. | 11:34 |
| sambetts | Ok, great :D | 11:34 |
| ttrifonov | the idea is to retain any QS in get_absolute_url, if any, so that'll be fine. | 11:35 |
| sambetts | I'm just running the test suite on my testbed then I'll push the new patch for review :D | 11:35 |
| ttrifonov | ncie | 11:35 |
| ttrifonov | nice | 11:36 |
| *** sayan has joined #openstack-horizon | 11:36 | |
| *** masco has quit IRC | 11:40 | |
| *** e0ne has joined #openstack-horizon | 11:44 | |
| *** rodrigods_ has joined #openstack-horizon | 11:48 | |
| *** rodrigods_ has quit IRC | 12:02 | |
| regebro | How do I figure out WHY the login fails? | 12:02 |
| regebro | 'Login failed for user "admin".' is not a very useful error message. | 12:03 |
| *** masco has joined #openstack-horizon | 12:03 | |
| mrunge | ttrifonov, would you lend me an eye for this patch? you already worked on it, and it slipped on my side for too long now? https://review.openstack.org/#/c/107011/ | 12:07 |
| *** HenryG_afk is now known as HenryG | 12:09 | |
| *** krykowski_ has joined #openstack-horizon | 12:09 | |
| *** masco has quit IRC | 12:09 | |
| *** masco has joined #openstack-horizon | 12:10 | |
| *** pawels has left #openstack-horizon | 12:10 | |
| *** julim has joined #openstack-horizon | 12:11 | |
| *** krykowski has quit IRC | 12:13 | |
| *** jprovazn has quit IRC | 12:26 | |
| *** gokrokve has joined #openstack-horizon | 12:28 | |
| *** doug-fish has joined #openstack-horizon | 12:28 | |
| *** dulek has quit IRC | 12:29 | |
| *** krykowski_ has quit IRC | 12:30 | |
| *** dulek has joined #openstack-horizon | 12:31 | |
| *** gokrokve has quit IRC | 12:33 | |
| *** cedricss has joined #openstack-horizon | 12:35 | |
| *** cedrics has quit IRC | 12:35 | |
| *** ramishra_ has quit IRC | 12:37 | |
| *** jacalcat has joined #openstack-horizon | 12:38 | |
| *** ramishra has joined #openstack-horizon | 12:41 | |
| *** ArthurBerezin has joined #openstack-horizon | 12:41 | |
| *** SJ has quit IRC | 12:44 | |
| *** dulek has quit IRC | 12:46 | |
| *** ArthurBerezin has joined #openstack-horizon | 12:54 | |
| *** ArthurBerezin has quit IRC | 12:55 | |
| *** _crobertsrh is now known as crobertsrh | 12:56 | |
| *** ramishra has quit IRC | 12:57 | |
| *** vkmc has joined #openstack-horizon | 12:59 | |
| *** tzumainn has joined #openstack-horizon | 13:02 | |
| thiagop | Good day everyone! | 13:03 |
| thiagop | I was wondering here | 13:03 |
| *** jasondotstar has joined #openstack-horizon | 13:03 | |
| *** aix has quit IRC | 13:03 | |
| thiagop | how does horizon works when we have multiple instances of a service in the same infrastructure (multiple Novas for instance)? | 13:03 |
| *** tosky has quit IRC | 13:05 | |
| *** radez_g0n3 is now known as radez | 13:11 | |
| *** jay-atl has quit IRC | 13:12 | |
| *** tosky has joined #openstack-horizon | 13:12 | |
| *** neelashah has joined #openstack-horizon | 13:13 | |
| ZZelle | thiagop, what do you mean? | 13:14 |
| thiagop | ZZelle: how does the system knows what endpoint to use if I have nova1 and nova2? | 13:14 |
| ZZelle | thiagop, multiple nova in the same region, in different regions ? | 13:14 |
| thiagop | ZZelle: let's make it simple (I think): same region. | 13:15 |
| ZZelle | thiagop, afaik, not working | 13:15 |
| thiagop | which endpoint to use** | 13:15 |
| ZZelle | thiagop, you should have at most one endpoint per service per region | 13:16 |
| *** asahlin has joined #openstack-horizon | 13:17 | |
| ZZelle | thiagop, nova1/2 are multiple frontends to the same nova deployment or to distinct ones? | 13:17 |
| sambetts | tsufiev: ping Question about your comment here https://review.openstack.org/#/c/120790/4/horizon/base.py | 13:19 |
| *** jprovazn has joined #openstack-horizon | 13:20 | |
| tsufiev | sambetts, pong | 13:20 |
| tsufiev | sambetts, is it unclear? | 13:21 |
| thiagop | ZZelle: currently, I'm trying to understand how does it work, It's not a existing scenario. I'm trying to understand how management through Horizon works (or doesn't works) in these kinds of environment. :) | 13:22 |
| sambetts | tsufiev: If I move the logic out of the class and into the decorator, other classes would lose the ability to use that decorator with their own custom _access_cache function, what do you think? | 13:22 |
| *** rbertram has joined #openstack-horizon | 13:22 | |
| tsufiev | sambetts, hm, let me look into it again... | 13:23 |
| thiagop | ZZelle: I think that, for the sake of example, we can consider distinct ones. | 13:23 |
| ZZelle | thiagop, so they should be associated to different regions | 13:23 |
| ZZelle | thiagop, if you are using neutron with nominal nova/neutron config, it implies one neutron per region | 13:25 |
| sambetts | tsufiev: the way I wrote the decorator is to be pretty generic, so that the idea of cache could be implemented in other classes using the same decorator, but with their own _access_cache method | 13:25 |
| tsufiev | sambetts, I thought that HorizonComponent._access_cache() logic is base for all the components that could ever call can_access(), so haven't imagined the possibility of having different _access_cache methods | 13:26 |
| sambetts | tsufiev: it would only be if there was a very specific use case that wants to override it, I can't think of any right now, but it leaves the flexiblity there | 13:28 |
| *** gokrokve has joined #openstack-horizon | 13:28 | |
| tsufiev | sambetts, as I said, please regard this as matter of taste :). Personally I prefer to provide some generic functions only when the real use case for it arises, but am aware that some people like having more flexible machinery | 13:29 |
| *** peristeri has joined #openstack-horizon | 13:30 | |
| tsufiev | sambetts, I agree that your approach is reasonable | 13:31 |
| sambetts | tsufiev, I'm happy either way to be honest, I was just trying to see which direction makes most sense, I would have liked to have all the logic including the decorator inside of HorizonComponent, but I don't think thats possible with decorators | 13:32 |
| *** gokrokve has quit IRC | 13:33 | |
| sambetts | tsufiev, would you feel there was a disconnect between the logic and the class using the logic, if it was moved out of the class? | 13:35 |
| tsufiev | sambetts, yeah, I don't know a way either to move all logic into HorizonComponent with decorators | 13:35 |
| tsufiev | sambetts, nope, it was just a distaste to functions acting both like setter and getter | 13:36 |
| tsufiev | sambetts, perhaps it would be worth adding some docstring to either decorator or class method - to emphasize the idea (and possible future merits) of such separation? | 13:37 |
| sambetts | tsufiev, I agree, its a bit on the ugly side, maybe there is a nicer solution using properties or something? | 13:39 |
| *** ramishra has joined #openstack-horizon | 13:42 | |
| tsufiev | sambetts, I don't know how to use properties there for nicer solution, perhaps somebody else could give an advice | 13:43 |
| sambetts | I'll give it a go and see what I can do, to clean it up | 13:44 |
| *** derekh has joined #openstack-horizon | 13:48 | |
| *** lcheng has joined #openstack-horizon | 13:54 | |
| *** dulek has joined #openstack-horizon | 13:55 | |
| mflobo | where are the models (models.py https://docs.djangoproject.com/en/1.7/intro/tutorial01/#creating-models) on Horizon? | 14:00 |
| *** sigmavirus24_awa is now known as sigmavirus24 | 14:02 | |
| *** gokrokve has joined #openstack-horizon | 14:03 | |
| *** gokrokve has quit IRC | 14:03 | |
| *** gokrokve has joined #openstack-horizon | 14:03 | |
| *** gokrokve has quit IRC | 14:03 | |
| *** gokrokve has joined #openstack-horizon | 14:04 | |
| *** jay-atl has joined #openstack-horizon | 14:07 | |
| *** rbertram has quit IRC | 14:08 | |
| thiagop | ZZelle: is it a "Horizon to work" restriction? | 14:14 |
| ZZelle | thiagop, no it's a wrong configuration on your deployment | 14:15 |
| ZZelle | thiagop, otherwise how to choose the right service endpoint ? | 14:15 |
| -amotoki- Horizon is the most translated project. On the other hand Horizon is a project which breaks the string freeze MOST. | 14:19 | |
| -amotoki- It seems most patch authors are not aware of the string freeze...........ah.... | 14:20 | |
| amotoki | we need to stop merging string change at some point (this weekend?)... | 14:22 |
| ZZelle | amotoki, hi | 14:22 |
| amotoki | ZZelle: hey | 14:22 |
| amotoki | hey night | 14:22 |
| ZZelle | amotoki, i was looking at your mail on DOA, should we include https://review.openstack.org/119202 in Juno DOA? | 14:24 |
| *** lcheng has quit IRC | 14:24 | |
| amotoki | ZZelle: DOA seems to mean django-openstack-auth. | 14:25 |
| ZZelle | amotoki, yes, reusing ayoung abbrev :) | 14:25 |
| amotoki | ZZelle: In general, openstack-auth 1.1.7 is a final release for Juno unless a release critical bug is found. | 14:25 |
| ZZelle | amotoki, it seems more annoying than critical | 14:26 |
| amotoki | as you may know, client dependency freeze is in effect last Friday as described in ttx mail. | 14:26 |
| *** Drago has joined #openstack-horizon | 14:26 | |
| ZZelle | amotoki, oups, ok | 14:27 |
| amotoki | and the dependency freeze exception was discussed in the release management meeting today. | 14:27 |
| amotoki | what I am not sure is how many fixes are required to make region work properly. | 14:28 |
| amotoki | I am not familiar with "region"..... it is just a topic in my side. | 14:28 |
| ZZelle | amotoki, it seems the change solves the region lost on project switch ... other icehouse region bugs seem fixed | 14:29 |
| amotoki | everyone rushes in the end of the release but it doesn't scale unfortunately..... | 14:30 |
| *** david-lyle has joined #openstack-horizon | 14:31 | |
| *** david-lyle has quit IRC | 14:31 | |
| amotoki | ZZelle: A good news is that we can release openstack-auth at any time the team wants (though we cannot update the release requirement file). | 14:31 |
| *** lcheng has joined #openstack-horizon | 14:31 | |
| *** lcheng has quit IRC | 14:31 | |
| *** david-lyle has joined #openstack-horizon | 14:32 | |
| ZZelle | amotoki, indeed | 14:33 |
| *** david-lyle has quit IRC | 14:33 | |
| sambetts | This patch https://review.openstack.org/#/c/121529/ is failing gate-horizon-python27-django14, I think its a version incompatiblity, has anyone got any suggestions? | 14:34 |
| *** david-lyle has joined #openstack-horizon | 14:34 | |
| *** david-lyle has quit IRC | 14:34 | |
| sambetts | ttrifonov: ^^ | 14:34 |
| *** david-lyle has joined #openstack-horizon | 14:35 | |
| *** ankit_ag has quit IRC | 14:38 | |
| *** aix has joined #openstack-horizon | 14:44 | |
| -amotoki- it raises when we drops django 1.4 support... | 14:44 | |
| *** lcheng has joined #openstack-horizon | 14:45 | |
| amotoki | doug-fish: thanks for listing on string concatenation in bug 1307476 | 14:48 |
| doug-fish | amotoki: sure np. You think a change of that scope is still acceptable? | 14:48 |
| amotoki | doug-fish: personally it should be deferred to Kilo ...... but perhaps French has problems..... | 14:49 |
| amotoki | French? i am not sure. | 14:49 |
| doug-fish | sure understood. I'm going to code it up either way. Having the code should facilitate discussion. | 14:50 |
| amotoki | doug-fish: According to my rough experiece, we already change/introduces nealy 100 strings (at least 60) after the string freeze. | 14:51 |
| derekh | Hi horizon, tripleo CI is broke https://bugs.launchpad.net/tripleo/+bug/1373430 | 14:53 |
| doug-fish | amotoki: yep. Understood. Still, if the strings aren't really translatable, this might be needed. I'm tempted to break it up into multiple patches again, so that if only some strings are troublesome a more selective merge can be done | 14:53 |
| derekh | looks liek this commit is when it started https://review.openstack.org/#/c/120242/15 | 14:53 |
| derekh | any ideas ? | 14:53 |
| amotoki | doug-fish: good point! We have many third party libraries xstatic-* in Juno and the headache is increasing.. | 14:55 |
| amotoki | how can we coordinate translation efforts for js libraries? it is a question. | 14:56 |
| *** jprovazn is now known as jprovazn_afk | 14:56 | |
| amotoki | As OSS mind, we should contribute upstreams of course :-) | 14:57 |
| doug-fish | amotoki: are you saying there are js libraries that will be translated as part of openstack! | 14:57 |
| doug-fish | oh yes - that's what I expected! | 14:57 |
| derekh | Is a revert correct here https://review.openstack.org/123751 or is there a simple fix for the patch ? | 14:57 |
| amotoki | doug-fish: I already had some inconsistency in the release management between django-openstack-auth and horizon. | 14:58 |
| amotoki | I18N team wonders how to handle openstack-auth trans. | 14:58 |
| doug-fish | amotoki: .... and what is the answer? | 14:59 |
| amotoki | doug-fish: no answers... just to follow its own release. | 14:59 |
| doug-fish | amotoki: yeah, I think that seems right | 14:59 |
| *** sayali has quit IRC | 15:00 | |
| amotoki | As an upstream development I believe it is the right stance. Keeping the consistency on translation across libraries is up to distributors to some extent. | 15:01 |
| amotoki | doug-fish: do you have time to check https://review.openstack.org/#/c/123751/ ? | 15:02 |
| doug-fish | amotoki:derekh: yeah, I'm looking at it now | 15:02 |
| amotoki | doug-fish: At a glance, it is better to propose another fix rather than reverting the whoe. | 15:02 |
| *** neelashah has quit IRC | 15:03 | |
| amotoki | *whole. | 15:03 |
| doug-fish | I don't know triple-O enough to understand why it is broken | 15:03 |
| derekh | I've add horizon to the bug 1373430 | 15:04 |
| amotoki | but if we can't identify the root cause it should be reverted at this moment from the release management perspective. | 15:04 |
| derekh | doug-fish: let me try and spin up a current env and I can provide you with debug info | 15:04 |
| doug-fish | derekh: super, thanks! | 15:04 |
| amotoki | derekh: thanks for raising this! | 15:05 |
| derekh | doug-fish: that will probably take 30 minutes | 15:05 |
| derekh | amotoki: no prob | 15:05 |
| -amotoki- feels today neutron channel is very silent.. it is rare horizon channle is active than neutron. | 15:06 | |
| *** rebelagentm has joined #openstack-horizon | 15:07 | |
| *** ZZelle has quit IRC | 15:08 | |
| derekh | doug-fish: amotoki this may be relevant (I don't know enough about horizon to know for sure) we have our own local_settings.py http://git.openstack.org/cgit/openstack/tripleo-image-elements/tree/elements/horizon/os-apply-config/etc/horizon/local_settings.py | 15:08 |
| derekh | could we be missing something ? | 15:08 |
| *** ZZelle has joined #openstack-horizon | 15:08 | |
| derekh | I did some poking at it earlier to see if I could figure it out, it looked to be like | 15:09 |
| derekh | datepicker_locale() | 15:09 |
| derekh | wasn't being called at all | 15:09 |
| doug-fish | hmm | 15:09 |
| amotoki | derekh: but DATEPICKER LOCALE is a new settings and i wonder why it is affected.... | 15:09 |
| doug-fish | I bet the tripleO datepicker usage needs to be changed | 15:10 |
| derekh | The error occurs while running thia file http://git.openstack.org/cgit/openstack/tripleo-image-elements/tree/elements/horizon/os-refresh-config/post-configure.d/14-horizon | 15:10 |
| derekh | brb | 15:10 |
| -amotoki- need to move neutron reviews now... thanks for understanding. | 15:11 | |
| *** pawels has joined #openstack-horizon | 15:11 | |
| *** aix has quit IRC | 15:11 | |
| *** neelashah has joined #openstack-horizon | 15:17 | |
| *** jacalcat has quit IRC | 15:19 | |
| *** rbertram has joined #openstack-horizon | 15:19 | |
| *** aix has joined #openstack-horizon | 15:23 | |
| *** openstackx has joined #openstack-horizon | 15:24 | |
| *** cedrics has joined #openstack-horizon | 15:25 | |
| *** david-ly_ has joined #openstack-horizon | 15:25 | |
| *** cedrics_ has joined #openstack-horizon | 15:26 | |
| *** david-lyle has quit IRC | 15:27 | |
| *** cedricss has quit IRC | 15:28 | |
| *** jacalcat has joined #openstack-horizon | 15:29 | |
| doug-fish | derekh: I see what's wrong. Fix is small, but I have to go to a 1/2 hr meeting. | 15:29 |
| *** cedrics has quit IRC | 15:30 | |
| derekh | doug-fish: ok, we have reverted the commit in the tripleo CI so we should be ok for the moment, | 15:31 |
| *** ramishra has quit IRC | 15:31 | |
| doug-fish | derekh: meeting is rescheduled. Fix will be out soon. | 15:32 |
| derekh | doug-fish: I probably wont be here when your back but if you mail me with the review I can test it later derekh@redhat.com | 15:32 |
| doug-fish | will do. Thanks! | 15:32 |
| *** cedrics_ has quit IRC | 15:32 | |
| *** dulek has quit IRC | 15:32 | |
| derekh | doug-fish: I can confirm datepicker_locale isn't being called, when I change the decorator above it to register.tag it is called (but then I've caused another error) | 15:32 |
| derekh | doug-fish: anyways I'll leave you too it and thanks for the help | 15:33 |
| *** ihrachyshka has quit IRC | 15:36 | |
| *** Sukhdev has joined #openstack-horizon | 15:40 | |
| *** masco has quit IRC | 15:40 | |
| *** ramishra has joined #openstack-horizon | 15:47 | |
| *** tosky has quit IRC | 15:54 | |
| *** ramishra has quit IRC | 15:56 | |
| rbertram | doug-fish: just saw datepicker_locale mentioned - is there a problem? | 15:57 |
| *** nlahouti has joined #openstack-horizon | 15:57 | |
| *** ttrifonov is now known as ttrifonov_zZzz | 15:57 | |
| doug-fish | rbertram: yeah, but no worries - I'm on it | 15:57 |
| *** openstackx has left #openstack-horizon | 15:57 | |
| rbertram | doug-fish, derekh: have to run now, but I can focus on it in a couple of hours if I need to. Hope I didn't miss something! | 15:58 |
| doug-fish | rbertram: no worries! I'm sure it will be fixed up by then! | 15:58 |
| *** AlkaD has joined #openstack-horizon | 15:59 | |
| *** k4n0 has quit IRC | 16:03 | |
| *** sayali has joined #openstack-horizon | 16:03 | |
| *** gary-smith_ has quit IRC | 16:03 | |
| *** jmoffitt_ has quit IRC | 16:03 | |
| *** vokhrimenko has quit IRC | 16:07 | |
| *** gary-smith has joined #openstack-horizon | 16:09 | |
| *** clu_ has joined #openstack-horizon | 16:10 | |
| *** amerine_ has joined #openstack-horizon | 16:13 | |
| *** amerine has quit IRC | 16:14 | |
| *** absubram_ has joined #openstack-horizon | 16:18 | |
| doug-fish | amotoki, derekh, rbertram : https://review.openstack.org/#/c/123779/ | 16:21 |
| derekh | thanks, I just commented with "check experimental", this should run tripleo-ci on it | 16:23 |
| *** sambetts has quit IRC | 16:23 | |
| doug-fish | derekh: sounds good. Let me know how it works! | 16:24 |
| derekh | doug-fish: will do | 16:24 |
| *** sambetts has joined #openstack-horizon | 16:24 | |
| *** dsneddon has quit IRC | 16:24 | |
| *** dsneddon has joined #openstack-horizon | 16:25 | |
| *** MaxV has quit IRC | 16:25 | |
| *** pkarikh has quit IRC | 16:31 | |
| *** ygbo has quit IRC | 16:32 | |
| *** radez is now known as radez_g0n3 | 16:34 | |
| *** sambetts has quit IRC | 16:34 | |
| *** sambetts has joined #openstack-horizon | 16:35 | |
| *** neelashah has quit IRC | 16:37 | |
| *** nlahouti has quit IRC | 16:37 | |
| *** Ala has quit IRC | 16:39 | |
| *** neelashah has joined #openstack-horizon | 16:40 | |
| *** ArcTanSusan has joined #openstack-horizon | 16:41 | |
| *** neelashah1 has joined #openstack-horizon | 16:41 | |
| *** sambetts has quit IRC | 16:43 | |
| *** Ala has joined #openstack-horizon | 16:43 | |
| *** Ala has quit IRC | 16:44 | |
| *** sambetts has joined #openstack-horizon | 16:44 | |
| *** dsneddon has quit IRC | 16:45 | |
| *** neelashah has quit IRC | 16:45 | |
| *** tosky has joined #openstack-horizon | 16:45 | |
| *** ArcTanSusan has quit IRC | 16:46 | |
| *** dsneddon has joined #openstack-horizon | 16:46 | |
| *** ihrachyshka has joined #openstack-horizon | 16:48 | |
| *** ihrachyshka has quit IRC | 16:48 | |
| *** ArcTanSusan has joined #openstack-horizon | 16:49 | |
| *** sambetts has quit IRC | 16:54 | |
| *** qba73 has quit IRC | 16:54 | |
| *** sambetts has joined #openstack-horizon | 16:54 | |
| *** arborism has joined #openstack-horizon | 16:55 | |
| *** harlowja_away is now known as harlowja | 16:56 | |
| *** derekh has quit IRC | 16:56 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 16:57 | |
| *** sambetts has quit IRC | 17:00 | |
| *** sambetts has joined #openstack-horizon | 17:01 | |
| *** Drago1 has joined #openstack-horizon | 17:02 | |
| *** johnma has joined #openstack-horizon | 17:03 | |
| *** rwsu has quit IRC | 17:03 | |
| *** arborism has quit IRC | 17:05 | |
| *** Drago has quit IRC | 17:05 | |
| *** amcrn has joined #openstack-horizon | 17:05 | |
| *** rwsu has joined #openstack-horizon | 17:06 | |
| *** dsneddon has quit IRC | 17:06 | |
| *** pawels has left #openstack-horizon | 17:06 | |
| *** dsneddon has joined #openstack-horizon | 17:06 | |
| *** sambetts has quit IRC | 17:09 | |
| *** sambetts has joined #openstack-horizon | 17:09 | |
| *** Sukhdev has quit IRC | 17:14 | |
| *** akrivoka has quit IRC | 17:15 | |
| *** sayan has quit IRC | 17:20 | |
| *** Drago1 has quit IRC | 17:23 | |
| *** mrunge has quit IRC | 17:24 | |
| *** dsneddon has quit IRC | 17:26 | |
| *** harlowja has quit IRC | 17:27 | |
| *** harlowja has joined #openstack-horizon | 17:27 | |
| *** dsneddon has joined #openstack-horizon | 17:27 | |
| *** lcheng has quit IRC | 17:32 | |
| *** sambetts has quit IRC | 17:34 | |
| *** sambetts has joined #openstack-horizon | 17:35 | |
| *** Drago1 has joined #openstack-horizon | 17:37 | |
| *** romainh has left #openstack-horizon | 17:42 | |
| *** sambetts has quit IRC | 17:43 | |
| *** sambetts has joined #openstack-horizon | 17:43 | |
| *** e0ne has quit IRC | 17:46 | |
| *** gokrokve has quit IRC | 17:46 | |
| *** ericpeterson has joined #openstack-horizon | 17:49 | |
| *** jcoufal has quit IRC | 17:51 | |
| *** MaxV has joined #openstack-horizon | 17:52 | |
| *** tosky has quit IRC | 17:55 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 17:57 | |
| *** sayan has joined #openstack-horizon | 17:58 | |
| *** AlkaD has quit IRC | 18:00 | |
| *** AlkaD has joined #openstack-horizon | 18:02 | |
| *** sambetts has quit IRC | 18:03 | |
| *** sambetts has joined #openstack-horizon | 18:04 | |
| *** radez_g0n3 is now known as radez | 18:06 | |
| *** bpokorny has joined #openstack-horizon | 18:08 | |
| *** gokrokve has joined #openstack-horizon | 18:08 | |
| *** ttrifonov_zZzz is now known as ttrifonov | 18:12 | |
| *** sambetts has quit IRC | 18:13 | |
| *** sambetts has joined #openstack-horizon | 18:13 | |
| *** bpokorny has quit IRC | 18:24 | |
| *** zigo has quit IRC | 18:26 | |
| *** zigo has joined #openstack-horizon | 18:28 | |
| rbertram | doug-fish: OH! So in all my testing, I didn't think to turn compression back on. Sorry! | 18:31 |
| *** sambetts has quit IRC | 18:31 | |
| *** lsmola has quit IRC | 18:31 | |
| rbertram | doug-fish: Lesson learned. | 18:31 |
| *** lsmola has joined #openstack-horizon | 18:31 | |
| doug-fish | no worries Randy. None of the reviewers thought of that either. :-[ | 18:32 |
| *** sambetts has joined #openstack-horizon | 18:32 | |
| *** Sukhdev has joined #openstack-horizon | 18:36 | |
| *** e0ne has joined #openstack-horizon | 18:40 | |
| *** denis_makogon has joined #openstack-horizon | 18:40 | |
| *** nlahouti has joined #openstack-horizon | 18:42 | |
| *** ArcTanSusan has quit IRC | 18:43 | |
| *** e0ne is now known as e0ne_ | 18:49 | |
| *** ArcTanSusan has joined #openstack-horizon | 18:56 | |
| *** e0ne_ has quit IRC | 18:56 | |
| *** bpokorny has joined #openstack-horizon | 18:57 | |
| *** MaxV has quit IRC | 18:57 | |
| rbertram | asahlin: wonder if you should add this to the JS guidelines: "be sure to test your code with compression on before submitting." Also clear cache. Anything else like that? | 18:58 |
| *** MaxV has joined #openstack-horizon | 18:59 | |
| *** lcheng has joined #openstack-horizon | 18:59 | |
| *** bpokorny_ has joined #openstack-horizon | 19:00 | |
| *** e0ne has joined #openstack-horizon | 19:00 | |
| *** morganfainberg is now known as morgan | 19:02 | |
| *** sambetts has quit IRC | 19:02 | |
| *** bpokorny has quit IRC | 19:02 | |
| *** denis_makogon has quit IRC | 19:02 | |
| *** morgan is now known as morganfainberg | 19:03 | |
| *** AlkaD has quit IRC | 19:04 | |
| *** jmoffitt has joined #openstack-horizon | 19:06 | |
| *** amerine_ is now known as amerine | 19:09 | |
| asahlin | rbertram: I thought about adding a comment on clearing cache to pickup JS changes.. didn't even think about compression. I think both are worth mentioning | 19:09 |
| *** ameoba has joined #openstack-horizon | 19:11 | |
| *** AlkaD has joined #openstack-horizon | 19:11 | |
| ericpeterson | there is also testing it with offline compression vs the default online compression too, not sure that this would matter | 19:12 |
| *** coolsvap is now known as coolsvap|gone | 19:13 | |
| *** radez is now known as radez_g0n3 | 19:15 | |
| *** ameoba has quit IRC | 19:16 | |
| *** Longgeek has quit IRC | 19:18 | |
| *** athomas has quit IRC | 19:19 | |
| *** jprovazn_afk has quit IRC | 19:20 | |
| *** echevemaster has joined #openstack-horizon | 19:20 | |
| *** e0ne is now known as e0ne_ | 19:20 | |
| *** ArcTanSusan has quit IRC | 19:28 | |
| asahlin | rbertram, ericpeterson: Compression is turned off/on by specifying COMPRESS_ENABLED = False /True (True is default) in local_settings.py, correct? | 19:32 |
| afaranha | amotoki: ping | 19:38 |
| *** ArcTanSusan has joined #openstack-horizon | 19:40 | |
| ericpeterson | yep asahlin, but if you turn it to offline, you will need to manually compress offline | 19:40 |
| ericpeterson | python manage.py compress (or something like that) | 19:40 |
| *** radez_g0n3 is now known as radez | 19:41 | |
| rbertram | asahlin: yes, COMPRESS_ENABLED is what I made my mistake with | 19:44 |
| *** rbertram has quit IRC | 19:44 | |
| *** e0ne_ has quit IRC | 19:46 | |
| asahlin | ericpeterson: after you mentioned offline compression.. I was reading up on it some.. I *think* mentioning "If you turned compression off during development, re-enable and test before submitting your code" should suffice. | 19:47 |
| ericpeterson | yeah, it's just a best practice to ensure that a change would work in both modes | 19:47 |
| ericpeterson | and there are really 3 different modes.... COMPRESS = False..... then compress_online / offline | 19:48 |
| afaranha | david-ly_: Regarding this blueprint https://blueprints.launchpad.net/horizon/+spec/rbac-panels I talked to Amotoki earlier and we discussed what need to be done | 19:48 |
| afaranha | do you have time to explain me a bit more about it? | 19:48 |
| ericpeterson | compress = false is really a no-opt | 19:48 |
| *** coolsvap|gone has quit IRC | 19:51 | |
| *** lcheng has quit IRC | 19:54 | |
| *** david-ly_ is now known as david-lyle | 19:58 | |
| david-lyle | afaranha: that bp has so much detail, I don't understand the need for clarification ;) | 19:59 |
| *** bpokorny has joined #openstack-horizon | 20:00 | |
| david-lyle | so, what's intended is a combination of the admin and project views as they exist and have the data loading and action visibility be driven by RBAC | 20:00 |
| *** nlahouti has quit IRC | 20:00 | |
| david-lyle | so that we don't have all this near duplicate code in two dashboards | 20:00 |
| afaranha | Right, I understood this part, but how to do it | 20:01 |
| afaranha | We need to change the has_permission and can_access variables, right? | 20:01 |
| david-lyle | I think there are still needs for uniquely admin views that could live in an admin dashboard | 20:01 |
| *** lcheng has joined #openstack-horizon | 20:01 | |
| afaranha | I was gonna ask if we just follow the already merged codes related to this bp, like this one https://review.openstack.org/#/c/86417/ | 20:02 |
| david-lyle | afaranha: I started with the Identity dash | 20:02 |
| david-lyle | I think there's more work necessary in identity to be complete | 20:02 |
| david-lyle | but it's an example of the basic idea | 20:02 |
| david-lyle | you'll see the get_data calls make RBAC checks to determine what data to show | 20:03 |
| afaranha | ok, my idea eas to start in identity, we found out this inconsistence trying to list projects | 20:03 |
| afaranha | my idea was* | 20:03 |
| *** bpokorny_ has quit IRC | 20:03 | |
| david-lyle | yes, RBAC check on project list access | 20:03 |
| david-lyle | that's really the beginning of it | 20:04 |
| gary-smith | david-lyle: along those lines, some panels under Admin (like Compute > Instances) ignore the current selected project | 20:06 |
| gary-smith | but those under Project do not | 20:06 |
| david-lyle | gary-smith: correct | 20:06 |
| gary-smith | and hence the tables under Admin need to have a Project column | 20:06 |
| afaranha | david-lyle: ok, I'll then just check the panels and buttons and make them appear or not accordingly to RBAC | 20:06 |
| gary-smith | but those under project do not. So this would need to be handled too | 20:06 |
| afaranha | As there's patches for other services it'll help a lot the understanding of the solution :) | 20:07 |
| gary-smith | I guess that is all explained in the bp :-) | 20:07 |
| david-lyle | yes, the actions in other services should be handled already | 20:07 |
| *** packet has joined #openstack-horizon | 20:07 | |
| david-lyle | the conditional data loading is the issue | 20:07 |
| david-lyle | at least in the project dashboard | 20:08 |
| david-lyle | gary-smith: I do have just a _few_ more details to add to the BP | 20:10 |
| david-lyle | :D | 20:10 |
| gary-smith | well, now you have a template for it | 20:11 |
| *** jtomasek has quit IRC | 20:11 | |
| david-lyle | whoever came up with that is creating a lot of work for me | 20:11 |
| gary-smith | ;-) | 20:12 |
| *** colinmcnamara has joined #openstack-horizon | 20:12 | |
| *** colinmcnamara has quit IRC | 20:14 | |
| *** colinmcnamara has joined #openstack-horizon | 20:14 | |
| *** rbertram has joined #openstack-horizon | 20:23 | |
| *** sayan has quit IRC | 20:24 | |
| *** packet has quit IRC | 20:27 | |
| *** packet has joined #openstack-horizon | 20:28 | |
| *** sayan has joined #openstack-horizon | 20:28 | |
| *** packet has quit IRC | 20:29 | |
| *** packet has joined #openstack-horizon | 20:30 | |
| *** ArcTanSusan has quit IRC | 20:32 | |
| *** MaxV has quit IRC | 20:34 | |
| *** Sukhdev has quit IRC | 20:37 | |
| *** colinmcnamara has quit IRC | 20:45 | |
| *** radez is now known as radez_g0n3 | 20:46 | |
| *** ttrifonov is now known as ttrifonov_zZzz | 20:50 | |
| *** sayali has quit IRC | 20:52 | |
| *** jacalcat has quit IRC | 20:53 | |
| *** ArcTanSusan has joined #openstack-horizon | 20:54 | |
| *** crobertsrh is now known as _crobertsrh | 20:54 | |
| *** Drago1 has quit IRC | 20:55 | |
| *** nlahouti has joined #openstack-horizon | 20:57 | |
| *** bpokorny_ has joined #openstack-horizon | 20:57 | |
| *** peristeri has quit IRC | 20:57 | |
| *** bpokorny has quit IRC | 21:00 | |
| *** sayan has quit IRC | 21:09 | |
| *** rbertram has quit IRC | 21:14 | |
| doug-fish | Can https://review.openstack.org/#/c/123779/ get some attention? It's needed for tripleo CI. | 21:15 |
| ericpeterson | doug-fish: there is a code block hard coding stuff to en only??? | 21:16 |
| ericpeterson | amd I reading that correct? | 21:17 |
| ericpeterson | s/amd/am | 21:17 |
| doug-fish | sort of yeah | 21:17 |
| ericpeterson | why don | 21:17 |
| doug-fish | as long as you don't use compression everything is fine. | 21:17 |
| ericpeterson | t they just hard code to en | 21:17 |
| ericpeterson | at least then it won't explode on non-en users | 21:17 |
| doug-fish | well compression doesn't actually cause the language to be set, so its just breaks | 21:18 |
| ericpeterson | it's going to fail in ES/FR/IT whatever it seems to me | 21:18 |
| ericpeterson | right, the variable stuff should go out of a compression block | 21:18 |
| doug-fish | nope. I'd bet $0.32 it won't. | 21:18 |
| ericpeterson | it won't fail per se.... but those users won't get the js files | 21:18 |
| doug-fish | you mean without the fix, right? | 21:19 |
| ericpeterson | they won't get the <script> tag.... and their browser will be sad without fancy js stuff | 21:19 |
| ericpeterson | no, the fix I think is not so good | 21:19 |
| doug-fish | oh | 21:19 |
| ericpeterson | ah nevermind.... having me think outloud and make a fool of myself helps.... thanks | 21:20 |
| * ericpeterson retreats sheepishly | 21:20 | |
| doug-fish | no worries | 21:20 |
| doug-fish | It's unclear enough that none of the reviewers (including me) picked it up in the first place | 21:21 |
| *** alexpilotti has joined #openstack-horizon | 21:34 | |
| *** alexpilotti has quit IRC | 21:35 | |
| *** alexpilotti has joined #openstack-horizon | 21:36 | |
| *** ArcTanSusan has quit IRC | 21:36 | |
| *** nlahouti has quit IRC | 21:38 | |
| gugl2 | doug-fish, the fix seems to be reasonbale, but not clear how to test the fix | 21:39 |
| *** ArcTanSusan has joined #openstack-horizon | 21:41 | |
| doug-fish | test it? now there's an idea! | 21:42 |
| doug-fish | :-D | 21:42 |
| gugl2 | doug-fish, meaning...how to make sure no breaks and what to check | 21:43 |
| doug-fish | gugl2: at a high level the idea is that you'd do the compress at the command line and change some local_setting value related to compression. But I'll have to go find some notes if that high level isn't enough to help you | 21:43 |
| doug-fish | once the compression is set up you'd just check a few languages and make sure the proper datepicker is shown | 21:44 |
| doug-fish | gugl2: I don't suppose my vague hand waving about compression is enough to remind you how to set it up? | 21:45 |
| gugl2 | doug-fish, i am confused...sounds like lot of work to set up | 21:47 |
| *** harlowja has quit IRC | 21:47 | |
| *** harlowja has joined #openstack-horizon | 21:47 | |
| doug-fish | it's really not that bad. It will take me longer to find/write up the details than it would for you to do it. | 21:48 |
| gugl2 | doug-fish, just try to help. If it is too much hassle for you...no worries | 21:48 |
| gugl2 | doug-fish, or any doc you can point me to? | 21:48 |
| doug-fish | gugl2: I don't know if such a doc exists. I appreciate the extra look/test of the code so I'm happy to describe how to do it. | 21:49 |
| doug-fish | Give me 5 or 10 mins ... | 21:49 |
| gugl2 | ok | 21:50 |
| *** AlkaD has quit IRC | 21:56 | |
| *** ericpeterson has quit IRC | 21:56 | |
| *** ericpeterson has joined #openstack-horizon | 21:59 | |
| *** ericpeterson has quit IRC | 21:59 | |
| *** ericpeterson has joined #openstack-horizon | 21:59 | |
| gugl2 | https://review.openstack.org/#/c/117053/ need some critics as well | 22:00 |
| *** david-lyle has quit IRC | 22:00 | |
| *** david-lyle has joined #openstack-horizon | 22:01 | |
| *** harlowja has quit IRC | 22:03 | |
| *** harlowja has joined #openstack-horizon | 22:03 | |
| *** nlahouti has joined #openstack-horizon | 22:05 | |
| *** rebelagentm has quit IRC | 22:05 | |
| *** harlowja has quit IRC | 22:09 | |
| *** harlowja_ has joined #openstack-horizon | 22:09 | |
| doug-fish | gugl2: I threw some instructions in the bug: https://bugs.launchpad.net/tripleo/+bug/1373430 | 22:11 |
| gugl2 | doug-fish, ok, will take a look. Thanks so much! | 22:11 |
| doug-fish | gugl2: sure. Thank you! | 22:12 |
| *** rodrigods_ has joined #openstack-horizon | 22:12 | |
| *** rodrigods_ has quit IRC | 22:13 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 22:15 | |
| *** doug-fish has left #openstack-horizon | 22:21 | |
| *** neillc_ has joined #openstack-horizon | 22:21 | |
| *** jasondotstar has quit IRC | 22:21 | |
| *** julim has quit IRC | 22:25 | |
| *** neelashah1 has quit IRC | 22:37 | |
| *** ZZelle_ has joined #openstack-horizon | 22:51 | |
| *** david-lyle has quit IRC | 22:59 | |
| *** lcheng has quit IRC | 22:59 | |
| *** ZZelle_ has quit IRC | 23:02 | |
| *** ericpeterson has quit IRC | 23:03 | |
| *** packet has quit IRC | 23:10 | |
| *** jpich has joined #openstack-horizon | 23:10 | |
| *** Sukhdev has joined #openstack-horizon | 23:21 | |
| *** dsneddon has quit IRC | 23:27 | |
| *** rodrigods_ has joined #openstack-horizon | 23:29 | |
| *** dsneddon has joined #openstack-horizon | 23:29 | |
| *** rbertram has joined #openstack-horizon | 23:31 | |
| *** echevemaster has quit IRC | 23:37 | |
| *** rodrigods_ has quit IRC | 23:38 | |
| *** coolsvap has joined #openstack-horizon | 23:42 | |
| *** dsneddon has quit IRC | 23:48 | |
| *** dsneddon has joined #openstack-horizon | 23:50 | |
| *** openstack has joined #openstack-horizon | 23:56 | |
| *** rodrigods_ has joined #openstack-horizon | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!