Monday, 2014-08-25

*** colinmcnamara has quit IRC00:04
*** colinmcnamara has joined #openstack-horizon00:09
*** stpierre has joined #openstack-horizon00:16
*** colinmcnamara has quit IRC00:24
*** mitz has joined #openstack-horizon00:37
*** lblanchard has quit IRC00:39
*** stpierre has quit IRC00:55
*** mitz has quit IRC01:01
*** mitz has joined #openstack-horizon01:04
*** colinmcnamara has joined #openstack-horizon01:10
*** stpierre has joined #openstack-horizon01:13
*** mitz has quit IRC01:13
*** mitz has joined #openstack-horizon01:16
*** rbertram has joined #openstack-horizon01:36
*** prasoon_ has quit IRC01:50
*** nlahouti_ has quit IRC01:52
*** colinmcnamara has quit IRC02:24
*** colinmcnamara has joined #openstack-horizon02:31
*** rebrego has joined #openstack-horizon02:35
*** regebro is now known as Guest5755702:35
*** rebrego is now known as regebro02:35
*** Guest57557 has quit IRC02:38
*** stpierre has quit IRC02:54
*** colinmcnamara has quit IRC03:03
*** nlahouti has joined #openstack-horizon03:05
*** rbertram has quit IRC03:20
*** stpierre has joined #openstack-horizon03:26
*** jasondotstar has quit IRC03:26
*** colinmcnamara has joined #openstack-horizon03:40
*** stpierre has quit IRC03:43
*** colinmcnamara has quit IRC03:43
*** atan8 has joined #openstack-horizon03:45
*** stpierre has joined #openstack-horizon03:59
*** atan8_ has joined #openstack-horizon04:00
*** atan8 has quit IRC04:00
*** vivekd has joined #openstack-horizon04:20
*** atan8_ has quit IRC04:25
*** amotoki has joined #openstack-horizon04:29
*** stpierre has quit IRC04:40
*** sbfox has quit IRC04:47
*** vivekd has quit IRC04:49
*** sbfox has joined #openstack-horizon04:54
*** vivekd has joined #openstack-horizon05:01
*** stpierre has joined #openstack-horizon05:01
*** nikunj2512 has joined #openstack-horizon05:06
*** rebrego has joined #openstack-horizon05:10
*** regebro is now known as Guest9009905:10
*** rebrego is now known as regebro05:10
*** Guest90099 has quit IRC05:11
*** mrunge has joined #openstack-horizon05:20
*** regebro has quit IRC05:22
*** ramishra has joined #openstack-horizon05:24
*** ramishra has quit IRC05:26
*** stpierre has quit IRC05:26
*** ramishra has joined #openstack-horizon05:26
*** masco has joined #openstack-horizon05:26
*** colinmcnamara has joined #openstack-horizon05:27
*** ramishra has quit IRC05:41
*** jtomasek has joined #openstack-horizon05:48
*** rdopieralski has joined #openstack-horizon05:49
*** rdopieralski has quit IRC05:50
*** masco has quit IRC05:51
*** rdopieralski has joined #openstack-horizon05:51
*** regebro has joined #openstack-horizon05:57
*** colinmcnamara has quit IRC05:59
*** prasoon has joined #openstack-horizon06:03
*** masco has joined #openstack-horizon06:03
*** k4n0 has joined #openstack-horizon06:05
*** cedrics has joined #openstack-horizon06:15
*** MaxV has joined #openstack-horizon06:18
*** jprovazn has joined #openstack-horizon06:35
*** stpierre has joined #openstack-horizon06:41
*** cedricss has joined #openstack-horizon06:41
*** cedrics has quit IRC06:43
*** ramishra has joined #openstack-horizon06:44
*** tmazur has joined #openstack-horizon06:44
*** oro_ has joined #openstack-horizon06:49
*** oro has joined #openstack-horizon06:49
*** ramishra has quit IRC06:51
*** ramishra has joined #openstack-horizon06:52
*** cedricss has quit IRC06:53
*** arezmerita has joined #openstack-horizon07:03
*** ramishra has quit IRC07:08
*** romainh has joined #openstack-horizon07:10
*** jcoufal has joined #openstack-horizon07:12
*** nlahouti has quit IRC07:14
*** Longgeek has joined #openstack-horizon07:16
*** cedrics has joined #openstack-horizon07:16
*** ramishra has joined #openstack-horizon07:23
*** cedricss has joined #openstack-horizon07:25
*** cedrics has quit IRC07:25
*** ramishra has quit IRC07:29
*** ramishra has joined #openstack-horizon07:30
*** bvandenh has joined #openstack-horizon07:35
*** ramishra_ has joined #openstack-horizon07:37
*** ramishra has quit IRC07:37
*** romainh has quit IRC07:37
*** romainh1 has joined #openstack-horizon07:37
*** romainh1 has left #openstack-horizon07:38
*** romainh has joined #openstack-horizon07:40
*** sbfox has quit IRC07:40
*** ramishra_ has quit IRC07:41
*** ramishra has joined #openstack-horizon07:42
*** ramishra has quit IRC07:43
*** ramishra has joined #openstack-horizon07:43
*** nlahouti_ has joined #openstack-horizon07:45
*** ramishra has quit IRC07:48
*** nlahouti_ has quit IRC07:49
*** ramishra has joined #openstack-horizon07:50
*** ygbo has joined #openstack-horizon07:54
*** stpierre has quit IRC07:55
*** jpich has joined #openstack-horizon07:57
*** stpierre has joined #openstack-horizon07:58
*** linkid has joined #openstack-horizon08:00
*** regebro has quit IRC08:00
*** regebro has joined #openstack-horizon08:01
*** stpierre has quit IRC08:11
*** stpierre has joined #openstack-horizon08:16
*** ramishra has quit IRC08:17
*** nlahouti has joined #openstack-horizon08:20
*** stpierre has quit IRC08:25
*** nlahouti has quit IRC08:28
*** k4n0 has quit IRC08:39
*** jtomasek has quit IRC08:46
*** jtomasek has joined #openstack-horizon08:47
*** stpierre has joined #openstack-horizon08:48
*** ramishra has joined #openstack-horizon08:52
rdopieralskidoes anybody have a lot of errors in the run_tests on master?08:53
*** k4n0 has joined #openstack-horizon08:53
rdopieralskisomething with gettext?08:53
*** stpierre has quit IRC08:55
*** akrivoka has joined #openstack-horizon08:57
rdopieralskifalse alarm, sorry08:59
*** stpierre has joined #openstack-horizon08:59
*** sayan has joined #openstack-horizon09:00
*** sayan has joined #openstack-horizon09:00
*** ramishra has quit IRC09:03
*** qba73 has joined #openstack-horizon09:17
*** nlahouti has joined #openstack-horizon09:26
*** nlahouti has quit IRC09:31
*** wuhg has joined #openstack-horizon09:32
*** swartulv has quit IRC09:42
*** swartulv has joined #openstack-horizon09:44
*** tosky has joined #openstack-horizon09:54
*** stpierre has quit IRC09:55
*** nlahouti has joined #openstack-horizon09:57
*** stpierre has joined #openstack-horizon09:58
*** dulek has joined #openstack-horizon10:02
*** nlahouti has quit IRC10:04
*** e0ne has joined #openstack-horizon10:05
*** e0ne has quit IRC10:08
*** e0ne has joined #openstack-horizon10:12
*** qba73 has quit IRC10:12
*** qba73 has joined #openstack-horizon10:14
*** e0ne has quit IRC10:15
*** ramishra has joined #openstack-horizon10:18
*** qba73 has quit IRC10:19
*** e0ne has joined #openstack-horizon10:20
*** e0ne has quit IRC10:21
*** e0ne has joined #openstack-horizon10:26
*** e0ne has quit IRC10:28
*** qba73 has joined #openstack-horizon10:29
*** nlahouti has joined #openstack-horizon10:30
*** qba73 has quit IRC10:31
*** e0ne has joined #openstack-horizon10:32
*** qba73 has joined #openstack-horizon10:33
*** qba73 has quit IRC10:34
*** nlahouti has quit IRC10:34
*** qba73 has joined #openstack-horizon10:34
*** prasoon has quit IRC10:35
*** qba73 has quit IRC10:37
*** e0ne has quit IRC10:39
*** stpierre has quit IRC10:39
*** stpierre has joined #openstack-horizon10:41
*** e0ne has joined #openstack-horizon10:43
*** qba73 has joined #openstack-horizon10:44
*** e0ne has quit IRC10:44
*** qba73 has quit IRC10:44
*** ramishra has quit IRC10:46
*** ramishra has joined #openstack-horizon10:47
*** k4n0 has quit IRC10:47
*** e0ne has joined #openstack-horizon10:48
*** e0ne has quit IRC10:53
*** ramishra has quit IRC10:56
*** e0ne has joined #openstack-horizon10:56
*** k4n0 has joined #openstack-horizon11:00
*** nlahouti has joined #openstack-horizon11:01
*** e0ne has quit IRC11:03
*** nlahouti has quit IRC11:05
*** e0ne has joined #openstack-horizon11:07
*** e0ne has quit IRC11:09
*** e0ne has joined #openstack-horizon11:12
*** e0ne has quit IRC11:15
*** e0ne has joined #openstack-horizon11:19
*** ramishra has joined #openstack-horizon11:26
*** e0ne has quit IRC11:27
*** vkmc has joined #openstack-horizon11:27
*** vkmc has quit IRC11:27
*** vkmc has joined #openstack-horizon11:27
*** ramishra has quit IRC11:30
*** e0ne has joined #openstack-horizon11:32
*** nlahouti has joined #openstack-horizon11:32
*** nlahouti has quit IRC11:36
*** prasoon has joined #openstack-horizon11:39
*** nikunj2512 has quit IRC11:42
*** prasoon has quit IRC11:46
*** prasoon has joined #openstack-horizon11:47
*** asahlin has quit IRC11:47
*** e0ne has quit IRC11:49
*** e0ne has joined #openstack-horizon11:54
*** e0ne has quit IRC11:58
*** e0ne has joined #openstack-horizon12:02
*** nlahouti has joined #openstack-horizon12:03
*** MaxV has quit IRC12:03
*** nlahouti has quit IRC12:09
*** e0ne has quit IRC12:09
*** bvandenh has quit IRC12:18
*** masco has quit IRC12:19
*** bvandenh has joined #openstack-horizon12:19
*** akrivoka has quit IRC12:21
*** akrivoka has joined #openstack-horizon12:22
*** sayan has quit IRC12:23
*** e0ne has joined #openstack-horizon12:24
*** e0ne has quit IRC12:28
*** jasondotstar has joined #openstack-horizon12:34
*** nlahouti has joined #openstack-horizon12:35
*** nlahouti has quit IRC12:40
*** sayan has joined #openstack-horizon12:47
*** pkoniszewski has joined #openstack-horizon12:49
*** rbertram has joined #openstack-horizon12:53
rbertramrdopieralski: I have datepicker working, with a first-pass at enabling globalization.12:57
*** tzumainn has joined #openstack-horizon12:57
rbertramrdopieralski: I think we will need two patches: 1. update to datepicker 1.3.1 in xstatic, with some straightforward minor changes to horizon.forms.js.12:58
*** lblanchard has joined #openstack-horizon12:58
rbertramrdopieralski: 2. enable globalization in datepicker, which will require more discussion.12:59
rbertramrdopieralski: So for first patch, I'm looking at your https://review.openstack.org/#/c/113893/  I need to update it to 1.3.1 & add horizon.forms.js changes. Can I do that?13:03
*** sseago has joined #openstack-horizon13:06
*** nlahouti has joined #openstack-horizon13:06
*** nlahouti has quit IRC13:11
*** neelashah has joined #openstack-horizon13:14
*** masco has joined #openstack-horizon13:15
*** chandankumar has joined #openstack-horizon13:20
*** peristeri has joined #openstack-horizon13:23
*** stpierre has quit IRC13:27
*** rebelagentm has joined #openstack-horizon13:32
*** woodm1979 has joined #openstack-horizon13:35
*** k4n0 has quit IRC13:35
*** nlahouti has joined #openstack-horizon13:37
rdopieralskirbertram: sounds good, please do13:38
rdopieralskirbertram: there is a problem now that nobody reviews those patches though13:39
rdopieralskirbertram: but I hope that someone will get to it sooner or later13:39
rbertramrdopieralski: Ok13:39
rdopieralskirbertram: (I can +2 your patch, but not my own)13:39
*** dulek has quit IRC13:40
*** vivekd_ has joined #openstack-horizon13:40
rbertramrdopieralski: I've been seeing that. This patch will be prereq to fixing the globalization of datepickers, maybe some people will care about that.13:40
rbertramrdopieralski: Also we can tag it as bootstrap, since current datepicker does not have bootstrap3 support (though I haven't seen specific problems)13:41
*** nlahouti has quit IRC13:41
*** vivekd has quit IRC13:42
*** vivekd_ is now known as vivekd13:42
rdopieralskirbertram: ok13:43
jpichThe deadline for accepting new dependencies is next week as well (same as feature freeze), we probably should highlight what absolutely needs to get through in tomorrow's meeting13:45
jpichthere's an exception process but it's limited13:45
*** chandankumar has quit IRC13:46
toskyjpich: does it apply also for (selenium) testing code?13:46
jpichtosky: No (unless they add new dependencies)13:49
toskyjpich: thanks13:49
jpichYou're welcome13:49
*** neelashah has quit IRC13:51
*** oro_ has quit IRC13:55
*** oro has quit IRC13:55
*** asahlin has joined #openstack-horizon13:57
*** rbertram has quit IRC13:59
*** radez_g0n3 is now known as radez14:02
*** julim has joined #openstack-horizon14:04
*** masco has quit IRC14:05
*** tmazur has quit IRC14:07
*** nlahouti has joined #openstack-horizon14:08
*** ericpeterson has joined #openstack-horizon14:08
*** neelashah has joined #openstack-horizon14:09
*** nlahouti has quit IRC14:12
*** amotoki has quit IRC14:14
*** atan8 has joined #openstack-horizon14:14
*** doug-fish has joined #openstack-horizon14:14
*** david-lyle has joined #openstack-horizon14:17
*** vivekd has quit IRC14:17
*** jtomasek has quit IRC14:21
*** vivekd has joined #openstack-horizon14:21
*** david-lyle has quit IRC14:23
*** david-lyle has joined #openstack-horizon14:23
*** masco has joined #openstack-horizon14:25
*** radez is now known as radez_g0n314:25
*** jpomero_ has joined #openstack-horizon14:26
*** jcoufal_ has joined #openstack-horizon14:28
*** jmoffitt_ has joined #openstack-horizon14:29
*** gary-smith_ has joined #openstack-horizon14:29
*** dguerri_ has joined #openstack-horizon14:30
*** malikeye_ has joined #openstack-horizon14:31
*** jrist_ has joined #openstack-horizon14:31
*** mgagne_ has joined #openstack-horizon14:32
*** mgagne has quit IRC14:32
*** gary-smith has quit IRC14:32
*** dguerri has quit IRC14:32
*** freyes has quit IRC14:32
*** Ephur has quit IRC14:32
*** ygbo has quit IRC14:32
*** jcoufal has quit IRC14:32
*** jpomero has quit IRC14:32
*** malikeye has quit IRC14:32
*** jmoffitt has quit IRC14:32
*** jroll has quit IRC14:32
*** jrist has quit IRC14:32
*** russellb has quit IRC14:32
*** cloudnull has quit IRC14:32
*** Ephur has joined #openstack-horizon14:33
*** jroll has joined #openstack-horizon14:33
*** freyes has joined #openstack-horizon14:33
*** russellb has joined #openstack-horizon14:33
*** cloudnull has joined #openstack-horizon14:33
*** ygbo has joined #openstack-horizon14:35
*** nlahouti has joined #openstack-horizon14:35
*** vijendar has joined #openstack-horizon14:37
*** nlahouti has quit IRC14:39
*** vijendar has quit IRC14:47
*** vijendar has joined #openstack-horizon14:48
*** Ephur has quit IRC14:50
*** Ephur has joined #openstack-horizon14:50
*** vivekd has quit IRC14:52
ericpetersongetting new machine setup, following http://docs.openstack.org/developer/horizon/quickstart.html?highlight=install    I think some xml packages are missing / not listed14:52
david-lyledid keystone's patch just merge to require lxml again :(14:53
*** rdopieralski has quit IRC14:54
ericpetersonlooks like flake might also not be included on a base ubuntu 14.4 install too14:55
david-lyleflake is a python package not system library?14:55
ericpetersoncould be installed either way, but the setup docs don't mention it either way14:56
ericpetersoncan confirm that once libxml2-dev and python-flake8 are installed, then it just works™14:57
david-lyleok the libxml2-dev is from the keystone requirement14:57
david-lylenot sure why python-flake8 would not be satisfied14:58
ericpetersoni'm with you that flake8 is kind of a "no duh" kind of requirement..... but it's not strictly in the setup docs, so a noob would certainly hit that14:59
*** jpomero_ is now known as jpomero14:59
*** sbfox has joined #openstack-horizon15:00
jpichFlake8 is in the global requirements, looks like we should add it to our test-requirements too15:00
david-lylefair enough, was probably a nested dependency that went away15:02
david-lyleericpeterson: did you file a bug? or should I?15:02
ericpetersoni have note15:03
ericpetersons/note/not15:03
david-lyleb-flat?15:03
david-lyleoh ok15:03
ericpetersonsounds a bit pitchy yo dawg15:03
david-lyleI'll do it15:03
ericpetersonthanks15:03
*** jprovazn has quit IRC15:05
david-lyleericpeterson: is the libxml2-dev requirement for devstack or Horizon?15:08
ericpetersonjust horizon, trying to run a basic ./run-test.sh -p15:09
*** mikedillion has joined #openstack-horizon15:09
david-lylepython-keystoneclient just made lxml a test-requirement rather than requirement on Aug 1515:10
rebelagentmjpich: Hi, Julie!15:11
david-lyleis this icehouse or juno?15:11
jpichrebelagentm: hello!15:11
*** nlahouti has joined #openstack-horizon15:13
*** radez_g0n3 is now known as radez15:13
rebelagentmjpich: Do you personally do your development and testing in a Devstack VM?15:13
jpichrebelagentm: For the vast majority of my work, yes indeed15:14
rebelagentmjpich: O.K.  I just got one set up and I'm going to try re-running the tests that were failing for me15:15
rebelagentmjpich: This is a totally clean install, so fingers crossed!15:15
rebelagentmjpich: And this would still be the same run_tests script, right?15:15
jpichrebelagentm: Yes!15:16
jpichrebelagentm: We're talking integration tests too, are we? For context :-)15:16
*** Longgeek has quit IRC15:16
rebelagentmjpich: Yes.  First thing I want to do is make sure it runs without my changes.  If that succeeds, I'll try with my changes15:17
jpichrebelagentm: Excellent. My fingers shall be crossed as well for you.15:17
rebelagentmjpich: For the first time, do I run stack.sh first or just run_tests.sh?15:17
rebelagentmjpich: Thanks! :)15:17
jpichrebelagentm: stack.sh will set up devstack itself, have you done this yet? You should only need to do it once15:17
jpich(then save/suspend the VM for when you need, as devstack doesn't persist across reboots)15:18
jpichrebelagentm: Huh yeah make sure you're running devstack in a VM if it is the first time you're using it15:18
jpichthere's no uninstall button15:18
rebelagentmjpich: Cool.15:18
*** sbfox has quit IRC15:18
rebelagentmjpich: run_tests instantly fails with "Too few arguments"15:21
*** pkoniszewski has quit IRC15:21
ericpetersontry a -p15:21
ericpetersonor a -V15:21
ericpeterson-p will be faster15:21
ericpetersonand less picky15:21
jpichrebelagentm: Did you add the --integration switch?15:21
rebelagentmI added --with-selenium15:22
jpichActually it should run all the tests by default anyway... rebelagentm, can you paste the command + output on paste.openstack.org?15:22
*** sbfox has joined #openstack-horizon15:22
jpichrebelagentm: Also are you running it from /opt/stack/horizon?15:23
rebelagentmjpich: I was running it from /devstack15:23
jpichrebelagentm: So that would run the devstack tests, run_tests.sh create a separate little environment for each project15:23
jpichrebelagentm: You'll need to cd to /opt/stack/horizon first so it runs the horizon tests and recognises the horizon options15:24
rebelagentmjpich: That looks better!15:24
jpichrebelagentm: \o/15:24
rebelagentmjpich: \m/15:25
rebelagentmjpich: Identity seems to be breaking15:33
*** amotoki has joined #openstack-horizon15:33
jpichrebelagentm: Did you try the dashboard manually first to make sure devstack completed successfully?15:33
rebelagentmYeah.  The dashboard worked.  I was able to login15:34
jpichSo, you're seeing test failures for the UT? Integration tests?15:34
rebelagentmMostly.  Before the Selenium tests ran though, there was a traceback for "Exception while obtaining flavors list"15:36
*** atan8 has quit IRC15:36
*** sayan has quit IRC15:37
david-lylerebelagentm: that's in the trove tests and is not really a failure15:38
david-lyleif you are not getting it in the failure/error count at the end15:38
rebelagentmdavid-lyle: Cool.  Thanks!15:38
*** peristeri has quit IRC15:39
david-lyleit just dumps an errant log message to the console15:39
david-lylecheck the job tally at the bottom of the test run for a failure15:39
rebelagentmSo, it seems that it is just the Selenium tests then15:39
rebelagentmdavid-lyle: I have nine errors, which looks to all be Selenium tests15:39
david-lyleok, but that's not related to the Exception while obtaining15:40
rebelagentmAll because it looks like it was never able to login successfully15:40
david-lylethat's all I wanted to point out15:40
rebelagentmRight15:40
rebelagentmThank you!15:40
jpichrebelagentm: Feel free to post a paste if you'd like help debugging15:41
*** cedricss has quit IRC15:41
rebelagentmjpich: Will do.  I'm going to run the tests one more time to make sure it wasn't just a fluke.  I confirmed again that I can login manually15:42
rebelagentmNow that it has been run once and set everything up, do I need to manually activate the virtualenv before running the script again?15:43
amotokijpich: there is a security bug with "New" status https://bugs.launchpad.net/horizon/+bug/1355487. is it related to https://bugs.launchpad.net/horizon/+bug/1349491 ? You dealt with the latter recently. If you have time, could you look?15:43
jpichrebelagentm: For the integration tests, you'll likely have to update horizon.conf with the right credentials before running the tests, but that shouldn't be related to selenium unit tests failures (separate credentials)15:43
jpichamotoki: Yeah. I thought I'd leave it for a while and see if someone less dumb than me takes it up, I'm angry for missing that while fixing the other one. I'll have a look tomorrow if no one else has picked it up by then15:45
jpichrebelagentm: ./run_tests.sh automatically creates a virtual environment for you (in .venv) and uses it for running the tests so no need to activate anything when running the script again15:46
amotokijpich: thanks. The problem is that it is not easy to know we have security bugs. I read openstack-security list but I don't check it regularly...15:47
linkidhi15:47
jpichamotoki: Yeah, the Launchpad emails are difficult to filter precisely15:48
linkidamotoki: for my patch (the one with string.letters and python 3), I'm on my way to add a check in pyflakes15:48
linkid'cause I think it is not only an OpenStack issue, so, adding it to Hacking should be more restrictive15:49
amotokijpich: I looks around horizon bugs with no tags and New status. Most of them are still in "New" status, but most of them are now tagged.15:49
jpichamotoki: Thank you!!15:49
jpichamotoki: Now we need people to take responsibility for different tags and fix all the bugs ;)15:50
amotokijpich: we seem to need domain specific expert for triaging bugs. tags help it.15:50
jpichI agree15:50
amotokijpich: it is the way nova does: https://wiki.openstack.org/wiki/Nova/BugTriage   we need the similar team.15:51
amotokilinkid: which one? i cannot remember it since i reviewed several numbers of .....15:52
jpichamotoki: That is super cool. I think we're all feeling the strain with more and more projects being added and more and more bugs being filed, that would really help. Informally I can think of who is responsible for some areas, but other places are definitely receiving less love and attention15:52
linkidamotoki: sorry : https://review.openstack.org/#/c/116516/15:53
amotokijpich: i noticed that tag '-*' in launchpad advanced search will list non-tagged bugs. It is nice.15:54
jpichamotoki: Nice!15:54
*** enykeev has joined #openstack-horizon15:54
amotokiit seems better we discuss how to triage bugs in the weekly meeting.15:55
jpichOr start a ML thread...15:56
amotokiAh.. ML thread sounds good. we need more boarder attentions.15:57
amotokilinkid: it sounds really nice. We saw not a small of number of python 3 compat patches, but we are not sure the similar will be repeated or not.15:58
amotokilinkid: i hope you leave a comment on the review. I am not sure how python3 compat work in OpenStack is going, so i cannot know its priority. do you know any?15:59
*** vijendar1 has joined #openstack-horizon16:00
linkidamotoki: before patching it, I checked if there were not other string.letters in other files and it should be ok, now, for that. But yes, I think it's a good thing to add python 3 tests because django is moves to it too16:00
*** vijendar has quit IRC16:01
rebelagentmjpich: Tried to paste my log and paste.openstack.org has an Internal Server Error16:02
linkidamotoki: I will leave a comment, yes. But I really don't know about python 3 compat in OpenStack, sorry… The only thng I know, by checking in openstack-infra/config is that dashboards are not using the python3 job16:02
linkidbut many projects do16:02
rebelagentmjpich: Here you go:  http://paste.openstack.org/show/99996/16:03
jpichrebelagentm: Hm, try to delete your cookies for the domain and/or wait a few seconds before refreshing, if still no luck any other paste site will do - fpaste.org?16:03
jpichah :)16:03
*** mat-lowery has joined #openstack-horizon16:03
rebelagentmjpich: I just thought it was funny :)16:03
rebelagentmI believe the integration tests are failing16:03
rebelagentmThe browser comes up to /identity, but the page just shows a 500 error16:04
jpichrebelagentm: I call it annoying :-) I'm not sure why paste.openstack.org16:04
rebelagentmI did update horizon.conf16:04
*** bvandenh has quit IRC16:04
rebelagentmjpich: :)16:04
jpichrebelagentm: I think you're still running the unit tests, you didn't use the "--integration" flag yet right?16:04
rebelagentmjpich: LOL16:04
rebelagentmI bet you're right16:04
rebelagentmI didn't use that flag16:05
rebelagentmonly --with-selenium16:05
rebelagentmI guess I was making assumptions16:05
jpichrebelagentm: Ok! So it's the Selenium unit tests. Does a browser window pop open during the tests? Or are you trying to run them from a SSH session?16:05
jpich(...from "e.g." an SSH session)16:05
mat-loweryHi all. I have a Trove-related change (https://review.openstack.org/#/c/71686/) that has +1's from the Trove-team and I'm just wondering how to get Horizon-team eyeballs on it.16:06
rebelagentmjpich: Yes.  And some of them seem to be fine.  But the ones in my paste are failing16:06
amotokilinkid: thanks. The reason that python3 job is not enabled in horizon is just perhaps because there are several unsolved problem related to python3, but I am not sure either.16:06
rebelagentmjpich: A browser opens16:06
amotokilinkid: in your case, the patch looks good and I feel that it is worth moving forward.16:07
jpichrebelagentm: ...Hm!16:07
linkidamotoki: For the dashboard I'm working on, I've enabled the py33 job, but I'm making it non-voting not to be block like I am now. Maybe Horizon could do that when we'll have django 1.716:08
* jpich tries ./run_tests.sh --only-selenium on a fresh local checkout and see what happens16:08
linkid(and thank you)16:08
*** ramishra has joined #openstack-horizon16:09
rebelagentmwill do16:09
amotokilinkid: regarding django 1.7, we still have unit test failures. https://bugs.launchpad.net/horizon/+bug/1360794   I tried to identify the cause but cannot so far :(16:10
jpichrebelagentm: Well... It works on my machine lol, if it's a fresh checkout I'm stuck as to what could be the issue for you... For these tests you shouldn't even need devstack to run16:10
*** qba73 has joined #openstack-horizon16:11
david-lyleamotoki, those tests are a mess16:12
david-lyleI think there must be a subtle failure in the actual code that is causing the bad behavior16:13
david-lyleneed to try and test my theory16:13
jpichrebelagentm: Are the tests slow to run? Do you think it could be a timeout while waiting for the page to load? Or are you running then directly in the VM already?16:13
amotokidavid-lyle: yeah..... I tried but have no good result so far. I wonder who catches the exception. Removing logging.setLevel or similar line help us to debug.16:14
*** atan8 has joined #openstack-horizon16:14
jpichmat-lowery: Sorry for the review delay, the queue is a bit of a disaster still. I had looked at that patch, I hope I can get to it again - were the Trove folks who reviewed it able to actually test the patch in Horizon?16:16
linkidamotoki: ok. Django 1.7 is not ready yet, according to the django ML, so, there is some time to check the code ;)16:18
mat-loweryjpich: Thanks. The two who +1'ed it are out today. I can ask tomorrow. My guess it that it was code review only and not actually pulled and tested.16:18
gary-smith_david-lyle amotoki: agreed, it's kind of a hack to suppress the log messages. Some of the error handling seems to always spew out logs, even when the exceptions are caught16:18
david-lyleamotoki, what I imagine is, that there is an error in the exception handling, that doesn't get executed under normal conditions16:18
david-lyleforcing an error in the live code may produce an error16:19
david-lyleran across something similar in the Hypervisor evacuate patch I picked up16:20
amotokiwhat I see is an exception is raised in __init__ method in workflow.16:20
*** qba73 has quit IRC16:22
jpichmat-lowery: Ok, fair enough! I'll see how my Trove setup is faring, I'm more comfortable with also testing things for areas/components I'm less familiar with, when it's possible. Cheers16:23
mat-loweryjpich: Thanks!16:23
*** cedrics has joined #openstack-horizon16:25
*** radez is now known as radez_g0n316:26
*** amotoki has quit IRC16:27
*** tqtran has joined #openstack-horizon16:31
*** absubram has joined #openstack-horizon16:33
*** mat-lowery has left #openstack-horizon16:33
*** atan8 has quit IRC16:34
*** ramishra has quit IRC16:35
*** ramishra has joined #openstack-horizon16:35
*** arezmerita has quit IRC16:35
*** ygbo has quit IRC16:38
*** dsneddon has joined #openstack-horizon16:42
*** radez_g0n3 is now known as radez16:47
*** harlowja has joined #openstack-horizon17:01
*** prasoon has quit IRC17:01
*** prasoon has joined #openstack-horizon17:02
*** mgagne_ has quit IRC17:11
*** mgagne_ has joined #openstack-horizon17:11
*** jpich has quit IRC17:12
*** ramishra has quit IRC17:13
*** ramishra has joined #openstack-horizon17:13
*** mikedill_ has joined #openstack-horizon17:15
*** ramishra has quit IRC17:18
*** mikedillion has quit IRC17:19
*** prasoon has quit IRC17:19
regebroHmm. So where does the keystone test data get stuck onto the request? Grumble.17:20
*** prasoon has joined #openstack-horizon17:20
*** tnovacik has joined #openstack-horizon17:24
*** aix has quit IRC17:24
*** prasoon has quit IRC17:24
*** masco has quit IRC17:27
*** amerine has joined #openstack-horizon17:27
*** colinmcnamara has joined #openstack-horizon17:27
*** colinmcnamara has quit IRC17:32
regebrogot it!17:32
*** linkid has quit IRC17:36
*** e0ne has joined #openstack-horizon17:39
*** radez is now known as radez_g0n317:39
*** mgagne_ is now known as mgagne17:39
*** wuhg has quit IRC17:42
*** jprovazn has joined #openstack-horizon17:44
*** david-ly_ has joined #openstack-horizon17:49
*** david-lyle has quit IRC17:53
*** sbfox has quit IRC17:56
*** cedrics has quit IRC17:56
*** sbfox has joined #openstack-horizon17:59
*** ArcTanSusan has joined #openstack-horizon18:00
*** ArcTanSusan has quit IRC18:03
*** clu_ has joined #openstack-horizon18:07
*** ArcTanSusan has joined #openstack-horizon18:11
*** jprovazn has quit IRC18:13
*** david-ly_ is now known as david-lyle18:18
*** woodm1979 has quit IRC18:19
*** e0ne has quit IRC18:19
*** sbfox1 has joined #openstack-horizon18:20
*** sbfox has quit IRC18:20
*** sbfox1 has quit IRC18:20
*** e0ne has joined #openstack-horizon18:20
*** sbfox has joined #openstack-horizon18:20
*** e0ne has quit IRC18:25
*** e0ne has joined #openstack-horizon18:26
*** e0ne has quit IRC18:26
*** rbertram has joined #openstack-horizon18:29
*** jasondotstar has quit IRC18:30
*** regebro has quit IRC18:31
*** jasondotstar has joined #openstack-horizon18:31
*** jasondotstar has quit IRC18:38
*** akrivoka has quit IRC18:38
*** tosky has quit IRC18:42
*** ArcTanSusan has quit IRC18:46
*** e0ne has joined #openstack-horizon18:57
*** jasondotstar has joined #openstack-horizon19:03
*** Ugallu has joined #openstack-horizon19:10
*** Ugallu has quit IRC19:10
*** Sukhdev has joined #openstack-horizon19:16
*** ArcTanSusan has joined #openstack-horizon19:17
*** ArcTanSusan has quit IRC19:25
*** e0ne has quit IRC19:26
*** ArcTanSusan has joined #openstack-horizon19:35
*** mikedill_ has quit IRC19:41
*** jcoufal_ has quit IRC19:46
*** tnovacik has quit IRC19:57
*** fifieldt_ has joined #openstack-horizon20:03
*** fifieldt has quit IRC20:06
*** ArcTanSusan has quit IRC20:10
*** ArcTanSusan has joined #openstack-horizon20:12
*** peristeri has joined #openstack-horizon20:19
*** mikedillion has joined #openstack-horizon20:23
*** lcheng has joined #openstack-horizon20:28
*** julim has quit IRC20:32
*** sbfox has quit IRC20:32
*** romainh has left #openstack-horizon20:38
*** sbfox has joined #openstack-horizon20:41
*** dkorn has joined #openstack-horizon20:59
*** david-lyle has quit IRC21:06
*** linkid has joined #openstack-horizon21:13
*** rodrigods has quit IRC21:13
*** linkid has left #openstack-horizon21:15
*** ArcTanSusan has quit IRC21:16
*** Sukhdev has quit IRC21:16
*** Sukhdev has joined #openstack-horizon21:18
*** lblanchard has quit IRC21:20
*** mikedillion has quit IRC21:21
*** rebelagentm has quit IRC21:27
*** mrunge has quit IRC21:28
*** rbertram has quit IRC21:36
*** ArcTanSusan has joined #openstack-horizon21:42
*** MaxV has joined #openstack-horizon21:47
*** stpierre has joined #openstack-horizon21:47
MaxVjomara: Hey, just got your mail, have you got 5mn21:47
*** radez_g0n3 is now known as radez21:48
*** stpierre has quit IRC21:52
*** amerine has quit IRC21:53
*** radez is now known as radez_g0n321:54
*** vijendar has joined #openstack-horizon21:54
*** vijendar has quit IRC21:54
*** david-lyle has joined #openstack-horizon21:55
*** vijendar1 has quit IRC21:55
*** MaxV has quit IRC21:58
*** nlahouti_ has joined #openstack-horizon21:58
*** peristeri has quit IRC21:59
*** neelashah1 has joined #openstack-horizon21:59
*** nlahouti has quit IRC22:00
*** neelashah has quit IRC22:00
*** MaxV has joined #openstack-horizon22:02
*** jasondotstar is now known as jasondotstar|afk22:02
*** mitz has quit IRC22:06
*** clu_ has quit IRC22:06
*** clu_ has joined #openstack-horizon22:07
*** asahlin has quit IRC22:08
*** david-ly_ has joined #openstack-horizon22:09
*** david-lyle has quit IRC22:10
*** dguerri_ has quit IRC22:10
*** dguerri has joined #openstack-horizon22:12
*** HenryG_ has joined #openstack-horizon22:12
*** doug-fish1 has joined #openstack-horizon22:13
*** jgravel__ has joined #openstack-horizon22:14
*** doug-fish1 has left #openstack-horizon22:14
*** doug-fish has quit IRC22:14
*** HenryG has quit IRC22:15
*** jgravel_ has quit IRC22:15
jomaraMaxV: hey sorry i was running an errand, still around?22:17
*** david-ly_ is now known as david-lyle22:18
MaxVjomara: here22:28
jomaraMaxV: hey!22:31
MaxVjomara: what is your issue? :)22:32
jomaraMaxV: one sec, im preparing something for you22:35
MaxVjomara: I don't move22:35
*** julim has joined #openstack-horizon22:36
*** sbfox has quit IRC22:38
jomaraMaxV: gah, sorry, having to switch back to a different branch, one more minute22:39
*** neelashah1 has quit IRC22:39
*** julim has quit IRC22:41
jomaraMaxV: ahhhh i am not getting different errors than before! im going to send you what i have now, anyway, because most likely its still wrong22:41
jomarahttp://pastebin.com/dJAgY7ZW22:42
jomarabefore i was getting issues with horizon.utils, which seems to have magically fixed itself22:42
MaxVfirst, why qunit?22:43
MaxVwe now have jasmine with better examples across the web22:43
MaxVthen use some dedicated module even for controllers, it will avoid loading all the ng module22:44
MaxVall the hz module*22:44
jomaraMaxV: i just sampled my previous work from teh angular /membership stuff22:45
jomaraMaxV: is allt he jasmine support i need already in horizon, or do i need to pluck it from your patch?22:45
*** lblanchard has joined #openstack-horizon22:45
jomarai was also attempting to somewhat limit the new stuff i was adding22:45
MaxVgood question, maybe some fixes in my patch need to be merge to use jasmine correctly22:46
MaxVthe error display seems to indicate that the sources from angular-bootstrap have not been included22:47
MaxVSetup failed on Should instantiate controller: [$injector:unpr] Unknown provider: $modalInstanceProvider <- $modalInstance22:47
MaxVthere is a typo here too: StackLaunch = injector.got('StackLaunch');22:48
jomarahaha, nice, wasnt making it that far22:48
jomaragood call, it is probably from the bootstrap js22:49
jomaraMaxV: should i abandon this and move it to jasmine?22:49
MaxVit is better especially for module mocking, and for spying some calls22:50
*** asahlin has joined #openstack-horizon22:50
MaxVit also have more example from the angular world22:50
MaxVall the stuff I found was based on jasmine22:51
jomaraok, that's probably a good choice then22:53
jomaraMaxV: what do you think i'll need to include to get it working?22:53
jomara(From your patch)22:53
*** amerine has joined #openstack-horizon22:54
MaxVhttps://review.openstack.org/#/c/115321/5/horizon/test/settings.py,cm22:54
MaxVjomara: ^ make angular bootstrap available in the test namespace22:55
jomaraMaxV: excellent, thanks22:55
MaxVjomara: and this one: https://review.openstack.org/#/c/115321/5/horizon/templates/horizon/jasmine/jasmine.html,cm22:55
MaxV<script type="text/javascript" src="{% url 'horizon:jsi18n' 'horizon' %}"></script>  and <script type="text/javascript" src="{{ STATIC_URL }}horizon/lib/angular/angular-bootstrap.js"></script>22:56
*** zul has quit IRC22:57
jomarai need to rebase my patch, its not based on the code that has the xstatic stuff (i started it a really long time ago =(22:58
jomaraMaxV: ok, thanks22:58
jomaraMaxV: how do you actually run them?22:58
*** ericpeterson has quit IRC22:58
MaxVjomara: helpers.py in horizon.test, I had a pdb breakpoint in jasmine_done function22:59
*** sbfox has joined #openstack-horizon22:59
MaxVjomara: then I run ./runtest --only-selenium22:59
MaxVjomara: It blocks on the jasmine page23:00
jomarainteresting23:00
MaxVjomara: and I only have to change javascript and reload to have them updated23:00
MaxVjomara: (reload the browser)23:00
*** vkmc has quit IRC23:01
jomaraMaxV: ok, nice, i will give that a shot - thanks!23:06
MaxVjomara: np :)23:06
*** bao_ has joined #openstack-horizon23:08
bao_hello23:08
bao_anyone on atm?23:09
*** zul has joined #openstack-horizon23:09
*** ArcTanSusan has quit IRC23:10
*** absubram has quit IRC23:13
*** ArcTanSusan has joined #openstack-horizon23:14
*** Sukhdev has quit IRC23:17
*** amerine has quit IRC23:23
*** MaxV has quit IRC23:34

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!