| *** aaronsheffield has quit IRC | 00:01 | |
| *** jamesgu_ has quit IRC | 00:45 | |
| *** sthussey has quit IRC | 00:55 | |
| *** aaronsheffield has joined #openstack-helm | 00:57 | |
| *** cfriesen has quit IRC | 02:00 | |
| openstackgerrit | Krishna Venkata proposed openstack/openstack-helm-infra master: WIP/RFC: minikube single node gate deployment https://review.openstack.org/618785 | 02:03 |
|---|---|---|
| *** jamesgu_ has joined #openstack-helm | 02:54 | |
| openstackgerrit | Renis Makadia proposed openstack/openstack-helm-infra master: Helm Tests for Ceph-RGW chart https://review.openstack.org/602515 | 02:55 |
| *** aaronsheffield has quit IRC | 03:06 | |
| *** sgrasley has quit IRC | 03:47 | |
| *** cfriesen has joined #openstack-helm | 05:45 | |
| *** roman_g has joined #openstack-helm | 06:57 | |
| *** gkadam has joined #openstack-helm | 07:00 | |
| *** cfriesen has quit IRC | 07:22 | |
| *** aojea has joined #openstack-helm | 07:28 | |
| *** rgogunskiy has quit IRC | 07:28 | |
| *** jamesgu_ has quit IRC | 07:52 | |
| *** roman_g has quit IRC | 08:12 | |
| *** lemko has joined #openstack-helm | 08:38 | |
| *** rgogunskiy has joined #openstack-helm | 08:41 | |
| *** rgogunskiy has quit IRC | 08:42 | |
| *** rgogunskiy has joined #openstack-helm | 08:44 | |
| openstackgerrit | Tin Lam proposed openstack/openstack-helm-infra master: Make access control annotations more generic. https://review.openstack.org/613703 | 08:54 |
| *** rgogunskiy has quit IRC | 09:11 | |
| openstackgerrit | Jean-Philippe Evrard proposed openstack/openstack-helm-images master: Add build process and osh-infra images https://review.openstack.org/615571 | 09:15 |
| *** roman_g has joined #openstack-helm | 09:32 | |
| openstackgerrit | Jean-Philippe Evrard proposed openstack/openstack-helm-images master: [WIP] Add build process and osh-infra images https://review.openstack.org/615571 | 10:19 |
| *** jistr is now known as jistr|mtg | 10:34 | |
| openstackgerrit | Jean-Philippe Evrard proposed openstack/openstack-helm-images master: [WIP] Add build process and osh-infra images https://review.openstack.org/615571 | 11:01 |
| openstackgerrit | Merged openstack/openstack-helm-infra master: Make access control annotations more generic. https://review.openstack.org/613703 | 11:44 |
| *** jaypipes has joined #openstack-helm | 12:31 | |
| *** aaronsheffield has joined #openstack-helm | 13:07 | |
| openstackgerrit | Aaron Sheffield proposed openstack/openstack-helm-infra master: Adding AppArmor profile to Calico v3 https://review.openstack.org/614805 | 13:11 |
| openstackgerrit | Jean-Philippe Evrard proposed openstack/openstack-helm-images master: Add build process and osh-infra images https://review.openstack.org/615571 | 13:13 |
| openstackgerrit | Jean-Philippe Evrard proposed openstack/openstack-helm-images master: Add openSUSE Leap 15 VBMC image https://review.openstack.org/620065 | 13:14 |
| *** phuoc has quit IRC | 13:15 | |
| *** phuoc has joined #openstack-helm | 13:16 | |
| *** jistr|mtg is now known as jistr | 13:21 | |
| *** sthussey has joined #openstack-helm | 13:56 | |
| srwilkers | o/ | 13:57 |
| portdirect | \o | 13:57 |
| openstackgerrit | Jean-Philippe Evrard proposed openstack/openstack-helm-images master: Add openstack-helm repo images https://review.openstack.org/620608 | 14:13 |
| evrardjp | srwilkers: portdirect good morning | 14:23 |
| evrardjp | so I removed kubeadm-aio from the import of osh-infra to osh-images thing, and that commit should be ready. It also now builds on bionic vs xenial, so we don't have to worry about that in the future. | 14:24 |
| portdirect | evrardjp: nice - had a peek at it earlier, will have a proper one now | 14:24 |
| evrardjp | Now I am importing osh images into osh-images with 620608 . I have a question about one of the images | 14:24 |
| portdirect | shoot | 14:25 |
| evrardjp | kubernetes-entry point seem to rely on makefile, which is for me, a bad idea for gates. I'd like the minimum use of wrapping things (that's why I am not using build.sh for gating on the images, but directly using dockerfile with an ansible task) | 14:26 |
| evrardjp | so I consider kubernetes-entrypoint requires an update there , am I the only one to see that, and where is this useful for? | 14:26 |
| portdirect | we dont build kubernetes-entry-point ? | 14:27 |
| portdirect | i think im missing somthing | 14:27 |
| evrardjp | https://github.com/openstack/openstack-helm/blob/master/tools/images/kubernetes-entrypoint/Makefile#L61-L81 | 14:27 |
| portdirect | ah - good find | 14:28 |
| evrardjp | I could totally understand if we had a multiple layer dockerfile that re-uses previous steps. | 14:28 |
| portdirect | thats from a time when it was broken upstream | 14:29 |
| evrardjp | but that sounds more complex and relying on the user, which is something I'd like to avoid | 14:29 |
| evrardjp | portdirect: do we still need that? | 14:29 |
| portdirect | i think we can safely remove it now | 14:29 |
| evrardjp | could you clarify its purpose, and by what should it be replaced now ? | 14:29 |
| portdirect | kubernetes entrypoint? | 14:30 |
| evrardjp | yeah | 14:30 |
| evrardjp | that image | 14:30 |
| portdirect | it does all the dependency checking prior to launching the service in a pod | 14:31 |
| portdirect | https://github.com/stackanetes/kubernetes-entrypoint#kubernetes-entrypoint | 14:31 |
| portdirect | you'll find it as part of every pod in osh | 14:31 |
| portdirect | brb | 14:31 |
| evrardjp | I googled the stackanetes part already, my question was: if I remove it, it should probably be replaced by something else, right? | 14:32 |
| openstackgerrit | Renis Makadia proposed openstack/openstack-helm-infra master: Helm Tests for Ceph-RGW chart https://review.openstack.org/602515 | 14:35 |
| srwilkers | evrardjp: we consume the upstream kubernetes-entrypoint in quay.io/stackanetes | 14:39 |
| srwilkers | which is why we don't need the image that exists in the repository currently | 14:39 |
| evrardjp | ok | 14:43 |
| evrardjp | that's a clear answer :) | 14:44 |
| srwilkers | :) | 14:44 |
| evrardjp | sometimes 4 words are better than 2. | 14:44 |
| evrardjp | :D | 14:44 |
| evrardjp | testing portdirect sense of humour there | 14:44 |
| evrardjp | he should be fine, but now that he migrated, he might have changed :p | 14:45 |
| srwilkers | it's hard to take the irish out of portdirect | 14:45 |
| srwilkers | (ive found that's the easiest way to test him) | 14:45 |
| portdirect | evrardjp: i live in George Orwell's nightmares now. | 14:51 |
| portdirect | srwilkers: I'll deal with you later | 14:51 |
| portdirect | ;P | 14:51 |
| srwilkers | hehe | 14:55 |
| *** cfriesen has joined #openstack-helm | 15:00 | |
| evrardjp | seem to work. | 15:08 |
| evrardjp | whiskey whisky, you know, right? | 15:08 |
| srwilkers | ;) | 15:10 |
| srwilkers | evrardjp: taking another look at the image stuff now | 15:14 |
| evrardjp | srwilkers: will read your review then | 15:19 |
| evrardjp | good thing is that images are supposed to be separate, so they will build independantly. I would probably require your help to be building a Makefile, who's the Makefile pro here? | 15:20 |
| evrardjp | srwilkers: have a look at https://review.openstack.org/#/c/620608/ too. | 15:20 |
| evrardjp | I can probably adapt commit message if we are picky :) | 15:21 |
| portdirect | evrardjp: why `cd ${SCRIPT_DIR}/.. > /dev/null` ? | 15:23 |
| srwilkers | yeah, just left feedback there | 15:23 |
| openstackgerrit | Renis Makadia proposed openstack/openstack-helm-infra master: Helm Tests for Ceph-RGW chart https://review.openstack.org/602515 | 15:23 |
| evrardjp | because that's ugly to see it changes folder in log | 15:27 |
| openstackgerrit | Jean-Philippe Evrard proposed openstack/openstack-helm-images master: Add openstack-helm repo images https://review.openstack.org/620608 | 15:29 |
| evrardjp | done | 15:29 |
| openstackgerrit | Renis Makadia proposed openstack/openstack-helm-infra master: Helm Tests for Ceph-RGW chart https://review.openstack.org/602515 | 15:34 |
| *** gkadam has quit IRC | 15:35 | |
| *** jamesgu_ has joined #openstack-helm | 15:36 | |
| srwilkers | nice evrardjp :) | 15:41 |
| evrardjp | flattering me doesn't come without risks | 15:42 |
| evrardjp | :p | 15:42 |
| portdirect | evrardjp: re > /dev/null i'd remove them - we should be able to clearly see the context that commands are running from. | 15:44 |
| evrardjp | I am fine with editing the > /dev/null, but srwilkers will have to revote on it :p | 15:44 |
| portdirect | wfm, thx guys :) | 15:45 |
| srwilkers | That’s fine with me. All that effort to revote will cost you though | 15:46 |
| portdirect | where's my coffee? | 15:46 |
| portdirect | please dont add things to it again. | 15:46 |
| evrardjp | haha | 15:47 |
| evrardjp | well it costs gating time and rebase of my suse patch :p | 15:47 |
| evrardjp | but that's fine | 15:47 |
| openstackgerrit | Jean-Philippe Evrard proposed openstack/openstack-helm-images master: Add build process and osh-infra images https://review.openstack.org/615571 | 15:48 |
| openstackgerrit | Jean-Philippe Evrard proposed openstack/openstack-helm-images master: Add openstack-helm repo images https://review.openstack.org/620608 | 15:50 |
| openstackgerrit | Jean-Philippe Evrard proposed openstack/openstack-helm-images master: Add openstack-helm repo images https://review.openstack.org/620608 | 15:50 |
| openstackgerrit | Jean-Philippe Evrard proposed openstack/openstack-helm-images master: Add openSUSE Leap 15 VBMC image https://review.openstack.org/620065 | 15:51 |
| evrardjp | okay they should be all there ^ | 15:51 |
| evrardjp | now I am bringing LOCI in, then I am adding a job to publish those into some namespace (to be discussed), then adding a global makefile for convenience/previous conventions | 15:52 |
| evrardjp | portdirect: where are we in the skimming of the 1.0 storyboard list? | 15:55 |
| portdirect | its srwilkers and my priority for this week | 16:06 |
| *** jamesgu__ has joined #openstack-helm | 16:07 | |
| srwilkers | yep. i started looking at that this morning while doing some code reviews | 16:08 |
| *** kranthikirang has joined #openstack-helm | 16:08 | |
| openstackgerrit | Renis Makadia proposed openstack/openstack-helm-infra master: Helm Tests for Ceph-RGW chart https://review.openstack.org/602515 | 16:08 |
| evrardjp | sorry for my lack of reviews nowadays. I am focusing on getting this done. | 16:09 |
| *** jamesgu_ has quit IRC | 16:10 | |
| srwilkers | evrardjp: no worries | 16:10 |
| evrardjp | portdirect: you forgot two votes: https://review.openstack.org/#/c/620608/ and https://review.openstack.org/#/c/620065/ | 16:33 |
| cfriesen | supamatt: so for https://review.openstack.org/#/c/619747 I realized what was going on with the apache2/httpd thing. We're running a centos image, and they use "httpd" instead of "apache2" for the filenames. We added a symlink /var/log/apache2 which points to /var/log/httpd, but centos is creating the file with the name "httpd.pid" | 16:45 |
| cfriesen | supamatt: so maybe the most generic thing is to handle both paths? Also, I think we could just do "rm -f" without the check whether it exists first. | 16:46 |
| *** kranthikirang has quit IRC | 16:55 | |
| supamatt | I feel like a check to see if the pid exists is always safer | 16:59 |
| *** kranthikirang has joined #openstack-helm | 17:00 | |
| *** aojea has quit IRC | 17:09 | |
| *** kranthikirang has quit IRC | 17:11 | |
| *** kranthikirang has joined #openstack-helm | 17:11 | |
| srwilkers | i also prefer a check. in regards to handling differing paths, would it be possible to check the distribution and act appropriately? not sure if checking the output of uname or something would be sane | 17:20 |
| srwilkers | as admittedly im used to ubuntu for the most part | 17:20 |
| srwilkers | or /etc/os-release. not sure | 17:23 |
| * srwilkers runs off to lunch | 17:24 | |
| cfriesen | supamatt: we're not checking to see if the pid exists, but rather the pid file. "rm -f <file>" just deletes the pid file if it exists, and ignores errors if it can't delete it, so its essentially equivalent to "if file exists, delete file" | 17:28 |
| openstackgerrit | Gage Hugo proposed openstack/openstack-helm master: WIP - Scan templated python files with bandit https://review.openstack.org/607721 | 17:29 |
| cfriesen | supamatt: srwilkers: looks like /etc/os-release would have the necessary info: http://paste.openstack.org/show/736331/ | 17:34 |
| evrardjp | when I hear checking if pid exists and then doing a rm ... I get scared of race conditions... :) | 17:42 |
| srwilkers | cfriesen: nice | 17:50 |
| *** gmmaharaj has joined #openstack-helm | 18:02 | |
| *** gmmaha has quit IRC | 18:02 | |
| *** gmmaharaj is now known as gmmaha | 18:02 | |
| *** kranthikirang has quit IRC | 18:03 | |
| *** kranthikirang has joined #openstack-helm | 18:03 | |
| *** kranthikirang has quit IRC | 18:04 | |
| openstackgerrit | Pete Birley proposed openstack/openstack-helm master: Nova: Mount cgroups read only https://review.openstack.org/620673 | 18:18 |
| portdirect | cfriesen: do you publish images for starlingx yet? | 18:38 |
| portdirect | lets get centos images up as part of the work evrardjp is doing, then we can tackle these cases properly if your not yet in a position to publish images | 18:38 |
| portdirect | it would be good to get proper support in the charts that we can gate on, rather than having to jump though hoops at both ends to get a working solution | 18:39 |
| cfriesen | portdirect: I think they're up as of fairly recently...I'll try to find the location | 18:39 |
| portdirect | nice - thx dude | 18:39 |
| portdirect | if we did it properly, we could remove the need for your symlink fun that you do today :) | 18:40 |
| cfriesen | yep. had to do a quick-n-dirty to get it running. :) | 18:40 |
| srwilkers | ++ | 18:41 |
| openstackgerrit | Steve Wilkerson proposed openstack/openstack-helm master: OSH: Temporarily move Armada job to experimental https://review.openstack.org/620679 | 18:49 |
| openstackgerrit | Merged openstack/openstack-helm-images master: Add build process and osh-infra images https://review.openstack.org/615571 | 18:58 |
| openstackgerrit | Renis Makadia proposed openstack/openstack-helm-infra master: Helm tests for Ceph-OSD and Ceph-Client charts https://review.openstack.org/599919 | 19:00 |
| cfriesen | portdirect: looks like I was premature...they're still working on the last bits of actually making the images available for download. | 19:27 |
| cfriesen | portdirect: but the vanilla centos image is available, of course | 19:27 |
| openstackgerrit | Jean-Philippe Evrard proposed openstack/openstack-helm master: Add Reno to OSH repo https://review.openstack.org/563481 | 19:52 |
| openstackgerrit | Renis Makadia proposed openstack/openstack-helm-infra master: Helm Tests for Ceph-RGW chart https://review.openstack.org/602515 | 20:08 |
| *** kranthikirang has joined #openstack-helm | 20:33 | |
| *** kranthikirang has quit IRC | 20:35 | |
| *** openstackgerrit has quit IRC | 20:36 | |
| *** kranthikirang has joined #openstack-helm | 20:36 | |
| *** openstackgerrit has joined #openstack-helm | 20:50 | |
| openstackgerrit | Gage Hugo proposed openstack/openstack-helm-infra master: k8s-keystone create cluster roles and tests https://review.openstack.org/577920 | 20:50 |
| *** kranthikirang has quit IRC | 20:50 | |
| *** kranthikirang has joined #openstack-helm | 20:54 | |
| openstackgerrit | Gage Hugo proposed openstack/openstack-helm-infra master: k8s-keystone create cluster roles and tests https://review.openstack.org/577920 | 20:56 |
| openstackgerrit | Randy Martinez proposed openstack/openstack-helm master: docs: Adding Operations Documentation https://review.openstack.org/620694 | 20:57 |
| openstackgerrit | Gage Hugo proposed openstack/openstack-helm master: Create admin k8s roles on keystone bootstrap https://review.openstack.org/620696 | 21:02 |
| *** kranthikirang has quit IRC | 21:09 | |
| *** kranthikirang has joined #openstack-helm | 21:10 | |
| *** kranthikirang has quit IRC | 21:14 | |
| *** jamesgu__ has quit IRC | 21:14 | |
| *** jamesgu__ has joined #openstack-helm | 21:18 | |
| openstackgerrit | Gage Hugo proposed openstack/openstack-helm master: WIP - Scan templated python files with bandit https://review.openstack.org/607721 | 21:22 |
| *** kranthikirang has joined #openstack-helm | 21:25 | |
| *** lemko has quit IRC | 21:35 | |
| *** kranthikirang has quit IRC | 21:42 | |
| *** kranthikirang has joined #openstack-helm | 22:01 | |
| *** kranthikirang has quit IRC | 22:06 | |
| openstackgerrit | Mike Pham proposed openstack/openstack-helm-infra master: WIP - Adding auth tags for the logs to support special filter for openstack and application security logs https://review.openstack.org/620714 | 22:18 |
| openstackgerrit | Mike Pham proposed openstack/openstack-helm-infra master: WIP - Adding auth tags for the logs to support special filter for openstack and application security logs https://review.openstack.org/620714 | 22:20 |
| openstackgerrit | Mike Pham proposed openstack/openstack-helm-infra master: WIP - Adding auth tags for the logs to support special filter for openstack and application security logs https://review.openstack.org/620714 | 22:22 |
| *** kranthikirang has joined #openstack-helm | 22:56 | |
| openstackgerrit | Scott Huang proposed openstack/openstack-helm-infra master: Add Nagios Elasticsearch Query Command https://review.openstack.org/618797 | 23:17 |
| openstackgerrit | Scott Huang proposed openstack/openstack-helm-infra master: Add Nagios Elasticsearch Query Command https://review.openstack.org/618797 | 23:22 |
| *** kranthikirang has quit IRC | 23:23 | |
| *** kranthikirang has joined #openstack-helm | 23:25 | |
| *** kranthikirang has quit IRC | 23:45 | |
| *** aaronsheffield has quit IRC | 23:46 | |
| *** jamesgu_ has joined #openstack-helm | 23:55 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!