| *** uck has quit IRC | 00:08 | |
| *** spzala has quit IRC | 01:02 | |
| *** spzala has joined #openstack-heat-translator | 03:02 | |
| *** spzala has quit IRC | 03:07 | |
| *** tbh has joined #openstack-heat-translator | 03:24 | |
| *** tbh has quit IRC | 03:49 | |
| *** spzala has joined #openstack-heat-translator | 11:34 | |
| *** tbh has joined #openstack-heat-translator | 11:57 | |
| *** bobh has joined #openstack-heat-translator | 11:59 | |
| *** bobh has quit IRC | 12:06 | |
| *** spzala has quit IRC | 12:28 | |
| *** vishwanathj has joined #openstack-heat-translator | 12:57 | |
| *** tbh has quit IRC | 13:05 | |
| *** tbh has joined #openstack-heat-translator | 13:06 | |
| *** spzala has joined #openstack-heat-translator | 13:11 | |
| *** spzala has quit IRC | 13:11 | |
| *** spzala has joined #openstack-heat-translator | 13:11 | |
| *** mvelten has joined #openstack-heat-translator | 13:22 | |
| *** openstackstatus has joined #openstack-heat-translator | 13:36 | |
| *** ChanServ sets mode: +v openstackstatus | 13:36 | |
| -openstackstatus- NOTICE: OpenStack Infra now has a Twitter bot, follow it at https://twitter.com/openstackinfra | 13:43 | |
| spzala | mvelten: tbh: hi | 13:50 |
|---|---|---|
| spzala | wish if Kanagaraj was here on the channel | 13:50 |
| mvelten | hi there | 13:51 |
| tbh | spzala, hi | 13:51 |
| tbh | spzala, mvelten the approach you mentioned sounds good | 13:53 |
| spzala | hi guys | 13:53 |
| spzala | tbh: cool, thanks | 13:53 |
| spzala | mvelten: did you look at my latest comment on the patch? | 13:53 |
| mvelten | yes fine for me | 13:54 |
| spzala | mvelten: awesome, thanks!! | 13:55 |
| mvelten | with "test with a real heat deployment" added :) | 13:55 |
| spzala | mvelten: :) absolutely +2 for that | 13:55 |
| spzala | tbh: please test it once you remove files section. I will test it too - only thing I don't have in my env is Aodh/Ceilometer. | 13:56 |
| spzala | tbh: mvelten: I actually tested real heat deployment with tbh's previous patch (before he added files section) and that's how I found out two problems | 13:56 |
| spzala | I ended up this two errors: | 13:57 |
| spzala | ERROR: Property error: : resources.asg_group.properties: : Unknown Property resources | 13:57 |
| spzala | ERROR: Property error: : resources.asg_group.properties: : Unknown Property default_instances | 13:57 |
| spzala | and the fix is now added in the tbh's patch | 13:57 |
| spzala | so totally agree that unless we try real test deployment, it's always shaky | 13:58 |
| spzala | those two errors weren't part of tbh's changes though, it's original bad code but I was told that 'real test deployment' was done in the initial patch on scaling .. oh well | 13:59 |
| spzala | (trying to see if we can have Kanagaraj join us and see if he is fine from Tacker's perspective ) | 14:02 |
| tbh | spzala, will test and push | 14:02 |
| spzala | tbh: prefect! thanks! | 14:03 |
| *** bobh has joined #openstack-heat-translator | 14:42 | |
| *** KanagarajM has joined #openstack-heat-translator | 15:00 | |
| KanagarajM | Hi | 15:00 |
| spzala | KanagarajM: Hi | 15:01 |
| spzala | you made it :-) | 15:01 |
| spzala | thanks for joining | 15:01 |
| KanagarajM | spzala, :) | 15:01 |
| KanagarajM | spzala, hey, nope. | 15:02 |
| spzala | :) | 15:02 |
| spzala | https://review.openstack.org/#/c/371063/ | 15:02 |
| KanagarajM | looking into | 15:02 |
| spzala | sure | 15:03 |
| KanagarajM | spzala, for generating the nested template, may you could give an option for the output dir and generate the templ and nested tmp in that dir | 15:04 |
| spzala | tbh: just fyi, KanagarajM is here | 15:04 |
| spzala | KanagarajM: that's what I actually suggested but we thought for quick fix let's use PWD? | 15:04 |
| KanagarajM | and while using like sdk in tacker, may be you could give addition python api, to get the nested tmpl(s) and main tmpl | 15:04 |
| spzala | KanagarajM: we have --output-file option for CLI | 15:05 |
| spzala | KanagarajM: and if that option is provided my thought was to save the translated and nested templates there | 15:05 |
| spzala | if that option is not provided than we simply store in the $PWD | 15:05 |
| KanagarajM | yes, that sounds better | 15:05 |
| spzala | but with that patch, we assumed the second scenario only. | 15:06 |
| KanagarajM | and for tacker, pls address the option suggested here, it would be great :) | 15:06 |
| spzala | KanagarajM: Cool | 15:06 |
| tbh | KanagarajM, which option you are talking about? | 15:06 |
| spzala | KanagarajM: sure, so hopefully we should be able to cover both this options | 15:06 |
| mvelten | my patch adresses the needs so we can merge that with $PWD and see later | 15:06 |
| spzala | mvelten: that's awesome | 15:06 |
| spzala | KanagarajM: so for now, can we just go with $PWD for heat-translator upcoming 0.6.0 release if that fits in Tacker's case? | 15:07 |
| KanagarajM | tbh, in tacker, we use translator to get the HOT tmpl, as part of it, i would like to get the nested tmpl in python api | 15:07 |
| mvelten | it also allows to switch to only output one template, with substack embedded as text inside (the output is ugly but it works) | 15:07 |
| spzala | KanagarajM: and then with mvelten's patch both options will be available with master repo | 15:08 |
| KanagarajM | spzala, but is files in the HOT template valid one ? | 15:08 |
| tbh | KanagarajM, for that purpose, we have added "files" action, which can't be deployed directly | 15:08 |
| spzala | KanagarajM: yes, absolutely | 15:08 |
| tbh | KanagarajM, it is not valid | 15:08 |
| spzala | KanagarajM: 'files' is not valid | 15:08 |
| spzala | KanagarajM: so we removing it | 15:08 |
| KanagarajM | yes, i am concerned on it | 15:09 |
| spzala | KanagarajM: sorry, i thought you mean translated files :-) | 15:09 |
| spzala | KanagarajM: yup, totally agree and you can see comments related to your comments.. and the final approach (the last comment) that we will take out 'files' section | 15:09 |
| tbh | KanagarajM, for tacker, if we need both templates using translator we have to output both yaml files | 15:09 |
| spzala | KanagarajM: so with that, it will generate nested templates (e.g. asg_reg.yaml on it's own) | 15:10 |
| KanagarajM | spzala, 1 sec, | 15:10 |
| spzala | mvelten: that's awesome, so are you saying that with one template, it will be two 'stacks' like two stack heat resources? | 15:10 |
| spzala | KanagarajM: sure | 15:10 |
| KanagarajM | spzala, pls refer here https://github.com/openstack/tacker/blob/master/tacker/vnfm/infra_drivers/openstack/openstack.py#L279-L281 | 15:12 |
| KanagarajM | i would expect to provide something like translator.get_main_template() ... translator.get_nested_templates() | 15:12 |
| KanagarajM | 2nd method would give me the map | 15:13 |
| spzala | KanagarajM: in that case, | 15:13 |
| KanagarajM | while first one give the pyhton dic | 15:13 |
| mvelten | mine does that :D the output is a map | 15:13 |
| KanagarajM | and make the backward compatible on existing api, so that it does not break tacker | 15:13 |
| KanagarajM | mvelten, 1 sec | 15:14 |
| mvelten | I think the api didnt change ? with tbh patch I think ? | 15:14 |
| spzala | mvelten: that's true, no api change with tbh's patch | 15:14 |
| KanagarajM | mvelten, https://review.openstack.org/#/c/371063/8/translator/hot/tosca_translator.py here there is no api provided as suggested above | 15:14 |
| spzala | mvelten: but it won't satisfy the need for Kanagaraj | 15:15 |
| tbh | spzala, mvelten right no change in api | 15:15 |
| spzala | tbh: thanks, yup agree | 15:15 |
| KanagarajM | spzala, i mean, when translator.translate() is called, let it behave like earlier | 15:16 |
| spzala | KanagarajM: with the current approach is like, you need to look into $PWD and get the nested template but I agree with you that for your need to programatically using nested template we need APIs | 15:16 |
| tbh | KanagarajM, spzala why can't we pass output-dir arg to Translator and then read the templates from the dir | 15:16 |
| KanagarajM | spzala, yes, for tacker that is important | 15:16 |
| mvelten | we need tacker integration for now ? | 15:17 |
| tbh | KanagarajM, spzala probably we can follow the naming convention to name "main.yaml" for parent template and add remaining files to "files" in tacker code | 15:17 |
| KanagarajM | tbh, it would be an workarround than a solution. and for tacker, translator is like sdk and not a cli/tool | 15:17 |
| mvelten | because we were planning to introduce this properly with my patch (multi files support) | 15:17 |
| mvelten | this is a workaround | 15:18 |
| mvelten | so if you dont need it right now in tacker I would wait for my patch to come in before doing anything | 15:19 |
| tbh | KanagarajM, and at the same time, heat-translator has to keep other projects requirements also in mind | 15:19 |
| spzala | KanagarajM: true, but can we go with workaround for now? and as mvelten: said with his patch which is up for review it will be a proper solution | 15:19 |
| KanagarajM | tbh, yes, so i would prefer to keep as sdk , which would help tacker, heat-translaotr cli and other dependent | 15:20 |
| spzala | the reason we are pushing for workaround vs. mvelten: patch is review time needed for his patch etc. | 15:20 |
| spzala | KanagarajM: Tacker's not using heat-translator from master right? | 15:20 |
| spzala | i.e. it uses pypi of translator? | 15:21 |
| mvelten | I need to change a lot of stuffs in my patch to handle correctly the various scaling possibilities added in the last 2 months, I can't do that properly in a rush for newton | 15:21 |
| spzala | for Tacker to use new pypi of translator with fix (proper fix or workaround) we only have little time for newton cycle it seems before tacker's newton release | 15:21 |
| tbh | spzala, yes pypi | 15:22 |
| KanagarajM | spzala, i am ok to go without this patch in place, as 1. tacker does the translator job now and it works as expected 2. it does not break any projects. so if we are all fine, we could push this support to ocata. | 15:22 |
| spzala | mvelten: agree, rushing may break other things and we shouldn't rush | 15:22 |
| mvelten | it will only not work if you pass a tosca that would trigger the generation of multiples files | 15:22 |
| KanagarajM | mvelten, spzala yes. exactly +1 | 15:23 |
| spzala | KanagarajM: that's great | 15:23 |
| spzala | yes +2 from me | 15:23 |
| spzala | well, that's desired conclusion of our discussion | 15:23 |
| spzala | :-) thank you so much guys KanagarajM: tbh: mvelten: | 15:24 |
| spzala | tbh: so it sounds good with you too? | 15:24 |
| KanagarajM | spzala, tbh, mvelten thank you. | 15:24 |
| tbh | spzala, you mean to abandon the current patch? | 15:25 |
| spzala | tbh: no no | 15:25 |
| spzala | tbh: your patch is valuable | 15:25 |
| spzala | KanagarajM: yrw, thank you | 15:25 |
| spzala | tbh: your patch is great to fix the bug | 15:25 |
| tbh | spzala, I mean to get it in ocata | 15:26 |
| spzala | tbh: Tacker probably can't use it as such so they will keep their workaround for now | 15:26 |
| spzala | tbh: no, we will merge it today for only after get mvelten: and kanagaraj review | 15:26 |
| spzala | and then we will do heat-translator pypi so the patch changes go in it | 15:26 |
| KanagarajM | spzala, tbh , yes, at this moment, i don't want to enable anything related to OS::Heat::AutoScaling, OS::Heat::ScalingPolicy in translaotr | 15:27 |
| KanagarajM | as it might regret tacker. | 15:27 |
| spzala | see, even though tacker can't use the patch the bug Kanagaraj reported is valid | 15:27 |
| spzala | and your patch provides a fix for it, it's just that Tacker won't be able to use the fix | 15:27 |
| tbh | spzala, agree | 15:27 |
| spzala | KanagarajM: hmmm.. little confused now | 15:28 |
| spzala | KanagarajM: we already have some autoscaling support in translator which is broken as you know, and tbh: patch fixes it | 15:28 |
| spzala | Kanagaraj: so that's ok to have in newer release of translator for tacker right? it's just Tacker won't use it as such | 15:29 |
| spzala | KanagarajM: as this at least enables user to use scaling non-programatically | 15:29 |
| KanagarajM | spzala, sure, as far as it does not break the tacker functioanlity, i am very happy to enable it in translator, | 15:30 |
| spzala | KanagarajM: sure, with this patch no change in API or anything so it shouldn't break anything on Tacker's side | 15:31 |
| spzala | KanagarajM: I usually get bobh: help to verify that translator/parser not breaking Tacker before releasing new PyPI | 15:31 |
| spzala | bobh: hi .. hope I can count on your help this time too for verification :-) | 15:32 |
| KanagarajM | now tacker uses earlier version of pypi translator | 15:32 |
| mvelten | ok I get it now, the problem is that the fix cant be used right now by tacker because it needs to handle the multiple files case, what I didnt get is that the problem was actually reported by tacker :) | 15:32 |
| spzala | KanagarajM: so if there is anything that breaks Tacker we will undo those changes | 15:32 |
| spzala | mvelten: :) hehe | 15:32 |
| mvelten | it should not break, it will not just fix the pb for them | 15:32 |
| spzala | mvelten: exactly | 15:32 |
| KanagarajM | spzala, i think its other way, translator would pull out :) | 15:33 |
| spzala | KanagarajM: sorry didn't get it but what I was saying is we will remove any changes in translator if it breaks Tacker - that sounds good? I guess we are on same page there? :-) | 15:34 |
| KanagarajM | spzala, yeah ;) | 15:34 |
| spzala | KanagarajM: ;) OK | 15:34 |
| spzala | Alright, so cool. The conclusion is: | 15:35 |
| spzala | 1. Go with tbh: patch once he remove 'files' section, enable $PWD nested template etc. per discussion | 15:35 |
| spzala | 2. Create release of heat-translator pypi 0.6.0 and if it break tacker in anyway we will revert | 15:36 |
| spzala | 3. mvelten: patch during ocata will provide a proper fix for Tacker | 15:36 |
| KanagarajM | spzala, +1 :) | 15:37 |
| mvelten | +1 | 15:37 |
| tbh | spzala, yup | 15:37 |
| spzala | KanagarajM: mvelten: tbh: thanks!! tbh: way to go :-) | 15:37 |
| spzala | Please review the patch once tbh: make changes | 15:38 |
| KanagarajM | spzala, yrw. thanks. | 15:39 |
| spzala | KanagarajM: :) :) | 15:40 |
| KanagarajM | spzala, :) | 15:40 |
| bobh | spzala: I'll try :-) | 16:00 |
| spzala | bobh: :-) THANKS! | 16:03 |
| spzala | bobh: it's been a big help every time with release. once tbh: patch merge I will reach out to you | 16:03 |
| bobh | spzala: no problem - I'm still trying to test the heat template version update | 16:10 |
| spzala | bobh: ah, nice that you are looking at it. The patch that's under review, I think that one is important one but we can push it next release | 16:10 |
| spzala | bobh: as it's last minute now and not sure if it can break anything | 16:11 |
| bobh | spzala: might be a good idea | 16:11 |
| spzala | bobh: cool, thanks | 16:11 |
| openstackgerrit | bharaththiruveedula proposed openstack/heat-translator: Add nested template support for auto scaling https://review.openstack.org/371063 | 17:02 |
| *** KanagarajM has quit IRC | 17:02 | |
| spzala | sridhar_ram: thanks, sorry missed the ping due to lunch but I am glad that you are fine with the current approach we are taking | 17:08 |
| sridhar_ram | spzala: yes, can't take risk at this stage | 17:21 |
| *** uck has joined #openstack-heat-translator | 17:38 | |
| *** tbh has quit IRC | 17:52 | |
| *** bobh_ has joined #openstack-heat-translator | 18:33 | |
| *** bobh has quit IRC | 18:33 | |
| *** bobh_ has quit IRC | 20:24 | |
| *** bobh has joined #openstack-heat-translator | 20:24 | |
| *** bobh has quit IRC | 20:49 | |
| *** bobh has joined #openstack-heat-translator | 20:50 | |
| *** bobh has quit IRC | 21:23 | |
| *** spzala has quit IRC | 21:43 | |
| *** bobh has joined #openstack-heat-translator | 23:05 | |
| *** bobh has quit IRC | 23:43 | |
| *** bobh has joined #openstack-heat-translator | 23:47 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!