Thursday, 2015-10-01

*** bobh has joined #openstack-heat-translator00:41
*** jruano has quit IRC00:43
*** sridhar_ram has quit IRC01:46
*** jruano has joined #openstack-heat-translator01:47
*** bobh has quit IRC02:00
*** bobh has joined #openstack-heat-translator02:10
*** topol has joined #openstack-heat-translator02:51
*** topol has quit IRC03:10
*** spzala has quit IRC03:34
*** bobh has quit IRC03:54
*** jruano has quit IRC03:54
*** topol has joined #openstack-heat-translator03:56
*** topol has quit IRC04:12
*** topol has joined #openstack-heat-translator04:13
*** topol has quit IRC05:07
openstackgerritVahid Hashemian proposed openstack/heat-translator: Fix translation issue with interface inputs and functions  https://review.openstack.org/20629505:20
*** topol has joined #openstack-heat-translator05:31
*** topol has quit IRC05:35
*** vahidh has quit IRC07:29
*** openstackgerrit has quit IRC07:46
*** openstackgerrit has joined #openstack-heat-translator07:46
*** jruano has joined #openstack-heat-translator08:43
*** jruano has quit IRC09:14
*** topol has joined #openstack-heat-translator10:15
*** topol has quit IRC10:19
*** vahidh has joined #openstack-heat-translator10:49
*** vahidh has quit IRC10:54
*** bobh has joined #openstack-heat-translator12:21
*** bobh has quit IRC12:25
*** spzala has joined #openstack-heat-translator12:31
*** topol has joined #openstack-heat-translator12:36
*** topol has quit IRC12:41
*** vahidh has joined #openstack-heat-translator13:32
*** vahidh has quit IRC13:37
*** jruano has joined #openstack-heat-translator13:57
*** topol has joined #openstack-heat-translator14:03
*** bobh has joined #openstack-heat-translator14:26
*** sridhar_ram has joined #openstack-heat-translator14:36
*** vahidh has joined #openstack-heat-translator14:50
spzalaHi all15:00
vahidho/15:00
spzalavahidh: o/15:00
spzalawho is around? srinivas: meena: ?15:01
vahidhthey don't seem to be online15:01
*** srinivas has joined #openstack-heat-translator15:02
srinivasHi Sahdev & Vahidh15:03
spzalavahidh: true but not any more :-)15:03
spzalaHey Srinivas15:03
vahidhHi Srinivas15:03
spzalaI haven't get chance to request to get into openstack meeting due to some other priorities but will do soon.. next week will give more time to me to work on that15:04
vahidhSounds good. Thanks for the effort :)15:04
spzalabut related good news is my patch on logging this channel is approved and merged so logging is in place now15:04
srinivasHi Vahid. thanks for cyclic import reference.. very well explained15:04
spzala:-) np15:05
spzalaGood Vahid.15:05
vahidhspzala: perfect. great news15:05
vahidhsrinivas: no problem. glad it helped15:05
srinivasgood news15:05
spzalavahidh: srinivas: yep :-) .. if you share the cyclic ref. email with me that would be good..help me with reviewing that patch.15:06
spzalahttp://eavesdrop.openstack.org/irclogs/%23openstack-heat-translator/  just fyi15:06
spzalaAlright, so going with what I have as an agenda15:06
topolHi spzala, quick suggestion15:07
vahidhspzala: you can find the link in the reviews of the patch. I added it in my comment there15:07
spzalatopol: Hi, sure15:07
topolSo when you start a meeting can you type in everyones name that typically attends.  That way we all get pinged when you start15:07
topoljust copy paste it from somewhere15:07
spzalavahidh: Cool, I will get it from there .. thought that was in regard to Srinivas's email on imports15:07
spzalatopol: sure good idea15:08
spzalatopol: will do ;)15:08
topolthanks.  Im easily distracted15:08
spzalatopol: yeah understood :)15:08
spzalaAlright, so going with agenda I have (once we are in meeting channel it will be on-line but for now bear with me)15:09
spzalaPypi packages for parser and translator - since we have reached a good milestone i.e. supporting parsing for CSAR (and CSAR support for translation which may require some tests in progress)15:10
spzalaand there is a need from user to have it, I have created pypi for parser yesterday15:10
spzalahttps://pypi.python.org/pypi/tosca-parser/0.2.015:10
vahidhperfect. thanks Sahdev.15:11
spzalaFor translator - it looks good overall based on Vahid and my testing. And Vahid is adding tests for CSAR in translator. Once that's done we shooting to have pypi for translator by end of week this week15:12
spzalavahidh: thanks and thanks for heavy lifting on CSAR15:12
topolspzala, did you have tagging issue? did you get that fixed?15:12
topolspazala I saw some email15:12
spzalatopol: actually, it's not an issue at all15:13
srinivassahdev & vahid, sounds good15:13
topolspzala oh goodie!15:13
spzalatopol: yup like if you see here https://pypi.python.org/pypi/python-heatclient15:13
vahidhspzala: no problem, it was fun :)15:13
spzalayou notice a similar duplication look like message but I figure that, it's due to README and it's common15:14
topolGood job vahidh! you are the ceasar of CSAR15:14
spzalaLOL agree with topol15:14
vahidhtopol: :) thanks15:14
spzalavahidh: :) glad to know it15:14
spzalasrinivas: thanks15:14
spzalawell going on with round table before we have open discussion. srinivas: good suggestion on a_file flag15:15
srinivassahdev & vahid, i am thinking like it is better to have a small after reaching some milestone15:15
srinivasdemo15:15
spzalasrinivas: vahid: I have replied that email and it makes sense to me... will wait on Vahid's thought on it15:16
vahidhsrinivas: I agree with your suggestion on a_file15:16
vahidhthe thing is when I created that patch it was all under heat-translator15:16
vahidhso a_file was internal15:16
spzalasrinivas: having demo right away speically on a quick release is difficult, but I meant to send and email announcement but I wanted to check on possible tagging issue before that15:16
srinivasdemo after implementing a big feature is a good idea. So everyone understands the usecase. What do all say?15:17
vahidhwhen we broke it into two patches I missed the fact that a_file is now exposed15:17
spzalasrinivas: tagging issue as topol mentioned which I resolved just 10 mins before meeting15:17
srinivasnot immediately.. planned demos . like sprint demo15:17
spzalavahidh: yes internal and in CLI it's not needed to be provided by user but programmatically it does require (e.g. as we have in test methods) so good to handle it and remove that need in future15:18
spzalasrinivas: yes that make sense15:18
spzalasrinivas: we will be trying to have something ready around summit time15:18
srinivasok sahdev. thanks15:19
vahidhspzala: yes I agree, but again this will impact heat-translator since it makes call to ToscaTemplate, so will have to plan carefully15:19
spzalasrinivas: yrw15:19
spzalavahidh: that's true, we will handle it so that no backward compatibility is broken15:20
vahidhspzala: yes, we need to take that into consideration15:20
spzalavahidh: I am not suggesting any changes in 0.2.0 but in future.15:20
vahidhspzala: yes, understood :)15:20
spzalavahidh:  yup and this should be easy to handle in parser side :)15:21
vahidhspzala: yes, I'm thinking just need to move the code that detects the format from heat-translator to tosca-parser15:21
srinivasHi All, What is the issue?15:22
spzalavahidh: sure.15:22
vahidhsrinivas: we are discussing how to handle the a_file issue that you brought up15:22
srinivasi could not able to follow15:22
srinivasok.15:22
spzalasrinivas: it's handling URL in toscatemplate class15:22
spzalaI think we are good on that. Good suggestion srinivas15:23
spzalamoving on15:23
srinivasyrw15:23
spzalasrinivas: how's going overall? anything from you? policy? group? imports?15:23
srinivasimports.. i already sent patch for review.15:23
spzalasrinivas: I know all under progress and for imports I guess new patch coming soon15:23
spzalasrinivas: nice15:24
srinivasI will try for next patch with cyclic imports by tomorrow15:24
spzalasrinivas: yeah, that's what I meant by new patch .. cool15:24
spzalasrinivas: other than that patch looks good15:24
srinivasbtw.. next 2 weeks i might be busy.. I am applying US BV next week.. might be travelling on oct11 to San jose15:24
spzalasrinivas: sure, np vahidh is in valley not sure if you guys can meet f2f but good if can :-)15:25
vahidhsrinivas: nice, business trip?15:25
srinivasyes.15:25
srinivasplease provide your contact numbers.. If possible, we will meet15:25
vahidhyup, we can try to set up something to meet face to face if time allows15:26
srinivaswill be there in san jose for 1 week15:26
vahidhjust email me when you're here and we can take it from there15:26
spzalasrinivas: I guess  meena and others will continue contribution? or they traveling too? just wondering?15:26
srinivasno.. they will continue..15:27
srinivassahdev, I too will continue in next week.. whenever i find some free time15:27
srinivas;)15:27
spzalasrinivas: I am in North Carolina (NC) just in case you have any personal trip on this side of US :)15:27
spzalasrinivas: :-) COOL15:27
spzalavahid: and I are trying to finish translator side changes with new parser pypi in next two days. anything else from you vahid: ?15:28
vahidhspzala: not really, you covered it well. I just add that I can now start submitting murano patches that were waiting on pypi release15:29
spzalavahidh: coo, yup, once we have pypi for translator this week getting back on Murano sounds like a plan15:30
vahidhspzala: yes :)15:31
spzala:-)15:31
spzalaopen discussion? any thing anyone wants to talk?15:31
spzalawith our small crowd 30mins meeting time seems perfect, but I will keep it for an hour just in case. ;)15:31
srinivasVahid, can you please brief me on Murano. May be some presentation on next week.. including CSAR.. I don't have idea on these15:31
vahidhsrinivas: murano is another opestack project mainly run by Mirantis. it adds an application catalog to openstack15:32
vahidhit supports HOT and MuranoPL as the two formats for specifying applications that you add to the catalog15:33
vahidhwe want to add TOSCA to its supported formats15:33
vahidhso you can for example take the wordpress or elk CSAR templates and import them into murano application catalog for deployment15:34
srinivasVahidh.. can you plan small demo on this next week.. may be 10mins should be good enough15:34
vahidhsrinivas: not sure, I don't have all the pieces ready yet15:35
srinivasok. whenever we have vahidh..15:35
*** sridhar_ram has quit IRC15:35
vahidhsure, definitely15:35
spzalavahidh: sounds good.15:36
spzalaif nothing else, then we call this a meeting.15:37
vahidhsrinivas: this is the spec for that work: https://review.openstack.org/#/c/194422/15:37
srinivasok vahidh. i will go through it.15:37
srinivasSahdev, expecting demo on CSAR also :-)15:38
spzala:-) sure15:38
spzalaVahid and I have a techtalk submitted for summit, if it goes fine we will have it as part of it but regardless we will create..good to have it.15:39
spzalaaite, I guess we call this a meeting. The channel is open so we can continue informal discussion as we need. Thanks again all!!15:41
vahidhthanks, good meeting15:41
spzalayup :-)15:41
srinivasI am leaving the meeting. bye to Sahdev, Vahidh & Topol15:43
vahidhbye srinivas15:43
*** srinivas has quit IRC15:44
spzalasrinivas: good night!15:44
*** jruano has quit IRC15:53
*** sridhar_ram has joined #openstack-heat-translator15:55
openstackgerritSahdev Zala proposed openstack/heat-translator: Update README  https://review.openstack.org/23000516:26
*** zaneb has quit IRC16:38
*** bobh has quit IRC17:00
*** jruano has joined #openstack-heat-translator17:03
*** bobh has joined #openstack-heat-translator17:15
openstackgerritVahid Hashemian proposed openstack/heat-translator: Fix translation issue with interface inputs and functions  https://review.openstack.org/20629517:21
*** topol has quit IRC17:47
*** jruano has quit IRC18:00
*** topol has joined #openstack-heat-translator18:16
*** topol has quit IRC18:20
*** sridhar_ram has quit IRC18:30
*** openstackgerrit has quit IRC18:31
*** openstackgerrit has joined #openstack-heat-translator18:31
*** topol has joined #openstack-heat-translator18:32
*** topol has quit IRC18:38
openstackgerritMerged openstack/heat-translator: Fix translation issue with interface inputs and functions  https://review.openstack.org/20629519:08
*** zaneb has joined #openstack-heat-translator19:18
*** topol has joined #openstack-heat-translator19:34
openstackgerritSahdev Zala proposed openstack/heat-translator: Update README  https://review.openstack.org/23000519:46
*** topol has quit IRC20:00
openstackgerritVahid Hashemian proposed openstack/heat-translator: Handle URLs for input templates and imports  https://review.openstack.org/21339220:02
openstackgerritMerged openstack/heat-translator: Update trove classifier  https://review.openstack.org/22960420:48
*** sridhar_ram has joined #openstack-heat-translator20:55
openstackgerritVahid Hashemian proposed openstack/heat-translator: Handle URLs for input templates and imports  https://review.openstack.org/21339221:16
*** bobh has quit IRC21:44
*** spzala has quit IRC21:54
*** spzala has joined #openstack-heat-translator21:56
spzalavahidh: there?21:59
spzalavahidh_: there? :-)22:00
vahidhHi spzala22:00
spzalaHey, my sametime is not connecting so just wanted ping that if need to chat anything I am here :-)22:00
spzalaI am reviewing your updated patch22:01
vahidhnp :) I just submitted a follow-on patch for the URL input to address your comments22:01
vahidhthanks. just saw your second line :)22:02
spzala:-) yrw22:04
*** vahidh_ has quit IRC22:06
spzalavahidh: it looks great, the only thing I see is for this file translator/tests/data/tosca_single_instance_wordpress_with_local_abspath_import.yaml - there is no unit test ?22:08
spzalaI know we have a similar file and this one only has abs_path vs relative path - but in order to have all templates tested good to test this one22:09
vahidhthere is one: test_hot_translate_template_by_url_with_local_abspath_import22:10
vahidhthat uses an uploaded version of that file22:10
vahidhwill have to update the link to github once the patch merges22:10
spzalaOk, cool..thx. So that particular test22:13
spzalaexception22:14
spzalastill has toscalib :-)22:14
spzalais it not getting tested? the exception?22:14
*** topol has joined #openstack-heat-translator22:14
spzalavahidh: ^^ :)22:16
spzalavahidh: line 379 ..no rush when you get chance22:17
vahidhsorry, the reason toscalib didn't matter there was the import path was given as an absolute path, and for URLs absolute reference doesn't make sense22:17
vahidhso it fails before even trying the import22:17
vahidhlet me check22:17
vahidhdo you mean:22:18
vahidh           raise Exception(22:19
vahidh                'The unit test that was expected to fail did not fail.')22:19
vahidh?22:19
spzalaok, right but then the assert really doesnt matter ?22:19
vahidhaah! now I see what you mean22:19
spzalano I was wondering,22:19
vahidhshoot. sorry :)22:19
*** topol has quit IRC22:19
spzalaok :-)22:19
spzala:-) np at all22:19
vahidhwill have to resubmit22:20
spzalaOK, sure np.. also before you resubmit22:20
spzalaone more thing22:20
vahidhsure22:21
spzalatranslator/tests/data/tosca_single_instance_wordpress_with_local_abspath_import.yaml what I was saying about test here is - we seems doesn't have test that is testing the output of this template as HOT ?22:21
vahidhyes, I kind of thought that would be redundant because we are just playing around with imports (relative/absolute file paths and urls)22:22
vahidhif you want I can add one quickly22:22
spzalasomething we have for other templates usually22:22
spzalaYup, that's exactly what I was saying earlier22:22
vahidhI'll add it22:23
spzalaso I totally understand, so the only thing is import statement but still we want to make sure that all of our templates are working out of box and we have covered in test22:23
vahidhmakes sense. sure, should be quick adding it22:24
spzalayup, I would have done same as you did but like you said it's just an additional hot file22:24
spzala:-)22:24
spzalaOK, thanks22:24
vahidh:)22:24
vahidhooh, I know why I didn't add that one22:30
vahidhit's because I cannot know what the absolute path to the import wordpress.yaml will be22:31
vahidhit would be different depending on where it's running22:31
vahidhmakes sense spzala?22:32
spzalavahidh: hmmm... so won't it always be /translator/tests/data/custom_types/wordpress.yaml if you use that particular template?22:33
spzalato me, that's why you have provided abs path?22:33
vahidhno, on my machine it's /home/stack/workspace/heat-translator/translator/tests/data/custom_types/wordpress.yaml22:33
spzalaahh true, well in that case it's still a relative path to the project and not an abs path.22:34
vahidhif I use that path on my machine it works, but I don't know what it would look like on jenkins server22:34
spzalasimialr to custom_types/wordpress.yaml22:34
vahidhwell, I didn't know what to use there. the fact that it starts with a '/' would make it an absolute path22:35
spzalatrue, not only jenkins but also anyone's local machine once project was downloaded22:35
vahidhtrue22:35
vahidhbut the feature is there22:35
vahidhfor anyone who wants to try it locally22:35
spzalaOK, well then in the description of template can you please add something like "this template is a test template and uses an absolute path to the project" something like that if that makes sense and you think we convey the right purpose to the user?22:38
spzalaor let's not add it .. I am thinking22:38
spzalaif we can't test in Jenkin's evn. I feel it difficult to add22:38
vahidhif we add it and someone tests it against the hot_Wordpress it would fail since now the description is different22:39
vahidhbut since we are not checking the output here we can add it, jenkins won't complain :)22:39
spzalavahidh: lol22:40
vahidhadd it then?22:40
spzalawell, no let's not do that .. i would rather change description and create a new hot_* yaml and compare it22:40
spzalawhat do you think?22:40
spzalaor what if we don't change the description22:41
spzalabut still add test to compare against hot_Wordpress22:41
vahidhsure, I think the name of the file gives some sort of a clue22:41
vahidhwe can't add test, remember the absolute path thing would fail on jenkins22:41
spzalasure so if create unit test and test against existing hot_Wordpress that will work right? in that case, I am fine keeping it as it is and just add that test method22:42
spzalaI think that covers the testing well22:42
vahidhthe problem is we can't have a unit test for this one22:42
vahidhI can make it working on my machine, but when you download it there is no guarantee it would work on yours22:43
spzalaok, gotcha.. you said that I thought you were saying second time that it will work22:43
vahidhunless you have the file in exactly the same OS path as I do22:43
spzalawell, then let's not add it at all22:43
vahidhnope, sorry if I confused you22:44
spzalathat doesn't cause any problem22:44
spzalaoh no.. no problem at all22:44
vahidhok, then no change with respect to that file (just removing toscalib references)22:44
spzalaas it is, it's just a hanging template for sample purpose I guess?22:44
vahidhyes, plus we have a unit test for it that would fail22:45
vahidhnone that would succeed22:45
spzalaOK, even we have unit test that would succeed (as failure) taht's fine but I don't see in your patch where you are using "tosca_single_instance_wordpress_with_local_abspath_import.yaml" file anywhere?22:46
spzalaunless I am not searching well :(22:46
vahidhyes, because I'm using the URL for it (a box url that would change to github url later on)22:47
spzalathe test method you said earlier doesn't have this file22:47
vahidhif you go to that URL inside the test you'll get the same file22:47
spzalaI understood but where I am confused is:22:47
spzalaok so you are not referencing this file staright in test but the URL you have used is pointing to this file?22:48
vahidhyes22:48
spzalaahhh22:48
spzalasorry i didn't get that part earlier22:48
vahidhbecause I wanted to cover the case where the template is in a URL and it's referencing an import via absolute path, and we need to disallow it22:49
spzalaOK, gotcha.. well, in this case you can sure modify the description right?22:49
vahidhyes22:49
vahidhI'll add a line there to explain the absolute path22:50
spzalaPerfect, then I would modify description that this is a test file used in URL cover this particular test you mentioned.22:50
spzalaGreat.. my fear is someone will use it on CLI or something and complain that it failed22:50
vahidhyes, that could happen :)22:51
spzala:-) yup, and having description will cover us there I believe22:51
spzalaso we are good with it then22:51
vahidhyes, I'll submit shortly22:51
spzalaOK sounds great..thanks vahidh,22:54
vahidhnp spzala22:54
vahidhshould I change the path /translator/tests/data/custom_types/wordpress.yaml to something like /tmp/wordress.yaml?22:55
vahidhor it's good as is?22:55
spzalavahidh: yes that's a good idea22:55
spzalalet's have a path which can also be self readable in abs path sense22:56
vahidhsure, thanks22:56
spzalanp, thank you :-)22:56
vahidhnp :)22:56
openstackgerritVahid Hashemian proposed openstack/heat-translator: Handle URLs for input templates and imports  https://review.openstack.org/21339222:58
spzalavahidh: thanks for the quick update looks Great ..only small thing like 37923:07
spzalavahidh: shouldn't that change to /tmp/wordpress.yaml now?23:08
spzalas/line 379/like 37923:08
vahidhyes :)23:09
vahidhnot sure why it passed on my local machine23:09
vahidhgood catch as always23:09
spzala:-) sure23:09
spzalathanks.. it's minor.. I thought it passed because again due to some URL work you are going to do later? as you mentioned in commit.23:10
vahidhaah, I should have updated the uploaded version too!23:10
spzala:-) OK, thanks vahidh!!!23:11
vahidhnp :) thanks for catching it23:12
spzala:-) np, that was easy.. your quick updates aren't :-)23:12
openstackgerritVahid Hashemian proposed openstack/heat-translator: Handle URLs for input templates and imports  https://review.openstack.org/21339223:12
vahidhno they are easy too :)23:13
vahidhI hope this time we got them all23:13
spzala:-) nah but well. It's great this time.23:14
spzala:-)23:14
vahidh:)23:14
openstackgerritMerged openstack/heat-translator: Handle URLs for input templates and imports  https://review.openstack.org/21339223:28
openstackgerritVahid Hashemian proposed openstack/heat-translator: Add translation of CSAR archives  https://review.openstack.org/23020623:42
*** bobh has joined #openstack-heat-translator23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!