| opendevreview | Merged openstack/glance stable/wallaby: [stable-only] Specify openstacksdk stable branch https://review.opendev.org/c/openstack/glance/+/826740 | 05:52 |
|---|---|---|
| opendevreview | Merged openstack/glance stable/victoria: [stable-only] Specify openstacksdk stable branch https://review.opendev.org/c/openstack/glance/+/826743 | 07:59 |
| *** bhagyashris_ is now known as bhagyashris | 08:01 | |
| *** bhagyashris_ is now known as bhagyashris | 08:53 | |
| opendevreview | Merged openstack/glance stable/ussuri: [stable-only] Specify openstacksdk stable branch https://review.opendev.org/c/openstack/glance/+/826744 | 09:07 |
| tbarron | any glance folks want to join the meeing right now in #openstack-qa on using cephadm in devstack-plugin-ceph? | 15:06 |
| abhishekk | tbarron sorry I missed it was busy in something | 15:44 |
| tbarron | dansmith: no problem, and ty | 15:45 |
| ade_lee__ | rosmaita, abhishekk hey -- all the prereqs to https://review.opendev.org/c/openstack/glance/+/790536 have merged | 16:45 |
| ade_lee__ | would be great to get this in too. | 16:46 |
| abhishekk | ade_lee__, ack, will have a look, thank you | 16:46 |
| ade_lee__ | thanks! | 16:46 |
| rosmaita | nice to see that job working | 16:46 |
| abhishekk | ++ | 16:47 |
| abhishekk | just one question, as we are inheriting from parent job, do we need to redefine variables in child job? | 16:50 |
| abhishekk | for example, https://review.opendev.org/c/openstack/glance/+/790536/35/.zuul.yaml#296 | 16:51 |
| ade_lee__ | abhishekk, I don't think so - I had put them in there - just in case .. | 16:53 |
| ade_lee__ | fungi, ^^ | 16:54 |
| ade_lee__ | abhishekk, I can try without them too and see if it all passes | 16:54 |
| abhishekk | dansmith, ^^ | 16:54 |
| abhishekk | ade_lee__, good idea | 16:54 |
| dansmith | yeah I don't know | 16:55 |
| abhishekk | sorry as it will going to take more time | 16:55 |
| dansmith | I expect they are inherited | 16:55 |
| abhishekk | that is what I am thinking as well | 16:55 |
| ade_lee__ | abhishekk, another way we could do this is to take advantage of https://opendev.org/openstack/tempest/src/branch/master/zuul.d/integrated-gate.yaml#L300-L314 | 16:57 |
| abhishekk | looking | 16:58 |
| abhishekk | you mean adding 'tempest-centos8-stream-fips' as parent ? | 16:59 |
| ade_lee__ | yeah something like that .. | 16:59 |
| abhishekk | that will also do I guess | 17:00 |
| ade_lee__ | or maybe defining tempest-integrated-storage-fips in tempest and inherit from that .. | 17:00 |
| ade_lee__ | abhishekk, many ways to skin the cat as it were .. | 17:01 |
| abhishekk | yep, we should just avoid duplication as much as possible | 17:01 |
| ade_lee__ | abhishekk, ok - I'll poke around a bit and try refactor | 17:03 |
| abhishekk | thank you | 17:04 |
| abhishekk | I will be keeping watch on the patch,everything else is fine | 17:04 |
| fungi | ade_lee__: job variables are inherited but can be overridden, however it looks like what you're asking is whether the dict you're putting in the devstacl_localrc variable will be merged with the dict keys from the parent job's devstack_localrc variable? i think it overwrites the devstack_localrc dict in this case | 17:06 |
| fungi | so it gets fully replaced, not merged with the keys from that variable in the parent | 17:07 |
| abhishekk | ade_lee__, that answers, I guess no need to do anything here | 17:08 |
| abhishekk | thank you fungi! | 17:08 |
| abhishekk | fungi, any difference in 'devstack_localrc' and 'devstack_local_conf' or they both writes to local.conf file? | 17:15 |
| fungi | abhishekk: that's probably more of a question for the devstack folks in #openstack-qa, as they're the ones maintaining that job and the interfaces for it | 17:18 |
| abhishekk | fungi, ack, will post it there | 17:18 |
| fungi | i think devstack_localrc may be a literal inclusion while devstack_local_conf is parsed and iterated over to generate devstack_localrc | 17:18 |
| fungi | but i can't say for sure without digging into the parent job definitions | 17:19 |
| abhishekk | ack, I asked it in qa channel and will try to find out as well, thank you again | 17:19 |
| ade_lee__ | abhishekk, feels like we should merge the jobs as we have them here (because we know they work) and then we can test as a follow up to see if we can refactor | 18:02 |
| abhishekk | ade_lee__, sounds good | 18:02 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!