| *** bkopilov has joined #openstack-glance | 00:00 | |
| *** jessegler has quit IRC | 00:04 | |
| *** gcb has quit IRC | 00:21 | |
| *** bkopilov has quit IRC | 00:54 | |
| *** bkopilov has joined #openstack-glance | 00:57 | |
| *** zzzeek_ has quit IRC | 01:09 | |
| *** zzzeek_ has joined #openstack-glance | 01:11 | |
| *** bkopilov has quit IRC | 01:16 | |
| *** bkopilov has joined #openstack-glance | 01:16 | |
| *** zzzeek_ has quit IRC | 01:33 | |
| *** zzzeek_ has joined #openstack-glance | 01:34 | |
| *** zzzeek_ has quit IRC | 01:36 | |
| *** smatzek has joined #openstack-glance | 01:40 | |
| *** smatzek has quit IRC | 01:41 | |
| *** smatzek has joined #openstack-glance | 01:41 | |
| *** zzzeek_ has joined #openstack-glance | 01:47 | |
| *** smatzek has quit IRC | 01:50 | |
| *** Sukhdev has quit IRC | 01:57 | |
| *** bkopilov has quit IRC | 01:59 | |
| *** gcb has joined #openstack-glance | 02:03 | |
| *** zhurong has joined #openstack-glance | 02:03 | |
| *** namnh has joined #openstack-glance | 03:07 | |
| openstackgerrit | Pengju Jiao proposed openstack/glance master: Fix glance image-download error https://review.openstack.org/460280 | 03:17 |
|---|---|---|
| *** bkopilov has joined #openstack-glance | 03:18 | |
| *** gyee has quit IRC | 03:23 | |
| *** links has joined #openstack-glance | 03:41 | |
| *** udesale has joined #openstack-glance | 03:46 | |
| *** mabrams has joined #openstack-glance | 05:02 | |
| *** aavraham has joined #openstack-glance | 05:02 | |
| *** aavraham has quit IRC | 05:03 | |
| *** aavraham has joined #openstack-glance | 05:04 | |
| *** ratailor has joined #openstack-glance | 05:10 | |
| *** d0ugal has joined #openstack-glance | 05:22 | |
| *** groen692 has joined #openstack-glance | 05:40 | |
| *** rcernin has joined #openstack-glance | 05:41 | |
| *** d0ugal has quit IRC | 05:52 | |
| *** nicolasbock has joined #openstack-glance | 05:55 | |
| *** pcaruana has joined #openstack-glance | 06:04 | |
| *** tshefi has joined #openstack-glance | 06:31 | |
| *** groen692 has quit IRC | 06:32 | |
| *** groen692 has joined #openstack-glance | 06:33 | |
| *** zhurong has quit IRC | 06:40 | |
| *** zhurong has joined #openstack-glance | 06:44 | |
| *** belmoreira has joined #openstack-glance | 06:46 | |
| *** namnh has quit IRC | 06:52 | |
| openstackgerrit | Zhaokun Fu proposed openstack/glance master: replace http with https https://review.openstack.org/457151 | 06:55 |
| *** namnh has joined #openstack-glance | 07:01 | |
| *** tesseract has joined #openstack-glance | 07:02 | |
| *** zhurong has quit IRC | 07:30 | |
| *** openstackgerrit has quit IRC | 07:33 | |
| *** andreykurilin has joined #openstack-glance | 07:44 | |
| andreykurilin | hi folks! | 07:44 |
| andreykurilin | For the last month we have too much failures related to glance | 07:44 |
| *** aarefiev_pto is now known as aarefiev | 07:44 | |
| andreykurilin | in rally gates | 07:44 |
| andreykurilin | I suppose it had happen after moving under uwsgi | 07:45 |
| *** namnh has quit IRC | 07:45 | |
| andreykurilin | the last failure `502 Bad Gateway: Bad Gateway: The proxy server received an invalid: response from an upstream server.: Apache/2.4.18 (Ubuntu) Server at 10.13.185.120 Port 80 (HTTP 502) ` | 07:45 |
| andreykurilin | Can anyone help me to investigate an issue, possible just proper configuration of devsack plugin is required | 07:46 |
| *** markvoelker_ has quit IRC | 07:47 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** zzzeek has joined #openstack-glance | 08:00 | |
| *** namnh has joined #openstack-glance | 08:01 | |
| *** e0ne has joined #openstack-glance | 08:19 | |
| *** mvk has quit IRC | 08:26 | |
| *** zhurong has joined #openstack-glance | 08:27 | |
| *** mvk has joined #openstack-glance | 08:55 | |
| *** zhurong has quit IRC | 09:27 | |
| *** e0ne has quit IRC | 09:31 | |
| *** e0ne has joined #openstack-glance | 09:34 | |
| *** openstackgerrit has joined #openstack-glance | 09:36 | |
| openstackgerrit | Erno Kuvaja proposed openstack/glance master: Add Discovery stub for Image Import https://review.openstack.org/482182 | 09:36 |
| *** mvk has quit IRC | 09:37 | |
| *** links has quit IRC | 09:37 | |
| *** links has joined #openstack-glance | 09:39 | |
| *** links has quit IRC | 09:44 | |
| *** dalgaaf has quit IRC | 09:47 | |
| *** dalgaaf has joined #openstack-glance | 09:47 | |
| *** markvoelker has joined #openstack-glance | 09:48 | |
| *** links has joined #openstack-glance | 09:49 | |
| *** mvk has joined #openstack-glance | 09:51 | |
| *** d0ugal has joined #openstack-glance | 09:52 | |
| *** d0ugal has quit IRC | 09:59 | |
| jokke_ | andreykurilin: I can't remember when last time the NV rally job would have succeeded in glance runs | 10:01 |
| andreykurilin | jokke_: we launchs scenarios of glance in our regular gates | 10:02 |
| andreykurilin | everything was quite stable and I did not see any failures before moving to the uwsgi | 10:02 |
| andreykurilin | the concurrency bigger than 1 kills glance with a big probability | 10:03 |
| jokke_ | hmm-m ... racecondition somewhere? | 10:04 |
| andreykurilin | yes | 10:04 |
| andreykurilin | jokke_: I can share logs of jobs, if needed | 10:05 |
| *** groen692 has quit IRC | 10:06 | |
| andreykurilin | but I couldn't find any usefull there | 10:06 |
| andreykurilin | logs.openstack.org/15/481915/4/gate/gate-rally-dsvm-rally-ubuntu-xenial/ffbf74c/logs | 10:07 |
| andreykurilin | an error- http://logs.openstack.org/15/481915/4/gate/gate-rally-dsvm-rally-ubuntu-xenial/ffbf74c/rally-plot/results.html.gz#/GlanceImages.create_and_get_image/failures | 10:07 |
| *** namnh has quit IRC | 10:08 | |
| *** gcb has quit IRC | 10:13 | |
| *** links has quit IRC | 10:13 | |
| jokke_ | Hmm-m | 10:16 |
| jokke_ | I think we were fighting with the bad gateway responses somewhere else while ago, just can't remember where/what was it | 10:16 |
| *** markvoelker has quit IRC | 10:22 | |
| *** groen692 has joined #openstack-glance | 10:22 | |
| andreykurilin | jokke_: previousy there was another issue | 11:11 |
| *** bkopilov has quit IRC | 11:11 | |
| andreykurilin | https://review.openstack.org/#/c/479366/ | 11:11 |
| andreykurilin | it was 500 InternalError as far as I remember | 11:12 |
| andreykurilin | mtreinish: hi! are you around? | 11:18 |
| *** markvoelker has joined #openstack-glance | 11:20 | |
| *** smatzek has joined #openstack-glance | 11:23 | |
| *** smatzek has quit IRC | 11:24 | |
| *** smatzek has joined #openstack-glance | 11:24 | |
| *** links has joined #openstack-glance | 11:46 | |
| *** ratailor has quit IRC | 11:51 | |
| *** markvoelker has quit IRC | 11:53 | |
| *** links has quit IRC | 11:59 | |
| *** markvoelker has joined #openstack-glance | 12:19 | |
| *** MVenesio has joined #openstack-glance | 12:32 | |
| *** bkopilov has joined #openstack-glance | 12:33 | |
| *** openstackgerrit has quit IRC | 12:47 | |
| *** udesale has quit IRC | 12:58 | |
| *** udesale__ has joined #openstack-glance | 12:58 | |
| *** burgerk has joined #openstack-glance | 13:01 | |
| *** gcb has joined #openstack-glance | 13:32 | |
| *** burgerk has quit IRC | 13:47 | |
| *** d0ugal has joined #openstack-glance | 13:54 | |
| *** jistr is now known as jistr|call | 13:58 | |
| *** d0ugal has quit IRC | 14:00 | |
| *** zzzeek_ has quit IRC | 14:18 | |
| *** zzzeek_ has joined #openstack-glance | 14:21 | |
| *** d0ugal has joined #openstack-glance | 14:25 | |
| *** gyee has joined #openstack-glance | 14:27 | |
| *** d0ugal has quit IRC | 14:31 | |
| *** efried has joined #openstack-glance | 14:34 | |
| efried | jokke_ yt? | 14:34 |
| *** rcernin has quit IRC | 14:38 | |
| *** rcernin has joined #openstack-glance | 14:40 | |
| jokke_ | efried: yes | 14:55 |
| efried | jokke_ https://review.openstack.org/#/c/460280/14 is busted FYI | 14:55 |
| efried | jokke_ I don't claim to be a glance expert, mind you. | 14:55 |
| efried | jokke_ I was going to ask if it would be okay for me to propose a new patch set. | 14:56 |
| jokke_ | efried: ohh ... hmm-m ... are you sure that it's busted ... it looks right for the v1 path | 14:59 |
| efried | jokke_ For the v1 path I think it's good. | 14:59 |
| efried | jokke_ It's the v2 path - the specific thing the bug was trying to fix - that's broken. | 14:59 |
| jokke_ | yeah and that's the whole point for that if..else in the cache there | 14:59 |
| efried | jokke_ AFAICT, nothing ever refers to image_meta.size - only image_meta['size'] (which goes through the __getitem__ shenanigans in ImageTarget). | 15:00 |
| efried | jokke_ That __getitem__ stuff actually resolves the attr on the `target` member, not on the ImageTarget itself. | 15:00 |
| efried | So setting image_meta.size won't result in image_meta['size'] having that value. | 15:01 |
| jokke_ | efried: so the if..else in the cache code does the recognition. If it's ImageTarget we are dealing with v2 path and that handles it. If not then we know that we're dealing with v1 path and handle it correctly again | 15:01 |
| jokke_ | or did I totally misread that | 15:02 |
| efried | jokke_ Right, I'm talking specifically about the v2 path. I don't think setting image_meta.size is the right thing to do. You would need to set image_meta.target.size instead. | 15:02 |
| jokke_ | oh no ... correct if I'm wrong, but it's that 'if _not_' part that flips the logic wrong way around | 15:03 |
| jokke_ | it should work just fine without that not there | 15:03 |
| jokke_ | I think I really misread it | 15:03 |
| efried | jokke_ I'm not debating the conditionals. They're set up correctly. (Though I personally would have done them the other way to avoid the `not`.) | 15:04 |
| efried | jokke_ I'm saying L79 is setting the wrong thing on the ImageTarget. | 15:05 |
| *** mabrams has quit IRC | 15:11 | |
| *** zzzeek_ has quit IRC | 15:12 | |
| *** tshefi has quit IRC | 15:18 | |
| *** rcernin has quit IRC | 15:18 | |
| *** jistr|call is now known as jistr | 15:22 | |
| jokke_ | efried: I'm still missing something here ... let me have another look with full focus what's going on | 15:26 |
| efried | jokke_ Sure thing. Perhaps easiest to explain in the context of the test case... | 15:27 |
| efried | jokke_ https://review.openstack.org/#/c/460280/14/glance/tests/unit/test_cache_middleware.py@364 is asserting on image_meta.size | 15:28 |
| efried | jokke_ But nothing anywhere else in the code base ever refers to image_meta.size - it is only ever used as image_meta['size'] | 15:28 |
| *** catintheroof has joined #openstack-glance | 15:28 | |
| efried | And if you replace that part of the assertion with image_meta['size'], the test fails. | 15:28 |
| efried | Which means the bug ain't fixed. | 15:28 |
| *** zzzeek_ has joined #openstack-glance | 15:30 | |
| *** aavraham has left #openstack-glance | 15:33 | |
| *** e0ne has quit IRC | 15:34 | |
| jokke_ | efried: I hear you ... and by the looks if it if it's ImageTarget that class has only ever target set | 15:37 |
| jokke_ | there is nothing else as object attribute on that object | 15:38 |
| *** belmoreira has quit IRC | 15:38 | |
| *** udesale__ has quit IRC | 15:40 | |
| jokke_ | efried: but setting it as image_meta['size'] should not work on that later case either as ImageTarget does not have __setitem__ defined so that will not be set on the target either, no? | 15:42 |
| efried | jokke_ Correct - assigning to image_meta['size'] doesn't work. | 15:43 |
| efried | jokke_ The way to do it is to assign to image_meta.target.size | 15:43 |
| jokke_ | efried: yes, now we're on same page .... thanks for bearing with me on this | 15:43 |
| efried | jokke_ The change as it stands will "resolve" the bug - in the sense that we no longer see the exception trace, because we're no longer trying to assign with dict syntax. | 15:44 |
| efried | But | 15:44 |
| jokke_ | and only reason why that test does not fail is that it's referring to that size we set on ImageTarget earlier, not to the target objects size attribute | 15:44 |
| efried | It will regress the fix for bug 900959 (mentioned in the comment) because it's not actually setting the size in the right place. | 15:45 |
| openstack | bug 900959 in Glance "Adding remote image when cache enabled results in image having size of 0" [Critical,Fix released] https://launchpad.net/bugs/900959 - Assigned to Eoghan Glynn (eglynn) | 15:45 |
| efried | jokke_ Yes, exactly. | 15:45 |
| jokke_ | yes and that was the part I overlooked ... Thank you! Amazing catch! | 15:45 |
| efried | jokke_ Sure thing. I have the fix in my sandbox - would it be appropriate for me to propose it, or should I let the authors handle it? | 15:47 |
| efried | Looks like Pengju may still be active. I'll follow up in the code comments. | 15:48 |
| jokke_ | efried: I think as Pengju has as much if not even more than me problem to understand what you actually found there, it would be amazing if you post fix and make sure co-authors are in the commit correctly ;) | 15:48 |
| efried | jokke_ Okay. Surely I'd want to make sure the authors are on the same page either way. | 15:49 |
| jokke_ | Maybe the fix for the issue you pointed out helps him understand as well what went wrong in that patch | 15:49 |
| efried | Roger wilco. | 15:50 |
| *** aarefiev is now known as aarefiev_afk | 15:56 | |
| *** openstackgerrit has joined #openstack-glance | 16:01 | |
| openstackgerrit | Eric Fried proposed openstack/glance master: Fix glance image-download error https://review.openstack.org/460280 | 16:01 |
| efried | jokke_ ^^ | 16:01 |
| openstackgerrit | Mike Fedosin proposed openstack/glance master: Satisfy API Reference documentation deleting tags https://review.openstack.org/420038 | 16:36 |
| *** groen692 has quit IRC | 16:52 | |
| *** efried is now known as efried_lunch | 16:58 | |
| *** groen692 has joined #openstack-glance | 17:44 | |
| *** zzzeek_ has quit IRC | 17:46 | |
| *** zzzeek_ has joined #openstack-glance | 17:49 | |
| *** tesseract has quit IRC | 18:25 | |
| *** groen692 has quit IRC | 18:26 | |
| *** nicolasbock has quit IRC | 18:50 | |
| *** efried_lunch is now known as efried | 18:56 | |
| *** mvk has quit IRC | 19:11 | |
| *** MVenesio has quit IRC | 20:25 | |
| *** adisky__ has quit IRC | 20:36 | |
| *** zzzeek_ has quit IRC | 20:49 | |
| *** catintheroof has quit IRC | 21:04 | |
| *** zzzeek_ has joined #openstack-glance | 21:11 | |
| *** smatzek has quit IRC | 21:17 | |
| *** pcaruana has quit IRC | 21:23 | |
| andreykurilin | oh...our gates are blocked, can anyone help with investigation about glance+uwsgi configuration? previously everything was ok | 22:12 |
| *** markvoelker has quit IRC | 22:16 | |
| *** markvoelker has joined #openstack-glance | 22:17 | |
| *** efried is now known as efried_zzz | 22:19 | |
| *** d0ugal has joined #openstack-glance | 23:36 | |
| *** masber has joined #openstack-glance | 23:55 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!