| *** SarathMekala has quit IRC | 00:02 | |
| SridarK_ | yushiro: I was looking at that it seems osc_utils usage has some issues | 00:03 |
|---|---|---|
| yushiro | SridarK_: Thanks. I confirmed that and I found these error are from 'test_network_trunk' | 00:06 |
| yushiro | I fixed Akihiro's utility patch but I forgot to fix network_trunk at that time. | 00:06 |
| *** njohnsto_ has quit IRC | 00:08 | |
| yushiro | I was rushed and I was lacking a little mental concentration. | 00:09 |
| *** _SarathMekala_ has quit IRC | 00:10 | |
| yushiro | I'll fix 'network_trunk' now. | 00:16 |
| SridarK_ | yushiro: ok | 00:23 |
| SridarK_ | yushiro: when i run it locally i was not able to pick up the osc_utils - it complained | 00:24 |
| SridarK_ | can u also run locally in ur env to make sure | 00:24 |
| yushiro | SridarK_: 'run locally' means not UT but use devstack env? | 00:26 |
| SridarK_ | no as UT | 00:26 |
| SridarK_ | not devstack | 00:26 |
| SridarK_ | may be u checked already | 00:26 |
| yushiro | SridarK_: Yes, I can run on my env but I'll try to re-checkout. | 00:27 |
| SridarK_ | ok great | 00:27 |
| SridarK_ | njohnston: mfranc213: http://paste.openstack.org/show/565461/ | 00:44 |
| SridarK_ | on the UT failure - seems like the the test fails as it is not in the ns as expected | 00:45 |
| njohnston | SridarK_: If I pull the current version, does it have all the current fixes, or are there unstaged UT fixes yet? | 00:52 |
| *** vishwanathj has quit IRC | 00:53 | |
| SridarK_ | njohnston: i think mfranc213 got in the fixes | 00:53 |
| SridarK_ | we still have this failure | 00:53 |
| yushiro | SridarK_: I updated python-neutronclient repos and checkout my patch [1]. Then, execute 'tox' and succeeded. | 00:59 |
| SridarK_ | yushiro: ok good fingers crossed on Jenkins | 00:59 |
| njohnston | all right, I figured it out | 01:21 |
| njohnston | the mock was bad | 01:22 |
| njohnston | mock_get_namespaces.return_value = ri.ns_name was the problem | 01:24 |
| njohnston | it needed to be | 01:24 |
| njohnston | mock_get_namespaces.return_value = [ri.ns_name] | 01:24 |
| njohnston | so all tests should pass now, but I am checking pep8 | 01:24 |
| *** chandanc_ has joined #openstack-fwaas | 01:25 | |
| njohnston | ok, pushed another PS, there was a pep8 error | 01:26 |
| njohnston | SridarK_: check it out | 01:26 |
| SridarK_ | njohnston: ok | 01:27 |
| njohnston | thanks! | 01:27 |
| *** chandanc_ has quit IRC | 01:41 | |
| mfranc213 | njohnston: thank you | 02:05 |
| mfranc213 | SridarK: thank you also | 02:05 |
| *** yamamoto_ has joined #openstack-fwaas | 02:14 | |
| *** mickeys has quit IRC | 02:36 | |
| *** SarathMekala has joined #openstack-fwaas | 03:11 | |
| *** chandanc_ has joined #openstack-fwaas | 03:11 | |
| chandanc_ | yushiro, i tried to use the CLI but got the following error | 03:16 |
| chandanc_ | ubuntu@devstack4:/opt/stack/python-neutronclient$ openstack firewall group list | 03:16 |
| chandanc_ | WARNING: openstackclient.common.utils is deprecated and will be removed after Jun 2017. Please use osc_lib.utils | 03:16 |
| chandanc_ | Exception raised: cannot import name utils | 03:16 |
| chandanc_ | am i missing something ? | 03:17 |
| yushiro | chandanc_: hmm, maybe you should install 'osc-lib' by pip | 03:17 |
| yushiro | Have you already tried it ? | 03:18 |
| chandanc_ | thanks i will do that | 03:18 |
| chandanc_ | just now | 03:18 |
| yushiro | OK | 03:18 |
| chandanc_ | oh, hold on. the patch was pulled yday | 03:18 |
| chandanc_ | will recheck with the latest patch | 03:18 |
| yushiro | Yes. Jenkins got +1 version | 03:19 |
| chandanc_ | ubuntu@devstack4:/opt/stack/python-neutronclient$ pip list |grep osc-lib | 03:21 |
| chandanc_ | osc-lib (1.1.0) | 03:21 |
| chandanc_ | I am using PS12 | 03:22 |
| chandanc_ | but sill getting the same issue | 03:22 |
| yushiro | You cloned python-neutronclient and applied my latest patch and installed osc-lib, didn't you? | 03:23 |
| chandanc_ | yes | 03:24 |
| chandanc_ | let me check my env, your code looks good | 03:25 |
| yushiro | Please execute 'sudo python setup.py install' in your <path_to>/python-neutronclient/ | 03:25 |
| chandanc_ | Traceback (most recent call last): | 03:27 |
| chandanc_ | File "/usr/local/lib/python2.7/dist-packages/osc_lib/shell.py", line 135, in run | 03:27 |
| chandanc_ | ret_val = super(OpenStackShell, self).run(argv) | 03:27 |
| chandanc_ | File "/usr/local/lib/python2.7/dist-packages/cliff/app.py", line 267, in run | 03:27 |
| chandanc_ | result = self.run_subcommand(remainder) | 03:27 |
| chandanc_ | File "/usr/local/lib/python2.7/dist-packages/osc_lib/shell.py", line 180, in run_subcommand | 03:27 |
| chandanc_ | ret_value = super(OpenStackShell, self).run_subcommand(argv) | 03:27 |
| chandanc_ | File "/usr/local/lib/python2.7/dist-packages/cliff/app.py", line 350, in run_subcommand | 03:27 |
| chandanc_ | subcommand = self.command_manager.find_command(argv) | 03:27 |
| chandanc_ | File "/usr/local/lib/python2.7/dist-packages/cliff/commandmanager.py", line 75, in find_command | 03:27 |
| chandanc_ | cmd_factory = cmd_ep.resolve() | 03:27 |
| chandanc_ | File "/usr/local/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 2255, in resolve | 03:27 |
| chandanc_ | module = __import__(self.module_name, fromlist=['__name__'], level=0) | 03:27 |
| chandanc_ | File "/opt/stack/python-neutronclient/neutronclient/osc/v2/fwaas/firewallgroup.py", line 21, in <module> | 03:27 |
| chandanc_ | from neutronclient.osc import utils as osc_utils | 03:27 |
| chandanc_ | ImportError: cannot import name utils | 03:27 |
| chandanc_ | openstack firewall group list --debug | 03:27 |
| yushiro | Is your python-neutronclient repository included following commits? | 03:28 |
| yushiro | 04053c5e30913b518e6cf92b060dd77f75ae88e7 | 03:28 |
| chandanc_ | no | 03:29 |
| yushiro | My patch depends on ^^^ commit. | 03:31 |
| chandanc_ | oh ok | 03:31 |
| SarathMekala | yushiro : I have brought up my setup and am running UT for the CLI. I am also hitting same issue | 03:31 |
| SarathMekala | stack@bng-vhost218-scbg:/tmp/python-neutronclient$ python -m testtools.run neutronclient.tests.unit.osc.v2.fwaas.test_firewallgroup.py | 03:31 |
| SarathMekala | Tests running... | 03:31 |
| SarathMekala | ====================================================================== | 03:31 |
| SarathMekala | ERROR: unittest2.loader._FailedTest.test_firewallgroup | 03:31 |
| SarathMekala | ---------------------------------------------------------------------- | 03:31 |
| SarathMekala | Traceback (most recent call last): | 03:31 |
| SarathMekala | ImportError: Failed to import test module: test_firewallgroup | 03:31 |
| SarathMekala | Traceback (most recent call last): | 03:31 |
| SarathMekala | File "/usr/local/lib/python2.7/dist-packages/unittest2/loader.py", line 172, in loadTestsFromName | 03:31 |
| SarathMekala | module = __import__(module_name) | 03:31 |
| SarathMekala | File "neutronclient/tests/unit/osc/v2/fwaas/test_firewallgroup.py", line 21, in <module> | 03:32 |
| SarathMekala | from neutronclient.osc import utils as osc_utils | 03:32 |
| SarathMekala | ImportError: cannot import name utils | 03:32 |
| yushiro | SarathMekala and chandanc_: I recommend you should 'checkout' my patch not 'cherry-pick'. | 03:32 |
| SarathMekala | I too dont see the commit 04053c5e30913b518e6cf92b060dd77f75ae88e7 in my git log | 03:32 |
| yushiro | If you do 'checkout', dependency commits are included. | 03:33 |
| yushiro | On other way, you should cherry-pick 04053c5e30913b518e6cf92b060dd77f75ae88e7 and rebase. | 03:33 |
| yushiro | Both ways are same result. | 03:33 |
| chandanc_ | openstack firewall group list | 03:36 |
| chandanc_ | WARNING: openstackclient.common.utils is deprecated and will be removed after Jun 2017. Please use osc_lib.utils | 03:36 |
| chandanc_ | Row has incorrect number of values, (actual) 0!=4 (expected) | 03:36 |
| chandanc_ | yushiro, now hitting this | 03:36 |
| *** mickeys has joined #openstack-fwaas | 03:37 | |
| yushiro | Row has incorrect number of values, (actual) 0!=4 (expected) | 03:39 |
| yushiro | Is this an error msg? | 03:39 |
| chandanc_ | ya | 03:39 |
| chandanc_ | similar for rule list | 03:39 |
| chandanc_ | ubuntu@devstack4:/opt/stack/python-neutronclient$ openstack firewall rule list | 03:40 |
| chandanc_ | WARNING: openstackclient.common.utils is deprecated and will be removed after Jun 2017. Please use osc_lib.utils | 03:40 |
| chandanc_ | Row has incorrect number of values, (actual) 0!=3 (expected) | 03:40 |
| yushiro | Thanks. I'll find some errors. | 03:41 |
| chandanc_ | sure yushiro | 03:41 |
| chandanc_ | I will be away for breakfast | 03:41 |
| chandanc_ | catch you soon | 03:41 |
| *** mickeys has quit IRC | 03:42 | |
| SridarK_ | chandanc_: hi | 03:45 |
| SridarK_ | yes i also ran into the osc utils issues - which yushiro clarified | 03:45 |
| chandanc_ | Hello SridarK_ | 03:45 |
| chandanc_ | Ya, just gave the trace to yushiro | 03:46 |
| SridarK_ | sorry just saw u are out for breakfast | 03:46 |
| chandanc_ | basically running with --debug | 03:46 |
| SridarK_ | let me also grab some dinner | 03:46 |
| chandanc_ | not yet :) | 03:46 |
| chandanc_ | will go | 03:46 |
| SridarK_ | ok i will talk to u after :-) | 03:46 |
| SridarK_ | i want to validate the agent ext patch | 03:47 |
| chandanc_ | sure | 03:47 |
| SridarK_ | we ran into some issues with v1, which njohnston & mfranc213 fixed | 03:47 |
| chandanc_ | will ping | 03:47 |
| SridarK_ | yes talk in a bit | 03:47 |
| *** chandanc_ is now known as chandanc_afk | 03:47 | |
| SarathMekala | yushiro, after checking out the PS UT is running fine for the CLI in my dev env | 03:48 |
| SarathMekala | stack@bng-vhost218-scbg:/tmp/python-neutronclient$ tox -e py27 neutronclient.tests.unit.osc.v2.fwaas | 03:48 |
| SarathMekala | py27 develop-inst-nodeps: /tmp/python-neutronclient | 03:48 |
| SarathMekala | py27 installed: appdirs==1.4.0,Babel==2.3.4,cffi==1.7.0,cliff==2.2.0,cmd2==0.6.8,coverage==4.2,cryptography==1.5,debtcollector==1.8.0,docutils==0.12,enum34==1.1.6,extras==1.0.0,fasteners==0.14.1,fixtures==3.0.0,flake8==2.2.4,funcsigs==1.0.2,functools32==3.2.3.post2,hacking==0.10.2,idna==2.1,ipaddress==1.0.16,iso8601==0.1.11,Jinja2==2.8,jsonpatch==1.14,jsonpointer==1.10,jsonschema==2.5.1,keystoneauth1==2.12.1,linecache2==1.0.0,MarkupSafe==0.2 | 03:48 |
| SarathMekala | 3,mccabe==0.2.1,mock==2.0.0,monotonic==1.2,mox3==0.18.0,msgpack-python==0.4.8,netaddr==0.7.18,netifaces==0.10.5,-e git+https://git.openstack.org/openstack/requirements@f44746275ea711ca67089a145c831b1071a5fb1a#egg=openstack.requirements,openstacksdk==0.9.4,os-client-config==1.18.0,os-testr==0.7.0,osc-lib==1.1.0,oslo.concurrency==3.14.0,oslo.config==3.17.0,oslo.context==2.9.0,oslo.i18n==3.9.0,oslo.log==3.16.0,oslo.serialization==2.13.0,oslo.ut | 03:48 |
| SarathMekala | ils==3.16.0,oslosphinx==4.7.0,oslotest==2.10.0,packaging==16.7,paramiko==2.0.2,Parsley==1.3,pbr==1.10.0,pep8==1.5.7,positional==1.1.1,prettytable==0.7.2,pyasn1==0.1.9,pycparser==2.14,pyflakes==0.8.1,Pygments==2.1.3,pyinotify==0.9.6,pyOpenSSL==16.1.0,pyparsing==2.1.8,python-cinderclient==1.8.0,python-dateutil==2.5.3,python-glanceclient==2.5.0,python-keystoneclient==3.5.0,python-mimeparse==1.5.2,-e git+https://github.com/openstack/python-neutr | 03:48 |
| SarathMekala | onclient.git@9ce8013cd50fb032f2fe99e1940367e4953c0458#egg=python_neutronclient,python-novaclient==5.1.0,python-openstackclient==3.1.0,python-subunit==1.2.0,pytz==2016.6.1,PyYAML==3.12,reno==1.8.0,requests==2.11.1,requests-mock==1.0.0,requestsexceptions==1.1.3,retrying==1.3.3,rfc3986==0.4.1,simplejson==3.8.2,six==1.10.0,Sphinx==1.2.3,stevedore==1.17.1,tempest==12.1.0,testrepository==0.0.20,testscenarios==0.5.0,testtools==2.2.0,traceback2==1.4 | 03:48 |
| SarathMekala | .0,unicodecsv==0.14.1,unittest2==1.1.0,urllib3==1.16,warlock==1.2.0,wrapt==1.10.8 | 03:48 |
| SarathMekala | py27 runtests: PYTHONHASHSEED='3713653351' | 03:48 |
| SarathMekala | py27 runtests: commands[0] | sh -c find . -type d -name '.?*' -prune -o \( -type d -name '__pycache__' -o -type f -name '*.py[co]' \) -print0 | xargs -0 rm -rf | 03:48 |
| SarathMekala | py27 runtests: commands[1] | python setup.py testr --testr-args=neutronclient.tests.unit.osc.v2.fwaas | 03:48 |
| SarathMekala | running testr | 03:48 |
| SarathMekala | running=OS_STDOUT_CAPTURE=1 OS_STDERR_CAPTURE=1 ${PYTHON:-python} -m subunit.run discover -t ./ ${OS_TEST_PATH:-./neutronclient/tests/unit} --list | 03:48 |
| SarathMekala | running=OS_STDOUT_CAPTURE=1 OS_STDERR_CAPTURE=1 ${PYTHON:-python} -m subunit.run discover -t ./ ${OS_TEST_PATH:-./neutronclient/tests/unit} --load-list /tmp/tmpy5QsZj | 03:48 |
| SarathMekala | running=OS_STDOUT_CAPTURE=1 OS_STDERR_CAPTURE=1 ${PYTHON:-python} -m subunit.run discover -t ./ ${OS_TEST_PATH:-./neutronclient/tests/unit} --load-list /tmp/tmpxnERXw | 03:48 |
| SarathMekala | running=OS_STDOUT_CAPTURE=1 OS_STDERR_CAPTURE=1 ${PYTHON:-python} -m subunit.run discover -t ./ ${OS_TEST_PATH:-./neutronclient/tests/unit} --load-list /tmp/tmp_P2lUq | 03:49 |
| SarathMekala | running=OS_STDOUT_CAPTURE=1 OS_STDERR_CAPTURE=1 ${PYTHON:-python} -m subunit.run discover -t ./ ${OS_TEST_PATH:-./neutronclient/tests/unit} --load-list /tmp/tmpn0IPrA | 03:49 |
| SarathMekala | running=OS_STDOUT_CAPTURE=1 OS_STDERR_CAPTURE=1 ${PYTHON:-python} -m subunit.run discover -t ./ ${OS_TEST_PATH:-./neutronclient/tests/unit} --load-list /tmp/tmpLMhEon | 03:49 |
| SarathMekala | running=OS_STDOUT_CAPTURE=1 OS_STDERR_CAPTURE=1 ${PYTHON:-python} -m subunit.run discover -t ./ ${OS_TEST_PATH:-./neutronclient/tests/unit} --load-list /tmp/tmpcbksxJ | 03:49 |
| SarathMekala | running=OS_STDOUT_CAPTURE=1 OS_STDERR_CAPTURE=1 ${PYTHON:-python} -m subunit.run discover -t ./ ${OS_TEST_PATH:-./neutronclient/tests/unit} --load-list /tmp/tmp5RzeK_ | 03:49 |
| SarathMekala | running=OS_STDOUT_CAPTURE=1 OS_STDERR_CAPTURE=1 ${PYTHON:-python} -m subunit.run discover -t ./ ${OS_TEST_PATH:-./neutronclient/tests/unit} --load-list /tmp/tmp7S99HQ | 03:49 |
| SarathMekala | Ran 72 tests in 1.038s (-0.794s) | 03:49 |
| SarathMekala | PASSED (id=5) | 03:49 |
| SarathMekala | ____________________________________________________________________________________________ summary ____________________________________________________________________________________________ | 03:49 |
| SarathMekala | py27: commands succeeded | 03:49 |
| SarathMekala | congratulations :) | 03:49 |
| SarathMekala | yushiro, is there any way to get the names of the test cases taht got executed? | 03:49 |
| yushiro | SarathMekala: Sorry. Would you use http://paste.openstack.org/ ? | 03:50 |
| yushiro | if you want to specify some method, you should execute as follows: | 03:50 |
| yushiro | ./.tox/py35/bin/python -m unittest neutronclient.tests.unit.osc.v2.fwaas.test_firewallgroup | 03:51 |
| yushiro | tox -e py35 neutronclient.tests.unit.osc.v2.fwaas.test_firewallgroup | 03:51 |
| yushiro | 'python' command is faster than 'tox' but 'tox' smiles :) | 03:53 |
| *** yamamoto_ has quit IRC | 04:23 | |
| *** chandanc_afk is now known as chandanc_ | 04:24 | |
| chandanc_ | Hello SridarK_ | 04:25 |
| yushiro | chandanc_: my devstack env cannot control fwaas v2 resources via 'openstack' command... | 04:29 |
| yushiro | chandanc_: Therefore, I re-build devstack. | 04:29 |
| chandanc_ | oh | 04:29 |
| yushiro | chandanc_: Is there any additional conf in local.conf ? | 04:30 |
| chandanc_ | let me share my local.fonf | 04:30 |
| chandanc_ | hold on | 04:30 |
| yushiro | please paste http://paste.openstack.org/ | 04:30 |
| chandanc_ | the devstack doesnot bringup fwaas_v2 | 04:30 |
| chandanc_ | i have configured neutron with the service plugin and agent side config manually | 04:31 |
| chandanc_ | in neutron.conf service_plugins = firewall_v2,neutron.services.l3_router.l3_router_plugin.L3RouterPlugin | 04:33 |
| yushiro | OK. thanks. | 04:34 |
| chandanc_ | http://paste.openstack.org/show/565619/ | 04:36 |
| chandanc_ | the l3 agent config | 04:36 |
| chandanc_ | SridarK_, ping | 04:36 |
| yushiro | Thanks, chandanc_ | 04:37 |
| *** yamamoto_ has joined #openstack-fwaas | 04:39 | |
| chandanc_ | yushiro, do you think the error i got in CLI is due to my devstack environment ? or is there some issue in the code ? | 04:45 |
| yushiro | I think code has some issue. | 04:46 |
| chandanc_ | ok, I will wait for next PS | 04:47 |
| yushiro | Hove you tried 'create' method? | 04:47 |
| *** yamamoto_ has quit IRC | 04:49 | |
| chandanc_ | no haven't | 04:53 |
| chandanc_ | let me try that | 04:53 |
| *** carl_baldwin has quit IRC | 05:03 | |
| *** dougwig has quit IRC | 05:03 | |
| *** asingh has quit IRC | 05:03 | |
| chandanc_ | (client) ubuntu@devstack4:~/WA/venv/client/src/python-neutronclient-orig$ openstack firewall rule create --destination-ip-address 20.20.20.0/24 --destination-port 80 --action allow | 05:04 |
| chandanc_ | WARNING: openstackclient.common.utils is deprecated and will be removed after Jun 2017. Please use osc_lib.utils | 05:04 |
| chandanc_ | 'Namespace' object has no attribute 'public' | 05:04 |
| *** asingh has joined #openstack-fwaas | 05:04 | |
| *** carl_baldwin has joined #openstack-fwaas | 05:04 | |
| *** dougwig has joined #openstack-fwaas | 05:07 | |
| SridarK_ | chandanc_: hi | 05:31 |
| *** yamamoto_ has joined #openstack-fwaas | 05:34 | |
| *** mickeys has joined #openstack-fwaas | 05:40 | |
| *** mickeys has quit IRC | 05:44 | |
| *** AndChat596400 has joined #openstack-fwaas | 05:48 | |
| yushiro | ping njohnston | 05:48 |
| yushiro | Thanks for your comment policy.json | 05:49 |
| yushiro | As armax says, we should close own repository for policy.json | 05:49 |
| AndChat596400 | Sridark sorry I came out of office for some work | 05:49 |
| AndChat596400 | On mobile | 05:50 |
| AndChat596400 | Plz send me a mail | 05:50 |
| AndChat596400 | Chandan | 05:51 |
| SarathMekala | yushiro, I did not understand what armax said | 05:52 |
| yushiro | SarathMekala: I think fwaas policy definition should be managed into neutron-fwaas repository. | 05:53 |
| SarathMekala | does he mean that the policy.json should be inside fwaas | 05:53 |
| SarathMekala | ok | 05:53 |
| SarathMekala | so will fwaas attributes get injected into /ect/policy.json | 05:54 |
| yushiro | but, as njohnston says, there is no feature to merge definition with neutron's policy.json. | 05:54 |
| SarathMekala | or is there any extension mechanism :) | 05:55 |
| yushiro | SarathMekala, Yes, in the future, we should remove policy definitions for fwaas and re-define into own repository. | 05:55 |
| SarathMekala | ok.. but how do they get used... | 05:56 |
| SarathMekala | after separation | 05:56 |
| SarathMekala | its an area to think through i think | 05:57 |
| yushiro | As you said, we need some extension mechanism. | 05:58 |
| SarathMekala | ok.. sound good :) | 05:59 |
| yushiro | chandanc_: | 06:01 |
| yushiro | I built devstack and tried to use CLI. | 06:02 |
| yushiro | firewall group create succeeded but list dosn't work. | 06:02 |
| yushiro | I'll investigate more. | 06:02 |
| AndChat596400 | Thanks yushiro | 06:05 |
| *** AndChat596400 has quit IRC | 06:08 | |
| *** AndChat596400 has joined #openstack-fwaas | 06:08 | |
| yushiro | chandanc_,: I found the issue. I'll fixing now. | 06:38 |
| *** mickeys has joined #openstack-fwaas | 06:40 | |
| *** mickeys has quit IRC | 06:45 | |
| *** chandanc_ has quit IRC | 06:50 | |
| AndChat596400 | Cool yushiro | 07:10 |
| *** AndChat596400 has quit IRC | 07:15 | |
| *** AndChat596400 has joined #openstack-fwaas | 07:31 | |
| *** mickeys has joined #openstack-fwaas | 07:39 | |
| *** AndChat|596400 has joined #openstack-fwaas | 07:42 | |
| *** AndChat596400 has quit IRC | 07:43 | |
| *** AndChat|596400 has quit IRC | 07:47 | |
| *** AndChat596400 has joined #openstack-fwaas | 07:47 | |
| *** mickeys has quit IRC | 07:56 | |
| *** mickeys has joined #openstack-fwaas | 08:10 | |
| *** mickeys has quit IRC | 08:11 | |
| yushiro | Hi, I'm fixing CLI patch and I found issue for pluginv2 - firewall-rule | 08:14 |
| yushiro | When updating firewall_rule, following error occurred. | 08:14 |
| yushiro | https://github.com/openstack/neutron-fwaas/blob/master/neutron_fwaas/services/firewall/fwaas_plugin_v2.py#L342 | 08:14 |
| yushiro | TRACE neutron.api.v2.resource KeyError: 'firewall_policy_id' | 08:15 |
| SarathMekala | ls | 08:15 |
| SridarK_ | yushiro: ok yes that is a bug, i have a bug opened to fix add some ut and fix some issues around rules | 08:28 |
| SridarK_ | i will track this | 08:28 |
| yushiro | SridarK_: I see. thanks. | 08:29 |
| SridarK_ | yushiro: i think u can continue and let this not stop the CLI | 08:29 |
| yushiro | Yes, still continue. and thanks for your e-mail to armax | 08:30 |
| SridarK_ | ok | 08:39 |
| *** chandanc_ has joined #openstack-fwaas | 08:49 | |
| chandanc_ | Sorry guys | 08:49 |
| chandanc_ | I am back | 08:49 |
| *** jhesketh_ has joined #openstack-fwaas | 08:54 | |
| *** AndChat596400 has quit IRC | 08:58 | |
| *** jhesketh has quit IRC | 08:58 | |
| *** malos has quit IRC | 08:58 | |
| *** malos has joined #openstack-fwaas | 08:59 | |
| SridarK_ | ah chandanc_ | 09:02 |
| SridarK_ | ok just sent an email | 09:02 |
| chandanc_ | Sorry SridarK_ | 09:02 |
| SridarK_ | oh pls no worries | 09:02 |
| SridarK_ | quick call ? | 09:02 |
| chandanc_ | sure | 09:02 |
| *** AndChat596400 has joined #openstack-fwaas | 09:03 | |
| *** yamamoto_ has quit IRC | 10:02 | |
| *** jhesketh_ is now known as jhesketh | 10:20 | |
| *** yamamoto has joined #openstack-fwaas | 10:43 | |
| njohnston | OK, we need to land 355576 ASAP: https://review.openstack.org/#/c/364223/ | 10:44 |
| njohnston | Good morning, by the way. :-) | 10:44 |
| chandanc_ | working on it | 10:45 |
| njohnston | chandanc_: thanks! | 10:48 |
| njohnston | yushiro: How goes https://review.openstack.org/351582 - I asw Akihiro had some feedback? | 10:49 |
| *** SarathMekala has quit IRC | 10:51 | |
| yushiro | njohnston: Yes, I asked him to review and got some comments. I'm now reflecting. | 10:51 |
| chandanc_ | njohnston, I will have to leave for home now, office cab | 10:51 |
| *** yamamoto has quit IRC | 10:52 | |
| chandanc_ | i am having trouble bringing up the l3 agent with v1 | 10:52 |
| chandanc_ | Can you also look in parallel | 10:52 |
| chandanc_ | i will login back in an hour | 10:53 |
| njohnston | sure thing | 10:53 |
| chandanc_ | thanks njohnston | 10:53 |
| njohnston | yushiro: When amotoki said, "yushiro: I think you don't need to hurry. the feature is not targeted to Newton." was he saying that he thinks FWaaS v2 is not targeted for Newton? | 10:57 |
| yushiro | njohnston: I don't believe it but he does. I strongly work to integrate fwaasv2 in Newton. | 10:59 |
| *** yamamoto has joined #openstack-fwaas | 11:00 | |
| *** chandanc_ has quit IRC | 11:02 | |
| *** AndChat596400 has quit IRC | 11:08 | |
| *** AndChat596400 has joined #openstack-fwaas | 11:08 | |
| *** chandanc_ has joined #openstack-fwaas | 11:18 | |
| *** AndChat|596400 has joined #openstack-fwaas | 11:26 | |
| yushiro | njohnston: thanks for your follow. | 11:28 |
| njohnston | Sure thing. More communication is always better. | 11:28 |
| yushiro | yeah. | 11:28 |
| yushiro | I'd like to communicate more easily in English.. | 11:29 |
| *** AndChat596400 has quit IRC | 11:29 | |
| *** chandanc_ has quit IRC | 11:30 | |
| yushiro | I'm practicing English web training. I hope I can talk to you more smart at the Summit(If I can go there) | 11:30 |
| njohnston | I think your English is quite nice. :-) | 11:34 |
| yushiro | Thanks. It is very confortable for me to talk to FWaaS members. | 11:35 |
| *** chandanc_ has joined #openstack-fwaas | 11:39 | |
| chandanc_ | njohnston, i am still on the way, but after the entrypoints are configured the l3 agent load is failing due to difference in the extension class http://paste.openstack.org/show/565673/ | 11:39 |
| njohnston | chandanc_: Thanks! I will make those changes and update the patch. | 11:43 |
| chandanc_ | sure, I think you have a better handle of the agent side. | 11:44 |
| *** chandanc_ has quit IRC | 12:08 | |
| *** AndChat|596400 has quit IRC | 12:10 | |
| *** yamamoto has quit IRC | 12:11 | |
| *** yamamoto has joined #openstack-fwaas | 12:13 | |
| njohnston | For some reason, my devstack doesn't seem to want to find the v1 plugin; I am getting "ImportError: Plugin 'firewall' not found." and my usual tricks don't seem to be working | 12:15 |
| *** yamamoto has quit IRC | 12:16 | |
| *** yamamoto has joined #openstack-fwaas | 12:26 | |
| njohnston | yushiro SridarK_ xgerman: request for reviews on https://review.openstack.org/#/c/362342/ | 12:40 |
| yushiro | njohnston: sure. I'll check it now. | 12:41 |
| yushiro | ok, LGTM | 12:44 |
| yushiro | Thank you for update. | 12:45 |
| *** yamamoto has quit IRC | 12:57 | |
| mfranc213 | hello | 13:03 |
| mfranc213 | unfortunately i am traveling today and tomorrow. i will be away from keyboard most of the time. | 13:04 |
| SridarK_ | Hi all | 13:05 |
| SridarK_ | njohnston: looks like 362342 is in | 13:06 |
| *** chandanc_ has joined #openstack-fwaas | 13:17 | |
| SridarK_ | chandanc_: hi | 13:20 |
| chandanc_ | hello SridarK_ | 13:20 |
| njohnston | back online from my office | 13:20 |
| chandanc_ | still working | 13:20 |
| SridarK_ | njohnston: hi | 13:20 |
| njohnston | SridarK_: hi! | 13:22 |
| chandanc_ | SridarK_, njohnston I am now stuck at tenent/project_id issue, looks like the l3 ext expects project_id but v1 plugin return tenant_id | 13:23 |
| SridarK_ | oh boy | 13:23 |
| SridarK_ | i thought we can still use them interchangeably | 13:24 |
| chandanc_ | no the l3 ext framework expects project_id | 13:25 |
| chandanc_ | 50 def get_routers_in_project(self, project_id): | 13:25 |
| chandanc_ | 51 """Given a project_id, return a list of routers that are all in | 13:25 |
| chandanc_ | 52 the given project. Returns empty list if the project_id provided | 13:25 |
| chandanc_ | 53 doesn't evaluate to True. | 13:25 |
| chandanc_ | 54 """ | 13:25 |
| chandanc_ | 55 if project_id: | 13:25 |
| chandanc_ | 56 return [ri for ri in self._router_info.values() | 13:25 |
| chandanc_ | 57 if ri.router['project_id'] == project_id] | 13:25 |
| chandanc_ | we cannot change that, so we have to probably change v1 plugin ? | 13:26 |
| *** yamamoto has joined #openstack-fwaas | 13:26 | |
| SridarK_ | ok | 13:27 |
| *** yamamoto has quit IRC | 13:27 | |
| SridarK_ | but the v2 plugin also uses tenant_id | 13:28 |
| SridarK_ | so i am a bit confused | 13:29 |
| chandanc_ | let me do one test and get back | 13:29 |
| SridarK_ | ok | 13:30 |
| *** yamamoto has joined #openstack-fwaas | 13:30 | |
| *** yamamoto has quit IRC | 13:32 | |
| *** yamamoto has joined #openstack-fwaas | 13:33 | |
| *** yamamoto has quit IRC | 13:34 | |
| *** yamamoto has joined #openstack-fwaas | 13:34 | |
| *** yamamoto has quit IRC | 13:34 | |
| SridarK_ | njohnston: in https://review.openstack.org/#/c/355576/33/setup.cfg L#48, should that be fwaas = .... | 13:36 |
| SridarK_ | as in l3_agent.ini we are setting extensions = fwaas | 13:37 |
| njohnston | ok, so that should say fwaas and fwaas_v2 instead of firewall and firewall_v2 there? | 13:38 |
| *** diogogmt has quit IRC | 13:39 | |
| SridarK_ | njohnston: yes that is fine too, chandanc_: pls comment as well | 13:39 |
| SridarK_ | i think we need to match up on the l3_agent.ini and what we set here | 13:39 |
| njohnston | change to setup.cfg pushed | 13:40 |
| SridarK_ | ok | 13:40 |
| chandanc_ | yes we can use fwaas for v1 | 13:40 |
| chandanc_ | yes it has to matchup the ext name we use in the l3 ini file | 13:41 |
| *** diogogmt has joined #openstack-fwaas | 13:45 | |
| chandanc_ | getting ready to push a change in 10 mins | 13:47 |
| njohnston | chandanc_: Sounds good, be sure to rebase on master | 13:48 |
| chandanc_ | thanks, you saved me aPS | 13:49 |
| *** diogogmt has quit IRC | 13:50 | |
| SridarK_ | chandanc_: did u track down the issue ? | 13:54 |
| chandanc_ | SridarK_, yes i did | 13:58 |
| SridarK_ | ok | 13:58 |
| chandanc_ | but first i need help with the devstack patch | 13:58 |
| SridarK_ | oh ? | 13:58 |
| chandanc_ | can you send me again | 13:58 |
| chandanc_ | i seem to have lost it somehow | 13:59 |
| SridarK_ | i think njohnston already got that | 13:59 |
| chandanc_ | cool | 13:59 |
| chandanc_ | ok then pushing | 13:59 |
| SridarK_ | https://review.openstack.org/#/c/355576/33/devstack/plugin.sh | 14:00 |
| *** yamamoto has joined #openstack-fwaas | 14:00 | |
| xgerman | Hi | 14:05 |
| xgerman | are you guys all set? | 14:05 |
| *** vishwanathj has joined #openstack-fwaas | 14:06 | |
| SridarK_ | xgerman: hi | 14:07 |
| SridarK_ | gettting there we just want to be sure fwaas v1 is default and not broken | 14:07 |
| chandanc_ | Hello SridarK_ , njohnston | 14:07 |
| SridarK_ | chandanc_: yes how does it look, did not want to keep bothering u until the PS got pushed | 14:08 |
| chandanc_ | i pushed in the patch, the l3 ext for v1 seems to load without issue | 14:08 |
| xgerman | SridarK_ sounds good | 14:08 |
| SridarK_ | ok that is good | 14:09 |
| SridarK_ | were u able to do a tempest run ? | 14:09 |
| chandanc_ | there was a issue with the l3 ext framework | 14:09 |
| chandanc_ | SridarK_, no was not able to | 14:09 |
| SridarK_ | ok no i understand | 14:10 |
| SridarK_ | only now we have it loading | 14:10 |
| chandanc_ | ya | 14:11 |
| chandanc_ | some issues with the ext class | 14:11 |
| chandanc_ | one question | 14:12 |
| SridarK_ | ok | 14:12 |
| chandanc_ | the the l3.ext name is fwaas and fwaas_v2 right ? | 14:12 |
| chandanc_ | this is what will go in to the l3 Agent ini | 14:13 |
| SridarK_ | hmm what we set in setup.cfg | 14:13 |
| SridarK_ | let me check | 14:13 |
| chandanc_ | and the same need to be used in the l3 .ini | 14:13 |
| chandanc_ | where we call the plugin as firewall and firewall_v2 | 14:14 |
| SridarK_ | https://review.openstack.org/#/c/355576/36/devstack/plugin.sh - what goes to l3_agent.ini | 14:14 |
| chandanc_ | this is waht goes in neutron.conf | 14:14 |
| SridarK_ | fwaas | 14:14 |
| chandanc_ | yes | 14:14 |
| SridarK_ | no not neutron.conf | 14:14 |
| chandanc_ | i think we are on same page :) | 14:14 |
| SridarK_ | iniset_multiline $Q_L3_CONF_FILE AGENT extension fwaas | 14:14 |
| SridarK_ | ah ok | 14:14 |
| chandanc_ | cool | 14:15 |
| SridarK_ | https://review.openstack.org/#/c/355576/36/setup.cfg | 14:15 |
| SridarK_ | fwaas and fwaas_v2 | 14:15 |
| chandanc_ | but what is firewall_v2 commented out ? | 14:15 |
| chandanc_ | *why | 14:15 |
| SridarK_ | no look at PS36, njohnston has changed it | 14:16 |
| njohnston | I don't see that in https://review.openstack.org/#/c/355576/36/setup.cfg | 14:16 |
| chandanc_ | cool | 14:16 |
| SridarK_ | ok so now all pls pray hard | 14:16 |
| chandanc_ | sorry was on 33 | 14:16 |
| njohnston | OK, so what are the pending issues before we can merge 355576? Is it just jenkins? | 14:17 |
| SridarK_ | i am hoping so | 14:17 |
| chandanc_ | i could not run tempest | 14:17 |
| SridarK_ | chandanc_: can we do a quick test | 14:17 |
| chandanc_ | sure | 14:17 |
| SridarK_ | we can get on a call too | 14:17 |
| chandanc_ | ok | 14:17 |
| SridarK_ | we can try to flush out any issues quickly and try to have a PS that has Jenkins passing and tempest also passing | 14:18 |
| SridarK_ | njohnston: the UT fail is also ok ? | 14:18 |
| njohnston | yushiro: Do you need any assistance with https://review.openstack.org/#/c/351582/ ? | 14:45 |
| yushiro | njohnston: thanks but currently is OK. I'll push next PS 1 hour later. So, please try to use in devstack env. | 14:47 |
| njohnston | yushiro: Here is the new way to have policy.json changes - please take a look: https://review.openstack.org/#/c/364311/ | 14:47 |
| njohnston | when you have a moment, the client takes precedence | 14:48 |
| yushiro | njohnston: wow! we can use policy.d . | 14:48 |
| njohnston | indeed! | 14:48 |
| yushiro | that's sounds good. | 14:49 |
| njohnston | And I can see in devstack, in the devstack/functions-common.py repo, where it gets appended to the main policy.json | 14:49 |
| yushiro | njohnston: perfect. BTW, do you know how we should test with policy.d ? | 14:50 |
| yushiro | s/how we should test/how to test | 14:51 |
| *** diogogmt has joined #openstack-fwaas | 14:51 | |
| njohnston | functionally, stacka devstack and make sure that the resulting /etc/neutron/policy.json includes the fwaas entries | 14:53 |
| yushiro | well, in devstack, I think it makes sense. However, we'll add 'public' attribute and try to verify policy check when creating public resource or updating public resource. | 14:57 |
| yushiro | Please let me check about 'testing' | 14:58 |
| yushiro | I understand fwaas policy will be integrated automatically regarding devstack :) | 14:59 |
| njohnston | :-) | 15:02 |
| njohnston | SridarK_: You are correct, the tempest tests are failing :-[ | 15:05 |
| SridarK_ | njohnston: ok i think once we have a handle on this rpc issue we shd be good | 15:05 |
| njohnston | good | 15:05 |
| *** yamamoto has quit IRC | 15:10 | |
| *** mickeys has joined #openstack-fwaas | 15:14 | |
| *** SarathMekala has joined #openstack-fwaas | 15:44 | |
| *** _SarathMekala_ has joined #openstack-fwaas | 15:47 | |
| *** _SarathMekala_ has quit IRC | 15:47 | |
| njohnston | yushiro: How is the client patch going? I think python-neutronclient will release soon, based on the discussion I am seeing in #openstack-release | 15:47 |
| *** _SarathMekala_ has joined #openstack-fwaas | 15:48 | |
| yushiro | Yes. last 1 Ut! | 15:48 |
| yushiro | 1 test is failure. | 15:48 |
| yushiro | other is OK. | 15:48 |
| *** SarathMekala has quit IRC | 15:51 | |
| njohnston | brb grabbing lunch | 15:58 |
| njohnston | back | 16:02 |
| njohnston | chandanc_ and SridarK_: How are thing going with the RPC debugging? | 16:02 |
| chandanc_ | we had a problem with the db, had to restack | 16:03 |
| chandanc_ | njohnston, i think the devstack settings file is pointing to v2 plugin by default | 16:05 |
| chandanc_ | FWAAS_PLUGIN=${FWAAS_PLUGIN:-firewall_v2} | 16:05 |
| njohnston | I see, it is; should that say 'fwaas' instead? | 16:05 |
| chandanc_ | no firewall | 16:06 |
| njohnston | any other changes that need to be made? | 16:06 |
| chandanc_ | no | 16:06 |
| chandanc_ | i just realized after ther restack | 16:06 |
| njohnston | change pushed | 16:06 |
| chandanc_ | great | 16:07 |
| njohnston | So while N-3 closes today, that doesn't mean that Newton is totally cut. If we have bugs to fix, they can get fixed during the Newton RC-1 timeframe | 16:08 |
| SridarK_ | njohnston: chandanc_: back | 16:08 |
| chandanc_ | ok | 16:09 |
| chandanc_ | i was just starting | 16:09 |
| SridarK_ | ok give me 5 mins - i will get back on the call | 16:09 |
| njohnston | I think we need to look at things with that perspective | 16:09 |
| *** yamamoto has joined #openstack-fwaas | 16:11 | |
| SridarK_ | njohnston: ok i agree on that | 16:15 |
| SridarK_ | lets discuss this more | 16:15 |
| *** yamamoto has quit IRC | 16:15 | |
| yushiro | OK finished! | 16:29 |
| yushiro | I' ll push it now. | 16:29 |
| njohnston | yushiro: excellent! | 16:29 |
| njohnston | yushiro: I haven't seen the push yet... | 16:39 |
| yushiro | njohnston: sorry. I'll be late. I forgot writing releasenote.. | 16:39 |
| yushiro | I just updated. | 16:39 |
| yushiro | Sorry njohnston, I'm not sure about releasenote because of my thin English skill :( | 16:40 |
| yushiro | Please take a look.. | 16:40 |
| njohnston | Did you do 'git review'? I didn't see a message that it was pushed. | 16:40 |
| njohnston | perhaps my IRC is lagged | 16:41 |
| yushiro | me too. that's strange. However the patch is definitely updated. | 16:41 |
| yushiro | Anyway, I updated PS13 | 16:42 |
| njohnston | Thanks! Is Akihiro still around to review, do you know? | 16:43 |
| njohnston | Oh, I didn't see that your change depends on another change - https://review.openstack.org/#/c/348097/ | 16:45 |
| njohnston | so we would need to get both reviewed in order to get yours merged | 16:45 |
| *** yamamoto has joined #openstack-fwaas | 16:46 | |
| yushiro | Yes. | 16:47 |
| yushiro | njohnston: 2 hours ago, Akihiro asked me how to build devstack with fwaasv2. | 16:48 |
| njohnston | ok | 16:48 |
| yushiro | njohnston: Maybe he will review fwaasv2. I hope so. | 16:49 |
| *** yamamoto has quit IRC | 16:50 | |
| yushiro | I tested on my devstack with my PS(CLI) | 16:52 |
| yushiro | CRUD can work. | 16:52 |
| yushiro | OK, please take a look... I'll go home now. | 16:54 |
| yushiro | Thanks for your awesome follow!!! also SridarK_ chandanc_ Sarath xgerman and mfranc213 !! | 16:54 |
| yushiro | also paddu! | 16:54 |
| yushiro | see you tomorrow(today) | 16:55 |
| *** yushiro has quit IRC | 16:55 | |
| *** _SarathMekala_ has quit IRC | 17:12 | |
| njohnston | http://logs.openstack.org/76/355576/42/check/gate-neutron-fwaas-python27-ubuntu-xenial/02dedf9/testr_results.html.gz | 17:18 |
| *** SumitNaiksatam has joined #openstack-fwaas | 17:47 | |
| *** SridarK_ has quit IRC | 17:49 | |
| *** chandanc_ has quit IRC | 17:52 | |
| njohnston | Yushiro's patch for a -1, I am wondering if we should take a stab at fixing the issues since he is offline | 17:56 |
| njohnston | 13:56:18 <#openstack-neutron> ihrachys armax: should we approach fwaas folks to tell them their OSC pieces not going in newton? | 17:56 |
| xgerman | well, CLI stuff always needs to hit way BEFORE the rest | 18:19 |
| *** mickeys has quit IRC | 18:28 | |
| *** xdcc has joined #openstack-fwaas | 18:31 | |
| njohnston | yeah | 18:37 |
| njohnston | sad but true | 18:38 |
| *** SridarK_ has joined #openstack-fwaas | 18:39 | |
| SridarK_ | njohnston: hope Jenkins is still keeping us hopeful | 18:41 |
| njohnston | SridarK_: tempest tests are all passing, just very slowly | 18:41 |
| SridarK_ | ah ok sigh | 18:42 |
| SridarK_ | dang that super call - really took us out - sometimes the symptoms dont quite give us a clue on the right direction | 18:46 |
| njohnston | yep | 18:46 |
| njohnston | tempest tests passwd | 18:46 |
| njohnston | passed | 18:46 |
| SridarK_ | ok | 18:46 |
| njohnston | xgerman SridarK_: Please review https://review.openstack.org/#/c/355576/, Jenkins has reported in | 18:48 |
| njohnston | By the way, I think we should make the tempest job voting again | 18:48 |
| xgerman | k | 18:48 |
| njohnston | not right now, but soon | 18:49 |
| njohnston | that would have helped me find the super() issue sooner | 18:49 |
| njohnston | I might potentially have found ti during the course of development because I would not have been able to ignore it | 18:49 |
| njohnston | :-) | 18:49 |
| SridarK_ | dang armax just sent an email out | 18:49 |
| SridarK_ | lets talk to him | 18:50 |
| njohnston | OK, looks like it is approved | 18:53 |
| njohnston | :-) | 18:53 |
| SridarK_ | njohnston: can u join in on neutron | 18:56 |
| njohnston | Oh thank goodness, it merged | 18:58 |
| njohnston | 14:58:30 openstackgerrit Merged openstack/neutron-fwaas: FWaaS v2 utilize L3 Agent Extension framework https://review.openstack.org/355576 | 18:59 |
| SridarK_ | njohnston: oh boy that was like an Indiana Jones movie | 19:01 |
| *** njohnston|car has joined #openstack-fwaas | 19:12 | |
| njohnston|car | Heading home to chill out and relax. Tomorrow I'll start on updates to the networking guide. | 19:14 |
| SridarK_ | njohnston|car: ok well deserved - we can start pulling things in for that, will continue to test | 19:17 |
| *** njohnston|car has quit IRC | 19:28 | |
| *** mickeys has joined #openstack-fwaas | 19:29 | |
| *** mickeys has quit IRC | 19:33 | |
| *** SridarK_ has quit IRC | 19:41 | |
| *** mickeys has joined #openstack-fwaas | 19:58 | |
| *** xdcc has quit IRC | 20:37 | |
| *** SridarK_ has joined #openstack-fwaas | 22:03 | |
| *** SridarK_ has quit IRC | 22:25 | |
| *** vishwanathj has quit IRC | 23:30 | |
| *** yushiro has joined #openstack-fwaas | 23:48 | |
| yushiro | morning | 23:48 |
| *** diogogmt has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!