| *** serverascode has quit IRC | 00:15 | |
| *** serverascode has joined #openstack-dragonflow | 00:18 | |
| *** yamamoto has joined #openstack-dragonflow | 03:50 | |
| *** yamamoto has quit IRC | 04:03 | |
| *** yamamoto has joined #openstack-dragonflow | 04:39 | |
| *** yamamoto has quit IRC | 04:40 | |
| *** yamamoto has joined #openstack-dragonflow | 04:40 | |
| *** yamamoto has quit IRC | 04:47 | |
| irenab | pino: There is a spec and work in progress to place DB migration baseline: https://review.openstack.org/#/c/500647/ https://review.openstack.org/#/c/401210/ | 05:54 |
|---|---|---|
| dimak | Good morning | 06:04 |
| irenab | morning | 06:05 |
| openstackgerrit | Eyal Leshem proposed openstack/dragonflow master: Add add command to df-db https://review.openstack.org/531119 | 07:28 |
| leyal- | Good morning | 07:29 |
| irenab | leyal-, hi | 07:34 |
| leyal- | irenab - ין | 07:35 |
| leyal- | irenab - hi | 07:35 |
| irenab | I just posted comments on the df-db related patchset 4, please check. Meanwhile you uploaded more updated version :-) | 07:35 |
| leyal- | irenab, thanks! i will take a look | 07:36 |
| *** natanbro has joined #openstack-dragonflow | 08:05 | |
| oanson | Morning | 08:09 |
| openstackgerrit | Eyal Leshem proposed openstack/dragonflow master: Add add command to df-db https://review.openstack.org/531119 | 08:11 |
| oanson | lihi, http://hyper.readthedocs.io/en/development/quickstart.html#requests-integration | 08:34 |
| lihi | oanson, still in early alpha | 08:36 |
| oanson | :( | 08:36 |
| oanson | https://github.com/DavidWittman/ansible-redis | 08:38 |
| openstackgerrit | Omer Anson proposed openstack/dragonflow master: [WIP] Use NbApi where possible in df_db https://review.openstack.org/530594 | 08:46 |
| openstackgerrit | Omer Anson proposed openstack/dragonflow master: Use NbApi where possible in df_db https://review.openstack.org/530594 | 08:46 |
| oanson | leyal-, ^^^ I've updated this patch. I'm still not sure I'm happy with it, but it passed rudimentary manual testing. | 08:47 |
| leyal- | oanson, cool. i will look at that | 08:54 |
| oanson | Thanks! | 08:55 |
| *** yamamoto has joined #openstack-dragonflow | 09:01 | |
| *** yamamoto has quit IRC | 09:10 | |
| *** yamamoto has joined #openstack-dragonflow | 09:13 | |
| *** yamamoto has quit IRC | 09:18 | |
| *** yamamoto has joined #openstack-dragonflow | 09:30 | |
| *** yamamoto has quit IRC | 09:32 | |
| *** yamamoto has joined #openstack-dragonflow | 09:38 | |
| openstackgerrit | Omer Anson proposed openstack/dragonflow master: Spec: Database Migration https://review.openstack.org/500647 | 09:38 |
| openstackgerrit | Omer Anson proposed openstack/dragonflow master: Add north-bound DB migration mechanism https://review.openstack.org/401210 | 09:38 |
| openstackgerrit | Omer Anson proposed openstack/dragonflow master: Add upgrade code for DHCP port per network https://review.openstack.org/527716 | 09:38 |
| openstackgerrit | Omer Anson proposed openstack/dragonflow master: Add upgrade script for Make Subnet a first-order model https://review.openstack.org/527717 | 09:38 |
| openstackgerrit | Omer Anson proposed openstack/dragonflow master: Added Migration code for floatingip field removal https://review.openstack.org/529012 | 09:38 |
| openstackgerrit | Omer Anson proposed openstack/dragonflow master: Added migration code to remove peer_bridge from OvsPort https://review.openstack.org/530213 | 09:38 |
| *** yamamoto has quit IRC | 10:27 | |
| *** yamamoto has joined #openstack-dragonflow | 10:27 | |
| *** yamamoto has quit IRC | 12:02 | |
| *** yamamoto has joined #openstack-dragonflow | 12:18 | |
| *** yamamoto has quit IRC | 12:23 | |
| *** yamamoto has joined #openstack-dragonflow | 13:03 | |
| oanson | snapiri, ping | 13:05 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: Application decoupling spec https://review.openstack.org/503538 | 13:06 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: [WIP] New application framework https://review.openstack.org/529358 | 13:06 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: [WIP] Connect new Datapath object to ryu base https://review.openstack.org/529980 | 13:06 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: [WIP] Add dragonflow legacy node to new datapath https://review.openstack.org/529981 | 13:06 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: [WIP] Port portsec app to new framework https://review.openstack.org/529982 | 13:06 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: [WIP] Port SG app to new framework https://review.openstack.org/530028 | 13:06 |
| *** yamamoto has quit IRC | 13:08 | |
| *** yamamoto has joined #openstack-dragonflow | 13:44 | |
| *** yamamoto has quit IRC | 13:44 | |
| openstackgerrit | Omer Anson proposed openstack/dragonflow master: Use NbApi where possible in df_db https://review.openstack.org/530594 | 13:50 |
| *** natanbro has quit IRC | 13:52 | |
| oanson | irenab, ping | 14:14 |
| irenab | oanson, pong | 14:14 |
| oanson | I'm looking at your comment on https://review.openstack.org/#/c/530594/ | 14:14 |
| irenab | first or second? | 14:15 |
| oanson | If instead of sys.exit, I throw a SystemExit exception, will that do? | 14:15 |
| oanson | Line 39 | 14:15 |
| irenab | why not let the caller of this method sort this out? | 14:15 |
| oanson | It comes out as a lot of repeated code | 14:16 |
| oanson | Basically, it's the same try ... catch return whenever it is called | 14:16 |
| irenab | It is just a getter, so seems a bit drastic to exit the process if it cannot get the requested | 14:17 |
| oanson | Usually, true | 14:17 |
| oanson | But this case is a very command-line-utility oriented implementation | 14:17 |
| oanson | It is not meant to be called as a library. For that, the original get_model (on model_framework) exists | 14:17 |
| irenab | Or just rename the method to something like 'get_or_abort' | 14:18 |
| irenab | oanson, seens its open source, you may never know how the code is going to be 'abused' | 14:18 |
| oanson | I could. If that would be enough | 14:18 |
| irenab | having more meaningful name will work for me in this case | 14:19 |
| oanson | I refuse to code for future ignorance :) It is marked as private, and modifying it like you want (raising exception rather than exit) is exactly the behaviour of the inner function | 14:19 |
| oanson | ^^^ That was for the 'open source is abused' comment. Not the other one | 14:19 |
| irenab | raising exception is much better than exiting, but still SystemExit is a bit drastic for getter | 14:20 |
| irenab | in python there is no strict private metod that can be guaranteed | 14:21 |
| snapiri | If I may barge in, I believe that creating an exception for that purpose, throwing it, and catching it in the common ancestor would work best | 14:21 |
| irenab | I second snapiri | 14:21 |
| oanson | I think that adds a lot of bloat. | 14:22 |
| snapiri | SystemExit would work, and is a second-best alternative | 14:22 |
| oanson | I am willing to settle on a SystemExit solution | 14:22 |
| snapiri | fine with me | 14:22 |
| irenab | oanson, sold :-) | 14:22 |
| oanson | Then that's what I'll do | 14:23 |
| *** yamamoto has joined #openstack-dragonflow | 14:45 | |
| openstackgerrit | Eyal Leshem proposed openstack/dragonflow master: Add add command to df-db https://review.openstack.org/531119 | 14:54 |
| *** yamamoto has quit IRC | 14:56 | |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: Application decoupling spec https://review.openstack.org/503538 | 15:18 |
| dimak | snapiri, take a look at my comments on the app spec | 15:18 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: [WIP] New application framework https://review.openstack.org/529358 | 15:41 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: [WIP] Connect new Datapath object to ryu base https://review.openstack.org/529980 | 15:41 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: [WIP] Add dragonflow legacy node to new datapath https://review.openstack.org/529981 | 15:41 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: [WIP] Port portsec app to new framework https://review.openstack.org/529982 | 15:41 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: [WIP] Port SG app to new framework https://review.openstack.org/530028 | 15:41 |
| *** yamamoto has joined #openstack-dragonflow | 16:43 | |
| *** yamamoto has quit IRC | 16:48 | |
| *** yamamoto has joined #openstack-dragonflow | 16:49 | |
| *** yamamoto has quit IRC | 17:33 | |
| *** yamamoto has joined #openstack-dragonflow | 17:43 | |
| *** yamamoto has quit IRC | 17:46 | |
| *** yamamoto has joined #openstack-dragonflow | 17:46 | |
| *** yamamoto has quit IRC | 17:46 | |
| *** yamamoto has joined #openstack-dragonflow | 18:47 | |
| *** yamamoto has quit IRC | 18:56 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!