Monday, 2016-04-11

*** zenoway has joined #openstack-dragonflow00:23
*** zenoway has quit IRC00:27
*** zenoway has joined #openstack-dragonflow00:44
*** gongysh has quit IRC00:47
*** zenoway has quit IRC00:49
*** zenoway has joined #openstack-dragonflow01:11
*** gongysh has joined #openstack-dragonflow01:19
*** zenoway has quit IRC01:55
*** hshan has joined #openstack-dragonflow02:27
*** zenoway has joined #openstack-dragonflow02:32
*** zenoway has quit IRC02:37
*** zenoway has joined #openstack-dragonflow02:44
*** zenoway has quit IRC02:48
*** dingboopt has joined #openstack-dragonflow02:49
openstackgerrithujie proposed openstack/dragonflow: add ovsdb monitor fullstack test case  https://review.openstack.org/29690503:23
openstackgerrithujie proposed openstack/dragonflow: add ovsdb monitor fullstack test case  https://review.openstack.org/29690503:23
nick-matodin: ok. i'm glad it is working for you.03:41
*** hujie has joined #openstack-dragonflow03:42
*** oanson has joined #openstack-dragonflow04:10
*** gongysh has quit IRC04:38
*** irenab has quit IRC04:45
*** irenab has joined #openstack-dragonflow05:29
*** gongysh has joined #openstack-dragonflow05:40
gampelyuanwei: ping hi05:49
*** gampel has quit IRC06:00
*** gsagie has quit IRC06:01
*** oanson has quit IRC06:01
*** gsagie has joined #openstack-dragonflow06:14
*** oanson has joined #openstack-dragonflow06:15
*** gampel has joined #openstack-dragonflow06:15
gampelFrank_Duan: ping06:19
*** CrayZee has quit IRC06:21
*** CrayZee has joined #openstack-dragonflow06:24
hshanoanson: ping06:28
oansonpong06:28
oansonhshan: pong06:29
hshanhi, omer,  I want to discuss the comments you gave for me about the "parser.OFPFlowMod("06:29
hshando you remember?06:29
Frank_DuanHi06:29
oansonYes06:30
oansonYou made changes to DFLowApp.mod_flow, to set the aging cookie06:30
oansonIf I understand correctly, this cookie has to be set on all flows06:31
hshanI've scanned for all the related code: all of them should be replaced by ryu_base_app.py DFLowApp.mod_flow06:31
hshanyes, it's should be set on all flows06:31
oansonYes06:31
oansonYou are correct. All flow modifications should be done with DFlowApp.mod_flow06:31
hshanbut arp_responder.py is a exception, which is not subclass of DFlowApp06:32
hshanso arp_responder.py has to do it itself06:32
oansonI see the problem. It still needs to set the cookie06:32
hshanI think it should be solved in another patch, what's your opinion?06:33
oansonThat would break reliability functionality.06:34
hshanyes, it is the basis of reliability06:34
oansonIt means arp-responder related flows may be removed when they shouldn't be, since the cookie is always 006:34
hshanyes, you're right06:34
hshanbut if I put the modification in reliability patch, that will  make the reliability patch too big,06:35
oansonBut you can call set_aging_cookie_bits in ArpResponder.06:35
oansonThe same way you do in mod_flow06:35
hshanI agree06:35
oansonThis way, it only adds 3-4 lines. That's not too bad.06:35
hshanbut I have to modify all other apps except ArpResponder to use mod_flow, do you understand me?06:36
oansonYes.06:36
hshanthe modification file list will be very long06:37
oansonBut I am afraid that without it, the controller may become unstable.06:37
oansonYou can first add a patch for all apps to use mod_flow, and on top of that the reliability patch06:37
oansonYou are correct, It is probably better that way06:37
hshanyes, that's just what I plan06:37
oansonThat's a good idea.06:38
hshanokay, I'll do it this way:)06:38
hshananother topic06:38
oansonGreat. Thanks!06:38
oansonSure06:38
hshanwhen will you hand the "switch_features_handler" to ovsdb_monitor?06:39
hshanthat's the basics of reliability too.06:39
openstackgerritLi Ma proposed openstack/dragonflow: Fix port update event loss  https://review.openstack.org/30328406:42
oansonYou need switch_features_handler to start the OVSDB monitor. Am I right?06:43
hshanno, it's not needed now06:44
oansonIn any case, this event should already be provided.06:44
*** yuli_s has joined #openstack-dragonflow06:44
yuli_shello06:44
oansonapps can implement switch_features_handler, and then they get that event06:45
yuli_sdingboopt, I was checking the sg patch yesterday.06:45
hshanoanson: it's not true06:45
yuli_si had 2 bugs06:45
hshanlet me explain it for you06:45
yuli_shttps://bugs.launchpad.net/dragonflow/+bug/156849806:46
openstackLaunchpad bug 1568498 in DragonFlow "sg test bug 1" [High,New]06:46
yuli_shttps://bugs.launchpad.net/dragonflow/+bug/156850606:46
openstackLaunchpad bug 1568506 in DragonFlow "sg test bug 2" [Undecided,New]06:46
dingbooptOk06:46
dingbooptI will take a look at them. thanks06:46
hshanthe current implementation of ovsdb_monitor got a little different from former implementation by hujie06:46
yuli_si am running stack now06:47
yuli_sand will try to reproduce these errors06:47
oansonhshan: I see06:47
hshanhujie's version do all the jobs in a new green thread, the openflow got a thread, dragonflow(processing the event queue) got a thread06:48
hshanso we have to synchronize between the 3 threads06:48
hshanwe must to make sure openflow is ready first, so the datapath is ready for apps to flush flow06:49
hshanthen the ovsdb_monitor could do it's job06:49
hshanbut in current implementation: ovsdb_monitor runs in the same thread with dragonflow, am I right?06:50
oansonhshan, ovsdb monitor has its own thread. In OvsdbSwitchApi calling self.ovsdb.start() starts a new thread06:51
hshani don't mean that06:52
oansonSo OVSDB gets its event from the self.ovsdb thread. It then sends the event to the queue, processed by the controller thread06:52
hshanyes06:53
oansonI don't understand the problem06:53
hshanI mean ovsdb monitor send the 'sync_started', 'vm port online event' 'sync_finished' to event queue is in the same thread with dragonflow, right?06:53
oansonYes06:54
oansonAnd the the DF controller processes all these events when it gets control back06:54
hshanokay, so when openflow.start() is blocked by wait_until_ready, 'sync_started', 'vm port online event' 'sync_finished' are blocked too06:55
hshanso we don't need ryu_base_app's switch_features_handler to start ovsdb_monitor now06:55
hshanit's needed in hujie's implementation06:56
hshando you agree with it?06:56
oansonYes.06:56
hshanokay, here we just need to move 'switch_features_handler ' from switch_features_handler to ovsdb_monitor06:57
hshanovsdb_monitor doesn't need to make any modification, because we can handle it in ryu_base_app when we read the 'sync_start' from event queue06:58
hshanwe could first send 'sync_start' to apps, then send 'switch_features_handler' to apps06:59
hshanoanson: are you there?07:00
oansonhshan, yes. 1 sec07:01
hshanok07:01
oansonI don't think the OVSDB monitor supports the features handler.07:02
oansonIt is a response to a features request made by ryu07:02
oansonI don't understand why it has to be moved?07:02
*** saggi has joined #openstack-dragonflow07:02
hshanit's for reliability feature consideration07:03
hshantoo07:03
hshanso let me ask you a question, what do apps use 'switch_features_handler ' for?07:04
hshanit's for apps to send framework flows, right?07:04
oansonI think that for startup. But that was before sync_started/sync_finished were created07:04
hshanthat' why we need to move it07:05
oansonWe may need to move from switch_handler to sync_finished, but no this version07:05
hshanall flows should be flushed after sync_started07:05
oansonIn fact I'd go as far as saying that we can do without the switch_handler event entirely. Only use sync_started.07:06
hshanyou mean we can remove " switch_handler event " totally ?07:07
oansonyes.07:07
oansonBut I think it's too risky for this version.07:07
hshanso, when will apps send framework flows?07:07
oansonWe are in feature freeze, with code freeze next week07:07
oansonRight now, in switch_handler. But like you said, it may be better in sync_started/sync_finished.07:08
oansonI think gampel and gsagie should give their opinion too on this, since it might be a big change.07:08
hshanyes, it's just a time point07:08
hshansorry, the code is freeze now, and that will last to the end of next week, right?07:09
oansonHopefully, only till next Monday.07:10
hshanokay, i got that07:10
hshanthe reason I talk about that is: it's the basic of reliability feature07:11
hshanwe've tested that locally, everything work fine, maybe you could test it too after moving  'switch_features_handler '07:13
oansonSure. I can test it.07:14
oansonCan you upload the new code for review? Then I can take it from there.07:14
hshanokay, i'll add that part of code back07:15
hshanI think we'll be more confidence about the moving when you tested it:)07:15
oanson:)07:16
hshananother topic: i fixed a bug in 'dragonflow/tests/common/utils.py',  and you gave a comments 'I should modify the test code that use table_id', you remember that07:17
oansonYes. I remember07:18
oansonThis is a bug. The table now looks like '9,' instead of '9'07:18
hshanyes07:19
hshani'll evaluate it, if the modification is not very big, I'll do it in the patch, or I'll add a new patch including 'bug fix and fullstack testcases for reliability feature'07:19
oansonI have to go for a sec. I'll be back soon07:19
hshansee you07:19
hshangsagie: ping07:26
oansonhshan: I'm back. Sorry07:27
oansonhshan: That's a good idea. It would be better if the table was a number, and not a number + a comma :)07:28
hshanpretty good07:28
hshanI'll add a new patch for bug-fix and fullstack of reliability features07:29
oansonGreat. Thanks!07:31
hshanoanson: thank you very much, that's all I want to make sure with you07:31
hshanI'll add the code back as soon as possible07:31
oansonhshan: No problem07:31
openstackgerrithujie proposed openstack/dragonflow: Fix unnecessary IDL run invoke bug  https://review.openstack.org/30393407:35
openstackgerrithujie proposed openstack/dragonflow: Fix unnecessary IDL run invoke bug  https://review.openstack.org/30393407:38
openstackgerrithujie proposed openstack/dragonflow: Fix unnecessary IDL run invoke bug  https://review.openstack.org/30393407:43
yuli_sdingboopt, i think i understand the bug better now07:52
yuli_sin df-df07:52
yuli_sKey = ea1ac88f-7c25-477c-83a7-0cd53ff992d5 , Value = {"parent_name": null, "macs": ["fa:16:3e:ca:8e:d1"], "name": "ea1ac88f-7c25-477c-83a7-0cd53ff992d5", "chassis": "ubuntu", "lswitch": "315ed568-4533-4f85-af13-a73a588af3de", "enabled": true, "topic": "c1487fc89cbe4e169329b25c9eb9ecfb", "ips": ["10.0.0.3", "fd42:8ae4:15ec:0:f816:3eff:feca:8ed1"], "device_owner": "compute:nova", "port_security": ["fa:16:3e:ca:8e:d1"], "sg07:52
yuli_sids": ["41d2f9d1-4111-487f-a8da-73ea385386ac"], "tunnel_key": 6, "external_ids": {"neutron:port_name": ""}, "tag": null, "security_groups": ["40d413ff-126e-4ca7-aeec-d81cba15a953"]}07:52
yuli_sthis is a port of the vm07:53
yuli_sit has 2 security group fields !07:53
yuli_sone is sgids and another one is security_groups07:54
yuli_sboth have different values !07:55
yuli_s"sgids": ["41d2f9d1-4111-487f-a8da-73ea385386ac"]07:55
yuli_s"security_groups": ["40d413ff-126e-4ca7-aeec-d81cba15a953"]07:55
yuli_sone point to default security group07:55
yuli_sanother point to the security group I created07:55
openstackgerritding bo proposed openstack/dragonflow: This patch implements security group app  https://review.openstack.org/28053808:16
*** raofei has joined #openstack-dragonflow08:22
*** yamamoto has joined #openstack-dragonflow08:24
oansonyuli_s, ping08:27
yuli_soanson, yes08:31
openstackgerritheshan proposed openstack/dragonflow: code for local controller reliability  https://review.openstack.org/29206008:36
*** zenoway has joined #openstack-dragonflow08:44
*** Shlomo_N has joined #openstack-dragonflow08:48
openstackgerrithujie proposed openstack/dragonflow: add ovsdb monitor fullstack test case  https://review.openstack.org/29690508:59
oansonHi09:02
oansonWe're starting the meeting in #openstack-meeting-409:02
oansonPlease join.09:02
nick-maok09:03
*** liuhaixia has joined #openstack-dragonflow09:09
*** Mic22 has joined #openstack-dragonflow09:11
*** yuanwei has joined #openstack-dragonflow09:13
liuhaixiahi,gal, good morning. I have question about when to create  bridge 'br-int'. With pure neutorn, ovs-agent response for create bridge 'br-int'.09:32
gsagiehi09:33
liuhaixiaWith dragonflow, /dragonflow/devstack/plugin.sh  create 'br-int'.09:33
gsagieliuhaixia: its currently created by our devstack script i believe09:33
gsagiebut if needed you can move it to the df code09:33
liuhaixiaI see it.09:33
liuhaixiaoh, this is what I want to know.09:34
liuhaixiaDo you have plan to move it to code?09:34
liuhaixiaBecause in HWS Cloud, we need df code to do this.09:35
liuhaixiaI think if we do not use devstack to install openstack, we also need to create 'br-int' manually or by scripts.09:38
liuhaixiaSorry, you mean I can move it to code:)09:39
liuhaixiaI know, thanks.09:39
*** feipeng has joined #openstack-dragonflow09:46
*** Frank_Duan has quit IRC10:06
openstackgerritLi Ma proposed openstack/dragonflow: Fix port update event loss  https://review.openstack.org/30328410:38
openstackgerritheshan proposed openstack/dragonflow: add check_controller() and set_controller_fail_mode() to vswitch_api  https://review.openstack.org/29206010:40
openstackgerritLi Ma proposed openstack/dragonflow: Fix port update event loss  https://review.openstack.org/30328410:43
openstackgerritheshan proposed openstack/dragonflow: code for local controller reliability  https://review.openstack.org/29206010:43
openstackgerritheshan proposed openstack/dragonflow: add check_controller() and set_controller_fail_mode() to vswitch_api  https://review.openstack.org/30402610:51
*** zenoway has quit IRC11:16
*** zenoway has joined #openstack-dragonflow11:19
*** mastermind has joined #openstack-dragonflow11:21
openstackgerritheshan proposed openstack/dragonflow: change dragonflow apps to use mod_flow instead of ryu's OFPFlowMod  https://review.openstack.org/30405011:23
*** zenoway has quit IRC11:23
*** Shlomo_N has quit IRC11:25
*** mastermind has quit IRC11:26
openstackgerritheshan proposed openstack/dragonflow: change dragonflow apps to use mod_flow instead of ryu's OFPFlowMod  https://review.openstack.org/30405011:26
*** yamamoto has quit IRC11:46
*** zenoway has joined #openstack-dragonflow11:52
openstackgerritheshan proposed openstack/dragonflow: code for local controller reliability  https://review.openstack.org/29206011:56
*** zenoway has quit IRC12:01
gsagieAll our friends in China, any of you is coming to OpenStack Austin summit by any chance?12:08
*** gongysh has quit IRC12:09
*** zenoway has joined #openstack-dragonflow12:19
*** yamamoto has joined #openstack-dragonflow12:22
hshanoanson: ping12:22
oansonpong12:22
oansonhshan, pong12:23
hshanI encounter a problem when I make set_controller and set_fail_mode through idl, I guess it's caused by the filter12:23
hshanI add the related rows to ovsdb_monitor_table_filter_default, but it doesn't work12:24
hshanI think you must know how to do it12:25
hshanI interested in 'controller' and 'fail_mode' row under 'Bridge' table12:25
oanson1 sec. I will look at the code12:29
hshanoanson: do you hear me?12:29
hshanokay12:29
openstackgerritEran Gampel proposed openstack/dragonflow: Mitaka Version Features Update  https://review.openstack.org/30382512:30
oansonDid you add 'Controller' with 'target' field to ovsdb_monitor_table_filter_default? In addition, did you add the fields 'controller' and 'fail_mode' in 'Bridge' table to ovsdb_monitor_table_filter_default?12:31
hshan'Did you add 'Controller' with 'target' field to ovsdb_monitor_table_filter_default?' how?12:33
hshanI did the second job12:33
oansonadd to ovsdb_monitor_table_filter_default the key: 'Controller': ['target']12:34
oansonYou need to have the 'Controller' table added, otherwise it won't be in the idl.12:34
hshanlet me try it12:35
hshanjob done! thank you very much!12:37
oansonNo problem :)12:38
liuhaixiaHelp. Does anybody have the problem when run 'tox -e fullstack'?12:40
liuhaixiaThree of my colleagues have meet the problem since this week.12:41
liuhaixiaThe error 'No local packages or download links found for pbr>=1.8'12:41
oansonCan you please run 'pip show pbr'?12:43
liuhaixiaIt works fine.12:43
liuhaixiaName: pbr12:44
liuhaixiaVersion: 1.8.112:44
liuhaixiaVersion: 1.8.112:44
oansonCould you try again, after running '. .tox/fullstack/bin/activate'?12:44
oanson(run 'deactivate' when finished to leave the virtualenv')12:44
liuhaixia(fullstack) stack@PEK1000047303:~/dragonflow$ pip  show pbr12:45
*** gongysh has joined #openstack-dragonflow12:46
openstackgerritheshan proposed openstack/dragonflow: add check_controller() and set_controller_fail_mode() to vswitch_api  https://review.openstack.org/30402612:46
liuhaixiaIt seems not work fine.12:47
oansonWhat's the output?12:47
liuhaixiaAn HTTPS request has been made12:48
liuhaixia.tox/fullstack/lib/python2.7/pip/_vendor/requests/packages/urllib3/util/ssl_.py:31512:48
liuhaixiaSNIMissingWarning: An HTTPS request has been made, but the SNI12:48
liuhaixia(Subject Name Indication) extension to TLS is not available on this platform.12:48
liuhaixiaIt looks like SSL issue.12:49
oansonYes12:50
oansonDo you get a pip version error?12:50
oansonSomething like:12:50
oansonYou are using pip version 8.0.2, however version 8.1.1 is available.12:50
oansonYou should consider upgrading via the 'pip install --upgrade pip' command.12:50
liuhaixiaNo12:50
liuhaixiaIt does not have version error.12:51
*** zenoway has quit IRC12:51
oansonI am not familiar with this issue. I will have to search it.12:51
liuhaixiaThank you, I will try also.12:52
hshangsagie, oanson: the splitting of reliability is ready, details please see email12:59
hshanif you got any problems please email me, see you13:00
*** zenoway has joined #openstack-dragonflow13:05
gsagiehshan: can you please send me which patch to try and test13:06
gsagiewhich is highest in the hierarchy?13:06
gsagiehshan: ?13:08
openstackgerritEran Gampel proposed openstack/dragonflow: Mitaka Version Features Update  https://review.openstack.org/30382513:12
*** zenoway has quit IRC13:18
openstackgerritOmer Anson proposed openstack/dragonflow: Lookup router_port's network_id with lswitch's topic  https://review.openstack.org/29812113:26
*** oanson has quit IRC13:31
*** zenoway has joined #openstack-dragonflow13:33
*** irenab has quit IRC13:41
*** zenoway has quit IRC13:41
*** zenoway has joined #openstack-dragonflow13:55
*** zenoway has quit IRC14:04
*** yamamoto has quit IRC14:06
*** zenoway has joined #openstack-dragonflow14:09
openstackgerritYuli proposed openstack/dragonflow: Fix empty ofport value Closes-bug: #1568506  https://review.openstack.org/30415214:09
openstackbug 1568506 in DragonFlow "sg test bug 2" [High,New] https://launchpad.net/bugs/1568506 - Assigned to Omer Anson (omer-anson)14:09
*** yamamoto has joined #openstack-dragonflow14:10
*** zenoway has quit IRC14:13
openstackgerritYuli proposed openstack/dragonflow: Fix empty ofport value  https://review.openstack.org/30415214:16
*** yuli_s has quit IRC14:20
*** zenoway has joined #openstack-dragonflow14:27
openstackgerrityuan wei proposed openstack/dragonflow: Impliment security group fullstack and ut cases  https://review.openstack.org/29910514:28
*** zenoway has quit IRC14:32
*** zenoway has joined #openstack-dragonflow14:41
*** zenoway has quit IRC14:45
*** yamamoto has quit IRC14:51
*** openstackgerrit has quit IRC15:18
*** openstackgerrit has joined #openstack-dragonflow15:18
*** yamamoto has joined #openstack-dragonflow15:21
*** yamamoto has quit IRC15:27
*** zenoway has joined #openstack-dragonflow15:31
*** zenoway has quit IRC15:35
*** yamamoto has joined #openstack-dragonflow15:42
*** yamamoto has quit IRC15:52
*** gongysh has quit IRC16:18
openstackgerritMerged openstack/dragonflow: Send Chassis update on SEND_ALL topic  https://review.openstack.org/30260116:29
*** yamamoto has joined #openstack-dragonflow16:52
*** yamamoto has quit IRC17:00
*** oanson has joined #openstack-dragonflow17:42
*** openstackgerrit has quit IRC20:05
*** zenoway has joined #openstack-dragonflow20:25
*** openstackgerrit has joined #openstack-dragonflow20:28
*** zenoway has quit IRC20:28
*** zenoway has joined #openstack-dragonflow20:29
*** openstackgerrit has quit IRC20:41
*** openstackgerrit has joined #openstack-dragonflow20:55
*** oanson has quit IRC21:32
*** zenoway has quit IRC21:39
*** zenoway has joined #openstack-dragonflow21:41
*** zenoway has joined #openstack-dragonflow21:43
*** zenoway has quit IRC21:43
*** zenoway has joined #openstack-dragonflow21:45
*** zenoway has quit IRC21:45
*** zenoway has joined #openstack-dragonflow21:46
*** zenoway has joined #openstack-dragonflow22:03
*** zenoway has quit IRC22:06
*** zenoway has joined #openstack-dragonflow22:08
*** zenoway has quit IRC22:08
*** zenoway has joined #openstack-dragonflow22:10
*** zenoway has quit IRC22:11
*** zenoway has joined #openstack-dragonflow22:12
*** zenoway has quit IRC22:13
*** zenoway has joined #openstack-dragonflow22:15
*** zenoway has quit IRC22:15
*** zenoway has joined #openstack-dragonflow22:16
*** zenoway has quit IRC22:16
*** zenoway has joined #openstack-dragonflow22:18
*** zenoway has quit IRC22:18
*** zenoway has joined #openstack-dragonflow22:21
*** zenoway has quit IRC22:27
*** zenoway has joined #openstack-dragonflow22:29
*** zenoway has quit IRC22:29
*** zenoway has joined #openstack-dragonflow22:32
*** zenoway has quit IRC23:15
*** saggi has quit IRC23:26
*** gampel has quit IRC23:26
*** gsagie has quit IRC23:27
*** gsagie has joined #openstack-dragonflow23:40
*** saggi has joined #openstack-dragonflow23:40
*** gampel has joined #openstack-dragonflow23:41
*** zenoway has joined #openstack-dragonflow23:45
*** zenoway has quit IRC23:49

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!