Friday, 2019-08-23

*** brinzhang_ has joined #openstack-doc00:51
*** brinzhang has quit IRC00:54
*** goldyfruit has quit IRC03:01
*** KeithMnemonic1 has quit IRC03:06
*** KeithMnemonic has joined #openstack-doc03:12
openstackgerritIan Wienand proposed openstack/openstack-manuals master: Move proposal job into project-config  https://review.opendev.org/67813303:26
openstackgerritIan Wienand proposed openstack/openstack-manuals master: Move proposal job into project-config  https://review.opendev.org/67813303:34
openstackgerritMerged openstack/openstack-manuals master: Move proposal job into project-config  https://review.opendev.org/67813304:25
*** kopecmartin|off is now known as kopecmartin05:55
openstackgerritAndreas Jaeger proposed openstack/training-guides master: WIP: Update to normal docs jobs  https://review.opendev.org/67815506:08
AJaegeramotoki, asettle, stephenfin, I'm now happy with the changes we have for PDF building, see:06:38
AJaegerhttps://review.opendev.org/#/c/678077 https://review.opendev.org/678142 and https://review.opendev.org/66455506:38
AJaegerI'm testing this in https://review.opendev.org/#/c/67808006:39
AJaegerthanks amotoki to getting us there!06:39
amotokiyay! I hope the zuul-job patch lands soon :)07:03
amotokiWe also need to send a mail to announce our current status and the basic instructions07:04
*** jawad_axd has joined #openstack-doc07:07
AJaegerI'll ping for those changes to be merged...07:08
*** rcernin has quit IRC07:15
*** miloa has joined #openstack-doc07:42
AJaegeramotoki: first +2s coming in ;)08:29
asettleAJaeger, ohhhhhhh :o08:57
asettleThis is exciting!08:57
* AJaeger just gave a -1 on https://review.opendev.org/#/c/664555/ - this will not work in general as is yet.08:58
asettleSure sure08:58
AJaegerno time to dig deeper - asettle if you want to discuss what to do ("design"), it would be nice.08:59
asettleAJaeger, talking about the template design of the PDF?08:59
AJaegeramotoki, asettle : https://review.opendev.org/#/c/664555/ is merged ;)08:59
amotoki\o/09:00
* AJaeger needs to step out for a bit and leaves 664555 for you ;)09:00
asettleUhhh09:02
asettlestephenfin, you got any clarity here cause I don't?09:03
stephenfinwhuh?09:04
asettleAndreas was asking me to look into the design? I'm confused?09:05
AJaegerasettle: read my last comment on 664555, please09:07
AJaegerdesign : What should happen if api-ref job is run and the tox.ini has a pdf environment?09:07
asettleI mean, I have09:07
asettleOh. Thank you09:07
asettle:)09:07
AJaegerFigure out what we need - and once that's clear, we can define what to change...09:08
AJaegerwill be out for a bit...09:08
asettleo/09:09
-amotoki- is a bit tired by working on common jobs with nested dependencies :)09:12
amotokiAJaeger: good catch on build-openstack-api-ref/guide09:16
amotokias of now, we assume pdfdocs tox env is a counter part of docs tox env09:17
amotokiwe can add similar variants for api-ref and api-guide but I am not sure this is what stephenfin wants.09:18
amotokiif we go to this route, '-pdf' suffix or 'pdf-' prefix would make more sense09:20
-amotoki- will be offline next one or two hours09:21
asettleamotoki, I don't see the need at this point to gen the api-ref and api-guide into PDFs. Perhaps that could almost be a subsequent ideal if someone so wants. But at this point in time, the main priority is the user facing content.09:44
*** brinzhang_ has quit IRC09:46
stephenfinWe can't generate PDFs for the api-guide anyway since the plugin only supports HTML output10:36
AJaegerok, I'll tweak the job late today...10:55
asettleGood to know. Thanks AJaeger11:02
*** tesseract has joined #openstack-doc11:12
*** goldyfruit has joined #openstack-doc11:14
*** hemna has joined #openstack-doc11:40
amotokiasettle: I agree our primary goal is a user-facing document (though whether the contributor doc is a user-facing document is a question for a long time since doc migation). The problem is if "pdfdocs" tox env exists PDF build will be run for API ref or API guide too (unintentionally).12:55
amotokiasettle: A question is how to disable PDF build for them.12:55
amotokiasettle: I see two ways; the one is to have a flag to disable PDF build.12:56
amotokiasettle: the other way is to define a prefix or a suffix for PDF build. this means if a tox env for HTML build is 'docs' and a prefix 'pdf-' is for PDF build, when 'pdf-docs' exists PDF build will run.12:57
amotokiby doing so, for API ref, there is no 'pdf-api-ref' by default so PDF build will not be run.12:58
asettleThanks for the explanation amotoki12:58
AJaegeramotoki: I'll fix the change so that it will not be run for API* jobs anymore.12:59
asettleI commented on the PR asking whether or not it would be easier to disable the PDF jobs? AJaeger 's suggestion was to have another tox env12:59
AJaegeramotoki: One way: Create a new base job, have api-ref, api-guide and openstack-tox-docs inherit from the new base job...12:59
AJaegerBut adding a flag would work as well13:00
asettleThe flag is an interesting options - provides choice. But then we're still building huge PDFs with both docs and api docs13:00
asettleWhich, thinking out loud, would that not be incredibly messy and enormous?13:00
amotokiAJaeger: or we can update openstack-tox-docs which look for a tox env whose name is 'pdf-<tox-env-for-docs>'13:01
AJaegeramotoki: yes, that works as well...13:01
AJaegerand is one way to disable it ;)13:01
AJaegername it "this-environment-should-not-exist-otherwise-you-are-screwed" ;)13:02
amotokiA simplest way at the moment seems to introduce a flag in openstack-tox-docs and specify the flag to false in api-ref/api-guide job.13:02
amotokihmm... when I search "parent: openstack-tox-docs" in codesaerch.o.o, there are more jobs who inherit openstack-tox-docs.13:04
AJaegerthose all build the same docs, so no problem for these13:08
amotokiAJaeger: btw, build-openstack-api-(ref|guide) inherit opendev-tox-docs, so changes in openstack-tox-docs does not affect them.13:08
AJaegerYou only need to care about those thta change teh tox environemn13:08
AJaegeramotoki: I need to update my tree ;)13:08
amotokiTalking about jobs in openstack-zuul-jobs, only build-openstack-deploy-guide might be affected.13:11
AJaegeramotoki: let me rebase the change to master...13:33
AJaegeramotoki: I need to rebase the build-api- jobs on openstack-tox-docs for requiremetns files13:35
amotokithe work on the common job for PDF build is much more complicated that what I thought first..... I wonder folks who want to support PDF build imagined it :(13:38
hemnamorning13:40
hemnahow is it all goin?13:40
amotokihemna: we are still working on the common job. we've found another problem on a way to support/detect 'pdfdocs' in the common job definition.... I am not sure the common job lands today.13:41
* AJaeger is updating it right now13:44
hemnaok13:46
hemnaI've been away the last 2 days at the cinder midcycle13:46
asettleHow was it?13:47
hemnait was good13:47
hemnasmall team this time13:47
hemnaI still haven't found a solution to the memory issue with TeX13:47
*** jawad_axd has quit IRC13:49
amotokihemna: I think it happens for a sample config file, right?13:51
* AJaeger just updated https://review.opendev.org/664555 - what do you think?13:53
AJaegeramotoki: this renames the tox environment to "pdf-docs"13:53
*** jawad_axd has joined #openstack-doc13:53
AJaegerand offers a way to disable it.13:53
AJaegerDid I cover everything? ;)13:54
amotokiAJaeger: looking at it..13:54
AJaegerthanks13:55
* asettle goes to review13:56
*** jawad_axd has quit IRC13:58
asettleLooks good, other than the one question I had inline14:01
amotokiI think it is good for now. In future, we can calculate tox_pdf_docs from tox_envlist and we can run PDF build automatically when tox_pdf_docs exists.14:02
amotokiso we can drop tox_pdf_docs and tox_skip_pdf14:03
AJaegerasettle: I'm sure stephenfin got it working - but it might be a different package list.14:08
AJaegerSo, unless he confirms that the list as is works on Fedora, let's leave it.14:08
AJaegerthanks, amotoki14:08
asettleAJaeger, that's fair. It would be nice to confirm at least one other distro. hemna - by chance, are you testing with SUSE?14:14
asettleJust referencing my comment here: https://review.opendev.org/#/c/664555/21/roles/prepare-build-pdf-docs/README.rst14:14
amotokiAJaeger: asettle: one thing I know is Fedora has no xindy package, but latex_use_xindy = False is our current practice, so it might not be a problem.14:17
* asettle thinks 14:17
asettleHmm okay14:17
asettlestephenfin, would be good if you could confirm when you have a mo14:17
amotokiAJaeger: asettle: other than that, bindep.txt in several projects covers ubuntu and rpm based distros.14:18
asettleGood to know14:21
AJaegersomething is wrong, https://zuul.opendev.org/t/openstack/build/fe819c27f21740f2b52f8bdd4f3c6fed only has PDF, no HTML ;(14:22
asettleHaha oh no14:22
AJaegeramotoki: yes, I know that it covers that - and I'm happy to change the text or code14:22
* AJaeger needs coffee and will the ncheck...14:22
asettleAJaeger, this looks good though! https://openstack.fortnebula.com:13808/v1/AUTH_e8fd161dc34c421a979a9e6421f823e9/logs_80/678080/4/check/openstack-tox-docs/fe819c2/pdf/horizon.pdf14:24
amotokibut no html artifacts....14:24
asettleNope14:25
amotokiAJaeger: looking at ara report, both tox runs were called with tox -epdf-docs..... our expectation is tox -e docs and tox -e pdf-docs though..14:26
amotokiis confused with what happens.....14:29
AJaegeramotoki: yes, that's the problem - now figuring out why...14:31
*** jawad_axd has joined #openstack-doc14:46
hemnaback, my memory issue happens when building the cinder pdf14:49
*** kopecmartin is now known as kopecmartin|off14:51
*** jawad_axd has quit IRC14:51
amotokihemna: are you still hitting this?14:57
AJaegeramotoki: didn't you had a way with latex_elements and memory increase?14:58
amotokiAJaeger: I didn't. in neutron and nova doc, I avoid this by skipping inline sample config files IIRC.14:59
amotokimaxlistdepth=10 helps us when we hit deeper list issue15:00
AJaegerah15:00
AJaegerimport_role is bad, include_role did the trick - https://zuul.opendev.org/t/openstack/build/386ee418bde04aabafafbc2967cfa430 looks fine, doesn' it?15:01
amotokiAJaeger: ah.... I should check the difference between include_role and import_role, but I didn't know improt_role affects other same role in a playbook..15:04
AJaegeramotoki: import is at initial setup, include evaluates when used. I didn't know that either ;(15:06
amotokiAJaeger: thanks. I now seem to understand the description of import_role in the ansible doc.15:08
*** jawad_axd has joined #openstack-doc15:11
hemnaI just tried to run my cinder patch against Leap15:12
hemnaand it failed15:12
hemnait failed to install the requirements15:13
hemnaamotoki: but yes, I am still hitting the memory issue15:13
*** jawad_axd has quit IRC15:16
hemnaCould not find a version that satisfies the requirement Sphinx===2.2.015:16
hemna(on Leap 15.115:16
AJaegerI can install sphinx on Leap 15.1 wihtout problems, question is what is missing for it...15:18
hemnahrmm15:19
hemnaI'm on master now too and trying to run tox -edocs15:19
hemnafails on sphinx15:19
amotokiLeap is openSUSE?15:20
amotokipip installs sphinx from PyPI, so I don't see any reason which depends on distros....15:20
AJaegeryes, openSUSE hsa two flavors - openSUSE Leap and openSUSE tumbleweed (the rolling release)15:21
AJaegeramotoki: yes, I installed via pip as well15:21
AJaegerhemna: can you paste the output?15:21
AJaegerasettle: could you +2A https://review.opendev.org/677802, please?15:23
AJaegerhemna: do you have cinder changs with pdf building up that I can look at with 664555 ?15:31
*** jamesmcarthur has joined #openstack-doc15:47
hemnasure just a sec15:50
hemnahttps://review.opendev.org/#/c/677301/15:53
hemnathat's my cinder patch to build pdf15:53
hemnahttp://paste.openstack.org/show/762691/15:58
hemnathat's the cinder tox -edocs failure on master in Leap 15.115:58
hemnanot sure why it can't install sphinx 2.2.015:59
AJaegerhemna: want to make 677301 depends-on 664555 ?16:01
hemnaI suppose we can16:03
hemnaI'm just trying to run it locally16:03
hemnathink that patch will fix the memory issue?16:03
hemnaok so you are naming the job 'pdf-docs' not 'pdfdocs'16:03
AJaegerhemna: mmh, does cinder not use python3 for base-python?16:03
AJaegerhemna, yes, pdf-docs16:03
AJaegerso, we can use pdf-api-ref later16:04
hemnaok I'll have to update my 3 patches to rename it to pdf-docs16:04
hemnathe docs job in cinder tox.ini is python316:04
AJaegerhemna, do you have python3 installed?16:05
hemnahttps://github.com/openstack/cinder/blob/master/tox.ini#L13416:05
AJaegerhemna: indeed - my local copy was on pike...16:05
hemnayup16:06
hemnapython3 rungs16:06
hemnaruns16:06
AJaegerhemna: tox -e docs works fine for me - and that paste is really strange, I'm out of ideas16:08
hemnayah I'm confused as to why it fails16:09
AJaegerhemna: it looks like sphinx is not available. Are you using a local pypi mirror?16:11
*** tesseract has quit IRC16:11
AJaegerline 154 says that version 1.8.5 is the latest it could find - so, where do you get sphinx from?16:11
hemnahttp://paste.openstack.org/show/762693/16:17
hemnaI tried to pip install it manually into the same venv16:17
hemnait shows the list of versions it knows about for sphinx16:17
hemna1.8.5 is the latest16:17
hemna?@!16:18
hemnano custom ~/.pip either16:19
hemnahttps://pypi.org/project/Sphinx/#files16:19
hemna2.2.0 is the only version available on pypi16:19
hemnaso I'm confused16:19
AJaeger1.8.5 is the latest python2 version. Is your venv really using python3?16:20
AJaegerhemna: doc/requirements.txt has:16:20
AJaegersphinx!=1.6.6,!=1.6.7,>=1.6.3,<2.0.0;python_version=='2.7'  # BSD16:20
AJaegerSo, if your venv by accident uses python2 instead of python3, that might be the reaons16:21
*** AJaeger_ has joined #openstack-doc16:31
*** AJaeger has quit IRC16:35
*** AJaeger_ is now known as AJaeger16:38
*** AJaeger_ has joined #openstack-doc16:47
*** AJaeger has quit IRC16:51
*** miloa has quit IRC17:02
hemnaok17:03
hemnapython2 is uninstalled17:04
hemnapython3.4 is what's on the system17:04
AJaeger_3.4? I have 3.6.5 installed17:05
AJaeger_hemna, re-install python3 package, I think something is strange with your system if you still have 3.417:08
*** jamesmcarthur has quit IRC17:11
*** jamesmcarthur has joined #openstack-doc17:11
amotokihemna: I succeeded to build PDF file for cinder doc. Is it okay to update your cinder change?17:12
amotokihemna: As OpenStack developers, 3.6 and 3.7 are the expected version for python3 now :)17:13
hemnayah, this is Leap 15.117:14
hemnatrying to do an update now to see if it helps17:14
*** jamesmcarthur has quit IRC17:22
amotokihemna: it looks like that literalinclude of cinder.conf sample file causes memory issue. Commenting out that literalinclude solves the memory issue.17:30
amotokihemna:  In addition, I need to set maxlistdepth: 10 in latex_elements.17:30
amotokihemna: by these two changes I can generate the PDF file for cinder.17:30
amotokigood night17:33
hemnaok that sounds good17:51
*** cp has quit IRC17:58
AJaeger_amotoki, good night!18:14
AJaeger_asettle, stephenfin, hemna , amotoki : All changes are in ;) Happy PDF Building :)18:14
*** AJaeger_ is now known as AJaeger18:14
openstackgerritMerged openstack/contributor-guide master: use promote job  https://review.opendev.org/67780218:56
openstackgerritMerged openstack/openstack-manuals stable/newton: Update for openstack-doc-tools 2.0  https://review.opendev.org/67803118:59
AJaegerstephenfin, asettle, are you going to send an email to the mailing list with updated instructions about PDF goal? you should be unblocked now ;)19:00
openstackgerritMerged openstack/openstack-manuals stable/ocata: Update for openstack-doc-tools 2.0  https://review.opendev.org/67803619:02
hemnaoh well, I can't get python to upgrade to 3.7 on leap19:04
* hemna is giving up19:04
openstackgerritAndreas Jaeger proposed openstack/openstack-manuals stable/newton: Update URL of contributor guide  https://review.opendev.org/67828919:14
*** jamesmcarthur has joined #openstack-doc19:28
*** jamesmcarthur has quit IRC19:32
*** jamesmcarthur has joined #openstack-doc19:32
*** jamesmcarthur has quit IRC19:43
openstackgerritMerged openstack/openstack-manuals stable/newton: Update URL of contributor guide  https://review.opendev.org/67828919:44
*** jamesmcarthur has joined #openstack-doc19:45
*** jamesmcarthur has quit IRC19:50
*** jamesmcarthur has joined #openstack-doc20:14
AJaegerasettle, amotoki, stephenfin, have a look at the nova PDF at https://review.opendev.org/#/c/676730 and read my comment ;( Hope either of you can look into this at some time...20:17
* AJaeger joins hemna in giving up20:17
*** jamesmcarthur has quit IRC20:18
*** jamesmcarthur has joined #openstack-doc20:19
AJaegerwe could probably enforce to use the projectname (that's a zuul variable)20:23
*** jamesmcarthur has quit IRC21:46
*** jamesmcarthur has joined #openstack-doc21:48
*** jamesmcarthur has quit IRC21:50
*** jamesmcarthur has joined #openstack-doc21:51
*** jamesmcarthur has quit IRC22:07
*** jamesmcarthur has joined #openstack-doc22:07
*** rcernin has joined #openstack-doc22:11
*** KeithMnemonic has quit IRC22:13
*** jamesmcarthur has quit IRC22:13
*** jamesmcarthur has joined #openstack-doc22:31
*** jamesmcarthur has quit IRC22:37
*** jamesmcarthur has joined #openstack-doc22:39
*** jamesmcarthur has quit IRC22:46
*** jamesmcarthur has joined #openstack-doc22:50
*** jamesmcarthur has quit IRC23:01
*** rcernin has quit IRC23:11
*** rcernin has joined #openstack-doc23:12
*** jamesmcarthur has joined #openstack-doc23:15
*** jamesmcarthur has quit IRC23:17
*** jamesmcarthur has joined #openstack-doc23:19
*** jamesmcarthur has quit IRC23:22
*** jamesmcarthur has joined #openstack-doc23:22
*** jamesmcarthur has quit IRC23:32
*** jamesmcarthur has joined #openstack-doc23:38
*** jamesmcarthur has quit IRC23:42

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!