Tuesday, 2021-03-09

*** lbragstad has quit IRC00:23
*** tosky has quit IRC00:28
*** martinkennelly has quit IRC00:50
*** lbragstad has joined #openstack-cinder00:52
*** hamalq has quit IRC01:24
*** rratnaka has joined #openstack-cinder01:27
*** ociuhandu has joined #openstack-cinder01:42
*** zenkuro has quit IRC01:46
*** ociuhandu has quit IRC01:46
*** zenkuro has joined #openstack-cinder01:47
*** venkatakrishnath has joined #openstack-cinder02:03
venkatakrishnathHi, I have been asking for review for these patches since last one month and posted in IRC many times. Can someone please review these https://review.opendev.org/c/openstack/cinder/+/75019902:09
venkatakrishnathhttps://review.opendev.org/c/openstack/cinder/+/76515402:09
*** rcernin has quit IRC02:25
*** rcernin has joined #openstack-cinder02:42
openstackgerritAjitha Robert proposed openstack/cinder master: Bug fix for revert to snapshot feature  https://review.opendev.org/c/openstack/cinder/+/77941702:47
*** rcernin has quit IRC02:48
*** rcernin has joined #openstack-cinder02:51
*** carloss has quit IRC03:00
openstackgerritLance Bragstad proposed openstack/cinder-tempest-plugin master: Add basic volume protection tests  https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/77835703:07
*** ajitha has joined #openstack-cinder03:14
*** rcernin has quit IRC03:20
*** psachin has joined #openstack-cinder03:29
*** ociuhandu has joined #openstack-cinder03:30
*** ociuhandu has quit IRC03:34
*** rcernin has joined #openstack-cinder03:40
*** lbragstad has quit IRC03:43
*** zzzeek has quit IRC03:46
*** zzzeek has joined #openstack-cinder03:47
*** rcernin_ has joined #openstack-cinder03:51
*** kmarc_ has joined #openstack-cinder03:52
*** gary_perkins_ has joined #openstack-cinder03:56
*** icey_ has joined #openstack-cinder03:56
*** rcernin has quit IRC03:59
*** dsariel has quit IRC03:59
*** hoonetorg has quit IRC03:59
*** openstackgerrit has quit IRC03:59
*** icey has quit IRC03:59
*** jv_ has quit IRC03:59
*** gary_perkins has quit IRC03:59
*** LarsErikP has quit IRC03:59
*** tbarron has quit IRC03:59
*** kmarc has quit IRC03:59
*** jv_ has joined #openstack-cinder04:02
*** vishalmanchanda has joined #openstack-cinder04:16
*** vishalmanchanda has quit IRC04:21
*** vishalmanchanda has joined #openstack-cinder04:21
*** GirishChilukuri has joined #openstack-cinder04:29
*** udesale has joined #openstack-cinder04:31
*** venkatakrishnath has quit IRC04:34
*** whoami-rajat_ has joined #openstack-cinder04:41
*** whoami-rajat_ is now known as whoami-rajat04:46
*** ociuhandu has joined #openstack-cinder05:18
*** ociuhandu has quit IRC05:22
*** rcernin_ has quit IRC05:48
*** rcernin_ has joined #openstack-cinder05:49
*** m75abrams has joined #openstack-cinder06:46
*** ociuhandu has joined #openstack-cinder07:00
*** rratnaka has quit IRC07:02
*** rratnaka has joined #openstack-cinder07:05
*** ociuhandu has quit IRC07:06
*** m75abrams has quit IRC07:17
*** m75abrams has joined #openstack-cinder07:17
*** rratnaka has quit IRC07:20
*** swegener has joined #openstack-cinder07:22
*** rratnaka has joined #openstack-cinder07:23
*** vishalmanchanda has quit IRC07:36
*** zenkuro has quit IRC07:39
*** zenkuro has joined #openstack-cinder07:40
*** ociuhandu has joined #openstack-cinder07:43
*** e0ne has joined #openstack-cinder07:56
*** GirishChilukuri_ has joined #openstack-cinder08:02
*** lpetrut has joined #openstack-cinder08:04
*** GirishChilukuri has quit IRC08:06
*** GirishChilukuri has joined #openstack-cinder08:09
*** GirishChilukuri_ has quit IRC08:11
*** rpittau|afk is now known as rpittau08:24
*** rcernin_ has quit IRC08:24
*** martinkennelly has joined #openstack-cinder08:41
*** ociuhandu has quit IRC08:48
*** ociuhandu has joined #openstack-cinder08:49
*** ociuhandu has quit IRC08:49
*** e0ne has quit IRC08:51
*** GirishChilukuri has quit IRC08:52
*** _pewp_ has quit IRC08:53
*** _pewp_ has joined #openstack-cinder08:54
*** GirishChilukuri has joined #openstack-cinder08:55
*** sapd1 has joined #openstack-cinder08:57
*** tosky has joined #openstack-cinder09:02
*** ociuhandu has joined #openstack-cinder09:04
*** ociuhandu has quit IRC09:14
*** ociuhandu has joined #openstack-cinder09:15
*** ociuhandu has quit IRC09:20
*** m75abrams has quit IRC09:24
*** GirishChilukuri has quit IRC09:28
*** ociuhandu has joined #openstack-cinder09:28
*** m75abrams has joined #openstack-cinder09:32
*** udesale_ has joined #openstack-cinder09:55
*** jawad_axd has joined #openstack-cinder09:58
*** udesale has quit IRC09:59
*** manoj_katari has joined #openstack-cinder10:02
manoj_katari@core reviewers: please review these changes made for IBM SVF driver. Comments are addressed and CI is green.10:05
manoj_katarihttps://review.opendev.org/c/openstack/cinder/+/76515410:05
manoj_katarihttps://review.opendev.org/c/openstack/cinder/+/75019910:05
*** ajitha has quit IRC10:08
*** GirishChilukuri has joined #openstack-cinder10:23
*** rcernin_ has joined #openstack-cinder10:27
*** carloss has joined #openstack-cinder10:59
*** icey_ is now known as icey11:02
*** sapd1 has quit IRC11:16
*** rcernin_ has quit IRC11:26
*** Luzi has joined #openstack-cinder11:27
*** ociuhandu_ has joined #openstack-cinder11:49
*** GirishChilukuri_ has joined #openstack-cinder11:51
*** ociuhandu has quit IRC11:53
*** ociuhandu_ has quit IRC11:53
*** GirishChilukuri has quit IRC11:55
*** GirishChilukuri_ has quit IRC11:55
*** GirishChilukuri has joined #openstack-cinder11:56
*** brinzhang has quit IRC11:56
*** lpetrut has quit IRC11:56
*** ociuhandu has joined #openstack-cinder11:57
*** lpetrut has joined #openstack-cinder11:58
*** e0ne has joined #openstack-cinder12:00
*** GirishChilukuri_ has joined #openstack-cinder12:02
*** ociuhandu has quit IRC12:03
*** GirishChilukuri has quit IRC12:06
*** GirishChilukuri has joined #openstack-cinder12:06
*** GirishChilukuri_ has quit IRC12:07
*** e0ne has quit IRC12:07
*** ociuhandu has joined #openstack-cinder12:13
*** ociuhandu has quit IRC12:18
*** psachin has quit IRC12:47
*** __ministry1 has joined #openstack-cinder12:52
*** GirishChilukuri has quit IRC12:58
*** zzzeek has quit IRC13:00
*** zzzeek has joined #openstack-cinder13:02
*** knomura has joined #openstack-cinder13:03
*** enriquetaso has joined #openstack-cinder13:13
*** m75abrams has quit IRC13:15
*** vishalmanchanda has joined #openstack-cinder13:16
*** m75abrams has joined #openstack-cinder13:16
*** lbragstad has joined #openstack-cinder13:24
*** sapd1 has joined #openstack-cinder13:48
*** venkatakrishnath has joined #openstack-cinder13:52
*** tkajinam has quit IRC13:53
*** knomura has quit IRC14:02
*** manoj_katari has quit IRC14:06
*** knomura has joined #openstack-cinder14:08
*** legochen has joined #openstack-cinder14:09
*** GirishChilukuri has joined #openstack-cinder14:10
*** caiqilong has quit IRC14:13
venkatakrishnathCan someone please review https://review.opendev.org/c/openstack/cinder/+/76480414:15
jungleboyjvenkatakrishnath:  Let me do my follow up review.14:18
*** pcaruana has quit IRC14:19
venkatakrishnathjungleboyj Thanks. Update you once that patch gets Zuul +1 and CI passed14:22
knomuraCould someone please review https://review.opendev.org/c/openstack/cinder/+/77757814:22
*** rratnaka has quit IRC14:23
*** abhishekk is now known as konan14:26
*** konan is now known as abhishekk14:28
*** Luzi has quit IRC14:34
jungleboyjwhoami-rajat:  Can you make sure your comments were addressed here?  https://review.opendev.org/c/openstack/cinder/+/75019914:34
jungleboyjknomura:  Done.14:36
GirishChilukurijungleboyj Addressed review comments for this patch https://review.opendev.org/c/openstack/cinder/+/75313414:37
knomurajungleboyj: thanks for your review.14:39
*** __ministry1 has quit IRC14:41
knomurajunbleboyj: And I'd like you to review it https://review.opendev.org/c/openstack/cinder/+/77054114:44
whoami-rajatjungleboyj: will take a look14:45
*** ociuhandu has joined #openstack-cinder14:51
lbragstado/ i must specify an image_id in the volume reference when i create a volume to create a bootable volume from an image, right?14:54
lbragstadlooking at https://docs.openstack.org/api-ref/block-storage/v3/?expanded=create-a-volume-detail14:54
lbragstadi see the description eludes to that, but i don't see image_id as a request parameter14:54
eharneylbragstad: yes, i guess it's the imageRef parameter?14:55
lbragstadok14:57
lbragstadthat's what it looks like14:57
lbragstadi imagine that's a string14:57
*** ociuhandu has quit IRC14:57
eharneyyes14:58
lbragstadok - cool, trying that out quick14:59
*** rosmaita has left #openstack-cinder15:03
*** rratnaka has joined #openstack-cinder15:04
*** pcaruana has joined #openstack-cinder15:04
*** rosmaita has joined #openstack-cinder15:08
*** ociuhandu has joined #openstack-cinder15:08
*** sfernand has joined #openstack-cinder15:22
sfernandHi folks, we have 3 patches that require reviews before the feature freeze:15:28
sfernandhttps://review.opendev.org/c/openstack/cinder/+/77064915:28
sfernandhttps://review.opendev.org/c/openstack/cinder/+/77545515:28
sfernandhttps://review.opendev.org/c/openstack/cinder/+/77671315:28
sfernandrosmaita: I guess we will need a exception in order to get them merged :(15:29
rosmaitasfernand: don 't be so pessimistic15:29
*** e0ne has joined #openstack-cinder15:29
*** lpetrut has quit IRC15:29
sfernand:P15:31
*** e0ne has quit IRC15:31
*** manoj_katari has joined #openstack-cinder15:31
toskybonus point if you the features are covered by automated tests :)15:32
sfernandthey are all vendor specific, but we are already working on internal tempests for them15:35
GirishChilukuriHi Team, I am getting this error while running revert to snapshot test from cinder-tempest-plugin oslo_config.cfg.NoSuchOptError: no such option volume_revert in group [volume-feature-enabled]15:35
GirishChilukuriany suggestions on this15:35
rosmaitatosky has a good point ... it will speed up reviewing if you (meaning anyone, not just sfernand) can put a comment on your patch pointing to the log that shows your feature passing your CI15:35
GirishChilukuri[volume-feature-enabled]15:37
GirishChilukurivolume_revert = True15:37
GirishChilukuriapi_extensions = all15:37
GirishChilukuribackup = False15:37
GirishChilukurivolume-revert = True15:37
GirishChilukuriextend_attached_volume = True15:37
GirishChilukurimanage_volume = True15:37
GirishChilukurimanage_snapshot = True15:37
rosmaitaGirishChilukuri: if that is a paste, you have a hypen instead of underscore in volume_revert15:38
rosmaitanm, just saw that you have it twice15:38
GirishChilukuriI have added above entire in /etc/tempest/tempest.conf15:39
*** m75abrams has quit IRC15:39
*** e0ne has joined #openstack-cinder15:40
GirishChilukurirosmaita Initially I used volume_revert, It was failed. So itried with different combinations.15:40
toskyGirishChilukuri: do you have a link to the full log? It's almost impossible to understand what's going on with just the final error without context15:41
GirishChilukuritosky I tried it in my local vm devstack.15:42
*** rratnaka has quit IRC15:43
toskyGirishChilukuri: sure, but I guess the logs can be extracted15:45
*** ociuhandu has quit IRC15:45
*** ociuhandu has joined #openstack-cinder15:45
*** knomura has quit IRC15:45
*** e0ne has quit IRC15:47
*** ociuhandu has quit IRC15:47
*** ociuhandu has joined #openstack-cinder15:47
*** e0ne has joined #openstack-cinder15:48
*** udesale_ has quit IRC15:48
*** stephenfin has quit IRC15:53
*** stephenfin has joined #openstack-cinder15:54
lyarwoodgeguileo / tosky ; https://bugs.launchpad.net/cinder/+bug/1917750 - I think I've hit this again, just building a multinode env to confirm now. Would you mind taking a look and letting me know if I'm getting something obviously wrong here?15:55
openstackLaunchpad bug 1917750 in Cinder "Running parallel iSCSI/LVM c-vol backends is causing random failures in CI" [Undecided,New]15:55
lbragstadrosmaita ok - i have everything filled out for the first round of cinder protection tests https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/77835715:58
toskyalso eharney and enriquetaso: please see lyarwood's comment above: ^15:59
rosmaitalbragstad: thanks, will look15:59
lbragstadto my knowledge - all the tests in there test the policies in https://opendev.org/openstack/cinder/src/branch/master/cinder/policies/volumes.py15:59
lbragstadand the project-reader tests are skipped16:00
*** e0ne has quit IRC16:01
*** jv_ has quit IRC16:02
*** jv_ has joined #openstack-cinder16:02
toskylbragstad: oh, so he skip condition is in https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/778357, not in https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/772915/1016:07
toskybut on the other hand the tests in 772915 are noop16:07
toskywell, not exactly, there is one, but it is passing16:07
*** GirishChilukuri_ has joined #openstack-cinder16:14
*** GirishChilukuri has quit IRC16:17
*** GirishChilukuri has joined #openstack-cinder16:24
*** rratnaka has joined #openstack-cinder16:26
*** GirishChilukuri_ has quit IRC16:28
*** rratnaka14 has joined #openstack-cinder16:31
lbragstadtosky yep -sure16:32
lbragstadthat can be moved16:32
lbragstadrosmaita tosky  do you know what there are two different policies for controlling force delete?16:32
lbragstadhttps://opendev.org/openstack/cinder/src/branch/master/cinder/policies/volumes.py#L2716:32
lbragstadhttps://opendev.org/openstack/cinder/src/branch/master/cinder/policies/volume_actions.py#L2716:33
lbragstads/what/why/16:34
rosmaitalbragstad: looking16:35
lbragstadfrom what i can tell, the policy in volumes.py is the only one that is enforced https://opendev.org/openstack/cinder/src/branch/master/cinder/api/v3/volumes.py#L7516:35
lbragstadbut if i set this in my policy file http://paste.openstack.org/raw/803395/ it fails - but i'm not sure where that's getting picked up?16:37
*** venkatakrishnath has quit IRC16:37
*** jawad_axd has quit IRC16:42
*** jawad_axd has joined #openstack-cinder16:42
*** venkatakrishnath has joined #openstack-cinder16:42
*** jawad_axd has quit IRC16:44
rosmaitavolume:force_delete came in with microversion 3.23, not sure why it has a different policy, though16:44
rosmaitawill have to look at the spec16:44
eharneypresumably because the newer support for force delete isn't an "extension"16:49
*** jv__ has joined #openstack-cinder16:52
rosmaitalbragstad: somebody being very clever: http://paste.openstack.org/raw/803395/16:53
rosmaitathat wasn't clever16:53
rosmaitahttps://opendev.org/openstack/cinder/src/branch/master/cinder/api/contrib/admin_actions.py#L7116:53
rosmaitathat's clever16:53
lbragstadyeah.. i just stumbled across that16:54
enriquetasotosky, eharney and lyarwood: I'm looking into https://bugs.launchpad.net/cinder/+bug/1917750 but I'll bring it on tomorrow's bug report week16:54
openstackLaunchpad bug 1917750 in Cinder "Running parallel iSCSI/LVM c-vol backends is causing random failures in CI" [Undecided,New]16:54
lbragstadso - things in contrib actually use a subclassed authorize implementation that modifies the policy target16:55
lbragstadand, depending on the mv, one policy gets used over the other16:55
lbragstadiiuc16:56
eharneyi think which policy is used depends on which API you call, since they're different APIs16:56
lbragstadso - theoretically (i haven't tested this yet) but if i override "volume_extension:volume_admin_actions:force_delete" in my deployment but i don't override "volume:force_delete" - could i get different authorization behavior depending on the mv i specify in the client?16:58
lbragstadah - https://opendev.org/openstack/tempest/src/branch/master/tempest/lib/services/volume/v3/volumes_client.py#L276-L28117:00
eharneyi'm not sure i understand what you want to know17:00
lbragstadyeah - that is using the actions API17:00
eharneycalling the admin action os-force_delete uses the "extension" policy17:00
*** takamatsu has quit IRC17:00
*** openstackgerrit has joined #openstack-cinder17:00
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax Driver - Allowing for all types of boolean in extra specs  https://review.opendev.org/c/openstack/cinder/+/75242317:00
*** jv__ has quit IRC17:00
eharneythe volume:force_delete policy applies to an action taken on the volume itself, which only exists after microversion 3.2317:00
lbragstadyep - that makes sense17:01
lbragstadso - the thing i'm trying to figure out is if there is a potential for drift if one policy is overridden and the other isn't17:02
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax Driver - Check for moving to same target  https://review.opendev.org/c/openstack/cinder/+/77954017:03
eharneydrift in what sense?17:04
lbragstadif an operator overrides the "extension" policy to be tighter for some reason, but doesn't override the non-extension policy17:05
*** rpittau is now known as rpittau|afk17:05
lbragstadboth policies ultimately protect the same behavior, don't they?17:05
openstackgerritWalt proposed openstack/cinder master: Added admins view all volume_admin_metadata  https://review.opendev.org/c/openstack/cinder/+/77954117:06
eharneyfrom the user point of view, yes17:08
openstackgerritSri Harsha mekala proposed openstack/python-cinderclient master: Support passing client certificates for server version requests  https://review.opendev.org/c/openstack/python-cinderclient/+/77631117:16
*** lpetrut has joined #openstack-cinder17:18
lbragstadis there a reason to use one over the other, excluding mv availability?17:19
eharneyif you want to combine force and cascade delete you have to use the newer one17:19
* lbragstad nods17:20
*** GirishChilukuri_ has joined #openstack-cinder17:22
*** GirishChilukuri has quit IRC17:25
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax Driver - Initiator group contents check  https://review.opendev.org/c/openstack/cinder/+/76416217:31
*** venkatakrishnath has quit IRC17:37
*** ociuhandu has quit IRC17:41
*** ociuhandu has joined #openstack-cinder17:54
*** ociuhandu has quit IRC17:54
*** ociuhandu has joined #openstack-cinder17:55
openstackgerritFelipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Add support for QoS minimums specs  https://review.opendev.org/c/openstack/cinder/+/77064917:55
*** rratnaka14 has quit IRC17:57
*** rratnaka has quit IRC17:57
*** lpetrut has quit IRC18:00
*** knomura has joined #openstack-cinder18:00
*** ociuhandu has quit IRC18:02
*** ociuhandu has joined #openstack-cinder18:02
*** ociuhandu has quit IRC18:02
*** ociuhandu has joined #openstack-cinder18:03
*** knomura has quit IRC18:05
*** ociuhandu has quit IRC18:12
*** ociuhandu has joined #openstack-cinder18:16
*** GirishChilukuri_ has quit IRC18:17
*** hamalq has joined #openstack-cinder18:30
*** ociuhandu has quit IRC18:53
*** ociuhandu has joined #openstack-cinder18:54
*** takamatsu has joined #openstack-cinder18:55
*** ociuhandu has quit IRC19:01
*** manoj_katari has quit IRC19:03
*** hamalq has quit IRC19:09
*** hamalq has joined #openstack-cinder19:09
openstackgerritFelipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Add support for QoS minimums specs  https://review.opendev.org/c/openstack/cinder/+/77064919:18
*** ociuhandu has joined #openstack-cinder19:27
openstackgerritMerged openstack/cinder master: Pure Storage: check volumename length does not exceed maximum  https://review.opendev.org/c/openstack/cinder/+/76940519:34
*** ociuhandu has quit IRC19:37
*** e0ne has joined #openstack-cinder19:37
openstackgerritLance Bragstad proposed openstack/cinder master: WIP: Contemplate deprecating one of the force delete volume policies  https://review.opendev.org/c/openstack/cinder/+/77957019:40
*** ociuhandu has joined #openstack-cinder19:49
*** ociuhandu has quit IRC19:52
*** ociuhandu has joined #openstack-cinder19:52
*** e0ne has quit IRC19:56
openstackgerritLance Bragstad proposed openstack/cinder-tempest-plugin master: Implement basic protection testing jobs  https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/77291519:57
openstackgerritLance Bragstad proposed openstack/cinder-tempest-plugin master: Add basic volume protection tests  https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/77835719:57
openstackgerritLance Bragstad proposed openstack/cinder-tempest-plugin master: Remove skip tests for project-reader tests  https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/77957319:57
*** e0ne has joined #openstack-cinder19:58
*** e0ne has quit IRC19:58
openstackgerritLance Bragstad proposed openstack/cinder master: Implement project personas for volume API  https://review.opendev.org/c/openstack/cinder/+/76019919:58
*** lbragstad has quit IRC20:01
*** e0ne has joined #openstack-cinder20:11
*** lbragstad has joined #openstack-cinder20:15
*** e0ne has quit IRC20:16
openstackgerritMerged openstack/cinder master: [Pure] Fix failing consistency group tempest tests  https://review.opendev.org/c/openstack/cinder/+/77594420:24
openstackgerritMerged openstack/cinder master: Hitachi: Use get_volume_stats in the base driver  https://review.opendev.org/c/openstack/cinder/+/77054120:24
*** irclogbot_3 has quit IRC20:31
*** irclogbot_1 has joined #openstack-cinder20:32
openstackgerritGorka Eguileor proposed openstack/cinder master: Fix old attach method  https://review.opendev.org/c/openstack/cinder/+/77804720:32
openstackgerritGorka Eguileor proposed openstack/cinder master: Remove unnecessary save call  https://review.opendev.org/c/openstack/cinder/+/77804820:32
openstackgerritGorka Eguileor proposed openstack/cinder master: Fix volume OVO create method  https://review.opendev.org/c/openstack/cinder/+/77804920:32
openstackgerritGorka Eguileor proposed openstack/cinder master: Remove unused code path in attachment_delete  https://review.opendev.org/c/openstack/cinder/+/77853220:33
openstackgerritGorka Eguileor proposed openstack/cinder master: Remove unnecessary DB read  https://review.opendev.org/c/openstack/cinder/+/77853320:33
openstackgerritGorka Eguileor proposed openstack/cinder master: Fix notification information  https://review.opendev.org/c/openstack/cinder/+/77853420:33
openstackgerritGorka Eguileor proposed openstack/cinder master: Remove unnecesary db call in volume_detached  https://review.opendev.org/c/openstack/cinder/+/77853520:33
openstackgerritGorka Eguileor proposed openstack/cinder master: Expose volume_attachments in Volume OVO  https://review.opendev.org/c/openstack/cinder/+/77957620:33
*** ociuhandu has quit IRC20:33
openstackgerritGorka Eguileor proposed openstack/cinder master: Use `volume_attachment` OVO field  https://review.opendev.org/c/openstack/cinder/+/77957720:33
openstackgerritGorka Eguileor proposed openstack/cinder master: Expose group in Volume OVO  https://review.opendev.org/c/openstack/cinder/+/77957820:33
*** legochen has quit IRC20:37
*** whoami-rajat has quit IRC20:42
openstackgerritSimon Dodsley proposed openstack/cinder stable/victoria: Pure Storage: check volumename length does not exceed maximum  https://review.opendev.org/c/openstack/cinder/+/77959620:45
openstackgerritSimon Dodsley proposed openstack/cinder stable/ussuri: Pure Storage: check volumename length does not exceed maximum  https://review.opendev.org/c/openstack/cinder/+/77959720:47
openstackgerritSimon Dodsley proposed openstack/cinder stable/train: Pure Storage: check volumename length does not exceed maximum  https://review.opendev.org/c/openstack/cinder/+/77959820:48
hemnaanyone know the policy code well?20:52
hemnatrying to figure out how to make a policy disabled by default20:52
hemnare: https://review.opendev.org/c/openstack/cinder/+/77954120:53
hemnaalso, why doesn't the volume manager allow for a model update during init_host time after a call to ensure_export?20:57
hemnacreate_export() can return a model update20:58
hemnalooking at the lvm driver's ensure_export() implementation, it actually returns a model_update21:02
hemnabut the volume manager ignores it21:02
hemnaoopsie21:02
openstackgerritMerged openstack/cinder master: [Storwize] Provide IOPS based storage offering  https://review.opendev.org/c/openstack/cinder/+/75019921:02
lbragstadrosmaita ok - so here is what i have so far https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/772915/1121:16
lbragstadthe series starting there adds some protection tests21:16
lbragstadand https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/779573/1 removes skips for ProjectReader, which should fail the protection job21:17
rosmaitalbragstad: ack21:17
lbragstadhttps://review.opendev.org/c/openstack/cinder/+/760199 depends on the latest patch in the ctp series21:17
lbragstadso - the protection tests should pass with that cinder patch21:18
*** e0ne has joined #openstack-cinder21:19
lbragstadbecause of https://review.opendev.org/c/openstack/cinder/+/760199/5/.zuul.yaml21:19
*** e0ne has quit IRC21:19
toskylbragstad: sorry, one comment (with -1) on 77291521:22
hemnalooks like several drivers return a potential model_update from ensure_export()21:25
hemnawhich makes sense as the information coming back from a re-export could change in the backend21:25
hemnabut the volume manager ignores it entirely21:26
hemnalvm even returns a model_update21:26
openstackgerritSimon Dodsley proposed openstack/cinder stable/victoria: [Pure] Fix failing consistency group tempest tests  https://review.opendev.org/c/openstack/cinder/+/77960221:28
openstackgerritSimon Dodsley proposed openstack/cinder stable/ussuri: [Pure] Fix failing consistency group tempest tests  https://review.opendev.org/c/openstack/cinder/+/77960321:28
openstackgerritSimon Dodsley proposed openstack/cinder stable/train: [Pure] Fix failing consistency group tempest tests  https://review.opendev.org/c/openstack/cinder/+/77960421:29
openstackgerritLance Bragstad proposed openstack/cinder-tempest-plugin master: Implement basic protection testing jobs  https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/77291521:37
openstackgerritLance Bragstad proposed openstack/cinder-tempest-plugin master: Add basic volume protection tests  https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/77835721:37
openstackgerritLance Bragstad proposed openstack/cinder-tempest-plugin master: Remove skip tests for project-reader tests  https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/77957321:37
lbragstadtosky ^ done21:37
lbragstadall the tests continue to pass for me locally with the cinder change21:37
toskylbragstad: sorry for that final comment, I've missed it earlier21:39
toskyfor what I can see, at least the base change could go in21:39
toskylet's see if the gates agree21:39
lbragstadthe protection behavior needs some attention, it's my best guess at how to map some of the policies into the new model21:40
*** zenkuro has quit IRC22:04
openstackgerritEric Harney proposed openstack/cinder master: mypy: policy.py  https://review.opendev.org/c/openstack/cinder/+/77500822:14
openstackgerritEric Harney proposed openstack/cinder master: mypy: annotate image/glance.py  https://review.opendev.org/c/openstack/cinder/+/76606422:15
*** ociuhandu has joined #openstack-cinder22:21
*** lxkong has joined #openstack-cinder22:22
*** rcernin has joined #openstack-cinder22:24
openstackgerritEric Harney proposed openstack/cinder master: api-ref: Fix "name" parameter  https://review.opendev.org/c/openstack/cinder/+/77962222:28
*** rcernin has quit IRC22:30
*** rcernin has joined #openstack-cinder22:30
openstackgerritFelipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Add support for dynamic Adaptive QoS policy group creation  https://review.opendev.org/c/openstack/cinder/+/77545522:30
*** ociuhandu has quit IRC22:38
*** tkajinam has joined #openstack-cinder23:00

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!