Thursday, 2020-07-09

*** pcaruana has quit IRC00:03
*** hamalq has quit IRC00:09
*** knomura has joined #openstack-cinder00:14
*** knomura has quit IRC00:19
*** knomura has joined #openstack-cinder00:28
*** knomura has quit IRC00:33
*** enriquetaso has quit IRC00:35
*** vkmc_ is now known as vkmc00:54
*** lseki has quit IRC00:54
*** gouthamr_ has quit IRC00:59
*** gouthamr_ has joined #openstack-cinder01:05
*** jdillaman has quit IRC01:11
*** Liang__ has joined #openstack-cinder01:15
*** gouthamr_ has quit IRC01:25
*** gouthamr_ has joined #openstack-cinder01:37
openstackgerritwanghao proposed openstack/cinder master: Support multiple filters together for volume time comparison filter  https://review.opendev.org/74014601:40
*** gouthamr_ has quit IRC02:52
*** brinzhang has joined #openstack-cinder02:55
*** Lucas_Gray has quit IRC02:56
*** gouthamr_ has joined #openstack-cinder02:56
*** rcernin has quit IRC03:00
*** jmlowe has quit IRC03:01
*** rcernin has joined #openstack-cinder03:02
*** yaawang has quit IRC03:10
*** yaawang has joined #openstack-cinder03:10
*** brinzhang_ has joined #openstack-cinder03:11
*** brinzhang has quit IRC03:15
*** Lucas_Gray has joined #openstack-cinder03:20
*** gouthamr_ has quit IRC03:26
*** gouthamr_ has joined #openstack-cinder03:32
*** Lucas_Gray has quit IRC03:32
openstackgerritwanghao proposed openstack/cinder master: time comparison filter didn't support time zone offset  https://review.opendev.org/73441503:35
openstackgerrithaixin proposed openstack/cinder master: volume list query optimization  https://review.opendev.org/74015203:49
*** ociuhandu has joined #openstack-cinder03:56
*** gouthamr_ has quit IRC04:00
*** ociuhandu has quit IRC04:01
*** markvoelker has joined #openstack-cinder04:08
*** gouthamr_ has joined #openstack-cinder04:11
*** gouthamr_ has quit IRC04:29
*** gouthamr_ has joined #openstack-cinder04:30
*** gouthamr_ has quit IRC04:35
*** gouthamr_ has joined #openstack-cinder04:40
*** abdysn has joined #openstack-cinder05:02
*** Luzi has joined #openstack-cinder05:12
*** udesale has joined #openstack-cinder05:13
*** brinzhang0 has joined #openstack-cinder05:13
*** markvoelker has quit IRC05:13
*** markvoelker has joined #openstack-cinder05:14
*** m75abrams has joined #openstack-cinder05:15
*** brinzhang_ has quit IRC05:16
*** markvoelker has quit IRC05:18
*** Luzi has quit IRC05:19
*** zzzeek has quit IRC05:19
*** Luzi has joined #openstack-cinder05:19
*** zzzeek has joined #openstack-cinder05:23
*** lxkong has joined #openstack-cinder05:27
openstackgerritwanghao proposed openstack/cinder master: Support multiple filters together for volume time comparison filter  https://review.opendev.org/74014605:49
n-saitols05:51
n-saitosorry.05:52
*** brinzhang_ has joined #openstack-cinder05:59
*** brinzhang0 has quit IRC06:03
*** vishalmanchanda has joined #openstack-cinder06:05
openstackgerrithaixin proposed openstack/cinder-specs master: volume list query optimization  https://review.opendev.org/72607006:15
openstackgerritKazumasa Nomura proposed openstack/cinder master: Add Hitachi Block Storage Driver  https://review.opendev.org/71283206:23
*** yaawang has quit IRC06:32
*** yaawang has joined #openstack-cinder06:33
*** pcaruana has joined #openstack-cinder06:37
openstackgerritLucian Petrut proposed openstack/cinder master: smbfs: pick up remotefs method signature change  https://review.opendev.org/73995406:42
*** CeeMac has joined #openstack-cinder06:44
*** vishakha has joined #openstack-cinder06:47
*** brinzhang0 has joined #openstack-cinder06:48
*** gouthamr_ has quit IRC06:50
*** brinzhang_ has quit IRC06:51
*** gouthamr_ has joined #openstack-cinder06:52
*** knikolla has quit IRC06:54
*** sri_ has quit IRC06:54
openstackgerritRajat Dhasmana proposed openstack/cinder master: WIP: default type overrides  https://review.opendev.org/73770706:55
*** knikolla has joined #openstack-cinder06:56
*** sri_ has joined #openstack-cinder06:56
*** whoami-rajat has joined #openstack-cinder06:59
*** gouthamr_ has quit IRC07:04
openstackgerritwanghao proposed openstack/cinder master: time comparison filter didn't support time zone offset  https://review.opendev.org/73441507:05
*** gouthamr_ has joined #openstack-cinder07:05
*** gouthamr_ has quit IRC07:15
*** gouthamr_ has joined #openstack-cinder07:22
*** geguileo has joined #openstack-cinder07:31
openstackgerritGorka Eguileor proposed openstack/cinder master: Add cinder-manage command to remove file locks  https://review.opendev.org/73414407:39
*** akrog has joined #openstack-cinder07:42
*** geguileo is now known as Guest7526507:42
*** akrog is now known as geguileo07:42
*** markvoelker has joined #openstack-cinder07:43
*** gouthamr_ has quit IRC07:46
*** markvoelker has quit IRC07:48
*** m5z has quit IRC07:52
*** gouthamr_ has joined #openstack-cinder07:52
*** gouthamr_ has quit IRC07:57
*** udesale_ has joined #openstack-cinder08:00
*** Lucas_Gray has joined #openstack-cinder08:01
*** udesale has quit IRC08:03
*** gmann has quit IRC08:03
*** vkmc has quit IRC08:04
*** gmann has joined #openstack-cinder08:06
*** vkmc has joined #openstack-cinder08:07
*** m5z has joined #openstack-cinder08:09
*** gouthamr_ has joined #openstack-cinder08:09
*** udesale_ has quit IRC08:10
openstackgerritwanghao proposed openstack/cinder master: Support multiple filters together for volume time comparison filter  https://review.opendev.org/74014608:17
walshh_is anyone available to look at https://review.opendev.org/#/c/731479/ it has clean CI.  Thank you08:21
*** benj_ has quit IRC08:41
*** n-saito has quit IRC08:47
*** benj_ has joined #openstack-cinder08:58
*** tosky has joined #openstack-cinder09:10
*** udesale has joined #openstack-cinder09:12
*** whoami-rajat has quit IRC09:18
*** _pewp_ has quit IRC09:18
*** _pewp_ has joined #openstack-cinder09:19
*** rcernin has quit IRC09:23
*** aarora06 has joined #openstack-cinder09:35
aarora06rosmaita: Hi .. I had a doubt regarding this code - https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L2494 Here this conditions is checked for migrating volume via volume driver - if not force_host_copy and new_type_id is None:    But, new_type_id would always be not None in-case a user wants to retype to a new type. I think check for new_type_id is None should be removed. What do you think?09:37
openstackgerritwanghao proposed openstack/cinder master: Time comparison filter didn't support time zone offset  https://review.opendev.org/73441509:40
*** markvoelker has joined #openstack-cinder09:44
*** markvoelker has quit IRC09:48
*** jmlowe has joined #openstack-cinder10:04
*** ociuhandu has joined #openstack-cinder10:16
openstackgerritStephen Finucane proposed openstack/python-cinderclient master: trivial: Drop references to os-testr  https://review.opendev.org/74022310:22
*** jmlowe has quit IRC10:24
*** jmlowe has joined #openstack-cinder10:25
*** Liang__ has quit IRC10:28
*** tkajinam has quit IRC11:02
*** markvoelker has joined #openstack-cinder11:19
*** markvoelker has quit IRC11:24
openstackgerritAlex Deiter proposed openstack/cinder master: Creating snapshot on NFS backend fails  https://review.opendev.org/73927711:27
openstackgerritGorka Eguileor proposed openstack/cinderlib master: RBD: Fix error on disconnect  https://review.opendev.org/73822611:37
*** jungleboyj has quit IRC11:46
*** jungleboyj_ is now known as jungleboyj11:46
*** whoami-rajat has joined #openstack-cinder11:46
*** bhagyashris is now known as bhagyashris|brb12:04
*** raghavendrat has joined #openstack-cinder12:10
rosmaitaaarora06: look at the method signature at line 2473.  Also, i believe this code is also used for the os-migrate_volume¬†action, which does not specify a target volume_type, so the new_type_id can be None12:24
openstackgerritMerged openstack/cinder stable/ussuri: Disable siblings for the cinderlib functional tests  https://review.opendev.org/73897812:27
openstackgerritMerged openstack/cinderlib master: Stop to use the __future__ module.  https://review.opendev.org/73282312:27
aarora06rosmaita: yes, it can be None. But, for retype also, migrate_volume is called - which is because some drivers implement only migrate_volume and do not perform normal retype. In case of retype, new_type_id is not None. Also, for retype it will always go into migrate volume generic method.12:29
rosmaitaaarora06: not sure i understand your point12:34
*** bhagyashris|brb is now known as bhagyashris12:37
aarora06This is the migrate_volume call to the driver method: https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L2497 .. I am saying this should be accessible to drivers during retype. This is the migrate_volume call from retype: https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L2925 ..12:38
openstackgerritLuigi Toscano proposed openstack/cinder stable/train: Disable siblings for the cinderlib functional tests  https://review.opendev.org/74026312:39
*** andrebeltrami has joined #openstack-cinder12:40
aarora06rosmaita: https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L2872 So, if https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L2872 - driver retype call fails, the driver resorts to migrate_volume. But, because new_type_id will not be None during retype, migrate_volume of the driver code will never be called for migration_policy of 'on-demand' during retype call.12:40
raghavendrathi reviewers,12:40
raghavendratthis is regarding https://review.opendev.org/#/c/739033/ and https://review.opendev.org/#/c/739468/12:40
raghavendratfor both patches, zuul and CI have passed. Appreciate if someone can have a look.12:41
rosmaitaaarora06: since you originally asked me what I thought, i think that i personally do not like changing method signatures that have been around a long time, and as long as new_type_id has a default of None, that check must remain in that function.  I don't know what else to tell you12:44
openstackgerrithaixin proposed openstack/cinder master: volume list query optimization  https://review.opendev.org/74015212:46
aarora06rosmaita: We can probably have that enabled for retype if it is not None. Maybe we can pass a special parameter when migrate_volume is called from retype (something like retype=True) and enable driver migrate_volume call?12:47
rosmaitaaarora06: you need to give me some context for this -- has it caused some kind of problem?12:49
*** lseki has joined #openstack-cinder12:51
aarora06rosmaita: yes .. it did cause an issue specific to a driver. That driver did not implement retype method but had implemented migrate_volume method. So, it kind of relied on migrate_volume method during retype. Not sure if that is correct on the driver part. (I am not sure if I can tell the name of that driver on public forum)12:52
rosmaitaif it's a driver in the cinder source code repo, then you can mention it12:52
aarora06rosmaita: Nope .. it is not there in cinder source code repo.12:53
rosmaitabut it seems that if the driver is relying on the generic method to perform retype, then it should be passing the new_type_id in that case.  This seems like a driver bug, not a cinder bug12:54
aarora06rosmaita: okay. sure .. thank you for the reply.12:55
rosmaitaaarora06: np12:55
openstackgerritElod Illes proposed openstack/cinder stable/stein: Revert "Make greande jobs n-v for EM and oldest stable"  https://review.opendev.org/74027213:00
rosmaitastable cores: please take a look at https://review.opendev.org/#/c/736749/ to finally close out OSSN-008613:03
rosmaitae0ne eharney geguileo jungleboyj smcginnis ^^13:03
openstackgerritLucian Petrut proposed openstack/cinder master: smbfs: pick up remotefs method signature change  https://review.opendev.org/73995413:05
*** e0ne has joined #openstack-cinder13:06
*** raghavendrat has quit IRC13:06
*** e0ne has quit IRC13:07
* jungleboyj is happy to have IRC Cloud back.13:12
*** e0ne has joined #openstack-cinder13:18
*** mindthecap has joined #openstack-cinder13:51
*** e0ne has quit IRC14:03
*** e0ne has joined #openstack-cinder14:03
*** mindthecap has left #openstack-cinder14:10
*** abdysn has quit IRC14:24
*** aarora06 has quit IRC14:28
openstackgerritMerged openstack/os-brick stable/queens: Fix "Remove VxFlex OS credentials" regression  https://review.opendev.org/73674914:42
*** e0ne has quit IRC14:44
*** bhagyashris is now known as bhagyashris|dinn14:52
*** vishalmanchanda has quit IRC14:54
openstackgerritKeith Berger proposed openstack/os-brick stable/pike: Fix "Remove VxFlex OS credentials" regression  https://review.opendev.org/74031814:54
*** Lucas_Gray has quit IRC14:55
*** Luzi has quit IRC14:56
rosmaitaKeithMnemonic: have you seen http://lists.openstack.org/pipermail/openstack-discuss/2020-July/015838.html ?15:00
KeithMnemonicyes but i have 13 days ?15:02
KeithMnemonicor am i too late15:02
*** sfernand has joined #openstack-cinder15:03
rosmaitanot sure ... depends on the gate situation15:06
KeithMnemonicwell there is this https://review.opendev.org/#/c/737094/ if someone wants to push it through15:08
*** abhishekk is now known as abhishekk-afk15:09
*** Lucas_Gray has joined #openstack-cinder15:11
rosmaitaKeithMnemonic: i don't know how i feel about that, i'd really prefer pike and ocata to go EOL so we're not spending a lot of time fixing stuff for little gain15:11
*** ganso has quit IRC15:13
*** dviroel_ is now known as dviroel15:15
KeithMnemonicfair enough, never hurts to ask though ;-)15:15
rosmaitayeah, and we can see if there's any response to the EOL proposal on the ML15:16
*** ganso has joined #openstack-cinder15:17
lsekiHi folks, can I have another look at this backport, please?15:19
lsekihttps://review.opendev.org/#/c/738124/15:19
openstackgerritSimon O'Donovan proposed openstack/cinder master: PowerMax Driver - Failover abilities legacy improvements  https://review.opendev.org/74032115:25
*** m75abrams has quit IRC15:36
*** bhagyashris|dinn is now known as bhagyashris15:49
*** geguileo has quit IRC16:02
*** geguileo has joined #openstack-cinder16:03
*** udesale_ has joined #openstack-cinder16:08
*** whoami-rajat has quit IRC16:08
*** udesale has quit IRC16:10
*** hamalq has joined #openstack-cinder16:18
*** hamalq_ has joined #openstack-cinder16:19
*** hamalq has quit IRC16:22
*** ociuhandu_ has joined #openstack-cinder16:23
*** abhishekk-afk is now known as abhishekk16:26
*** ociuhandu has quit IRC16:27
*** udesale_ has quit IRC16:27
*** ociuhandu_ has quit IRC16:28
*** patrickeast_ has joined #openstack-cinder16:47
*** andreaf has quit IRC16:48
*** mnasiadka_ has joined #openstack-cinder16:48
*** simondodsley_ has joined #openstack-cinder16:48
openstackgerritLucian Petrut proposed openstack/cinder master: smbfs: pick up remotefs method signature change  https://review.opendev.org/73995416:48
*** whoami-rajat has joined #openstack-cinder16:49
*** dasp_ has joined #openstack-cinder16:49
*** patrickeast has quit IRC16:55
*** simondodsley has quit IRC16:55
*** coreycb has quit IRC16:55
*** carloss has quit IRC16:55
*** mnasiadka has quit IRC16:55
*** dasp has quit IRC16:55
*** mnasiadka_ is now known as mnasiadka16:55
*** patrickeast_ is now known as patrickeast16:55
*** simondodsley_ is now known as simondodsley16:55
*** coreycb has joined #openstack-cinder16:58
*** carloss has joined #openstack-cinder16:58
*** whoami-rajat has quit IRC17:17
*** whoami-rajat has joined #openstack-cinder17:18
*** Lucas_Gray has quit IRC17:19
*** ajitha has joined #openstack-cinder17:44
hemnaok so latest ceph-iscsi is that it passes all the same tempest tests as rbd driver does17:49
hemnagoing to put up some updates to my ceph-iscsi chain of reviews17:49
*** andrebeltrami has quit IRC18:00
*** vishakha has quit IRC18:50
*** ajitha has quit IRC19:08
*** tosky has quit IRC19:26
*** whoami-rajat has quit IRC19:40
*** ociuhandu has joined #openstack-cinder20:12
*** geguileo has quit IRC20:12
*** geguileo has joined #openstack-cinder20:13
*** _pewp_ has quit IRC20:19
*** _pewp_ has joined #openstack-cinder20:20
*** ociuhandu has quit IRC20:31
*** ociuhandu has joined #openstack-cinder20:47
openstackgerritGhanshyam Mann proposed openstack/devstack-plugin-open-cas master: DNM: testing focal  https://review.opendev.org/74037420:49
*** ociuhandu has quit IRC20:59
*** eharney has quit IRC21:42
*** tkajinam has joined #openstack-cinder23:00

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!