Thursday, 2016-08-25

*** Suyi has quit IRC00:00
*** mtanino has quit IRC00:00
*** leeantho has quit IRC00:01
*** Julien-zte has quit IRC00:02
openstackgerritMerged openstack/cinder: Datera driver 2.2 update  https://review.openstack.org/35253300:04
*** lprice has joined #openstack-cinder00:04
*** bwallis has quit IRC00:05
openstackgerritMerged openstack/cinder: Group specs: Fix exception name  https://review.openstack.org/35882900:05
*** cknight1 has quit IRC00:06
*** cknight has joined #openstack-cinder00:07
*** david-lyle has quit IRC00:08
*** lprice has quit IRC00:11
*** yangyapeng has quit IRC00:12
*** chlong has quit IRC00:13
*** gouthamr_ has joined #openstack-cinder00:13
*** qeelee has joined #openstack-cinder00:14
*** gouthamr has quit IRC00:16
*** ducttape_ has quit IRC00:21
*** sdague has joined #openstack-cinder00:22
openstackgerritMerged openstack/os-brick: Fix iSCSI multipath cleanup  https://review.openstack.org/23113400:22
*** chlong has joined #openstack-cinder00:26
*** faiz89 has quit IRC00:28
*** laughterwym has joined #openstack-cinder00:30
*** laughterwym has quit IRC00:30
*** laughterwym has joined #openstack-cinder00:31
*** rmcall has quit IRC00:31
*** rmcall has joined #openstack-cinder00:33
*** ducttape_ has joined #openstack-cinder00:35
*** ducttape_ has quit IRC00:40
*** bardia has quit IRC00:40
*** Julien-zte has joined #openstack-cinder00:42
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/35950800:43
*** raunak has quit IRC00:44
openstackgerritMerged openstack/cinder: Use original volume OVO instance in create flow  https://review.openstack.org/34422400:48
openstackgerritMerged openstack/cinder: Use OVOs to set errors in manage volume/snapshot  https://review.openstack.org/35306800:48
*** ducttape_ has joined #openstack-cinder00:50
*** ducttape_ has quit IRC00:51
*** markvoelker has joined #openstack-cinder00:55
*** alonma has joined #openstack-cinder00:56
*** Julien-zte has quit IRC00:59
*** alonma has quit IRC01:01
*** tommylikehu has joined #openstack-cinder01:02
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/35950801:04
*** Julien-zte has joined #openstack-cinder01:04
*** tommylikehu has quit IRC01:06
*** sdake has quit IRC01:06
*** cknight has quit IRC01:07
*** lixiaoy1 has quit IRC01:07
*** lixiaoy1 has joined #openstack-cinder01:07
*** cknight has joined #openstack-cinder01:07
*** jamielennox is now known as jamielennox|away01:11
*** jamielennox|away is now known as jamielennox01:11
openstackgerritMerged openstack/cinder: TrivialFix: Remove logging import unused  https://review.openstack.org/35973301:13
*** raunak has joined #openstack-cinder01:13
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/35950801:14
*** yangyapeng has joined #openstack-cinder01:18
*** ebalduf has quit IRC01:22
openstackgerritDao Cong Tien proposed openstack/cinder: Stop using mox from unit/image/*.py  https://review.openstack.org/35572101:25
*** cknight1 has joined #openstack-cinder01:25
*** cknight has quit IRC01:25
*** Apoorva has quit IRC01:29
*** faiz89 has joined #openstack-cinder01:29
*** faiz89 has quit IRC01:34
*** raunak has quit IRC01:35
*** markvoelker has quit IRC01:36
*** sdake has joined #openstack-cinder01:36
openstackgerritCao Xuan Hoang proposed openstack/cinder: TrivialFix: Remove cfg import unused  https://review.openstack.org/36016701:36
*** yangyape_ has joined #openstack-cinder01:36
*** yangyapeng has quit IRC01:38
*** sdague has quit IRC01:38
*** Lee1092 has joined #openstack-cinder01:39
*** sdake_ has joined #openstack-cinder01:39
openstackgerritMerged openstack/os-brick: Mask out passwords when tracing  https://review.openstack.org/35437001:41
*** sdake has quit IRC01:42
*** yangyapeng has joined #openstack-cinder01:47
*** yangyape_ has quit IRC01:47
*** ducttape_ has joined #openstack-cinder01:52
*** sdake_ has quit IRC01:54
*** ducttape_ has quit IRC01:57
*** mtanino has joined #openstack-cinder01:58
*** zhangguoqing has joined #openstack-cinder01:58
*** yangyape_ has joined #openstack-cinder01:59
openstackgerritRui Chen proposed openstack/python-cinderclient: Fix NoneType error for cinderclient v1  https://review.openstack.org/35956301:59
*** yangyapeng has quit IRC02:01
*** xianghui has quit IRC02:03
*** xianghui has joined #openstack-cinder02:03
*** xianghui has quit IRC02:04
*** sdake has joined #openstack-cinder02:04
*** xianghui has joined #openstack-cinder02:04
*** xianghui has quit IRC02:04
*** gouthamr_ is now known as gouthamr02:05
*** xianghui has joined #openstack-cinder02:11
*** bigdogstl has joined #openstack-cinder02:12
*** ducttape_ has joined #openstack-cinder02:15
*** raunak has joined #openstack-cinder02:20
*** laughterwym has quit IRC02:20
*** laughterwym has joined #openstack-cinder02:21
*** thiagolib has quit IRC02:27
*** thiagolib has joined #openstack-cinder02:28
*** serverascode has quit IRC02:28
*** mtanino has quit IRC02:31
*** serverascode has joined #openstack-cinder02:31
*** yangyapeng has joined #openstack-cinder02:32
openstackgerritxianming.mao proposed openstack/python-cinderclient: Update flake  https://review.openstack.org/35958402:34
*** sdake has quit IRC02:34
*** sdake has joined #openstack-cinder02:35
*** yangyape_ has quit IRC02:35
*** julim has quit IRC02:35
*** zhangguoqing has quit IRC02:38
*** bswartz has quit IRC02:38
openstackgerritlijunli proposed openstack/cinder: When only .pyc left, the extended API cannot be used.  https://review.openstack.org/36018602:39
*** sdake has quit IRC02:45
*** alonma has joined #openstack-cinder02:46
*** ducttape_ has quit IRC02:46
*** sdake has joined #openstack-cinder02:47
*** alonma has quit IRC02:50
*** raunak has quit IRC02:51
*** cknight has joined #openstack-cinder02:53
*** ducttape_ has joined #openstack-cinder02:53
*** cknight1 has quit IRC02:54
*** cknight1 has joined #openstack-cinder02:59
*** smile-luobin has quit IRC02:59
*** cknight has quit IRC03:00
*** smile-luobin has joined #openstack-cinder03:00
*** cknight1 has quit IRC03:06
*** cknight has joined #openstack-cinder03:07
*** raunak has joined #openstack-cinder03:09
*** jamielennox is now known as jamielennox|away03:09
*** bardia has joined #openstack-cinder03:10
*** sdake has quit IRC03:12
*** gcb_ has joined #openstack-cinder03:16
*** ducttape_ has quit IRC03:16
*** alonma has joined #openstack-cinder03:17
*** salv-orlando has joined #openstack-cinder03:17
*** salv-orl_ has quit IRC03:20
*** alonma has quit IRC03:22
*** ducttape_ has joined #openstack-cinder03:22
*** chlong has quit IRC03:23
*** cknight has quit IRC03:23
*** jamielennox|away is now known as jamielennox03:23
*** ducttape_ has quit IRC03:26
*** bigdogstl has quit IRC03:27
*** yangyapeng has quit IRC03:29
openstackgerritavnish proposed openstack/cinder: Use upper constraints for all jobs in tox.ini  https://review.openstack.org/35964003:30
*** dkehn_ has quit IRC03:31
*** bigdogstl has joined #openstack-cinder03:31
*** Julien-zte has quit IRC03:32
*** rmcall has quit IRC03:33
*** rmcall has joined #openstack-cinder03:33
*** yangyapeng has joined #openstack-cinder03:35
*** bigdogstl has quit IRC03:35
*** chlong has joined #openstack-cinder03:35
*** ManishD has joined #openstack-cinder03:36
*** yangyapeng has quit IRC03:38
*** chlong has quit IRC03:38
*** yangyapeng has joined #openstack-cinder03:38
*** chlong has joined #openstack-cinder03:38
*** gcb_ has quit IRC03:39
*** bigdogstl has joined #openstack-cinder03:40
*** yangyapeng has quit IRC03:40
*** yangyapeng has joined #openstack-cinder03:41
*** EinstCrazy has joined #openstack-cinder03:41
*** Julien-zte has joined #openstack-cinder03:41
ManishDhello Guys, please can you review my patch: https://review.openstack.org/#/c/357131/03:42
*** raunak has quit IRC03:42
*** dkehn_ has joined #openstack-cinder03:43
*** zhangguoqing has joined #openstack-cinder03:45
*** raunak has joined #openstack-cinder03:46
*** bigdogstl has quit IRC03:47
*** alonma has joined #openstack-cinder03:49
*** bigdogstl has joined #openstack-cinder03:49
*** yangyape_ has joined #openstack-cinder03:49
*** coolsvap_ has joined #openstack-cinder03:50
*** bigdogstl has quit IRC03:51
*** yangyapeng has quit IRC03:52
*** alonma has quit IRC03:54
*** bigdogstl has joined #openstack-cinder03:54
*** bardia has quit IRC03:56
openstackgerritxing-yang proposed openstack/cinder: Add group snapshots  https://review.openstack.org/32805203:56
*** raunak has quit IRC03:57
*** raunak has joined #openstack-cinder03:58
openstackgerritxing-yang proposed openstack/cinder: Add group snapshots  https://review.openstack.org/32805204:00
openstackgerritLisaLi proposed openstack/cinder: Recover volume status after remove_export  https://review.openstack.org/36021104:03
*** mtanino has joined #openstack-cinder04:08
*** raunak has quit IRC04:12
*** gaurangt has joined #openstack-cinder04:12
*** bswartz has joined #openstack-cinder04:13
*** rmcall has quit IRC04:13
openstackgerritlijunli proposed openstack/cinder: When only .pyc left, the extended API cannot be used.  https://review.openstack.org/36018604:15
*** alonma has joined #openstack-cinder04:20
*** ducttape_ has joined #openstack-cinder04:23
*** EinstCrazy has quit IRC04:24
*** alonma has quit IRC04:25
openstackgerritMerged openstack/cinder: Dell SC: Live Volume Autofailover  https://review.openstack.org/35078204:25
*** ducttape_ has quit IRC04:28
*** raunak has joined #openstack-cinder04:29
*** bigdogstl has quit IRC04:30
*** gaurangt has left #openstack-cinder04:32
*** bardia has joined #openstack-cinder04:33
*** laughter_ has joined #openstack-cinder04:36
*** links has joined #openstack-cinder04:37
*** gouthamr has quit IRC04:39
*** laughterwym has quit IRC04:39
*** alonma has joined #openstack-cinder04:39
*** aswadr_ has joined #openstack-cinder04:41
*** alonma has quit IRC04:44
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/35950804:47
*** ManishD has quit IRC04:52
*** ManishD has joined #openstack-cinder04:52
*** mtanino has quit IRC04:53
openstackgerritxianming.mao proposed openstack/cinder: Drop unused logging import  https://review.openstack.org/36022504:54
*** Poornima has joined #openstack-cinder04:55
*** shausy has joined #openstack-cinder04:56
*** lkuchlan has joined #openstack-cinder04:57
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/35950804:57
*** raunak has quit IRC04:59
*** raunak has joined #openstack-cinder05:00
openstackgerritxianming.mao proposed openstack/cinder: Drop unused logging import  https://review.openstack.org/35836605:02
*** pdeore has joined #openstack-cinder05:06
*** scottda has quit IRC05:06
*** sumit has joined #openstack-cinder05:08
*** EinstCrazy has joined #openstack-cinder05:09
*** alonma has joined #openstack-cinder05:11
*** EinstCrazy has quit IRC05:11
*** alonma has quit IRC05:15
*** raunak has quit IRC05:17
*** nkrinner_afk is now known as nkrinner05:22
*** bardia has quit IRC05:22
*** lixiaoy1 has quit IRC05:23
*** akerr_ is now known as akerr_away05:23
*** ducttape_ has joined #openstack-cinder05:25
*** harlowja_at_home has joined #openstack-cinder05:25
*** lixiaoy1 has joined #openstack-cinder05:27
*** lpetrut has joined #openstack-cinder05:29
*** ducttape_ has quit IRC05:29
*** kaisers_ has joined #openstack-cinder05:32
*** shausy has quit IRC05:33
*** lkuchlan has quit IRC05:33
*** shausy has joined #openstack-cinder05:33
*** Poornima has quit IRC05:39
*** laughter_ has quit IRC05:41
*** laughterwym has joined #openstack-cinder05:41
*** alonma has joined #openstack-cinder05:42
*** david-lyle has joined #openstack-cinder05:43
*** Poornima has joined #openstack-cinder05:44
*** harlowja_at_home has quit IRC05:45
*** alonma has quit IRC05:47
openstackgerritAvishay Traeger proposed openstack/python-cinderclient: List manageable volumes and snapshots  https://review.openstack.org/35127505:52
*** pbandark has joined #openstack-cinder05:52
openstackgerritxianming.mao proposed openstack/cinder-specs: Update homepage with developer documentation page  https://review.openstack.org/35700305:52
openstackgerritxianming.mao proposed openstack/python-cinderclient: Update flake  https://review.openstack.org/35958405:53
openstackgerritxianming.mao proposed openstack/cinder-specs: Update flake8  https://review.openstack.org/35955505:53
*** lkuchlan has joined #openstack-cinder05:54
*** Poornima has quit IRC05:56
*** e0ne has joined #openstack-cinder05:57
*** Poornima has joined #openstack-cinder05:58
*** sandanar has joined #openstack-cinder05:58
openstackgerritMerged openstack/cinder: Fix incorrect parameter in create_key  https://review.openstack.org/35867006:04
*** zhangguoqing has quit IRC06:05
*** rajinir has quit IRC06:05
*** zhangguoqing has joined #openstack-cinder06:05
*** Poornima has quit IRC06:08
*** david-lyle has quit IRC06:09
*** alonma has joined #openstack-cinder06:14
*** alonma has quit IRC06:18
*** Poornima has joined #openstack-cinder06:23
*** shausy has quit IRC06:24
*** shausy has joined #openstack-cinder06:24
*** ducttape_ has joined #openstack-cinder06:26
*** rcernin has joined #openstack-cinder06:28
*** ducttape_ has quit IRC06:30
*** lpetrut has quit IRC06:31
*** lixiaoy1 has quit IRC06:33
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Imported Translations from Zanata  https://review.openstack.org/35762306:34
openstackgerritxianming.mao proposed openstack/cinder: Drop unused logging import  https://review.openstack.org/35836606:36
*** Poornima has quit IRC06:36
*** Poornima has joined #openstack-cinder06:38
*** lixiaoy1 has joined #openstack-cinder06:38
*** lkuchlan has quit IRC06:41
*** arecknag has joined #openstack-cinder06:45
*** alonma has joined #openstack-cinder06:45
*** zhangguoqing has quit IRC06:46
*** zhangguoqing has joined #openstack-cinder06:47
*** yangyapeng has joined #openstack-cinder06:48
*** lpetrut has joined #openstack-cinder06:48
*** alonma has quit IRC06:49
*** yangyape_ has quit IRC06:50
*** salv-orlando has quit IRC06:51
*** yangyape_ has joined #openstack-cinder06:53
*** yangyapeng has quit IRC06:53
*** yangyapeng has joined #openstack-cinder06:55
*** yangyape_ has quit IRC06:58
*** laughterwym has quit IRC06:59
*** laughterwym has joined #openstack-cinder07:01
*** tesseract- has joined #openstack-cinder07:08
nikeshm_DuncanT: hi07:14
DuncanTHi07:14
nikeshm_DuncanT: small fix https://review.openstack.org/#/c/359758, if you get time please look07:14
nikeshm_for kaminario07:14
nikeshm_1 2 line change07:15
nikeshm_1-2 line change07:15
nikeshm_drivers07:15
nikeshm_CI and jenkins happy07:15
nikeshm_xyang also gave +207:15
nikeshm_DuncanT: thanks07:16
DuncanTnikeshm_: Done. Great commit message, makes it nice and easy to review :-)07:16
nikeshm_:)07:17
*** alonma has joined #openstack-cinder07:17
*** lpetrut has quit IRC07:19
*** alonma has quit IRC07:21
swamireddyDuncanT: Hi ...07:22
DuncanTswamireddy: Hi. I've got your patch on my screen right now. Just wondering if I care about the two stype nits :-)07:22
DuncanT*style07:22
DuncanTswamireddy: Approved. Details like that should be covered by an automatic tool I think07:24
*** ducttape_ has joined #openstack-cinder07:26
swamireddyDuncanT: Thanks...07:26
swamireddyDuncanT: please let me know, if need to fix the nits here?07:28
DuncanTswamireddy: A cleanup patch would be nice. Doesn't need a bug or anything, just put "Cleanup of minor code style nits from review XXXXX" in the commit message07:29
*** AndyWojo has quit IRC07:29
swamireddyDuncanT: Got it...07:30
DuncanTThanks. No mad rush on it07:31
*** ducttape_ has quit IRC07:31
*** e0ne has quit IRC07:32
swamireddyDuncanT: sure will take care of this... Thank you very much07:32
*** AndyWojo has joined #openstack-cinder07:32
*** e0ne has joined #openstack-cinder07:33
swamireddyDuncanT:  I will be submitting the patches for backup and snapshot summary also... (similar to volume summary and will take care these nits)07:34
DuncanTswamireddy: Perfect07:34
openstackgerritCao ShuFeng proposed openstack/python-cinderclient: Enhance help message of upload_to_image  https://review.openstack.org/35967807:35
*** sheel has joined #openstack-cinder07:37
*** alonma has joined #openstack-cinder07:48
*** alonma has quit IRC07:53
*** salv-orl_ has joined #openstack-cinder07:59
*** salv-orl_ has quit IRC07:59
*** zzzeek has quit IRC08:00
*** salv-orl_ has joined #openstack-cinder08:00
*** zzzeek has joined #openstack-cinder08:00
openstackgerritlijunli proposed openstack/cinder: When only .pyc left, the extended API can not be used.  https://review.openstack.org/36018608:05
*** laughterwym has quit IRC08:06
*** laughterwym has joined #openstack-cinder08:09
openstackgerritDavanum Srinivas (dims) proposed openstack/cinder: [WIP] Testing latest u-c  https://review.openstack.org/30376608:10
*** alonma has joined #openstack-cinder08:11
*** yuriy_n17 has quit IRC08:11
*** alonma has quit IRC08:15
*** zhangguoqing has quit IRC08:16
*** laughterwym has quit IRC08:19
*** pgadiya has joined #openstack-cinder08:23
*** ducttape_ has joined #openstack-cinder08:27
openstackgerritMerged openstack/cinder: Retype issue in Kaminario Cinder drivers  https://review.openstack.org/35975808:27
openstackgerritMichal Dulko proposed openstack/cinder: OVO request_spec in migrate/manage/retype calls  https://review.openstack.org/25245808:29
openstackgerritMichal Dulko proposed openstack/cinder: Switch request_spec_list in create CG to OVO  https://review.openstack.org/25303308:29
openstackgerritMichal Dulko proposed openstack/cinder: Convert filter_properties to OVO (create, retype)  https://review.openstack.org/25730508:29
*** laughterwym has joined #openstack-cinder08:30
openstackgerritMerged openstack/cinder: Add volumes/summary API support  https://review.openstack.org/33506708:30
*** ducttape_ has quit IRC08:32
*** jordanP has joined #openstack-cinder08:32
*** andymaier has joined #openstack-cinder08:34
*** laughterwym has quit IRC08:35
*** lkuchlan has joined #openstack-cinder08:35
*** sborkows has joined #openstack-cinder08:36
*** Julien-zte has quit IRC08:41
*** alonma has joined #openstack-cinder08:43
*** aarefiev_ has joined #openstack-cinder08:43
*** zul has joined #openstack-cinder08:46
*** alonma has quit IRC08:47
*** aarefiev has quit IRC08:47
*** openstackgerrit has quit IRC08:48
*** openstackgerrit has joined #openstack-cinder08:49
*** aarefiev_ is now known as aarefiev08:50
*** jordanP has quit IRC08:56
*** jordanP has joined #openstack-cinder08:57
*** yuriy_n17 has joined #openstack-cinder08:57
dulek#success multinode grenade job is testing rolling upgrades on every Cinder patch (non-voting for now)! :)08:58
openstackstatusdulek: Added success to Success page08:58
*** lixiaoy1 has quit IRC09:08
*** lixiaoy1 has joined #openstack-cinder09:09
*** alonma has joined #openstack-cinder09:14
*** salv-orlando has joined #openstack-cinder09:18
*** e0ne has quit IRC09:18
*** sayalilunkad has quit IRC09:18
*** alonma has quit IRC09:18
*** lixiaoy1 has quit IRC09:18
*** sayalilunkad has joined #openstack-cinder09:20
*** salv-orl_ has quit IRC09:20
*** dkehn_ has quit IRC09:22
*** kaisers_ has quit IRC09:23
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/35950809:23
*** yuriy_n17 has quit IRC09:26
*** Poornima has quit IRC09:27
*** ducttape_ has joined #openstack-cinder09:28
*** e0ne has joined #openstack-cinder09:31
*** Poornima has joined #openstack-cinder09:31
*** ducttape_ has quit IRC09:33
*** zul has quit IRC09:33
openstackgerritYuriy Nesenenko proposed openstack/cinder: Deleting volume metadata keys with a single request  https://review.openstack.org/32839909:36
e0nedulek: good news!09:36
*** kaisers_ has joined #openstack-cinder09:37
*** zul has joined #openstack-cinder09:38
*** dkehn_ has joined #openstack-cinder09:39
duleke0ne: I hoped Cinder would achieve assert:support-rolling-upgrades tag in Newton, but this would require a voting job running and this will take some time to make sure the job is stable. But well - it's still cool. :)09:40
*** pbandark has quit IRC09:41
openstackgerritMichal Dulko proposed openstack/cinder: Pin RPC server's serializer to min obj version  https://review.openstack.org/35053409:42
*** alonma has joined #openstack-cinder09:45
openstackgerritNguyen Phuong An proposed openstack/cinder: Replace 'self' by 'cls' in classmethod  https://review.openstack.org/36038209:46
*** pbandark has joined #openstack-cinder09:48
*** mkoderer__ has joined #openstack-cinder09:48
*** Poornima has quit IRC09:50
*** alonma has quit IRC09:50
openstackgerritCao ShuFeng proposed openstack/python-cinderclient: Enhance help message of upload_to_image  https://review.openstack.org/35967810:02
openstackgerritxiaoqin proposed openstack/cinder: Storwize: remove SCSI LUN ID during volume attaching  https://review.openstack.org/36039410:04
*** e0ne has quit IRC10:09
openstackgerritDavanum Srinivas (dims) proposed openstack/cinder: [WIP] Testing latest u-c  https://review.openstack.org/30376610:10
*** alonma has joined #openstack-cinder10:17
*** lpetrut has joined #openstack-cinder10:17
*** alonma has quit IRC10:21
openstackgerritVipin Balachandran proposed openstack/cinder: Driver documentation cleanup  https://review.openstack.org/35767110:28
*** ducttape_ has joined #openstack-cinder10:29
*** ducttape_ has quit IRC10:34
*** newcomer25 has joined #openstack-cinder10:34
openstackgerritlijunli proposed openstack/cinder: When only .pyc left, the extended API can not be used.  https://review.openstack.org/36018610:34
*** newcomer25 has left #openstack-cinder10:36
flip214how can I tell "openstack image create" which cinder backend to use?10:37
jgriffithflip214: same as any other time... it's just a special create10:42
jgriffithflip214: the "openstack image create" is actually the equiv glance call I believe?10:43
flip214possibly, yes.10:44
jgriffithflip214: that wasn't really a question :)10:44
jgriffithflip214: it was a statement :)10:44
*** Digvijay has joined #openstack-cinder10:44
flip214and on "nova boot --block-device source=image,..."?10:44
*** alonma has joined #openstack-cinder10:45
flip214is the volume always in the same backend as the image?10:45
jgriffithflip214: no10:45
eantyshevHello! Can I ask for reviews in https://review.openstack.org/276465, please?10:46
jgriffithflip214: and typically images aren't on a Cinder backend unless you set that up10:46
*** gaurangt has joined #openstack-cinder10:47
*** gaurangt has left #openstack-cinder10:48
flip214jgriffith: yeah, that's what we want to do, so that image cloning is only a thin snapshot...10:49
flip214thank you very much for the quick answers, BTW10:49
*** alonma has quit IRC10:49
*** sdague has joined #openstack-cinder10:51
*** yangyapeng has quit IRC10:57
flip214"glance image-upload" can't pass a cinder backend in, too10:57
*** vbala has joined #openstack-cinder10:58
sdaguefyi - that cinder unit test oom is the #1 tracked gate fail right now - http://status.openstack.org/elastic-recheck/gate.html#161656110:58
*** alyson_ has joined #openstack-cinder11:03
*** alonma has joined #openstack-cinder11:03
*** akerr_away is now known as akerr_11:03
*** timcl has joined #openstack-cinder11:05
*** sandanar_ has joined #openstack-cinder11:07
*** alonma has quit IRC11:07
*** sandanar_ has quit IRC11:09
*** sandanar__ has joined #openstack-cinder11:09
*** sdague has quit IRC11:10
*** sandanar has quit IRC11:10
*** gaurangt has joined #openstack-cinder11:12
*** gaurangt has left #openstack-cinder11:16
*** sdague has joined #openstack-cinder11:24
*** sheel has quit IRC11:26
openstackgerritGorka Eguileor proposed openstack/cinder: DB: Optimize update methods  https://review.openstack.org/33294411:27
openstackgerritGorka Eguileor proposed openstack/cinder: DB: Optimize volume_update method  https://review.openstack.org/33294311:27
*** sdague has quit IRC11:31
openstackgerritMichal Dulko proposed openstack/cinder: Pin RPC server's serializer to min obj version  https://review.openstack.org/35053411:31
*** sandanar__ has quit IRC11:35
*** sandanar__ has joined #openstack-cinder11:36
*** ManishD has quit IRC11:36
*** campee has quit IRC11:44
*** vbala_ has joined #openstack-cinder11:45
*** vbala has quit IRC11:46
*** dansmith has quit IRC11:49
*** campee has joined #openstack-cinder11:49
*** dansmith has joined #openstack-cinder11:49
*** Digvijay has quit IRC11:50
*** akerr_ has quit IRC11:54
*** yuriy_n17 has joined #openstack-cinder11:56
yuriy_n17dulek: Hi! Very sorry for disturbing. Please take a look at https://review.openstack.org/#/c/359070/ whenever you have free time.11:59
*** ducttape_ has joined #openstack-cinder12:11
*** gouthamr has joined #openstack-cinder12:11
dulekyuriy_n17: Oh, I've looked at this one and I'm not sure what to do about it. There's clearly something strange in these tests as geguileo pointed out.12:14
dulekyuriy_n17: Can we get driver maintainer to look at the issue?12:14
geguileoI spent over half an hour trying to figure out what was going on with that test12:15
*** sandanar_ has joined #openstack-cinder12:15
*** zul has quit IRC12:15
geguileoThen I gave up since it wasn't my patch  :-(12:15
*** salv-orlando has quit IRC12:15
*** alonma has joined #openstack-cinder12:17
*** mpjetta has quit IRC12:18
*** tpsilva has joined #openstack-cinder12:18
*** mpjetta has joined #openstack-cinder12:18
*** sandanar__ has quit IRC12:18
*** diablo_rojo_ has quit IRC12:19
*** rhefner has quit IRC12:19
*** akerr has joined #openstack-cinder12:20
*** diablo_rojo_ has joined #openstack-cinder12:20
*** mfisch has quit IRC12:21
*** sage_ has joined #openstack-cinder12:21
*** sage has quit IRC12:21
*** sandanar_ has quit IRC12:21
*** bradjones has quit IRC12:21
*** alonma has quit IRC12:21
*** briancurtin has quit IRC12:23
*** vern has quit IRC12:23
*** vern has joined #openstack-cinder12:24
*** thurloat has quit IRC12:25
*** mfisch has joined #openstack-cinder12:25
*** mfisch has quit IRC12:25
*** mfisch has joined #openstack-cinder12:25
*** thurloat has joined #openstack-cinder12:25
*** briancurtin has joined #openstack-cinder12:26
*** bradjones has joined #openstack-cinder12:27
*** bradjones has quit IRC12:27
*** bradjones has joined #openstack-cinder12:27
*** pdeore has quit IRC12:27
*** mtreinish has quit IRC12:27
yuriy_n17dulek: I see, that question to IBM...12:27
*** uberjay has quit IRC12:28
*** ducttape_ has quit IRC12:28
dulekHey, jungleboyj, help us! :)12:29
* dulek knows he isn't here yet.12:30
*** mtreinish has joined #openstack-cinder12:30
*** uberjay has joined #openstack-cinder12:30
*** edmondsw has joined #openstack-cinder12:34
*** yangyapeng has joined #openstack-cinder12:34
*** JoseMello has joined #openstack-cinder12:35
*** scottda has joined #openstack-cinder12:36
*** sbezverk_ has joined #openstack-cinder12:37
openstackgerritMerged openstack/python-cinderclient: Enhance help message of upload_to_image  https://review.openstack.org/35967812:38
*** sbezverk has quit IRC12:39
*** cdelatte has joined #openstack-cinder12:42
*** pauloewerton has joined #openstack-cinder12:43
*** xyang1 has joined #openstack-cinder12:45
*** xyang has joined #openstack-cinder12:46
*** cdelatte has quit IRC12:46
*** frakt_ has quit IRC12:46
*** laughterwym has joined #openstack-cinder12:47
*** markvoelker has joined #openstack-cinder12:48
*** frakt has joined #openstack-cinder12:48
*** eharney has quit IRC12:53
*** mgagne_ is now known as mgagne12:54
*** lkuchlan has quit IRC12:56
*** gaurangt has joined #openstack-cinder12:56
*** salv-orlando has joined #openstack-cinder12:58
*** zhangguoqing has joined #openstack-cinder12:59
*** rlrossit has joined #openstack-cinder13:00
*** lkuchlan has joined #openstack-cinder13:00
*** zhangguoqing has quit IRC13:03
*** alee has quit IRC13:07
*** porrua has joined #openstack-cinder13:08
*** julim_ has joined #openstack-cinder13:09
*** julim_ has quit IRC13:15
*** julim_ has joined #openstack-cinder13:17
openstackgerritAlexey Khodos proposed openstack/cinder: NexentaStor5: add extend method to NFS driver  https://review.openstack.org/29788013:18
*** jordanP has quit IRC13:20
*** ducttape_ has joined #openstack-cinder13:22
*** links has quit IRC13:22
*** rooneym has joined #openstack-cinder13:23
openstackgerritAlexey Yelistratov proposed openstack/cinder: Support new osprofiler API  https://review.openstack.org/31567613:24
*** eantyshev has left #openstack-cinder13:24
rooneymCould I get a little attention on this tiny patch of mine contained to the NetApp drivers? https://review.openstack.org/#/c/356635/13:25
*** dustins has joined #openstack-cinder13:26
*** xyang has quit IRC13:27
openstackgerrittimgclark proposed openstack/cinder: Pure - warn when deleting destroyed snapshot  https://review.openstack.org/35993013:27
*** xyang has joined #openstack-cinder13:29
openstackgerritxing-yang proposed openstack/cinder: Add generic volume groups  https://review.openstack.org/32245913:30
*** zul has joined #openstack-cinder13:31
*** ehrhardt has joined #openstack-cinder13:31
*** eharney has joined #openstack-cinder13:31
*** ducttape_ has quit IRC13:33
*** salv-orlando has quit IRC13:35
*** ehrhardt has quit IRC13:39
*** ehrhardt has joined #openstack-cinder13:39
*** ehrhardt has quit IRC13:41
*** sdague has joined #openstack-cinder13:41
*** ehrhardt has joined #openstack-cinder13:41
*** laughterwym has quit IRC13:42
*** laughterwym has joined #openstack-cinder13:43
*** Lee1092 has quit IRC13:44
openstackgerritVivek Dhayaal proposed openstack/cinder: Support ZeroMQ messaging in cinder multibackend  https://review.openstack.org/27711313:45
*** eharney_ has joined #openstack-cinder13:46
*** eharney has quit IRC13:47
*** laughter_ has joined #openstack-cinder13:48
smcginnisscottda: ping13:48
scottdasmcginnis: hola13:49
smcginnisscottda: Hey, were you able to spend any more time tracking down that oom failure?13:49
scottdasmcginnis: Yes, I updated the bug report. 6/7 runs the failure was during VolumeMigrationTestCase, but that's not necessarily where the problem lies....13:50
scottdasmcginnis: It does look like issues are in tests/unit/test_volume.py...which sucks since that file is huge.13:51
*** laughterwym has quit IRC13:51
scottdasmcginnis: I looked at recent commits and tried to skip some of those tests, but that didn't make the problem go away.13:51
smcginnisscottda: Well, at least that narrows it down I guess.13:51
*** Yogi1 has joined #openstack-cinder13:51
eharney_there are numerous issues in that file :)13:51
smcginnis:)13:51
*** eharney_ is now known as eharney13:51
smcginniseharney: Good thing you moves at least some of it out.13:51
*** alee has joined #openstack-cinder13:52
*** kaisers_ has quit IRC13:52
scottdasmcginnis: Next, I was going to go back in time and see if I can do a binary search to reproduce in an attempt to narrow down to the problematic commit , assuming it is a single commit.13:52
smcginnis*moved13:53
geguileoscottda: It's usually easier to see if testr can find the conflicting tests automatically13:53
scottdasmcginnis:  But I probably won't have time again until tomorrow. Or maybe I'd better wait until next week, and review for FF instead.13:53
scottdageguileo: How?13:54
geguileoscottda: I don't remember from the top of my head13:54
geguileoscottda: Give me a minute to see if I can find my notes or a link to a post or something13:54
*** jgregor has joined #openstack-cinder13:55
* geguileo does it once every 2 or 3 months so doesn't remember13:55
geguileoscottda: https://rbtcollins.wordpress.com/2015/12/02/diagnosing-flaky-tests/13:55
scottdageguileo: OK. I looked at various things during  the runs like 'dstat --top-oom' and various proc files in an attempt to catch the problematic tests...13:55
geguileoscottda: I have my own notes, but they are soooo brief, that it's probably best you have a look there13:56
geguileoscottda: I don't remember if it was up to date, but I'll certainly point you in the right direction13:56
scottdageguileo: Thnx. I'll have a look.13:56
*** cknight has joined #openstack-cinder13:56
*** ebalduf has joined #openstack-cinder13:57
*** ociuhandu has joined #openstack-cinder13:57
*** yangyape_ has joined #openstack-cinder13:58
eharneyscottda: did the log say how much memory was used when the process was killed?  (i think it should)13:59
*** e0ne has joined #openstack-cinder14:00
scottdaeharney: Yes, on my 2GB VM:14:01
scottdaAug 24 17:18:13 dev2gb kernel: [20319.182011] Killed process 26775 (python) total-vm:747216kB, anon-rss:632412kB, file-rss:2556kB14:01
*** yangyapeng has quit IRC14:02
*** wxy__ has quit IRC14:02
*** wxy__ has joined #openstack-cinder14:03
*** yangyape_ has quit IRC14:03
*** yangyapeng has joined #openstack-cinder14:04
*** zul has quit IRC14:04
*** qeelee has quit IRC14:05
smcginnisWould be nice if ostestr had memory_profiler integration or something like that. Some debug mode to track memory usage per test.14:05
*** zul has joined #openstack-cinder14:06
*** Julien-zte has joined #openstack-cinder14:07
*** laughter_ has quit IRC14:08
*** laughterwym has joined #openstack-cinder14:08
eharneyi was thinking of just setting a low ulimit and running tox to see if it fails14:08
akerrsmcginnis: hah, we've been working on trying to do something like that as well.  We keep having to increase the size of the nodes that run the unittests due to segfaults and wanted to know if there were any obvious offenders14:08
duleksmcginnis: Spec tracking etherpad is almost empty now - are there any reviews I should focus on now?14:09
duleksmcginnis: I'm going through my queue, but I know we're close to N-3 now.14:09
smcginnisakerr: Might be a good area to spend some time investigating. Probably find a few things to fix.14:09
smcginnisdulek: Good question.14:09
*** laughter_ has joined #openstack-cinder14:09
*** lkuchlan has quit IRC14:09
duleksmcginnis: I can join you with solving UT memory issues, but looks like you've got it covered. ;)14:10
smcginnisdulek: I think our major focuses we identified in Austin are mostly good. Or at least as good as they'll get for O.14:10
openstackgerritxing-yang proposed openstack/cinder: Add group snapshots  https://review.openstack.org/32805214:10
*** laughte__ has joined #openstack-cinder14:10
*** laughte__ has quit IRC14:10
smcginnisdulek: Some more eyes on jgriffith's patch wouldn't hurt: https://review.openstack.org/#/c/327408/14:11
*** laughte__ has joined #openstack-cinder14:11
openstackgerritxing-yang proposed openstack/cinder: Add group snapshots  https://review.openstack.org/32805214:11
smcginnisWrapping up python-cinderclient and python-brick-cinderclient-ext patches would be good since that's the next deadline.14:11
duleksmcginnis: What's happening with group stuff xyang is working on? Ocata?14:12
*** ducttape_ has joined #openstack-cinder14:12
*** laught___ has joined #openstack-cinder14:12
smcginnisdulek: That would be another good one.14:12
*** laught___ has quit IRC14:12
smcginnisdulek: I think there's just the generic groups patch outstanding yet.14:12
*** laught___ has joined #openstack-cinder14:13
smcginnishttps://review.openstack.org/#/c/322459/14:13
*** esker has joined #openstack-cinder14:13
*** laughterwym has quit IRC14:13
duleksmcginnis: Oh, cool!14:14
scottdaTake some Ritalin before starting to review that one...14:14
*** laughterwym has joined #openstack-cinder14:14
smcginnisHah! :)14:14
*** laughter_ has quit IRC14:14
* dulek googles "ritalin".14:15
smcginnis:D14:15
*** laughte__ has quit IRC14:15
dulekOh, I'll just use cola to brew my coffee. It should have similar effect. ;)14:16
smcginnisThere you go! :)14:16
*** mtanino has joined #openstack-cinder14:16
*** laughter_ has joined #openstack-cinder14:16
akerrsmcginnis: I think merooney actually did profile all the tests and didn't find any outliers, but I'll double check with him once he gets in14:16
*** laughterwym has quit IRC14:16
smcginnisakerr: Oh cool. Would be good to hear any findings.14:17
*** pgadiya has quit IRC14:17
*** laught___ has quit IRC14:18
*** shausy has quit IRC14:21
*** sborkows has quit IRC14:22
*** lkuchlan has joined #openstack-cinder14:24
*** esker_ has joined #openstack-cinder14:25
*** e0ne has quit IRC14:29
*** esker has quit IRC14:32
*** rajinir has joined #openstack-cinder14:32
*** lixiaoy1 has joined #openstack-cinder14:34
*** e0ne has joined #openstack-cinder14:34
gaurangthemna: ping14:35
*** esker has joined #openstack-cinder14:35
*** esker has quit IRC14:36
xyang1scottda: :)14:37
*** ociuhandu has quit IRC14:38
*** esker has joined #openstack-cinder14:38
*** esker has quit IRC14:38
*** alonma has joined #openstack-cinder14:39
*** enriquetaso has joined #openstack-cinder14:39
*** esker_ has quit IRC14:40
jgriffiththe entering/exiting Kamaniro driver might very well make my head explode14:40
*** esker has joined #openstack-cinder14:41
*** sdake has joined #openstack-cinder14:42
smcginnisjgriffith: I haven't looked in to that, but why isn't that getting suppressed like the other logs?14:42
*** zul has quit IRC14:42
jgriffithsmcginnis: That's going to be what I play with on the plane this morning I think :)14:43
jgriffithand maybe the oom thing unless somebody found it14:43
smcginnisjgriffith: Not yet.14:43
*** wN has quit IRC14:43
*** alonma has quit IRC14:43
jgriffithI think it's dell SC's fault :)14:43
smcginnisjgriffith: scottda narrowed it down to test_volumes but we're still not sure what in there is the root cause.14:44
smcginnisjgriffith: Hah!14:44
jgriffithsmcginnis: oh?14:44
jgriffithhmmm14:44
*** e0ne has quit IRC14:45
jgriffithsmcginnis: "rm -rf cinder/volume/tests/unit/test_volume.py; git rm -rf cinder/volume/tests/unit/test_volume.py; git commit -m "Because it sucks"; git review14:45
smcginnis;)14:45
jgriffithsmcginnis: it's even kind of a one-liner for you to use :)14:45
smcginnisjgriffith: Probably it's uncovering an actual issue in the code somewhere though. Unless we're doing something stupid in a fake or something.14:46
openstackgerritxing-yang proposed openstack/cinder: Add group snapshots  https://review.openstack.org/32805214:46
openstackgerritLisaLi proposed openstack/cinder: Recover volume status after remove_export  https://review.openstack.org/36021114:46
lixiaoy1jgriffith: Hey, may I take you some time to discuss your comments about my patches?14:47
jgriffithsmcginnis: scottda odd though, the only thing added to test_volume in that time frame is this one:  https://github.com/openstack/cinder/commit/f5634ea3c12e037959d5561f4363c8ede7724de6#diff-748a8d2544303f66f74c67983c0fce9a14:47
jgriffithlixiaoy1: for sure14:47
*** timcl has quit IRC14:47
jgriffithlixiaoy1: we never seem to be able to connect here the past few days :)14:48
lixiaoy1jgriffith: yes. seems today you are earlier.14:48
lixiaoy1jgriffith: first it is about the patch https://review.openstack.org/#/c/319078/ , retype encrypted volume14:48
*** openstackgerrit has quit IRC14:48
*** lprice has joined #openstack-cinder14:48
jgriffithsmcginnis: scottda I don't have a setup handy but can try and deploy one... maybe just try a local revert of that to start if you have a repro of it14:48
scottdajgriffith: Yeah. And I posted in the bug that oom_killer kicks in during test_volume. I don' think that's conclusive that the issue is there, just strong evidence.14:49
scottdajgriffith: And my setup is a 2GB VM, btw14:49
*** timcl has joined #openstack-cinder14:49
lixiaoy1jgriffith: you mentioned about your new attach flow. do you have concerns?14:49
scottdajgriffith: With devstack running14:49
scottdaAnyway, I gotta run. I'll work on the oom issue later today...14:49
*** openstackgerrit has joined #openstack-cinder14:49
jgriffithlixiaoy1: some... but the specifics around that aren't worth going in to14:50
jgriffithlixiaoy1: I have problems with how encryption works though14:51
lixiaoy1jgriffith: what are the problems?14:51
jgriffithlixiaoy1: and I was (am) concerned with adding the additional if detection in random places during the attach flow14:51
jgriffithlixiaoy1: ummm... it sucks14:51
jgriffithlixiaoy1: I think we need to come up with a way to make it more passive and pluggable14:52
*** esker has quit IRC14:52
jgriffithlixiaoy1: currently it's sprinkled all around here and there introducing various code path checks and changes14:53
jgriffithlixiaoy1: which in my experience results in a brittle architecture going forward14:53
*** david-lyle has joined #openstack-cinder14:53
jgriffithlixiaoy1: I also have issues with it in terms of the resource usage, performance hit that's incurred when using and the fact that anybody that does compression, dedupe etc is kinda screwed14:54
lixiaoy1jgriffith: it uses linux kernel dmcrypt to encrypt/decrypt, so after we attach the encrypted volume to host, that is encrypted device. the data read from it is encrypted. so if we want to read unencrypted volume, we need to attach encryptors.14:54
jgriffithlixiaoy1: but none of that has anything to do with your patch, or probably with what you're asking :)14:54
jgriffithlixiaoy1: yes14:54
lixiaoy1jgriffith: I understand your concerns. it is sprinkled all round14:55
jgriffithlixiaoy1: that's really my biggest issue14:55
jgriffithlixiaoy1: but I'm certainly not saying your patch shouldn't merge because of that14:55
jgriffithlixiaoy1: note that I just commented, I didn't down vote14:56
lixiaoy1jgriffith: that's also where some bugs are caused. some places which need to attach encryptor don't14:56
jgriffithlixiaoy1: because forward progress on something that exists is good... but it would be great if we were initerested in optimizing it in the future14:56
jgriffithlixiaoy1: EXACTLY!!!  YES, thank you!  You get it!!!14:57
lixiaoy1jgriffith: yeah, I saw your idea about not down voting14:57
lixiaoy1jgriffith: let me investigate more in future release about the encryption14:58
jgriffithlixiaoy1: that's fine... I'll take a closer look at that patch today as well and give you a definitive vote on it14:59
jgriffithrather than just a comment14:59
lixiaoy1jgriffith:  so could you kindly help to continue reviewing this patch?14:59
jgriffithlixiaoy1: :)14:59
lixiaoy1jgriffith: thank you14:59
jgriffithlixiaoy1: You're welcome14:59
*** david-lyle has quit IRC14:59
*** markstur has joined #openstack-cinder14:59
*** JoseMello has quit IRC15:00
lixiaoy1jgriffith: ok, let's go to next two patches: ok, let's go to next two patches: https://review.openstack.org/#/c/268609/ and https://review.openstack.org/#/c/268608/ , there are ovo about attach_volume and detach_volume15:00
jgriffithyes, I figured I'd be hearing about these sooner or later15:01
*** markstur has left #openstack-cinder15:01
*** zul has joined #openstack-cinder15:01
openstackgerritxing-yang proposed openstack/python-cinderclient: Add support for group snapshots  https://review.openstack.org/32977015:02
lixiaoy1jgriffith: about whether need to version and objectify *everything15:02
*** Suyi_ has joined #openstack-cinder15:02
*** alonma has joined #openstack-cinder15:04
*** yangyape_ has joined #openstack-cinder15:04
*** chris_morrell has joined #openstack-cinder15:04
jgriffithlixiaoy1: yeah?15:05
lixiaoy1jgriffith: I thought you were looking at the two patches :)15:05
*** yangyapeng has quit IRC15:05
jgriffithlixiaoy1: I still stand by that, I've failed to see what this is buying us yet, and until we get even one resource completely *done* I don't see any value or need to move on to internal "things"15:05
jgriffithlixiaoy1: haha... sorry15:06
jgriffithlixiaoy1: I thought you were typing something :)15:06
jgriffithlixiaoy1: Turns out we're both just staring at each other in awkward silence :)15:06
lixiaoy1jgriffith: yes :)15:06
lixiaoy1jgriffith: 1. Decrease the times to access db.  For example, we need to refresh volume object when we use db to update it.15:07
lixiaoy12. Decrease the complexity for future development. As if both db and volume functions are called, devs need to be very carefully about when needs to refresh, and which object needs to refresh.15:07
lixiaoy13. Access the resource through unified object interfaces. Let object handle the interactions with db.15:07
lixiaoy1jgriffith: I think these are benefit we do things through object15:07
jgriffithlixiaoy1: ok... how come?15:08
*** alonma has quit IRC15:08
lixiaoy1jgriffith:for example,  if we update volume in db, and then we need to refresh the volume object to keep it consistent with db date15:08
lixiaoy1jgriffith: let me give you the code, wait a moment15:09
jgriffithlixiaoy1: let's use the volume_attachment object for the discussion, because that's the one I'm questioning15:11
*** zul has quit IRC15:11
*** wN has joined #openstack-cinder15:11
*** wN has quit IRC15:11
*** wN has joined #openstack-cinder15:11
lixiaoy1jgriffith: ol15:11
lixiaoy1ok15:12
*** salv-orlando has joined #openstack-cinder15:12
*** pbandark has quit IRC15:12
*** ociuhandu has joined #openstack-cinder15:12
lixiaoy1jgriffith: https://review.openstack.org/#/c/268608/12/cinder/volume/manager.py  line 97315:14
lixiaoy1jgriffith: line 937 at right panel. if we update attachement through db operations, and then for volume object, we need to refresh it15:16
*** lkuchlan has quit IRC15:16
*** alonma has joined #openstack-cinder15:16
lixiaoy1jgriffith: also if we update volume_admin_metadata through db, and then for volume object, we also need to refresh this data, or else the value in volume object is not consitent with data in db15:17
jgriffithlixiaoy1: which file?15:17
*** nkrinner is now known as nkrinner_afk15:17
*** salv-orl_ has joined #openstack-cinder15:18
lixiaoy1jgriffith: https://review.openstack.org/#/c/268608/12/cinder/volume/manager.py15:18
jgriffithlixiaoy1: so how often do you think we should encounter those cases?  And why shouldn't we actually be explicit rather than implicit and fetch/update when we KNOW that we should?15:18
jgriffithlixiaoy1: how about this as a proposal....15:20
lixiaoy1jgriffith: if we use both db operation and object together ,it is probably that some data are not consistent. we need to refresh object.15:20
jgriffithlixiaoy1: geguileo dulek smcginnis we don't continue doing the internal resources until we're completely finished with the xternal resources like "volume" and we've erradicated the use of dict access completely?15:20
*** salv-orlando has quit IRC15:20
jgriffithIn other words we finish at least one of the conversions completely 100% through before we start another one?15:21
*** alonma has quit IRC15:21
*** links has joined #openstack-cinder15:21
jgriffithand if it ends up like many Cinder things where we never finish ... at least we didn't create another bunch of half done changes15:21
jgriffithinterestingly it would've been easier to start with something like these and going the other way now that I think about it :)15:22
openstackgerritKaitlin Farr proposed openstack/cinder: Replace key manager with Castellan  https://review.openstack.org/28049215:22
*** sdague has quit IRC15:22
jgriffithlixiaoy1: my problem is that the object conversion so far brings me little value, it adds significantly MORE code, introduces some complexity15:22
jgriffithlixiaoy1: the only real advantage at this point is well-defined states, but I'd argue there are much simpler ways to do that15:23
jgriffithlixiaoy1: just so you understand, my problem isn't the direction or the future plans for it etc15:24
lixiaoy1jgriffith: maybe I didn't describe it clearly. :( at least it can decrease the times to access db15:24
jgriffithlixiaoy1: my problem is that we have a tendency to go down these paths and end up being half in/ half out on this sort of thing15:24
jgriffithforever15:24
jgriffithlixiaoy1: I don't think I believe that's true15:24
dulekjgriffith: I hope Ocata will bring stabilization when we'll not be working on a lot of new stuff.15:25
jgriffithYou're just moving the call to the db... wrapping the wrapped db call in another wrapper15:25
lixiaoy1jgriffith: https://review.openstack.org/#/c/268608/19/cinder/objects/volume_attachment.py15:25
jgriffithdulek: I would love to have that be the case15:25
lixiaoy1jgriffith: from here it may be clearer.15:25
jgriffithlooking15:25
jgriffithlixiaoy1: no... sorry, I don't see at all how that makes it more "efficient"15:26
*** zul has joined #openstack-cinder15:26
lixiaoy1jgriffith: please look at finish_attach method15:26
jgriffithlixiaoy1: maybe I'm just not consdering something correctly?15:27
jgriffithYes, I'm looking there15:27
lixiaoy1jgriffith: if we don't do it through object method, we need to call db.volume_attach at first, and then call volume.refresh to reload volume15:27
jgriffithlixiaoy1: we still send the exact same ol "volume_attached" call to the db like we did before15:27
lixiaoy1jgriffith: but we returned updated_values for this object, and update it15:28
jgriffithlixiaoy1: sure... but so?15:28
jgriffithlixiaoy1: the object code just calls it for us15:28
lixiaoy1jgriffith: so that we don't need to call volume.refresh to reload data15:28
*** jungleboyj has joined #openstack-cinder15:28
jgriffithlixiaoy1: so all we did was introduce an additional layer/wrapper15:28
jgriffithlixiaoy1: one more level of indirection15:28
jgriffithlixiaoy1: but we didn't actually eliminate any work15:29
lixiaoy1jgriffith: with this method, only one time to access db15:29
lixiaoy1jgriffith: without this wrapper, needs two times to access db15:29
jgriffithlixiaoy1: I don't think that's true15:29
jgriffithlixiaoy1: if you measure/count from entry to return...  the count would be the same15:30
openstackgerritMatan Sabag proposed openstack/cinder: ScaleIO over subscription support  https://review.openstack.org/35654715:30
*** sdague has joined #openstack-cinder15:30
jgriffithlixiaoy1: just becasue you moved it out of the method and have it embedded in the object the call is still being made.  It's just being made from somewhere else no?15:30
lixiaoy1jgriffith: not same :)15:30
*** akerr has quit IRC15:32
lixiaoy1jgriffith: ok, if we let db.volume_attach returns updated_values of volume, and updates it for volume object, the counts are same.15:32
*** sandanar has joined #openstack-cinder15:32
lixiaoy1jgriffith: may be we can start from beginning? one step by step. It is late in my time, I am a little dizzy15:33
lixiaoy1jgriffith: at first, look into this solution: if we keep the original db.volume_attach method https://review.openstack.org/#/c/268608/19/cinder/db/sqlalchemy/api.py (left)15:35
jgriffithlixiaoy1: ok15:35
jgriffithlixiaoy1: sorry.. plane wifi is spotty15:35
*** esker has joined #openstack-cinder15:36
lixiaoy1jgriffith: in this function it returns volume db object.15:37
*** gouthamr is now known as gouthamr|afk15:38
jgriffithlixiaoy1: ok15:39
lixiaoy1jgriffith: let me go through it by myself at first. wait a moment please15:39
jgriffithsure15:39
*** kaisers_ has joined #openstack-cinder15:40
*** alonma has joined #openstack-cinder15:41
*** xinli has joined #openstack-cinder15:42
*** kaisers_ has quit IRC15:44
*** leeantho has joined #openstack-cinder15:45
*** alonma has quit IRC15:46
*** andymaier has quit IRC15:46
*** diablo_rojo has joined #openstack-cinder15:48
*** esker has quit IRC15:49
*** esker has joined #openstack-cinder15:50
jgriffithlixiaoy1: honestly I pretty much defer to geguileo and dulek on those efforts, if they're happy with them then they should merge them IMO15:50
jgriffithlixiaoy1: I did vote with a -1, but I full admit that geguileo and dulek are much more well versed in the object efforts and advantages than I am15:51
geguileojgriffith: What patches are we talking about?15:51
jgriffithlixiaoy1: I'm just a grumpy old man yelling at kids to get off my lawn :)15:51
geguileolol15:51
smcginnisjbernard1, eharney: Didn't we have something in the works to do with ceph and snapshots?15:52
jgriffithnot really... but trying to lighten things up a bit15:52
lixiaoy1jgriffith: geguileo: https://review.openstack.org/#/c/268608/1915:52
smcginnisjbernard1, eharney: It's supported, right?15:52
*** jungleboyj has quit IRC15:53
smcginnisFound it: https://review.openstack.org/#/c/281550/15:53
geguileojgriffith: Oh yes, we should port to versioned objects all ORM instances we are sending over RPC as dictionaries15:53
geguileojgriffith: But I agree with you we shouldn't move EVERYTHING to versioned objects15:54
geguileoIf it's not being passed in an RPC message it shouldn't have a versioned object15:54
lixiaoy1jgriffith: maybe we can look into detach patch, as it is clearer. https://review.openstack.org/#/c/268609/28/cinder/volume/manager.py  Line 1074, at the original codes we detach volume, and then gets volume from db15:55
*** esker has quit IRC15:56
lixiaoy1jgriffith: but with object method, we no need to refresh volume object15:56
*** esker has joined #openstack-cinder15:57
lixiaoy1geguileo: if we intersect ovo objects and db object, we need to keep carefully when it needs to refresh ovo object when should not15:58
geguileolixiaoy1: That's why we should be using DB objects15:58
geguileolixiaoy1: 2 of my patches fixing that just got merged15:58
geguileohttps://review.openstack.org/#/c/353068/15:59
lixiaoy1lixiaoy1: which two patches?15:59
geguileohttps://review.openstack.org/#/c/344224/15:59
geguileoThose 215:59
geguileoBecause we were updating the DB without updating the OVO instances in memory15:59
*** links has quit IRC16:00
*** guitarza1 is now known as guitarzan16:02
*** aleksey1 has joined #openstack-cinder16:03
*** aleksey1 is now known as alekseyruban16:03
lixiaoy1geguileo: so you mean we'd better use DB objects internal, just use volume object during rpc call16:03
lixiaoy1geguileo: after manager gets ovo object, we transfer it to DB objects, and use it inside?16:04
*** esker has quit IRC16:04
geguileolixiaoy1: No, no16:04
geguileolixiaoy1: We should use OVOs when we have them16:04
geguileolixiaoy1: And not use DB calls16:04
geguileolixiaoy1: What I'm saying is that we don't have to move every ORM class to an OVO class16:04
lixiaoy1geguileo: that's also what I think.16:04
geguileolixiaoy1: Only those that go over RPC16:05
geguileolixiaoy1: In my HA A/A work I have created the workers table with Worker ORM class16:05
geguileolixiaoy1: But since I won't be passing that over RPC there is no OVO counterpart16:05
geguileoand there shouldn't be one16:05
lixiaoy1geguileo: but if we don't move ORM to ovo. we need to pay more attention about when needs to refresh ovo object after db operations16:05
geguileolixiaoy1: No16:05
lixiaoy1geguileo: why16:06
geguileolixiaoy1: Because if we don't move ORM to OVO it's because it's not linked to an OVO16:06
geguileolixiaoy1: And we only work with ORM instances and dictionaries16:06
*** zul has quit IRC16:07
lixiaoy1geguileo: yes, your Worker DB class no needs to pass over RPC. But for volume objects, such objects need to pass over RPC16:07
geguileolixiaoy1: What are we discussing then?16:07
lixiaoy1geguileo: jgriffith has concerns about my two patch attach_volume and detach_volume,16:08
geguileolixiaoy1: I know, and I explained why I'm ok with them16:08
geguileolixiaoy1: So, what are we discussing?16:08
*** diablo_rojo has quit IRC16:09
*** diablo_rojo_ is now known as diablo_rojo16:09
lixiaoy1geguileo: are you ok with the patches? or are you ok with John's comments that we no need to create volume method finish_attach to do things16:09
geguileolixiaoy1: At least one of those patches has a +2 from me and I haven't removed it16:10
geguileolixiaoy1: So I'm ok with the patch16:10
lixiaoy1jgriffith: I see. But John give -1, and I am discussing with him why I think the changes are reasonable16:11
lixiaoy1sorry, last words to you geguileo16:11
*** xinli has quit IRC16:13
*** xinli has joined #openstack-cinder16:13
*** arecknag has quit IRC16:15
*** timcl has quit IRC16:19
*** chris_morrell has quit IRC16:20
*** pdeore has joined #openstack-cinder16:20
*** lixiaoy1 has quit IRC16:21
*** lixiaoy1 has joined #openstack-cinder16:22
*** sdague has quit IRC16:23
karthikp_eharney: Hi16:23
*** raunak has joined #openstack-cinder16:24
*** zul has joined #openstack-cinder16:25
openstackgerritWalter A. Boring IV (hemna) proposed openstack/os-brick: Fix cmd execution stderr, stdout unicode errors  https://review.openstack.org/34108516:34
*** porrua has quit IRC16:34
*** laughter_ has quit IRC16:35
*** baumann has joined #openstack-cinder16:35
*** e0ne has joined #openstack-cinder16:39
karthikp_Hi All, I have an change which increases the size of database column... but i see that alter column length is banned operation unless i put it into a exception16:39
karthikp_Is this fine or frowned upon16:39
*** Apoorva has joined #openstack-cinder16:40
*** Apoorva has quit IRC16:40
*** baumann_ has joined #openstack-cinder16:40
*** abalfour has joined #openstack-cinder16:41
*** Apoorva has joined #openstack-cinder16:42
*** e0ne has quit IRC16:43
*** baumann has quit IRC16:43
*** xyang has quit IRC16:44
openstackgerritWalter A. Boring IV (hemna) proposed openstack/cinder: 3PAR use OSLO versioned Object for volume  https://review.openstack.org/33914716:45
*** rcernin has quit IRC16:45
*** xyang has joined #openstack-cinder16:46
*** timcl has joined #openstack-cinder16:46
*** gouthamr|afk is now known as gouthamr16:46
abalfourI have a (probably dumb) question about Gerrit and the CI systems...16:46
*** alonma has joined #openstack-cinder16:46
abalfourIf someone stucks a "run-VendorX CI" in a review, and nothing happens, how would one follow up and figure out if the request made it out, if the Vendor CI dropped the ball, etc?16:47
abalfoursigh. s/stucks/stuck/16:49
*** david-lyle has joined #openstack-cinder16:50
alekseyrubanHi everybody. Can anybody take a look at my patch sets please? https://review.openstack.org/#/c/356142/6 https://review.openstack.org/#/c/358474/316:51
*** alonma has quit IRC16:51
*** Suyi_ has quit IRC16:52
*** tesseract- has quit IRC16:56
*** _ducttape_ has joined #openstack-cinder16:57
*** ducttape_ has quit IRC17:01
*** zul has quit IRC17:04
*** pdeore has quit IRC17:05
*** porrua has joined #openstack-cinder17:05
*** jgregor has quit IRC17:06
*** e0ne has joined #openstack-cinder17:07
erloneharney: ping17:09
openstackgerritAnthony Lee proposed openstack/cinder: Disabling online volume copy in HPE 3PAR drivers  https://review.openstack.org/34806017:09
*** ebalduf has quit IRC17:12
*** dfisher has joined #openstack-cinder17:16
*** Suyi_ has joined #openstack-cinder17:17
*** baumann_ has quit IRC17:17
*** lpetrut has quit IRC17:19
*** bwallis has joined #openstack-cinder17:19
*** xinli has quit IRC17:21
*** zul has joined #openstack-cinder17:24
openstackgerritMerged openstack/os-brick: Add connector for GPFS volumes  https://review.openstack.org/35457617:25
*** _ducttape_ has quit IRC17:25
*** gaurangt has left #openstack-cinder17:26
*** kaisers_ has joined #openstack-cinder17:29
eharneyerlon: hi17:31
erloneharney: hey Eric17:31
*** xinli has joined #openstack-cinder17:32
*** zul has quit IRC17:32
erloneharney: so, I have reach a point that have solved the underlying problems behind the NFS snapshots/attachment17:34
eharneyerlon: ok.  which problems are those?17:34
*** kaisers_ has quit IRC17:34
erloneharney: there is a bug indeed in libvirt, that does not allow the attachment of a volume with external snapshot if apparmor is enabled17:35
erloneharney: https://bugzilla.redhat.com/show_bug.cgi?id=136159217:35
openstackbugzilla.redhat.com bug 1361592 in libvirt "image backing file cannot be accessed when adding device to running domain due to incomplete apparmor profile" [Unspecified,New] - Assigned to libvirt-maint17:35
erloneharney: someone has already hit it17:35
eharneyerlon: that sounds like misconfiguration of apparmor profiles to me17:36
erloneharney: no is not, libvirt adds the files to the profile 'on the fly'17:36
erloneharney: so, for example, if you attach a volume, it will add the volume path to the profile17:37
erloneharney: that why, attaching volumes without snapshot works17:37
erloneharney: but, if the volume has snapshots, libvirt does not add the backing files to the profiles, only the top most files17:38
erloneharney: and then QEMU can't open the backing files17:38
erloneharney: I did the following tests:17:38
eharneyok, makes sense after reading https://libvirt.org/drvqemu.html#securitysvirtaa17:39
erlon1 - tried to attach a snapshot to the instance, and then looked at the kernel audit logs, there you can see that QEMU tried to make access to the backing files and were blocked17:39
erlon2 -  looped over, the profile file in this same operation, and I could see that libvirt add the snapshots file, and right after (the operation failed) it removes the file17:41
eharneyok17:42
erloneharney: so, do you think its ok to implement the feature know this limitation?17:43
*** bardia has joined #openstack-cinder17:43
smcginniserlon: It would need to be very well documented.17:43
eharneyerlon: yes, because that isn't going to be fixed properly without an update to ubuntu's libvirt package, and we can document how to make it work until that happens, and it works fine on other distros17:44
erloneharney: we could implement it with the limitation and it would only work with apparmor disable17:44
eharneyholding up the feature because apparmor policies need an update is not really sensible, we just need to document it properly17:44
erloneharney: ok then, Ill keep the work I started in Cinder and Nova17:45
erloneharney: my idea now is to send all backing chain to Nova, so it can build an XML file and send it to libvirt: http://paste.openstack.org/show/556064/17:46
openstackgerritMerged openstack/cinder: Fix password masking result  https://review.openstack.org/35998817:47
erloneharney: later on, when they they fixed, they can get the backing files from the XML17:47
*** eharney_ has joined #openstack-cinder17:47
eharney_sorry, dropped off... my laptop is not currently very stable17:47
*** Lee1092 has joined #openstack-cinder17:47
erloneharney: no problem, got the last message?17:48
*** sdague has joined #openstack-cinder17:48
*** baumann has joined #openstack-cinder17:48
ntpttr___hi, is there a reason that commands like backup-restore will only take an ID and not a name, but for volume operations a volume name works?17:48
erloneharney: later on, when they they fixed, they can get the backing files from the XML17:48
eharney_no, i missed it17:49
erlonsmcginnis: +1, yes, there are several tricks to make it work the way it is today17:49
eharney_and eavesdrop takes a few minutes to catch up17:49
*** eharney has quit IRC17:49
*** eharney_ is now known as eharney17:50
*** jgregor has joined #openstack-cinder17:50
*** alonma has joined #openstack-cinder17:50
erloneharney: if you want just say where you were dropped and I paste it17:50
eharneyi didn't see anything after i typed about "holding up the feature"17:51
*** ducttape_ has joined #openstack-cinder17:51
erloneharney: ok then, Ill keep the work I started in Cinder and Nova17:51
erloneharney: my idea now is to send all backing chain to Nova, so it can build an XML file and send it to libvirt: http://paste.openstack.org/show/556064/17:52
erloneharney: later on, when they they fixed, they can get the backing files from the XML17:52
eharneyerlon: i'm not sure that will help, do you know how that is going to translate to libvirt writing a new apparmor profile at the right time?17:53
*** sandanar has quit IRC17:53
*** rcernin has joined #openstack-cinder17:53
*** alonma has quit IRC17:54
erloneharney: no, but its somehow retrieved from the XML sent from Nova, because it works with a volume without snapshots17:54
erloneharney: the libvirt expected format is the one I sent in the link17:55
eharneyerlon: isn't that because libvirt writes a profile for the base volume file?17:55
erloneharney: no, the current NFS Cinder code only sends the base file17:56
erloneharney: so Nova uses it17:56
eharneyerlon: right, and libvirt can update apparmor for that because it knows that filename17:56
*** akerr has joined #openstack-cinder17:57
erloneharney: the first thing I tried was to send the snapshot17:57
erloneharney: yes17:57
eharneyerlon: i think trying to fix apparmor by sending more information to Nova's API is probably the wrong place to address it17:57
*** akerr_ has joined #openstack-cinder17:58
erloneharney: I don't think so, if you are adding a disk to libvirt, and the disk has snapshots, you should tell it17:59
erloneharney: the way libvirt accepts that is using the <backingStore> tags17:59
eharneyerlon: i disagree, it's a MAC system, the whole point is that applications don't have to do that, you configure it on the system correctly.  If anything, libvirt can do it (which it apparently does), but I don't think Nova/Cinder needs to17:59
*** david-lyle has quit IRC18:00
*** alonma has joined #openstack-cinder18:00
erloneharney: the other way was to tell only the snapshot file, and let libvirt findout about the backing chain18:00
eharneyerlon: that's what's supposed to happen18:01
erloneharney: MAC?18:01
openstackgerritxing-yang proposed openstack/python-cinderclient: Add generic volume groups  https://review.openstack.org/32262718:01
eharneyerlon: apparmor is mandatory access control18:01
*** akerr has quit IRC18:02
*** sdake has quit IRC18:03
*** david-lyle has joined #openstack-cinder18:04
erloneharney: ok, if I send the XML with backingStore tags its not guaranteed that they will fix libvirt using that18:04
*** sdake has joined #openstack-cinder18:04
*** alonma has quit IRC18:05
eharneyerlon: which distro version are you on?18:05
erlonubuntu 16.0418:05
erloneharney: ^18:07
eharneyok18:07
*** ociuhandu has quit IRC18:09
*** david-lyle has quit IRC18:11
*** david-lyle has joined #openstack-cinder18:12
eharneyerlon: it seems like we could have devstack add the right path to /etc/apparmor.d/libvirt/TEMPLATE for the NFS mount paths for Nova and Cinder18:13
*** lpetrut has joined #openstack-cinder18:13
*** zul has joined #openstack-cinder18:14
erloneharney: hmmm, that would be nice, so we don't have to disable apparmor18:14
*** david-lyle_ has joined #openstack-cinder18:15
*** julim_ has quit IRC18:15
erloneharney: I mean, the admin trying to use18:15
*** david-lyle_ has quit IRC18:15
bswartzsmcginnis: ping18:15
smcginnisbswartz: Hey18:15
erloneharney: that will be very useful to configure the testing jobs18:15
* smcginnis has spotty wifi so may drop out from time to time18:15
*** diablo_rojo_ has joined #openstack-cinder18:16
openstackgerritMerged openstack/cinder: Fix mysql binary comparison  https://review.openstack.org/35583718:17
*** alonma has joined #openstack-cinder18:21
*** ManishD has joined #openstack-cinder18:21
*** aswadr_ has quit IRC18:21
*** rlrossit has quit IRC18:22
* hemna refrains from wifi comment.........almost.18:23
*** lpetrut has quit IRC18:24
*** e0ne has quit IRC18:24
*** alonma has quit IRC18:25
smcginnishemna: I'm not at a three letter company. ;)18:25
*** timcl has quit IRC18:25
*** rlrossit_ has joined #openstack-cinder18:26
*** alonma has joined #openstack-cinder18:31
*** zul has quit IRC18:34
*** alonma has quit IRC18:35
*** jgregor has quit IRC18:36
*** xyang has quit IRC18:36
*** salv-orl_ has quit IRC18:37
*** timcl has joined #openstack-cinder18:40
*** marcusvrn_ has joined #openstack-cinder18:41
*** lkuchlan has joined #openstack-cinder18:42
*** kaisers_ has joined #openstack-cinder18:43
*** baumann has quit IRC18:43
*** baumann has joined #openstack-cinder18:44
*** jgregor has joined #openstack-cinder18:48
*** kfarr has joined #openstack-cinder18:49
*** xyang has joined #openstack-cinder18:50
*** salv-orlando has joined #openstack-cinder18:51
*** krotscheck has left #openstack-cinder18:51
*** alonma has joined #openstack-cinder18:51
hemna:P18:53
*** diablo_rojo_ has quit IRC18:53
*** akerr_ is now known as akerr_away18:54
*** alonma has quit IRC18:56
*** sdague has quit IRC18:58
*** akerr_away has quit IRC18:59
*** akerr has joined #openstack-cinder19:00
*** ccesario has joined #openstack-cinder19:03
*** ManishD has quit IRC19:03
*** xyang has quit IRC19:07
*** xyang has joined #openstack-cinder19:07
*** diablo_rojo_ has joined #openstack-cinder19:08
*** david-lyle has quit IRC19:10
*** zul has joined #openstack-cinder19:11
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/35950819:12
*** raunak has quit IRC19:18
*** vbala_ has quit IRC19:19
*** Apoorva has quit IRC19:20
*** e0ne has joined #openstack-cinder19:21
*** salv-orlando has quit IRC19:21
*** e0ne has quit IRC19:23
SwansonGerrit is nice and breaky today.19:25
*** timcl has quit IRC19:25
*** sdague has joined #openstack-cinder19:26
*** xyang has quit IRC19:27
*** xyang has joined #openstack-cinder19:28
*** timcl has joined #openstack-cinder19:32
*** bwallis has quit IRC19:34
openstackgerritKarthik Prabhu Vinod proposed openstack/cinder: Fixes the length of resource field in database for quota tables  https://review.openstack.org/35521419:35
*** esker has joined #openstack-cinder19:39
*** sdague has quit IRC19:39
*** sdague has joined #openstack-cinder19:39
*** baumann_ has joined #openstack-cinder19:39
*** zul has quit IRC19:41
*** alekseyruban has quit IRC19:41
*** baumann has quit IRC19:43
-openstackstatus- NOTICE: The Gerrit service on review.openstack.org is restarting to implement some performance tuning adjustments, and should return to working order momentarily.19:45
*** lkuchlan has quit IRC19:46
*** lkuchlan has joined #openstack-cinder19:48
*** dfisher has left #openstack-cinder19:48
*** raunak has joined #openstack-cinder19:54
smcginnis"performance tuning adjustments" :D19:54
*** zul has joined #openstack-cinder19:54
*** Apoorva has joined #openstack-cinder19:56
openstackgerritMerged openstack/cinder: Add support for force backup for Nimble Storage  https://review.openstack.org/34908619:57
xyang:)20:00
xyang@smcginnis: let's see how much it will speed things up20:01
*** sdake has quit IRC20:03
*** bardia_ has joined #openstack-cinder20:03
*** sdake has joined #openstack-cinder20:04
*** bardia__ has joined #openstack-cinder20:04
*** bardia has quit IRC20:05
rooneymIf I could get another +2 for this driver contained 9-line defect patch I'd be super appreciative :) https://review.openstack.org/#/c/356635/20:05
jgriffithrooneym: done...20:07
jgriffithrooneym: curious, have you guys ever considered consolidating all of those structures?20:07
*** esker has quit IRC20:07
smcginnis+1 :)20:07
*** bardia_ has quit IRC20:08
*** ducttape_ has quit IRC20:11
rooneymjgriffith: a good point, I'll write a story for someone to do so haha20:11
*** abalfour has left #openstack-cinder20:13
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/35950820:13
*** ducttape_ has joined #openstack-cinder20:14
*** alee has quit IRC20:18
*** timcl has quit IRC20:19
*** Yogi1 has quit IRC20:21
openstackgerritWalter A. Boring IV (hemna) proposed openstack/os-brick: Multipath device keeps old size when extending volume  https://review.openstack.org/35332520:21
*** sdake has quit IRC20:29
*** sdake has joined #openstack-cinder20:35
openstackgerritxing-yang proposed openstack/python-cinderclient: Add support for group snapshots  https://review.openstack.org/32977020:36
*** lkuchlan has quit IRC20:38
*** JoseMello has joined #openstack-cinder20:38
*** zul has quit IRC20:38
*** baumann_ has quit IRC20:39
*** bardia__ has quit IRC20:41
*** ehrhardt has left #openstack-cinder20:43
*** akerr has quit IRC20:44
*** akerr has joined #openstack-cinder20:45
*** diablo_rojo_ has quit IRC20:45
*** salv-orlando has joined #openstack-cinder20:46
*** xyang has quit IRC20:47
*** eharney has quit IRC20:49
porrua[20:49
porrua[20:49
*** akerr has quit IRC20:52
*** xyang has joined #openstack-cinder20:52
*** alonma has joined #openstack-cinder20:52
*** akerr has joined #openstack-cinder20:53
*** Lee1092 has quit IRC20:54
*** kfarr has quit IRC20:54
*** akerr has quit IRC20:54
*** eharney has joined #openstack-cinder20:57
*** alonma has quit IRC20:57
*** rlrossit_ has quit IRC20:57
hemna]21:00
hemna]21:00
hemnawe can't have open ended discussions in here......21:00
smcginnishemna: Oh man, I was so resisting closing the brackets. :D21:02
hemnaI tried...but failed to resist21:03
*** enriquetaso has quit IRC21:03
smcginnishehe21:03
*** sdake_ has joined #openstack-cinder21:05
*** sdake has quit IRC21:08
*** alonma has joined #openstack-cinder21:13
*** salv-orl_ has joined #openstack-cinder21:17
openstackgerritMerged openstack/cinder: NetApp: Report multiattach as enabled  https://review.openstack.org/35663521:17
*** alonma has quit IRC21:17
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/35950821:18
*** sdague has quit IRC21:18
*** salv-orlando has quit IRC21:19
*** sdake_ has quit IRC21:20
*** jgregor has quit IRC21:20
*** sdake has joined #openstack-cinder21:22
scottdaIs it worth a re-check of HPE storage CI for https://review.openstack.org/#/c/322459/66 ? Or does that need investigating?21:22
hemnascottda, so I just did a recheck against a brick patch for the same basic failures21:23
hemnafailing quickly like that means that the CI env is effed21:23
hemnabut I would like that to pass on that patch if possible21:23
hemnathat patch is huge21:24
hemna:(21:24
scottdaYeah, I agree it should pass21:24
hemnahttps://github.com/tj/git-extras21:25
hemnafound that today21:25
hemnakinda handy stuffs21:25
*** david-lyle has joined #openstack-cinder21:26
scottdacool21:26
hemnagit summary is cool21:27
*** smile-luobin has quit IRC21:28
*** smile-luobin has joined #openstack-cinder21:28
hemnahttp://paste.openstack.org/show/563682/21:31
hemnafor Cinder21:31
*** david-lyle has quit IRC21:31
*** dustins has quit IRC21:32
*** eharney has quit IRC21:32
*** pauloewerton has quit IRC21:35
openstackgerritRaunak Kumar proposed openstack/cinder: Add Fibre Channel support for Nimble Storage  https://review.openstack.org/35944821:36
*** xyang has quit IRC21:43
*** xyang has joined #openstack-cinder21:43
*** xyang has quit IRC21:44
*** xyang has joined #openstack-cinder21:45
*** lprice has quit IRC21:48
*** xinli has quit IRC21:58
*** Suyi_ has quit IRC21:59
*** Suyi_ has joined #openstack-cinder21:59
*** gouthamr has quit IRC22:00
*** gouthamr has joined #openstack-cinder22:00
*** gouthamr has quit IRC22:00
*** alyson_ has quit IRC22:03
*** lpetrut has joined #openstack-cinder22:12
*** kaisers_ has quit IRC22:15
*** tpsilva has quit IRC22:18
*** alonma has joined #openstack-cinder22:23
*** sdake has quit IRC22:24
*** gouthamr has joined #openstack-cinder22:25
*** ducttape_ has quit IRC22:25
*** ducttape_ has joined #openstack-cinder22:26
openstackgerritxing-yang proposed openstack/cinder: Skip tests that caused hang  https://review.openstack.org/36080722:27
*** alonma has quit IRC22:27
*** ducttape_ has quit IRC22:30
*** ntpttr has quit IRC22:31
openstackgerritAlexey Khodos proposed openstack/cinder: NexentaStor5: add extend method to NFS driver  https://review.openstack.org/29788022:32
*** xyang has quit IRC22:32
*** salv-orl_ has quit IRC22:34
*** rooneym has quit IRC22:35
*** ntpttr has joined #openstack-cinder22:36
*** sdake has joined #openstack-cinder22:37
*** cknight has quit IRC22:40
scottdaxyang1: Is there any way to see what volumes are in a group, or what group a volume belongs to?22:40
*** xyang has joined #openstack-cinder22:42
xyang1scottda: I did not add that to the view, but they are in the group object22:42
scottdaxyang1: OK, so not visible using your CLI patches....just checking.22:43
xyang1scottda: yes22:43
scottdaMight be nice to add someday...22:43
xyang1scottda: we could do an enhancement22:43
scottdastuff looks good, BTW. I agree with hemna That it'd be good to see HPE (and other) CI's pass before merging.22:43
*** alonma has joined #openstack-cinder22:44
*** esker has joined #openstack-cinder22:44
*** xyang has quit IRC22:46
*** xyang has joined #openstack-cinder22:46
xyang1scottda: how to trigger hpe ci22:46
hemnaI think I triggered it no?22:47
hemnaguess I didn't on that one.22:47
hemnaI just reissued it22:47
xyang1hemna: ok22:47
hemnaour CI is not managed by my team anymore.......22:48
*** alonma has quit IRC22:49
xyang1hemna: I hope we don't wait for days though, the gate is so slow22:49
hemnait's horribly slow now :(22:49
xyang1hemna: also I may get another merge conflict:(22:49
*** Apoorva has quit IRC22:50
xyang1hemna: then start all over again:(22:50
hemnayah, that's the risk on these huge patches22:50
hemnaman, I'd like to refactor that api code22:50
hemnaso we can reuse some of the v2 stuffs that won't change22:51
xyang1hemna: put common code under a common folder instead of reusing v2?22:54
*** xyang has quit IRC22:54
hemnayah or something like that22:55
hemnamaybe a base compatibility class22:55
hemnaand just add hooks in the base method that allows for changes...22:55
hemnaI dunno22:55
hemnathat can turn into a mess over time too22:55
scottdaI agree we can/should do something22:56
*** xyang has joined #openstack-cinder22:56
xyang1hemna: has your CI being running normally lately?  the failure looks like it did not even start with any tests22:58
*** chlong has quit IRC22:58
hemnait's been puking today22:58
hemnaI've issued rechecks on some other patches to try and see if it magically fixes itself22:58
hemnabut at this point that's all I Can do22:58
*** Apoorva has joined #openstack-cinder22:59
*** gouthamr_ has joined #openstack-cinder22:59
xyang1hemna: actually it passed at patchset 6423:00
*** ducttape_ has joined #openstack-cinder23:00
xyang1hemna: just rebase after that, so should be ok to go23:00
hemnaugh our CI puked again23:01
hemna*sigh*23:01
hemnaok I added a +223:02
xyang1hemna: thanks!23:02
hemnaI can't +A it without our CI saying it's ok23:02
hemnabut at least I won't hold it up if someone was thinking of waiting for the 3PAR CI to pass23:03
hemnahave to run to soccer.....23:03
*** hemna is now known as hemnafk23:03
*** gouthamr has quit IRC23:03
xyang1hemna: ok, have fun23:03
*** alonma has joined #openstack-cinder23:04
*** ducttape_ has quit IRC23:08
*** alonma has quit IRC23:09
*** chlong has joined #openstack-cinder23:12
*** lpetrut has quit IRC23:14
*** ebalduf has joined #openstack-cinder23:18
*** xyang has quit IRC23:18
*** JoseMello has quit IRC23:20
*** ducttape_ has joined #openstack-cinder23:23
*** ducttape_ has quit IRC23:33
*** chlong has quit IRC23:35
*** yangyape_ has quit IRC23:38
*** xyang has joined #openstack-cinder23:41
*** xyang has quit IRC23:46
*** ducttape_ has joined #openstack-cinder23:47
*** xyang has joined #openstack-cinder23:50
*** david-lyle has joined #openstack-cinder23:52
*** xyang1 has quit IRC23:52
*** rcernin has quit IRC23:53
*** xyang has quit IRC23:54
*** xyang has joined #openstack-cinder23:57
*** leeantho has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!