| *** haomaiwang has quit IRC | 00:35 | |
| *** takedakn has quit IRC | 00:42 | |
| *** bswartz has joined #openstack-cinder | 00:52 | |
| openstackgerrit | Eli Qiao proposed openstack/cinder: Handler KeyManager exception when deleting a volume https://review.openstack.org/209828 | 00:53 |
|---|---|---|
| *** chlong has joined #openstack-cinder | 00:55 | |
| *** sparr has quit IRC | 01:07 | |
| *** tbarron has quit IRC | 01:07 | |
| *** salv-orlando has joined #openstack-cinder | 01:07 | |
| openstackgerrit | Teruaki Ishizaki proposed openstack/cinder: Sheepdog: Improve image operations https://review.openstack.org/202954 | 01:09 |
| *** salv-orlando has quit IRC | 01:13 | |
| *** salv-orlando has joined #openstack-cinder | 01:13 | |
| *** simondodsley has quit IRC | 01:16 | |
| *** EinstCrazy has joined #openstack-cinder | 01:19 | |
| *** zhangjn has joined #openstack-cinder | 01:20 | |
| *** zhenguo has joined #openstack-cinder | 01:24 | |
| *** salv-orlando has quit IRC | 01:26 | |
| *** tobasco_ has joined #openstack-cinder | 01:36 | |
| *** tobasco has quit IRC | 01:37 | |
| *** kambiz has quit IRC | 01:37 | |
| *** takedakn has joined #openstack-cinder | 01:39 | |
| *** zhangjn has quit IRC | 01:40 | |
| *** haomaiwang has joined #openstack-cinder | 01:40 | |
| *** zhangjn has joined #openstack-cinder | 01:41 | |
| *** aix_ has joined #openstack-cinder | 01:41 | |
| *** vilobhmm1 has joined #openstack-cinder | 01:42 | |
| *** aix has quit IRC | 01:42 | |
| *** vilobhmm11 has joined #openstack-cinder | 01:43 | |
| *** kambiz has joined #openstack-cinder | 01:43 | |
| *** vilobhmm1 has quit IRC | 01:47 | |
| *** chlong has quit IRC | 01:49 | |
| *** Lee1092 has joined #openstack-cinder | 01:50 | |
| openstackgerrit | Peter Wang proposed openstack/cinder: Update name_id and provider_location for migration https://review.openstack.org/217522 | 02:02 |
| openstackgerrit | Peter Wang proposed openstack/cinder: Update name_id and provider_location for migration https://review.openstack.org/217522 | 02:04 |
| *** takedakn has quit IRC | 02:12 | |
| *** zhangjn has quit IRC | 02:19 | |
| *** tbarron has joined #openstack-cinder | 02:20 | |
| *** sparr has joined #openstack-cinder | 02:21 | |
| *** hw__chenying has joined #openstack-cinder | 02:23 | |
| *** salv-orlando has joined #openstack-cinder | 02:28 | |
| openstackgerrit | Tina Tang proposed openstack/cinder: Clone cg support in VNX driver https://review.openstack.org/215530 | 02:31 |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Use cinder internal tenant to create the destination volume https://review.openstack.org/210237 | 02:39 |
| *** salv-orlando has quit IRC | 02:41 | |
| *** IlyaG has joined #openstack-cinder | 02:43 | |
| *** hakimo_ has joined #openstack-cinder | 02:52 | |
| *** hakimo has quit IRC | 02:54 | |
| openstackgerrit | Vincent Hou proposed openstack/python-cinderclient: Volume status management for volume migration https://review.openstack.org/189547 | 02:54 |
| *** EinstCrazy has quit IRC | 02:57 | |
| openstackgerrit | Vincent Hou proposed openstack/python-cinderclient: Volume status management for volume migration https://review.openstack.org/189547 | 02:58 |
| *** vincent_hou has joined #openstack-cinder | 02:58 | |
| vincent_hou | Is there any Peter Wang here? | 02:59 |
| *** lixiaoy1 has joined #openstack-cinder | 02:59 | |
| *** wilson1 has quit IRC | 02:59 | |
| vincent_hou | Anyone knows his IRC name? | 02:59 |
| openstackgerrit | Patrick East proposed openstack/cinder: Generic image-volume cache https://review.openstack.org/195795 | 03:02 |
| *** haomaiwang has quit IRC | 03:03 | |
| *** haomaiw__ has joined #openstack-cinder | 03:03 | |
| *** IlyaG has quit IRC | 03:23 | |
| *** vilobhmm11 has quit IRC | 03:26 | |
| *** vilobhmm1 has joined #openstack-cinder | 03:27 | |
| *** I has joined #openstack-cinder | 03:35 | |
| *** I is now known as Guest25059 | 03:36 | |
| *** longguang has joined #openstack-cinder | 03:36 | |
| *** links has joined #openstack-cinder | 03:40 | |
| *** davechen has joined #openstack-cinder | 03:41 | |
| *** salv-orlando has joined #openstack-cinder | 03:43 | |
| *** jwcroppe_ has joined #openstack-cinder | 03:45 | |
| *** jwcroppe has quit IRC | 03:47 | |
| *** Guest25059 has quit IRC | 03:49 | |
| *** haigang has joined #openstack-cinder | 03:49 | |
| *** samwan has joined #openstack-cinder | 03:49 | |
| *** vilobhmm1 has quit IRC | 03:50 | |
| *** vilobhmm1 has joined #openstack-cinder | 03:51 | |
| *** takedakn has joined #openstack-cinder | 03:53 | |
| *** garthb has joined #openstack-cinder | 03:55 | |
| *** salv-orlando has quit IRC | 03:56 | |
| openstackgerrit | Thang Pham proposed openstack/cinder: Conversion to volume object https://review.openstack.org/177054 | 03:59 |
| openstackgerrit | Thang Pham proposed openstack/cinder: Sync volume versionedobject to ORM https://review.openstack.org/218361 | 03:59 |
| *** vilobhmm1 has quit IRC | 04:02 | |
| *** vilobhmm1 has joined #openstack-cinder | 04:04 | |
| openstackgerrit | Vincent Hou proposed openstack/python-cinderclient: Volume status management for volume migration https://review.openstack.org/189547 | 04:04 |
| *** takedakn has quit IRC | 04:04 | |
| openstackgerrit | Thang Pham proposed openstack/cinder: Register RPC and object versions https://review.openstack.org/209701 | 04:09 |
| *** hw__chenying has quit IRC | 04:09 | |
| *** subhadeep_de has quit IRC | 04:21 | |
| *** subhadeep_de has joined #openstack-cinder | 04:22 | |
| *** sgotliv has joined #openstack-cinder | 04:29 | |
| longguang | does cinder implement chain-snapshot, but images (stored in glance) when create snapshot? | 04:29 |
| openstackgerrit | Lei Li proposed openstack/cinder: Adjust to right exception for chunkeddriver https://review.openstack.org/202481 | 04:32 |
| *** zhangjn has joined #openstack-cinder | 04:37 | |
| *** shyama has joined #openstack-cinder | 04:41 | |
| *** sgotliv has quit IRC | 04:43 | |
| *** takedakn has joined #openstack-cinder | 04:47 | |
| *** deepakcs has joined #openstack-cinder | 04:49 | |
| *** salv-orlando has joined #openstack-cinder | 04:52 | |
| *** theanalyst has quit IRC | 04:54 | |
| *** theanalyst has joined #openstack-cinder | 04:56 | |
| *** salv-orlando has quit IRC | 04:57 | |
| *** salv-orlando has joined #openstack-cinder | 04:57 | |
| *** ig0r__ has joined #openstack-cinder | 04:59 | |
| *** ig0r_ has quit IRC | 04:59 | |
| *** shausy has joined #openstack-cinder | 05:01 | |
| *** samwan is now known as sam_wan | 05:06 | |
| *** salv-orlando has quit IRC | 05:10 | |
| *** takedakn has quit IRC | 05:11 | |
| *** sam_wan is now known as sam_wan_ | 05:12 | |
| *** vincent_hou_ has joined #openstack-cinder | 05:13 | |
| *** sam_wan_ is now known as wanshan | 05:14 | |
| *** wanshan is now known as wan_shan | 05:14 | |
| *** vincent_hou has quit IRC | 05:14 | |
| *** vincent_hou_ is now known as vincent_hou | 05:15 | |
| openstackgerrit | LisaLi proposed openstack/cinder: Minor optimization https://review.openstack.org/218178 | 05:17 |
| *** wan_shan has quit IRC | 05:17 | |
| *** takedakn has joined #openstack-cinder | 05:18 | |
| *** haigang has quit IRC | 05:23 | |
| *** takedakn has quit IRC | 05:32 | |
| openstackgerrit | XinXiaohui proposed openstack/cinder: Calculate virtual free capacity and notify https://review.openstack.org/206923 | 05:34 |
| *** garthb has quit IRC | 05:35 | |
| *** shausy has quit IRC | 05:36 | |
| *** shausy has joined #openstack-cinder | 05:36 | |
| *** haigang has joined #openstack-cinder | 05:47 | |
| *** markvoelker has joined #openstack-cinder | 05:51 | |
| *** markvoelker_ has joined #openstack-cinder | 05:53 | |
| *** yrabl has joined #openstack-cinder | 05:56 | |
| *** markvoelker has quit IRC | 05:56 | |
| *** sam_wan has joined #openstack-cinder | 05:57 | |
| *** hw__chenying has joined #openstack-cinder | 06:01 | |
| *** ankit_ag has joined #openstack-cinder | 06:06 | |
| *** salv-orlando has joined #openstack-cinder | 06:10 | |
| *** vilobhmm1 has quit IRC | 06:16 | |
| *** vilobhmm1 has joined #openstack-cinder | 06:18 | |
| openstackgerrit | LisaLi proposed openstack/cinder: Raise HTTPBadRequest for invalid filters https://review.openstack.org/217015 | 06:18 |
| *** ishant has joined #openstack-cinder | 06:18 | |
| *** afazekas_ has joined #openstack-cinder | 06:19 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Imported Translations from Transifex https://review.openstack.org/218741 | 06:19 |
| *** markvoelker has joined #openstack-cinder | 06:22 | |
| *** vincent_hou has quit IRC | 06:23 | |
| *** vincent_hou has joined #openstack-cinder | 06:25 | |
| *** markvoelker_ has quit IRC | 06:25 | |
| *** markvoelker_ has joined #openstack-cinder | 06:27 | |
| *** haigang has quit IRC | 06:27 | |
| *** haigang has joined #openstack-cinder | 06:28 | |
| *** markvoelker has quit IRC | 06:29 | |
| *** haigang has quit IRC | 06:29 | |
| *** vilobhmm1 has quit IRC | 06:30 | |
| *** anshul has joined #openstack-cinder | 06:34 | |
| *** haigang has joined #openstack-cinder | 06:36 | |
| openstackgerrit | zhaohua proposed openstack/cinder: Huawei: fix multi REST-URLs bug https://review.openstack.org/214500 | 06:42 |
| *** zhangjn has quit IRC | 06:45 | |
| *** zhangjn has joined #openstack-cinder | 06:45 | |
| *** stefan_amann has joined #openstack-cinder | 07:03 | |
| *** hw__chenying has quit IRC | 07:24 | |
| *** hw__chenying has joined #openstack-cinder | 07:24 | |
| *** marcusvrn_ has quit IRC | 07:25 | |
| *** ronis has joined #openstack-cinder | 07:25 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: LVM: add the exception handling to volume copy https://review.openstack.org/218750 | 07:26 |
| *** alexschm has joined #openstack-cinder | 07:28 | |
| *** zhangjn has quit IRC | 07:28 | |
| *** kaisers has joined #openstack-cinder | 07:33 | |
| *** takedakn has joined #openstack-cinder | 07:37 | |
| *** baojg has joined #openstack-cinder | 07:40 | |
| *** takedakn has quit IRC | 07:47 | |
| *** sgotliv has joined #openstack-cinder | 07:47 | |
| *** ndipanov has joined #openstack-cinder | 07:47 | |
| *** takedakn has joined #openstack-cinder | 07:47 | |
| *** yrabl has quit IRC | 07:48 | |
| *** hw__chenying has quit IRC | 07:48 | |
| *** takedakn has quit IRC | 07:49 | |
| *** yrabl has joined #openstack-cinder | 07:50 | |
| *** shyama has quit IRC | 07:50 | |
| *** hw__chenying has joined #openstack-cinder | 07:52 | |
| *** ircuser-1 has joined #openstack-cinder | 08:08 | |
| *** zhangjn has joined #openstack-cinder | 08:10 | |
| *** jistr has joined #openstack-cinder | 08:15 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: LVM: add the exception handling to volume copy https://review.openstack.org/218750 | 08:23 |
| *** lpetrut has joined #openstack-cinder | 08:23 | |
| *** salv-orlando has quit IRC | 08:24 | |
| *** salv-orlando has joined #openstack-cinder | 08:25 | |
| *** shyama has joined #openstack-cinder | 08:28 | |
| *** hw__chenying has quit IRC | 08:28 | |
| *** markvoelker_ has quit IRC | 08:28 | |
| *** lpetrut has quit IRC | 08:29 | |
| *** zhonghua-lee has quit IRC | 08:30 | |
| *** lpetrut has joined #openstack-cinder | 08:30 | |
| *** aix_ has quit IRC | 08:32 | |
| *** aix has joined #openstack-cinder | 08:33 | |
| *** haigang has quit IRC | 08:44 | |
| *** haigang has joined #openstack-cinder | 08:44 | |
| *** zhangjn has quit IRC | 08:45 | |
| *** haigang has quit IRC | 08:50 | |
| *** haigang has joined #openstack-cinder | 08:52 | |
| *** e0ne has joined #openstack-cinder | 08:58 | |
| vincent_hou | I have logged one bug https://bugs.launchpad.net/cinder/+bug/1490445. This is something I am not quite certain. Need folks to verify it. | 09:04 |
| openstack | Launchpad bug 1490445 in Cinder "Migration: Unnecessary destination volume check during delete_volume" [Undecided,New] | 09:04 |
| *** IanGovett has joined #openstack-cinder | 09:08 | |
| *** e0ne has quit IRC | 09:09 | |
| *** flip214 has joined #openstack-cinder | 09:09 | |
| *** e0ne has joined #openstack-cinder | 09:09 | |
| *** bluex-pl has joined #openstack-cinder | 09:10 | |
| *** bluex-pl has quit IRC | 09:14 | |
| *** bluex-pl has joined #openstack-cinder | 09:14 | |
| *** haigang has quit IRC | 09:20 | |
| *** zhangjn has joined #openstack-cinder | 09:23 | |
| *** baojg has quit IRC | 09:23 | |
| *** markvoelker has joined #openstack-cinder | 09:23 | |
| *** salv-orlando has quit IRC | 09:24 | |
| *** markvoelker_ has joined #openstack-cinder | 09:26 | |
| *** zhangjn has quit IRC | 09:27 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Remove the unnecassary volume_api.get(context, volume_id) https://review.openstack.org/218781 | 09:27 |
| *** markvoelker has quit IRC | 09:30 | |
| *** vincent_hou has quit IRC | 09:31 | |
| *** markvoelker_ has quit IRC | 09:31 | |
| *** haigang has joined #openstack-cinder | 09:33 | |
| *** ig0r_ has joined #openstack-cinder | 09:37 | |
| *** markvoelker has joined #openstack-cinder | 09:37 | |
| *** baojg has joined #openstack-cinder | 09:38 | |
| *** ig0r__ has quit IRC | 09:39 | |
| *** zhangjn has joined #openstack-cinder | 09:39 | |
| *** zhangjn has quit IRC | 09:41 | |
| *** shyama has quit IRC | 09:48 | |
| *** aix has quit IRC | 09:49 | |
| *** amann has joined #openstack-cinder | 09:49 | |
| *** s_amann has joined #openstack-cinder | 09:49 | |
| *** amann has quit IRC | 09:49 | |
| *** stefan_amann has quit IRC | 09:52 | |
| *** lixiaoy1 has quit IRC | 09:53 | |
| *** davechen has left #openstack-cinder | 09:54 | |
| *** baojg has quit IRC | 10:00 | |
| *** takedakn has joined #openstack-cinder | 10:11 | |
| *** takedakn has quit IRC | 10:14 | |
| *** haigang has quit IRC | 10:14 | |
| *** takedakn has joined #openstack-cinder | 10:14 | |
| *** haigang has joined #openstack-cinder | 10:15 | |
| *** takedakn has quit IRC | 10:17 | |
| *** takedakn has joined #openstack-cinder | 10:18 | |
| *** aix has joined #openstack-cinder | 10:18 | |
| *** bluex-pl has quit IRC | 10:34 | |
| *** sam_wan has quit IRC | 10:41 | |
| *** DTadrzak has joined #openstack-cinder | 10:44 | |
| *** bluex-pl has joined #openstack-cinder | 10:49 | |
| *** ganso_ has joined #openstack-cinder | 10:57 | |
| *** jaypipes has joined #openstack-cinder | 10:58 | |
| *** takedakn has quit IRC | 11:01 | |
| *** bluex-pl has quit IRC | 11:03 | |
| *** bluex-pl has joined #openstack-cinder | 11:03 | |
| *** bluex-pl has quit IRC | 11:09 | |
| *** e0ne has quit IRC | 11:10 | |
| *** takedakn has joined #openstack-cinder | 11:11 | |
| *** takedakn has quit IRC | 11:13 | |
| *** takedakn has joined #openstack-cinder | 11:13 | |
| *** haomaiw__ has quit IRC | 11:15 | |
| *** ishant has quit IRC | 11:25 | |
| *** anshul has quit IRC | 11:29 | |
| *** anshul has joined #openstack-cinder | 11:30 | |
| *** sgotliv has quit IRC | 11:31 | |
| *** jaypipes has quit IRC | 11:35 | |
| *** jaypipes has joined #openstack-cinder | 11:36 | |
| *** openstackgerrit has quit IRC | 11:46 | |
| *** openstackgerrit has joined #openstack-cinder | 11:47 | |
| *** sgotliv has joined #openstack-cinder | 11:48 | |
| *** markvoelker_ has joined #openstack-cinder | 11:51 | |
| *** markvoelker has quit IRC | 11:51 | |
| *** markvoelker_ has quit IRC | 11:55 | |
| *** markvoelker has joined #openstack-cinder | 11:56 | |
| *** e0ne has joined #openstack-cinder | 11:59 | |
| openstackgerrit | Daniel Tadrzak proposed openstack/cinder: Service object https://review.openstack.org/160417 | 12:02 |
| *** dtadrzak_ has joined #openstack-cinder | 12:03 | |
| *** cristicalin has joined #openstack-cinder | 12:03 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: LVM: add the exception handling to volume copy https://review.openstack.org/218750 | 12:03 |
| openstackgerrit | Daniel Tadrzak proposed openstack/cinder: CGSnapshot Object https://review.openstack.org/195027 | 12:04 |
| *** IanGovett1 has joined #openstack-cinder | 12:05 | |
| openstackgerrit | Daniel Tadrzak proposed openstack/cinder: Cleanup for cinder tests with CGSnapshot https://review.openstack.org/207866 | 12:05 |
| *** IanGovett has quit IRC | 12:05 | |
| cristicalin | anybody have a good example of python-cinderclient code using connection pooling or the session ? | 12:07 |
| cristicalin | I need to write something that fetches the quotas for tenants and cinder is particularly crappy in performance because I can't figure out how to tell it to reuse the keystone auth | 12:08 |
| cristicalin | it works for nova an neutron, nova has a connection_pool=True you can set in the Client class | 12:08 |
| cristicalin | but no luck for Cinder | 12:08 |
| cristicalin | any help would be greatly appreciated | 12:09 |
| *** sgotliv has quit IRC | 12:09 | |
| *** bluex-pl has joined #openstack-cinder | 12:09 | |
| *** Yogi1 has joined #openstack-cinder | 12:11 | |
| * DuncanT finally gets back into the swing of reviewing things | 12:12 | |
| *** raildo-afk is now known as raildo | 12:16 | |
| *** theanalyst has quit IRC | 12:18 | |
| *** theanalyst has joined #openstack-cinder | 12:19 | |
| *** akerr has joined #openstack-cinder | 12:20 | |
| DuncanT | cristicalin: The only way I can see to do it is to get a token manually (e.g. keystone token-get) and pass that into cinder-client | 12:22 |
| *** simondodsley has joined #openstack-cinder | 12:31 | |
| *** edmondsw has joined #openstack-cinder | 12:32 | |
| *** krtaylor has quit IRC | 12:34 | |
| *** haomaiwa_ has joined #openstack-cinder | 12:37 | |
| *** timcl has joined #openstack-cinder | 12:38 | |
| *** takedakn has quit IRC | 12:41 | |
| *** takedakn has joined #openstack-cinder | 12:42 | |
| *** diablo_rojo has joined #openstack-cinder | 12:42 | |
| *** smoriya has quit IRC | 12:42 | |
| *** annegentle has joined #openstack-cinder | 12:44 | |
| openstackgerrit | Daniel Tadrzak proposed openstack/cinder: Cleanup for SnapshotObject https://review.openstack.org/198341 | 12:46 |
| *** sgotliv has joined #openstack-cinder | 12:47 | |
| *** krtaylor has joined #openstack-cinder | 12:47 | |
| *** afazekas__ has joined #openstack-cinder | 12:56 | |
| *** sgotliv has quit IRC | 12:57 | |
| *** cbader has joined #openstack-cinder | 12:58 | |
| *** afazekas_ has quit IRC | 12:58 | |
| *** merooney has joined #openstack-cinder | 13:02 | |
| *** edmondsw has quit IRC | 13:04 | |
| *** dustins has joined #openstack-cinder | 13:04 | |
| *** anshul has quit IRC | 13:08 | |
| *** bluex-pl has quit IRC | 13:13 | |
| *** sgotliv has joined #openstack-cinder | 13:14 | |
| *** xyang1 has joined #openstack-cinder | 13:16 | |
| *** yrabl has quit IRC | 13:17 | |
| dhellmann | hey, folks, who's filling in for thingee for the L3 checkup this week? | 13:18 |
| *** ankit_ag has quit IRC | 13:19 | |
| *** kbyrne has quit IRC | 13:19 | |
| dhellmann | DuncanT: ^^ ? | 13:20 |
| *** anshul has joined #openstack-cinder | 13:20 | |
| *** e0ne has quit IRC | 13:22 | |
| scottda | dhellmann: maybe jgriffith | 13:23 |
| DuncanT | dhellmann: jgriffith I believe | 13:23 |
| simondodsley | looks like the cores are going to be busy today - a lot of things out there waiting to get into L-3 | 13:25 |
| *** nkrinner has quit IRC | 13:27 | |
| *** eharney has joined #openstack-cinder | 13:27 | |
| *** anshul has quit IRC | 13:28 | |
| *** e0ne has joined #openstack-cinder | 13:29 | |
| *** mtanino has joined #openstack-cinder | 13:30 | |
| *** links has quit IRC | 13:30 | |
| *** kbyrne has joined #openstack-cinder | 13:32 | |
| *** edmondsw has joined #openstack-cinder | 13:33 | |
| *** IanGovett1 has quit IRC | 13:35 | |
| *** superdan is now known as dansmith | 13:35 | |
| *** salv-orlando has joined #openstack-cinder | 13:36 | |
| *** dims has joined #openstack-cinder | 13:36 | |
| *** rushil has joined #openstack-cinder | 13:36 | |
| geguileo | e0ne: ping - file I/O volume migration patch | 13:37 |
| *** rushil_ has joined #openstack-cinder | 13:37 | |
| *** thangp has joined #openstack-cinder | 13:39 | |
| e0ne | geguileo: hi | 13:39 |
| *** annasort has joined #openstack-cinder | 13:39 | |
| geguileo | e0ne: I saw you +2 that patch but didn't +1 WF, any specific reason? | 13:39 |
| geguileo | e0ne: https://review.openstack.org/#/c/187270/23 | 13:39 |
| e0ne | geguileo: i just wanted to be sure that it's everything ok with infra | 13:40 |
| *** anshul has joined #openstack-cinder | 13:40 | |
| *** rushil has quit IRC | 13:41 | |
| e0ne | geguileo: afaik, a lot of patches were affected with new netaddr package | 13:41 |
| e0ne | geguileo: may be we need to +A on it and recheck if CI will failed | 13:41 |
| geguileo | e0ne: So you think this may fail CI when we try to merge it? | 13:42 |
| e0ne | geguileo: i'm not sure. but it's not related to the pacht | 13:42 |
| e0ne | s/pacht/patch | 13:43 |
| geguileo | e0ne: But if it fails it just won't merge ;-) | 13:43 |
| e0ne | geguileo: you're right. just put my +A on it. thanks:) | 13:43 |
| geguileo | e0ne: Ok | 13:43 |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Remove the unnecassary volume_api.get(context, volume_id) https://review.openstack.org/218781 | 13:45 |
| *** yuriy_n17 has joined #openstack-cinder | 13:45 | |
| *** esker has quit IRC | 13:47 | |
| *** esker has joined #openstack-cinder | 13:48 | |
| *** bill_az has joined #openstack-cinder | 13:49 | |
| openstackgerrit | wanghao proposed openstack/cinder: Add pagination to backups https://review.openstack.org/204493 | 13:49 |
| *** annegentle has quit IRC | 13:49 | |
| *** breitz has quit IRC | 13:50 | |
| *** breitz has joined #openstack-cinder | 13:50 | |
| *** amoturi has joined #openstack-cinder | 13:51 | |
| *** jungleboyj has quit IRC | 13:54 | |
| *** agarciam has joined #openstack-cinder | 13:57 | |
| *** anshul has quit IRC | 13:58 | |
| *** zhangjn has joined #openstack-cinder | 13:59 | |
| *** zhangjn has quit IRC | 13:59 | |
| *** mriedem has joined #openstack-cinder | 13:59 | |
| *** zhangjn has joined #openstack-cinder | 14:00 | |
| *** IanGovett has joined #openstack-cinder | 14:01 | |
| *** deepakcs has quit IRC | 14:03 | |
| *** bnemec has joined #openstack-cinder | 14:05 | |
| *** afazekas__ has quit IRC | 14:08 | |
| *** zhangjn has quit IRC | 14:09 | |
| openstackgerrit | wanghao proposed openstack/cinder: Add updated_at into response of listing detail https://review.openstack.org/202029 | 14:09 |
| *** markvoelker has quit IRC | 14:09 | |
| *** edtubill has joined #openstack-cinder | 14:11 | |
| *** eharney has quit IRC | 14:11 | |
| *** boris-42 has joined #openstack-cinder | 14:11 | |
| *** timcl has quit IRC | 14:11 | |
| *** anshul has joined #openstack-cinder | 14:11 | |
| *** rushil_ has quit IRC | 14:12 | |
| *** sidbhatt13 has joined #openstack-cinder | 14:13 | |
| *** sidbhatt13 has quit IRC | 14:15 | |
| *** zhangjn has joined #openstack-cinder | 14:17 | |
| *** shausy has quit IRC | 14:17 | |
| *** peter-wang has joined #openstack-cinder | 14:18 | |
| *** yrabl has joined #openstack-cinder | 14:19 | |
| *** peter-wang has left #openstack-cinder | 14:19 | |
| *** annegentle has joined #openstack-cinder | 14:19 | |
| *** zhangjn has quit IRC | 14:21 | |
| *** r-daneel has joined #openstack-cinder | 14:22 | |
| *** peter-wang has joined #openstack-cinder | 14:22 | |
| openstackgerrit | Joel Coffman proposed openstack/cinder: Clean up volume_type_update method https://review.openstack.org/213829 | 14:22 |
| *** timcl has joined #openstack-cinder | 14:24 | |
| openstackgerrit | Tom Barron proposed openstack/cinder: Scheduler-based over-subscription for NFS drivers https://review.openstack.org/216055 | 14:28 |
| *** lpetrut has quit IRC | 14:32 | |
| *** sidbhatt13 has joined #openstack-cinder | 14:33 | |
| *** mriedem is now known as mriedem_away | 14:39 | |
| *** andreykurilin__ has joined #openstack-cinder | 14:41 | |
| *** lpetrut has joined #openstack-cinder | 14:43 | |
| openstackgerrit | Daniel Tadrzak proposed openstack/cinder: Cleanup for cinder tests with CGSnapshot https://review.openstack.org/207866 | 14:44 |
| *** garthb has joined #openstack-cinder | 14:47 | |
| *** jkremer has joined #openstack-cinder | 14:48 | |
| *** eharney has joined #openstack-cinder | 14:48 | |
| *** zhangjn has joined #openstack-cinder | 14:49 | |
| jgriffith | mriedem_away: on patch https://review.openstack.org/#/c/218664/1 | 14:51 |
| jgriffith | mriedem_away: I was wondering if you'd mind terribly moving that to the existing log statement here: https://github.com/openstack/cinder/blob/master/cinder/volume/api.py#L642 | 14:51 |
| *** dims has quit IRC | 14:51 | |
| *** IlyaG has joined #openstack-cinder | 14:53 | |
| *** markvoelker has joined #openstack-cinder | 14:53 | |
| *** gouthamr has joined #openstack-cinder | 14:54 | |
| *** markvoelker has quit IRC | 14:54 | |
| *** markvoelker has joined #openstack-cinder | 14:55 | |
| *** crose has joined #openstack-cinder | 14:55 | |
| openstackgerrit | Daniel Tadrzak proposed openstack/cinder: Cleanup for SnapshotObject https://review.openstack.org/198341 | 14:56 |
| *** jistr is now known as jistr|call | 14:57 | |
| *** cristicalin has quit IRC | 14:58 | |
| *** rhagarty__ has joined #openstack-cinder | 14:58 | |
| *** zhipeng has joined #openstack-cinder | 14:58 | |
| openstackgerrit | Tom Barron proposed openstack/cinder: NetApp DOT block driver over-subscription support https://review.openstack.org/215865 | 14:58 |
| *** lcurtis has joined #openstack-cinder | 15:00 | |
| *** rhagarty__ has quit IRC | 15:02 | |
| *** s_amann has quit IRC | 15:02 | |
| *** dims has joined #openstack-cinder | 15:03 | |
| *** s_amann has joined #openstack-cinder | 15:03 | |
| amoturi | Could someone from the core team please review this patchset https://review.openstack.org/#/c/211299/ | 15:03 |
| *** lyanchih has joined #openstack-cinder | 15:04 | |
| *** hemnafk has quit IRC | 15:04 | |
| *** bnemec has quit IRC | 15:04 | |
| *** rhagarty__ has joined #openstack-cinder | 15:08 | |
| openstackgerrit | Daniel Tadrzak proposed openstack/cinder: Cleanup for cinder tests with CGSnapshot https://review.openstack.org/207866 | 15:08 |
| *** bnemec has joined #openstack-cinder | 15:09 | |
| lyanchih | jaypipes: Hi, recently I report a bug https://bugs.launchpad.net/nova/+bug/1489744 . It is talking about swap volume will stay in incorrect status. When I try to fix, I found nova expect cinder’s migration_volume_complete api should attach and detach volume. But cinder will only return new volume’s id. I have no idea about such situation. Nova’s member said I can come here to discuss. | 15:11 |
| openstack | Launchpad bug 1489744 in OpenStack Compute (nova) "Swapping volume will not result in correct status" [Undecided,New] - Assigned to Chung Chih, Hung (lyanchih) | 15:11 |
| openstackgerrit | Oleksii Butenko proposed openstack/python-cinderclient: Add functional tests for python-cinderclient https://review.openstack.org/218895 | 15:18 |
| *** hodos has joined #openstack-cinder | 15:18 | |
| *** peter-wang has quit IRC | 15:20 | |
| *** ronis has quit IRC | 15:21 | |
| *** jaypipes has quit IRC | 15:26 | |
| *** agarciam has quit IRC | 15:28 | |
| *** haomaiwa_ has quit IRC | 15:29 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/215440 | 15:30 |
| *** david-ly_ has joined #openstack-cinder | 15:31 | |
| *** david-ly_ is now known as david-lyle_ | 15:33 | |
| *** harlowja_at_home has joined #openstack-cinder | 15:33 | |
| *** david-lyle has quit IRC | 15:33 | |
| openstackgerrit | Eric Harney proposed openstack/cinder: Remove executable bits on files https://review.openstack.org/218407 | 15:34 |
| *** david-lyle_ is now known as david-lyle | 15:35 | |
| *** anshul has quit IRC | 15:35 | |
| *** crose has quit IRC | 15:35 | |
| *** jungleboyj has joined #openstack-cinder | 15:36 | |
| *** lyanchih has quit IRC | 15:38 | |
| *** rhagarty__ has quit IRC | 15:43 | |
| *** IanGovett1 has joined #openstack-cinder | 15:43 | |
| *** IanGovett has quit IRC | 15:43 | |
| openstackgerrit | Eric Harney proposed openstack/cinder: Detect addition of executable files https://review.openstack.org/218408 | 15:46 |
| *** rushil has joined #openstack-cinder | 15:48 | |
| *** shyama has joined #openstack-cinder | 15:49 | |
| *** jistr|call is now known as jistr | 15:53 | |
| *** zhangjn has quit IRC | 15:54 | |
| *** sgotliv has quit IRC | 15:55 | |
| *** diegows has joined #openstack-cinder | 15:58 | |
| *** annegentle has quit IRC | 15:59 | |
| *** markvoelker_ has joined #openstack-cinder | 16:00 | |
| *** markvoel_ has joined #openstack-cinder | 16:01 | |
| *** timcl has quit IRC | 16:03 | |
| *** Apoorva has joined #openstack-cinder | 16:03 | |
| *** markvoelker has quit IRC | 16:03 | |
| *** dannywilson has joined #openstack-cinder | 16:04 | |
| *** sayali has quit IRC | 16:04 | |
| *** IanGovett1 has quit IRC | 16:05 | |
| *** timcl has joined #openstack-cinder | 16:05 | |
| *** markvoelker_ has quit IRC | 16:05 | |
| *** IanGovett has joined #openstack-cinder | 16:06 | |
| *** sayali has joined #openstack-cinder | 16:06 | |
| *** zhipeng has quit IRC | 16:07 | |
| openstackgerrit | Michael Price proposed openstack/cinder: Add additional SSC extra specs to E-Series driver https://review.openstack.org/215808 | 16:08 |
| openstackgerrit | Michael Price proposed openstack/cinder: Implement thin provisioning support for E-Series https://review.openstack.org/215833 | 16:08 |
| *** mriedem_away is now known as mriedem | 16:08 | |
| *** IanGovett1 has joined #openstack-cinder | 16:10 | |
| *** IanGovett has quit IRC | 16:10 | |
| mriedem | jgriffith: is there a reason for moving it from the volume manager to the volume api? | 16:10 |
| mriedem | oh i see the comment now | 16:10 |
| mriedem | jgriffith: i'm assuming you're referring to sdague's oslo blueprint/rules on logging | 16:11 |
| *** leeantho has joined #openstack-cinder | 16:11 | |
| *** jistr has quit IRC | 16:13 | |
| mriedem | jgriffith: https://wiki.openstack.org/wiki/LoggingStandards#Messages_at_INFO_should_be_a_unit_of_work | 16:14 |
| mriedem | jgriffith: i could change from info to debug in https://review.openstack.org/#/c/218664/ - i think that makes sense | 16:14 |
| mriedem | i wanted to keep the log message before the call to the volume driver though | 16:14 |
| jgriffith | mriedem: correct | 16:14 |
| jgriffith | mriedem: fair enough | 16:14 |
| jgriffith | mriedem: I still gave it a +2 :) | 16:14 |
| mriedem | yeah, i'll update quick | 16:14 |
| jgriffith | mriedem: I would prefer it demoted to debug in that case, but leaving it up to you | 16:15 |
| jgriffith | mriedem: if you don't like any of those options I'll go ahead and approve it | 16:15 |
| jgriffith | mriedem: but our logging is kind of a mess and inconsistent in Cinder :( | 16:15 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder: Remove API races from delete methods https://review.openstack.org/205835 | 16:15 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder: Add atomic conditional updates to objects https://review.openstack.org/205834 | 16:15 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder: WIP: Remove more API races https://review.openstack.org/216378 | 16:15 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder: Move get_by_id to CinderObject https://review.openstack.org/218012 | 16:15 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder: Improve metadata update operations https://review.openstack.org/216376 | 16:15 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder: Remove API races from attach and detach methods https://review.openstack.org/216377 | 16:15 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder: Rename db.api methods to match models' names https://review.openstack.org/218936 | 16:15 |
| jgriffith | I see everybody has been busy creating all sorts of branches and using stash this week-end | 16:16 |
| patrickeast | jgriffith: hey, let me know if/when you have a couple min to chat about the image cache review, just saw your comments and wanted to make sure I understand everything | 16:16 |
| jgriffith | patrickeast: I'm working on some stuff now | 16:17 |
| jgriffith | patrickeast: with the caching | 16:17 |
| jgriffith | patrickeast: so the biggest problem is the context stuff | 16:17 |
| jgriffith | patrickeast: it's also "kinda fat" | 16:17 |
| jgriffith | patrickeast: we could've done this much more easily with a new of modified create_from_image I think.. but that's not a big deal | 16:18 |
| jgriffith | patrickeast: I'm not sure why your db calls are puking all over the place though | 16:18 |
| patrickeast | jgriffith: yea so thats new, i haven't seen that | 16:18 |
| jgriffith | patrickeast: it's sort of disturbing | 16:18 |
| patrickeast | jgriffith: ill have to go try and repo this morining, it might be something from one of the rebases | 16:18 |
| jgriffith | patrickeast: and what's WORSE, is thanks to tflow retries I end up with 3 image volumes | 16:18 |
| patrickeast | jgriffith: definitely want to get that fixed | 16:19 |
| jgriffith | patrickeast: but none in the db and none that ever get used | 16:19 |
| patrickeast | jgriffith: shiit | 16:19 |
| patrickeast | jgriffith: thats not good | 16:19 |
| jgriffith | patrickeast: at the very least we need to mark these as non-retryable for taskflow | 16:19 |
| patrickeast | jgriffith: do you know how to do that? | 16:19 |
| * patrickeast doesn't | 16:19 | |
| jgriffith | patrickeast: yeah... there's a list of exceptions you can add in and say "don't try these again" | 16:20 |
| jgriffith | patrickeast: but that means we also have to translate and raise something appropriate in that case | 16:20 |
| *** e0ne has quit IRC | 16:20 | |
| patrickeast | jgriffith: ah, ok, gotcha | 16:20 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/os-brick: Add new Connector APIs for path validation https://review.openstack.org/199764 | 16:20 |
| jgriffith | patrickeast: the tenant thing is easier to get around, drivers can pull in the config themeselves | 16:20 |
| jgriffith | patrickeast: but that's kind of a PITA as it's just using the existing clone... it *should* be able to just use the owner context like we already do in the clone call | 16:21 |
| patrickeast | jgriffith: yea so i wasn't sure about the tenant, imo its weird to have each backend be able to use their own internal tenant... so i'm not really sure the problem with that config | 16:21 |
| jgriffith | patrickeast: I agree, I'm certainly not proposing each has their own tenant | 16:21 |
| jgriffith | patrickeast: it looks like you moved some of the configs into manager which I think will help with some of the things I was concerned about so that's good | 16:22 |
| patrickeast | jgriffith: ok cool, but that does mean i don't understand what the issue is :o | 16:22 |
| jgriffith | LOL | 16:22 |
| jgriffith | patrickeast: so here's the problem.... | 16:22 |
| *** jaypipes has joined #openstack-cinder | 16:22 | |
| *** skylerberg has joined #openstack-cinder | 16:22 | |
| jgriffith | patrickeast: You create the template (create-volume(internal-tenant-context, image=xxxx)) | 16:22 |
| jgriffith | patrickeast: that's all cool | 16:22 |
| jgriffith | patrickeast: BUT, then the clone_volume call goes down | 16:23 |
| *** ronis has joined #openstack-cinder | 16:23 | |
| openstackgerrit | Eric Harney proposed openstack/cinder: Detect addition of executable files https://review.openstack.org/218408 | 16:23 |
| openstackgerrit | Matt Riedemann proposed openstack/cinder: Add debug logging before attaching volume in driver https://review.openstack.org/218664 | 16:23 |
| jgriffith | patrickeast: it's supposed to be "source-context" and vref as params | 16:23 |
| jgriffith | patrickeast: that way the src context is used to "find" the actual source volume for the clone... and the destination project info is pulled from the vref | 16:24 |
| patrickeast | jgriffith: ok, im following you there | 16:24 |
| jgriffith | patrickeast: it looks like you're passing in the context for the destination on the clone call | 16:24 |
| jgriffith | at least that's what I'm seeing at the driver layer | 16:24 |
| * patrickeast pulls up the code | 16:24 | |
| patrickeast | lemmie check... i thought i was doing what you just described as the correct way, but totally possible i mixed em up | 16:25 |
| *** salv-orl_ has joined #openstack-cinder | 16:25 | |
| jgriffith | patrickeast: hmm... | 16:25 |
| patrickeast | so this is in the cache hit clone or in the cache miss creation of the template clone? | 16:25 |
| jgriffith | patrickeast: could be... I haven't stepped through everything yet (surprisingly kinda busy this morning :) ) | 16:25 |
| patrickeast | or both? | 16:25 |
| patrickeast | heh yea i imagine today will be busy for a lot of foks | 16:26 |
| jgriffith | patrickeast: not sure... all I know is it's in a clone call | 16:26 |
| patrickeast | folks* | 16:26 |
| patrickeast | ok i'll take a look | 16:26 |
| *** ronis has quit IRC | 16:26 | |
| jgriffith | mriedem: you're the man!!! | 16:26 |
| mriedem | \o. | 16:27 |
| patrickeast | one last thing, just to make sure we are on the same page, my comment about documenting it wont work for some drivers wasn't anything to do with the driver configs not working, i agree that needs to be fixed, i was talking specifically about the problem 3PAR has | 16:27 |
| patrickeast | jgriffith: ^ | 16:27 |
| *** harlowja_at_home has quit IRC | 16:28 | |
| jgriffith | patrickeast: understood... but I have issues with that :( | 16:28 |
| *** salv-orlando has quit IRC | 16:28 | |
| jgriffith | patrickeast: I'm not going to fight it any more, but I STILL firmly believe that this business of "some features work for some backends, and not for others" is the COMPLETE WRONG direction for Cinder | 16:28 |
| patrickeast | jgriffith: i've discussed this a bunch with hemna and the problem is 100% the way they implemented their clone_volume in the driver | 16:28 |
| patrickeast | jgriffith: its a bug in their driver | 16:28 |
| jgriffith | patrickeast: understood | 16:29 |
| jgriffith | patrickeast: the good thing is I'm obviously the only one who cares about this any more so it's not really a big deal :) | 16:29 |
| *** porrua has joined #openstack-cinder | 16:29 | |
| jgriffith | patrickeast: Totally cool with that. | 16:30 |
| patrickeast | jgriffith: :( don't get me wrong i understand what you are saying, i guess i see this as differently... it isn't that they *cant* do it, its just a bug they have with the way its implemented right now | 16:30 |
| *** jungleboyj has quit IRC | 16:30 | |
| jgriffith | patrickeast: I'm just using it as an opportunity to state my opinion that I think we're making some pretty big mistakes with the project and we should really think about quality and behavior for people using Cinder | 16:31 |
| patrickeast | jgriffith: gotcha | 16:31 |
| *** markvoel_ has quit IRC | 16:31 | |
| *** ociuhandu has joined #openstack-cinder | 16:31 | |
| jgriffith | patrickeast: and stop worrying so much about the features our company has to offer or what BS our sales people feed us that they "have to have" | 16:31 |
| jgriffith | patrickeast: anyway, don't get me started :) | 16:31 |
| *** markvoelker has joined #openstack-cinder | 16:31 | |
| *** yrabl has quit IRC | 16:32 | |
| patrickeast | jgriffith: haha, alright, well i think we are on the same page with this stuff... i'll try and figure out whats going on with the db and double check the context stuff | 16:32 |
| *** markvoelker_ has joined #openstack-cinder | 16:32 | |
| jgriffith | patrickeast: cool... I'm looking as well (on and off) | 16:32 |
| patrickeast | jgriffith: thanks for taking the time to look at this stuff, i appreciate the in-depth review | 16:33 |
| *** lifeless has quit IRC | 16:34 | |
| *** angela-s has joined #openstack-cinder | 16:34 | |
| *** annegentle has joined #openstack-cinder | 16:35 | |
| *** markvoelker has quit IRC | 16:36 | |
| *** markvoelker_ has quit IRC | 16:37 | |
| sidbhatt13 | Hello. I'm new here and just getting started developing a new volume driver. Quick question: the minimum features that a driver must implement are listed here (http://docs.openstack.org/developer/cinder/devref/drivers.html) but the page doesn't mention Juno/Kilo/Liberty. Has anything changed, or is the list on that page still current? | 16:39 |
| *** crose has joined #openstack-cinder | 16:39 | |
| *** jungleboyj has joined #openstack-cinder | 16:40 | |
| *** yuriy_n17 has quit IRC | 16:40 | |
| *** lifeless has joined #openstack-cinder | 16:41 | |
| jgriffith | patrickeast: ya know, it sure would've been easier to just put all this in the manager :) | 16:42 |
| jgriffith | sidbhatt13: not much has changed... BUT | 16:43 |
| jgriffith | sidbhatt13: you probably will have better luck just looking at the base VD class in openstack/cinder/cinder/volume/driver.py | 16:44 |
| *** s_amann has quit IRC | 16:44 | |
| patrickeast | jgriffith: maybe, I tried a couple of ways but it always ended up worse jumping back and forth between task flow code and manager code... seemed to be best if its all one way or the other | 16:44 |
| sidbhatt13 | jgriffith: i'll do that, thanks. | 16:45 |
| jgriffith | patrickeast: yeah.... but the nice thing about keeping it in manager is you can just effect everything locally as a driver | 16:45 |
| jgriffith | patrickeast: you don't need to jump back and forth... but admittedly, yes there are a couple of details that end up being a trade-off and might not be much better | 16:45 |
| *** sghanekar has joined #openstack-cinder | 16:45 | |
| patrickeast | jgriffith: we can always look into refactoring it too, ideally this can we changed around and not affect the end user in any way | 16:46 |
| patrickeast | be* | 16:46 |
| jgriffith | patrickeast: agreed | 16:47 |
| jgriffith | sidbhatt13: look for these: https://github.com/openstack/cinder/blob/master/cinder/volume/driver.py#L485 | 16:48 |
| jgriffith | sidbhatt13: things in base vd with the abc decorator are things you "MUST" impelement | 16:48 |
| jgriffith | sidbhatt13: good place to start at any rate | 16:48 |
| jgriffith | sidbhatt13: and make sure you referece the lvm driver for some details | 16:48 |
| jgriffith | sidbhatt13: things are going to be kinda hectic around here the next day or two but there's usually plenty of helpful people around | 16:49 |
| sidbhatt13 | jgriffith: yup, looking at that class now. i'll hang out here and also subscribe to the mailing list in case i have other questions. btw, any idea what the deadline might be for completing a new volume driver for the "M" release? | 16:50 |
| jgriffith | sidbhatt13: for M it's going to likely be the first milestone again (don't know exact date) | 16:51 |
| jgriffith | sidbhatt13: but will probably be around end of Nov/Dec I'm guessing (early) | 16:51 |
| sidbhatt13 | jgriffith: ok. thanks. | 16:52 |
| *** tpsilva has joined #openstack-cinder | 16:52 | |
| *** crose has quit IRC | 16:53 | |
| *** lpetrut has quit IRC | 16:53 | |
| *** dims has quit IRC | 16:55 | |
| *** salv-orl_ has quit IRC | 16:56 | |
| sdague | jgriffith: https://jenkins06.openstack.org/job/gate-cinder-python27/4414/console - openssl now a requirement for the tests, but not specified? | 17:00 |
| sdague | 2 cinder patches failing in gate over this | 17:01 |
| jgriffith | sdague: looking... | 17:01 |
| *** kvidvans has quit IRC | 17:01 | |
| jgriffith | sdague: sigh... k | 17:02 |
| jgriffith | sdague: I'll get it added or get xyang1 to check it out (her code introduced it) | 17:02 |
| sdague | jgriffith: ok, thanks | 17:02 |
| jgriffith | sdague: sure | 17:02 |
| jgriffith | xyang1: you around? | 17:02 |
| *** earlephilhower has joined #openstack-cinder | 17:02 | |
| xyang1 | jgriffith: What is this? | 17:02 |
| *** dannywilson has quit IRC | 17:02 | |
| jgriffith | xyang1: looks like vmax added a dep on ssl? | 17:03 |
| jgriffith | xyang1: https://jenkins06.openstack.org/job/gate-cinder-python27/4414/console | 17:03 |
| xyang1 | jgriffith: Let me see | 17:03 |
| jgriffith | xyang1: ./emc_vmax_https.py:import ssl | 17:04 |
| xyang1 | jgriffith: I wonder why it failed now | 17:04 |
| xyang1 | It was merged some time ago | 17:05 |
| jgriffith | xyang1: looking.... | 17:06 |
| *** IanGovett1 has quit IRC | 17:08 | |
| *** rhagarty_ has quit IRC | 17:09 | |
| *** rhagarty has quit IRC | 17:09 | |
| sdague | it may be that there is some platform assumption that's not expressed in tox that leaked through? | 17:10 |
| *** julim has joined #openstack-cinder | 17:11 | |
| jgriffith | sdague: which patch ref is that? I think I'm confused. | 17:14 |
| *** rhagarty has joined #openstack-cinder | 17:14 | |
| jgriffith | xyang1: either way, as your using ssl wouldn't hurt us to update to explicitly adding pyopenssl I don't hink | 17:14 |
| jgriffith | think | 17:14 |
| *** rhagarty_ has joined #openstack-cinder | 17:14 | |
| xyang1 | I don't know. This was merged back in Feb. 8 | 17:15 |
| *** rhedlind has joined #openstack-cinder | 17:15 | |
| xyang1 | jgriffith: sdague I'd like to see which patch this is failing on | 17:16 |
| jgriffith | xyang1: regardless, the import of OpenSSL is in the driver code | 17:16 |
| sdague | just go to status.openstack.org/zuul | 17:16 |
| jgriffith | xyang1: and we're not doing anything anywhere ot ensure it's there | 17:16 |
| sdague | there are 2 patches failing in gate | 17:16 |
| jgriffith | sdague: yeah, but I'm not seeing the same thing :( | 17:17 |
| jgriffith | sdague: I'm just seeing the gluster fail? | 17:17 |
| sdague | oh, they just reset | 17:17 |
| sdague | because ironic | 17:17 |
| jgriffith | sdague: hehe.. ok, so I'm not crazy | 17:17 |
| jgriffith | well... | 17:17 |
| sdague | https://jenkins06.openstack.org/job/gate-cinder-python27/4414/console - those results are still registered | 17:17 |
| openstackgerrit | yogeshprasad proposed openstack/cinder: Retype support for CloudByte iSCSI cinder driver https://review.openstack.org/218645 | 17:18 |
| sdague | 2015-08-31 16:32:35.299 | Triggered by: https://review.openstack.org/187270 | 17:18 |
| sdague | the review url always exists in the console | 17:18 |
| openstackgerrit | yogeshprasad proposed openstack/cinder: Retype support for CloudByte iSCSI cinder driver https://review.openstack.org/218645 | 17:19 |
| *** aix has quit IRC | 17:21 | |
| *** alexschm has quit IRC | 17:23 | |
| *** IanGovett has joined #openstack-cinder | 17:24 | |
| xyang1 | jgriffith: sdague I can open a bug and fix our test to ignore the import error? | 17:24 |
| *** e0ne has joined #openstack-cinder | 17:26 | |
| *** dims has joined #openstack-cinder | 17:29 | |
| *** vilobhmm1 has joined #openstack-cinder | 17:29 | |
| *** dims_ has joined #openstack-cinder | 17:30 | |
| *** dims has quit IRC | 17:30 | |
| openstackgerrit | Joel Coffman proposed openstack/cinder: Clean up volume_type_update method https://review.openstack.org/213829 | 17:31 |
| nikeshm | hi, do cinder supports incremental snapshot? | 17:35 |
| *** e0ne has quit IRC | 17:36 | |
| *** e0ne has joined #openstack-cinder | 17:39 | |
| *** kvidvans has joined #openstack-cinder | 17:40 | |
| *** diablo_rojo has quit IRC | 17:40 | |
| *** lpetrut has joined #openstack-cinder | 17:43 | |
| *** ig0r__ has joined #openstack-cinder | 17:43 | |
| jbernard | nikeshm: it depends on the backend being used | 17:44 |
| jbernard | nikeshm: and the cinder driver that enables it (to be more precise) | 17:44 |
| jbernard | nikeshm: but it can, yes | 17:44 |
| *** ig0r_ has quit IRC | 17:46 | |
| sdague | xyang1 / jgriffith all those patches are failing in the gate again | 17:46 |
| *** MIDENN_ has joined #openstack-cinder | 17:46 | |
| xyang1 | sdague: pyOpenSSL is in the requirement | 17:47 |
| nikeshm | jbernard: can you share any link of incremental snapshot? | 17:47 |
| *** crose has joined #openstack-cinder | 17:47 | |
| jbernard | nikeshm: you can look at the rbd driver | 17:48 |
| sdague | xyang1: where? | 17:48 |
| xyang1 | sdague: jgriffith gloabal-requirements.txt | 17:48 |
| *** aix has joined #openstack-cinder | 17:48 | |
| sdague | xyang1: it's not in cinder's requirements file | 17:49 |
| xyang1 | sdague: You mean the test requirement should have this too? | 17:50 |
| sdague | xyang1: one of the requirements files needs it, if it's going to unconditionally import it | 17:50 |
| sdague | there needs to be no assumption on system level packages | 17:50 |
| sdague | yes, there are now 4 cinder patches failing in the gate | 17:51 |
| sdague | for this reason | 17:51 |
| xyang1 | sdague: I wonder if something got removed recently as this is an old change | 17:52 |
| sdague | xyang1: might have been | 17:52 |
| sdague | mtreinish: any thoughts on why this might have just exposed? | 17:53 |
| sdague | did something change with ostestr | 17:53 |
| mtreinish | sdague: is there a link? I don't have any context | 17:53 |
| mtreinish | but I haven't pushed a ostestr release in a few weeks | 17:54 |
| sdague | all the cinder tests are now failing on openssl not being there - https://jenkins03.openstack.org/job/gate-cinder-python27/1436/console | 17:54 |
| nikeshm | jbernard: thanks, what about glustefs driver? | 17:54 |
| sdague | but apparently, this isn't new | 17:54 |
| sdague | so, trying to develop a working theory on why | 17:54 |
| mtreinish | sdague: that error is coming from the test runner trying to do discovery | 17:54 |
| sdague | like discovery changing | 17:54 |
| sdague | mtreinish: right | 17:55 |
| sdague | mtreinish: but it's on patches that don't touch that file | 17:55 |
| sdague | that has the discovery issue | 17:55 |
| jbernard | nikeshm: i think you'll find support there as well | 17:56 |
| openstackgerrit | yogeshprasad proposed openstack/cinder: Retype support for CloudByte iSCSI cinder driver https://review.openstack.org/218645 | 17:57 |
| mtreinish | sdague: well the last unittest2 release (which is where discovery would be) is from june | 17:58 |
| sdague | mtreinish: yep, nothing is jumping out at me either | 17:58 |
| sdague | which is why I was throwing it to you as a hail marry | 17:58 |
| sdague | in case I missed something | 17:58 |
| *** IlyaG has quit IRC | 17:59 | |
| mtreinish | sdague: well, the other thing is maybe it was getting pulled into the nodepool images before | 18:00 |
| mtreinish | but that would imply site packages was enabled | 18:00 |
| mtreinish | so it it's probably not that | 18:00 |
| sdague | so here is a failing run - https://jenkins03.openstack.org/job/gate-cinder-python27/1435/console | 18:01 |
| sdague | here is a passing run - https://jenkins02.openstack.org/job/gate-cinder-python27/1354/consoleFull | 18:01 |
| sdague | in the passing run, openssl definitely gets installed | 18:01 |
| mtreinish | sdague: yep, it's getting pulled in by something | 18:02 |
| nikeshm | jbernard: when i googled "Incremental Snapshot in openstack cinder", its giving "incremental backup support" in cinder | 18:03 |
| sdague | http://paste.openstack.org/show/435330/ | 18:03 |
| sdague | in the failing case, no cffi installing either | 18:03 |
| *** timcl has quit IRC | 18:03 | |
| *** IlyaG_ has joined #openstack-cinder | 18:03 | |
| sdague | no cryptography | 18:03 |
| jbernard | nikeshm: that's a different feature | 18:03 |
| e0ne | thingee: hi Mike. are you around? | 18:04 |
| *** salv-orlando has joined #openstack-cinder | 18:04 | |
| *** IlyaG_ has quit IRC | 18:05 | |
| sdague | ah... it's the python-glanceclient release | 18:06 |
| sdague | python-glanceclient 1.0 no longer requires pyopenssl directly | 18:06 |
| sdague | they removed all of that | 18:06 |
| mtreinish | sdague: oh, ok, that makes sense | 18:06 |
| sdague | the cinder code still needs pyopenssl, but didn't specify it | 18:06 |
| mtreinish | sdague: well the fix is the same either way, cinder should be requiring pyopenssl if it is importing it | 18:07 |
| sdague | and worked because glanceclient dragged it in | 18:07 |
| mtreinish | yep | 18:07 |
| openstackgerrit | Mitsuhiro Tanino proposed openstack/cinder-specs: Fix Get Volume Driver Capabilities Spec https://review.openstack.org/216394 | 18:07 |
| sdague | jgriffith / xyang1 ^^^ | 18:07 |
| sdague | that's why you used to work before | 18:07 |
| sdague | and are going to fail 100% now | 18:07 |
| *** salv-orlando has quit IRC | 18:09 | |
| sdague | ok, jgriffith / xyang1 someone posting that patch? | 18:12 |
| xyang1 | sdague: I can do it | 18:12 |
| openstackgerrit | Sean Dague proposed openstack/cinder: Add support for file I/O volume migration https://review.openstack.org/187270 | 18:12 |
| xyang1 | sdague: jgriffith so I add it to cinder test-requirement only? | 18:13 |
| sdague | ok, I'm clearing all the gate queue patches at the moment, as these are jamming it up for others | 18:13 |
| sdague | xyang1: that should be fine | 18:13 |
| *** IlyaG has joined #openstack-cinder | 18:13 | |
| openstackgerrit | Sean Dague proposed openstack/cinder: Enhance FC zone support for Huawei driver https://review.openstack.org/201578 | 18:13 |
| xyang1 | sdague: Ok, thanks | 18:13 |
| openstackgerrit | Sean Dague proposed openstack/cinder: Add pagination to backups https://review.openstack.org/204493 | 18:13 |
| *** takedakn has quit IRC | 18:13 | |
| openstackgerrit | Sean Dague proposed openstack/cinder: Allow specified backend capabilities to be retrieved https://review.openstack.org/212861 | 18:13 |
| openstackgerrit | Sean Dague proposed openstack/cinder: LVM: add the exception handling to volume copy https://review.openstack.org/218750 | 18:13 |
| sdague | xyang1: https://bugs.launchpad.net/cinder/+bug/1490668 - opened a bug for this | 18:16 |
| openstack | Launchpad bug 1490668 in Cinder "cinder test-requirements does not include pyopenssl" [Critical,New] | 18:16 |
| xyang1 | sdague: Ok | 18:16 |
| tbarron | yah, our internal CI is clogged up with this one too ^^^^ :) | 18:17 |
| sdague | tbarron: would have been helpful to raise that fact :) | 18:17 |
| eharney | xyang1: i think i've found a way to get the tests to pass w/o adding it as a requirement | 18:17 |
| *** IlyaG has quit IRC | 18:17 | |
| xyang1 | eharney: Oh, how | 18:17 |
| tbarron | sdague: agree, but I just realized what it was ... | 18:17 |
| *** markvoelker has joined #openstack-cinder | 18:17 | |
| *** IlyaG has joined #openstack-cinder | 18:18 | |
| sdague | eharney: it explodes on pep8 for similar reasons | 18:18 |
| *** julim has quit IRC | 18:18 | |
| nikeshm | jbernard: thanks, when i searched "copy on write", then its showing Ceph RBD drivers | 18:18 |
| eharney | xyang1: we often do this kind of thing for driver reqs: https://paste.fedoraproject.org/261621/4508614/raw/ | 18:18 |
| xyang1 | eharney: That is ok too, if you guys think that is better | 18:19 |
| nikeshm | jbernard: but not showing about any other driver | 18:20 |
| xyang1 | sdague: eharney which way is better | 18:20 |
| *** markvoelker has quit IRC | 18:21 | |
| *** julim has joined #openstack-cinder | 18:21 | |
| eharney | xyang1: i always prefer this because it means we don't add deps that are only relevant for one driver | 18:21 |
| sdague | honestly, I'm not sure what you are testing, I'll leave eharney to decide | 18:21 |
| xyang1 | sdague: eharney ok, will do | 18:21 |
| *** IlyaG has quit IRC | 18:22 | |
| *** diablo_rojo has joined #openstack-cinder | 18:23 | |
| jbernard | nikeshm: you'll have to look into the particular drivers you're interested in | 18:25 |
| openstackgerrit | Eric Harney proposed openstack/cinder: Don't require OpenSSL for unit tests https://review.openstack.org/218977 | 18:25 |
| *** rushil has quit IRC | 18:25 | |
| eharney | xyang1: ^ had some unrelated issues in my test env (i think), hopefully this works | 18:25 |
| jbernard | nikeshm: the incremental logic is implemented in the storage backend, so you're looking for backend support and wether the cinder driver exposes it | 18:26 |
| xyang1 | eharney: Ok, let's see | 18:26 |
| jbernard | nikeshm: i think you'll find support for snapshots in most cases; backups are a different matter | 18:26 |
| *** p0rtal has joined #openstack-cinder | 18:27 | |
| jbernard | nikeshm: improvements on that front are underway | 18:27 |
| jgriffith | eharney: xyang1 just my two cents... but IMO that should use pyopenssl, and even if you use the if/else hack you still should probably have it in the requirements file. | 18:28 |
| eharney | jgriffith: we've opted to not add things like this for a handful of other drivers to the requirements files in the past... | 18:28 |
| xyang1 | jgriffith: If we add to requirement, then we still need to change the driver? | 18:28 |
| eharney | jgriffith: hp reworked their stuff to not require hp3parclient, we have that for rbd/rados too... | 18:30 |
| *** takedakn has joined #openstack-cinder | 18:30 | |
| eharney | jgriffith: drbd as well... violin... purestorage... | 18:31 |
| jgriffith | eharney: well, I meant the requirements, not test-requirements | 18:32 |
| openstackgerrit | xing-yang proposed openstack/cinder: Catch OpenSSL ImportError https://review.openstack.org/218981 | 18:32 |
| eharney | jgriffith: we don't list any of those in either | 18:32 |
| jgriffith | eharney: but I guess you're saying the same thing there | 18:32 |
| jgriffith | eharney: geesh dude, calm down | 18:33 |
| jgriffith | eharney: :) | 18:33 |
| jgriffith | give me a chance to type already | 18:33 |
| xyang1 | jgriffith: eharney sdague patch submitted, let me know if I need to change :) | 18:33 |
| jgriffith | xyang1: cool, does that monkey patch work like that when it's None? | 18:34 |
| xyang1 | jgriffith: Test does not require monkey patch | 18:35 |
| jgriffith | xyang1: cool | 18:35 |
| xyang1 | jgriffith: I can still add pyopenssl in requirement if you and eharney can agree with each othet:) | 18:35 |
| jgriffith | eharney: I'm certainly not arguing.. but I do want to clarify if that's ok with you? | 18:36 |
| jgriffith | eharney: I personally see a difference between things like hp-3parclient and openssl libraries | 18:36 |
| jgriffith | eharney: which is the only reason I mentioned it | 18:36 |
| eharney | jgriffith: well.. the drbd driver does this with dbus, which is more like the openssl requirements | 18:37 |
| jgriffith | eharney: I don't think that things like pyopenssl and vendor libraries fall into the same category; however I also don't care. If it's preferred to if out the import because only one driver is using it that's fine by me | 18:37 |
| jgriffith | eharney: ok, but regardless that doesn't change the statement I made above. Again, I'm not arguing with you at all | 18:38 |
| eharney | we can add it as a req if it's easier to fix the gate etc, but i'm not really sure what the benefit is | 18:38 |
| jgriffith | eharney: I don't think there is any benefit and not saying we should do that. Just pointing out why that was my first response | 18:38 |
| jgriffith | that's all... no big deal | 18:38 |
| patrickeast | jgriffith: hey, so i can't for the life of me repro that db issue you are seeing with the image cache, got any tips on how you made it break? are you using devstack defaults or anything special with your db config? | 18:39 |
| patrickeast | i can create volumes from images and cache hits, misses, evictions, shared images, private images, different sizes, etc. and everything looks peachy in the logs http://paste.openstack.org/show/435367/ | 18:39 |
| eharney | the main reason i don't like adding them is that most people don't need that library at all, but it brings it into every test env install, etc | 18:39 |
| *** salv-orlando has joined #openstack-cinder | 18:39 | |
| jgriffith | eharney: yeah, I agree with you. I used to give Walt crap about that ALL the time ;) | 18:40 |
| jgriffith | eharney: totally cool | 18:40 |
| jgriffith | eharney: the only thing that's different is that it is in the global reqs already, and used in other projects; but really I'm not arguing one way over the other | 18:40 |
| eharney | jgriffith: well... it was in there, anyway :) | 18:41 |
| mriedem | xyang1: did an os-brick release get out with the rootwrap filter stuff? | 18:41 |
| mriedem | dep freeze is this week | 18:41 |
| xyang1 | mriedem: I don't think so | 18:41 |
| *** takedakn has quit IRC | 18:41 | |
| xyang1 | mriedem: Where is hemna | 18:41 |
| jgriffith | mriedem: nope | 18:41 |
| jgriffith | Walt's not around, haven't seen him today | 18:42 |
| *** sgotliv has joined #openstack-cinder | 18:42 | |
| mriedem | i'll push the release request | 18:42 |
| mriedem | and add cinder core | 18:42 |
| jgriffith | mriedem: thanks | 18:42 |
| xyang1 | mriedem: Thanks | 18:42 |
| *** dflorea has joined #openstack-cinder | 18:42 | |
| jgriffith | mriedem: I'm looking to see if there's anything queued up that might be *important* | 18:42 |
| *** lpetrut has quit IRC | 18:43 | |
| xyang1 | kmartin: Will hemna be back soon? | 18:44 |
| jgriffith | mriedem: might want to merge this one https://review.openstack.org/#/c/193451/ | 18:44 |
| jgriffith | anish: ^^ | 18:44 |
| mriedem | no idea | 18:45 |
| mriedem | jgriffith: there are 2 changes with +2s though https://review.openstack.org/#/q/status:open+project:openstack/os-brick,n,z | 18:45 |
| jgriffith | mriedem: yeah... and it looks like anish 's change breaks some things | 18:46 |
| mriedem | i'd probably hold off on feature adds at this point | 18:46 |
| mriedem | right... | 18:46 |
| jgriffith | mriedem: agreed | 18:46 |
| jgriffith | mriedem: I didn't notice that until just now | 18:46 |
| *** daneyon_ has joined #openstack-cinder | 18:47 | |
| jgriffith | mriedem: ok, those two should be good, other than that I think freeze is fine | 18:48 |
| jgriffith | mriedem: hemna and others can revisit if they want later | 18:48 |
| *** ig0r__ has quit IRC | 18:48 | |
| *** dflorea_ has joined #openstack-cinder | 18:48 | |
| mriedem | cool, posting to the dev ML for now on the plan | 18:48 |
| mriedem | then i'll push the releases change once those are merged | 18:49 |
| jgriffith | mriedem: perfect | 18:49 |
| *** daneyon has quit IRC | 18:49 | |
| *** timcl has joined #openstack-cinder | 18:50 | |
| *** dflorea has quit IRC | 18:51 | |
| tbarron | xyang1: please see my comment on https://review.openstack.org/#/c/218981/ | 18:52 |
| tbarron | xyang1: hopefully I'm doing something wrong ... | 18:52 |
| eharney | tbarron: xyang1: see my version, it handled that https://review.openstack.org/#/c/218977/ | 18:53 |
| tbarron | eharney: kk, I'll try that | 18:53 |
| *** gouthamr has quit IRC | 18:55 | |
| xyang1 | eharney: Ok, thanks | 18:55 |
| jgriffith | eharney: oh, I didn't see you submitted as well | 18:55 |
| jgriffith | xyang1: isn't that the case I specifically asked you about here in IRC ? :) | 18:56 |
| *** edmondsw has quit IRC | 18:56 | |
| xyang1 | jgriffith: Sorry | 18:56 |
| jgriffith | xyang1: LOL... no problem | 18:57 |
| kmartin | xyang1, Walt is having computer issues but he is here? | 18:57 |
| *** hemna has joined #openstack-cinder | 18:57 | |
| tbarron | eharney: xyang1: https://review.openstack.org/#/c/218977/ works for me locally | 18:57 |
| *** edmondsw has joined #openstack-cinder | 18:57 | |
| kmartin | xyang1, need me to have him check something? | 18:57 |
| jgriffith | eharney: xyang1 I'll leave it between the two of you which one to merge :) | 18:57 |
| jgriffith | kmartin: stats on releasing os-brick before dependency freeze | 18:58 |
| hemna | hey | 18:58 |
| hemna | sorry, my desktop here at work is hosed, been offline all morning | 18:58 |
| jgriffith | hemna: check dev list | 18:58 |
| *** ociuhandu has quit IRC | 18:58 | |
| anish | mriedem: jgriffith err, what breakage | 18:58 |
| jgriffith | hemna: mriedem posted question WRT os-brick and dependency freeze | 18:59 |
| jgriffith | anish: looks like all the 3'rd party CI's failed your os-brick patch | 18:59 |
| anish | coz last I discussed there was a breakage with iser being called from outside of nova, but that is fixes now | 18:59 |
| hemna | somehow lvm upgrade on my ubuntu changed the UUID of my / partition and now it can't boot. bleh. | 18:59 |
| anish | jgriffith: yeah, that I noticed. weirdly it's the fc CIs | 18:59 |
| anish | I do not touch fc at all | 19:00 |
| mriedem | hemna: jgriffith: http://lists.openstack.org/pipermail/openstack-dev/2015-August/073321.html | 19:00 |
| mriedem | xyang1: ^ | 19:00 |
| jgriffith | anish: well... you know what I say about FC :) But regardless if it breaks them that's no-bueno | 19:00 |
| *** gouthamr has joined #openstack-cinder | 19:00 | |
| *** gouthamr has quit IRC | 19:01 | |
| hemna | mriedem, sounds ok to me. | 19:01 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/215440 | 19:02 |
| anish | jgriffith: makes sense | 19:03 |
| anish | I'd be happy to fix things if anyone who knows the FC code could talk to me | 19:03 |
| *** gouthamr has joined #openstack-cinder | 19:04 | |
| anish | the purestorage ci seems to fail in code that is completely in the FC connector. there is no code change there so very weird | 19:04 |
| jgriffith | anish: could be a *coincidence* | 19:04 |
| jgriffith | anish: you need to figure that out with patrickeast and hemna I guess | 19:05 |
| Swanson | Is there a global FC breakage that explains my broken FC CI? | 19:05 |
| patrickeast | jgriffith: anish: which review? | 19:05 |
| anish | iono, IBM is passing FC | 19:05 |
| anish | patrickeast: https://review.openstack.org/#/c/193451/ | 19:05 |
| patrickeast | ew, that looks like a rootwrap problem? http://ec2-54-67-51-189.us-west-1.compute.amazonaws.com/51/193451/21/check/PureFCDriver-tempest-dsvm-volume-multipath-brick/3542641/logs/screen-c-bak.txt.gz?level=TRACE | 19:06 |
| *** shyama has quit IRC | 19:06 | |
| *** Apoorva has quit IRC | 19:06 | |
| anish | patrickeast: yeah, same things with IBM storwize | 19:07 |
| anish | rootwrap problems | 19:07 |
| asselin_ | we've been having fc issue for our cinder patches but hemna found the issue this morning | 19:07 |
| asselin_ | we were inadvertently using os-brick/master instead of the version in pip | 19:08 |
| patrickeast | anish: so its either something in that change, or a brick problem (maybe fixed later on?) | 19:08 |
| patrickeast | anish: that isn't something that would show up in the intermittent failures (which we do have) | 19:08 |
| anish | exact same problem with HP storage as well | 19:08 |
| asselin_ | anish, if you're having the same issue as us, look at your pip-freeze | 19:09 |
| anish | asselin_: nope, I'm just trying to figure out if my patch is breaking fc | 19:09 |
| *** dflorea has joined #openstack-cinder | 19:10 | |
| *** dflorea_ has quit IRC | 19:11 | |
| asselin_ | hemna, ^^ | 19:11 |
| *** dflorea has quit IRC | 19:12 | |
| *** jwcroppe has joined #openstack-cinder | 19:13 | |
| openstackgerrit | Tom Barron proposed openstack/cinder: Scheduler-based over-subscription for NFS drivers https://review.openstack.org/216055 | 19:13 |
| anish | jgriffith: well, they all seems to be failing with the exact same root wrap issue except for HP iscsi which has a failure on tempest.scenario.test_volume_boot_pattern.TestVolumeBootPattern.test_create_ebs_image_and_check_boot | 19:14 |
| *** jwcroppe_ has quit IRC | 19:15 | |
| anish | at least that I think could not be related to the patch | 19:15 |
| asselin_ | test_create_ebs_image_and_check_boot should have been fixed by an upstream tempest updated | 19:19 |
| *** subhadeep_de has quit IRC | 19:20 | |
| *** Apoorva has joined #openstack-cinder | 19:21 | |
| angela-s | hemna: Brocade CI has reported successful run now: https://review.openstack.org/#/c/196640/ | 19:22 |
| *** hodos|2 has joined #openstack-cinder | 19:29 | |
| *** lpetrut has joined #openstack-cinder | 19:29 | |
| *** hodos has quit IRC | 19:31 | |
| openstackgerrit | xing-yang proposed openstack/cinder: ScaleIO driver should use os-brick connector https://review.openstack.org/214420 | 19:36 |
| jgriffith | patrickeast: If you want to repro the issue; just hack in a 'raise' in your clone_volume method in your driver | 19:36 |
| jgriffith | patrickeast: then you should see the same thing | 19:37 |
| *** sidbhatt13 has quit IRC | 19:37 | |
| *** salv-orlando has quit IRC | 19:37 | |
| patrickeast | jgriffith: ok cool | 19:37 |
| patrickeast | jgriffith: wait a sec, that means the exception was coming from your driver code, what was causing that? the context thing? | 19:39 |
| patrickeast | jgriffith: or you put in a raise just to test things? | 19:39 |
| jgriffith | Yes, the context thing | 19:40 |
| jgriffith | which I still haven't had a chance to look at, but firing it back up now | 19:40 |
| patrickeast | jgriffith: gotcha | 19:40 |
| patrickeast | jgriffith: i was looking through the code and as far as i can tell it *should* be working, but I think there might be some weirdness introduced with the dual context stuff i'm not fully accounting for | 19:41 |
| openstackgerrit | Sean Dague proposed openstack/cinder: Port image_utils to Python 3 https://review.openstack.org/213817 | 19:47 |
| jgriffith | patrickeast: LOL.. well of course it *should* be working | 19:47 |
| patrickeast | jgriffith: :D | 19:47 |
| sdague | I'm going to keep sniping out cinder changes that I see until the unit test fix lands in the gate | 19:47 |
| patrickeast | jgriffith: what i mean is the db calls for volume_get work with either context, both don't get seem to actually get filtered by project | 19:48 |
| jgriffith | sdague: I noticed... not sure others caught that we shouldn't be +2/A 'ing for the time being | 19:48 |
| jgriffith | hemna: smcginnis_afk DuncanT patrickeast e0ne ^^ | 19:49 |
| jgriffith | sdague: is this something we can help with or easier for you to just pick them off as you come across them? | 19:49 |
| e0ne | jgriffith: no +A for tonight. i've got it!:) | 19:49 |
| sdague | honestly, I'm about to call it a day, so I'll leave it for others | 19:49 |
| jgriffith | e0ne: well... just until we get the EMC import patch merged | 19:50 |
| *** salv-orlando has joined #openstack-cinder | 19:50 | |
| sdague | I'm dealing with a well pump replacement and it's time for beer | 19:50 |
| jgriffith | sdague: cool... you just yanking anything that fails? | 19:50 |
| jgriffith | sdague: Ohh... ouch! | 19:50 |
| sdague | jgriffith: honestly, right now, I'm just yanking any cinder patch, because they'll all fail | 19:50 |
| e0ne | jgriffith: anyway, it's almost 11pm. good time to stop reviewing:) | 19:50 |
| sdague | I'm just checking that it's not the fix patch first before I do | 19:50 |
| jgriffith | sdague: alright... good luck with the pump; I'll watch the gate for a bit | 19:50 |
| sdague | jgriffith: thanks | 19:51 |
| jungleboyj | jgriffith: So, nothing else from the cinder-liberty-3 review list is going to make it today? | 19:51 |
| jgriffith | jungleboyj: NO | 19:51 |
| jgriffith | jungleboyj: we just need to get the one patch in before anything else at this point | 19:51 |
| jungleboyj | jgriffith: Ok. | 19:52 |
| jungleboyj | Still cutting off items from that list at mdnight tonight? | 19:52 |
| jgriffith | jungleboyj: yes | 19:52 |
| jgriffith | and it's midnight UTC | 19:52 |
| *** DericHorn-HP has joined #openstack-cinder | 19:52 | |
| *** sidbhatt13 has joined #openstack-cinder | 19:53 | |
| jgriffith | and well... I guess given the time it takes for things to get through, maybe the answer to your question will in fact be yes L3 is done | 19:53 |
| jungleboyj | jgriffith: Yeah, that was what I was trying to get it. | 19:53 |
| jgriffith | jungleboyj: sorry.... lost track of how slow things are at the moment | 19:53 |
| jungleboyj | Midnight UTC is 4 hours away. | 19:54 |
| jungleboyj | Should I go through everything and -2 | 19:54 |
| jgriffith | Of course we'll be waiting a long time it appears | 19:54 |
| jgriffith | jungleboyj: maybe so | 19:54 |
| * jungleboyj volunteers to become very unpopular | 19:54 | |
| jgriffith | jungleboyj: we can consider where things are at tonight if/after this merges: https://review.openstack.org/#/c/218977/ | 19:55 |
| e0ne | jungleboyj: you're "Capitan Oslo", not "Capitan -2" ;) | 19:55 |
| openstackgerrit | Joel Coffman proposed openstack/cinder: Enforce constraints at DB layer rather than API https://review.openstack.org/219007 | 19:55 |
| jungleboyj | jgriffith: Up to you, you are the boss right now. | 19:56 |
| jungleboyj | ;-) | 19:56 |
| hemna | so we're done | 19:56 |
| hemna | ? | 19:56 |
| jgriffith | hemna: well, the queue is at 5 hours | 19:56 |
| jungleboyj | Oooh, we got hemna's attention. | 19:56 |
| hemna | well, I had to eat lunch. | 19:56 |
| jgriffith | hemna: doing the math and based on the "rules" that were set in place it kinda looks like features are done | 19:56 |
| hemna | still no working desktop. | 19:57 |
| jgriffith | hemna: note that doesn't apply to bug fixes, and honestly IMO features should have pretty much been done already anyway | 19:57 |
| jgriffith | hemna: What's up with that!!! | 19:57 |
| *** bswartz has quit IRC | 19:57 | |
| jungleboyj | hemna: What happened to your desktop? | 19:57 |
| diablo_rojo | I think you should not let jungleboyj do all the -2's. He just wants his +1/-1 score to be lower than mine :P | 19:57 |
| hemna | ok, there is just 1 more os-brick patch that I'd like to get in, but haven't been able to test it yet. | 19:57 |
| hemna | not sure what the 'rules' are wrt os-brick | 19:58 |
| kmartin | I have a new driver, is it to late to make liberty? | 19:58 |
| jgriffith | hemna: os-brick doesn't count here | 19:58 |
| *** Yogi1 has quit IRC | 19:58 | |
| * hemna cheers | 19:58 | |
| jgriffith | kmartin: every release you do that!!! | 19:58 |
| jgriffith | :) | 19:58 |
| *** rushil has joined #openstack-cinder | 19:58 | |
| jgriffith | jungleboyj: not this is features, not bug fixes | 19:58 |
| kmartin | yep, had to keep the tradition | 19:58 |
| jgriffith | jungleboyj: I'm happy to help out | 19:59 |
| jungleboyj | jgriffith: Yes ... I know this is the just the features. | 19:59 |
| jgriffith | :) | 19:59 |
| jgriffith | just making sure Initially I thought "not that many" but now that I look again OI-Vai | 19:59 |
| jgriffith | there's a lot of crap dumped in over the week-end | 20:00 |
| jungleboyj | jgriffith: Yeah. | 20:00 |
| *** david-lyle has quit IRC | 20:01 | |
| hemna | so bug fixes can still +A ? | 20:01 |
| jungleboyj | hemna: Yes. | 20:02 |
| hemna | ok coolio. thanks | 20:02 |
| jgriffith | tbarron: appears this is done... yes? | 20:02 |
| jgriffith | https://blueprints.launchpad.net/cinder/+spec/netapp-use-pypi-client-library | 20:02 |
| jungleboyj | I am mainly concerned with this: https://etherpad.openstack.org/p/cinder-liberty-3-reviews | 20:03 |
| e0ne | jgriffith: what about "moving something to objects" patches? | 20:03 |
| jgriffith | e0ne: sigh... | 20:03 |
| jgriffith | e0ne: technically those should be out, but they're in progress; and I hate the half in half out thing | 20:03 |
| jgriffith | e0ne: I'm just starting by cleaning up the BP's... then I'll go from there | 20:03 |
| jgriffith | e0ne: jungleboyj the idea being that if it's not on the L3 list in launchpad it's out | 20:05 |
| jgriffith | e0ne: jungleboyj I'm moving everything that's not submitted or not needs review out of L3 now | 20:05 |
| *** markvoelker has joined #openstack-cinder | 20:06 | |
| *** david-lyle has joined #openstack-cinder | 20:06 | |
| jungleboyj | Ok, you want me to block the reviews for now then? | 20:06 |
| jgriffith | jungleboyj: so if it's a bp and it's NOT on the L3 list it gets a -2 or just ignored | 20:08 |
| *** subhadeep_de has joined #openstack-cinder | 20:08 | |
| xyang1 | jgriffith: What about our vote in last meeting? Not valid?:) | 20:08 |
| jgriffith | jungleboyj: speaking of which: https://blueprints.launchpad.net/cinder/+spec/db2-database | 20:08 |
| jgriffith | jungleboyj: not sure what the current state of that one is ^^ | 20:08 |
| jgriffith | jungleboyj: looks done? | 20:09 |
| *** sidbhatt13 has left #openstack-cinder | 20:09 | |
| jungleboyj | jgriffith: Yeah, we could mark that Done. The support is in and we have a 3rd Party CI for it. I had thought we needed to get unit tests going on it, but with the CI we are good. | 20:10 |
| jungleboyj | So, lets close that one out. | 20:10 |
| *** dflorea has joined #openstack-cinder | 20:10 | |
| jgriffith | jungleboyj: so those are all the easy ones, items that had nothing associated or had no reviews | 20:10 |
| jgriffith | jungleboyj: now the "hard" part is all the "Needs Code Review ones" | 20:10 |
| jgriffith | which will make people cry | 20:10 |
| jungleboyj | Yeah. | 20:11 |
| jgriffith | jungleboyj: k, marking it as Implemented | 20:11 |
| *** dims has joined #openstack-cinder | 20:11 | |
| *** dims has quit IRC | 20:12 | |
| jgriffith | jungleboyj: now for the 27 "needs review" items :( | 20:12 |
| jungleboyj | Sheesh, 27 BPs. | 20:12 |
| jgriffith | jungleboyj: yeah... remaining! | 20:12 |
| jgriffith | jungleboyj: fairest thing I can think of is to first cut all that are "low" priority | 20:12 |
| jungleboyj | Agreed. | 20:12 |
| xyang1 | I think some are merged, but status not updated | 20:12 |
| jgriffith | jungleboyj: e0ne eharney xyang1 thoughts on that? | 20:13 |
| patrickeast | seems like the right way to do it, thats what the priority is there for, right? | 20:13 |
| mtanino | Can I change the status of this to implemented? https://blueprints.launchpad.net/cinder/+spec/efficient-volume-copy-for-cinder-assisted-migration | 20:13 |
| jgriffith | xyang1: yeah... I'm looking at those as I go through... but as I've ALWAYS said in the past it's submitters responsibility to make sure LP is updated and reflects reality! | 20:13 |
| *** crose has quit IRC | 20:13 | |
| jgriffith | mtanino: if it's implemented YES you should | 20:13 |
| jgriffith | patrickeast: yeah... in theory :) | 20:14 |
| *** sidbhatt13 has joined #openstack-cinder | 20:14 | |
| xyang1 | jgriffith: I can't change others bp status any way | 20:14 |
| e0ne | jgriffith: agree. we can drop low priorities BPs from l-3 | 20:14 |
| jungleboyj | Ok, starting to update those reviews. | 20:14 |
| *** sidbhatt13 has left #openstack-cinder | 20:14 | |
| angela-s | jgriffith: addressing the elephant in the room, when can we start requesting exceptions? :) | 20:14 |
| *** dims_ has quit IRC | 20:14 | |
| jgriffith | angela-s: no exceptions this time around :) | 20:14 |
| * jungleboyj hears the trumpet of the elephant. | 20:14 | |
| mtanino | jgriffith: I thought we shouldn't change that status of the BP. DONE. | 20:15 |
| jgriffith | angela-s: so we can probably discuss tomorrow or Wed in meeting | 20:15 |
| jgriffith | mtanino: well... I don't know how Mike does things, but IMO if the system didn't pick it up the way it was supposed to you should change it | 20:15 |
| jgriffith | or notify somebody else to change it | 20:15 |
| angela-s | jgriffith: ok, will wait until tomorrow or in meeting, thanks | 20:15 |
| mtanino | jgriffith: I understand. Thank you. | 20:16 |
| xyang1 | jgriffith: We don't really have an exception process | 20:16 |
| jgriffith | Personally LP is the only thing I have to go off of for status, so if it's wrong, I'm kinda screwed | 20:16 |
| jgriffith | xyang1: correct.... that needs to be discussed with the PTL | 20:16 |
| jgriffith | xyang1: who informed me that there was no such thing | 20:16 |
| jgriffith | xyang1: so I just follow orders | 20:16 |
| xyang1 | jgriffith: :). Not completely true | 20:16 |
| jgriffith | xyang1: what's not completely true? | 20:17 |
| *** dflorea_ has joined #openstack-cinder | 20:17 | |
| xyang1 | jgriffith: But I don't want to get anyone into trouble | 20:17 |
| jgriffith | xyang1: is there a process I don't know about? OOops | 20:17 |
| jgriffith | xyang1: no no... if I'm doing something wrong, please let me know | 20:17 |
| * jgriffith slams on the brakes | 20:17 | |
| jgriffith | stops what he's doing | 20:17 |
| jgriffith | xyang1: LOL... or you mean about "me following orders" :) | 20:18 |
| xyang1 | jgriffith: No:) | 20:18 |
| patrickeast | any chance we could get a follow up email to http://lists.openstack.org/pipermail/openstack-dev/2015-August/071505.html explaining the FFE policy (or lack thereof) would make it easier for people like me who may have to explain why things don't go in | 20:19 |
| *** rushil has quit IRC | 20:20 | |
| *** dflorea has quit IRC | 20:20 | |
| *** pv__ has joined #openstack-cinder | 20:21 | |
| pv__ | hey im debugging my attach-volume functionality on my cinder driver, its an FC driver and im running devstack on an HBA enabled machine | 20:21 |
| pv__ | im getting http://pastebin.com/iNs2bT07 in my n-cpu logs | 20:21 |
| pv__ | after my c-vol log reports "initialize connection completed successfully" | 20:21 |
| *** Apoorva has quit IRC | 20:22 | |
| pv__ | when i do a systool -c fc_host -v it shows both the HBA cards with their respective WWNs but apparently openstack doesnt see the same thing, i dont understand why | 20:22 |
| pv__ | any help? | 20:22 |
| jungleboyj | jgriffith: xyang1 hemna Any concerns with this approach: https://review.openstack.org/#/c/202023/ | 20:22 |
| jgriffith | jungleboyj: that seems reasonable and pretty clear IMO | 20:23 |
| hemna | jungleboyj, lgtm | 20:23 |
| jungleboyj | jgriffith: Thank you. Moving forward in the low proprity reviews then. | 20:23 |
| *** kvidvans has quit IRC | 20:24 | |
| *** nzrf has left #openstack-cinder | 20:24 | |
| *** Apoorva has joined #openstack-cinder | 20:25 | |
| pv__ | has anyone encountered the same sort of issue when testing the attach method for their FC driver? | 20:26 |
| jgriffith | tbarron: what's up with this one: https://blueprints.launchpad.net/cinder/+spec/scalable-backup-service | 20:27 |
| jgriffith | tbarron: I don't see any code for it? | 20:27 |
| jgriffith | tbarron: ahh... wait, the second link has a bunch of stuff | 20:27 |
| jgriffith | tbarron: all listed as either merged or abandoned... assuming done? | 20:28 |
| *** thangp has quit IRC | 20:32 | |
| *** dflorea_ has quit IRC | 20:33 | |
| angela-s | pv__: may i ask what vendor and what OS? | 20:33 |
| pv__ | both devices are emulex | 20:33 |
| pv__ | and OS is ubuntu 14.04 server | 20:34 |
| jungleboyj | jgriffith: patrickeast What did we decide on this one? Does it have longer or not? https://review.openstack.org/#/c/214825/ | 20:34 |
| angela-s | pv__: ok, just ruling out 1 possibility | 20:34 |
| xyang1 | jgriffith: That one is WIP. Https://review.openstack.org/#/c/203291 | 20:34 |
| xyang1 | jgriffith: tbarron's patch | 20:34 |
| *** dflorea has joined #openstack-cinder | 20:35 | |
| jgriffith | xyang1: thanks | 20:35 |
| angela-s | pv__: do the HBAs show up in the nameserver on the FC switches? | 20:35 |
| jgriffith | xyang1: so sounds like that's out then | 20:35 |
| xyang1 | jgriffith: Yes | 20:35 |
| *** svilgelm has joined #openstack-cinder | 20:35 | |
| pv__ | im not sure sorry, what exactly do you mean by that? | 20:35 |
| *** simondodsley has quit IRC | 20:36 | |
| *** diogogmt has joined #openstack-cinder | 20:36 | |
| angela-s | pv__: on the CLI of the FC switch, if you issue 'nsshow', are the WWNs showing up? | 20:36 |
| *** lpetrut has quit IRC | 20:36 | |
| jgriffith | hemna: I'm deferring this one to you: https://blueprints.launchpad.net/cinder/+spec/brick-add-open-iscsi-transport-support | 20:37 |
| jgriffith | patrickeast: smcginnis_afk xyang1 e0ne jungleboyj other than that, the LP listing should now be somewhat accurate: https://launchpad.net/cinder/+milestone/liberty-3 | 20:38 |
| hemna | jgriffith, we need that one in L | 20:38 |
| *** dflorea_ has joined #openstack-cinder | 20:38 | |
| jgriffith | hemna: cool, that's why I left it alone and checked with you :) | 20:38 |
| pv__ | one second, im getting access to the FC switch to check | 20:38 |
| *** dflorea has quit IRC | 20:38 | |
| jgriffith | hemna: you might want to bump the priority to reflect that | 20:38 |
| *** svilgelm has left #openstack-cinder | 20:39 | |
| hemna | ok | 20:39 |
| e0ne | jgriffith: thanks you your job! | 20:39 |
| hemna | I can't change the priority :( | 20:39 |
| jungleboyj | jgriffith: Thanks. I have -2's on all the low priority items. Let me know how you would like to on the higher priority ones. | 20:39 |
| tbarron | jgriffith: sorry, was afk. I got assigned other work to do for L3 and will target https://blueprints.launchpad.net/cinder/+spec/scalable-backup-service for M | 20:39 |
| jungleboyj | *to do | 20:39 |
| jgriffith | hemna: now worries, I'll do it | 20:39 |
| jgriffith | hemna: that actually sounds like a backward compatbility bug to me | 20:40 |
| *** kvidvans has joined #openstack-cinder | 20:40 | |
| hemna | jgriffith, yah it kinda is. | 20:40 |
| *** gouthamr has quit IRC | 20:40 | |
| *** dflorea has joined #openstack-cinder | 20:41 | |
| *** _cjones_ has joined #openstack-cinder | 20:41 | |
| *** _cjones_ has quit IRC | 20:42 | |
| jgriffith | Ok, so FWIW; that brings our BP backlog to 14 | 20:42 |
| jgriffith | There's still one or two in there that I don't think have a prayer | 20:42 |
| jgriffith | but, the idea being that those should be the priority for reviews at this point | 20:43 |
| *** Lee1092 has quit IRC | 20:43 | |
| *** dflorea_ has quit IRC | 20:45 | |
| *** dflorea has quit IRC | 20:45 | |
| tbarron | jgriffith: https://blueprints.launchpad.net/cinder/+spec/netapp-use-pypi-client-library is indeed done (I was AFK) | 20:45 |
| pv__ | yeah the HBAs are showing up when i do an nsshow | 20:45 |
| pv__ | from the FC switch cli | 20:45 |
| jgriffith | tbarron: good :) | 20:45 |
| *** dflorea has joined #openstack-cinder | 20:45 | |
| pv__ | the WWNs match the ones I get when i do a systool -c fc_host -v | 20:46 |
| jgriffith | tbarron: If my adjustments were correct no worries, just let me know if I missed something | 20:46 |
| pv__ | so im not sure why nova keeps telling me it cant find any FC devices | 20:46 |
| *** rushil has joined #openstack-cinder | 20:46 | |
| patrickeast | jungleboyj: not sure if it was answered, but that replication one https://review.openstack.org/#/c/214825/ imo falls into the same category as the rest of the low priority bp's | 20:46 |
| patrickeast | jgriffith: ^ correct? | 20:46 |
| patrickeast | there was the vote to give more time for driver impls... but i had assumed that was just the 1 week from the deadline to post one gerrit/pass jenkins and the actual feature freeze | 20:47 |
| jgriffith | patrickeast: I was avoiding that one intentionally :( | 20:48 |
| *** bkopilov has quit IRC | 20:48 | |
| jgriffith | patrickeast: but the reality is if you look at the back-log even if it were +2/A right now, it likely wouldn't merge until Wed some time | 20:49 |
| jgriffith | patrickeast: I'm not making the call on that one though | 20:49 |
| jgriffith | at least not today | 20:49 |
| jgriffith | there's enough that's obvious right now to work through IMO | 20:49 |
| angela-s | pv__: ok, i just wanted to confirm that the FC part is working. unfortunately, i do not know what the root of the issue you are facing is. | 20:49 |
| *** dflorea has quit IRC | 20:50 | |
| pv__ | alright thanks! ill keep at it | 20:50 |
| *** timcl has quit IRC | 20:51 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Fix a merge problem in VMAX driver https://review.openstack.org/218421 | 20:51 |
| *** ebalduf has joined #openstack-cinder | 20:52 | |
| *** bkopilov has joined #openstack-cinder | 20:53 | |
| *** xyang1 has quit IRC | 20:55 | |
| *** jwcroppe_ has joined #openstack-cinder | 20:55 | |
| *** markvoelker has quit IRC | 20:56 | |
| *** jwcroppe has quit IRC | 20:57 | |
| *** dims has joined #openstack-cinder | 20:57 | |
| tbarron | jgriffith: all our driver feature patches were of course in Low and only started getting review attention recently, as everyone expected given their priority. But we had bps approve and working code up before the deadlines. | 21:00 |
| *** Apoorva_ has joined #openstack-cinder | 21:00 | |
| tbarron | jgriffith: jungleboyj: so all these remaining are getting -2s at this point and retargeted for Mitaka? | 21:00 |
| *** bkopilov has quit IRC | 21:00 | |
| *** xyang1 has joined #openstack-cinder | 21:01 | |
| *** esker has quit IRC | 21:01 | |
| tbarron | jgriffith: jungleboyj: what I'm trying to figure out is how we as code/bp submitters could be doing anything differently on this? | 21:01 |
| *** jwcroppe has joined #openstack-cinder | 21:02 | |
| *** jwcroppe_ has quit IRC | 21:04 | |
| *** Apoorva has quit IRC | 21:04 | |
| *** annegentle has quit IRC | 21:04 | |
| jgriffith | tbarron: submit early, submit often | 21:06 |
| jgriffith | tbarron: and expect things like gate congestion on the last day of feature acceptance | 21:06 |
| tbarron | jgriffith: we did - but didn't get review cycles till just very recently. I'm not blaming, just describing. | 21:06 |
| jgriffith | tbarron: I hear ya | 21:07 |
| tbarron | jgriffith: these are changes where we met the deadlines that I'm talking about. I told my people *not* to ask for reviews on IRC, that there was | 21:07 |
| *** jwcroppe_ has joined #openstack-cinder | 21:07 | |
| jgriffith | tbarron: understood | 21:08 |
| tbarron | a prioritization of core features first and that reviewers would get to them. Keep up with review comments, stay rebased, don't bug people. | 21:08 |
| jgriffith | tbarron: just to be clear though, that doesn't mean that the review process goes on indefinitely | 21:08 |
| guitarzan | tbarron: maybe you can get them on a meeting agenda? | 21:08 |
| jgriffith | guitarzan: +1 | 21:08 |
| guitarzan | much more focused than random irc pestering | 21:09 |
| jgriffith | tbarron: I have a long list of things that I never got to this time around | 21:09 |
| guitarzan | "pestering" | 21:09 |
| jgriffith | and it sucks, but it's also happened to me every release for the last 4 years so I'm kinda used to it | 21:09 |
| jgriffith | life goes on | 21:09 |
| tbarron | guitarzan: are you saying I'm doing "random irc pestering" now? | 21:09 |
| guitarzan | tbarron: no, the opposite | 21:09 |
| tbarron | guitarzan: kk, sorry, I may be a bit twitchy :-) | 21:10 |
| jgriffith | and every time I tell myself "Ok, get all your crap done in the first milestone... but I never do | 21:10 |
| *** jwcroppe has quit IRC | 21:10 | |
| guitarzan | tbarron: I'm saying you were having people *not* pester, and instead maybe you could just get a batch of reviews on a meeting agenda | 21:10 |
| *** hemna has quit IRC | 21:10 | |
| Swanson | I've had luck with random irc pestering. | 21:10 |
| guitarzan | sure, squeaky wheel and all that, but it's hard to recommend that :) | 21:10 |
| tbarron | guitarzan: last time I put something on the agenda (about getting our bps approved) I got slapped down pretty hard :-) | 21:10 |
| jgriffith | as guitarzan traditionally irc meetings are the best place to raise awareness and get input | 21:10 |
| jgriffith | tbarron: by who? | 21:10 |
| guitarzan | tbarron: ah, that sucks... | 21:10 |
| jgriffith | tbarron: that what weekly meetings are for | 21:11 |
| jgriffith | IMO | 21:11 |
| jgriffith | tbarron: if nothing else, raise it during Open-Discussion (when we have them) | 21:11 |
| *** svilgelm has joined #openstack-cinder | 21:11 | |
| jgriffith | tbarron: so if you want to put a prioritized list together and present things as needed for consideration feel free. I suspect I'll be getting a flood of those types of things the next 48 hours :) | 21:12 |
| Swanson | I'm pretty sure thingee said to not put such things on the agenda. But I suppose that doesn't include open discussion. | 21:12 |
| jgriffith | Swanson: ahh.. he may have | 21:12 |
| jgriffith | tbarron: just to be clear though: http://lists.openstack.org/pipermail/openstack-dev/2015-August/071505.html | 21:13 |
| tbarron | https://etherpad.openstack.org/p/cinder-liberty-3-reviews has eight of our reviews that made the bp and code + jenkins deadlines. | 21:13 |
| *** akerr has quit IRC | 21:14 | |
| jgriffith | tbarron: even if you follow the guidelines and meet the date, that doesn't change when freeze happens | 21:14 |
| tbarron | several have no review comments. | 21:14 |
| Swanson | jgriffith: I'm trying to remember if he redirected people to the mailing list for that | 21:14 |
| *** julim has quit IRC | 21:14 | |
| tbarron | most have "add a period to a message" or "please refactor a bit" type remarks. | 21:14 |
| tbarron | nothing fundamental. | 21:14 |
| jgriffith | tbarron: yeah, I've always felt we were out of control with that business | 21:14 |
| tbarron | jgriffith: I understand that freeze happens anyways. How can we increase review throughput so that given the lack of any | 21:15 |
| tbarron | fundamental objections it is still impossible for submitters to make the freeze. We don't have control or influence on the | 21:15 |
| tbarron | review throughput except to do our part to stay up to date, respond right away, etc. | 21:16 |
| Swanson | I've always felt that having two spaces after a period was worth a -1 and has nothing to do with the involuntary eye twitch I've developed. | 21:16 |
| jgriffith | tbarron: better focus? More reviewers? Less code change? | 21:16 |
| jgriffith | I dunno | 21:16 |
| jgriffith | Swanson: :) | 21:16 |
| *** svilgelm has quit IRC | 21:16 | |
| tbarron | I personally have nothing against nitpick -1s. | 21:16 |
| * jgriffith does | 21:16 | |
| jgriffith | I'd rather come back and fix little things if need be.. but that's not the point | 21:17 |
| jgriffith | tbarron: so look, here's the thing | 21:17 |
| tbarron | I just pointed out that that is what we have on the outstanding reviews in that queue. Or we have no comments at all. | 21:17 |
| *** lprice has joined #openstack-cinder | 21:17 | |
| jgriffith | tbarron: I'm not the PTL. This information and process was communicated quite clearly BY the PTL on numerous occasions | 21:17 |
| tbarron | jgriffith: understood, and I'm not asking you to violate the process. | 21:18 |
| jgriffith | tbarron: you were present, both at the mid-cycle meetup, and in the weekly meeting 2 weeks ago when it was reiterated and clarified | 21:18 |
| tbarron | jgriffith: I am not quarelling with sticking to the process. | 21:18 |
| tbarron | I *am* going on record that we followed the process and it isn't working. | 21:18 |
| jgriffith | tbarron: well, sometimes process for the sake of process is broken | 21:18 |
| jgriffith | tbarron: and I agree completely | 21:18 |
| *** esker has joined #openstack-cinder | 21:19 | |
| jgriffith | every release, folks come up with great process ideas to "solve" the throughput problems, and every release people are upset | 21:19 |
| Swanson | tbarron: I really do think that if you can't bring these things up at the meeting then you need to pester on IRC or on the ML. I don't think we should be doing that but if you need something pushed through that is your only option. | 21:19 |
| jgriffith | this is ALL projects BTW, not just Cinder | 21:19 |
| tbarron | jgriffith: I admire thingee introducing clear process and setting clear deadliines. | 21:19 |
| tbarron | jgriffith: I *do not* want to undermine that. | 21:19 |
| jgriffith | tbarron: well then.. you have them | 21:19 |
| jgriffith | tbarron: you don't get it both ways | 21:20 |
| *** bkopilov has joined #openstack-cinder | 21:20 | |
| jgriffith | tbarron: you admire and appreciate them... except when it doesn't work out for you? | 21:20 |
| jgriffith | tbarron: :) | 21:20 |
| tbarron | I *do* think that we need to somehow going forwards modify something so we don't get messed up when we play by the rules. | 21:20 |
| tbarron | jgriffith: that's *not* what I'm saying. | 21:20 |
| jgriffith | tbarron: ok... so look; | 21:21 |
| tbarron | I am saying that we played by the rules and didn't get review cycles. | 21:21 |
| jgriffith | tbarron: first of all, you can certainly raise an appeal/request for something | 21:21 |
| tbarron | Not in time. | 21:21 |
| jgriffith | tbarron: I can guarantee that asking for all 8 would be a wast of your time and mine | 21:21 |
| jgriffith | tbarron: I would also say that yeah... life is hard in OpenStack | 21:21 |
| jgriffith | welcome!!! | 21:21 |
| jgriffith | time is short | 21:21 |
| jgriffith | things never work out | 21:21 |
| jgriffith | tbarron: AND, to somehow thing that "Hey... if I submit everything 1 week before the deadline I'll be fine" is stupid | 21:22 |
| jgriffith | it's not going to work, because you and EVERYBODY else is trying to do the same thing | 21:22 |
| jgriffith | it's a simple math problem | 21:22 |
| jgriffith | it doesn't work | 21:22 |
| jgriffith | the gate gets overloaded, reviewers get overloaded, the change rate is just too high | 21:22 |
| jgriffith | tbarron: now, as I said before; I'm perfectly open to folks brining items to Wed's meeting that we can discuss as a team | 21:23 |
| tbarron | jgriffith: so I guess I should learn to treat L3 deadlines as L2 deadlines :-) | 21:23 |
| jgriffith | tbarron: I'm also working on proposals for the summit in Tokyo to maybe modify some of the ways we work currently in the hopes that it helps with this sort of thing | 21:24 |
| *** esker has quit IRC | 21:24 | |
| tbarron | jgriffith: I'll talk to our people about priorities, triage, etc. | 21:24 |
| jgriffith | tbarron: and finally... one last thing I'd like to point out!!! https://review.openstack.org/#/c/184951/ | 21:24 |
| tbarron | jgriffith: I'll look for those proposals with great interest. | 21:24 |
| *** esker has joined #openstack-cinder | 21:24 | |
| jgriffith | ^^ I submitted that SPECIFICALLY because of this very situation!!! | 21:24 |
| Swanson | I thought I was going to drop dead when I had to merge by a kilo-1 to get my driver in. Could not believe how long it was taking to get through gate. | 21:25 |
| jgriffith | tbarron: it went over like a led balloon | 21:25 |
| jgriffith | Swanson: exactly! | 21:25 |
| *** dustins has quit IRC | 21:26 | |
| jgriffith | landing strips, interim deadlines, driver freeze, feature freeze... doesn't matter; they're all deadlines and they all incur the same challenges in the end | 21:26 |
| *** hodos|2 has quit IRC | 21:26 | |
| Swanson | jgriffith: I think we talked about this friday. I think drivers need to trail the release so that they can implement all the features in a release. | 21:26 |
| jgriffith | Swanson: yes, although when I read back through the notes I don't think I presented that whole thing very well | 21:27 |
| *** jwcroppe has joined #openstack-cinder | 21:28 | |
| patrickeast | just to add my 2c it does seem like maybe we could at least improve throughput of reviews a bit more with better automated tests (maybe things like in-tree functional tests) and increasing core reviewers... both have some risk though to decrease quality if not done well though | 21:28 |
| patrickeast | the idea that folks need to download my patch, spin up their own system, and make sure it doesn't blow up seems like a lot of time wasted | 21:29 |
| patrickeast | for some things totally makes sense | 21:29 |
| *** edtubill has quit IRC | 21:29 | |
| patrickeast | but if its going to just barf immediately its not really valuable | 21:29 |
| jgriffith | patrickeast: sure... although when it comes to "core" things that's what CI is for no? | 21:29 |
| patrickeast | jgriffith: yea but there isn't an easy way to just flip on some new feature or add new tempest tests along side a patch | 21:30 |
| jgriffith | patrickeast: and BTW, part of the challenge here is the "vendor-specific" features/methods that become optional | 21:30 |
| patrickeast | jgriffith: i guess my point was there are probably some things we could do to help at least a little bit with it | 21:30 |
| jgriffith | patrickeast: there is if we go back to doing things the way we used to, where that was part of the process | 21:30 |
| patrickeast | jgriffith: yea definitely a problem with vendor specific things | 21:30 |
| jgriffith | patrickeast: and YES, there are always thing that we can do to improve... for sure! | 21:30 |
| tbarron | we could consider a random ordering of reviews in the backlog so that one or two vendors aren't at the end (irrespective of being ready as early or earlier than others). | 21:30 |
| asselin_ | patrickeast, you could add cross-project dependency to tempest, no? | 21:30 |
| *** jwcroppe_ has quit IRC | 21:31 | |
| jgriffith | patrickeast: more cores is fine, but it doesn't solve the problem IMO | 21:31 |
| *** jkremer has quit IRC | 21:31 | |
| patrickeast | asselin_: yea but its then requiring the cinder reviewers to go look at the tempest review and review that | 21:31 |
| jgriffith | tbarron: so personally that's why I don't use any of the etherpads, dashboards or whiz-bang toys for review | 21:31 |
| tbarron | the random ordering suggestion is built on agreeing - which I'm not sure I should - to the idea that there will always be more backlog than review throughput. | 21:31 |
| jgriffith | tbarron: just randomly pick anything that hasn't failed or been down-voted already | 21:31 |
| patrickeast | jgriffith: yea i agree, its a bandaid approach and doesn't scale | 21:31 |
| jgriffith | tbarron: have you ever looked at the backlog? | 21:32 |
| *** mudassirlatif has joined #openstack-cinder | 21:32 | |
| jungleboyj | tbarron: Catching up. So are there particular ones you feel we failed you on? | 21:32 |
| tbarron | jgriffith: yeah, I've actually been doing some reviews from time to time, so I do look at it. | 21:33 |
| jgriffith | tbarron: go here: https://review.openstack.org/#/q/status:+open+cinder,n,z | 21:33 |
| tbarron | jungleboyj: no one personally has failed me. But we have 8 reviews on the launchpad (bascially almost all we submitted) that | 21:33 |
| tbarron | are getting -2ed here. | 21:33 |
| jgriffith | tbarron: tell me how many pages you go back before finding the end :) | 21:33 |
| tbarron | jgriffith: I'm well familiar with that page | 21:34 |
| *** merooney has quit IRC | 21:34 | |
| tbarron | jgriffith: I think that's why the etherpad was set up. We were towards the bottom of the Low priority. | 21:34 |
| tbarron | jgriffith: I didn't try to change that. Big mistake. | 21:34 |
| Swanson | Is every cinder patch is going to fail today? | 21:34 |
| *** e0ne has quit IRC | 21:34 | |
| jgriffith | Swanson: yes until the ssl patch merges | 21:35 |
| Swanson | jgriffith: which one is that? | 21:35 |
| *** annegentle has joined #openstack-cinder | 21:35 | |
| tbarron | I think I've made my point. Am going to have a beer and move on. | 21:35 |
| jgriffith | Swanson: https://review.openstack.org/#/c/218977/ | 21:35 |
| eharney | jgriffith: grenade just failed that patch for the second time, i think with an unrelated error :/ | 21:36 |
| jgriffith | eharney: darn it!! | 21:36 |
| eharney | pkg_resources.ContextualVersionConflict: (pbr 0.11.0 (/usr/local/lib/python2.7/dist-packages), Requirement.parse('pbr<2.0,>=1.3'), set(['sqlalchemy-migrate'])) | 21:36 |
| * eharney dunno | 21:36 | |
| Swanson | jgriffith: that one is toast | 21:36 |
| *** hemna has joined #openstack-cinder | 21:36 | |
| jgriffith | eharney: so there's a bunch of stuff going on in gate right now | 21:37 |
| jgriffith | eharney: hmm... but I don't see that anywhere else | 21:37 |
| patrickeast | eharney: i saw an email a few min ago that mentioned a new sqlalchemy-migrate release breaking the gate | 21:37 |
| guitarzan | "555 fails in 24 hrs" impressive one | 21:37 |
| patrickeast | i thought just for kilo though | 21:37 |
| jgriffith | patrickeast: well, that would puke grenade then :) | 21:38 |
| *** annegent_ has joined #openstack-cinder | 21:38 | |
| jgriffith | patrickeast: well, not always, but usually | 21:38 |
| patrickeast | ohh derp, yea grenade would be broken | 21:38 |
| eharney | yeah, grenade does kilo->liberty | 21:38 |
| *** tpsilva has quit IRC | 21:38 | |
| eharney | patrickeast: and yes it was the sqlalchemy-migrate issue | 21:39 |
| jgriffith | tbarron: so the point here is "shit happens", even if you meet all deadlines etc; if the gate pukes, or something goes wrong in the process there's not much can be done | 21:39 |
| jgriffith | tbarron: find rank the items in priority and "why" and post to dev list | 21:39 |
| jgriffith | we'll go from there | 21:39 |
| tbarron | jgriffith: I hear ya, thanks. | 21:39 |
| *** annegentle has quit IRC | 21:40 | |
| jungleboyj | With regards to the 'IRC Pestering' from earlier I don't mind people asking me for reviews in IRC at all. I think Mike prefers they not happen in the meetings. | 21:40 |
| *** sgotliv has quit IRC | 21:41 | |
| jgriffith | eharney: so how hard do you think it would be to add an automated check for imports against requirements file? | 21:43 |
| kmartin | jgriffith, in grizzly I remember them all fitting on two pages, the good old days | 21:43 |
| jgriffith | eharney: so we could check that third party section maybe and say if it doens't have the "if xxxx/else" block and it's not in the requirements file fail | 21:44 |
| *** porrua has quit IRC | 21:44 | |
| *** gouthamr has joined #openstack-cinder | 21:44 | |
| jgriffith | kmartin: haha.. and keep in mind that I think auto-abandon is running occasionally now so that's not even all of them LOL | 21:44 |
| eharney | jgriffith: i started thinking about that, i'm not too sure | 21:44 |
| eharney | jgriffith: but, i think it also can be done with a job that runs cinder-volume on a node w/ no other services installed (though it wouldn't have helped in this case) | 21:44 |
| guitarzan | actually mapping to requirements sounds really hard | 21:46 |
| jgriffith | eharney: OH... snap!! | 21:46 |
| jgriffith | eharney: that reminds me, I never finished my functional test stuff | 21:47 |
| *** ebalduf has quit IRC | 21:47 | |
| jgriffith | eharney: so cinder/tests/functional would be perfect for that | 21:47 |
| eharney | jgriffith: hmmm, quite possible | 21:47 |
| *** kvidvans has quit IRC | 21:47 | |
| jgriffith | eharney: something that just walked through the tree and did an init on every driver even? | 21:48 |
| eharney | though i'm not sure it solves the "oops now it broke because one of our deps changed their deps" case which is what we hit here | 21:48 |
| jgriffith | eharney: true | 21:48 |
| eharney | jgriffith: well, the unit tests basically do that now | 21:48 |
| jgriffith | eharney: true, but this would eliminate mocks/stubs and other various magic | 21:48 |
| eharney | ah, that's true | 21:49 |
| jgriffith | eharney: well.. until people mocked things there I suppose | 21:49 |
| eharney | jgriffith: you could pull it off if you added a new driver method that was pre-check_for_setup_error, like check_for_environment_error | 21:49 |
| *** cbader has quit IRC | 21:49 | |
| jgriffith | eharney: yeah... I like that idea | 21:50 |
| eharney | i dunno how popular that would be, but it's worth considering | 21:50 |
| jgriffith | eharney: I think it's a pretty worthwhile investment personally | 21:50 |
| jgriffith | eharney: if we communicate it early enough, and give everybody time to implement that "one" method | 21:51 |
| jgriffith | eharney: it's not overly burdensome | 21:51 |
| jgriffith | summit topic perhaps | 21:51 |
| eharney | jgriffith: yeah, and fortunately that's something we could implement for drivers if needed, too | 21:51 |
| eharney | seems like a good idea | 21:51 |
| eharney | (to have a summit topic, that is) | 21:51 |
| jgriffith | eharney: +1 | 21:52 |
| jgriffith | eharney: I'm also playing with the idea of a contrib directory | 21:53 |
| guitarzan | hmm, it doesn't even really have to be implemented in the driver no? | 21:53 |
| guitarzan | you just need something to instantiate their class | 21:53 |
| guitarzan | er, parse the driver even | 21:53 |
| jgriffith | guitarzan: well the idea would be to get results not just barf I think | 21:54 |
| eharney | guitarzan: i think that's true only if we decided to go the route of not allowing soft deps | 21:54 |
| guitarzan | jgriffith: ah... that sounds hard too :) | 21:54 |
| guitarzan | eharney: not sure I follow | 21:55 |
| jgriffith | guitarzan: so I almost have this model of a "contrib" manager as a sub-class of the base manager... and that's where "experimental" or non-required methods ends up living | 21:55 |
| guitarzan | but that's ok | 21:55 |
| eharney | guitarzan: currently we don't list a lot of driver library dependencies in requirements.txt / test-requirements.txt | 21:55 |
| guitarzan | eharney: gotcha | 21:55 |
| guitarzan | because they shouldn't be there | 21:55 |
| jgriffith | guitarzan: I'm also playing around with a similar model for drivers to extend functionality the same sort of way | 21:55 |
| guitarzan | so I'm not sure how this is possible | 21:55 |
| guitarzan | jgriffith: not another mass driver refactor! :D | 21:56 |
| jgriffith | guitarzan: nope, no refactor... | 21:56 |
| guitarzan | I thougth abc won :) | 21:56 |
| *** garthb_ has joined #openstack-cinder | 21:56 | |
| jgriffith | guitarzan: well, yeah :) | 21:57 |
| *** garthb_ has quit IRC | 21:57 | |
| jgriffith | guitarzan: but it just moves those optional things out of the base | 21:57 |
| jgriffith | I'm sure everyone will hate it even more than my last proposal, but I'll keep trying :) | 21:57 |
| *** IanGovett has quit IRC | 21:57 | |
| jgriffith | guitarzan: BTW, this is an example https://review.openstack.org/#/c/218977/1/cinder/volume/drivers/emc/emc_vmax_https.py | 21:59 |
| jungleboyj | jgriffith: I don't feel good -2'ing this one: https://review.openstack.org/#/c/207020/ | 22:04 |
| jungleboyj | Thoughts? | 22:04 |
| jgriffith | jungleboyj: well, I'm the one who blocked it :( | 22:04 |
| jgriffith | jungleboyj: I'm fine with merging it... it's a doc update that goes with a feature that already merged | 22:05 |
| jgriffith | jungleboyj: IMO those sorts of things should be allowed all the way up to the end | 22:05 |
| jgriffith | docs are a completely different category I think | 22:05 |
| jgriffith | jungleboyj: good catch | 22:05 |
| jungleboyj | Ok, I will look at that one. I will not -2 that one. | 22:06 |
| jungleboyj | jgriffith: Thank's for the input. | 22:06 |
| jgriffith | jungleboyj: I'm going to just +2/A it because I blocked it, and after reading the response agree that documenting is good | 22:06 |
| *** eharney has quit IRC | 22:07 | |
| jungleboyj | jgriffith: Good deal. | 22:07 |
| *** markvoelker has joined #openstack-cinder | 22:11 | |
| mtanino | jungleboyj: https://review.openstack.org/#/c/212861/ this one was pulled from gate queue due to the gate test error... | 22:12 |
| patrickeast | :*( rip image cache... guess we try again in M | 22:12 |
| jungleboyj | patrickeast: Yeah, that was hard to do. I wanted that in. | 22:12 |
| jgriffith | patrickeast: same as I told tbarron propose it | 22:12 |
| openstackgerrit | Joel Coffman proposed openstack/cinder: Enforce constraints at DB layer rather than API https://review.openstack.org/219007 | 22:12 |
| jgriffith | patrickeast: ie exception and the core team can all vote on it | 22:12 |
| patrickeast | jgriffith: yea i'll bring it up | 22:13 |
| jgriffith | jungleboyj: assuming that's ok with you as well | 22:13 |
| jgriffith | seems fair to at least discuss | 22:13 |
| jungleboyj | jgriffith: I am fine with that. | 22:13 |
| jgriffith | jungleboyj: also to mtanino 's point, watch those suckers that were pulled with the comment "(Pulled from gate, cinder can no longer pass unit tests) | 22:13 |
| jgriffith | " | 22:13 |
| jungleboyj | Oh, mtanino I am sorry. Fixing. | 22:14 |
| jgriffith | jungleboyj: those were items that were +2/A already | 22:14 |
| jgriffith | so should get a reset | 22:14 |
| jgriffith | jungleboyj: my fault, I should've pointed that out | 22:14 |
| mtanino | jgriffith: jungleboyj thank you. | 22:14 |
| jungleboyj | Fixed. Were there others. | 22:15 |
| jgriffith | jungleboyj: hmm... there's a few | 22:15 |
| jgriffith | jungleboyj: owner will be either sdague or myself | 22:15 |
| *** markvoelker has quit IRC | 22:16 | |
| jgriffith | jungleboyj: and go figure, I just added one in when I KNEW I was removing anything that went over there :( | 22:16 |
| openstackgerrit | John Griffith proposed openstack/cinder: Add instructions on how to deploy API under Apache https://review.openstack.org/207020 | 22:17 |
| *** garthb has quit IRC | 22:17 | |
| *** garthb has joined #openstack-cinder | 22:17 | |
| *** garthb_ has joined #openstack-cinder | 22:17 | |
| *** garthb_ has quit IRC | 22:17 | |
| jungleboyj | This one had been +A: https://review.openstack.org/#/c/187270/ | 22:18 |
| *** garthb has quit IRC | 22:18 | |
| *** garthb_ has joined #openstack-cinder | 22:18 | |
| *** garthb has joined #openstack-cinder | 22:19 | |
| jungleboyj | Looks like I should remove my -2 here as well: https://review.openstack.org/#/c/204493/ | 22:20 |
| xyang1 | jgriffith: This one is already merged: https://blueprints.launchpad.net/cinder/+spec/support-import-export-snapshots | 22:21 |
| jungleboyj | I need to drop off for a few. Then back on. Will clean up the etherpad. | 22:21 |
| xyang1 | jgriffith: This one is also merged: https://blueprints.launchpad.net/cinder/+spec/cinder-incremental-backup-improvements-for-l | 22:22 |
| jgriffith | xyang1: thanks! | 22:23 |
| jgriffith | patrickeast: hey! I believe I found the problem | 22:24 |
| patrickeast | jgriffith: \o/ | 22:24 |
| patrickeast | jgriffith: so what was it? | 22:24 |
| patrickeast | s/was/is/ | 22:24 |
| jgriffith | patrickeast: so it looks like the create-from image goes down, BUT it creates it with the regular tenant (creates the cache volume with the normal tenant) | 22:25 |
| jgriffith | patrickeast: verifying now | 22:25 |
| patrickeast | jgriffith: | 22:25 |
| patrickeast | jgriffith: oops, so it does do that first | 22:25 |
| patrickeast | jgriffith: then clones that volume to make the cached one | 22:25 |
| jgriffith | patrickeast: hmm... something's funky | 22:26 |
| *** jungleboyj has quit IRC | 22:26 | |
| patrickeast | flows supposed to be something like: create minimal sized volume from image like normal -> clone and cache the clone -> extend original (if needed) -> return back original as the requested one | 22:26 |
| jgriffith | patrickeast: ohhhhh | 22:27 |
| jgriffith | patrickeast: so it clones it AFTER the first create! | 22:27 |
| jgriffith | patrickeast: DERP I've been looking at this all wrong then | 22:27 |
| patrickeast | jgriffith: yea, that got around a ton of the permission issues, the internal tenant doesn't have to do anything with glance anymore | 22:27 |
| *** lprice has quit IRC | 22:27 | |
| patrickeast | it *used* be the other way around | 22:27 |
| patrickeast | to be* | 22:27 |
| jgriffith | patrickeast: ahh... that's how you fixed the glance issue I was having | 22:27 |
| patrickeast | jgriffith: yea we keep all our dirty tricks in-house now | 22:28 |
| *** edmondsw has quit IRC | 22:28 | |
| guitarzan | patrickeast: hmm, can we ask for it to work the other way? :) | 22:29 |
| * guitarzan runs | 22:29 | |
| patrickeast | guitarzan: haha sure, but you have to give the internal tenant access to all your images | 22:29 |
| patrickeast | guitarzan: or the ones you want cached at least | 22:30 |
| guitarzan | I'm actually 100% ok with that | 22:30 |
| guitarzan | others might not be though | 22:30 |
| patrickeast | guitarzan: its a problem for like private user images, imo it makes things really tricky to handle the permissions | 22:30 |
| guitarzan | I don't understand why though, you still have to do all the validation on future creates | 22:31 |
| patrickeast | guitarzan: yea sure, but we validate based on the caller context who is trying to create the volume | 22:31 |
| patrickeast | guitarzan: not on the cinder internal tenant | 22:31 |
| guitarzan | sure | 22:31 |
| guitarzan | oh you mean the context of the initial create | 22:31 |
| *** jaypipes has quit IRC | 22:32 | |
| *** annegent_ has quit IRC | 22:32 | |
| jgriffith | patrickeast: well shit! That breaks everything for me :( | 22:32 |
| guitarzan | anyway, it feels better to me to make the readonly copy first | 22:32 |
| patrickeast | as-is the permissions work the same way they do without the cache, if you do something like 'cinder create --image-id 123 10' you have to have permission to access image 123 | 22:32 |
| *** annegentle has joined #openstack-cinder | 22:32 | |
| guitarzan | patrickeast: sure, I expect that | 22:32 |
| patrickeast | instead of having to *also* give the cinder internal tenant access to 123 | 22:33 |
| guitarzan | but that doesn't prevent us from fetching the image with an admin tenant | 22:33 |
| jgriffith | :w | 22:33 |
| patrickeast | to get caching | 22:33 |
| patrickeast | jgriffith: :o why does that break it? | 22:33 |
| guitarzan | patrickeast: anyway, just tossing that out there | 22:33 |
| guitarzan | OR even just storing it on a volume with the internal tenant using the customer token | 22:33 |
| *** ociuhandu has joined #openstack-cinder | 22:33 | |
| tbarron | so, I had that beer and am going to give an example of a change set that was not well served by our process: https://review.openstack.org/#/c/215847/ | 22:35 |
| patrickeast | jgriffith: does the clone/extend thing not work for you? what happened? | 22:35 |
| tbarron | This was *not* a NetApp change. | 22:36 |
| tbarron | It was posted on 8/21 and not reviewed until 8/28. | 22:36 |
| tbarron | On that day it received a -1 asking for a modification to the commit msg. | 22:36 |
| tbarron | That mod was done and posted back in < 1.5 hours. | 22:36 |
| tbarron | It then received threee +1s, almost right away. | 22:37 |
| jgriffith | cinderclient doesn't even apply here FWIW | 22:37 |
| tbarron | Wasn't reviewed again till 8/28, which was a -2 because the deadline had been hit. | 22:37 |
| mtanino | oh, it's my patch. | 22:38 |
| jgriffith | tbarron: so when jungleboy gets back he can remove that | 22:38 |
| *** hemna has quit IRC | 22:38 | |
| jgriffith | tbarron: cinderclient is a completely different story | 22:38 |
| jgriffith | tbarron: although with dep freeze now I guess that's the same... hmm. | 22:38 |
| mtanino | jgriffith: I thought so too. | 22:38 |
| jgriffith | tbarron: FWIW it could have 5 +1's and that's not the same as 1 +1 and two +2's | 22:39 |
| jgriffith | :) | 22:39 |
| Swanson | +1s are pretty much meaningless. | 22:41 |
| tbarron | jgriffith: sure, my point is that it just illustrates someone doing it right, there being nothing anybody has brought up wrong with the code, and it still getting axed. | 22:42 |
| tbarron | jgriffith: which is I guess your point that s*t happens | 22:43 |
| jgriffith | tbarron: dude, you're killin me. It's not my process, I don't like it either. The door isn't closed, what more can I say to you? | 22:43 |
| *** resker has joined #openstack-cinder | 22:43 | |
| * jgriffith remember why he didn't want to be PTL any more :) | 22:43 | |
| tbarron | jgriffith: :-) | 22:44 |
| Swanson | jgriffith: Not running for PTL again, I take it? :) | 22:44 |
| *** esker has quit IRC | 22:47 | |
| *** resker has quit IRC | 22:48 | |
| *** esker has joined #openstack-cinder | 22:48 | |
| *** jungleboyj has joined #openstack-cinder | 22:55 | |
| jungleboyj | Ok, I am back briefly. | 22:55 |
| jungleboyj | xyang1: jgriffith I am going to update the etherpad with what I did tonight. Did you see anything that I -2'd that I shouldn't have? | 22:55 |
| jgriffith | jungleboyj: there was some questions about mtanino cinderclient change: https://review.openstack.org/#/c/215847/ | 22:56 |
| jgriffith | jungleboyj: but other than that I think what you did was awesome | 22:56 |
| jgriffith | jungleboyj: thanks for stepping up and doing that | 22:56 |
| jgriffith | jungleboyj: I figure tomorrow and Wed we'll do the whole "group discussion" thing | 22:56 |
| mtanino | jgriffith: jungleboyj I think this one is also proposed cinderclient https://review.openstack.org/#/c/189547/ | 22:57 |
| jungleboyj | Oh, we shouldn't block that if it's dependent patch is going to be merged. Thanks. | 22:57 |
| xyang1 | jungleboyj: jgriffith are you -2 everything or just low priority ones | 22:58 |
| jungleboyj | xyang1: Everything at this point unless it is something that is stuck on the gate. | 22:59 |
| xyang1 | jungleboyj: Ok | 22:59 |
| *** gouthamr_ has joined #openstack-cinder | 22:59 | |
| xyang1 | jungleboyj: This one was pulled from gate https://review.openstack.org/#/c/201578/ | 23:00 |
| jungleboyj | mtanino: I will have to follow up on that one with Vincent. | 23:00 |
| mtanino | jungleboyj: I undestand. | 23:01 |
| jungleboyj | xyang1: Thank you. | 23:01 |
| *** gouthamr has quit IRC | 23:02 | |
| jungleboyj | jgriffith: Agreed. I think we should discuss the image cache work. If there is anything else that comes up we can discuss. I will make sure to stay on top of IRC tonight and tomorrow. | 23:03 |
| jungleboyj | jgriffith: You are welcome. Thanks for taking the BP side of things. | 23:03 |
| jgriffith | jungleboyj: thanks!! | 23:03 |
| *** annegentle has quit IRC | 23:04 | |
| mtanino | only 7 in gate queue... | 23:07 |
| jgriffith | mtanino: yeah... getting there | 23:08 |
| jungleboyj | Ok, I will be logged in if anyone else needs me to fix something. I have some family commitments but then will be online tonight getting the etherpad updated. | 23:09 |
| jgriffith | jungleboyj: note | 23:09 |
| jgriffith | jungleboyj: we need this to merge: http://lists.openstack.org/pipermail/openstack-dev/2015-August/073340.html; so we can then recheck and merge this: https://review.openstack.org/#/c/218977/ | 23:10 |
| jgriffith | jungleboyj: *before* anything goes in to verify stage in the gate | 23:10 |
| jgriffith | anything from Cinder that is | 23:10 |
| jungleboyj | Oh man, what a mess. | 23:11 |
| jgriffith | I'm not completely sure how keeping new changes to Cinder impacts all of that right now, but that's what we've been doing at any rate | 23:11 |
| jungleboyj | jgriffith: Ok, so we need to watch for the first to merge, recheck/merge 218977 then merge the other ones that were +A. | 23:12 |
| jungleboyj | Piece of cake. | 23:12 |
| jgriffith | jungleboyj: :) | 23:12 |
| jgriffith | exactly! | 23:12 |
| jgriffith | LOL | 23:12 |
| jungleboyj | jgriffith: Thanks for the roadmap. I will keep an eye on it. | 23:13 |
| jgriffith | and that's why folks are bent out of shape, but honestly there's not much I can do about it | 23:13 |
| jgriffith | if the gate stops, the gate stops... it happens | 23:13 |
| *** lcurtis has quit IRC | 23:13 | |
| jungleboyj | Ok, back in a couple hours. Family is calling. I think we are being fair about it by getting the other ones that had gotten +A a chance. | 23:13 |
| *** ganso_ has quit IRC | 23:15 | |
| *** daneyon has joined #openstack-cinder | 23:16 | |
| *** Apoorva has joined #openstack-cinder | 23:17 | |
| *** daneyon_ has quit IRC | 23:17 | |
| *** Apoorva has quit IRC | 23:17 | |
| *** Apoorva has joined #openstack-cinder | 23:18 | |
| *** daneyon_ has joined #openstack-cinder | 23:18 | |
| *** Apoorva_ has quit IRC | 23:20 | |
| *** gouthamr has joined #openstack-cinder | 23:20 | |
| *** Zhongjun has joined #openstack-cinder | 23:21 | |
| *** daneyon has quit IRC | 23:22 | |
| *** gouthamr_ has quit IRC | 23:23 | |
| *** rushil has quit IRC | 23:24 | |
| *** lprice has joined #openstack-cinder | 23:30 | |
| *** rushil has joined #openstack-cinder | 23:32 | |
| *** rushil has quit IRC | 23:36 | |
| *** rushil has joined #openstack-cinder | 23:36 | |
| jgriffith | patrickeast: FYI, got the image-caching thing squared away | 23:44 |
| jgriffith | patrickeast: it actually exposed a bug in my code that's been around *forever* | 23:45 |
| jgriffith | patrickeast: thanks for your patience | 23:45 |
| * jgriffith has a long list of bugs to fix in the next week or so :( | 23:45 | |
| patrickeast | jgriffith: woot, always happy to help break things | 23:46 |
| patrickeast | find bugs* | 23:46 |
| patrickeast | jgriffith: thanks for testing it out | 23:47 |
| patrickeast | speaking of bugs... anyone seen issues with nova in their ci systems like so http://ec2-54-67-51-189.us-west-1.compute.amazonaws.com/49/209749/13/check/PureFCDriver-tempest-dsvm-volume-multipath/474146a/logs/screen-n-cpu.txt.gz?level=TRACE | 23:49 |
| *** smoriya has joined #openstack-cinder | 23:49 | |
| patrickeast | only seems to happen with my FC driver (which is actually a concerning theme with my ci failures...) | 23:49 |
| jgriffith | patrickeast: that's yummy | 23:49 |
| jgriffith | patrickeast: tried an ER search? | 23:49 |
| patrickeast | jgriffith: yea, nothing turned up | 23:50 |
| patrickeast | although i'm not a logstash ninja, so maybe am searching for the wrong thing | 23:50 |
| jgriffith | hmm... I got some results | 23:50 |
| jgriffith | well... one ;) | 23:51 |
| patrickeast | haha | 23:51 |
| jgriffith | http://logstash.openstack.org/#eyJzZWFyY2giOiJcIkRldmljZUlzQnVzeTogVGhlIHN1cHBsaWVkIGRldmljZSAodmRiKSBpcyBidXN5LlwiIiwiZmllbGRzIjpbXSwib2Zmc2V0IjowLCJ0aW1lZnJhbWUiOiIxNzI4MDAiLCJncmFwaG1vZGUiOiJjb3VudCIsInRpbWUiOnsidXNlcl9pbnRlcnZhbCI6MH0sInN0YW1wIjoxNDQxMDY1MDM1MTY3fQ== | 23:51 |
| jgriffith | patrickeast: bumping out the time frame on it | 23:51 |
| jgriffith | patrickeast: it's hit a few times... 4 in the last 7 days | 23:52 |
| patrickeast | hmm interesting, so it does seem to be the same error | 23:52 |
| *** IlyaG has joined #openstack-cinder | 23:52 | |
| patrickeast | have to go dig into them more to see if its the same tests or not | 23:52 |
| jgriffith | patrickeast: I wonder if this has anything to do with what mtreinish was looking at earlier? | 23:52 |
| patrickeast | jgriffith: oh maybe, that was the issue with the device not showing up on the partition tables, right? | 23:53 |
| jgriffith | patrickeast: roger | 23:53 |
| *** diegows has quit IRC | 23:53 | |
| *** DericHorn-HP has quit IRC | 23:54 | |
| *** andreykurilin__ has quit IRC | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!