Thursday, 2015-08-27

tbarronpatrickeast: thanks!  at least we know we're not alone.00:01
*** p0rtal has quit IRC00:02
patrickeasttbarron: my guess is that something is supposed to be mocked out that isn't... but from what i was seeing in the test it should not be actually running real code when it does the 'self._delete_temp_backing(backing)'00:02
patrickeastcouldn't really trace through it or test a fix easily since i can't repro it though :(00:03
*** p0rtal has joined #openstack-cinder00:04
mtanino_tbarron: I see that error several times...00:05
*** zhangjn has quit IRC00:05
tbarronpatrickeast: mtanino_:  AttributeError: '_SentinelObject' object has no attribute 'readlines' ...00:06
mtanino_tbarron: yup :(00:06
*** r-daneel has joined #openstack-cinder00:09
tbarronmost recent change to that test seems to be: 212aff32 cinder/tests/unit/test_vmware_vmdk.py (Sergey Vilgelm          2015-07-08 15:18:13 +0300 1655)     @mock.patch.object(VMDK_DRIVER, '_get_disk_type')00:11
tbarron^^^ which is a switch to oslo_utils.fileutils from fileutils.file_open()00:13
*** mtanino_ has quit IRC00:13
*** tsekiyama has quit IRC00:14
*** edtubill has joined #openstack-cinder00:15
*** bnemec has quit IRC00:18
*** lixiaoy1 has joined #openstack-cinder00:19
jgriffithtbarron: I have not seen that myself00:22
tbarronjgriffith: well, I hope you remain blessed in that regard :-)00:22
jgriffithhaha00:22
patrickeasttbarron: so the part that I don't really get is that it seems to be coming from this code block https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/vmware/vmdk.py#L1677-L168200:25
patrickeastits the exit from the exec utils with statement00:25
patrickeastthe test doesn't seem to be a negative one though, so i'm not sure why it is even in there in the first place00:26
patrickeastsome exception was raised... but it blows up trying to handle it00:26
*** esker has quit IRC00:27
*** smoriya has joined #openstack-cinder00:27
tbarronpatrickeast: yeah, that's helpful.  Maybe _delete_temp_backing would have had this problem all along (like the readlines failure when printing out exception from a mocked out file object).00:30
tbarronpatrickeast: so the question, as you say, is why we now hit the Exception that leads to the _delete_temp_backing() call.00:30
patrickeasttbarron: heh yea, and why only sometimes00:31
tbarronpatrickeast: use of tmp files in tests seems more functional than unit to me :-)00:31
patrickeasttbarron: definitely00:31
*** xyang1 has quit IRC00:31
tbarronpatrickeast: and an exception will be raised if ``timeout`` is exceeded when running image_transfer.download_stream_optimized_data()00:34
tbarronpatrickeast: so there is likely the indeterminacy00:35
patrickeasttbarron: yea maybe, looks like that image_transfer method is supposed to be mocked out though, it should just be returning...I think00:36
patrickeastI guess if it isn't mocked out that could very well be the problem00:36
*** edtubill has quit IRC00:38
tbarronpatrickeast: oh, but I think you are right: @mock.patch.object(image_transfer, 'download_stream_optimized_data')00:39
*** asd112z has joined #openstack-cinder00:41
*** salv-orlando has quit IRC00:43
*** martyturner1 has joined #openstack-cinder00:44
*** rick_chen has joined #openstack-cinder00:45
*** martyturner has quit IRC00:46
rick_chenthingee: HI Mike, Do you receive my email about the Prophetstor CI account?00:47
*** bnemec has joined #openstack-cinder00:47
rick_chenthingee: I completed all Ramy's comment.00:48
*** zhangjn has joined #openstack-cinder00:49
*** martyturner1 has quit IRC00:50
*** zhangjn has quit IRC00:51
jgriffithrick_chen: thingee is on vacation for the next week and 1/200:52
*** zhangjn has joined #openstack-cinder00:53
*** zhangjn has quit IRC00:54
*** sghanekar has joined #openstack-cinder00:55
*** zhangjn has joined #openstack-cinder00:55
*** andreykurilin__ has quit IRC00:55
anteayarick_chen: ^^01:00
*** skylerberg has quit IRC01:02
tbarronpatrickeast: well, it looks like everything that could be throwing the exception is mocked out (kinda like you said at the outset).01:03
tbarronpatrickeast: I haven't used this mock.sentinel stuff myself though, so may be missing something.01:04
*** _cjones_ has quit IRC01:05
*** zhenguo has joined #openstack-cinder01:05
*** garthb_ has quit IRC01:07
*** leeantho has quit IRC01:11
*** rick_chen has quit IRC01:12
*** rick_chen has joined #openstack-cinder01:15
rick_chenjgriffith: OK, I got. Does my Thrid-party CI account need Mike permission to re-enable until he returns?01:17
*** bswartz has joined #openstack-cinder01:20
*** akerr has joined #openstack-cinder01:30
*** dannywilson has quit IRC01:31
*** akerr_ has joined #openstack-cinder01:31
*** dannywilson has joined #openstack-cinder01:32
*** akerr has quit IRC01:35
*** r-daneel has quit IRC01:35
*** gouthamr has quit IRC01:36
*** mudassirlatif has quit IRC01:36
*** dannywilson has quit IRC01:36
*** dannywil_ has joined #openstack-cinder01:36
*** gouthamr has joined #openstack-cinder01:36
openstackgerritwanghao proposed openstack/cinder: Add pagination to backups  https://review.openstack.org/20449301:40
*** dannywil_ has quit IRC01:41
*** bnemec has quit IRC01:41
*** Lee1092 has joined #openstack-cinder01:43
*** dims has joined #openstack-cinder01:43
*** jdandrea has quit IRC01:43
*** sghanekar has quit IRC01:48
*** p0rtal has quit IRC01:48
*** p0rtal has joined #openstack-cinder01:49
*** p0rtal has quit IRC01:54
openstackgerritThang Pham proposed openstack/cinder: Conversion to volume object  https://review.openstack.org/17705401:59
*** ndipanov has quit IRC02:00
*** rick_chen has quit IRC02:01
*** haomaiwa_ has joined #openstack-cinder02:03
*** jlk has left #openstack-cinder02:04
*** haomaiwa_ has quit IRC02:09
*** haomaiwang has joined #openstack-cinder02:10
*** chenying has joined #openstack-cinder02:10
*** asselin has quit IRC02:15
openstackgerritChangBo Guo(gcb) proposed openstack/cinder: Use version convert methods from oslo.utils  https://review.openstack.org/21451602:16
*** Apoorva has quit IRC02:21
*** akerr has joined #openstack-cinder02:23
*** akerr__ has joined #openstack-cinder02:24
*** akerr_ has quit IRC02:26
*** akerr has quit IRC02:27
*** skylerberg has joined #openstack-cinder02:29
openstackgerritMichael Price proposed openstack/cinder: NetApp E-Series over-subscription support  https://review.openstack.org/21580102:30
*** gouthamr_ has joined #openstack-cinder02:33
*** gouthamr has quit IRC02:36
*** gouthamr_ has quit IRC02:37
*** baojg has joined #openstack-cinder02:39
openstackgerritHuang Zhiteng proposed openstack/os-brick: iSCSI Connector: force disconnect iscsi session  https://review.openstack.org/21703202:42
*** mriedem has quit IRC02:43
*** salv-orlando has joined #openstack-cinder02:44
*** salv-orlando has quit IRC02:48
*** akerr__ has quit IRC02:50
*** asd112z has quit IRC02:50
*** jlk has joined #openstack-cinder02:50
openstackgerritwanghao proposed openstack/cinder: Add UniqueConstraint for quota usages table  https://review.openstack.org/21746502:51
*** hakimo_ has joined #openstack-cinder02:52
*** takedakn has joined #openstack-cinder02:53
*** hakimo has quit IRC02:55
*** dims has quit IRC02:56
*** haomaiwang has quit IRC03:01
*** haomaiwang has joined #openstack-cinder03:01
*** EinstCrazy has joined #openstack-cinder03:32
*** hw__chenying has joined #openstack-cinder03:35
*** chenying has quit IRC03:38
*** jgriffith has quit IRC03:43
*** jgriffith has joined #openstack-cinder03:44
*** jgriffith is now known as Guest5416203:45
*** takedakn has quit IRC03:45
*** haomaiwang has quit IRC04:01
*** haomaiwa_ has joined #openstack-cinder04:01
*** jamielennox is now known as jamielennox|away04:04
*** jamielennox|away is now known as jamielennox04:05
*** jlk has left #openstack-cinder04:09
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/21544004:13
*** hw__chenying has quit IRC04:31
*** rushil has joined #openstack-cinder04:32
*** BharatK has quit IRC04:33
*** rushil_ has joined #openstack-cinder04:34
*** asselin has joined #openstack-cinder04:34
*** rushil has quit IRC04:37
*** links has joined #openstack-cinder04:38
*** shyama has joined #openstack-cinder04:45
*** BharatK has joined #openstack-cinder04:45
*** BharatK_ has joined #openstack-cinder04:46
*** changbl has quit IRC04:46
*** dflorea has joined #openstack-cinder04:46
*** BharatK has quit IRC04:50
*** rushil_ has quit IRC04:50
*** p0rtal has joined #openstack-cinder04:51
*** davechen has joined #openstack-cinder04:53
*** haomaiwa_ has quit IRC05:01
*** haomaiwang has joined #openstack-cinder05:01
*** salv-orlando has joined #openstack-cinder05:02
*** nkrinner has joined #openstack-cinder05:02
*** skylerberg has quit IRC05:05
*** salv-orlando has quit IRC05:07
*** vincent_hou has joined #openstack-cinder05:10
*** openstackgerrit has quit IRC05:16
*** openstackgerrit has joined #openstack-cinder05:17
*** ankit_ag has joined #openstack-cinder05:23
*** zerda has joined #openstack-cinder05:28
*** albertom has quit IRC05:29
openstackgerritPeter Wang proposed openstack/cinder: Update name_id and provider_location for migration  https://review.openstack.org/21752205:30
*** albertom has joined #openstack-cinder05:30
openstackgerritPeter Wang proposed openstack/cinder: Update name_id and provider_location for migration  https://review.openstack.org/21752205:33
*** dflorea has quit IRC05:36
*** dflorea has joined #openstack-cinder05:38
*** smoriya has quit IRC05:38
*** vincent_hou has quit IRC05:38
*** dflorea has quit IRC05:42
*** baojg has quit IRC05:45
*** rushiagr_away is now known as rushiagr05:45
*** dims has joined #openstack-cinder05:46
*** agarciam has joined #openstack-cinder05:48
*** p0rtal has quit IRC05:48
*** p0rtal has joined #openstack-cinder05:49
*** EinstCrazy has quit IRC05:50
*** baojg has joined #openstack-cinder05:52
*** dims has quit IRC05:52
*** baojg has quit IRC05:52
*** EinstCrazy has joined #openstack-cinder05:53
*** hw__chenying has joined #openstack-cinder06:00
*** haomaiwang has quit IRC06:01
*** 5EXABZ8QP has joined #openstack-cinder06:01
openstackgerritRajesh Tailor proposed openstack/python-cinderclient: Fix help message for reset-state commands  https://review.openstack.org/21753006:05
*** afazekas_ has joined #openstack-cinder06:06
*** p0rtal has quit IRC06:10
*** sghanekar has joined #openstack-cinder06:15
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Imported Translations from Transifex  https://review.openstack.org/21446806:19
*** baojg has joined #openstack-cinder06:22
*** deepakcs has joined #openstack-cinder06:22
openstackgerritLisaLi proposed openstack/cinder: Data transformation betweeen encrypted volumes and images  https://review.openstack.org/21656706:25
*** sghanekar has quit IRC06:27
nikeshmLisaLi: hi06:29
nikeshmLisaLi: i missed reviews on https://bugs.launchpad.net/openstack-manuals/+bug/143603106:30
openstackLaunchpad bug 1436031 in openstack-manuals "Migrate volumes in OpenStack Cloud Administrator Guide - current" [Medium,Fix released] - Assigned to Lisa Li (lisali)06:30
nikeshmnikeshm: i commented on that, if you have time please look once06:32
nikeshmLisaLi: i commented on that, if you have time please look once06:32
openstackgerritHuang Zhiteng proposed openstack/os-brick: iSCSI Connector: force disconnect iscsi session  https://review.openstack.org/21703206:34
*** albertom has quit IRC06:34
*** DTadrzak has quit IRC06:35
*** pots has quit IRC06:35
*** pots has joined #openstack-cinder06:36
*** alexschm has joined #openstack-cinder06:38
*** albertom has joined #openstack-cinder06:39
lixiaoy1nikeshm: ok, let me have a look06:40
*** salv-orlando has joined #openstack-cinder06:47
*** vlaza has joined #openstack-cinder06:48
*** DTadrzak has joined #openstack-cinder06:49
*** martyturner has joined #openstack-cinder06:50
*** salv-orlando has quit IRC06:52
*** rushiagr is now known as rushiagr_away06:53
*** kaisers has quit IRC06:54
*** martyturner has quit IRC06:55
nikeshmlixiaoy1: thanks06:56
*** anshul has joined #openstack-cinder06:57
*** markus_z has joined #openstack-cinder07:00
*** 5EXABZ8QP has quit IRC07:01
*** haomaiwang has joined #openstack-cinder07:02
*** theanalyst has quit IRC07:03
*** theanalyst has joined #openstack-cinder07:04
*** salv-orlando has joined #openstack-cinder07:06
*** yrabl has joined #openstack-cinder07:07
*** yrabl has quit IRC07:07
*** markus_z has quit IRC07:07
*** stefan_amann has joined #openstack-cinder07:08
*** ronis has joined #openstack-cinder07:08
*** yrabl has joined #openstack-cinder07:09
*** yrabl_ has joined #openstack-cinder07:09
*** yrabl_ has quit IRC07:09
*** ronis_ has joined #openstack-cinder07:09
*** ronis has quit IRC07:13
*** tobasco_ is now known as tobasco07:14
openstackgerritTeruaki Ishizaki proposed openstack/cinder: Sheepdog: Improve snapshot and clone operation  https://review.openstack.org/19895207:17
*** e0ne has joined #openstack-cinder07:18
openstackgerritLisaLi proposed openstack/cinder: Copy encryptors from Nova to Cinder  https://review.openstack.org/21755707:18
nikeshmlixiaoy1 : hi, did you get chance to look on that?07:20
openstackgerritLisaLi proposed openstack/cinder: Data transfer between encrypted volumes and images  https://review.openstack.org/21656707:28
lixiaoy1nikeshm: I am looking it now. I just finish downloading code07:29
geguileoe0ne: Backup metadata fix has +1 from Jenkins  ;-)07:29
nikeshmthanks07:29
lixiaoy1nikeshm: yes, I noticed the problem07:31
lixiaoy1nikeshm: I will fix it. One question: now the files are changed to *.rst, they are xml fomer07:32
nikeshmlixiaoy1 : sorry, as of now, i am not familiar with this07:33
nikeshmlixiaoy1 : might be some one in openstack-manauls can help07:34
lixiaoy1nikeshm: no problem. I will look into it. Anyway thank you for finding the problem.07:35
lixiaoy1geguileo: Congratulations to be cinder core. although late07:35
geguileolixiaoy1: Thanks  :-)07:35
*** dims has joined #openstack-cinder07:35
e0negeguileo: great! i'll take a look on it a bit later07:37
geguileoe0ne: No hurry, since it cannot merge until Tempest test merges07:37
geguileoe0ne: I mean the patch that temporary disables the test07:38
*** DTadrzak has quit IRC07:38
*** DTadrzak has joined #openstack-cinder07:39
*** dims has quit IRC07:40
openstackgerritLisaLi proposed openstack/cinder: Data transfer between encrypted volumes and images  https://review.openstack.org/21656707:43
*** pots has quit IRC07:52
*** p0rtal has joined #openstack-cinder07:53
openstackgerritLisaLi proposed openstack/cinder: Data transfer between encrypted volumes and images  https://review.openstack.org/21656707:55
*** IanGovett has joined #openstack-cinder07:56
*** sgotliv has joined #openstack-cinder07:56
*** haomaiwang has quit IRC08:01
*** haomaiwang has joined #openstack-cinder08:01
*** e0ne has quit IRC08:01
*** lpetrut has joined #openstack-cinder08:02
*** lpetrut1 has joined #openstack-cinder08:02
*** baojg has quit IRC08:02
*** lpetrut has left #openstack-cinder08:03
*** lpetrut1 has quit IRC08:03
*** lpetrut1 has joined #openstack-cinder08:03
*** takedakn has joined #openstack-cinder08:08
*** boris-42 has quit IRC08:10
*** kaisers has joined #openstack-cinder08:11
*** kaisers has quit IRC08:12
openstackgerritDaniel Tadrzak proposed openstack/cinder: CGSnapshot Object  https://review.openstack.org/19502708:13
openstackgerritDaniel Tadrzak proposed openstack/cinder: Cleanup for cinder tests with CGSnapshot  https://review.openstack.org/20786608:13
*** jordanP has joined #openstack-cinder08:14
*** pots has joined #openstack-cinder08:14
*** kaisers has joined #openstack-cinder08:14
*** jistr has joined #openstack-cinder08:15
*** baojg has joined #openstack-cinder08:16
openstackgerritDaniel Tadrzak proposed openstack/cinder: Cleanup for SnapshotObject  https://review.openstack.org/19834108:20
*** JoeStack has joined #openstack-cinder08:27
*** bluex-pl has joined #openstack-cinder08:28
*** ndipanov has joined #openstack-cinder08:30
dulekgeguileo: Hi. Wanted to ask your opinion.08:35
geguileodulek: 5 mins, on a call08:35
*** yuriy_n17 has joined #openstack-cinder08:41
geguileodulek: Hi08:41
geguileodulek: I'm available now08:41
dulekgeguileo: I'm aware of the freeze that was on Sunday, not all of versioned objects compatibility mode patches were ready, so we're unable to merge them.08:41
dulekgeguileo: I wonder about the objects patches - CGSnapshots, Services, Volumes.08:41
dulekgeguileo: If we would be able to merge them in L and compatibility mode in M, then we'll get no-downtime upgrades from L to M.08:41
dulekgeguileo: All of these patches were ready before the deadline, so I feel like freeze may not apply to them.08:41
dulekgeguileo: Do you think this is worth pursuing?08:42
dulekgeguileo: (I was on vacations last week, so I may be missing something.)08:42
geguileodulek: If I'm not mistaken if the BP was approved and the patches were passing jenkins they probably are not affected by the merge08:42
geguileos/merge/freeze08:42
dulekgeguileo: Actually the last patch of *compatibility mode* weren't.08:43
geguileodulek: Although I'm not so sure about the rolling migration (no downtime from L to M)08:43
dulekgeguileo: Objects were ready long before.08:43
dulekgeguileo: Why?08:43
geguileodulek: Well, has anybody actually tested that?08:44
dulekgeguileo: Ah, right.08:44
geguileodulek: Have we moved all Volume operations to use Volume Versioned Objects?08:44
geguileodulek: Has Volume Versioned Object been updated?08:44
dulekgeguileo: Let me check again on the thangp's patches.08:45
geguileodulek: Because as far as I remember, Volume Versioned Object is out of sync with Volume ORM object08:45
openstackgerritHuang Zhiteng proposed openstack/os-brick: iSCSI Connector: force disconnect iscsi session  https://review.openstack.org/21703208:45
dulekgeguileo: https://review.openstack.org/#/c/17705408:49
dulekgeguileo: This patch updates it, I've double checked and it is in sync.08:49
geguileodulek: That patch is not going to be merged like that, I can guarantee it08:50
*** haomaiwang has quit IRC08:51
geguileodulek: It will need to be split in 3 or 408:51
openstackgerritwanghao proposed openstack/cinder: Add pagination to backups  https://review.openstack.org/20449308:51
dulekgeguileo: It had +2's quite a few times. The problem is it gets into merge conflicts often due to the size.08:51
geguileodulek: Because it's doing multiple thing in the same patch08:51
*** haomaiwang has joined #openstack-cinder08:51
geguileodulek: Oh, then I'll give it a -2 right away08:52
dulekgeguileo: I don't think thangp can split it more while providing a minimal functionality.08:52
geguileodulek: Really?08:52
geguileodulek: He can do Volume object changes in another patch08:52
dulekgeguileo: Ah, right, that's different story than other objects, because VolumeObject was there in the first place, even if it wasn't used.08:53
geguileodulek: He should move the refresh stuff to other patch as well, an probably move it to the base class08:54
geguileodulek: And that's just from looking at it 3 minutes  ;-)08:54
*** jistr has quit IRC08:54
geguileodulek: I'll comment on the patch08:55
dulekgeguileo: Okay, thanks.08:55
geguileodulek: Thank you for pointing out those patches08:55
geguileodulek: I've been looking at L3 priority patches lately and missed some other stuff08:55
dulekgeguileo: Just FYI - here's follow-up patch: https://review.openstack.org/#/c/20140408:55
*** pots has quit IRC08:55
geguileodulek: Thanks08:56
*** jistr has joined #openstack-cinder08:56
*** lixiaoy1 has quit IRC08:59
openstackgerritLisaLi proposed openstack/cinder: Data transfer between encrypted volumes and images  https://review.openstack.org/21656708:59
*** e0ne has joined #openstack-cinder08:59
*** haomaiwang has quit IRC09:01
*** davechen has quit IRC09:01
*** jistr has quit IRC09:01
*** haomaiwang has joined #openstack-cinder09:02
*** jistr has joined #openstack-cinder09:05
nikeshme0ne: hi is this patch https://review.openstack.org/#/c/147186/ is not going to be merged as liberty09:16
nikeshme0ne: its your patch right09:16
nikeshmin liberty09:16
e0nenikeshm: it's eharney's patch09:17
nikeshmoh sorry09:17
nikeshmthanks i will ask him09:18
*** andreykurilin__ has joined #openstack-cinder09:20
jordanPe0ne, are you, by any chance, core on os-brick ?09:33
e0nejordanP: yes, all cinder cores are os-brick cores too09:34
jordanPe0ne, excellent. May I bother you a sec to look at https://review.openstack.org/#/c/196631/ (it's needed to unblock a change you +Aed yesterday)09:35
jordanPe0ne, thanks09:46
e0nejordanP: you're welcome!09:46
*** baojg has quit IRC09:50
*** dims has joined #openstack-cinder09:50
openstackgerritHuang Zhiteng proposed openstack/os-brick: iSCSI Connector: force disconnect iscsi session  https://review.openstack.org/21703209:58
*** haomaiwang has quit IRC10:01
*** haomaiwang has joined #openstack-cinder10:02
*** jistr has quit IRC10:06
openstackgerritVictor Stinner proposed openstack/cinder: Fix Python 3 issues in wsgi  https://review.openstack.org/21741710:10
*** zhenguo has quit IRC10:10
openstackgerritNikesh proposed openstack/cinder: Fix handling of volume copy for 'virtual' volumes  https://review.openstack.org/21761510:10
*** EinstCrazy has quit IRC10:13
*** zhangjn has quit IRC10:15
*** jistr has joined #openstack-cinder10:18
*** pots has joined #openstack-cinder10:26
*** ociuhandu has quit IRC10:30
*** pythonguy has joined #openstack-cinder10:32
pythonguyhello guys10:32
*** pythonguy has quit IRC10:35
*** hw__chenying has quit IRC10:36
openstackgerritSzymon Wr√≥blewski proposed openstack/cinder: utils.synchronized lock name formatting  https://review.openstack.org/21725810:41
*** takedakn1 has joined #openstack-cinder10:41
*** takedakn has quit IRC10:42
duleke0ne: Sorry, I've accidentally updated your grenade patch. As I actually did that let me address nits I've found there.10:43
*** mewald has joined #openstack-cinder10:45
*** ociuhandu has joined #openstack-cinder10:46
mewaldHow do I make cinder-volume redundant? Can I simply run multiple instances configured with the same backends?10:46
dulekmewald: Actually no. C-vol can run active/passive only.10:48
dulekmewald: I mean - you can run multiple instances, but you may run into some race conditions.10:48
dulekmewald: Which backends does you use?10:49
mewaldI plan to use CEPH10:49
mewaldso I can only have one instance of cinder-volume and cinder-backup as it must run on the same node that runs cinder-volume, right?10:50
dulekmewald: That's right. Mirantis Fuel is however running c-vol in A/A HA mode. So probably problems are very rare - but possible.10:51
mewaldare there any plans to make A/A c-vol safe in future releases?10:52
openstackgerritMichal Dulko proposed openstack/cinder: Add LC_ALL=C to lvcreate, lvextend and pvresize  https://review.openstack.org/21667510:52
openstackgerritNikesh proposed openstack/cinder: Fix handling of volume copy for 'virtual' volumes  https://review.openstack.org/21761510:52
*** pots has quit IRC11:00
*** haomaiwang has quit IRC11:01
*** haomaiwa_ has joined #openstack-cinder11:02
*** aix has quit IRC11:02
e0nedulek: please, rebase your patch to the master11:05
e0nedulek: my patch won't be merged in Liberty11:05
e0nedulek: and thank you for fixing commit message11:06
*** haomaiwa_ has quit IRC11:11
*** bswartz has quit IRC11:32
*** aix has joined #openstack-cinder11:33
nikeshmsmcginnis: hi uploaded one fix for dothill drivers https://review.openstack.org/#/c/217615/11:37
*** e0ne has quit IRC11:42
*** haomaiwang has joined #openstack-cinder11:53
*** deepakcs has quit IRC11:54
*** haomaiwang has quit IRC12:01
*** haomaiwang has joined #openstack-cinder12:02
*** dflorea has joined #openstack-cinder12:03
*** dflorea has quit IRC12:07
*** agarciam has quit IRC12:09
*** raildo-afk is now known as raildo12:10
*** dims has quit IRC12:14
*** rushil has joined #openstack-cinder12:14
*** thangp has joined #openstack-cinder12:15
*** rushil_ has joined #openstack-cinder12:18
*** ociuhandu has quit IRC12:20
thangpgeguileo: ping12:20
thangpgeguileo: re:177054, i already broke up the changes as much as possible12:21
*** anshul has quit IRC12:21
thangpgeguileo: the bulk of it is updating unit tests12:21
*** zerda has quit IRC12:21
*** rushil has quit IRC12:22
*** haigang has joined #openstack-cinder12:22
*** mtanino has joined #openstack-cinder12:24
*** ociuhandu has joined #openstack-cinder12:26
*** haigang has quit IRC12:26
*** dims has joined #openstack-cinder12:29
*** BharatK_ has quit IRC12:30
*** annegentle has joined #openstack-cinder12:31
*** openstackgerrit has quit IRC12:31
*** openstackgerrit has joined #openstack-cinder12:32
*** edmondsw has joined #openstack-cinder12:32
*** pots has joined #openstack-cinder12:32
*** timcl has joined #openstack-cinder12:34
tbarronmewald: for splitting backup/volume services see https://review.openstack.org/#/c/203215/12:34
tbarronmewald: active/active c-vol will be a journey.  First step is https://review.openstack.org/#/c/205834/12:35
*** andreykurilin__ has quit IRC12:35
openstackgerritNikesh proposed openstack/cinder: Fix volume copy for 'virtual' volumes in DotHill  https://review.openstack.org/21761512:36
*** anshul has joined #openstack-cinder12:38
*** simondodsley has joined #openstack-cinder12:38
openstackgerritDaniel Tadrzak proposed openstack/cinder: CGSnapshot Object  https://review.openstack.org/19502712:43
*** e0ne has joined #openstack-cinder12:44
*** merooney has joined #openstack-cinder12:47
*** bswartz has joined #openstack-cinder12:48
*** diablo_rojo has joined #openstack-cinder12:49
*** eduardo has joined #openstack-cinder12:49
*** salv-orlando has quit IRC12:53
*** porrua has joined #openstack-cinder12:55
*** rushil_ has quit IRC12:58
*** akerr has joined #openstack-cinder12:59
*** anshul has quit IRC12:59
*** haomaiwang has quit IRC13:01
*** haomaiwang has joined #openstack-cinder13:02
*** martyturner has joined #openstack-cinder13:04
*** dustins has joined #openstack-cinder13:06
*** changbl has joined #openstack-cinder13:06
*** tpsilva has joined #openstack-cinder13:06
*** I has joined #openstack-cinder13:06
*** I is now known as Guest6274913:07
*** rushil has joined #openstack-cinder13:08
*** diogogmt has joined #openstack-cinder13:10
*** martyturner1 has joined #openstack-cinder13:10
*** mtanino has quit IRC13:11
*** ankit_ag has quit IRC13:12
*** anshul has joined #openstack-cinder13:12
*** martyturner has quit IRC13:13
openstackgerritMasaki Kanno proposed openstack/cinder: Prevent that all backup objects are deleted  https://review.openstack.org/21770213:15
*** diablo_rojo has quit IRC13:16
*** salv-orlando has joined #openstack-cinder13:23
*** zhenguo has joined #openstack-cinder13:25
*** afazekas_ has quit IRC13:26
*** julim has joined #openstack-cinder13:28
*** Yogi1 has joined #openstack-cinder13:30
*** diablo_rojo has joined #openstack-cinder13:30
*** xyang1 has joined #openstack-cinder13:31
*** mriedem has joined #openstack-cinder13:32
geguileothangp: I dissagree13:33
thangpgeguileo: ok...13:33
geguileothangp: Like I said in the comment13:34
geguileothangp: You can split the Volume versioned object code13:34
geguileothangp: You can split the refresh code13:34
thangpgeguileo: I already replied to it13:34
thangpgeguileo: you cant put refresh in base13:34
thangpgeguileo: the majority of the patch is unit tests13:35
thangpgeguileo: breaking it into these minor pieces seems a lot of work for little gain13:35
geguileothangp: The "little" gain is good reviews13:36
*** gouthamr has joined #openstack-cinder13:37
thangpgeguileo: it increases the number of patches to rebase13:37
geguileothangp: Because I can assure you there is no good review of a 2200 loc patch13:37
thangpgeguileo: i dont disagree, but 2000 of those lines are in unit tests13:38
thangpgeguileo: which is the annoyance13:38
geguileothangp: Why mix test fixing with the other stuff in the patch?13:39
*** Guest62749 has quit IRC13:39
geguileothangp: Why mix api/rpc/manager changes with changes to the object?13:39
thangpgeguileo: because changing it to objects breaks unit tests13:39
thangpgeguileo: the whole point of the patch is to send objs over rpc13:39
geguileothangp: I know the point of the patch, but you have to split it13:40
thangpgeguileo: i will look at splitting part of it13:41
thangpgeguileo: but you cant put refresh in base, as i said in the patch13:41
openstackgerritVincent Hou proposed openstack/cinder: Volume status management during migration  https://review.openstack.org/18631213:43
geguileothangp: You say you can't put it in the Cinder base object, and I think you can13:43
thangpgeguileo: each obj has its own get_by_id13:43
thangpgeguileo: which calls the db13:44
thangpgeguileo: the base cinderobject should not have a get_by_id13:44
geguileothangp: Well, I think it can13:44
openstackgerritNikesh proposed openstack/cinder: Fix volume copy for 'virtual' volumes in DotHill  https://review.openstack.org/21761513:44
thangpgeguileo: how could you put refresh in base?13:45
geguileothangp: You move get_by_id to base and set an attribute in each object to set the model13:46
geguileothangp: Similar to what I did in conditional updates13:46
thangpgeguileo: each get_by_id calls a different db api13:46
*** diogogmt has quit IRC13:47
thangpgeguileo: you cant make a db call generic13:47
geguileothangp: Well, I can, and I did for conditional objects13:48
thangpgeguileo: what patch is that?13:48
openstackgerritNikesh proposed openstack/cinder: Fix volume copy for 'virtual' volumes in DotHill  https://review.openstack.org/21761513:48
geguileothangp: https://review.openstack.org/#/c/205834/13:48
thangpgeguileo: i'm not going to disagree that it cant be done, but it looks like something we/i can do outside of this patch13:51
geguileothangp: That's the whole point, you do the refresh stuff in another patch and you do it as it should be done13:52
*** breitz has quit IRC13:52
*** mtanino has joined #openstack-cinder13:52
*** breitz has joined #openstack-cinder13:52
*** BharatK has joined #openstack-cinder13:57
*** haomaiwang has quit IRC14:01
*** 7GHAA12OT has joined #openstack-cinder14:02
openstackgerritDaniel Tadrzak proposed openstack/cinder: Cleanup for cinder tests with CGSnapshot  https://review.openstack.org/20786614:03
*** jwcroppe has joined #openstack-cinder14:03
*** krtaylor has quit IRC14:07
*** asselin__ has joined #openstack-cinder14:15
*** asselin has quit IRC14:18
*** vlaza has left #openstack-cinder14:19
*** diogogmt has joined #openstack-cinder14:20
*** eharney has joined #openstack-cinder14:23
*** IanGovett has quit IRC14:24
*** diogogmt has quit IRC14:25
*** IanGovett has joined #openstack-cinder14:25
openstackgerritVincent Hou proposed openstack/cinder: Volume status management during migration  https://review.openstack.org/18631214:26
*** krtaylor has joined #openstack-cinder14:35
openstackgerritDerrick Wippler proposed openstack/python-cinderclient: No longer ignores CINDER_SERVICE_NAME  https://review.openstack.org/21480214:35
*** links has quit IRC14:37
*** yrabl has quit IRC14:38
*** salv-orlando has quit IRC14:38
openstackgerritDerrick Wippler proposed openstack/python-cinderclient: Fixed test_password_prompted  https://review.openstack.org/21470414:40
*** diablo_rojo has quit IRC14:42
*** wilson2 has quit IRC14:44
*** wilson has joined #openstack-cinder14:45
wilsonhemnafk: hi14:46
wilsonhemnakf: I have addressed your comments at patch https://review.openstack.org/#/c/201578/14:46
wilsonhemnafk: please check if it's ok, thanks!14:48
*** dustins has quit IRC14:48
*** dims has quit IRC14:51
nikeshmthe last item in the dictionary should have a trailing comma, but in many places in cinder code, this rule is not followed14:51
nikeshmhttp://docs.openstack.org/developer/hacking/#dictionaries-lists14:51
*** dims has joined #openstack-cinder14:51
smcginnisnikeshm: Yeah, I was enforcing that in reviews for a while but decided I didn't really care. :)14:52
smcginnisIt's kind of a trivial guideline in my opinion.14:52
smcginnisThe only benefit I see (or that's given) is that if you add to a dictionary it will show up in stats as a one line change instead of two.14:53
smcginnisDoesn't seem that compelling to me to enforce.14:53
nikeshmsmcginnis: ok thanks14:53
smcginnisThat's just my opinion of course.14:53
nikeshmhmm14:53
openstackgerritYuriy Nesenenko proposed openstack/cinder: Add retries to delete a volume in the RBD driver  https://review.openstack.org/21774614:53
*** afazekas_ has joined #openstack-cinder14:54
*** jaypipes has joined #openstack-cinder14:55
*** dustins has joined #openstack-cinder14:57
yuriy_n17geguileo: Hi! Please review https://review.openstack.org/#/c/217746/14:58
yuriy_n17smcginnis: Hi! Please review https://review.openstack.org/#/c/217746/14:59
*** 7GHAA12OT has quit IRC15:01
*** jdurgin1 has joined #openstack-cinder15:01
*** haomaiwa_ has joined #openstack-cinder15:02
*** krtaylor has quit IRC15:02
*** hemnafk is now known as hemna15:03
*** edtubill has joined #openstack-cinder15:03
*** nkrinner has quit IRC15:03
openstackgerritMichal Dulko proposed openstack/cinder: Validate filters in snapshot*, backup* in db.api  https://review.openstack.org/21711015:03
*** xiaohui has quit IRC15:03
*** xiaohui has joined #openstack-cinder15:04
*** martyturner1 has quit IRC15:05
*** ronis_ has quit IRC15:08
smcginnisyuriy_n17: No need to explicitly add reviewers and ping them on each patch.15:10
smcginnisyuriy_n17: Cores will eventually get to reviewing them.15:10
smcginnisyuriy_n17: Save the pinging for when you have a critical patch you really need attention on. :)15:11
yuriy_n17smcginnis: Thanks a lot.15:12
openstackgerritYuriy Nesenenko proposed openstack/cinder: Add retries to delete a volume in the RBD driver  https://review.openstack.org/21774615:13
openstackgerritJon Bernard proposed openstack/cinder: Add support for file I/O volume migration  https://review.openstack.org/18727015:15
*** wilson has quit IRC15:17
openstackgerritAlex O'Rourke proposed openstack/cinder: LeftHand: Adding Consistency Group Support  https://review.openstack.org/21438615:17
*** lcurtis has joined #openstack-cinder15:18
*** wilson has joined #openstack-cinder15:18
Guest54162e0ne: ping15:18
Guest54162baaahhhhh!!!!15:18
*** Guest54162 is now known as jgriffith15:18
*** jgriffith is now known as Guest2815915:19
Guest28159e0ne: You gave this a -1: https://review.openstack.org/#/c/189588/115:19
Guest28159e0ne: but I see no comment as to why?15:19
Guest28159Ahh... wait, I see it :)15:19
Guest28159NM15:19
dulekyuriy_n17: Hey, thanks for review, it's quite embarrassing I've left that there. ;)15:22
*** links has joined #openstack-cinder15:22
yuriy_n17dulek: no problem ;)15:24
openstackgerritMichal Dulko proposed openstack/cinder: Validate filters in snapshot*, backup* in db.api  https://review.openstack.org/21711015:25
*** afazekas_ has quit IRC15:27
*** dustins has quit IRC15:28
hemnaxyang1, ping15:28
xyang1hemna: Hi15:29
hemnaxyang1, mriedem  can we get this guy in today? https://review.openstack.org/#/c/207553/15:29
xyang1hemna: Looks good to me15:30
*** asselin__ has quit IRC15:30
openstackgerritTom Barron proposed openstack/cinder: NetApp DOT block driver over-subscription support  https://review.openstack.org/21586515:33
hemnatbarron, did you need any brick help w/ the backup work you are doing?  I know you had mentioned it a bit at the midcycle15:33
tbarronhemna: I will for sure, but that work has slipped to start of M.15:34
hemnatbarron, ok.   If you need any help, let me know15:34
tbarronhemna: I got assigned other work for L3 ....15:34
tbarronhemna: I will, and thanks very much for the offer!!!15:34
hemnadecoupling from the drivers seems like a really good idea to me.15:34
*** afazekas_ has joined #openstack-cinder15:35
*** asselin has joined #openstack-cinder15:36
tbarronhemna: I appreciate the endorsement of the idea.  I think we can do some api-race fixing in backup (for both backup and volume opbjects) as part of this too, using the new compaere-and-swap.15:36
*** tsekiyama has joined #openstack-cinder15:36
tbarroncompare15:36
*** asselin__ has joined #openstack-cinder15:36
hemnatbarron, I think it's also worth noting that some of that effort also should be aware of the 'ing' checking effort in the API ?15:37
*** changbl has quit IRC15:37
tbarronhemna: I agree, from what I understand of that.  Need to learn more.15:37
openstackgerritThang Pham proposed openstack/cinder: Register RPC and object versions  https://review.openstack.org/20970115:39
*** mewald has quit IRC15:40
*** asselin has quit IRC15:40
*** skylerberg has joined #openstack-cinder15:40
*** ccesario has quit IRC15:41
*** anshul has quit IRC15:41
*** asselin__ has quit IRC15:42
*** bnemec has joined #openstack-cinder15:42
*** jdurgin has quit IRC15:43
*** changbl has joined #openstack-cinder15:44
*** jdurgin has joined #openstack-cinder15:44
smcginnisThis has become software defined: http://snag.gy/wJjt9jpg15:47
smcginnisSeems like an appropriate picture given the state of some of our code. ;)15:47
hemnathe yellow wire is wrong15:47
smcginnisFrom OpenStackSV15:47
*** BharatK has quit IRC15:47
smcginnishemna: Yeah, where's the standardization on cable colors?!15:48
*** andreykurilin__ has joined #openstack-cinder15:48
*** Apoorva has joined #openstack-cinder15:48
hemnawire_ v. wire:15:48
*** diablo_rojo has joined #openstack-cinder15:48
smcginnis;)15:48
*** rushil has quit IRC15:50
*** afazekas_ has quit IRC15:50
*** changbl has quit IRC15:51
*** wilson has quit IRC15:52
*** alexschm has quit IRC15:52
*** wilson has joined #openstack-cinder15:52
*** markstur_ has joined #openstack-cinder15:53
*** markstur has quit IRC15:54
*** Guest28159 has quit IRC15:54
*** jgriffit1 has joined #openstack-cinder15:55
*** haomaiwa_ has quit IRC16:01
*** haomaiwa_ has joined #openstack-cinder16:02
*** haomaiwa_ has quit IRC16:06
*** afazekas_ has joined #openstack-cinder16:08
*** ccesario has joined #openstack-cinder16:10
*** changbl has joined #openstack-cinder16:10
*** sgotliv has quit IRC16:11
openstackgerritTom Swanson proposed openstack/cinder: Dell SC: init_volume stale volume info fix  https://review.openstack.org/21685916:13
*** timcl has quit IRC16:14
*** jgriffit1 has quit IRC16:14
*** jgriffit1 has joined #openstack-cinder16:15
*** e0ne has quit IRC16:18
*** lpetrut1 has quit IRC16:20
*** jgriffith has joined #openstack-cinder16:22
*** jgriffith is now known as Guest6747416:22
*** yuriy_n17 has quit IRC16:22
*** jistr has quit IRC16:24
*** dustins has joined #openstack-cinder16:24
*** bluex-pl has quit IRC16:24
*** eharney has quit IRC16:26
*** _cjones_ has joined #openstack-cinder16:26
*** garthb_ has joined #openstack-cinder16:26
*** garthb has joined #openstack-cinder16:26
*** garthb has quit IRC16:27
*** leeantho has joined #openstack-cinder16:27
openstackgerritWilson Liu proposed openstack/cinder: Enhance FC zone support for Huawei driver  https://review.openstack.org/20157816:27
*** afazekas_ has quit IRC16:27
*** sghanekar has joined #openstack-cinder16:28
*** dannywilson has joined #openstack-cinder16:29
*** dannywilson has quit IRC16:29
*** dannywilson has joined #openstack-cinder16:29
*** salv-orlando has joined #openstack-cinder16:29
*** stefan_amann has quit IRC16:31
*** sghanekar has quit IRC16:32
*** annegentle has quit IRC16:33
*** jdurgin1 has quit IRC16:34
*** p0rtal_ has joined #openstack-cinder16:35
*** Guest67474 is now known as jgriffith16:38
*** mdenny has quit IRC16:38
*** mdenny has joined #openstack-cinder16:38
*** p0rtal has quit IRC16:39
*** boris-42 has joined #openstack-cinder16:39
*** p0rtal_ has quit IRC16:39
*** jgriffit1 has quit IRC16:39
*** zhenguo has quit IRC16:41
*** skylerberg has quit IRC16:44
*** jordanP has quit IRC16:44
*** links has quit IRC16:45
*** ndipanov has quit IRC16:50
*** annegentle has joined #openstack-cinder16:51
*** annegentle has quit IRC16:51
*** EinstCrazy has joined #openstack-cinder16:51
*** afazekas_ has joined #openstack-cinder16:52
*** krtaylor has joined #openstack-cinder16:52
*** sghanekar has joined #openstack-cinder16:53
hemnasmcginnis, got a second ?16:54
*** annegentle has joined #openstack-cinder16:54
openstackgerritWalter A. Boring IV (hemna) proposed openstack/os-brick: FC Stop calling multipath command line  https://review.openstack.org/21338916:55
*** harlowja has joined #openstack-cinder16:55
*** timcl has joined #openstack-cinder16:56
*** rhe00 has quit IRC16:57
*** aix has quit IRC16:58
*** rhe00 has joined #openstack-cinder16:58
*** mudassirlatif has joined #openstack-cinder16:59
*** jordanP has joined #openstack-cinder17:00
*** jgriffith_ has joined #openstack-cinder17:00
*** yrabl has joined #openstack-cinder17:01
*** rhe00 has quit IRC17:03
*** lpetrut has joined #openstack-cinder17:03
*** lpetrut has quit IRC17:03
*** jgriffith has quit IRC17:03
*** jgriffith_ is now known as jgriffith17:03
*** lpetrut has joined #openstack-cinder17:04
*** sidbhatt13 has joined #openstack-cinder17:04
*** rhe00 has joined #openstack-cinder17:04
*** vilobhmm1 has joined #openstack-cinder17:05
*** lpetrut has left #openstack-cinder17:06
*** afazekas_ has quit IRC17:07
*** diablo_rojo has quit IRC17:08
*** eharney has joined #openstack-cinder17:09
*** afazekas_ has joined #openstack-cinder17:09
openstackgerritWalter A. Boring IV (hemna) proposed openstack/os-brick: iSCSI fix misleading Log warning on connect fail  https://review.openstack.org/21780217:10
*** garthb has joined #openstack-cinder17:10
*** garthb_ has quit IRC17:10
*** crose has joined #openstack-cinder17:11
*** afazekas_ has quit IRC17:15
*** setmason has joined #openstack-cinder17:17
*** ronis_ has joined #openstack-cinder17:18
openstackgerritAndrey Pavlov proposed openstack/cinder: test  https://review.openstack.org/21780917:19
*** bnemec has quit IRC17:21
jbernardis anyone working on the vmware backing_from_stream_optimized_file failure?17:23
*** afazekas_ has joined #openstack-cinder17:27
jgriffithjbernard: not that I'm aware of17:32
jbernardjgriffith: ive done a few runs to try to reproduce, but no luck yet17:33
jbernardjgriffith: seems to fail every now and then in the gate17:33
*** mriedem1 has joined #openstack-cinder17:33
thrawn01hey guys I was looking at taking on, https://bugs.launchpad.net/cinder/+bug/1415241  but I'm not sure what the error is in the example. it's non obvious to me =/17:34
openstackLaunchpad bug 1415241 in Cinder "cinder hacking checks don't cover logging format string arg count" [Undecided,New] - Assigned to Scott DAngelo (scott-dangelo)17:34
*** dflorea has joined #openstack-cinder17:34
*** mriedem has quit IRC17:36
*** annegentle has quit IRC17:36
*** dflorea has quit IRC17:38
scottdathrawn01: the args are in parenthesis, so there is only one arg being passed in, instead of 217:39
*** dflorea has joined #openstack-cinder17:39
thrawn01scottda: I suspected that might be the case, I was just about to test it. thanks!17:40
*** e0ne has joined #openstack-cinder17:45
*** dflorea has quit IRC17:45
*** p0rtal has joined #openstack-cinder17:47
*** afazekas_ has quit IRC17:48
*** EinstCrazy has quit IRC17:48
*** dflorea has joined #openstack-cinder17:57
*** dflorea has quit IRC18:00
*** garthb has quit IRC18:01
*** garthb has joined #openstack-cinder18:02
*** merooney has quit IRC18:02
smcginnishemna: Still around?18:03
hemnayuh18:03
smcginnishemna: Just got back from back to back meetings. I'll catch up in a bit.18:04
hemnano worries18:04
*** merooney has joined #openstack-cinder18:04
openstackgerritGoutham Pacha Ravi proposed openstack/cinder: Add parameter to filter pools for NetApp driver  https://review.openstack.org/21058818:06
*** garthb has quit IRC18:09
*** ociuhandu has quit IRC18:11
openstackgerritAlex O'Rourke proposed openstack/cinder: LeftHand: Adding Consistency Group Support  https://review.openstack.org/21438618:14
*** crose has quit IRC18:14
*** DTadrzak has quit IRC18:17
*** takedakn1 has quit IRC18:22
*** sidbhatt13 has quit IRC18:23
*** annegentle has joined #openstack-cinder18:24
*** annegentle has quit IRC18:25
*** zhonghua-li has joined #openstack-cinder18:27
*** crose has joined #openstack-cinder18:27
*** zhonghua-lee has quit IRC18:30
*** crose has quit IRC18:33
openstackgerritAlex O'Rourke proposed openstack/cinder: LeftHand: Adding Consistency Group Support  https://review.openstack.org/21438618:36
*** zhonghua has joined #openstack-cinder18:39
*** cpallares has quit IRC18:40
*** zhonghua-li has quit IRC18:41
*** zhonghua-lee has joined #openstack-cinder18:42
*** zhonghua has quit IRC18:44
*** cpallares has joined #openstack-cinder18:46
*** annegentle has joined #openstack-cinder18:46
*** shyama has quit IRC18:49
*** crose has joined #openstack-cinder18:52
*** e0ne has quit IRC18:53
*** garthb has joined #openstack-cinder18:56
*** rushil has joined #openstack-cinder18:56
tbarronjbernard: I've been unable to reproduce it locally.  One thing I notice is that there are two such tests, in different classes.18:58
tbarronjbernard: 'open' is mocked differently in the two.  In one case, six.moves.open is mocked IIRC; in the other, a vmware.vmdk.open()18:59
openstackgerritYuriy Nesenenko proposed openstack/cinder: Add retries to delete a volume in the RBD driver  https://review.openstack.org/21774618:59
tbarronjbernard: may not be a clue.  I put an assert in both methods to see if somehow the mocked open method wasn't getting called.19:00
tbarronjbernard: but in both cases I saw the mocked open called the expected number of times.19:00
tbarronjbernard: that was all local.  Note that the (mocked) delete is called both in the exception path of the first part of the test, and in the second (negative) part of the test.19:02
tbarronjbernard: these are combined positive and negative case tests, which I would have rather seen separated.19:03
eharneytbarron: the error looks to me like something isn't mocked right, and looking at _test_create_backing_from_stream_optimized_file... that wouldn't be too surprising19:05
eharneyit looks worryingly complicated19:05
tbarroneharney: yeah, patrickeast and I were looking last night but couldn't figure the mock-out failure.19:06
tbarroneharney: but certainly it must be that.19:06
patrickeastmaybe we should just delete the test and file a vmware bug XD19:06
* patrickeast is only half joking19:06
tbarroneharney: this is IMO a way over-complicated unit test.  I'd like unit tests to be plain dumb simple, not "clever"19:07
eharneya test with that many mocks and sentinels in it needs to be redone somehow19:07
*** merooney has quit IRC19:07
tbarroneharney: =100019:07
tbarron+100019:07
tbarronpatrickeast: it's not a bad idea given that it's an unproductive time sink.19:09
eharneytbarron: has this hit many times?19:11
*** aix has joined #openstack-cinder19:11
tbarroneharney: mtanino, patrickeast, and my folks have hit it.  In the latter case, several times in the last few days.19:11
mtaninoyes...19:12
tbarroneharney: I can file a bug whining about hitting the issue intermittently.19:12
eharneyi'd lean more toward patrickeast's idea because i don't think anyone is going to look at that and know how to fix it very quickly19:13
*** skylerberg has joined #openstack-cinder19:14
*** simondodsley has quit IRC19:17
tbarronvilobhmm1: are you the person to talk to about vmware.vmdk unit tests?19:18
tbarronvilobhmm1: never mind - I've got the wrong nic!!! sorry.19:19
thangptbarron: it's vipin19:19
thangptbarron: but he's in india19:20
tbarronthangp: thanks, don't see him on ...19:20
vilobhmm1tbarron : I don't think so19:20
tbarronthangp: slacker :-)19:20
tbarronvilobhmm1: sorry about that!19:20
vilobhmm1tbarron : np :)19:20
tbarronI had too many nicks in my 'v' hash bucket.19:20
openstackgerritMitsuhiro Tanino proposed openstack/cinder: Adds framework for get_capabilities() feature  https://review.openstack.org/20124319:21
*** JebAka has joined #openstack-cinder19:21
openstackgerritMitsuhiro Tanino proposed openstack/cinder: Efficient volume copy for generic volume migration  https://review.openstack.org/18370119:21
jbernardeharney: ive hit it 3 or 4 times in the last two days19:22
openstackgerritMitsuhiro Tanino proposed openstack/cinder: Allow specified backend capabilities to be retrieved  https://review.openstack.org/21286119:22
jbernardpatrickeast: would i be hated if i submitted that patch? :) given the time to recheck and the frequency of failure, it doesn't seem like a bad idea to me19:23
patrickeastjbernard: haha i doubt it, i would give it a +119:24
tbarronjbernard: I'll +1.  I'd do it myself it wouldn't take a week to show up :-)19:25
jbernardi was thinking just remove the test and file a bug against the driver19:26
jbernardactually, i think there is already a bug for it19:26
*** rushil has quit IRC19:26
openstackgerritEdmund Rhudy proposed openstack/cinder: Adds allow_availability_zone_fallback option to Cinder  https://review.openstack.org/21785719:29
eharneyjordanP: are you sure you don't need a new os-brick release for https://review.openstack.org/#/c/200610/ to move along?19:30
jordanPeharney, for now my CI has been working with the "git" version of os-brick19:31
jordanPso it can wait19:31
openstackgerritEdmund Rhudy proposed openstack/cinder: Adds allow_availability_zone_fallback option to Cinder  https://review.openstack.org/21785719:31
*** esker has joined #openstack-cinder19:31
eharneyjordanP: i'm wondering if that's why it's stuck, though19:32
jordanPeharney, yeah... I wonder myself too...19:32
eharneyjordanP: i think that happens when depends-on can't be resolved correctly, which it maybe can't, because i think the gate uses released libs for brick?19:32
jordanPeharney, do you know if there's a difference betweek "recheck" and "reverify" nowadays ?19:33
eharneyjordanP: there's not19:33
jordanPok19:33
eharneyjordanP: but yeah, i suspect you'll have to have a release and bump requirements.txt for that to work :/19:33
jordanPbut in the gate, my "code" is actually not executed, only the unit tests19:34
eharneywell, it may be possible to land it if you remove the Depends-On19:34
*** jungleboyj has joined #openstack-cinder19:35
jordanPeharney, if I just change the commit message I won't lose my +A right ?19:35
jordanP(fingers crossed...)19:36
eharneyjordanP: i think you will, but i'll just re-add it if there aren't code changes19:36
*** annegentle has quit IRC19:36
*** annegentle has joined #openstack-cinder19:37
jordanPeharney, ok, doing that now then19:37
*** e0ne has joined #openstack-cinder19:37
eharneyjordanP: the last sofs CI there shows aborted btw19:38
jordanPeharney, yeah, we are discssing this issue right now in #openstack-qa19:38
eharneyjordanP: ah, ok19:39
jordanPit's a tempest bug actually19:39
openstackgerritJordan Pittier proposed openstack/cinder: Rework Scality SOFS driver to use RemoteFS class  https://review.openstack.org/20061019:40
jordanPeharney, the reason I had to "silent" my CI: https://review.openstack.org/#/c/217804/ fyi19:42
eharneyjordanP: well that's fun19:44
jordanPnot really :p...19:44
*** skylerberg has quit IRC19:44
openstackgerritEdmund Rhudy proposed openstack/cinder: Adds allow_availability_zone_fallback option to Cinder  https://review.openstack.org/21785719:48
*** IanGovett has quit IRC19:51
*** pots has quit IRC19:55
openstackgerritDanny Wilson proposed openstack/cinder: Replication V2 for Pure Storage  https://review.openstack.org/21482520:00
openstackgerritxing-yang proposed openstack/cinder: Allow CG without snapshot to be deleted  https://review.openstack.org/21389220:02
*** merooney has joined #openstack-cinder20:02
*** Lee1092 has quit IRC20:03
*** esker has quit IRC20:04
*** xyang1 has quit IRC20:06
*** esker has joined #openstack-cinder20:08
*** mudassirlatif_ has joined #openstack-cinder20:08
*** rushil has joined #openstack-cinder20:09
*** kvidvans has joined #openstack-cinder20:09
openstackgerritEric Harney proposed openstack/cinder: Remove driver.set_execute()  https://review.openstack.org/21736420:10
*** mudassirlatif has quit IRC20:10
*** mudassirlatif_ is now known as mudassirlatif20:10
*** martyturner has joined #openstack-cinder20:12
*** esker has quit IRC20:13
*** e0ne has quit IRC20:13
*** sghanekar_ has joined #openstack-cinder20:14
*** ronis_ has quit IRC20:14
*** sghanekar has quit IRC20:15
*** eharney has quit IRC20:15
*** mriedem1 is now known as mriedem20:17
*** p0rtal_ has joined #openstack-cinder20:21
*** rhagarty__ has quit IRC20:23
*** rhagarty_ has quit IRC20:23
*** p0rtal has quit IRC20:24
openstackgerritJon Bernard proposed openstack/cinder: Skip intermittent VMDK tests  https://review.openstack.org/21788220:24
jbernardpatrickeast, tbarron ^20:25
tbarronjbernard: +1 from me.  Thanks.20:28
*** rhagarty has joined #openstack-cinder20:29
*** rhagarty_ has joined #openstack-cinder20:30
*** JoeStack has quit IRC20:30
*** markvoelker has quit IRC20:33
*** dustins has quit IRC20:34
*** kvidvans has quit IRC20:39
openstackgerritAnna Sortland proposed openstack/cinder: Earlier authority check for create volume API  https://review.openstack.org/21789920:39
hemnaI thought reverify was for gate jobs only ?20:40
*** IlyaG has joined #openstack-cinder20:41
jungleboyjhemna: ++20:41
*** jlk has joined #openstack-cinder20:44
patrickeasthemna: its kind of arbitrary, the official jenkins zuul config will do the same thing for recheck/reverify iirc20:44
jlkI'm in need of a clue bat. How does the cinder-volume service accept tasks? (things in volume/manager.py)20:44
patrickeasthemna: and a bunch of other CI systems do the same thing20:44
hemnaugh20:44
openstackgerritAlex O'Rourke proposed openstack/cinder: LeftHand: Adding Consistency Group Support  https://review.openstack.org/21438620:45
*** krtaylor has quit IRC20:46
openstackgerritWalter A. Boring IV (hemna) proposed openstack/cinder: 3PAR update driver to store stats  https://review.openstack.org/21677120:46
*** rushil has quit IRC20:50
*** julim has quit IRC20:50
*** rushil has joined #openstack-cinder20:51
*** rushil_ has joined #openstack-cinder20:52
*** julim has joined #openstack-cinder20:54
*** rushil has quit IRC20:56
*** raildo is now known as raildo-afk20:56
tbarronjlk: not sure exactly what you are asking, but I think we do a pretty good job in chapter 4 of http://netapp.github.io/openstack-deploy-ops-guide/ explaing workflow from client requests through API over messaging bus to scheduler, cinder-volume, cinder-backup, and back, etc.20:58
tbarronjlk: maybe that will help.20:58
*** mudassirlatif has quit IRC21:02
jlktbarron: thanks that helps. I'm trying to chase an issue where during volume creation, cinder-scheduler picks a particular volume service, makes a "cast" on the service, and considers the job done.21:02
jlkOn the cinder-volume side we're not seeing a response to the request to actually make the volume21:02
*** mudassirlatif has joined #openstack-cinder21:03
jlkit appears to just be running the periodic tasks and publishing info21:03
guitarzanjlk: are you using the same cinder.conf on all your boxes?21:04
tbarronguitarzan: +121:04
jlkthere is a slight difference, the host that is running cinder-volume service has a defined backend configuration21:05
jlkwhereas the host running cinder-api and cinder-scheduler do not21:05
*** merooney has quit IRC21:05
jlkwait a sec.21:06
*** julim has quit IRC21:07
guitarzanjlk: also, does the host/service list look like you expect it to?21:07
jlkyes, the host and service list look right21:08
jlker host+service21:08
guitarzancan you see what queue c-sched is throwing messages on?21:08
jlkwhere would that info live?21:09
*** gouthamr has quit IRC21:09
tbarronjlk: you're in good hands, guitarzan may have done this a few times before :-)  I'm off to a monthly OpenStack meetup ...21:09
*** rushil_ has quit IRC21:10
jlkthere appear to be two queues for each host that's running cinder-scheduler, plus two scheduler_fanout queues.21:11
jlknone of them have any messages in them.21:11
guitarzanhmm, so someone is picking it up?21:11
*** Yogi1 has quit IRC21:11
*** IlyaG has quit IRC21:11
jlkit would appear so21:11
*** merooney has joined #openstack-cinder21:12
jlkscheduler itself is getting the messages and picking a host to build the volume on21:12
jlkit's after that where the messages seem to stop21:12
*** jordanP has quit IRC21:12
guitarzanso it isn't throwing a message out for c-vol? and it isn't complaining with a No hosts found message?21:12
jlkI see a message from scheduler like:21:13
jlk2015-08-27 21:09:26.575 9048 DEBUG cinder.openstack.common.rpc.amqp [req-144fa1c21:13
jlk7-7d75-4cf2-a1c4-78e773d4d790 e6fa6803d81749eba1c43a9966bff6b1 c08a60feec12400da21:13
jlk5badc671038b735] Making asynchronous cast on cinder-volume:ds1421@nimble... cas21:13
jlkt21:13
*** gouthamr has joined #openstack-cinder21:13
*** IlyaG_ has joined #openstack-cinder21:14
jlkafter it decides to use the host ds1421@nimble21:14
*** timcl has quit IRC21:14
guitarzanand that queue is empty in rabbit?21:16
jlkyes21:16
jlkcinder-volume.ds1421@nimble021:17
guitarzanand that c-vol doesn't look like it's doing anything with that message?21:17
jlkcorrect21:17
jlkI don't really see anything in the logs having to do with /incoming/ messages, only with running periodic tasks to generate outgoing messages.21:17
guitarzandare I ask if you have another rogue c-vol running somewhere? :)21:17
jlkI really hope not, I'll hunt around. It would be odd if there was, with the same hostname21:18
guitarzanit doesn't really have to have that hostname, just cinder.conf that thinks it is21:18
jlktrue21:19
guitarzanhere's a fun test though21:20
guitarzankill c-vol and try to create one21:20
guitarzansee if it gets thrown in that queue21:20
jlkyeah, I thought I tried this.21:20
guitarzanthat's kind of racy though, depending on how fast the scheduler kicks it out21:20
jlkright21:20
*** skylerberg has joined #openstack-cinder21:20
jlkah too slow21:21
jlkwell21:22
jlknothing showed up in the queue21:22
jlkand the status is creating21:23
jlkso maybe scheduler isn't actually putting the message out?21:24
guitarzanI've never seen anything like that before21:25
openstackgerritPatrick East proposed openstack/cinder: Generic image-volume cache  https://review.openstack.org/19579521:25
guitarzanI wonder if anyone else has any idea21:25
jlkI'm going to bounce all of rabbit and see what gets re-created21:25
guitarzanone thing I can guarantee... it's some super simple configuration problem :)21:27
jlkhah, ugh.21:27
jlkso queues got recreated, but same behavior21:28
*** rushil has joined #openstack-cinder21:28
guitarzanbut you can't catch any messages in the c-vol queue21:28
jlkoh let me stop and try the build again21:28
guitarzanare you running c-vol with debug and verbose on?21:29
*** tpsilva has quit IRC21:29
jlkyeah21:29
guitarzanok21:29
jlkso with the service stopped, a create call still gets into "creating" status, but no message in the queue21:29
guitarzanwhat does cinder service-list look like?21:31
jlkwell right now https://gist.github.com/j2sol/ee26b1fff48438b813af21:32
jlkbecause I shut off both schedulers to see if I could catch c-vol putting a message out for scheduler for a capability update21:32
jlkso weird, no message winds up in any of the queues (queue count is 0) with the schedulers turned off21:33
jlkdoes c-vol put messages in the scheduler queue?21:33
guitarzan"Notifying Schedulers of capabilities"21:34
guitarzanit should21:34
guitarzanand you don't get the "Received volume service update from <blah>" messages in the scheduler log21:35
jlkwell schedulers are turned off, so nothing in log yet21:36
jlk2015-08-27 21:37:07.687 4797 DEBUG cinder.manager [-] Notifying Schedulers of capabilities ... _publish_service_capabilities /usr/local/lib/python2.7/dist-packages/cinder/manager.py:12821:37
jlk2015-08-27 21:37:07.688 4797 DEBUG oslo_messaging._drivers.amqp [-] UNIQUE_ID is 39b7043b4eef4d348037a7071fc302be. _add_unique_id /usr/local/lib/python2.7/dist-packages/oslo_messaging/_drivers/amqp.py:22621:37
jlkwait...21:38
guitarzanI'd check rabbit config on the schedulers21:38
jlkcinder-volume, does it ever directly write to the database?21:38
guitarzanI think so21:38
jlkbecause the updated_at line in the database keeps getting updated21:38
jlkI thought only cinder-scheduler and API wrote to the db21:39
*** mriedem has quit IRC21:39
guitarzanif only it was that clean21:39
jgriffithjlk: manager does most of the db access; and there are a number of drivers sadly that have snuck in db access as well21:40
jlkso it'd be driver specific?21:40
*** crose has quit IRC21:40
openstackgerritDerrick Wippler proposed openstack/python-cinderclient: No longer ignores CINDER_SERVICE_NAME  https://review.openstack.org/21480221:40
guitarzanjlk: the service state stuff is not21:40
jgriffithjlk: so I have no idea what you guys have going on here... haven't been following; I was just answering the question about DB access :)21:41
guitarzanno talking between c-vol and c-sched21:41
guitarzaneither direction21:41
guitarzanmy guess is sched doesn't talk to rabbit21:41
guitarzanbut that's just a guess21:41
guitarzanbut he did say the sched log looked like it was doing creates21:42
guitarzanso who knows?21:42
*** annegentle has quit IRC21:45
*** krtaylor has joined #openstack-cinder21:45
*** merooney has quit IRC21:49
*** rushil has quit IRC21:50
*** gouthamr has quit IRC21:51
jbernardjungleboyj: ping re https://review.openstack.org/#/c/187270/2121:53
jbernardjungleboyj: the rpc version, i assume the race looser would rebase21:53
jungleboyjjbernard: Correct.  It was just a stream of consciousness kind of thing.  That is where I am at today.21:53
jungleboyj:-)21:53
jbernardjungleboyj: gotcha, im there most days too21:54
jungleboyj:-)21:54
jbernardjungleboyj: gate fails on vmdk, hopefull a recheck will get me past that21:54
jbernardadn i think there's a problem happening with grenade21:54
jbernardim not particularly lucky today21:55
jgriffithguitarzan: but creates are casts no?  In other words they just go into a black-hole21:55
*** merooney has joined #openstack-cinder21:55
jbernardjungleboyj: ill address the other suggestions with a patch update, thanks for the comments21:55
jgriffithguitarzan: from the schedulers perspective... although if you were correct then you'd probably see the no-valid hosts if nothing talkie talkie to each other21:55
openstackgerritJacob Gregor proposed openstack/cinder: Clean up line continuation in Storwize driver  https://review.openstack.org/21793321:56
jgriffithguitarzan: cuz there woudl be no services checking in with scheduler so he'd be hosed21:56
guitarzanjgriffith: yeah, casts do just disappear when there's no proper queue for them right?21:56
*** rushil has joined #openstack-cinder21:56
jungleboyjjbernard: Thanks for the update.  Wasn't clear to me what was going on with the check failure.  Thanks for addressing the other items.21:56
jgriffithguitarzan: I'd say yes, except the problem is it should never be cast, because it won't pass the filter to get that far to begin with21:56
guitarzanyeah, I can't see a simple reason it isn't working21:57
guitarzanjlk: do you have the sched logs from a create?21:57
*** dflorea has joined #openstack-cinder21:57
jgriffithguitarzan: so it sounds like the scheduler can "hear" the vol-service, but the vol-service can't hear the scheduler21:57
jlkguitarzan: jgriffith: so i think I might have a clue. It would appear that the host running cinder-volume is running juno code, and the hosts running cinder-api and cinder-scheduler are running havana code.21:57
jgriffithguitarzan: which is ez enough to see in the sched logs (look for updates from c-vol services)21:57
jgriffithjlk: yeah, that will certainly do it21:57
*** merooney has quit IRC21:57
guitarzanit's a little surprising that no errors or anything show up when speaking different languages21:58
jlkyeah it's totes weird21:59
guitarzanbut I've never tried that, so I don't really know21:59
*** mudassirlatif has quit IRC21:59
*** porrua has quit IRC22:00
*** gouthamr has joined #openstack-cinder22:01
*** gouthamr has quit IRC22:01
*** merooney has joined #openstack-cinder22:02
openstackgerritEric Harney proposed openstack/cinder: Tests: Fix open mock in vmdk tests  https://review.openstack.org/21793622:02
*** rhe00 has quit IRC22:02
*** merooney has quit IRC22:02
*** rushil has quit IRC22:04
*** IlyaG_ has quit IRC22:04
*** rushil has joined #openstack-cinder22:04
*** rushil_ has joined #openstack-cinder22:06
*** edtubill has left #openstack-cinder22:06
*** annegentle has joined #openstack-cinder22:07
*** IlyaG_ has joined #openstack-cinder22:08
*** IlyaG__ has joined #openstack-cinder22:09
*** rushil has quit IRC22:09
*** IlyaG_ has quit IRC22:12
*** rushil_ has quit IRC22:14
*** gouthamr has joined #openstack-cinder22:15
*** rushil has joined #openstack-cinder22:15
*** merooney has joined #openstack-cinder22:15
openstackgerritDanny Wilson proposed openstack/cinder: Fix delete_snapshot error case in Pure driver  https://review.openstack.org/21794022:16
*** gouthamr has quit IRC22:16
*** rushil_ has joined #openstack-cinder22:16
*** martyturner has quit IRC22:17
*** mudassirlatif has joined #openstack-cinder22:19
*** rushil has quit IRC22:20
*** annegentle has quit IRC22:24
*** annegentle has joined #openstack-cinder22:25
*** adrianofr has quit IRC22:27
*** IlyaG__ has quit IRC22:27
*** annegentle has quit IRC22:29
*** dflorea has quit IRC22:30
openstackgerritWalter A. Boring IV (hemna) proposed openstack/os-brick: WIP: Add new Connector APIs for path validation  https://review.openstack.org/19976422:30
*** dflorea has joined #openstack-cinder22:31
*** merooney has quit IRC22:31
*** dflorea has quit IRC22:32
*** dflorea has joined #openstack-cinder22:33
*** dflorea has quit IRC22:35
openstackgerritMitsuhiro Tanino proposed openstack/cinder-specs: Fix Get Volume Driver Capabilities Spec  https://review.openstack.org/21639422:36
*** jungleboyj has quit IRC22:37
*** annegentle has joined #openstack-cinder22:39
*** dflorea has joined #openstack-cinder22:42
*** esker has joined #openstack-cinder22:42
openstackgerritDanny Wilson proposed openstack/cinder: Fix delete_snapshot error case in Pure driver  https://review.openstack.org/21794022:47
*** thangp has quit IRC22:47
*** esker has quit IRC22:48
*** lcurtis has quit IRC22:49
*** edmondsw has quit IRC22:51
*** esker has joined #openstack-cinder22:51
*** esker has quit IRC22:56
*** gouthamr has joined #openstack-cinder22:58
*** setmason has quit IRC22:59
*** setmason has joined #openstack-cinder23:00
*** jwcroppe has quit IRC23:00
*** jwcroppe_ has joined #openstack-cinder23:03
*** rushil_ has quit IRC23:04
*** akerr is now known as akerr_away23:07
*** mriedem has joined #openstack-cinder23:08
*** jwcroppe_ has quit IRC23:09
*** jwcroppe has joined #openstack-cinder23:10
*** gouthamr has quit IRC23:11
*** hemna is now known as hemnafk23:12
*** akerr_away is now known as akerr23:12
*** bswartz has quit IRC23:13
*** akerr has quit IRC23:13
*** annegentle has quit IRC23:14
*** jwcroppe has quit IRC23:14
*** dims_ has joined #openstack-cinder23:18
*** takedakn has joined #openstack-cinder23:20
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/21544023:21
*** dims has quit IRC23:22
*** takedakn has quit IRC23:24
openstackgerritOpenStack Proposal Bot proposed openstack/python-cinderclient: Updated from global requirements  https://review.openstack.org/21091823:25
jlkguitarzan: jgriffith: version mismatch between api/scheduler and volume was absolutely what was going on.23:27
*** JebAka has quit IRC23:28
*** jaypipes has quit IRC23:31
*** dflorea has quit IRC23:33
*** bnemec has joined #openstack-cinder23:35
*** dims_ has quit IRC23:38
*** vilobhmm1 has quit IRC23:39
*** bill_az has joined #openstack-cinder23:39
*** vilobhmm1 has joined #openstack-cinder23:39
*** gouthamr has joined #openstack-cinder23:42
*** takedakn has joined #openstack-cinder23:43
*** mudassirlatif has quit IRC23:44
*** setmason has quit IRC23:44
*** vilobhmm1 has quit IRC23:46
*** mudassirlatif has joined #openstack-cinder23:46
*** dflorea has joined #openstack-cinder23:48
openstackgerritAnthony Lee proposed openstack/os-brick: Adding a tool that allows querying of LUNs  https://review.openstack.org/20419123:49
*** setmason has joined #openstack-cinder23:52
*** dflorea has quit IRC23:56

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!