Tuesday, 2019-01-29

*** tetsuro has joined #openstack-blazar00:15
*** masahito has joined #openstack-blazar01:01
*** masahito has quit IRC01:05
*** masahito has joined #openstack-blazar03:17
*** openstackgerrit has joined #openstack-blazar03:17
openstackgerritMasahito Muroi proposed openstack/blazar master: Use LOG.exception at except block in status module  https://review.openstack.org/63364803:17
*** nehaalhat has joined #openstack-blazar05:42
nehaalhatmasahito: Hi masahito san, I want to discuss with you regarding bp: https://blueprints.launchpad.net/blazar/+spec/oslo-middleware-request-id06:57
nehaalhatmasahito: after the implementation of this bp for v1, now it will return x-openstack-request-id header in response06:59
masahitonehaalhat: hi06:59
nehaalhatmasahito: also implementing request context logging, so that it will log this request_id and global_request_id in logs07:00
masahitoSounds great to me :-)07:01
openstackgerritPierre Riteau proposed openstack/blazar master: Use LOG.exception in except block in status module  https://review.openstack.org/63364807:01
nehaalhatmasahito: now for v1, it is getting logged in the logs, but for v2 also it is logging request_id in logs and as I have implemented this bp for v1 only, it will not return x-openstack-request-id header in response for v207:02
nehaalhatmasahito: the problem is that I have inherited BlazarContext class form oslo_context.RequestContext, which willl generate request_id if it is none at: https://github.com/openstack/oslo.context/blob/master/oslo_context/context.py#L272-L27307:04
nehaalhatso for v2, it logging that request_id in logs07:05
masahitoI'm not clear your problem. Is it the BP supports only v1 or both v1 and v2?07:09
nehaalhatbp supports for v1 only07:09
masahitoFrom my understand, you've already implemented the BP for v1. Additionally, your patch supports outputting the id to log message as well.07:11
masahitoIt sounds ready to review.07:11
nehaalhatfor v1 it works fine... 1) it is returning the request_id in x-openstack-request-id header in response 2) Also it logs that particular request_id which is generated by oslo_middleware in logs07:12
nehaalhatthe problem for v2 is that: as oslo_middleware will not generate request_id for v2, that will be None, so oslo_context will generate that request_id at [1] because of which it will log that request_id in logs. [1]: https://github.com/openstack/oslo.context/blob/master/oslo_context/context.py#L272-L27307:14
nehaalhatas this bp is for v1, but BlazarContext inherits oslo_context.RequestContext and it generates request_id if it is None, so for v2 the behaviour will get change07:16
nehaalhatfor v2 also user can see request_id in logs after this bp implmenation07:17
nehaalhatso I want to confirm that is it fine for v2 to log that request_id in logs, or do you have any other suggestions07:18
nehaalhatfor your reference: http://paste.openstack.org/show/744156/07:23
masahitoIs your problem the scope of the BP is only for v1 but your patch supports both v1 and v2?07:23
nehaalhatrequest context logging part is supported by both v1 and v2 after the changes for v107:24
masahitoummm... I'm still not clear your problem....07:25
nehaalhatyou can check this: http://paste.openstack.org/show/744156/07:26
masahitoDoes the paste display correct behavior you expected or not?07:26
nehaalhatthis behaviour is for v1, which is correct07:26
masahitoHow does the behavior change in v2?07:27
nehaalhatsimilarly If I request for v2, then it going to log that request_id in logs....this is change in behaviour07:27
nehaalhatbut will not return in response07:28
masahitoThat's what I'm not clear.  v1 also logs the request id.07:29
nehaalhatyes v1 logs the request_id which is generated by oslo_middleware07:30
masahitoThe problem is that v2 doesn't return request-id in current implementation and is it okay or not?07:30
masahitoIs it right?07:31
nehaalhatno...the prb is that I have not implemented this bp for v2, still it will log the request_id generated by oslo_context... so is it fine?07:35
masahitoBut the target of the BP is for v1, right?07:38
masahitoThat is my question. The BP is targeting v1 but the problem is about v2.07:40
masahitoSo what's the problem? I don't see any problem.07:41
nehaalhatthe problem is that: it will log request_id for v2.... so is it fine07:43
masahitoIf your change support v2 as well, it's really nice. So the change looks fine to me.07:44
openstackgerritTetsuro Nakamura proposed openstack/blazar-tempest-plugin master: Wait before lease status transition  https://review.openstack.org/63340808:05
openstackgerritMasahito Muroi proposed openstack/blazar master: Support on_start and on_end method in FloatinIPPlugin class  https://review.openstack.org/63295808:06
openstackgerritMasahito Muroi proposed openstack/blazar master: Support update_reservation in floatingip_plugin  https://review.openstack.org/63295908:06
openstackgerritMasahito Muroi proposed openstack/blazar master: Expose floatingip APIs and virtual:floatingip resources  https://review.openstack.org/63346208:06
openstackgerritMasahito Muroi proposed openstack/blazar master: Prevent the delete floating IP API from deleting reserved floating ips  https://review.openstack.org/63366908:06
openstackgerritMasahito Muroi proposed openstack/blazar master: Avoid negative expression in query filter  https://review.openstack.org/61572708:32
*** priteau has joined #openstack-blazar08:54
*** asmita has joined #openstack-blazar09:10
asmitamasahito: Thank you for your review on patch https://review.openstack.org/#/c/630026.I will make the changes as suggested by you.09:12
asmitamasahito: If you can find time,I request you to review patch https://review.openstack.org/#/c/632942.Thank you.09:14
openstackgerritPierre Riteau proposed openstack/blazar-dashboard master: Fix outdated link to Babel documentation  https://review.openstack.org/62434809:30
openstackgerritMerged openstack/blazar master: Fix typo in spec  https://review.openstack.org/62436709:34
openstackgerritMerged openstack/python-blazarclient master: Fix typo in exception class name  https://review.openstack.org/62560709:36
openstackgerritMerged openstack/python-blazarclient master: Use template for lower-constraints  https://review.openstack.org/62673109:37
openstackgerritMerged openstack/blazar-dashboard master: Use template for lower-constraints  https://review.openstack.org/62666909:38
openstackgerritMerged openstack/python-blazarclient master: Update hacking version  https://review.openstack.org/62766409:40
openstackgerritMerged openstack/blazar-dashboard master: Fix outdated link to Babel documentation  https://review.openstack.org/62434809:58
*** masahito has quit IRC10:21
*** masahito has joined #openstack-blazar10:52
*** masahito has quit IRC10:57
nehaalhatpriteau: Hi,  I want to discuss with you regarding bp: https://blueprints.launchpad.net/blazar/+spec/oslo-middleware-request-id11:08
nehaalhatpriteau: let me know once you are free11:08
*** masahito has joined #openstack-blazar11:31
*** masahito has quit IRC11:36
*** asmita has quit IRC11:53
priteaunehaalhat: I am afraid I am not available today. Could you send me an email with your questions?11:54
nehaalhatpriteau: ok12:07
*** nehaalhat has quit IRC12:23
tetsuropriteau: Now zuul is happy with the change in https://review.openstack.org/#/c/633408/12:28
*** tetsuro has quit IRC12:28
*** priteau has quit IRC13:04
*** priteau has joined #openstack-blazar13:04
*** priteau has quit IRC13:12
*** masahito has joined #openstack-blazar13:32
*** masahito has quit IRC13:37
*** masahito has joined #openstack-blazar15:34
*** masahito has quit IRC15:38
*** openstackgerrit has quit IRC15:51
*** masahito has joined #openstack-blazar17:35
*** masahito has quit IRC17:40
*** masahito has joined #openstack-blazar19:36
*** masahito has quit IRC19:41
*** masahito has joined #openstack-blazar21:37
*** masahito has quit IRC21:42
-openstackstatus- NOTICE: http://zuul.openstack.org is not working. https://zuul.openstack.org does work. Please use that while we investigate.23:12
*** masahito has joined #openstack-blazar23:39
*** masahito has quit IRC23:43

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!