| *** tetsuro has joined #openstack-blazar | 00:15 | |
| *** masahito has joined #openstack-blazar | 01:01 | |
| *** masahito has quit IRC | 01:05 | |
| *** masahito has joined #openstack-blazar | 03:17 | |
| *** openstackgerrit has joined #openstack-blazar | 03:17 | |
| openstackgerrit | Masahito Muroi proposed openstack/blazar master: Use LOG.exception at except block in status module https://review.openstack.org/633648 | 03:17 |
|---|---|---|
| *** nehaalhat has joined #openstack-blazar | 05:42 | |
| nehaalhat | masahito: Hi masahito san, I want to discuss with you regarding bp: https://blueprints.launchpad.net/blazar/+spec/oslo-middleware-request-id | 06:57 |
| nehaalhat | masahito: after the implementation of this bp for v1, now it will return x-openstack-request-id header in response | 06:59 |
| masahito | nehaalhat: hi | 06:59 |
| nehaalhat | masahito: also implementing request context logging, so that it will log this request_id and global_request_id in logs | 07:00 |
| masahito | Sounds great to me :-) | 07:01 |
| openstackgerrit | Pierre Riteau proposed openstack/blazar master: Use LOG.exception in except block in status module https://review.openstack.org/633648 | 07:01 |
| nehaalhat | masahito: now for v1, it is getting logged in the logs, but for v2 also it is logging request_id in logs and as I have implemented this bp for v1 only, it will not return x-openstack-request-id header in response for v2 | 07:02 |
| nehaalhat | masahito: the problem is that I have inherited BlazarContext class form oslo_context.RequestContext, which willl generate request_id if it is none at: https://github.com/openstack/oslo.context/blob/master/oslo_context/context.py#L272-L273 | 07:04 |
| nehaalhat | so for v2, it logging that request_id in logs | 07:05 |
| masahito | I'm not clear your problem. Is it the BP supports only v1 or both v1 and v2? | 07:09 |
| nehaalhat | bp supports for v1 only | 07:09 |
| masahito | From my understand, you've already implemented the BP for v1. Additionally, your patch supports outputting the id to log message as well. | 07:11 |
| masahito | It sounds ready to review. | 07:11 |
| nehaalhat | for v1 it works fine... 1) it is returning the request_id in x-openstack-request-id header in response 2) Also it logs that particular request_id which is generated by oslo_middleware in logs | 07:12 |
| nehaalhat | the problem for v2 is that: as oslo_middleware will not generate request_id for v2, that will be None, so oslo_context will generate that request_id at [1] because of which it will log that request_id in logs. [1]: https://github.com/openstack/oslo.context/blob/master/oslo_context/context.py#L272-L273 | 07:14 |
| nehaalhat | as this bp is for v1, but BlazarContext inherits oslo_context.RequestContext and it generates request_id if it is None, so for v2 the behaviour will get change | 07:16 |
| nehaalhat | for v2 also user can see request_id in logs after this bp implmenation | 07:17 |
| nehaalhat | so I want to confirm that is it fine for v2 to log that request_id in logs, or do you have any other suggestions | 07:18 |
| nehaalhat | for your reference: http://paste.openstack.org/show/744156/ | 07:23 |
| masahito | Is your problem the scope of the BP is only for v1 but your patch supports both v1 and v2? | 07:23 |
| nehaalhat | request context logging part is supported by both v1 and v2 after the changes for v1 | 07:24 |
| masahito | ummm... I'm still not clear your problem.... | 07:25 |
| nehaalhat | you can check this: http://paste.openstack.org/show/744156/ | 07:26 |
| masahito | Does the paste display correct behavior you expected or not? | 07:26 |
| nehaalhat | this behaviour is for v1, which is correct | 07:26 |
| masahito | alright. | 07:26 |
| masahito | How does the behavior change in v2? | 07:27 |
| nehaalhat | similarly If I request for v2, then it going to log that request_id in logs....this is change in behaviour | 07:27 |
| nehaalhat | but will not return in response | 07:28 |
| masahito | That's what I'm not clear. v1 also logs the request id. | 07:29 |
| nehaalhat | yes v1 logs the request_id which is generated by oslo_middleware | 07:30 |
| masahito | The problem is that v2 doesn't return request-id in current implementation and is it okay or not? | 07:30 |
| masahito | Is it right? | 07:31 |
| nehaalhat | no...the prb is that I have not implemented this bp for v2, still it will log the request_id generated by oslo_context... so is it fine? | 07:35 |
| masahito | But the target of the BP is for v1, right? | 07:38 |
| nehaalhat | yes | 07:38 |
| masahito | That is my question. The BP is targeting v1 but the problem is about v2. | 07:40 |
| nehaalhat | yes | 07:40 |
| masahito | So what's the problem? I don't see any problem. | 07:41 |
| nehaalhat | the problem is that: it will log request_id for v2.... so is it fine | 07:43 |
| masahito | If your change support v2 as well, it's really nice. So the change looks fine to me. | 07:44 |
| nehaalhat | ok | 07:45 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/blazar-tempest-plugin master: Wait before lease status transition https://review.openstack.org/633408 | 08:05 |
| openstackgerrit | Masahito Muroi proposed openstack/blazar master: Support on_start and on_end method in FloatinIPPlugin class https://review.openstack.org/632958 | 08:06 |
| openstackgerrit | Masahito Muroi proposed openstack/blazar master: Support update_reservation in floatingip_plugin https://review.openstack.org/632959 | 08:06 |
| openstackgerrit | Masahito Muroi proposed openstack/blazar master: Expose floatingip APIs and virtual:floatingip resources https://review.openstack.org/633462 | 08:06 |
| openstackgerrit | Masahito Muroi proposed openstack/blazar master: Prevent the delete floating IP API from deleting reserved floating ips https://review.openstack.org/633669 | 08:06 |
| openstackgerrit | Masahito Muroi proposed openstack/blazar master: Avoid negative expression in query filter https://review.openstack.org/615727 | 08:32 |
| *** priteau has joined #openstack-blazar | 08:54 | |
| *** asmita has joined #openstack-blazar | 09:10 | |
| asmita | masahito: Thank you for your review on patch https://review.openstack.org/#/c/630026.I will make the changes as suggested by you. | 09:12 |
| asmita | masahito: If you can find time,I request you to review patch https://review.openstack.org/#/c/632942.Thank you. | 09:14 |
| openstackgerrit | Pierre Riteau proposed openstack/blazar-dashboard master: Fix outdated link to Babel documentation https://review.openstack.org/624348 | 09:30 |
| openstackgerrit | Merged openstack/blazar master: Fix typo in spec https://review.openstack.org/624367 | 09:34 |
| openstackgerrit | Merged openstack/python-blazarclient master: Fix typo in exception class name https://review.openstack.org/625607 | 09:36 |
| openstackgerrit | Merged openstack/python-blazarclient master: Use template for lower-constraints https://review.openstack.org/626731 | 09:37 |
| openstackgerrit | Merged openstack/blazar-dashboard master: Use template for lower-constraints https://review.openstack.org/626669 | 09:38 |
| openstackgerrit | Merged openstack/python-blazarclient master: Update hacking version https://review.openstack.org/627664 | 09:40 |
| openstackgerrit | Merged openstack/blazar-dashboard master: Fix outdated link to Babel documentation https://review.openstack.org/624348 | 09:58 |
| *** masahito has quit IRC | 10:21 | |
| *** masahito has joined #openstack-blazar | 10:52 | |
| *** masahito has quit IRC | 10:57 | |
| nehaalhat | priteau: Hi, I want to discuss with you regarding bp: https://blueprints.launchpad.net/blazar/+spec/oslo-middleware-request-id | 11:08 |
| nehaalhat | priteau: let me know once you are free | 11:08 |
| *** masahito has joined #openstack-blazar | 11:31 | |
| *** masahito has quit IRC | 11:36 | |
| *** asmita has quit IRC | 11:53 | |
| priteau | nehaalhat: I am afraid I am not available today. Could you send me an email with your questions? | 11:54 |
| nehaalhat | priteau: ok | 12:07 |
| *** nehaalhat has quit IRC | 12:23 | |
| tetsuro | priteau: Now zuul is happy with the change in https://review.openstack.org/#/c/633408/ | 12:28 |
| *** tetsuro has quit IRC | 12:28 | |
| *** priteau has quit IRC | 13:04 | |
| *** priteau has joined #openstack-blazar | 13:04 | |
| *** priteau has quit IRC | 13:12 | |
| *** masahito has joined #openstack-blazar | 13:32 | |
| *** masahito has quit IRC | 13:37 | |
| *** masahito has joined #openstack-blazar | 15:34 | |
| *** masahito has quit IRC | 15:38 | |
| *** openstackgerrit has quit IRC | 15:51 | |
| *** masahito has joined #openstack-blazar | 17:35 | |
| *** masahito has quit IRC | 17:40 | |
| *** masahito has joined #openstack-blazar | 19:36 | |
| *** masahito has quit IRC | 19:41 | |
| *** masahito has joined #openstack-blazar | 21:37 | |
| *** masahito has quit IRC | 21:42 | |
| -openstackstatus- NOTICE: http://zuul.openstack.org is not working. https://zuul.openstack.org does work. Please use that while we investigate. | 23:12 | |
| *** masahito has joined #openstack-blazar | 23:39 | |
| *** masahito has quit IRC | 23:43 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!