| *** gecong_ has joined #openstack-blazar | 00:59 | |
| *** hiro-kobayashi has joined #openstack-blazar | 01:06 | |
| *** openstackgerrit has joined #openstack-blazar | 02:51 | |
| openstackgerrit | Hiroaki Kobayashi proposed openstack/blazar master: Add migration code for updating lease status https://review.openstack.org/536649 | 02:51 |
|---|---|---|
| gecong_ | hiro-kobayahi ping | 02:58 |
| openstackgerrit | Hiroaki Kobayashi proposed openstack/blazar master: Add a document about the state machine https://review.openstack.org/532402 | 03:09 |
| openstackgerrit | Hiroaki Kobayashi proposed openstack/blazar master: Add a release note of the state machine https://review.openstack.org/532403 | 03:09 |
| *** hiro-kobayashi has quit IRC | 03:24 | |
| *** gecong_ has quit IRC | 03:24 | |
| *** masahito has joined #openstack-blazar | 07:09 | |
| openstackgerrit | Masahito Muroi proposed openstack/blazar master: Spec: Suport multi availability zones https://review.openstack.org/524168 | 07:36 |
| *** masahito_ has joined #openstack-blazar | 07:36 | |
| *** masahit__ has joined #openstack-blazar | 07:39 | |
| *** masahito has quit IRC | 07:40 | |
| *** masahito_ has quit IRC | 07:42 | |
| *** masahit__ has quit IRC | 08:12 | |
| *** hiro-kobayashi has joined #openstack-blazar | 08:19 | |
| openstackgerrit | Hiroaki Kobayashi proposed openstack/blazar master: Add hosts operations to the API reference https://review.openstack.org/530065 | 08:28 |
| *** masahito has joined #openstack-blazar | 08:57 | |
| *** priteau has joined #openstack-blazar | 09:02 | |
| openstackgerrit | Pierre Riteau proposed openstack/blazar master: Add DevStack gate jobs for Python3 https://review.openstack.org/533543 | 09:10 |
| openstackgerrit | Pierre Riteau proposed openstack/blazar master: Add a document about the state machine https://review.openstack.org/532402 | 09:23 |
| openstackgerrit | Pierre Riteau proposed openstack/blazar master: Add a release note of the state machine https://review.openstack.org/532403 | 09:24 |
| openstackgerrit | Pierre Riteau proposed openstack/blazar master: Add migration code for updating lease status https://review.openstack.org/536649 | 09:26 |
| openstackgerrit | Pierre Riteau proposed openstack/blazar master: Spec: Support multi availability zones https://review.openstack.org/524168 | 09:27 |
| openstackgerrit | Merged openstack/python-blazarclient master: Align json indents https://review.openstack.org/533506 | 09:35 |
| *** bertys has joined #openstack-blazar | 10:03 | |
| priteau | masahito: I didn't realize we had API schema tests in Tempest, where are they? | 10:03 |
| masahito | priteau: I think Blazar hasn't have the tests never. | 10:04 |
| priteau | So we only have the scenarios, right? | 10:04 |
| masahito | When we revived Blazar, I saw only one scenario test that creates one host reservation. | 10:04 |
| masahito | priteau: yes. | 10:05 |
| bertys | right. They should be added to blazar-tempest-plugin/tests/api | 10:05 |
| priteau | And for scenarios, we could use blazarclient? | 10:05 |
| masahito | yes. I implemented tempest's blazar client to test both API and scenario with one scenario test in early stage. | 10:06 |
| priteau | I understand better now | 10:10 |
| masahito | Added this on Rocky PTG etherpad. | 10:10 |
| masahito | priteau, hiro-kobayashi, bertys: I can't mention it in this weekly meeting... I received our official mascot pictures. | 10:11 |
| masahito | s/can't/forgot/ | 10:12 |
| priteau | Great! | 10:12 |
| masahito | You can download it here. | 10:12 |
| masahito | https://www.dropbox.com/sh/cs6fdtt2bthzb3m/AABz7Am_XqLZVdokg_8hbZ9ra?dl=0 | 10:12 |
| masahito | I'm not sure how long the link is active. So please download it if needed :-> | 10:13 |
| priteau | Will there be stickers at the PTG? | 10:13 |
| masahito | maybe... | 10:13 |
| hiro-kobayashi | Nice! | 10:13 |
| masahito | In previous PTG, there were stickers at PTG reception desk. | 10:14 |
| bertys | masahito: Nice! are you planning to sign up to PTG interview? | 10:14 |
| masahito | And a sign with the mascot in front of meeting room. | 10:15 |
| masahito | bertys: what's that? | 10:15 |
| bertys | masahito: let me find the link | 10:15 |
| masahito | bertys: I can't read mail today because of technical issue in my office. | 10:15 |
| bertys | #link https://docs.google.com/spreadsheets/d/1MK7rCgYXCQZP1AgQ0RUiuc-cEXIzW5RuRzz5BWhV4nQ/edit#gid=1679980237 | 10:16 |
| masahito | It's announced in the ML? | 10:17 |
| masahito | I'll check it later and sign Blazar there. | 10:19 |
| bertys | See e.g. https://wiki.openstack.org/wiki/PTG/Rocky/Etherpads | 10:19 |
| masahito | bertys: thanks. | 10:20 |
| masahito | We planned to have review meeting today. It's okay to start? | 10:20 |
| hiro-kobayashi | I'm okay | 10:21 |
| masahito | I didn't have much time to push codes after last review meeting. | 10:22 |
| masahito | Today's items are mainly resource-monitoring and python-3 | 10:22 |
| masahito | hiro-kobayashi: Do you have other patches for review? | 10:22 |
| hiro-kobayashi | few patches for state-machine | 10:23 |
| masahito | got it. | 10:24 |
| masahito | starts with at least to review. Which patch is for state-machine? I don't see branch named state-machine. | 10:26 |
| hiro-kobayashi | https://review.openstack.org/#/q/status:open+project:openstack/blazar+branch:master+topic:bp/state-machine | 10:26 |
| hiro-kobayashi | I've pushed a patch for migration from older version: https://review.openstack.org/#/c/536649/ | 10:27 |
| hiro-kobayashi | Other 2 patches a about documentation. | 10:27 |
| masahito | looks like my query is wrong. I can't see the 2 patches for docs. | 10:27 |
| hiro-kobayashi | OK | 10:28 |
| hiro-kobayashi | doc: https://review.openstack.org/#/c/532402/ | 10:28 |
| hiro-kobayashi | https://review.openstack.org/#/c/532403/ | 10:28 |
| hiro-kobayashi | second one is release note | 10:28 |
| hiro-kobayashi | I'll push one more patch which change status literal to status object. e.g. 'pending' to blazar.status.reservation.PENDING. | 10:29 |
| hiro-kobayashi | I found some status literals in resource plugins code. | 10:29 |
| hiro-kobayashi | Then, this bp will be completed. | 10:29 |
| hiro-kobayashi | Oh, and this patch https://review.openstack.org/#/c/526235/ for blazar-dashboard. It removes action and status_reason fields. | 10:31 |
| masahito | Lots of patches. | 10:33 |
| masahito | :-) | 10:33 |
| masahito | Questions for migration codes. | 10:33 |
| hiro-kobayashi | Sorry I said few... | 10:33 |
| hiro-kobayashi | masahito: ok | 10:33 |
| masahito | We can add the codes in migration codes. If so, the upgrade and downgrade script works for state-machine. | 10:35 |
| hiro-kobayashi | Do you mean alembic migration code? | 10:35 |
| masahito | yes | 10:36 |
| hiro-kobayashi | I could not find how to update existing field by alembic. | 10:36 |
| masahito | Calling delive_stable_status() in upgrade() | 10:39 |
| masahito | and set Null in downgrade() for all Lease. | 10:39 |
| hiro-kobayashi | I was thought of that but could not find how to update existing fields value. One idea was changing default value to derive status, but it's bad when registering a new record. | 10:40 |
| priteau | hiro-kobayashi: http://alembic.zzzcomputing.com/en/latest/ops.html#alembic.operations.Operations.execute | 10:42 |
| hiro-kobayashi | priteau: Oh, thanks! | 10:42 |
| masahito | IIRC, migration scripts can execute any codes. | 10:42 |
| priteau | found at https://stackoverflow.com/questions/24612395/how-do-i-execute-inserts-and-updates-in-an-alembic-upgrade-script | 10:43 |
| priteau | Look at the code in the first answer as well | 10:43 |
| hiro-kobayashi | Then I'll update the patch and related release note. | 10:43 |
| priteau | That makes me remember, when I updated Chameleon, I had to do some manual data migrations in Blazar | 10:44 |
| priteau | My notes from our upgrade: | 10:44 |
| priteau | Active reservations need another migration as the resource_id field has changed from aggregate ID to the ID in the computehost_reservations table: | 10:44 |
| priteau | UPDATE computehost_reservations SET aggregate_id=(SELECT resource_id FROM reservations WHERE id=computehost_reservations.reservation_id); | 10:45 |
| priteau | UPDATE reservations SET resource_id=(SELECT id FROM computehost_reservations WHERE reservation_id=reservations.id); | 10:45 |
| hiro-kobayashi | priteau: which do you prefer, current patch or alembic migration? | 10:45 |
| priteau | I prefer an alembic migration | 10:45 |
| hiro-kobayashi | OK | 10:45 |
| priteau | Once the migration is done, no need for backward compatibility code anymore | 10:45 |
| masahito | no more comments. Move on to patches for resource-monitoring. | 10:47 |
| masahito | https://review.openstack.org/#/q/status:open+project:openstack/blazar+branch:master+topic:bp/resource-monitoring | 10:48 |
| masahito | patches by implements instance recovery healing looks good to me. | 10:50 |
| masahito | I have some questions for a patch of time windown. | 10:51 |
| masahito | The recursive approach is nice, but if an user delete lease in alloc_to_watch the watched allocation isn't removes. | 10:52 |
| hiro-kobayashi | Oh, it's bad. It should be more resilient. | 10:54 |
| masahito | And the new two config are bit complex to me. It looks first_recovery_window and second_and_later_recovery_window. Is it correct? | 10:55 |
| masahito | That's my question. | 10:55 |
| hiro-kobayashi | Yes, these 2 time windows are described here: http://logs.openstack.org/88/532388/2/check/build-openstack-sphinx-docs/2fec947/html/_images/healing_time_window.png | 10:56 |
| hiro-kobayashi | Now that I think I should not have introduced 2 time windows. just 1 is simpler. | 10:57 |
| masahito | Okay. | 10:58 |
| masahito | Or I thought it's like DNS retrying. | 10:58 |
| hiro-kobayashi | I mean that we can introduce one config, e.g. 'recovery_check_interval' and gradually lengthening the interval. Like n * 'recovery_check_interval' where n is the number of recovery check. | 10:59 |
| hiro-kobayashi | masashito: right! | 10:59 |
| hiro-kobayashi | I'll update the patch based on your comment. thanks! | 11:00 |
| hiro-kobayashi | Any comments about the time window? | 11:00 |
| -masahito- either looks okay for me. | 11:00 | |
| hiro-kobayashi | or anything | 11:00 |
| masahito | okay move on to last things. | 11:02 |
| masahito | patches for python-3 | 11:02 |
| masahito | All of the patches LGTM. | 11:03 |
| masahito | For API patch, we discussed in weekly meeting. | 11:03 |
| hiro-kobayashi | I think we are almost completing this bp. | 11:04 |
| hiro-kobayashi | More manual test may be needed, though. | 11:05 |
| hiro-kobayashi | After merging https://review.openstack.org/#/c/533543/ and solving the client problem, Let's change *-py35 tests to 'voting'. | 11:06 |
| masahito | right. | 11:07 |
| masahito | I think we've reviewed all the patches we need to do so? | 11:09 |
| hiro-kobayashi | Yes, I think so. | 11:09 |
| hiro-kobayashi | api-ref patches are okay for offline. | 11:10 |
| masahito | got it. | 11:11 |
| hiro-kobayashi | Oh, one more thing. | 11:11 |
| bertys | ok for me, I personally also suggest to use 1.0.0b3 tag for Q3 release. Good progress overall | 11:11 |
| hiro-kobayashi | masahito: I've replied your comment on https://review.openstack.org/#/c/529262/ . Please check it. | 11:11 |
| masahito | got it. | 11:12 |
| masahito | one comment. | 11:12 |
| masahito | Followed except-block with different Exception type isn't executed in Python. | 11:13 |
| hiro-kobayashi | Oh, really. I misunderstood. | 11:14 |
| masahito | In that case, if InvalidStatus exception is raised, block of 'except Exception' doesn't work. | 11:15 |
| masahito | Try a similar codes in your local :-) | 11:15 |
| hiro-kobayashi | Oh, yes i know. | 11:16 |
| masahito | If nothing more, we can end the meeting. | 11:18 |
| hiro-kobayashi | masahito: Got your comment. thanks! | 11:18 |
| bertys | thanks all! Have a good day,evening! | 11:19 |
| masahito | hiro-kobayashi, bertys: thanks! Have a good day and evening, too! | 11:20 |
| hiro-kobayashi | Thanks! I have nothing and looks we can end meeting. | 11:20 |
| hiro-kobayashi | Have a nice day/evening! | 11:20 |
| *** bertys has quit IRC | 11:21 | |
| *** hiro-kobayashi has quit IRC | 11:22 | |
| *** masahito has quit IRC | 11:26 | |
| *** masahito has joined #openstack-blazar | 11:28 | |
| *** masahito has quit IRC | 11:32 | |
| openstackgerrit | Merged openstack/blazar master: Fix exception message issues with Python3 https://review.openstack.org/533075 | 11:51 |
| openstackgerrit | Merged openstack/blazar master: Fix filter issues with Python3 https://review.openstack.org/533078 | 11:51 |
| *** masahito has joined #openstack-blazar | 12:04 | |
| *** nicolasbock has joined #openstack-blazar | 12:22 | |
| *** masahito has quit IRC | 12:24 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/blazar master: Remove use of unsupported TEMPEST_SERVICES variable https://review.openstack.org/536831 | 13:49 |
| *** bauzas_ has joined #openstack-blazar | 15:08 | |
| *** bauzas_ has quit IRC | 15:09 | |
| *** bauzas_ has joined #openstack-blazar | 15:18 | |
| *** bauzas_ has quit IRC | 15:22 | |
| *** bauzas has quit IRC | 15:23 | |
| *** bauzas has joined #openstack-blazar | 15:24 | |
| *** nicolasbock has quit IRC | 15:47 | |
| *** openstackgerrit has quit IRC | 16:03 | |
| *** masahito has joined #openstack-blazar | 19:25 | |
| *** masahito has quit IRC | 19:30 | |
| *** nicolasbock has joined #openstack-blazar | 20:59 | |
| *** priteau has quit IRC | 22:03 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!
