Friday, 2015-09-18

*** vivek-eb_ has joined #openstack-barbican00:18
*** vivek-ebay has quit IRC00:18
aleedave-mccowan, interesting .. I got it working this way ..00:38
aleedave-mccowan, I think it makes a bit more sense in it really is a union between two different queries00:40
*** david-lyle has quit IRC00:40
dave-mccowanalee i'll buy it.00:41
aleedave-mccowan, booyah!  the patch passed the gate!00:41
dave-mccowanalee do you know the "rules" around when we need to call session.flush() and/or session.commit()00:42
aleedave-mccowan, +2 it please00:42
aleedave-mccowan, no - woodster_ would be the one to ask about that00:42
aleebut if I recall correctly, you want to do it as little as possible and let sqlalchemy figure out when to do it itself00:43
dave-mccowanalee i added some to the refresh_table() code and the intermittent failures went away00:43
aleeah good to know00:44
*** david-lyle has joined #openstack-barbican00:44
aleeseems like a reasonable idea -- I wonder if that method needs to be synchronized in some way ..00:44
aleeespecially if updates are actually happening00:44
aleewell - only if updates are actually happening00:45
aleedave-mccowan, gotta put kids to bed - back in a little bit ..00:47
openstackgerritDave McCowan proposed openstack/barbican: Finish Initialization of CA Table when Barbican Starts
*** vivek-eb_ has quit IRC00:53
*** su_zhang has quit IRC01:00
openstackgerritDave McCowan proposed openstack/barbican: Finish Initialization of CA Table when Barbican Starts
aleedave-mccowan, your patch is on top of the latest one I checked in?01:08
aleeok - I'll take a look, but we'll need to wait for Ozz to get a second +201:09
dave-mccowanif i mark the other jobs (that will fail w/o your patch) with WIP, will they stop running in the gate?01:09
rm_youi don't think WIP stops queued jobs01:10
rm_youor unqueues them01:10
dave-mccowanrm_you btw, have you seen the email thread on openstack-dev about lbaas and barbican?01:11
dave-mccowanhmmm... the queue just emptied, alee was that you?01:11
aleedave-mccowan, nope01:12
dave-mccowanah... they actually finished (and failed).  zuul is back on track.01:12
rm_youdave-mccowan: err, maybe? which one01:14
rm_youdave-mccowan: is it the one i responded to a couple of times?01:14
dave-mccowan[openstack-dev] [Barbican] Providing service user read access to all tenant's certificates01:16
*** lisaclark1 has joined #openstack-barbican01:18
*** lisaclark1 has left #openstack-barbican01:28
openstackgerritMerged openstack/barbican: Add functional test for project CA
*** zz_dimtruck is now known as dimtruck01:43
rm_youcan you prod my change too?01:50
rm_youfailed due to the cas thing01:50
rm_youdave-mccowan: ^^01:54
dave-mccowanrm_you the fix just merged.  just click rebase and you should be good.01:55
dave-mccowanoh.   i see, it needs a new workflow.  i'm on it.01:57
dave-mccowanrm_you ^^01:57
openstackgerritDave McCowan proposed openstack/barbican: Add barbicanclient clone back (was overzealous in pruning)
dave-mccowanrm_you i'll watch it and +W it after the gate passes.01:58
*** xaeth_afk is now known as xaeth02:13
rm_youdave-mccowan: thanks02:13
*** xaeth has left #openstack-barbican02:14
*** diazjf has joined #openstack-barbican02:16
*** xaeth has joined #openstack-barbican02:17
*** xaeth is now known as xaeth_afk02:23
openstackgerritDave McCowan proposed openstack/barbican: Clean up CAs Policy Rules
*** gyee has quit IRC02:30
openstackgerritDave McCowan proposed openstack/barbican: Handle case of no logging environment variables
openstackgerritDave McCowan proposed openstack/barbican: Updates quota values to be read from conf file
aleedave-mccowan, your init CR has failures ..02:49
*** su_zhang has joined #openstack-barbican02:50
dave-mccowanalee yea, the unit tests can't keep track of how many CAs there are.02:50
aleedave-mccowan, ah02:51
aleedave-mccowan, I'm almost done with a CR to fix GET /cas to send back the right number based on project02:51
aleedave-mccowan, you might want to rebase on top of that02:52
aleedave-mccowan, wait its functional tests not unit tests failing, right?02:53
aleedave-mccowan, ah quota unit tests ..02:53
dave-mccowanalee yea, that's a new one.  i don't think it failed for me locally.02:55
aleedave-mccowan, I think I'm going to want to consult with woodster_ and jaosorior about the commits()02:55
aleeand flushes()02:56
dave-mccowanalee me too.  and then i want to double check all my other database code after we learn the right way. :-)02:56
openstackgerritDave McCowan proposed openstack/barbican: Add function to catch unknown attributes in URI
openstackgerritDave McCowan proposed openstack/barbican: Finish Initialization of CA Table when Barbican Starts
openstackgerritDave McCowan proposed openstack/barbican: Python 3 Refactoring: Replace six.iteritems() with the preferred items()
openstackgerritMerged openstack/barbican: Add barbicanclient clone back (was overzealous in pruning)
openstackgerritDave McCowan proposed openstack/barbican: Clean up CAs Policy Rules
openstackgerritAde Lee proposed openstack/barbican: Fix ca related controllers
openstackgerritFernando Diaz proposed openstack/barbican: Cleanup Secrets created after Order functional tests
*** edtubill has joined #openstack-barbican04:25
*** edtubill has quit IRC04:30
*** edtubill has joined #openstack-barbican04:31
openstackgerritElvin Tubillara proposed openstack/python-barbicanclient: barbican help needs authentication
rm_workthat jeebus, finally04:37
rm_workthat always annoyed me but i never managed to find time to look into it04:38
rm_work*thank jeebus04:38
*** dimtruck is now known as zz_dimtruck04:39
*** vivek-ebay has joined #openstack-barbican04:39
aleedave-mccowan, that test has been added to the run_tests SKIP04:39
aleedave-mccowan, I could add it to the other test case class but I think I plan to add some more tests there04:40
dave-mccowanalee you're missing a \ in the regex.  (i noticed this test failed in the dvsm-new run.)04:43
aleedave-mccowan, phooey04:45
openstackgerritFernando Diaz proposed openstack/barbican: Cleanup Secrets created after Order functional tests
aleedave-mccowan, adding a few more funcitonal tests and then resubmitting ..04:46
dave-mccowanalee i'm done for the night.  see you tomorrow.04:47
openstackgerritFernando Diaz proposed openstack/barbican: Cleanup Secrets created after Order functional tests
aleedave-mccowan, yup -- I may be crashing soon too.04:47
*** dave-mccowan has quit IRC04:47
rm_workFixed the gate migration thing:
*** vivek-ebay has quit IRC05:22
*** openstackgerrit has quit IRC05:31
*** openstackgerrit has joined #openstack-barbican05:31
*** edtubill has quit IRC05:46
*** shohel has joined #openstack-barbican06:06
openstackgerritFernando Diaz proposed openstack/barbican: Cleanup Secrets created after Order functional tests
openstackgerritOpenStack Proposal Bot proposed openstack/barbican: Imported Translations from Zanata
*** jroll has quit IRC06:27
*** eglute has quit IRC06:27
*** jroll has joined #openstack-barbican06:33
*** eglute has joined #openstack-barbican06:33
*** su_zhang has quit IRC07:00
*** woodster_ has quit IRC07:09
*** diazjf has quit IRC07:27
*** darrenmoffat has quit IRC08:40
*** darrenmoffat has joined #openstack-barbican08:41
*** chlong has quit IRC08:47
*** Kevin_Zheng has quit IRC11:25
*** jaosorior has joined #openstack-barbican11:41
*** dave-mccowan has joined #openstack-barbican11:45
openstackgerritDave McCowan proposed openstack/barbican: Finish Initialization of CA Table when Barbican Starts
jaosoriordave-mccowan: ping11:52
dave-mccowanjaosorior pong11:52
jaosoriordave-mccowan: in that file. In what case will the plugin entries have expired?11:52
dave-mccowanjaosorior i don't know why, but when they are created they with an expiration timestamp.
jaosoriordave-mccowan: Interesting. Gotta ask alee why is that so11:56
dave-mccowanjaosorior the biggest question i have about that CR is using session.flush() and commit().   i had some problems where the cas list sometimes came back empty after i wrote to it.  that problem seemed to go away when i added flush/commit.  i'd like to know if/when we need to use them.11:57
jaosoriorI think there exists an that basically does those operations11:57
dave-mccowanjaosoior. yea, i stepped through the code.  we do call with each _add_ca()11:59
*** kebray has joined #openstack-barbican12:00
*** everjeje has quit IRC12:03
*** shohel has quit IRC12:04
*** shohel has joined #openstack-barbican12:04
*** chlong has joined #openstack-barbican12:06
*** chlong has quit IRC12:07
*** chlong has joined #openstack-barbican12:07
*** shohel has quit IRC12:12
*** everjeje has joined #openstack-barbican12:19
*** shohel has joined #openstack-barbican12:32
*** zz_dimtruck is now known as dimtruck12:39
aleedave-mccowan, jaosorior - morning ya'll..12:51
dave-mccowanalee good morning!12:51
*** dimtruck is now known as zz_dimtruck12:55
aleedave-mccowan, still workiing on getting a new patch up.  I started adding new tests and  quickly saw some problems with get_preferred12:55
aleedave-mccowan, which I think you saw before.12:55
dave-mccowanalee have you looked through my patches from yesterday?  i've got fixes to a couple think i saw.12:55
aleeyeah - I did -- and ended up putting a couple of those fixes in I think12:56
aleedave-mccowan, anyways I think I;m going to take out the new tests for now and just get the original patch in (and passing tests)12:57
aleethen look at the preferred thing as a separate patch12:57
*** su_zhang has joined #openstack-barbican12:59
dave-mccowanalee how is global_preferred supposed to fit in to the whole "select the preferred" algorithm?13:01
aleedave-mccowan, this is set by the barbican service admin13:01
aleeif a request comes in without a ca_id,13:02
aleeand the project admin has not set any project cas - and therefore no preferred cas13:03
aleethen the request will go to the global preferred ca13:03
alee(instead of just whatever the first available is)13:03
aleewell - first configured13:03
openstackgerritDave McCowan proposed openstack/barbican: Finish Initialization of CA Table when Barbican Starts
openstackgerritDave McCowan proposed openstack/barbican: Clean up CAs Policy Rules
*** rellerreller has joined #openstack-barbican13:09
aleedave-mccowan, ping13:19
dave-mccowanalee pong13:20
aleedave-mccowan, right now - GET /preferred returns a list of references that looks  like ["cas", ["htpps://foo"]]13:20
aleedoes that make sense?13:20
*** zz_dimtruck is now known as dimtruck13:20
dave-mccowanalee would it always be a list of one?13:21
aleedave-mccowan, or should we really return a ca object? like get_ca does13:21
aleeor just a reference?13:21
alee"ca", "http://foo"13:22
aleedave-mccowan, my inclination is a ca object -- like get_ca ..13:23
dave-mccowanalee it should be something with json braces. one idea, off the top of my head:  {'ca': {'ref' : 'http://foo'}}13:24
dave-mccowanalee but i like being consistent with get_ca.  that's sounds better.13:24
aleedave-mccowan, ok - thats what I'll do13:24
*** woodster_ has joined #openstack-barbican13:32
dave-mccowanwoodster_ ping.  i need some wisdom on how to properly use session.flush(), .commit(), etc.
*** dimtruck is now known as zz_dimtruck13:39
*** kebray has quit IRC13:42
*** openstackgerrit has quit IRC13:46
*** openstackgerrit has joined #openstack-barbican13:46
*** zz_dimtruck is now known as dimtruck13:55
*** kebray has joined #openstack-barbican13:59
*** spotz_zzz is now known as spotz14:01
jaosoriorAnybody in need of reviews?14:02
dave-mccowanjaosorior o/14:06
dave-mccowanjaosorior there are several patches out now that are must-haves for Release Candidate next week.14:06
dave-mccowanjaosorior we should prioritize those... non-urgent patches can go straight to Mitaka14:07
dave-mccowanjaosorior ^^^ it would be awesome if at least those five landed today-ish.14:10
*** kfarr has joined #openstack-barbican14:13
jaosoriordave-mccowan: reviewing14:18
*** jroll is now known as jroll|dupe14:31
*** jroll|dupe is now known as brickednick14:31
*** david-lyle has quit IRC14:31
*** brickednick is now known as jroll14:31
*** edtubill has joined #openstack-barbican14:31
dave-mccowanalee: jaosorior and i were wondering this morning why CAs have an expiration date.14:35
*** edtubill has quit IRC14:36
aleedave-mccowan, jaosorior about to push out an update to the big CR14:36
aleejust as soon as the func tests run14:36
aleeits a big one - sorry -- just kept growing14:37
aleedave-mccowan, jaosorior so expiration ..14:37
aleedave-mccowan, jaosorior the idea here is that the actual cas/subcas that are being provided by the backend ca are really defined at the backend ca14:38
aleethat is -- I can go directly to dogtag and create a new subca14:39
aleebut then barbican wont know anything about it14:39
aleebecause it wasn;t created through barbican14:39
jaosorioralee: Is it then possible for a CA to not have expiration?14:39
aleeso the only way to keep in sync is to poll the ca regularly14:40
*** kebray has quit IRC14:40
aleejaosorior, the ca plugin itself defines what its expiration is14:40
aleejaosorior, so if it want to set it to 10 years , fine14:40
*** pglass has joined #openstack-barbican14:41
dave-mccowanalee what is the trigger in the code for Barbican to search for new ones?  it seems with the logic now the trigger is expiration of *all* of the old ones14:41
aleedave-mccowan, right -- the idea is that the ca plugin will expira all its cas at the same time14:42
aleethen when refresh is called -- it will query the plugin14:42
aleeand get all the supported cas/subcas14:42
dave-mccowanalee, jaosorior the code seems to allow for expiration == None.14:42
aleejaosorior, dave-mccowan - its a compromse between checking each operation - and never checking14:43
*** edtubill has joined #openstack-barbican14:43
dave-mccowanalee it would be cleaner to have that "timer" as part of the plugin definition, instead of every CA and sub-CA.14:44
*** silos has joined #openstack-barbican14:44
aleedave-mccowan, absolutely14:44
aleedave-mccowan, I think thats a bug to be filed ..14:44
alee(and fixed)14:44
dave-mccowanalee three cheers for /v2/14:45
jaosoriorhahaha yeah14:45
*** diazjf has joined #openstack-barbican14:46
openstackgerritAde Lee proposed openstack/barbican: Fix ca related controllers
aleedave-mccowan, jaosorior ^^14:47
aleedave-mccowan, I incorporated a bit of one of your fixes in there to get it to work ..14:47
openstackgerritChristopher Solis proposed openstack/barbican: Updates quota values to be read from conf file
dave-mccowanalee after this, do you have much left on the known to-do list?14:49
aleedave-mccowan, when I ran it , I ran into some quota failure -- but it may pass on the gate14:49
aleedave-mccowan, the known knowns .. :)14:49
aleedave-mccowan, a little bit -- mostly cleanup -- let me find my list14:50
jaosorioralee: reviewing14:50
openstackgerritFernando Diaz proposed openstack/barbican: Cleanup Secrets created after Order functional tests
aleedave-mccowan, 1. getting ca_behaviors to track project_cas so we can unskip the funcitonal test in my latest patch - and maybe add more preferred_ca and project_ca functonal tests14:52
*** kebray has joined #openstack-barbican14:52
alee2. fixing genertion of intermediates in the snakeoil ca14:52
alee3. updating dogtag plugin to provide subcas14:52
aleedave-mccowan, those are the main things14:53
alee4. updating the quickstart/api docs for cas14:53
*** kfarr has quit IRC14:54
*** kebray has quit IRC14:54
aleedave-mccowan, I also had a note to confirm that when issuing a cert, we need to ensure that if a subca is being used, then it must be owned by the requestees project.14:54
aleewould be good to have a functional test to prove that14:55
*** kebray has joined #openstack-barbican14:55
aleedave-mccowan, jaosorior maybe I should put all these on an etherpad14:55
jaosorioralee: Probably that's a good idea14:57
dave-mccowanalee etherpad sounds good.  also also on that page we should have a list of patches out for review that need to land for liberty.  everything else gets deferred to mitaka.14:58
aleedave-mccowan, jaosorior
aleedave-mccowan, jaosorior feel free to add patches etc.15:02
jaosorioralee: will do15:05
jaosoriorBuuuut I gotta go now. Have a good day people :D15:05
*** jaosorior has quit IRC15:06
openstackgerritFernando Diaz proposed openstack/barbican: Remove .pyc files before performing functional tests
aleedave-mccowan, whats the gate like today?15:08
aleerellerreller, woodster_  we may need another reviewer for some of the ca stuff please.15:11
*** xaeth_afk is now known as xaeth15:12
dave-mccowanalee much better15:21
*** ccneill has joined #openstack-barbican15:22
dave-mccowanalee yesterday afternoon, there were 450+ jobs queued.  now just 63.  we need rm_work's patch to land in to infra, so we don't run the devstack tests twice.15:23
dave-mccowanelmiko ping15:24
aleedave-mccowan, hey -  how do I see the progress of the current run?15:24
elmikodave-mccowan: hey15:25
dave-mccowanalee if you're on zuul's page, filter on "barbican" and then click in the middle of the box of the job you're interested in.15:25
aleeah cool15:26
*** igueths has joined #openstack-barbican15:26
dave-mccowanelmiko are you an infra core?  it would be nice to land this one:   it will help our gate jobs go faster.15:26
iguethsHi all.15:26
aleeclick on middle ..15:26
elmikodave-mccowan: ah, sorry not me15:26
dave-mccowanelmiko sorry.  i guess you just seemed like the powerful type. ;-)15:27
elmikodave-mccowan: lol, /me blushes15:28
dave-mccowanalee did you find it?15:29
aleedave-mccowan, yeah -- loks like my coverage will fail - but not sure why ..15:29
aleedave-mccowan, looks like its failing to run15:30
redrobotgood (ugt) mornin'15:30
aleeredrobot, you're just in time15:31
aleeredrobot, we need another core reviewer for the ca stuff - and you've been nominated15:32
redrobotalee lol, sounds good, what CRs?15:34
aleeredrobot, lets start with my big one ..15:34
aleedave-mccowan also has some as well15:35
dave-mccowanredrobot: the six on this etherpad are all must-have (IMO) for RC1.
redrobotdave-mccowan ack15:37
*** shohel has quit IRC15:37
dave-mccowanalee if you're getting intermittent unit test failures in, you may want to rebase on my CR 22415615:38
dave-mccowanalee i had that... worked locally and failed in the gate.  i added plugin_name filters to help the test cases count cas.15:40
*** gyee has joined #openstack-barbican15:42
aleedave-mccowan, aaargh .. waiting to gate tests - like watching paint dry ..15:44
*** su_zhang has quit IRC15:54
aleedave-mccowan, redrobot the gate finally came back on my
aleedave-mccowan, redrobot it looks like there are some failures there - but in fact, the coverage one just plain failed to run and the new gate ended up quitting on the second run of the funtonal tests15:59
aleelike the server just went down16:00
aleedave-mccowan, redrobot - those gates are non-voting and they have nothing to do with my CR16:00
aleedave-mccowan, did you have coments on this CR?16:01
*** diazjf has quit IRC16:08
*** everjeje has quit IRC16:32
openstackgerritOpenStack Proposal Bot proposed openstack/barbican: Updated from global requirements
*** rellerreller has quit IRC16:38
*** vivek-ebay has joined #openstack-barbican16:46
woodster_alee, are you there?16:49
aleewoodster_, yup16:49
woodster_alee: are you talking about the CA CRs that Dave is putting up?16:49
aleewoodster_, there are a bunch ..16:50
aleewoodster_, ^^16:50
aleewoodster_, many are small but a couple are large16:51
woodster_alee, wow, ok there are a bunch16:51
aleewoodster_, is big as is
aleewoodster_, the rest are a lot smaller16:52
aleewoodster_, but the big ones are where we need more eyes16:52
dave-mccowanwoodster_ we had a specific question about:     the question is: when should we use flush() and commit()?  i saw some weirdness (missing DB entries) that went away when I added them.  but, i'd rather know for sure when and what we are supposed to use.16:53
*** su_zhang has joined #openstack-barbican16:54
dave-mccowanalee i'm slogging through yours now.16:55
*** rellerreller has joined #openstack-barbican16:55
dave-mccowanalee we're going to have merge conflicts :-(16:56
aleedave-mccowan, thanks.  yeah - but not too many I think16:56
*** chadlung has joined #openstack-barbican16:57
*** su_zhang has quit IRC17:06
*** kebray has quit IRC17:06
dave-mccowanwoodster_ thanks for the review.  where to call initialize is something we talked about this week.  can you recommend a better place?  the other places we considered all came before controllers init...17:13
woodster_dave-mccowan: can you just do in the on_get() as you have now?17:14
woodster_dave-mccowan: so make it a lazy process...only computed when you need it?17:15
dave-mccowanwoodster_ only if we can impose on users that the first call they do is GET /cas/.17:16
woodster_dave-mccowan: well, how many operations require that cas info to be set from the plugins?17:16
dave-mccowanwoodster_, alee.  i think all of them.  without the init, barbican thinks there are zero CAs.17:17
aleewoodster_, dave-mccowan I would say all the operations in /cas and then issuing a cert request17:18
aleewoodster_, dave-mccowan we already call refresh() in the case of a cert request17:18
dave-mccowanalee, woodster_ that does seem like a simple and safe fix though.17:20
woodster_so I'm thinking a common refresh() place that /cas operations can call off to to check refresh on plugins17:20
woodster_so could eventually only check if a time period has elapsed since the last check17:21
aleewhat about in _lookup() on the cas controller?17:22
aleeand mayeb also then get_cas() etc.17:22
dave-mccowanwoodster_ a common call is good.  we could even tie it into a message service too, for a plugin to poke Barbican to refresh.17:23
dave-mccowanalee, woodster_  i like being direct and obvious.... just add a one-liner to each method that needs current data.17:24
aleedave-mccowan, sure thats fine with me.17:24
aleewoodster_, had a chance to look at my CR yet? dave-mccowan ?17:24
openstackgerritMerged openstack/barbican: Add function to catch unknown attributes in URI
openstackgerritMerged openstack/barbican: Remove .pyc files before performing functional tests
*** diazjf has joined #openstack-barbican17:35
dave-mccowanalee, woodster.  i took out the flush()/commit() and i'm back to broken.  each all to refresh() is building new CAs.
openstackgerritArun Kant proposed openstack/python-barbicanclient: Part 2: Adding ACL support for CLI commands and docs
*** su_zhang has joined #openstack-barbican18:06
openstackgerritArun Kant proposed openstack/python-barbicanclient: Part 2: Adding ACL support for CLI commands and docs
*** su_zhang_ has joined #openstack-barbican18:09
*** su_zhang has quit IRC18:12
openstackgerritArun Kant proposed openstack/python-barbicanclient: Part 2: Adding ACL support for CLI commands and docs
openstackgerritArun Kant proposed openstack/python-barbicanclient: Part 3: Adding ACL functional tests.
*** rellerreller has quit IRC18:19
aleedave-mccowan, woodster_ any other comments on ?18:20
aleedave-mccowan, woodster_ I only see Oz's comments and they're pretty straightforward.18:21
aleeI could rebase on top of dave's patch - but I want to wait until thats in a final form.18:21
dave-mccowanalee speaking of final form for init.  what do you think?  without flush/commit, it doesn't work.  so, i'd like to leave it.18:26
aleedave-mccowan, well thats a mighty good argument for leaving them in.18:27
aleewoodster_, ^^ what do you think ? you're the expert here in db sqlalchemy stuff.18:27
aleedave-mccowan, you have no objections to anything else in my patch?18:28
*** mragupat has joined #openstack-barbican18:31
dave-mccowanalee not really.  if we had more time, i'd bring up some nits...18:32
*** kebray has joined #openstack-barbican18:33
aleedave-mccowan, nits are for post-rc118:34
*** kebray has quit IRC18:35
*** kebray has joined #openstack-barbican18:45
*** kebray has quit IRC18:45
*** kebray has joined #openstack-barbican18:46
redrobotalee looks like is in merge conflict19:12
diazjfanyone know whats going on with "gate-tempest-dsvm-neutron-src-python-barbicanclient", just failed again on arunkant 's new patch19:18
*** dimtruck is now known as zz_dimtruck19:22
aleeredrobot, yeah -- I'm going to rebase now19:23
aleealthough I could just end up rebaseing on top of dave-mccowan last patch19:24
aleeredrobot, shouldn't stop your review though ..19:24
dave-mccowanalee fyi doug just workflowed my init patch19:25
aleedave-mccowan, ok cool -- I will rebase on top of yours now then :)19:26
aleedave-mccowan, any more of yours still out there?19:26
aleedave-mccowan, if I'm gonna end up rebaseing in any case ..19:27
aleedave-mccowan, can you fix
aleeand submit19:29
aleedave-mccowan, thats the last relevant one, right?19:31
dave-mccowani think so.  just the one change suggested by ozz?19:31
aleeback to the old name19:32
aleedave-mccowan, let me know when done19:33
diazjfredrobot, thanks for the +A, know whats going on with I wanna get all the behavior stuff merged soon19:35
openstackgerritDave McCowan proposed openstack/barbican: Clean up CAs Policy Rules
dave-mccowanalee ^^19:36
aleedave-mccowan, thanks .. stand by .. rebasing in progress ..19:37
*** su_zhang_ has quit IRC19:42
*** silos has left #openstack-barbican19:45
aleedave-mccowan, did your patch still have the populating of ca tables on ca controller startup?19:47
aleedave-mccowan, I thought we decided not to do that?19:47
dave-mccowanalee that's what we discussed, but in the end we merged as is.19:48
aleedave-mccowan, ok - we might reconsider thatearly next week19:49
dave-mccowanalee i think we're ok with start-up.  it's not too early, and potentially the same time as waiting for customer input.19:49
dave-mccowanalee we might have a hole if the entries have expired.  only get_cas and post_order refresh the table now.19:49
aleedave-mccowan, rigth - lets revisit after my patch merges :)19:50
openstackgerritMerged openstack/barbican: Finish Initialization of CA Table when Barbican Starts
openstackgerritMerged openstack/barbican: Updates quota values to be read from conf file
aleedave-mccowan, yeah - just a few merge conflicts ..20:01
dave-mccowanalee big question, now that these are all smushed together... does it work?  :-)   how complete is the functional test coverage?20:02
aleedave-mccowan, well its a lot beter than it was ..20:03
aleedave-mccowan, let me get it all merged together first ..20:03
*** su_zhang has joined #openstack-barbican20:04
aleedave-mccowan, passed pep 8 and only fails 4 unit tests . fixing ..20:08
aleedave-mccowan, ping20:14
aleedave-mccowan, so I have a question about your init patch20:15
dave-mccowanalee pong20:15
aleein (unit test)20:15
aleeyou define num_root_cas =220:15
aleewhere is that used?20:15
dave-mccowanalee i used it in a failed attempt at to help the tests count.  it should be removed.  i ended up, instead, filtering by plugin_name so the test's entries didn't conflict with each other.20:16
aleeah I was wondering how you mananged to avoid worrying about this ..20:17
dave-mccowanalee it was a pita.  the tests would work for me locally and then fail in the gate.20:18
aleeyeah - because it depends on whats in the db to begin with20:18
aleeand that depends on what plugins are configured20:18
aleein the dogtag ate ofr instance only dogtag is configured20:19
*** vivek-ebay has quit IRC20:20
dave-mccowanalee it seems what tests have run before and after might also be a factor, as far as i could tell20:20
aleeshouldn't be ...20:21
aleebut lets see ..20:21
*** ccneill has quit IRC20:33
*** insequent has joined #openstack-barbican20:33
openstackgerritMerged openstack/barbican: Cleanup Secrets created after Order functional tests
aleedave-mccowan, unit tests pass ..20:37
dave-mccowanalee woot!20:38
aleedave-mccowan, now -funcrional tests ..20:39
openstackgerritOpenStack Proposal Bot proposed openstack/barbican: Updated from global requirements
*** ccneill has joined #openstack-barbican20:44
*** chadlung has quit IRC20:48
aleedave-mccowan, looking good so far ..20:49
*** vivek-ebay has joined #openstack-barbican20:50
aleedave-mccowan, there is a problem I think20:51
aleedave-mccowan, so I killed my database and then startup up the server20:52
aleedave-mccowan, on startup , I get errors like ..20:52
aleeMissingArgumentError: Must supply non-None value argument for CertificateAuthorityMetadatum entry20:52
aleedave-mccowan, which is presumably in the init code for the cas20:52
aleeie. the controllers20:53
aleedave-mccowan, and then my server does not come up20:53
dave-mccowanalee yea, i've found to clean up i need to clean out the snake oil directory when i delete the database.20:53
aleedave-mccowan, hmm ..20:54
aleedave-mccowan, ok - we need to look into making that more robust ..20:55
dave-mccowanalee +120:55
*** vivek-ebay has quit IRC20:57
*** vivek-ebay has joined #openstack-barbican20:57
dave-mccowanalee what's the right answer for that?  should snakeoil be able to recover old CAs without Barbican database entries?21:00
aleedave-mccowan, sorry - just trying to get the patch out ..21:12
aleedave-mccowan, maybe21:13
*** chlong has quit IRC21:14
*** mragupat_ has joined #openstack-barbican21:42
openstackgerritAde Lee proposed openstack/barbican: Clean up CAs Policy Rules
openstackgerritAde Lee proposed openstack/barbican: Fix ca related controllers
aleedave-mccowan, ^^21:42
aleeredrobot, ^^21:43
aleedave-mccowan, going for a quick run -- hopefully the tests will pass.21:43
aleeredrobot, looking to you to workflow please once it goes through21:44
*** mragupat has quit IRC21:46
*** mragupat_ has quit IRC21:46
*** mragupat has joined #openstack-barbican21:47
*** chadlung has joined #openstack-barbican21:48
*** ccneill has quit IRC21:53
*** chadlung has quit IRC21:55
*** pglass has quit IRC21:59
*** su_zhang has quit IRC22:02
*** edtubill has left #openstack-barbican22:02
*** su_zhang has joined #openstack-barbican22:04
*** xaeth is now known as xaeth_afk22:05
*** igueths has quit IRC22:11
*** mragupat has quit IRC22:12
openstackgerritMerged openstack/barbican: Completes localization of the api directory structure
*** chadlung has joined #openstack-barbican22:21
openstackgerritMerged openstack/barbican: Updated from global requirements
*** ptoohill is now known as pc-pothole22:29
*** nelsnelson has quit IRC22:38
*** spotz is now known as spotz_zzz22:40
*** chadlung has quit IRC22:42
*** openstackgerrit has quit IRC22:46
*** openstackgerrit has joined #openstack-barbican22:46
aleedave-mccowan, redrobot my patch passed gate - ship it please!22:57
aleewoodster_, ^^22:57
aleedave-mccowan, woodster_ redrobot ^^22:58
redrobotalee the parent commit is failing the py27 gate22:58
aleeaargh - thats like a 5 line patch ..22:59
aleeredrobot, coverage is messed up for some unknown reason - looks like it did not even run23:00
aleepy27 failure is quota tests -- dave-mccowan ^^23:01
aleerechecking ..23:02
*** diazjf has quit IRC23:08
*** kebray has quit IRC23:09
dave-mccowanalee looks like you accidentally changed that patch.  patch #4 was OK and had workflow, and they you uploaded patch set #523:19
redrobotdave-mccowan patches 4 and 5 look the same to me. :-\23:23
dave-mccowanredrobot.  yea.  i must have been looking at the wrong CR.  derp.23:26
redrobotit's weird that one patch would pass but not the other...23:27
dave-mccowanthe current job passed both unit and coverage this time.  we just have to wait for the devstack runs.23:33

Generated by 2.14.0 by Marius Gedminas - find it at!