Thursday, 2015-04-16

*** stanzi has quit IRC00:02
*** stanzi has joined #openstack-barbican00:03
*** zz_dimtruck is now known as dimtruck00:05
elmikowoodster_: ok, for reasons that only the mysql devs know, server_default='0' seems to work00:06
elmikonot sure about postgresql, i'll try that next00:06
*** stanzi has quit IRC00:07
*** kebray has quit IRC00:11
*** kebray has joined #openstack-barbican00:15
*** kebray has quit IRC00:16
*** stanzi has joined #openstack-barbican00:19
elmikowoodster_: that does seem to work in postgres00:20
*** tkelsey has joined #openstack-barbican00:21
*** SheenaG has quit IRC00:25
*** tkelsey has quit IRC00:26
*** stanzi has quit IRC00:26
*** stanzi has joined #openstack-barbican00:26
*** stanzi has quit IRC00:31
openstackgerritDave McCowan proposed openstack/barbican: Add utility functions to convert between and PEM and DER
*** crc32 has joined #openstack-barbican01:25
woodster_elmiko: so we'll have quite a list of do's and don'ts before this is done01:29
aleedave-mcc_, redrobot ping02:06
dave-mcc_alee pong02:18
aleedave-mcc_, so - I just verified that (with a small tweak) the dogtag tests work.02:19
dave-mcc_alee \o/02:19
aleedave-mcc_, now how close are we to getting the skipped tests working?02:19
dave-mcc_alee i've had them working in my local environment for a couple days... we just need to get all the CRs toghether.02:20
aleedave-mcc_, because depending on what you guys end up doing for that -- that may change what happens in the dogtag code02:20
dave-mcc_alee i just found something fun for gate... rare, but random, failures in unit tests.  i'm fixing it now.02:20
dave-mcc_alee, we want the big CR too land ASAP, and then fix KMIP and dogtag in subsequent CRs.02:20
aleeright - but the big cr does not unskip all the tests , right?02:21
dave-mcc_alee, correct, it still skips a few.02:21
aleedave-mcc_, well +2 from me -- now we just need a workflow02:23
aleehockeynut, jvrbanac ?02:24
dave-mcc_alee, unfortunately it failed the gate due to random unit test failure.  we could recheck, and maybe it will work next time.02:25
dave-mcc_alee, i just submitted recheck.  but i'm working on patch to fix it.  there are several unit tests related to containers that assume the order of a list is predictable; it is not.02:26
aleedave-mcc_, yeah - we need to fix those tests02:27
dave-mcc_alee, it's in validators, orders, containers, and others.02:28
aleedave-mcc_, really?02:28
aleedave-mcc_, from what I see - it failed the gate because of this -- >  api.v1.smoke.test_rsa.RSATestCase.test_rsa_create_and_get_container_with_passphrase02:29
dave-mcc_alee, and models02:29
aleedave-mcc_, ie. functional tests02:29
dave-mcc_alee yea, that was random... that usually passes because refs[0] and refs[1] are in the same order it was passed in.  but sometimes, the values are switched.02:30
dave-mcc_alee that same assumption is made all over the place.02:30
aleedave-mcc_, are you looking at ?02:30
aleeright -- but maybe that assumption is ok in other cases.  In these functional tests, though it may be invalid02:31
aleedave-mcc_, where are you seeing unit tests even being invoked in the gate?02:32
dave-mcc_alee... i assumed they were.  they aren't?02:33
aleedave-mcc_, perhaps - but I dont see them in the console02:33
aleedave-mcc_, I think you just need to focus on fixing the offending functional tests02:34
*** peter-hamilton has quit IRC02:34
dave-mcc_alee i think separate jobs for unit and functional.  sounds good.  i'll fix those and submit a CR asap.  hopefully no one else has hit this yet.02:34
aleedave-mcc_, you can use self.assertIn(...)02:42
dave-mcc_alee, i was just going to ask you for a suggestion.02:42
dave-mcc_instead of self.assertEqual(get_resp.model.secret_refs[0].name, 'public_key')02:42
*** crc32 has quit IRC02:43
aleenames = ['public_key', 'private_key']02:43
aleeself.assertIn(get_resp.model.secret_refs[0].name, names)02:43
aleedave-mcc_, ^^02:44
aleesoemthing like that02:44
aleedave-mcc_, ping02:56
dave-mcc_alee pong02:56
aleedave-mcc_, question -- with the big cr in -- if you remove the skips in, do the tests pass for you?02:57
aleedave-mcc_, I have them passing with a small tweak to one test02:57
dave-mcc_alee i haven't tried lately.  i thought maybe.  was the tweak with payload_content_encoding?02:58
aleedave-mcc_, in test_rsa_order_certificate_from_csr() ..02:58
aleetest_model = order_models.OrderModel(02:58
alee            **get_order_create_certificate_simple_cmc(02:58
alee                base64.b64encode(csr)))02:58
aleecsr needs to be base64 encoded02:59
aleeother than that - they all pass for me (against dogtag)02:59
dave-mcc_alee, yes.
dave-mcc_alee awesome!03:00
aleedave-mcc_, do they pass for you?03:00
*** xaeth_afk is now known as xaeth03:00
dave-mcc_alee, i haven't tried lately.  i had them passing, and then put some fixes in the bug-cr and some in separate ones to keep them small... waiting for them all to merge.03:01
dave-mcc_alee, the base64(csr) fix is one waiting at the gate.  i think it was hit with the out of order list issue.03:02
*** xaeth is now known as xaeth_afk03:02
aleeok - so roll the fix for the order-list issue in with that03:03
aleeand that way it will pass the gate03:03
dave-mcc_alee good idea.  will do.03:06
*** SheenaG has joined #openstack-barbican03:16
*** rm_you| has joined #openstack-barbican03:23
*** rm_you has quit IRC03:27
openstackgerritDave McCowan proposed openstack/barbican: Fix errors in functional tests
dave-mcc_alee, i just fixed test_rsa, since it was the one failing.  hopefully it gets us going.03:32
dave-mcc_alee, if we can get that one workflowed, i can rebase the big one and we can get that one through too.03:32
aleedave-mcc_, looking03:33
dave-mcc_alee, i've got an extra function i wrote an didn't use.  i'll revert that.03:36
dave-mcc_alee, let me know if there rest is ok, and i'll push up the second patch03:36
aleedave-mcc_, you mean the get_secret_dict() function?03:37
aleedave-mcc_, I'd actually prefer you to encapsulate the test in that function03:38
aleeie. use the funciton instead of repeating yourself in two tests03:38
dave-mcc_alee, yea, i know that's better.  it's on my to-do list to duplicate all the repetitious code in this file.  (not for rc1).  ok, i'll do it right.03:39
dave-mcc_alee, done.  anything else?03:45
openstackgerritDave McCowan proposed openstack/barbican: Fix errors in functional tests
*** SheenaG has quit IRC04:02
openstackgerritDave McCowan proposed openstack/barbican: Fix base64 decoding of payloads in one-step POST
aleedave-mcc_, good for me04:09
dave-mcc_alee, all passing now.  there were a couple bugs in 173452 that i fixed in 173396.  they're lined up now.04:09
openstackgerritDave McCowan proposed openstack/barbican: Add utility functions to convert between and PEM and DER
*** tkelsey has joined #openstack-barbican04:23
*** tkelsey has quit IRC04:29
openstackgerritDave McCowan proposed openstack/barbican: Fix handling of payload_content_encoding for orders
*** dimtruck is now known as zz_dimtruck05:18
*** dave-mcc_ has quit IRC05:31
openstackgerritDouglas Mendizábal proposed openstack/barbican: Fix KMIP Secret Store input/output
*** jaosorior has joined #openstack-barbican07:01
openstackgerritMerged openstack/barbican: Fix errors in functional tests
openstackgerritJuan Antonio Osorio Robles proposed openstack/python-barbicanclient: Initial setup for command line tests
openstackgerritJuan Antonio Osorio Robles proposed openstack/python-barbicanclient: Use keystoneclient to get endpoint if it's empty
*** chlong has quit IRC07:40
*** xek has joined #openstack-barbican08:00
*** rm_you| has quit IRC08:39
*** rm_you| has joined #openstack-barbican08:40
*** rm_work is now known as rm_work|away09:13
*** woodster_ has quit IRC09:30
*** gitorres has left #openstack-barbican09:36
openstackgerritJuan Antonio Osorio Robles proposed openstack/python-barbicanclient: Use keystoneclient to get endpoint if it's empty
*** jamielennox is now known as jamielennox|away11:47
*** joesavak has joined #openstack-barbican11:56
openstackgerritGrzegorz Grasza (xek) proposed openstack/barbican-specs: Use oslo.versionedobjects to help with upgrades
*** everjeje has joined #openstack-barbican12:27
*** rellerreller has joined #openstack-barbican12:36
*** jsavak has joined #openstack-barbican12:43
*** joesavak has quit IRC12:46
rellerrellerredrobot I reviewed You want me to workflow or wait for alee?12:49
*** woodster_ has joined #openstack-barbican13:00
*** nkinder has quit IRC13:09
*** stanzi has joined #openstack-barbican13:14
*** stanzi has quit IRC13:15
*** stanzi has joined #openstack-barbican13:16
*** stanzi has quit IRC13:20
jaosoriorwoodster_: ping13:21
woodster_jaosorior: morning (or evening rather)13:23
jaosoriorwoodster_: hey man, I remember there was gonna be some working regarding starting to use the standard output or format for the version output, meaning the output that comes out when we access the / resource in Barbican. What happened to that?13:24
woodster_jaosorior: the bp was approved but know one freed up to work on it. The quota bp wasn't implemented either...tsv has been pulled to work other things but said he'd come back to it in liberty13:26
jaosoriorwoodster_: alright, was just wandering about it13:27
woodster_jaosorior: yeah, we need a few more barbicaneers to get all the stuff done!13:27
*** alee_ has joined #openstack-barbican13:28
woodster_elmiko: I'm mailing a patch to you to adds named FKs and reworks that first version file a bit...please let me know what you think13:52
elmikowoodster_: ack, i'll take a look13:52
elmikowoodster_: i got that migration you posted to work for both mysql and postgresql13:53
woodster_elmiko: and that was just by chaning the boolean default value to 0?13:54
elmikowoodster_: pretty much13:54
elmikowoodster_: oh, and the downgrade mismatch in the comments makes alembic think there are 2 heads, but that's separate13:55
*** stanzi has joined #openstack-barbican13:57
*** dave-mccowan has joined #openstack-barbican13:58
*** stanzi has quit IRC14:00
*** stanzi has joined #openstack-barbican14:01
elmikowoodster_: looking at your patch, i'm not so sure we need to drop the secret_id constraing14:05
elmikoi think only the tenant_id constraint needs to change14:05
*** paul_glass has joined #openstack-barbican14:05
*** nkinder has joined #openstack-barbican14:06
elmikohmm, or maybe it does...14:06
*** igueths has joined #openstack-barbican14:06
woodster_elmiko: I think if more than one FK exists in a table we need to name the constraints, but also whenever we touch FKs like in the other tables with just project FKs. We really need to move to naming all constraints to avoid issues14:08
elmikowoodster_: ok, fair14:08
elmikowoodster_: the only other thing jumping out to me, at the moment, is that if we change the fk's to be explicitly named do we also need to change the model to show that name?14:10
elmikonvm, missed that part14:10
elmikowoodster_: at first pass, this change makes sense14:11
woodster_elmiko: yep14:11
woodster_elmiko: yeah I figure when I fix my CR per you default value change, I'll also beef up the doc that a14:12
woodster_elmiko: that I modified with it14:12
elmikowoodster_: +114:13
woodster_elmiko: would you be up for modifying youR CR along the lines of that patch?14:14
elmikowoodster_: definitely, i just want to test it against my setup here14:14
elmikowoodster_: and thanks for the help =)14:15
woodster_elmiko: good point, I didn't test on Postgres:\14:15
elmikowoodster_: gotta say though, this does give me a new perspective on why folks like postgres over mysql14:19
alee_redrobot, dave-mccowan I see the big cr was workflowed14:27
alee_redrobot, dave-mccowan - I'm working right now on dogtag changes14:27
dave-mccowanalee_ it failed the final gate, though.  no merge.  :-(   but, it's passing on my bog.14:31
*** stanzi has quit IRC14:39
*** stanzi has joined #openstack-barbican14:40
*** zz_dimtruck is now known as dimtruck14:44
*** stanzi has quit IRC14:44
dave-mccowanalee_, can you check if functional tests run for you on git review -d 173396 ?14:50
alee_dave-mccowan, sure -- give me a few mins -- almost sorted all the dogtag issues.14:51
*** stanzi has joined #openstack-barbican14:51
alee_dave-mccowan, once I do, I need to rebase anyways14:51
dave-mccowanalee_  thanks.  odd, it worked in jenkins check, but failed in jenkins gate.14:53
dave-mccowanalee_, i see the bug now.15:02
iguethsredrobot: So out of the directory tree at , which file (s) should I focus on to attempt to make sense of whatever the failure is?15:02
elmikowoodster_: your patch works well for me, the only issue i have with postgres is that there seems to be a timing issue which causes one migration to fail because a table is not created15:02
elmikowoodster_: i'm not sure what to do about that15:02
redrobotigueths looks like your CR failed for an unrelated change15:03
alee_dave-mccowan, which test is failing?15:03
dave-mccowanredrobot, alee_ three of them.  i see the fix now, but i don't know why it's tempermental.15:04
dave-mccowanalee_, oh wait... i don't see the fix.15:05
iguethsredrobot: Can you elaborate?15:05
dave-mccowanalee_ one is api.v1.functional.test_certificate_orders.CertificatesTestCase.test_create_stored_key_order15:08
*** stanzi has quit IRC15:09
*** stanzi has joined #openstack-barbican15:09
dave-mccowanalee_, redrobot. in the passing "check", in the barbican screen, i don't see error: "string or callable".  in the failing "gate", i do see the error "string or callable".  that error was fixed by 173456 which has merged.15:09
iguethsRebased...Here goes take 9.15:10
openstackgerritIgor Gueths proposed openstack/barbican: Potential resource exhaustion when registering consumers to containers
redrobotdave-mccowan alee_  strange....  I'll pull down the patch, rebase on master and see if I can get the tests to pass...15:11
*** stanzi has quit IRC15:14
*** kebray has joined #openstack-barbican15:14
*** darrenmoffat has quit IRC15:14
*** stanzi has joined #openstack-barbican15:14
*** darrenmoffat has joined #openstack-barbican15:15
*** bbby has joined #openstack-barbican15:15
woodster_elmiko: ugh :\  so much for liking postgres more! For grins, maybe try to stick a sleep(10) in there to rule out some other sequencing issue? It bugs me that these migration steps aren't transactional either15:17
elmikowoodster_: i'm talking with folks in #sqlalchemy about this now, maybe it has to do with the get_foreign_keys call15:18
*** rm_work|away is now known as rm_work15:18
woodster_elmiko: well, if you manually upgrade/downgrade across that change, does that pass? Only when you do it as a batch of version changes, correct?15:19
elmikowoodster_: correct15:19
*** xaeth_afk is now known as xaeth15:20
*** SheenaG has joined #openstack-barbican15:22
alee_jaosorior, very naughty15:23
*** stanzi has quit IRC15:23
jaosorioralee_: wha?15:23
*** stanzi has joined #openstack-barbican15:24
alee_jaosorior, you put in a fix to return 409 when a secret is being updated with a PUT with payload already present15:24
rm_workjaosorior: commented on
alee_jaosorior, thats good in itself, but the check you used is this --15:24
alee_if self.secret.encrypted_data:15:25
alee_            _secret_already_has_data()15:25
rm_workjaosorior: ah and right as I say that, I found the etc/functional_tests.conf in the barbicanclient stuff15:25
alee_secret.encrypted_data() is only valid for the crypto_plugin15:25
rm_workjaosorior: so then my only concern is the lack of consistency, which is probably not your problem15:26
alee_ie. not for dogtag/kmip ....15:26
jaosorioralee_: well, shit15:27
jaosoriorrm_work: so... will you revert the -1?15:28
rm_workjaosorior: curious how concerned we are about the consistency issue first15:29
rm_workwas hoping someone would comment15:29
rm_workbut I would +1 if pressed :P15:29
rm_workconsistency is one of the things I get a little OCD about sometimes15:29
alee_jaosorior, its fixed easily enough --- you just need to throw the exception later in the code.15:29
jaosoriorrm_work: that's why it's 'v2' in CONF.identity.auth_version, that covers for the decimals if they would exist... though that was actually mostly meant since there was some part of the keystone version config that would take decimales for the 3.X api15:30
rm_workI guess maybe the client CLI args need to change to use v2 and v3? that matches both the client's functional_test.conf and the barbican server's config?15:30
jaosorioralee_: can you point out to the file?15:30
alee_jaosorior, plugin/resources.py15:31
*** rellerreller has quit IRC15:31
alee_jaosorior, line 7715:31
alee_instead of throwing a ValueError() , you throw a different exception15:32
alee_jaosorior, or better yet ..15:33
alee_change to check to : secret_model.encrypted_data or secret_model.secret_store_metadata15:33
jaosorioralee_: Wasn't that the case for the two step secret creation?15:33
alee_jaosorior, it all goes through the same --15:33
elmikowoodster_: so, according to the folks in #sqlalchemy we shouldn't be doing db inspection during the migrations15:33
alee_jaosorior, the right check is as above ..15:34
jaosorioralee_: Actually a subsequent change would have gotten rid of the weird things of sometimes getting a secret_model and sometimes not15:34
elmikowoodster_: i'm thing about changing those get_foreign_key checks to instead gate on if the dialect is mysql15:34
alee_I'll change it in my upcoming cr15:34
alee_jaosorior, yup - that fixes it15:36
*** dave-mccowan has quit IRC15:37
jaosorioralee_: I'm talking about the changes in this CR
jaosorioralee_: But honeslty, I'm still not quite sure to what change are you referring to that broke things15:37
alee_jaosorior, no worries -- it was a change in controllers/secrets.py15:39
woodster_elmiko: that makes sense. Once everything is named though we shouldn't have to worry about this anymore15:39
elmikowoodster_: yeah, exactly =)15:40
rm_workjaosorior: i gave up caring, every single place this is configured is different (and none of it is really due to your patchset) T_T15:40
woodster_elmiko: did the sqlalchemy folks have thoughts on the Postgres timing issue by chance15:40
jaosoriorrm_work: if you want we can sit down, agree on a more consistent way, and I'll work on a patch for that15:41
rm_workit would be good to at least agree on what the correct way is, for a start -- and possibly if they NEED to be different for some reason, at least comment in place "# Your options are "v2" or "v3"15:42
rm_workor whatever they should be -- because i see the example default, but no idea what the other option is in some cases15:42
elmikowoodster_: yes, they thought it had to do with postgres' transaction DDL. so we shouldn't be inspecting the db during a migration15:43
jaosorioralee_: Any updates on the dogtag gate? That would have helped preventing this. I don't have a dogtage instance running myself :/15:43
alee_jaosorior, I was thinking exactly the same thing -- redrobot ^^15:43
elmikowoodster_: i'm going to change the "fk_name_to_try in fkeys" logic to instead just look at the ctx.dialect to see if we're using mysql15:44
elmikowoodster_: if that makes sense to you15:44
redrobotalee_ jaosorior no progress, kinda took a back seat to getting Kilo out the door, and some internal stuff.15:44
jaosorioralee_: Can you push a fix? It would be better since you actually can test with dogtag. Sorry for the regression on your side15:45
alee_redrobot, ok - we're not leaving Vancouver until we have a running dogtag gate.15:45
redrobotalee deal!15:45
woodster_elmiko: that makes sense given what the sqlalchemy folks said15:45
alee_jaosorior, yeah - doing it as part of a larger cr15:45
*** kebray has quit IRC15:47
*** kebray has joined #openstack-barbican15:52
*** dave-mccowan has joined #openstack-barbican15:55
redrobotdave-mccowan alee got one failure when I rebased onto master.15:56
dave-mccowanredrobot, was it the same "ERROR" instead of "PENDING" ?15:57
redrobotdave-mccowan nope, it's one for consumers15:57
alee_dave-mccowan, redrobot  -looks like it passed the gate?15:58
openstackgerritMichael McCune proposed openstack/barbican: [WIP] Adding MySQL fixes to migrations
dave-mccowanalee_, redrobot: jaosorior issued reverify and it worked.  random failures?  :-(16:00
elmikowoodster_: latest patch, works with both but i still have a question about one of the constraints that presumably was an error in the old migrations16:00
jaosoriordave-mccowan: random failures, actually, I'm yet to figure out why though16:00
woodster_elmiko: would naming it help?16:02
elmikowoodster_: oh yea, i meant to add a name to the constraint that's added. but i was more confused by the preferred_certificate_authorities_project_id_key name because it never appears in the actual db schema16:03
dave-mccowanjaosorior, i fixed some random errors in  (bad assumption of list order) but, the others i've seen have different symptoms.16:03
woodster_elmiko: maybe too long?16:04
elmikowoodster_: nah, i think it was a misname on the part of the migration. in the db there is a preferred_certificate_authorities_project_id_fkey name16:05
redrobotalee_ dave-mccowan jaosorior  gate is still in progress
elmikowoodster_: i really need to analyze the db schemas against the sqlalchemy models again16:05
openstackgerritMerged openstack/barbican: Fix base64 decoding of payloads in one-step POST
woodster_elmiko: interesting that it wouldn't show up on db16:06
redrobotalee_ dave-mccowan jaosorior woot!  it merged! :D16:06
elmikowoodster_: that's what i though16:06
*** gyee_ has joined #openstack-barbican16:06
elmikowoodster_: i might not get to it for a few hours though, got some meetings coming up16:07
jaosoriorredrobot: might have been some connectivity issues in the gate... or something O_O16:08
jaosorioranyway, did reverify on the CRs that depended on that one16:11
woodster_elmiko: yeah meeting foo for me too16:11
elmiko\o/ yay meetings ;)16:12
jaosoriorredrobot: got a couple of minutes for this one?
jaosoriorwould be nice to get a working barbicanclient :P16:13
jaosorioralee_: by the way, what larger CR were you talking about? is it something that's uploaded yet? or is it to come?16:14
alee_jaosorior, its coming16:16
alee_jaosorior, fixes to dogtag plugin to get it to pass functional tests16:16
jaosorioralee_: Awesome, ping me when it's up16:17
alee_jaosorior, will do :)  cause no one will  test the changes except me :/16:18
jaosorioralee_: well, that re-asserts the needfor that gate16:20
openstackgerritJuan Antonio Osorio Robles proposed openstack/barbican: Refactor dogtag gate scripts
*** gyee_ has quit IRC16:43
*** kebray_ has joined #openstack-barbican16:45
*** kebray has quit IRC16:46
openstackgerritMerged openstack/python-barbicanclient: Adding payload flag to get secret
rm_work^^ BTW what did that really add? just… now you can use -d OR -p ?16:53
rm_workis there a plan to deprecate -d ?16:54
redrobotrm_work yeah, I was just wondering the same thing16:55
rm_workmerged before i managed to review, would have asked that16:55
redrobotrm_work the idea was that --decrypt was going to return the payload without the ascii box, but it appears that you can do that with the existing --decrypt16:55
redrobotderp --payload was going to be different16:56
rm_workso one option i mentioned was that you COULD print&bail16:56
redrobotbut now they're both the same16:56
rm_workand just dodge cliff16:56
rm_workbut that's a bit "dodgy" :P (pun intended)16:56
redrobotturns out cliff had an undocumented feature to allow non-boxy output16:56
rm_workyeah, kinda16:56
redrobotbut yeah, no value on that above CR16:56
rm_workbut still not what i would expect the output to be16:56
rm_workif args.payload: print(entity.payload); sys.exit(0)16:57
*** alee_ is now known as alee_lunch16:58
rm_workyou guys doing loonch today?16:58
rm_workstill waiting IPA-AH myself16:58
redrobotrm_work -f value doesn't do plain payoload?16:58
redrobotrm_work we're in the all hands still16:58
rm_workaccording to chellygel it does "value = payload"16:58
redrobotrm_work but yeah, loonch16:58
rm_workstill not JUST payload16:58
redrobotyeah....  so why did we merge the change >_<16:59
rm_workredrobot: i am at home right now but I could meet somewhere possibly :P let me know16:59
rm_workredrobot: do not know16:59
rm_workmy response when i saw the merge message in channel was "shit"16:59
rm_work"meant to comment on that"16:59
redrobotnow it just adds confusion on whether you should use --payload or --decrypt ...16:59
rm_work--payload matches the other operations now at least17:02
rm_workso "secret get -p" and "secret store -p"17:02
rm_workare similar17:02
rm_workI still don't like "store" BTW -- why mess with CR[U]D -- but whatever17:02
redrobotlol, you're beating a dead horse rm_work :-P17:03
rm_workhehe i know17:03
rm_workbut i mistype it virtually every time still17:03
rm_workand I've been using the client for quite a while17:03
redrobotrm_work well, good news is we've got a chance to fix it in the unified cli17:04
rm_workredrobot: IF you were going to grab loonch, where would that be, do you think?17:04
redrobotrm_work hoping this meeting will be over soon17:04
rm_workredrobot: also -- sorry if my constantly ribbing you about Thai Thai is annoying :P17:05
rm_workredrobot: well I still need to DRIVE17:05
redrobotrm_work we thinking Erick's?17:05
rm_workredrobot: so i need heads up17:05
rm_workredrobot: text me please if you leave :P17:08
redrobotrm_work meeting is just about over17:08
rm_workor change destination17:09
rm_workredrobot: yeah but I have to start driving NOW17:09
redrobotrm_work heading out in 517:09
*** tkelsey has joined #openstack-barbican17:11
*** stanzi has quit IRC17:33
*** stanzi has joined #openstack-barbican17:34
*** joesavak has joined #openstack-barbican17:35
*** jsavak has quit IRC17:38
*** stanzi has quit IRC17:38
*** rellerreller has joined #openstack-barbican17:40
*** jsavak has joined #openstack-barbican17:47
*** jsavak has quit IRC17:47
*** dave-mccowan has quit IRC17:50
*** joesavak has quit IRC17:51
*** alee_lunch is now known as alee_17:52
iguethsCan I get some +2's on Hopefully before the Devstack gate breaks for me again!17:55
openstackgerritMerged openstack/barbican: Fix handling of payload_content_encoding for orders
openstackgerritMerged openstack/barbican: Add utility functions to convert between and PEM and DER
*** joesavak has joined #openstack-barbican17:57
*** stanzi has joined #openstack-barbican17:57
*** rellerreller has quit IRC18:01
*** rellerreller_ has joined #openstack-barbican18:01
openstackgerritJuan Antonio Osorio Robles proposed openstack/barbican: Refactor dogtag gate scripts
openstackgerritDoug Hellmann proposed openstack/python-barbicanclient: Uncap library requirements for liberty
openstackgerritDoug Hellmann proposed openstack/python-kiteclient: Uncap library requirements for liberty
*** stanzi has quit IRC18:17
*** stanzi has joined #openstack-barbican18:17
*** tkelsey has quit IRC18:20
*** stanzi has quit IRC18:22
woodster_igueths: workflow +1!18:31
*** rellerreller_ has quit IRC18:35
iguethswoodster_: Awesome!18:51
openstackgerritMerged openstack/barbican: Potential resource exhaustion when registering consumers to containers
*** stanzi has joined #openstack-barbican19:27
*** nkinder has quit IRC19:32
-openstackstatus- NOTICE: gerrit has been restarted to clear a problem with its event stream. any gerrit changes updated or approved between 19:14 and 19:46 utc will need to be rechecked or have their approval reapplied for zuul to pick them up19:46
redrobotthanks for the heads up openstackgerrit19:47
redrobotor openstackstatus19:47
openstackgerritAde Lee proposed openstack/barbican: Fix Dogtag plugin to make latest functional tests pass
openstackgerritDouglas Mendizábal proposed openstack/barbican: Fix KMIP Secret Store input/output
alee_woodster_, redrobot jaosorior  -- changes to get dogtag plugin working19:49
redrobotalee_ nice!19:50
alee_redrobot, woodster_ jaosorior - with this , dogtag ca and kra pass all functional tests19:50
*** stanzi has quit IRC19:50
alee_so lets crank out those +2's :)19:50
*** stanzi has joined #openstack-barbican19:51
alee_jvrbanac, hockeynut ^^19:51
*** stanzi has quit IRC19:55
*** kebray_ has quit IRC20:01
*** stanzi has joined #openstack-barbican20:02
jaosorioralee_: just a very minor comment. Other than that a +2 from my side20:05
alee_jaosorior, looking20:06
alee_jaosorior, I guess there is no way for me to change the commit message without resubmitting, is there?20:09
redrobotalee_ you can edit it on gerrit20:10
jaosoriorUhm... I think you can edit it straight from gerrit20:10
alee_jaosorior, redrobot - cool - doing so right now20:10!20:11
woodster_elmiko, does you CR support mysql migrations then, or were there still some issues?20:12
redrobotalee_ jaosorior woodster_ the KMIP patch is up for review as well
woodster_...looking now....20:12
*** stanzi has quit IRC20:13
elmikowoodster_: it supports both20:13
*** stanzi has joined #openstack-barbican20:13
elmikowoodster_: the only outstanding question is the constraint issue20:13
elmiko(i have comments in the review)20:14
openstackgerritAde Lee proposed openstack/barbican: Fix Dogtag plugin to make latest functional tests pass
alee_jaosorior, redrobot -- modified20:15
woodster_elmiko: I had added comments since then...I'm thinking those constraints were just postgres ones that didn't really need to be there. As for adding named constraints to the models, we could take that on first thing in Liberty, no need to have in this CR20:15
alee_redrobot, guess the mod makes you add your +2 again ..20:15
elmikowoodster_: makes sense, should i remove the extraneous constraint stuff then?20:16
alee_redrobot, jaosorior thanks20:16
jaosorioralee_: +2 delivered20:16
alee_woodster_, need a whoop whoop please ! :)20:16
woodster_alee, there are lot out there, is their a preferred review order? :)20:17
*** stanzi has quit IRC20:17
elmikowoodster_: the name on those postgres constraints is incorrect anyways, not sure where alembic got those from20:17
woodster_elmiko: oh got it. Well, it is possible these were hand generated?20:19
elmikowoodster_: possible, but the comments seem to suggest otherwise. maybe best to just remove them?20:19
*** igueths has quit IRC20:20
elmikoeither that or fix the name20:21
elmikobut i'm unclear if that constraint even exists20:21
woodster_elmiko just for postgres though right?20:22
woodster_elmiko, it is a uniqueness constraint that wasn't is possible postgres optimizes that with no need for a constraint20:23
woodster_elmiko: my guess is that wasn't entirely auto generated20:23
*** major3rd has joined #openstack-barbican20:23
elmikowoodster_: ok, that would make more sense20:24
elmikowoodster_: on your comment in the review about adding named fk constraints, should i do that now or wait?20:25
alee_woodster_, whoop whoop?20:25
alee_woodster_, yes please20:25
*** igueths has joined #openstack-barbican20:26
alee_woodster_, awesome - thanks!20:26
*** major3rd has quit IRC20:28
*** joesavak has quit IRC20:30
openstackgerritChelsea Winfree proposed openstack/python-barbicanclient: Fix the clientrc file to match defaults and add docs
*** joesavak has joined #openstack-barbican20:32
*** kebray has joined #openstack-barbican20:33
*** jsavak has joined #openstack-barbican20:34
*** stanzi has joined #openstack-barbican20:35
woodster_elmiko: we can wait to do that...clean house first thing in Liberty then20:35
elmikowoodster_: ack20:36
elmikowoodster_: i'm gonna remove the extraneous postgres constraint stuff then20:36
woodster_elmiko, so I'd say once your patch is ready we can +2 it. I added a patch to my alembic change too, including adding more guidance for column migrations20:36
woodster_elmiko: sounds good20:37
woodster_alee, all those +2s should be good for my stackalytics!20:37
*** joesavak has quit IRC20:37
*** major3rd has joined #openstack-barbican20:41
major3rdHey guys. This is my first time in the IRC and I have some questions about barbican. Is there where I can ask for help?20:43
*** nkinder has joined #openstack-barbican20:45
redrobotmajor3rd ask away20:45
major3rdredrobot: Thanks. So I set up barbican in a development environment running Rhel 6.5 and I'm trying to utilize the kmip_plugin feature in barbican. However, I'm getting an SSL error. In the kmip_plugin section in barbican-api.conf file it requests a keyfile, certfile, and ca_certs. What exactly are those values suppose to be? I think that's why barbican is not working.20:48
redrobotmajor3rd hmm... I'm not so familiar with the KMIP plugin.  rellerreller or kfarr would know for sure, but unfortunately they're not on right now.20:49
*** kebray has quit IRC20:49
redrobotmajor3rd I want to say that they are required to establish a connection to your KMIP device?  ... but I may totally be making that up on the spot ;)20:49
openstackgerritChelsea Winfree proposed openstack/python-barbicanclient: Porting over more documentation to RST from cli wiki
major3rdhah thanks. I figured that's what they're for and I put what it sounds like should be there but it's still not working. Do you happen to know when they will be online?20:50
chellygelwoodster_, theres another set of docs to end your wiki :(20:51
redrobotmajor3rd rellerreller is usually around in the AM (PDT).  You can also shoot a question to the openstack mailing list.  kfarr is pretty good about answering emails about KMIP questions.20:52
*** kebray has joined #openstack-barbican20:52
major3rdredrobot thanks I'll do that. Thanks for your help!20:52
woodster_major3rd: also I was seeing an issue with kmip plugin __init__ exceptions not showing up in logs due to config issues. If you suspect that you could either debug through the setup, or try this CR out locally:
major3rdwoodster_: thanks! I'll look into it. Hopefully that should help.20:54
woodster_chellygel: wiki docs don't go down easy! Thanks for working to bury those though20:54
redrobotjaosorior alee_  oh wow, seems like the dogtag gate is working now!  It used to fail on DogTag installation, but it seems this last run failed because of actual failed tests! :-O20:54
redrobotjaosorior alee_  I'm going to rebase on top of your changes and see if it'll pass.20:55
chellygelwoodster_, i think that CR is the last of the CLI docs that existed in the wiki -- so thos ecan get blown away once published ! but the barbican proper docs... those will definitely take some time20:55
alee_cool beans!20:55
elmikowoodster_: checking out the downgrade on that project migration, it's a total mess because of all the indexes created20:56
elmikowoodster_: basically mysql wants all those constraints cleaned before dropping the index20:56
openstackgerritDouglas Mendizábal proposed openstack/barbican: Refactor dogtag gate scripts
woodster_elmiko: yeah, so we might have to do the approach similar to 795737bb3c3: auto-named to hard-named on upgrade, hard-named to auto-named on downgrade?21:05
elmikowoodster_: yea, could be. there is some extraneous stuff going on here. i'll post the review and maybe you can give some advice on which to name?21:06
openstackgerritChelsea Winfree proposed openstack/python-barbicanclient: Fix the clientrc file to match defaults and add docs
chellygelwoodster_, ^ fixed21:11
openstackgerritChelsea Winfree proposed openstack/python-barbicanclient: Porting over more documentation to RST from cli wiki
chellygeland woodster_ in regards to ^ -- i can't change that, that is how it is listed in the client itself -- I can fix it, but i think it would need to be a separate CR21:14
*** xaeth is now known as xaeth_afk21:17
openstackgerritChelsea Winfree proposed openstack/python-barbicanclient: Updating client and client docs for accuracy
chellygelwoodster_, ^ separate CR for URI/HREF issue21:23
*** xaeth_afk is now known as xaeth21:29
*** alee_ has quit IRC21:30
*** stanzi has quit IRC21:38
*** jamielennox|away is now known as jamielennox21:39
*** stanzi has joined #openstack-barbican21:39
*** kebray_ has joined #openstack-barbican21:39
*** kebray has quit IRC21:40
*** xaeth is now known as xaeth_afk21:41
*** SheenaG has quit IRC21:42
*** stanzi has quit IRC21:43
elmikowoodster_: i forget, are you one of the TX crew?21:47
*** major3rd has quit IRC21:48
*** paul_glass has quit IRC21:51
rm_workchellygel: an secret :P21:59
redrobotelmiko he is.  he's also distracted right now. (I can see him from my desk)21:59
elmikoredrobot: hehe, ok. didn't mean to bug ;)22:00
elmikomysql may or may not be driving me slightly crazy22:01
redrobotelmiko lol22:01
elmikowould it be too much to ask for a drop_index call to also remove the associated foreignkey.... ffffffffuuuuuuuuuuuuuu22:02
openstackgerritCharles Neill proposed openstack/barbican: Security tests for Secret resources
*** SheenaG has joined #openstack-barbican22:03
openstackgerritMerged openstack/barbican: Fix KMIP Secret Store input/output
openstackgerritMerged openstack/barbican: Fix Dogtag plugin to make latest functional tests pass
*** tkelsey has joined #openstack-barbican22:17
*** tkelsey has quit IRC22:22
elmikowoodster_: ok, i've got this working. big question, should i name all these foreignkeys in the troublesome migration?22:28
elmikomy worry is that it will make the review way more complicated22:28
*** jsavak has quit IRC22:31
*** dimtruck is now known as zz_dimtruck22:34
woodster_elmiko: you could make a dependent CR to fix that one migration script22:34
woodster_elmiko: so maybe put up what you have now to cap that CR off (so the upgrades work, not all the downgrades)?22:35
woodster_elmiko: is it mainly the FK constraints that are the issue?22:35
elmikowoodster_: actually, i've got the downgrades working as well, it's just very verbose as we need to drop the fk constraints for each index22:37
*** igueths has quit IRC22:39
openstackgerritMichael McCune proposed openstack/barbican: [WIP] Adding MySQL fixes to migrations
woodster_elmiko: well, I think that is a necessary beast unfortunately. Would you be able to add a function to do the heavy lifting to reduce lines of code?22:39
openstackgerritChelsea Winfree proposed openstack/python-barbicanclient: Updating client and client docs for accuracy
elmikowoodster_: yea, i did, similar to what you had before22:39
elmikowoodster_: that review i just posted works for up/down on both mysql and postgres22:40
elmikoi *think* we're good on mysql migrations /me fingers-crossed22:40
woodster_elmiko: that looks good to me! There are a lot of constraints in that module anyway.22:41
elmikowoodster_: yea22:41
elmikoand with luck it won't blow up redrobot's migration ;)22:41
woodster_elmiko: nice!22:42
woodster_elmiko: +222:42
redrobotwoot!  you're the man elmiko !22:42
elmikoha, just glad i could help =)22:43
redrobotelmiko wanna remove [WIP] from the title?22:43
woodster_alee, redrobot can you guys review these CRs?: and
elmikooh yea, sorry22:43
openstackgerritMichael McCune proposed openstack/barbican: Adding MySQL fixes to migrations
elmikosorry woodster_ you gotta review again now, on the upside it will help the stackalytics scores ;)22:44
elmikook, i'm gonna go not think about db migrations. have a good one all!22:45
*** alee_ has joined #openstack-barbican22:45
redrobotelmiko haha, well deserved.  thanks again!22:46
openstackgerritChelsea Winfree proposed openstack/python-barbicanclient: Fix the clientrc file to match defaults and add docs
woodster_elmiko: awesome work, thanks again!22:51
*** chadlung has joined #openstack-barbican22:52
*** nkinder has quit IRC22:59
*** chlong has joined #openstack-barbican23:02
woodster_arunkant, were you up for updating your CADF blueprint per comments?:  It probably needs to be moved to a new 'liberty' folder now too23:10
*** jaosorior has quit IRC23:12
*** bbby has left #openstack-barbican23:29
*** chadlung has quit IRC23:45
*** chadlung has joined #openstack-barbican23:46
openstackgerritMerged openstack/barbican: Security tests for Consumer resources
*** SheenaG has quit IRC23:49
*** chadlung has quit IRC23:53
*** SheenaG has joined #openstack-barbican23:55

Generated by 2.14.0 by Marius Gedminas - find it at!