Friday, 2015-05-15

*** salv-orlando has quit IRC00:03
*** sigmavirus24_awa is now known as sigmavirus2402:12
*** sigmavirus24 is now known as sigmavirus24_awa02:15
*** sigmavirus24_awa is now known as sigmavirus2402:40
*** sigmavirus24 is now known as sigmavirus24_awa02:52
*** HenryG has quit IRC03:51
*** alex_xu has joined #openstack-api05:24
*** HenryG has joined #openstack-api05:38
openstackgerritAlex Xu proposed openstack/api-wg: Clarify the return code when server have hard-code length limit  https://review.openstack.org/18178405:57
*** fzdarsky has joined #openstack-api07:09
*** fzdarsky has quit IRC07:17
*** gilliard is now known as gilllliard07:26
*** fzdarsky has joined #openstack-api07:30
*** woodster_ has quit IRC08:10
*** e0ne has joined #openstack-api09:55
*** e0ne is now known as e0ne_09:56
openstackgerritSean Dague proposed openstack/api-wg: http guideline expansion: background  https://review.openstack.org/18193109:59
openstackgerritSean Dague proposed openstack/api-wg: add section describing 501 common mistake  https://review.openstack.org/18345609:59
*** e0ne_ is now known as e0ne10:01
*** cdent has joined #openstack-api10:06
cdentHTTP is such a fine source of bikeshedding material10:07
sdagueheh10:11
sdagueI was wondering if you were going to be online today10:11
sdagueso... the 501 thing is why I still don't want "go to the rfc"10:11
sdagueas step 210:11
sdaguethat's how we got there10:12
sdagueI hopefully updated the wording on https://review.openstack.org/181931 to be ok with you10:12
sdaguealso - https://review.openstack.org/18345610:12
sdagueand you can read the initial conversation that got us there10:12
cdentthe final paragraph with “appropriate references to rfcs” is great and satisfies me10:12
cdentI’m happy with it10:12
sdaguecool10:12
cdentyeah, I was just on my way to that list thread10:13
cdentI _should_ be packing and otherwise preparing myself (my journey starts tomorrow early afternoon but I won’t be there until sunday evening) but I can’t seem to stay away...10:14
sdagueso, chris ferris and I argued against what was decided, but he had 0 pull, as he was a random architect at IBM, and my pull was very limitted. I eventually caved because I was arguing against one of the highest visibility devs at the time10:14
sdagueheh10:14
sdaguemy journey also starts tomorrow afternoon, but I need the rest of my house to wake up before I start figuring out packing10:15
cdentIf I had thought in advance I would own five pairs of exactly the same jeans and ten black t shirts: 5 short sleeved, 5 long10:16
cdentand then I’d be done10:16
cdentbut I guess I’m not that kind of person10:16
cdentI might be forced to wear this on at leat one day: http://www.zazzle.com/business_customized_t_shirt-23598970652042432410:16
cdentsdague: thanks for point to that bit of history. fascinating in the way it sort of illuminates some of our modern luminaries...10:21
sdagueheh10:24
sdagueboth on the shirt, and on the comments :)10:25
*** e0ne is now known as e0ne_10:31
*** e0ne_ is now known as e0ne10:33
*** cdent has quit IRC10:52
*** e0ne is now known as e0ne_11:26
*** e0ne_ is now known as e0ne11:48
gilllliardoh well,11:56
gilllliardinteresting reading on the old ML, thanks sdague11:56
gilllliardNova API meeting in 3 minutes, btw11:57
gilllliard#openstack-meeting11:57
sdaguegilllliard: yeh, I figured that historical context would be useful11:57
sdagueI'm surprised it wasn't cancelled this week11:58
sdaguegiven all the inflight people11:58
sdagueI've got to get back to packing, so will not be there11:58
gilllliardsdague: it wasn't cancelled, and there's some agenda, so I'll pop along and see if anyone else is there.11:59
*** gilllliard is now known as gilliard_en_rout12:09
*** e0ne is now known as e0ne_12:22
*** e0ne_ is now known as e0ne12:26
*** annegentle has joined #openstack-api12:48
*** e0ne is now known as e0ne_12:54
*** e0ne_ is now known as e0ne12:56
openstackgerritSean Dague proposed openstack/api-wg: add section describing 501 common mistake  https://review.openstack.org/18345613:23
*** woodster_ has joined #openstack-api13:41
openstackgerritSean Dague proposed openstack/api-wg: add subsection around caching behavior and http  https://review.openstack.org/18352313:45
sdagueryansb: so I coppied the format of other links in there, what's the right link syntax I should use? I seriously always mix up all the link semantics in my head13:53
ryansbsdague: `link title<http://link.com/foo>`_13:54
sdagueryansb: ok, great, I'll fix this last patch13:54
ryansb(rst link syntax makes me very sad compared to markdown)13:54
ryansbthanks :)13:55
*** cdent has joined #openstack-api13:55
ryansbyou can also do13:55
ryansbLink_13:55
ryansb.. _Link: http://foo.bar/baz13:55
ryansbbut that's a bit harder to follow13:55
sdagueyeh, that seems less source readable13:56
openstackgerritSean Dague proposed openstack/api-wg: add subsection around caching behavior and http  https://review.openstack.org/18352313:56
sdagueok, I guess I should fix the whole stack, eh?13:57
*** annegentle has quit IRC13:59
openstackgerritSean Dague proposed openstack/api-wg: http guideline expansion: background  https://review.openstack.org/18193113:59
openstackgerritSean Dague proposed openstack/api-wg: add subsection around caching behavior and http  https://review.openstack.org/18352313:59
openstackgerritSean Dague proposed openstack/api-wg: add section describing 501 common mistake  https://review.openstack.org/18345613:59
sdagueryansb: ok, that fixes the links in the whole stack14:00
ryansbsdague: :)14:00
elmikoi gotta move faster, my drafts keep getting over-written ;)14:01
elmikoyou're too fast sdague!14:01
sdaguewhat's the approval / merge process look like for the group. As I'm relatively new in contributing, mostly spurred on by cdent and jaypipes discussions over the last couple of weeks.14:01
sdagueelmiko: :)14:01
sdagueI also take feedback over irc14:01
sdague:)14:01
elmikowe have usually been pretty conservative with our merge process. allow time for everyone to take a look and comment.14:02
sdagueok, no prob.14:02
elmikousually things get merged with like +8 or more responding14:02
cdentThe merging process appears to be complete magic14:02
sdaguehopefully most of this is pretty ack kind of stuff, except for that 501 discussion14:02
cdentpeople talk, have coffee, and then after a while stuff merges14:03
elmikoyea, what cdent says is pretty accurate14:03
sdaguecdent: I have a new subsection up that you will probably appreciate14:03
sdagueok, there is a little girl demanding attention here, so away for a bit14:03
elmikocdent: i don't think it's complete magic, but there is some mystery14:05
elmiko;P14:05
elmikothe way i see it, patches are up for long enough that everyone could get a look and comment.14:05
cdentI know that there is some logic behind it, it’s not obvious. And I think that’s fine. It seems that things pootle along for a while and then when various things signal consensus a merge happens.14:06
elmikosince many folks don't check the api-wg reviews that frequently it can take time to build consensus14:06
elmikoyea, i think that's accurate14:06
cdentIt works! \o/14:08
*** salv-orlando has joined #openstack-api14:08
*** sigmavirus24_awa is now known as sigmavirus2414:24
etoewssdague: here's what we have in terms of formal process http://specs.openstack.org/openstack/api-wg/process.html14:24
etoewsfor merging that is14:25
elmikoooh, good link!14:25
etoewsthe more informal goes something like this:14:28
etoews1. discuss within the wg until consensus is reached within the wg14:28
etoews2. expand to cross-project liaisons (this is where it gets a bit fuzzy)14:28
etoews3. bring up consensized guidelines at a cross-project meeting14:28
etoews4. "freeze" the guideline with a -1 workflow for 1 week while waiting for feedback from CPLs14:28
etoews5. merge after 1 week on lazy consensus or rework as necessary14:28
cdentconsensized is a nice word14:29
etoewswe really only arrived at that process a couple of weeks ago. probably why it appears to be magic.14:29
etoewsi'm definitely happy to accelerate the process14:30
elmikoetoews: how strongly should we follow #4, is that a hard -1 after the cross-project discussion?14:30
etoewsthe -1 workflow is just so it doesn't get merged "accidentally"14:30
elmikogot it14:30
etoewssigmavirus24 and someone else suggested it.14:30
sigmavirus24I am to blame14:31
sigmavirus24I'm sorry14:31
sigmavirus24And you're welcome14:31
etoews:)14:31
elmikoit's a good idea14:31
*** annegentle has joined #openstack-api14:31
etoewsthis is good fodder for discussion at the summit14:31
etoewswe could take one of the working sessions to update http://specs.openstack.org/openstack/api-wg/process.html with this info if all are agreeable14:32
elmikothat could be cool14:32
etoewsadded it to the etherpad https://etherpad.openstack.org/p/liberty-cross-project-api-wg14:34
ryansbI like that merge process (though it isn't the fastest) since our specs rely so hard on consensus/acceptance from project devs14:42
elmikoagreed, i think it makes sense14:44
*** salv-orlando has quit IRC14:46
openstackgerritMerged openstack/api-wg: Change RFC2616 links to RFCs 723[0-5]  https://review.openstack.org/17744514:59
*** cdent_ has joined #openstack-api15:09
*** cdent has quit IRC15:09
*** cdent_ is now known as cdent15:09
cdentetoews: “I've seen it happen with 4xx status codes”. Where was that? That’s a) surprising b) saddening.15:27
etoewsi think it was heat15:28
etoewsbut working off devstack so it may have been in debug mode15:28
cdenteven so, still weird15:28
etoewsi also swear i've seen it before but can't quite recall exactly where15:29
cdentbut then again, I recently discovered that WSME was logging 4xx as WARN not DEBUG15:29
cdentwhich struck me as completely surprising15:29
etoewsdanger. the user is doing something wrong.15:30
cdentpanic. now.15:30
ryansbwhoa, users make mistakes? Hold up.15:42
sdagueetoews: yeh, I'm unlikely to make the session because of all the cross neutron / nova network things. But will try to connect.15:42
etoewssdague: sounds good. we're also having follow up working sessions on wed and thurs. see the bottom of https://etherpad.openstack.org/p/liberty-cross-project-api-wg15:45
sdagueyeh... well... being involved in nova means my design summit week is mostly predetermined. Perhaps drinks at some point.15:49
elmikohehe15:49
etoewsat least the keeps it simple for you :)15:57
etoewsso i'm looking at https://review.openstack.org/#/c/181784/6/guidelines/http.rst15:57
etoewsto me this sounds like basic input validation stuff, just return a 400.15:58
etoewsdoes it really need a guideline? seems like this is covered by rfcs.15:58
cdentaye, there’s the rub15:58
elmikogood point, but didn't this specific example come up at some point?15:58
cdentthe specific example did come up and the getting this particular submission to come round to 400 was a bit of struggle15:59
elmikoimo, this is ripe material for separating the response codes into a separate guidelines and to make use of the "Examples" section for clarity.16:00
cdentetoews: originally it was 403, and I assume the introduction of the 403 text, now that it has been changed to 400, is to clarify that doubt16:01
cdentthis goes back, as we often do, to the question of how much are we supposed to be recapitulating the rfcs and/or expecting to already know them16:02
etoewsi'm fine recapitulating the rfcs when there's some ambiguity or there a reason openstack does things some particular way.16:04
etoewsbut this is input validation16:04
cdentapparently for this person there was ambiguity16:04
etoewsi would hope that returning a 400 doesn't need to be recapitulated.16:04
*** annegentle has quit IRC16:04
etoewsright16:04
cdentI would hope that too, but the evidence suggests otherwise16:04
etoewsi might need to ... calibrate ... my perspective on this.16:05
cdentyes, I’ve had to do a _lot_ of calibration16:07
cdentAnd realize that the main win we’re ending up with in this stuff is an educational resource16:07
elmiko+116:07
etoewsthat's exactly where my thinking was going too16:07
elmikoi find it to be helpful16:08
elmikobut i'm not sure how much of the rfc's we are restating16:08
etoewsperhaps there's a larger educational role for the api wg than i anticipated.16:08
cdentI was going through Jay’s slides and realized that his goals for the wg were a lot more about api consistency, which is good, but it seems a distance off from just doing http okay16:08
elmikoto build consistency though, especially with a variable developer pool, don't we have to educate a little bit?16:09
elmikosorry to question and run, but i gtg. back later16:09
cdentelmiko: yes, exactly16:09
etoewsokay. this really helps me a lot.16:10
cdentFrom what I’ve experienced a vast number of the people contributing to openstack are not hugely experience in either http or python.16:10
openstackgerritSean Dague proposed openstack/api-wg: http guideline expansion: background  https://review.openstack.org/18193116:10
openstackgerritSean Dague proposed openstack/api-wg: add subsection around caching behavior and http  https://review.openstack.org/18352316:10
openstackgerritSean Dague proposed openstack/api-wg: add section describing 501 common mistake  https://review.openstack.org/18345616:10
cdentAnd that’s great in the sense that we’ve got a big community16:10
cdentbut it does imply a requirement to be educational16:10
sdagueok, rebased after the rfc update bits, and fixing some of the latest comments and links16:11
sdaguecdent: I would 100% agree with you.16:11
sdagueetoews: so... I would say 80+% of the folks that are implementing the API side of openstack services, this project was the first time they did anything at the HTTP level16:12
sdagueso... recapitulating basic http stuff is needed16:13
sdagueotherwise, you get the 501 situation16:13
cdent16:13
sdagueI think looking at how that conversation happened historically, where we ended up, and what it's going to take to reverse it is really educational in grasping where the basic knowledge levels started with16:14
etoewssdague: that's very good to know. i added a note about the "educational aspect" to the etherpad and i think i'll update my blog post too.16:14
*** e0ne is now known as e0ne_16:15
sdaguecdent: so I'll at one more thing to your first time list16:16
sdaguefor a vast number of people contributing to openstack, this is the first open source project they've ever contributed to16:16
cdentyeah16:16
cdentI had a realization the other day: I’ve never worked on not open source16:17
sdagueetoews: and, honestly, I think getting the logging guidelines written down last year was a really interesting educational experience of "most people just had no idea things they were doing were whacky, and were happy to change as long as someone told them why and how"16:18
sdaguehttps://blogs.gnome.org/markmc/2014/06/06/an-ideal-openstack-developer/ gets to the heart of it kind of nicely16:19
sdaguethere is a ton of stuff one really *should* know to contribute to openstack, to the point that no one actually does16:19
cdentI saw that talk (in London)16:19
*** e0ne_ is now known as e0ne16:20
sdagueit would have been fun to see :)16:20
etoewsmy perspective has been calibrated :)16:20
cdentwas that that grinding noise?16:20
etoewssmoke is pouring out of my ears.16:21
sdagueheh16:21
sdagueit's fine, as long as you think of it as a long game, things get written down now, and 2 or 3 years later, it's better16:21
* cdent notes he still hasn’t started packing16:23
sdagueheh, I did accomplish that16:24
openstackgerritSean Dague proposed openstack/api-wg: http guideline expansion: background  https://review.openstack.org/18193116:27
openstackgerritSean Dague proposed openstack/api-wg: add subsection around caching behavior and http  https://review.openstack.org/18352316:27
openstackgerritSean Dague proposed openstack/api-wg: add section describing 501 common mistake  https://review.openstack.org/18345616:27
sdaguethat should finally fix those sphinx links16:27
sdagueman, that is a gorpy and fragile syntax16:27
* cdent is not a fan16:28
* cdent communes with his suitcase16:34
openstackgerritJay Pipes proposed openstack/api-wg: Add guidance on 500 Internal Server Error  https://review.openstack.org/17936516:35
*** e0ne has quit IRC16:37
openstackgerritJay Pipes proposed openstack/api-wg: Should not return server-side tracebacks  https://review.openstack.org/18359916:40
openstackgerritJay Pipes proposed openstack/api-wg: Adds clarifications on state-conflicting requests  https://review.openstack.org/18009416:40
openstackgerritJay Pipes proposed openstack/api-wg: Adds clarifaction on when to use 409  https://review.openstack.org/17938616:41
*** subscope has joined #openstack-api16:47
*** fzdarsky has quit IRC17:00
*** annegentle has joined #openstack-api17:05
*** annegentle has quit IRC17:10
*** e0ne has joined #openstack-api17:15
*** annegentle has joined #openstack-api17:35
*** annegentle has quit IRC17:40
*** subscope has quit IRC17:44
*** subscope has joined #openstack-api17:49
*** annegentle has joined #openstack-api18:11
*** openstackgerrit has quit IRC18:22
*** openstackgerrit has joined #openstack-api18:23
*** cdent has quit IRC18:23
sdagueetoews: so for stuff like the comment here - https://review.openstack.org/#/c/183456/ how would you feel about setting ground rules that people should just fix and upload changes like that? Instead of adding review cycle delay.19:18
sdaguewe often do that in nova, just fix the typo, then stick our +2 on it19:18
elmikodoc team does that too, iirc19:21
sdaguehaving realized that the etherpad on http has just lived in this channel, I just sent out an email about it.19:24
sdaguesee if people are up for grabbing a bullet or two before getting on a plane.19:25
elmikoawesome!19:28
elmikosdague: so, we have the 2xx codes stuff in there. did you envision it changing?19:32
*** annegentle has quit IRC19:33
elmikomaybe it should be formatted more as natural text than bullet points19:34
*** sigmavirus24 is now known as sigmavirus24_awa19:38
elmikosdague: (looking at the etherpad) i'm a little confused about the "never use 5xx" comment. shouldn't it be used if the server has an error?19:40
*** subscope has quit IRC19:54
sdagueelmiko: the applications shouldn't intentionally create a 5xx19:56
sdagueso, the 2xx content is currently totally reasonable, we may want to think about clarity later, I was mostly going to leave as is19:56
elmikosdague: ok, so only the framework should be returning a 5xx. like if an exception gets thrown.19:56
sdagueyeh19:56
elmikook.19:57
elmikoi'm not quite confident enough in my advice to tackle one of these, but i'm trying to understand more.19:57
*** fzdarsky has joined #openstack-api19:59
sdagueok, no problem19:59
elmikoi'll try and take a stab at the 5xx case, i think that makes sense to me20:00
sdaguemaybe it will spur cdent into snagging some20:00
sdagueelmiko: cool, thank you20:00
elmikosdague: do you think it's better to create a new patch from master or depend on your chain?20:02
sdagueI'm not sure it matters20:02
elmikok20:02
elmikothanks for the advice =)20:02
sdaguethere will be some merge conflicts, but they will be easy to resolve20:02
elmikofor sure20:02
elmikoand then for 1xx, we should just never be generating them, correct?20:03
sdaguecorrect20:05
elmikocool20:05
sdagueetoews: https://review.openstack.org/#/c/131725 - seems stalled out?20:11
elmikomaybe we should combine it and the dependency into a new CR using the template?20:14
etoewssdague: looking...20:14
etoewssdague: that one seems to be superseded by https://review.openstack.org/#/c/131726/20:17
etoewsodd to do those as 2...20:17
elmikoyea20:17
etoewswe do want to say something about api documentation20:18
etoewsit came up with annegentle a week or two back20:19
etoewsand we agreed that documentation was in scope for creating guidelines around20:21
etoewshowever, i know for a fact that the original author of those patch sets, Sam Harwell, is no longer working on anything openstack related.20:21
etoewsi'm pretty sure we won't be seeing any updates from him20:22
etoewsso either we patch over them or abandon the patch sets altogether20:22
etoewsi'd like to get anne's opinion before we make a decision there20:24
etoewsbut i suspect she won't have a chance to render an opinion before the summit20:24
elmikohmm, reading through that second CR i think this may be a large can of worms...20:24
sdagueyeh, it seems just orthoginal at this point realistically20:25
*** fzdarsky has quit IRC20:30
openstackgerritMichael McCune proposed openstack/api-wg: Adding 1xx guidance  https://review.openstack.org/18369420:34
*** annegentle has joined #openstack-api20:44
annegentlehey20:45
elmikohi20:46
openstackgerritMichael McCune proposed openstack/api-wg: Adding 5xx guidance  https://review.openstack.org/18369820:46
openstackgerritMichael McCune proposed openstack/api-wg: Adding 1xx guidance  https://review.openstack.org/18369420:48
*** annegentle has quit IRC21:49
*** annegentle has joined #openstack-api21:51
*** annegentle has quit IRC22:51
*** elmiko is now known as _elmiko22:57
*** terrylhowe has quit IRC23:03
*** e0ne has quit IRC23:04
*** annegentle has joined #openstack-api23:51
*** annegentle has quit IRC23:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!