| opendevreview | Tobias Rydberg proposed opendev/irc-meetings master: Public Cloud SIG holds its meeting at 0800 UTC during winter time. https://review.opendev.org/c/opendev/irc-meetings/+/900025 | 09:20 |
|---|---|---|
| frickler | 900k \o/ | 09:29 |
| opendevreview | Martin Kopec proposed opendev/irc-meetings master: [iwg] Update office hour date and time https://review.opendev.org/c/opendev/irc-meetings/+/900027 | 09:35 |
| opendevreview | Merged opendev/irc-meetings master: Public Cloud SIG holds its meeting at 0800 UTC during winter time. https://review.opendev.org/c/opendev/irc-meetings/+/900025 | 11:38 |
| amorin | hey all, the mistral team is struggling figuring out why devstack keeps failing in CI while it seems working correctly when executed manually. The last change we did is the following: https://review.opendev.org/c/openstack/mistral/+/899169/2 | 12:29 |
| amorin | As you could see, per Jan comment, apache wsgi seems not able to find mistral wsgi script, even if it was sucessfully installed. I dont get how we endup in this situation, my manual check were not doing the same result | 12:31 |
| fungi | amorin: is it only happening with the latest version of pip? | 12:31 |
| fungi | amorin: did you see this discussion? https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/HVFN5RBSHRTM3B2UUKPAWKH6H6AT6CYR/ | 12:32 |
| amorin | let me check the pip version | 12:33 |
| fungi | amorin: the tl;dr is that with pip 23.1 or later, if the project is relying on pbr to set up wsgi entrypoints, "editable mode" (pip install -e) a.k.a. use_develop=true in tox.ini doesn't install them unless the project has a pyproject.toml file specifying pbr as a build-system.build-backend | 12:36 |
| fungi | using older pip or not using editable mode are a couple of possible workarounds, depending on the situation | 12:37 |
| amorin | why then would it work manually but not in CI? | 12:37 |
| fungi | without knowing how your local environment differs from ci (particularly what version of pip you're using and how you're calling it), it's hard to say | 12:38 |
| amorin | my "system" pip is the following: pip 22.0.2 from /usr/lib/python3/dist-packages/pip (python 3.10) | 12:38 |
| amorin | ubuntu 22.04 | 12:38 |
| fungi | i'm checking that mistral-devstack log to see if it's using pip 23.1 | 12:40 |
| amorin | 2023-10-25 14:12:17.987653 | controller | Found existing installation: pip 22.0.2 | 12:41 |
| amorin | 2023-10-25 14:12:18.219253 | controller | Uninstalling pip-22.0.2: | 12:41 |
| amorin | 2023-10-25 14:12:18.231134 | controller | Successfully uninstalled pip-22.0.2 | 12:41 |
| amorin | 2023-10-25 14:12:19.407380 | controller | Successfully installed pip-23.3.1 | 12:41 |
| amorin | seen in logs | 12:41 |
| fungi | bingo | 12:41 |
| amorin | https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_bd2/899169/4/check/mistral-devstack/bd23c56/job-output.txt | 12:41 |
| amorin | perfect! you are amazing fungi! | 12:41 |
| fungi | if i can be amazing just by reading the openstack-discuss mailing list, i've probably been trying too hard ;) | 12:42 |
| amorin | lol | 12:42 |
| amorin | is a decision taken regarding the solution? pyproject.yaml file is the future? | 12:43 |
| fungi | amorin: in the initial message in that thread sean also proposes a temporary alternative to cap the pip version in devstack, but it seems like there's a rough consensus that we'll start adding minimal pyproject.toml files with https://review.opendev.org/899519 for keystone as an example | 12:46 |
| fungi | looks like that change is currently blocked on some test bitrot in keystone | 12:47 |
| amorin | ok, perfect then I'll add the same for mistral and link it to the same topic, thanks | 12:47 |
| fungi | amorin: oh, yep looks like https://review.opendev.org/q/topic:pip-23.1-support has a bunch now as of yesterday | 12:47 |
| amorin | yup | 12:48 |
| fungi | sean's not in here, but i'll mention it in #openstack-infra | 12:48 |
| fungi | amorin: sean points out there's a script at https://etherpad.opendev.org/p/pep-517-and-pip-23#L21 if you want to propose multiples | 12:51 |
| fungi | and also some cross-project tracking notes in there | 12:52 |
| amorin | ack thanks, will do mistral manually for now, maybe other mistral stuff with the script later | 12:52 |
| amorin | here is the patch | 12:57 |
| amorin | https://review.opendev.org/c/openstack/mistral/+/900038 | 12:58 |
| amorin | last thing I want to ask, we are fixing multiple things in mistral (see the relation chain). I expect only the last one will get the v+1, who should I ask for a manual v+1 on previous commits ? | 12:59 |
| amorin | or maybe it's handled automatically by zuul? | 12:59 |
| fungi | amorin: if you need to fix multiple things at once, you can either squash them into a single change (we did that yesterday to get pbr's tests passing, for example), or you can temporarily disable the failing jobs and enable them again once the necessary changes to make them pass are merged | 13:01 |
| amorin | I was thinking that it would be better to keep the changes in separate commits. | 13:01 |
| amorin | I am ok with disabling the failing jobs, is it something I should do in .zuul.yaml ? | 13:02 |
| amorin | adding voting: false is the trick, right? | 13:02 |
| fungi | yeah, or just commenting out/deleting them in the check and gate pipelines | 13:05 |
| kevko | fungi: don't know how but i fixed it :D | 14:53 |
| kevko | hello \o/ | 14:54 |
| fungi | what did you change? | 14:55 |
| kevko | guys, can I have two depends-on in a review ? will it work ? (btw, one is merged ...but i don't want to replace it because i want to track it ) | 14:55 |
| kevko | https://review.opendev.org/c/openstack/kolla-ansible/+/899901/16 << probably this fungi | 14:55 |
| kevko | fungi: and this https://github.com/openstack/ansible-collection-kolla/commit/8b4437f94363b5103e41902df7f8d07b10a09bea | 14:56 |
| fungi | you can specify multiple depends-on yes. whether it will work depends more on what your expectations are, if your jobs are configured to consume git repository source for the projects where the depended-on changes reside, and other factors | 14:56 |
| kevko | but it was really long night ..so it's possible that in some point i've was glad that it works so i reverted everything and i was happy that it is working :D | 14:57 |
| fungi | in particular, avoid making dependency loops, since zuul won't be able to untangle them into a linear series | 14:57 |
| kevko | yeah ..i know | 14:57 |
| fungi | also jobs need to set required-projects to include the projects you want to depends-on to | 14:58 |
| fungi | otherwise zuul won't prepare speculative checkouts for them | 14:58 |
| *** diablo_rojo is now known as Guest5670 | 15:18 | |
| kevko | hmm, fungi, okay .. why this patch https://review.opendev.org/c/openstack/kolla-ansible/+/900055/1 is not running letsencrypt tests ? can u check please ? | 15:41 |
| clarkb | kevko: did you put the new test in a pipeline? | 15:44 |
| fungi | looks like it's setting a feature flag var for the job | 15:44 |
| clarkb | I think the jobs aren't in any pipeline so they don't run. But that is after a quick skim of the change stack | 15:45 |
| fungi | yeah, the parent change defines kolla-ansible-lets-encrypt-base but doesn't instantiate it into any pipeline | 15:46 |
| fungi | same for kolla-ansible-ubuntu-lets-encrypt and kolla-ansible-rocky9-lets-encrypt | 15:46 |
| fungi | i guess kolla-ansible-lets-encrypt-base isn't meant to be added to any pipeline, but kolla-ansible-ubuntu-lets-encrypt and kolla-ansible-rocky9-lets-encrypt presumably should be | 15:47 |
| fungi | kevko: i think you want to insert them into check and gate sections in https://opendev.org/openstack/kolla-ansible/src/branch/master/zuul.d/project.yaml | 15:49 |
| fungi | or whatever pipelines make sense | 15:49 |
| kevko | hmm thanks | 15:58 |
| kevko | i am going to try | 15:58 |
| kevko | fungi: thank you very much ..it looks like it helps :) | 16:13 |
| *** dhill is now known as Guest5683 | 18:28 | |
| opendevreview | Julia Kreger proposed openstack/diskimage-builder master: Skip glean-install for ironic ramdisks https://review.opendev.org/c/openstack/diskimage-builder/+/900083 | 19:46 |
| clarkb | the gitea 1.21.0 release is imminent. Apparently the last todo on their side is writing the release documentation/blog | 21:09 |
| clarkb | I guess that includes a changelog because that doesn't exist yet either | 21:09 |
| fungi | writing changelogs after the fact seems so 1995 | 21:26 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!