| frickler | wow. $ curl -s https://zuul.opendev.org/api/tenant/openstack/config-errors|jq '.[].name '|grep Regex|wc -l | 10:04 |
|---|---|---|
| frickler | 220 | 10:04 |
| fungi | is that lower than previous? | 11:40 |
| frickler | no, that's completely new, caused by the next incompatible change zuul is planning. and I really wonder who is (expected to be) going to amend all the configs this time round | 13:49 |
| frickler | weird coincidence, the total number of current config errors is exactly the size of the electorate for the current election | 13:49 |
| fungi | which incompatible change? | 14:06 |
| fungi | oh, the regex deprecation | 14:07 |
| fungi | luckily it seems to be concentrated in a relatively small number of repositories | 14:08 |
| fungi | i wonder how ^(?!^zuul$)\S+$ should be rewritten to be re2 style instead of perl style | 14:10 |
| fungi | looks like pcre's negative lookahead is the problem | 14:11 |
| fungi | https://github.com/google/re2/issues/156 | 14:12 |
| fungi | "As a matter of principle, RE2 does not support constructs for which only backtracking solutions are known to exist. Thus, backreferences and look-around assertions are not supported." | 14:12 |
| fungi | okay, so not solveable directly in the regex string, but https://review.opendev.org/892060 provides a solution | 14:15 |
| fungi | regex: ^zuul$ | 14:18 |
| fungi | negate: true | 14:19 |
| fungi | something like that | 14:19 |
| fungi | luckily, deprecation warnings don't block config loading like config errors do | 14:22 |
| fungi | the last time we had a major backward-incompatible change to zuul configuration, we warned people about it for a year but nobody noticed until it actually took effect and became a syntax error, so hopefully the ability to have non-fatal deprecation warnings this time will increase the visibility and lead to fewer unpleasant surprises | 14:24 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!