| Clark[m] | ianw sorry ended up outside with kids since it finally stopped raining. Will look in a bit | 00:07 |
|---|---|---|
| Clark[m] | Re checking migrations it should check the notedb version stamp. The thing you set to the old value if downgrading | 00:08 |
| ianw | Clark[m]: don't worry too much | 00:08 |
| ianw | Clark[m]: https://bugs.chromium.org/p/gerrit/issues/detail?id=16839#c1 is where i got to | 00:10 |
| ianw | basically i think it has done what we asked it to do, as copyAllScoresIfNoChange defaults to true | 00:10 |
| Clark[m] | Oh interesting. | 00:11 |
| ianw | i'm not sure if this migration is supposed to run every single time, it says its idempotent | 00:12 |
| ianw | so if it does run every single upgrade, we probably want to get our acl's in the exact same format as it's expecting so that it doesn't keep rewriting them | 00:13 |
| ianw | i guess it is only called from "public class Schema_185 implements NoteDbSchemaVersion" | 00:15 |
| ianw | that makes sense and why you can just edit the schema version to 184 and be OK -- because the copyConditions are understood by 3.6 | 00:16 |
| ianw | and re-upgrading to 185 is idempotent | 00:17 |
| clarkb | I think it won't even try to reapply them if set to 185 (like we currently are | 00:32 |
| clarkb | but ya should be fine going back and forth as long as you adjust that version to match the gerrit version | 00:32 |
| clarkb | so I guess NO_CHANGE would've already been euqivalent to what we had and meeting the criteria for it is super weird and unlikely to really ever happen in practice. I think for Verified and Workflow we still don't want it but for other labels it is likely far more harmless | 00:36 |
| clarkb | sounds like only the only label got it added that wasn't already copy condition TRIVIAL_REBASE? the impact is pretty minor in that case | 00:36 |
| opendevreview | Ian Wienand proposed openstack/project-config master: Indent Gerrit ACL options https://review.opendev.org/c/openstack/project-config/+/879906 | 01:39 |
| opendevreview | Ian Wienand proposed openstack/project-config master: gerrit/acls : add NO_CODE_CHANGE https://review.opendev.org/c/openstack/project-config/+/880115 | 01:39 |
| opendevreview | Matthew Thode proposed ttygroup/gertty master: make gertty work with sqlalchemy-2 https://review.opendev.org/c/ttygroup/gertty/+/880123 | 04:46 |
| prometheanfire | seems to work alright, never used sqlalchemy before | 04:47 |
| opendevreview | Ian Wienand proposed opendev/infra-specs master: zuul-credentials : new spec https://review.opendev.org/c/opendev/infra-specs/+/821645 | 05:09 |
| opendevreview | Ian Wienand proposed opendev/system-config master: gerrit: add NO_CHANGE to verified/workflow copyConditions https://review.opendev.org/c/opendev/system-config/+/880124 | 06:11 |
| *** amoralej|off is now known as amoralej | 07:39 | |
| *** amoralej is now known as amoralej|lunch | 10:56 | |
| *** amoralej|lunch is now known as amoralej | 12:28 | |
| frickler | clarkb: I may be a couple of minutes late | 13:58 |
| clarkb | frickler: ok | 13:58 |
| clarkb | I'm about to jump into the call now | 13:58 |
| clarkb | paulali[m]: we are in https://meetpad.opendev.org/opendev-contributor-bootstrap-202304 if you are still able to join us | 14:03 |
| paulali[m] | clarkb: just joining in a bit. | 14:04 |
| frickler | I hadn't seen that "meeting terminated" thing before, is that a special button or just default when the moderator leaves? | 15:08 |
| clarkb | frickler: ya the moderator has a leave meeting button or end meeting for everyone button | 15:09 |
| frickler | ah, cool | 15:09 |
| clarkb | If you click the end meeting foreveryone function then others see it as terminated | 15:09 |
| clarkb | infra-root I think we can start looking at removing old static now https://review.opendev.org/c/opendev/system-config/+/880086. | 15:23 |
| clarkb | corvus: also https://review.opendev.org/c/opendev/zone-zuul-ci.org/+/879783 is zuul domain specific revert of short ttls on those records if you think we are ready for that | 15:23 |
| clarkb | frickler: it seems that usp parameter is logged internally in a way that plugins can hook into but there is no known public plugin that does so yet. Definitely feels like functionality that google is using internally that we all have to live with now :/ | 16:05 |
| opendevreview | Clark Boylan proposed opendev/zone-opendev.org master: Update etherpad.o.o to point at etherpad02 https://review.opendev.org/c/opendev/zone-opendev.org/+/880168 | 16:38 |
| opendevreview | Clark Boylan proposed opendev/zone-opendev.org master: Cleanup etherpad DNS records https://review.opendev.org/c/opendev/zone-opendev.org/+/880169 | 16:38 |
| clarkb | this is prep work for the eventual etherpad switch. I'm going to WIP both of them as I'm not ready for that yet (I want to test the db migration first and ensure 02 is happy) | 16:39 |
| clarkb | fwiw I think I'd like to finish up static01 cleanup before thinking about etherpad too much. That way I can focus on fewer things at once if ya'll need to prioritize reviews | 16:43 |
| *** amoralej is now known as amoralej|off | 16:52 | |
| corvus | clarkb: 783 approved but see comment from frickler | 17:44 |
| clarkb | oh I thought we had set our default ttl to an hour across the board already | 17:45 |
| clarkb | I'll look at gating.dev's zonefile too and push changes for that | 17:45 |
| opendevreview | Clark Boylan proposed opendev/zone-zuul-ci.org master: Set default ttl to one hour https://review.opendev.org/c/opendev/zone-zuul-ci.org/+/880213 | 17:48 |
| clarkb | remote: https://review.opendev.org/c/opendev/zone-gating.dev/+/880214 Set default ttl to one hour | 17:50 |
| clarkb | corvus: frickler ^ thanks for that | 17:50 |
| opendevreview | James E. Blair proposed zuul/zuul-jobs master: WIP: Update promote-container-image to copy from intermediate registry https://review.opendev.org/c/zuul/zuul-jobs/+/878538 | 17:50 |
| opendevreview | Merged opendev/zone-zuul-ci.org master: Revert short @ record TTLs https://review.opendev.org/c/opendev/zone-zuul-ci.org/+/879783 | 17:52 |
| clarkb | If anyone has time to sanity check https://review.opendev.org/c/opendev/system-config/+/880086 to remove static01 from inventory that would be much appreciated. I don't want to self approve that without any reviews. The change itself is straightforward mostly looking for judgement call on being ready to say we won't revert to the old server | 17:53 |
| prometheanfire | I don't think gertty is being dev'd on much, but if it is, getting https://review.opendev.org/880123 in would be nice | 18:00 |
| opendevreview | James E. Blair proposed zuul/zuul-jobs master: Update promote-container-image to copy from intermediate registry https://review.opendev.org/c/zuul/zuul-jobs/+/878538 | 18:32 |
| opendevreview | Ghanshyam proposed openstack/project-config master: Retire openstack-health project: end project gating https://review.opendev.org/c/openstack/project-config/+/880013 | 18:34 |
| opendevreview | James E. Blair proposed zuul/zuul-jobs master: Update promote-container-image to copy from intermediate registry https://review.opendev.org/c/zuul/zuul-jobs/+/878538 | 18:34 |
| opendevreview | Ghanshyam proposed openstack/project-config master: Retire patrole project: end project gating https://review.opendev.org/c/openstack/project-config/+/880013 | 18:34 |
| opendevreview | James E. Blair proposed zuul/zuul-jobs master: Update promote-container-image to copy from intermediate registry https://review.opendev.org/c/zuul/zuul-jobs/+/878538 | 18:36 |
| opendevreview | Ghanshyam proposed openstack/project-config master: Retire patrole projects: remove project from infra https://review.opendev.org/c/openstack/project-config/+/880220 | 18:46 |
| opendevreview | Ghanshyam proposed openstack/project-config master: Add TC repos in gerritbot https://review.opendev.org/c/openstack/project-config/+/880235 | 19:29 |
| opendevreview | Ghanshyam proposed openstack/project-config master: Add TC repos in gerritbot https://review.opendev.org/c/openstack/project-config/+/880235 | 19:51 |
| clarkb | ianw: if you get a chance can you take a look at the change to remove static from the inventory? I didn't feel super comfortable making a change like that with no reviews. My day is running out of time as I have a family thing soon. I'm happy to land it tomorrow and watch it if it looks good to you | 22:58 |
| ianw | sure, i can watch it to | 23:03 |
| opendevreview | Merged opendev/system-config master: Remove static01 from inventory https://review.opendev.org/c/opendev/system-config/+/880086 | 23:19 |
| opendevreview | Merged zuul/zuul-jobs master: test-registry: split docker and container paths https://review.opendev.org/c/zuul/zuul-jobs/+/878497 | 23:46 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!