| opendevreview | Ian Wienand proposed zuul/zuul-jobs master: stage-output: use links in docs https://review.opendev.org/c/zuul/zuul-jobs/+/861924 | 00:06 |
|---|---|---|
| opendevreview | Merged opendev/system-config master: Move clouds definitions into control-planes-clouds group https://review.opendev.org/c/opendev/system-config/+/861130 | 00:13 |
| *** rlandy is now known as rlandy|out | 00:53 | |
| fungi | clarkb: i guess 861800 is no longer needed? | 00:55 |
| opendevreview | Merged openstack/project-config master: Create 'Backport-Candidate' for Charms repos https://review.opendev.org/c/openstack/project-config/+/861892 | 01:06 |
| opendevreview | Merged opendev/system-config master: Run jobs with a jammy bridge.openstack.org https://review.opendev.org/c/opendev/system-config/+/857799 | 03:28 |
| opendevreview | Merged opendev/system-config master: testinfra: Update selenium calls https://review.opendev.org/c/opendev/system-config/+/858003 | 04:47 |
| *** ysandeep|PTO is now known as ysandeep | 05:07 | |
| opendevreview | Rafal Lewandowski proposed openstack/diskimage-builder master: Added example configuration https://review.opendev.org/c/openstack/diskimage-builder/+/861582 | 08:00 |
| *** ysandeep is now known as ysandeep|lunch | 09:08 | |
| *** rlandy|out is now known as rlandy | 10:29 | |
| opendevreview | Merged opendev/irc-meetings master: Change chair contact information for keystone https://review.opendev.org/c/opendev/irc-meetings/+/861894 | 10:43 |
| *** ysandeep|lunch is now known as ysandeep | 10:46 | |
| *** dviroel|out is now known as dviroel | 11:25 | |
| fungi | looks like we got new pbr (5.11.0) and stevedore (4.1.0) releases | 12:00 |
| *** ysandeep is now known as ysandeep|mtg | 12:15 | |
| *** dasm|off is now known as dasm | 13:13 | |
| *** ysandeep|mtg is now known as ysandeep | 13:44 | |
| clarkb | fungi: correct 861800 has been abandoned | 14:03 |
| *** dviroel is now known as dviroel|ptg | 14:08 | |
| clarkb | mordred isn't here anymore, but the reason we don't use `pip wheel` in assemble is that we don't want the wheel(s) for the target install to mix with the wheels for the dependencies (which currently go in the wheel cache in a separate dir) | 14:25 |
| clarkb | I think this is beacuse we don't necessarily have shared info between assemble on the builder and install-from-bindep on the base image and it is easy to pip install /path/*.whl to work around that | 14:26 |
| clarkb | I think this is solveable though where we can do the wheel install in assemble, make note of the wheels that created and stash them in a file, run pip wheel against everything else. Then in install-from-bindep read the contents of that file and pip install those using find links? | 14:27 |
| *** ysandeep is now known as ysandeep|dinner | 14:29 | |
| opendevreview | Clark Boylan proposed opendev/system-config master: Switch python-builder/python-base to pip wheel https://review.opendev.org/c/opendev/system-config/+/862152 | 14:55 |
| *** ysandeep|dinner is now known as ysandeep | 14:55 | |
| *** marios_ is now known as marios | 15:52 | |
| *** marios is now known as marios|out | 16:05 | |
| *** dviroel|ptg is now known as dviroel|lunch\ | 16:06 | |
| *** ysandeep is now known as ysandeep|out | 16:20 | |
| *** jpena is now known as jpena|off | 16:39 | |
| *** dviroel|lunch\ is now known as dviroel | 16:53 | |
| gtema | clarkb: which cloud is still having cinderv1? I think what happened is that support for it got dropped from cinderclient which is used in OSC (we still haven't switched to SDK here) | 17:34 |
| gtema | If we could get access to this we may add support in SDK/OSC for that | 17:34 |
| clarkb | gtema: its rax (they do have v2 but its not complete and some operatins don't work so we've just fallen back to 1) | 17:34 |
| gtema | Ah great, will get access to it so can evaluate adding it | 17:35 |
| fungi | also i did some additional testing of python-openstackclient versions and the cinder v1 issues talking to rax seem to be independent of the python-cinderclient version i used (working venv with older osc worked vs newer osc did not even though both venvs had the same cinderclient version) | 17:59 |
| fungi | i also pinned keystoneclient and ksa to the same version in both venvs | 17:59 |
| fungi | so those don't appear to be involved | 18:00 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Switch python-builder/python-base to pip wheel https://review.opendev.org/c/opendev/system-config/+/862152 | 18:00 |
| clarkb | infra-root thoughts on landing https://review.opendev.org/c/opendev/zone-opendev.org/+/861230 to restore the opendev.org DNS record TTLs? | 18:11 |
| clarkb | it seems unlikely we'll need to revert to the old host at this point so TTLs being an hour is probbly fine. THen tomorrow? I'll plan to clean up the old server. | 18:11 |
| clarkb | pip CI is broken on a git submodule thing | 18:16 |
| clarkb | I ended up making a PR as requested by them for the cache thing. We'll see how this goes | 18:16 |
| fungi | i've heard no complaints about gitea or the lb | 18:18 |
| fungi | i guess i can go ahead and approve it, since the impact of that should be approximately nil | 18:19 |
| clarkb | I'll bundle up the gitea-lb01 removabl with jvb02 removal to reduce the rtt on those. (we definitely don't need the second jvb for meetpad after this ptg, it held up well but there wasn't concurrent load that would demand the extra jvb server) | 18:19 |
| opendevreview | Merged opendev/zone-opendev.org master: Reset TTLs for opendev.org records https://review.opendev.org/c/opendev/zone-opendev.org/+/861230 | 18:22 |
| clarkb | thanks! | 18:23 |
| fungi | sounds good | 18:26 |
| clarkb | the TTLs I see now are back to an hour | 19:11 |
| fungi | excellent | 19:11 |
| opendevreview | Clark Boylan proposed openstack/diskimage-builder master: DNM testing the combo of the depends on https://review.opendev.org/c/openstack/diskimage-builder/+/862187 | 19:44 |
| clarkb | ok my pip wheel change in the base images does break siblings. The reason is we end up with multiple wheels for the same package (in this case dib in the nodepool siblings job) and pip cannot resolve that. I will have to think about how that can be resolved | 20:29 |
| clarkb | I was hoping that it would just pick the higher version and roll with it | 20:29 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Switch python-builder/python-base to pip wheel https://review.opendev.org/c/opendev/system-config/+/862152 | 20:43 |
| clarkb | in my commit message I described an alternative appraoch that turns out to actually be the fix for this so I'm trying that here ^ | 20:43 |
| clarkb | the update to address https://github.blog/2022-10-18-git-security-vulnerabilities-announced/#cve-2022-39253 is apparently affecting zuul and is also the cause of my failed pip ci jobs. Heads up here if other things run into it | 21:36 |
| clarkb | focal and jammy both seem ot have updated by now in our CI system so should see fallout for that if it is there | 21:38 |
| clarkb | firefox's about firefox menu button (to check if I need to restart for updates) is next to the report deceptive site button. Not great ui there | 22:03 |
| fungi | how are the security updates to git manifesting in job failures? | 22:07 |
| clarkb | in zuul's case zuul's submodule testing adding a repo with a file:// broke with default settings | 22:07 |
| clarkb | I think pip ci has a similar problem | 22:08 |
| fungi | aha | 22:08 |
| *** rlandy is now known as rlandy|bbl | 22:30 | |
| *** dasm is now known as dasm|off | 22:46 | |
| *** dviroel is now known as dviroel|out | 22:47 | |
| opendevreview | Clark Boylan proposed openstack/diskimage-builder master: DNM testing the combo of the depends on https://review.opendev.org/c/openstack/diskimage-builder/+/862187 | 22:51 |
| clarkb | ok I think the last recheck on ^ shows my pip wheel change may be working but this update should run all the functional nodepool + dib jobs too which will give us a better idea | 22:52 |
| clarkb | https://zuul.opendev.org/t/openstack/build/9fe18928b6db4a87ad93bd2b4ab7a47e/log/job-output.txt#15414 I think that line shows it successfully installing the sibling package of dib rather than the last actual release | 22:57 |
| clarkb | however I also note a lot of wheels get downloaded which I did not expect. | 22:57 |
| clarkb | does pip wheel maybe only preserve wheels that need to be built and aren't hosted on pypi? | 22:58 |
| clarkb | it definitely feels that way. Seems like all the things that it had to build before when it broke are there but then everything els eit downloads. I think that is ok though somewhat contrary to our original goals | 23:00 |
| fungi | it shouldn't. my local runs of tox show pip reusing cached wheels it downloaded previously | 23:04 |
| fungi | with 22.3 | 23:05 |
| clarkb | fungi: using `pip wheel` and --find-links or `pip install` and --cache-dir? | 23:05 |
| clarkb | it does what you describe with `pip install` and --cache-dir but switching to the suggested `pip wheel` and --find-links like that change does seems to not | 23:05 |
| fungi | using `pip install` and letting it leverage its default cachedir of ~/.cache/pip | 23:05 |
| clarkb | I mean its still doing what we want which is build wheels in a disposable image and copy them over to the prod install to avoid needing build deps on the prod image | 23:06 |
| fungi | oh, got it. pip wheel not reusing cached wheels | 23:06 |
| clarkb | right, upstream says doing that is bad and they want us to use `pip wheel` and --find-links | 23:06 |
| fungi | that *might* be intentional, or it could be a side effect nobody upstream has spotted | 23:06 |
| clarkb | but ya I think I have pip wheel working in that stack now with the caveat I've just pointed out | 23:07 |
| fungi | does pip wheel without --find-links do the same? | 23:07 |
| clarkb | this second pass of nodepool + dib testing will tell us | 23:07 |
| fungi | i mean, obviously --find-links is necessary for our use case | 23:07 |
| fungi | just wondering if the not reusing cached wheels (or not caching wheels?) is a side effect of passing --find-links | 23:07 |
| clarkb | oh I stopped passing --cache-dir | 23:08 |
| clarkb | but maybe I should do both? | 23:08 |
| clarkb | fungi: if you look at the install starting at https://zuul.opendev.org/t/openstack/build/9fe18928b6db4a87ad93bd2b4ab7a47e/log/job-output.txt#15076 it illustrates the behavior I'm talking about | 23:08 |
| fungi | if i just do pip wheel in one of my projects without --find-links it reuses the cached wheels for deps it needs | 23:08 |
| clarkb | right I guess what I'm confused about is it is supposed to write all the wheels for all the deps into the --wheel-dir but then when you use --find-links against that dir it seems to ignore those files if they also exist on pypi? | 23:09 |
| clarkb | essentially negating the need of a cache dir | 23:09 |
| clarkb | except that doesn't actually seem to be the case | 23:10 |
| clarkb | https://zuul.opendev.org/t/openstack/build/9fe18928b6db4a87ad93bd2b4ab7a47e/log/job-output.txt#3101 this is where all the wheels are written to the wheel dir | 23:10 |
| clarkb | so why is it ignoring those files later? Must be another pip bug... | 23:10 |
| fungi | and you're using a file:// url right? | 23:11 |
| clarkb | its only the wheels it builds at https://zuul.opendev.org/t/openstack/build/9fe18928b6db4a87ad93bd2b4ab7a47e/log/job-output.txt#3178 that it actually uses out of the find links dir later | 23:11 |
| clarkb | fungi: yes its pip install /path/to/foo.whl when we do the install later | 23:11 |
| clarkb | fungi: ianw: I still need to restart Gerrit to pick up https://review.opendev.org/c/opendev/system-config/+/861270 is now a good time to do that? | 23:12 |
| fungi | oh, i meant to the --find-links parameter | 23:12 |
| fungi | clarkb: now seems like a fine time for a gerrit restart, sure | 23:12 |
| clarkb | fungi: yes `--find-links /output/wheels` | 23:12 |
| fungi | --help suggests it should be `--find-links file:///output/wheels` | 23:13 |
| clarkb | I think just /foo is equivalent | 23:13 |
| fungi | oh, nevermind i misread. it does say local path *or* file:// url | 23:14 |
| clarkb | the behavior makes me think that find links isn't disabling pypi and that it still prefers pypi to local wheels | 23:14 |
| clarkb | it can't find wheels for the other things on pypi so it fallsback to the local files there | 23:14 |
| fungi | but yes, it seems like --find-links is for adding wheels, not specifying a preferred location for them | 23:14 |
| fungi | it at least doesn't say it overrides the index or extra index urls | 23:14 |
| clarkb | "opendevorg/gerrit@sha256:385212f091675ee9b7702f2d59ed76bee87a154782918f8a92dec3b0c37366cd" via docker inspect of the image on review02 matches https://hub.docker.com/layers/opendevorg/gerrit/3.5/images/sha256-385212f091675ee9b7702f2d59ed76bee87a154782918f8a92dec3b0c37366cd?context=explore | 23:15 |
| fungi | so i would infer the behavior you're observing is probably expected | 23:15 |
| clarkb | I'll go ahead and down then up -d the service now | 23:15 |
| fungi | i have a feeling if you bring that --find-links behavior to their attention, their response will be that you should run a local https://pypi.org/project/devpi-server/ on the machine | 23:18 |
| clarkb | or use --cache-dir :P | 23:18 |
| clarkb | it honestly seems backwards that the fix for this is to use the cache dir the way we've been using it | 23:18 |
| clarkb | I think I'll call that out on the issue since they keep saying using pip wheel | 23:18 |
| fungi | "what we want is a local cache of wheels which pip will reuse" | 23:19 |
| fungi | better, which pip will populate and reuse | 23:19 |
| clarkb | gerrit web ui loads for me and other than complaints about not being able to compress log files that don't exist and more ssh clients that can't negotiate things | 23:19 |
| fungi | yeah, gerrit lgtm still | 23:20 |
| fungi | 3.5.3-14-ga092026d23-dirty | 23:20 |
| clarkb | and now we're running the 3.5 tagged image | 23:21 |
| clarkb | one less thing on the pile now :) | 23:21 |
| clarkb | #status log Restarted Gerrit on our latest gerrit 3.5 image (change 861270) which resyncs our plugin versions to 3.5.3. | 23:22 |
| opendevstatus | clarkb: finished logging | 23:22 |
| ianw | ++ thanks :) | 23:24 |
| clarkb | looks like we can use --no-index | 23:26 |
| fungi | aha, that's the ticket | 23:30 |
| clarkb | https://review.opendev.org/c/opendev/system-config/+/862152 I left a comment there with what we found. It would be helpful for reviewers to weigh in on whether or not they want the new behavior or --no-index to emulate the old | 23:31 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!