Wednesday, 2022-07-06

*** rlandy is now known as rlandy|out01:17
opendevreviewMerged opendev/system-config master: gitea: fix loadbalancer forwarding in testing  https://review.opendev.org/c/opendev/system-config/+/84879301:24
opendevreviewwangxiyuan proposed opendev/system-config master: Update openEuler mirror repo  https://review.opendev.org/c/opendev/system-config/+/84870301:30
opendevreviewwangxiyuan proposed opendev/system-config master: Update openEuler mirror repo  https://review.opendev.org/c/opendev/system-config/+/84870301:31
opendevreviewwangxiyuan proposed opendev/system-config master: Update openEuler mirror repo  https://review.opendev.org/c/opendev/system-config/+/84870301:40
opendevreviewwangxiyuan proposed opendev/system-config master: [WIP]Drop openEuler 20.03 LTS SP2 repo mirror  https://review.opendev.org/c/opendev/system-config/+/84879601:40
opendevreviewwangxiyuan proposed opendev/system-config master: Update openEuler mirror repo  https://review.opendev.org/c/opendev/system-config/+/84870301:44
opendevreviewwangxiyuan proposed opendev/system-config master: [WIP]Drop openEuler 20.03 LTS SP2 repo mirror  https://review.opendev.org/c/opendev/system-config/+/84879601:45
opendevreviewIan Wienand proposed opendev/system-config master: letsencrypt: selfsigned testing certs - use common CA, setup SAN  https://review.opendev.org/c/opendev/system-config/+/84856201:58
opendevreviewIan Wienand proposed opendev/system-config master: gitea-lb: test ssl connections during testing too  https://review.opendev.org/c/opendev/system-config/+/84877701:58
opendevreviewIan Wienand proposed opendev/system-config master: paste : move testing host to paste99, remove https hacks  https://review.opendev.org/c/opendev/system-config/+/84868501:58
opendevreviewIan Wienand proposed opendev/system-config master: gitea: test loadbalancer to gitea  https://review.opendev.org/c/opendev/system-config/+/84868701:58
ianwwell the os-testr/pbr thing doesn't replicate in a xenial docker image, to start 02:56
ianwsigh, nor on a xenial image i just jumped on02:59
*** ysandeep|out is now known as ysandeep|ruck03:12
ianwahh, https://review.opendev.org/c/openstack/diskimage-builder/+/787827 is the pre-install for glean03:13
opendevreviewIan Wienand proposed openstack/project-config master: nodepool elements: fix pip upgrade venv  https://review.opendev.org/c/openstack/project-config/+/84880003:32
ianwfrickler / clarkb: ^ ... rather embarrassing error on my behalf there...03:33
ianwgiven the time i'm going to self-approve and monitor that, dropped a comment with a link to local replication03:42
opendevreviewMerged openstack/project-config master: nodepool elements: fix pip upgrade venv  https://review.opendev.org/c/openstack/project-config/+/84880003:53
*** raukadah is now known as chandankumar04:22
opendevreviewIan Wienand proposed opendev/system-config master: gitea: test loadbalancer to gitea  https://review.opendev.org/c/opendev/system-config/+/84868704:29
*** ysandeep|ruck is now known as ysandeep|ruck|afk04:32
*** ysandeep|ruck|afk is now known as ysandeep|ruck05:08
opendevreviewIan Wienand proposed opendev/system-config master: gitea: test loadbalancer to gitea  https://review.opendev.org/c/opendev/system-config/+/84868706:04
*** ysandeep|ruck is now known as ysandeep|ruck|lunch08:43
ianwlooks like xenial is creating qcows now09:12
* frickler moos approvingly, but still doesn't understand why that error only seemed to break things a year later09:18
*** ysandeep|ruck|lunch is now known as ysandeep|ruck09:53
*** rlandy|out is now known as rlandy10:24
*** dviroel|out is now known as dviroel11:25
fungifor a moment i thought it might be more recent fallout from https://review.opendev.org/846248 but that hasn't merged yet11:30
*** rlandy is now known as rlandy|brb12:23
*** rlandy|brb is now known as rlandy12:42
fungiokay, one remaining bit of weirdness i've noticed... in the message headers for mailing list posts after the conversion to https urls, the List-Archive header still says http but the others (List-Unsubscribe, List-Subscribe) correctly say https13:07
funginot a huge deal of course, since the archive urls will get redirected to https anyway, but there must be something still missing somewhere13:08
fungiahh, looks like DEFAULT_URL_PATTERN may not be the whole story. https://wiki.list.org/DOC/4.27%20Securing%20Mailman%27s%20web%20GUI%20by%20using%20Secure%20HTTP-SSL%20%28HTTPS%29?action=show&redirect=DOC%2F4.27+Securing+Mailman%27s+web+GUI+by+using+Secure+HTTP-SSL suggests also setting PUBLIC_ARCHIVE_URL which our current configs don't do13:12
fungifrom the existing behavior and the wording there, i'm now inferring that mailman constructs that url with an http scheme if you don't set PUBLIC_ARCHIVE_URL at all13:13
fungii'll put together a change to add that, for completeness13:13
fungiaha, it's inherited from Defaults.py13:17
opendevreviewJeremy Stanley proposed opendev/system-config master: Update Mailman archive URLs to use HTTPS  https://review.opendev.org/c/opendev/system-config/+/84884313:25
*** dasm|off is now known as dasm13:39
opendevreviewMerged opendev/base-jobs master: Separate swift provider selection from the swift log upload task for base-test  https://review.opendev.org/c/opendev/base-jobs/+/84802713:44
fungijrosser_: ^ testing that can proceed at your convenience13:45
jrosser_fungi: excellent - thanks13:46
fungithanks for working through it!13:47
*** dviroel is now known as dviroel|lunch14:59
*** ysandeep|ruck is now known as ysandeep|dinner15:28
opendevreviewJonathan Rosser proposed zuul/zuul-jobs master: [DNM] test 848027  https://review.opendev.org/c/zuul/zuul-jobs/+/84888015:38
opendevreviewJonathan Rosser proposed zuul/zuul-jobs master: [DNM] test 848027  https://review.opendev.org/c/zuul/zuul-jobs/+/84888015:49
clarkbjrosser_: note I think the first patch was correct15:50
jrosser_oh hmm15:50
jrosser_i was digging around for an example of that15:50
clarkbjrosser_: the second will ensure the base-jobs repo is also copied onto the test node (which isn't necessary)15:50
jrosser_as it didnt appear to run15:50
clarkbjrosser_: I think it did looking at https://zuul.opendev.org/t/zuul/build/12cd1331897944b2a3f55560e7ff182d/15:50
clarkbbecause the uploads upload our logs there is a bit of a chicken and egg so things might be cut off at ^ but if you grep base-test you'll see it ran that version15:52
jrosser_feel like i am asking a stupid question but how did you find the results15:54
*** marios is now known as marios|out15:54
clarkbjrosser_: I found it via the zuul status page for your change15:55
clarkbhttps://zuul.opendev.org/t/zuul/status there15:55
jrosser_oh right well the reason i went messing with it a second time was i thought it had not run at all, as theres nothing reported back to gerrit15:55
clarkbit may not have completed fully?15:56
jrosser_i went there and put 848880 in the search box and there was no sign of it15:57
clarkbwhne you push a new ps it deletes the jobs for the old one and won't report back so if that happened before it completed15:57
clarkbjrosser_: were you in the openstack tenant view?15:57
jrosser_oh quite possibly :)15:57
clarkbzuul run its jobs in the zuul tenant. So you have to switch tenant contexts in the status page15:57
jrosser_doh15:57
clarkbIn the top right of the web page is a Tenant link if you clikc that it takes you to the listing and hyou can change15:58
jrosser_i think browser autocomplete got me there15:58
clarkbanyway I've looked at the console stream, console rendered from json and the executor debug log and I think this looks good to me. Others should confirm though15:58
fungithanks! i was planning to take a look as soon as i finish lunch15:59
clarkbhttps://paste.opendev.org/show/b3PlARhoBRvLyUtgd1s7/16:00
clarkbOne thing I'm noticing looking at that is that {{ item }} is the "loop_var" can we override that to not be {{ item }} when using with_random_choice?16:00
clarkbthe raeson for that is that we've found that if you end up nested somehow (maybe less of a concern with this particular change) that {{ item }} can end up with weird valeus from outer scopes16:01
clarkbBut other than that I think this is working as expected and the {{ item }} thing is probably fine in this scenario as it isn't in a role but a playbook (which means it is top level)16:01
opendevreviewJonathan Rosser proposed opendev/base-jobs master: Separate swift provider selection from the swift log upload task  https://review.opendev.org/c/opendev/base-jobs/+/84888116:01
jrosser_clarkb: oh yes i can change that name16:02
clarkbjrosser_: in zuul-jobs we try to use a zj_ var prefix for loop vars. This is opendev base jobs so maybe opendev_base_ or something16:03
*** ysandeep|dinner is now known as ysandeep16:03
clarkbbut its a minor concern given this is at the top level playbook16:03
*** dviroel|lunch is now known as dviroel16:08
*** ysandeep is now known as ysandeep|out16:08
opendevreviewJonathan Rosser proposed opendev/base-jobs master: Avoid potential loop variable collision in base-test post-logs  https://review.opendev.org/c/opendev/base-jobs/+/84888316:09
fungiclarkb: jrosser_: yep, debug log on ze02 doesn't appear to have emitted any swift credentials for build 12cd1331897944b2a3f55560e7ff182d, and it does seem to have included the provider name ahead of the upload task16:14
fungithis should do nicely16:15
jrosser_the {{ foo }} in task names is really handy16:16
fungionce 848883 merges and we get a good recheck on the test change, we should be ready to update the base job for real16:17
jrosser_i also did this https://review.opendev.org/c/zuul/zuul-jobs/+/84815316:18
jrosser_which really is at the stage of "is this even a good idea?"16:18
clarkbGiven that the debugging in the base job works and will work even in the timeout acse I think 848153 may not be necessary? I don't think it is problematic just not useful unless you modify the base jobs too (to run the upload twice) and we've already got a base job update that works16:21
jrosser_right - i wasnt sure of the value of having the url to whatever partial upload might had happened16:22
jrosser_that is something else that gets lost along the way with the kind of failures we were seeing16:23
opendevreviewMerged opendev/base-jobs master: Avoid potential loop variable collision in base-test post-logs  https://review.opendev.org/c/opendev/base-jobs/+/84888316:25
clarkbI think it does add a bit more value if we need to fetch the content after the fact for further debugging16:26
clarkbas we'll know the exact location in that case16:27
opendevreviewJonathan Rosser proposed zuul/zuul-jobs master: [DNM] test 848027 and 848883  https://review.opendev.org/c/zuul/zuul-jobs/+/84888016:40
clarkbhttps://paste.opendev.org/show/bO5NBF1aBd6mvKZ1kn2o/ has a warning in it which might be related to the loop var update? I don't understand that17:24
clarkbgoing to recheck to see what shows up in the streaming log17:24
clarkbthe paste was for build e2106ee5f1fe4583902eed0ae3699bdb on ze1017:25
corvusclarkb: i think that's a zuul bug -- check for that in the debug logs of other normal jobs17:25
clarkbcorvus: ya its the callback plugin that zuul provides that is complaining.17:26
corvusclarkb: oh, i see there's a specific warning about item -- you may be right.  ignore what i said :)17:26
clarkbcorvus: fwiw that does show up for other jobs17:26
clarkbBut ya I'm wondering if this specific change of item to something else is maybe what triggers it17:26
corvusyeah; unclear17:27
corvusthat method assumes 'item' in result_dict17:29
corvusthat could be a keyerror if it isn't there17:30
clarkbit should probably look at "ansible_loop_var": "opendev_base_item" to find the name instead?17:31
clarkbbut ya that seems to be the likely cause of that. I think it is ok here? or do we want to be extra careful about it? The values operated on there are not secrets though so should be fine either way I think17:31
corvusmaybe -- assuming that is the error17:31
corvus(this should be able to be tested in a zuul unit test, fwiw)17:32
clarkbthere is a console stream difference. When we used {{ item }} the random selection task printed its selection. When using {{ opendev_base_item }} the task succeeds but doesn't record that value and we record it as part of the name of the next task17:33
clarkbI think this is safe but with that slightly less helpful amount of debugging (but all the info we're aiming to add is there)17:33
corvusi'm assuming it didn't record the value because of the callback plugin failure17:33
clarkbya makes sense17:34
clarkbgiven that I'm happy to go back to item them update it if/when we fix the zuul callback17:34
clarkbor leave it as is and wait for when we fix it17:34
corvusshould i be able to see the change in https://zuul.opendev.org/t/zuul/build/12cd1331897944b2a3f55560e7ff182d/log/job-output.txt ?17:36
corvusoh found it17:36
corvushttps://zuul.opendev.org/t/zuul/build/12cd1331897944b2a3f55560e7ff182d/log/job-output.txt#1397-139917:36
corvusso is that run from before the variable change or after?17:37
corvusokay, that's the before17:39
corvusand https://zuul.opendev.org/t/zuul/build/e2106ee5f1fe4583902eed0ae3699bdb/log/job-output.txt#1413-1415 is the after17:39
corvuswhy does that just say `ok: "ovh_bhs"` and not `Item: ovh_bhs Runtime: ...` ?  where does _log_messag() go?17:41
clarkbya thats what I think is eaten by hte error? But I'm not sure17:41
corvuswell it doesn't show up in the old version either17:42
corvusoh, i think that's the command case17:43
clarkboh you're asking about a slightly different format of output. Where would that come from?17:43
clarkbah17:43
corvushttps://opendev.org/zuul/zuul/src/branch/master/zuul/ansible/base/callback/zuul_stream.py#L513-L51717:43
corvusthere, i think that's the case we should hit, and that produces the output we see in the "item" case, and that's the likely KeyError in the other case17:44
corvusso yeah, i think i'm 99% sure i understand this now and that's what's happening :)17:44
clarkbmakes sense17:46
clarkband I think we can do result_dict[result_dict["ansible_loop_var"]] to fix it?17:46
corvusyeah17:47
corvusclarkb: er, do you have a link to that ssh thing fedora users were having to do to talk to gerrit?18:15
corvusoh i think i found it https://lists.opendev.org/pipermail/service-discuss/2021-October/000291.html18:16
clarkbcorvus: ya the openssh release notes for 8.8 have details now that upstream openssh has caught up with fedora18:19
clarkbGerrit 3.6 is expected to fix this18:20
corvusin the mean time.. it seems jammy is affected18:20
clarkbya anything with openssh 8.8 or newer will be18:20
clarkbfedora just happened to do it on 8.7 early18:20
clarkbI still contend that all of those clients are buggy and should default to rsa + sha2 if they have disabled rsa + sha118:21
clarkbI looked at the openssh code for a while and got lost trying to figure out how to update the default18:21
opendevreviewNeil Hanlon proposed openstack/diskimage-builder master: Add Rockylinux 9 build configuration and update jobs for 8 and 9  https://review.opendev.org/c/openstack/diskimage-builder/+/84890119:42
*** dviroel is now known as dviroel|out20:50
*** dasm is now known as dasm|off21:36
*** rlandy is now known as rlandy|biab21:50
opendevreviewIan Wienand proposed opendev/system-config master: static: remove unused letsencrypt group variable  https://review.opendev.org/c/opendev/system-config/+/84890622:21
opendevreviewIan Wienand proposed opendev/system-config master: [wip] static: move certs to group, update testing name to static99  https://review.opendev.org/c/opendev/system-config/+/84890822:49
ianwbtw after i stuffed up and accidentally killed it, then re-ran it (much slower, as it checked the current setting before updating), all 2,138,256 stats finally have their xfilesfactor set to 0 on graphite now22:58
ianw#status log all stats on graphite.opendev.org reset with an xfilesfactor of 0; c.f. https://review.opendev.org/c/opendev/system-config/+/84787623:00
opendevstatusianw: finished logging23:00
*** rlandy|biab is now known as rlandy23:01
fungithanks for fixing that!23:25
*** rlandy is now known as rlandy|out23:37

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!