| clarkb | I've pinged davido and indicated we'll try and triple check that locally now | 00:00 |
|---|---|---|
| clarkb | fungi: do you want to udpate teh changes and hold or should I? | 00:00 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Use Gitea for Gerrit's code browser URLs https://review.opendev.org/c/opendev/system-config/+/825339 | 00:13 |
| opendevreview | Clark Boylan proposed opendev/system-config master: DNM: Fail our Gerrit testing for an autohold https://review.opendev.org/c/opendev/system-config/+/825396 | 00:13 |
| clarkb | fungi: I went ahead and deleted the old autohold and made a new one for the latest patchset there | 00:15 |
| fungi | ah, thanks! i had stepped away to do dishes, sorry | 00:21 |
| clarkb | no problem | 00:22 |
| clarkb | fungi: does https://158.69.76.92/c/x/test-project/+/3/1/file-3.txt look better? | 00:52 |
| clarkb | if so I'll leave a note on my change upstream indicating we've triple tested it now | 00:53 |
| fungi | clarkb: yep, lgtm. seems that took care of it. thanks! | 00:58 |
| clarkb | I've mentioned it to davido and indicated the instance will stay up too. So lets not delete the autohold just yet | 00:59 |
| fungi | sure thing | 01:00 |
| dhill_ | fungus | 02:02 |
| opendevreview | Ian Wienand proposed zuul/zuul-jobs master: encrypt-file: always import expiring keys https://review.opendev.org/c/zuul/zuul-jobs/+/829853 | 06:30 |
| opendevreview | Ian Wienand proposed zuul/zuul-jobs master: encrypt-file: always import expiring keys https://review.opendev.org/c/zuul/zuul-jobs/+/829853 | 06:49 |
| opendevreview | Ian Wienand proposed zuul/zuul-jobs master: encrypt-file: always import expiring keys https://review.opendev.org/c/zuul/zuul-jobs/+/829853 | 06:58 |
| opendevreview | Ian Wienand proposed zuul/zuul-jobs master: encrypt-file: always import expiring keys https://review.opendev.org/c/zuul/zuul-jobs/+/829853 | 07:31 |
| opendevreview | Ian Wienand proposed zuul/zuul-jobs master: encrypt-file: always import expiring keys https://review.opendev.org/c/zuul/zuul-jobs/+/829853 | 07:45 |
| opendevreview | Ian Wienand proposed zuul/zuul-jobs master: encrypt-file: always import expiring keys https://review.opendev.org/c/zuul/zuul-jobs/+/829853 | 08:56 |
| *** dviroel|out is now known as dviroel | 10:54 | |
| opendevreview | Dr. Jens Harbott proposed opendev/system-config master: Restore is:mergeable predicate in Gerrit https://review.opendev.org/c/opendev/system-config/+/829882 | 12:10 |
| noonedeadpunk | hey there! Question to zuul experts - why in the world job `openstack-ansible-shastest-metal` runs for the patch? https://review.opendev.org/c/openstack/openstack-ansible/+/829868/10/zuul.d/jobs.yaml#232 | 14:46 |
| noonedeadpunk | Or it does because I'm adding job here, and after merge it won't? | 14:46 |
| noonedeadpunk | Or if irrelevant-files is defined for parent I'm "cursed" now? | 14:47 |
| fungi | noonedeadpunk: zuul is "smart" about always running jobs if you change their configuration, just to make sure you're not breaking them | 14:48 |
| noonedeadpunk | aha, awesome | 14:51 |
| noonedeadpunk | I suspected it could be case, but decided to double-check before merging or messing more with config) | 14:52 |
| clarkb | fungi: I assume you're reupping the relaese key and that is why we got email about confirming it? | 15:45 |
| fungi | yeah | 15:45 |
| fungi | i just finished confirming it | 15:45 |
| fungi | https://review.opendev.org/c/openstack/releases/+/829933 Publish the Zed Cycle signing key for future use | 15:46 |
| clarkb | fungi: in a way I prefer the publication of the public key like this since we don't really need to go and sign anything. Its right there in the git repo | 15:47 |
| clarkb | signing might be slightly stronger assurance though | 15:48 |
| clarkb | and I note you did sign it when you generated it | 15:48 |
| fungi | well, the idea frickler and i had was that if you want to attest to it as well, you can double-check the fingerprint from the keyring on bridge, and then upload an update of that file in the releases repo with your own signature added | 15:49 |
| clarkb | makes sense | 15:50 |
| fungi | otherwise it's not all that different from what we were doing with the sks keyserver network, just a little more like the caff workflow | 15:50 |
| clarkb | frickler: I left a note about possibly testing that mergeability check change on a held node that doens't have the config update already. This way we can simulate what will happen in production when we shift over | 15:52 |
| clarkb | I think you can use the node fungi and I held for gitea weblink testing if you like | 15:52 |
| clarkb | basically shutdown gerrit there, add the new config, start gerrit, then check if it reindexed things or if we only get mergability checks on changes that are updated from that point forward | 15:52 |
| clarkb | fungi: the fix for gerrit did land | 15:53 |
| fungi | clarkb: should we drop the depends-on and test again? | 15:57 |
| jentoio | clarkb: morning, sorry Ive been busy and traveling recently so haven't responded. (still catching up on backlog) I'm still interested in helpwiht with container work, afternoon is best for me (between lunch / dinner) | 15:57 |
| jentoio | clarkb: any day is fine to meet during those hours. thanks | 15:58 |
| clarkb | jentoio: thats great to hear. I'm having a really slow start this morning so hesitant to suggest today, but maybe early next week? | 15:58 |
| clarkb | fungi: ya that seems like a reasonable next step | 15:58 |
| jentoio | clarkb: sounds good, i'm pretty flexible | 15:58 |
| fungi | on it | 15:59 |
| fungi | clarkb: should i drop the old autohold or keep it and add another? | 16:00 |
| fungi | yesterday you mentioned not deleting the current one yet | 16:00 |
| clarkb | fungi: the change landed so I'm assuming davido had a look if interested. I think we can delete and replace at this point | 16:01 |
| fungi | will do | 16:01 |
| opendevreview | Jeremy Stanley proposed opendev/system-config master: Use Gitea for Gerrit's code browser URLs https://review.opendev.org/c/opendev/system-config/+/825339 | 16:02 |
| opendevreview | Jeremy Stanley proposed opendev/system-config master: DNM: Fail our Gerrit testing for an autohold https://review.opendev.org/c/opendev/system-config/+/825396 | 16:02 |
| fungi | new autohold set, old one released | 16:04 |
| opendevreview | Clark Boylan proposed openstack/diskimage-builder master: Remove OS CI mirror role from fedora(-minimal) tests https://review.opendev.org/c/openstack/diskimage-builder/+/829942 | 16:14 |
| clarkb | NeilHanlon: fungi ianw ^ I think that is necessary to fix dib tests (its fallout from our removal of f34 mirrors) | 16:14 |
| fungi | ahh, thanks, i hadn't gotten around to looking at those failures yet | 16:15 |
| NeilHanlon | clarkb: so i can rebase 829747 on 829942 and push that? | 16:16 |
| clarkb | NeilHanlon: yes | 16:16 |
| frickler | fungi: did we discuss yet whether to push updates to the signing key as new PS or as new patch on top of your review? one is losing previous reviews, the other requires even more reviews, so I'm unsure which is better | 16:16 |
| fungi | frickler: same here, i don't know which would make more sense | 16:17 |
| frickler | clarkb: yeah, I can do that testing on Monday | 16:17 |
| clarkb | frickler: sounds good | 16:18 |
| frickler | fungi: o.k., so I'll go for updating the review | 16:18 |
| fungi | frickler: also, we can do both... keep updating the current review until the release team gets around to approving it, then push additional reviews as needed afterward to add more signatures | 16:18 |
| frickler | or that, o.k. | 16:18 |
| fungi | frickler: also, a reminder, we included the precise syntax for the export commands in doc/source/index.rst of the releases repo | 16:19 |
| NeilHanlon | clarkb does this look right? https://paste.opendev.org/show/bsfTrTHLyywWHLh6J1AJ/ | 16:20 |
| clarkb | NeilHanlon: yup the hash seems to match. | 16:20 |
| opendevreview | Neil Hanlon proposed openstack/diskimage-builder master: Swap coreutils-single for coreutils in Rocky Linux container builds https://review.opendev.org/c/openstack/diskimage-builder/+/829747 | 16:20 |
| NeilHanlon | i put a depends-on in the commit message.. not sure if that was needed | 16:21 |
| clarkb | NeilHanlon: the depends-on is only needed if you are expressing a dependency to another repository's changes. The git tree is sufficient for changes within a repository | 16:21 |
| clarkb | but it won't hurt anything here | 16:21 |
| NeilHanlon | ah, you know what I remember reading that | 16:22 |
| NeilHanlon | by the way, wanted to thank everyone for their kindness and assistance to a noob :) | 16:23 |
| fungi | NeilHanlon: one trick is to just do `git review -d 829942 && git review -x 829747 && git review` | 16:23 |
| NeilHanlon | ooooh | 16:24 |
| * NeilHanlon reads the manpage furiously | 16:24 | |
| fungi | that does: 1. download the exact change 829942, 2. cherry-pick the state of change 829747 on top of it, 3. push the new stack of changes for review | 16:24 |
| NeilHanlon | git-review makes so much sense | 16:25 |
| fungi | that trick is effectively the same as rebasing 829747 on 829942 | 16:25 |
| NeilHanlon | did I lose the code review votes on 9747 because I changed the commit message? | 16:25 |
| clarkb | NeilHanlon: yes | 16:25 |
| fungi | whereas a rebase or cherry-pick without altering the commit message should preserve the code-review votes | 16:26 |
| fungi | unless you needed to perform a nontrivial merge conflict resolution | 16:26 |
| NeilHanlon | gotcha, so e.g. if it can do a FF it might be OK? | 16:26 |
| fungi | yes | 16:26 |
| NeilHanlon | that's neat | 16:27 |
| fungi | it's a configurable behavior in gerrit. we've got the code-review label to preserve votes on a clean rebase, but verified and workflow are cleared on any update even if it's a ff | 16:27 |
| clarkb | Gerrit does allow you to ignore commit message changes when deciding to reapply votes. We don't use that functionality because historically a number of projects we host actually linted their commit messages. And since depends-on is supported by zuul it can have behavior changes too | 16:28 |
| fungi | well, also projects do review and request fixes to commit message contents | 16:28 |
| *** dviroel is now known as dviroel|lunch | 16:29 | |
| fungi | so if the commit message changes, then they may need to know to re-review the commit message | 16:29 |
| NeilHanlon | makes sense. The more I learn about gerrit and zuul the more I like them | 16:29 |
| *** dviroel|lunch is now known as dviroel | 17:32 | |
| clarkb | fungi: NeilHanlon I think the stack at https://review.opendev.org/c/openstack/diskimage-builder/+/829747 is mergeable now. Zuul reports +1 after my fix | 18:19 |
| clarkb | fungi: also https://149.202.179.152/c/x/test-project/+/3/1/file-3.txt looks good | 18:20 |
| opendevreview | Jeremy Stanley proposed opendev/system-config master: Use Gitea for Gerrit's code browser URLs https://review.opendev.org/c/opendev/system-config/+/825339 | 18:44 |
| opendevreview | Jeremy Stanley proposed opendev/system-config master: Block access to Gitiles https://review.opendev.org/c/opendev/system-config/+/829975 | 18:44 |
| fungi | clarkb: ^ | 18:44 |
| fungi | now with less danger | 18:44 |
| clarkb | fungi: it looks like you removed the gitiles config in that splitting was that intentional? | 18:47 |
| fungi | nope! thanks, i forgot that git reset undoes git add | 18:49 |
| opendevreview | Jeremy Stanley proposed opendev/system-config master: Use Gitea for Gerrit's code browser URLs https://review.opendev.org/c/opendev/system-config/+/825339 | 18:50 |
| opendevreview | Jeremy Stanley proposed opendev/system-config master: Block access to Gitiles https://review.opendev.org/c/opendev/system-config/+/829975 | 18:50 |
| fungi | now with more file | 18:50 |
| clarkb | thanks +2 | 18:52 |
| fungi | i should have used rebase's split option | 18:54 |
| fungi | i keep forgetting that exists | 18:54 |
| clarkb | oh TIL | 18:55 |
| clarkb | I usually do a reset dance too | 18:55 |
| *** dviroel is now known as dviroel|afk | 20:09 | |
| opendevreview | Matthew Thode proposed openstack/diskimage-builder master: update gpg / file verification for Gentoo https://review.opendev.org/c/openstack/diskimage-builder/+/829978 | 20:20 |
| fungi | infra-root: if anyone's willing to approve 825339 now that it works with upstream gerrit, i'm happy to do a gerrit restart over the weekend so we can proceed with 829975 | 20:20 |
| ianw | fungi: sure, i poked on the held node and lgtm! | 20:51 |
| opendevreview | Ian Wienand proposed zuul/zuul-jobs master: encrypt-file : role to encrypt a file https://review.opendev.org/c/zuul/zuul-jobs/+/828818 | 21:06 |
| opendevreview | Ian Wienand proposed zuul/zuul-jobs master: encrypt-file: always import expiring keys https://review.opendev.org/c/zuul/zuul-jobs/+/829853 | 21:06 |
| fungi | thanks! | 21:31 |
| opendevreview | Merged zuul/zuul-jobs master: Add patch to list of build dependencies https://review.opendev.org/c/zuul/zuul-jobs/+/829063 | 21:36 |
| opendevreview | Merged opendev/system-config master: Use Gitea for Gerrit's code browser URLs https://review.opendev.org/c/opendev/system-config/+/825339 | 21:37 |
| opendevreview | Jeremy Stanley proposed opendev/system-config master: Block access to Gitiles https://review.opendev.org/c/opendev/system-config/+/829975 | 21:40 |
| fungi | ianw: ^ | 21:40 |
| fungi | i'll plan to restart gerrit at some quiet point once i've confirmed we have the updated image on the server | 21:40 |
| opendevreview | Merged openstack/diskimage-builder master: Remove OS CI mirror role from fedora(-minimal) tests https://review.opendev.org/c/openstack/diskimage-builder/+/829942 | 22:20 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!