| opendevreview | Merged opendev/base-jobs master: Remove success-url https://review.opendev.org/c/opendev/base-jobs/+/802975 | 00:49 |
|---|---|---|
| opendevreview | Merged openstack/diskimage-builder master: Replace deprecated assertEquals https://review.opendev.org/c/openstack/diskimage-builder/+/817663 | 01:39 |
| *** ysandeep|out is now known as ysandeep | 02:59 | |
| opendevreview | Ian Wienand proposed opendev/base-jobs master: infra-prod: split out setup steps https://review.opendev.org/c/opendev/base-jobs/+/807807 | 04:06 |
| opendevreview | Ian Wienand proposed opendev/base-jobs master: infra-prod: override checkout on periodic/hourly https://review.opendev.org/c/opendev/base-jobs/+/818189 | 04:06 |
| opendevreview | Ian Wienand proposed opendev/system-config master: Refactor infra-prod jobs for parallel running https://review.opendev.org/c/opendev/system-config/+/807672 | 04:08 |
| opendevreview | Ian Wienand proposed opendev/system-config master: infra-prod: clone source once https://review.opendev.org/c/opendev/system-config/+/807808 | 04:08 |
| opendevreview | Ian Wienand proposed opendev/system-config master: infra-prod: remove duplicated bridge setup steps https://review.opendev.org/c/opendev/system-config/+/818190 | 04:08 |
| opendevreview | Ian Wienand proposed opendev/system-config master: infra-prod: remove master override steps https://review.opendev.org/c/opendev/system-config/+/818191 | 04:08 |
| ianw | clarkb: thanks for your review comments, that took me forever to loop back on. i think the hourly/periodic setup setup is a point to deal with | 05:06 |
| ianw | after context switching it all back in, i've written http://lists.opendev.org/pipermail/service-discuss/2021-November/000297.html because the changes are a tangle | 05:06 |
| *** ysandeep is now known as ysandeep|PTO | 07:50 | |
| *** ykarel_ is now known as ykarel | 08:30 | |
| *** jpena|off is now known as jpena | 09:50 | |
| opendevreview | Pierre Riteau proposed opendev/git-review master: Fix use of removed --preserve-merges option https://review.opendev.org/c/opendev/git-review/+/818219 | 10:59 |
| *** pojadhav is now known as pojadhav|afk | 11:27 | |
| opendevreview | Pierre Riteau proposed opendev/git-review master: Fix use of removed --preserve-merges option https://review.opendev.org/c/opendev/git-review/+/818219 | 11:29 |
| *** ykarel is now known as ykarel|afk | 12:37 | |
| *** pojadhav|afk is now known as pojadhav | 12:55 | |
| opendevreview | Lajos Katona proposed openstack/project-config master: Grafana dashboard for instance usage of projects https://review.opendev.org/c/openstack/project-config/+/818230 | 13:23 |
| *** pojadhav is now known as pojadhav|afk | 13:38 | |
| opendevreview | Lajos Katona proposed openstack/project-config master: Grafana dashboard for instance usage of projects https://review.opendev.org/c/openstack/project-config/+/818230 | 13:48 |
| *** ykarel|afk is now known as ykarel | 13:49 | |
| opendevreview | Lajos Katona proposed openstack/project-config master: Grafana dashboard for instance usage of projects https://review.opendev.org/c/openstack/project-config/+/818230 | 13:50 |
| opendevreview | Ade Lee proposed zuul/zuul-jobs master: DNM https://review.opendev.org/c/zuul/zuul-jobs/+/807031 | 14:51 |
| opendevreview | Clark Boylan proposed opendev/git-review master: Try to detect git version and rebase appropriately https://review.opendev.org/c/opendev/git-review/+/818238 | 15:19 |
| *** ykarel is now known as ykarel|away | 15:49 | |
| johnsom | Hi infra friends. I have a patch that never launched any jobs in zuul yesterday, with no message posted to the patch: https://review.opendev.org/c/openstack/designate-tempest-plugin/+/806291 | 15:57 |
| johnsom | I am 95% sure I fumbled the .zuul.conf but it seems odd I didn't get any feedback | 15:57 |
| johnsom | This probably warrants a bug report on zuul and any notes from the logs would be nice to have. | 15:58 |
| opendevreview | Lajos Katona proposed openstack/project-config master: Grafana: remove midonet and fwaas dashboards https://review.opendev.org/c/openstack/project-config/+/818244 | 16:00 |
| clarkb | johnsom: Gerrit disconnected the request zuul made to lookup the depends on | 16:03 |
| clarkb | I agree zuul could probably report something in this case to make it clear a recheck is fine | 16:03 |
| johnsom | Is there a log snippet or is that enough information that the zuul team will know what happened? | 16:04 |
| johnsom | Or, if you want to open the bug.... grin | 16:04 |
| clarkb | https://paste.opendev.org/show/b8QlGAhqB2F9XquiDD1G/ ya I'm collecting the info | 16:05 |
| clarkb | corvus: ^ fyi | 16:05 |
| johnsom | Thank you clarkb | 16:07 |
| clarkb | and if it wasn't clear I think you're good to recheck. Thank you for reporting the issue | 16:07 |
| johnsom | Yep, NP. I did fumble the zuul.yml, so I need to push a change anyway | 16:08 |
| clarkb | I suspect this processing is happening earlier in the process than where we handle exceptions for say config errors to report back to gerrit. But I haven't confiemd that yet. I can take a closer look later today probably (currently openinfra live keynotes) | 16:11 |
| johnsom | clarkb FYI: https://storyboard.openstack.org/#!/story/2009687 | 16:17 |
| clarkb | thanks | 16:18 |
| opendevreview | Gonéri Le Bouder proposed zuul/zuul-jobs master: ensure-python: install package on Fedora https://review.opendev.org/c/zuul/zuul-jobs/+/818248 | 16:36 |
| clarkb | fungi: if you have time for https://review.opendev.org/c/openstack/project-config/+/818170 after keynotes that would be great (turning off openstackid gating for retirement) | 16:40 |
| fungi | yep! | 16:47 |
| *** marios is now known as marios|out | 16:53 | |
| clarkb | ok time to get breakfast, then dive into the git review and zuul things that came up this morning | 17:11 |
| *** jpena is now known as jpena|off | 17:34 | |
| opendevreview | Clark Boylan proposed opendev/git-review master: Try to detect git version and rebase appropriately https://review.opendev.org/c/opendev/git-review/+/818238 | 17:48 |
| opendevreview | Ghanshyam proposed openstack/project-config master: Retire training-labs: remove project infra https://review.opendev.org/c/openstack/project-config/+/817507 | 17:50 |
| opendevreview | Merged openstack/project-config master: Set noop jobs on openstackid repos https://review.opendev.org/c/openstack/project-config/+/818170 | 18:05 |
| opendevreview | Clark Boylan proposed opendev/git-review master: Fix use of removed --preserve-merges option https://review.opendev.org/c/opendev/git-review/+/818219 | 18:11 |
| clarkb | johnsom: remote: https://review.opendev.org/c/zuul/zuul/+/818257 Attempt to errors when updating change dependencies | 18:25 |
| clarkb | I don't know if that code is correct, but I wanted to get the general shape of the thing pushed then we can see what testing says | 18:25 |
| clarkb | and then probably add a test for the case too | 18:25 |
| opendevreview | Clark Boylan proposed opendev/git-review master: Fix use of removed --preserve-merges option https://review.opendev.org/c/opendev/git-review/+/818219 | 19:11 |
| clarkb | fungi: ^ updated to make that a bit more resilient | 19:11 |
| fungi | thanks, i also agree with your comment about the rsplit() | 19:14 |
| fungi | also, any particular benefit to doing rsplit(None, 1)[1] instead of split()[-1]? | 19:15 |
| clarkb | I find it easier to understand personally | 19:15 |
| fungi | wfm | 19:16 |
| fungi | negative indices on slices remind me of awk, which i spent far too long steeped in during my youth | 19:16 |
| fungi | rsplit is probably a bit more clearly deliberate that split with a negative slice | 19:17 |
| fungi | s/that/than/ | 19:17 |
| clarkb | ya to me rsplit means "I want something at the end) | 19:17 |
| opendevreview | Marco Vaschetto proposed openstack/diskimage-builder master: Allowing ubuntu element use local image https://review.opendev.org/c/openstack/diskimage-builder/+/817481 | 19:35 |
| opendevreview | Ian Wienand proposed openstack/project-config master: Add dstat_graph project https://review.opendev.org/c/openstack/project-config/+/818278 | 19:52 |
| clarkb | infra-root smarcet approved the other two chagnes I need for openstackid retirement. https://review.opendev.org/c/opendev/puppet-openstackid/+/818172 is the last on before we can land https://review.opendev.org/c/openstack/project-config/+/818176 if you haev a moment | 19:53 |
| opendevreview | Merged opendev/puppet-openstackid master: Retire this project https://review.opendev.org/c/opendev/puppet-openstackid/+/818172 | 19:57 |
| ianw | clarkb: lmn if you have any thoughts on the parallel run things. i totally get it's a expensive context switch to think about :) | 20:02 |
| clarkb | ianw: ya I'm hoping to dig into that after lunch today | 20:02 |
| clarkb | I've been doing a lot of random things this morning between keynotes and zuul and git review and so on | 20:02 |
| fungi | i appreciated the ml post, i just need to properly read and digest it | 20:02 |
| ianw | np, i know there's a lot going on, as always! | 20:05 |
| clarkb | also I wrote a novel about locking test results and clean check :) | 20:05 |
| ianw | that sounds like an "after breakfast" thing :) | 20:07 |
| ianw | i don't know if it's just i'm looking now, but it certainly seems more of my gerrit mails are ending in up my (work) gmail spam | 20:08 |
| clarkb | I think SpamapS complained about that too. I think that google is treating it as spam more often now which si funny considering it is their software | 20:09 |
| clarkb | I was also hopign to land https://review.opendev.org/c/opendev/system-config/+/816769 and child this week if others are able to review it. This is the chagne stack that updates the gerritbot user on eavesdrop for the irc and matrix bots | 20:10 |
| clarkb | I think that is one of the easier user changes we've got and will serve as a good sanity check for the process and what it looks like in config management | 20:10 |
| clarkb | ianw: also I always forget that there is a two hour time swing between us when DST changes. You're here early now :) | 20:14 |
| ianw | nothing like a few reviews to get the day going | 20:21 |
| opendevreview | Merged openstack/project-config master: Complete openstackid repo retirements https://review.opendev.org/c/openstack/project-config/+/818176 | 20:22 |
| ianw | clarkb: one thought on 816769; do we need to create that user in the container too? | 20:26 |
| clarkb | ianw: that is one of the things I'm not 100% clear on and this is a good test case for. I think that docker will run the process with the assigned uid. Then you only need the uid to exist in the container if reading or writing to places that needs those permissions | 20:30 |
| clarkb | ianw: in this case we bind mount all the config that is read so that shouldn't be an issue. And the executabel itself should be executable by others | 20:30 |
| clarkb | Thinking more generally I think we should consider updating the gerritbot image to use the uid since we control that image. However, matrix gerritbot is different and we consume it from that upstream and wouldn't have the uid on the image | 20:31 |
| clarkb | Basically this boils down to being explicit in the image and at run time as belts and suspenders where we acn but then do runtime when we don't control the image | 20:31 |
| clarkb | And this will sort of prove that out I think? | 20:32 |
| ianw | ok, i think the weird thing will be if you log into the container to poke and the shell can't determine a name | 20:32 |
| clarkb | ianw: I think that won't be an issue unless you specify the user when exec'ing or run'ing too | 20:33 |
| opendevreview | Merged opendev/system-config master: gerrit: test reviewed flag add/delete/add cycle https://review.opendev.org/c/opendev/system-config/+/817301 | 20:33 |
| ianw | hrm, i guess you log in as root by default? | 20:34 |
| clarkb | ya | 20:34 |
| clarkb | I think it is a good idea to update the image fwiw. I'm just suggesting we do it after the fact so that we can sort out how necessary that is | 20:34 |
| clarkb | if you'd like I can write that chagne before we land anything and do a depends on | 20:35 |
| clarkb | then its all ready to go once we're done learning stuff | 20:35 |
| ianw | that's ok | 20:35 |
| corvus | infra-root: i'll be afk tomorrow through sunday | 21:01 |
| clarkb | corvus: enjoy your time off | 21:08 |
| corvus | thx | 21:08 |
| fungi | have a great time, and thanks for the heads up! | 21:08 |
| clarkb | ianw: I've reviewed the first four changes in your email and the plan laid out by the email lgtm. I'll work on getting to the last two changes next | 21:15 |
| clarkb | ianw: note there are some changes that have commenst and some will need updating | 21:15 |
| ianw | thanks, will get to soon | 21:18 |
| clarkb | ianw: ya I think a little refactoring has to happen. Details on https://review.opendev.org/c/opendev/system-config/+/818190 and https://review.opendev.org/c/opendev/base-jobs/+/807807 but once that is done we should be good to go | 21:31 |
| ianw | clarkb: hrm, ok on the ephemeral inventory part, didn't realise that | 21:55 |
| ianw | at least the known_hosts bit is duplicated right? that's actually writing out to .ssh/known_hosts | 21:55 |
| clarkb | ianw: yup that seems correct the module docs say it writes to the file by default | 22:03 |
| clarkb | so ya I guess that could get refactored into the base job but we have to keep the inventory updates in each play that uses them | 22:03 |
| opendevreview | Ian Wienand proposed opendev/system-config master: infra-prod: remove duplicated bridge key setup https://review.opendev.org/c/opendev/system-config/+/818190 | 22:07 |
| opendevreview | Ian Wienand proposed opendev/system-config master: infra-prod: remove master override steps https://review.opendev.org/c/opendev/system-config/+/818191 | 22:07 |
| opendevreview | Ian Wienand proposed opendev/system-config master: Refactor infra-prod jobs for parallel running https://review.opendev.org/c/opendev/system-config/+/807672 | 22:07 |
| opendevreview | Ian Wienand proposed opendev/system-config master: infra-prod: clone source once https://review.opendev.org/c/opendev/system-config/+/807808 | 22:07 |
| opendevreview | Ian Wienand proposed opendev/base-jobs master: infra-prod: override checkout on periodic/hourly https://review.opendev.org/c/opendev/base-jobs/+/818189 | 22:14 |
| opendevreview | Ian Wienand proposed opendev/base-jobs master: infra-prod: split out setup steps https://review.opendev.org/c/opendev/base-jobs/+/807807 | 22:14 |
| clarkb | ianw: I've got to do a school run now but will rereview after | 22:19 |
| ianw | clarkb: thanks. i'm thinking keep the setup-keys job, but remove the inventory add there. i'll post a follow-on to keep it clearer | 22:19 |
| opendevreview | Merged openstack/project-config master: grafana: update nodepool/dib images https://review.opendev.org/c/openstack/project-config/+/818035 | 22:23 |
| opendevreview | Ian Wienand proposed opendev/base-jobs master: infra-prod-setup-keys: drop inventory add https://review.opendev.org/c/opendev/base-jobs/+/818297 | 22:47 |
| clarkb | ianw: did you see my question on https://review.opendev.org/c/opendev/system-config/+/807672/11 its not super important but I think we can probably claen that up? | 22:55 |
| clarkb | ianw: and acomment on https://review.opendev.org/c/opendev/base-jobs/+/818297 for keeping order correct as far as landing changes goes | 22:59 |
| clarkb | I think we can probably land some of these changes though so that CI will work for the other changes | 23:00 |
| clarkb | would be good if we can get at least one more set of eyeballs on the chagnes first though | 23:00 |
| clarkb | oh nice the openstackid cleanups have all landed. One less zuul config error now :) | 23:04 |
| clarkb | thanks for the reviews on https://review.opendev.org/c/opendev/system-config/+/816769 I'll aim to try and land that tomorrow. I got a very early start today for the openinfra live keynotes and feel I'm about to fading out | 23:12 |
| ianw | clarkb: sorry, had to run out, will check now | 23:24 |
| opendevreview | Ian Wienand proposed opendev/base-jobs master: infra-prod-setup-keys: drop inventory add https://review.opendev.org/c/opendev/base-jobs/+/818297 | 23:27 |
| ianw | ^ that does the depends-on | 23:28 |
| ianw | re 807672 that was from when zuul wasn't reporting, which turned out to be due to the syntax error message size, since fixed. will remove | 23:30 |
| opendevreview | Ian Wienand proposed opendev/system-config master: Refactor infra-prod jobs for parallel running https://review.opendev.org/c/opendev/system-config/+/807672 | 23:31 |
| opendevreview | Ian Wienand proposed opendev/system-config master: infra-prod: clone source once https://review.opendev.org/c/opendev/system-config/+/807808 | 23:31 |
| clarkb | I'm going to leave 807808 unreviewed for now as that one should become easier to undersatnd once zuul is happy with it and that requires a few of the other changes to land first | 23:38 |
| ianw | clarkb: if you're happy i can monitor the changes up to there. i do think they should all be no-ops, so i'm not expecting to do anything but monitor | 23:48 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!