| ianw | i left a comment about the current way it populates attention set for positive votes in https://bugs.chromium.org/p/gerrit/issues/detail?id=15154 | 00:26 |
|---|---|---|
| ianw | just something to hopefully start a discussion. i think we can probably remember to add/remove users as appropriate manually, it's not the end of the world | 00:27 |
| Clark[m] | ianw: that seems to be a good writeup. Anything else I can look at? | 00:35 |
| ianw | Clark[m]: thanks, i thing all good right now, just monitoring everything | 00:54 |
| *** ryanKor_ is now known as ryanKor | 01:25 | |
| opendevreview | Ian Wienand proposed opendev/system-config master: gerrit: diff config files on upgrade https://review.opendev.org/c/opendev/system-config/+/813375 | 04:10 |
| opendevreview | Ian Wienand proposed opendev/system-config master: gerrit: diff config files on upgrade https://review.opendev.org/c/opendev/system-config/+/813375 | 04:27 |
| *** bhagyashris is now known as bhagyashris|rover | 04:43 | |
| *** ysandeep|away is now known as ysandeep| | 04:48 | |
| frickler | infra-root: gerrit dashboards have a regression for me. http://fricklercloud.de/designate should show only designate-related patches, but it now shows me patches from all projects | 04:58 |
| ianw | frickler: hrm, yeah i don't seem to see anything different to a regular change page at all | 05:07 |
| ianw | something a bit simpler seems to work | 05:13 |
| ianw | https://review.opendev.org/dashboard/?title=Mine&foreach=owner:self&My+Pending=is:open&My+Merged=is:merged | 05:13 |
| ianw | frickler: if i reduce your query to "foreach=project%3Aopenstack%2Fdesignate+status..." (i.e. only match designate) it seems to work. so that narrows it down a bit | 05:19 |
| ianw | foreach=%28project%3Aopenstack%2Fdesignate+OR+project%3Aopenstack%2Fpython%2Ddesignateclient%29 also seems to work ... | 05:20 |
| ianw | in fact, if i copy-paste in the URL, it all works. so it's not the dashboard -- it's something about the redirect I guess | 05:24 |
| ianw | frickler: is it possible this actually started happening a few days ago when we switched to the bullseye based images? | 05:25 |
| opendevreview | Ian Wienand proposed opendev/system-config master: gerrit: diff config files on upgrade https://review.opendev.org/c/opendev/system-config/+/813375 | 05:25 |
| frickler | ianw: I'm not sure when I last tried, might be some days ago, so it's possible that it's actually not related to 3.3, yes | 05:40 |
| frickler | maybe I can find some diff in the logs | 05:40 |
| ianw | i'm tracing it debugger, but i'm not sure | 05:41 |
| ianw | it gets the headings, but the query is completely wrong | 05:48 |
| *** ykarel__ is now known as ykarel | 05:51 | |
| ianw | frickler: this is what hits apache https://paste.opendev.org/show/809895/ | 05:54 |
| *** ysandeep| is now known as ysandeep | 05:57 | |
| frickler | oh, weird. if I do a reload, everything works fine suddenly | 06:21 |
| frickler | maybe this is just pre-3.3 stuff cached in the browser | 06:23 |
| ianw | frickler: yes, if you reload, or paste the URL, it works | 06:23 |
| ianw | i'm almost certain it has to do with the fragment in the redirected URL | 06:23 |
| ianw | fircklercloud redirects to review.openstack.org/#/dashboard ... and then that redirects to review.opendev.org | 06:24 |
| ianw | the *second* redirect there; because the #/dashboard is a fragment isn't passed on. that's why we see it loading just "/" | 06:25 |
| frickler | oh, good point, that one I can easily fix | 06:25 |
| ianw | it may "just work" using review.opendev.org and not bouncing through another redirect ... | 06:25 |
| ianw | why it used to work, well i have no idea :) | 06:26 |
| frickler | hmm, no, that didn't help. | 06:28 |
| frickler | but anyway, I can live with the reload workaround | 06:29 |
| opendevreview | Dong Zhang proposed zuul/zuul-jobs master: Implement role for limiting zuul log file size https://review.opendev.org/c/zuul/zuul-jobs/+/813034 | 06:32 |
| opendevreview | Ian Wienand proposed opendev/system-config master: gerrit: diff config files on upgrade https://review.opendev.org/c/opendev/system-config/+/813375 | 06:39 |
| ianw | frickler: i think it's worth a bug. notice how the URL somehow changes from /#/dashboard... to /dashboard? | 06:51 |
| frickler | ianw: no, I hadn't seen that. but indeed if I redirect to /dashboard directly, I don't need the reload | 06:56 |
| frickler | so then the question is whether that's an intended change by gerrit that didn't make it into the documentation or possibly something with our setup | 06:57 |
| *** ysandeep is now known as ysandeep|brb | 07:00 | |
| *** ykarel__ is now known as ykarel | 07:15 | |
| ianw | frickler: i don't think it's "our" (apache, etc.) side involved, it seems to be something polygerrrit does. all the documentation gives the fragment approach (/#/dashboards) but maybe that just hasn't kept up with ... something | 07:23 |
| *** ysandeep|brb is now known as ysandeep | 07:27 | |
| opendevreview | Ian Wienand proposed opendev/system-config master: gerrit: diff config files on upgrade https://review.opendev.org/c/opendev/system-config/+/813375 | 07:29 |
| *** jpena|off is now known as jpena | 07:32 | |
| *** sboyron_ is now known as sboyron | 08:00 | |
| *** sboyron is now known as Guest2498 | 08:01 | |
| opendevreview | Ananya proposed opendev/elastic-recheck rdo: WIP: ER bot with opensearch for upstream https://review.opendev.org/c/opendev/elastic-recheck/+/813250 | 08:26 |
| *** ykarel is now known as ykarel|lunch | 09:05 | |
| sshnaidm | can anyone merge this release please: https://review.opendev.org/c/openstack/releases/+/813009 | 09:22 |
| *** sboyron_ is now known as sboyron | 09:26 | |
| *** sboyron is now known as Guest2502 | 09:27 | |
| *** Guest2502 is now known as sboyron_ | 09:29 | |
| *** ysandeep is now known as ysandeep|lunch | 09:33 | |
| *** ykarel|lunch is now known as ykarel | 10:21 | |
| *** ysandeep|lunch is now known as ysandeep | 10:26 | |
| *** dviroel|afk is now known as dviroel | 11:18 | |
| *** jpena is now known as jpena|lunch | 11:22 | |
| opendevreview | amolkahat proposed zuul/zuul-jobs master: [DNM] Python 2.7 workaround for configparser.readstring() https://review.opendev.org/c/zuul/zuul-jobs/+/813414 | 11:24 |
| *** ykarel_ is now known as ykarel | 11:41 | |
| *** jpena|lunch is now known as jpena | 12:16 | |
| fungi | sshnaidm: that's a link to a release request? you need the openstack release managers in #openstack-release, not the opendev sysadmins | 12:38 |
| sshnaidm | fungi, thanks! | 12:39 |
| fungi | no problem | 12:39 |
| sshnaidm | fungi, I have a question though, not related. I'd like to create a special branch on https://opendev.org/openstack/ansible-collections-openstack/ - not openstack release project. What is the process? Can I do it by my own? | 12:41 |
| fungi | sshnaidm: yep, the permissions and process are explained here... https://docs.opendev.org/opendev/infra-manual/latest/drivers.html#branches | 12:45 |
| fungi | sshnaidm: an example acl snippet for it is here: https://docs.opendev.org/opendev/infra-manual/latest/creators.html#creation-of-branches | 12:47 |
| fungi | sshnaidm: you would insert that create line in the acl here: https://opendev.org/openstack/project-config/src/branch/master/gerrit/acls/openstack/ansible-collections-openstack.config#L6 | 12:51 |
| fungi | looks like you already have a ansible-collections-openstack-release group, so i'd probably delegate it to that for safety | 12:52 |
| opendevreview | Shnaidman Sagi (Sergey) proposed openstack/project-config master: Add creating branch ACL to ansible-collections-openstack repo https://review.opendev.org/c/openstack/project-config/+/813420 | 12:55 |
| sshnaidm | fungi, like this? ^ | 12:55 |
| fungi | sshnaidm: yep, that looks correct | 13:03 |
| *** sboyron_ is now known as sboyron | 13:05 | |
| *** sboyron is now known as sboyron_ | 13:06 | |
| *** sboyron_ is now known as sboyron | 13:06 | |
| opendevreview | Ananya proposed opendev/elastic-recheck rdo: Fix ER bot to report back to gerrit with bug/error report https://review.opendev.org/c/opendev/elastic-recheck/+/805638 | 13:07 |
| opendevreview | Ananya proposed opendev/elastic-recheck rdo: Fix ER bot to report back to gerrit with bug/error report https://review.opendev.org/c/opendev/elastic-recheck/+/805638 | 13:08 |
| sshnaidm | please take a look at patch I revived: https://review.opendev.org/c/zuul/zuul-jobs/+/803471 | 13:53 |
| opendevreview | Merged openstack/project-config master: Add creating branch ACL to ansible-collections-openstack repo https://review.opendev.org/c/openstack/project-config/+/813420 | 13:57 |
| *** ykarel_ is now known as ykarel | 14:27 | |
| *** ykarel is now known as ykarel|away | 14:30 | |
| opendevreview | Dong Zhang proposed zuul/zuul-jobs master: Implement role for limiting zuul log file size https://review.opendev.org/c/zuul/zuul-jobs/+/813034 | 14:46 |
| opendevreview | Dong Zhang proposed zuul/zuul-jobs master: Implement role for limiting zuul log file size https://review.opendev.org/c/zuul/zuul-jobs/+/813034 | 14:50 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Force gerrit image build to tag 3.4 https://review.opendev.org/c/opendev/system-config/+/813449 | 15:31 |
| clarkb | infra-root I noticed ^ seems necessary when looking at the failure on https://review.opendev.org/c/opendev/system-config/+/813375 | 15:31 |
| clarkb | infra-root: other than cleaning up around the gerrit upgrade the other big thing I was hoping to get done today is upgrading gitea to 1.15.4: https://review.opendev.org/c/opendev/system-config/+/813243 I hae diffed the three templates we override between 1.15.3 and 1.15.4 and there is no upstream delta so our existing edits should be fine | 15:46 |
| clarkb | the changelog notes a number of bugfixes but otherwise should be a straightforward update | 15:46 |
| *** ysandeep is now known as ysandeep|out | 15:50 | |
| opendevreview | Clark Boylan proposed opendev/gerritlib master: Rename Gerrit Non-Interactive Users to Service Users https://review.opendev.org/c/opendev/gerritlib/+/813452 | 15:52 |
| fungi | clarkb: are you ready for the gitea upgrade change to merge now, or should i hold off approving? | 15:53 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Rename Gerrit Non-Interactive Users to Service Users https://review.opendev.org/c/opendev/system-config/+/813453 | 15:54 |
| clarkb | fungi: I think now should be fine as there doesn't seem to be any urgent gerrit stuff. The only concern I would have is that change might run the gerrit 3.4 jobs now? and those will fail until that other change lands and promotes a 3.4 tag. The check jobs don't run gerrit jobs so I think we're good to approve it and figure it out after it if does run the gerrit jobs | 15:55 |
| *** marios is now known as marios|out | 16:02 | |
| opendevreview | Alfredo Moralejo proposed openstack/diskimage-builder master: [WIP] Add support for CentOS Stream 9 in DIB https://review.opendev.org/c/openstack/diskimage-builder/+/811392 | 16:12 |
| opendevreview | Clark Boylan proposed opendev/gerritlib master: Rename Gerrit Non-Interactive Users to Service Users https://review.opendev.org/c/opendev/gerritlib/+/813452 | 16:20 |
| opendevreview | Clark Boylan proposed opendev/gerritlib master: Fix CI setup https://review.opendev.org/c/opendev/gerritlib/+/813456 | 16:20 |
| clarkb | EMS has updated price terms but we're grandfathered in for the OpenDev server, I don't have any concerns there. But might be worth a look to see if we should switch plans intentionally | 16:27 |
| *** jpena is now known as jpena|off | 16:45 | |
| clarkb | fungi: re project renaming prep were you goign to look at running the metadata update after renames? | 16:59 |
| fungi | yeah, but i havent yet | 17:01 |
| opendevreview | Ananya proposed opendev/elastic-recheck rdo: WIP: ER bot with opensearch for upstream https://review.opendev.org/c/opendev/elastic-recheck/+/813250 | 17:05 |
| *** ysandeep|out is now known as ysandeep | 17:05 | |
| opendevreview | Ananya proposed opendev/elastic-recheck rdo: WIP: ER bot with opensearch for upstream https://review.opendev.org/c/opendev/elastic-recheck/+/813250 | 17:11 |
| opendevreview | Ananya proposed opendev/elastic-recheck rdo: WIP: ER bot with opensearch for upstream https://review.opendev.org/c/opendev/elastic-recheck/+/813250 | 17:14 |
| opendevreview | Ananya proposed opendev/elastic-recheck rdo: WIP: ER bot with opensearch for upstream https://review.opendev.org/c/opendev/elastic-recheck/+/813250 | 17:22 |
| opendevreview | Merged opendev/system-config master: Update gitea to 1.15.4 https://review.opendev.org/c/opendev/system-config/+/813243 | 17:40 |
| clarkb | the deploy job for that just started | 17:42 |
| clarkb | I'm keeping an eye on it | 17:43 |
| opendevreview | Ananya proposed opendev/elastic-recheck rdo: WIP: ER bot with opensearch for upstream https://review.opendev.org/c/opendev/elastic-recheck/+/813250 | 17:46 |
| clarkb | gitea01 has updated and lgtm | 17:47 |
| fungi | yeah, i'm not seeing any issues with it either | 17:48 |
| opendevreview | Merged opendev/system-config master: Force gerrit image build to tag 3.4 https://review.opendev.org/c/opendev/system-config/+/813449 | 17:50 |
| clarkb | the image promote jobs for ^ are behind the gitea upgrade deploy job. Once those happen I'll recehck things to hopefully get happy test results back | 17:51 |
| clarkb | the system-config-run job does run successfull for 3.4 so should be fine, just need a version tagged on docker hub | 17:52 |
| clarkb | fungi: https://review.opendev.org/c/opendev/gerritlib/+/813456 and child are two easy fixes/cleanups | 17:53 |
| clarkb | https://review.opendev.org/c/opendev/system-config/+/813453 too | 17:53 |
| clarkb | through 06 are done now | 17:58 |
| clarkb | and now all eight are done. lgtm from what I see | 18:02 |
| clarkb | https://hub.docker.com/layers/opendevorg/gerrit/3.4/images/sha256-e45714038d430ab4c5bc91efcb866aef4d0c15606d6a0ceab409b5568a7c6122?context=explore that exists now. Time to recheck things | 18:07 |
| *** ysandeep is now known as ysandeep|out | 18:08 | |
| clarkb | on the upgrade diff check for gerrit I think we should land that first, then if it creates major problems for the 3.3 -> 3.4 upgrade test job we can make that non voting to land the 3.2 removal stuff. Then sort out the 3.4 upgrade next | 18:19 |
| opendevreview | Merged opendev/gerritlib master: Fix CI setup https://review.opendev.org/c/opendev/gerritlib/+/813456 | 18:23 |
| opendevreview | Merged opendev/gerritlib master: Rename Gerrit Non-Interactive Users to Service Users https://review.opendev.org/c/opendev/gerritlib/+/813452 | 18:31 |
| clarkb | fungi: if you have time for more reviews I think we land https://review.opendev.org/c/opendev/system-config/+/813375 next. Then we can recheck https://review.opendev.org/c/opendev/system-config/+/813073 and determine if we need to make any changes for that upgrade to run properly. | 18:53 |
| clarkb | I guess https://review.opendev.org/c/opendev/system-config/+/813310 is related to 813375 and we probably want to land them both? | 18:54 |
| fungi | mmm, codesearch seems to be down? | 19:17 |
| fungi | or maybe my home network is broken | 19:18 |
| fungi | must have been me, i can reach it now and uptime is 64 days | 19:19 |
| clarkb | ya I can get to it | 19:27 |
| clarkb | fwiw I think https://www.gerritcodereview.com/3.4.html#other-core-changes is what concerned me when lokoing at 3.4 upgrades. The amount of changes is very large | 19:33 |
| opendevreview | Merged opendev/system-config master: gerrit: diff config files on upgrade https://review.opendev.org/c/opendev/system-config/+/813375 | 19:36 |
| clarkb | I have rechecked https://review.opendev.org/c/opendev/system-config/+/813073 to get us new results on the shift of the upgrade job now that the diff checker is in place | 19:38 |
| clarkb | fungi: I finally got around to reviewing and approving https://review.opendev.org/c/opendev/system-config/+/812527 to make the ansible-devel job a bit more useful again | 20:03 |
| opendevreview | Merged opendev/system-config master: Test ansible-devel with an ubuntu-focal bridge.o.o https://review.opendev.org/c/opendev/system-config/+/812527 | 20:13 |
| fungi | clarkb: thanks! i suppose that also means we can safely upgrade bridge to focal | 20:18 |
| clarkb | fungi: https://review.opendev.org/c/opendev/system-config/+/813073 still passes after the diff check landed. I think we can land that change next. Then we'll be ready to drop the 3.2 image management whenever we are comfortable with having a more difficult revert should that become necessary | 20:19 |
| clarkb | but I found an issue that caused the quoting in gerrit config fix to fail that I'm trying to sort out | 20:19 |
| clarkb | we're setting heapLimit to 96GB on our test nodes and sometimes taht causes problems: https://zuul.opendev.org/t/openstack/build/b6cd7ddad6774dc3be11b254bbb26efe/log/review02.opendev.org/docker/gerrit-compose_gerrit_1.txt#35-38 | 20:20 |
| fungi | oh, hah! yeah i can see where a 96gb heap limit on an 8gb ram test node might cause a problem ;) | 20:20 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Replace testing group vars with host vars for review02 https://review.opendev.org/c/opendev/system-config/+/813534 | 20:26 |
| clarkb | I think ^ should fix it but you all should review that one very carefully to be sure I didn't accidentally update prod vars or similar | 20:26 |
| clarkb | I've rechecked the config quote fixup as the above change should correct the issue it hit and that issue doesn't seem super common | 20:31 |
| clarkb | ianw: fungi: also now i wonder if we're properly checking config diffs in the upgrade test since it seems like the upgrade should've failed without the quote fix? | 20:31 |
| clarkb | I don't think it hurts to have that check running, but we probably don't want to rely on it too much yet without confirmation it does what we expect? | 20:32 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Replace testing group vars with host vars for review02 https://review.opendev.org/c/opendev/system-config/+/813534 | 20:43 |
| clarkb | needed to update file matchers to run the review tests | 20:43 |
| fungi | i thought the quotes change was proposed to get the diff addition to pass? but it's likely i misconstrued the relationship between thse (or lack thereof) | 20:47 |
| clarkb | fungi: I don't think they had a strict relationship | 20:47 |
| fungi | yeah, starting to realize that | 20:47 |
| clarkb | and ya it occurred to me after the test job update landed but the quote fix didn't that maybe the diff check isn't really testing what we want it to | 20:47 |
| clarkb | fungi: we can remove the +A from the quotes check if we want to before landing | 20:48 |
| clarkb | but I think the quotes fix is fine as is since | 20:48 |
| clarkb | er since it is largely removing quotes and gerrit doesn't want them there | 20:48 |
| fungi | right | 20:48 |
| *** dviroel is now known as dviroel|out | 21:16 | |
| ianw | clarkb: hrm, yes i wondered about it passing too, i'll look into it | 21:20 |
| ianw | https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_331/813375/5/check/system-config-upgrade-review/331c69e/review02.opendev.org/etc/gerrit.config.pre-upgrade | 21:24 |
| ianw | https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_331/813375/5/check/system-config-upgrade-review/331c69e/review02.opendev.org/etc/gerrit.config | 21:24 |
| ianw | they are the same -- but that suggests that 3.2 re-wrote the config file | 21:25 |
| fungi | oh, yeah gerrit "just does that" and has since ~forevah | 21:28 |
| fungi | if you start gerrit, it will rewrite its config based on its own sense of style | 21:29 |
| opendevreview | Shnaidman Sagi (Sergey) proposed openstack/diskimage-builder master: Improve DIB for building CentOS 9 stream https://review.opendev.org/c/openstack/diskimage-builder/+/806819 | 21:57 |
| ianw | we can check before as well, it might be getting a bit ott. i guess that would flag if something changed in a point release | 22:01 |
| opendevreview | Merged opendev/system-config master: gerrit: Update quotes for 3.3 https://review.opendev.org/c/opendev/system-config/+/813310 | 22:20 |
| clarkb | oh good point it could be that our old config was getting rewritten too | 22:37 |
| clarkb | I'd believe that | 22:37 |
| ianw | can someone with an account confirm | 22:38 |
| ianw | https://gerrit-review.googlesource.com/#/dashboard/?title=Mine&foreach=owner:self&My+Pending=is:open&My+Merged=is:merged | 22:38 |
| ianw | gives them a blank page? | 22:38 |
| ianw | just following up on frickler's issue and want to make sure i'm not nuts | 22:38 |
| clarkb | ianw: yes first load seems to be blank then I do a refresh and I get stuff | 22:39 |
| clarkb | seems upstream exhibits the same behavior (a good thing?) | 22:39 |
| ianw | yep, and if you watch the url bar, it sort of loads, then the fragment # disappears? | 22:39 |
| ianw | yeah, it's not quite the same as what we saw -- but much easier to explain to upstream :) | 22:40 |
| clarkb | yup that happens to me too | 22:40 |
| ianw | ok, it may just be documentation on using /#/dashboard is out of date; i'll ask and if it is can propose an update | 22:41 |
| clarkb | ++ | 22:41 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Replace testing group vars with host vars for review02 https://review.opendev.org/c/opendev/system-config/+/813534 | 22:42 |
| clarkb | hopefully ^ is closer to working | 22:42 |
| clarkb | there are a few UI things I really like on 3.3 in particular when you rename or delete/add files that is called out very explicitly now | 22:48 |
| clarkb | fungi: https://review.opendev.org/c/opendev/system-config/+/813073 any objections to landing that now? | 22:48 |
| clarkb | fungi: also https://review.opendev.org/c/opendev/system-config/+/813453 | 22:49 |
| clarkb | ianw: I think it was you who asked what big changes in 3.4 had me concerned and after rereading the release notes I think it was more the long list at https://www.gerritcodereview.com/3.4.html#other-core-changes less so than any single big change | 22:50 |
| ianw | clarkb: yeah i think the diff is working, so probably best we just leave it and we'll catch future changes (rather than trying to add another step to pre-check) | 22:51 |
| clarkb | ianw: ++ sounds good to me | 22:51 |
| clarkb | but also I think we probably can start planning for a 3.4 upgrade ~post PTG | 22:51 |
| ianw | haha yes that gives the old scroll finger a workout | 22:52 |
| clarkb | The 3.4 upgrade also doesn't need an offline reindex, it reindexes online | 22:53 |
| clarkb | the upgrade itself should be super straightforward like the 3.3 upgrade. Just need to test that things work with it like the zuul summary (I think it does because the system-config-run-review-3.4 job passes) and zuul itself etc | 22:53 |
| clarkb | ianw: also luca indicated he is waiting on reviews for release notes before doing that 3.3.7 release. I would expect it to happen soon but hasn't happened yet | 22:56 |
| ianw | so the checks api is finally a thing with 3.4? | 22:57 |
| clarkb | ianw: I think it may just be the standardized UI rendering of checks results? | 22:57 |
| clarkb | the checks api itself is deprecated? But that is something we should probably try to get clarification on since it is confusing | 22:58 |
| clarkb | corvus: may understand it better through his work integrating zuul upstream | 22:58 |
| clarkb | fungi: thank you for the reviews! | 23:01 |
| fungi | pip 21.3 was just now released | 23:02 |
| fungi | apparently comes with a "faster" and "smarter" dep solver | 23:02 |
| fungi | also installing from a git repo does "partial cloning" though hopefully nobody's really doing things in jobs which could be impacted by that | 23:03 |
| clarkb | here's hoping it helps | 23:03 |
| clarkb | fungi: that can affect pbr's version calculations I think | 23:03 |
| fungi | i assume that changelog entry is about git-specific url requirements, not generally installing from a local directory which just happens to also be a git repo | 23:04 |
| clarkb | I think that leaves us with https://review.opendev.org/c/opendev/system-config/+/813074/ and https://review.opendev.org/c/opendev/system-config/+/813534 as the last changes I had related to the gerrit upgrade. The first one we should only land when we're happy with rolling forawrd with 3.3 and not reverting and the second should be mergeable whenever but deserves careful review to | 23:05 |
| clarkb | make sure I haven't gotten the prod vars mixed up inappropriately | 23:05 |
| clarkb | fungi: that would be my hunch given you don't need to clone when pointed at a local dir | 23:06 |
| clarkb | I've updated the infra meeting agenda. Is there anything missing that should be added? I'll give you all ~10-15 minutes to say something before I send it out | 23:22 |
| fungi | seems good to me | 23:24 |
| ianw | lgtm, i'll get back to the parallel job thing soon | 23:26 |
| clarkb | ya I'm hoping to get back to account cleanups soon too. Though probably next week at the earliest | 23:29 |
| clarkb | We've been having too much fun with updating all the things :) | 23:29 |
| opendevreview | Merged opendev/system-config master: Test upgrade from Gerrit 3.3 to 3.4 https://review.opendev.org/c/opendev/system-config/+/813073 | 23:35 |
| opendevreview | Merged opendev/system-config master: Rename Gerrit Non-Interactive Users to Service Users https://review.opendev.org/c/opendev/system-config/+/813453 | 23:35 |
| opendevreview | Merged opendev/system-config master: letsencrypt: avoid running on handler changes https://review.opendev.org/c/opendev/system-config/+/812765 | 23:35 |
| ianw | clarkb: if feel like there is a way we can avoid duplicating things like the backup list | 23:37 |
| ianw | maybe that should go in the global group-level? | 23:37 |
| ianw | (813534) | 23:37 |
| clarkb | ianw: ya I think one option is to put the common stuff in the prod review.yaml group vars file | 23:38 |
| clarkb | then only specify things like replication and heap size etc in the per host host var file | 23:38 |
| clarkb | I can give that a go if you think that would be better | 23:39 |
| ianw | probably better to avoid duplication of things like that; and it should be applicable if we ever have a review03 etc too | 23:40 |
| clarkb | it looks like my change successfully set the heap limit to 6g insteadof 96g | 23:40 |
| clarkb | ya, let me give that a go | 23:40 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Replace testing group vars with host vars for review02 https://review.opendev.org/c/opendev/system-config/+/813534 | 23:51 |
| clarkb | ianw: ^ I think that is better but it also calls out hwo we inconsistently use the 'review' and 'gerrit' groups. In this case I'ev stuck with 'review' because the service-review.yaml playbook uses that group to match hosts. But I think a good followup to this change would be combining the two groups and being consistent (drop one or the other in the process0 | 23:52 |
| mordred | clarkb: I believe at one point in time in history, review == production review\d+ and gerrit == dev+production - review{,-dev)0\d+ | 23:55 |
| mordred | I agree - rationalizing seeming like a good idea at this point | 23:55 |
| ianw | ++ on that | 23:58 |
| ianw | question inline about what we need to override, but lgtm | 23:58 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!