| *** gmann is now known as gmann_afk | 00:07 | |
| opendevreview | Jeremy Stanley proposed zuul/zuul-jobs master: Test tox.requires doesn't break sibling installs https://review.opendev.org/c/zuul/zuul-jobs/+/812004 | 01:06 |
|---|---|---|
| *** gmann_afk is now known as gmann | 01:11 | |
| *** ysandeep|out is now known as ysandeep|sick | 05:11 | |
| *** jpena|off is now known as jpena | 06:58 | |
| *** frickler_ is now known as frickler | 07:25 | |
| *** odyssey4me is now known as Guest1483 | 08:12 | |
| *** ykarel is now known as ykarel|lunch | 08:50 | |
| opendevreview | Marios Andreou proposed openstack/diskimage-builder master: Correct path for CentOS 9 stream base image https://review.opendev.org/c/openstack/diskimage-builder/+/806819 | 09:02 |
| *** ykarel|lunch is now known as ykarel | 10:20 | |
| *** dviroel|out is now known as dviroel | 10:47 | |
| *** jpena is now known as jpena|lunch | 11:27 | |
| *** jpena|lunch is now known as jpena | 12:26 | |
| opendevreview | Jeremy Stanley proposed zuul/zuul-jobs master: Revert "Revert "Include tox_extra_args in tox siblings tasks"" https://review.opendev.org/c/zuul/zuul-jobs/+/812005 | 12:37 |
| *** ykarel is now known as ykarel|afk | 12:43 | |
| mrkiko | Hello folks!! I am a blind user of gertty. All seems to work, but the fact that it doesn't use terminal cursor consistently to hilight focused element gets in my way. I am using a screen reader software, and when the cur4sor doesn't move on the hilightyed element, I can't basically understand what I am doing. Any chance you could help me? | 12:48 |
| opendevreview | Jeremy Stanley proposed zuul/zuul-jobs master: Test tox.requires doesn't break sibling installs https://review.opendev.org/c/zuul/zuul-jobs/+/812004 | 12:49 |
| opendevreview | Jeremy Stanley proposed zuul/zuul-jobs master: Revert "Revert "Include tox_extra_args in tox siblings tasks"" https://review.opendev.org/c/zuul/zuul-jobs/+/812005 | 12:49 |
| fungi | mrkiko: i think we narrowed that down to a regression with newer urwid. let me see if i can figure out which version started breaking it | 12:49 |
| mrkiko | fungi: that would help me a lot really. If I cxan do something, let me know | 12:51 |
| fungi | mrkiko: per my previous notes, something changed between urwid 2.0.1 and 2.1.0 causing it to no longer highlight some things like the parent change field. downgrading to urwid<2.1 and restarting gertty got it working for me again | 12:51 |
| fungi | i haven't had time to try bisecting urwid commits to work out where it broke, so not yet sure what change is needed to gertty to accommodate current urwid versions there | 12:52 |
| fungi | mrkiko: are you installing gertty with pip or with a distro package (or some other way)? | 12:53 |
| fungi | if it's pip installed, then downgrading urwid there should be easy to test and see if that addresses the problem you're experiencing | 12:54 |
| mrkiko | fungi: but, does the hardware cursor move around in the old urwid version? I can't see easily the hilighting | 12:56 |
| mrkiko | fungi: it's distro installed but it's from arch / AUR so and it's a gertty-git I think, so I can pretty much upgrade it at will. I can downgrade urwid, yes. | 12:57 |
| fungi | mrkiko: oh, i think i understand what you're getting at, i recall some mainframe-based applications i've used in the past via serial terminal had similar behavior... it's possible that's an option in urwid, though unfortunately i suspect it may not be | 12:58 |
| fungi | i'll check the urwid docs for mention of anything which seems like it might be that | 12:58 |
| fungi | also corvus may know when he's around | 13:00 |
| fungi | the canvas class can be initialized with cursor coordinates, but i'm not yet finding anything which can force the cursor to be displayed | 13:03 |
| fungi | possible i'm digging in the wrong place though | 13:04 |
| mrkiko | fungi: I would be very grateful if you help me out. | 13:05 |
| fungi | mrkiko: are you wanting a free-floating cursor (old mainframe style), or just for the cursor position to be moved to whatever's highlighted (like lynx does it)? | 13:06 |
| mrkiko | fungi: lynx behaviour would be the ideal; if free-floating one is possible, then I would need a clear way to edistinguish "buttons" (i.e.: things that may do something if I presse enter on them) vs static text | 13:07 |
| mrkiko | using a braille display to read things | 13:07 |
| fungi | the listbox widget has a make_cursor_visible() method which might do the trick: https://urwid.org/reference/widget.html#urwid.ListBox.make_cursor_visible | 13:09 |
| fungi | i get the impression most other widgets are already expected to show the cursor when they have focus | 13:09 |
| fungi | yeah, getting into the gertty source, it does seem to use listboxes for a lot of the interface, so maybe that's why | 13:11 |
| fungi | it could be as simple as calling that make_cursor_visible() method in a few key listbox constructors, but i'll need to play around with it | 13:13 |
| fungi | i've got a couple of meetings, but hopefully i can tinker with it in a few hours if nothing else catches fire | 13:14 |
| mrkiko | fungi: :D :D thanks a lot. If I can do something to help out, let me know. Really. It would be an important thing for me. | 13:17 |
| *** ykarel|afk is now known as ykarel | 13:29 | |
| *** ysandeep|sick is now known as ysandeep | 13:55 | |
| corvus | mrkiko: fungi to make sure i understand, we're not talking about the "keyboard navigation doesn't highlight "depends on" change links with new urwird versions problem. instead, it's that we need to having a blinking underscore or box cursor on the button that's highlighted? | 14:22 |
| fungi | corvus: roughly, i think... the terminal needs to be told to move its cursor to the start of what's being highlighted, which may or may not also require a non-hidden cursor (but not hiding the cursor may also make it easier to confirm the terminal's actual cursor location) | 14:26 |
| *** ykarel is now known as ykarel|away | 14:26 | |
| fungi | it seems that screen readers rely on the terminal cursor position to know where to start streaming characters | 14:26 |
| fungi | basically if you just launch `lynx` (assuming you have it installed) and navigate around its built-in homepage with the arrow keys, you'll see a terminal cursor at the start of the hyperlinks there | 14:27 |
| corvus | ack. and just to get into the weeds -- lynx puts the cursor in the space between words rather than on the first character. if wonder if that's aesthetic or functional. | 14:29 |
| TheJulia | Anyone ever seen zuul spit out "Unable to freeze job graph: 0" ? | 14:33 |
| fungi | TheJulia: yes, usually it's an indication that there's a configuration error in the change or which has started to impact one of the projects needed for it | 14:34 |
| corvus | TheJulia: the change has no files | 14:35 |
| corvus | and there's a job with a file matcher | 14:35 |
| clarkb | Interesting that nova ran into this the other day | 14:35 |
| corvus | i think clarkb reported that as a bug yesterday | 14:35 |
| clarkb | corvus: well I mentioned it. I'm still on the fence as to whether it is a bug. Or rather whether it being an error is a bug. I think the message reported could be better | 14:36 |
| * TheJulia sighs | 14:36 | |
| corvus | yes, we do strive to do better than "0" :) | 14:36 |
| * TheJulia goes and changes a file to run a cross-repo change | 14:36 | |
| corvus | is there a meme going around about empty commits? | 14:36 |
| TheJulia | test | 14:36 |
| TheJulia | who knows | 14:36 |
| corvus | just wondering why we've seen 2 all of a sudden (this is not a new bug in zuul, it's been latent for years) | 14:37 |
| TheJulia | did someone else raise the same question? | 14:37 |
| clarkb | TheJulia: yes gouthamr pushed an empty commit to nova the other day | 14:38 |
| TheJulia | hmm | 14:38 |
| corvus | hrm it looks like https://review.opendev.org/c/openstack/ironic-inspector/+/812137 is the change in question? | 14:38 |
| corvus | that does'nt look empty to me, nor does its depends-on | 14:38 |
| TheJulia | oh, on multiple jobs this morning | 14:38 |
| TheJulia | didn't even notice it that | 14:39 |
| TheJulia | I noticed it on a bifrost change which I just revised | 14:39 |
| corvus | oh ps1 is empty | 14:39 |
| corvus | ps2 has a file | 14:39 |
| TheJulia | basically pushing a semi-breaking change for CI into ironic and doing cross-repo testing | 14:39 |
| corvus | (and it's ps1 that got the error) | 14:39 |
| corvus | okay, so yes, this is the same issue. basically: file matchers not compatible with changes with no files. | 14:40 |
| TheJulia | fun, I guess only in the last couple of years for zuul? | 14:45 |
| TheJulia | feels like I've pushed empty commits before without issues, but it could have been a long time ago | 14:46 |
| *** mazzy56 is now known as mazzy5 | 14:46 | |
| fungi | TheJulia: they would have worked without files matchers | 14:48 |
| fungi | so could be the jobs for the projects in question weren't using them until more recently | 14:49 |
| TheJulia | we've had file matchers for ages | 14:49 |
| TheJulia | but *shrug*, it really doesn't matter | 14:49 |
| corvus | fungi: i don't think that listbox method is what we're looking for; i think that just makes it scroll so the cursor is in view | 14:54 |
| fungi | corvus: yeah, the more i read the rest of the reference, the more i got the impression it may also need to call functions to relocate the cursor | 14:55 |
| fungi | but unhiding the cursor will probably help in being able to check that it's doing that | 14:56 |
| corvus | fungi: have you found where it hides it? | 14:59 |
| *** ysandeep is now known as ysandeep|out | 15:00 | |
| corvus | oh here we go: https://github.com/urwid/urwid/blob/master/urwid/raw_display.py#L714 | 15:01 |
| fungi | corvus: ahh thanks, and no i got sidetracked by meetings but was going to dig back in shortly | 15:02 |
| corvus | that looks fairly hard-coded, this may be tricky. | 15:02 |
| corvus | okay, a very quick hack to remove that shows me that: 1) that is reponsible for hiding the ecursor, and 2) urwid leaves the cursor in strange places, almost never at the start of something highlighted. so fixing this may require non-trivial changes to urwid. | 15:05 |
| fungi | corvus: for testing purposes i can probably just tweak the urwid source to un-hide the cursor, and then see if forcing cursor location on highlight $somehow is sufficient for accommodating screen readers | 15:05 |
| fungi | ahh, yeah, that's what i was wondering | 15:05 |
| fungi | corvus: most of the widget classes have a cursor attr, which defaults to None but seems to take a (relative?) coordinate pair when initializing, so maybe that's part of the answer | 15:06 |
| mrkiko | corvus: so, by default lynx hidden the cursor some time ago. To have it not hide it, you should set show_cursor to false in the lynx.cfg file | 15:07 |
| mrkiko | corvus: It would be ok for me even if the cursor was on the first character. | 15:08 |
| fungi | first character of whatever's being highlighted, you mean? | 15:08 |
| corvus | mrkiko: thanks, that's good to know | 15:08 |
| corvus | the cursor appears at the start of the word for the review, diff, local checkout, local cherry-pick buttons | 15:09 |
| corvus | for just about everything else, it appears at the end of the box it's formatting (so several characters to the right of the reply button, for example) | 15:10 |
| corvus | and doesn't always move consistently | 15:11 |
| corvus | like, it may remain on the line below if you arrow-up, or it may remain on the line above if you arrow-down | 15:11 |
| fungi | so the arrows are scrolling the viewport rather than necessarily relocating the cursor | 15:12 |
| corvus | probably, but even without any actual scrolling this is true | 15:12 |
| fungi | mmm | 15:12 |
| *** artom_ is now known as artom | 15:13 | |
| mrkiko | corvus: sorry, show_cursor:true doesn't hide the cursor of cours.e I'm tired... | 15:14 |
| mrkiko | :) | 15:14 |
| corvus | mrkiko: that's okay, for some reason my lynx defaulted to showing the cursor anyway :) | 15:14 |
| fungi | as has mine, but maybe it's older than the change to start hiding it | 15:17 |
| opendevreview | Jeremy Stanley proposed zuul/zuul-jobs master: More exact section matching for tox showconfig https://review.opendev.org/c/zuul/zuul-jobs/+/812160 | 15:20 |
| opendevreview | Ade Lee proposed zuul/zuul-jobs master: DNM https://review.opendev.org/c/zuul/zuul-jobs/+/807031 | 15:20 |
| opendevreview | Merged openstack/diskimage-builder master: Allowing ubuntu element use local image https://review.opendev.org/c/openstack/diskimage-builder/+/809009 | 15:31 |
| clarkb | TheJulia: gouthamr: fyi https://review.opendev.org/c/zuul/zuul/+/812161 | 15:32 |
| gouthamr | nice! | 15:33 |
| mrkiko | fungi: corvus: I guess it was more a change in tyhe default in general | 15:37 |
| corvus | TheJulia: i stand corrected, that likely was a recently introduced zuul bug | 15:37 |
| *** dviroel is now known as dviroel|lunhc | 15:42 | |
| *** dviroel|lunhc is now known as dviroel|lunch | 15:42 | |
| fungi | looking through the urwid history it seems like they were trying to make that work for some controls: https://github.com/urwid/urwid/pull/116 landed in 2.1.0 | 15:44 |
| *** marios is now known as marios|out | 15:46 | |
| fungi | also i see some references to calling self._invalidate() after focus changes to update cursor position | 15:49 |
| corvus | one thing i notice is the "Reply" button isn't actually a button, it's a Link which is a gertty-local widget, so that may need better cursor handling to match the buttons | 15:49 |
| fungi | i also see a report that lineboxes confuse the cursor position while unlined boxes initialize the cursor to (relative) 0,0 | 15:50 |
| TheJulia | clarkb: awesome, thanks! | 15:53 |
| opendevreview | Jeremy Stanley proposed zuul/zuul-jobs master: More exact section matching for tox showconfig https://review.opendev.org/c/zuul/zuul-jobs/+/812160 | 16:03 |
| opendevreview | Jeremy Stanley proposed zuul/zuul-jobs master: Revert "Revert "Include tox_extra_args in tox siblings tasks"" https://review.opendev.org/c/zuul/zuul-jobs/+/812005 | 16:03 |
| *** jpena is now known as jpena|off | 16:09 | |
| corvus | fungi, mrkiko: yeah, it looks like a lot of the problem is that the gertty hypertext widget doesn't handle cursors right. i'm working on improving that. | 16:15 |
| *** dviroel|lunch is now known as dviroel | 16:26 | |
| opendevreview | James E. Blair proposed ttygroup/gertty master: Correctly locate cursor in hypertext widgets https://review.opendev.org/c/ttygroup/gertty/+/812170 | 16:28 |
| corvus | fungi, mrkiko: https://review.opendev.org/c/ttygroup/gertty/+/812170 should be the first step in addressing that. it's not everything, but that should make the internal links in commit messages highlight correctly, as well as the "Reply" buttons | 16:29 |
| corvus | the next thing i note is that some of the fields in the change info area also don't have cursors. | 16:29 |
| corvus | fungi: i think the issue is, at least at first, not so much about whether the cursor is hidden or not, but that if an urwid widget doesn't supply a cursor position, it will automatically be hidden. so we don't actually need to tell urwid not to hide the cursor, but instead, we need to tell it where to put it in the first place. | 16:30 |
| fungi | corvus: got it, and that's what the cursor parameters for the widget initiators are for? | 16:31 |
| corvus | i confess, i didn't even really notice that we were already had a visible cursor on the "Review" "Diff", etc buttons. but they are there. so what i did in that change was to make the links behave like the buttons do, and then the cursor automatically appeared. | 16:32 |
| corvus | fungi: i haven't actually run into that yet. | 16:32 |
| fungi | it wasn't clear to me from the api reference whether the cursor parameter would warp the position to the widget on focus | 16:33 |
| corvus | fungi: if you have a minute to double check 812049 looks good, i'll go ahead and merge that | 16:42 |
| fungi | yep, in the process of restarting on it now | 16:42 |
| fungi | are you testing with urwid 2.0 or 2.1? | 16:42 |
| corvus | 2.1 | 16:43 |
| clarkb | note 812049 is a zuul bug fix for anyone following along. I think they mean 812170 | 16:43 |
| corvus | oh yes sorry :) | 16:44 |
| fungi | ahh, yes i meant 812170 (812049 is already approved anyway) | 16:44 |
| fungi | corvus: lgtm, i do see the cursor jump to the start of each control when it's highlighted | 16:46 |
| corvus | great. there's more to do, but this is probably 70% of the outstanding issues, so i'll go ahead and merge it. | 16:47 |
| fungi | thanks for that, i'll try to narrow down what urwid commit(s) broke the depends on and needed by fields | 16:47 |
| fungi | maybe that'll provide a clue as to how to solve them | 16:47 |
| corvus | fungi: yeah, we're gonna need that too | 16:48 |
| fungi | 101 commits on urwid from release-2.0.1 to release-2.1.0 | 16:50 |
| opendevreview | Merged ttygroup/gertty master: Correctly locate cursor in hypertext widgets https://review.opendev.org/c/ttygroup/gertty/+/812170 | 16:50 |
| corvus | mrkiko: we've merged one change that should provide a noticeable improvement if you want to update to git master; hopefully we can get the rest done soon. | 16:51 |
| melwitt | this might be a dumb question but I was wondering, if I have a stack of several patches and one at the bottom Depends-On a change in another repo, will all the following patches in the stack also depend on it? | 16:52 |
| corvus | melwitt: yes | 16:53 |
| melwitt | sweet. thanks | 16:53 |
| fungi | zuul considers all the transitive dependencies of any change, whether implied or explicit, to be part of the set it should test | 16:57 |
| fungi | wow, skimming those 101 urwid commits, some have titles like "I love cheese." or "And again." or "Damn you Travis." | 17:01 |
| fungi | cute, but unhelpful | 17:01 |
| clarkb | fungi: I'm often reminded that I should be grateful for our culture of writing decent commit messages | 17:02 |
| corvus | yeah that's no way to run a railroad | 17:02 |
| fungi | corvus: no idea why yet, but https://github.com/urwid/urwid/commit/86c6101 is where it stops working | 17:12 |
| fungi | really just added a check for if hasattr(self._topmost_widget, "mouse_event") | 17:13 |
| fungi | reverting that doesn't bring back the behavior though, so the history may not be entirely linear so there could be another commit involved | 17:15 |
| *** ysandeep|out is now known as ysandeep | 17:17 | |
| fungi | yeah, more likely it's dd5414f Merge branch 'columns-selectable' | 17:17 |
| fungi | also reverting 95bc645 and 018509d from that series seems to have fixed it, so hopefully i can narrow it down to one of the two | 17:25 |
| fungi | corvus: reverting https://github.com/urwid/urwid/commit/018509d on top of master fixes the behavior for me, and that commit does look more likely to have changed behavior there | 17:28 |
| fungi | seems like maybe it's thinking those aren't supposed to be selectable? | 17:29 |
| fungi | probably the if w.selectable() check is failing for them | 17:30 |
| corvus | fungi: thanks! | 18:04 |
| fungi | of course, i'm still trying to work out for sure if that's the case and why it might cause that, but it's a start | 18:06 |
| *** ysandeep is now known as ysandeep|out | 18:17 | |
| fungi | corvus: also https://review.opendev.org/809279 is necessary for me to be able to install gertty without forcing an alembic downgrade | 18:35 |
| corvus | fdegir: ++ we'll get all of those eventually :) | 18:36 |
| corvus | fungi: ^ sorry fdegir | 18:36 |
| fungi | no prob | 18:36 |
| opendevreview | Merged ttygroup/gertty master: Import alembic.migration https://review.opendev.org/c/ttygroup/gertty/+/809279 | 18:36 |
| fungi | and yeah, it was just a copy of how you fixed the same issue in zuul | 18:36 |
| fungi | well, i've so far worked out that forcing _selectable = True when initializing ChangeButton widgets doesn't work around the related changes selection problem, i'm still fumbling around trying to grok urwid | 18:38 |
| fungi | oh, or maybe the super() was overriding that | 18:40 |
| fungi | nope, not it | 18:40 |
| fungi | oh, right, rows winds up in a pile, and the offending urwid commit defaulted piles to have _selectable = False | 18:55 |
| fungi | though naively switching that in the instantiated pile doesn't seem to help | 18:57 |
| fungi | swapping the default on the Pile class in urwid does fix it though, so maybe i'm just not properly updating the pile after setting it selectable | 19:00 |
| fungi | aha, nope, i was on the right track, just setting it on the wrong object | 19:11 |
| fungi | i have a simple gertty patch that's working with latest urwid there now, but my internet provider has picked this moment to stop letting me make new outbound connections for some reason | 19:25 |
| fungi | oh, or it's that gerrit is down | 19:27 |
| fungi | is anyone else having trouble reaching gerrit (over ipv4 or ipv6)? | 19:27 |
| fungi | checking the nova api at vexxhost | 19:28 |
| fungi | says the instance is "active" | 19:30 |
| fungi | no errors on the server's console, and it's responsive | 19:31 |
| fungi | i can reach mirror.ca-ymq-1.vexxhost.opendev.org over both ipv4 and ipv6 | 19:33 |
| fungi | but it also can't reach the gerrit server | 19:34 |
| fungi | https://status.vexxhost.com/ says things are peachy | 19:35 |
| fungi | infra-root: any opinions on what to do next? | 19:35 |
| ildikov | yep, a few of us are doing an OpenStack training today and Gerrit is certainly down | 19:37 |
| fungi | now it's taking forever for me to get a response back from the nova api in vexxhost ca-ymq-1 | 19:38 |
| fungi | thanks for confirming ildikov! | 19:39 |
| ildikov | fungi: np | 19:39 |
| melwitt | same here | 19:39 |
| melwitt | (gerrit) | 19:39 |
| melwitt | review.opendev.org took too long to respond. ERR_CONNECTION_TIMED_OUT | 19:39 |
| ildikov | not sure what else I can do, but will monitor the channel here to keep the training participants up to date | 19:39 |
| ildikov | I hope it's something easy to fix! | 19:40 |
| simondodsley | don't we all.... :) | 19:40 |
| fungi | mnaser: any chance you have a moment to see if the port for server instance 16acb0cb-ead1-43b2-8be7-ab4a310b4e0a (review02.opendev.org) has become disconnected or something? | 19:40 |
| mnaser | fungi: yes, we've got a weird issues going on here with neutron. it's being worked/restored on, the port should be reappearing | 19:40 |
| clarkb | fungi: sorry was away from the keyboard | 19:40 |
| fungi | mnaser: thanks for the heads up! | 19:40 |
| clarkb | ah ok sounds like something we can't fix ourselves /me will wait patiently | 19:41 |
| ildikov | simondodsley: that was the most clever thing I could come up with to say on Friday afternoon, lol | 19:41 |
| fungi | our graphs indicate cacti lost contact with review between the 19:10 and 19:15 utc snmp polls | 19:42 |
| fungi | #status notice The review.opendev.org Gerrit server has become unreachable as of approximately 19:10 UTC due to a networking issue in the provider, but should be reachable again shortly | 19:43 |
| opendevstatus | fungi: sending notice | 19:43 |
| -opendevstatus- NOTICE: The review.opendev.org Gerrit server has become unreachable as of approximately 19:10 UTC due to a networking issue in the provider, but should be reachable again shortly | 19:43 | |
| clarkb | fungi: I think we still use a cinder volume on review to host the review_site contents | 19:45 |
| clarkb | fungi: when this is resolved we may need to check that that wasn't impacted? | 19:45 |
| clarkb | (I'm not sure how that is attached under the hood but if it relies on that network port...) | 19:45 |
| fungi | yeah, i'll have a look once i can reach it again | 19:46 |
| fungi | good call | 19:46 |
| fungi | ooh, it seems to be back up | 19:48 |
| mnaser | clarkb: it shouldn't be impacted, this was only neutron-network facing | 19:48 |
| Clark[m] | Cool | 19:48 |
| fungi | yeah, no sign of block device disconnects in dmesg | 19:48 |
| fungi | we proabably tossed a few change merges if zuul finished testing things in gate pipelines while gerrit was unreachable | 19:49 |
| fungi | gerritbot seems to have not reconnected to it though, i'll give it a swift kick | 19:50 |
| Clark[m] | Zuul changes can always be rechecked | 19:50 |
| fungi | #status log Restarted Gerritbot to reestablish its connection to the Gerrit server | 19:51 |
| opendevstatus | fungi: finished logging | 19:51 |
| fungi | zuul seems to still be happy, it reported on a change i pushed immediately after gerrit came back | 19:52 |
| fungi | corvus: not sure if https://review.opendev.org/812214 is a proper fix or a clumsy one, but it seems to be working here with latest urwid now | 19:53 |
| Clark[m] | The reconnect code in zuul is aggressive | 19:55 |
| corvus | fungi: it might be worth seeing if we need to implement a selectable method for the things we put in the pile, but if that looks hard, 812214 is certainly an improvement :) | 20:03 |
| fungi | i'll look for an example of that once i'm done with dinner prep | 20:12 |
| fungi | since it's just inline instantiating urwid.Pile objects, i expect implementing a selectable method for the pile would require a new class | 20:13 |
| fungi | but maybe the objects within the pile being selectable would work, you're suggesting? | 20:14 |
| fungi | (instead of making the pile itself selectable) | 20:15 |
| clarkb | fungi: do we need another status notice to let people know gerrit is back? or just expect them to figure that out on their own? | 20:32 |
| fungi | it came back about the time i sent the initial notice, i figured best to not spam them | 20:53 |
| corvus | it did say reachable shortly. i think we're covered. | 20:54 |
| clarkb | wfm | 21:00 |
| *** dviroel is now known as dviroel|out | 21:24 | |
| anticw | status | 21:47 |
| anticw | (sorry, was looking for a bot reply) | 21:47 |
| fungi | i can be a bot if you need | 22:05 |
| opendevreview | Jeremy Stanley proposed opendev/system-config master: Setting Up Ansible For ptgbot https://review.opendev.org/c/opendev/system-config/+/803190 | 22:12 |
| fungi | diablo_rojo_phone: ^ pushed some fixes noted on the last patchset | 22:13 |
| fungi | once test results come back on that, i'll see what else needs fixing up | 22:16 |
| mrkiko | corvus: fungi: thanks a lot!!!!!!!! you've been, and are, very very helpful! I'm going to test it ASAP! I was reading the IRC history := . thanks a lot. Really. I'll let you know! | 22:30 |
| fungi | mrkiko: glad i could help, definitely let us know if the new patches are helping at all. i don't have a screen reader set up to test with, so mostly guessing | 22:52 |
| fungi | corvus: it's not clear to me what shadowing the inherited selectable() method would accomplish since all it seems to do is return the self._selectable attr anyway: https://github.com/urwid/urwid/blob/master/urwid/widget.py#L463-L482 | 23:13 |
| fungi | i guess we could shadow it with a method which just always returns true? | 23:13 |
| fungi | would i implement that in the ChangeButton class? | 23:13 |
| corvus | fungi: yeah, that sounds like the urwid way to do it | 23:17 |
| fungi | fwiw, making the ChangeButton class always selectable (either with an always true selectable() method or with the _selectable attr set true) doesn't seem to solve the problem like making the Pile selectable does | 23:17 |
| corvus | i'm seeing a problem with bindep on debian testing: https://zuul.opendev.org/t/zuul/build/a294d63366f440fa88252417c271adaf/log/job-output.txt#1774-1785 | 23:18 |
| fungi | we're instantiating urwid.Pile directly though, so would need a custom class inheriting from that instead i guess | 23:18 |
| corvus | if that doesn't jump, search for "LooseVersion" | 23:18 |
| corvus | it's a python traceback in bindep | 23:18 |
| corvus | AttributeError: 'LooseVersion' object has no attribute 'version' | 23:19 |
| corvus | anyone understand that? | 23:19 |
| fungi | yeah, i'm guessing it's the distutils there having a problem | 23:20 |
| corvus | that's on debian testing- | 23:22 |
| fungi | probably bindep was relying on something which got remove from distutils | 23:22 |
| fungi | trying to see if i can spot it | 23:22 |
| fungi | from distutils.version import LooseVersion as as_ver | 23:22 |
| fungi | so the as_ver() in that traceback is distutils.version.LooseVersion() | 23:23 |
| fungi | distutils is in the process of being split out from stdlib, and this may be related | 23:23 |
| fungi | i need to figure out which distutils it's using | 23:23 |
| fungi | though i guess it's the stdlib one since it's /usr/lib/python3.9/distutils/version.py | 23:24 |
| fungi | corvus: ooh, looks like we prefer to import packaging.version.parse for that instead of distutils.version.LooseVersion | 23:31 |
| fungi | corvus: so my guess is that the former only works if the packaging library is installed, while the latter only works on old python stdlibs | 23:31 |
| fungi | either the python3-packaging deb or packaging from pypi | 23:32 |
| fungi | probably we should use an environment marker to have bindep require packaging if python_version is new enough to support it | 23:33 |
| opendevreview | Jeremy Stanley proposed opendev/bindep master: Require packaging https://review.opendev.org/c/opendev/bindep/+/812238 | 23:36 |
| fungi | corvus: ^ i'll tweak that with an appropriate python_version once i see which jobs fail for it | 23:37 |
| corvus | cool thanks; i was able to unblock zuul-preview by pinning to buster | 23:37 |
| corvus | that's probably what testing was the last time we build that image anyway :) | 23:37 |
| fungi | bullseye was testing up until a couple months ago | 23:39 |
| fungi | or maybe a month ago | 23:39 |
| fungi | buster was stable, now oldstable | 23:39 |
| fungi | bookworm is now testing | 23:39 |
| corvus | maybe it was bullseye; but i really wouldn't put it past being buster :) | 23:40 |
| fungi | too many b release codenames in a row for my taste | 23:40 |
| corvus | that project basically never changes | 23:40 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!